labofsahil/github-event-dataset-2012 huggingface dataset:
The problem I think is the fact that override and backend, backend and override what? We are really redirecting what modules are loaded in the functions dict for the duration of the single state call
What name does the docs use? If `sav` is the command name upstream there's no need to install an additional symlink.
That doesn't improve things a great deal because some systems have env in /bin/. But fine.
modprobe loop is still needed. dont remove it
I don't like the dependency on the UI system. However this won't be changed.
Possibly something to contend with in the new design approach... When the event handling is performed by threads from the ThreadPoolExecutor pool, the locks currently the thread firing the events are not an issue (e.g. the DefaultNexusConfiguration lock).  However, if the threads in the pool are exhausted (or -- unlikely -- the pool has been shutdown) the execution of the handler will be done in the context of the thread calling DefaultEventInspectorHost.processEvent().  If the design assumes that asynchronously handled events will always be free of any prior synchronization locks, there is no guarantee that will be the case.

This is not an issue if the order of lock acquisition is always consistent, but this rare circumstance seemed like a subtlety worth pointing out.  Perhaps it has already been considered.
Oh please, always submit a commit message. I beg ;)
Ok, si algo me faltaba por actualizar porque ahora si que va
fwiw, you might want to use "import views" here and just use ``views.firefox_performance`` etc. in the URL Patterns.
Doesn't seem to solve it :/
And as you may expect, is hard to know what's going on. I've tried all the permutations I can think of...
Thanks, fixed.=
my fail, hatte die Umstrukturierung nicht bemerkt
jo...mach ich dann glei...

sollte ja ein simples strg-h wern;)
I have no idea. At 02:00 test_one_log showed that events get written and read again. But there is a test_livestatus_perf.py where i will add also a log-benchmark.
никак. поддержка wowarmory дропнута ввиду ухода ее в приват.
this - not crushdump. but this log saying, that your server has fully incorrect VMAP data...
Maps issues not related at all with hight CPU usage. Also i have those maps missing since years and no problems...

5503031.map
5503032.map
5503131.map
5503132.map

Those maps are The EYE instance.

5563231.map Sethekk Halls

5573232.map Unknown.

Try to close those instances increasing levelmin in instance_template or deleting completely entry. BE CAREFUL! If you delete the entry, first move all players in this map or server will crash when players attemps to load into this map.
I have grid unload disabed too with 24Gb RAM. When the server is 20h online, I have 20/24Gb used and 1 cpu 100%. I think both things are related.
Yeah, I forgot sometime, how Ruby is cool :)
This is messy as hell because of the original code layout. I'd rearrange it, but I don't wanna uh introduce different coding paradigms to the project. Yeah.
RHEL6:
```
/home/eilemann/Software/Equalizer/libs/co/rdmaConnection.cpp: In member function 'bool co::RDMAConnection::_createQP()':
/home/eilemann/Software/Equalizer/libs/co/rdmaConnection.cpp:966: error: 'struct rdma_cm_id' has no member named 'pd'
/home/eilemann/Software/Equalizer/libs/co/rdmaConnection.cpp: In member function 'bool co::RDMAConnection::_initBuffers()':
/home/eilemann/Software/Equalizer/libs/co/rdmaConnection.cpp:983: error: 'struct rdma_cm_id' has no member named 'pd'
/home/eilemann/Software/Equalizer/libs/co/rdmaConnection.cpp:989: error: 'struct rdma_cm_id' has no member named 'pd'


$ rpm -q librdmacm
librdmacm-1.0.14.1-1.x86_64
```
All good. Thanks for that!
The backend is a source of events with type Common::EVENT_CUSTOM_GESTURE and the gesture type stored in Event::customType.
Horn is correct. Will revert this in a while.
Actually... I did the `visit(Exists)` (but Exists is a unary operator). But I think the syntax will be the same as for ExistsCondition...
committed to wrong branch. created compound-filters branch for this.
do we need the `base/apps` fixture?
And you didn't see the funniest comments on the code, the ones when we "kill" something are quite .... visual in general ;)
Yes, here is the recording - if you want to skip right to it, I make the jumping sounds repeatedly after the 0:27 mark - you can't miss it.

This was recorded with jack_capture using JACK -  SSNES PS3 - with SNES9x prior to the fixed point alterations - using 32Khz input rate (for SSNES) and 32KHz Settings.SoundInputRate (for SNES9x).

http://cdn.anonfiles.com/1328371474200.zip

I'll get back to you on the CRC32 of the ROM.
get rid of the parentheses
So after reading this patch, why can't we update the label for the GC span element given if iGC is enabled or not? I kinda would like to avoid the addition of further elements in the widget. The used width is already too much and we got some negative feedback on it.
I am :)
without this, a few local variables further up are reported as unused.
Probably a bug in ECJ, but since this is a test, I'm fixing it anyway at the expense of speed and memory usage :P
~~~ js
'elements': (typeof html5.elements == 'string' ? html5.elements.split(' ') : html5.elements) || defaultHtml5Elements.split(' '),
~~~
By default, we route all dozuki requests through *.dozuki.com. "SSO &&
custom_domain" is the only special case where we actually use the
custom domain.

--
David Patierno
dmpatierno@gmail.com

On Feb 13, 2012, at 11:45 AM, Daniel Beardsley
<reply@reply.github.com>
wrote:

> I think the `(sso && custom_domain)`  should just be `(custom_domain)`  because having a custom domain at ALL means HTTPS won't work because that custom domain isn't listed on our SSL Certificate.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/iFixit/iFixit-iOS/commit/282e4bbd7f4f4efd8c5754b87ae6a10ec45e7475#commitcomment-961558
@ozten - is the Gettext library expensive to create?  Renderer is run for every tooltip, every screen, etc, and could become expensive.  Could we create one instance on demand and cache it?  EJS caches its templates internally, but I should probably do the same for each EJS instance.
Yeah, the callable-map stuff used for synths and instruments is from the days before protocols and deftype.  It would be nice to use .invoke instead, among other things.  Why don't we start on this in a "protocols" branch, and then after the next release we can shift it into master.
I also stopped here.
Reason I suggest is that the new code has to handle both address types in trying to hack around an apparent issue with RDMA CM.  See upcoming commit.  Sorry to be a pest - hopefully the other address handling fixes are working out and letting you move forward.
dreadii, I rewrote the icc trashmobs script that locknes reverted:
http://pastebin.com/91a48Zk1 -> .cpp
http://pastebin.com/gvabCjEm -> .sql

I don't know if it's correct, but it worked for me. ^^
Just a heads-up that Int64 only became available in the September 2012 haxe release (2.08)
That's it about  array::T* __object : cannot be defined here as the example query_result::array_t : < ..., class T> is not definable.
如果网站不是放在根目录，则去掉index前面的/。很常见的一个问题。
ist der text am richtigen ort?
No. Open an issue if you want one.
I'm running some light tests against all the community tests and this one seems to fail for me when it's in the `<head>` element.

![screenshot](https://img.skitch.com/20120206-d3pbb5knrnufmnmuu4emnawy86.jpg)
What is wrong with the default sql comments anyway?

        <cfquery name="blah">
        /* sql comment here  */

        </cfquery>
You forgot to put punctuation on the end.
Oops.
While pushing to optiml-alpha-gpu to github, somehow dev-merge branch is
also pushed.
I'm not using dev-merge branch anymore.
Are you okay with removing it?

HyoukJoong.

On Tue, Jan 24, 2012 at 2:08 PM, asujeeth <
reply@reply.github.com
> wrote:

> I thought this branch was dead... are you still using it for something? If
> not we should go ahead and remove it.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/stanford-ppl/Delite/commit/4d7a07a724c39edf6ba511e08e0ba87dc3d38a93#commitcomment-898118
>
can req.body.length ever be < 0? null and undefined are not < 0, seems like we really want to check whether it is not > 0
Bother, I don't know what went wrong, will just commit a fix.
can we make this approx_size(), and have subtract the head/tail .version?  size() on an std::list is O(n), and the log can grow beyond 1000 entries when the pg is degraded
This is cool and all but you kinda broke the unit tests ;)  I will get them working again this time :P
sure, first I wanted it to be readable. When I used 1M times/sec in the tight loop I'll look into efficiency - I promise!:)
Sorry mistaken commit - was trying to get build working. Will back this out!
I've heard of them, but haven't worked with those kinds of files, so I never really intended to add support for them.

If it's useful at least to you, and you want to start building it, as I said, I'd be happy to have the added feature in the main repo. 

Also, feel free to refactor any of the (many) code smells if they are impeding any progress on your part :)

I'd also be interested in knowing more about specifically what kind of data/project you'd use this for. You can take that conversation into email if you want. It's my github username at gmail.
the array is gone, as the redis way its better for me
Don't you think the rule "one thing per line" could be applied here?
Simplify to "return v->store..."
Что за "Г "?
I don't know why no one has spotted this before but it is quite an obvious bug. Thx for the patch.
Of course the entire loop could be simplified, e.g.:

```C#
    private void ShiftControlsUp(int index)
    {
      int spacing = Spacing(System.Windows.Controls.Orientation.Vertical);

      for (int i = index+1; i < Children.Count; i++)
      {
        Children[i].YPosition -= (Children[index].Height + spacing);
      }
    }
```
This commit broke Jpeg decoding
what's the advantage in that?
I usually try and keep the dependency at the lowest level which requires it, to make the modules, well, modular :-)
for example, if one day I'd replace the Processor module with another NewProcessor module that does not use Cassandra back-end but rather Hadoop, then there project no longer needs dependency on cassandra and hector.
putting it all on the root POM makes it monolithic instead of modular.
Ah, duh. :)
All new variables should be declared as "var new_ls = ..." to prevent scoping issues.
does it makes sense to listen to only 1 signal and not the others ? (e.g. listen to pause only, not start, nor stop ?)
If it doesn't, then you might use a unique signal instead : stateChanged(PauseEnum);
AFAIK, hthor works either locally or in Dali, not on both at the same time. 

To be honest, I don't think it makes sense, unless it's a temporary internal file that could be created directly via IFile interface.

File name as local path were already working in Roxie, so if you really wanted to resolve local files, you'd have passed a local path. This is just for the case where Dali is turned off, so we resolve them locally *as well*.
커밋 메세지가 엄청 자세히 길게 적혀 있거든요!! 

On Feb 22, 2012, at 12:15 AM, Outsider wrote:

> 커밋 메시지는 왜 저렇게 나와?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/whiteship/springsprout/commit/5a70cd5b61a6a8f4ca519b9ab03ff979bf07045b#commitcomment-994965
내가 손대면서 테스트는 완전 깨지고 있는듯... ;;

당분간 테스트 스킵하면서 진행햐.. 후다다다다닥... (도주중... ㅡㅡ;;)
A Vérifier
*reference*_loot_template
Working on implanting it with out the patcher man :D
Reminder to self: rewrite this to iterate over an array of paths.
You don't need to keep the arc type in a variable (return in the inner blocks).
just by reading this code: you seem to add the selectedClass with either checking or un-checking the element ... ???
i think these spell are not related to thaddius
@enVias You're wrong... It definitely interrupts when you leave LoS. Blizz's update tick was probably a lot less frequent though, which is why sometimes you could leave LoS and re-enter it and the spell will still cast.
That's useless. The proper way would be
*xcuserdata*
That would ensure all Xcode userdata is ignored.
OK, I'll check it as soon as I can.
What's different here? @tilucsi
Yeah it's temporary indeed. This one comes from the cs.info forums
Without crashlogs we cant do anythink with it.
I didn't have rpmbuild installed so it raised an error while running `make package` and I forgot to fix it.

I think we should probably statically link all libraries we can.  I don't think the size of the binary file will be an issue.
See bab2b13c438e4383faf15c66fa079229ad23dbc2 - you should be able to use the `isInstantiable` method now.
Homework 4
============

| **Part** | **Points** |
|--------|------|
| base | 1 |
| advanced | 0.75 |
| **Total** | **1.75 pts** |

# Section 1:  If

**2-3)** Not a big deal (aka no points lost) but if I phrase things as "add four" or "double it", I mean to modify the variable.  So `n *= 2`, not just `n*2`.

**4)** Your way of doing it is fine, but you can take advantage of the order of the if statements here and go the other direction.

```python
if grade >= 90:
    print "4. A"
elif grade >= 80:
    print "4. B"
# ...snip...
```

## Section 2:  While

**3)** Your method will work this way, but I was hoping you'd use variables.

```python
num = int(raw_input("3. Countdown from: "))

if num % 3 == 0:
    step = 3
elif num % 2 == 0:
    step = 2
else:
    step = 1

while num >= 0:
    print num
    num -= step
```

## Section 3: Lists

**4)** You inserted 7 as the third element, not replaced.  `nums[2] = 7`

**5)** Extends defintely works here.  Alternatively you can use `nums += nums2`.

**9)** Most got this one wrong since it was so vaguely worded.  I mean a list which only contained the second element, or `nums[1:2]`.


## Section 4:  For

**1)** Yes, I too know of the `sum` function, but I as looking for you guys to write it yourself.

```python
total = 0
for n in nums:
    total += n
```

**2)**  Your code is commented out but it looks close

**3)**  Your code works here, but you are using ints instead of just bools.

```python
evenCheck = True
for i in nums:
    if i%2 != 0:
        evenCheck = False

if evenCheck:
    print "3. All even"
else:
    print "3. Some odd"
```

Alternatively, now that you know list comprehensions.

```python
alleven = all(i%2 == 0 for i in nums)
```

**4)**  So here you had an empty list of numbers, then took a list of all the odd numbers and appended them to the empty list one at a time.  `oddHundred` is the same thing as `range(1,101,2)`.

**5)**  Very complicated solution, but I guess it works.  It can more simply be written like this:

```python
for i in range(len(nums)):
    nums[i] *= i
```

## Cake or Death

First off, `int` of a number is the same things as just the number:

```python
cake = int(6)
choice = (int(0))

# same as
cake = 6
choice = 0
```

Second, you code works and is correct.  The only thing is that I was looking to enter "cake" or "death", not "1" or "2".  Otherwise, well done overall.


## Checkerboard
Good attempt but not quite.  It doesn't actually alternate and the boards are twice as big as they should be and one row to wide.  Here is a "clever" solution we mentioned in class.

```python
width = int(raw_input("Width: "))
height = int(raw_input(Height: "))

row = "#-" * width

for i in range(height):
    start = i % 2
    end = width + start
    print row[start:end]
```
Is Zend_Service_Amazon_S3_Exception supposed to extend this instead of Zend_Service_Amazon_Exception (which doesn't exist)?
Good catch!, will push a fix.
I see it now. Thank.
I don't know what's the best but as far as i'm concerned i never had the need to enabled show_sql at runtime, only other loggers in some occasions...
The overhead should be small
Changed the activation status
Logger (throughout).
スペースはいらない
Chris,

I have review this pull request and I am a little confused.  Many of the changes/additions you made move "bashism" in the harness.  In our recent meeting regarding the harness direction I believe we all agreed that moving bash commands into the harness was a bad idea.  Invoking ruby on a target system to perform a simple "test -f" hardly seems efficient.  Additionally, your proposed changes duplicates existing harness functions -- such as creating a remote file.
cool, I'm sorry for no pull request. thought it was trivial enough that
you could fix it quick without me have to fork;pull;branch;patch;push;send
pull request

;)

-Ryan

On Fri, Jan 6, 2012 at 4:22 PM, Josh Arnold <
reply@reply.github.com
> wrote:

> fixed and pushed
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/DarthFubuMVC/jquery-continuations/commit/0835aaee01aa1b763ed30611be0117ef60ecafd9#commitcomment-845120
>
Any reason why you ignored my tests? I 've corrected it locally, pls don't correct it :)
<Victor M Ramirez Alvarado>+
<VictorRamirez602>+<Vramirez602@aol.com>+<Vramirez602@hotmail.com>=Me
<http://wwwv3.VictorRamirez602.Vramirez602@.com>+
<Routin>#<124001545>=<CheckinAccout>#976890053>
Ok now lets latk about this: there are 2 issues.
The code saves the assistant and speech and validation when ALL  those three are available.
Now I can see one collision: If the 4s is not setup (doesnt have assistant,speechid) then this acts like a bug and the server does not save any of those and more important the validation data. 
Another thing is that sometimes on public servers the 4s cannot create an assistant , speechid due to banning. But its possible for other devices to use its validation data, as long as they have created an assistant. 
So requiring assistant and speechid is kinda biggy in my point of view! 
Any ideas?
I think your variable 'pf' is just the imaginary part of my variable 'p'
It might be best for us to define p as a complex number (ie, my 'p' plus 1i times your 'pf' )
Then alpha(ii)=sum(p.exp(Omega*t(ii))) 
... which is much cleaner than line 75 !
Using an actual boolean `true` seems to work fine. Is there some compatibility reason to have it as a string?
word sounds good
"selecedEvent" might be a better name
Inline styles... *cringe*
Instead of the getOrElse you could simply do + senderOption and it will be Some(path) or None which is just as informative.
we decided to not have auto re-join

I think the `auto-join` still has a purpose, to be able to define seed nodes (== deputy nodes) but not join them automatically at startup
I'd get rid of the "val wrappedTransport" and inline that whole expression where wrappedTransport is used.
Possibly start the comparison by checking eq, then check size, then do the map's (since they allocate quite some objects)
Why have multple TLs instead of just one with different states? Keeping multiple TLs up to date is complecting things.
Then maybe it should be a FiniteDuration in the cluster for symmetrical reasons.
it was the correct order, or at least mostly working order, but when 2137 is merged it will be the reverse order, and I have already fixed that in my local branch of this pull req.

Is there any case where one wan't to do shutdown without a removeNode? Easiest would be to always do removeNode under the hood when doing shutdown.
I agree, and I keep getting myself confused about the final API on this stuff.

Yes, let's address this by getting rid of the old stuff at the right point in the process.
2 of these on one line plus a block = overload
Even I didn't like it, this should be moved to num class, if i'm right. The ping_o_matic should be removed as well. Thanks up.
I think I missed something:

How is a developer supposed to implement his own facets?
Hmm. `_get_or_bust()` wouldn't work here because `limit` is actually an optional param. I suppose we could write a function that gets a value from a dict, or returns None, and rasies ValidationError if the value is there but the wrong type. But aren't we reinventing the schema and validate() system?
extra space before "time"
Is there a reason two of these tests are disabled? Should either comment on why they are so it doesn't look like an accidental commit or flat out delete them if they aren't needed anymore.
Two separate issues:

1. on the db field renaming, I (re-)suggest:

card_id -> referer_id
referenced_card_id -> referee_id
referenced_name -> referee_key

2. on this use, I don't like ref_type because I think this is very different from ref_type in the db, no?  The code just below (`ref_type = :show` suggests this has nothing to do with the T, L thing.)

also, this comment is late, but I  kinda think we should be getting rid of the word "transclusion" in favor of "inclusion" where possible for consistency
I think ref_id is ambiguous.  a given reference has just one type and one chunk of text, so just "ref" suffices there.   but there are two cards involved in any reference, so I think we should use "referer" and "referee" to distinguish.  see https://github.com/wagn/wagn/pull/34#issuecomment-11100360
Thread message?
You're right on the principle, but isn't GetMovieInfo creating the VideoInfoTag needed by GetStreamDetails?
Can't think of one at least immediately, guess I'll change that.

While on the subject, do you have any better suggestion than using "@"?
Why are you changing logging settings in here?
person?
not sure about the logic, can you make unit tests with that?
i don't think shrinkwrap can work this way,
worker files create lots of globals, they should not be loaded into window
Unfortunately, currently this is not enough. Please add:
```
qDeleteAll(mMap->tileset());
```
before deleting the map.
'susyTree' is particular to the susycaf ntuple.  I think it's better to keep it as "/" in defaults.py
`cd li<TAB>b/` and `vim lo<TAB>g` are good. Also, `node.log` made sense because our service scripts are creating `tree.log` and `redirect.log`, that was the idea behind `*.log`. How about logging to `app.log` or `tree.log`?
Long lines, wrap at 80 columns.
Check the return value. If another thread concurrently deletes the environment variable, `s` is left uninitialized.
Swap the meaning of T and R so that R is the result and T is the partial data (this will be more consistent with other code we have); or leave T as the accumulated type and change R to V for Value.
Les placeholders ne marche pas sur les vieux browsers (IE).
You could use more feature-centric package name, such as `filetransfer` or `file`?
No, in that case the Delete request will not go off on the second call to featureStore.save()
Yeah... this is much cleaner :+1:
Shouldn't the last arg be `2` as the `algo` is also a required argument?
This will break support for deployment to sub URI
Here is where the issue lies, you can't assume that the database configuration file is at `config/database.yml`.
I know they use dashes, but all the Rails helpers generate with underscore, so is better to use what Rails use.
Why so? It's not passing? And before we didn't have the variable shortcut.
I can't believe that this map is gone! This has been the source of so many leaks and spurious errors in the IDE... We should open a bottle of champaign and dance to he music of the backspace key!
Don't need parens for guard
Providing a default argument is robbing Peter to pay Paul.  Because it's at the bottom of the "use this" rules, it means it's last chosen.  However, there's still the issue of people not realizing they are accidentally spawning a new fork-join thread pool for parallel collections.   It's important we get these right for folks using parallel collections inside highly concurrent servers.   I'd rather not have my code accidentally use the wrong set of threads, or have less important parts vie for resources with more important parts if both use parallel collections.

That said, having a default argument may be the lesser of all evils.
same as above, 2.4 syntax error
print statement left in
Doing a `git grep "_eval_as_leading_term("` shows only definitions and one call in core:

```
sympy/core/expr.py:        obj = self._eval_as_leading_term(x)
```
By doing this, they are. I suppose we could put them as property definitions. But in help(ImmutableMatrix) rows and cols show under

```
Data descriptors inherited from sympy.matrices.expressions.matexpr.MatrixExpr:
```

And shape shows under 

```
Data descriptors defined here.
```
Hm I think this is ok ... I just wasn't sure (as a user, without looking at the code), how the identity morphisms are taken care of. Since you have a doctest demonstrating this, I think you can leave it as is.
There was a pep8 change (which looks arbitrary in light of several adjacent lines where pep8 could have been done) and a swapping of p and q (which was the only necessary change). I'm not sure what determines which is preferred, however.
Yeah, this test was for an earlier implementation of Tr(Matrix).  I will remove this.  

Since, many of the doit() tests use cases right now are on classes in quantum module I have tests on the _eval_trace() methods on respective classes.
>create this file "on the fly", using "runtime" directory

Good proposal.
will do, sorry.
Every Content node should have a folder_view…
This should not be necessary to add if the spec_helper is correct.
Sorry, I accidentally commented on your commit rather than the diff.  I am just going to re-comment on the diff.

Spaces around +.

Also: __no__ spaces around =, as is correct above.  For arithmetic operations, use the space.  However, the standard style for specifying argument values is no space.  So file=sys.stderr is correct.
The callback can't be a Closure ?
Style issue: space between if and paren.
typo: oprions --> options
It looks like this is ignoring the rules.  How do we handle the dropping of loaded segments that transfer from one grouping to another/fall off the end?
to elect
you only need to use :term: for the first occurrence of a term in a section.
Fixed, will appear in next commit.
Is there a reason why composition was chosen instead of inheritance?
Underscore for container?
As the signature of this function is now incompatible with the old signature, it should be renamed to phpbb_on_page. The BC break needs to be documented for MOD authors on http://wiki.phpbb.com/PhpBB3.1
Here, tests can be trivially put into their own method. You can use the method name to describe what the test does, e.g. `test_common_checks_valid_file`
Well phpBB itself at the moment indeed doesn't use db_tools, however it is designed for this type of database mutations so I don't see why it shouldn't be used here.
Guess you can remove that statement once it is actually used ;)
doesn't matter to me... +1
`extractUnit("7 deg")` //  "deg"
That's fine, isn't it?
See: pseudo-scoped vars
so it changed. we still shouldn't mix checks
150 is a nice round number
@caridy I can refactor the travis.yml into scripts as you requested. I'm not a fan of having the .jar as part of the repo.
Is this an API change we need to note in the change docs?
А почему тут ошибка? Ну нет баннеров и нет, отображаем пустой список
Thanks for your comment.
I removed personal info from all file headers.
Alright, I'll change it to that
I don't think I can use 'each' or 'for..in' here, because I need the 'i' index

 (the address for the first module 'login' is a bit different than all the others)
At what point do you populate the ```self._attr_cache``` dictionary?
Indeed. However, it does seem to be used by ``test_quickplot`` and others.
unnecessary nested function
两个图的图例绘制几乎都是一样的，可以思考一下如何重用。
"implicit."  seems to have disappeared.
Maybe a comment here explaining the two cases in english?
yes you are right done
To be clear, this is the very line that fixes the behavior discovered in #360, for the reason discussed above.
We decided we need ```@param``` entries for everything. Are you saying it just needs to be more descriptive or that it should be removed? I could get behind the former, but not the latter.
A wrapper function seems a bit overkill since the only thing we really need is to mock over it in this test (and perhaps a few others in the future) - i.e. wrapper function would be suitable if we expected cyclus api users to override the method.
I think this should be all lower case - just convention for namespacing.
We could use similar language to the above here maybe, but I think this is fine. Especially keep the parts about 1.6, I like committing to that publically somewhere.
Buzz already abstract this. No need to build the body yourself
Yes, added it.
OK, I'll try a different style... brb.
rather than add some real html and then selecting it, you should do what you did in your other tests, create some arbitrary html with jQuery, and append it to `#qunit_fixture`. I know that you're just following examples in the tests here, but it's something we're committed to changing and keeping an eye on going forward.
I changed it because:

Appending to .cssText needs to happen on a separate line.

...and changing .cssText *after* the iframe has been inserted in the dom, might cause reflows (all be it small ones)

...and invoking `jQuery.extend` is inherently slower than direct property assignments

...and the resulting minified code is approximately the same size as the original `jQuery.extend` version (+/- 2 bytes)
I realize you're just copying from register_extension, but this line was a bug there. Thanks for bringing it to my attention; fixed in https://github.com/meteor/meteor/commit/6cc67f43738943aa54107033081b758f9df5d747
Yep, it looks right :)
Since this function previously returned all colorbars in the figure, wouldn't it make more sense to return the colorbars from all data layers?
We should use the ledoit_wolf of the sickit learn. Anyhow, I don't believe that it is used in the current codebase, so we should just remove it.
We check for permissions for a reason ;)
not included in tests
remove extra comma after arguments
I think this will leak the names of deleted accounts. Possibly need to use Wrapped here?
Checkstyle didn't break. Is that the lint you mean?
These have their own pom which does not invoke checkstyle.
Good catch. Path.GetDirectoryName will not return the correct directory though if the path doesn't end in a \ (it will be a level up). Would you then just want to add .git on so it would be as if the user had selected the "project" dir?
just a `.forEach` here would be fine
`this` instead of freestanding `@`
I didn't review the original code for drag/drop, but this seems odd to trigger this event on ``DocumentManager``.  Would it make more sense to do this internally, perhaps in ``swapWorkingSetIndexes``?
No, I think we're ok to check it individually for each case.
Update docs to indiciate return $.Promise
fixed and fixed "containg"
I don't know Ruby either, but the below should be right.
@mostafaeweda Ok, that sounds like a plan. But maybe you can update it in Ace next since you looked at it anyway?
We should probably delay the connection attempts until after the thread has been spawned and is running. Otherwise its possible that we get into weird issues with the other client types. Ie, I think at least one memcached client inherits from threading.local which might prove for some surprising behaviour for those that don't expect it.
Media queries for the responsive footer.
Yup, agree it's outside the scope of this.

Not sure about 1., it's seems moot if we're going with the git config approach. It's also confusing that it's in multiple places. Either or. ?
Missed one. I've changed it and updated pull request.
So I download the tar gz file for RC then unzip and pip freeze?
Just a hint here: you could use `butter.currentMedia` too.
there is no removeEventListener for this, will that be a problem?
Fix this indentation, please.
I just think "blob" is a technical term that sounds like it's made-up to a user.  JSON or JSON file are both fine.
This should probably say "Popcorn Maker ran into..."
can we split this line and line 27 up a bit
This comment looks out of place here. Should it be above the `try` below?
that doesn't look right
Ok, I'll let it in, but I've found a much cleaner and more easy to understand version that I'll replace it with. This may work, but it's confusing as hell.

I'll also add in the unit tests I've got for the flag helper functions.
Oh, one other tip... this code:

`User.all.map {|u| u.username}`

can be written a little more concisely as

`User.all.map(&:username)`

The &:symbol syntax can be used when you want to basically just use an instance method to transform each object in the enumerable.  More nifty Ruby magic.
Sorry if that was not clear. I wrote in the commit for this edit that opt.retries should never be None because a default was set in the add_option().
I wouldn't change this now, but for future reference it would be much nicer to use Q.js and promises.
I put it in so that people can use the stateconf renderer without having to define their own no-op state function like this. I'm not sure where else to put it. Suggestions?
pretty much fully tested now
you can just make them `case class`s since they don't have a body
I spun this off into issue #128.
'title' attribs are more useful than 'alt' attribs here for the vast majority of users, as in normal peoples' browsers they float the text over the image. 'alt' attribs only show the text when images aren't being shown.  I guess having *both* would be good, but if we only have one then 'title' it has to be.
Is this line part of the patch? Or was it added as a convenience for development? Should we document this setting in the developer docs?
OWSLib already provides an abstracted request/response model; don't we already have an abstraction of CSW in OWSLib itself?  If catalogue/catalogue.py commits to an OWSLib interface, with ISO as the metadata model, isn't this enough?  I think it may be too much bloat too abstract from OWSLib a level higher, not to mention transforming many objects at runtime when we already have them in OWSLib's CSW and ISO abstraction.
Is this still a concern for _product_hover and _repo_hover?
May want to flag as "TODO", so that we revisit it later.
I see the full diff here, do you not?
i think this needs to be `throw new Error(err)`
This isn't right. You should be returning the cancellation token that you created in this callback.
err, you can't. I live in a world where 'let is the new var'. sorry.
This API section should be removed now that the the "automodapi" directive is present in ``index.rst``.  You can either remove it in this PR or I'll do it in master once this is merged.
I believe arithmetic interpolation/convolution to be the most basic operations that nddata has (I would think that by concatenating those one can do 90% of what people want to do with nddata arrays). when you convolve an nddata array withan attached sderror one wants to use the error propagation rule for the convolution and interpolation. The same applies to mask (extrapolated values should be masked, etc.).
So you mean dispense with the decorator entirely, and just put the imports at the top?  I'm not a fan of that because we definitely want function-level control of what actually has a dependency.  But I could see simplifying this a lot by dispensing with the wrapping and having the decorator just attach the `optional_deps_needed` attribute to the function.  Then it's still possible to search for optional dependencies, just without a fancy/graceful failure when the function is actually called.
If we call Shutdown Start- or InitShutdown() this can be Shutdown() again, which would be fine.
Why a configure variable?  Why not use a viewVariable?  This makes fewer dependencies on Configure and I think will make things simpler overall.  Perhaps something like `_rootNode`
Shouldn't this be folder5?
It's too bad this can't be dynamic. I don't have an immediate solution, and I know this solution is what we agreed on, I just see this and recognize that any facilities that you want to interact with your growth market now need to have this extra inheritance built in by the developer. While it's worth being careful about, this isn't a problem in my opinion, so long as they're still useable by simulations that don't involve the growth market.
Should be in user model.
In this use case you *still* need to know how to encode binary data in a way that is compatible with the file format being used to persist the ui state, and different file formats will have different requirements, so in this case it doesn't seem like a stretch to say that your 'pipe' in this case is a pipe onto a disk file instead of a socket...
keys should be snake_case - and ideally, as short as possible while still being meaningful.
ah, ok; makes sense then.
this should be a test dep
aren't these specified in some parent pom? if they are and you need to use different one please leave a comment explaining.
https://github.com/kaltura/mwEmbed/commit/df3a0a7886e0ad7617bb5d653085ae79edcf4719#L5L104
oops, I added this for white space testing originally.
I think this needs to be `_lazy` since it might be run before the locale middleware is.
Total nit but you've got a bunch of inconsistent spacing stuff should be `{{ num_answers }}` likewise above. 

Also `{{ profile.user.username }}` there is a space missing at the end.
ahh, yeah, that's better. done.
"...if you had to change the timezone".
Hmm I don't know? :)
I don't think we should pretend to throw PDO exceptions, but throw a new InstallerException?
``$container->isTrackingResources()`` ?
Would CS call for `()` here? /cc @stof
You are right. I'll fix this.
use ``if (!$profilerIndexed) {``
love the example--we should put it in finagle-example (under mysql/)
If user data is ever passed to this method it is vulnerable. Also, it
has a bug related to ? appearing in the query in a string value. If we
can't make the method safe for user data and have it work in the
presence of non-interpolated strings I would rather have it be more
obvious in the code that calls MySQL that they are constructing the
query by hand rather than it looking like a safe prepared statement
call.

On Jul 23, 2012, at 12:25 PM, Ruben Oanta
<reply@reply.github.com>
wrote:

>> +  def flatten(params: Seq[Any]): Seq[Any] = params flatMap {
>> +    case p: Product => flatten(p.productIterator.toSeq)
>> +    case i: Iterable[_] => flatten(i.toSeq)
>> +    case x => Seq(x)
>> +  }
>> +
>> +  /**
>> +   * Replace each wildcard instance in sql with the output from
>> +   * running f(param(i))
>> +   */
>> +  private def replace(sql: String, params: Seq[Any], f: Any => String): String = {
>> +    if(params.isEmpty) {
>> +      return sql
>> +    }
>> +
>> +    val matcher = Query.wildcard.matcher(sql)
>
> As in, a rogue library that has a malicious toString method?
>
> We can completely remove it but the problem of sql injection is still there if the a user builds their own sql statement.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/twitter/finagle/pull/98/files#r1218606
Great!. Please consider extending it from [Biz](https://github.com/umpirsky/wisdom/blob/master/src/Wisdom/Whois/Parser/Tld/Biz.php) and leaving body empty, look at [Us](https://github.com/umpirsky/wisdom/blob/master/src/Wisdom/Whois/Parser/Tld/Us.php) as an example. Optionally, you can fix `\ No newline at end of file`. Thanks ;)
This method is a Whopper™ and a little hard to follow.

I would consider some aggressive private method extraction with intention-revealing names, if you can do that in modules. I believe so:
http://stackoverflow.com/questions/318850/private-module-methods-in-ruby

If not, it might be complex enough to warrant extracting an object.
I think the + 1 here is a bug.  Shouldn't it be

roi.xend = std::min (roi.xbegin + blocksize, roi_xend);

or you end up doing an extra (overlapping!) column for each thread.
What's up with all the lines that are commented out?
Removed. I believe I misinterpreted the behaviour of the ```pre_bounary = self.ignore_existing_data_limits``` block.
Again, no line breaks :p
@thobbs can you create a final pull here at my repo, so I can just use yours as final one,
Old find - and necessary - as was discussed when I was first looking for it many times.
The current code is awfully slow to detect an Icarus so anyone with a dozen will find cgminer spending around almost a minute detecting their devices - for xiangfu, without this implemented properly with correct timeouts, it takes over 3 minutes
Any reason this is called intu_jetty?  If it is just installing redhat's jetty, we can name it jetty
'Mine' compares that the fully transformed model is the same as the model built up through the transformed operations, so it checks that the data is the same.
'Yours' compares that the transformed model is valid according to the legacy resource definition, i.e. it checks the structure.
I agree there is some overlap but I also think they test different enough things that both should be used or they could be rolled into one somehow.
being super picky here, but comments should have a space: `// See #8237 & #8828`
ditto as above
Same here. Plus, two form elements in a label is invalid, too.
I feel like we should cache this? Maybe in .onfirstseeen
remove this unused variable
`var daysOfWeek;`
Ideally there should be a better way (maybe an event on navigator.language) but for now this is the only way :/
a better name for this variable would be CHUNK_SIZE
I have change the code a little bit before merging. Let me know what do you think.
Yes, better that way, thanks :)
we could use Utils.getphoneDetails for this, as I'm adding the photo logic on it too. Just for having it  in only one place
What do you think @borjasalguero && @steveck-chung ??

Not blocking this PR anyway, the rest looks ok for me
select-option?
We still need to put something in the value of the checkboxes. That's right that we don't use it directly but we still need a way to distinguish with messages whose we have the ID. So why not keeping this ?
Thank you for adding this, but you forget `lockscreen.js`.

File a issue or add the fix to this pull request.
shouldn't this be 'textContent' instead of innerHTML?
Can we make this not repository specific?
Hi Paul,

We have a nexus repository/proxy here, and the local pluginRepository definition was not being used.
I thought that the org.dstovall one was no longer there; had I read the error properly I would have seen it was my maven setup.

com.jolira is in maven central, and hence works with with any setup; if it is used then the whole <pluginRepositories> section could also be removed. I can also work around it by adding the repo to my nexus config, so don't worry if you don't want it, but using it may make life easier for others with a similar setup to ours.

NB: Apologies, but this same line has snuck in with one of the other pull requests, so if you don't want it, it will have to be removed.

Thanks for epublib, it has been really helpful.

Regards,
Luke Farrar
`let` doesn't have a tailing `->` :(

Also in this case,

```
let el
    stuff
```

compiles to

```javascript
(function(el){
  stuff;
}.call(this, el));
```

which throws an error in `strict mode` when the nonexistent `el` variable is accessed :(
"destroy" is all mispelled here.
wtf weird it works fine now, maybe it was on my retina, or maybe im just crazy hahaha
for me this always added the ", ca" to the end, should it be?

if (address.indexOf(suffix, address.length - suffix.length) === -1) {
Please replace spaces with tabs to conform to the rest of Leaflet code.
It should be ok to just check for the truthiness of `translateTo` here, right? I favor the shorter (in code) test.
Sorry for the confusion.
Anyway, should I redefine it in each statement, or?
A bit of bikesheding: assertStdoutContains or something, to make clear that we don't care about all the output, just that it has some bit in it?
I considered this a special case, since the data API isn't completely set up yet at this point.
I have some internal requests so that time are localized to the web client TZ. I think it make sense
both your code and mine will replace the existing key if the unique name is already in the array.
I agree, if any tool in your toolchain is too retarded to figure out a constructor returns an instance, you should use another one. Useles docblocks are annoying.
You mean `!strpos(...)` instead?
Travis run the testsuite, not the code sniffing
[Here's a link](http://stackoverflow.com/questions/2293498/git-commit-hooks-global-settings/2293578#2293578) for anyone who wants to install hooks globally.
I don't know why. We had no time to find out why this happen. In console this one works but in live application not. I will be happy if you find reason.
is there a reason to not just delete the commented stuff below?  We'll have it in git history.
do we need `data-upgrade` as a test if we already check for images with a `data-fullsrc`?
There are no builtin exceptions of any useful kind in JavaScript. Further, JavaScript barely knows what arguments are, much less invalid ones.
`// Add an empty string in order to start with a `;` on join call.`
It may be obvious for you as you wrote the code and you already know what are next actions,
but when you are reading the code for the first time, you first read this and don't really understand why would you add an empty string.
Part of the review is to improve readability of the code so that it is easier to understand for people that join the project.
Could you use two different listener names like `onPB` and `onPB2` and replace `our` with `onPB` (or whatever you come up with).
ahh nvm that, it is used.
Shouldn't we throw here, expect when aDataType is null?
@lloyd - is this ever actually called since the confirm page calls /wsapi/complete_email_addition?
Minor nitpick:
`locale` was chosen to maintain consistency with the Playdoh framework. The benefit is that a Mozilla community member who has been hacking on webdev projects can more easily jump into the Identity stack.
I'm not sure this clause does us any good. If an unknown exception is raised Django will return a 500 to the client regardless. The only thing this adds is the exception message, and as I mentioned above, from a security perspective I don't think that's something we should do.
Why would we expect this to fail? It seems like this is just dependent on getting puppetlabs/hiera#98.
Filed as https://projects.puppetlabs.com/issues/18048
BTW, we deliberately don't have Symbol#to_i, it's an old relic from the past
The problem with initializing to False is that this dict would need to have a timeout key set to time.time() + some number of seconds to ensure that the heartbeat doesn't kill the kernel before it is able to receive the execute_request that would set executing to True.

What do you think is a good value for timeout to be initialized to?
I'm confused, is this reporter implementation in later versions of master as i have?

Is this still allowing for reporters loaded at a random location when passed  (as reative or absolute path) at the command line or in mocha.opts, while still loading the existing ones? Also, I was under the impression that require threw on node, and the existing code had a mix of try/catch and checking for existence. Which one should it be? I'll update the pull request.
`5px 10px 0;` do same job.
Yep, I didn't know the name so I wasn't really changing it, just didn't know what to put :). I may have missed that in my "I need more info" email ;)
Is there a nice way to hide local function definitions? If not, I've been using __name (vaguely python-inspired) to indicate that name is not exported, to avoid conflicts.
Tähän varmaan olisi hyvä tehdä parempi tarkistus, että ollaan taaksepäin yhteensopivia. Lisäisin iffii:

```php
if ($lasku["kolmikantakauppa"] == "K" and $tilino_triang != 0) {
    ...
}
```

Sama tarkistus olisi tietysti hyvä olla myös muissa ehdoissa, jossa valitaan tilinumeroa.
@harjis Tää ei mielestäni oo oikea tapa korjata tää hommeli. Korjaa mieluummin siitä kohtaa missä tehdään toi monivalintalaatikko UI, että se päässää muuttujaan kuka.tunnus eikä kuka.myyja.
You are right. Fixed in 59e598acc5681d6793e7732b04dfde93a19961d2.
I'm using this one at https://github.com/FabioBatSilva/doctrine2/blob/8f3189840806bb20a29300845ca4fe5011a05d06/lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php#L423 to fix the class name before use the reflection API.
do we really want this ? It looks like some weird magic.
you should keep tje leading ``\``
We should be able to use `Macro.expand_aliases` here. :)