labofsahil/github-event-dataset-2012 huggingface dataset:
Amazing work! could you try to add some line breaks around the 80 column mark? 

Was this maybe done through copy paste? :frowning:
This is not only your problem, and it's larger than expected, let me explain.

If you read JDatabasePostgresql::insertid dockblock you'll find some useful information on how to use "insertid" call: because I need to extract information from last "INSERT INTO" JDatabasePostgresqlQuery object I MUST run "insertid" after INSERT INTO query execution.

In this case, inside file.php and others under this folder, as you can see there's no JDatabaseQuery to insert row, but JTable object.
To go more deeper, inside JTable::store you can find an insert into (or an update query, depending on a value), and some other queries, so as I've just explained this procedure will not work for PostgreSQL because insertid doesn't follow INSERT INTO JDatabaseQuery.

I've opened some discussion under platform mailing list about JTable but till now nobody answer.
rows_norm is always >= 0. There are two interesting cases here.

1) `rows_norm <= alpha`.
Old code: `1 - alpha / rows_norm` would be < 0, so the `maximum()` made shrink get set to zero.
New code: `rows_norm` would be set to alpha (by the `maximum()`), so shrink would get set to zero. 
Thus, same result.

2) `rows_norm > alpha`
Old code: In this case, we have `alpha / rows_norm < 1`, so shrink > 0 somewhere.
New code: same thing.
Thus, same result.

Does that make sense @agramfort ?
no need for Jenkins ;-)


On Sun, Dec 16, 2012 at 4:37 PM, Alexandre Gramfort <
notifications@github.com> wrote:

> In mne/viz.py:
>
> >      data = epochs.get_data()
> >      if vmin is None:
> >          vmin = data.min()
> >      if vmax is None:
> >          vmax = data.max()
> >
> > -    erf_imshow = partial(_erfimage_imshow, scaling=scaling,
> > +    erf_imshow = partial(_erfimage_imshow, scaling=scalings,
>
> when I see scaling=scalings (singular plural it raises a red flag...)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/221/files#r2430073>.
>
>
Why are you setting the directory for application strings to applicationDirPath()? 1) applicationDirPath() is the default value where appropriate anyway and 2) it's not portable. Lots of systems separate executables from bundled data.
I can't do anything with this exception so I just make it propagate as a runtime exception. I think it's cleaner this way than declaring throws.
Shouldn't this be called HibernateOpenmrsMetadataDAO?
Same note on backwards compatibility and overloading the constructor as on ChangeSetExecutor.
you don't need to extend a bundle to be able to replace a service. Any service registered later with the same id will replace the previous one
同时<header>Connection</header>头的值被清空。

同时<header>Connection</header>头的值也应被清空。
Oh right.  For some reason I thought that was rake only, but I may be thinking of `#sh`.
So what's the call here?

The end result of this pull request as it stands is that instance
variables are never cached if the instance responds to them directly.
This means if there are DB columns, everything is as you'd expect. If
there are no DB columns and you're relying on this caching behavior,
then #reload is brokenish, but it's not like it ever worked(ish).

On Tue, Jun 12, 2012 at 4:48 PM, Matthew Schulkind <mschulkind@gmail.com> wrote:
> Yes, that's what I mean, and I totally agree with you.
>
> Look at the tests around there and the caching in
> Attachment#instance_read() and Attachment#instance_write(). Somebody
> else has a different opinion and I fear there is code out there
> relying on this. Until #reload is called, the tests suggest that
> @dummy.avatar.updated_at even if @dummy does not respond to
> :avatar_updated_at. The tests further suggest that when @dummy.reload
> is called, @dummy.avatar.updated_at should stop returning the cached
> value. This last part is the one I don't see how to implement. This is
> also why I decided it's just unfeasible to support this behavior and
> deleted the test. Unless you want to potentially break people relying
> on this caching, the best option is probably just to declare #reload
> broken wrt to this caching.
>
> On Tue, Jun 12, 2012 at 4:43 PM, Geoffrey Hichborn
> <reply@reply.github.com>
> wrote:
>>> @@ -1090,12 +1090,6 @@ def do_after_all; end
>>>        assert_equal now.to_i, @dummy.avatar.updated_at.to_i
>>>      end
>>>
>>> -    should "return nil when reloaded and sent #avatar_updated_at" do
>>
>> You mean, what if dummy doesn't respond to avatar_updated_at?  It should probably return nil or raise NoMethodError (though I think raising an exception is a little aggressive).
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/thoughtbot/paperclip/pull/914/files#r971018
Wayyy too much blocking in this demo.
Kdyby někdo vymyslel elegantnější zápis, tak pull rád upravím.
Ahh...we can get the other root from cos(x) if we always rewrite trigs
in terms of tan:

>>> solve(cos(x).rewrite(tan))
[-pi/2, pi/2]

>>> solve((2*sin(x)-cos(x)).rewrite(tan))
[-2*atan(2 + sqrt(5)), -2*atan(-sqrt(5) + 2)]

>>> solve((2*sin(x)-cos(x)).rewrite(exp))
[-I*log(-sqrt(3/5 + 4*I/5)), -I*log(sqrt(3/5 + 4*I/5))]


I guess it's your call on this. I could add a note that says that if
you want multiple roots that you should re-write in terms of cos...
просто имена закончились
Лучше еще Q_FUNC_INFO писать.
Dos líneas juntas.
Really? For all python versions?
Double?
spaces after #
@romainneutron btw: i've added caching of the formats based on `$pathfile` in the `FFProbe` class. For example in our setup, we also need the format of the input file outside of the helpers, and in this case the call to the low-level prober can be cached.
Gets 
++ below...
`$app['phraseanet.core']->getAuthenticatedUser()` instead of `\User_Adapter::getInstance($session->get_usr_id(), $appbox);`
No issues :)
That's the joy and pain of collaborative open source development.
I mean the colon :
NGHUTPR
I was just thinking, if you made this a class variable instead of an instance one on Base, then overwrote it in Root to an empty list, you wouldn't need to change anything else. I.e.:
<pre><code>
class Root(object):
   "" stuff """
   _ignore_users = []
</code></pre>
Likewise, Util.close() swallows exceptions, so I don't think we need another try..finally here.
Not sure how I feel about :misc or even :miscellaneous. Any other ideas on what that should be? :player? Just thinking out loud.
Should be `requests.adapters`.
Awesome, I learned something new. Thanks.
Yes, it is needed there.  By importing Axes3D, the Axes3D class gets registered with the rest of matplotlib and it allows for more seamless integration with the rest of mpl.  This is fully documented in the mplot3d documentation.
Was the logic faulty in the first place? I can't see that multiplying the z value by the size of x is a sensible thing to be doing... I would have thought the purpose of this line was more along the lines of: ```np.array([z[0]] * x.size)```.

Better yet would be ```np.tile(z[0], x.size)```.

@WeatherGod : Any thoughts?
Good point.  I will fix on v1.1.x
The property above this `valid_signature_items` does this exact same logic so instead of all of thise you can just do `return self.valid_signature_items[0].click()` :)
why parens around symmetric?
This class seems to have a lot of generated text. Are there plans to update this later?
E.g. if you expect a collection to be not empty
You're right -- I put that in when I was first thinking about compaction and I wanted to ignore any file that might not compact.

I've dropped the limit to 10K.
Minor: I think the original comment was more descriptive of the code.
Are you sure ``$value`` has the correct type as ``*`` is not a sub-type of ``array|object<Traversable>``?
Then there is no need to change this, and IIRC is "a litle bit" faster =)
Altering the load path should not be necessary here.
I think `$.isPlainObject` would fit better here...
Can we do this server-side?
On 4/24/12 2:55 PM, Lucas Madar wrote:
>> @@ -131,6 +131,24 @@ def commit_text(commit)
>>  
>>      EOH
>>  
>> +    if data['show_diff']
>> +      patch_resp = http_get commit['url'] + ".diff" # Why doesn't this use accept headers?
> 
> I am getting an error "Status 406" using the github e-mail service hook on my repositories with embedded diffs. Did something here get pushed that shouldn't have? Or is it unluckily unrelated?

I *might* be related but I'm not sure. I originally tested with curl and
noticed that github didn't honor the "Accept" header and, in fact,
returned "406 Not Acceptable" (which is what you are getting) when I
passed in anything other than "text/html". But in the end I didn't set
the "Accept" header, so I don't understand why you would be seeing that.

There's a little bit of discussion of this section of the code in the
pull request here:
https://github.com/github/github-services/pull/275#r636575

For an example, check out this:

https://github.com/github/github-services/pull/275/commits

vs.

https://github.com/github/github-services/pull/275/commits.json

-David
should add this._updateMarkerHandler(); here.
Wasn't the formatting of the date the reason this piece of code was added? (for non-gregorian calendars)
Presumably the previous `Video.objects.get_popular_videos()` is tested somewhere else, and we assert that the videos in the context list are the same.
shouldn't this be checking for '-item' rather than just 'item' ?
these error messages are never used i think
`set_possible_old_flag` is not the best name, but so that you know what you have to do there.
Or maybe you can leave it for now and we will optimize this later.
Not necessary. You should add `unread_notification` class only if notification is really unread.
```php
$schema = $parserClassName::getInstance()->getSchema($className);
$schemaManager->add($schema);
```
hey guys, i thought about something :D

why do we even need the JSON file where we save the classes which we use for the chunk generator.
As u can see i added a chunk_generator entry to the config. 0 = normal and 1 = flat. 
The switch-case takes care of which classes will be added to the JSON file as we first create the world.
Why not take care of this every time we load the world?

Just remove the
if (chunkGeneratorManager == null)

and remove the loading from the chunk_generator.json file and it will work the same way.

So we don't spam the SAVED_WORLD directory with unnecessary files.
These can be left alone because it is a reference to the value specified with the key relationships model. However, the value specified by the relationship_field_names method does need to change like you did.
maybe someone wants to have an implementation wrapping the Doctrine implementation ? In such case, using DoctrineBundle to configure the doctrine implementation still makes sense.
Perfectly fine here, but in config you usually have only a reference to the service Id...
The derivative needs to be squared:  (derivative(self.formula,  measure.value)) ** 2.
Yes, I like that. I'll make that change.
comment this line
yeah we would do this as well.
"Save"
Remove knowledge of cargo and refueling, see below.
I haven't been choosing versions sequentially, this one just felt right.
Just write for female.
We have these strings as constants elsewhere.
no objection

On Dec 19, 2012, at 12:52 PM, Barnaby Rowe <notifications@github.com> wrote:

> In galsim/correlatednoise.py:
> 
> > @@ -0,0 +1,328 @@
> > +"""@file correlatednoise.py
> > +
> > +Python layer documentation and functions for handling correlated noise in GalSim.
> > +"""
> > +
> > +import numpy as np
> > +from . import _galsim
> > +from . import base
> > +from . import utilities
> > +
> > +class CorrFunc(base.GSObject):
> > +    """A class describing 2D Correlation Functions calculated from Images.
> Mike, I'm happy to make the CorrFunc a container for a GSObject, simply to mark it out structurally as not in an is-a relationship with this base class.  Would anyone else object?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 


-------------------------------

Rachel Mandelbaum
rmandelb@andrew.cmu.edu
http://www.andrew.cmu.edu/~rmandelb/
Well, the last sentence too.  Scale can be changed by providing the dx keyword, just like for draw.  

But I was more suggesting to copy the corresponding paragraph from draw which is slightly more descriptive about the various options to parallelize the two doc strings.  (Starting with "This method can create..."  -- obviously keep the current sentence about binning photons.)
these calls are necessary?
Hmmm so if we embed the video in the email then theres no way to tell if they watch it.... hmmm

but isn't the idea of the video to persuade the friend to visit the site?

Shouldn't the video be included in the form and then under it be like click this awesome cool link to donate to the project I'm tring to help!!! Then when they click the link we keep track of that
On Fri, Mar 30, 2012 at 04:27:39AM -0700, Raphaël Pinson wrote:
> >    include apache::params
> >    apache::conf {$name:
> >      ensure        => $ensure,
> >      path          => "${apache::params::conf}/conf.d",
> >      filename      => $filename,
> >      configuration => $configuration,
> > +    notify        => Service["apache"],
> 
> Did you mean to use `Service["apache"]` here and `Exec["apache-graceful"]` above?

The idea was to restart the apache daemon if a conf snippet is added to
/etc/apache/conf.d, because it could contain Server-context directives,
which require this.

If a conf snippet is added to /var/www/<sitename>/conf, then we are
necessarily in a Virtualhost-context, and I believe "apachectl graceful" is
sufficient in these cases.

The idea is to try to avoid as much as possible restarting apache when a
graceful would be enough.
Include the name of the audio formats supported by audiolab in the help  option
I think the enable/disable needs to be deeper. If it's at this level then the ordering of your system configuration being loaded and Evenitron being initialized matters. If it's down within the client or a top-level flag referenced from within the client then it doesn't matter what order it happens in.

I'm in the habit of switching to 'merkin English when I code as that's what the core libraries and keywords use. With Ruby in particular with the lack of intellisense you have to think "is this code I'm in control of" in order to determine if it's -ize or -ise. Defaulting to American English avoids that tripping you up.

I'd also say that for Evenitron the majority of our target audience is American, given the larger population and the larger Ruby/Rails community, our ideal customer being a Heroku user, etc. Even if we use British English elsewhere, this project should be in American English.

:phone:
if value.size != 2 || !ISO_639.find_by_code(value) とかですかねぃ
we should not check this in the code if we want to register a account then it should be a different method
```Slet nyheden permanent```
These are major modifications to common test utilities. Make sure you've run all the tests (and there are no regressions) before checking in.
i think this should be oncomplete(username) instead.  then username can be null or an actual username.
No, it wouldn't be, it'd be the bot's nick
This should probably be namespaced to help differentiate between the "montage application load" and the standard DOM "load" event.
When I try to require this ^ after active_resource in irb, I get false, so it must be already required for us by ARes
I'm a little confused, why does ```default_params``` need a ```resource_name``` passed to it?
Зачем output открывается здесь?
Since you have already pulled out 'volumeControl', you should use it here instead of chaining the function binding. This will make the code easier to read.
s/sandboc/sandbox
"return fi.isWritable();" is even more readable, and a bit shorter
Actually now that I have the validation working, I'm hitting the bug you found (tests fail). I'll fix it and let you know when you should recheck. Thanks.
Här hade du missat att skriva `rader` :)
`over-fits` instead of `under-fits` here
don't think they should be.
I'd rather move this to base.py.
Ok, what would be reasonable? 2**20 (one megafeature)?
if pos_label == None and n_labels == 2, it does not break but the case 
is considered a binary classification case whereas it should be 
considered a multiclass classification case because pos_label == None 
(cf. documentation of sklearn.metrics.precision_recall_fscore_support)


Le 30/10/2012 20:49, Alexandre Gramfort a écrit :
>
> In sklearn/metrics/metrics.py:
>
> > @@ -652,7 +652,7 @@ class (default is 1). Everything else but 'pos_label'
> >      if not average:
> >          return precision, recall, fscore, support
> >
> > -    elif n_labels == 2:
> > +    elif n_labels == 2 and pos_label != None:
>
> what happens if pos_label == None and labels == 2? does it break?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/scikit-learn/scikit-learn/pull/1296/files#r1983873>.
>
ок. приймається
This makes me miss Kiln.
Why isn't that: buf->writestring("unittest {}"); ?
I find that syntax to be confusing to the reader as i would then start thinking why this is calling the parent version directly, since it looks like it's avoiding potential specializations of the function.  Also if it were to be overridden in this class then the new overridden version wouldn't be used without modifying this line.  

In general this construction breaks the model of letting the runtime chose the method to use based on the actual type of the pointer.

With that said, i leave it to you to remove at merge time or leave as is.
Espaces en trop devant La liste des entrées ?
This no longer seems needed due to `theme_ting_search_carousel_javascript()`?
The side effect sets the logTimings variable. This construct is used a few dozen times in the surrounding code (once for every option) - commenting all of them would IMHO be overkill. The code is pretty clear when viewed in context.
This should probably have a comment about needing the user (which could possibly be obtained from the IResultSetFactory)
I think it should always be considered an error for the constructor to leave a field uninitialized.The constructor can call init() if that is appropriate.

Apart from anything else you get warnings from some compilers/ide's if you don't set a value for all fields. And there have been quite a few cases in Thor where Valgrind pointed out fields that were in fact accessed before start() / init() got called.
Is it valid to assume both have the same pathsepchar?
Also, it appears we are using Mozilla products in the tests. I don't think this is a big deal, since you're providing your own data it should just work.
old code, I agree
Lastly, none of this belongs in models.

Models should just be a simple harbour before you fly out to the middleware. Move all of this code into views.py
```assertFileNotExists``` added
Tip - use [assertCount](http://www.phpunit.de/manual/3.7/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.assertions.assertCount).
We're no longer installing git-flow via homebrew, and were ensuring the version number is the latest `stable` version.
No, that logic should be left to the feed.
Oh right, since the .fitVids() is called on the container, not the object. I'll change it
```os.path.join()``` is preferable.
3 blank lines! take it easy there :) (same for test_thresholding.py)
`multichannel=True`
This example is broken and does not work for me.
This is a really nice example. Thanks!
You can replace this line (`im.shape`) with `plt.autoscale(False)` and then remove the calls to `xlim` and `ylim`.
need information that time is in UTC with iso8601 encoding
http://api.jquery.com/slideToggle/
Why not re-use the existing billboards and only add/remove when the word is shorter or longer?
I don't think it would be of much value to actually share the cache, but it could be beneficial to have a canvas cache in other places.  We'd have to profile to be sure.
What is the default `repeat`?  If it is `(1, 1)`, leave it out.  Users can read the wiki or reference doc for all the uniforms.
Same as above, if this function is needed more then once, you can put it in the Torrent or even YarrProvider.
I also fixed this bug.  I used
    UITableViewCell* cell=[_tableView cellForRowAtIndexPath:[_tableView indexPathForRowAtPoint:point]];
Which I think is a lot nicer.  It uses the built in tableView properties for finding a  tableViewCell given a point.
It's a safety precaution. Bad things happen if either Ti or Titanium gets redefined.
If the controller needs to execute addBlueWindow,  why do we have the onOpen handler here?

Never mind. You know, the previous example is nonsensical (you would never open a navigation group and then immediately open a second window on top of it).

Instead, perhaps we should just list the markup for the nav group and the second window, and then show the controller code that you'd use in the controller for the first window:

`navgroup.js`:
~~~
var blueWin = Alloy.createController('bluewindow').getTopLevelView()
$.nav.open(blueWin);
~~~

Did I get that right ;-)
I'm not seeing the updated commit. Did you push it?
I don't think there is an element with this id in the HTML?
Achei melhor por que não tenho que ficar escrevendo no testes Humanize::Bytes::Byte, Humanize::Bytes::Kilo, etc...
After this step there needs to be an assertion to check that the featured tab is selected as per the litmus 'expected results'
cheers,
marlena/zac
I'm not sure if I understood you. I'm happy to make any changes, but if I change the "///" additions to "//", then the templates will not get documented at all.
>I tend to react very negatively to any insistence of people changing the style of their code precisely because I hate being told how to format my code (it's one of the worst parts of having to deal with other programmers IMHO). So, in almost all cases, I'm generally going to fight against any attempt to require a particular coding style. And while I agree that having an inconsistent style in a file is undesirable, I'd honestly rather be able to just always format the code that I write however I want to even if that means that the resulting overall style is inconsistent. But I do try and keep what I write consistent with the rest of the file, because it matters to other people like you.

Experience with various codebases has convinced me that a uniform style helps a lot, in particular with wasting time on discussions like this and also in reviewing random whitespace changes whenever someone feels like changing some code. Coding exactly the way you want is one of the perks of solitary projects.
Ho, I though you wanted to replace the code with an assertion. Yes, after all operation, assert(translatedLower <= translatedUpper); should be always true and can be added to make the code stronger.
> hey, are these very common names at top public level?

As there is no difference in `public` or `private` in respect to name clashes as access level is tested after overload resolution I don't understand what did you mean here.
Okay. I added `See_Also` note which links to `takeExactly`.
There is a certain amount of precedent in `std.traits` for raising an error instead of returning arbitrary sentinel values for invalid input. In particular, the traits that reflect on functions will generally error if the input isn't a function. I think that behaviour would be more useful here than this `0`.
You may want to do something with the ExceptionToCatchEvent if the exception wasn't actually handled.
I was organizing TestClientsEngineStage by grouping mock servers, delegates, tests, etc & adding a comment for the group. Is it just the @author that you prefer I remove? Or the entire comment?
think more in a dll; retrieveModelDescriptionOf(....)
this doesn't matter since ofTexture sets the correct values, i've just removed those 2 lines
I don't see why? We still want an error to be raised if the target doesn't respond to that method and the resulting exception will prevent generate_silence from being called, which is probably what we want.
Nitpicking: since you only use this variable for membership testing, I'd probably use a set (constructed using set()) rather than a list. But since the list is never going to have more than ~20 elements, the difference here is probably on the order of microseconds, so I wouldn't worry about it.
Changed to one line. It looks way cooler under OSL and CAT :)
What about removing this? It's redundant with @SerializedName.
This crashes when notes is empty
Yes, for example the default private userspace has a number of i18n keys embedded.
I'd suggest we namespace these, so these would become

```javascript
sakai.api.Util.Modal.setup()
sakai.api.Util.Modal.open()
sakai.api.Util.Modal.close()
```
be explicit about variable names `dump_header` and `verbose`
Is there a reason to use window over document here? It seems like we typically use document for these sorts of bindings, but I could be wrong
Yeah, I'm aware of this but I'm not yet sure if we need some kind of deprecation here.
Probably it's better to annotate the whole core.sys package at once.

Anyhow it's undeniably a bug to let a C library call back into throwing functions.
Luckily we already have that correct for [atexit et.al.](https://github.com/D-Programming-Language/druntime/commit/370ffd8d6da3978f742fd17572b418aaf85db355).
Maybe those should be moved there? Or is there a reason they're only here?
Side note: Can't we just import these from `core.sys.windows.windows`?
Pretty sure you mean. personal preference - one statement one line.
typo initailized

"Serializers can not be provided if this adapter is __initialized__ with __an external__ RedisTemplate. You may set serializers directly on __the__ RedisTemplate".
suggestion. looks sane overall.
Lines are too long
I think we shouldn't use the constant in the tests, but instead hard-code the value here.
`type` is missing.
Don't believe those errors. :-) So yes, the problem is that there is string returned from GET. My mistake. But int should be good enough. Can you convert to int instead?
PREROUTING is not a built-in chain for the filter table, but I think you can apply policies to any chain in a table, so maybe this value shouldn't be limited to the built-in chains? (I am by no means an iptables expert so I may be off base here.)
``|previous_release|``?
Entering the rotation with a text editor would solve these ugly approximations.
should it be something like this:

```xml
<php>
        <server name="AUTOLOAD_FILE" value="./Tests/autoload.php.dist" />
</php>
```
Muito bom ein! Mas eu sugiro a refatoração seguindo o exemplo: https://gist.github.com/1988936
`send` can throw, we should wrap it in try / catch black and at least log the error.
Following the pattern described in the docs for ["Filters and auto-escaping"](https://docs.djangoproject.com/en/1.4/howto/custom-template-tags/#filters-and-auto-escaping)
will help if you can undo this. Does not seem to be needed for feature 1.
For the user/pass handling changes you've suggested, I need some clarification.

The implementation suggested above does not seem to read the values from the text input boxes if they  were not supplied.

The current implementation treats user and pass as optional parameters -- if the optional parameters are not supplied (determined by checking the number of arguments), the default behavior is to read the values from the text boxes.  If the text input boxes were not filled in by the user, the empty string will be read from the text input box.

Perhaps the change you would like to see is:

1) Check for empty URL (i.e. url.length < 1  OR  url === '' )
2) Not call open w/ user and pass parameters if user was read from the username text box and user is empty string (i.e. user.length < 1 OR user === '' )
3) If user but no pass, add empty pass (i.e. if user.length > 0 AND pass === '' then set pass to '' before calling open w/ user and pass params)

But for #3, if pass (read from text box) is empty, its not necessary to set it to empty again.

For now, I will implement #1 and #2 above --- if this is not what you mean, please clarify what change you'd like to see.
sub-pro perties?
Is there any callback to notify when the async function returns? Is that documented elsewhere in this class?
Why are you appending it to an empty string? You already call toString onit.
Terrible hack #1
Where do I do that? I haven't done that before.
`else if` instead of `elseif`, and it should **not** be on its own line but just after the closing curly bracket.
Why are you doing this twice?
is this intentional or left over debugging code?
Still has incorrect undefined checks. It should be using typeof
Ok for this vars : localize_date_format and localize_datetime_format
I'll correct that and re-submit.