labofsahil/github-event-dataset-2012 huggingface dataset:
Simon's game, one of the most challenging games ever.

You are suposed to memorize and repeat a color and sound sequence wich increases by one on each round. You win the round if you are able to repeat the whole squence, if not you lose and must try again this round or start over.

More info:
http://en.wikipedia.org/wiki/Simon_%28game%29
I added that for you Kenneth. :P
That's Pythonic. In Ruby, we raise ArgumentError.

```
irb(main):001:0> 3 < 'a'
ArgumentError: comparison of Fixnum with String failed
```
This breaks niceEditors.findEditor('someTextAreaID') which is the documented way to get a specific instance. Perhaps it was intended to go elsewhere?
how are you redirecting to an instance variable? Cant seem to understand it.
This looks like a model thing. We should try to move it there
Shouldn't you check `not group_found` instead?
Thanks Mike,

Can you try and re-send this pull request and base it off the 0.9-devel branch? I'm positive this has been fixed in the latest at 0.9-devel (if not, please ask me to merge this again but this time to the head of 0.9-devel). This should make it into 0.9.3 which Glyn is currently working to release soon.

Cheers
copyright year is 2012
@christianv : according to our naming conventions, this should be currentPath. I'll make the change.
I tested both postgresql and mysql both worked fine.
well spotted, thank you. Next patch asap.
La línea está removida, está ok el commit.
so which of all these test are good ?? :)
This leads to a crash when you remove a trigger.

    Process:         Quicksilver [89917]
    Path:            /Applications/Quicksilver.app/Contents/MacOS/Quicksilver
    Identifier:      com.blacktree.Quicksilver
    Version:         ß63 (3912)
    Code Type:       X86 (Native)
    Parent Process:  launchd [214]
    
    Date/Time:       2012-01-20 11:31:23.744 -0500
    OS Version:      Mac OS X 10.7.2 (11C74)
    Report Version:  9
    
    Crashed Thread:  0  Dispatch queue: com.apple.main-thread
    
    Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
    Exception Codes: KERN_INVALID_ADDRESS at 0x00000000e08e51a7
    
    VM Regions Near 0xe08e51a7:
        CG shared images       00000000c79b9000-00000000c7bd9000 [ 2176K] r--/r-- SM=SHM  
    --> 
        Submap                 00000000ffff0000-00000000ffff2000          r-x/r-x process-only submap
    
    Application Specific Information:
    objc_msgSend() selector name: countByEnumeratingWithState:objects:count:
    objc[89917]: garbage collection is OFF
    Performing @selector(removeTrigger:) from sender QSGlossyBarButton 0xa3a3a00
    
    Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
    0   libobjc.A.dylib               	0x92060d47 objc_msgSend + 23
    1   com.blacktree.Quicksilver     	0x0001284c 0x1000 + 71756
rewind "edits 7" to capture changes first and then most of the moves
const 呗
Have found a fault with this and I think it's to do with the transparency. The parent scroll bar (main one) messes up a bit.
I am having a mess of a time working with git.  The biggest problem is learning the terminal interface and the github interface.  So it must have too me an hour to get my first commit going.  i have not mad any changes to my code yet.  That's the next step.
I have 2 tables user and permission. A user may have more than one permission so I came up with this:

select * from user u
join permission p on u.permission_id = p.id

Now I want to retreive a User + List[Permission] 

with the user being of type:

case class User(id: Pk[Long], Seq[Permission])

User.single ~ ( Permission.single * )

The compiler throws this error:
type mismatch; found : anorm.ResultSetParser[List[models.auth.Permission]] required: anorm.RowParser[?]

This had worked before the refactoring, now it does not anymore.

Please also see my post here:
http://groups.google.com/group/play-framework/browse_thread/thread/ca758fa370a5fc1f
Both should  use ${commons.version} otherwise the release plugin fails to resolve the dependency version automatically.
Why use the git protocol? Some firewalls block the git ports, but not http.
Hi Tom,

Why do you want me to push someone else patch on the dev branch ?

Thibault

Le 18/02/2012 18:29, Thomas White a écrit :
> Can you also push this to the _dev  branch, please?
>
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/LimeSurvey/LimeSurvey/commit/3e868ee1357956fb6c701772536b3d24bc0c1cf1#commitcomment-981321
This doesn't test anything. You must specify #once
I don't think Rails provides a very elegant way to solve this problem out of the box. The best thing that comes to mind immediately is to provide some love for decent_exposure (https://github.com/voxdolo/decent_exposure) users where exposed objects are automatically hydrated from whatever content type is being sent to the request.  I'd love to see this support since, AFAIC it is the right way&trade; to expose objects to views anyway. We could isolate it in such a way that decent_exposure users would __have__ to require it (like `require 'roar/rails/exposure'` or something). The next best solution I can think of is to provide a before filter or Rack middleware, neither of which feel right to me. I'm certainly open to any other ideas, but.
^^this!
I'm curious, as I don't really understand this, why is this SpeciesSchemaModel and not ActiveRecord::Base ?
Credits to?
Kelsey, we mentioned earlier that we should check for local changes before deleting modules.  Is that still the case?
Greetings Ralf,

Thanks for the heads-up. I've been a slacker on switching my mailing 
lists to my new address - I'll jump on that now! Also, I am now in a 
position where I can actually work on the cwt stuff as part of my 
personal development time at work, and so I could actually help in this 
effort!

Cheers,

Sean
>> *From:* Ralf Gommers 
>> <reply@reply.github.com 
>> <mailto:reply@reply.github.com>>
>> *Date:* February 1, 2012 1:58:08 PM MST
>> *To:* Sean Arms <lesserwhirls@gmail.com <mailto:lesserwhirls@gmail.com>>
>> *Subject:* *Re: [scipy-cwt] More minor changes to 
>> scipy/signal/cwt.py, like rearranging the order of Classes and 
>> Functions. (ee67365)*
>>
> Hi, on scipy-dev there's a discussion on better wavelet support in 
> scipy which you may be interested in. There was another developer who 
> had also started implementing CWT, I pointed him to this repo.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lesserwhirls/scipy-cwt/commit/ee673656d879d9356892621e23ed0ced3d358621#commitcomment-923998
y u delete stoat? >:
Jan had even showed a way for Siri to pick random replies.



On Feb 11, 2012, at 12:44 AM, onetootreefor
<reply@reply.github.com>
wrote:

> some of the responses you replaced, replaced real iphone 4S responses. Not a big deal, but I like to try to keep it as close to the real thing. Some of the ones you replaced are alternate responses for the same question, so we need to KEEP BOTH not just replace ones that already exist. When I return home Im going to start on making multiple responses for the same question.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/caughtinflux/SiriServer/commit/3c16eabdf6aaa05c74742950f330fcad05c2c3e0#commitcomment-954941
It should actually create the classes defined below.
@matthiasnoback, thank you very much for fixing these errors.
Is there a reason why you wrap the above inside a Fiber? Does the fiber potentially get suspended in #send_data or Readline.readline?
Why do you need a nameValue Pair <b>Dictionary</b> for every name value pair ?
These links need a `rel` attribute describing the relationship between this representation and the one being linked to.
Thanks. You are absolutely right. Can't believe I haven't seen that! :-)

You seem to have added some unrelated changes to your patch, though. If you create a new pull request that only does fixes the “'not in' after 'not'” issue I'll merge it right away.
I think the support for git 1.5 should be kept for now. The only remaining difference I see, is the remote branch prefix.
@relation MyRelation

@attribute att1 numeric
@attribute att2 {val1,val2,val3,val4,val5}
@attribute att3 string
@attribute att4 date yyyy-MM-dd
@attribute att5 relational
@attribute att5.1 numeric
@attribute att5.2 {val5.1,val5.2,val5.3,val5.4,val5.5}
@end att5

@data
3.141593,val3,'This is a string!',2001-11-09,'4.141593,val5.3\n5.141593,val5.2'
2.718282,val1,'And another one!',2000-12-01,'3.718282,val5.4\n4.718282,val5.1'
Split out looks good. Reviewed
Since we have variables for all the other selectors in this file, shouldn't we also have something like

`var show = ".show"`

on top of the file?

Apart from that it also feels like this classname could easily conflict with future code.
if you put settings up there all sets of elements that you extend with lazyload will have to refer to the same settings. So settings2 would overwrite (extend) the set1's settings:

$(set1).lazyload(settings1);
$(set2).lazyload(settings2);
Checking array of integers is dangerous: I have a regression dataset where responses are all integers. A more reliable way would be to count the number of unique values but this can break too.
# Homework 3

| **Part**  | **Points** |
|-----------|------------|
| base      |  1 |
| advanced (ascii) |  0.25 |
| humor and design | 0.25 |
| **Total** |  1.5 |

I love it.  The insults were unrelenting, the math problems are well integrated with the conversation, and all the output is cleanly formatted.  Your code has no errors in it either.  Only a couple of notes:

```python
# original code
greeting=raw_input(""+name+": ")

# the leading "" isn't necessary, name is already a string
greeting = raw_input(name + ":")
```

```python
# original code
print "PrissyBot: On a scale of 1 to 10, how annoying are you?"
scale=raw_input(""+name+": ")
scale=int(scale)
s=int(10-scale)
print "PrissyBot: Add",s,"to that, and you're spot on."

# cleaner/shorter
print "PrissyBot: On a scale of 1 to 10, how annoying are you?"
scale = int(raw_input(name + ": "))
print "PrissyBot: Add", (10-scale), "to that, and you're spot on."
```

Finally, since your printing seems clean, you might want to look at string formatting in python.  You can find more information it [here](http://docs.python.org/library/string.html#formatstrings).

Anyways, for hurting my feelings, I give you the [asterisk](http://youtu.be/JTVpxxzb2Dc) award

![award image](http://scienceblogs.com/pharyngula/upload/2006/10/asterisk.gif)
Returning `$text` is actually not sufficient. Tests still fail.
[quote]
# krb5-config --libs gssapi
-Wl,-O1 -Wl,--as-needed -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -lkeyutils -lresolv -ldl
[/quote]
may be replace 
CORE_LIBS="$CORE_LIBS -lspnegohelp -lgssapi_krb5 `krb5-config --libs gssapi`"
to
CORE_LIBS="$CORE_LIBS -lspnegohelp `krb5-config --libs gssapi`"
Vale entonces no es cosa de esto, haría falta poner el AttackStart(){return} para que no entrara en combate y no despawnee.
Doesn't look like en-US :)
I thought you might be interested to know that my fork of this project, which has undergone a number of changes for my personal use, is also failing tests now that I upgraded to 616.
Add ldpi drawable
guess it would make sense to add a README.md so the project can be better searched for
runnerwindows.rb should probably be DRY'd up, since it's largely a clone of runner.rb, but with slightly different methods.
Well, no offense but its done completely wrong, unless you don't want other plugins to be able to make a addon -.-
não curti muito isso, alguem sabe como usaria isso com metodos do rspec? tipo periodo.turmas.should have turma
Moving default config params to it's own file.  See other SS plugins as reference.
Please, read
http://goo.gl/6bse4
Does IE10 support the non-prefixed event as well?
@ericf my version avoids being recursive by moving index by index through the array. If it finds an array, it uses `splice` to expand that array into elements of the first one. It only moves to the next index when the element is not an array. So it's not shallow. It's ranking in the middle probably because it creates more intermediary arrays and has to check `array.length`: http://jsperf.com/yui-array-flatten/2

I thought recursion would be more expensive. It's nice to go back to a problem and learn from others :)
Can't this be replaced with http://commons.apache.org/lang/api-3.0.1/org/apache/commons/lang3/ArrayUtils.html#isNotEmpty(T[])
I will alter the port shortly. (I am in the middle of a changeset and cant quite commit yet) Will post an update in a little bit.
ok, it's the `dummy` overloading clash
I don't think that this one should be tagged LongRunningTest (since it takes about 3 seconds to run), but I do think that we should tag some of the tests when they do take a long time. I can imagine that provoking the failure detector in weird ways will need actual wall clock time to pass.

Maybe the multi-node tests should be tagged with something automatically so you can exclude all of them easily.
Because otherwise we wouldn’t know how to create a Future during `ask()`. But we could also change that to require an `implicit ExecutionContext`. (That was all from akka-actor, still diggin’)
hmm, don’t think so, since that would turn `true` a bit too early, no?
Quick note here:  I think SNAPSHOT versioning is odd with Ivy.  This isn't "canon" with the Ivy way, but I *think* it should be ok temporarily.  You really want this to be a timestamped version, and have "integration" set on the Ivy metadata.

It should be ok for now....
yes, you can, that is in your control, since you started it
this actor is just a listener that runs the registered callback at the right time, once
if you change your mind and don't wan't to do anything in your callback that is also fine
this can take a string... like for example, a selector
Yes, using core.abbrev would be nice.
Why is the File.Exists(path) entry here ?
Hmm, I wonder if you could save some lines here by having a dict mapping 'dataset', 'user' and 'group' to the matching action functions. Not a huge deal
This was relatively easy to merge forward too, I've fixed it a bunch of times already.
This part should include "Berker Peksag" as well.
what about, if request.post starts with `[`  ( I mean array )
These both seem to be unimplemented.
Why was this added? The name of the method indicates to me that this class shouldn't respond to it.
Whould be final
This change has raised another issue for me....

Nodes run on workflows before this change were run with a maximum harmonic order of 8 as a float and now the values are not considered equal.
With workflow level as DEBUG and stop_on_first_rerun it says 8!=8.00000 and reruns the node...

Perhaps we could compare the numbers after datatyping them both to float?
I think the behavior has only changed for 1D arrays. For example, in numpy 1.6.1:

<pre>
In [17]: a = np.zeros((1,3))

In [18]: b = np.zeros((2,3))

In [19]: np.concatenate((a, b))
Out[19]: 
array([[ 0.,  0.,  0.],
       [ 0.,  0.,  0.],
       [ 0.,  0.,  0.]])

In [20]: np.concatenate((a, b), axis=10)
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-20-1db841fd19b0> in <module>()
----> 1 np.concatenate((a, b), axis=10)

ValueError: bad axis1 argument to swapaxes
</pre>
(1) Yes, unfortunately numpy doesn't have an in-place swap function, so the temp buffer is used to accomplish that. The array is still modified in place -- two lines down the buffer gets written back to it. (2) And yes, this only shuffles items in the outer array, which is what the function is documented to do. I'd have thought shuffling along an axis made more sense, but the API was made 5+ years ago so...
typo "adeed" --> "added"
php.h is used for DEFAULT_SLASH, IS_SLASH and INI_STR("extension_dir").

Do we have equivalents in the Zend world?
actually it exists .. just in the API docs there is a typo NODE_TYPE_MANAGEMENT_UPDATE_IN_USE_SUPORTED
http://www.day.com/maven/jsr170/javadocs/jcr-2.0/javax/jcr/Repository.html#NODE_TYPE_MANAGEMENT_UPDATE_IN_USE_SUPORTED
I'm :+1: on this change. No records should be added to the database in a migration.
Can you check to see if there is a way to do this with ARel nodes?  I want to reduce the amount of raw SQL string concatenation we have.
You could make `id: :DESC` and `id: :foo` etc raise an `ArgumentError` though.
I think it cannot be removed, it has been removed from the json pull request #7527 when I asked to, but @rafaelfranca had to add it back in 4fa2f10494260c0937ffe066aace09747e57d7c7, otherwise [postgresql tests fail on Travis](http://travis-ci.org/#!/rails/rails/jobs/2352045/L127).
Same thing for blank lines here.
Let's not be so gung-ho with the 1.9 hash syntax.  If we commit everything with 1.9 hash syntax, it means that backporting becomes a PITA.
Again, remove this addition as we're creating a separate `assert_redirects` method.
Sorry but we're not supposed to deprecate things in stable branches anymore.
I wonder why Paul wrote `locally` here.
Please don't change unrelated files.
merge these two comment blocks?
might want to remove your user name... also, could add a note saying we will attempt to automatically detect the location of the SSW if none is specified here (if you think that is feasible).
namedtuple requires python version >= 2.6
Put an empty line under all your header lines.
1. I think that the proper name-token must be `._to_mpmath`
    See [comment 9 of issue 2418](http://code.google.com/p/sympy/issues/detail?id=2418#c9)

2. Removed function can be used outside, so it will be better to form it as @deprecated.

3. Please add the tests with method `.evalf` which uses `_to_mpmath`
Whenever you use the & and ^ for the dot and cross products it is probably good practice to always enclose the operation in parentheses because these two operators have special order of operation rules that don't necessarily act like you think they do. In this case it is fine, but I think all example code that a user may possibly look at to figure out how to write their own problems should have this explicit. New users may spend forever trying to figure out the bug if they type something like

```
A & B ^ C ^ D
```

and expect the order of operations to match they way they think  about it on paper.

Look back on the sympy mailing list, the online docs, or old pull requests to see how these operators work (or you may already know).
I'm pretty sure I have it right. Let's make it concrete

```

>>> j = 0
>>> for i in range(3):
...   if i == 1:
...     if j > 2: break
...     j += 1
... 
>>> print j
1

>>> for i in range(3):
...   if i == 1:
...     if j > 2: break
...   if i == 1:
...     j += 1
... 
>>> print j
1
```
Why this distinction? Is it not better to always return the same type?
> This is correct because gcd, lcm and others always give monic results over a field.

I know.  I was just pointing out that it should be the same way for Float.  Even if `gcd(1.2, 4.2)` gives something other than `1`, `gcd(1.2*x, 4.2*x)` should give `x` (or `1.0*x`).  You mentioned that it was inconsistant above. But I guess the inconsistency you were referring to was the function vs. the method.
global declarations should go at the top of the function, I believe.
I'm saying that for Categories in zk12x the language codes are already correct and the method should not be called at all, since it empties the display_name/desc. The method was (when reading the code) only meant for really legacy language codes like eng, nld and deu, those are already en, nl and de in zk12x, so the method is not needed to call for Categories with version >= 1.1
one too many.  [[NSMutableSet alloc] init] is already retained. no need for the additional retain.
Please, use "UserShell" and "User" instead.
then this can become (no sense in doing the check twice and define ```obj``` which really cant be used in a useful way.

```javascript
return existsSync(filepath);
```
The `__init__` docstring should go as a "Parameters" section of the class docstring.
Should be wrapped in a (shared?) closure/service.
Race condition: what if the following happens:

  * Worker thread: write() EAGAIN
  * Main thread: drain pipe
  * Worker thread: set async_sweep_needed

I suppose you should retry the write after you set the async_sweep_needed bit.
Error received on Mac?
You shouldn't get here at all.
Check please in IRB:   RUBY_PLATFORM
it should be darwin
I would consider setting the default value here to 'nil', usually I will run with command line arguments.
Better ask Alexey, our tester.
Having the userData in a file like this is going to make it rather difficult to edit on the fly.  I'm assuming one of the things in the userData is the specific version of things that you want deployed and when you change from one AMI to another it's possible you will also want to change the userdata.

I think we should use ZK or MySQL for storing this in a node-agnostic, persistent fashion.  It should also be editable via an endpoint.
Changing back to Identities, since its recommended and what we're doing in Deathstar.
Document error/exception return. If there is no false return don't return true on success either.
Return values aren't documented
I would be a-ok with a global.

> Since it's static it does not matter much where it is, since there is no coupling.

If I'm understanding you correctly you're saying it "works fine". I don't dispute that, rather it is my opinion that this is a poor interface.
Why set this to 0 here? It should be set to $config['default_style'], while setting it to 0 works, it screws with the ACP statistics on which users use which style.
Rewrote this section entirely.
I don't see where ConnectionMessages uses these events.
this is not longer supported, use yui->config->debug, logLevel and filter accordingly.
I'm surprised that this is needed, since the port can only be an integer, no?  (The change can't hurt.)
@imalberto so this feature is targeting "mojito build" right? If that's the case, how is this different from having a custom yui->config setting in application.json for a particular dimension with these custom values: comboBase, base, combine, filter?
You changed the code here, but made no change to the logic.  Why?
Continuing the great tradition of turning nouns into verbs... could we PEP8 the names please. I'm looking at you "Fake_GribApi", and you "Fakeup_Gribapi_Context"!

(While you're at it, the use of the word "context" doesn't really add much and is a bit reverse-Polish.)
Would be nicer if the XML output didn't include default values; only used two attributes for ellipses; and just used earth_radius for spheres.
e.g. This example would become:
```
<geogCS earth_radius="6371229.0"/>
```
good results *for* some graph*s*
I added a comment explaining this that I'll push in a few minutes.
use filter or getByPk instead of all this code
put a space after ,
I'm not sure if the issue is here but:

Something I observed when I dropped in to debugger in the `QuantileCurveCalculator`: Some of the randomly generated PoE values are greater than 1.0. Is it coming from this function?

Also, why are the weights `1` for the first realization and `0` for rest? For test data, this doesn't make sense. A curve should never have a weight of `0`; if the weight is `0`, then the curve shouldn't exist.
...but `createInputPseudo`, `createButtonPseudo`, `:checked`, `:text`, and `:button` all skip it. If we can't pull up a case where a node lacks a `nodeName`, maybe it's time to drop the guard everywhere.
I'm a little confused as to why - can you explain?
Actually, i notice the existing function text_to_cstring. However, there are some error when linkage. I try use text_to_cstring again, it works well. Maybe i have something wrong before. I will change to the existing functions: text_to_cstring and cstring_to_text.  Thanks.
(For that matter, can we re-use the same rendering for both of them?)
We can't really have things hosted on people's dropboxes. Also, the URL has to be versioned to prevent breakages if the package is updated.
Please justify your statement.
Explicit version not needed; it will be detected from the URL.
Define two base exception hierarchies - rest, and non rest.  Both have same semantics.
Oula c'est choquant... Je ne cerne pas ce que tu voulais faire.
I'll have a look at the txAMQP routing key.

for the email-like flexible routing mechanism: [keyword]@[shortcode].[internationalprefix]  :)
You can have multiple layers of dispatchers, so you could split by shortcode using one set of dispatchers and then split by keyword using another set. I'd rather have several simple things than one complex thing.
I don't know... rootpy_globals.py will attempt to wrap these globals in a better way. What if we set ROOT.gPad to an invisible canvas initially and prevent it from ever being None?
Should we add this to all 'message' handlers?
This endif is superfluous!
it seems less readable the way you propose, i'd keep as is
Aha, you have fallen for my trap of agreeing that readability is more important, thereby forcing you to admit that `pk` and `v` are shitty names :p
if Array.isArray(accounts) might help safety too?
Is it worth optimizing this a little since we do this functionName test twice?

```
matchingFunctions = functions.filter(function (funcEntry) {
   return funcEntry.functionName === functionName;
});

if (matchingFunctions.length === 0) {
  return result.resolve([]).promise();
}
```
So this is for a case like `<a rel=" href="foo">` ?  Might be good to add an example like that in the comment -- I had to think for a minute to understand what this case looks like.
For methods that return nothing (i.e. `undefined`), our style is to omit the `@return`.
Oh that's right. So right now it is getting the quotations around like and the label shows up like this: 

``` Search Results for: "<query>" - X matches in 1 file ```. So I guess I have escaped query or should I put in like this? 

``` javascript
.text("for: '" + query + "' " + summary + (numMatches > FIND_IN_FILES_MAX ? StringUtils.format(Strings.FIND_IN_FILES_MAX, FIND_IN_FILES_MAX) : ""))
```

Thanks!
The jasmine formatted timeout message currently reads ``timeout: timed out after 10000 msec waiting for success NativeApp.closeAllLiveBrowsers``. I think we can skip the extra "timeout".
Those are list items. I've rewritten it to be a sentence instead.
Should remove the comma here since there are now only two items in teh list.
Can you add a space after {APP_NAME} just like you have in the above line? Not only this instance, but you have others with {APP_NAME} or {APP_TITLE} without a space. Can you fix all these instances for consistency?
The parameter name might be clearer as `normalize`.
Changing the font size like this is a bit jarring. How about keeping the font size the same, but changing column to be "span5" instead of "span4" (BootstrapReporter.js, line 33)?
Are these two functions not already somewhere? We do this __all the time__, so if there's something off with the function we call, you should just fix that function. (Or at least put these next to it with a comment about what's different and why it'd break things to use one over the other.)
I like keeping the X-Update-Range header the same as the http Range: header. This would imply that the = should still be in there.

The Content-Range response (oddly enough) does not include the =, but the 'Range' request header does have the =
what about the ModeMap in those partial values? does it contain the expected stuff?
WmsLegend and UrlLegend now in master
I'd recommend following a convention where private fields start with an underscore. Right now it's hard to differentiate between variables in a method and a private field.
It will be BigInteger, not BigInt, as the MongoDB API is in Java land. Use fully qualified class name here to avoid confusion.
could you use here #elsif instead of another nested #ifdef clause?
Should this be cleansed a bit with `!!`?
Why the extra whitespace?
Should be:

  -moz-transition: opacity 0.5s;
  -ms-transition: opacity 0.5s;
  -o-transition: opacity 0.5s;
  -webkit-transition: opacity 0.5s;
  transition: opacity 0.5s;
Please leave this.
This else could also disappear, right?
These entries were all added as a result of 'DISTRONAME Linux' style bugs. Since we're stripping the word 'Linux' from those names they are no longer necessary.
Yes, I've been thinking we need that as well, but I've been returning 400/500 level codes for now. It's probably worth for us to add in this exception handling this week anyway, so just leave as it then.
see if you can make FILE_COLUMN property a static field of this class. Then you can use it later below when fetching out of the cursor.

If you do this, you may have to change CursorReadingVisitor.columnIndex to use property.toString() instead of property.name
Такой проверки в условиях задачи небыло
is this line really necessary? The is the same as the plugin id.
Don't like the idea of doing Organization.find(default_org) in haml.  Look at the model changes I 'll suggest in user.rb to account for this. The call ->  current_user.default_org must always return an org object not an id. How its stored in the database should not matter.
danke dir.
Some comments in here would be awesome
Seriously I'm interested in supporting edge cases, when it breaks and someone has a valid scenario, then I'll rethink it. YAGNI.
require放在dateFormat外边，影响性能的
local function targetGroup()
    if hasbuildrule then
        return groups.CustomBuild
    else if ...
    ...
    end
end

table.insert(targetGroup(), node)
Also, then it would be fine to do `pkg_dir = os.path.join(self.dist_dir, 'pkg')`
This is mainly a matter of style, but should we use the `@property` decorator here instead?  All the Pythons we support have it, including the `@property.setter` extension.
There are no leveldb tools; I think 'recovery' is the same as 'opening', and 'crashing' is the same as 'closing' in LevelDB. There are a few flags to set the degree of checksum verification or paranoidness when opening, though.
I think just changing this check to `if (substr($key, -11) === '.ini.php') {`  should allow the function to accept any file ending with `.ini.php`
Why go to separate get/set methods?
Even if doesn't throw an error its a bad thing to do imo.
Use sprintf for this
Leftovers from copy & paste!
Missing a space after $strData.
Doe it.
Don't use a space after a :
z duvodu kompatibility mezi 32-bit a 64-bity se do _IO* jako posledni parametr nedava ukazatel. Pro oba pripady -- zapis i cteni -- tam bude proste int.
I can go with the `or`, but the `is_string()` stuff is necessary to make sure that password fields won't be repopulated. Checking with `is_null()` would not be enough.
This was added to make it synchronize with how other method works under HTML::link*
This is duplicate. See L507.
I would go ahead and put the NotImplementedError here, since you're already redefining them to be no-ops in the inherited classes.
Actually, meant to ask if this is different from the one in `apps/sumo/utils.py`.
You can replace these 3 lines with `.border-radius(6px);`
I ideally want it to be placed globally too, but plistlib isn't available on any other OS other than OS X prior to Python 2.6. Do you know of a better work around?
`urlparse.urljoin` works differently. `urlparse.urljoin` joins, for example, a host with a path with a query string. 

Perhaps an unfortunate use of a function name of my part. Should I rename mine to "url_join" or "urlconcat" or something you think?
Everywhere else you have fresh new pep8 variable names but here.
They are. :)

The raven client captures the local variables and sends them up to sentry for inspection.    Locally - I'm seeing that these two configurations are different, when they should in fact be the same.
As it happens, adhoc queries have landed on sqerl master. I don't think we should change our approach at this time, however.
I don't like to be picky about style guide stuff, but you're not consistant with out style or even consistent with your own code :)

    if (condition)
    {
    }
    else
    {
    }

That is ideal :)
What is the goal of this private property which is written but never accessed ?
copy / paste error "(if the address object is an array)".

Should there be an example with multiple constraints ?
the FormView does not seem to be used in the code
i assume this was a mistake
shouldn't it have an interface to be able to mock it in tests ? Mocking a final class is impossible
the test should include an assertion
Sorry but I am not here to fix the all the test suite because it's not currently properly formatted.

Someone, in the past, decided not to mock a TableMap and use ItemQuery and ReadOnlyItemQuery instead.

I am not here to discuss if their choice was right or not, I was ok creating test cases for my PR, but fixing|rewriting other test cases because they do not match the required formatting expected right now, I do not have the man power to do that and I am not that experience in the Propel code to do so.

I found a problem with my test data, understood why it was happening and found a fix that will not break other people code. Trying to understand other test cases to be able to modify their test so that the test suite looks good, I cannot do.

An I am pretty sure it might not end there, trying to mock TableMap might ask for another class to be mocked, etc ...
The logout method is still inhertied from the parent. It is not removed.
That makes sense. I agree it would need more work to be more robust and safe. But if you don't think it is worth having we can scrap it and let the user explicitly build the queries.
Find all? Where do we want to show all the comments? In something like an activities page?
optional.. but we should start moving to 
self.pinScales = @[@0.31,@0.57,... ];
It will just use the ruby in the PATH.  We could hard-code it to be safe, but it seemed like a potential referential integrity problem.
Yes I see it for NOFF it can done easily but to change some structures..
Oh, its conditionally optional :)
Code style

`node? registry[node] : registry;`
The styleguide method wouldn't be accessible if others added more controllers. It's best to keep application wide methods like this in ApplicationController.
Is there a reason to use allcaps here?
If I was to receive this error in the caller code, I think `UnknownError` is probably not quite descriptive enough. I would probably recommend `UnknownFreezerError` or something similar.
There's nowhere else to go. The only extra overhead is checking if `element.parentNode` exists.
Or filter on menuItems here with item.index? (regarding the bellow comment)
I think I copied this from another widget and I have no idea why its different to to the appendTo call in _drawMenu. I will adopt autocomplete's code here, ok?
removed .htaccess match
This declaration doesn't match the docs in the rest of this file (or the actual declaration): `$tablet-landscape` vs `ipad-landscape` and the addition of `phone-portrait` aren't propagated.
Indentazione sbagliata
Hi @borjasalguero , it is already REM Have a look at https://github.com/gtorodelvalle/gaia/blob/d9b9846038ba00cb4fd885006580cfa553136737/apps/communications/dialer/js/recents.js#L805 and https://github.com/gtorodelvalle/gaia/blob/d9b9846038ba00cb4fd885006580cfa553136737/apps/communications/dialer/js/recents.js#L806 There we make the conversion from pixels to rems. The rest can be computed in pixels since the getComputedStyle() returns the data in pixels ;-) Thanks for the comment!
No, I tried that. Also title.textContent = " " collapses as well. We need a non-breaking space for this to work.
And if this path is defined in gecko, it might be better to add some comments about that it's a predefined path.
nit: utill -> until
Suggestion: You could ask WindowManager for the app name. You do not have to solve that in gecko side.(Bug 801810).
No need for the intermediary variable. Also it seems a bit weird that tap takes directctly a target while the other methods (swipe, down) takes a event.
Nope, that's something that we need to remove :) thx for catching
Gee I wish we have StringEncoding API implemented ...
Please use “on/off switch” instead.
/me messed up and left it in there :(
The X is in here to force CSS float clearing. Would a period (".") fix the screen reader problem? Thanks for reporting this.
why ``endswith`` over ``==``?
Okay. Lets just add an issue to add specialization for max/min/first/last.
For functional testing. Clarified.
I prefer to keep a space before each new access declarator
Doesn't fix the issue as $info[0] doesn't exist in the error case. Casting value to array could help -- or adding if ($info) $this->bind($info); with the original code.
This needs to be fixed..
Agreed. I had planned to break it up into three parts at some point, but I just haven't taken the time to do it yet.
Basically... ChatComponents need.
```java
ChatChannel activeChannel;
final Set<Channel> channels = new HashSet<Channel>();

void chat() // sends message to the active channel
void chat(Channel) // send message to specified channel
void join(Channel) // joins a new channel
void leave(Channel) // leaves a new channel
```

These should probably have events as well.
there seems to be a whitespace issue here
Missing continue in if branch - if name is not in scsis, removing cause ValueError exception. This is correctly handled on line 136
s/currenlty//g :)
This is wrong. For modularity each resource should not require the app. Just set `module.exports = /* the resource */`
>>> 1. Don't leave spaces before commas
E.G `HasGeek Media LLP · No 194, 2nd 'C' Cross, 4th Main, Opposite Domlur Club, Domlur 2nd Stage, Bangalore - 560 071`, I find space after `,` .
Unnecessary condition is always true
I'm not sure why editing the creator is based the creator not being an admin. I think this should check if one can edit the creators settings - so if creator is current user or current_user is an admin.
As it is "specific" to Mongo driver to require a ruby datetime object. why not use the conversion to DateTIme inline in the output only
 @tmphash['@timestamp'] = DateTime.iso8601(@tmphash['@timestamp'])
By `check` do you mean `checkbox`? If so, the longer name is easier to understand. Ditto for the "CheckGroup" class name.
+1 for some StringUtils action.
Could you take this occasion an rewrite the [unit testing](https://addons.mozilla.org/en-US/developers/docs/sdk/latest/dev-guide/tutorials/unit-testing.html) in the[CommonJS style?

We're trying to remove the old ones, that is very confusing for the collaborators.
Nit: not sure it's worth appending this header to the content, I think `content` should probably come with it's own.
You missed this one. With it fixed we can go and land it. Thank Alex!
Flow control ?
I see where you are coming from and it may be overkill.  My thought process was that the condition before only tests non day-spanning times.  These three tests actually test that when a range spanning days is given the behavior is essentially still the same.  I could remove them if you'd like, but I was trying to be overly thorough with these tests.
That comment is bothersome; does this still return the same true boolean rather than a generic boolean?
Yeah, I think putting them in the Puppet::DSL space would make a lot of
sense since they seem to be related to the ruby DSL.

On Thu, Aug 16, 2012 at 7:15 AM, Mateusz Lenik <notifications@github.com>wrote:

> In spec/unit/dsl/context_spec.rb:
>
> > +
> > +require 'puppet/dsl/parser'
> > +require 'puppet/dsl/context'
> > +require 'puppet/parser/null_scope'
> > +
> > +include PuppetSpec::DSL
> > +
> > +describe Puppet::DSL::Context do
> > +
> > +  before :each do
> > +    prepare_compiler_and_scope
> > +  end
> > +
> > +  context "when creating resources" do
> > +
> > +    it "should raise a NoMethodError when trying to create a resoruce with invalid type" do
>
> I created Puppet::InvalidTypeError and Puppet::InvalidFunctionError. I
> placed both classes in lib/puppet/error.rb.
> Should I relocate them to lib/puppet/dsl directory and rename to
> Puppet::DSL::InvalidTypeError, etc. to make them DSL specific?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/puppetlabs/puppet/pull/1041/files#r1392845>.
>
>
Same as below: please drop this comment, this is only noise.
Not sure - I moved it over from the other document as-is.
Sorry, this commit is the latest by the looks. Let my just apply my changes.
Renamed and added a safe addToHead function
With the HTML5 spec, this is the format (French or otherwise). If you choose not to use the HTML5 input helpers, you are more than welcome as a user to extend this class and override the getDateValidator() method, which was part of my intent here for a separate method.
That won't catch the null case. We'd need both.
Hmm, Isn't `@see` is for class/method reference? `@link` is [mostly for  URLs](http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.link.pkg.html)
Remove all the spaces in the parenthesis
Same doc string as above.
Just HydratingResultSet is fine here.
Up to you, really. My thinking would be that if it's a convenience wrapper, you may as well also have it include the "plugins.rest." prefix as a convenience. But it was just a suggestion, so feel free to ignore it.

If you do, though, then you need to fix the call sites to include the prefix in `getInt`/`getString`.
Try using a breadth first search instead of recursion here to reduce the number of required method calls.

```
<?php
while($ids) {
     foreach ($ids as $id) {
          ...
     }
}
```
Why not `User.authenticate(params[:username], params[:email])` here instead?
As long as it is not made impossible by the api ;-) I honestly see no point in declaring this "bad practice", at least for user code...
Upgrades repo from previous versions
change docstring to something like "Support for building and installing Pasha"
So should I revert it ? =)
An custom Response could help. But why you want to call it multiple times ?
I was actually wondering more about a stateless or singleton bean (I can see a extended PC being used though)
True, nice code. Myself I just copy/pasted and added to what the tastypie guys do, to keep it close to their code base. I'll consider changing it, to make it smaller.

Thanks!
This shouldn't have to change. Habitat let's you `.get('identity')` and receive an object if the env variables look like `OPENBADGES_IDENTITY_XXX`, I think.
no real reason, I can change to lower case tho,
It looks like this only needs to be the following:

```
} else if (token.type === LOGIC_TOKEN) {
```
Yes, we decide to use the _id for security reasons as the unsubscribe link would be:

http://craftsmanship.sv.cmu.edu/unsubscribe/50a71f70a3559903f4000001

vs

http://craftsmanship.sv.cmu.edu/unsubscribe/johnleee

We don't believe it'll ever happen but this will make it difficult for malicious users to unsubscribe other users based on the github id.
could be leaky, consider ```with```
> and I do have first hand knowledge that the packages will have \\ in their path name

Ah, ok. I actually think this is a mistake.

"Windows compatibility" means you should be able to run Node on Windows, install the Stitch module, and everything should still work. It does *not* mean, for example, `require` paths should suddenly start using '\' in their paths. This would tie your code to the system it's developed on, making collaboration nearly impossible. Requiring that stitch uses Unix paths parallels the uniformity of URLs.

That said, if Node accepts both forward and back slashes for `require` for paths, stitch should also. Though it should accept both forms from all operating systems like Node and not be dependent on the developing system.
Yep, would add it back, and rebase. You don't actually need to do another pull request -- fine to just 'git push -f' this branch; the pull request will automatically update.
Doesn't the `tz` variable there possible have underscores in the name like "Los_Angeles"? So, for the caption part we could do a humanization of that.
“Second error\nFirst error\n"
Try this for saveAuthor
```
function saveAuthor(item,xpathAuthor,doc) {
	var contents = doc.evaluate(xpathAuthor, doc, null, XPathResult.ANY_TYPE, null);
	var author;

	while (author = contents.iterateNext()) {
		item.creators.push(
			ZU.cleanAuthor(
				author.textContent.replace(/[\s\d-\.]+$/, ''),
				"author",
				true
			)
		);
	}
}
```
same with this one. `$('p').addClass('foo bar')`
It is not required. lock() and waitForLock() is individually usable methods. If it was unclear maybe we should rename waitForLock() to something else? Waitforlock() will attempt to lock for a given amount of time.
Still probably executes module_load_include far too often.  Perhaps it's best if this gets pushed into a seperate file, or included with the class it extends.
nit: can you put this in a `<p>`? it should look the same but I don't like mixing block-level and inline elements.
It only goes in this else if (!this.isSprinting()), so how can this work? o.O
ooh you're right! dammit I was thinking in Ruby again...
CoffeeScript allows commas to be omitted when list items appear on separate lines:

```coffeescript
exports.types = [
  'Artifact'
  'Basic'
  'Creature'
  'Enchantment'
  'Instant'
  'Land'
  'Legendary'
  'Ongoing'
  'Plane'
  'Planeswalker'
  'Scheme'
  'Snow'
  'Sorcery'
  'Tribal'
  'Vanguard'
  'World'
]
```
Let's say, it is normal, the url of nextPage and thisPage shares a same prefix. If not, it could not be the nextPage.

but the baseURL seems not right. so I changed _getBaseURL as well.
а почему эта функция в тесте? это основная функция как мне кажется
guard как-то плоо соотносится с файлом
`sure`?
Yeah, I'm not sure what was going on there
It does work, you're using an outdated version of PHP :)
This is a cool function. Is it something that already exists somewhere?
Interesting fact:

If we swap [:restrict_plugins and :restrict_controller filters](https://github.com/resolve/refinerycms/blob/ba98e45c6363f5ee5aef381f0b708347f3076594/core/lib/refinery/admin/base_controller.rb#L12) then [Refinery::Plugins.set_active(plugins)](https://github.com/resolve/refinerycms/blob/ba98e45c6363f5ee5aef381f0b708347f3076594/core/lib/refinery/admin/base_controller.rb#L50) sets active plugins and `Refinery::Plugins.active` in my previous comment returns an array of plugins.
I think passing getCached in makes this function quite hard to use. Which places are planning to use getFullConfig?

- I would rename getFullConfig to getConfig, retrieving the config for a tenant
- I would remove getCached, and always assume that the cached version should be retrieved if the globally exposed function is called
- There could be an internal function to re-retrieve the cache from Cassandra.
Done, I'm using:
```
assert.equal(users[loggedinUserId].hasOwnProperty('thumbnailUrl'), canLoggedIn);
```
now
According to http://www.datastax.com/docs/1.0/cluster_architecture/cluster_planning#keyspace-planning, we should make our replication strategy 'NetworkTopologyStrategy'. Can you add this into oae-util?
I think the postComment/createComment function should deal with both posting a top level comment and posting a reply to a comment, by accepting an optional replyTo parameter.
Added a `furnitureStatus` Array and doing some checks on it.
This can be shortened to `Cassandra.runQuery(q.query, q.params, callback);`
You wonder, I agree :)
Typo. Should be MCPlayerDropItemEvent.
Does this solve http://bugs.dokuwiki.org/index.php?do=details&task_id=1970 ?
the Pathname.mkpath should be the mkdir_p. I just do not wanna add a new method such as force_to_file. so I set:

* force_dir the default is no to keep back compatibility.
* first check the dir whether exits before making path.
да - Вы проверяете совпадение, чтобы не сделать замену на идентичный символ, но в случае совпадения всегда берете, так сказать следующий элемент. Просто в качестве рекомендации - можно было бы генерировать случайные числа внутри цикла с предусловием.
почитав описание метода вынужден признать что этот if осмысленный
Скажите, зачем вам такое свойство?
Необязательно синтезировать свойства. Если не синтезировать, то доступ к ним можно получить через _dna и _dnaSimbols
проперти нийциализируется в геттерах
We are not using fixtures anymore (we are using blueprints to generate fake datas).

I think you can safely remove this file.