labofsahil/github-event-dataset-2012 huggingface dataset:
Why not use JavaConverters as in the other cases? (same for CamelMessage)
That's what you told me, and it certainly seems to be the case.  Should we delete it and wait until we have a feature designed for it?
if it's getting the wrong set during the rename then the problem is in the attribute tracking (using the wrong name at the wrong time), not here.
Please be more specific.  You want to put them on a different class, that's just moving them.  You don't like the method names, or the way it uses the class attributes?
1. And now check 5 lines before that, you can't be sure thus it needs empty() first.
2. You're right, that's an old left-over from before we standardized it. Still any new contributions need to follow the [coding standards](http://docs.fuelphp.com/general/coding_standards.html)
3. It was a binding suggestion, non negotiable. We do screen pull-requests to keep things consistent and ensure quality. I always allow people to fix it themselves so they'll get credit when we pull from them, but if that it's too much trouble to work with feedback I'll just code up the fix myself in the suggested manner.
more whitespace needed
Please add an empty line above the if
What is "output"?  I don't see that var anywhere in this class.
How about the ``mask==None`` case?
Typo--strength.  But what is the "strength" of a Hann filter?
shouldnt the space spanned by the two contrasts be orthogonal for that to be true?
I'm probably missing something, but how do I define a url without an action. And how do I write the `h.url_for` in `get_proxified_resource_url`? I'm sorry if these are stupid questions but I couldn't find a better way.
Huh? Is this going to break IGroupForm and its support for multiple group types?
Looks like you had more to say.
Changed in commit 0ebe9e19.
Seems more readable now
Ooooh..... Still look weird but ok
Looks like you're missing some {} here
if (i==0) {
...
} else {
  return i;
}
Since the privacy mode applies specifically to notifications, can you put something to that effect in the variable/enum/setting names?

e.g. global_settings_notification_privacy_mode and enum NotificationPrivacyMode
这一行为什么注释掉了？
Here both `-P` and `-L` are accepted, but only `L` is implemented.
done, seems like I added it doing some test
As far as I understand, the PHP constructor is not called, which means that the template line is not guessed and the message is not updated accordingly. Here is the relevant snippet from `Twig_Loader_Error`:

```php
        if (-1 === $this->lineno || null === $this->filename) {
            $this->guessTemplateInfo();
        }

        $this->rawMessage = $message;

        $this->updateRepr();
```

To avoid updating the C extension whenever we change the PHP constructor, is it possible to call it?

I'm going to send a PR with additional unit tests that prove the problem.
I would, as my last argument in this "case", like to point out that it's less than 40 lines of code (and less, if factored out) to implement this, and would take considerably more if it were outside of the `TUITableViewCell` implementation. =backs out=
You forgot these ones with the commit! :panda_face:
We don't care 1.6 for the moment. When we will remove the deprecated code, we'll do what we should. 

Here, I don't want an other file check. It is useless and it has a cost for perf.
That's right. Removed.
`b(options.with_dtrace)` and drop the `and options.with_dtrace` check?
Does this work correctly with daylight savings because we later call setHours?
:-1: 
Nikdy nemůžeš předem vědět, kolik bude potřeba paměti na zpracování chyby. Například takové vygenerování laděnky do souboru bude vždy potřebovat víc jak 10kB.
Navíc je to plýtvání pamětí kvůli edge case, se kterým se téměř nikdy nesetkáš. Akorát se plýtvá prostředky serveru. Jaká je pravděpodobnost, že na produkci vznikne fatální chyba (tj. compile/parse)? 1e-20%?
I tend to think that it's best to have simple invariants on the C side, simple invariants on the Python side, and code in one place to translate between them. That way any single piece of code you look at has minimal external dependencies to think about.

So I'd just translate None<->NULL in trace_data_allocations, and use only NULL in the actual callbacks.
I think the proper way to add these comments is `# => true`, can you please change that? Thanks.
I think you can just check for `empty?`:

    (record.class.column_names - record.attribute_names).empty?

Also, the method could be a predicate, like `contains_all_columns?(record)`
1. Why these extra test cases?
2. Consider mirroring the test cases in https://github.com/rails/rails/blob/master/activesupport/test/inflector_test.rb#L45-71, so that when each of the words are tested separately in their own test case. i.e. When one or more of them failed, the rest will still be tested instead of skipped.
I think otherwise it'd raise an error if this is loaded before `ClassFolder` ([which does contain that constant](https://github.com/frodsan/rails/blob/532b8cd4960cb18c83093dbf88208a27b644fcc2/activesupport/test/autoloading_fixtures/class_folder.rb)). But this might defeat the purpose of [dependency loading test](https://github.com/frodsan/rails/blob/532b8cd4960cb18c83093dbf88208a27b644fcc2/activesupport/test/dependencies_test.rb#L208) for these constants, which I believe is why it's like that. @frodsan can you give some thoughts here?
This case points out clearly what I'm not a fan of in this PR - it changes the semantics of validating inclusion from "if the record is valid, the data will be one of these" to "if the record is valid, at least *some* of the data will be as specified but the rest could be whatever".

For instance, unless I'm missing something this test will also pass:
```ruby
assert Topic.new("aliases" => [1, 'foo', :bar, {baz: :wat}]).valid?
```

Note that exclusion still works correctly, since having any of the excluded values will cause the record to fail validation. The culprit in the inclusion case appears to be here:

https://github.com/durran/rails/blob/4036439631c86e705614a5a09fe34a79b22fa06c/activemodel/lib/active_model/validations/clusivity.rb#L26

The behavior I'd expect would arise if the `any?` there changed to `all?` in the inclusion case - DeMorgan's theorem strikes again?

The need for error messages with parenthetical notes also seems like a smell that this validation is wearing one too many hats...
I'm not sure, can we force to define attribute methods here? @josevalim
I think you could test that it does not respond to `:production?` before to ensure that, and also test that `str.production?` still returns true afterwards.
Why not just show a compileTimeOnlyMessage?
You must mean "sorted.tail exists disagreeTest", not "contains".  You are checking if a sequence of MethodSymbols contains a Function1[MethodSymbol, Boolean], which is unlikely.  (Covariant contains, the bane of type-safety.)
I don't quite get the logic of ``elif`` here.
OK, let's get this in and continue improving it. Especially if it is
being used for GSOC work. That way we can start ironing out issues.
Turns out that I actually needed the False case. I like the simplicity of the new function. Is it possible to get some of the old behavior back?
It's only a matter of habit «optimize all that is posible to optimize». The matrix multipication has a O(n^3) time in general, so i think it will be a good idea to reduce this time werever we can.
Yes it actually does go away. Would the test be clearer if it was written simply `assert conjugate(Order(x)) == Order(x)`?
We could treat spaces around operators with the same sort of flixibility that is given to space after commas and require that there be at least one (but perhaps more) on each side of an `=`.
No. `as_coeff_mul` always returns a Rational

```

>>> (-.3*x).as_coeff_mul()
(1, (-0.300000000000000, x))
>>> (-.3*x).as_coeff_Mul()
(-0.300000000000000, x)
```
Two things:

  - Without the Factory(:instructor) in setup, then the course isn't in the database at at the time we visit the course page, and the integration tests blow up.
  - I think the Factory. deprecation is only for defining factories. Resolving a factory still uses the Factory syntax. I updated to the latest factory_girl gem, and FactoryGirl(:instructor) did not work, and I didn't see any deprecation warnings in the log.
Okay, it does not seem very usefull to have controllerPath of a module outside of its basePath.
If one follows the conventions used in the guide it will work, so I think it is okay as it is.
Honest!
Doesn't look like this import is necessary. If needed, add it to the scala section.
It's being used here to warn about the change in authentication; removing it is out of the scope of this change.
Rather than using $('#clickForMore'), change the above to not use an ID and then use d3's .each() and select the anchor relative to the excerpt or simply use .on() to bind a click handler to delegate this to the excerpt itself (which can catch when the event bubbles and check that the event.target is an anchor tag with the proper class or data- attribute).
Да наверное с лайнендами косяки)
getUnitsCSS*
didn't someone at MDNYC mention we can/should leave 'let' here? or change it to 'var'?
viasat 4 is already included, please be careful and double check if you don't make mistakes.....
`Number(choice)` would be more appropriate here, I think.
OK, move to avatar manager then.
No I didn't, my bad. Never mind.
nn- wanted the version usage consistent with the changes that were made to the 3.1 docs and 3.1 uses 3.1.x on this line now.
> You mean you want to rename the $row variable throughout the mcp_forum_view method?
Strictly speaking this is not necessary. You can create additional variable(s) for the event dispatch.

Whether it is better to change the surrounding code to use better variable names or create aliases for event api can be debated.

> In my opinion, if there is any confusion about what a variable being passed into an event contains, we should add comments above the $vars = ... call, rather than changing the variable name in the rest of the code just so it is clear in the event call what the variable contains.
We want to improve the quality of our code, not keep the mess that exists forever. 

> And to clarify, after looking at the code, $row contains the array of data about a given topic. $topic_row contains the template variables filled with data from $row.
This does not appear to be a particularly good choice to me. Again, when this sort of thing happens locally in a function it's perhaps not a big deal, but when it becomes part of a public api there is a problem.
Unlike main_* events this is actually the overall footer, i.e. same code as used in prosilver's overall footer. Correct?
On correct operating systems you can read /dev/random (on slightly less correct systems it's spelled /dev/urandom).

Lacking that, http://us.php.net/manual/en/function.openssl-random-pseudo-bytes.php looks like a good fit and is 5.3+.

Lacking that (at runtime), I don't see why we have to md5 the salt, thus drop that part. Then either http://us.php.net/manual/en/function.uniqid.php (and note the caution) or mt_rand, call them about 10 times, concatenate results, truncate to desired length (100 chars?).
Very much improved in 0c181da6fe04f4f9d9c50b22ffac166847b5e8dc
typo with encounter
Това ли имаш в предвид?

```
users/show.html.haml
  when a user is not logged in
    doesn't show a link to the edit profile page
    faculty number
      is not visible
  when a user is logged in
    shows a link to the edit profile page if viewing user's own profile
    doesn't show a link to the edit profile page if viewing someone else's profile
    faculty number
      is visible when viewing user's own profile
      is visible when viewing someone else's profile as admin
      is not visible when viewing someone else's profile
```
Also does not work in reverse order. `filter()` would do the trick here.
Small small thing:  I don't think this comment is necessary.
K. I'm still working through the YUI cookbook to fill out my YUI knowledge.
в последней ноде в резалте возвращался почему то только результат 1го запроса. т.к. в ноде раньше не работал, потыркался и разделил
In your code cleanup phase tomorrow you want to use the old model Patient (and see if you can use the other models instead of creating new ones raxacorePatient/raxacoreEncounter, etc)
should remove ```getBillId``` and ```setBillId```, and put their functionality into this required override methods.
openMRS is using java.util.Date TIMESTAMP format in their dateCreated, so I think we should use that format here as well
rename to settings
Are you sure that w is always of type float64? Event when x is of type float32?
When you insert the extra elemwise into the graph everything fails. This confuses me.
"If lazy is True or False"
please fill in some comments what we are trying to achieve
Why an empty table?
Shouldn't we sort test_results? Or maybe I'm misunderstanding something?
Ну если бы не было несколько классов в одном файле, можно было бы сделать не упячечно
I'd try this:

> Django requires Python, specifically Python 2.6.5 - 2.7.x. No other Python libraries are required for basic Django usage. Django 1.5 also has experimental support for Python 3.2 and above.
Please always use `pun_htmlspecialchars()`.
I'm sorry, Luigi, but this is false. The original bug report (filed by Muharem) suggested a distributed solution; however, when you asked me _specifically_ about this requirement in late July, we discussed it, and agreed that parallelization was not necessary. In fact, on July 31st, you updated the bug description and removed the requirement for using celery to distribute the calculations and replaced it with: `At the moment we should not provide support for parallel execution of post processing task`.

https://bugs.launchpad.net/openquake/+bug/1025204/+activity

Subsequent updates to the bug description seem to remove all mentions of this specific requirement.

Also, treating the status quo of the code in the `master` as requirements doesn't make any sense, especially for implementation details which are not exposed to the user.
@mikesherov Should be .css("width") instead according to #810?
Code with class type names like "State", "Ref" can be made easier to read if, within the same file, a explicit "using" statement or even comment saying which namespaces they are under. It is actually better to have these also for types like uint16_type until they are really everywhere in the code base. But since they have a special name, it is okay to find them by "grep". The declaration of "State" or "Ref" is hard to find... They are too common.
We need an array with size N rather than 1.
Again, pointer to MADLIB issue also desirable.
Unclear why this is necessary or what it does.
Might as well use `item_id` here instead of `doc['id']`.
This doesn't test anything.
I'd preface these with Package Group and Package Category. Group is such an ambiguous term I like to make sure the context is always there.
Is there a better way of doing this which doesn't involve a separate case for older edited things which still have the 'editted' property as a boolean?
Nit: copyright header?
Can we back up a step?  Let's bounce back to the issue (#80), to see whether what's being implemented here is the best way to get what you want.  The core of JUnit has not yet enabled any features that enable changes in behavior based on global state--I'd like to thoroughly discuss the solution space before committing to changing that behavior now.
In general `String(foo)` is safer and calls `toString` internally if appropriate, but this should be fine.
Man this stuff is hacky. Not saying I really have a better way, just that it may be fragile, so let's make sure to keep an eye on it and make sure test coverage is solid so this doesn't break in the future.
There was actually a test for that specific behavior =/ I'm not crazy about it either, should we just change things?
Ah, yeah. I misread that.
bar!

Yeah, oops. I was debugging a poorly written hitch.
moved. Also, moved the check up to right after mulberry.Device is included.
nope. removed.
Oh, I skipped over your earlier comment. "product" works too.

Relatedly, it's currently hard-coded that links in the caption become child-node like. That could be optional by providing a class to be used on links in the caption. Do we want to provide the option for "normal" links in caption?
OK, I changed it with the last commit
The formatted indentation here doesn't appear when formatted for MD. I've been using the "view file" button at the top of this file in the pull request to test the formatting.
a much better name, thank you!
I think at least until we've decided on a new inheritance pattern to use, this should follow the same pattern as other InlineWidget subclasses:

```
    InlineColorEditor.prototype = new InlineWidget();
    InlineColorEditor.prototype.constructor = InlineColorEditor;
    InlineColorEditor.prototype.parentClass = InlineWidget.prototype;
```

And then you can remove the `_extends()` helper function.  I think eventually we may move to a pattern that's _more_ like this generated code, but it'll be using Underscore so we'd still be throwing away what's here.
Oh, good point.  Looks like the switch is needed but the line above it is not (because there's no .rgb, .name, or .hsl elements anywhere).
Yeah, I see your point about keeping the result area as wide as possible. I agree that the smaller font size seems like the best tradeoff for now. 

Merging.
removeHandler doesn't seem to be used in this function.
It is indeed, I just tested/debugged it. It's the same logic as copy/paste; I guess clicking on a menu doesn't change the "active element" focus.
Please use caps for all enum values.
This is necessary, because not all tests that create cases close cases.  If the process for closing all cases isn't generic enough that it can be specified by subclasses with form and button names, this might be a bit of a problem.
Doesn't `@private` need to be placed at the very end of the comment block?
Move these static routes (robots, sitemap, favicon) into a separate file.
@ericwclymer mentions this method later, but `int eventArgs` seems like a strange parameter to this method.
Not sure I like the name of this variable. If it's for display purposes maybe _clipCountDisplay? If I came across this code I would assume that clipCount was an int or long.
I think the problem here is that we don't want to call insertBefore on every item in the set. Only the before element. I played with the code and this seems to work:

```javascript
Raphael.st.insertBefore = function(el, before) {
  // As of now, only groups can have children
  if (this.tagName === 'g') {
    if (before) {
      var el = el.paper ? el : this.paper.buildElement(el);
      // Reposition the element on the paper
      el.raphaelInsertBefore(before);
  
      // Update the shadow DOM
      this.shadowDom.insertBefore(el.shadowDom, before.shadowDom);
      return el;
    } else {
      return this.appendChild(el);
    }
  }
};

```
FacebookBackend now extends MongoEngineBackend (previous CustomUserModelBackend).
This doesn't quite work. Try using the scrollbars here. To make scrollbars work you need three things:

1. A wrapper div (like `scrollbar-wrapper`).
2. A content div (something inside of `scrollbar-wrapper`).
3. A destination -- somewhere to actually put the scrollbar.

The problem here is that you're applying two scrollbars to content that only has one wrapper, and the scrollbar code is easily confused :P. So, you can do one of two things here:

1. Place each set of content (basic, advanced) inside another div respectively, and maintain one visible content div. When the user chooses a mode, simply place the correct wrapper div (for basic or advanced) inside the content div and update scrollbars. That *should* work.
2. Make two separate `scrollbar-wrapper` divs, using each as the wrapper div for its respective scrollbar. It's content won't have to move that way.

In either case, you'll have to figure out a way to make only the current scrollbar visible/functional.
Looks like this function isn't quite done. `isTrackEventEditor` should check `_currentEditor`, no?
use addEventHander instead of onclick
split `->loadEtcResolvConf($filename)` to new line?
So far I've avoided having validation methods.  Instead of having this method it might be more powerful / light to have a "getUserByAlias" method (returns a user or null).  At the point where you want to validate you can call that method and if it returns null you know it is a valid alias (this method is then also more useful)
What if mkdirs returns false? Javadoc here should document the attempt at ir creation, retry a few times on 'false', and if still can't make it - log a WARN messages since a temp is usually crucial to operation.
Is this date value supposed to be hardcoded?
Ok but, what about projects that ain't air?
test1 or test? Likewise for two lines below.
wrapped this inside a serverside span tag.
Six consecutive `end`s? What is this, Java? :smile: I suspect this won't be as bad if the printing is done as a separate step.
I realize this is existing code, so do not have to change it; however, wanted to make you aware of 'routes.js'.

routes.js is generated from the RAILS routes.rb using 'rake jsroutes'.  This will allow you to use paths in JS similar to what we use within the RAILS app.  For example, the above would become something like the following:
  url: KT.routes.object_system_template_path(template_id),
Is there a reason that you don't want this to be inclusive?
Do you actually need a tolerance? I mean, it is surely possible to have some case where this is necessary, but before having one I would prefer the simpler solution of no tolerance at all.
Haha, yeah man. Subtle.
would it be better to use a regex? though this works in almost all cases probably.
I am going to reject this change. Given that there is only at most 2 cores in the mobile devices and object mapping is a CPU intensive operation, I think the most sensible default for the response mapping queue is 1. You can always customize it in your application if you want to enable concurrent mapping.

I would be open this change specifically for OS X targets where the CPU is more fierce.
This is discussed elsewhere, but caching has been deferred for the time being.
This appears to be a typo (not sure what the exact intended phrasing was...)
os:timestamp() is better, unless this needs to be an always-increasing timestamp for some reason.
Thanks ceeram! you are right.
Yes, you'll get a warning from the include, and the return false will prompt the thrown exception of PHPUnit not found.  That's the desired result if you're trying to run tests without PHPUnit installed.
Originally there were 2 asserts in the same function checking for 2 cases but since I think we can only check for 1 exception per test method I split that into 2.
True may cause problems for projects in which:
* translations are not fully available,
* the feature name already includes (in parenthesis) info about its type (See http://ref.geoview.bl.ch/)
and I don't need to define the method as abstract: the interface already does it
Can you apply the codingstandards here? See https://github.com/forkcms/coding-standards#13-indenting-and-aligning
Or use [Path.GetTempFileName()](http://msdn.microsoft.com/en-us/library/system.io.path.gettempfilename.aspx)
this logic can stay here, as it is a hack
Ah, yeah I missed that the last one had a different pattern.

So...
```python:
dict([line.split(': ', 1) for line in message.split('\n') if ':' in line else ('Message', line)])
```
True, just fixed that one. Didn't check the database class at first. Probably had to do that first... (I know being lazy sucks sometime)
But I do need the path to be able to call unlink().
Whether we use SSL isn't currently in `git_transport` but `transport_http`  because that's the only one that can do SSL. I can put it in the main class if you prefer, but it's just going to be set to `0` on every other transport. Maybe `gitno_connect()` should get a extra parameter to tell it whether it should init ssl?
`git_btype` reminds me of anything but "branch type". Try a longer name. ^^
Do we really want to use uncached here? Topics shouldn't change that often, so I think it'd be better to use the cached version.
this is totally not a big deal. but just because we don't use named colors anywhere else i would love if we could make this a #fff. but we don't have to.
Not sure if we can come up with sufficiently creative descriptive names that would justify these fields.

Just see how uninspired the current names/descriptions for the translations in https://svn-agbkb.informatik.uni-bremen.de/sfb-repos/Projects/I1_OntoSpace/standards/OntoIOp/registry/registry.turtle are.

But once we have alternative translations between the same pair of logics, more creative names/descriptions might come in.
Dependencies are actually checked in to the dreadnot repo, can you run `npm install` in the root of the repo (should pull down the updated request module if I remember npm correctly) then push the updated module.
Good question. :)

For background, if you use an ivar without initializing it, you get a warning like `warning: instance variable @foo not initialized`  So when @document_boost_extractor is read on line 258, you get a warning unless it has a value (thus why I'm setting it to nil).

The three best approaches I've found are using an attr_reader (whether public or private), initializing the variable (as seen here), or checking `defined?`

Ruby also doesn't throw warnings if you do something like @foo ||= 'bar'` even if @foo isn't initialized, but that isn't really relevant here.

more reading: http://mislav.uniqpath.com/2011/06/ruby-verbose-mode/

Let me know if you have any new thoughts on this.
I would renamed it to ``AcceptHeaderParser``
@gimler it is an issue when updating from beta4 to beta5/RC1, not when upgrading from 2.0 to 2.1
wrong class name (btw, this shoould be unit tested, which would have shown you the issue with a Fatal Error)
"form" should be "view"
Done and squashed.
rawurlencode should be used to conform to the rfc
@rande : I think it's better to check it here too, relying only on whether or not the dispatcher is there is not entirely true as it is just an optimization of the current application, avoiding the service to be build when it is not needed, checking here too makes the command more portative.

@lolautruche : I don't think it is a big deal, and I often see this without ```isset()``` in symfony code.
@Tobion Thanks for your reviews, I've fixed the issues you pointed

This one is fixed too, I don't know why github still shows it
i18nを利用したいところ。(これはいいけど…)
not a fan of this ... just looks weird.
But you can keep it, I understand it helps the compiler.
To avoid using FNORD without resorting to perl, you could do
```bash
local words = $( echo "${1}" | sed -re 's/(^|[^\])((\\\\)*),/\1\2\n/g' -e 's/\\,/,/g'
```
which would have the additional advantage of working correctly regardless of the (odd or even) number of backslashes before a comma.
Curiosity: does this work?

```ruby
should_not have_received
```

If so, reads a little better to me.
This should be in cmake's FindBoost. 
Please remove this line (but you'd have to set your BOOST_DIR variable to the current boost install path).
This is a lot nicer now - thanks.
Good catch - didn't spot that. Should be fixed with 5433b2b.
I realize that currently we don't ever populate the password field (since we don't remember that one), but I kept this there anyways in case the user chooses to save the password with a browser feature/plugin? Assuming that's correct logic, I'm still unsure when, for example, Chrome populates the password field if it is saved in the browser...
doesn't this call ``page.all_languages.sort()`` way more often than it has to? How about ``page.all_languages.insert(bisect.bisect(page.all_languages, title.language), title.language)``?
Do you have better suggestions? I can simply avoid this change, entirely.  I can put the full query I need in `cms_sitemap.py`.
It looks like there's an extra comment here. In the YARD docs for most of my libs I don't include any blank comments between the `@api` line and the method definition. It's a small point, but I figured I should mention it anyway.
Uninitialized vars at the top.
although testing..
nit: prefer
`url('images/...` to
`url("./images/...`

other instances in the file :)
A good candidate to add to the Shortcuts class!
or rather generic "dom" names I know add/remove/update are not exactly unique :)
Why we need a `<div>` here?
I would suggest we rename the 'loading' var to 'imgsLoading'
Can you centralize these event listeners into `handleEvent` function? Thanks.
We have two kinds of way to achieve fullscreen in an app:
* Specify fullscreen: true in manifest.
* use mozRequestFullScreen() in your app.

The first one is done by window manager hook:
1. Resize the app by using window.innerWidth and window.innerHeight
2. Set the top to 0 by css.
We do this because this way resolves many z-index problems about app transitioning, instead of only using mozRequestFullScreen in system app for the app. They have the same effect.

The second one is done by gecko surely. 
The case here is:
* Open gallery app, click an image. Click share and choose the wallpaper, which is designed to be an inline activity.
Once the line in `z-index.css` applies, you will see the activity frame is cutten :) Because we forgot the second usage of fullscreen. So copy the height form activity caller doesn't work for this case. That's why I do these.
Running `turnScreenOn()` should not reset the timer here. Once you made the change in L69-L74 you should be able to move back this line. (to L206)
I'm allergic to variable names with number in them, so I would vote for something like `connstatePrimary` and `connstateSecondary`.

But I can see how you didn't want to implicitly give more importance to one line sine they both have the same graphical look. No blocker either.
`typeof(self.bluetooth.dataset.enabled) === 'undefined'`

can be 

`self.bluetooth.dataset.enabled === undefined`

or 

`!('enabled' in self.bluetooth.dataset)`

you may update your code if you want
If you're able to compute the rank here, right when the candidates are being generated, perhaps you could maintain the top 3 list here.  Or at least remember the minimum rank required to be in the top three.  Then you could just prune candidates that will never be high enough, and save yourself time on the sort() later on.  You don't really need to sort the candidates, you just need to find the highest ranked ones, which is probably O(n), rather than O(nlogn) right?
Out of the scope for this PR, but makes me realize we should probably rename this function and maybe have it take the frame as a parameter directly.
I prefer not to indent a simple outer closure because it's only serving as a wrapper, rather than actual functional code that needs indentation to explain what it's doing.
I still think the poll_id_generator stuff is unnecessary. :)
I agree that this doesn't provide tons of documentation value.  @myronmarston, you're right that it merely shows that the DRb option can be turned on and that you can set the port (and that there is no port set by default).

I haven't the foggiest clue how to document this any further.  If you guys don't know how it is used, I sure don't! So I'd vote that if you think that this documentation adds nothing, we just scrap it.  I think the other documentation here is helpful, so I'd like to see it added even if we drop the DRb documentation.  Do feel free to cut these features.  Whatever you see fit to do.
Is there a reason for uppercase X and Y?
I think a faster algorithm is:
```scala
maxRhow.foldLeft(ov) { (oldDense, jmax) =>
  val (j,max) = jmax
  if (oldDense(j) < max.get) oldDense.updated(j, max.get)
  else oldDense
}
```
This way, you only do as many operations as the size of the sparse one.
if i could favorite a function...
Make this a TODO and open an issue to fix it.
You can do it now.
`$.formData` does not exist in this branch you retarded monkey
You don't need this else (as I mentioned in the CL). I'll merge this anyway as it does no harm, but please remove it in a followup.
The type is needed for casting, list does not pass it along.
Yes, but __why__?
I thought, keeping shallow clone separate will increase readability. Besides, if a user set shallow=True and clobberOnFailure=True and we'll have suppress clobberOnFailure and we'll have to handle that situation.
This chdict should not have a category in it.
It should be possible to pass these as option or argument to allow using it in non-interactive mode IMO
Please use a better exception message (``Impossible to build the archive ...``), otherwise you will have to catch it and wrap it in the ArchiverManager
This would also benefit from being changed to "Page can't be loaded because of an encoding error"
Well yes, this page isn't linted. I also was surprised we had code like this around seeing as our normal convention is to force braces even around single lines.

I have a few other points about normalisation and JS conventions that will come in next pull request
I'm sure this is intentional, but what's the reasoning?
Look at those two lines!!! You just love this, don't you...  Note above about the helper methods also applies here as aide to clarity.
Please make this a separate commit
Fixing his by adding a check on minimal length needed to put a IPV6 packet inside the UDP.
I have experienced some differences between the production server perl and the development environment perl. Setting up a test script and testing it would be good.
thanks for the comment.
Please "use strict"
With getter will go away.
It might be worth mentioning that in some cases (generally those out of our control) we might need to deprecate faster than this.
Added this test to make sure that http request objects are properly recognized and converted to CEF data, and also to ensure that it can be mixed in with other normal CEF key/value objects.
I tried initially to make those not map to the spec, but it turned out to be harder to code against, in my opinion. If you feel very strongly, I can try again.
Same here. Why does it have to be a const?
Add a space here :-)
Old values were wrong. In these tests, you computed dp with: `dp = dprime(y_true, y_pred)` but the old definition of `dprime()` was `dprime(y_pred, y_true)`.  (i.e., switched order)
it's wrong, isn't it?
Just to be clear, I get the conventional wisdom about taking the private code out into another class whose purpose it is to do what the private method does - then test it there.

But I dont think this code lends itself well to this approach - we could consider making the config load class a helper on the Hiera::Config class or something along those line then refactor this backend and the config class to use this new shared method. I'd generally handle a refactor of that scope in another ticket though.
I would like to be paranoid and test what is actually in that file. At the moment it isn't clear to me what a user would expect to find in there.
Why are there two places that we perform this evaluation?
As per commit 9c361f16979ab2adf5bce2d3ce786ad88029a16a, we should not manually load mocha at all.
@brixen - check out https://github.com/rubyspec/rubyspec/blob/master/library/date/parse_spec.rb I used that as a guide for writing these specs. I'm happy to go over and improve the quality of any pull request I create, but you've got to be less critical and make it easier for people to be able to contribute. 
I'm particularly appreciative that @dbussink has taken the time to look at and comment on this pull request and I tried to accommodate his requests. As it is the majority of pull requests have just sat ignored on this project. 
I even noticed Charles Nutter's PR sat untouched for months. So I doubt it has much to do with the quality of the contributions.
I'm sure your very busy, and maybe they are not up to your high standards, but that's where someone either needs to comment to help get them improved or explain why they are being rejected. Otherwise, I'm not sure there's so much advantage in the project being open source.
I don't think we need sudo, the app runs with the same user it's fetched as.
Would this just be a matter of changing the Exception message text ("Locale does not contain a region")? Or should some logic be added to fall back to a default region for a locale that only contains a language part?
has subdir
This implementation looks really expensive.  I'd not accept objects here since PHP already handles objects just fine ($obj instanceof Type).

This abstraction should really only be for string class comparisons.  Also, the body below can also be simplified for performance.
You forgot the first parameter!
Have you seen the Travis build indicates that your commit has an error? The error can be related to a test or coding standards.

Here, it's an CS issue :
> tests/ZendTest/Log/Writer/AbstractTest.php (trailing_spaces)
> library/Zend/Log/Writer/AbstractWriter.php (trailing_spaces, braces)

```php
} catch (Exception $e) {
```

You should add import (e.g. use) for the Exception class, and configure your editor to remove trailing spaces auto.
yeah, i put the bracket on the new line...
This doesn't receive any params.
[This comment is supposed to appear on line 1297, which is outside of the diff. Let’s see whether that works.]

> `if vidRes.getString() == vidResList[res]:`

This is never true (unless the resolution is one with an unrecognized aspect ratio). I suggest `if self.GetVidResField() == vidResList[res]:`.
Fields.FirstOrDefault(f => f.Equals(input[0], StringComparison.OrdinalIgnoreCase),

Also, yank this into a separate function. There isn't a reason for it to be declared inline.
Ignore the above, github automatically format the XML :-/

.<property>
              .<key>0</key>
              .<label>Read a book</label>
            .</property>
            .<property>
             . <key>1</key>
              .<label>Watched TV</label>
            .</property>
            .<property>
              .<key>2</key>
              .<label>Other</label>
            .</property>
ah I see what you mean, that makes sense
@anti t-funkkarit uupuu.
Ok, I get typeEquals now, but this does not apply to hashCode() that does not take parameters.
JSHint yells at you for having 'use strict' and an undeclared variable. It has the added benefit of being a nice way of seeing what parts of the script are being pulled in from other files.
this should be url
add space after 1000
I think we should default the time to -1. This way we don't need to cache a currentTime + 1, and if a function is later applied, it would be unexpected if it fired at a seemingly random time?
а навіщо ми перевіряємо ext? є валідатор на MIME type. хіба якщо не вказано $ext, то буде проблема?
@tpope Check the following url out, It seems `github.com` will automatically redirect  the `.../tree/...` part to `.../blob/....`

https://github.com/tpope/vim-fugitive/tree/master/plugin/fugitive.vim#L12

But is there a way you might come up to guard against this at code level instead of depending on the github redirection?
(Write is used as a noun, i.e. "the write object", meaning the argument to the write method. That is an explanation, but there is still potential for improvement.)
How about making the target a random spot in the sequence... set TARGET_NUMBER as a random between the first and last and then use cardinal to state which one?
Wow, I've never heard of that before. I discovered that answers was a global by accident and just assumed it was Resig magic. Will revert immediately.
Are we still skipping the shim? The purpose of this pull request is to not do that, right? So this warning should be removed I think
I can't see this used anywhere?
Search and replace :)
domains are lowercase
you should return 1 here to set the appropriate exit code
Remove this line. Code should be easy to read, and not require comments. if it requires comments, you need to break it up into a new method.
Just add a new file directly instead of having it imported from somewhere.
It's just a static file, so it doesn't really matter.
How about `create-console-appender`, and have it take the level as an argument? You could also just default to DEBUG in a no-arg version of the function. That way it can be more generically reusable (hopefully).
This error needs to be more descriptive. What's missing, what's expected, etc.
This function should have some documentation. Also, canDelete or checkDelete is probably a better name.
Just to verify that I got this right:
In the nginx config we would have hardcoded `expires` statements that tell the browser to cache indefinitely. (2)
This works because when a file changes, it filename will have changed (assuming it's all hashed) and the querystring to the /api/ui/staticBatch will thus have changed.

I *think* there might be a small optimization we can do in (1) when running in production. We could let the app servers send the appropriate cache headers which would cause nginx to cache the static files as well. (Assuming that nginx respects the change in querystring). That's probably unneeded for now.
```
______________               _________                 ___________
| App Server |   ---(1)--->  | Nginx |    ---(2)--->   | Browser |
‾‾‾‾‾‾‾‾‾‾‾‾‾‾               ‾‾‾‾‾‾‾‾‾                 ‾‾‾‾‾‾‾‾‾‾‾
```
Well, is it? Or just needs to be? :)
This comment doesn't totally match the method.
Putting the empty params in the query string somehow caused the Venmo app to tokenize a recipient/amount in a strange way. We switched it so the param only appends to the query string if it's not empty
just a micro optimisation -- it only gets evaluated once. but you're right, looks a bit stupid.
Rotate session_id

```
		if (($_SESSION['last_activity'] + $config['sess_time_to_update']) <= $now)
		{
			$this->sess_regenerate(FALSE); // don't destroy
		}
```
Наверное мы неправильно друг друга поняли.
Я имела  в виду что вместо вашего кода можно было написать:
if (mutationPercent<0 || mutationPercent>100) {
return или вывод ошибок
}
дальше основная логика. 

Таким образом получается что основная логика не вложена в дополнительные скобки, которые затрудняют чтение
Тогда ваш метод теряет масштабируемость, если вдруг понадобиться писать такой же метод , но для 200 элементов? Понятно, что в контексте данной задачи, ваше решение подходит, я баллы за это не снимал.
Но замечу, что ошибки не будет, в отличии от "сишного" `#include`. Дело в том, что `#import` сначала проверяет, не импортировался ли этот файл ранее, и не будет лишний раз его импортировать.
Материал первой лекции, вроде бы.
Действительно, есть "заглушка" на максимальное число.
ага )) вот Вы какой, я ВАС понял.
Однако, 
в условии задачи сказано следующее,  "Нужно заменить строго Х процентов, то есть заменять одну ячейку можно максимум один раз."

Обратите внимание, ни слова ни сказано про то какие новые значения должен принимать массив
По условию не требуется отслеживать конкретное значение в массиве при его "мутации"
Требуется отслеживать только количество изменений по конкретному индексу массива, в моем случае это реализовано через NSIndexSet он хранит уникальные индексы, каждый в единственном числе, колличество индексов в наборе котроллируется и всегда ровно X
Вот и все
```
return unless clean_marker
```

или даже

```
clean_marker = self.class.extract_marker(marker) or return
```

Но тут меня пусть Саша поправит - я могу с приоритетами напутать )
Yeah but spasming is not a word.
I think a method like that on `<RACSubscribable>` is a great idea. The API will be a little weird, but we can just make it clear that `combineLatest:`/`zip:` are usually what one wants.
Unless I'm much mistaken `attachEvents` also adds the downstate handlers among other things. This would prevent all that based on the hover setting.
add a line below with the short description.

The colors used to plot each evoked dataset.
I agree but if you don't scale with len(vertidx) the PCA time series appear
much bigger.
I think that explains the issue with connectivity. I've to play a bit more
with it.
I don't see the point of doing this. Since it's built-in, managed by the `Global` object, and using a special syntax, there is no need to check the configuration.
Can you add specs that verify how you're storing it? (As a config var)
I think I understood it after I translated it to something more readable.

```sh
( is-false "$_screen_is_on_remote" || is-true "$_screen_auto_start_on_remote" ) && ( is-false "$_screen_is_started" && is-true "$_screen_auto_start")
```
Yeah, it just shows the prototype (below) - I could just copy and paste the above for now and do a PR for Symfony with a `setExample` that shows all the factories
.
。
maybe clean up closing bracket
Cleaned up.  I was a little confused about whether to do self ! Kill or self ! Failed(cause), but the results appeared the same, so I went with Kill.
The Actor Endpoint ( part of the  Camel Actor Component 'plugin') right now only supports receiving messages from Camel. The createProducer (not to be confused with producer actor) is used to send messages into the endpoint. The ActorComponent is only there to send to actors registered through an actor endpoint URI. So you can use an actor as an endpoint to send to in a camel route. so from(someuri) to (actoruri), but not 'the other way around'.

supporting createConsumer would mean that you could consume messages from an Actor endpoint in a route, which I think doesn't make sense, because an actor does not (necessarily) send out messages (and it is not fixed to where). It can always receive messages of course.

Producer Actors can be used for sending stuff to some other uri/ component type registered in Camel, so yes that is covered in a sense.
To clarify: Do you prefer a shorter sentence, or a detailed paragraph?
Or both?
ну, у меня работает..
`const auto&` ж тут полущ в обоих случаях.
Instead of "deployed; then load" I would go with "deployed. Then, load"
i removed all the loops he was doing - we don't need those - i guess he was doing that because he has a checkbox in each view that he wanted to also check/uncheck automatically.  since we don't, we can avoid parsing the view tree hierarchy.
Sentence must start with upper case
Please format the display by <p>, <br/> and </p>.
No wonder my GET call was going to the create method!
Even with something this simple lets avoid one letter variable names. At the very least it's a pylint violation.
I disagree! I think the complexity and lightweight solution we would possibly get does not warrant the complexity incurred. Galder already implemented a method for stop and destroying cache:
cache.getCacheManager().removeCache(cacheName);
@GromNaN  I added a new commit.
Can you please use [TomDoc format](http://tomdoc.org) for this documentation?

In particular:

 * Use complete paragraphs/sentences, punctuation and capitalization included.
 * Document _all_ parameters.
 * Align all parameter descriptions (as can be seen in the TomDoc examples).
 * Treat "Returns" as a section and try to combine the two above sentences.
Yes I think this makes it much more readable and straight to the point. At this stage we only have the requirement for one type of sorting so we should avoid making an overly complex solution to a very simple problem :)
"A histogram" and "built".
Link is required here for keyboard navigation.
Ok thanks, I know that these are trivial but I just wanted to be sure they would be included in the PSR in the end.
Ok, just thought I'd check for a Ritchie-ism. I'll figure out what feels right to me and send another pull request.


On Aug 14, 2012, at 9:47 PM, Sam Ritchie <notifications@github.com> wrote:

> In src/clj/forma/hadoop/jobs/forma.clj:
> 
> >    [{:keys [est-start est-end t-res]}
> > -   start-period val-ts]
> > -  (let [[start-idx end-idx] (date/relative-period t-res start-period
> Not really sure! I've been away from the code for a while...
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Thanks for the tip. I'd like to get this into muscle memory, so I'll modify the pull request accordingly.
could you please extend the CMath::normone function with the dnrm2 stuff and use it here? for this please put the function in the .cpp file  - thanks.