labofsahil/github-event-dataset-2012 huggingface dataset:
On Thu, Aug 2, 2012 at 5:49 PM, Łukasz Langa
<reply@reply.github.com>
wrote:
>> @@ -467,8 +469,14 @@ def get_context_data(self, **kwargs):
>>                  h.span = (h.end - h.start).days
>>              elif h.start:
>>                  h.span = (datetime.date.today() - h.start).days
>> +        try:
>> +            page = max(1, int(self.request.GET.get('page', 1)))
>
> Why use `max(1, ...` here if not on line 507?

Because on line 507 it can have other values, because show_all is enabled there.

-- 
Radomir Dopieralski, http://sheep.art.pl
Don't monkey-patch globals, you will break external libraries.
redirect us
Try to find another mechanism to verify Job Entity. Does this method has test anyway ? Also suppose we want to search Job by other criteria ! What you are gonna do ? add another if ?
I think we still need to call this (or a modified version) method, otherwise the sequence is not correctly updated for Postgresql.
We should change the tested permissions to be something else than `0o666` now that's the default one.
Yeah, the size bump is a big consideration here. It's great to get all the bits and pieces isolated into deprecated.js, but I don't think we want to pay some hundred-byte penalty just so a very few people can exclude deprecated.js in a custom build. Once we move on to 1.9/2.0 this will all be moved out to a plugin where it won't matter anyway, so I'm not worried about isolating all the deprecated stuff here, just the stuff that's convenient and doesn't add a lot of bytes.
This is causing errors all over the place when the 'maxparams' option is enabled.

```
[jshint]
 Cannot read property 'length' of undefined
 Cannot read property 'length' of undefined
 Cannot read property 'length' of undefined
 Cannot read property 'length' of undefined
 Cannot read property 'length' of undefined
```

This is so because the parameter passed to this function (`funct['(params)']`), which has the value returned by `functionparams()` assigned, can be undefined. `functionparams()` returns undefined in some cases.

Please fix this asap. Currently this feature can't be used. When enabled node-jshint returns full of warnings from incorrect line numbers.
```
$ jshint .
modules/....js: line 61, col 46, Cannot read property 'length' of undefined
modules/....js: line 449, col 50, Cannot read property 'length' of undefined
modules/....js: line 141, col 64, Cannot read property 'length' of undefined
modules/....js: line 43, col 54, Cannot read property 'length' of undefined 
```
(@ commiter) Please ignore bib file during merge since the changes are only present due to use of BibDesk.
Well, yeah, mkdir_p fails here on Windows.
Ditto on scoped_ptr, here.
A new layer, implemented as an actor, "core", __has__ been …
We're nixing the idea thing. The options are just happy and sad.
Build number does not match clang!
The number would match `:llvm` (which means llvm-gcc in homebrew).

But please note, I can install this with clang and with llvm without problems, so perhaps this is no longer needed (on 10.8.2)?
Can replace with simply:

    (HOMEBREW_REPOSITORY+'Library/Hold').mkpath
This is a remnant of an alternative approach I looked at.  Please ignore.
We shouldn't need to write say on empty lines - this is what paragraph was intended to do.
If this returns an array, you should use "domains".  If this should return a single item (i don't know why it wouldn't since domains are unique) then this is ok.  I think refactoring find_domain on the rest_client to not return an array is the right long term decision, especially if the number of places we access it is still limited.  If no domain exists find_domain should throw a DomainNotFoundException
https://twitter.com/#!/carlosble is the one to be blamed for that. I was pairing with him last night to track this down!
Cette fonction n'est pas fonctionnel en effet mais le "contour" est bon. Il faut donc remettre son code. Si on supprimait juste comme àça mon code sans explication valable, je serait pas très content :-p
fwiw I would lean toward option 1 (require Java users to specify the extra param) as well. The other solutions don't seem like they pull their weight, they add a bunch of methods and some cognitive overhead for a pretty small gain in convenience.
I don't like it particularly, but I like the multiline version even less:
```python
if result:
    d = succeed(riak_object)
else:
    d = riak_object.reload()
```
Had not been observed at all at time of DEC2704, so this diff is consistent with the database implementation.
To avoid confusing the user, this call should accept either i) a directory relative to the USER'S CURRENT DIRECTORY (not the directory of this file) or ii) an absolute file path
I don't think we need to add "since" tags to non-public classes
I may simply move the desc of variants to or wiki.
Then we may leave the first sentence unchanged here.

ok?
Again, can you put the comment on its own line?
I would estimate minimal. It gives the ability to override how the attributes are stored, which we know we'll end up needing for drafts. I should change this from building the string to instead use `getPath`.
From function this name, I totally didn't get that calling this actually performs the document edit as well.  A more action-oriented name would be better.
Is this change still necessary? It doesn't seem correct. ``CodeHintList`` explicitly adds ``$hintMenu`` to the DOM in ``open()`` line 266 and also explicitly removes from the DOM in ``close()`` on line 293. It seems like we would explicitly use ``false`` for the ``autoAddRemove`` param here.
Ahhhh, duh, fixed. Thanks Jason.
_removePopUp is a private function that's only called in 2 places. Seems unnecessary to have the 3rd parameter optional. Why not specify it here, then remove the logic that sets the default value?
I am not sure that limiting the number of items in the list is a good idea. A common usage for code hinting is for reminding you of things that you can't remember, so the thing you want very likely is not in the top 8 (or so). Sometimes you want to see the whole list.
Uh wtf is this. `type: "C9 SERVER EXCEPTION"` ???
in apf in databinding.js line 851 there is:
var newNode = apf.mergeXml(xmlNode, insertPoint, options);
if the mergeXml would add only unique nodes i think then the problem would be solved
Sine it's updated everywhere - then, it's cleaner to get it removed
`preserve_paths` is not the same as `clean_paths`, it should only contain those things which would get cleaned automatically but are still needed. In this case it’s probably not needed at all.
Huh--Just checked the methods() call. In 1.8 it returns strings, but in 1.9 it returns symbols. I think it's cleaner to convert them all to strings up front. Would you mind making that change? If not I'm okay merging this as-is since it accomplishes the task for both major ruby versions.

Thanks again,

David
NM, the limit=0 looks like a "touch and go" non blocking way to hit a view.
I would do a `!TextUtils.isEmpty(account.authToken)` here instead just to be on the safe side.
This looks like a mixed foreach/fori... strange one...
Of course the idea is not always to hide the fact that there are missing values. But to behave in a smart way. If the value is missing and it is required, then there should be some error (just not unhandled exception which throws 500).
If I put 'home' there it would always append it at the end as such: http://site/register/home
This seems like it will get expensive very quickly -- especially here for releases where there are hundreds of changes to some of them in a day. Is it possible to load more entries on demand rather than all of them at once?
Will this fail to send an error state back up? I think calls to `findAllProjects` expect 2 args back -- error first -- right?
annnnnd ignore me, because i prefer that too. I misread the diff and thought it was in reverse. CARRY ON.
switching to isNaN() here
Just to help future-proof functions like these, can you pass in the config instead of `butter`?
Is there a reason these aren't just declared like `function onTrackEventMouseUp()`?
Hahahahah oops.
Make sure you add this change to `tools/build.js` too so deploy doesn't break.
same for formatting as above
Initialize this to false when the PDFView is created.
Nice, I didn't know you could do this!
I've changed it as suggested
"""Files are laid out as just files.""" - That sentence is entirely redundant. It is like: The black cat is colored black.
I'm afraid I don't know what you're after with the whitespace, I tried to stick to the style used, but it's a new one on me. The semicolons are gone though.
Thank you for explaining. I'm not sure how to resolve this. I think the updatePrerequisitesCheck() function could return a vector with DNSRecords that we need to check. THen in the processUpdate() method, after we're procesed the Answer items, do this check.

I think that flow is a bit weird, but i don't have any other idea on how to solve this. Feedback please!
```ruby
self._certificate_and_key(id).try :[], 'cert'
```
will do the same trick ;)
It's used, see:

https://github.com/iNecas/katello/commit/2fab33bd1dfe940e063e339b2758b3e3ccbe9b28#L13R100

and

https://github.com/iNecas/katello/commit/2fab33bd1dfe940e063e339b2758b3e3ccbe9b28#L12R13
May not be the greatest idea to do for in loops here. KT.utils.each(<list>, function(attrib){ <do your thing> }); 
Not a deal breaker..
I agree but since this is preliminary version and bigger refactoring is expected, I tried to put everything in the one place. Once we integrate with Pulp v2, we will remove most of the stuff from here because Pulp will support much more from disconnected. Thus, I have decided only for one file.
Pushed below.
Unfortunately it is not possible as the included module injects its methods into the Classmethods resp InstanceMethods submodules and we have to define them first. I'm not happy at all with this pattern but that is how the rest of the orchestration is done
I think it should be ```factory :unit do``` (units should be singular and the ```:class => Unit``` statements are unnecessary when the class is in the name).
Could you actually place a sleep in here? For example if you have only 1 wreck spawning (when you have more than only 1 crash site type). Because if you do that in the server_functions or server_monitor files your server is likely to freeze (crash)...

But still I wanted to make those crashsites spawn over time! Like if you have a restart cycle of 6 hours the crashsites should be spawning from 1 hour after the restart to 1 hour before the restart...

_randomTime = floor(random 14401) + 3600;
sleep _randomTime;
// now spawn heli

Is that possible somehow?
Here and in the subtraction one, perhaps you should say ``Whether to propagate errors following the propagation rules defined by `error` `` or something like that.  Just reading this blindly, I think "how does it know *how* to propagate errors?"
Original claim sim would print results after completing the transfers but before the next rebalance cycle. This version does not. Are we losing any interesting information?
I threw a rem 20 in here. at one test every three seconds, you'll end up with 1 log per minute. I'd call that fair.
Again, lean on Rails here. http://api.rubyonrails.org/classes/ActionView/Helpers/TextHelper.html#method-i-pluralize
Why are you always trying to introduce new and weird coding conventions?
``static inline std::string BlockSubstr(const uint256& hash)`` would do the job, no?
what happens if it is not found? Do you get a warning?
@Ocramius even so there are no collisions. the path will be different.

I added another test, please take a look..

````
key:6 -> /495d80004e0d8b98/00de3d8352b57684/cc9c356c2bed619b/935e794b562513ed/key6
key\6 -> /27689c7696334f66/723368a8c165717d/5f4bac1e59614291/0290d9477df585df/key6
key/6 -> /966c4c8ee8f76a35/3d6d11836fc89705/ccb9ca43dd9688fd/6be83d9d348c884e/key6
key"6 -> /0e69680bd4076662/6853cbad327d0545/7bf2f621876764e6/9361a8ca65dd2d8b/key6
key*6 -> /da68d27386a73d97/c8839c300f66b0dd/3fdb7e03e13ce6cc/d1a4c2c75344aaa6/key6

...

````


Anyway, I don't see any problem with prepend the hash..
i see sometimes for a simple string is '' and other times as above in other files is ""

perhaps we want to follow a determined pattern?
Can you switch this to UTF8?
Are you referring to the `iptest` vs. `iptest3` difference or the `iptest` vs. `{envbindir}/iptest` difference?
I think you are right, but I am going to have to remove the dependency on
bash anyway, to make it work on windows.

cheers,

Flávio

On Sat, Jun 9, 2012 at 10:35 AM, Thomas Kluyver <
reply@reply.github.com
> wrote:

> > +    =====
> > +    To activate this magic just write at the top of the cell:
> > +
> > +        %%virtualenv my_env
> > +        import sys
> > +        print sys.version
> > +
> > +
> > +    """
> > +    if not os.path.exists(os.environ['WORKON_HOME'] + '/' + line):
> > +        print >> sys.stderr, "Environment {} does not
> exist.".format(line)
> > +        return
> > +    env_activate_cmd = 'bash -c "source {}/{}/bin/activate && python
> -"'\
> > +    .format(os.environ['WORKON_HOME'], line)
> > +    cmd = shlex.split(env_activate_cmd)
> > +    p = Popen(cmd, stdout=PIPE, stderr=PIPE, stdin=PIPE)
>
> You're effectively recreating `shell=True` by using `bash -c`. But the
> vulnerability the docs mention is about untrusted input injecting shell
> code - which we don't need to worry about, because the notebook exists to
> let the user run arbitrary code.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1891/files#r955665
>



-- 
Flávio Codeço Coelho
================
+55(21) 3799-5567
Professor
Escola de Matemática Aplicada
Fundação Getúlio Vargas
Rio de Janeiro - RJ
Brasil
I don't think it's particularly important.  It seems a little bit funky to be using another program's private storage dir, so I might lean slightly towards putting it in the profile dir.  We could just ping cython-users, and see what they officially recommend for this kind of behavior.

I don't think the idea that this might some day end up in Cython itself should be relevant to where it caches while it resides in IPython, given that it is such an inconsequential thing to change.

I've also always been a bit more partial to 'ipfoo' than 'ipy_foo' for denoting IPython things, so if it's in .cython, I would prefer 'ipmagic' to 'ipy_magic', but I don't feel strongly (or, I do but I know it's silly, so I will pretend that I don't).

pro profile-dir: IPython only writes data to its own dir
pro .cython: all your Cython caches (that I know of) are in ~/.cython, so trashing all Cython caches is a single `rm -rf`.
Since this is a public function, it should use a proper numpy-standard compliant docstring as [per our development guidelines](http://ipython.org/ipython-doc/dev/development/doc_guide.html#docstring-format).
In general we prefer not to have too much of these whitespace-only changes because they make the diffs longer to read, and we don't have a super-strict whitespace policy, so different contributors have their editors set differently.

In this case there's not that much to be a bother, as fortunately this PR only touches few files, so we'll let it pass.  But if you ever make a PR that touches a ton of file, please refrain from adding whitespace-only changes all over, as it will make review harder.
probably id should be nodepool.  also, setting defaultcredential is not necessary
Come on, buddy. ;/
Your C# is showing: a 49-character function name. :wink2:
Actually, considering that we are even having this discussion, I think it would be good to make it no longer an optional parameter, and remove the default value. Explicit is better than implicit. This would also make it easy to find all the places we need to consider, as they will all break the tests, in theory.
I would suggest changing the name of this variable to `elem` or similar.
``fetchall`` and not ``fetch_all`` (sorry that one is my fault, I didn't verify before sending my previous message).
Right. As discussed elsewhere, the cron apps themselves are dumb. They rely on their daddy for configuration values. E.g. database_host. I didn't know about the bugzilla app needing a configurable URL. 

I don't know how else to solve the problem with the dependency and next-/last-run state AND have fully configurable apps. Perhaps we need to bite the bullet and go back into the rabbit hole of configman InnerClassList stuff. Ready to listen to your general advice again.
`GroupUser.objects.create(group=group, user=profile)` should be enough and ignore the next three lines.
Is there anything that needs to go into base.bat too?
I guess we can leave it for now. It's just that exceptions bring the whole server down. But we need to decide on an approach for this and then apply it consistently everywhere.
```/users/suspend/``` can simply redirect back to ```/users/``` while ```/users/reset/``` needs to add another item to the dict that is passed to render_template. I'm not sure how this could be separated without duplicating code
including the start date is not too useful, logger.log() will snapshot 'now' (as will logcat).
This is wrong. You can have several firewalls using the same method
does not match the name of the class
So: 

- it would be great to link the spec in the comment
- it would not do more than what is strictly required - btw "left unencoded" is "encoded then decoded" to be exact.
``` php
<?php
$store = new Store($cacheDir ?: $kernel->getCacheDir().'/http_cache');
```
 Seems readable enough :)
you could also use base64_encode() here instead of the raw base64 encoded username/password, the same remark applies to the next two test methods below
`computeDeprecationCount` for the private method?
Maybe use the more specific `\UnexpectedValueException` and add to phpdoc.
(lldb) po [utc class]
(id) $1 = 0x0220f8bc __NSCFString
Please separate test phases with a newline

I like use of `expects`. We should use more since it's The Future.
To test backport to 0.10 had to change to in_filename.c_str(), same for line 444
How much overlap do this and NaturalEarthFeature have? Is it worth having a "ShapefileFeature"?
rogue print
I guess the docstring comes in in another PR right?
This can be replaced with (complement crosscram.game/can-move?).
But not sure for ParseException... Because BaseException will not catching in `*Worker.handle`.
common practice for this sort of thing would be "make([]*skynet.ServiceInfo, 0, len(instances))", which would pre-allocate the right number of entries in the slice while keeping the semantics of a zero-len slice. not a big deal.
The file is "dnsmasq" but the class is "DHCPManager". Is that right?
revert too
Just curious - Why are we writing out explicit newlines? I'll go ahead with test/merge of this PR since it looks like this is not new to the messaging subsystem writer and it already has been doing it before this commit.
never mind. I misunderstood the boolean value.  It is for modification purpose, it has nothing to do with service state. 

I'll pass false for read-attribute and true else.
Never mind; this is for 7.1!
I really don't see how this can actually work with :reload. a :relaod is basically the same as a container start, and this code is not re-run on reload. If this static stuff that is run once per JVM does not break with reloads then as far as I understand it either:

- The OSGI container does not honour the :reload op
- This construct is not actually necessary
- You have not tested a sufficiently complicated bundle deployment to break :reload

The activateInternal method adds stuf to a service container, on reload this ServiceContainer goes away. There is definitely a problem here.
Yes. I just changed it because now isRunning() returns true also if it's stopping (without entering in the possible cases).
@sgharms, @scottgonzalez meant you shouldn't have two spaces there.
Hahaha I wish there was a less-silly way to represent this.
just set a class on the div and set the styles in a stylesheet
I think we don't need to update date/time for lock screen.
It will be updated when it's locking.
If you need to use elements a lot  make it a local variable at the top of the function.
Maybe now I am more paranoid but it seems like a good idea to check if a wake lock exists and release it if it still exists at this point (to ensure we only have one?)
Is there any reason why this cannot be `BlobView.prototype.get`?
Nit: dead code
nit: this format has always been ugly:

return new CustomEvent('localsettingschanged', {
  ... 
});
This was a previous request by @etiennesegonzac if I am now wrong to ease the visualization of the selector instead on including it directly inside querySelectorAll. Wasn't it?
var entry = entryPoints[i]; and use it :)
which properties are you animating?
Do we still need to do this with shared js?
Hu? Is there any bluetooth stuff in the FTU?
if ('photo' in contact and contact.photo != '') 

Otherwise it fires an warning in strict mode.
`framesFromOrigin` I meant. It's longer than `frames[origin]`!
Should this be postError instead of postResult?
out.indexOf(.....
Do we need it? If we are going to remove 'ts_'  prefix we could remove it.
I have removed the condition. No point in having it there.
Here we display the app on `X` click and valid pin, but we can also prevent app launch on `X` click if you think that's better.
nit: I believe the prefix 'g' is not necessary here, 'g' means global variable, I guess. (I'm always doubting only @fabi1cazenave knows what the 'g' stands for. :-p)
from modifyLinks put `var parameters = ('sample_rate=' + SAMPLE_RATE + '&snippet_id=' + show_snippet_id);` here and send it as a second parameter called `parameters` into the `modifyLinks()` function. 

That way, the `modifyLinks()` function does just that.
Also yay docs!
This should be seqnos and not [seqnos], since seqnos is already an array.
Try to avoid instanceof please, use double dispatch pattern or similar!
Having requiresEditableRepository be false by default is dangerous. e.g. I was trying to run TestTurningAutomaticVersionSelectionOffWithIisnodeYmlWithNodeProcessCommandLine, which does modify the repo, and ends up hacking repeatedly on the cached copy. There could be lots of other tests that are busted in similar ways.
We don't use boolean, bool or var.
For the new generator site builder, when running the deployment script these settings are always set as env variables, for the original we do that only for custom scripts.

Also note that I set those env variables before any of our own defaults (like SourcePath, MSBuildPath, ...) this is on purpose to not change current behavior, unless you think we should change the order here?
again, copied from puppet broker, not even sure what it does :P
I think I've mentioned this to @solnic before, but if we're always specifying the type I wonder if it should become a position argument like it is in other related systems.
Shouldn't we just take this line out entirely?
these should be (in my opinion) OrderedDicts .... so that they can be effectively hashed for simple ID generating purposes ...
Who searches emails in an archive really?
wtf are you doing
The archive software is either 'foolzfukuka' or 'fuuka', not 'fuuka' or 'gentoo'.
shouldn't we test whether `pushd` also successfully changed `pwd`?
* On 2012-08-07 19:22:32 -0700, Yiqiao Pu (notifications@github.com) wrote:
> > +    @param params: Dictionary with the test parameters
> > +    @param env: Dictionary with test environmen.
> > +    """
> > +    vm = env.get_vm(params["main_vm"])
> > +    vm.verify_alive()
> > +
> > +    session = vm.wait_for_login(timeout=int(params.get("login_timeout", 360)))
> > +
> > +    # Try to install 'qemu-guest-agent' package.
> > +    gagent_install_cmd = params.get("gagent_install_cmd")
> > +    s = session.cmd_status(gagent_install_cmd)
> > +    session.close()
> > +    if s != 0:
> > +        raise error.TestError("Could not install qemu-guest-agent package")
> > +
> > +    gagent_name = "org.qemu.guest_agent.0"
> 
> Is this one should be the virtio serial port name which can be got from vm.virtio_ports?
It could be get from vm.virtio_ports, but this guest agent name is a
fixed value which would not change in every case, so I prefer to write
it down directly.
Unless the order is extremely expensive computation-wise or I/O-wise, I suggest removing the TODO comment: other functions will probably use this feature in later releases.
I think this API is only available on recent version of twisted.
Did you verify you code against older version of twisted?
@tomprince @djmitche https://gist.github.com/2078378 shows two alternate implementations: an incremental list without .split(), and a list of tuples. Please choose one, or propose another.
Two tests gets all of trial's assurances of a clean reactor in between.  I can refactor it so the two tests call a single `do_..` method.
`for prop in properties when prop of this`
May be can use 
 
    CC_SAFE_RELEASE(this->mRootNode);
As you added this `use`, it would be cleaner to add also: `use Composer\Installer\LibraryInstaller`
from my experience the `is_mobile_device?` helper is not very useful anymore, because we do some manual processing before each request (in case someone manually switched mobile/desktop view). better you do something like this:

```ruby
if request.format == :mobile
  'application'
else
  'blank'
end
```
(ruby automatically returns the last statement from a block, so no need for manually using `return`)
D1? C&P error?
I'd log the confirmation at the end of the registration process.
@randx can confirm this magic behavior
can you change this to "from HTTP request from %s", where %s is the IP issuing the request?
I'd instead store this `clean_filename(infile_root)` so it can be safely reused everywhere.  Otherwise, somebody will forget to call the cleanup function somehwere...
long as opposed to int, why because we do stupid things that's why.
Cool!  I didn't know I could do that.  Tried it and it's perfect.
> I don't understand your comment sorry. I do whatever we were doing before just use copy of @packaging instead of original.

I understand now! Hmm I wonder why does it works then ? I guess `runTests` take same `@packaging`.
I'm not sure what you're saying here, internals(this).contentWorker is undefined I think.
as it turns out, <tt>verifyChain</tt> was already there and not used, I noticed the same thing. I chose not to take it out yet. Agree that cleaning up dead code is something we should do. Do we have an easy way to detect dead code?
Yes, I think this is a better name.
I don't think `load_test_data` should have responsibility for going back to the objectstore to mark the rows completed - it shouldn't need to care where the data its loading came from. I think the call to mark them completed should instead be done directly from the higher level method that you extract out of the management command (as I suggested above), once the call to `load_test_data` returns successfully.
As above, why not have click_manage_api_keys return a KeyPage object?
First, it's not link to safe mode, as I said, the errors are raised since you have `STRICT_ALL_TABLES`, so you can have this options without safe mode and so you can have the errors without safe mode.

Second, this test, tests saving "" value and after, setting it to null, and testing isModified method. You can't do what you are saying.
This doesn't describe the current function.
It is explained in the commit message
ok. this code is no longer used
Yes, that appears to be the case :-(

(http://stackoverflow.com/questions/9048305/checking-objective-c-block-type)

So void return type (see latest pull request update) and assuming that people exhaustively test their code at runtime to catch mis-matches is the best tradeoff? or you like _.eachArray and _.eachDict? (I prefer compliance with underscore)
wtf? not good :P
I'm not sure what is meant by 'plugin library overhead'. Code is code... you add code here or you bring it in from somewhere else, it has the same weight.
It was a few months ago since I made most of these changes - but I believe it for mainly for accessibility. Currently when hitting [esc] it doesn't focus back to the element (I think it was for that).
evil you -- ruining our perfect column alignment? ;)
processException() is already inside the abstract sql. There's really nothing more that needs to be factored out.
please indent with 4 spaces this class.
This should be fixed in PR #1527
Space missing after "if".
`è tempo` -> `è possibile`
Add @return tags to all functions that need them please. See the above functions
Requires `@author` and `@since`.
I think we could rename this file to different structure i.e.: `api/developers.feature`
just `informations`
yes... i am currently investigating and implementing different routing mechanisms to be used with meteor, flatrion director is one of them... so stay tuned...
that's not pdf ;)
So we should change all of them. =)
This cannot rely on the constructor to be set, because it will be used before the constructor is called.
Not sure, but shouldn't this be put in the test module?
move the tuple to a new line?
Any environment variable that starts with EASYBUILD is passed to the job
Missing typehint.
Done. I changed my mind, the code is cleaner this way.
I would remove "as such", it's a somewhat odd expression ;-)
Yeah, that was more me testing things. I was having trouble with it either trying to execute 'app' ($name) or just the first part of the command.
Yes for setting, no for https. www.mozilla.org is not very https ready.
If it's a list of objects, would you recommend changing them to a values list and then checking against that? I may be confused, but assertContains checks one string against another, right?
yeah, you can just remove stop(), the plus() calls and the plus() function itself
That's going to make it really hard to localize if/when we do that.

An option would be to do something like this

```html
<span class="optional-tag" style="display:none">{{ _('Optional') }}</span>
<script>
$(function() {
});
</script>
I wanted to bring this up in commiters. I'd rather handle it with a separate batch job, but i know there has been some hesitation to use Drupal's cron in Islandora.
Use a comment  not enters to separate the sections
Test with text with quotes and double quotes, probablu you need add to adslashes function
Also, I'm not fully sure what the expected behaviour is with DST transitions, but since this is not really defined by the spec we can keep it as-is :)
Here, the implementation is wrong because you override the table engine. You need to check if the table has no engine.

````php
if ($table->hasOption('engine')) {
    $table->setOption('engine', 'InnoDB');
}
```
Typo : Cached :arrow_right: Cache
The parenthesis looks weird here. One space after the first parenthesis but no space after it ;-)
And I'm silly, the line in question (that you commented on) is an info.  So my comment above accurately shows the logging.

Think that is excessive?
Please keep braces on the same line as the function declaration/if statement/for statement/etc.  Having a consistent style helps keep the code easier to read.
Here you're using :node instead of :name.  So maybe switching back to :node under the facts endpoint would make sense?
what if they're not using a dialogue?
The JSDocs in general really need to be a bit more descriptive. It's pointless to have them if it just repeats the name of the function.

I'm not sure what this function does and how it differs from readConfigForModule.
No it looks like I don't need to do both.
Sure, that's not what I meant though. I understand it's copy/pasted, but I would say this is not code I would encourage. I would change it to 

```scala
val added = result.add(tpe)
if(added) ...
```
I changed it to `foldLeft`
What about a test when the test class is `private`? :)
Yes, if it makes sense.
I really didn't know about ``IAnnotationModelExtension2``, so nice! thanks so much for this tip! 

Further, I see no reason why the implementation of ``getAnnotationsAtOffset`` should be eager (i.e., returning ``List``), it is much better to use an ``Iterator`` all the way down ;)
Yeah, I'm not sure the padding is actually working right -- something needs fixing though.
Sorry :S I'll fix the class name :)
It is especially important to keep Makefile's free of trailing space.
@derekjones To be fair, some classes were already using this method, and I just wanted to be consistent. Looking through and making these changes, I also found class variables not used by their classes.
Стоп, всё правильно у вас с количеством, но эта конструкция явно сбивает с толку.
Правда ваша, при разных длинах массива код не будет работать. Хотя я об этом не думал, так как в условиях задачи ничего не сказано об этом. Несовсем понятны модификаторы (assign, readwrite).
А что будет если в Set попробовать добавить повторный элемент? Не отвалися эксепшн?
Да хоть float. 
while срабатывает, когда от операции count-- остается что-то != 0, если там 0, то цикл не запустится, и соответственно с нулем операции "--" не произойдет. 
0 это nil или булевое NO в понятии obj C
метод int может принимать и отрицательные значения. на мой взгляд разумно бы проверять и то что percentage >= 0
sorry for the typo

html_DATA it should be
Ah. Right! :-)
`App.footer.$el.toggle(this.lodoList.length);`
1 liner, spacing and strict equal.

```js
if (wait === 0) return;
```
I can confirm that it works with his patch and that it's NOT working without. Scrolling up (or down) diagonally makes jQuery mobile believe that there was as slide.

That's because, when you scroll up, the origin of the coordinate system scrolls up too so there is actually no vertical movement going on...

Therefore you have to add the scrollTop() difference to the vertical movement. scrollTop() not being part of the same coordinate system as the data.pageY.
My thought here was this:  If the shake argument matches a Shake Name even if its numeric, it should be converted to that shake.   If it cannot be resolved as a known name, then assume its a shake id and proceed.  The error handling of handling it as a shake id will cover the case where its an unknown name AND unknown shake id
Should we simply remove the wma alias?
Is fine with me. Just had this because it runs quicker, was working example
if you wish ;-)


On Sun, Nov 11, 2012 at 5:14 PM, Alexandre Gramfort <
notifications@github.com> wrote:

> In examples/preprocessing/export_ica_from_raw.py:
>
> > +# decompose sources for raw data
> > +ica.decompose_raw(raw, start=start, stop=stop, picks=picks)
> > +print ica
> > +
> > +###############################################################################
> > +# export ICA as raw for subsequent analyses in ICA space
> > +
> > +ica_raw = ica.export_sources(raw, start=start, stop=stop)
> > +
> > +print ica_raw.ch_names
> > +
> > +ica_lout = make_grid_layout(ica_raw.info)
> > +
> > +# uncomment the following two line to save sources and layut
> > +ica_raw.save('ica_raw.fif')
> > +ica_lout.save(os.path.join(os.environ['HOME'], '.mne/lout/ica.lout'))
>
> why not just add these lines to the existing raw ICA example and avoid
> creating a new example?
> this example as some duplication with the other example including the main
> docstring that is used
> to name an example on the web page.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/183/files#r2092807>.
>
>
with score_func = 'correlation' I think I can live with take_abs=True and select_mode='max'
option 2 is to not support abs and select_mode and let users do it in one line of numpy if we
return the scores too. If you prefer option 1 I can live with it if it really makes the examples
easier.
This used to be equivalent to +=, but I changed it to -= because that makes a lot more sense. In other words, doing raw.time_as_index(raw.index_as_time([whatever], True), True) should give you back `[whatever]`, and it wouldn't have before.
log the error or use test.isError
The caching implementation looks good, at a quick glance; I'll let Rafal review more closely.

However the underlying functionality (that each encounter type maps to only one visit type) is probably not sufficient in the long-term, so I'd like to avoid elevating this to being an official part of the public API. We'll eventually want functionality _like_ this in VisitService, but it needs more thought.

So, could you make one more tweak and move this out of VisitService/VisitServiceImpl, and back to the visit assignment handler?
this shouldn't go in crud because it only applies to `admin/pages_controller`
Might be worth giving some context to translators.
I like explicitly stating what we're looking for in the scenario... this way the scenarios and the expectations in the code are aligned. However, your example is very clean and easy to read. Will think about this some more.

```ruby
Visitor signs up
  with valid data
  tries with an invalid email
  tries with a blank password
```
Не разрывай список аргументов шаблона, лучше `const DriveItem&` на следующую строчку перенеси.
Согласен. Третейский судья тут не помешает
如果是一列的  檔名可以命名: `_row-post`
如果是一個小區塊的 檔名可以命名: `_cell-post`
well, could be just one file that's not deleting for some reason but we should still respect the user's desire to delete cache by deleting (or trying to delete) everything else
If you're insisting on xmldoc, make it useful xmldoc. Else, leave it out.
Hah! I forgot about that. I must have been playing with the default option for Hash#fetch.
s/was/were/
You're right, it really does!
push and uninstall were out of order, so i fixed it ;)
oops :) sorry
Collections.sort() only works on List (since it needs to move things around something which a Set cannot do).
yeah .. not quite sure about this feature .. maybe it should optionally also support some config for this?
Yep. This is good. Thanks.
I'm not sure whether this is good or not. How realistic is it to ask a first-time/infrequent contributor to run the tests over all python versions? Is such a statement going to put people off from contributing all together? Perhaps we could just encourage the use of TravisCI to do the version testing on behalf of the user to keep their lives as simple as possible.
Agreed.  I'll file a separate issue for that.
Idem que pour le message de permission, plutot que d'avoir ce bout de code identique défini a la fois dans la commande et dans le listener autant le definir une bonne fois pour toute dans une méthode que tu peux appelé a souhait.
Plus, ca sépare la logique de ce que fait le plugin (changer le gamemode) des specificité du parsing d'une commande ou du traitement d'un événement.
Goot tip, I will change that :-)
How about a short-struct function to go with these two?
The uniqueness/security aspect of the different encryption methods is something that is beyond me really. I have nothing against UUIDs.

The way I dealt with this the first time around was to set a unique constraint in the migration for token fields and do something like

Try to insert, catch ActiveRecord::RecordNotUnique and then try again if it's raised. That way you ensure uniqueness.
@bp323 I believe the idea here is to stop execution entirely to call out / make obvious that there's a critical issue.
I think that's correct. I made the change.
please use { } around the if here (because the following statement requires > 1 line)
Do you mean stuff in the examples folder?
will the uints here give us warnings from hell :D
This doesn't work as intended. `not parent = self` will always be false.
What? Why have you done this?
No. About 0.1 ms each for integers, 0.1 + x for strings (depends the number of characters) 1ms + x for arrays and doubling the memory. This is not noticeable in a forum with 5 users or 20 users but when it's about 500 users it is noticeable.
Is this the exercise part of art-connections? "multiple-choice" seems like it could apply to any multiple choice question
Our coding style is to put `{` unless the line is so long that putting `{` on the same line makes things hard to read.
Are you sure ``$scrollingStyle`` has the correct type as "object<Zend\View\Helper\type>|string" is not a sub-type of "string|null"?
It looks much much better with syntax hilight this way, -- but I'll change it since I guess it's more "correct".
We just need to add the placeholder variable in the retuned input stung in the getInput method.
yeah .. but its a bit annoying to then have to update it in two places ..
i could also just write ".." instead of a specific version ..
the standard location is ``Resources/meta/LICENSE``
That's correct, good spot. However, you've ommitted mentions of the action projects it does support at this moment.
I agree it would be nicer, I will patch qt-components.
I don't quite understand this.  Seems like neither case should trigger an alert?
Shouldn't this say ```pdb_filters```?

Even better, I'd rename this so you'd ```{% load pdb %}```.
I see that we have not defined localized names for panels. This is not good. This is bug.

OK, I see that we are everywhere using `get_name` as something machine-readable and constant. OK, leave `get_name` here, but we should define something like `verbose_name` or `display_name` then and use this everywhere where we show panel name to the user.
Ah, then say, if you think. ;-)

Hover? Hmm. OK, let's see. ;-)
Remove `#add_comment` part also from templates. So that button for test comment.
You should verify that `oauth_token` in GET matches request token stored in session.
But who creates them?
The `equalValues?` predicate is correct for the `wrap*` functions, since they don't do any type conversion.
@creisman  check here plese
"default subclass" is odd wording I think
This should change according to the bibstyle used.

If we remove the line, does it solve the problem?
Well I've took the example from here: http://symfony.com/doc/master/cookbook/templating/twig_extension.html
I think we need to validate options here instead of name!
TODO: Bug, but benin.   Add ".never" here.
Might as well do
```javascript
var template_func = request_response.is_response ? this._response : this._request;
```
Generally not a fan of negative margin as it doesn't always play nice with other styling, but if there's no other simple way of doing this, it's fine.
Done: 828a355
Not sure if this is the ideal fix for the issue, but a quick search seems to imply that others have been bitten by this: http://www.gamedev.net/topic/110180-isctypeh-in-vcnet/
Hm, is this why we want RDoc? I'm not sure if there's a way to include README.md in the RDoc output.
if we only want ppplot, then we shouldn't need ppf. check for ppf only where it is relevant
Oh no, I meant we could use streaming for non-yml files, but move the logic for streaming into `TwitterCldr::Resources`.  Just a thought, probably not necessary.
Don't display which fields are required in this way!
Yeah, you're right, but I'm not sure what to call it. I was thinking it's the root of the instance of a mulberry app. We need to decide the terminology for what a user created app is. I think 'project' is ok but I agree with Matt that it's easily confused with project_templates. Since this isn't something an end user will see, I'm not sure whether it matters though.
So the dashboard report is run on the draft course and the quiz report on the ready course.  why can't they be both run on the ready course.
Can't there be a convention?  

convention > configuration  > documentation.  but we at least need documentation.
I'll address this in a future pull request.
yes, there are several places in test case only,  i will remove that column
Fixed; no more try/finally needed.
Cut and paste coding ;)
Yikes, really bad code (catching all `Exception`s and ignoring, without even logging)! But same as groovy, so merging.
"... each webpage. And we call such a summary a tl;dr. Once it is written ...:" plutot.
Weird, huh? I didn't think so. But I was getting errors with the W3C HTML validator (which, admittedly, is an experimental feature) and added them. I like HTML4 Strict a lot, and HTML5 doesn't say not to do strict, so to me it reads easier and removes any doubt. Also I vaguely remember some crazy stuff was okay as a part of HTML5, like swapping between /> and > which to me is super no.

*shrugs*
Those two changes will break tests - please fix the tests too.
see comments on alchemist test
does PSR-2 really mandates to split every level as multiline ? It makes lines quite empty
Hum nevermind, I missed that we are already in the sub-case where the `$MAIL` == `mail`.
change the name of HTML. create_message is not according to our naming convention.
Again, why the whole file is in change? It should not be like this.
ident is differen than the rest for the following lines
I think you need to push the branch to your fork, and then submit a new
pull request, and delete your old pull request.  Is this correct, hans?
--
Kent Williams norman-k-williams@uiowa.edu






On 6/26/12 12:12 PM, "lwen"
<reply+p-1052885-2fb15493aa24705f008994f249645cb053eabf00-482621@reply.gith
ub.com> wrote:

>> @@ -155,7 +155,7 @@ int main( int argc, char * argv [] )
>>        resampleFilter->SetInput (referenceMesh);
>>        resampleFilter->SetReferenceMesh (deformedFixedMesh);
>>        resampleFilter->Update();
>> -
>> +std::cout<<"stop here!!!!"<<std::endl;
>
>I made the change. can you see the update?
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/BRAINSia/BRAINSStandAlone/pull/87/files#r1052885



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________
Fucking hell, I need to stop reviewing code from my phone.  The double opening parens merged into one on my screen, my appologies.  On that note, people should put some whitespace between parens so they don't merge together like that.
Usually we install the latest stable release and sometimes even a more
recent development version. I am fine with the version you propose for
now. We can also have a `--devel` switch to install the (unstable) dev
version and even `--head` to check out the latest from a version
control. So for most people something useful is among these options.
Then we have `brew --versions formula` to list the older versions.
User can checkout an older one. Thought this does not work for a new
formula of course.

For python vs. python3 we made an exception because its a complete new
branch and both major versions will be used in parallel (and are
somewhat incompatible to each other, such that python3 not always just
replaces puthon2).
As redenumi functia in <code>load()</code>
Is there a specific reason to delete this? It is/was used to prevent loops cause by coordinate computation approximation errors.
This should always return 1, correct?  Could we put a Q_ASSERT to make sure we catch if that ever doesn't happen?
In my mind, it was like this: This is an assassination talent. In assassination, you should use deadly poison. If we can found it without a full aura scan,  this is faster. This was just an idea, but yes, a full aura scan works. (and this code is from another part of skyfire core, for mutilate damage i guess)
I agree the .rb is a little weird.  The way I 've coded it, I don't think we have much of a choice because "require" in ruby wants a .rb file.  A quick test shows that 'require "foo"' and both 'require "foo.rb"' both result in ruby looking for foo.rb (but ignoring an existing file foo even if foo.rb does not exist).

Note that I followed the pattern that rails uses for loading a config .rb file, e.g.:

    require File.expand_path('../../config/boot',  __FILE__)

[well, almost followed... in the README we say to specify the full filename including .rb extension rather than omitting .rb as in the above line but either way works]

In defense of the .rb extension, it does imply you can put pretty much any ruby code in there which of course is true.  I.e., it is technically more than just a config file.
And the slug too? Though I notice none of the slugs are...