labofsahil/github-event-dataset-2012 huggingface dataset:
Fixes

Hiya.

I've made some fixes to this module, I'd be most grateful if you could review them and give me some feedback (or release a new version if you're happy with them).
CMD_PARAM_EXPORT was not recognized from config file and not saved

Hi,

I moved $bootstrap->getFormatter call below the code that reads values from the config file. Otherwise the specified export format from the config file was not recognized.

Also I found an unused variable $export when saving the export format, which was stored in the auto saved config file as NULL. I replaced it with $params[CMD_PARAM_EXPORT].

Now I'm able to store the export option and use it from the config file.

cheers!
Create attachments from data option + other minor changes

I have an app that's creating attachments from MongoDB/GridFS. I wanted to use your plugin for this but it doesn't work with this scenario as there's no path to a file -just data, so I added a "data" option.

I also removed some redundant and superfluous method calls and quote the filename in the Content-XXX headers. 

Also see:
https://github.com/sshaw/Mojolicious-Plugin-RenderFile/commit/ca441d66e9cdfe6a5754c8144ab6da9a951b9c7a#commitcomment-1495095

And: 
https://github.com/koorchik/Mojolicious-Plugin-RenderFile/commit/5acf954f3598d6bf56718667156771bbe14a0843#commitcomment-1495628
Added support for the German LoveFilm site

This update requires the latest Services.bundle to be pushed to the store, namely: 
https://github.com/plexinc-plugins/Services.bundle/commit/3054d1655b116d646a11a5b26e024d89d427fc4f
Added output method and config variable
update the Vagrant file for version 0.9.x of vagrant

Vagrant 0.9.0 introduces numerous backwards incompatibilities in the syntax of the Vagrantfile and available configuration options.  This updates the Vagrantfile to be 0.9.x compatible.

Thanks!
Nathen
誤植を1件見つけました
CUSTOM-10 Implement proposed concept fixes

Implement proposed concept fixes, related to AMRS-171.  Adds changes from TRUNK-3591, TRUNK-3592 and TRUNK-3593 to the AMRS Customization Module for overriding the Concept Proposal form and controller.
INTSAMPLES-65 - Basic File Sample (Text Copy) Has Incorrect Filter Attribute

Reference: https://jira.springsource.org/browse/INTSAMPLES-65

* Change *filename-pattern* attribute to *filename-regex*.
Jakefile

pull request for #148

I have removed rakefile and albacore. (Haven't yet removed build.cmd and clean.cmd).
Added jakefile.js and Build/njake.js.

**Getting started**
* install node.js
* `npm install -g jake` (linux/mac users need to run using `sudo`)

**List of currently available tasks**
`jake -T`

```
$ jake -T
Facebook C# SDK v6.0.10
jake default                   # Build all binaries, run tests and create nuget and symbolsource packages
jake build:net45               # Build .NET 4.5 binaries
jake build:net40               # Build .NET 4.0 binaries
jake build:net35               # Build .NET 3.5 binaries
jake build:winrt               # Build WinRT(Metro) binaries
jake build:wp71                # Build Windows Phone 7.1 binaries
jake build:sl5                 # Build Silverlight 5 binaries
jake test                      # Run tests
jake nuget:pack                # Create NuGet and SymbolSource pacakges
```

You can also execute default task using just `jake`.

I have also added mono build support, but current will not be listed when running `jake -T` nor will it build correctly due to the nuget package restore. (Since mono is not yet supported now I think it is fine to leave this.) It might be better to have Facebook-Mono.sln

*You will get build errors but here is how to build under mono*

**Build using Mono in Windows**

```
jake build:mono['C:\Program Files (x86)\Mono-2.10.8\bin\xbuild.bat']
```

**Build using Mono in Linux/Mac**

(Assumes xbulid is in environment path)
```
jake build:mono
```
Latest shared / merge from unstable
BUGFIX 

Only show the actions if on the "Content" tab, as AdvancedWorkflowExtension doesn't decorate CMSPageSettingsController. This is to prevent a "Not found" error message when pressing a workflow action button, when on the "Settings" panel of a page.
allow empty card issue date

* fixed bug where using an empty card issue date will raise an exception because _format_card_date() expects a string
First change set from Ruben

Here is the list of changes that I made:

- If home is not set, open options instead of envato homepage
- Don't show the 0 badge
- Display item names and price on notification
- Go to statement page instead of marketplace home

Thanks!
Ruben
hotfix....
New way test as suggested on rebuild mailing list

See http://lists.openstreetmap.org/pipermail/rebuild/2012-April/000221.html
Made Menu classes more extendible

I just needed to extend a private method to add special functions, so I made some private methods protected.

I hope your OK with this.
Styling for small screens
Store hash of files and offer to download changed files

This commit stores a (filename).hash file inside the .sparkleshare directory on the SD card and checks it against the hash returned by the SparkleShare-Dashboard server. This allows the app to detect updated files and offer them for re-download.
Pull test

Hi guys, just experimenting with Git...
Socialactivity
Upgrade to Bootstrap 2.0.2

Hi!

I had some issues with the paginator, so had to upgrade bootstrap to 2.0.2, because it better supports disabled links (via <span> instead of <a href>). I also added some styles to the fixtaglib stylesheet and changed the paginator taglib to use <span> for disabled links. Hope you like it.

Regards
Werner (LordOfTheRams)
Add more content for the DrupalCon draft.
Update Spanish and Catalonian translations
Add test cases for Arabic and Thai hashtags.

This adds unit tests for extracting and auto-linking Arabic and Thai hashtags.
Added support for VIM code folds.

Developers who use VIM will sometimes place code folding markers after the opening function curly brace like:

    function testing()
    {/*{{{*/
        return true;
    ...

If these markers are present, an error should not be raised. This pull request addresses that issue.
Исправления

Патч:

-  Убирает завершающие пробелы
-  Исправляет CSS
3 commits

If you accept my changes check this for history: https://github.com/lilianmoraru/Converting-Decimal-to-another-base/network
Pull Req - Fix for issue #12 [Native Packager exception occurs if the version attribute contains 4 digits]

Fixes Blackberry GHI #12 - Native Packager exception occurs if the version attribute contains 4 digits
Fixed issues with status not creating and statuses page not rendering

This fixes #3 (and probably #1). Once I had fixed that error, I actually encountered another where the /statuses/index page wouldn't render due to the latest redmine using `project.identifier` to identify the project URLs. This fixes that too (see the helper change).
Add support for Opera and Firefox

Add -o-min-device-pixel-ratio and min--moz-device-pixel-ratio to _retina.scss.
Adjust pixel-ratio to 1.5.
This seems to me to be the cause of the Density Plot bug I filed on the ...

...CPA Bugs forum

I'll dig a bit further into the code when I have more time.
Updated to work correctly with empty string keys

Fix for bug #170.  Also removed some of the logging in the test decorators to make spotting errors easier
battery icon style settings revamped + new textonly style

http://dl.dropbox.com/u/7965056/Screenshot_2012-01-28-00-36-04.png
Update README.rdoc

Line #3: The word "developed" was misspelled "developped".
Several Fixes

Fix for thumbnail bug
Sort UCP by new posts
Links in spoilers are hidden again
actualizacion

comprobante
Bescos tommy

Bonjour, je fais une Pull-Request pour avoir votre avis sur mon code avant de continuer le développement ce week-end.

Merci d'avance.

Tommy
Mbappou yvan

Monsieur,

J'ai un souci avec ma base de donnée. L'idée c'est de faire une table de jointure (ici appelée Authentifications)
pour savoir quelles sont les applications qui ont été utilisées par un utilisateur quelconque.
Le souci c'est que lorsque je veux tester des enregistrements sur cette table la en lançant irb -r './database' , j'ai cette erreur:

/home/ymbappou/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/irb/init.rb:216:in `parse_opts': Unrecognized switch: - (IRB::UnrecognizedSwitch)
	from /home/ymbappou/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/irb/init.rb:18:in `setup'
	from /home/ymbappou/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/irb.rb:53:in `start'
	from /home/ymbappou/.rvm/rubies/ruby-1.9.3-p0/bin/irb:16:in `<main>'

Pourriez-vous m'éclairer svp? 

D'autre part , lorsque je teste via mon navigateur le comportement de mon service d'authentification avec le compte "super_user" et le password "su" qui est l'administrateur du service auth, lorsque je crée une application via le formulaire, elle ne s'enregistre pas dans la table Applis et lorsque je reprends les mêmes commandes de mon code via irb tout se passe bien et je n'ai non plus aucune idée de là où ça pourrait bloquer.

Merci.
refactored IF statement in one-to-one templates so values are displayed

Updated the list and show templates for one-to-one relations so the value is displayed even if no AssociatedAdmin is defined
Mojolicious 2.46 compatibility

It seems there was a change in Mojo::IOLoop class anytime in the past.
PLFM-1348: update tests around auth now that display name isn't in session, can't update crowd user attributes. also clean up User (found in code review).
NSURLConnection / Background thread fix - wrust@kissmetrics.com

Applied fix for stranded NSURLConnection requests when called from a background thread.
Adding a check for Darwin and use greadlink to provide readlink access 

Small changes for all update_* so we can run on OS X. Tested on OS X Mountain Lion.

I did have to install coreutils/wget with homebrew.
SPR-9215

Adding test cases for SPR-9215.

Transaction not working when use Java Configuration with AspectJ

https://jira.springsource.org/browse/SPR-9215
fix french translation

Upon compilation I received the following:

fr.po: warning: Charset "" is not a portable encoding name.
                Message conversion to user's charset might not work.
tabs - spaces, fixed Array(), removed insertAfter, made a basic JSHint config file

> replaced tabs with spaces, fixed remaining uses of Array(), removed insertAfter, made a basic JSHint config file

This time, I checked over the commit with `git diff -w`. (Should have put the tabs -> spaces in a separate commit, but too late now :D)
View code consolidation

Move some of the view related code from the Module class to the layout view script
translate javascript

only works with dokuwiki branch jscachekey
Shuttle Bus app changed for new Semester

## Major changes
* Modifying Main.java for the new semester
* Replacing match_parent by fill_parent for backward compatibility with Android 2.1
* Commenting out missing drawables in options_menu2.xml (I believe you just forget to include them in the repository.)
* Adding a .gitignore file where all my Eclipse files would be mentioned and ignored (you can ignore to merge this file though)

__These changes have been tested for Android 2.3.3 and later.__
Thanks for your interest in improving Git.
We do code reviews always in the open and I do not respond to pull-requests on Github. Could you redirect this to git@vger.kernel.org like everybody else does, following Documentation/Sub mittingPatches?

The command line convention for all commands is to have dashed option before all the other options, so the right place to put the optional -p would be before the optional <stash>, even though the command may happen to accept a malformed command line.

Also it might make more sense not to single out -p; I think you can give any reasonable option that is acceptable to the diff family of commands, e.g. "--stat", "--name-status", "--summary", ...
Ah right forgot the check. Sorry.
Initial work on filters. Expect more within comming days or weeks.
Here, instead of changing from "s", which will store a char pointer, to "O" which will accept any python object, we should use "s#" which stores the char pointer and size, and allows for null bytes in the char pointer. Explanation here: http://docs.python.org/c-api/arg.html
grrrr Pivosgroup == davilla, I did it again (forgot to change github login :)
My latest pull request (a few days ago) implements this simplification.
I first tried `sleep 2` and that worked (except the test below concerning how long it should take fails). Then I tried `sleep 0.1` and it worked. Then I tried `sleep 0.01` and it worked as well, so I figured that it might just want me to pass control to another thread, which, sure enough, works. Weird stuff, since it seems like the select block should be synchronous, right?
@dirk good point!
By using glob, we can do some moderately fancy bits of file manipulation to find all extension directories.

For example using an example in the shell

$ ls -l ../../*/*/update.xml
-rw-r--r--  1 kfdm  staff   144B Feb 12 17:49 ../../applescripts/Extension one/update.xml
-rw-r--r--  1 kfdm  staff   150B Feb 12 17:49 ../../applescripts/Extension two/update.xml
-rw-r--r--  1 kfdm  staff   141B Feb 12 17:49 ../../scripts/Extension three/update.xml
-rw-r--r--  1 kfdm  staff   142B Feb 12 17:49 ../../scripts/Extension four/update.xml

Looping through again, we can get the real directory for each and put them into an array to loop through later.
Sorry for the hassle folks!
Hmm, that's true. Better to keep it then.

Btw, add a "\\" sign before \* in the edit box to avoid github thinking you want italics.
One could e.g add ```_encoding``` in core.common, set it as default to ```sys.stdin.encoding``` or ```'ascii'``` if that does not work. And use core.common._encoding further on. This way the unittests can enforce an encoding e.g UTF-8 (by changing core.common._encoding) and you know what you will get.

I tested again with all the new fixes and when using 'Latin1' codec, one unittest fails due to unicde.
Very nice. I never noticed that the old plate armor wasn't completely filled. Oops.
Sorry I just assumed that you meant achievements when you said notifications. Are you going to use achievements or something else?
I love the comment :)
Can you point me to the gist of the change... it just looks like shuffling code.
oops this `Series` is totally unnecessary also
EGG is for chicken eggs, SPAWNER_EGG is for the new spawner eggs you get in creative.

Debating if I should change EGG to CHICKEN_EGG, though this would be a breaking change. My reasoning behind adding a new separate spawn reason is due to our PlayerEggThrow event (it only applies to chicken eggs being thrown) which clearly showed me that they should be separate.
Wouldn't it be better to use `PHPUnit_Framework_TestCase::markTestIncomplete()` to mark tests that have not been implemented yet? Skipped tests, contrary to throwing exceptions, do not prevent the whole test suite from passing on successful runs, but they give a clear indication on what still needs to be implemented / tested.
Yeah good point. I just tested and it works well.
What is the purpose of including the condition 'event.target.offsetWidth !== 0'?
IE<9 is crashing on this function due to invisible objects attempting to gain focus, but that's only happening because offsetWidth is zero. I don't understand why the embargo is only included if offsetWidth is 0.
"Leave workspace" link is now working again (just had to un-comment the old implementation from when the workspace used to open in the same window).
*snail_caseing ...*
I "Lifted" the mouse propagation from Path.SVG; there is likely a better way to do this, but I couldn't get other methods to send the click event for a label click.
Ok, I'll push that once the movement fixes are reviewed I guess, to avoid a conflict.
Due to the rename, there is no 'roundup' to call.
shouldn't dr_id be reminder_id or something like that?
I've just performed the fix and pushed it, should be ok now
обновите ОС, какие проблемы?
или патчи поставте по тайм зонам
It's not tested.
Still doesn't work.  You can't use a delegate literal at all for some reason.  I'll merge the changes though and update the code.
While that makes sense, I am syncing these across multiples computers & would like the info I have in ```.extra``` to also sync. Is there a better way to do this than just add ```.extra``` to my ```.gitignore``` file?
wie siehts damit aus? ok so?
thanks!  my midnight mind didn't spot this :p
since this check not need (see full code)
may be. bad tested things.
When I didn't reboot server every day, memory usage of mangos process was stable and I think, there was not a leak. but CPU usage was ~100% (one from cores). There was source of lags. Why it become 100% after 24hrs online - I don't know...
Подозрительно выглядит. Действительно нет ошибки
recheck "enum Gossip_Option" at GossipDef.h, if you really have option_ids like you say
could use map here instead
this `import` should go below the python imports
/**
     * Parse a value into dispatchable controller, action and paramters
     *
     * @param    string           Value to parse
     * @return   void             No value is returned
     */
    public function parse($value);

Switch out `$str` for `$value` and it should be golden.
This is BC break, as before this we can put i.e. an `Request` object as a param (which AFAIK is possible when normally using Controllers), now we need to _hack_ around.
The problem is that the anonymous function is generated incorrectly, since the parens for `f()` are added outside this method, that's why it was failing; the generated code was something like `function($){return $!==null?$.f:null}(object)()` instead of `function($){return $!==null?$.f():null}(object)`. I don't know which code adds those parens at the end, to call it before adding `:null}` and omit the call after `(object)`.
The problem I see with this approach is that binding the callback function to the scope could cause memory leaks when a tile is destroyed before the callback is executed. I would more prefer something like 

    getURLasync: function(bounds, callback, scope) {
        callback.call(scope, url);
    }

and expect the callback function to receive the url as argument (in ```Tile/Image.js```):

    getURLasync(bounds, function(url) { this.url = url; this.initImage(); }, this);
I hope you are aware that in some environments ini_set() is disabled for security reasons.

Personally I don't think this change should be added to the main distribution. If you need such changes you can just modify your index.php.
1. Fix style issues using CSS, do not relay on JS for this.
2. It's only an enhancement. And the issue itself is neglectable
3. 90% of time html5shiv is used in to ways:

a) using it directly inside of IE conditional comments 
b) as part of Modernizr
You are not allowed to remove the copyright headers of my scripts.
Please insert it again...
Move to `settings.py`.
Ah.  Thanks for the clarification.

I don't think this should be a problem unless you set node['nagios']['plugin_dir'] to be the same as node['nagios']['config_dir'].  By default node['nagios']['plugin_dir'] is set to /usr/lib/nagios/plugins in nagios/attributes/default.rb and node['nagios']['config_dir'] is set to /etc/nagios in nagios/attributes/client.rb.

So that move command should expand to:

mv /etc/nagios/*_nagios*.cfg /etc/nagios/dist

and that shouldn't touch /usr/lib/nagios/plugins/pagerduty_nagios.pl
`{}` is unnecessary
Added check if temperature is available if not do not display Temperature bar graph.
Expanded temp conversion prog.
We hope to see you back once 0.8 is out and we provide it ;)
Actually that does not make any sense and should be removed until there are some DTDs present.
this doesn't seem right
If you had written "fixes #4" it would automatically close the issue when the changes were pulled into teatrove/teatrove.  see: https://github.com/blog/831-issues-2-0-the-next-generation
@PheonixKotori: Roger that. I guess I have a little time to pick up the slack on client-side development then- I'm hoping to get a lot done this weekend.
lol don't set form delimiter's to li's it messes up the Inline help,  I have a helper function that I used to use to return the validation_errors() as a array that looped thru them and spit out a ul list if that would help.
I moved this into alt because I thought Play was coming out with a new version "soon" but I guess not.
Adding it in the front did not work (shows only the watermark and none of the other text. Adding it in the end will print the watermark over the screenplay text. It has to be here if it's going to be visible, and under the screenplay text.
Yes, in an environment without selenium (or any other splinter dependency)

setup.py imports splinter/\_\_init\_\_.py to determine the package version.

\_\_init\_\_.py imports browser.py, which imports driver/firefox, which imports selenium and lxml. You'll not be able to install splinter without installing selenium and lxml before, but that's not what setup.py and its dependency management are aimed for.

Simply moving the version to setup.py should fix the problem, but I think that splinter.version is also referenced from sphinx.\_\_version\_\_
Again we need to parameterize over jobs.
Whitespace off here?
Não investiguei a fundo, mas depois que eu alterei o valor de DIR_INSTALACAO para "sys" (antes estava "MojoPHP") um erro louco de 404 not found que eu estava tendo na requisição do /index.php sumiu. Development Environment in MAMP. Confere o histórico aí:

https://github.com/mikemaciel/MojoPHP/commit/ffe16d9515d8ebfdcde969a075a2ae27357edba6#diff-1
xuuu
Shouldn't this become onUpdate?
That's tough – most of the German online CSS references are poorly maintained. Try [Michael Jendryschiks HTML/CSS introduction](http://jendryschik.de/wsdev/einfuehrung/css/selektoren) – I'm not sure how up-to-date this is, though. [Sitepoint's CSS reference](http://reference.sitepoint.com/css) is way better and actively maintained, but in English.

Quick explanation: #xyz>div selects any div which is a direct child if #xyz; #xyz div selects any div which is a child of #xyz, but it doesn't have to be direct, it can be nested in other elements; #xyz > div is the same as #xyz>div since whitespace doesn't matter in CSS. :-)
Why would HTTP be preferred? It's worlds and worlds less efficient.
right here are the major changes, the two lines were deleted : 

```java
graphics.setBackground(new Color(0,0,0,0));
graphics.clearRect(paintArea.x, paintArea.y, paintArea.width, paintArea.height);
```
Looks like a wrong docblock.
I would tend to remove **all** this constructors in favor of initializers. This way there is no ambiguity on which one to use.
back soon, installing win7 updates.
You're right. It's to do with the include order.  I've been trying several different ways of doing it but their all nastier than the last.  I am starting to think that an ActiveModel::Callbacks style around_ filter would be the way to go.  More on this later :)
This is incorrect. RunningMode.ADMIN_ONLY does not disable Stage.RUNTIME for interfaces.
Hi Bogdan,

I remember that we decided not to add the empty text-node but it might 
cause you problem when you will put the caret since there is no 
text-node, isn't ?

g.

On 23/02/12 09:34, Bogdan Flueras wrote:
> Just wanted to ask you about this, and put the TODO as a reminder, in that case I agree.
> There is some other issue though: in TreeInsertParagraph if a textnode was split at the end (Enter at the end of the text node) the split is done but we don't add to the tree the new text node child with empty string.  Could you adjust your code to do just that?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/xwiki-contrib/wiki30/commit/7be796482bb2b41d877cba2cd37a894effee37ca#commitcomment-999825


-- 

Gérald Oster                                       oster@loria.fr
Maître de Conférences                         www.loria.fr/~oster
ESIAL - Université de Lorraine
Equipe SCORE - LORIA / INRIA Nancy-Grand Est
1 : The problem is that domtemplate will output anything that used to be a non-ascii character as html hex code instead ("…" becomes "&#x2026" you can see this on your forum as well.);, this is not a really a problem when the site is english only but it's ugly and would be a stupid waste of space when using a different script. (Cyrillic for example) 

2 : There should be one there, thanks for pointing that out.

3: No, the XML prolog does not output.
Ditto here. Although, I'm less convinced this code is useful anyplace else.
Bonjour Philippe,

 PD> I have time (at least) to check your commits. I do have a few questions:

Thanks for looking.

 PD> - in cache_inode_get.c : why removing the unlock in the case
 PD>   cache_inode_valid fails ?

The code just looked "wrong".

There is no indication that cache_inode_valid() takes extra locks in
case of failure (actually, it cannot do that of it will always
deadlock), so this code looked like it was trying to unlock the entry
twice on failure.

 PD>   The entry will remain locked which will lead to later
 PD>   deadlocks. The fact is that this function almost never returns
 PD>   an error (which hides many things) : your code will result in a
 PD>   segfault because you set pentry to NULL then deference
 PD>   pentry->lock

Note that this isn't my change - I did not add pentry changes,
I've only removed the lock. In the hindsight I should've spotted this.

I think this code was meant to say:

  P_w(&pentry->lock);
  if ((*pstatus = cache_inode_valid(....)) != CACHE_INODE_SUCCESS)
  {
        V_w(&pentry->lock);
        pentry = NULL;
  }
  else
  {
        V_w(&pentry->lock);
  }

The 'else' got lost and this created the confusion.

In fact, I usually write fragments like this slightly differently:

  P_w(&pentry->lock);
  *pstatus = cache_inode_valid(....);
  V_w(&pentry->lock);

  if (*pstatus != CACHE_INODE_SUCCESS)
        pentry = NULL;

Less code and less chances to miss 'else'.

 PD> - in cache_inode_getattr.c : you need to keep the V_r. If not,
 PD>   the pentry will remain locked, which will result in deadlocks

Um, I'm adding the unlock, not removing it. And the reason I'm doing
it because it was locked previously and must be unlocked on the 'error
out' path.

In fact, what are you feelings about using goto's and error_out for
managing this kind of situations? It is similar to what Linux kernel
practices and it works there reasonably well.

 PD> - in cache_inode_link.c : same issue
 PD> - in cache_inode_rename.c : same issue too. 

Once again, I'm unlocking on error, not removing the lock.

Compare that with cache_inode_rename.c where I've removed the lock
which was unlocked twice.

 PD> The key here, is that cache_inode-* calls makes all of the lock
 PD> management. If they take lock, when should release it when
 PD> exiting. The statements that you removed were set for that
 PD> purpose. 

We're in violent agreement on that one.

 PD> - in cache_inode_rdwr.c : why removing the test on
 PD>   if(seek_descriptor->whence != FSAL_SEEK_SET) ? Was it causing
 PD>   bugs ?

No, it was simply duplicated code - the same check is done earlier in
the same function.

And the 'missing' brace was causing vi to go crazy when trying to
match braces.

 PD> In the current state, I can't integrate that commit (the change
 PD> in cache_inode_get seems quite dangerous).

I agree on that one - do you want me to re-write this in the same
commit or add another one on top to fix the 'else' problem?

max
I have the same problem. Also using Java 7.
otherwise lgtm
Ok, I'll wait the data source before testing.
I usually see this framed as "cur" and "next" pointers, with "cur = next" in the iteration clause of the for statement, "next = cur->next" at the beginning of the loop body, and then operations on cur.
Ruby 1.8.7 treats that colon as a `then`, Python-style, but Ruby 1.9 will think you're starting a JSON-style hash (`{foo: 1, bar: 2}`) and barf.
Why not have attr_accessor  and override payment.attributes to return number?  This was a major issue with spree IMO.  One bug away from accidentally storing credit card numbers.  Yes this bug happened to a project that used spree that I know of. I'm not sure if spree has a number column any more.  

BTW:  I'd love to help out.  If you have time to skype or yahoo IM.

PS:  Please tell me if you want more / less / no comments.  I'd hate to be bothering you.  =)
PPS: You did some work on shoedazzle at one point right?
Just replace class-wc-product.php with that from the dev version
I think I havent found spell with script effect for summoning, but I dont remember.

DoCastSpellIfCan doesnt work for 5 spells cast one after another, only 4 were usually summoned (5 worked like in 10% tries) so I made it like that to work always properly.
hmm... the git tarballs have apparently been removed from kernel.org and its mirrors.
it is indeed fine to remove mirrors which will result in a 404...

please dont forget to update sha512 and filesize if you change the version, like for git it is missing now
The rest of the day got busy so I couldn't reply, hold off on doing DO for the time being.
to_a is more idiomatic, but I'm not sure why you'd have a method named like this
Log, printf나 hit count 같은 고유한 문맥에서 쓰이는 단어는 <code>\<code\></code>등으로 감싸서 튀게하는게 좋을 것 같습니다.
Actually because you're deferring callbacks to a timeout you're probably okay. The loop will have finished running before the first callback is called.
Closes #5362
I can't believe that some people have to develop applications for this awful operating system every day. 

Back to bash scripting for me.
Also, some of your commits are still showing up as unknown. If you're using multiple computers for development, maybe one of them doesn't have your Git details set up properly locally?

It looks like your changes in the main develop branch are two commits ahead of what you based this commit on, but not sure what differs between those two commits and this thing.

The menu works, anyway, so could always just rebranch / pull from the main develop branch and restart there :)
The SvgResultParser isn't working yet, it throws an error as described in one of the TODOs above.  Also the mouse over test fails, I think maybe we will need some setup that calls addEventHandler with all the event handlers which the Graph would normally supply?
Do you want me remove back-ticks in other OS commands also? Or just for Windows?
Javascript whitelist in global settings is added twice without this code.  With this code, urlfilter lists without '##'  are removed.
I love LGPL too.
Yep. See [`eval` in `/src/coffee-script.coffee`](https://github.com/jashkenas/coffee-script/blob/de9970412af1cfad462496ec83605defd56d437d/src/coffee-script.coffee#L81) and [`run` in `/src/coffee-script.coffee`](https://github.com/jashkenas/coffee-script/blob/de9970412af1cfad462496ec83605defd56d437d/src/coffee-script.coffee#L60). I had to do something similar in [63ce244](https://github.com/jashkenas/coffee-script/commit/63ce244359688ac348e95878f0c189e5c331b5ec#L2R81) and 0c5726d3ab33251c5f89e506cda72e5cf19fbac5.

Fixed in 44e1ccec7e8f75c7e7862d96e35d009e4db68d37. Thanks for the report.
In order to make WebTestCase Test to work
thanks dude cleaning up my mess ;)
That was the point of the backspace functionality. Unless I am missing something? When the user hits backspace (and results are not showing) the last selection is removed from the selections array and the field's value is updated? Was that not working correctly, or u just didn't like it?
Supongo que nos lo ha reportado el mismo jajaja.

Por cierto, no se ni como puedes pensar que nosotros, que la arreglamos, la vamos a bugear... es como si tu usaras hacks en el server... no tiene sentido...
Use "#" before issue numbers. Looks like github will create links to issues then :) For example issue #1
Thanks :)
I did not test the behavior when setting wait to false but if supervisord refuse the start command I am afraid we have an annoying problem xD
one solution could be to span another thread to control the restart:

```ruby
def restart(wait = true)
  if wait
    stop(true)
    start(true)
  else
    Thread.new do
      stop(true)
      start(true)
    end
  end
end
```
Ok, I found an error in the dmesg log:
[SMD]smd_open() fail, because radio no open DATA5 smd chnnel
Implementation optimizations correctly annotated. Reviewed
**Part** | **Points**
------------- | -------------
base | 1
**Total** | 1

```python
print len (nums)
```
Putting a space before a `:` or the `()'s` is highly discouraged. Don't do it, I'm surprised it worked.
die map mit animationen hoffe sie funktioniert bei euch auch
btw chopper cube geht auch nachder 14 tage test version noch weil die teile von irredit immer noch freigeschaltet sind
hab nach gelesen hoffe sie haben nicht gelogen ^w^
Could you add fixtures for this change?
So I can build new VM images now?
Again multiple inheritance suggests this is not correct
yes.  The new DHCP code needs to be ported to master
@robyurkowski this should just be called SettingsController now
I think this link probably needs to be up the top with the other links - certainly there is no reason for the link to a user's comments to be more prominent that the link to their diary entries.

I know the link list at the top of the user page isn't brilliant, but addressing that is a separate project and we need to be consistent with what we have already for now.
Yes, I tried, the ics kernel boot succ.
don't you mean here : `if self.pbid is None or self.pbid == '':` ?
bcm4325 cause extremal power drain (about 10% per hour) when wifi is enabled.
I can't find problem for now...
Tried to compile module from LGE's kernel: power drain still here...
Gary, i was wondering if (after what we know now and realizing where the problem is and where it should be fixed) we should just put Thread.sleep(2000) after adapter.afterPropertiesSet(); and also remove adapter.start() since we know its a meaningless call. After all its a test code and after a while we might begin to wonder what all those lines of code mean. 
Either way its good for me, but i figured i'll ask.
Actually tail -f is a good example of this. It does exit with status 130, but also doesn't really mean much... "an exit status of zero indicates success, and a nonzero value indicates failure"

If I control-c from tail -f, IMO its not a failure that the program was interrupted, but rather, a successful termination, initiated by the user.
Necessary because those are now in two separate CompositeFields, so we can do the visual grouping of buttons more easily
Okay, if it works without, we shouldn't use it.
estaban debugeando el flujo de información en una vista con un formulario :P de ahí lo sacan
So this conversation is closed out (for those looking after the fact), I missed that @niran was talking about form field, not a model field. :-)
I think you have a threading bug here w.r.t. asynchronous exceptions; if the thread is killed before your exception handler is installed, the MVar never gets written to. You need to mask asynchronous exceptions before you fork; the usual idiom for this is:

    mask $ \restore -> forkIO $ try (restore io) >> tryPutMVar done ()
What if decimalPlaces is a big number?
I can’t add this name: there is `Markdown` owned by `Hallison Batista` with different github source. I can only use `markdown@tpope` as a name.
Thats' exactly the spirit. I also noticed that when the drawing is small (thumbnail size, which is what the logo should be anyway), the hearts and ears are not visible at all. Your ears and hearts are cute, I'm just not happy with the little guys to begin with, I'll redraw them tomorrow!
The ticket was talking about config.data not remaining an object after the initial transport. Unless I read it wrong.



On Sep 7, 2012, at 7:42 PM, "Eric Ferraiuolo" <notifications@github.com<mailto:notifications@github.com>> wrote:


In src/io/js/io-base.js:

> @@ -642,6 +642,7 @@ IO.prototype = {
>          // querystring-stringify-simple.
>          if ((Y.Lang.isObject(data) && !data.nodeType) && !transaction.upload) {
>              data = Y.QueryString.stringify(data);
> +            config.data = data;


Shouldn't this be config.body = data? To match what it does in Node.js?

—
Reply to this email directly or view it on GitHub<https://github.com/yui/yui3/pull/243/files#r1559823>.
Is the rest of the library going to change too? IOW, are widgets now going to be y-[widget name]-content, etc.? I'm all for short but really against inconsistency.
If we're unsure that there's a use case, my vote would be to leave it out for now. We can add it later, and which point we may want to consider whether it's a number (depth/level) instead of a boolean for more flexibility.
I moved it outside of the `next()` function so it can be reused by the route-specific callbacks. Each set of callbacks for a particular route should all receive the same set of parameter matches. Since this information is to be shared by these route callbacks, I needed a place to store the matches. Notice that the route's `callbacks` are also in the outer scope.

By defining the variable in the outer scope, I'm able to reference it during the "recursive" calls to `next()` when a route's callbacks are being executed. Once we move on to the next route, the matches are reevaluated.
You're right. Return false but generate a warning?
those functions (_plan_key and _gencode_key) are probably worse a wiki entry...

"the coloring part of the key" is the part that capture what effects on the coloring for that loop: that is the accessors conflicts on Dats.
this is a list of conflicts, there a conflict for each dat that is INCremented. for each conflicting dat, the conflict list all the (map, [idx]) tuples where map.toset == dat and (dat, map, idx, INC) is an arg of the loop.

don t know if that makes more sense now ...
Use just new.
awesome documentation in here!
Is this line safe?
yes, needs `try publish finally unregister`
ummm, "composer"?
Yes, `sys.props` is specialized to be a two way mutable mirror of `System.properties`.
well, right, the problem isn't that we're explicit here.  the problem is that we *have* to be, which means that we don't have a functioning userstamp on the revisions table, which we did have before.

I think we need to get that to work.
Please, Adriá, read my answer to your first comment above.

--

We do not need that interface function anymore.
with the limit seeing as 31 is the default I'd not specify it.  maybe we should allow the limit to be set

eg `limit = context.get('limit')`

I I did I use the keyword `limit=31` so that it is clear when reading what the 31 is for.
Updated, thanks for feedback :)
I'll let @twall comment on this, but I think catching and ignoring exceptions here is a really bad practice. This is just not supposed to fail, and if it does, something has gone awfully wrong.
cosmetic: space between if and (. Same in some of the checks further down.
```
args << "--style-measure #{max_width}" if max_width = options.fetch?(:max_width)
```

80 characters. :trollface:
Need a slightly more helpful error message here :)
`if lock_mode` should suffice.
Let's rename ``SourceTail`` to ``Rest`` in both functions.
This is an excellent idea: interpret FQCN as fully-qualified config name, meaning that a transport is loaded quite like a dispatcher. Then this would change into

      enabled-transports = ["akka.remote.transport.tcp"]
do we always know that x,y == 0,0 means not a touch/mouse event?  I just want to be sure we never create a tap here and then again in mouseup/touchend
All I did was clean up the example code though... nothing new introduced.
Huh? They type it exactly like I did… except that I tagged the enum.
I think it should be `[s]how`! ;)
"pkg-detail" make sense, but the second things are designed to make zif more compatible with yum. I think we can just drop info-only.
Default string "%s_resample" is inconsistant with other classes and I don't believe it is necessary for Resample(), correct?
Ah, maybe it was just accessing random memory bits...
Checked over all patched lines for this issue as well.
Those methods names seems weird. `array?(value)` means `value === Array` to me. But I can't think nothing better now
I think this is not "unobtrusive CoffeeScript" it is "unobtrusive Javascript"
This silently fails when you set `config.action_dispatch.rack_cache = true` but didn't include rack-cache in your Gemfile. It should raise a LoadError. Maybe something like:

```ruby
if rack_cache = config.action_controller.perform_caching && config.action_dispatch.rack_cache
  begin
    require 'rack/cache'
  rescue LoadError => error
    error.message << ' Be sure to add rack-cache to your Gemfile'
    raise
  end
  require "action_dispatch/http/rack_cache"
  middleware.use ::Rack::Cache, rack_cache
end
```
:D I think I like `each_with_object`
Urgh, I cannot track it down, my tests are green, and I wonder why?
I think some people suggested leave this it in same line instead of a new one, I don't remember who exactly
On Thu, Jul 26, 2012 at 4:11 PM, Paul Phillips
<reply@reply.github.com>
wrote:
>> @@ -112,11 +112,23 @@ abstract class SymbolLoaders {
>>      enterClassAndModule(root, name, new SourcefileLoader(src))
>>    }
>>
>> +  /** The package objects of scala and scala.reflect should always
>> +   *  be loaded in binary if classfiles are available, even if sourcefiles
>> +   *  are newer. Late-compiling these objects from source leads to compilation
>> +   *  order issues.
>> +   *  Note: We do a name-base comparison here because the method is called before we even
>> +   *  have ReflectPackage defined.
>> +   */
>> +  def binaryOnly(owner: Symbol, name: String): Boolean =
>> +    name == "package" &&
>> +    (owner.fullName == "scala" || owner.fullName == "scala.reflect")
>> +
>
> Man, I just got rid of coreClassesFirst.  It would be much better if there was an absolute prohibition on embedding the names of classes or files as strings in source like this.  It makes things so hard to debug later.  Can't we at least have some kind of configuration file which is consulted on these questions.
>
It's not a matter of configuration but of bootstrap. Happy to put the
constants somewhere else but I doubt it's better. The point is that,
as it says in the doc comment, we have to exclude scala package and
scala reflect package from being loaded from source. Any logic or
constants we write should be right in this method, nowhere else.

Cheers

 - Martin
No motivation.  It won't look any prettier.
Just personal preference, but `x && {sideEffect; true}` is a bit icky.

```
val LastOverlappingIndex = overlapping.length - 1
overlapping.indexWhere(_.guard == EmptyTree) match {
  case -1 => if (!currIsDefault) needDefault = true; true
  case LastOverlappingIndex => true
  case _ => false
}
```
yeah, i wasn't sure about what to do here. This is for the colorbar but it would be difficult to interpret a colorbar with transparent overlays. Anyway, I just left this in for now just to get this out the door but we can put in an issue to resolve this after 0.2
Bare excepts, and asserts impacting the logic of the code should be avoided.
Was only a matter of style: spaces around `>`.
I don't believe this is actually implemented, though I could be wrong. See http://en.wikipedia.org/wiki/Modular_multiplicative_inverse
The issue is that 5**-1 mod 7 involves a negative power. Regardless, divmod does not yield the correct response. I'm going to keep this as @XFAIL for now.
**U**nsupported
Well, I can not make such decisions. You should consult with @mdomba and @qiangxue for this.
Should this be "at reference pressure", too?
This should be split into an internal node loop and then a boundary+ghost node loop.
These changed cause `BaseRouter` now always returns 1 host?
Any result of the pondering?  The more I think about it, the more I like a special default (perhaps given by a string ``"default"`` or ``"default (360,-360) deg"`` or something) that maintains this reasonable behavior regardless of units.
What's XXX? Also we need to have this documented in the guide with the versions affected.
Shouldn't you also update d_xmlType on saving?
Shouldn't `i` be encoded?
Problem will happen when a person have the config file (which is very likely) but does not intend to use it. Then for passive behavior of not using the file he will have to do an active behavior of setting the flag to empty string or nil. This is counter intuitive better to use it if he specified in the flag to use it.
Yes it helps to organize the dirs but I think we should have a empty string/nil value here anyway.
Should the schema be "l20n:"?
Seeing as this patch does not support memory control, I think this feature should be deemed "experimental".
think we need to copy over tags and review_tags too here?
Must be rebased and updated to 'cat' => 'post
Why is there a new line added here? Do we need tow lines between the assign_vars() call and the $vars variable?
These should actually be the Unicode quotes that you can copy paste, for example, from USE_SMTP_EXPLAIN.
This and other lines in the comments need to be shortened to <= 79 characters.

Wording needs to be changed as well; something much more simple:
"Determine which forums the user has both the f_read and f_read_other permissions."
Not required, it just makes urls look better.

As for bantu's point is fair enough, but I don't think that should prevent us from adding a feature and it's not hard to fix it manually? Could we see some stats on how many boards have it enabled/disabled?
The other way around. sizeof() takes constant time.
Why not? Make a change, commit it and push. Seems like very little work to push commits after you have made them?
IT was inconsistent with the rest of the menu, and I can't see any harm in changing it.
Has nothing to do with that. Read http://tools.ietf.org/html/rfc2616. You need a proper parser.
This should be inside of `phpbb_gen_download_links()`. I.e. the function should make sure its dependencies are available. That's still easy because the function already knows the root_path and phpEx. Please use class_exists and require instead of require once.
Camera rotations are done in FPS manner, so yes.
-a        -- write all files; default is to only write new and changed files
    -E        -- don't use a saved environment, always read all files
    -N        -- do not do colored output

I can't remember the reason for always forcing a full build; maybe something in the akka or atmos docs where things were being missed or messed up in some way, requiring `make clean` often enough.

Yeah, possible to break this out into a sphinxOptions with this as default.
Ah... 2 reasons:

1. WAI's request type has a conduit sink as the body type, while this has an Lazy-ByteString (which is what we want). Transforming the request type to this let's us get rid of the body parameter in a Hails app, and also ties the body to the request so we don't have to pull any tricks with the converters to make sure the integrity on the body is right for the current request (since we'll just be able to pass in request only).
2. Having a separate type gives us a little bit more independence from the underlying server framework. This is a more minor advantage but seems nice.
The results are sorted by dependency order, not lexicographic order.  (In fact, the dependency ordering is the purpose of this method.)
Ideally yes. Hopefully that happens as the tests are ported to the new testing framework.

I'm punting here/now since I'm concerned about this redesign work growing in scope...
Baby zombies don't age; for instance in the [chunk NBT](http://www.minecraftwiki.net/wiki/Chunk_format#Mobs) it is just a byte tag that is 0 or 1.
Nice var name. :)
Missing XML comments of type and it's members
where's the given/when/then declarations? pff ;)
I think this whole project might be better being called `Nancy.Demo.Razor.Localization` because that's what it is showing off, not localization in general
undo this change... piyush is working on it. ```/src/``` shouldn't be in path?
I haven't run it, but it looks like this test requires the test to be run from a specific folder. More a question for @nouiz or @lamblin -- is this OK?
The actual query execution runs  should also be executed against an hsql config to  validate results and against a multi-partition config for correct behavior.