labofsahil/github-event-dataset-2012 huggingface dataset:
I'll have to think about it some more. It would be nice if it worked easily in the notebook, but the user's code shouldn't need to be notebook specific. It might be that the implementation you've already got is the neatest - I just misunderstood its purpose at first. We should at least make the name/docstring clearer - `url_prefix`?
Ooh, lovely. I looked at the existing string % url code and simply expanded the same style.
I briefly discussed the code with Min, and he graciously ignored the pain in mine.

On Jul 23, 2012, at 10:38 AM, Bradley M. Froehle wrote:

>> @@ -484,7 +501,12 @@ def reload(self):
>> 
>>     def _repr_html_(self):
>>         if not self.embed:
>> -            return u'<img src="%s" />' % self.url
>> +            width_by_height = []
>> +            if self.width:
>> +                width_by_height.extend(['width="%d"' % self.width])
>> +            if self.height:
>> +                width_by_height.extend(['height="%d"' % self.height])
>> +            return u'<img src="%s" %s/>' % (self.url, ' '.join(width_by_height))
> 
> Do we not have any convenience functions for building an HTML tag out of a dictionary?  I guess I would have expected us to have something like:
> 
> ```python
> attr = {}
> attr['src'] = str(self.url)
> if self.width:
>    attr['width'] = int(self.width)
> if self.height:
>    attr['height'] = int(self.height)
> return render_html_tag('img', **attr)
> ```
> 
> Anyway, in the future this might be written more cleanly as:
> ```python
> width = height = ''
> if self.width:
>    width = 'width="%d" ' % self.width
> if self.height:
>    height = 'height="%d" ' % self.height
> return u'<img src="%s" %s%s/>' % (self.url, width, height)
> ```
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/2178/files#r1216363
For the most part we are putting the `{` at the end of the previous line with a space after the `(`.  Please fix throughout.
Yeah, I guess those aren't really options, are they?
match a close curly
ouch cyclomatic complexity :)
Ah. Did not know. Cool!
This was a bug fix. The old line ordered and reversed incorrectly so if there were more than 20 Records, then it showed the earliest 20 and not the most recent 20. Oops.
This should use clean_excerpt() like the other excerpts do. That way we can change it in one place and it affects all of them.
base_old.html? does that mean it's not used anymore?
This will throw an unhandled error in case of bad data (non-existent rcv id).
another sort-of nitpick: we've been using double quotes for docstrings throughout.  let's do that here, too.  In general we have preferred using double-quotes for most everything, because it makes it easier if you have text that contains a contraction "can't" or something.
s/uuid/ooid
we ought to have a style standard.  Lars prefers one item per line in a select list.
Using help_text in the Form will let you avoid doing this.
moving this to just under the module declaration makes this compile for me.
@adamfairholm my bad for taking so long. Had some server issues so I was staring at Terminal all day yesterday..
oops too fast, it needs to be reverted !
Can't this be "cached" in private variable ? Or it's necessary to get it from db every time ?
Why not returning a new DateTime in this case instead of -1 ?
@vicb https://github.com/symfony/symfony/pull/4013#r708907
@jalliot Right. Thanks. Fixed it.
Looking at the full file, I must agree with @Tobion and @stof, the assertion is duplicated twice. Here the full method from the full file at commit 062c35b. Around the middle, assertions are the same.


    public function testGetLanguages()
    {
        $request = new Request();
        $this->assertEquals(array(), $request->getLanguages());

        $request = new Request();
        $request->headers->set('Accept-language', 'zh, en; q=0.6, en-us; q=0.8');
        $this->assertEquals(array('zh', 'en_US', 'en'), $request->getLanguages());
        $this->assertEquals(array('zh', 'en_US', 'en'), $request->getLanguages());

        $request = new Request();
        $request->headers->set('Accept-language', 'zh, en-us, en');
        $this->assertEquals(array('zh', 'en_US', 'en'), $request->getLanguages());

        $request = new Request();
        $request->headers->set('Accept-language', 'zh, i-cherokee; q=0.6');
        $this->assertEquals(array('zh', 'cherokee'), $request->getLanguages());
    }


You can look at it [here](https://github.com/kerihenare/symfony/blob/062c35b3646810447772369e55fe32451937127b/tests/Symfony/Tests/Component/HttpFoundation/RequestTest.php#L784)
I did have plans for the arrow keys, which I have left out for now to keep it simple (cycle through options with up/down arrows).
cases were sorted alphabetically previously. You should probably keep this order
@pborreli thanks for the sample ;)
Maybe add a black rectangle to the colorbar plot so it's clear that values below the low threshold get clipped to black?
It does happen. Code falls through and returns a 0 in the event of an error.
I think that feeds and replies update should be single api call and return them both based on timestamp.
Typo in the description, "email" twice
Should this be required and not 'requires' ?  Any reason not to use the generation of required params here and in unit_earch call?
nit: @constructor last
Sounds good Doug! Will get app.py going and I was curious about production
deployment and I think you have answered that as well.

On Mon, Aug 13, 2012 at 2:49 PM, Doug Hellmann <notifications@github.com>wrote:

> In akanda/routerapi/v1.py:
>
> >
> >  blueprint = flask.Blueprint('v1', __name__)
> >
> > +app = flask.Flask('routerapi')
>
> It looks like devserver.py is meant to hold the development version of the
> server wrapper. I think I stuck that in *main*.py in ceilometer.api, but
> devserver.py is a good name for it. I would not put the app there, though,
> since you'll want to reuse the same basic app instance for development and
> production to ensure they have the same routes.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dreamhost/akanda/pull/17/files#r1365203>.
>
>
companyName() method used in $formats
This is the save failed function that is subscribed to the saveDatumFailedToPouch channel and will get fired aytime somethign publishes to saveDatumFailedToPouch. it works similar to the success function above except that it toasts the user that there was a failure, augments teh failure and moves on to the next datum. so that the import isnt blocked if one datum fails to save in the middle.
The dilemma I had here is that domain attribute was not defined in xsd for 1_0. 
so the proper way to fix this would be to add "domain" attribute in to xsd 1_0 and add load-balancing-group to 1_1 and fix parser accordingly
is it worth a search and replace for s/Thread.sleep/org.jboss.narayana.qa.Delays.sleep/g

Then implement the sleep function in Delays to do a Thread.sleep(getDelayFactor()

WDYT?
Do we have this above? Would it make sense to just `$.extend()` it ahead of time? At least caching the offset would probably be good.
There's trailing whitespace here, blank lines should be completely blank.
I don't know nginx conf very well, but if at all possible, don't hardcode directory names like `(js|css|img)`. Instead determine if the path is an existing file or directory, and if not, reroute to testswarm index.php (as you already do below). That way we also get nicer 404 handling.
two space indent needed here
I'm not really strong in English but isn't 'both' used for two values?
Yes, ;)
var toaster = self.toaster;
this should now be in view
On 01/08/2012 05:19, ian-liu wrote:
>>       this.refresh();
>>     },
>>   
>> +  setEnabledButtonText: function al_setEnabledButtonText() {
>> +    document.styleSheets[0].insertRule(
>> +      'input[type=checkbox]:checked + span.setEnabledBtn:after { content: "' +
>> +      _('on') + '";}', 0);
>> +    document.styleSheets[0].insertRule(
>> +      'input[type=checkbox] + span.setEnabledBtn:after { content: "' +
>> +      _('off') + '";}', 0);
>> +  },
>> +
> @vingtetun I feel hard to use content: attr(data-text) instead.
> Because I use innerHtml to construct alarmList in line 280 ~ 284.
> It should be assign two data-text dynamically.

Not sure to understand. Can't you create 2 css rules, one for unchecked 
and one for checked that use content: attr(data-unchecked) and content: 
attr(data-checked) ?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla-b2g/gaia/pull/2959/files#r1279887
I don't think this is the right test here.  setDisplayedApp() calls setAppSize() before setting displayedApp.  So adding this line will change the behavior of setDisplayedApp(), I think.

I suppose you could add a second, optional argument to setAppSize, called doNotChangeActivityFrame or something and then test that.
I suggest to create the shadow in CSS if it doesn't have a huge impact in performance. It's the best way to ensure we always have a shadow applied to the icon. Regarding the icon size, i'm sure @patrykdesign can help you.
The async storage is to be used as a Cache for the first STK message (applications list menu) as discussed herehttps://bugzilla.mozilla.org/show_bug.cgi?id=792751 and here https://github.com/frsela/gaia/issues/9
Do we always want to do this? Or should we check to see if they have a preferred key already registered?
Collapse the two initializers into the same thing.
So what would you recommend here?  Suggesting your grammar is superior to mine? or just disabling spellchecker? (Besides, this is not a result of automated corrections, I made these changes myself.)
You'll also want to change this.
With the converter (which I copied from our setter approach on TupleUnpacker) we can have access to both the type and the fields when we generate the TupleConverter to use.  Otherwise, the TuplePacker is only looked up implicitly using the type, and we can't do the pre-submit check with the fields that everything is correct.

For the case of the Ordered packer, I just want to make sure there is a constructor with the right arity.
Spell out `helper_functions` here, and put newlines between each set of classes that you're mocking (to be consistent with other tests).
``
      $keys = array_keys($form);
      element_children($keys);
``
Should there be a return here to avoid also performing in the Sburb queue?
I just feel like there should be a distinction in the return value vs success and fail, but I guess this is a minor if not non-existent use case anyway. Alright, I think that's everything.

Meeerrrge!!!
Technically, shouldn't you accept just the error in the flux? If one doesn't know the flux of a source yet, how do you know what the error in the background is? (maybe this is non-optical bias on my part, but before I do photometry, the only thing I know is the error on the fluxes of each pixel)
The comment's also being *removed* in this patch, so that's fine :)
Hi Mat,
Thank you for adding this resource directory feature.
But you might miss one thing, that is we should check whether the file exists. If not, we should search the root directory of resource folder.
There are some implementations of other platform(win32,linux,mac,ios) you could refer to.
The android port's implementation is a little different since this function just return *pszRelativePath* which is passed into. 
Because android is using just one *apk* file, we did this file check logic at *getFileData*.
typo here. And using ``interface`` seems weird to me
please remove the trailing whitespaces you added
what's this for? is it hold over from josh?
thx - doh ><
The best place to let everyone know what you want to work on is the mailing list. There's no other place where the discussions happen but there.

Github issues are reserved for filing bugs. General support and development concerns are discussed in the mailing list (Google groups).

As for the web server example, look at https://github.com/cpp-netlib/cpp-netlib/blob/master/libs/network/example/http/fileserver.cpp which already does practically everything you'd want from a fileserver. If you want to extend that to do other things then be my guest and send a pull request against it.

Let's continue this discussion in the mailing list to get a larger audience involved.
Convert to assertions
This should be ```typedef struct steel_slist{```
use link_to helper
You can't figure out reading the C++ code what I explained in the comment. I didn't see anything in the C++ code that said that if you "Store directly the input stream makes the cliboard's data available for Firefox but not to the others application or to the OS".
Actually, if you never doing that by yourself but just "copied" the C++ you will never figure it out.
And that's why I didn't see the value to add this link to "explain why": the link didn't explain anything about the comment I wrote.
was going to do that, but we'd have to call it, then invert the return value.  the code reuse removes no lines and hurts my brain.
You might flip both lines.
I have updated with the new background code
Nodes that inherit from a regexp node are ... not really supported.  We should treat that as an error, and fail, rather than handling it like this.
Is this actually an error?  In the DSL you can have resources declared at global scope that apply to all nodes, and an empty node declaration that simply identifies this as a known node to the system.  It seems like we should retain that.
Wait, why should the size be 3? We're creating one resource and expecting that it's not being added. That seems a bit magical.
Do we have a test that specifies that by default we expect the catalog to have 3 implicit resources? And if we do, what are they?
If we have an implicit size for the one added, I'd like to see it moved out to a var somewhere `@implicit_resources_size` perhaps.

Also, if we're checking size, we should have a test that checks the size of the catalog resources after one gets added, `@implicit_resources_size + 1`.
I saw the implementation and agree it's clean - my issue is that this is not really an RSpec concern - it's a Rails concern.
needs to be a volatile i think to test what you want to test...
CS?
Code\Generator
What is the purpose of save the return in the variable?
done, thx.
Den Satz würde ich streichen.
Yeah, the existing curated feed name is "windows8-packages" and we need to keep that.  Will the introduction of this automatically curated feed interfere with the existing curated feed?  It should just start adding packages to that feed it looks like.
What is the difference between source and lastDamager here @aPunch
Micro, but you could move the assignment one line up and do `o instanceof Tome`
The swank dependency needs to be in your ~/.lein/profiles.clj and not on this project as I wouldn't want this general use library to depend on swank. The same applies to the :dev profile below
This is already set by `ENV.fortran`.
Line break is wrong here. Combine assignments and add the line break between the logical blocks. One is variable creation the other is the array index definition.
Missing docblock comment here
Coding style is wrong here.
I would move this to an initializer file.
No need to `get_sockname` each time..

```ruby
@sock ||= begin
  sockname = get_sockname
  sockname ? Socket.unpack_sockaddr_in(sockname).reverse : nil
end
```
line 85-88
You should be able to use $ here instead of django.jQuery.
On 5/29/2012 1:11 PM, Aakash Desai wrote:
> How would I go about making that link localizable?

Leave it exactly as-is. ;)

> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/mozillians/pull/244/files#r893723
> 


-- 
James Socol
Community Platforms Manager
james@mozilla.com
@jamessocol
If we're checking these in another test (we should be in the login test), then we don't need to repeat them here.
We should rename _ to _fname, or something else that doesn't conflict with gettext, and then pass it to add_image. Same for line 151.
We should try to avoid `e.printStackTrace()` and use `org.pdtextensions.core.log.Logger:logException(e)` instead. It's fine if you're debugging locally, but when you get bug reports from users using `Logger` saves us a lot of feedback loops ;)
Btw, is it really necessary to add `assert`? I think `verify` will raise an error if the check fails, otherwise it just returns true, and the example in the README doesn't use it (I'm not so used to MiniTest::Mock, so just wondering :smiley:)
This isn't quite what we want here.  The error function should be avoided as a general rule.  Since this is runtime code, we want cleaner error handling.  There are several possibilities.  You could call pass or return a Maybe or an Either value.  The latter two would force the caller to explicitly handle the error, which is probably a good thing.
ah, I see, we actually ARE using mysql, I didn't know you could get travis to do that! Sweet. Still, need to fix comments above to explain what's the what. And perhaps change the Readme dev/testing section to explain you can do this?
Using an `id` for that will make it impossible to have two forms on one page later.
This could be private I do believe.
do you insist on the test* prefix? It's JUnit4 world ...
...  Or maybe, something like:
require_once __DIR__ . "/includes/globals.inc";
I wonder if it's better to change these methods to use a NodeKey rather than a String. It is true that SchematicDb uses String keys, but I would much rather use Strings as low as possible, considering that there's functionality in NodeKey that's very useful to use here, and using Strings may require re-creating NodeKey objects.
i really like the "fluent" way of working with the ExtraProperties object
The liquibase package creates a script that we can use as a qualified path: `/usr/bin/liquibase`
Will this produce a race condition that we discussed? Temp directory is created locally and then rsynced to the remote machine with the same name.
Libraries (like jquery, etc) are used to be included there.
I guess that was a silly kludge. It can work without that change, but I wasn't sure how to do it better.
Next time you modify this file, feel free to remove the unused component...
нужно, чтобы для целочисленных работало быстро. Хочешь ли ты при этом, чтобы работало для других мне не так важно. Основное, что нужно понимать, что нельзя так сильно замедлять программу при обобщении. Шаблоны сделаны не для этого,
тут ошибка, а там нет. ты уж определись
Probably _nicer_, should I adjust my PR?
oops, this file wasn't supposed to make it in the pull at all...unless you folks like it. the idea was to condense similar (commented) tests into two parameterized tests.
Since the litmus testcase says to use "Adblock Plus" I understand why it's in here.  Since Adblock Plus is developed by someone who does not work at Mozilla, we're trying to focus on using addons developed at Mozilla instead.  A couple of good choices for these tests would be MemChaser or Nightly Tester tools.
I'm really just saying that instead of the logic in development.rb checking for files under /var/www/stickshift/broker/config/environments/plugin-config/ it should check from a file that ships inside the plugin's gem dir.
yes but the RC_MODE command is defined in the airframe file, as well as the command laws, so there is nothing to break for normal quads right?
You got me confused with the SetAutoCommandsFromRC, it seems to be exactly the same as SetCommandsFromRC, so what would be the point of using that?
While `sys.exit(None)` does the right thing, for clarity this should return 0.
Should document the callback return values.
Yep, that's true today, but this may change in the future. I think it is better to be defensive and leave a note for future maintenance.
This call is pretty expensive. I guess it could be somehow fixed in the refactoring library, but if all one needs it the symbol at a given position, it would be way better to just use the compiler API directly, something like `compiler.askTypeTree(position)` and checking `tree.pos` for the returned tree.

`positionToSymbol` should be fixed as well, because the current behavior seems quadratic: for each symbol in the index it checks all its occurrences, and then for each occurrence does 'tree.exists(_.pos == position)`. `exists` does another *traversal* of `tree`! @misto, why not use `pos.contains` at the top level? Or even better, as seen above, `compiler.askTypeAt` for the given position, and then `tree.symbol` on the returned tree?
Oh weird, it didn’t display that way for me – must be a weird Windows formatting issue

Rohit Sethi
Vice President, Product Development
SD Elements

p:   +1 (888) 778-3330  x102
m:  +1 (732) 546-4473
t:    @rksethi

www.sdelements.com<http://sdelements.com/>

From: Ramanan Sivaranjan [mailto:notifications@github.com]
Sent: Wednesday, August 29, 2012 2:16 PM
To: sdelements/sde-lint
Cc: Sethi, Rohit
Subject: Re: [sde-lint] Rally integration (#21)


In jira_integration/tests/jira_plugin_test.py:

> @@ -1,6 +1,5 @@

> -# NOTE: Before running ensure that the options are set #properly in the

> -#       configuration file

> -

> +# NOTE: Before running ensure that the options are set properly in the

> +# configuration file

Again, 100% style, but I prefer indenting this line to line up with the line above. (I prefer how it was before.)

—
Reply to this email directly or view it on GitHub<https://github.com/sdelements/sde-lint/pull/21/files#r1488560>.
spaces between operators: `1 * TILESIZE` and please indent it similar to the comment i did above.
What is the specific exception that is raised?
I try many times of compilation without clang:: and failed, even the declaration of a variable of type CompoundStmt. I don't know exactly the reason it's, but I think there's a enum name with the same name at Parser::.
Вижу, вам больше по душе сначала объявить все переменные. Тогда хоть комментарии оставляйте, что и для чего вы будете использовать. Чтобы понятно было сразу.
Разве не в методе init должен вызываться родительский init?
вместо такого большого количества if..else гораздо более элегантно использовать оператор switch.

а еще непонятно почему для одной и тойже цели вы использовали разные подходы, в файле main.m
для выбора случайной буквы используется массив
```
NSArray *lettersArray = [NSArray arrayWithObjects:@"A",@"T",@"G",@"C", nil];
```
и выбор по рандомному индексу, почему?
Не думаю что есть смысл заменять 0%.
чтобы избежать подобного, могу посоветовать придумать и реализовать метод, который случайным образом возвращает одну из четырёх букв. Читаться будет легче, и ошибок будет так же меньше (у вас примерно одинаковый код здесь и в методе mutate, поменяете здесь, но забудете поменять там - получится некорректно)
@Senior-Student а, ну да. Условие выполнено, но алгоритм при этом не оптимален. А я ещё не понял, зачем снимать копию. =)
Nitpick: Is it possible to remove all blank spaces at end of lines ?

In order to keep the code as clean as possible.

Thx :)
BTW @dak180 : if you find a clean solution, for compiling only the native architecture when building Development, I would be more than happy !
Согласен, но тебе нужно было где-то запилить список статусов, которые ты хочешь использовать
Not necessary because the $ you use below is a function of Backbone.View class. You just need to require it if you use it globally.
Did you see the tests folder in the library with the phpunit tests?
Please add some text to the readme indicating that `:created` is treated as a "special" field and expects an instance of `Time`.
I use [this](https://github.com/kennethreitz/autoenv).
是的，错别字囧
This URL is hardcoded in `metashare/urls.py`, so I think there is no need to make it a setting here.
Cool, changing it now...
can we avoid a property and use an attribute set at init time?
is it like a new tstep? if so I would call it tstep
2012/10/11 Alexandre Gramfort <notifications@github.com>

> In mne/fiff/evoked.py:
>
> > @@ -314,6 +314,18 @@ def plot(self, picks=None, unit=True, show=True,
> >          plot_evoked(self, picks=picks, unit=unit, show=show,
> >                      ylim=ylim, proj=proj, xlim=xlim)
> >
> > +    def to_nitime(self, picks=None):
> > +        """ Export Evoded object to NiTime
> > +        """
> > +        from nitime import TimeSeries
> > +
> > +        if picks is None:
> > +            picks = np.arange(self.data.shape[0])
> > +
> > +        evoked_ts = TimeSeries(self.data[picks], sampling_rate=self.info['sfreq'])
>
> indeed it can only work with preloaded data (in RAM or memmap) If you want
> to be able to avoid inplace modification I find it
>
much more pythonic to introduce a .copy() method to Raw maybe in the future.
>

1+ that's what I was thinking a few times during the last days.


>  —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/142/files#r1819634>.
>
>
Could have sworn the scaffold had semicolons :)
You need to press ctrl+alt+f and ctrl+alt+o to organise imports to get rid of full name for classes
We need the concept and concept name, off the top of my head, this is useful for the reasons below:
1- When filling forms or on some pages devs want to set the name that matched the search so that it is what gets displayed when the concept is displayed later.
2- In form entry, users like to set the concept name that matched the query to be set as obs.valueCodeName, thhough me and jeremy have been advocating for adding a concept name search widget to stop users from doing this.
3-In the UI for the search widgets we like to display the matched name
Was this sub-module set to a version inconsistent with the other modules?
Please wait for this to be resolved.
you should use ``:phpclass:`SessionHandler` `` so that it links to the PHP doc
You can simplify the file with double colons as they will render PHP code blocks. It's fine when you don't need mixed PHP/XML/YML tabs.

```
in the container with::

    $container->hasParameter($name);

You can retrieve parameters set in the container with::

    $container->getParameter($name);

and set a parameter in the container with::
```
The gsub is fine with me, at least we check that it's a ";" this way
ok, your's are better.
HI Viktor,

Regarding this comment, I'm trying to determine which timeout value from the config would be most appropriate.  Any guidance would be appreciated.  Is there a timeout config param that is meant to control how long to wait for a response to an ask?  

Thanks,
John

On Feb 23, 2012, at 2:11 AM, viktorklang wrote:

>> +abstract private[amqp] class FaultTolerantChannelActor(
>> +  exchangeParameters: Option[ExchangeParameters], channelParameters: Option[ChannelParameters]) extends Actor {
>> +
>> +  protected[amqp] var channel: Option[Channel] = None
>> +
>> +  implicit val timeout = Timeout(5 seconds)
> 
> A bit too magic for me, what's it used for, why isn't it pulled from the config?
Не сойдет. Не читабельно же, ну.
Ну и нулевым элементом добавь UnknownServer, конечно же.
No tendría que estar toda la página dentro de `<div class="page">`?
(when (not (nil? x) ...) and (when x  ...) are equivalent, except when x == false.  in most cases that can be ignored, and this is probably one of those cases.
suggest using `test.host` in favor of `localhost:3000` since a server isn't running on port 3000 when running tests
Then we can't use it as a a generator anymore :(
Please don't use underscores in normal field names. The Java convention only allows them to be used in "constant" (final static) field names. To get around the problem of having a field and a parameter with the same name in the setter, qualify the field with "this.".
I think I'd rather calls this ```listDirs``` to distinguish it from the routine handling a single directory.
Thank you for holding. I can't dedupe this without handing the function to their mutual grandparent, who has no business owning the function.
much cleaner!!
Thinking more this is 100% wrong. We must modify RDL to have the tenant name in the context at this point, and pass that through.
Mere cosmetical changes, can we leave these out?
and _final_ :)
He didn't remove it, just moved it to a lower method. This reminds me that I probably should add a PHP 5.4 requirement to `composer.json`, though (as well as `ext-intl`).
Indeed, it works and it's more elegant. I rushed into trying to do the same as SwiftMailer (which use the constant thing because it calls a function).
why did you change the baseurl here? crash-stats.mozilla.org just make a redirect to crash-stats.mozilla.com
crash-stats.allizom.org is tha staging site & crash-stats.mozilla.com is the production site
because i got out of the habit =)
But you do use clip:true in the Flickable in ImageContainer? I don't understand.

Also, clipping the ImageContainer (or the whole page) seems better than all of these odd bindings.
this also should now be an APIProperty if no longer being set on the layer
TicketFilter
Is this right? Don't we want `(thrift/unpack forma-val)` instead?
@apex13 can we remove `groupdashboard` here & in all the other files?
I don't think we officially support Opera but it couldn't hurt to have it in there anyways.
This should go into a noscript CSS file
Applied to newest RC.
we don't need this comments in code i think.
pry should probably be in the 'development' section
Not quite right:
< txn/txn.c  133  Warning 550: Symbol 'session_cnt' (line 93) not accessed
< txn/txn.c  93  Info 830: Location cited in prior message
Indentation is wrong from here to the end of method.
Это нужно было бы вернуть назад, ато счас при каждом изменении кода нужно перезагружать сервер...
http://postimage.org/image/h5t9o6tzr/

Is the added ui there?
Yeah there is a regression with the string type. Have to track it down, but tomorrow :)
Are you sure the variable ``$buttons`` exists, or did you maybe mean ``$button``?
True. But does make it easier to read imo.
Ja tämä saman kuin `(filter (complement pred) a-seq)`.
```js
get: getOpacity,
set: setOpacity
```
should be able to handle it..
Should `afterClose` really be empty? Should we be setting `aria-hidden` to true and `tabindex` to -1?
Discusion en cola? maybe
To line them up properly. Excuse my perfectionism. :P
Can we settle on one? I'm happy to kill any code of mine if the end-result is a cleaner code base.
Define value of this in `piplmesh.urls.py` and then use it there and here.

Space before `:`.
Decide if you have first `class` and then `id` attribute or opposite. But not mix. ;-)
You can rename this to `check_online_users` (same as task), or something, no?
Split this into two functions.
Aha,  `trim` in this function only? I thought you mean general. Nevermind then.
Seems fine. There may be inconsistences with external plugins.
`as_text`? Is this really the best?
No, also version should be added. See the output of `pip freeze`.
Remove these lines if they aren't doing anything.
Объединить все в setParams(ZendRouteMatch $routeMatch, ZendRequestInterface $request)
are these always in all the responses? If not we should have some tests for those cases, probably shouldn't set the `avs_result` and `cvv_result` if they are not present
What does ```query``` do? Since it's not standard ActiveMerchant, some rdoc would be handy to explain what it's used for.
ohaaaa! bin rot/grün farbenbild... und auch +/- indifferent....
I removed this comment, as I realized it was in the ``Leaf``class and used in the ``Dendrogram`` class. I'd be fine changing to ``fill_footprint``.
no need to remove the definition. It is a private service so it will be removed during the optimization pass if not used by another service
I'm a little confused by this `execute` block here. Why do we have to explicitly try to start it? Shouldn't that be handled by the `service` block directly above?
> stopping/killing/crashing your application will get all data lost

stopping/killing/crashing your application will cause your data to be lost
I assume _entityQuorum_ is just an example of how such a method would look like, but is would be defined in a provider specific subclass, correct?
@brettweavnet will address this in an upcoming refactor
I don't see how that could be much shorter. Do you have something in mind?
Why lastIndexOf instead of indexOf?
not "libre"?
If you can't express an *or* in the filter, can't you just call `TISCreateInputSourceList` twice, once for `kTISTypeKeyboardLayout`s and once for `kTISTypeKeyboardInputMode`s. And then merge the two lists? I don't know if that's better than it is right now, but it might be worth a try.
this js's files are writen for me :P if you want you can min them :P
doesn't self.params have nans here? in that case it would require nan_dot
How about `direction = seconds < 0 ? :ago : :until`? It's shorter and a bit easier to read it that way.
I did it, but as you can see we end up having same "on_xmpp_loop_tick" method in TNArchipelHypervisor and TNArchipelVirtualMachine.
I would think so.  That's been bugging me when I've noticed it in a few of the files - I cannot imagine a scenario without them.
Sure.  That would be clearer.  I suppose I was leaving open the option of other composite types that might come along some day, but I don't have any idea what that might be.  :)
Done, tested, pushed.  BUT - this checkRadii function that you suggested modifying is not called for those SBProfiles that only take one type of radius specification - Sersic, Airy, Box, deVauc all still have defaults.  This is not good/consistent...
David has already commented on the content of this function, if `pad` needs to exist at all we should pull it out so that it doesn't get redefined everytime getISODateString is called, unless it needs to for some reason that is passing me by.
This code is getting complicated. I'm not sure how it could be easily simplified, and if the complexity is required...
Leaving as-is.
ok how about deleting it then.
You're right. Win32 is a completely different beast. The right solution is probably to move the real functions into the posix layer.
Well, the test was not previously recursing into directories and I decided that led to a very shallow test case. So I tweaked the test to be more thorough - and I removed my emacs backup file as well. :-) In retrospect, I probably should not have combined both changes into a single commit, but I hope we've at least ended up with the right outcome.
What is the use case for this? If you are using the Apache matcher, you always rely on `$_SERVER`.
according to the Ray's [github homepage](https://github.com/sebhtml/ray) the `PREFIX` has to set only for the first `make` call. Not for make install.
Mie sincer imi place mai mult cu if. Daca voi considerati ca vreti neaparat cu switch, facem schimbarea
author tag, and license header
agree, back to: https://www.chiliproject.org/issues/992
И здесь с исключением беда.
Перед threw тоже должен быть двойной отступ? Я думал, что имелось в виду перед at
Notice how the `World` object is now fairly ignorant of game-specific terms. It is up to the `Game` object to introduce those.
Maybe we should retry at least one time (in case of a timeout on OxonTime)?
I think this locator will catch even failed uploads by the ambiguity of the locator
Although this is a bit ugly it is an exmaple of catching only a successfully uploaded screenshot `div.preview div.preview-thumb[style^='background-image:url(https']`
iirc, the pep8 preference for one-line doc strings is to put the whole thing on one line.
I'm wondering is this a Chef bug, or a mistaken global search and replace in the cookbook?

Is the `@params` instance variable cast as symbol key only, or as symbol _and_ string keys both like node attributes?
In any case, I think info + error could be merged into something like:

```ruby
def info
  if options[:template_framework] && !is_framework?(options[:template_framework])
    say "SimpleForm doesn't support the framework: #{options[:template_framework]}"
  elsif !options[:template_framework]
    say "SimpleForm supports:"
    say "#{frameworks.join(', ')}"
    say 'to install a framework specifiy (--template_framework || -b) framework'
  end

  if options[:template_engine] && !is_engine?(options[:template_engine])
    say "SimpleForm doesn't support the engine: #{options[:template_engine]}"
  end
end
````

Or similar, you get the idea.
We can still use the `options.keys != [:wrap_with]` check here.
Renamed function, added slightly longer description to the doc strings. I hope this is OK now?
Unused variable. You should use a pyflakes plugin for your editor to detect these.
Do I understand this correctly: if a pair is passed, then ``value`` is put into position ``hash(feature_name)``.  Was that explained in the doc above and the narrative? Maybe you could make that more explicit.
This should be `NearestCentroid(metric=metric)` isn't it? I think all the other tests have the same issue.
Start with a capital letter, end with a full stop.
Jawohl :)
I think it would be good do have some sort of default. Usually there are no mandatory ``__init__`` parameters.
> A 'neural_network', or 'neural' module sounds really good.
>
> @ogrisel <https://github.com/ogrisel> Yes, Contractive Autoencoders 
> are to follow! :)
>
> @amueller <https://github.com/amueller> There's a nice paper this year 
> that makes MLPs much simpler to use, they show how to automatically 
> tune the learning rate (http://arxiv.org/pdf/1206.1106v1). That only 
> leaves the n_components hyper-parameter!
>
> —
>
I saw the paper but didn't try it out yet. Have you given it a try?
By the way, that look a lot like RPROP, which we often use
(but is a lot less heuristic).

Do you think that would also be interesting for the SGD module?
On Sun, May 06, 2012 at 09:11:01AM -0700, Alexandre Gramfort wrote:
> it seems more natural to have clf.named_steps['reduce_dim'] return the PCA instance. WDYT?

That was a bug of the docs
That is not really true. The full kernel matrix will be computed on the training set, right?
No I don't, but I need it internally. I'm iteration over the ever_active_set till no more kkt violations occur. I can throw after I have the right coefs, or keep it in case I want to use it for enet_path.
That's at least how I understand [0] p. 20
> So, you are saying that if n_targets==1 it is not important, but for
> n_targets big, it becomes important? If so, I think that a note on this in
> the docstrings would be useful.

done
I don't think the extra param is necessary; especially being public.

But this change is actually a mistake thinking about it now. I should be calling `initialize()` in the test. I'll update the test and revert this. Your call if you think a request property should be available. If you do, I'd recommend making it protected.
'parallel'
Another case why this loop is not correct:
button0:zIndex = 0;
button1:zIndex = 20;
button2:zIndex = 30;
button3:zIndex = 10;

now lets change button0:zIndex=15;
first it compares with button3.zIndex and because  15 > button3.zIndex, it inserts button0, and later on, it checks with button2 and button1 and does nothing,
final result would be button0 on top of all other buttons

(checked with js script)
This is not set anywhere (ie `setEnabled`) and we could probably just use `container_->getEnabled()` instead
Should both be `final`.
Why doing complicated things when it's as simple to compare against DateTime ?
Maybe special case in the condition below would be cleaner.
next.getClear() would be marginally more efficient.
Formatting (tabs?)
I know copied from existing code below, but these should probably at least cover https too?
Why specify `method="get"`? It's the default.
please rm
Which send/sent are you referring to?
There is a ``askConfirmation`` method that would fit perfectly for this instead
rebased and used the inherited removeDirectory method
Speaking about this, I'm wondering if we should implement bug 726487 and offer a way to group all addon's widget into the same group in order to implement such feature.
In any case, this page will always be usefull. It describe how to use a document inside of a widget.
This kind of hard-coded stuff makes me nervous about maintainablility. Who owns this servicebus namespace? Will it always be there?
Destrukturoinnin voi tehdä suoraan arvoista `rectangle` ja `point`:
~~~clojure
(let [[[x1 y1] [x2 y2]] rectangle
     [x3 y3] point]
  ...)
~~~
Yes I will be at work in 1 hour I will do extensive testing then.
On 20/11/2012 7:39 AM, "Manfred Moser" <notifications@github.com> wrote:

> In src/main/java/com/jayway/maven/plugins/android/AbstractAndroidMojo.java:
>
> > @@ -605,7 +605,12 @@ public void doWithDevice( final IDevice device ) throws MojoExecutionException
> >              {
> >                  try
> >                  {
> > -                    device.installPackage( apkFile.getAbsolutePath(), true );
> > +                    String result = device.installPackage( apkFile.getAbsolutePath(), true );
> > +                    if ( device != null )
>
> I updated this in master. Can you test it for me?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jayway/maven-android-plugin/pull/148/files#r2170756>.
>
>
ok, but now it not exit whis fatal error :)
not really but isn't called, I can comment :)
Sure. Should I just move it, or should I contact Pietro first?
I don't really see the point of defining these variables. Wouldn't the code be shorter and easier to read by just putting them in place?
Don't forget result can also be :skip.  Not sure how to assign colors here... how about
:fail = red
:skip = yellow
:pass = green
:queued = darkgray|purple
:running = lightgray|blue
"need", not "ned."  I probably did that.
What is this comment still here?  The property was removed right?
Take a look at how `deviationX` and `deviationY` are initialized. If you still think `dragStartX` and `dragStartY` are better names, then I will make the change.
まさしくそれが理由です。 > provisioning_profileやcodesign_certificate

ymlファイル作戦よさげですね。
ありがとうございます。
Upon further thought, I went ahead and changed the config to a required module.
Nvm. Re-read it, and it makes sense now :)
Dangit. That's a good point.
isKindOfClass: returns YES if the receiver is an instance of the specified class or an instance of any class that inherits from the specified class.
isMemberOfClass: returns YES if the receiver is an instance of the specified class.
isKindOfClass will return true for all of our View Proxies. isMemberOfClass will return true only for the basic TiUIViewProxy
Both of the TODOs apply to the same bug that is linked to 2 lines down.
why do you need to check for both separators here ? why not just 'sep' ?
Copying should be able to be sync.
This condition should be first since a possible returned value of `'foo'` is not `null` (passing the first condition) and this function would attempt to increment it (which would simply concatenate 1 to the end of `'foo'`). Flipping the order of the conditions would allow `'foo'` to throw an exception.
IMHO, placing both "Type" and "FQSEN" is redundant, since an FQSEN may also be a type.
this should be possible to do b/c autorequire returns an array
No, AA doesn't have 'clear' method. Then `object.clear` was called by UFCS here.
The called function is <a href="https://github.com/D-Programming-Language/druntime/blob/master/import/object.di#L573">this</a>, it gets the argument with ref, and set it to `T.init` - it's null if T is AA type.
Could you add yourself to AUTHORS? :)
They import optional libs which aren't there in our runtime environment. So if the bundle is handled, and the classes get scanned, nasty ClassNotFoundExceptions are printed out. I will add a comment
this method is pretty hard to read/understand. Can you please refactor it into further sub methods making clear what it all is about?
Just an indentation fix.
Nevermind. I traced through my changes and discovered I'd done this to accommodate a call to AuthorizableManager.findAuthorizable().isAdmin() (this logic was actually broken up over several statements). I've revised that code to check if the result of findAuthorizable() is a User object and will be reverting this refactoring of the isAdmin() method.
Comme noté plus bas, devrait être dans un autre projet
Can we use names for this?

{top : X, right: Y, bottom: Z, ...}
ah .. i see what you mean now .. yup that code messed up during refactoring. will have a look
make sure we've unit test for that
double to
sort here is a shortcut by me to to preserve sorting like standard resque - Its probably more correct for me to preserve ordering instead (as I did in resque-queue-priority), but shuffling is even more an the unexpected behavior for standard resque users
Can use the `top` variable here instead of re-calculating the position
currently the id is passed in on options.object, but we could do what you suggested and make them set it on id instead of object. You're probably right that using object doesn't make sense so I will fix that up
Actually, does that make sense? DEFAULT_EDITOR is still being used on https://github.com/secretrobotron/butter/blob/9046a38007e29a4f3ac11263128ee61da470b77c/src/editor/module.js#L46

Either way, once that's cleared up, SR+
yeah, i noticed that userExercise had conspicuously vanished up top and replaced with `Exercises` but hadn't investigated what that meant in hg country
It would be nice to have declarations for the ASCII functions too.
Shall let it slide then, but you better pinky-promise!
Are example apps being versioned, if so then the generated version.h need to be included and used in the main function of each example app.
You are logging updateDate, but using createDate - I think you need updateDate here.

Also, why are we updaing the other columns to their existing values? This SQL is only used here, so only need to update the date.
I think a Link on the first reference and then &lt;interfacename&gt; on the rest will suffice, One thing I don't like is the risk of Oracle deciding to move the javadocs.
"Canceled build has no reports to Gerrit." - I'm not sure if this is true. All canceled builds should be reported currently as "Failed" with the text "Aborted".
If the admin has configured the approve command with --force.
So I guess it is easier to just not mention it at all.

You should also add a warning that this is an experimental feature.
I am not talking about code structure, but code style.

For jQuery plugins, you can check [my plugin](https://bitbucket.org/mitar/jquery-visage). It is a nice example of how to make a very configurable jQuery plugin. (I believe.) If you will find any comments on code structure there, please advise me, because I am using it as a example for my later projects. (But it probably does not conform to above mentioned code style because it was done much earlier than that.)

Just skimming over the links above. I don't like the `_` prefixes, this is unnecessary in JavaScript as you can nicely hide variables with scopes. Also, I suggest you assign `this` to `self` at the beginning of object constructor in JavaScript and then use `self` everywhere, as jQuery like to override `this` with something else in different contexts so you will safe yourself a lot of trouble this way.
On 03/01/2012 01:46 PM, Diego Zamboni wrote:
>> +#           # you can use classes to restrict which nodes would
>> get this setting +#           am_db_node:: +#
>> "hosts[192.0.2.20]" +#                   string  =>
>> "clusterscan.mynet.com clusterscan", +#                   comment
>> => "DB nodes should get an entry for the db cluster so they
>> arent +#                               relying on DNS"; +# +# +#
>> methods: +#           "any" usebundle =>
>> etc_hosts_manage_all_entries("main.hosts"); +# +#    } + + +
>> vars: +        "ip" slist => getindices("$(config)");
> 
> I'm a bit concerned that the IP addresses are not being escaped,
> and in some pathological cases, this could lead to incorrect lines
> being modified or removed. The following could be used:
> 
> vars: "ips" slist => { "1.2.3.4", "5.6.7.8" }; "esc_ips[$(ips)]"
> string => escape($(ips));
> 
> You could then use "$(esc_ips[$(ip)])" instead of "$(ip)" in the
> regex line #81, and modify
> etc_hosts_manage_all_entries_delete_nonmanaged() to take "esc_ips"
> instead, and create the regex using the escaped versions of the
> IPs.
> 
> What do you think?

Oh thats seems like a great idea, its something i was worried about
too but I hadnt been able to come up with the right pathological test
case to break it :) and i didnt know about the escape() function!

I'll look into making the suggested changes.

-- 
Nick Anderson <nick@cmdln.org>