labofsahil/github-event-dataset-2012 huggingface dataset:
I see where you’re coming from with including it.  As to good or bad—my primary concern is that it could cause unwanted side effects by triggering an event handler I didn’t mean to trigger.

Does the current implementation of the event emitter support namespaced events? If so, then would the second emit be covered automatically by the namespaced event and the user could have a chance to filter out the event based on that? Otherwise, this might cause unwanted side effects which would be trickier to overcome than just letting the user emit both events in their code.
It might be good if there's a BIG LOUD COMMENT saying that this is a temporary hack/workaround.
И ещё раз - в этом проекте принят определенный code style. Я не стал его опписывать явно, потому что кода вполне достаточно чтобы в нем разобараться. И писать код в одном стиле - очень критично, иначе все превратится в кашу
I would suggest using the package name 'org.opencv.android' and removing the "OpenCv" prefix from classes names.
Old name survived
Yeah - just use something like `numpy.ascontiguousarray` before computing the CRC.
已增加
Add assert that, if output is discrete, new_output_grads is 0 (if it has a dtype).
Can you add some documentation in ``Scan.__init__``'s docstring to tell what ``typeConstructor`` is? (btw that doctstrings mentions a parameter ``properties`` that does not exist).
drop m_hasFixedParams? It's only used in an assert in getExtractedParameters which is only ever called directly after returning from this function that set it.

Actually, the end-purpose of this call is always to populate a ParameterSet. If that ParameterSet were passed into this function and we took care of calling setParameters, here, the caller would never have to ask for or see the intermediate Object[] "result" and it would not have to be a data member  -- it could just be a local temp that got serialized into the ParameterSet.
cleans up error handing logic to exit immediately if possible
Don't use \
Yes, this is an artifact of how I've been using the capability.
already added a check for that though. massify() normalizes.
Should this be done as part of running the tests instead of doing it as side effect of import. I am wondering if somebody could import the django.test.simple without running tests.
Shouldn't this be called a TextWidget?
I like the idea to have the same distribution mechanism for the hazard and the risk part.

However, we miss a general "distribute" utility function that takes in input a "concurrent_tasks" parameter.
I think it should be addressed sooner or later.

For the sake of simplicity I have started implementing a simple distribution strategy that splits the work in a fixed amount of tasks.
Therefore, I am using the openquake.utils.tasks.distribute function.

At this stage, we are happy with the performance you can get by simply tuning this parameter. It could be set to the number of celery workers for maximum performance and it can be reduced if memory capacity is a concern.
what is the purpose of this
Performance of a last-ditch failure is not important. Using `stderr` would also introduce otherwise unnecessary dependencies on the buffered IO implementation. You could make it atomic by doing `printTo(stderrRawFile(), str("unhandled exception: ", etc));`, thereby buffering to a thread-local String.
Instead of creating two points where the `value` is determined, just modify the above statement:

```js
value = jQuery.isFunction( value ) ? value() : ( value == null ? "" : value );

```

this matches both `null` and `undefined` and means no changes to line 776
woops, didn't see your reply
Requiring the first character of the match to be non-whitespace eliminates the need for `.replace( rstartWithWhitespace, "" )` on [L0L965](#L0L965).
The main reason is that we think all of the functions in the dt.sql, dt_preproc.sql and dt_utility.sql are used internally (the function's name starts with __). Thanks.
On 32-bit builds, the binary will be plain `mame`, rather than `mame64`. Same for mess.
Couldn't you read the current version from the `package.json` file? I'd like to keep version management into one single place of possible :)
I'm not entirely happy with how `sent` currently is implemented as part of `add_outbound_message_key()` but don't see any better way atm either. It is useful enough to keep around until we think of / find a cleaner solution.
This should use the ```--match``` feature instead of JSON.
Current it's not necessary.
Isn't `empty?` supposed to return true if an array has 0 items ?
I'm not 100% sure but I think it does.
This should be: "Don't use filenames that use 4 GB of RAM."   ;-)
Nice comment. At Square we're very nitpicky: all comments are sentences with a Capital Letter and a period. So this would be "Let runtime exceptions through." . . . it's a picky thing.
The indentation should be two TABs as for most of the file.
This comment is much simpler and conveys the message. I have incorporated the changes in all the classes.
What was wrong with `constructor`? I prefer that to `klass`
No, the Chunk weak reference is allowed to contain null. It would then get the chunk from the world when getChunk is called.
Nice to name this childrenStore
I understand. I'm just trying to help you making this bonus feature better. I will try to find the potential issue with these characters later in Brackets.
Actually, I'm not seeing any recent changes to PopUpManager.
I think the idea with storing _enabled on the command is that we shouldn't need to re-run the function here.  If the command impl is listening for the right change conditions and pushing updates to the enabled state whenever it hears about such changes, I think checking _enabled should be enough here.  And actually, if that's all true I'm not sure Command needs to keep track of _isEnabledFn at all.

Or did we decide to punt on "push" enablement and only check when menus are shown, for now?  (That would have to change if we add toolbars or async native menus, but we don't have either of those yet).
May need to return the x,y coords in case context menu gets displayed in some place other then the x,y coords that were passed in, but I'm not sure if that's of any value to the caller.
True, but then `setAutomatic` would have to call `_addListeners` and `_addListeners` will have a call to `setAutomatic`, that in practice shouldn't be a circular problem, but JSLint gives errors about it. A solution would have `enableAutomatic` and `disableAutomatic` as private functions (and maybe a third one to avoid code repetition) and `setAutomatic` as the public API that uses the other 2.
The root name property is the product name, e.g. Corp™ Brackets and is only used in the about box
Why timeout with 100? And why the next one with 200? setTimeout with a constant value tends to be a code smell; is there a possible timing issue here?
`strerror()` is much more convenient and probably safe in a function called infrequently as this and typically from an initialization context
typo? (looks like it was already wrong but is still wrong)
this feels too coupled with the underlying implementation of @memoized. should make more exlicit
should this column be 'dataLocation' or 'data_location' or whatever?
Right pointing arrow.
Kiepska nazwa na funkcję, może: createServer ?
Please add javadoc ;-)
Move name of the MongoDB database to the setting variable.
`f` is before `t` in the alphabet. ;-)
Also this function is then unnecessary, no?
these two declarations can be done on lines 4 and 5
Here, I use `concat` because I don't have to think about what to do with each item -- I just want all of them. When I need to inspect each one, I use `push` because I'm likely in some sort of decision-making loop over a collection of items.
#2045 reduces this function to two lines.

a duration set, and an initital call to set the left and width of the viewport.

_duration = e.target.duration;
resetViewport();
I don't understand the need for this.  If you're already including jquery above, why document.write it as well?
This was a test. You passed!
%i -> %ui
I wish. GHC complains.
This model update looks a lot like the 4 lines following (492-495). Is there something I'm missing?
This doesn't look like it's supposed to be part of this changeset--the type isn't used elsewhere in these patches.
I realize this was already merged but by changing this to look for a specific exception, will this degrade gracefully in the event of some other error?  Such as if the Candlepin service was down.
more like trolling the code
Because if the title is being displayed instead of the URL, there's nothing to compare to.

I agree it's a bit fragile because you have to remember to update the boolean, but the only alternative I thought of was to set the image as a background image, have a CSS class to make the go button a refresh button and then test for the presence of the class to determine behaviour, but storing state as CSS classes seemed wrong?
Looks like a small change.
Probably on something already not working really well on a 320px width screen...

But I'll let @timdream have the final word on this :)
So I've changed this to now be ``enable_color`` and ``disable_color``, in line with the other methods of the class. This is because ``set_color`` sounds like it would take a color as an argument.
What is this? Why is it part of this pull request?
There IS really no consistency in the source code, some us it, some not ... what's the coding standard? I'm fine with leaving out using namespace boost, but then this should be changed globally. Or can you explain it to me?
And once more we have HTML :D.
We have a SLOT and SIGNAL, which handles the unit, why should we not use this? It's used in the other 2 files, too. I really like the ?: operator and disagree here. Can we find a consensus which leads to similar solutions for all 3 files edited in this pull :)?
Do we really want to increment a full major version...not that it matters, but it seems excessive...
Ah, its used for importing URIs, not exporting, sorry...I still dont like the idea of a constants header, but I suppose for MAX_URI_LENGTH it makes some sense.
NotFoundException would be more accurate
I would prefer doing `echo $this->element('foo', array(), array('ignoreMissing' => true));`
than `if ($this->elementExists('foo') {echo $this->element('foo');}`.
It avoids running `View::_getElementFilename()` twice when element actually exists, which would be in most of the cases.
The problem is some heavy ajax and a page refresh on the logout event. The test that was affected was test_change_password in BrowserID-tests and verify it against Chrome, it suffered a bit more than Firefox. Here's a Jenkins trace: http://qa-selenium.mv.mozilla.com:8080/job/browserid.dev.123done.windows.7.chrome/183/testReport/tests.test_change_password/TestChangePassword/test_can_change_user_password/
Please remove the leading underscore.

and properties should be declared before methods
@moneycat a0bcdcecab24c405c03b141e07d40cc99841ca12

It is already handled by gui.common.__init__.py
"the" instead of "this"
Well, it's true that I can put it at class top level, but I don't see why `'jpeg' in _supported_format` can be not defined. and Bool traits would be overkill no ?
This cleanup should be done as early as possible to prevent that some exception stops execution and we leave the junk behind.  So I'd suggest doing the deletion immediately after images have been published above.
pep-8 here and there above.
sure, is there a style guide somewhere that the team is following?
I think this comment is no longer applicable.
I think there's Functions.identityfunction, right?
https://github.com/kaltura/mwEmbed/commit/df3a0a7886e0ad7617bb5d653085ae79edcf4719#L2L216
`head = NULL` in case the creation of the symbolic ref fails and we jump to `cleanup` where we try to free it again.
Harald, could you please remove these "Added by..." comments again? We can see that you added the code in the commit log, and I would prefer to keep the code free of this kind of "clutter".
I should have left a comment here. So in this case the true value of `dude_says` isn't a unicode string, but a mock. When calling `unicode(dude_says)` it throws an exception about expecting a unicode object and getting a Mock. That exception is thrown by the `unicode` function itself when it tries to coerce whatever value it gets from calling `obj.__unicode__()`. Calling it this way doesn't throw the exception.
There's a space in the alt tag
You could probably do the `<a href...> ... </a>` all on one line.
nope.  removed.
I'm assuming the reason for this whole block is because you can't do:

```python
if cursor.execute('select 1 from reports ewhere uuid=%s'%uuid).fetch():
    cursor.execute('UPDATE reports ....
else:
    cursor.execute('INSERT INTO ...
```

Is that right? Is that because you can't wrap it in a transaction due to the threading?

If that is the case, I think you should add a verbosish comment to explain it. You know, for future reference when the next guy in several months (might be you) says "why can't this be done in a simpler way?"
the long full path is too many characters for the short field in postgres.  We're losing messages due to truncation.  if you want to verify that the proper MDSW is running, it's in the log of the config at the beginning of the run.  Finally, it's been suggested that since this data is publicly visible, we ought not advertise pathnames  to components.
Ah ha! This is where the execute command gets the `databaseName` set.
Indentation problem in markdown rendering.
Christian,

It's still there - you might need to just re-submit after removing the PR.

Adam
I would go with params instead of extra_params. Also always use CamelCase.

And you can use $options = array(), $params = array(), like this you don't need the additional if (is_array( check as it will not enter the foreach as long as the arrays are empty.
This is wrong. You can have a scalar prototype, not only an array prototype
indeed you are right .. i hear @kimhemsoe is working on UPSERT abstraction for the Doctrine DBAL, so it might be in the summer release.
until then i guess all we can sensibly do is add a switch statement and hardcode handling for different RDBMS.

for sqlite we can use REPLACE INTO, for postgresql (and maybe also DB2) MERGE etc.
but i think its ok to add these later on a need basis rather than burden this PR with supporting all RDBMS
This is wrong. It can also be a single bundle, not only an array
Missing empty line between the params and the return. And ``Boolean`` should be written with a capital letter
@fabpot Any preference in this? The patch works fine without the `::create()`, but I can add and implement `::create()` too.
Good catch! What to do? Removing the test or duplicating the one from 2.1 into 2.0?
Please keep the short class name (and add the use statement if it is missing).

And it should mention the ``SecurityContextInterface`` instead.

And it should be ``|null``, not ``|void``.
Btw, the logic in ``execute`` does not seem to consider it as an optional argument
I see. Would be nice to explain this in the Phpdoc as it helps to understand the difference.
失敗の検証はこっちのほうがいいと思います
+1
In general I would say to avoid using server-side prepared statements at all. Even if they are perfectly monitored, they are still in very many cases generating 3 round trips (prepare, execute, close) when 1 would suffice (query). In most of our apps that we care about, there would be huge numbers of prepared statements in order to pre-prepare them all (as table name is not an allowed placeholder, and they are mostly sharded into N tables); so the round trip multiplication can't be avoided by pre-preparing all possible statements.

So since a good client-side prepared statement handler is necessary, may as well use it everywhere, even when it's not strictly needed.
Agreed. I visited the idea of having this just wrap a netty ChannelBuffer, but I remember running into a lot of issues. It could have been my lack of experience of working with netty Buffers / nio Buffers.
we shouldn't hard-code the `<%` `%>` delimiters since devs can change them to `{{}}` etc
I don't think we can completely remove this method because of first login. When a person first decides to let us access their Yammer account if I follow the code correctly this is how we save their access tokens on their User model.
"I don't always accidentally attribute copyright to the wrong person, but when I do, it's to Atari™"
CColormap ?
Please, instead of declaring each command argument as a new command, use an if statement with a single declaration.

For example:

 /command [$arg] = >>>
if(equals_ic($arg,potato),die('potatoes are yum'))
if(equals_ic($arg,tomato),die('tomatoes are yuck'))
die(concat('I have never heard of',$arg))

Personal thing really, I could change it for you if you like...
Much cleaner; I like.
if I understand it correctly, consult won't care.  But, in the interest of making it more human-readable, it should be possible to output the string to a buffer then strip out the spaces, if you'd prefer that.
also I think we'd prefer this int declared at the start of the function
Наверное с фабрикой удобнее было бы
This method isn't defined anymore (because of the ``return`` a couple of lines above), but still references in some places which breaks the admin
urlParts => params?
:-)..thanks, i was struggling for a better word
added a tool tip to most gravatars telling the user that they can click on them to see the user's page
A mon avis tu as un bug là :-) Tu peux corriger?
I think it should work, but now I need to remember why I did that. Looking at it here it doesn't look like it should be there at all.
This should be getDeprecationData() (and the @return changed)
Is this operation meant to be used by external callers, or is it just for internal use from ConfigAdminServiceImpl? If it's internal only, OperationEntry.EntryType.PRIVATE should be passed to registerOperationHandler, and the operation won't appear in :read-resource-description, etc.

If possible, we shouldn't make changes to the public management API in the 7.1 branch.
I think that this change should not include this commit.
OK, I have several objections to this:
1) Why does the monitor have anything to do with cross-validation?
2) Assuming you do need to use the monitor for cross-validation, why does it need to be reset?
3) Assuming the monitor does need to be reset, why clear out a perfectly good monitor containing useful data? Why not just make a new monitor for the new stage of the experiment?
4) Assuming this method does need to exist, the comment explaining it should be more universal than just however you're using it for cross-validation right now.
this doesn't cause test failures? Is requestWakeLock available in FF?
type there
You are right \O/
btw, we could use `dataConnection-*` rather than `data-connect-*` for consistency.
I feel the distinction is pretty obvious, implied by the wallpaper being notoriously veiled and the fact that the app grid slides *over* the wallpaper. Think of being able to edit the wallpaper from the Launchpad on Mac.
Not useful for many purposes but critical when trying to determine the url of an app (without launching).
My rational for adding it is we need to reload the system app and the best way to do that (I believe) is to get the url of the system app then go there.
You can see an example of that in the notifications test which has been updated.
I used 1 and 3? in my PR for purpose.
Because the spec is, this banner belongs to homescreen only.
Same here, I’d probably prefer to add this to the existing `js/storage.js` file instead of creating a new one, but I’ll let you be the judge on that.
It seems duplicated in fb_contacts.js, fb_data.js and here.
okay, then why we need this function here?
Hmm, what do you mean by *“markup independent icons”?
Also `(bitStr.substr(i, 1) == '1')`
separate in a isolated function
repreSenting
This is the pattern I typically use. The reused pid case should be extremely unlikely. It'd have to be a long running process to really cause problems.
This will be satisfied even if a != b, but d(a, b) = 0.

Maybe: if (a == b) beCloseTo else !beCloseTo?
I see, it was just moved!
How does this even work? `place_error_app` right now takes 2 arguments and you're calling it with only one. Add in tests to each method that calls `place_error_app` to avoid extra time in QA tracking these kinds of problems down.
Like before, returning false doesn't tell the user (or future version of you who has to debug this) why stopping an app didn't work. Return a JSON'ed hash containing whether or not the call succeeded, and the reason why it failed (in that scenario).
Yes (and not even the double bang is required): `return (hd.isVariable(proxy) && proxy.unwrap().translateTo);`
This option seems not to be used anywhere, can we remove it?
TIL `form` is the supertype of anything that is writeable. hard drive? that's a form. memory? that's a form.
Why would this happen? (Would this happen on GAE?)
t needs a better name
Yes, it should be a simple template interpolation. But I couldn't get Ember to create an element (<h1>, <h2>) on the fly.
This file is the generated doc. The original coffeescript is in coffeescript/view/layout/section.coffee
Sounds good -- changes pushed.
Should try to eliminate whitespace changes to avoid merge issues with CM master (since we're so far off now :( )
Ampersands should be escaped in HTML and because I'm writing the HTML out by hand rather than using a link helper I need to do it manually.
So I think this is causing issues on my installation -- we don't have a fallback profile set in global_config.ini, and an empty-string profile is not currently rejected by Cobbler, but will cause sync's to fail.

So on the repair path, install_host is getting a profile of '' and passing it through, which doesn't match None so we don't query to get the current one.

Perhaps simplest fix is in install_host to also check if profile is the string (in addition to None)?
There is already a removeDirectory method that can be used for this purpose, and there should probably be one added for copy/cp abstraction if we want to do this. The problem though is that if the rename() fails, most likely the copy+delete will fail too, leaving garbage in the temp dir. I'd like to find a better solution for this, maybe if we catch the Access denied error and usleep(100) or something then retry it'd work? Assuming it is due to the windows search indexer or something along those lines.
I'm testing the following. I'll have to check fail2ban.log later to see if it works.

actioncheck = import random; rulenum = random.randint(10000,12000)
I don't get what this line is doing.
I wasn't involved in the tab's review, but I found `getTabType` very misleading. It seems to indicate the type of the tab itself (like, for instance, if it's a "app tab") instead of the type of the content, that also is commonly used as `contentType`. So, if there is no any particular reason to have this name, I would change it in `getTabContentType`.
Please add comments describing arguments, it's far from obvious in this case.
ok, updated the test to match, should be green now
I'm particularly interested in whether these following lines are the right approach, or whether there's some way we can push better constraints down into the datasource table to avoid even the possibility of these error conditions.
It was commented out as part of my big refactor for #7749, and this is part of the reason that things are broken (and the reason that ticket #13948 was filed).  So yes, it changes behavior--because the behavior was broken :)
This change is a great service to humanity.
I don't quite get this: With the new implementation, it is not possible that files are stored more than one time, is it?

If we still need that piece of code: Why don't you just read all values, uniquify them (``mylist = list(set(mylist))``) and fill the rest with empty strings?
I'd rather have a function in the recent file handler that returns the most recently used file's name.
Hi, thanks for comments.

About the second comment, I added more explanation.

For background, I originally wanted to lock the thread object at Thread#setup as `@lock` was initialized as a new Channel instance previously.

I couldn't do that because it seems that I can't do `Rubinius.lock(self)` in a thread and do `Rubinius.unlock(self)` in another thread. So I moved the lock of the thread object to `Thread::in_new_thread()` from `Thread#setup`. And, I made the parent thread wait for the child thread to lock the thread object by this lock/unlock pair of init_lock_.
Sorry about the confusion on existing style. I let a lot of crappy specs got committed and I'm doing my best not to allow that again while cleaning things up. I appreciate you fixing style issues in your commits.

Yes, we should be as explicit as possible about the version behaviors. If there is a behavioral difference between 1.9 and 2.0, we should capture that in a spec.
We actually don't need both deletes.  Deleting by the riak key is a superset of deleting by doc id.  Let's get rid of the first delete call.
We could do something like this:

```less
# variables.less
@modalBorder:         rgba(0,0,0,.3);
@modelBoxShadowColor: @modalBorder;
```
This doesn't appear to fix things -- the condition is tries <= retries, which will still be true if you set tries = retries. 

In fact, I'd recommend a 2nd boolean variable to make this more explicit: 

boolean success = false;
while (!success && tries <= tries) {
  try { 
     ....
     success = true;
   } 
}
If there's a failure in setting up one interface, the subsequent ones will be skipped because of boolean short-circuiting. Did you really intend that?
Same problems described from the other helper
Any specific reason to add the '.' ?
Using / ensures the user gets to the root, if they were in a subfolder (not that BPN has subfolders yet, since member files are just called member_)
It needs to be re-written with API in mind.
Per review: Add space inside parens.

Eg:
`if ( !html ) {`
Well, I see what you're saying, now without the configuration it breaks
outside the vm.

This way is more in line with other apps on the platform, so there is less
ambiguity switching projects, where in the development vm uses the local
static version.

sent from my sg2
On 13 Dec 2012 15:35, "Matthew Ford" <matt@bitzesty.com> wrote:

> You'll need to specify the preview url as an environment variable, thinks
> it's better that it works by default in the vm and you configure it outside
> (not the other way round) but this is up for discussion.
>
> sent from my sg2
> On 13 Dec 2012 15:29, "Chris Parsons" <notifications@github.com> wrote:
>
>> In config/environments/development.rb:
>>
>> > @@ -28,7 +28,7 @@
>> >    # Expands the lines which load the assets
>> >    config.assets.debug = true
>> >
>> > -  config.slimmer.asset_host = ENV["STATIC_DEV"] || "https://static.preview.alphagov.co.uk"
>> > +  config.slimmer.asset_host = ENV["STATIC_DEV"] || "http://static.dev.gov.uk"
>>
>> Not sure I understand this correctly, but won't this break the app in
>> development outside of a VM?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/alphagov/whitehall/pull/98/files#r2407585>.
>>
>>
>
Or `"psr-0": { "Doctrine": "lib/" }`
Slightly more clear: `Vote.create(:user_id => user.id, :votable => self, :direction => direction)`
escalus_users:get_jid
Is resetting the injected settings everytime really required ?
I Think we should add a `legacy_simple_mappings_spec`, where we put everything we want to be backwards compatible.
fixed

On Tue, 2012-10-23 at 05:54 -0700, Andy Georges wrote:
> In README.md:
> 
> > \ No newline at end of file
> > +- __startlogdaemon.py__ : Script that will start the logdaemon for  you and set environment variables for fancylogger.
> > +
> > +# License
> > +VSC-tools is made available under the GNU General Public License (GPL) version 2.
> > +
> > +# Acknowledgements
> > +EasyBuild was created with support of [Ghent University](http://www.ugent.be/en),
> 
> This is about VSC-tools, NOT EasyBuild.
> 
> —
> Reply to this email directly or view it on GitHub. 
> 
>
Yes, that's the entire point: a_warning, b_warning, c_critical, and let the object represent itself.
http://symfony.com/doc/current/cookbook/bundles/best_practices.html#controllers
I would prefer we stick to the index.html based redirect, in order to be consistent across all quickstarts
Yes, the URL scheme is entirely left to the application designer. That being said, most REST APIs - e.g. Twitter to some extent, Netflix, JIRA tend to follow the convention above (HATEOAS  aside, this makes REST operations predictable - which becomes a benefit when trying to integrate with JavaScript libraries which follow the same convention for example). In summary, the scheme is not wrong, but not typical for a RESTful API either.
This was a debug I forgot to pull out. I wonder if it's worth even having?
A 4-space indent without a double-colon is just a block quote. If the paragraph above doesn't logically end with a colon, you can do:

```
site and fix it.

::

    $ git checkout -b 
```
Then how about instead of overiding the save method we create our own clean_ircname function:

```python
def clean_ircname(self):
    if self.cleaned_data['username']:
        return self.cleaned_data['username']

    ...
```
The `user()` modelmaker creates first and last names if they aren't specified.
Shouldn't this be display = "block"; ?
The success message should be updated for clarity.
You tell me. Which attributes are snippet-only and which  template-only?
This type parameter does not help anything, why not take a `Map[String, Any]`?
Right. The we can remove "I should see .... " from the above regular expression and keep the rest.??
may rewrite without else:

if (lockAcquired) return true;
if (!wait) { release(); return false; }
the same here ($tab_selected_text_color)
It might make sense to make this closer to the actual vagrant config file:

```json
{                                                                                  
  "vagrant": {                                                                     
    "vm": {                                                                        
      "forward_port": {                                                            
        "12345": "54321"                                                           
      },                                                                           
      "network": {                                                                 
        "bridged": true,                                                           
        "hostonly": "12.34.56.78"                                                  
      }                                                                            
    }                                                                              
}
```
heredocs are a good choice:

<<MSG
Submit ... value

The avail... notequal
MSG
http://www.jb51.net/article/24740.htm
　　2.在class前使用tag(标签名)

　　在jQuery中第二快的选择器是tag(标签)选择器( 比如：$("head") )。跟ID选择器累时，因为它来自原生的getElementsByTagName()方法。
Already set a few lines above
зачем пользователю это изменять?
Replace that line with `status code`.
nope I think this is a old issue and this is a AMO design problem... Even as a user it's sometimes strange to push the right thing.
will that comment be merged?
does the unregistration response have acl_settings included?  That seems like something that would only come in response to the registration.
No, I mean, it *should* be slower. When you run a rake task from code it's faster than when you shell out and run it. Is there a bug with the current approach?
No those are the sort direction at query-time. The code above is specifying the value on which to sort.

e.g., My user search could sort on the user Display Names. Then when I perform a search, I specify the sort param to be `asc` or `desc` (via `SearchUtil.getSortParam`). The search then automatically sorts by the value of the sort field.

In this case, the value I want in sort also happens to be the value I have in `general` (sort first by the name of the content, then the description). So I assign it the same value.
Hmm, 1 second seems like a lot. This shouldn't take more than a few milliseconds should it?
My page was stale when I made this comment. Below, where you access context.user().id is where the error would occur, I think.
The default can be the username.
Fixed. I recommend having a closer look at those changes as it was a little bigger than just moving this to a validator check. I consolidated some of the other loginId error checking as well, and added a new method to the oae-util validator.
No, this can't happen, because actors are single-threaded.
Sine I'm not sure, I'll just ask: has this been consolidated?
Subtle difference, but looks better :)
I think you should add:
```php
// This API does not support IPv6
if (filter_var($address, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
    throw new UnsupportedException('The DataScienceToolkitProvider does not support IPv6 addresses.');
}
```

And update test.
we have to store the map of identifier to functions in the context
Даже если не обходиться свойством, хотелось бы, чтобы вы усвоили "Objective-C"-way насчёт сеттеров и геттеров. Это даже было рассмотрено в лекции, если не ошибаюсь. Сеттер обычно называют как setПеременная (именно так, переменную с большой буквы), а геттер - аналогично названию получаемой переменной.

Например, в классе есть массив NSArray *arr, тогда сеттер для него лучше обозвать как `-(void)setArr:(NSArray*)`, а геттер - `-(NSArray *)arr;`
self = [super init];
if(self) {...}
обычно записывают короче:
if (self = [super init]) {...}
хотя это дело вкуса
Можно-можно. Даже извне можно, чтобы не городить что-то вроде

`[[myCell DNA] objectAtIndex:i]`

Можно написать просто 
`[myCell DNA][i]` или даже `myCell.DNA[i]`

Но переусердствовать не стоит, мы изучаем Objective-C, который имеет свой синтаксис и свою идеологию обращения к объектам.
Не верно. Х - это процент от общего числа ячеек, что нужно поменять.
Спасибо, так и есть - узнал о том, что изменение обязательно, только прочитав обсуждение вчера.

On 06.11.2012, at 9:44, zhorkov023 wrote:

> In osx-project-1/main.m:
> 
> > +        return;
> > +    }
> > +    [self doMutate:percent];
> > +}
> > +
> > +- (void)doMutate:(int)percent {
> > +    NSAssert(percent > 0 && percent < 100, @"Percent should be between 0 and 100 (exclusive)");
> > +    NSMutableArray *notMutated = [NSMutableArray arrayWithCapacity:100];
> > +    for (NSUInteger i = 0; i < 100; i++) {
> > +        [notMutated insertObject:[NSString stringWithFormat:@"%ld", i] atIndex:i];
> > +    }
> > +    NSString *randBase;
> > +    NSUInteger randIndex;
> > +    for (NSUInteger i = 0; i < percent; i++) {
> > +        randIndex = [self getRandIndexFromNotMutated:notMutated];
> > +        randBase = [self getRandomNucleoBase];
> 
> Тут в 25% будет ситауция когда случайным образом выпадет тот же символ днк что и был перед мутацией. Таким образом мутация не произойдет
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Советую вам переопределить геттер, иначе принцип инкапсуляции тут не будет работать.
index будет разным потому что далее делаю [indexes removeObjectAtIndex:rnd];
И генератор вернет одно и то же число, то индекс будет уже другим.
I think you mean `before :each do` here.   This block isn't being run, and the test is failing.
Also, it's the cookie format version, not the protocol version.
You're not verifying what you say you are here.  This step should actually full include the ability to actually register.  This is yet another reason to have actual methods that you can call such as sign_up.  Just move these steps into those methods.
ah I was wondering about that, was confused by the indentation
This explicit `RACSubscriber` seems unnecessary. We can just use `subscribeNext:error:completed:` here.
I would remove these empty helper specs.
I think ICA should remember if it was last fit to Raw, Epochs, etc. Like that you won't be able to fit it to Epochs and then try to reconstruct a Raw object
please assign the value of ```filter.toUpperCase()``` to a variable and use it in both statements
We have to call `pluralize` and `camelize` on `options[:extension]` because otherwise it just uses the string that has been passed in. For example `--extension events` will result in code like this:

```ruby
module Refinery
  module events # <----
    class Blabla
    end
  end
end
```
Change this line to something like:

    // fill this with an array of 'users.yml' file paths
    $yamlUserFiles = ...;
Please don't use the `s:silentcompile` variable, since the `g:SingleCompile_showquickfixiferror` would not take effect if it is set during a vim session.
I think you can probably just do this on the model directly, i.e. `SecureReader.mass_assignment_sanitizer = ...`
Thanks; fixed it.
I am confused. where do you see it passed in the **kw ?
Two things:

1) It looks like my updates to system.clj function names has not yet been merged to master?
2) How does the (if) statement actually work here?  Doesn't the else clause have to contain a (do) statement?  Otherwise, doesn't it just return a list of S-expressions?  Or am I just being stupid and missing something that should be obvious?
I'd really like to be able to specify aperture dimensions in arcseconds or arcminutes. Specifying it only in pixels places a burden on the user to look up the pixel size.
No, it only sets the default. The real custom theme is chosen through a selection dialog by the user.
The double quotes look like a bug?!
I apparently didn't change it in this one (I run a different repo for all my live cookbooks), but yes, it says "service" not "server"
I thought the value of my contributions was judged by LOC.
Done and more
The activation happens on removal by returning the previous value, which might, or might not come from the cache store. The problem is that at the data container level, I've got no idea whether this is the case or not. That's where the activation count increase comes from. Such information is only available at the interceptor level.

The problem of all of this is that the activation/passivation logic is split between interceptors and data container. Clearly, keeping the logic in the interceptor didn't work since it opened consistency gaps. At the data container level, I'm missing a lot of information of about the operation (i.e. flag information, executed command, context...etc)

Btw, I haven't added this code for the fun of it, but rather to carry on being consistent with how ActivationInterceptor was working. If you look at the current [ActivationInterceptor](https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/interceptors/ActivationInterceptor.java), the removal increments the activation counter. Without this code existing unit tests will fail.

To sum up, I've gone for the approach that allowed us to cover the edge cases without changing the way passivation/activation counters are updated. TBH, we've never sat down and wrote down exactly how the activation/passivation should really work. We probably inherited it from the JBoss Cache days.

At one point we should find a better way to deal with passivation/activation wo/ this split of logic, but that's probably gonna require some decent refactoring, which I wanted to avoid right now.

If you have any other ideas, I'm all ears :)
looks like the best precision we can get is milliseconds. Maybe it's safer then to remove microseconds and nanoseconds from the time unit options?
weird, things got screwed when moving classes around. I;ll update this.
a bit too long indeed, changed to 5 minutes.
Same as in the previous case, handling the return of a future would make me write more code, so I don't think there really a lot of value from using a future.
no need for an empty c-tor here, just use the EmptyConstructorNamedCacheFactory
This is unnecessary, the parent class already does it, and already assigns the cache manager reference too.

As mentioned before in the list, if you wanna do anything other than starting a cache manager, it should be done in a overriden version of setup. Doing this keeps things separated and avoids potential issues with cache managers left open and testsuite halting.

See org.infinispan.client.hotrod.RemoteCacheManagerTest for an example of how it should look like.
Weren't we going to change this?
I wonder if the pythonic way would be to try to do the subtraction, and if it fails to raise the exception, rather than silently accepting a default value?  Does anyone else have a feeling on this?

Additionally, if this try block coincides with a user pressing ```ctrl+C``` a KeyboardInterrupt is silently ignored.
I agree with @akhmerov on this point.  I personally don't like the idiom of the empty list evaluating to false partly because of this reason.  I work with numpy arrays so much.  My second reason is that an iterator to an empty list evaluates to True, and so could cause a lot of confusion when coding in py3k with iterators being so prevelent there.
this regex is not used
You can put these on the next line with an indent. I won't complain, I promise. @cvan does it all the time and we're still friends.

It'll also help you stay under 80 chars.
No, it is not worth the effort we can do it later.

It works fine as it is now.
Rather than returning here, we should store the result and assert it. This means this method will throw if the connection cannot be established and we do not need an explicit assert in every test that uses this method.
I'm sorry, I have no idea! Maybe it's an issue with github?

On Fri, Jul 20, 2012 at 2:33 AM, charset
<reply@reply.github.com>
wrote:
>> @@ -147,7 +147,7 @@
>>                                               rule += p1 + value + p2 + value;
>>                                       }
>>                                       rule += '100% { -webkit-transform:rotate(100deg); }\n}';
>> -                                     document.styleSheets[0].insertRule(rule);
>> +                                     document.styleSheets[0].insertRule(rule, document.styleSheets[0].cssRules.length-1);
>
> Excuse me. But could you let me know why these mails were sent to me while I have no projects in github and follow no projects?
>
>
> --
>
>
>
>
> At 2012-07-20 00:46:37,becw <reply@reply.github.com> wrote:
>>> @@ -147,7 +147,7 @@
>>>                                              rule += p1 + value + p2 + value;
>>>                                      }
>>>                                      rule += '100% { -webkit-transform:rotate(100deg); }\n}';
>>> -                                    document.styleSheets[0].insertRule(rule);
>>> +                                    document.styleSheets[0].insertRule(rule, document.styleSheets[0].cssRules.length-1);
>>
>>This doesn't work for me as written; adding the rule to the end of the CSSRuleList does work, though:
>>
>>```document.styleSheets[0].insertRule(rule, document.styleSheets[0].cssRules.length);```
>>
>>---
>>Reply to this email directly or view it on GitHub:
>>https://github.com/neteye/jquery-plugins/pull/47/files#r1198655
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/neteye/jquery-plugins/pull/47/files#r1203529
>Создать три метода типа quoteSavepointBegin, quoteSavepointRelease и quoteSavepointRollback ?

может просто savepointBegin? И двинуть в реализации DB (PgSQL и т.д.).
Should probably call this _globalAlpha to keep it consistent.
@arnodeclercq We shouldn't be making style changes in here & the rest of the file.
@nicolaasmatthijs I searched for `addtocontacts_form_cancel` but couldn't find anything. Apart from that `_cancel` didn't show anything either when looking in `addtocontacts.html`.

Am I missing something?
Could we add the `show more` button to this html?
@arnodeclercq There shouldn't be any changes to this file as far as I can see.
Can you add `|safeOutput` here?
I would like it if we could be a little more diligent at adding names and descriptions for these properties so things are a little more understandable on the administration console.
Roger. :)
please use 430 then
I dont knw what's the problem here, in my editor it is perfectly fine.
What is the motivation for ++x?
Security issue: Please use basename() to avoid directory traversal.
I would use `GridFieldDataColumns` component over `GridFieldComponent` here.
I ended up going with reserving "wiredtiger." for configuration strings we "own".   I'm not wedded to that, if you like something better that's fine with me.
What does this change has to do with json?
It's quite common and reasonable to use a different client-side library to the database version, not just in MySQL but at least also in Oracle.  Unless there's a particular incompatibility bug we know of or a target version for both client and server, I'd leave this as is.
Needs a space after if
Are you sure ``$this->current`` has the correct type as ``null|resource|false`` is not a sub-type of ``resource``? I found this a couple of more times on lines: 213, 242, 266, 293.
Are you sure the method ``validate`` can be called on ``$this->validator`` (of type "object<Symfony\Component\Validator\Constraints\CardSchemeValidator>|null")?
Should the type for parameter ``$internalName`` not be ``string|null``?
not clear on the necessity of the eval, but whatevs
Detail: Kommentar noch falsch, kopieren von nächster Methode
Since package versions are nested resources of packages, every action is in theory scoped to a package. Even though this is only accessible with `package_id` set to `None`, the `package_id` parameter still exists and the router will get confused if the method doesn't take it.
CS, добавить пробел перед "{"
What do you think about changing it to:  puts 'Try again with the --no_symbol option.'  ?
Another ,
Github pages is probably smart enough to remedy issues associated with this but it would probably be better if you said


```html
<html>
  <body>
    Sorry this page does not exist =(
  </body>
</html>
```

Or you could just have it rendered by jekyll
Is this the right documentation? (the parameter is named code)
Should this be &lt;sid&gt;?
you should use our internal version of which (much faster then shelling out to which)
Indentation. BTW.
Constant string -> `'`.
Just `account/password/`.
Yes, we have to find a way to do this. One would be to not use field type, but to use different [content-types](http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.7) for different post types. So route by that to those different resources. So instead of using URL, using HTTP field to chose which resource to invoke. Check how this is dispatched.
It was just an example of possibilities. You should think how you want to organize things.
That should work. Probably you just have to remove the old class, not both. But still, it should work. Check if Firebug if it really adds classes. Also, you can run your code in Firebug manually. So open Firebug, run `$('#id_password1').removeClass('input_ok input_error').addClass('input_ok');` and see what happens. Is there an error? Does DOM change?
Is the CasPrincipal object intended to be retained and re-used in a session, such that GetPassword() might be called more than once, say on demand in interacting with the Principal?  If so, would it be better for the GetPassword() implementation to cache the password once retrieved to avoid repeated calls to the CAS server to get the password?  (Or is making it retrieved just-in-time a strategy to avoid this class retaining the password in memory?)

If this were modified to keep the password around, I suppose it should be enhanced to keep it around encrypted ala what uPortal does.
That's right. It would be better to tell which required properties are missing exactly at startup.

 I added a method called `missingPropertiesAtStartup' in 'org.hibernate.ogm.util.impl.Log`. Also to tell which required properties are missing, I modified the method called `RedisDatastoreProvider.checkRequiredSettings` to return a `Map<String,String>` which contains unset properties if there are, otherwise return an empty map.  The modifications are as in the commit named [Add a method called missingPropertiesAtStartup' in org.hibernate.ogm.util.impl.Log](https://github.com/seiyak/hibernate-ogm/commit/e87ecf5d62ccbcf28aea11db1a44fe2a93d522b0).