labofsahil/github-event-dataset-2012 huggingface dataset:
I find "You'll want to switch to the newer Django version." rather glib -- perhaps they *don't* want to switch (or can't). Perhaps instead replace this with a pointer to older documentation? Something like "This book covers Django 1.4 and above, so if you're using an older version you probably want to consult Django's official documentation: <link to 1.3>, <link to 1.2>, etc."
I guess I'm not as familiar with the context. Why would a nil id be passed in? Typically you want to avoid using nils if possible. In this case could it make sense to just not pass it in?
And what is `IPList`?
why renaming this into just "pids"? I find it clearer to use get_* as it means we're doing a call to get some information about the pids (I think)
_Insert sound of concurrent spider-sense ringing._

Tell me if I am wrong, but it is my understanding that one of the main reasons to introduce promises in Jetpack is to encourage/enforce asynchronous programming. If you start building code that relies on order of evaluation, you are effectively introducing hypotheses that will all fall down and crumble once your code is effectively asynchronous/multi-threaded/multi-process.

I strongly suggest avoiding these considerations like a plague.
Can skip braces.
Gotta find another name then, because cls.ResourceManager is the generated class for the ResourceManager Scope Interface.
NgxUrlAsyncFetcher::Init()  is called by PSOL,and calls ShutDown() when Init() returns false
The way I read this is that it's part of a nested optimization for ci_corr. Is there anyway to avoid going through all these if statements each time it's called since we don't really need to? Right now just calling ci_corr takes close to 10 seconds and includes 1.6 million (!) function calls. Anything we can do to avoid unnecessary calculations is going to greatly speed things up. Even if ci_corr doesn't call test_corr and repeats some code since the latter might be (?) called just by a user with the outer optimization step.
Oh, ok. I just need to copy over the doc string. It was still a bit in flux, so I left it for last and forgot.
If you pull in all the changes and get the latest from source the tooltip
and overlays should be working on robot dashboard now. Adrian will have a
new set of pr2 icons soon so pr2 dashboard is looking up.

A question: Are there supposed to be error/warn icons in the robot monitor
tree?
Aaron

On 2012/10/07, at 15:24, Ze'ev Klapow <notifications@github.com> wrote:

In src/robot_dashboard/widgets.py:

>      def _show_console(self):
> -        if not self._console:
> -            self._console = ConsoleWidget(self._proxymodel)
> +        if self._console is None:
> +            self._console = ConsoleWidget(self._proxymodel, True)

and it works!

—
Reply to this email directly or view it on
GitHub<https://github.com/zklapow/robot_dashboard/pull/9/files#r1781223>.
Why this template does not extend our base templates?
I didn't know Python parsed this correctly, how neat.
Moi aussi! :)
There is a comma missing after this string element.
I'm sorry i usually work on linux and when i opened up this file it had hard line endings so i ran it through dos2unix to remove them. That's why every line is changed. I will keep this in mind for later.
turns out that this introduced a bug though -- I had manually set the perms on the log files before, had to fix
Should be integer operations - the amount column (self.amount) is an integer, so unless it decides to do some funky integer to float stuff in the background...
I wonder whether someone will come up with a use-case for an enricher to respond to notification-sensor events.
(e.g. has there been a "too hot" notification within the past 10 seconds).
What is the advantage of deliberately preventing someone from implementing that use-case if/when they come up with it?
Can make this private final; code is very careful to always synchronize on it, so good to avoid other classes just modifying the map or changing the field's value.
SshjTool.toCommandSequence needs this as well.
Given that we will always (currently) go through the SshjTool code path, then good to update it as well.

I'll take your word for it that the escaping is right (I notice the escapeLiteralForDoubleQuotedBash is not the same as was there before, but is presumably better. I also notice there are no unit tests for it!
This is not obvious and is kind of a special case. The code should look something like this:

    data.sizeStruct = size;
    date.size = &data.sizeStruct;

The reason is that in the original Java code `NSSize` is a class and the variables can therefore be null. In D `NSSize` is a struct and with its default initialization will yield a valid value. This is kind of a hack to have null values for `NSSize` variables.
It is nice to use the Play classloader instead of the system one because Play might do a bit of messing around with it.
You don't need CSRF token for forms that use the GET method.  It only works for POSTs.
Check out my post in piazza regarding likeable
Can you verify this still work for content within even if the `targetWindow` is an iframe? If not please remove these dead code.

If so, instead of inlining style, use `this.targetWindow.classList.add('rtl');` and add the style in stylesheet as a class selector.
It's in the git history, so there's really no need to keep dead (or dying) code around.  If this code may come back, then it may indicate the merge isn't ready for the master branch.  

What you could do if you're really sure about merging, is remove all the commented code and after I've merged it in, you can revert your private branch back to the version with commented code.  That way the dead code isn't around to confuse others and you will have it at hand to reactivate when you want it.
Our comm radio color is different, and you removed the nuke radio define.
I should do the same for MPU6000 but all these debugging variables are probably not necessary, or did you find them useful to get the driver going?
Maybe s/public/private to the method below?
This should actually be:

```
_instance.trigger(null, fileVersion);
```
Given this is the readme for tomcat, this is a bit confusing!
I don't see this method being used in the tests.
the issue is that ``inputClass`` is wrong too: when using form types, you can pass a type name, not only a class (and this is necessary when your type has some dependencies)
@～@ と [～] の記法の前後には空白を入れない。
Is there a specific reason to have the imports here? In general I would move them to the top.
Yep you are right, good catch :)
>    Should fit_grid_point be a public function?

Yeah, it can be handy.

It might use a rename tought: the 'grid' is irrelevant outside
gridsearch.
Err... this does not seem very graceful or informative.
Right (of course), I was being exact during development (get it working, then get it right!)
Thanks for the comment :) Very helpful.
I didn't want to go into the API discussion. We still haven't put that down. I think the next person making a claim about what the API is has to write it down ;)

My thinking was "pipline needs the ``y=None`` support, but here it is not necessary. So there is no reason to demand it here.
This was along the lines of the lightest possible interface as discussed in the score_func debate...

On the other hand, one could argue that having different degrees of API requirements are confusing.
Formatting: space between "MOVE" and the terminal ]
Done. Changed tabs with spaces.
Aucun paramètre
Why not catch(...) if you are not going to use it...
(There's a separate issue open on it)
And should be conditional on USE_URIPARSER ?
Pretty sure you can but then you have to watch out so that it doesn't become like `...</a>Next word no space...`
I did it now. However, it seems to me that the validation in https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/content/loader.js#L31-44 is bit broken. It check for local URLs only if we pass an array, and in that case doesn't allow data: URL.
It totally does work that way. I'm looking at the platform code right now. A login request returns a session token, the expiration date, and the user's profile.
this is brittle, try to identify with the minimum amount of steps.
These should definitely be in the model, not it's helper.
Use `grunt.utils._` instead.
The property works fine
  on Linux and Mac

I could not get the location of the jarsigner consistently, the java.home property points to the jre.

Many people have a JAVA_HOME set.
However some probably set it to the jre which would fail as effectively as the property.

I tried passing the location in as a command line parameter early on. That worked but felt like a step to adding lots of parameters to the buildserver. It looks like that is what others are doing so it may be the way to go.

V1.2/V1.3 uses a property file, ai4a.property. That worked well.
but...
It required folks to set the properties so I started on a setup utility to build the file based on what the user had. The setup utility also made sure the App Inventor user was set up.

V1.2/V1.3 used the Android tools rather than the dx jar etc. It also let us set Java to whatever version you wanted to use.

I uncomment the old code (why I left it) that finds the jarsigner on Linux and Mac and put a JARSIGNER_LOCATION in if the old code does not find a jarsigner.

Hmmm
Got it, what is your preference, change it to OptPort or simply remove it since it's really not needed?
It's more than almost confusing. @brandonprry if you can come up with a more sane way to express this, I'd love to see it. (there's a similiar construct in https://github.com/rapid7/metasploit-framework/pull/1018)
Also, this test is hard-coded to use `subject.attr`, while the actual attribute being tested is `@attribute`. I suspect if the spec is changed to set `:attribute` in the `define_model` block, this test will error.
Any particular reason for the Long->long switch? I think that the ID should be remain an Object (thus allowing for null in transient instances)  rather than a primitive.
I guess I can implement onCreateDialog() in ShadowDialogFragment and return newInstanceOf(Dialog.class)...
It's not a GUID then, it's just a random number, plus you only appear to be using the first 6 characters as well; which would mean your RegExp has no actual affect since neither g or - appear in the first 6 characters.  Why not just have use a simply counter variable?
If we didn't already port it, we should make an issue.  Linearly interpolating Euler angles is embarrassing.
Same comment as above about using the static `Cartesian3` method. Why not use `transformPositionToScaledSpace` instead?
What? What are you talking about man? This was your question: Any reason to delete this? And I answered it. Was your question implying anything about whether I understood some problem you explained some time in August? The answer is **NO, It was not**.  Unless you provide a comment, before the commented out test, explaining why this was commented out and why it still a problem or the fact you spend a significant amount time, then the chances of me **remembering** some problem that you explained on 8/16/2012 are very small. So if you are expecting me to remember everything out of the fly, then I am sorry to tell you "dont expect that from me" . If you want this to be remembered by developers, then provide a TODO stating why this should be remembered.
The intention was to use `defaultCompiler`. Looks like I forgot to change that use.
Hmmm... that sounds fishy. What exactly does the %appcmd% point to? Perhaps this is batch file that wraps something else and does not propagate the ERRORLEVEL? For reference, see https://github.com/tjanczuk/iisnode/blob/d77a518db40563089e79b54b2bdf99466821ffa9/src/scripts/install.bat#L62-68 This is how I was checking ERRORLEVEL of appcmd.exe back when iisnode had a *.bat install.
Isn't it necessary anymore? We need this for integration between aerogear controller and security.
Missing a word in your comment... "exception when [we] use 3+"
I understand where you're coming from, but I don't like to implement a new class knowing that it'll be removed soon. So we have 2 options:
1. Create TiUIAlertDialog class
2. Make this available for OptionDialog (by removing the AlertDialogProxy check) and file an iOS parity ticket. I actually discussed this with Sabil and Blain. They don't mind having this property for OptionDialog also. 

Thoughts?
my bad...I use the terms interchangeably since they are the same thing if you never leave JS land. Fixed.
two empty lines before clas
Is there a reason we use `../resources` here?
This should be `name`, it's more descriptive
Funny – to my non-native, but mainly BE-trained eyes, they are just the same in this context, but apparently, that is preferred for »restricting« clauses in AE style guides. Would never have guessed that…
should use a different symbol instead of `l`
I put this comment 1 line too high, this was of course, replaced by:

"static if (hasLength!R)"

Sorry.
Accidental.  I must have used auto-import to get the forge events in and didn't notice it when doing the commit. It's late. ;)
I'll try to fix it right now as using the map of names to components is
busted at the moment and i'd rather rip out the code path than try to fix
it.

On Tue, Aug 21, 2012 at 2:51 PM, John Messerly <notifications@github.com>wrote:

> In tests/browser_tests.dart:
>
> > @@ -118,9 +118,9 @@ void _appSetUp() {
> >  void _componentsSetUp() {
> >    // Use mirrors when they become available.
> >    var map = {
> > -    'x-list': (root, elem) => new ListComponent(root, elem),
> > -    'x-if': (root, elem) {
> > -      var res = new IfComponent(root, elem);
> > +    'x-list': (elem) => new ListComponent(elem),
>
> that reminds me, can you add a TODO to clean this test up? it should be
> using the polyfill scripts, not hardcoding the component construction map
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dart-lang/dart-web-components/pull/16/files#r1430050>.
>
>
お、そうだったんですね。Thanks!!1
Well, mostly Marina's code :D

What I changed was:

* No need to look at the body timestamp, because that server bug was fixed.
* Never a need to track per-record timestamps; we just want to know the last time we downloaded or uploaded stuff to the server. Yes, if there's concurrent modification this can lead to us pushing a change to a record that's already been altered, but that's a really narrow window. So always use `ServerClientsTimestamp` for `XIUS`.
* Persist the client record timestamp if we downloaded our record, or uploaded our record (because on upload the header timestamp is the same as the record modified time).

I don't believe this code ever intermingles our record with other clients' records, so the two code paths are separate.
Agreed, that would make sense. Easy to spoof otherwise for sure! I'll see if I can add a new option into socket.io called "trust forwarded header" or something like that. Then it can do a quick check in here.
you should use a different alias instead of replacing the core renderer IMO.
Typos.

Original: While I my corporation in one sense everyday, in another sense I am sure it is going to reach a decade in age and I am going to look at it's history like I do my old vinyl LP collection.
Corrected: While in one sense, I run my corporation everyday, in another sense I am sure it is going to reach a decade in age and I am going to look at its history like I do my old vinyl LP collection.
I believe we usually put a new line between a scope closing and the next statement.
@nicolaasmatthijs: Is there a way we can use the `sakai.api.Util.generateWidgetId()` function for this?
Maybe not inside this config file, but one level up?
Don't we already have this function somewhere in our codebase, maybe multiple times? I think the templategenerator widget has a version, and our core API also does. Can we API-ify this?
MINOR: Maybe move <<lf, <<ns and <<log_data away from other overides as these have custom actions compared to others (as already carried out in source file?)
is ignored when append is true.
I'm not sure what you mean by that. Can you please elaborate? This method is just used to get the <code>EventDrivenConsumer </code> instance for each of the definition in the xml
I think at this point we need to postpone this issue till better times.
The rule was stated pretty clearly the last time we had a chance to discuss it over the phone with Mark (single argument is always a payload) and as I stated in my last response the fact that we were lacking the test you showed means that we were not counting on this behavior and giving the state of the code it was clearly not intentional. And in fact there is a test in this PR that ensures exactly that which means your test and this test are mutually exclusive.
We had this discussion before where as with any bug fix the bug itself could always be counted as an existing behavior so fixing it always introduces some level of regression and therefore IMHO it is justified here as it fixes the inconsistency.
Also, as I said few times before in the remote chance that there is a user who actually relies on this behavior, fixing it would be a matter of adding a simple configuration in the form of header-expression and we already have plenty of regression introduced with 2.2 that have exactly that.

So let me know if that is not convincing enough so I can resolve the issue as Deferred and move on ;)
No, that was for versioning; we didn't want headers there. This probably is the simplest way to do this then, right?
We should change the name of the file too in order to be in sync with the class name. At the moment the two are in contradiction.
I think you can avoid this dependency. See below.
Strict please.
Doing it this way lets IDEs such as PHPStorm autocomplete / auto refactor these variables
as i said before, this is not guaranteed to work
why this call ?
NGHUTPR but I think these individual asserts are tribbles, and if it goes much further I'm going to have to seal off the bridge until you create something like `from proboscis import asserts`...`asserts.is_none(trib, trob, troob)` to contain them.
We should add a link to the optimization chapter that I just checked in.
Guess where this goes? =D
just for notes - this one is done
me conformo con "apellido, nombre"
@mrmorphic @sminnee This needs i18n (via _t()).
Not sure if thats possible with SelectionGroup, but then we need to make it possible :)
So smartSql will be the underlying SQL query for all query specs, not just "smart" queries...do I have that right?
I was looking for classes that could parse HTTP queries and found one only in ASP.Net. I did not want, however, to add a dependency on that library only to use their parser. 

Missing characters in the query string would mean malformed input. Processing that would require us to abort execution anyway. If we don't check return values, we'll get something like an "index out of range" exception. If we do - we can throw something nicer. However, I am not sure it's worth the effort.
Misspelt! If you can change that, I'd appreciate it.
No it will
Potentially have onAll function here to add a listener to all events of a given type
А и да.
seems like no I am not  fixing it since the entire file is like this
Should success have a value?
What exactly are all of the changes to this file?  Are they things you're just porting over from DW 0.6.1 or something you've written?