labofsahil/github-event-dataset-2012 huggingface dataset:
Should I add the override method to the application support file (I have now changed it to application.rb)?

It seems like you can't override a method this way, because I'm getting this error:

```
rspec-rails/lib/rspec/rails/application.rb:7: syntax error, unexpected '.', expecting ';' or '\n' (SyntaxError)
        def Rails.configuration.application=(*)
```

It doesn't seem to like this form of overriding...
Something like this works fine for me here: https://gist.github.com/5f99a7daa7dd172761f0
Tests fail with ```bare: false```, so we will need to update the coffee test if we make that change.
If these three lines aren't needed, then they should be deleted.
and, if you follow my suggestion above, this can simply be removed.
Ah, understood. Sounds good.
broker can be `string` too
@stloyd it works only because the code using Goutte is not tested. Goutte has many dependencies that are not installed with your setup: https://github.com/Behat/Mink/blob/master/composer/packages.json#L2

Mink itself works indeed because you use the symfony driver, not the goutte driver
Nope, that's not required.
What about having only one setting, `LESS_GENERATOR` and setting it either to True or to the path to less?
gotcha - I'm not used to the "capitalization equals variable" thing
Add this for breadcrumb translation
this is wrong. It cannot be in it since 2.0 as the next version will be 2.3
Was the comment so useless ? :)
github's diff output is misleading here, this chunk actually applied further down below.
`twitter` picks the current url of the video like `http://hasgeek.tv.local:8000/kracekumar/starred/922-mtv-unplugged-episode-5-susheela-raman-ennapane-hd` , the title of the video has to be placed along with tweet, and hasgeek.tv twitter handle .

Sample Tweet:
`MTV Unplugged: Episode 5 - Susheela Raman - Ennapane [HD] - http://hasgeek.tv.local:8000/kracekumar/starred/922-mtv-unplugged-episode-5-susheela-raman-ennapane-hd via @hasgeek.tv`. The title needs to shortened as well <140

Also if the video is in `liked ` or `starred` or in any auto_type playlist, the original playlist video has to be tweeted not the current url.

This will require some extra JS work.
remove unneccesary empty line
IIRC this could have other values too, like: `RSA-SHA1` or `PLAINTEXT`.
This caused an extra periodic update loop each time the calendar settings were changed.
The montreal is actually testing the capitalization.  (see monTreal on line 20.)
This is my spread sheet.
We need to give this a better name. ExerciseHomePageController works for me, however, why do we have a controller for this? Istn't this just an index view?
Is it a typo?
Well, that's annoying. I guess we could scrape the title from the HTML, but that's not any more appealing than adding a character map.
Debug print statement should be removed first
How about just "permalink:"?
This subhint is pretty sweet!
Why don't we instead wrap whatever incoming method (or _.sum) with a function that first rejects the nulls/undefined/NaNs? The point was to allow people to quickly say "_.min" or "_.max" and now to actually eliminate these values they will have to define their own.
there are multiple items on the page that have the LINK_TEXT Top Rated we need a more stronger locator
I would rename `search_string` to `search_term`
Does this render correctly? Think you're missing a trailing `)`.

I wonder if it's better to just inline this link a few lines above, so that maybe "You can use curl" is hyperlinked? Then you wouldn't need this extra sentence at all.
This key should be `results_for_html` now given it contains HTML.
Mmm, so this is just about good to go in; the thing I wanna point out here is that Twython, by default, allowed people to specify `version=x` in their function calls and it'd be merged in. With this modification it's defaulted/stuck to `/1/`; can you modify this to still allow it on a function by function basis, defaulting to `1` if no `version` is supplied?

If this goes in then we're good I'd say.
Is there a reason why we are filtering tenantId here?
The rowkey is all lowercase so I think this can stay.
perhaps we could store 0/1 instead of storing true/false strings ?
Yeah, the next couple of commits will have it working like that.
Just FYI, this stuff will move to the oae-config-aggregator/lib/init.js file after app life-cycle is merged.
Can't you use a default parameter? `canShowMultipleHyperlinks = true`?
AFAIK Java filters out private classes, but it's true that it only does when running all tests in a package. So you are right.
Missing empty parens
I was thinking to put the same properties that are declared in the below ``scala-2.10.x`` profile, i.e.,

```scala
<scala.version>2.9.3-SNAPSHOT</scala.version>
<scala.major.minor.version>2.9</scala.major.minor.version>
<scala.library.version>${scala.version}</scala.library.version>
<sbt.compiled.version>2.9.1</sbt.compiled.version>
<scala.precompiled.version>2_9_1</scala.precompiled.version>
<version.suffix>2_09</version.suffix>
```

This way there should be no prob, right? Sorry for not beeing clear in the first place.
I don't think it has to do with naming convention, but more with correct English. `partially` refers to `match` so must be an adverb, not an adjective.
What do you want to rename it to? I don't see what my PR has to do with this method.
As above, RFC error with respect to HTTP headers
The server_ip part was something I was really stuck over for a while, will try and catch you on irc to discuss as this is a tricky one!
Длину массива лучше задавать переменной, не указывать здесь явно цифрами.
"establishes two TCP connections"
You change the meaning here.
It was * and now you make it the interface friendly name!
Was this accidental?
we can remove the sentence "This can be filtered..." here because of your excellent documentation below.
Crap, but ie doesn't support it. Maybe include both, prioritizing `ns`
Apologies, I think that is cruft.  Please delete.
you should probably prefix your elements with something like `alertify` since it wouldnt be unreasonable for somebody to already have an `aText` id :)
Style: no space after the asterisk
ここを修正したんですね。
という感じでレビューコメントが付けられるのが大変便利です。
ZOMG! You're right! Thank you for pointing at this mistake. The issue lies with `long`s, not  `int`s.

And we might have already discussed this while you were implementing the retrieval of 64bits wide entries from the config.
> The reason for doing things outside of SourceEstimate is that it is more efficient, e.g. we only have to compute "label_vertidx" and "label_flip" once, instead of for every stc. So I think we should leave it like this..

I fully agree I was saying that it should also be exposed in SourceEstimates :)

the same way the baseline correction function if factorized in one function.
Oh yeah. Sorry, was thinking of how Array [] and slice are the same.
Fairly sure I shouldn't
should it say "for  all of your projects" instead of from all of your projects?
同时处理的请求数最多不超过5个。
=>
同时允许超过速率限制的请求数不多于5个。
`===` coding style
this was legacy from Diesel gem. I'll just create a well named token here and remove the comment
"unsuccessfully"
Curious, my line numbers are offset by 14 from these, I wonder where that comes from?
This delete is not needed as we have populated self.xformers[k].
That worked perfectly, thanks!
Ну так убей ее к хренам.
Не уверен, что эта прагма в твоем случае нужна. Вряд ли тебе придется хотя бы тыщу статей хранить и быстро-быстро по ним всякие запросы на вставку выполнять, как это в LMP. А вот если база навернется из-за асинхронности и продолбает статьи, будет очень печально.
@jfarcand, we use transport "streaming", enableXDR set in true for supported IE9-10, in opera "if" return true. You may be better to fix.
hay una ruta. asi que podes generar facil la url

On Sunday, July 8, 2012, Alpha <
reply@reply.github.com>
wrote:
>> @@ -0,0 +1,17 @@
>> +﻿using System;
>> +using System.Collections.Generic;
>> +using System.Linq;
>> +using System.Text;
>> +
>> +namespace CommonJobs.Domain
>> +{
>> +    public class SharedLink
>> +    {
>> +        [Obsolete]
>> +        public string Url { get; set; }
>
> En realidad es calculada, pero ahora mismo la necesito porque no tengo
una forma fácil de generar los links de forma automatizada. Uso esta
propiedad como container en el frontend, cuando se persiste luego no tengo
que generarla en el load.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CommonJobs/CommonJobs/pull/117/files#r1119455
>
El nombre de este parámetro no es keepRecentDays?
Right, I use common constants but I can go further. I'll fix this.
Yes, this will match anywhere in the string. As you said, using re.match would be more convenient if you just want to match the start of the string (explained [here](http://docs.python.org/2/howto/regex.html#match-versus-search))
please remove unused package annotation
Just giving it another test.
Hmmm - it would be an environment var we can pass.. then check for its existence?
Nit: ```// Load``` instead of ```//Load```
I think some pydocs here would go a long way, just enough to explain what this is or why it exists.
do we need sever=None here if we arent using it?
fair enough, I've changed the code to use Callables.
rCh is for reading and wCh is for writing. Will give them better names and javadoc it. Thanks!
should you really allow any char between ``import`` and the quotes ? It looks to me you will allow false positives. Shoudln't it be only whitespace.

and you should match that the opening and closing quotes are the same.

And the regex for the path inside the quotes is also too permissive IMO. It could match too much things (a quote for instance)
Nope to @ryanb ;)
May be worth mentioning that this isn't strictly necessary and that doing so means that travis-ci has to do more work (sometimes unnecessarily)...
Nope... just added normed argument. But I'm not too sure how numpy.histogramwd does normed in case of uneven bin though hopefully it does the right thing with variable bin size
More celebration after this step is in order. I think chocolate cake and strawberry smoothie are good candidates.
Nitty, but maybe describe what the `task-multiple` is in the docstring with a leetle background on the experience that led to magic number 15.
Foo was just an example..  It fits for all your functions
@apex13 Can't we just use the `fl-hidden` class here?
The goal is for institutions to be able to add their own widgets next to oae-core, e.g. oae-gt. These widgets should be included in the production build as well.
Good point, I'll think about that for future changes. I guess in this case I could've done `$newaddcontentContainerSelectedItemsContainer.find('#list-id');`
`$('#' + result.target, $container).length === 0` --> `!$('#' + result.target, $container).length`
@bp323 : This should use rootel
Actually, it looks like you just need to delete the `@Reference` annotation on `SakaiDocPagePublishOperation`. If a parent class needs a reference, use `@Component(componentAbstract = true)` on the parent.
but still you just need the standard CSVM interface for the things you are doing - so no need to work a specific svm implementation - CSVM should just work fine.
Changed to min-width and commented
I just used RegQueryValueEx because that's what uv_cpu_info was already using for reading cpu speed and name info (cares uses RegQueryValueEx also). I'm not sure if the unicode version is preferred over the ansi version or vice versa for this use.
That's a good idea, I'll use a function. Where should the function be defined?
discussion about the code
alias :process_resources_block, :process_resource_block?
why use `private` instead of `protected`, it's better to use protected to allow extended commands

also could you named it $input
Perhaps more clear as:

> Splunk admin port (default: 8089)
Remove those comments when you are reviewing translations. Always check the file.
Then you can remove TODO bellow, no? (Only for Facebook.)
Please tell me this is a joke :D
Ahhhh, back to work :)
Ehm, not good. You should not use ISO format. We are using another format for formatting dates. But `sender.serialize` should take care of this automatically? So maybe leave `sender.serialize` for now, but remove this isoformat.
It still does not work in Windows?

Which format do you use to encode datatime strings?
Alternatively, I forgot to commit it. Well, *now* it's next to `login.html`. :)
Use slow or fast instead of 500.
Hmm. But be careful. We probably do want that panels are repositioned automatically while window is resizing? Only we should not be doing Ajax requests to store the state until the very end.
Import only modules. Then you will not need such names as `OfficialBIDB`.
Empty line above, name the section `Twitter`.
Did you mean `reduceToScalar`?
Please use four-spaces shift width everywhere.
in MKSKSubscriptionProduct base64 encoding already done before sending receipt to server: https://github.com/MugunthKumar/MKStoreKit/blob/master/MKSKSubscriptionProduct.m#L73
Without this encoding I got '{"status":21002, "exception":"java.lang.IllegalArgumentException"}' response from apple server each time.
So what is with the dancing then :P. Seems like a bunch of things can be simplified with a few defaults for these columns on the models.
Nevermind, it was fine.
74ee1ee
Delete whole try-except.

Reason - there is no need to introduce a custom template for different payment backends. In most cases this view should show something like "Please wait redirecting to a payment gateway", and fire form submit with JS as soon as browser will load page.

This view is just simple mock for making a POST, not a custom view for payment acceptation/confirmation.
I would prefer to be more explicit here than having all the other types being "sockets". For instance if I make a typo and enter `kind="Watcher"`, I will end up with a `SocketStatsCollector` rather than with a `ValueError`
This change is to move them in `ConnectionStringParser.php` check this file name.
`group_order`
They're not quite the same.  `ngx_http_pagespeed_get_srv_config` is a casting wrapper for `ngx_http_get_module_srv_conf(r, ngx_pagespeed)` while here we'd need a casting wrapper for `ngx_http_conf_get_module_srv_conf(cf, ngx_pagespeed)`.
else m.reply "oops, couldn't build that branch, please check it on jenkins"
what do you think?
Missing new line above
absolutely, will do.

--  
Josh Butts
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Thursday, March 8, 2012 at 6:48 PM, Paul Annesley wrote:

> > $stub .= "<?php" . PHP_EOL;
> > $stub .= "Phar::mapPhar();" . PHP_EOL;
> > - $stub .= $bootstrapFile . PHP_EOL;
> > + $stub .= '$pheanstalkClassRoot = "phar://" . __FILE__;';
> > + $stub .= 'require_once $pheanstalkClassRoot . "/Pheanstalk/ClassLoader.php";';
> > + $stub .= 'Pheanstalk_ClassLoader::register($pheanstalkClassRoot);';
> > $stub .= "__HALT_COMPILER();" . PHP_EOL;
> >  
>  
>  
> I think the indentation is inconsistent…
> Could you amend the commit and force-push it to your branch?
>  
> ---  
> Reply to this email directly or view it on GitHub:
> https://github.com/pda/pheanstalk/pull/38/files#r537117
>  
>
Same with `#` as in my previous comment.
It would have been easier to spot in the diff if you hadn't gratuitously renamed outputStream to os :)
I've got it.  It's to do with the way I'm enforcing two-fold rotational symmetry for the case of even-dimensioned images.  Here's a succinct description of the problem:
![the_problem_with_draw_in_CorrFunc](https://f.cloud.github.com/assets/1454961/24654/4704fea2-4ab7-11e2-9c8d-dff9aacccdc3.jpg)

Basically, to continue trying to enforce the 2-fold symmetry in this way I now need to either have

1. Two case switches inside the `xValue` and `kValue` member functions, to ascertain which quadrant you are in rather than just which half of the correlation function.

2. ...Or on init I have to take the missing sliver of data values from the upper half of the left-most column of the input array, then invert them in the y direction and and glue them to the lower half of the right most column, from the middle row down.

Option 2 is probably more efficient long run (moving repeated case switching into a single init step) so I think that's probably best... But are there any other opinions?

I'm hoping that this glitch might be at the root of some of the issues in the tests below...
Perhaps replicate this comment when `final_nopix` is actually constructed, at line 664, too.
"CS144: Introduction to Computer Networking" Course Staff

doesn't look too strange to me.


On 9/25/12 10:29 PM, Sef Kloninger wrote:
>
> In main/courses/email_members/tasks.py:
>
> > @@ -170,7 +170,8 @@ def course_email_with_celery(hash_for_msg, to_list,  throttle=False, course_titl
> >      staff_email = 'noreply@class.stanford.edu'
> >      if course_handle:
> >          staff_email = re.sub(r'\--', r'-',course_handle) + '-staff@class.stanford.edu'
> > -    from_addr = course_title + " Staff <%s>" % staff_email
> > +    course_title_no_quotes = re.sub(r'"', '', course_title) # strip out all quotes
> > +    from_addr = '"%s" Course Staff <%s>' % (course_title_no_quotes, staff_email) #make certain that we quote the name part of the email address
>
> Surprised you didn't put the quotes around the whole email title, like 
> "Networking Course Staff" foo@bar <mailto:foo@bar>.
>
> The way you did it, "Networking" Course Staff seems strage, like the 
> name of the course is sarcastic or something. And did you test quotes 
> around only part of the name? I've only seen around the whole name.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/Stanford-Online/class2go/pull/830/files#r1692209>.
>
Change to a Runnable or Callable, rather than a Closure?
What is good about .pod? What the heck does a selector like this mean.. Naming is important.. We should try to find good names for the selectors as well..
Could you align this nicely?
And necessary it seems!
```Aeronave test2 = action.consultarPorCodigo(id);```  usar a variavel que ja existe

```assertThat(test2.getCodigo(), equalTo(codigo));```
My git output uses green.  I think green makes more sense.
This must be at the end of the previous line, like so:

`` you can load it like so::``
Well noticed, I will alter the logic.
really should be using the main get_sources shell script.  IMO This should be deleted.
loose it
Ah, OK.  I was trying to work around it with something like

    class ProviderXMLFormat
      include ActiveResource::Formats::XmlFormat

      def decode(xml)
        puts "xml is "+xml
        ActiveResource::Formats::XmlFormat.decode(xml)['provider']
      end
    end

    class AeolusCli::Model::Provider < AeolusCli::Model::Base
      self.format = ProviderXMLFormat.new

which got me closer but still gave me issues.  I'll try the Tim version...
Reference to above approach, for the record:
https://github.com/rails/rails/issues/2318#issuecomment-3555973
Подчёркивания в названии переменной запрещены.
И здесь правильное ожидаемое сообщение в исключении?
В качестве отступа - 4 пробела
this semicolon shouldn't be here, especially since only the js dude has an outputJoin with a semicolon in it.  This suggests it's using the wrong definition?
i thought someone had already noted that this does not belong in Base, as not every link on every page will go to a Statistics page.
Great idea @bebef1987 !
+1, changing the test!
why are we returning a list of web elements to the test?
Page objects should not contain all this logic. Why is this needed?
Here we're just wrapping an API call, why?
I've used the name `owner` here so that we can re-use the permission `IsOwnerOrReadOnly` for other user generated content objects with an `owner` field.
`hasMod` и так возвращает `Boolean`
RegEx objects already have unapplies. Couldn't you use the regex directly in patterns?
>
> In sklearn/rbm.py:
>
> > +
> > +    >>> import numpy as np
> > +    >>> from sklearn.rbm import RBM
>
> shouldn't this be s/RBM/RestrictedBoltzmannMachine here and 2 lines below?
>

Thanks.


> as for the module, neural_network is still shorter than cross_validation,
> why not?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-learn/scikit-learn/pull/1200/files#r1760553>.
>
>
> Usually I rooted for self.classes_, y = unique(y, return_inverse=True) and I
> used that in a lot of places.

+1: simply, readable and efficient.
Well, I wouln't see a usage for such function. You can see that the actual check for nil is already in a function which is 4 lines long.
This shouldn't be Windows only, right?
I think it's cool that you can use a function as an attribute, or rather what the function returns:

```d
string foo ()
{
	return "bar";
}

@foo int a;

static assert(__traits(getAttributes, a)[0] == "bar");

void main () { }
```

Perhaps lambdas can be useful as well.
I'm not convinced about the location of that file.  seems like doing so will put us in a situation where the we have a `src` folder but all the c++ source files are outside of it.  Maybe we just need a js folder?
What are type and project path needed for in device management?  It seems to me that device management should be independent from the type and the project level data.  This seems like unnecessary coupling.
What if the download request was made using the variation where you pass the `cacheName:` parameter? Would this still find and remove the correct file?

We may want to simplify the interface by removing the `cacheName:` variant, now that the custom cache schema can handle this.
How about checking if this is a number (0,1) or one of the strings ("read", "readwrite") ? I think I will abstract out that logic.
Same changes that I made to the `UserCreationForm`.
Maybe we should use some XSL that does support, if there is any... I'm not the right person to ask about that, though. ;) 

@richardkchapman do you know if we can "upgrade" our XSL implementation?
So no objections (in another commit) of making all the engines throw an exception here?
is memsize_t more appropriate as return type?
Why not use queryTransformAssignValue ?
Was there a reason this was increased?
I know it was like this before , but wonder why not just a contained object..
Socorro uses UTC so to avoid confusion we should use it in the filename too.
Again has some unwanted text about github.
I just submitted the pull request, hopefully that'll go in  quickly and we won't have to deal with this on the Formula end of the stick anymore
`bottom-left`-> `bottom-right`
Actually, I used same port than existing tests. So I went ahead and modified them as well.
I ended up using 8099 port. Nothing particular with this one?
Um, we need that! The [timezone-aware date handling](https://github.com/mytardis/mytardis/blob/master/tardis/tardis_portal/util.py) won't work without it.

It would be super-bad for the new OAI-PMH app. So bad that I'm wondering how you managed to get the tests to pass...
Could you adjust the formatting?
Plase check that you're using the default formatter 1 tab = 4 spaces
correct all xpath to css paths before checking this in.
please try to replace all the paths with css paths
@raydavis No need to be shy with me.
this should probably be a class property
I was thinking safe words as in S&M worlds, u know like the safe word is monkey, when I say monkey, u stop, but I agree it's a little confusing

-Josh

On Aug 6, 2012, at 12:53, jlee-r7 <reply@reply.github.com> wrote:

>> 
>> +        # some "safe words" to avoid for the value.  value would have to not match these regexes
>> +        # this is just basic idiot protection, it's not meant to be "undefeatable"
>> +        value.strip!
>> +        safe_words = [/^rm +(-rf|-r +-f|-f +-r) +\/+.*$/, /^msfconsole$/]
> 
> ```safe_words``` are not actually safe.  Confusing varname. 
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rapid7/metasploit-framework/pull/637/files#r1313947
How about `pyramid_up` and `pyramid_down`?
The static reference is being used to update the view's viewer by actions and commands.
Use `defaultValue` if we keep these arguments.
I actually couldn't find the code; I don't think eclipse refreshed when I asked it.  This is OK for now.  At some point, I'm interested in the bigger picture issue of trivially loading images for use as textures, etc.  @IanLilleyT also has to deal with it for the JSON material system as do all users.
I'll flesh out the doc a little more.
Doesn't look like `sourceUri` is used anymore.
Doesn't show up in generated doc.
I was worried about it because of that I've run the tests and all green
Technically, a table view is a container for table view sections, which are containers for table view rows, although in the typical case the table view section is created under the hood since the user didn't provide one (at least on mobile web). In any case, there are also table view sections to consider in this statement.
This entire function is wrong. You SHOULD NOT under ANY circumstances EVER calculate width outside of the layout algorithm
Separate into three components to avoid potentially mixing slash types:

```JavaScript
path.join(harnessPlatformDir, "harness", "tiapp.xml");
```
I'm getting an exception when running this code: .../sound/cricket.wav(No such file or directory) - I have circket.wav in /Resources dir.
This section responds to a longpress on a tableView that is outside the section bounds (Like the tableView header or footer). So the `section` piece was left out of the event. 

From the docs for `indexPathForRowAtPoint:`
An index path representing the row and section associated with point or nil if the point is out of the bounds of any row.

Observed behavior is that when the point belongs to sectionHeader or Footer it returns a false indexPath belonging to a row. Also observed that when the point belongs to the header of the first section `indexPath` is nil. The first special case is handled in the next block. The second special case is handled in the block above. The event generated here is for when indexPath is truly nil and does not correspond to a section or row.
`@field {Type} name description` http://code.google.com/p/jsdoc-toolkit/wiki/TagReference
If you wanted to DRY up your specs so that you don't copy this obj everywhere, you could have a top-level describe block for the `'incr command family'` and have the obj declared in that scope. Within that describe, you can have individual describe blocks for each command in that family (incr, mincr, incrby, etc).
Typo 'the for expiration'
If the backend class calls libzypp directly, it will require the whole application to be run as root. This should not be necessary to minimize the amount of code running as root.

We need to decide on a way how to access the backend. This zypp code should either go into a backend helper program, which is called by the frontend, or it should be replaced by using packagekit or something like that.
This makes it easy to run individual test groups, such as only the index tests.

So you could, for example, change:

> var suite = { ... };
> return suite;

to:

> var suite = { ... };
> return suite["Index Tests"];

which would only run the index tests.
I don't think we need these kind of comments. It's useful for us, but it is confusing for people reading the code.
Может нужно исходный инпут в этот момент обратно возвращать (туда где его клон)? В клоне кажется не будет выбран файл который был выбран в исходном. Или он уже не нужен бывает?
Fields medal for Menke!!
would you mind to add an informative g_warning if an event has more than one subjects, please?
And a comment with the assumption on a single-subject event is what we should get.
Thanks for the great review notes, Masahiro san.
1. `T.tupleof` can be empty
1.  this is `true` for

```D
struct S { int my_this; }
```
Use ".this" instead.
> And why not just populate the hash map via put? 

To do everything on one line :)

Personally I like that style but I can set up the map separately if you prefer that.
The `...` is used here to indicate that a substep of something bigger was performed, so it's useful imho. Also, it's only a debug message, so we shouldn't bother about it too much.
This was written prior to the changes you mentioned, but compared to the old error code:
* lets you preserve headers, and puts some details in header,
* works with the exception object rather than shipping around all its pieces
* emits a richer hash
* handles errors in middleware same as errors in app (this has been partially addressed I think, but see below)

I'd prefer it in core, and will fix up a pull request for review.

You'll still want the HandleExceptions class, because you want "normal" errors (database errors, bad requests, 404, etc) handled right before the render part of the stack. HandleException and everything below it supply a *hash* as the body; the render layer and everything above it supply a *string* as the body. If an error occurs, this will emit it a hash and be serialized same as anything else: CORS headers, correct serialization format, reporting, etc still occur.
should be elsif
i was trying to achieve *log-weasel-id* not being in this lib.  am i crazy @travis ?  can we just bind *job-data* or something?
Leftover comma?
I think we can't put windows azure credentials in `phpunit.xml.dist`. It'll be visible for public because of that we were using `getenv`. Or I'm missing something here?
This can be moved inside the `if` sentence below and we don't check the option twice.
Looks like it is (apart from your patches) :)
To butt in, many of the optimizations in OSL assume that code is side-effect free.  For example, calls to texture() that are determined to return a constant color, aren't necessarily side-effect free but we elide them.  Perhaps that's an "Oh, but I know it's OIIO" thing, but other examples would include closure merging (does \alpha * diffuse() + \beta * diffuse() = (\alpha + \beta) * diffuse()), etc.
You need to fix this comment - we now interrupt every 4 counts (0->3)
So couple ideas:

One  is to case over osfamily then in the Linux case subcase over operatingsystem.
Another is to leave it where it is.
Another is just to case over operatingsystem.(Possibly wriing a regex to capture both debian and ubuntu).
Same for $accessor.
I did this for the entire CSS file.
These should be fixed in latest push.
change const to var, not supported in IE, Safari, or Opera
I think that both names are equally ambiguous then. My concern is simply with the underscore in the current name. How about `is64BitChip` or something along those lines? This makes it explicit that we're talking about the chip and not the current operating mode.
Also, I am sure you can use the same instance of the EvaluationContext that is used by uri-variables (see line 284)
...contains **'json'** ... with **'text'**)...

How about to eliminate a mention about **us** ;-) ? Maybe 'this class' ?
That seems right then. I was going to suggest "addedToPool" but it's not a callback after the event, so "createForPool" sounds right.
is it a draft?
You aren't using here **%PREFIX%** placeholder...
handshak(e)status
lockKey
Right, i'll have test for that
a utility method like `tryGetKeyChain` would make code more clean here.
yes, It is working on firefox, chrome and IE 8
Yes, adding it here from the beginning was a bad idea. So I guess fixing it here for windows as well shouldn't hurt.
For installations that are running mixed environment they should "untick" the escaping option and let whatever buildstep take care of it for them.
The reason we needed it was a quick fix when we introduced the owner email parameters where standard email formatting is "First Name" first.name@acme.org
MLPFilterBy にならって、MLPStatus もインポートしておけば良いのでは。
No, use British, the largest proportion of the team is British.
yii → Yii
включающие → содержащих
js → JS
css → CSS
, а также возможность зависимости от других пакетов. → При описании пакета можно указать зависимости от других пакетов.
can you prefix the block name by ``sonata`` ?
Implies more computation at server side, but we could do that, yes
okay, I dont mind
I believe we don't need this instance variable here.
Уже работает в Островке
There's no point in a void check function that doesn't throw. I'd throw something now regardless, so people don't get used to this check not throwing.
Moving input arguments to an array...
I think it would be better to set

    public function __construct($apikey = false, ...

Then on line 87 you can say 

    if($apikey !== false) $this->_header['X-GData-Key'] = "key={$apikey}";
Maybe you want to check this field for an actual value instead of just any value to make sure nothing weird is going on.
ah, I see the VERSION constant now.
Should we add the Trialforce URL (for branded login) to the default list?
I don't think I am the author of this :)
Wouldn't it be better to use a class here, so you don't *have* to have `left|right` as the alignment, and easier to change the styles further?
Can you guys help me rewrite those opening paragraphs to capture that nuance? One of my earlier workings of the introduction got tied up in knots over exactly this but my attempts to simplify obviously went too far the other way.

I also think that actually the most helpful entry on device compatibility would be Tom's blog but perhaps that's too GOV.UK specific?
huh1?
Do we need to check for error field here?