labofsahil/github-event-dataset-2012 huggingface dataset:
Yeah I did it that way because when I logged out/back in as someone else it didn't get cleared, plus I figured we'd want to handle the defriending case. But we could certainly handle both those things some other way. 

Sent from my iPhone

On Apr 9, 2012, at 9:28 PM, Tim Su<reply@reply.github.com> wrote:

>> @@ -128,6 +133,31 @@ public void run() {
>>         }).start();
>>     }
>> 
>> +    /** fetch changes to users/friends */
>> +    private void startUsersFetcher(final boolean manual, final SyncResultCallback callback,
>> +            final AtomicInteger finisher) {
>> +        new Thread(new Runnable() {
>> +            @Override
>> +            public void run() {
>> +                int time = manual ? 0 : Preferences.getInt(LAST_USERS_FETCH_TIME, 0);
> 
> (for performance reasons - sending across 200 people seems like a slow op, and it's probably not what users want)
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/todoroo/astrid/pull/173/files#r663846
"Použít moje" sem myslel celý překlad ne jen konkrétní řádek, v současném je použit jiný styl než v následujících popisech a na konci je navíc nesmyslný výraz "přepínaček". Sice tam mám navíc jedno odřádkování, ale v dialogu se to zobrazí správně a je to čitelnější.
This can never happen. At this point, pos = name (from the line above) and name is always unchanged from its static definition above. Did you mean to be checking sharename? Otherwise, this test can be removed.
Yeah, should have changed that after changing to length via bookkeeping. Done.
If the eval'd symbol t doesn't have a super method, then the last ifelse fails. If there's a way to check that it has a super method, then that might be better than the try.
A `var updateDomain` is needed here to prevent global function creation.
@jlsherrill is reading it right. It is there, because it was not clear which way we choose for Foreman integration. Now user can use Katello username and password to login to Foreman UI (which was one of the possible ways).

Thanks, for remanding me. Sending of plain password is not needed any more. I've added TODO to my Foreman list. I'll fix it after the merge: In production random password will be generated and sent to Foreman (no need for user to be able to log in to Foreman UI). I'll leave the current option (plain password sending) in development for debugging purposes (a developer will be able to log in as a Katello user to Foreman UI). It will be configurable.
response.Messages[i] should be segment
spelling: convenience

non-inline code should be in ``` (for readability, more spacing)
NUM_PHOTOS?
s/line/row/
Because I want to simulate what a user would actually do when unlocking the screen.
I have this problem when running my scripts on linux, where 'configuration { "not linux" }' sections seems to be included anyway.
I wonder if this is related?
Documentation bug: I assume 'scipy' and 'matplotlib' were supposed to be separate strings.
I'll do a full doc revamp after the codes are fully reviewed, since the examples would need to be updated and such.
Right, I'm just afraid you using it here will tempt people into using more.  But that's probably just me being paranoid, so whatever you prefer is fine.
过滤掉纯英文的Meta？ 感觉如果要这么判断，最好写个comment

个人觉得可以直接不过滤，和下面统一逻辑反正回判断type。
这行是autoload用？这样的工厂方法觉得有点怪。
如果是工厂方法直接把返回值做实例用会更直接：
```php
$port_service = Service::factory('Port');
$port_service->isOnService($user->id);
$port_service->categoryMapping()
```
So it looks like read_some and systest_read are two different holdovers from basho_expect. Maybe we can convince @slfritchie to tell us a tale of two read functions?
I really don't care much for extract() as it makes the resulting local scope hard to understand.  If you really want to avoid using `$column['foo']` you should make explicit local variables.  I know that CakePHP uses extract() in a number of places, but I'm planning on reducing the number of uses.
Should probably remove references to 'behaviors' here as they could be anything.  It was wrong in the old docs too, but we shouldn't carry that mistake forward to the new method.
I used the same logic as implemented in the findGroupByName and findThemeByName.
Recursive functions are not my strong point.
yes, my bad, I should have stuck with the original :) This should be the `Shards` minus the shards that didn't participate in the write, as given by `PreferredShards`
No lonely braces, close up that space. :)
>  If you want a test for different character sets, that should be created separately to this test.

Excellent point. Sounds like a plan to me.
This case is for users that did specify the path. We only validate what they said before proceeding further. The users don't need to always specify the full path, that's what the `else` right after takes care of.
Same with this one, please.
I think `utils/encoding.py` is the most consistent. I'm not sure now why I suggested charenc.
For consistency's sake we generally use `floorf`.
I think I'd prefer to see a new `bool git_path_isdir_and_empty(const char *path)` function with a Windows implementation and a non-Windows implementation (less interleaving of #ifdefs would improve readability, even at the cost of a small amount of repeated code).

Then this function could just become a relatively simple `!git_path_exists || git_path_isdir_and_empty`.

What do you think?
Looking much better... But why are you alloc'ing an extra FILENAME max even in platforms where the `dirent` has a full array at the end? I don't think that having a conditional here is going to hurt us at all.
ACCEPT IT
port can be string, so don't check for type. + added query string
I'm almost of the mind that a `from .download_buttons import *` would be appropriate here. Thoughts?
This doesn't match the sentence-case capitalization used elsewhere on the site, but that may be intentional (and probably isn't a blocker).
i will if they fit in the 80 chars
37? Could this not be a configurable constant?
then you can do `item['mdn'] % {'locale': locale}` if you did [that above](#L4R54)
I'd expect to find this at the top after detectos and findjava
The regex is slow, so we only do it if necessary.
Because I had an issue of some speakers (for example Rowan Merewood)getting the following error when clicked on their name:

An exception has been thrown during the rendering of a template ("The "protalk_media_explore_speaker" route has some missing mandatory parameters ("id").") in ProtalkMediaBundle:Speaker:result.html.twig at line 47. 

I really don't understand this, because if I change id to search, it works for all users, but with id only for some of them.
un align this line, since it's not part of the block.
This type signature is unsafe. This should return an Object and you should require your callers to cast.

The problem with this type signature is that EVERYTHING compiles:
   String s  = parse(entity, String.class);
   String s  = parse(entity, Long.class);
   String s  = parse(entity, new TypeToken<List<Unicorn>>() {}.getType());

If you make the caller cast, then you can put an `@SuppressWarnings` tag there and a comment explaining why that particular call is safe.

(We made this mistake in Gson).
ok I guess we want it to be mandatory then.
Why not keep it? I find it quite nice that generic exception handlers can read out the code and get useful info out of it.
this `elseif` can be a simple `else` because the condition is always true at this point
This is wrong. It returns an Alias instance, not a Definition
extra space before dot, "PHP extensie" should be "PHP-extensie"
True. I could change it by adding an @ to the symlink-statement and reading error_get_last on a false result and then throw an exception with the appr. message. 
And how do you see the overall value of this addition?
Please add a check for ``window.localStorage`` here, to avoid breaking the profiler in old IE. This was not done for the timeline because it cannot be displayed on old browsers anyway, but it becomes needed when using it for the menu
Since the benefits of having a object serialized into cache far out-weights the cons, imho at least, I've made the CacheProxy mandatory, so that you can store anything you want/need in the cache systems without fear that you can't store a certain data-type.

Also, I'm thinking about using the Serializer Component, to my shame I've never used it so far, do you think it would make sense to use it here?
The log message is perhaps too generic, I mean there is the 'patch' word missing which would describe what is it about
pushed error fix
We can't have that arg on the same iine if we're not using vertical alignment.
Personally, I would suggest sticking with a convention (one way or the other). Too many configuration options lead to confusion. :-/
ok，我改成全称
yeah, no problem, btw would be ``&&`` instead of ``||``
I wasn't actually aware of that convention. I'll take a look if some of this can be cleaned up.
Added a TODO list on top of the selectmenu wiki page, including this one.
EditAlarm.alarm.daysOfWeek = ...;
    EditAlarm.refreshRepeatMenu();
indentation again (please re-indent the rest of the file as well)
I usually don't like !important rule in production. It hides something deeper but at this stage of the project let's say that's ok.
MozTransform -> transform I think
I think it's better to use Cards._findCard than assume it's the 0th card.  (I realize we're abusing the presumably private method; feel free to rename it and its usages to lose the underscore.)
I think you can just use transform now instead of MozTransform
decides *if*?
I don't think so.
This code would cause power menu never works when lockscreen shows.

An idea:
You could try watch ScreenManager.screenEnabled to know now the screen is off or on to determine to show or not.
Another idea is use screenchange event.
Neither is good I think because of timing issue.
Do you think we could change the naming of const to be consistent?
  So far we have 3 naming styles: ALL_CAPITALIZED and camelCase, and 'kStartWithK'.
@fabi1cazenave promised to have code for this next week. Can we wait until them?
It would seem cleaner, but at the top of the file: 'use strict';

Unfortunate side effect of:  SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function @ http://settings.gaiamobile.org:8080/js/settings.js
Mozna by si ty parametry zaslouzily vic jak jedno pismenko
I would use info_msg here.
You may reverse these 2 lines and save yourself the first sleep
some unit tests for this would be great so we have all the class merging combinations covered
maybe print both len(modelnames) and n_models in the error message ... so it's obvious when the error occurs what it is?
Also, if we want to do appscale light, maybe we can specify a database on the command line args.
From our talk yesterday, either (1) document this method, or (2) open an issue that says "somebody should document this method".
At the moment this is a lie. The logic code only actually supports IP address. There's no logic that converts a DNS hostname to an IP address.

Logic should be inserted to cover DNS.
Missing text...

Allow Changing Votes
If set to <em>Yes</em>, users are allowed to change their vote in the polls.
Not sure about this. I think we want to restrict number of displayed letters, not how much BBCode can be written. We already did a change that makes BBCode parser to cut generated HTML.
yes, it's a bit better like that
I'm tempted to suggest adding `codebase` here, but that is a free-form string.

Which also raises the issue of versioning message key formats, for changes like this.
This shouldn't need to be changed, as this code should never be dealing with a new Change object (see the comment at the beginning of the class).
Wow, that's *clever*
Not sure what you mean here, but the corrective hint was to omit "(2004)"
from the
title, since this is the year the book was edited.
-W

On 28 June 2012 16:38, Ian Darwin <
reply@reply.github.com
> wrote:

> > @@ -111,33 +112,33 @@
> >
> >      <para>KRR is about how we represent our knowledge in symbolic form,
> i.e.
> >      how we describe something. Reasoning is about how we go about the
> act of
> > -    thinking using this knowledge. System based languages, like Java or
> C+,
> > +    thinking using this knowledge. System based/Object-Oriented
> languages, like C++/Java/C#,
>
> Oops, I accidentally deleted the first one, could you please
> re-send it? (The one with "Thanks..." at the top).
>
> Ian
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/droolsjbpm/drools/pull/125/files#r1068188
>
Add definition -DHAVE_SPEEX
This probably needs a little more detail (error detail for down events, downtime for up events)
its because  it will ignore your mode
dashboard & profile are different
I cant find a code where `@project` is defined
What is an "invalid memcap"?
Yup, I'll fix the other ones if you get the one in this PR. Thanks!
I personally don't mind this but we need to be aware of two things here:
-All layouts overrides have to be changed or upload won't work anymore
-It's not valid XHTML1 (which we currently use for the admin template)
I would re-add this, or something like it. Just a way for people to share the link. I think this got lost in our merge conflicts.
Where are unbalanced_node and unbalanced_node_parent declared? What are they?
You're right that using the PATHEXT variable as a way to detect Windows is
lame, but Config (deprecated) and RbConfig also seems to be fairly broken:

  RbConfig::CONFIG['host_os'] =~ /mswin|windows|cygwin/i ==> nil (bogus!)

  RbConfig::CONFIG['host_os'] =~ /mswin|windows|cygwin|mingw/i ==> 0 (found)

  RUBY_PLATFORM ==> "i386-mingw32"

*sigh*.

However, it turns out that there is a "windows?" function in Util, part of
the vagrant project, so I'll use that.

Pat


On Mon, Jun 4, 2012 at 12:43 PM, Wil Moore III <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,36 @@
> > +module Vagrant
> > +  module Util
> > +    class FileUtil
> > +      # Cross-platform way of finding an executable in the $PATH.
> > +      #
> > +      #   which('ruby') #=> /usr/bin/ruby
> > +      #   by http://stackoverflow.com/users/11687/mislav
> > +      #
> > +      # This code is adapted from the following post by mislav:
> > +      #
> http://stackoverflow.com/questions/2108727/which-in-ruby-checking-if-program-exists-in-path-from-ruby
> > +      def self.which(cmd)
> > +
> > +        # If the PATHEXT variable is empty, we're on *nix and need to
> find the exact filename
>
> @webcoyote
>
> Would the following perhaps be safer?:
>
>   Config::CONFIG['host_os'].include? 'mswin'
>
> It may prove to be safer to go with a system flag such as this over a
> mutable environment variable.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mitchellh/vagrant/pull/933/files#r924609
>
nit: it would be slightly easier to read if we split this in two distinct actions/lines:

    Object.defineProperties(Selection.prototype, SelectionAPI);
    Object.freeze(Selection.prototype);
hmm odd that this happened..
I think it's even weirder than that, since the call to `checkSupport` triggers an `idp_seen` event, which (eventually) updates the table that feeds `db.getIDPLastSeen`. So maybe two races.

Your flowchart looks right to me.
Okay, wanted to communicate during the review that

1) I think we can do more tests once all the backend is updated
2) I have a temporary function in db.js that is only used in unit tests and will be removed once listEmails includes lastUsedAs.

Will remove.
@lloyd - can we get this information from WinChan instead of having to pass it from include.js?  It would be cleaner.
Actually no need for the `as excinfo` in that example - I initially thought you were making an assertion against properties of the raised exception, in which case you'd need that. But you're not, you're just asserting against output.
修正ありがとうございます。
Maybe it's better to return the name instead of the uri when project name is not specified. This is used to show the survey label text on top of the ListView
Is this only public for testing? I think this should be made private or extracted out in some way to allows it to be tested on its own.
Why did you change the name of this file? It's the entry point to the module as described in the `package.json`, so with it renamed the entry point is missing.
Could you please be more precise? For me, I'm testing a module method so I use FFI::Platform.windows?
Missing autopsy header.. do we still need this class? Maybe we can check it into CoreUtils; it looks pretty useful!
this is pretty hacky and adds a dependency for people to use the data attributes to get this "initialize behavior" - it also doesn't account for tabs which are injected after domready.
Did that because my IDE was complaining. Will revert :)
Oh, no,  `ModuleLoaderListener` implements `ListenerAggregateInterface`. The  listener takes care of attaching it to the right event.
Okay, no problem.  If it isn't controllable, then it shouldn't change again, and that's fine.
This probably isn't necessary. You just persisted the record to the database, you shouldn't need to immediately read that record back out. 
Just add the new privilege record to the person's collection.
Are'nt there? (#859)
This was my first implementation :

```php
'source' => function($meta) {
    if ($meta['source'] !== null) {
        retrun $meta['source'];
    }
    return $meta['source'] ?: Inflector::tableize($meta['name']);
}
```

For "better" performances I assumed that `function(&$meta)` can safely save some cycles but maybe you're right on that point and it my be better to not send $meta by reference. On the other hand initializers are intended to modify `$model->_meta` and the &$meta can be used in some use cases.

Example: 
You wan't a specific name and a specific source based on the specific name. Here the exectution order of the closure is important since the 'name' closure must be executed before the 'source' closure.

To avoid the "ordering" bug of closures, you can use a kind of "global" meta closure:

```php
Posts::config(array(
    'initializers' => array(
        'custom' => function(&$meta) {
            $meta['name'] = Inflector::singularize($meta['name']);
            $meta['source'] = Inflector::underscore($meta['name']);
        }
    )
));
```
No matter if the default closure 'source' is exectuted since it abord if a value is already setted.

Finally I don't know what would be the best... @nateabele ?
Lavaca's default Application type binds a tap event on all anchors to integrate with its router.  rel=nofollow is one way to tell Lavaca that its an external link.  Agreed its not the most semantic or elegant solution but it is one of the recommended ways to handle external links.
Remove all default html comments as described in the app spec
This is the line that fixes the test.
i think it makes sense
useless no but misplaced for sure :) The comment is back on `ConfigurationConverterTest::convertMapToCallback`
Sorry, I don't actually know why these lines changed. Think it is because of Unix-style line breakes.
Do the constructor first?
Spaces, spaces, spaces.
Ok, on further investigation, I think we should follow Marius' proposal. Jason made the changes in #238, so I'll close this one.
Wait, indent the `{% for %}`? But that's not contained by anything.
Again, spurious period removal here, I think; please restore.
Why not:
first_name=kwargs['first_name'], last_name=kwargs['last_name']
I feel like overriding `site_js` is fragile and we should have a per-page block we can override, just because this isn't as DRY and is prone to breakage if the `base.html` block changes and we don't update ones that override it.
hawt.
I know this isn't part of your patch, but can you delete the below comment?
"Popcorn Text Plugin"
特に意図していませんでした・・・！
border=やthはnonleyout tableという意味だったのですね・・・
fixed in 7e91372
sounds sensible, will do
and if there is a logic that uses the api_version method? such as /home etc?
Reading all this crappy ini parser related stuff I'm more and more in favor of a real json configuration file. It's also the default for this project so we should also change this for on-demand in the next days. It would make it way easier to parse and work with config settings. So leave it for now and we can take care of later.
addressed in comment below (rhombi are subset of kite answer type)
Abstract IPlugin classes aren't handled here.
Just to be clear any post marked with ```// Spout HD``` is code merged from MCPatcher's HD textures
Can you please use the "eea" i18n domain instead of "eea.tags" as this is a common use for all EEA packages. Thanks
For the example use a generic URL and Workspace, eg.-

http://myserver/rest/workflow/TRANS...............
The global sort hurts here - is there no way to arrange for the gNums to be generated sorted? Then you could GROUP them and sort by rnd ....
`RESOURCE_FOLDER` would make more sense.
can you cleanup/indent this part of the css?
Refactor into `Gandalf.Models.Event`
this was just moved to a new namespace, it didn't have them before but I will add them.
I removed this as part of the next PR.
Should note that the **reason** group resources cannot be assigned roles directly through the roles API is because the "Group Members" and "Member Of" (implemented through roles) should remain in sync.
Can you add a TODO item for this, so this can be removed when admin authentication moves back to the main UI ?
Can you add to the documentation that this is an internal function that assumes that the user has access to the comment/content? There's a few functions in the file that do something similar. Also, because this is now a function that no longer does any access checking, we no longer have to pass in the context.
>  I still think we should not wait for the indexer when asking for completions

I totally agree. Better to miss some completions than hanging the UI thread.

> [...] and the condition is because we need to wait for tests, [...]

Right, makes sense. Though, I'd very much prefer to have a ``ScalaPlugin.plugin.testMode``, as it better conveys the intention. But it's up to you to decide if this should be added now, or deferred for future improvement ;-)
Please put all of these attr_accessible calls in one call, rather than multiple calls. It reduces repetition.
More opportunity for sub-classing, e.g. this would appear in RegularDeck. Deck class might become an abstract base class.
Some weird indenting on comments
Gebruiken we font?
ну пример - тебе в функцию передали символ, которого нет в множестве {AGCT}, например Q. stringByReplacingOccurrencesOfString: withString: в данном случае ничего не заменит - он просто не найдет такого символа. Соответственно, когда ты сделаешь arc4random() % 3, ты потеряешь символ T т.к. у него индекс 3, а у тебя случайное значение выбирается из 0, 1 и 2, т.е. Т при таком условии никогда не выберется.
другой пример - у тебя параметр NSString * как-никак, значит, мы можем передать, например, @"CT", или @"GC" - после stringByReplacingOccurrencesOfString: withString: у нас останется всего 2 символа, с индексами 0 и 1, а arc4random %3 по прежнему генерит 0, 1 или 2 - соответственно, имеем выход за границу массива. Если же передать @"AGCT", то у нас вообще останется пустая строка... Правда, в этом случае посыплется и мой вариант - arc4random() % 0 не есть хорошо ))) Именно поэтому удобнее использовать не NSString для arrayOfChars, а именно NSArray - там подобная ситуация исключена. Загляни в мой код - там сделано именно так. Я эту функцию обозвал + (NSString *) randomElementWithout: (NSString *) element;

Да, функция класса - плюс вместо минуса. Ну, конкретно в данном задании профита от этого никакого (разве что проверять ее работоспособность без создания экземпляра класса), но по логике это именно функция класса - от членов класса она не зависит и может быть вызвана, когда никакого экземпляра класса не существует.
BOOL это просто signed char, Boolean это unsigned char. Оба
И если уж делать проверку на диапазон, то тогда диапазон должен выглядеть как [0, [DNA count]]
А реализация в Cell+Mutator.m
The uncompressed version uses line buffering so that when the SIGTERM happens, you don't lose a bunch of data. Does this lose tweets when SIGTERM kills the child process? Will you end up with a broken JSON file?
Where is `canChooseDirectories` declared? I don't see that variable in this function.
New line please
on the *score*
On this note, do we have any tests for expecting a n exception when an initialized proxy should be filtered?

I suppose we're forced to use DocumentNotFoundException since we can't discern if the find failed due to a nonexistent ID or some filter criteria.
Sem amigo no git!
You changed is_ignore_jump to true (middle param).

I don't know if users would expect back key to return at TOC location, but I suspect they would...
A couple things to address in the lead paragraph ...
- Since the user may not know the concept of a Maven goal, either describe it, or remove the reference to the concept and introduce it later.
- I wouldn't say Maven is definied by this phrase. Rather, it emphasizes "Convention Over Configuration."
sorry，我没一次性说清楚，double check
应该是先不加锁检查一次，加锁后检查一次：
(when-not (@handlers event-name)
      (locking (:register-lock eventbus)
       (when-not (@handlers event-name)
       (swap! handlers assoc-in [event-name] []))))

这样可以避免每次检查都需要加锁，第一次检查有就不用进入加锁了。
Makes sense.. let me kook into it.
+1 for support "dft" but I would call it "fourier" to be explicit.

we'll do "morlet" later. Things could then become redundant with minimum_norm/time_frequency.py . We'll look into it later.
this should be gone right?
Then instead of kwargs just say: 

methods : list of str
    the ....

And check stuff is list-like of strings and reduce it to the valid / known options

[m for m in methods if m in list_of_known_options]
I'm addings some cases + guessing.
If colors is str, always use that colour,
if None, cycle through list of colors.

Is there btw. a prefered order? 'w' 'y' 'g' 'r' 'b' ? if not I would just
take the COLORS list specified in  viz and prepend 'w'


On Fri, Dec 7, 2012 at 8:54 AM, Alexandre Gramfort <notifications@github.com
> wrote:

> In examples/plot_topo_compare_conditions.py:
>
> > +# Create epochs including different events
> > +epochs = mne.Epochs(raw, events, dict(audio_l=1, visual_r=3), tmin, tmax,
> > +                    picks=picks, baseline=(None, 0), reject=reject)
> > +
> > +# Generate list of evoked objects from conditions names
> > +evokeds = [epochs[name].average() for name in 'audio_l', 'visual_r']
> > +
> > +###############################################################################
> > +# Show topography for two different conditions
> > +
> > +layout = read_layout('Vectorview-all.lout')
> > +
> > +pl.close('all')
> > +pl.figure()
> > +title = 'MNE sample data - left auditory and visual'
> > +plot_topo(evokeds, layout, color=['y', 'g'], title=title)
>
> apparently there is a bug if you don't give color then only one evoked is
> plotted.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2345728>.
>
>
so this logic is... if commits isn't false/nil and commits has an rc in it?
Made a change here to improve performance and allow the lower bound to be a number > Math.random() limit.
Altough it isn´t you fault, can you please put the `:class:...` part on the next line?
This should be

    have a ``_locale`` parameter ...
This should be:

    // instances of Symfony\Component\Security\Core\Authentication\AuthenticationProviderInterface
    $providers = array(...);
should i remove all other extra parenthesis?
no need for protected
это слот
Ahora que lo pienso, esto se podría haber hecho con css puro, sin javascript, no?

Igual no tengo problemas en mergearlo.
Oh, it's true. Some times i "remember" this C++ heritage... :-P Fixed :-)
"en" is for english, this [breaks the build](https://travis-ci.org/gabrielfalcao/lettuce/builds/3689862).
Please fix and send again

https://travis-ci.org/gabrielfalcao/lettuce/builds/3689862
return lambda server_id: [volume for volume in volume_list if server_id in [attachment["server_id"] for attachment in volume.attachments]

I can't tell if the lambda is ugly or not
Lets update this to the new context stuff
exc.message is still equal to test_message, its not modified by the kwargs. we should still do it @TimSimpsonR? its basically a field, and the __str__ operator is where the new msg is used.
nix that comma
thanks, I've removed the value in the updated pull. Still I would like to see more details on it? How should I use the payload header you say I could "switch on" ?
extract `layerStyles.get(name)` in a variable and use in the for loop:
```java
final String[] styles = layerStyles.get(name);
for (int i = 0; i < styles.length; i++)
  ...
  String styleName = styles[i];
  ...
```
What is this stuff here?
This is the wrong place. You should add it on top, not at the bottom. This change is for 1.1.0, not for 1.1.0-alpha1 (which cannot change anymore)
I think that resourcePaths can be more generic than just files so I don't think that moving it to BaseAsset is a bad idea. For example now a HttpAsset can have dependencies too.
`wait_for_condition` is a good one you can use if there's no explicit wait you need
probably best just to delete it since it's specific to your machine. see any reason to keep it around?
@bp323 remove 1 space after `=`
You're jumping through a lot of hoops related to a template service for formatting JSON feeds when all you really need is the total count from a Solr query. How about turning the dependency around a bit? Instead of being dependent on the MeManagerViewerSearchPropertyProvider class, we might extract Query constructor code from that class into a method like Query queryConfigure(request). Then both the SearchPropertyProvider and the Collection Count Service could use that method, and the Collection Count Service would be able to take the more straightforward Query-to-search-service approach used by your message count code. If you want, you could even implement both interfaces in the same class.

One reason that seems attractive is that the current pairing of auth-all.json with MeManagerViewerSearchPropertyProvider is sort of a mess. The template has:
"resourceType:sakai/pooled-content ${_mimetype} AND ((manager:(${au}) OR editor:(${au}) OR viewer:(${au})) OR (showalways:true AND (manager:(${all}) OR editor:(${all}) OR viewer:(${all}))))${_q}",
But three of those properties are filled in by the same property provider, and so we've got tightly-coupled complexity spread across two places instead of one. If we move  more into the Java side of query construction, the template line would become:
${_q}${_mimetype}
And that query constructor could then be shared.
Have a look at the current version. I think it’s a little more clumsy but still bearable.
Pq instanciar uma tupla ao invés de passar a referência da própria lista?
what is libgen?
That's assuming a certain order of language - fixed it in the merge commit. Also, please don't space out the arrows, it looks ... wrong! ;)
You really easy read this line, aren't you?
string "original image" can't be translated, you will need getGS('original image') there
Is a separate block is required to exercise the `build_stubbed` factories?
This needs to be done in order to make friendlycode an embeddable widget. We're going to need a build step for production anyways, since we want to run `build-require.js` so clients don't need to load dozens of JS files and templates before the editor shows up.
Would this be simpler if it got pushed down into __wt_bt_cache_flush(), and the checkpoint code didn't change?

Basically, the checkpoint code could call __wt_bt_cache_flush, and that function handles WT_SYNC differently (which it already has to do), by turning on read-only eviction, making two separate calls to __wt_evict_file), turning off read-only eviction and returning.  Something like this:

```
        switch (op) {
        case WT_SYNC:
                 WT_ASSERT(session, ckptbase != NULL);

                /*
                 * Ordinary checkpoints are done in the calling thread. 
                 *
                 * Flush leaf pages first. 
                 */
                WT_RET(__wt_evict_file(session, WT_SYNC_FUZZY));

                /*
                 * XXX
                 * Set the checkpoint reference for reconciliation -- this is
                 * ugly, but there's no data structure path from here to
                 * reconciliation.
                 * Publish: there must be a barrier to ensure the structure
                 * fields are set before the eviction thread sees the request.
                 */
                WT_PUBLISH(btree->ckpt, ckptbase);

                /* Flush internal pages and create the checkpoint. */
                __wt_evict_readonly(session, 0);
                ret = __wt_evict_file(session, WT_SYNC);
                __wt_evict_readonly(session, 1);

                btree->ckpt = NULL;
                break;
        case WT_SYNC_COMPACT:
        case WT_SYNC_DISCARD:
        case WT_SYNC_DISCARD_NOWRITE:
                WT_ASSERT(session, ckptbase == NULL);

                /*
                 * Schedule and wake the eviction server, then wait for the
                 * eviction server to wake us.
                 */
                WT_RET(__wt_sync_file_serial(session, op));
                WT_RET(__wt_evict_server_wake(session));
                WT_RET(__wt_cond_wait(session, session->cond, 0));
                ret = session->syncop_ret;

                /* If discarding the tree, the root page should be gone. */
                WT_ASSERT(session, ret != 0 || btree->root_page == NULL);
                break;
        }
        return (ret);
```

I might just be trying to keep the checkpoint code simpler, I guess, but I don't see any reason this needs to be handled here, it's not really a feature of the checkpoint code, it's more a feature of how we implement checkpoint when we're dealing with the cache.
The fact that next is also a filter is important because a filter is part of a filter chain, thus it is possible to traverse it by starting with the first filter, going to the next one, than to the next one, ...
See my other pull request : https://github.com/EiffelWebFramework/EWF/pull/15
Are you sure that the method "addUserProviderFactory()" exists?
Estas cosas es mejor hacerlas sin paréntesis porque te obliga a indentar correctamente y evita errores a la larga (aunque entiendo que es es una rallada en Coffee al principio cuando no te acostumbras a cómo meter los paréntesis.)

```coffee
setTimeout =>
  @time = true
, @config.timeout
```
yay! this stuff looks clean. (temp) persistence FTW.
Hey, can you just move that on to the module too (also the test check) and that should be it.
Early return pattern whenever possible, especially true for within all these callbacks. The else statement consists in just calling the callback. Can you turn it into something like:

```js
if(!exists) return cb();

// rest of the code
```
No, I'm the one that's slow here. There should be a try..catch, to avoid triggering an error when touching the postMessage property in a UA that throws for SOP violations and doesn't implement postMessage yet. Would that make more sense? (This is of course provided we want to offer postMessage support both for same origin and different origin, which I think we should).
Good point, Rouven.
Could have sworn that worked before.  I'll fix that up.  Thanks.
Is this used anymore? Should we remove it?
This was intentionally not used on the class methods so that people using the views would not be forced to necessarily use the has_submit_permissions test.
Done as above.
We already discussed that, for each browser there is a CSS spec for gradients.
This URI will need to be changed if you're using the Subscriber API
No I don't get any errors with StringField. When you post comments entry is added to every user that is on superscription list. I placed notifications in user model because we said so when we were deciding what would be the best solution. But i can change it.
*Please enter the confirmation token you received to your e-mail address.*
Empty line between each group of imports.
All this is not good way to define things. Order should be predictable. So use list. Then define each layer as one entry there. Something like:

```
var map_layers = [
    {
        'label': gettext("Weather"),
        'layer': ew google.maps.weather.WeatherLayer(...)
    },
    {
        ...
    }
];
It's not used anymore. Removed.
I know what the code does. I am telling that you should use `user is None` instead of `user==None`.
You are correct in general, but I'm 99% certain that *this* call is safe. It is replacing code of the same form ([old L578](#L1L578)) , does not mutate anything other than property values, and passes unit tests.
latest version should be okay now.
because you need this variable some lines above
you could extract the split regex in a static constant for reuse
Is this necessary? Locally I see build/ivy-2.2.0.jar already.
it is formatted. looks quite pretty :)
yes, indeed!
I don't think this is needed, all event listeners are cleaned up. Remove the comment.
Might split only once.
Done: 0a320a6
Where does this macro come from? It's not an nginx macro and I don't see it in the mod_pagespeed tree either.
Yep, that's the conclusion I came to eventually as well. Thanks for clarifying :)
I think your editor kills new lines at the end of the file, which Git doesn't like.
Thanks for the suggestion - it's definitely an improvement.
меня смущает эта строка. Тут фактически делается запрос в базу. Что не очень хорошо. Хотелось бы обойтись без этого. Для этого есть несколько вариантов. Самый быстрый - это взять нужную инфу прям из queryset. Там кажись можно queryset.model или get_model как-то так.
Bounds checking. Either ignore or throw an IllegalArgumentException.
We can leave it for now.
this variables causes issues if empty, should be:
```php
    protected static $extra_filters = array();
    protected static $extra_hooks = array();
    protected static $extra_paths = array();
```
I had already opened a second pull request and have committed tests for my changes there. Please let me know if you'd like me to leave this one closed or close the other one (pull 52). Sorry for the headaches, I'm still getting used to GitHub.
Yea, sorry, this part is a bit messy. I will fix it.
Chaplain is duplicate.
I think this confused your program, it deleted this line.
```javascript
if (!titleElm)
    return;
```
It's probably a good idea to use just one name family here: "collapsible"/"collapse" vs "expandable"/"expand".
'App' is misleading here, use 'API'

    mk_api = MarketplaceAPI(mock_app, credentials=mozwebqa.credentials['api'])
Por favor, corregir el código ISO
This name looks a little bit weird: `with_no_wrapping_tag_and_wrapping_tag`?
use 1. / n_features or 1 / float(n_features) to avoid this
wouldn't it be easier to do
```python
pred_mask = [x in labels for x in y_pred]
```
same for true, then the intersection of the two booleans?
or maybe even

```python
mask = [x in labels and y in labels for x, y in  zip(y_pred, y_true)]
```
On Sun, Oct 14, 2012 at 12:44:38PM -0700, Andreas Mueller wrote:
> But this is only the case if you didn't inherit from ``ClassifierMixin`` or
> ``RegressorMixin``. I though that was the minimum requirement for the API.

In my mind, it is _very_ important not to require inheritence to use the
scikit-learn. The reason being that it should be possible to be
scikit-learn compliant without having a dependency on it.
Force-pushed a new version, please check.
No problem. I'll rebase it later.
This line looks wrong.
But, we already think `@xyz(args) void foo()` is legal, so we should think the syntax around UDA more seriously.
methods blur, focus, hasText are not supported by BB
Can you replace this with autoload in composer.json?

I think everything should work except for `HTTP_Request2`.
I feel like we’re missing a word or two in the second line. Could this be reworded slightly to be:

> Our trainers will walk you through a repository’s history with Git’s `log` command,
> and will illustrate a few collaborative techniques available using GitHub.

… or something along those lines?
Elsewhere, cpp's that define tests, appear to include various cppunit headers and then define ASSERT(a) ...

Not directly related to this commit perhaps, but should they all now be using this header instead?
yes it can.  It only uses the record of the second argument rather than the argument.
not sure if sortable is supporting odm
We should not use hardcoded HTML for doing forms. Please use the django forms module.
@rhelmer please include changes to the code that @ossreleasefeed mentions into this PR.
Fixed in 225e471
Is it intentional to use THRIFT 0.5.0, not THRIFT 0.8.0? Scrooge 3 implements THIRFT 0.8.0, I believe.
nit: unexpected leading space before `Registers`
I'd probably just leave this as `return self.table_pagination`.
My problem is probably due to the same reason.  I'll try something else.
Oops, I'm not sure how I missed that, but it's fixed now. Thanks!
dimensions switched: `height, width = image.shape[:2]`?
Could be.  Although I looked at the Process Explorer GPU usage chart before and after the change and it was about the same.  So the GPU didn't seemed to be working any less, at least on my system.  In any case I'll leave it in.
`TextureAtlas` is defined in the Renderer layer.  Returning `Rectangle` creates needless transforms.  Most - well all current - consumers do not want width and height; they want the coordinates.  Make it easy for them.  Make it easy for you.
rename isLayoutPass
It seems that you are storing a private variable 'id' in the person proxy and also an 'id' property in the properties hash.  Can we remove one of them if they aren't necessary?  Also, when doing "id", please use TiC.PROPERTY_ID instead.
Is it better to simply avoid the try/except ImportError and have simply:

from bson.objectid import ObjectId
from bson.errors import InvalidId

?
%w[Kelly Andy Rob Mick]
Yes. I think we could stub all of these unless we really care about the params they are passed on creation.
I'm easy either way. @cprice-puppet could you weigh in on this if you have a moment?
@sehmaschine This was the returned value when nothing was found…
Please don't use with in the tests, for now. Maybe in a few months.
I noticed @sorenh removed this as well in another pull request:  https://github.com/CiscoSystems/folsom-manifests/pull/6
Not possible:
a) The operation is non modifiable: auto b = - r[i];
r is never modified, so there is nothing to reference to.
b) Violates the whole do not leak addresses issues: The reason we have all these operators in the first place (as opposed to defining a referenceing opIndex, and letting everything else work from that).
if getting cute with dropOne for needle, why not do the same for haystack?
Wouldn't it be even faster if `~=` were used for all of these concatenations, since then it wouldn't be creating temporaries for each of the concatenations with `~`? Or does that not help with CTFE? Or is the compiler smart enough to optimize out that problem?

`Format` _is_ ridiculously slow though. It's actually rather shocking how much of a speed difference it can be to not use it.
no need for this with the up and coming rulez
I know, I am not a fan of this part either :( - it is optional as long as you don't need imports. Another option is to do imports differently, maybe do:

    <script src="model.dart"></script>
    <element>
      <script>
         Todo todo;
      </script>
    </element>
Pete, are you saying it should not have a target product?
AS you include Arquillian tests, you probably want to document how to run them in the README
Anyways, I'd say we create a separate issue for that and go ahead with this.
This looks like some spaces/tabs mixups again.
As I said in the commit: "… which makes much more sense as the settings window generates the event and it isn't solely used for spelling anymore."

Take a careful look at where the event is used, you'll see that it is generated by the settings dialog and used by the editor. It would not make sense to output two events if you can output one event. If you however want to do that, feel free to change that back, should be a fairly trivial edit...
Have you seen the checking for errors section here: https://github.com/shairontoledo/rghost/wiki/Converting-PDF-into-other-formats

I think it would be a good idea to do better error checking. I know too little error checking caused grief for ECN at some point. Thoughts?
No need for the ```@sections ||=```.
And if so, why, and is it correct to discard all but the first element?
Removes validation fix I added.
@croby: Has this work been completed? I would like to keep this function in here, as it used by /migrators/1.2.0/contentauthoring. This is a page that can be used to migrate custom templates, etc. that certain institutions might want to use. I'm okay with moving it to a different file once the back-end work is complete.
Should use `.on()`
This seems like a _very_ small timeout -- why do we need it?
Becomes irrelevant once the back-end code migration is pushed
Does anyone know where exactly this POSIX module ends up being included on Windows? It doesn't seem clear from the auto tester's output, and I have no Windows machine to test on.
OK, that sounds reasonable but please add a short comment then.
I've seen it in many other places inside druntime where it is used exactly like this. So why does there need to be a utitlity function now?
Same comment; blocking call - I will fix while merging
This can be simplified via XOR:
````java
String id = element.getAttribute(ID_ATTRIBUTE);
String name = element.getAttribute(NAME_ATTRIBUTE);
boolean hasId = StringUtils.hasText(id);
boolean hasName = StringUtils.hasText(name);
if (hasId ^ hasName) {
         parserContext.getReaderContext().error("Exactly one of the 'id' or 'name' is required.", element);
}
if (!hasId) {
  id = name;
}
 builder.addConstructorArgValue(id + ".messageGroupId");
````
WDYT?
I think the variable name `column` is misleading here. It should be `key`. Column is too tied to the server's persistance layer. We should not assume that there is a persistence layer or that it is column based.
Priority 5 is a little arbitrary. Just use 9 to scale one level in the priorities scale
This is no longer true. All configs are stored under ``etc/grid/config.xml``.
You are right, let's see the complete implementation now ;)
What ribuls?!? :-)
Read the man page on the prompt. You can use `%~` for the directory.
i'll document that the param is ignored. The other approach I tried is to use a type property to specify if it's polled or eventsource. But technically, the polled and eventsource properties could both be output with the type property. One of these object schemas would still get ignored, so i didn't see a point to go that route.
why changing it ? It does not add any value IMO
This might be a good time to introduce `strong_parameters`.
Its working from navigation controller now. Before it was not showing in landscape mode. the master part was going blank.
As I mentioned before, sometimes we need to make the script triggered manually by emitting signals from other parts instead of automatically updating itself(a lot of script components updating itself every frame should be expensive besides!) and under this condition, we need a switch to turn off the automatically updating while the script component is enabled still.
Après merge des PR de prettyprint de @jnizet, mes ASCII-art sont prettyfiés, si bien qu'ils comportent des couleurs cheloux.
Ajouter la classe `noprettyprint` a bien pour conséquence de ne pas avoir de bordure autour du code, mais maintient pourtant la coloration syntaxique. Un bug? Qu'en penses-tu @jnizet?
We don't want to add Zumo specific headers if a request is being made to facebook, for example.
We can avoid sudo ./configure if we update the configure script to only sudo the command that installs global npm modules.
There should be a blank space after this line.
The place that could cause some problems here in future is `next_item` as far as in one case it iterates through `list` and in case of Enumerator it doesn't. So it should be repaired, so both of methods will do the same but in different manner