labofsahil/github-event-dataset-2012 huggingface dataset:
The fetch test fails for this protocol, looks like this transport is not implemented yet:

    LibGit2Sharp.Tests.RepositoryFixture.CanFetchFromEmptyRepository(url: "git@github.com:libgit2/TestGitRepository") [FAIL]
    LibGit2Sharp.LibGit2SharpException : An error was raised by libgit2. Category = Net (Error).
    This transport isn't implemented. Sorry
on Raw
Agreed.  Do you know how to grab an env variable in coffeescript?
This should probably use an environment variable like `$SKYPE_TRANSPORT` or detect based on OS.
Just deprecate it instead of deleting
Since I added a new test user into data set we need to increment this by one.
Ok, I found out why I didn't do this in the first place, discardingCookies(names: String*) has the same method signature as discardingCookies(cookies: DiscardingCookie*) after type erasure since Scala uses Seqs and not Arrays for varargs methods, and so it won't compile.  So we either come up with a new method name, or we just change the signature.  I couldn't think of a better name, so I changed the signature.
Sorry, that must have gotten left in from my testing.
`creates a directory`
数量 -> 大小
可以添加translator="XXXX"
做好事要留名
We should put a copyright notice on this file
Thanks, you are right `deep.equal` does not `==`

`to.eql` is just an alias for `to.deep.equal`: https://github.com/chaijs/chai/blob/master/lib/chai/core/assertions.js#L373

I'd prefer `to.equal true` rather than `to.be.true` - I don't the property access syntax + true is reserved keyword
You shouldn't create all of these as top-level actors. Create an amqp-actor that is top-level and spawn the kids below that one.
I'd leave getRestParams protected, since it would be confusing in an open API. Whats a REST param anyway? GET and POST are REST verbs too.
Можно просто создавать диалоги на стеке.

    Dialog dia;
    if (dia.exec () == QDialog::Rejected)
        return;

И все так.е
Cleanup whitespace and comments.
Filtering is done on flowcell - should be visible in function name
Or are you referring to cases when the user in question *knows* that it exists? That I can agree on!
file_exists() is not necessary, @unlink($imgfile) on the next line should be enough
Why are you removing the private constructor? :p
Ummm. `.sass` files don't support curly braces :P
So we need to save the instance as deleting but the task manager should wait for the instance to really be deleted in nova.
What should I rename?
+1

On 13 August 2012 16:56, Adrian Nistor <notifications@github.com> wrote:

> In
> core/src/main/java/org/infinispan/configuration/cache/HashConfiguration.java:
>
> >     public ConsistentHash consistentHash() {
> > -      return consistentHash;
> > +      return null;
>
> consistentHash() is only used in our unit tests. Could we just remove it
> instead of deprecating it?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/infinispan/infinispan/pull/1236/files#r1363323>.
>
>



-- 
Manik

"In a decaying society, art, if truthful, must also reflect decay." - Ernst
Fischer
Doing the above would allow preservation of the previously removed lines
Agreed - it might be nice in the future to use a configuration variable to enable this. I think caching of the pages will prevent any big server-side issues. Anybody with more git-fu that has some suggestions is welcome to help!

I know that Github loads this info via AJAX calls rather than on page-load, so that's something we could consider in the future as well.
Nitpick, but if you could rename it to `session_key_method` for consistency sake I'd be happy!
So should we be returning `nil` from here in that case?
shouldn't these two comment lines also be spaced over to keep alignment? Personally, I feel that if the comment is too big to fit at the end of the line, then it should go above the code it refers to.
Argument validation for the grid specification arguments could be done on the python side. Thats basically in delaunay.interpolate.LinearInterpolator.__getitem__ (but we should grep for other possible references). 
Currently no validation is done. If we want to add them, we should think about the possible semantics of various cases.

 To @WeatherGod (2):  0 for x/ysteps would just return an empty grid. If you put a negative value, it would fail before reaching the loop, because numpy raises an exception if you try to allocate an array with negative dimenson.

To @WeatherGod (1), @ianthomas23 : To be exact, I was checking for 0/0 (which is nan) rather than the general */0 (which would be "inf" unless the * is also 0). 

The case with xsteps==1 and x0!=x1 may have valid use-cases, but it is not clear where the single point should be. Setting dx=0 in this case is equivalent to putting it on x0. We could, for example place it at 0.5*(x0+x1), or at x1. The stable code would fill the array with inf, which may be considered as some kind of error-indication.
On the other hand, I had actually used the case (x0==x1, xsteps>1) before, and from my point of view I was merely "extending its range of validity" to xsteps==0, without affecting the case described above.

However: I tend to think that having the "*/0" case produce x0 is actually better than the current "inf", and I do agree that it makes the code somewhat more readable. 
I'll accept your suggestion - just making sure you understand the implications.

btw: the other fix (#998) has the advantage that the edge cases are naturally resolved, and you do not have to think about all these cases (I guess it would also produce x0 rather than inf, but I did not check that).
I considered that but I found the preceding waits to be quite reliable and the video being only 3 seconds long i just kept this simple.

I don't really think that sleep(x) is the work of the devil like some people seem to.

In hindsight I don't really like the camera/music waits either as they assert on a string rather than a time object but in practice they seem to work ok!
s/Delet/Delete
I need to click icon in homescreen app, so first I swith to homescreen in L37, second I need to find iframe in system, so switch to system without arguments. finally I need to locate h1 tag in "Mozilla QA WebRT Tester" so I switch to iframe :+1:
If an above assertions fails the tear down won't run. Is this a problem?
Okay. Why isn't it being centered after the orientation change? Can we fix the root cause instead of a workaround in an entirely different component?
That's a my bad there. Should probably be just an action :create_if_missing, right?
This probably should be an interface
The issue here was the 'longer than 85 chars' notice. Should I leave the text on one line only? Or break it down as you said
Fixed in b05fe0b
don't do this first, second business, destructure and give the variables a name
Yes, I just kept it around because we'll need something to that effect when we have finally have admins for the companies. I'll remove it.
yeah, that's probably a left over that can be removed

On Sep 13, 2012, at 4:11 PM, Josh Kalderimis <notifications@github.com> wrote:

> In lib/travis/services/base.rb:
> 
> > @@ -0,0 +1,14 @@
> > +module Travis
> > +  module Services
> > +    class Base
> > +      include Travis::Services
> Isn't this a bit odd for Travis::Services::Base to include Travis::Services?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Please add a name for autoExpandColumn for the value column
Can you rewrite this line to

> where LANGUAGE and LOCALE are specific to your translation. For example, an American English translation would be ``<file alias="languages/tr_en_US.qm">languages/tr_en_US.qm</file>``.

And then I'll merge your pull request.

How did you find working with the freeseer-docs repo? Anything that could be improved?
if don't adding this check - than due to some error code after this line s not being executed.
Yeah, you can tell we read the same book, our stories start out pretty similar.
Thinking the file itself could be specified, and if it is, it automatically sets to specified.
Lol, I understand that.  Do you by chance have experience with jabber libs in other languages?  I may just look for a good Python one or something.  http://sleekxmpp.com/ looks nice.
Extend the TextureCoords struct to hold 4D coords.
Well, the other thing is, I really don't think this logic can ever be reached given how the object class is listed as a property of the method call parameter.

I'll go ahead and remove it based on your point.
I don't think this break is needed here.
Die comments die!
Some spacing issue here, no?
If this check stays in, please change it in two ways:

1: when comparing to None, use `is` or `is not` instead of != or ==. In this case, it'd be `if luid is not None`

2: Remove space between None and `:`.

if luid is not None:
Ehm, you are trying to reuse template this way? It is much better to simply define a new template and use template inheritance to remove any duplication.
If we would be really strict, this code should be provided to users which are not staff.

Probably we have to define another JavaScript file which is included only for those users. We might later on even have more stuff there.
Rename to `id`.
Now that we have mongogeneric, you could use `CreateView` here! :-)
I think we should keep the test-decoration here because it's nice to know what you're hovering over? But that might just be me.
Check Ulduar sniff I'm going to push this, there is enough proof that from 2105 Salvaged Demolisher goes with faction 2 when rided by player and many more of them.
You should take into account cases where there is more than one whitespace between the parenthesis and the bracket.
I guess something like


```ruby
user_klass.find_in_batches(:batch_size => MAX_BATCH_SIZE) do |users|
  users_for_wire = users.map{|u| user_for_wire(u)}.compact
  yield(prepare_batch(users_for_wire), users_for_wire.count) unless users_for_wire.empty?
end
```
 
could work? 

it just feels like lots is going on - it looks like what you have works - but always nice to see if it can be simpler.
Hier dus `$this->getDetector()` dan
In the end I had to switch to the `while` with `.shift()` I indicate reasons in code comments and in other comment here.
Agreed. Replaced these with ``direct_to_template`` generic views.
I think this line should be:

    if inst.respond_to?('options') ? inst.options && inst.options[:env_shebang] : inst.instance_variable_get(:@env_shebang)

it prevents reading `@env_shebang` in cases like:

    options == nil
    options == {}
    options == {:env_shebang=>nil}

it has no difference as long  as there is no `@env_shebang` in rubygems ... but can we do assume that?
You are just saying what was said. Perhaps something like "When true, the $callback is processed first when calling getConnectionString. When false (the default) the $callback is processed after the existing callbacks"
The same here. Also a map function doesn't need to be bound, just pass the according context in the map call.
Official french name, according to Wikipedia
`contains`, `references`, and `tags` are not very descriptive anyway. Without `--contains`, it's the previous tag, with contains, it's the next. Maybe, it should be 'next-reference', 'next-tag', and 'previous-tag'.
Not crucial, but it's customary to put a _ in front of classes that aren't meant to be public. Sometimes I don't do this because it's not really cut and dry between public/private.
Fine. Thanks fir the explanation!

Regarding data generation, I also doubt that a module covering the entire range of possible polluted data could be made. It is yet especially important for LTS since the complex structure of the algorithm makes it sensitive to specific data settings.
I coded a data generation module for the MCD test cases but I doubt it would be useful for LTS.
Should AtLeastOnEvent be renamed to AtLeastOneEvent?
Point.getSquaredDistance(Point other)
OK, understood; I will rework the addon and update the PR, so that it does not use the tinyXML and FileCurl from the xbmc lib directory. The URL.h, StringUtils.h, XMLUtils.h are OK to use from within an addon?

Thanks for your patience :)
My reading of the JSONObject.put javadoc indicates that this null check is unnecessary.  Please verify you need it here.
Don't swallow the stack trace.
You're right.  I had in my head that this was the RealGalaxy demo.  Sorry.
Quite right!  Might use the slow eigendecomposition way as a check, but otherwise you are quite right.
Might be worth making this a `beta_ellip`, due to the unfortunate clash with the Moffat parameter name.
Right.  In fact in our list of tasks related to code development, we had listed exception handling as an entirely separate thing that should be systematically thought through rather than only dealt with on a case-by-case basis as we add new files and functionality.  The question is, can this be done later on?  I think it takes time working with new functionality before we can completely understand the ways in which it can be messed with by bad inputs.  (For every obvious point that occurs to us now there are probably several other non-obvious ones.)  So perhaps we can try to fix glaring obvious issues now, and defer more subtle ones and a more systematic overall approach to later?
MutableMap.of("usePidFile", true) is more concise.
But too minor to care about changing it...
Up ver would be nice :smile:
this pattern will take an extra network call.  how about local variable, then check state?
Due to the translations I had done. Should I remove it or it doesn't matter?
What is tag count? The number of tags associated with a mongod? I assume we wouldn't have access to any of this information if connecting through mongos, correct?

Otherwise, is it the tags for our read preferences, that the connection presumably matched?

I think tags would be more useful than the count, which the user could calculate if necessary.
I think it should raise an exception instead of printing something; `raise TypeError(...)` (or `ValueError`, I don't know)
You can also pass :when => 2.2 for example to tell people when it's going away
@vicb ping
I only chose eager as it matches what Celery uses for a similar setting (http://celery.github.com/celery/configuration.html#celery-always-eager)
This pull request is only about fixing the directory traversal exploit in the web server from PZH and PZP.

Regarding the use of existing libraries/frameworks: Yes, we should definitely use them, as also mentioned bei John on the mailing list. Till then we do so that exploitable server should be fixed.
This should be `'use_cookies' => 1,`
@vicb as i've said - either way will work for me while we have interface.
I think I have to close the request and you need to open it again. Let's do that.
Are you intended to add logs by default in production code? I think users have to control logging
Don't we have some product docs to describe this?
The template size is the size of the enemy image.  In the case that it differs from the tile size, another calculation needs to be done to position the bottom of the enemy image on the center of the tile.  That make sense?
This doesn't seem to work either, some of the time, as sometimes a loading panel appears where the screenshot is expected to be, even for screenshots that have been added previously. In my manual test those panels sometimes appear for a very long time, so I'm not sure how to deal with that. I'm not even sure whether that is expected or a bug. It could be, for this test, that we just ignore what we see on the media subform and only test what we see after we click save changes and return back to the overall edit form.
ooops ... I need to remove this ...
Yep. I'll set content to [] and contentMeta to null.
I don't see d_w_max initialized. is it me?
I think you can just use ``str(e)`` and that works for both 2 and 3.
In `RandomizedPCA`, the data is not centered in the sparse case, see:
https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/decomposition/pca.py#L478

Can we do the same here? With the use of randomized_svd I suggested below, we would get sparse matrix support.
Is this exception case already covered in the test suite?
Smart trick. Exactly the method that you needed :)
For what it's worth, it does not seem to have much overhead:

```
In [1]: import numpy as np
In [2]: from sklearn.neighbors import KNeighborsClassifier
In [3]: X = np.random.uniform(0.0, 1.0, (100000, 4))
In [4]: t = np.random.binomial(1, 0.5, (100000, 1))
In [5]: model = KNeighborsClassifier(n_neighbors=5)
In [6]: model.fit(X, t)
# With the previous `mode` implementation:
In [7]: %timeit model.predict(X)
1 loops, best of 3: 2.93 s per loop
# With the call to `predict_proba`:
In [7]: %timeit model.predict(X)
1 loops, best of 3: 2.92 s per loop
```
tu as essayé de mettre tout ça dans typing.py ?
This usage is no longer accurate.
This should probably be a switch... and should possibly assert on 'none' as well as unknown, I think these should be replaced by the time they reach here?
No but keep it in case of next ROC. They keep using -rc instead of _rc
Op 3 okt. 2012 22:51 schreef "Greg Sutcliffe" <notifications@github.com>
het volgende:

> In puppet3/PKGBUILD:
>
> > @@ -8,8 +8,10 @@
> >  # Contributor: Niels Abspoel <aboe76 (at) Gmail (dot) com>
> >
> >  pkgname=puppet3
> > -pkgver=3.0.0rc5
> > -pkgrel=1
> > +_rc=8
> > +_pkgver=3.0.0
> > +pkgver=${_pkgver}_rc${_rc}
>
> Is there any need for this now that puppet3 is released?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/GregSutcliffe/aur-projects/pull/1/files#r1755256>.
>
>
This should only be required for running. Make the check later in _elif (args.command == 'run')_, print a message, and exit with a retCode != 0
From the docs: `Can only be modified when this socket is in the INITIALIZED state`
`registerForPushNotifications` is iOS only, would make sense that these are too. Better to check with Appcelerator.
screen_resolution doesn't seem to get initialized before being referenced
Exceptions do get logged already.

Ti_Debug is fine for now but there is a task to implement a proper logging mechanism for the whole app and qt is not available throughout the lib so it might need to change
Allright, good changes.. still could you split it out of the HSEARCH-1025, HSEARCH-1026 scope?

your fixes need backporting.
`coverd`
If packed (and that was deduced automatically) then the rows will be kept in memory - so there is no point creating a key.
This is not being used here... If this is part of a later patch, why not wait?
Maybe it's particular to our usage scenario, but the fact that every build is working on a given branch (whether it's default or any other named branch), made me think that everything should be working as before by just pulling the requested branch (or default), with the benefit of transferring only the changesets we are interested in on every cache update.
@peterbe re: sort vs sorted, the python sorting HowTo reports sorted is "slightly more efficient": http://wiki.python.org/moin/HowTo/Sorting/
Run this against jshint. It looks like there are variables defined without `var `
typo: rejecet instead of reject
The problem here is that if $controllerName is a fully-qualified class name, this test will fail, resulting in a false negative.

This is particularly relevant considering that the new view layer encourages having routes match to fully qualified names as a best practice; this should always work.
Same comment as above -- "function", not "methodname"
Ok, all changes done.
Would you prefer it to be different?
C'est une classe qui est destinée au bloc qui contient l'image, et non l'image elle-même.

Alors que les float font tous le travail d'alignement auprès de la bordure sur un grand écran, ici le float est à none, et pour garder l'alignement auprès de la bordure, je dois rajouter le text-align.
@shacker could you fix the indentation in a follow up PR?
built-in system imports should come first, separated from 3rd party imports by whitespace, separated from project internal imports by more whitespace. All alphabetical of course ;-)
`array_diff` could be better ? Moreover what is the exact intended behavior ?
When mock ups change there should be an Issue created of what has changed and what actions developers need to do. If it is a simple image change then a pull of the new images should be created and merged by a developer. This way no changes "sneak" by and we have a full change log of all design changes.
remove the extra space after the parenthesis
given the amount of time I am told that this issue has been under discussion, i don't think we're going to fix it all in one pull. the question is, does this pull represent an improvement over the previous code?

if i am not mistaken both methodologies would result in the same number of lines per test case. the only question is a) new helper class or b) slight deviation from the Page Object Model.
I did not know you could do this :-) Does it work?
do you really need this empty string stuff ? Users without a token should have ``null`` in it (the field was not nullable in your original PR which probably explains this thing)
no need for the 4 lines here let's just do: `res.setHeader('Content-Range', 'bytes */' + stat.size)`
But you're right that it's a good idea to cut out invalid fields when we make the test cases and map base fields to the item-specific field. I'll implement that in the test harness.
I'm pretty sure we can always get back to it.  Wasn't this code also in the original Perforce branch?  If so we can certainly get it from there if we ever need it as well.  Ultimately, I think our query string handling for links might get rather complicated, so we might need something completely different in the future anyway.
Can you pass camera.position as the last parameter to multiplyByVector instead of cloning into it afterward?
I started investigating this and am wondering how you'd prefer to see it implemented? e.g. either...
- a Core/loadXML.js in the spirit of loadJson.js that does an xml to json conversion e.g. based on http://davidwalsh.name/convert-xml-json.  I did a quick test and had to modify that example code to get it to work.
- do a straight XMLHttpRequest in the imagery provider and interrogate the result directly.
I'm thinking a loadXML might be preferable as it could start to centralize any XML handling logic.

Would you agree with this for edge cases?
- user provides different values in 'description' to those in the xml: Description overrides xml. (Alternatively xml could be considered the absolute truth and overrides description)
- xml fails to load but there's enough info in the description: Considered OK, but silently log a warning.
Honestly I don't see how that's useful at all with an Ellipsoid.  An ellipsoid is defined by its three radii.  So if I could using something like a Cartesian in the static ellipsoid methods, that might be useful in certain situations.  But that won't work, because of all those derived/cached values that the methods expect to exist.  Someone trying to use a non-ellipsoid in the ellipsoid methods would have to know way too much about the internals of the Ellipsoid for it to really be practical.
> As we discussed, we may want to expose this or base it on number of tiles. 10 ms is a really long time given that we only get 16 ms for 60 fps.

I dropped it to 5 ms and made it configurable.  Well, it's a private field on CentralBodySurface, which makes it pretty hidden, but it's potentially configurable in the (hopefully unlikely) event that you need to change it.

I also changed the way the processing works so that progress is guaranteed to be made each frame.  Previously, on a sufficiently slow machine, terrain and imagery might never load.
Thanks, all done.
Needs doc?
So this is a little nitpicky, but slice requires a start index, it's not optional.  undefined is getting coerced to 0 under the hood, so it works, but it is probably better to pass 0 explicitly.  See http://www.w3schools.com/jsref/jsref_slice_string.asp
split android, harness, and tiapp.xml into separate args to path.join
shouldBeUndefined
This would really benefit from the checking of digits in my proposed function above.
If you make this change, then you can probably do away with vectorize in BicycleDataProcessor, is that true?
"If you want to restart Jetty after each test class, set startOnce to false (...)"
this is useless (we already have the signature in the code) and breaks the phpdoc as it would be considered as the short description
Should probably destroy the `originalTitle` data attribute while we're at it.
simply ``if ($dryRun) {``
Keep in mind runtime may use dirty hacks that have some historical origin.
 I'm not sure _memset32 can be found on every architecture/OS.
Why not combine these two overloads? As far as I can tell, their implementations are identical
Absolutely. That said, using opSlice(void) on a range is bad form, because it isn't a member of the range interface.

Thanks again for reviewing.
Should get rid of the module_load_include() on line 7?
Sorry, commented out the spec. Presence of this validation does not allow me to rebuild data from scratch yet.
Backported this to Froyo, was missing this function.
Will all these artifacts always be the same version?
Javadoc to note that the caller is responsible for closing the cursor.
see the comment on descriptive variable names in `saml_spec.rb`
`else` should be on same line with `if` close bracket `}`
method need header comment
this should not be left in as the default.
Just open the tests and try to open following meta4 files: kernel.meta4, iso_encoding.meta4 and utf_encoding.meta4, I get parse errors
Is the exclamation mark a typo, or is that there on purpose?
Why do we need the migration code here now? Can we not safely remove it all together?
I think that's a great idea. What's the best API for that?
please always use this line (CMath::lgammal here)

gamma is deprecated too :)
It should be great has remove_doc(Id) method here too.
Stylistic question mostly. There's some duplication across versions and I wonder whether it would be better to factor out the common parts.
MINOR: Comments missing.
two ls in ...collector
Yes that sounds good. 

In section *Using ResultTransformers with the XsltPayloadTransformer* there is a similar description. 

Also, the note also applies to Document type payloads:

<note>
If the incoming message's payload is of type String, the payload after the Xslt transformation will be a String. Similarly, if the incoming message's payload is of type Document, the payload after the Xslt transformation will be a Document also. 
The specified ResultTransformer will be ignored with String or Document payloads. 
</note>
Can we add some assertions here on the type of error and message? Parsers with crap error messages are a recipe for frustrated uses when they can't figure out what's wrong.
OK, I'll check it. Thanks
Do we need to restrict this to PHP 5.4.0 versions only? Or do PHP 5.3.* versions also affected?
OK. But then you can simply do as jQuey supports. A plugin which operates on DOM objects, and some methods which are accessible through jQuery. So that you can do `$('#plot').datastream(options)` or `$.datastream.allMetrics()`.

And you can also then have `$.datastream.configure(options)` for global configuration. Similar to how jQuery has for Ajax.
Кстати о терминах. Не подскажешь, как адекватно можно перевести "invokables"? Всю голову сломал.
relative project links doesn't work (on github) in markdown files in project root, use whole url instead
To break line in JS you can use +

for example ->
var myString = "hello world "
                         + "how are you "
                         + "today?";

We try to keep a 80-120 char limit.
these changes should probably be left out of the change
`)` into a new line.
Probably make sense to move the status code assignment into this `if ... else ...` block now, instead of the existing `create and ... or ...`
where's my name :(
Not really sure if dash is the best option here (another idea was to use a colon, but dash seemed to be more appropriate).
These constants are duplicated in Geolocation.yml, above, and also (as noted in the above diff) seem to be redundant with existing constants.
I think you can (and prolly should) leave off the TYPE_STRING stuff.  That's just an internal detail of how we call the constructor.  Also "id" doesn't make sense.
```
/**
 * The base class for all non tab Titanium activities. To learn more about Activities, see the
* <a href="http://developer.android.com/reference/android/app/Activity.html">Android Activity documentation</a>.
 * 
```
removing account shouldn't be done on the UI thread. Since we already have an AsyncTask, removing the accounts here.
sorry, typo. fixed.
why removing the ``rabbitmq` key ?`
EOL changed?
Aren't showOverlay and HideOverlay our own code from the webplatform?
Fine for now, but needs a better long term solution.  Opened blackberry/BB10-WebWorks-Framework#134
agreed, armstrong.utils.gfk?
would be more readable if you put comments above the line like

```
...
//display the title
'title,
...
```