labofsahil/github-event-dataset-2012 huggingface dataset:
> EDIT: Actually, rotation and scale needs to be there for getting proper results. If it needs to be customised I think it's up to the developer, after > all, it's not a super big method, they can just copy and customise.

Sorry, I should have been more clear. Sometimes you want to apply the rotation and scale of a matrix, but you don't want to apply the translation. For example, suppose you have a vector that represents an axis and you want to convert it to the local space of an Object3D. In that case, you only want to apply scale and rotation. Applying the translation would be very wrong. In other cases you may want to convert a vertex point to an Object3D's local space, so there you would want to apply translation.

I agree that in the end its up to the developer. I have no idea which of the two use cases is the more "common" use case. I suppose you just pick one and see how many people complain :).
I've got most of these changes in my magic-__new__ branch.
What is pug?
Nice and clean, thanks!
Updated for 1.0 now
Why is there just the URL of this git in the plugin file?
oh yeah 9 not 6. Too late yesterday ;)
Yea that sounds like the best theory honestly. Another config variable is more memory wasted, namely for something as simple as a javascript library.
`0.upto @d.length - 1` is clearer
thanks, i just added that last minute to make sure people know why it is not working...
Hm, because it simplifies the next line in the code, where we remove the base from the path---ie we don't have to check what is the separator of the path.
use windows and you will see.
you are right. :P
Hmm, that's a good point. I suppose you are right. Thanks!
OK about the id, but not about the index. At least that's not what javadoc says :)
Could we use `pushd` and `popd` here?
Remove aura.
Even when it's only available for two minutes, it would be very easy to sniff for <sparkleshare> and <accept_url> and post the attackers public key. So I think it's best to force HTTPS.
Unused by the SPK. And stop + start do the same thing
"高帅富",我了个去
should call ... **to scroll the viewport** after...
Well, the wonderful thing about consistency is that one gets to choose what one wants to be consistent with :)

MarkDown doesn't use triple backticks anywhere, so using them would only be consistent in the weak sense of being consistent with TiddlyWiki's use of triple braces.

My preferred option is to use triple braces:

	{{{image/svg+xml
	Some text
	}}}

It would be nice to also be able to do:

	{{class{.extension
	Some more text
	}}}

Anyhow, I am investigating if this can be done in a compatible way.
not really. It's an interesting idea but I will make this a proper class and a better implementation
Sorted. thanks!
And I did test, FYI.

Maybe you should be more careful in reading what something does before throwing accustations and reverting code?
Sorry, pushed wrongly. will delete this and do it again
Is it possible to include the file and line number of the duplicate resource? Otherwise, it's hard to tell from the error message where the problem lies, especially because I'm using a tag to bind the exported/imported resource, and the tag isn't in the error message.

<pre>
$ puppet agent --test --certname host3 --server sirrus.puppetlabs.lan
err: Could not retrieve catalog from remote server: Error 400 on SERVER: Another local or imported resource exists with the type and title File[/tmp/test] on node host3
</pre>
OMG! Documentation!
This is unacceptable, people might be able to understand what it does.
These functions should eventually get merged with Util.java which has much of the same functionality.
LC_ALL jest dużo pojemniejszy i mieści w sobie m.in. ustawienia wyświetlania walut i sposób wyświetlania numerów telefonicznych... do naszych potrzeb zbędne. Tak samo jak UTF w angielskich nazwach dni tygodnia. en_US nie wszędzie musi być, a bez C nie wyobrażam sobie systemu :)

A LANG=C to moja ulubiona sztuka na laptopie żony, gdzie system ma polskie locale. Jak się jakiś program wysypie, to zamiast nieudolnych tłumaczeń komunikatów o błędach mam to, co twórca miał na myśli. Od razu wiadomo co dolega, a jeśli nie, to google lepiej wyszukają.
Yeah; the only things using dicts are the options > tagger script page and the tests; both of which I have changed now. :) Thanks for the feedback!
lgtm :-) thanks zac
Wow, that was fast. I can confirm that fix works now :)
I'm adding plugin support to Tomighty right now.  Your database feature is a perfect candidate to become a plugin, don't you think so?  :-)
Yes that's what I want, but cimports don't work in cython utilities.
CMSUI needs an unthemed response for views that must render in overlays. I suggested to Izak to use a viewlet to disable the theme but the viewlet should be registered against a skin layer not a browser layer as it currently is. Thinking about it some more though, this will be much cleaner as an IBeforeTraverseEvent that always disables theming in the plone.app.toolbar skin layer, removing the need to check the header.
I guess that this is the main part, that makes it all work, right? This is very clever (in the good sense of the word). Congrats.
OK, running 'jruby -S rake coverage' runs the specs now and it also generates a file 'coverage.ec'. However, rake aborts before generating a HTML report. I assume it's a native Java exception that still goes through, I'll investigate further!
automating sounds interesting and i'll definitely look into this. i personally don't think it's that hard to remain a human-powered changelog
and there are certainly problems with automated solutions. like ... cleanup/documentation commits, bad commit messages, etc which
shouldn't end up in a changelog.
Hmm... not sure about the syntax... but yes, `'*'` is probably a lot clearer than `.`. :D
Not so much "ignore" but give them an infinite distance from the user.
my preference would be to do 

	setMenuItemState('go-back',  currentHistoryIndex > 0 ? true : false , true);
So can you tell @Venugh to see this comment please I cannot reach him he has not set his email address nothing ... If he can look to this comments from his another project? https://github.com/Venugh/TrinityCore/commit/258799483ffc127376f60442e8891633be02efe6#comments it is crashing ... I am testing it now thx :)

And I will be gone as i came :-)
That works not...
Well, those settings are inside the bravo kernel but were missing from the htcleo board file. I was guessing that this might give us better performance with video and/or audio encoding/decoding. Right now I can't see any improvements though. Either those settings are actually not needed or the new base is actually incorrect and should be set to the old base.
How is this number determined? Do you just change it until it feels right?
das heißt im 0.10 tag von luci jetzt anders
En array returneras
I was seeing reproducible reboot issues occurring during high CPU load on the Galaxy Mini. I disabled it on all of my devices for that reason. Smartass seems to still work ok...
There's a syntax error on this line.  It's missing a comma which would cause it to fail to compile.
Sure - I'll update this. It's my first time with github - I have no idea there's so nice tool like the diff annotation and found a comment to be option to make some extra notes.
Eh? I think you're missing the point of the change. The actual format of the config file itself has not changed - I had to change the way it is accessed with the new configuration in order to *prevent* it turning

    a.b.c: true

to

    a:
        b:
            c: true

The former is how it should be, and how this change makes sure it is.
If test it on unmodified **JdbcMessageStore.java** we'll get messages here...
The alternative @Sanne is to always put this logger decorator in front of the `GridDialect`. But after your perf review, I was getting concerned that such a decorator would cost too much. We can relax that.
Can you change this to mention that the product id should not change across different packages
zImage needs to use RedbendUA to work atm you are writing it raw.
It's just the "standard" in Javascript. Or, I guess that should have read 'standard' ;)
It's a fix on the en-us only. This Language is supported by us, others are supported by External Devs.
Looks pretty good overall. However, one queue for the entire class doesn't quite make sense. It should be an ivar and therefore be a per-instance queue, to preserve the same semantics as `@synchronized(self)`. Can you make that change? (Making `defaultCenter` use `dispatch_once` is very nice, by the way.)
Was testing to see if this function was being run, accidentally left it in.
On Saturday, February 11, 2012, Trey Hunner <
reply@reply.github.com>
wrote:
> I just thought of another solution to this problem.  If we do need to use
`;` in a key/value pair in the future we could add quoting or escaping.
 Thoughts on this versus removing comments at ends of lines?
>
> Also, should we allow using `#` for commenting at the beginning of a
line?  Currently this is allowed (due to inih).
>


Yes, we could use escaping. And I suggest to add a new option to turn this
escaping on or off.

Keep sharp as comment symbol will meet some people's habit. Let's keep it.
No real changes on functionality, but the code is more clean to work
but it is in the android here on github (manifest)
I'm wondering about why you created this helper versus using 

    = render :partial => "about"

in the haml. The example is from the bottom of [the HAML Tutorial](http://haml-lang.com/tutorial.html).
That comment got mangled. It was an XML injection to delete index.html. `</Key></Object><Object><Key>index.html</Key></Object><Object><Key>.png`
Are you sure this works correctly? Isn't && higher priority than ==?
Yes, Patrik, you are of course right. I shouldn’t trust my reviews today; thanks a lot for catching this!
Why not use PoisonPill?
Remnant from the old API which also handled ProtobufMessages. Should be removed.
Ah, that is what I call geeky. Love it.
But don't create an entire ActorSystem for that, it's extremely expensive.
User cache needs some love to be used and useful
aren't we getting rid of invite_sender_id?
And (surprise, surprise) also do_direct_git is very, very close to its siblings in SVN.pm and CVS.pm, so we should try to find a way to unify them. Either by moving shared parts into new functions. Or by moving the parts that *differ* into new methods which are overloaded by each VCS class, and which are invoked by a generic do_direct_vcs() method. Or even a mixture of both.

The differences essentially are these:
* messages show "git", "svn" or "cvs" -> sounds like a good fit for a $vcs variable that is set accordingly, and used in messages.
* the actual command that is executed to update "the top level stuff" (svn/cvs) resp. "fetch & merge the remote repository" (git)
* some code that is executed once for each entry in the SelfUpdateTrees config var.

That looks indeed as if we could refactor the three methods. Good :)
https://github.com/kivy/kivy/blob/master/examples/widgets/softboy.avi already exists maybe just change the source to 

    source: "../softboy.avi"

instead of adding the avi again? Ditto for `softboy.png`
Thanks Marek.

I have an update that switches to StringComparer as you suggest, and will push an update later tonight when I can figure out what I am doing wrong with git.

-Mike
The docstring and code suggests that this method does not return a value so removed unused 'report' variable.

Not sure what commented out line: 227 was about but thought I'd clean that up while I was there.
Fixes a bug. The start function checks if model ==  null and throws if the model is null because it can't start without a model.
I am not even sure it is necessary anymore. I will test again without it.
It's not the cluster's role anymore to do the routing since the action registers themself to protocols now. We should probably add a test in TestProtocol to test routing there though ;)
I think addAsServiceProvider() is a better way and we use it in CDI TCK. The advantage is that ShrinkWrap container itself can resolve the right place. AFAIK the WebArchive uses WEB-INF/classes/META-INF/xyz.

See also SHRINKWRAP-266, ARQ-753, ARQ-818, ARQ-819, ... :-)
It's bad idea to modify buffer directly as result is unpredictable on some platforms. I think that one of the problems of CStdString.
Better to use "new char[size]".

And if you change string buffer directly for whatever reason, you need to update real string length as string class may still "think" that actual string has 0 size.
COLOUR and COLOURS --- just kidding. Pfft, Amurica.
Use logger here.
is this being used?  else remove
Na verdade tava desse jeito, consertei e esqueci de consertar no post.
join is smart enough to deal with things like joining "this/path" to "this/one" in addition to "this/path/" to "this/one" and also is smart enough to use backslashes when on windows, and other corner cases.  I usually always use it when dealing with paths and can always be confident that I will get a reasonable path from it.  Maybe "safer" isn't necessarily the right word.
Yep, because of UIKit. Odd, but I didn't call the shots and changing it now would potentially break many things (bad coders...?)
It's not a getter though, or a readonly property, it's a method.  You could argue that any method that doesn't return void could be accessed with dot syntax, and they can, but they shouldn't be.
ARRAY_SIZE(trace_codes)
do you think it's a good idea to emit `error` after calling callback? I have no idea how this API could be useful for anyone...
Please remove all code that's currently commented out.
Yes - The compiler gives an error that multiple overloaded methods cannot have a default value.
Usage of existing variable here?

```-$(RM_F) $(GEM_INIT).c *.o *.d $(GENERATOR_BIN) $(GEM_MAKEFILE) $(GEM_MAKEFILE_LIST) gem_init.a $(GEM_GEMSCONF)```
That line that tests 't8' and 'NA...' already existed, but I can go ahead and take it out.
Mostly it's motivated by my experience that every time I write a complete test it turns up bugs, so I'm trying to push things that way. The test here will do, but it would be nice to make something more complete. If you are pressed for time, and who isn't, this can go in as is. Writing a solid test for this looks to be non-trivial, but another PR with such a test would be welcome.
Sorry for the back and forth, but now that I see this in context, with the other properties camel cased, I realize that `getFeatureInfo` (instead of `getfeatureinfo` as property name would be more consistent.
отступа не хватает
When I ran the tests, there were only references to :lock

But I don't know if the method is receiving a hash with indifferent access.
Using `became.type = klass.name` doesn't work if you set the inheritance column to something other than `type`.

Setting `inheritance_column` to nil is an edge case that has to be considered, I will write a test for it...
Right I will just drop the private
Can you changes this to have a field with the original exception?  Like this:

```ruby
class ParseError < StandardError
  attr_reader :original_exception

  def initialize(message, original_exception)
    super(message)
    @original_exception = original_exception
  end
end
```

This way we don't lose any information from the original exception.
Let's get these into the default scalac.args.quick
next time you're in the 'hood, consider renaming `qual1` to `qualAdapted`
Ah, :power just told me

```
scala> AnyRefClass.tpe =:= ObjectClass.tpe
res1: Boolean = true
```

so yes, these symbol test could be rewritten to `_ =:= AnyValClass.tpe` and `_ =:= ObjectClass.tpe`, respectively
I agree that's clearer. I can't think of an example where it would have different semantics.
A mapping from the original symbols to the new ones would also do the job.
indeed -- on it
@chrisroberts I considered that, however, there is a good chance the receiving handler will not expect the standard event json, possibly causing endpoint failures. I would like to experiment w/ "partial" transformer failures, exiting after outputting some data. We could make it "fail fast" if there is a transformer issue, perhaps by passing a block to be called on success.
docstring with examples, please.
the most general what?
I will remove it from there.
again, I would recommend a for loop
You should be able to pass the href to the container it will handle this for you.
I would suggest to change line 64:

-  node['title'].missing = title_missing
+ node['title'].missing = node['filename']

or something similar (I don't know if there is "filename" key in dictionary)
Oh, BTW - can you help him with [retray](http://stackoverflow.com/questions/9735336/event-machine-for-parallel-api-requests/9735693#comment12383353_9735693)?
just do:

node_dict[thread.name] = thread_to_pydot_node(thread)
`returnCode` should be declared as an `NSInteger` here.
See QA comment about `shouldAcceptDateOnlyRanges`.
This is the number of connections currently in the pool to this host that could be grabbed to be used, not the amount currently in use.
I've removed this here and moved a condensed version over as a hidden comment TODO in the applications page
It is for links to other parts of the the website in the navigation bar. Hence for links and its describing to be next to the index link.
While certainly not required, it might be better to use ternary here:

```php
meta_refresh(3, (request_var('backtopost', 0)) ? $post_url : $redirect);
````
In case of spamers you dont really need to let them know. And if I as an admin decide to delete a user hard (current way) it doesnt send them any information either. So if that is done at all, it should be optional.
Why? It's just checking that variable names resolve properly, the actual files are unimportant.
SQLite3 3.0+
Also consider renaming the language key. What is "forum forum"?
I thought the idea of setting the parent to the style name was to make forking of the style easier to novice people. Not sure whether this is a valid reason.
Sure, I'll reuse the regex in get_varref.
Ironically I suspect that when this language key was written it may have reflected the situation perfectly: phpbb supported mysql 3.x and 4.x and only 4.x had fulltext search. Currently of course the proposed change should be made.
Yea, this is probably the right thing to do so windows and lint work without hassle
fixed in 04bd91e
De văzut ce excepție dă o listă la remove pe un element care nu este în listă.

În loc de None, de returnat [] sau players
Can be set to an error page, resembling a 404 page.
Different api for the same function name across files seems like it's asking for bugs.
In general I'd like to see us hide code of this type behind a config flag. So we'd see this if we had debug/verbose on but wouldn't run the check otherwise.
т.е. 2е поле в таблицу бд со статусом активен/неактивен?
я с нодой раньше не работал, поэтому нужны небольшие пояснения)
1) несколько нод не могут работать на запись/обновление с одной базой, или просто очередь на запись будет слишком большая?
2) согласен, интервалы сделаю. по поводу отдельной таблицы, нужна инфа по каждому промежутку? не лучше ли просто инфу за день делать и все? 4 сотни записей в день на каждый баннер получается же?
3) помоему можно и без крона. что если нода после записи своего интервала будет обновлять инфу по баннерам? там 1 апдейт запрос только делать, а причину перехода в инактив тогда будет считать php скрипт при первом показе админу и заносить в базу
Don't use Magic #s...
http://en.wikipedia.org/wiki/Magic_number_(programming)#Unnamed_numerical_constants
"Unique values with unexplained meaning or multiple occurrences which could (preferably) be replaced with named constants"

var WHO_BMI_UNDERWEIGHT = 18.5;
var WHO_BMI_NORMAL = 25;
var WHO_BMI_OVERWEIGHT = 30;
Iris already has an established standard. Multi-line docstrings start on their own line. Please stick to that convention. If you feel the documentation is not explicit enough, please propose a clarification.
This is interesting. I expect cartopy to have sensible behaviour without this. What happens without it?
I'm not sure I understand.
The changes in the PR enable us to load orography fields. It used to fail.

Does this affect your question?
Good point. I'd been assuming the merge would be successful. I'll add a warning if the merge wasn't completely successful (i.e. it resulted in more than one cube), and make sure I always pick the last one.
even less chars :+1:
group_outputs/2 may no longer be with us, but three references live on in the documentation.
This should read... "iterate through"
I don't think the presenter should be defined inside the view "JobAnnounceView.Presenter"
the space is still missing between the ``if`` and the brace
Made this change locally and will await your response on the other point before I push again
The `binaryOp` overloads should probably all be inline, and forward their arguments and return values
It'd be a bigger change that way, and I wanted to keep this one super simple. The other tasks all `expandFiles` *inside* the task function, and I wasn't sure how deliberate that is.
right, I'm reverting this to the behavior from before I introduced quickReady a few commits back. Nothing is relying on the return val. It's was/is just a byte saving return.
I just want to use third parity objects like `iFoo` and pass newcap errors for `new iFoo()` calls.

Disabling `newcap` is real, but not so good solution.
In my experiments, my implementation of the Student's-t-CDF was more accurate (see the comments in my implementation, i.e., in student.cpp). However, it only works for natural (as in natural number) degrees of freedom, not for rational ones. That's why my implementation resorted to boost as well in non-natural cases. However, a natural degree of freedom is far more common.

At this point, I do not see a reason to replace my existing Student's t implementation.
I suggest `\mathit{iteration}`, otherwise LaTeX will typeset as if it was a product of all the letters (note the different spacing between letters).
This file is a Wix template for the MSI installer.
yes. i am using this because we dont have any hitpoints regeneration values at the moment.
This reminds me that I think we need to straighten out our logging situation. Playdoh uses commonware.log I think.
This doesn't include the additional text "Note: while your feedback will be publicly visible, email address are kept private. We understand your privacy is important." that was in Cheng's ascii mockup. Did that get nixed? If so, we should add a comment to the bug about that.
> You, by refusing to merge this patch but insisting that it is absolutely necessary.

This is something of a leap in logic...

> We do not merge patches unless they are going upstream.

Again, more assumptions about the situation.
@mistydemeo just pushed a new version with `depends_on 'cmake' => :build`
Space on both sides of `<`
Not possible. GHC is written in Haskell, so one has to start with some binary distribution of a GHC to build it from source.

That is unless there is a sufficiently advanced Haskell compiler written in C that can do the job.
I prefer

"Remove the logged in users vote on the object."

But perhaps something should be said to make it clear that this function can also be called without problems, even if there is no already existing vote?
Changed the attribute name to 'colspecs'
What's a session handle? Comment maybe?
Sure - style/habit.  You're right, it's easier.  Done.
Use `{@link }` to link to this inline in the message rather than `@see`. `@see` is an abomination.
Instead of a special username, I'd suggest to introduce a --path or  --filename parameter.
Why you are removing font dialog?
Thanks for the explanation. It cleared it up a lot and additionally it cleared up other Batman things I didn't fully understand.
This may have also gotten some odd linebreaks inserted, causing the huge diff.
Same cleanup. No need to wrap the event handler.

``$(ProjectManager).on("beforeProjectClose", _beforeProjectClose)``
I changed these because it's a lot cleaner.

FWIW, I know that over-qualifying selectors makes style rule cascading slower, but it seems like more qualifiers *could* (I'm not sure if jQuery does) speed up tree searching. I'll save that for a research topic :)
Should just reference "listSelector" like the other cases below it
Any particular reason we need this check -- is it bad to show the icon when running a unit test?  Seems like something we might even want to test for eventually...
These magic numbers should be defined as enums,
ContextMenu is exported, so is this really private?
These aren't actually being used by our highlighting, I think--should we remove them to avoid confusion?
Well ... it works. But this is a bit of technical debt. Would be good to implement https://github.com/ajaxorg/cloud9infra/issues/2995 soon.
To answer your questions:

1) I checked mu and there doesn't seem to be any way to build it on windows.  Though I imagine it would be possible to build it using cgywin.

2) No, setting mu4e-bin-binary should be enough.
I suppose this is done to allow you to create a new BatesProcess without passing arguments. This is not really clean and dangerous. One solution I started using is the following: add support for **kwargs to the __init__ method. In the kwargs, you use a keyword noalloc to clearly state you are creating a new Python object but with no underlying C++ object.

```
class BatesProcess:

    def __init__(self, ..., **kwargs):

        if 'noalloc' in kwargs:
               return
```
also an include.
The `"11"` requires an extra (optional) variable that it's missing. Were you trying to scan for the block?
Probably you want `ProcessFormView` here?
Move the require.js text plugin out of src/text.js so that we don't need to include this filter in the makefile
You can use process.env anywhere, so you don't need to pass this
Actually, do we even need this outer scope to include `window`, `document` and `undefined`?
My personal testing shows you could make this value something like 10 for a better scrolling experience. 30 makes it really slow when I'm scrolling a lot.
we should probably unlisten trackeventupdated here so we don't have a ton of listeners left over when the user keeps opening/closing the editor
This probably doesn't need to be a property defined like this. Anything wrong with just having `this.projectHistoryState`?
this would fail lint, why not pass `window.Popcorn` into the closure so you can safely use Popcorn the whole time
Another global?
No `px` on 0 values
Are we going to enforce this everywhere? I like it, thought I forget everything it enforces.
Well, `parents` is an array of plural scaffold names, so I assume you mean it doesn't singularize octopuses/octopi correctly. Regardless, I'm going to go ahead and assume that no scaffold will ever be called octopuses :P. Regardless, all that matters for a database key is understandability and consistency, which I believe are both maintained here.
before removing the dependencies, and  no 'metadata_path' file, it's 'error'  when I run "doit".

I think it's not required, because I writed the meta into .rst or .md file, so I remove it, then there is no error again.

If  the code is wrong, could you modify it?  I can't handle this.   :-(
style: Are C99 comments ok?
:trollface: ?
Catch the appropriate exception here.
Left only to be backward compatible (Nexus Core is not using this field, but some plugin might).

Change detection should be done based on "generation" not on "change timestamp" (this is millisecond resolution)
`At(i, j) = A(j, i)`?
When two placeholders are used, please use this notation:
_("Params: %(a)s and %(b)s")  % ({"a": foo, "b": bar})
Translators will thank you.
Sounds good. ACK
We shouldn't need to set user_default_org=nil here, since we assign it a value on 90.
It would be nice to have a description of this script's purpose. The name communicates a bit, but I'm sure there are details or a rationale for its existence that you know and that I don't want to have to guess.
we no longer need this. Before this has here because "json" was included in 1.9+ but not 1.8.
Does firefox aurora work magically? That has not been the case for me even when preloading the profile.
Good idea, I added a constant to the top of the file that you can then absorb into the `ConfigurationItem` stuff.
Nevermind -- doesn't seem to work as advertised, since those aren't actual labels.
this code is confusing, but it was actually accepting 'd'.  I've changed it to be somewhat clearer.
个人更喜欢用 'a' => ture, 'b' => true 来表示。
不过很小的问题，个人喜好，可忽略。
其实是这里直接new Node然后调用type会有点怪，我觉得可以在Node或者Data里封装一个静态方法，就是取某个Id的type，如果取不到就返回null。然后这个方法里面去try catch。我来改吧。
It's just a more concise way to declare service_up/4 with default options.  As far as I know, the new service_up's are going to be used for more than what it is currently, so I just tried to be nice and not require the options.
You were the one who suggested to remove the fallback, when I added a Win7 compatibility for it :-P.
This needs to be:

return boost::filesystem::exists(StartupShortcutPath());
I keep thinking it should be ```$dnum = "(?:[0-9]*[\.]{$lnum}|{$lnum}[\.][0-9]*)";```
"Thrown when objects are removed"
what do these return values mean? this is not documented anywhere
#define lookupHost_SOME_MEANINGFUL_PHRASE 1
and why not using ``/`` simply ? It is no an issue for filenames as we are on 5.3+
Missing space between the last `.`
No - the latter has another class as well....  don't think it can be made significantly clearer.
is this correct, should it be true?
The other thing to try is `pd<tab>` - in a clean kernel, the only things starting with `pd` are magic functions, so it should replace it with `%pd`. I think it will get this wrong if you switch True/False.
probably better to use ImmutableList.builder as it supports adding Iterable contents
This `if` is starting to get unwieldy. Is it time to pull it apart yet, or should we wait until it needs one more clause? :smiling_imp:
BTW, I agree. I felt a bit shitty writing this (not even realizing just how inefficient it potentially was) but I do think it serves a purpose so I added it. I'm glad to get feedback on it though!!! :heart: If we could avoid the inefficiency (instead have something like a max size threshold to load blob) then I think it would so rarely come into play that the times when it was useful could be worth it.
I have not defined it here, because it is defined below.
This should probably be `h`
Is this what we want? For non-parsables to never be stale:

     >>> 1 > Date.parse("Barf Barf Barf")
     false
I guess this is what we want on windows.  Carry on.
Looks like these two `if`s could be combined into one with an `and`.
no |safe
If we can change the URL, you could put it in /media. If not, yes, you'll have to add it to urls.py, but you'll also have to create a view for it because you need to serve it with the right mimetype. So you can't use the `page` helper, you'll need a real url like this:

urls.py

    import views

    url(r'^foo/bar/baz/$', views.privacy_thing)

views.py

    def privacy_thing(req):
        return HttpResponse(mimetype="foo")

***This is untested, I can't remember how to set the mimetype, but it's something like that***
Same thing I mentioned with topic images.
Ah, this is PyQuery magic. Carry on.
I don't think these length == 0 checks are necessary, since it's an extreme edge case to set an empty array as property value, and in that case it's fine with one extra new primitive[]. If anything this just adds an unecessary if statement IMHO.
What do you think about havin this return `ok` and then matching that in `batch_reindex/6` so that we crash early if rabbit is down or we encounter some other error along the way?
I don't understand why we're calling fetch_client_or_user here. Are we actually doing any validation of the request? If not, let's organize it differently.
This would make the method's client more complex:

Before:

```
$manager->getConnection(function() {
   // ...
}, $host, $port, $enableHttps);
```

After:

```
$callback = function() {
   // ...
};

if ($enableHttps) {
    $manager->getSecureConnection($callback, $host, $port);
} else {
    $manager->getConnection($callback, $host, $port);
}
```

Mostly every getConnection() call needs a getSecureConnection() counterpart call.

So in this case it's not that evil IMO
ок. дивлюсь умову
```($user->getUsername() != $this->getUser()```
в лівій частині буде strign, а в правій об’єкт User. якщо вона спрацьовує, то або я чогось не розумію, або в User є магічний метод __toString
you should use ``&&`` instead of nesting the ``if`` here
Thanks for the link.
Will fix all related issues.
@Baachi thanks for the tip I had never taken the time to look at the src code before.
these methods are not part of the LdapInterface expected in the constructor.
I would just ignore files that cannot be read. Throwing an exception seems to be too much in this situation.
What if this extraction is called `Messenger`, which could be the renamed `UserMailerFacade`?
*Butter
This can result in the ident being an empty string.  We need to check that the ident is still valid after this transformation is run.
oops, i misread pr for commit there...
Is it just me or is "lb" not defined?
However, the rest looks good. I think we can merge it.
I hate then IDE does this.
Probably should change it to Sublime2 ;)
Using a fixed return value for timeouts will mess up on work restarts.
do we need to be nulling out the callbacks here to prevent leaks?
```javascript
  tryable == null;
  catchable == null;
  finalizer == null;
```
Why is left_ptr > and right_ptr <= ?  I feel like I should know the answer to this... :-)
A quoi sert ce filtre??? Là je pense que je vais le supprimer, je ne comprends pas l'intérêt
I don't think this actually has any effect (at least it didn't last time I tried it with the sun JDK module), as system imports had an explicit META-INF exclude hard coded into jboss-modules. This was a while ago though so I am not sure if this has changed.
Dammit,  uploaded the wrong patch.  Stay tuned,  will upload the correct one after dinner...
это тут прописывать не нужно, это надо только если у тебя `@RequestMapping` в контроллере на .jsp
It should be 'num' instead 'thread.num'
Out of curiousity, do you really need the setTimeout(.., 0) there? (same question for the 2 other cases where you have use it)
We move this functionality to 'sendMessage' method
Add a comment above
I thinks `_deleteAll` and `_get` should be un-prefixed.
Nice! There are some scenarios that I did not consider of, we definitely need this, thanks.
Risky in case someone changes the L10n code string on the HTML file without noticing that it is used for the styling too... ;-)
Good to know!
Smart profiler...
can we move this a common variable for the function, as it is duplicated on if and else
the idea would be that from the import functionality you should be able to import / unimport a contact but the flow has not yet been defined by UX.
`showWithPseudoEvent`
wifiLock = null (see comment below)
This code is fine, but you really can omit the three nulls and just pass the callback.
classList.toggle?
It's fine, just what to make sure @alivedise has no problem with that.

Still we need to come up with a conclusion that where should the SIM PIN Lock pad should live. It was discussed in #1568, and being implemented by @evelynhung at the moment.
Boo! Do you want to open an issue for that?
This seems like it should be it's own function.
"If not" is ambiguous (do I not have a fork, or is it not up to date?)  I agree with @chancancode that we need  to point them to the fork button at the top.  If necessary, I'm happy to make two versions of the instructions, so those with limited git understanding don't get left behind, and those who live by git don't get lost in the excess detail.
No use for echo outside of testing
我的snowflake2里面是我所有的设定。女主角的性格是很温和的，不是什么军队背景，而且对女二号是虽然是主仆但是更像姐妹的关系。所以“撤离“我觉得不妥
fix :octocat:
Ok, got it. I vote for groupRandomly for the more general method and shard for this specific usage.
Also, that abuse of takeWhile feels like it should be made explicit in GroupBuilder with a method called something like pass().
Still, don't catch the generic `Exception` class.
Not sure what may call commands.walk, but you may want to validate "move"+dir is a valid function before trying to call it.
Why a separate function for this if it's only called once (from main)?  Maybe it just needs a comment.
Hmm.. You cant remove this getResult ... it's required, even if you dont use the result (see http://twistedmatrix.com/documents/8.1.0/api/twisted.internet.defer.html). Please audit the rest of this code to make sure you always call getResult following every yield ... or, if you're brave, it would be cool to make this function use inlineCallbacks, but that's not always easy.
more simplicity, less complexity. simplified signature -- just making second arg optional. what are the downsides of making the stuff reserved in `options`?
I'm not sure this is a safe way to check the CN. I'd have to look into it more, but iirc the cert used to verify the connection is not always the last in the chain. I'm concerned that a self-signed cert after a valid cert for another domain, could be added to the end of the chain, pass the openssl verify, and then get to here and also pass this check. ... I might be wrong though and would have to look into the specifics of how openssl is validating the chain.
you should also check if there is a space in it. This would allow detecting properly some of the CLI commands containing ``::`` as a PHP callable cannot have a space in it.
Looks like a merge conflict with this commit https://github.com/diaspora/diaspora/commit/51b1ade3bc7fa498f9c8c3a7130c1429612dcae0
being very *very* Crockfordian here, but can we get this over two lines like the one below it?
Would be nice to align in columns (when `name` not given). A little tricky since it requires doing one pass to compute max length of each column. Just an idea.
The Rebuild button in the toolbar is now visible for users with access to the component but no edit/create/etc permissions. I suggest to show the button to users with core.admin permission, so it is in line with the com_categories for example. Line 68-72 of this file will become:
```
		if ($canDo->get('core.admin')) {
			JToolBarHelper::divider();
			JToolBarHelper::custom('menus.rebuild', 'refresh.png', 'refresh_f2.png', 'JTOOLBAR_REBUILD', false);
			JToolBarHelper::preferences('com_menus');
		}
```
colocar ## coding=utf-8 no início resolve essa questão de caracter especial, não?
maybe refactor this into:

    [ 'an', 'array', 'of', 'headers' ].forEach(function(header) {
        if (pres.headers.hasOwnProperty(header)) res.setHeader(header, pres.headers[header]);
    });

a nitpick, drops a little code perhaps.  groups the forwarded headers closer together.
I think for the ternary operation you want a space before and after the colon.
The special link in the Links category would be misplaced and underused. I think it belongs outside, next to description, as here. Is this OK?
Again activated() vs triggered().
Yes, right, I made the same mistake twice. Thank you for noticing.
Also fixed the indentation. 2 spaces.
This output is wrong, I'll fix
comments would be good
@weierophinney how do you think we should handle this? After calling "header($someHeaderString)" there are still no headers sent and "headers_sent()" returns false. Headers are sent, when content gets sent, too. When we change the implementation to use "headers_sent()", it would no longer mean, that "header($someHeaderString)" was called.
Fieldset is more concrete
Several things:

- If you have a return in a conditional body, you don't need an else.
- Invokables should all be treated the same, which leads to:
- You should likely define a factory for the DbSelect adapter instead. Having conditional logic based on type is a recipe for problems; what if somebody substitutes an alternate DbSelect implementation that isn't compatible with this?

Alternately, modify the DbSelect adapter to allow accepting an array of arguments, just like the other adapters.
Will do, I like the idea of using booleans rather than the strings ('assertTrue'). 

I had seen examples using the 'assertTrue' strings and $this->$assertion elsewhere - wouldn't this be reusable by other tests as well, though?
@denixport The format recommended by PSR-2 is:
```php
class SomeClassName extends AbstractClassOfSomeSort implements
    FirstInterface,
    SecondInterface
{
}
```

Typically, you'd only move the interface to the second line if it goes beyond the 120 character soft limit.
Don't understand reason for local variable "labels"
Yeah, this is an obvious security hole, should be whitelisted (whitelist can exist on the datastore object though to keep this generic)
the cow doesn't remember when he was but a calf
Could you use the "--benchmark" command line to choose the set of benchmarks to run, rather than changing this list in the source code? Or are you making the list match that in db/db_bench.cc now?
Also, make sure that the same srand call is before each of these RandDoubles, or else you'll get different colours each time and so different things associated with the same lap will have different colours
why doing this in the controller instead of the template (which is where it is done for other places) ?
Could this use array_key_exists('user_account_form_validate', $form['#validate']) in the if statement ?
here again a few CS issues with missing spaces and code that should be on the same line as the closing curly bracket
Can we remove this protocol and instead simply have a Enum.Iterator altogether?
add docstring: """Configure build: <single-line description how this deviates from standard configure>"""
I'll add that. I can fix when I merge for now.
I've no problem with you including your "provenance" but I think that you need to avoid acronyms - the average joe on the street won't know what these letters mean ;-) Spell it out - Red Hat Middleware Solutions Architect
This kind of in-line indenting is not preferred. Indent two spaces more than the previous line.

Also new hash syntax and add a space before the closing ruby tag.
eventのフィードも配信する？と思いましたがとりあえず。
<%- means don't HTML escape, which I'm using to make it easier to write the test fixtures
missing whitespace aroung operator =
Yeah it queues them on the save signal: https://github.com/tallowen/mozillians/blob/elastic_task/apps/taskboard/models.py#L48. I can't think of a better way except for manually refreshing the database which is sort of defeats the point of making sure these things are being indexed.
There is a lot of css that is specific to the edit_profile page else where. I agree that it makes more sense to break it out into its own file, but if that is being done, can we move *all* the rules?
add whitespace padding: `(function ( Popcorn ) {`
as far as i understand this,
self._save(old_filename, metadata, settings) saves the tags to the source file and then moves it,whereas 
self._save(new_filename, metadata, settings) saves them to the copied file only
i simple test gave me this result - with only line 160+ :
md5:b4c0c41984f16ce879c335f7cde2b31a
after:
md5:b95c57662cd0270a6ace66b31e9c7d52
completely different :)
совсем не понял
@CristinaRO If we do, how about I just add all of http://code.google.com/p/otwarchive/issues/detail?id=3163 ? (I was going to do it last night as a separate issue, but then realized this was still outstanding.)
Makes sense to me - for the tags help, I was experimenting with the code tag for more distinct formatting, but it became really small. If we do the help text deploy as a last emergency release, I'd really like to toss in https://github.com/otwcode/otwarchive/pull/705 as well.
Tab/space issue here?
This should work fine even with localhost as smtpHost, because that's also used when I use the mail command in the terminal. There is no need to specify the relay mail server.
yikes. this is what it was before? good change.
@Ocramius This PR ist just one commit ahead and simply removes the `['view_manager']` config key "hack".
Could this be UTC?
On 21/12/12 9:12 PM, pozorvlak wrote:
>
> In app/controllers/members_controller.rb:
>
> > @@ -1,6 +1,6 @@
> >  class MembersController < ApplicationController
> >    def index
> > -    @members = User.all
> > +    @members = User.where('confirmed_at IS NOT NULL')
>
> This could just be my unfamiliarity with MVC, but wouldn't this code 
> be better-placed as a method on User? Similarly for the SQL in the 
> call to |find| below.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/Growstuff/growstuff/pull/72/files#r2487251>.
>
Yeah... probably?

-- 
Alex "Skud" Bayley
skud@infotrope.net
http://infotrope.net/
Yeah, it's not entirely necessary, but it's easy enough to add or remove.  How do you think we should move forward?
OK, I didn't know. I hope, I fixed that regarding your intention - I am not expert in JS :)
Can you put some better newlines in this? hard to figure out which tags go with which.
Why are you doing dt.days/30 for both the amount on months and days
This can be accomplished by adding the app (or not) to `INSTALLED_APPS` in `../settings.py`.
кого тут не хватает?
Capital return
This is the magic!

Adding the colon silences RM's 1 != 1 error.
If you use ||= then it will always do the check if it is not repeated because it will be false, this prevents the reevaluation each time in the most common case
this could be rewritten as

    for idx, cat in enumerate(home.categories):
        Assert.equal(cat.name, self.expected_category_items[idx])
Personally I'd prefer the bug summary and number. Such as:

    _login_locator = (By.CSS_SELECTOR, '.buttonGroup #login')  # Bug 769251 - Duplicate ID login in Paypal login sandbox frame
There's a lot of functions defined here; should they be in a lib file instead.  Cartridges may create their own pre_receive_app hooks with only slightly different behavior.
Does this need to be made into a function, as opposed to being an anonymous function attached to the `canManagePrincipal` invokation?
I agree with not passing an array or an object. I'm fine with an object where we just aggregate the error messages.
Good question. I've unhidden them again and have provided usage examples for each of them.
The design here leaves a lot of vectors for bad data and no way to recover. For example, if a failure causes a library to not get updated when a content item is updated, you can now end up with duplicates in the libraries.

I think that to be robust, this would need to remove *all* instances of content for the members, and add them back in -- rather than being dependent on the `oldLastModified`.

What we could also consider doing is:

1. Store ContentMembers
2. Store LibraryByPrincipal, *without* any notion of the last modified date of content. Updating this would avoid having to do column scans to pluck out invalid data.
3. When a library is accessed sorted by content id, build it on-the-fly in a LibraryByPrincipalLastModifiedCache CF
4. When content is updated, use ContentMembers to determine which caches need to be invalidated and delete them

Now when you access ContentMembers, you can perform a quite performant secondary check on LibraryByPrincipal for each content item to ensure synchronicity.

I think this technique would scale to more forms of sorting as well:

Want to sort by content title? Build a LibraryByPrincipalTitleCache on-the-fly when requested, and invalidate those caches only when the title of a content item changes.
I added ```fill_in_with``` and ```process``` to make the API as similar to the form class as possible. Maybe I should drop this thought. The concept of this class is a combination of a table and a form. If I really wanted to combined the two APIs then the new API would explode. So I agree with you.

And there is currently no usage for ```process``` and ```fill_in_with```.
please rectify whitespace whilst here
Does not check for empty string as router will always have a controller and method.
остались после тестов, забыл убрать
Yes. Opera shows popup asking to user to increase quota when this exceed 1MB (and 2, 4, 8 ... ).
...a cryptographic signature...
No newline between these two rules (nit).
Can you point that? I really couldn't find an insertid call after insertObject in **JTable::store**.