labofsahil/github-event-dataset-2012 huggingface dataset:
Well, it was *1.0* compatible, but not Git Master, which must be considered *1.1* ;)
I've just pulled you changes in, thanks for the 1.1 fix :)
`Window` and `Document` are overwritten by lines 147 and 155...
doesn't this null `has`? so even if i include has.js prior, it's still undefined.
Shouldn't this support non-Homebrew installs of growl too?
The location button, when first switched on, turns on your location (as shown by the yellow man) and also follows your location, updating the map as you move.  If you scroll the map yourself, even just a fraction, the automatic following is switched off. 

There are, then, three states - on and following, on, and off.  Until now, the button only had two states - on and off - so there was room for confusion, and if you wanted to reenable following you had to press twice - off, then on again.

When it's off, the button now shows the location graphic with a hollow circle in the middle.  When pressed, the graphic changes to the normal location graphic with a filled centre, drawn with a border around it.  When the map is moved and following turned off, the button border is removed.  

It takes significantly longer to describe than to see in action :)
Out of curiosity, why did the dependency status image go away?
If you're planning to build a MyTardis-to-MyTardis sync protocol, you may find [mytardis-app-atom](https://github.com/tjdett/mytardis-app-atom) has some useful ideas.

I'd love to build a similar interface at the Experiment level, where the producing MyTardis instance provides a chronological Atom feed of Experiments with changes, and the consumer MyTardis parses the feed and ingests the appropriate records. File transfer could be handled in a very similar way to [mytardis-app-atom](https://github.com/tjdett/mytardis-app-atom) as well.

PubSubHubBub might be good notification protocol for changes (assuming a regular 1-minute poll of the feed is too slow).

/cc @steveandroulakis
Perhaps remove this section, since there's nothing in it?
Hm, that's a fair point.  Thanks for taking the time to think it through and comment!

As an aside, this discussion might be best on the standards mailing list. <http://groups.google.com/group/php-standards?hl=en>
@scottdavis I couldn't get this guy to pass. There's something I don't understand about the Appraisal system I think. compass-rails is not getting loaded correctly when I run rake, but this issue doesn't exist in a stand-alone application that I make by hand.
why you should remove the rocketpack on wipe ?  its blizzlike if you keep the rocketpack if you havent won the battle
ya lo reverti antes que dijeras nada,..
Why not just use a scaled vector here?  It saves you a pass through all the features, and it doesn't look like you modify the centroids directly.
You can now output the request XML for debugging by setting $Shipment::SOAP::WSDL::Debug = 1
it is an endless discussion if we want/ need support for dbc-overwrite/ custom spells
ah yeah, indeed. Dunno why I though it was for ``version`` here instead of ``require``...
but, but, this will stop the events from working :(
Why did you make this an array? It was a hash in Python.
Sorry Justin, missed this the first time round: the Infinispan tests should all use testng, not junit.
nah, its fine, all the links are fine ;)
it's just about skipping the first line. write

/**
 * blah
 */

not

/** blah
 */
Yeah, just went to look at if after I finished the SQL updates. Waiting on build to finish now :) G++ is probably a bit more pedantic lol.
amazing thx.)
honestly this wont change anything as if the eventId isnt in that list then itll either return false on the next line or itll crash.
It is very important to pass in the correct array length, I think (instead of 0).
The API can be found here:

http://tinyurl.com/JSF-cse1030-BankAccount
Because this fork is quite outdated. I would trust much more on the original source if I were you. You´d only need something like this on your `lib` folder:

```ruby
class MyMenuBuilder < TabsOnRails::Tabs::TabsBuilder
  def tab_for(tab, name, options, item_options = {})
    item_options[:class] = (current_tab?(tab) ? 'current' : '')
    @context.content_tag(:li, item_options) do
      @context.link_to(name, options)
    end
  end
end
```

and in addition of having a more stable codebase you will enjoy all the updates from the original developer.
And they repeat everywhere. You have a mistake that only big blocks of code must be separated to common.
good move on this fix!
why

On Wed, Mar 7, 2012 at 2:40 PM, red cat <redcatprogrammer@gmail.com> wrote:

> what
>
>
> On Wed, Mar 7, 2012 at 2:03 PM, Oscuro1987 <
> reply@reply.github.com
> > wrote:
>
>> Removed from collabs, you're no longer wanted here rcp.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/Oscuro1987/Severe-Uranium/commit/5fdd37285bd0c4aa2f5fca1b2892c57214f92147#commitcomment-1053563
>>
>
>
>
> --
> this email will self destruct in 10 seconds,
> have a nice day ;-)
>
>


-- 
this email will self destruct in 10 seconds,
have a nice day ;-)
&AuraEffect::HandleNULL,                                      // 330 SPELL_AURA_CAST_WHILE_WALKING    ! DOH...
you might want to add an aura handler...Flemzard,

like &AuraEffect::HandleCanCastWhileWalking ?? idk not sure on that one yet...
Ooo, interesting. Good call.
I just made a check, I don't have the kernel probe error and the keys are working fine here. There might be something different in the kernel configuration or some previous patch which needs to be applied, if you didn't yet. 
I recently packaged the exact clone on my kernel-hannspad repository for openmamba, here you can find the rpm containing the binary kernel:
http://www.openmamba.org/distribution/distromatic.html?tag=devel-makedist&pkg=kernel-hannspad.source

If you have problems extracting the files from rpm (rpm2cpio) just tell me and I will send you the file(s) unpackaged. Ciao!
Thank you for you patch but the name of "restore-trash" is not meant to be changed to "trash-restore". The trash-restore name is reserved for a future version.
Mexican mothers rub a hot chili in the kid's tongue when they swear. That's why I have such a high tolerance for spicy food.
Pourquoi ce changement de version de MoteurCsv?
Please add `language: ruby` and prefer `jruby-18mode` and `jruby-19mode`. To keep your `.travis.yml` in good shape, use [lint.travis-ci.org](http://lint.travis-ci.org).
did you copy from the google doc?
Isnt all this the RTP?
Wow, so much clearer. Nice job, @geraldalewis.
Disable interactive governor, it's broken.  (Had this same issue on my kernel two months ago when I tried to enable Interactive)

This is an extremely poor bandaid, it just masks the root problem of a broken governor.  If it locks up in LPM mode it can't be trusted to behave properly in normal operation.
this commit does not work
Gotcha. Your solution looks like it'll work... I'll commit the change in just a sec.
true, but in that specific case this might not be the bundle you like to hit. BTW, a completely other idea. If we're really implementing weaving hooks we might be able to do this in a more elegant manner anyhow.
I don't have a full understanding of how that code was intended to work.  I inspected it only enough to convince myself that my fix to the build break was safe enough.

One question: does this fix add any features, or is it "the correct way to fix the EV_A build break" (versus my commenting it out).  Either way is fine.

You have replaced the EV_A macro with something that I assume is an alternative to using the macro.  If you are doing this because you think that's the correct implementation, then you are already a step ahead of me.

Given that my original complaint was a build break, this should be easy to verify.

If I get a chance, I'll try and build it tomorrow, but this module is falling farther and farther from my actual job responsibilities.

If you (or anyone else) use this module a lot and want to become a maintainer, that's definitely up for grabs.  I do what I can, but it's basically pro bono work at this point, and it's a similar story for the other two guys.

  ---  Dave
Please add a blank line before this function and get rid of the two blank lines at the end of it. The continuation lines for the paginate call should also be indented to match the first argument.
yeah - for sure. I think it could be great to have at the core level. 
especially if it is as simple as just using ofMap - would be good to take a closer look at it. 
curious what @ofZach  thinks :)
thanks Petteri, good call, i set eclipse tabs to be 2 spaces (instead of 4) and i'll see if it fixes the problem
output archive name does not match archive name created earlier, should be myPackage.jar
Great and noted. Learned something new from you. :) 

Thank you.
After looking at how container boms are used I've noticed that it's a bit of a freestyle (found it only in few showcase modules actually, most of them have containers enabled explicitly). Shall we clean it up then?
Sorry I was sure to be on 2.0.9 it's work now thx
Ich schieb das erst mal bis auf weiteres vor mir hin. pygtk ist noch nicht im packet-manager bei mir drin. Da sind wohl noch ein Bugs die das ganze auf OSX blockieren. 

Am 31.01.2012 um 16:46 schrieb Matthaeus:

> Du brauchst pyGtk. Es soll wohl funktionieren:
> 
> "PyGTK applications are truly multiplatform and they're able to run, unmodified, on Linux, Windows, MacOS X and other platforms."
> 
> http://www.pygtk.org/about.html
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/platzhaltr/easy.rapid.gtd-on-your-fs/commit/c053616e4728b7ce819fa753993a8b73941b6461#commitcomment-918729
remove hardware/ti/omap3/liboverlay :)
why do you think you need remove the network manager stuff, I am guessing that the majority of shell users use NM and besides the code does fall back to reading from /proc files if network manager is not installed.

I you modify the patch to work without removing NM stuff, I will merge it in.
Line with 132px image should have a different filename: logo-132.png
shuld be
    de:
I would write it as: "Note that non-overriding final functions are considered virtual by this trait. Use getVirtualMethods and isVirtualMethod instead."
Ah ha, I would argue that should also be excon, fwiw.  Thanks for fixing it!
`===` isn't going to work here since we're dealing with arrays, will always return false
wow, am I understanding this correctly?   because `TestPipEnvironment`  wasn't creating the scripttest  temp_path,  $TMPDIR (which is set by scriptest) wasn't used.   it's clear that `TestPipEnvironment` was trying to use the temp features because it was setting `capture_temp` and `assert_no_temp`, but it wasn't happening.
"PyOP2 framework for high-performance unstructured mesh applications" ?
o yee
I look forward to the day we can use Python 2.7.
yes, we should
What does this sentence imply? I.e. what is it intended to convey to the reader?
can "getRouteDefinitionHandler" return different things throughout the lifecycle of the Consumer? (i.e. why (rd) ⇒ getRouteDefinitionHandler(rd) and not getRouteDefinitionHandler.apply _)
Remove this, it should be obvious when something is built
you should also `context.watch(targetActor)` and stop this supervisor when the child terminates (possibly informing the `caller`.
It can be 0, look at numerOfMessages
Do the added parenthesis serve some other purpose above improved readability? I noted one of your commit mentions a bug. If this is a/the bug I fail to see it. Please help me ;-)
Made inspect and to_s a little friendlier.  You can switch the type form in debug_type to avoid fetch.
The comment here is not exactly correct. It looks like simply a copy/paste error.
never mind, I twisted it in my head. it's fine as is!
This is where I wish we were working off separate branches on hits/hits for each "feature" - then you could just checkout the branch and make the change yourself.  We could then merge after conferring.
The list isn't being assigned to anything, so the fact that there are None's is negligible. That said, I don't feel strongly about this, so I'll go ahead and change it real quick :-)
Ah excellent.
added a see parent class for doc string
Since this is going into 2.0, let's use the new -d (daemonize) rather than backgrounding it.
Maybe, same reply as above.  I will circle back and see if any of this is needed once everything is actually working.  I may end up pulling/changing it anyway.
Hmm, maybe bring back Account.admin
It's an error on my side, it should'nt be commented
either github skipped the end of this line, or something went wrong in a c+p. it ends at .iH here
Either pass VIDEODB_CONTENT_FOO directly to GetFilePathById() and get rid of the iType variable or move the call to GetFilePathById() outside of all the if-else code and call it only once.
I think this could crash. 

m_pBufferRef will be unrefed when not needed. So i think you need to take a reference to cur_buf if you don't null it out directly. I would prefer if you could test:

````
    // This should not be here, just commented out to explain that it should be removed
    //if (link->cur_buf)
    //{
    //  m_dllAvFilter.avfilter_unref_buffer(link->cur_buf);
    //  link->cur_buf = NULL;
    //}
    if ((result = m_dllAvFilter.avfilter_request_frame(link)) < 0)
    {
      CLog::Log(LOGERROR, "CDVDVideoCodecFFmpeg::FilterProcess - avfilter_request_frame");
      return VC_ERROR;
    }
    m_pBufferRef = link->cur_buf;
    link->cur_buf = NULL;
````
(The first three notes of Fanfare for a Common Man, played on a muted trumpet. ;)
Oh, whoops. I had #318 backwards. I think `tmp` is better to standardize on; will change this back.
I agree with you. It is essential to have it on hand and it should work like in eclipse (to create new empty methods in case of abstract methods, also for derived classes)
Please use the logger instead of print statements.
well, this is an actual fix, pointing to location where templates are actually located and removing new lines so they are interpreted as command line arguments..
Sorry. My fault: I've edited the text before forking from your current version with the new RCT explanation. Ignore my version. It was just a temporary copy/paste from jpeg.org.
so this is needed because of https://github.com/mozilla/dryice/commit/fb9bb9ae0baf85f273fd317e6dee279a6a4312de :(

i've set it to 0.4.7 latest one which supported node 0.6,
but it would be good to find some other way for building ace
`osname == 'Ubuntu'`?
why use "address" here and "_address" on the line below?
Could you elaborate? What information could I extract from the parent
namespace about the sub namespaces? You would need to walk the namespace
array to find it's children.
Op 18 mei 2012 20:42 schreef "Fabien Potencier" <
reply@reply.github.com>
het volgende:

> > @@ -219,6 +219,23 @@ public function getNamespaceInterfaces($namespace)
> >          return $this->namespaceInterfaces[$namespace];
> >      }
> >
> > +    public function getNamespaceSubNamespaces($parent)
>
> Why not just get the subnamespaces by parsing the namespace?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/fabpot/Sami/pull/13/files#r847145
>
The constructor takes a required path argument which is used to initialise the main namespace. So, it is always defined.
Really?  I overrode the setter for it in TUITextView.
`siblings` might be a clearer name here.
s/via/through the/
These explanation comments should not be inclued in source code ;)
For static imports, star (`*`) imports are preferred.
strange, i responded by email hours ago -- it did not make it here -- anyway:

if you look at line 62 and line 54 you see batch_dir created twice, which only makes sense if it could possibly vary across 'pyfiles'
And in this line you still have `content_tag(:span,word)` without the space after the `,`
Sounds good, maybe after 4.0 release. But I think we encourage this in new features because they can't be backported.
Please use the inverse condition with `include?` instead of `in?`, in both places.
:heart::heart::heart::heart::heart::heart::heart::heart:
PSR-2, section 5: "There MUST be one space after the control structure keyword" :-)
```
To use the default, `import collection.parallel.Implicits.defaultTaskSupport`
```

Requiring explicit selection of the parallel strategy is principled, but it weakens the "just add .par and you're done" hook of the parallel collections.
There is. Read the discussion.
My pearson type III reference at 
http://projecteuclid.org/DPubS/Repository/1.0/Disseminate?view=body&id=pdf_1&handle=euclid.aoms/1177733130 
has blanks in the tables that if you calculate, will give you 'nan' values.  I think because of underflow?

For example, the first line of Table 2 (PDF page 71) is all blanks, but could be calculated with...

>>> pearson3.pdf(-5.49,[0,0.1,0.2,0.3,0.4,0.5])
array([  1.13781200e-07,   4.79383402e-09,   1.60987760e-11,
         5.89543973e-18,   0.00000000e+00,   0.00000000e+00])

Note the zeros for skews of 0.4 and 0.5.  These are replaced 'nan' values.  

Before putting in this test, ALL pearson3.cdf returns were 'nan'.  I suspect because if the integration process caught one 'nan', game over.
Yep, it's about the _GET_FUNC below. I agree with you that it's unlikely that the ctypes API will change. However, this call is not on a hot path, so I would rather prefer the code use public APIs, if the performance gain from the hack is not significant.
I'm not to the proper examples, yet, and this is more parenthetical. Is it ok to leave it indented or do you still think it should dedent.
I pushed another commit that consistently documents the O and K argument.
This branch isn't covered by your tests
I'd recommend relying on a more standard citation style, that is: "Stuart Russel and Peter Norvig, Artificial Intelligence: A Modern Approach, Second edition, section 9.2, page 276" (no extra linebreaks).  This is easier to read for me, but I may biased.
`smallest_change`, `_Vertex` and `_JGraph` seem to be completely removed. Why where they there in the first place?
I change implementation to constants
If you enter a coupon code that results in an overall worse discount the promo code will not exist in the order's adjustments. Although you would hope a user does not enter in a coupon code that results in a worse discount, this 'dummy proofs' the system a bit and gives some meaningful feedback to the user.
Example should reflect the defaults that are used in absence of a configuration.  ``csbot.deploy.cfg`` is the configuration that the deployed bot uses.
I think you need to pass `this` in as the context here
Probably best to put it after listening port > 1024.

Also missing toc.md addition.
This test is important because we want to make sure `ms('100') => 100`
We are using the pictogram font http://www.fontsquirrel.com/fonts/modern-pictograms to render some icons. J draws a tag ;)
So for both of these, what happens if someone searches for "nic pottier" .. I don't think it would work right?
"container.php" is the only file in the cache folder with the word "container" in it. Furthermore, adding an underscore would make it no longer match (and therefore not remove) the container.php file.
In that case you are correct, didn't see the `unique_id()` call.
Copyright should be updated `@copyright (c) 2011 phpBB Group`
Newline should be added (and to all the other files)
"are populated" or "get populated". In any case, the verb tense must agree with "is".
table names are mixed up here
#diff_content is 50 pixels smaller than #codepanel, so I've increased height difference by 50 pixels.
the search if should be removed here
1. you are missing database updater changes for this
2. this data should be in xcp info files, not in installer
where did this come from, not mentioned in any of the old code?
Well the page doesn't update after you comment, so I didn't notice it until I refreshed (after I did all my comments) that's my excuse. :P Anyway, we're off topic.
To clarify, Symfony controllers allow you to specify different class methods to act as controllers, and they can take any number of arguments. We only allow controllers to be a class that contains a "handle()" method, which takes no arguments. Because we use our own request class to get data, we don't use parameters.
Achievementul este pentru provocari castigate
Will be improved in scope of #9.
Will change.  (I think the evt.args was used before I copied such into local vars.)
Again "custom camera"
What is the reason for this change? It breaks unit tests in the IsCaseInsensitiveBaseOf fixture. Changing it back makes the tests pass again? Did you run all unit tests? The master branch currently fails due to this change
If you can paste the code here (or in pastebin and give us link), we can try to help you with any of your problem.
Forked as #130.
I think this actually does ```# major.feature.minor-dev -> major.feature```. Perhaps we could use ```[0:2]``` rather than [0:-1] so it works with ```0.9-dev``` as well?
I broke it out to match the subroutine break out in the spec.  

so keygen and the variables inside of it match the "Non-reversible Key Generation Process" (Local Subroutine) on page 50 of the spec.

In the spec on page 47 it's not called reg8 it's the shift register and the key serial number register which get transferred into the crypto register 1.

I feel like it more directly represents the parts of the spec that you have to read to figure out what is going on.
I think it is the output of the graph including all updates. I don't see anything that could make this list partial or overcomplete (we output multiple time the same variable). Where do you see potential problem with the call here?

But it could happen that one output variable is reused in the graph for a second output. But this don't cause any problem here.

About the FGraph feature, they are not documented I think. So don't expect people to know about them or know how to make one.
.. because I wanted to test that these are importable from linalg rather than linalg.ops.
wait, which one is easier to read again?
@nouiz OK if it is only temporary.
@abergeron Sure, it makes sense to test it, but not to add a new mode into the buildbot, it takes long enough to complete already.
I see how this code works, but it might be too clever. Why not:
1) Check for default value by checking odd or even number of params.
2) Iterate non-default params by twos reading pairs.
Global JS variable
def mark_device_with_nonpermanent_costs(self, queryset):
        items = list(queryset)
        for item in items:
            item.nonpermanent_costs = SplunkUsage.objects.filter(device_id=item.id).exists()
        return items
Typo on "hashes"
Не нашёл, куда переехала эта логика
Fixed in `f660886`. Forgot to reference pull request in commit :(
I thought about putting the full stop after the closing brackets (my personal preference ;) ) – but different style guides disagree on that and I don't know which one you follow ;)
Yeah, it's here. Here is a sample of the `curve_db` output from this function:

<pre>
[{'wkb': '\x01\x01\x00\x00\x00\xd3\x95\xaa\xbd\xf4;b@\x12U_mZ9*@', 'weight': 1, 'poes': array([ 1.00030807,  0.50061415,  0.33394695,  0.24940602,  0.20060009,
        0.16699133,  0.14394654,  0.12289803,  0.11166564,  0.09923764,
        0.09158608])}, {'wkb': '\x01\x01\x00\x00\x00\xd3\x95\xaa\xbd\xf4;b@\x12U_mZ9*@', 'weight': 0, 'poes': array([ 1.00003998,  0.50116545,  0.3341001 ,  0.24846011,  0.20031964,
        0.16531638,  0.14330985,  0.1256224 ,  0.11093922,  0.09967879,
        0.08987565])}, {'wkb': '\x01\x01\x00\x00\x00\xd3\x95\xaa\xbd\xf4;b@\x12U_mZ9*@', 'weight': 0, 'poes': array([ 0.99907994,  0.50140172,  0.33378938,  0.24912562,  0.20098917,
        0.16669528,  0.14182779,  0.12476982,  0.11240011,  0.10032123,
        0.09198044])}, {'wkb': '\x01\x01\x00\x00\x00\xd3\x95\xaa\xbd\xf4;b@\x12U_mZ9*@', 'weight': 0, 'poes': array([ 0.99881596,  0.5004549 ,  0.33450438,  0.25052302,  0.2001259 ,
        0.16649368,  0.14383335,  0.12611638,  0.11085494,  0.10020953,
        0.09063056])}, {'wkb': '\x01\x01\x00\x00\x00\xd3\x95\xaa\xbd\xf4;b@\x12U_mZ9*@', 'weight': 0, 'poes': array([ 1.00094145,  0.49958433,  0.33534489,  0.25116749,  0.19835615,
        0.16601893,  0.1431784 ,  0.12509308,  0.11016877,  0.10067437,

</pre>
That's a good thought. Hm.
This is missing djcelery.
Does this regexp catch a key composed of spaces or tabs?
Need to pass `--prefix=#{prefix}` to configure (or equivalent), otherwise we don't have any control over where things get installed.
A comment about where these two ids come from would be nice too, ie, why one or the other would be found. (Xcode 3 vs 4?)
suggestion:
```ruby
system "#{ENV.cc} #{ENV.cflags} -o md md.c"
```

I put everything into one string here, because otherwise I would need to put each flag into one argument.
I think this loop is somewhat wrong - or I am! ;-)

At this point temp[0] contains the last element of $accepted_languages.
What about the other elements?
I'm not sure you need a full stack trace on this as you're almost expected to see it in a development instance.
Je pense qu'il faut mettre la music ( même si c'est un peu relou de l'avoir tout le temps, le code commenté n'est pas une bonne idée a mon avis
We need to respect types here as well as not everything is a string.
There won't be any surprises on the Python side -- we'll just get the whatever YAML passes us -- but there certainly is the usual potential for slash-escapes to surprise people when writing their YAML. One should probably use single quotes for regular expression in YAML files since those don't support escapes (see http://www.yaml.org/spec/1.2/spec.html#id2760844).
OK, retour à l'original, qui finalement sonne mieux...
Looks like the fix in the extension is stripping both the ssl_client_key and the ssl_client_cert but the test is only testing that the ssl_client_key has been stripped.
This should be a tad more explicit such as:
`// send the client a Set-Cookie header if he doesn't have a valid cookie`
should be if ( (size()-m_v->m_rank[m_v->rank.size()-1]) < i )...
Can we make it so that this goes directly into the main CMakeLists.txt file instead of having a separate .cmake file? I'd really like to avoid having many cmake files around - it makes things more complicated if you just want to have a quick overview of the single CMake file.
意図して分けてます。_helperを経由せずに作成したdisplayObjectもあるはずなので。
Is it correct that keyIn is camelcase but keydown isn't?  If that's the actual smart autocomplete API, maybe we should add a comment to make it clear it's not a typo on _our_ end.
It's always had the restriction that it only points to a full-size editor, but it wouldn't hurt to clarify that.  Mind if we tackle that later, though, in the interests of keeping the diff small at end of sprint?
I think it would be better to only show the checkmark when we actually finish establishing the connection (STATUS_ACTIVE).
I ended up rewriting `getLiveDocForEditor()` to call `getLiveDocForPath()`.
Change all ``bool`` to ``boolean``. Looks like this error was mine originally.
Is there any reason why EMACS environment variable should be passed only for Mac OS?  I guess it can be default.
typo in 'Execute'
Lots of blank lines that can be removed.
I'm curious how you will deal with function overloading, as you don't add function name after MODULE_PATHNAME.  If it's the policy, norm2 is too short name?
Thinking on this a bit more - the Ionic.Zip dll is referenced manually rather than through a NuGet package - perhaps its that - but that doesn't explain why the old test passes...
Why aren't you using the alpha function here?  I think that also makes the next line simpler - and it's what I failed to spot in my last comment.  Sorry!
Returning None will cause a 500 internal server error. Instead return a redirect to the correct URL.
I'd also recommend doing this. You shouldn't run into any problems and it should be an easy switch.
You could move `next` to hidden field and then access it simply through POST?
No I don't like that example. I really don't like it. It goes completely against with what I was trying to achieve. But if you want it that way is the best to close this pull request because it makes no sense anymore and maybe open new just for facebook button (but it is 1 line of CSS so I don't think it is actually needed).
You're stealing `butter-editor-styles` here? Should you make a new class with the same properties so that it's less confusing?
Should be `applyExtraHeadTags`.
Right now, no. I would need to rewrite bits of this.
Space here after bracket, right?
what about backticks and double quotes?
So i see your way of testing: most of the external dependencies are doubled and every  dependency within the class is stubbed. However for specific tests for S3 shouldn't we better use Fog.mock! so our tests have more coverage?
`PATH.join()`
Should this be:

    @cid_widths         = @ohash.object(obj[:W]) || []

just in case there are no widths defined?
I would name it ``LogstashFormatter``
s/conntection/connection - applies below as well all the instances seem to have the typo (bonus points for consistency at least ;))
I had to read this a few times, but I think it's functionally correct.  Any reason for the `len` rather than just `set(vals.keys()) == set(mask.keys())`?  If so, maybe a comment about why...?
That was a leftover from when I was having trouble running astropy's test suite.  I've uncommented.

the convolve_fft import has been fixed (forgot to change it when I moved the function to convolve.py)
It's taken a few tries to get my automated release process for PyFITS perfect.  Every time I just make sure to take note of any anomalies and fix them for next time.  Each time it gets smoother, and even the first time I used as semi-automated process it was better than doing it manually.
This is a bit confusing, because `Column` could either be `table.Column` or `table.MaskedColumn`.  And it also hides the `Column` fixture function in this file.  Maybe call is `ColumnClass` as done in `table.py`?
Just noticed the changes in the `riak_kv` pull-request, so I guess this is all good.
https://github.com/basho/riak_kv/pull/325/files#L0R279
I used the same logic as implemented in the findGroupByName and findThemeByName.
Didn't know you could do that $('#a1,#a2') returns a list of 2 jQuery elements?
but anyway, breaking BC is a no-go until 3.0
While we're at it, let's move these into config/locales/en.yml. Read up on [rails internationalization](http://guides.rubyonrails.org/i18n.html) on how to do this. We just need to make entries in that file called things like "group_help_message" or something similar. So we can just cut out all these lines that say `message +=` and replace it with `t(:group_help_message)`
Is this for clearing any files with a read-only flag?
Mmh, you have both raise and pass here, is that what you meant?  Looks odd.
correct superclass to not bork on additional set elements
I don't understand.  As I mentioned in another comment, the identical edge object can have different weights in different graphs.  (See for example AsWeightedGraph, which allows you to map arbitrary weights onto the edges.)  So the line you mention does not always return true.
There is no `url` parameter, this should be `redirect(r'^apps/$', 'https://marketplace.mozilla.org'),`
l10n wrappers for strings?
There used to be 22 replies, butthe example I am using for testing (`CANNED_RESPONSES_WIKI`) has only 3.
So this md5's the entire thing. I was thinking you want something like "products_for:4d92038298fab".

You could do that by passing in "products_for" into md5_result and having it prepend that to the md5 of whatever _products_for_cache_key returns.
There's a get_or_create that will do this for you https://docs.djangoproject.com/en/dev/ref/models/querysets/#get-or-create
The above won't catch this? Or you don't trust the header?
I was thinking about other OS distros (Gentoo has one, we'll probably need to write a script for others), but you're right to call YAGNI.
I just mean that it is not very creative to have names (rdfs:label) such as "RDF→SROIQ translation". But so far, as we have at most one translation for any given pair of logics, there is no need for more descriptive names either.

I would probably leave the database as it is, with a "name" field corresponding to rdfs:label, and "description" corresponding to rdfs:comment (which is not currently set for any translation, but may well be in future).
standard else style } else if( jkljkljl ) {
There are ways to handle exceptions on all platforms, there should be some around in virtualenv.py, IIRC.
That change was not intended... Guess some files got somehow mixed up between versions. This is fixed now
Maybe use %r for stdout and stderr?
These semicolons look weird. I get the point, but for consistency it should probably be:

    $this->stream
        ->expects($this->at(0))
        ->method('end');
Do you know you'll get a `ConversionException`? Could that just be Throwable?
Symfony does not add the phpdoc on private properties
Please use `iterator_to_array($this->options)` here.
should be ``2.3``
@pborreli when following you first link, I receive a page asking to upgrade wordpress :)
IMO it would be nicer to just keep it in as defaultNull and in validate check if it's set and then tell people. This sort of thing could be removed in 2.2..
```PHP Fatal error:  Arrays are not allowed in class constants```
I would call this `isStarted()`
Sorry, I meant:

    return array(
        'pre.foo' => array('preFoo', 10),
        'post.foo' => array('postFoo'),
    );
Tokens do not exist anymore in the api, is this right?
Prefer `\.` to `[.]` and `\d+` to `.*?` unless there's a compelling reason not to.
Oracle JDK6 and Maven 2.2.1. Yup, maven is old; I forgot I had it downgraded for another project. Ignore if supporting old Maven isn't useful.
Without this change, my test cases fail. I can't explain why...
Too much of indent, break block to new line:

    [CPapi getNearestVenuesWithActiveFeeds:[CPUserDefaultsHandler currentUser].location
                                completion:
     ^(NSDictionary *json, NSError *error) {
         // give the user some reasonable default feeds
         if (!error) {
         ...
I'm open to improvements here, but the only problem I see with overwriting the existing file is the PATH won't point to the old ruby.  But, even with a separate file, it can't point to the old ruby, otherwise none of the gems will install properly.  And I really wanted to avoid a situation where two files end up in /etc/profiled.d/, both modifying the PATH.  That's going to be really confusing if a deploy fails part-way through.
loved should be in quotes
Since this was existing code I'm going to throw my .02 in on why the "repeat code over and over again in tests" thing doesn't make sense. Tests are methods just like any other. To say that controller methods should be refactored down to a bunch of tiny tiny methods yet tests should be allowed to grow large for the sake of readability seems like talking out of both sides of our mouths. If it's more readable to see where a user or event comes from in a test why isn't the same true in a controller? And on the same note, why is DRY code important in the app, but a side note in tests?

If that is the standard I'm fine with it, but I really don't see the logic.
Quite so. :put_litter_in_its_place:
And we need a test for that
Ah, sorry, I hadn't noticed that. No problem, you can leave it here.
Please add a space before the paren.
you should use ``@form_field_jq`` instead of doing the jQuery wrapping again
How about (or some variation of):

```
if attrs.has_key? name
  Hash[attrs[name].map { |k,v| [k, v].flatten }]
end
```
context.getServiceRegistry(true) should be used for START/STOP/PAUSE/RESUME as those ops update service state.
I think this should be type="xs:boolean". Should take advantage of the xsd version bump to fix this
I also think that we should error in this case, I doubt the deployment will work as expected with a module being ignored.
An EAP 6.0.0 host needs to be able to function properly in a domain controlled by an EAP 6.0.1 master (not just during an upgrade process, but permanently.)

If this operation is added in 6.0.1 and people use it, any 6.0.0 hosts will fail. That's OK in general, i.e. if you don't want to upgrade a host, you are stuck without new features on that host. But I don't want to introduce those kinds of compatibility concerns into EAP 6.0.1 unless we absolutely have to. Keep it to bug fixes and put our energy into master/AS 7.2/EAP 6.1.

So, I'd like this operation to be private on the 7.1 branch.
Totally makes sense
Added a comment. 

Thats the check I talked about in my email. 
With this check its possible to have custom positioned menus in popup style. Otherwise the 
Only other solution would be to separate pop-up styling and positioning in two different options.
Adding `_moveToTop()` sounds good.
What are you referring to? Currently the option can be an Object, String and Array. Object is being passed through to the position utility, so shouldn't we deprecate the other two?
Лучше не искать пользователя по имени. Там где делается вызов этой функции и так есть объект "User".

Так же не хотелось бы делать обращений к БД из JSP кода; надо как-то придумать куда сохранить подпись так чтобы она загружалась в контроллере, а не в JSP
We should never store passwords in plain text.  Let's use a django hash password utility function, or if there's not one we can hash it ourselves (eg https://github.com/pld/bamboo/blob/master/lib/utils.py#L61)
Same as previous comment.  :)
Nit: move this line after `new Audio()` will make test easier. Now set mozAudioChannelType twice you will get gecko exception.
nits:
* two empty lines before the new section
* give the section a meaningful title (e.g. OS License)
* unprefix `-moz-calc`
* leave the trailing empty line please :-)
This parameter is only used once, and everywhere else it is omitted.  If Tim negates its sense, then an undefined value will be the same as a true value, which seems more awkward to me than doing it this way.
Yeah, I get your point :-) Good remark :-) The point is that this code is in charge of calculating the space available for the contact name in case it very long and it has received (or made) several calls. Basically we calculate the available space (taking away the space for the type of call icon, number of calls and contact photo). We cannot use the "text-overflow: ellipsis" rule here since this "qs" part and the number of calls part ("(13)") are a couple of spans so the calculation has to be done this way. The reason to use pixels is due to the fact that getComputedStyle() returns the current size in pixels. The 5px is just a security margin.
Yes, just for now we are trying to move forward the final CSS for the demo but if cannot achieve this goal we will fallback to the simple implementation. Trust me, we are trying to move that file away.
I'm not against removing all the type attributes in a different PR. Just want to stay consistent.
It could be also a gaia issue. We play with focus when the window is shown.
There is a mix of ' and "
This value should be in sync with `ril.radio.disabled`. Whether of not to turn on vibration in the silent mode is up to you for now (and confirm with UX later)
why do you need to prefix the function with a _?
YEAH!!

Thanks so much for updating the tests :)
`\E_USER_NOTICE` can be just `E_USER_NOTICE`. Applies to the other instances as well.
@filipewl, id replaced by class hide-title d8829a4e0b
why is `scale` a subcommand in the `root` context?
Good point, if we catch the `EPIPE` when writing the json payload and respawn/retry that'll probably be good enough.
This filtering seems overly complicated. What's the situation you're seeing that requires this? I would expect any users of ZincClient, like the maven plugin, to ensure the arguments are valid already. If the maven plugin is passing unexpectedly empty args, then let's fix it there.
Unit tests for meta_neu are added in commit 1099ffde7b4d6bb1b8162268522ab6fe25263e69
Actually, I made a small error.  The index on which uniqueness should be requirement should be the compound version/obj/user index, e.g. 

    self.col.ensure_index([('obj', pymongo.ASCENDING), 
                                     ('user', pymongo.ASCENDING),
                                     ('version', pymongo.ASCENDING)], 
                                    unique=True)

See the little discussion of this sort of thing in the documentation at http://api.mongodb.org/python/current/api/pymongo/collection.html#pymongo.collection.Collection.ensure_index
Add in what replication is in the docstring.
But its there if you do want to test it out.
Right, but you're creating two sessions but using session_put and dissect_create_session, you can use both but you'll need session_get_and_del or if you just want to stick with dissector sessions then use dissect_match instead of session_get on line 120. Everything else looks good, thanks for contributing!
Add ``&& !$defective``
_Archive rather than __Archive.
The keys for the GitHub information in the `enhancement_data` object are prefaced with "g_" while the keys for the Zendesk information are prefaced with "z_". I can change this to use "git_" and "zen_" as prefixes if that makes things more clear.
This is going to be confusing at some point, it would be much more readable to call it is_tracking and use the not key word as necessary.
You would extend this one and add methods...:p
The map should be final.
Ah, no, the first time only checks if it exists, so all good.
Yeah, it was the "I" suffix to denote index. Variables in the rest of the file don't have any type inference in their names (although it would definitely help in some places...).
Might be safest to make this something like:

```if ticket.errors[:connection] && ticket.errors[:connection].any?```

This will protect against the possible situation where the key has been initialised but no actual errors are attached.
While that should work, there are still cache problems with some browsers, especially Opera: http://stevesouders.com/tests/redirects/results.php
End with a dot, not comma
not sure about the font-family having 3 on it...

Also not sure about the escape. 

https://github.com/nex3/sass/blob/master/lib/sass/tree/visitors/to_css.rb#L210

If you know ruby I am pretty sure the answer is here...

https://github.com/nex3/sass/blob/master/lib/sass/scss/rx.rb#L13
No, the CCFileUtils::sharedFileUtils method will create an object of class CCFileUtilsWin32, but it returns CCFileUtils*, so it won't affect for user how to use it.
Please declare at the deepest possible scope, see comment below.
var_dump ?
why making it static ?
In the case I change the `ArchiverInterface`, what do you think of:
```php
public function archive($sources, $target, $format, $sourceRef = null);
public function supports($format, $sourceType = null);
```
because the Person::by_account_identifier is not a Rails method, but one from the model ;)
i think there were problems unless i had specified that version
Why are you initializing the static fields and then making all methods synchronized and then checking for non-initialized fields? Either do eager or lazy initialization and avoid synchronized fields as this will really hurt in the long run. If you are doing static field initialization, make sure it is eager and make sure you define the field as "final".
Why is this commented out and L112 commented out?
FIXME :)
Need a check here for the buffer length.
why are we in need of a "sh" for the FP printing?
All this was added back in when debugging and discovered it was missing - and (at that time) no apparent way for it to delete from the flatfile index.
change string writing style no to be stacked.
use style in separate css file
Indentation of `validateOptions` is wrong.
`off` isn't used.
I think you meant options instead of options'
I've updated this patch again in order to accept only bool, int or string and throw an error otherwise.
Feel free to tell me if there is still something wrong.
Question: this is always the case? I would leave open the possibility, like we did for the "Stable" API (*"avoid breaking backwards compatibility unless absolutely necessary"*) that we could remove a module without necessary provide a full alternative to it. I see it as a rare condition, but like Stable API we can't really said that it can't be happen (e.g. the platform code change so much that a specific functionality make no sense anymore).
load testing doesn't hit static resources.  so zero affect.  there *is* a performance penalty for this substituion, but when we implement a CDN in dev, stage, and prod, it will happen so rarely (once per deployment per resource) that it doesn't matter.  and never in prod.
Can we also do the same for Songbird? The current nightlies are at 1.12.0a.
nice .. looks good to me.
Yes you're right ^^
I am fine with that decision.
Or even something completely different:

```
modulepath = $confdir/modules/internal:
+ $confdir/modules/upstream/:
+ $confdir/modules/meta
```
Better fix that before commit. :)
`wget` isn't installed on OSX by default - can you change this to `curl -so $URL` instead?

Our dotfiles are targeted at OSX.
we don't really want to move to scala 2.9 just yet.
Implementation detail changed. No need for a cache now.
Sorry Sir, I did it. I wanted to implement c language as well. But it pushed on github by mistake. I am very sorry for that.
It will be reverted soon.
This statement is nigh impossible to read, variable names like `a` don't help.
Sure it does :-) Copypasta ... Thanks
you sure crossroads.js is the right tool for achieving what we want?

i checked the source code of the reference knockout app you provided but couldn't find any spots where crossroads.js is used... do you know another reference implementation where it's used?

with crossroads.js, i could define the required routes this way:

	crossroads.addRoute('#/', function() {
  		Session.set('filter', null);
	});
	
	crossroads.addRoute('#/active', function() {
  		Session.set('filter', 'active');
	});
	
	crossroads.addRoute('#/completed', function() {
  		Session.set('filter', 'completed');
	});

unfortunately, crossroads doesn't catch the route... even if i remove the '#', it's not working...
Comma and whitespace are unnecessary here.
Isn't this going to change Last updated for all calendars.  I think you'll need a translation string in there.
For these 2, there is no way to merge (how do you merge integers together ?). But it should overwrite only when not null (so that the existing value is kept otherwise).

For the where clause and the ordering, merging together is more sensible. Replacing the existing where clause entirely seems useless. You could simply execute the criteria itself.
This should be taken care of by making `store_location` a before filter.
So, move the type to iterator, and Enum.t :: Enum.Iterator.t ?

On Wed, Oct 31, 2012 at 4:33 AM, José Valim <notifications@github.com>wrote:

> In lib/elixir/lib/enum.ex:
>
> > @@ -68,6 +68,8 @@ defmodule Enum do
> >    `{ key, value }` tuple.
> >    """
> >
> > +  @type t :: list() | tuple() | fun()
>
> It is the opposite. Enum works on everything that implements the
> `Enum.Iterator.t` protocol. We can allow people to type `Enum.t` for
> convenience, but it should proxy to the `Enum.Iterator.t`. For instance, if
> we update the iterator to support new types, those changes would be
> automatically reflected on `Enum.t`.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/elixir-lang/elixir/pull/601/files#r1990825>.
>
>
You've accidentally included your name here; could you remove it?
Please add a proper sanitycheckpath
Yeah, we have either

````
if (..) {
  ..
}
````

or

````
if (..) ..
````

for very short lines..
I'm confused about this. Why is it necessary to do this with `globals()`? This feels very hacky and if it's really necessary, it needs more explanation.
Why isn't this just `test_invite_without_message`? You can define an email address, it doesn't need to be passed in.
express is smart about detecting what content type to send it as. If `response.send` is given an object it will automatically `JSON.stringify` it and set the content-type to application/json unless told otherwise.
It might be worth changing this into a class to avoid using globals.
fixed in baf2a47d41ef62e475c1db96242e3b4881d62a8b
This should be an if statement.