labofsahil/github-event-dataset-2012 huggingface dataset:
Profiling-based improvement to import#values_sql_for_columns_and_attributes - 80% speedup for large imports

https://plus.google.com/u/0/103112149634414554669/posts/EGghnZ1icVY for details.

Three issues corrected:

1. Calling ActiveRecord::Base#connection within the loop. This may well be an ActiveRecord WTF, but connection actually isn't memoized; every time you call it, it goes back to the connection pool and fetches things over again. Yikes. So I memoized it local to the function.

2. Calling sequence_name needlessly, for non-id columns. This is a result of doing and in the wrong order. Statements are evaluated left-to-right; this means that you should put the stuff that's cheapest to fail on the left, and the expensive stuff (or the bits whose real return values you want preserved) on the right. So I just swapped the order.

There's a deeper WTF here, in that sequence_name should be memoized within ActiveRecord, but something was breaking that. Not sure what, and I haven't fixed that, so it'll still be slow if you are using a primary key column. Serves you right for trying to insert explicit primary key values instead of leaving that up to the database at insertion time. :-P

3. Double-escaping. connection.quote already does appropriate type conversion and escaping; calling connection.type_cast first provides no better security, but slows things down significantly by making things be converted twice. So I just got rid of that.

These three changes resulted in an 80% performance improvement for the import call.
Cache the trailers list
Fixing bugs in templates
Test of Hector mutation

Test of Hector mutation
The lastest from Brian!

Merged all our changes together. It builds but I haven't been able to get it to run; probably need to turn up the RAM as was suggested. Nevertheless, this is the most functional code we have so far, so I think we ought to merge to up to the main repo.
Calling set_table_name is deprecated.

Rails 3.2 warns about Calling set_table_name is deprecated.

DEPRECATION WARNING: Calling set_table_name is deprecated. Please use `self.table_name = 'the_name'` instead. (called from <class:Translation> at ... /i18n-active_record-b631b05a96d5/lib/i18n/backend/active_record/translation.rb:52)

Changed 'set_table_name' to 'self.table_name ='.
change to date instead of datetime
Ripped out JSON requesting & parsing; replaced with all XML processing

Should now work on those troublesome bits of text that trip up Spotlight's internal XML-to-JSON conversion.

Merging in a bit.
ofSphere non-GLUT based on Paul Bourke

Implemented code based on Paul Bourke here:
http://paulbourke.net/texture_colour/texturemap/

Includes normals, texture coords and verts
set isRecurring
Added record for Pandoc Plugin for Sublime

Hi Will,

If you'd be so kind to add my Pandoc plugin to Package Control I'd appreciate it.

Thanks!
Jeff
Small XML fix

cdata must come right after the opening tag, since everything between the opening tags and the cdata also counts as the element text.

(My editor also automatically fixed some whitespace-only lines)
Added module: CdliAutogenUsername
See issue #13 for details

Fixes issue #13
Replaces RELATIVE_WCF_DIR in acp templates
Virtual pageviews and custom tracker code combined

This pull request integrates two different features plus some minor styling changes. If you prefer them separated let me know to open different pull requests from the topic branches. I didn't do that because of the merge conflicts between the branches.

Cheers!
LPS-25031

Okay, this one's for real this time :)
Refactor

Parse json returned from Rabbitmq API
Improved shownotes of current episode

I improved the shownotes of the current episode and added some links to it.
Update hooks for models.

This patch moves a couple assumptions into the main code of the
engine, as these non-core objects can reasonably be required to be
provided by the host app. This has the net effect of less model
class overrides needed by the host app.
Minor fixes

* Tidied up the first line in "Measuring Inclusiveness and Disadvantagement"
* Fixed title on "Further Detail on the Questions"
Fix up a couple of Lighthouse issues
Make keystone errors fatal and handle error messages better [1/3]



 chef/cookbooks/keystone/providers/register.rb |   35 ++++++++++++++++--------
 1 files changed, 23 insertions(+), 12 deletions(-)
I changed a little more than I should have..

It was a tad lazy of me. My apologies. But you'll find all the info needed to add thumbs into the publications as well here.
LPS-23223

LPS-23223
Changes for rails 3

Here are the changes needed to work with our rails 3 code - this is what is now live on osm.org.
Feature/multisites

Fixes and optimization
Added -sources command line switch for explicit <sources/> setting

Autodetection won't work when merging coverage from multiple test assemblies.
訳

Backgroundの残りを訳しました。
Projektin kuvaus
Clean up generator's ERB theme

Makes the theme generator output cleaner and following 2.0's style.

I haven't done Slim or HAML yet, just seeing if this is okay first.

Output code:

https://gist.github.com/1883522

Screen caps:

`index`
![index](http://i.minus.com/iYMJNvGPffUJz.png)

`show`
![index](http://i.minus.com/ib03yVZnJRB0ih.png)

`edit `
![index](http://i.minus.com/iuHLOSBiWwI2a.png)

`new`
![index](http://i.minus.com/izQj7mL6ApvQU.png)
reduce sensitivity
v2.x: Implemented bbb-broker.php
Documentation patch

Update AmazonS3::list_objects documentation to indicate to the end user that the AWS call is paginated and how to list all objects.  Link to S3 REST documentation.
detect winning team

Try again ;)
I use the function ```current_winningTeamID()``` some days. It works for me. The ```self.console.game.serverinfo['team2score']``` include int and later float values. That is the reason why i use float for default. ```max(scoretable, key=scoretable.get)``` works fine for me. I dont understand courgette´s code samples. Sounds i need more python skills.
Fix JPPS from being included in internal builds
display-friends-tags-22

Show a notification popup with friends' tags for the current URL.

To test, put a yourname/following tag onto the objects for `@rustlem` and `@terrycojones`, then visit `http://brooklynstartup.com/?p=129` and you should see Russell and my tags show up in a popup. Add some tags yourself and reload. You should now see two popups.

Fixes #22
added info how to expose route defined by annotations

to save some time by n00b like me
Install templates

Hi there, 

thanks for your work on this project,

I found, that templates were not installed. 

Thanks,
-- 
m
Send the user data.

Any reason why this is commented out?
Syntax correction

I've done some little modifications for your library : 
- I have replaced some <?> chars by their correct value (°)
- I have done a little  edition for the Readme with a better implementation of reStructuredText

Yours,

Louis VICAINNE
Improved check if author exists.

Error pops when previewing a template.
Fix build document 

Fixing errors in docs/build.md like typos, code highlighting, and layout.
Corrected Apple Pie FEP.
Not sure what version of mock we're using, but in recent-y versions this is more obvious as:

```python
mock_dialog_run.assert_called_once_with()
```
@ono I'm a fan of using rake's dependent tasks, so I re-implemented it that way here: yaauie@7ef4654fd9b993e
Have you tested that? If I use a dictionary and read its content, I get the content of all dictionaries since they share their variables.
Yeah, I know. Let's talk about it later.

On Monday, February 27, 2012, Matias H. Leidemer wrote:

> Remember that, these kind of things (like changing faola.less) should be,
> first, in the master branch.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/fguth/faola/commit/1575695424f259fc0eb0cbee4339f3e55f2dc58a#commitcomment-1014708
>


-- 
Filipe Guth
Sent from iPhone
unsorted_list = [kw.name for kw in resource_ctrl.keywords._items]
i think that also
unsorted_list = [kw.name for kw in resource_ctrl.keywords]
should work
@stof I mentioned this option in my previous message but I don't see any advantage.
(Not that the file is small right now ;)
$this->data['workspace'] - ???.  e.g base/backend template    

  public $view = null;
    public function before()
    {
        $this->view = new View();


in controller -> $this->view->workspace
+1 :) kuko took it to another level :)
understood. just finding the way to reuse :)
I did this to keep the flow as clear as possible.

1. Only :ignore and formula are really 'skipped'
2. Only one 'next' in the loop so only one exit point in the (granted it is compound) logic

It also covers the edge case where you want to set :fixed as a default, and revert that behavior based on content you find while generating data.

What do you think?
Please reference the issues on JIRA in commit messages.

Please stop branching and including the phrase "general-devel" in every branch.

This is bad:
[TShock/general-devel-lua-w/TAPI] Code clean up and register all current Hooks with Lua. - Steven French ( https://github.com/TShock/TShock/commit/1d… )
It looks like this is a clang bug of sorts


    $ cat test.mm 
    #import <AppKit/AppKit.h>
    
    void f() {
      Protocol* p;
      [NSString stringWithFormat:@"%s", [p name]];
    }
    $ third_party/llvm-build/Release+Asserts/bin/clang -c test.mm 
    test.mm:5:33: warning: format specifies type 'char *' but the argument has type 'NSString *' [-Wformat]
      [NSString stringWithFormat:@"%s", [p name]];
                                   ~^   ~~~~~~~~
    1 warning generated.


What's happening is that Protocol is only forward-declared, and several other classes declare a `(NSString*)name` function. So the only `-name` function clang knows about returns `NSString`, hence the warning. Ideally, clang's warning would be less misleading.

Adding a `#include <objc/Protocol.h>` makes the warning goes away when building with `-isysroot /Developer/SDKs/MacOSX10.5.sdk`, so that's the right fix. (With the 10.6 SDK, you'll get:


    test.mm:7:38: error: 'name' is unavailable
      [NSString stringWithFormat:@"%s", [p name]];
                                         ^
    /usr/include/objc/Protocol.h:46:1: note: declaration has been explicitly marked unavailable here
    - (const char *)name OBJC2_UNAVAILABLE;
    ^
    1 error generated.


But that's a good thing.)
now that client which have failed to init on first try are added the map, should UpdateAndInitialiseClients() be changed to UpdateAndInitialiseClients(true)? This would the cients give a chance to connect on subsequent attempts.
Should the indent on the return expected be removed ?
Indeed if i wrote a better test for this, it would have been caught.
We didn't put in the logic to detect that yet, but when we do, we can tag it as an attribute.
On Feb 11, 2012, at 1:28 PM, Tim Su wrote:

> What kind of idea was clicked?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/todoroo/astrid/commit/6060fd5ef568906aa487f409132de389f04cc484#commitcomment-957026
Site suspended, what's going on? :S
Agregué esta función porque era algo repetitivo que se usaba mucho dentro del controlador, entonces encapsule el getteo del usuario + un control de excepción por si no lo llegase a encontrar por algún raro motivo.
准确的说应该写成Tag.all.each do |tag|
Build #4 being terminated won't affect future builds in any way. Regardless of what exactly needs to be changed in default JVM settings or Salat test suite setup, please make sure log size does not excess 2 MB or so. Otherwise instead of working on Java and Scala support + multiple JDKs, I will have to work on limiting log size in the worker. 225 MB does not sound reasonable to me.
Why have you added this shit?
I think we used the wrong default here. I'll change it.
Why do we need an option to disable sound?
typo, actually it is illegal
tst12, по поводу "@Batters на
 P.S. и по поводу команды у вас какие-то свои наверное с virusav домыслы" никаких у меня домыслов с ним нет! Да пофиг на домыслы, я его даже не знаю, о том, что я с ним хоть раз общался буду ваобще молчать. Ребят серьёзно если говорить, то данный форк (ну или как некоторые любят правильно называть R2 community) я считаю самым лучшим из всех мне известных, а то, что rsa бывает немного злым, это не повод с такой же злостью на него реагировать, как некоторые на фофжопе, такие как ланс например, этот кадр ваобще мразь полная, не знаю точно, но читал я посты на этом знаменитом сайте с руганью rsa vs Lanc смеялся до упада, это же какой гадостью нада быть, чтобы того, кто его можно сказать учил подставлять. Нет слов кароче, одни мысли и то плохие. 

В обещем, буду заниматься ща sql потиху разбираться в этом всё и в скорем времени буду помогать запросы править, так как самого уже эта проблема прижала, а значит надо с ней бороться!
@jhpedemonte opened #1621 for this issue.
Yeah I'm just adding these changes so we don't run into a situation later where we forget and suddenly can't figure out why things won't work.
É o arquivo de configuração do log4j, ele diz o que deve ser logado, e a saída padrão do log, que pode ser console, arquivo, etc. No caso usei console.
Это не есть хорошо. логин/пароль к почте в открытом виде...
Я должен был высылать как тестить отправку писем postfix-ом. Вместо него можно использовать http://mailcatcher.me/ (помойму, его проще настраивать).
На продакшн сервере настройка идет уже по-другому и никому никакие пароли не показываются
If that is out of memory how you are going to clean memory. All memory exceptions should be handled in ResourceManager! Because ResourceManager is a main tracker of memory and it has settings and possibilities to clean other tiles.
There is already a customizable 'Support' button. Would heavily recommend against doing this for following reasons:
1. Hard-coded is much easier to change when release new OpenEMR versions (otherwise, previous version link manuals will stay there)
2. Goal is to increase the traffic of the OpenEMR project website at www.open-emr.org and direct users to the online user manual there, which is obviously the current best documentation for users. If a vendor wants to modify this, then can simply do in the code.
you already called `$('#contributor-ac-error')` above. we could store this jQuery object in a `var`, so we don't have to do the function call, selector lookup, etc. again. (I would put it above line 479. also, per the style guide (http://mozilla.github.com/zamboni/topics/style.html#javascript):

    variable names for jQuery objects start with $. for example:

        var $el = $(el);
or hub_page_title
раЗделению тогда уж :)
service-inventory.uri should be optional
Both could easily still be supported, with an additional check if `Reporter` is actually a reporter or an "event" object.
https://github.com/SpoutDev/SpoutAPI/blob/32effe093f48ba0a93a3a20c4f92367422fc3e1c/src/main/java/org/spout/api/Game.java#L326
it shouldn't have unique=False
https://github.com/Undergarun/mangos/commit/06b69ca4fd75fcd94d5e3224933cfc66970ca4f4
Fixed in master, thanks!

[master 2b6f959] fixed counter issue for CorpusGenerator
 1 files changed, 1 insertions(+), 1 deletions(-)
Why not deleteRecursively(file)? The contents of tempdir might be directories
Dit is een comment...
Any naïve call made to getOfflinePlayers() with the newest dev builds result in an exception when this method makes its final cast:

Caused by: java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to [Lorg.bukkit.OfflinePlayer;
at org.bukkit.craftbukkit.CraftServer.getOfflinePlayers(CraftServer.java:941)
Haha, thanks guys. I'd say it was about time! Now I just need to figure out the build script issues so we can have fewer skipped tests... :-)
@dexterous, sorry, won't happen again. :-)
Note that we cannot have more than one MapActivity in the app, or else all sorts of crap goes down. Use the BamftMapActivity for all your MapActivity needs :)

http://code.google.com/p/android/issues/detail?id=3756
Does ender automatically resolve dependencies like underscore and add/build them separately?
this isn't needed unless you're using `{{link.class}} ` in the default layout...
你们怎么没有提交过呢。。。
All these variations make me suspect that subclassing might not be the best way of modelling what you want here. 

What about hiding basedir and datadir behind an abstraction and let the caller of DB choose which one they want?

```java
new DB(new AutoUnpackMariaDB(), new RamDisk());
```
@sergiu you should fully read my comments, not just part of it ;)

If people want to hang themselves that's ok but we shouldn't hang ourselves (not in xwiki-platform at least).
lost all the jot icons in duepuntozero, all transformed to text
Prob just remove that file from all commits since inception, then add to
new one going forward. I'll test and let you know commands, I want to learn
this value.
On Feb 16, 2012 9:51 AM, "Geoff Massanek" <
reply@reply.github.com>
wrote:

> That's what Dave did - changed the calls in these 2 files to be ENV calls
> instead of hardcoding the API tokens. Exactly the right change, except that
> now the API keys are in the git history. The link you sent explains how to
> completely remove a file from a git repository, but we can't just not have
> these 2 files in our repo - the app wouldn't work. I guess that we could do
> a git remove to wipe all history of it and then commit it, as if for the
> first time, using the ENV setup.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/gmassanek/send_five/commit/3623bfe9fa4d08c1f444cf9d3074385ddd20580f#commitcomment-974140
>
Put back the mobilesdk detection :)
What deprecation messages
On Fri, Jan 27, 2012 at 12:15 AM, henrik242
<reply@reply.github.com>
wrote:
> suundo?

Heh. Fixed.

                 Linus
Conditional expressions is enabled from 2.5.
http://docs.python.org/release/2.6.7/whatsnew/2.5.html#pep-308-conditional-expressions

Are you talking about Python<=2.4?
I don't check that msgpack-python works on Python 2.4. But If it works, no problems to pull this.
You could, so long as Mario's ppa has the right libnfs. At least i think libnfs build-dep is still pulled from Mario's ppa.
Correct. While it's technically incorrect according to the SWF spec, the Flash Player does a lot of SWF repair tricks - if they see an unknown symbol in a control tag, they halt execution until they get the dictionary symbol that defines it.
Just because people misue a fonctionality doesn't mean it should be prevented.
For example, Robert C. Martin prefered to use a global variable instead of a singleton or a monostate, because in his case these two design patterns involved complex bypassing code just to avoid a demonized global variable...
missing utf8 support like: http://www.php.net/manual/en/ref.pdo-mysql.php#90444
the presence of 'Movie' in the name of the method tells us it's a class method
URL parameters should be encoded.

```js
url += "&" + encodeURIComponent(name) + "=" + encodeURIComponent(h);
```
Yes, thanks, I know that now, I've just copied it from lulz kernel, but it isn't enough.
Това защо го има, като директорията е в gitignore?
This part of the code was written by a person who didn't know what he is doing. Thats why they were global
Maybe we can do the same here.
i don't get this :-/
why do you find and filter for img elements?
Please update - we can't mix and match GPL and Apache 2.0 code. Suggest replacing the header with the common Apache 2.0 header used by other source files.
Hey Pulkit, WRT the credit card picker, we shouldn't be putting trademarked or copyrighted material in this library (I'm talking about the credit card logos), which is why I haven't integrated this component. I also don't think the looping UIPickerView is a good UI. 0.2c
@moimikey - not `Options -SymLinksIfOwnerMatch` was casing you error. Please check https://github.com/retlehs/roots/issues/213#issuecomment-3470044 to solve your .htaccess
ist ok !!
Thanks to @janmoesen for [the `$'string'` tip](http://www.gnu.org/software/bash/manual/bashref.html#ANSI_002dC-Quoting).
Is there a plan to merge this with the master?
"In MSVC, you can use the CLR override keyword even if you're not compiling for CLR."
"In gcc, -Woverloaded-virtual warns against hiding a base class virtual function with a function of the same name but a sufficiently different signature that it doesn't override it."
@izak Glad to hear it, I'm having a good time here as well.  :-)
Thought I'd just close the loop on these comments to note that the pull request was merged in.  So all is well.
Does thix fix the Lichking walking to Frostmourne-Room, inluding wicked spirits and the rest of the adds?
cuz MoveInLineOfSight don't called for worldtriggers (flag_extra | 128)
It does make sense if action.GetInviteId() != action.Invite.GetInviteId();
va!!!
It might be worthwhile to change the BioMixerDetailsWidgetHelper a bit so we can test it.
Looks great overall. The main change I can see would be reusing the ConceptNeighbourhoodService.
Hey, I'm not accusing you of anything! At first I thought you must have gotten the comment wrong. But since @master-lincoln's second comment I understood that it was the creator of the API (probably Sun) that were complete morons :)
does it not compile or not show up in ogitor?
it should works with http://gnuwin32.sourceforge.net/
Enjoy your Java.
Nice notice.. I'll probably remove the whole osname/osver stuff and fall back to use lsb facts for some modules...
Perhaps the MailChimp API has some way of listing unsubscriptions from a list: http://apidocs.mailchimp.com/api/1.3/

But I can't see it..
without this it oversubscribes the drain function, I don't know for sure if there's any functional difference in the block and tackling, but it definitely is friendlier to event emitter when there's lots of data writes happening :)
Hum indeed. Paren parsing error in my brain. I should do more lisp programming.
yeah, but please don't do the normalization twice:

```php
<?php
if (null !== $value = $this->normalizeValue($object->$getter())) {
    $array[$key] =$value;
}
```

Btw, your own code is confusing: due to the operator precedence, ``$value`` is a boolean with the result of the ``!==`` check. My code above fixes it by having a meaningful value (switching to the yoda condition is the best way as it fixes the CS at the same time but you could also do it by adding braces)
Alt + Shift + F represents about half of my keystrokes :P
@FernFerret tells me you love styling. I gotta check checkstyle out sometime.
/me copies your config
Ok, I think we can close this pull request though according to this: https://github.com/Khan/khan-exercises/issues/11058#issuecomment-3497815
Considering that aether 1.11 has bugs fixed in latter releases, might want to consider picking one of that.
Unfortunately APC and Wincache don't speak exactly the same language, so cache_info and get_metadata return slightly different things in the two drivers.
split in to two modules. please refer to http://dev.metasploit.com/redmine/issues/6144
It's <String> because you are inferring a type to it. You can have a generic type, but you lose a lot of String methods, and you don't have to cast it.
*Note: Not exactly sure, but I had to do that for an iterator.
These few DSP changes might help with the buffer underruns we were having, yeah?
I think we're closer when it's compiled with `-DCUSTOMER_HW`:

```bash
<7>[215, WifiService] [   80.379059] bcm_wlan_power_on: WL_REG_ON voltage level successed
<7>[215, WifiService] [   80.380121] bcm_wlan_power_on: EXT_POR_L successed to pull up
<4>[215, WifiService] [   80.534143] 
<4>[215, WifiService] [   80.534163] Dongle Host Driver, version 4.218.248.23
<4>[215, WifiService] [   92.526961] dhd_module_init: sdio_register_driver timeout
<7>[215, WifiService] [   92.531243] bcm_wlan_power_on: WL_REG_ON level pull down
<6>[215, WifiService] [   92.532474] bcm_wlan_power_on: EXT_POR_Lsuccessed to  pull down
```
<META> <META> <META> <META>
Those aren't refernces to the imported libraries (well, not to the library
object those imports generate).

It works fine for me without the imports. I get sliding and math no problem.

On Tue, Feb 28, 2012 at 12:11 PM, Thibaut Lamadon <
reply@reply.github.com
> wrote:

> They are used when the markdown processor is created: at line 38:
>
>    extensions=['slider','mathjax']
>
> if the files are not imported I guess it ignores the plugins. Slider makes
> bullet-point transitions, mathjax makes sure markdown does not escape the
> math formulas.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/johnmcdonnell/markdown2deckjs/commit/72bf03d5ed160d16a1a7af3bdaccf5bebe8070c6#commitcomment-1021864
>
Actually, y'know what? Can we have something like

  public static long FLAG_ACTIVITY_REORDER_TO_FRONT_NO_ANIMATION = …;

and just use that everywhere?
first try but learnt that it doesn't work in this way
So just to confirm - unittest2 in <=2.6 provides the same functionality as unittest in 2.7?
By the way - best NOT to include all PYC files in the repository.
Edit your .gitignore and add *.pyc to it, then remove them all from the repo ;)
this line is empty
I'm not completely getting your question.

In case of a method-level constraint (be it a parameter or return value constraint) the path would comprise of exactly one `Node` instance with a descriptor for the concerned method/constructor (both in case of parameter and return value constraints) and a descriptor for the concerned parameter (only in case of parameter constraints). See also my answer above. Is that what you meant?

> I don't understand why the property path is considered complete in that case.

What other nodes would you expect? Note that this is about a constraint directly at a parameter or return value, not a constraint reached via traversing a parameter or return value.
Why does it ask you to hit Ctrl-c if you don't want to erase the file you specified?
s/4326/4329/ hehehe.

But anyways, it's cool you're tracking 2.6.32 stable now.  I'm jealous. :)  I went up to 2.6.39 once last year: http://mjanja.co.ke/2011/08/fun-with-kernels-on-the-huawei-u8150/

Of course our wireless blob won't load on anything but `2.6.32.9-perf`.  I guess I could change the makefile to fake it!  Is there anything different you've found in CAF's 2.6.32 kernel versus Huawei's?
Actually, the open source license documents that you can freely use the code shared by others, under the condition that you maintain the present credit notices. I did not claim to have written it, only modified. I guess you wouldn't know anything about that, though. Why not spend the time you waste trying to chase me around and spend it doing some actual work for the community and not just pulling the credits out of work you had no part in? I really thought you were different...
Yeah, I realized that and changed it in the last commit--I think.

Mr. Jamie Ly
Ambler, PA 19002




On Mon, Feb 27, 2012 at 9:43 PM, Hector Castro
<reply@reply.github.com>
wrote:
> Isn't this line still limiting the number of friends you analyze to `@max_count`?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CfABrigadePhiladelphia/the-other-philadelphia/commit/89982dfadff40f2f98f3162fa950b02c1a8e49c4#commitcomment-1018049
let's check in ncdf and put a comment in on why we need to transpose.
ok, I see it's used for gene autocompletion as well, where multiple values are possible.

Then it's fine with me to merge this change (after addressing another comment).
What makes this rearrangement necessary?
`copy`
I have introduced a Switch lock to avoid the race
List? Seq or IndexedSeq
I would rather just use range in both (it'll be fine in 2.x as well) to make things cleaner. What do you think?
I only started working on this part.   Then I started looking into the params parsing and came up with this concept:

Mime::Type.register "application/wagn.org-cards+xml", :xml_cards
Mime::Type.register "application/wagn.org-cards+json", :json_cards

MyRailsApp::Application.config.middleware.delete "ActionDispatch::ParamsParser"
MyRailsApp::Application.config.middleware.use ActionDispatch::ParamsParser, {
  Mime::XML => :xml_cards,
  Mime::JSON => :json_cards,
  Mime::XML_CARDS => :xml_cards,
  Mime::JSON_CARDS => :json_cards
}
I want to at least see if/how that would work, write a couple tests.
Docstring should show what the data_dict should contain.
@pixeltrix ah, could use `@files.concat` too.
Can deleteCallback be set directly to its callback and converted to a val?
I just realised, that in EcmaScript 5 environment, we don't need method duplication here. We could just use the native Function.prototype.bind.
这封邮件暂时不要翻译，有些邮箱会变成乱码。
stylistic nitpick: I might have split this into two lines, just to be consistent with the cases above and below
Doesn't `this.vars.USE_VARS` still make this opt-in? Didn't we agree to keep it opt-out?
Indentation is pretty messed up here.
*separators
This needs full attribution, with a license callout in LICENSE.md (assuming they're even compatible).
I actually want to fix how this part and the previous (DTrace/ETW) part interplay. Don't read too closely for now. I expect to do something like the FIXME (in red) suggests, just haven't quite figured it out yet.
Ça va remplacer les 3 lignes pour box-shadow.
did you mean cmdstr = cmdstr%(node.config, pkl_file, batch_dir, suffix) ?
First line of multiline comments should be blank
Check out Andrew's photos on Facebook.

If you sign up for Facebook, you'll be able to stay connected with friends by seeing their photos and videos, staying up to date with their latest status updates, exchanging messages and more.

Join Andrew on Facebook
http://www.facebook.com/p.php?i=100004081283072&k=AQB1169hEwF8httj18DD7ibKHoWR-sKquzG0UJse0nRzIfU8uNPfUNi4Gc-DX6a-AbgVt_kOD7OXKrOdSC7ErgNE1ik&r&app_id=350685531728

Already have an account? Add this email address to your account:
http://www.facebook.com/merge_accounts.php?e=reply%2Bp-1211683-cb882938b9d8e3baf0f11caa397688ec9850fe09-579774%40reply.github.com&c=AQBaPnTZ7-elufd9FfUGqmeOVADPFvyubDipEo-Oo4grEg&source=unknown

=======================================
This message was sent to reply@reply.github.com. If you don't want to receive these emails from Facebook in the future, please follow the link below to unsubscribe.
http://www.facebook.com/o.php?k=AS1Ej-35UYt5eYUi&e=reply%2Bp-1211683-cb882938b9d8e3baf0f11caa397688ec9850fe09-579774%40reply.github.com&mid=HMTEwMTI0NjQzOnJlcGx5K3AtMTIxMTY4My1jYjg4MjkzOGI5ZDhlM2JhZjBmMTFjYWEzOTc2ODhlYzk4NTBmZTA5LTU3OTc3NEByZXBseS5naXRodWIuY29tOjg
 Facebook, Inc. Attention: Department 415 P.O Box 10005 Palo Alto CA 94303
Three stars `***` is not recognized by Sphinx. Two stars around words indicates **bold face**, and one star indicates *italic*.
Plan to make a change which will require "expires" to be provided, next commit
опять пробелы, запятую на следующую строчку
и это :)
I think we can remove the `is_a?` check.  Can you look in to that?
The others never get called if `response` gets set, I played with some other iterator methods and this way was the cleanest. I'm open to suggestion.
oh wow, looks much cleaner now :)
I find the technique proposed here a little clearer:

https://www.securecoding.cert.org/confluence/display/java/NUM00-J.+Detect+or+prevent+integer+overflow
Our convention is to have annotations on the same line as the method declaration provided they are short enough. I think about every occurrence in this file meets that criteria.
I would use the lower case 'not' here (which is the Python builtin)
I'd recommend using Python string formatting instead of directly concatenating strings.

I mean: 

```Python
raise ValueError(".... Complex part: %s found in %s" % (repr(im(arg)), repr(arg)))
```

As far as I remember, this syntax works both for Python 2.5 and Python 3.
'many definite' -> 'many indefinite' probably?
There should be an empty line before starting code examples.
Did you push the changes yet?
Minor style point (which admittedly I've not picked up on before); is querying the model like this in the view a good idea, or should it be done in the controller?
There is no redirection involved. Throwing NotFoundException would cause the ExceptionRender to just render the error400.ctp  Also I actually think the blog tutorial is too simplistic too be really useful. Eg. It doesn't even cover basic model association.
Awesome! Great work on this, by the way. I've been playing with it and am
really impressed. FYI, I declared those three variables outside all
functions, and that's also been working great. Have you done much testing
with multitouch capable devices? It does not play nicely with more than one
finger touch events.

On Tue, Jun 19, 2012 at 12:43 PM, Keegan Brown <
reply@reply.github.com
> wrote:

> > +             mouseover: touchPause,
> > +             mouseout: touchUnpause
> > +     });
> > +     //TOUCHMOD -- PREVENT TRANSITIONS IF USER IS HOVERING OVER CYCLE +
> opts.touchClickDrag == true
> > +     $cont.bind({
> > +             mouseover: touchPause,
> > +             mouseout: touchUnpause
> > +     });
> > +}
> > +function destroyTouch (cont, opts) {
> > +     var $cont = $(cont);
> > +     $cont.unbind('touchstart touchmove touchend touchcancel');
> > +
> > +     if (opts.touchClickDrag) {
> > +             $cont.unbind({
> > +                     mousedown: dragStart,
>
> d'oh! pushed a quick fix up for now, might rework when I find time.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/malsup/cycle/pull/110/files#r1011630
>
The other method is to create abstract classes and extend them. I am not entirely sure if this way is better, as we will have many layers of abstract classes. In the current implementation, we can create new interfaces for nodes and have nodes extend those interfaces that contain the functionality that they need. However, with something like register handlers, it is being reimplemented over and over, which I really don't like either.
not an option
l10n and copy nit-pick: use a single "Please reload this page again in a few minutes to see latest content." ?
comment? :)
In html / css we tend to use dashes instead of CamelCase. So you might consider changing `profileSettings` to `profile-settings`
We use else if, not elseif - there are a lot more occurances of this, so I won't comment on each of them
count is a reserved word, you could use num_notifications or something similar instead. (same bellow)
Hmm, I'm not sure whether creating many objects in common.php is such a good idea.
I am having a hard time imagining a use case for this user role.
Should be `//`?
'Users', alternatively get rid of 'their' or change it to 'own'.
If topic_id is primary key, you can drop the limit.
If a certain (or even consistent) order of avatar drivers is important, have avatar manager return the list in correct order.
You ought probably remove the NOTE if the line is removed. (I left it there as a helpful reminder, or possible as marker of incorrect conclusion, because it wasn't the first time I tried to do things that way. )
Can't we just use isDestroyed here and get rid of the Reconnecting flags?
De ce de [0]?
I think we refer to $BIN in the main README.md. Could you please change that as well ?
remove comment abt ticket if irrelevant
Hm, it seems like you are sending the encounter right after creating, rather than just making the fields optional. I am going to comment out this line for now, as after the encounter is posted it goes directly to the main page, rather than letting us go on to illness details/bmi.
Please reference this ticket: https://raxaemr.atlassian.net/browse/RAXAJSS-206 wherever attributes are required
I was concerned about accidental hiding. But you're probably right that it would be better, given the existing example of tests/test_apps/*/*.jar. I'll change it.
Ditto regarding strtok.
How do you register this handler? If you don't register it, what kind of impact could it have?
Well, if you feel you don't need this in 1.5, then lets postpone this. When you look at the amount of comments in this pull request it is obvious there is still some work to do... However, if you want this into 1.5 I am sure we can fix the worst parts of the cache pollution in beta stages.

Your call :)
Right, this is a remainder of the history of my patch. Will fix.
module_name == object_name.lower()
Splitting this out to separate patch seems like a good idea to me. And, I suspect you would want to do this post-commit of this patch. This patch is already large enough.

In a perfect world the changes to app-loading would be done in completely separate patch, and then the migrations stuff would build on top of that. If you could do that splitting it would be excellent, but I am OK with just doing everything in single patch/branch.

It seems like a good idea that auto_register = False implies that no related model changes are done.
explain. removing due to it being set explicitly above
Adding this makes things crash: `('<script>lol()</script>ok', 'ok')`.
The fix for MADLIB-461: AR: Result is incorrect when running on dataset mushroom. 

The old version use the hash key of a svec to unique identify an association rule. However, as we know, the hash key is not unique, which cause the result is unstable. Especially, there are a large number of rules. Here, we define the table as below. As we know, the serial type will generate the unique number for each inserted row. Furthermore, we use the code ```DISTINCT ON({0}.svec_to_string(set_list))``` to select the unique rules (set_list, which is a svec). We can't distinct on the svec directly, since it's not hashable. And the group by on svec also has problem (MPP-18127).

```python
    plpy.execute(""" 
         CREATE TEMP TABLE assoc_loop_aux 
            (
            id              BIGSERIAL,
            set_list        {0}.svec
            )
         m4_ifdef(`GREENPLUM',`DISTRIBUTED BY (id)')
         """.format(madlib_schema));
```
In my local copy, I temporarily removed the explicit cast. So I can get the system reported error.

If we think the system error message is acceptable, I will remove the checking code and the explicit cast.
Currently this is handled from the caller, which is lmf_igd_merge::run() here.
Though this function is static, we think naming collision is not good. Thus, we added the prefix of "dt_" to avoid potential collision. What's the value of changing it to "cstring_to_text". Don't you think naming collision is bad?
In previous steps, we can guarantee the input data do not have duplicate index.
This has landed now, so you can switch this back. The stuff you want is in master tip.
No idea. Just don't like `www.` :P
Thanks for the catch and the suggestion.
I took most of your suggestions and refactored the code. I won't be able to work on it again until Monday.  The one place where I did not refactor is where we test if we need to run the wizard.  This is because you need to jump through hoops to get the data needed to run the wizard if we moved the code to the Runner.run! method.  It needs to be thought out a little bit.  I'll fix it when I get the chance but for now it is happy in initialize.

--
John (J5) Palmieri
I completely agree with the second sentence; still, I usually try avoiding invasive changes to existing code, in the attempt to reduce upstream merging friction...
In the case of the directory server we use, the naming attribute is the only one being accessible to the anonymous user.
In the (test) instance setup, I've set as User the uid as a User Display Name Field.
Noticed further down, thanks!
Remove or uncomment the logger line.
methoden sollten nur public sein wenn nötig. die öffentlichen schnittstelle einer klasse sollte möglichst klein sein, da methoden einer öffentlichen schnittstelle bei änderungen im BC probleme verursachen können.
pep8 nit: the lines should be aligned with the opening parentheses, like so:

```
from sqlalchemy import (Column, String, DateTime, Date, Float, Integer,
                        Boolean, BigInteger, func as safunc, and_, or_, not_)
```
Yeah, I was wondering about this.  I presume we don't have any tests that force the concurrency case that could have detected this?
`@Override` goes on the same line as the rest of the declaration. Not everyone has 30" Google displays!
I think there's corner cases that allow you to get < in using the unicode char codes.  There's a ton of edge cases in sanitization.  Instead you want to use a whitelist.

This guy does it properly: 

http://wonko.com/post/sanitize
Ok, so I should just return `undefined` instead of `Date.now()` and ijod will set it for me?
Yes, what I meant is a selection that starts and ends in empty tokens. This includes when you selected just before the text and/or in empty lines. In this cases CodeMirror doesn't add tokens, even if it is actually inside a comment, so it needs an extra analysis to see what happens.
No, we just don't need min-width/max-width any more it seems like if we want to make the sidebar fully moveable.
Looks like the `origDescriptor` argument is no longer needed.
Nit: listes -> listens
This change should fix that. navigator.language returns the empty string, which is then overridden by brackets.app.language.

We cannot rely only on brackets.app.language because this code is executed before everything else and thus brackets is undefined in the browser.
Typo: "or" --> "For"
You're dropping one condition here and I think this is the culprit for the unit test failing.

You need to AND exports.config.experimental condition with your _isHtmlFileExt call.
Add the fixed code her
Don't leave old code commented out. If it isn't used, delete it
Where's the error message for this validation?
The pool is only used, if a header_map is present; could you move the call to pjsua_pool_create?
I will merge your pull requests as soon as possible, thanks again for your contributions!
apologies, should be fixed now!
No, it doesn't matter. It is interpreted the right way. If there is a convention for GeoExt to do it like this i will change it.
Yes! I'll do that.

On Fri, Sep 21, 2012 at 12:57 PM, Kevin Sawicki <notifications@github.com>wrote:

> In app/src/main/java/com/github/mobile/AuthorizationClient.java:
>
> > @@ -0,0 +1,68 @@
> > +/*
>
> This class can be removed now right?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/github/android/pull/224/files#r1663907>.
>
>
this would be a good solution, yes use BUILDID_PUBLIC.
I am not sure what are you doing here with `kwargs`?
What's the difference between password and login_password?
https://webmademovies.lighthouseapp.com/projects/65733-popcorn-maker/tickets/1841-convert-a-lot-of-over-specific-lesscss-to-namespacingprefixing

The other is already filed.
Because I see the same line again 8 lines down. I actually removed that out of curiosity to see if both lines were needed, with intending to file it, but completely forgot.

I will ping you on irc and we can see if it is needed, and see if we should file it. Good catch though! I forgot I did that.
Same deal here, won't we leak this?
Try saving with a blank filename :). Again, copy & pasted.
Do you need either of these in here?
the `i * this.numComps + j` can be just a separate "offset" variable that's incremented here
I think warnings must be logged, if they are not raised.

maybe: 
warnings.warn(message, UserWarning)

See: http://docs.python.org/library/exceptions.html#exceptions.UserWarning
I think it's there to rescue activeresource or activerecord failures.  I added the explicit 'StandardError' just to make it clear that's what's being rescued.

I changed the save to save! since the return wasn't being checked, and it looks like the code is intended to handle failures like that through exception handling.
I think only the first scenario needs to be isolated.  The second doesn't make any HTTP requests, does it?
yes, that's confusing to have them named the same way. I see you propose to renames Answer and Answers below, which makes sense.... 
(the difference is of course that this is an Either3 where the Answer in SPARQL is one single binding. And Answers usually an iteration of such bindings.... But yes. tuning is needed in those two places...
For both of these: the first line binds the counter action to "counter" and the second actually forces that action to evaluate.  There is no returning the counter; that's why the return type is IO () and not IO (IO ())
Should Measure tool only be provided when editing tools are visible (ie when PostGIS used as datastore), or should it be a standard tool available all the time?
These changes are wrong - they remove my new code
there's a close quote missing on the first -L argument
I called them that right up until I realized that calling them `prev` and `next` simplified the code substantially when chaining field references--the list head is only a special case when you need it to be (which is checked with `isa()`).
i'll fix it
We already have a helper method 
```ruby 
def confirm(message)
```
that does the same thing as the following 6 lines. I suggest to reuse it (with modifications if neccessary).
If we do not want it verbose, then I can just remove that ```-vv``` and that is all.
I personally do not like that verbose output as well. But this is how other packages in Fedora and RHEL do that. So I just follow leaders.
Using fully qualified names and a cookie of openacd is prefered.  While the defaults of freeswitch are ClueCon with shortnames, one would need to modify freeswitch anyway...
use the ``getDefaultFormatter`` method instead
See bfa68e9	 (though don't know if I should put it back in light of what @damianb said?)
As part of the window manager cleanup that you asked me to work on, I tried to minimize the public API of the window manager and task manager.  And in the process, I removed stuff that the existing test framework depends on.  So now, I have to dig deeper into the document structure, but I don't have to rely on JS implementation details.

That seems like the right tradeoff to me...
Are those arguments to the ./build.sh script, or are they environment variables you're setting?
If environment variables, isn't the convention to put them before the executable command?
(I don't actually know)
I would either make ``H0``, ``Om``, and ``Ol`` non-keyword arguments, or I would raise an exception if they have not been set, otherwise one gets the obscure message::

    TypeError: float() argument must be a string or a number
Fixed in b07d0cb.
如果改成这样呢： $a_result->merge($b_result)；

感觉用merge一个对象更友好，连totalcount都能合起来，代码写起来也更易读。
Why not use twilio python api for this?  This will explode on characters like '<' and '"'
Don't see a reason to change this. It's better to have explicit namespaces, IMO.
it is for adding fields to a query or to the whitelist?
Are there situations where our offering facilities were expecting their own offered resource pointer pushed back to them (rather than the requested resource)? I imagine you thought about this already, but it seems possible that some facility relies on the offered resource ID or something being sent back to them with the match info.
collateral damage, the IDE likes to add a few internal notes but i have not identified why, i missed this one. Will remove it.
Mostly cut & paste from Mine.  Not everything applies to the teleporter.
Better error message, please.
Good point - just leave it as is.  I wish packages exported the same functions on all platforms, and just threw an error if the platform wasn't supported.