labofsahil/github-event-dataset-2012 huggingface dataset:
Can you check to see what py3 distutils expects here?

On Wed, May 30, 2012 at 8:37 PM, Min RK
<reply@reply.github.com>
wrote:
>> +
>> +        The contents of the cell are written to a `.pyx` file in the
>> +        directory `IPYTHONDIR/cython` using a filename with the hash of the code.
>> +        This file is then cythonized and compiled. The resulting module
>> +        is imported and all of its symbols are injected into the user's
>> +        namespace. The usage is similar to that of `%%cython_pyximport` but
>> +        you don't have to pass a module name::
>> +
>> +        %%cython
>> +        def f(x):
>> +            return 2.0*x
>> +        """
>> +        args = parse_argstring(self.cython, line)
>> +        code = cell if cell.endswith('\n') else cell+'\n'
>> +        # distutils.Extension cannot handle sources that a unicode
>> +        lib_dir=str(os.path.join(self.shell.ipython_dir,'cython'))
>
> Shouldn't it be `sys.getfilesystemencoding()`?
>
> Also, we should be careful that it is *str*, not bytes, since presumably py3 distutils isn't this broken.
>
> This is a stupid bug in distutils - I commented out the type checking in distutils, and the inlining with unicode paths works perfectly.  Unfortunately, I don't see a clean way of monkeypatching to just fix the checks.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1770/files#r905304



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
In the `NULL` case, shouldn't that be translated to python `None`, which wouldn't be displayed anyway?

I agree that in the case with printing it makes sense to only see the output once.
I was planning to use it as: ```self.custom_conntrol = SpyderControlWidget()```  but I think you're right. It would better match how you create ```control``` in the next line. I'm going to change it.
Well, the eventual goal is to have a full `git_clone` command in the API... But regardless, I'd say this needs to be exported. I'm sure somebody will want to implement some kind of whackass partial clone or the likes.
for more personal projects I usually follow the convention of db_projectname for the database and pg_projectname for the user (pg is for postgres). We could do something similar here.
Looks like persisted is empty, same as within the saveScreenshot method:

    INFO | frame: {"events":{"currentState":null,"currentModule":null,"currentTest":null,"userShutdown":false,"appQuit":false,"listeners":{},"globalListeners":[null]},"timers":[],"persisted":{}}
nice touch. @Roasbeef
Consider combining these two methods into one notification email
Forcing hash params would allow you to just set this to `Hash.new`.
documenting it as ``integer|string`` would be more precise than ``mixed``
I would have used `parent::set('expires', 0)` and `parent::set('pragma', 'no-cache')` instead.
right @stof true, but i mean to say that if we want to pass a Configuration as argument it has to extend ConfigurationInterface.
(:all)の中ではmockを作成できないので注意
(:all)でる必然があって使ってますか??
maybe "posts_count" was NSString or NSNull?
add spaces before and after `else`
Is it possible to separate animation block to something like:

    -  (void)dribbleAnimationWithView:(UIView *)view { ...

or

    -  (void)dribbleAnimationWithView:(UIView *)view completion:(void (^)(BOOL finished))completion { ...

and reuse it for `plusButton` and `commentImageView` below?

BTW and the end of this animation cascade you don't set `self.currentlyAnimating = NO;` is that intended?
Used to be - we needed to use the system ruby here because the aws bundle script (run on instance) would not work with newer ruby.  May not be the case anymore - but you should test this.
you change retrospective changes, why? I think that build team doesn't like it much
wa !
in chiye
html koo ?
нехватает уникальногг индекса для user
A negative or zero age means to not run the dbcleaner.
Might perhaps be enough with this regex?
Catch the exception, raise's it with the exception message. e.g: ````raise CommandError('Exception while deleting tags: '.format(e.message))````
perhaps reverse the order of these three and do an ```if .. elif .. else```?
nit: prefer ' over "
"Has been removed" is probably more appropriate
any reason we're leaving the commented code in here?
This was a bit weird, _sudo was not actually implemented for some reason. I
was going to check with Mark as to what the intent was.
Absolutely!....definitely needs to be private. Let me work on this one.

On Mon, Jul 23, 2012 at 1:52 PM, Duncan McGreggor <
reply@reply.github.com
> wrote:

> > @@ -8,11 +8,11 @@ class PfManager(base.Manager):
> >      EXECUTABLE = '/sbin/pfctl'
> >
> >      def _show(self, flag):
> > -        return self._sudo('-s' + flag)
> > +        return self.sudo('-s' + flag)
>
> Is there any reason that you removed the underscore here? There are other
> calls in this code to _sudo ...
>
> We probably don't want to expose _sudo as a public method, so the
> prepended underscore (signifying a private method) is probably best...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/dreamhost/akanda/pull/4/files#r1217637
>
I've done so; you're right that this test doesn't depend at all on the object being global.
Added an option to enable hook events as needed. Does it fits better?
what is the second widget? Should that be native_event?
Ukrainians use postcodes, what consists of five digits only, but default Address provider generates postcodes like "86039-9874" .
Can't tell if this line is >100 chars but if it is can you wrap it?
I would like to keep those at it's the only way to see what the app is doing without having a control webinterface.
Use `options.each` instead? Its a jQuery object.
That would result on a > 80 chars line, which create a jslint error :(
@fabricedesre thanks for the heads-up. What's the reason for removing localStorage? 

As suggested time ago by @davidflanagan we would need a library to make it as easier as possible to store simple data by following a similar interface as localStorage but using indexedDB as persistence mechanism. @davidflanagan do you have some code for that? If not I will be happy to contribute something later on ...
geko will fire a mozChromeEvent 'captive-portal-login-abort'
I'd use "app-install-success" (I've begun to use 'app-install-' prefix for new keys)
1. Again, please remove the raw data from Gaia. We don't need to ship two big files.
2. Anthy is under GPL. We cannot use GPL content.
3. Anthy README status the dictionary is coming from Cannadic ( http://cannadic.oucrc.org/ ). You need to reference the dict there.
4. Cannadic is, again, under GPL :(

I'll halt review from this point unless we can confirm that here is another dict with compatible license, or at least acknowledge that Cannadic is a temporary, unshippable solution.
Debug code need to be removed or perpend with something like `if (DEBUG)`
Yes, the sleep menu is showing and no need to do something in this case.
My comment is not explicit enough.
here also can you also add a note about using APP= to only run tests for one app (lowercase name of the app like APP=calendar)
moving to utils +1
This 'for' loop for noMissedCalls is quite similar to the missedCalls one, can you refactor?
Again, one line comments describing what are the functions doing are always welcome.
So the TODO comment is wrong?

Guess I am not clear. Does -n override color in all cases or not?
Turbolinks is trying to reimplement enough of the browser's semantics so it can satisfy the goals of being a drop-in. Good luck!
This should also check for string keys.

I.e:
```rb
DeepStruct.wrap({"a" => true}).a? == false
DeepStruct.wrap({:a => true}).a? == true
```
before

    `--noqueue` オプション

after

    ``--noquese` オプション
Wow it feels like specs should be doing this already... It sucks that they don't.
try:

    [[ -z "${rvm_stored_errexit:-}" ]] ||
    {
      set -e
      unset rvm_stored_errexit
    }

the single `=` messes travis build
Is this white space change necessary?
Gah, I don't know what happened here... I just wanted to add the few lines regarding helm!
You are still using browser sniffing and not feature sniffing. This is considered bad practice and should be avoided.
Then why add it?
Need to specify a radix -  `parseInt(number, 10);`
まず始めに巣のオブジェクトをモデルの参照に変更し、
それから不正なモデルや重複したモデルが追加されるのを防ぐ。
Backboneの例としてリポジトリにバンドルされている[Todo List アプリケーション](examples/todos/index.html)は[Jérôme Gravel-Niquet](http://jgn.me/)が作成したものです。もしBackboneをどこから始めたらいいか迷っている場合は、ひととおり[注釈付きのソース](docs/todos.html)を読む時間をとってみましょう。このアプリケーションではサーバにブラウザ内のすべてのtodoに送らずに、[LocalStorageのアダプター](docs/backbone-localstorage.html)を利用して透過的に保存します。Jérômeは[localtodos.com](http://localtodos.com/)にjQueryの代わりに[MooToolsを利用したバージョン](http://github.com/jeromegn/backbone-mootools)も作成しています。
please remove this bang
Why the hell is there these Evernote notifications? >_<
OK, I see, in that case so should this pull request be closed, if you are not interested to have it. I just thought it could be a good thing to have in the library, especially when it remove any attempts to receive a directory above "wwwroot". But I came up with another thing, sending files in a effective way. See what I have written about it in "uri thread" on the Google groups thread. You can answer there as well, or maybe Glyn.

PS. I will let Glyn close this pull request, when you have decided if this function should be added or not, but if so, please let me know faster, so I don´t waste time.
Ah ok.  This is how we do it with the Android app as well (https://github.com/iFixit/iFixitAndroid/blob/master/dozukify.sh) 

This works, but it would be great if we could have separate data files for storing these values, rather than relying on scripts - unfortunately I don't have any suggestions yet.  We should keep our eyes out for a good way to handle this.
Could you revert this line's change?
Wouldn't a message be better than none?
why params however, it can be instance variable
You may have to figure this out, it shouldn't happen:
  http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/loader/XPCOMUtils.jsm#351
Isn't it easy to trace using console.trace() ?
BTW why not call it `options.contexts` ?
authLevel doesn't seem to actually be used anywhere.
Some kind of `href` attribute (even something descriptive like `href="#close"`) would be nice. You can also use double quotes to wrap the string to avoid the `\` (`{{ _("No thanks, I'll risk it.") }}`).
not sure if that's what people commonly do, but I am not sure I like "client" to be the name of the data store. Sadly, I don't have a much better word handy, unless you just want to call it ``redis``, or ``db`` perhaps.
For `null`, triple equals makes more sense (unless you're just testing for truthiness, in which case the ` == null` can just go).
Does this work correctly if both options and a block are passed?
Features already have a library argument to do this
Changing directories feels wrong, for multithreaded programs it randomly disrupts Dir.pwd for other threads.

Checking if a directory exists and rebuilding paths feels like unnecessary work that glob can do for us.

Why not the simpler:

```ruby
def self.glob dir, pattern
  dir = dir.gsub(/[*?{}\[\]]/, '\\\\\&')

  pattern = File.join dir, pattern

  Dir.glob pattern
end
```
Yeah, whatever the variable ends up being called.
oops, forgot the quotes. meant 'false'
@tkruse Was this the additional instance you were talking about?
Block should be removed, rather than just commented out
@Maks3w: should I go forward with that? It looks like a big BC break for the DB writer, as the default column name (if not using a custom mapping) would have been `timestamp`. Alternatively, we could try passing an integer timestamp in the event data and use DateTime as-needed for formatting purposes ([date()](http://php.net/manual/en/function.date.php) wouldn't be as robust for timezones). That would at least alleviate concerns about how the DateTime object might be handled in the DB and ZendMonitor writers.
No need to comment; remove. :)
change $_latestVersion with $latestVersion because static property is $latestVersion, not $_latestVersion
bad replacement
Very true, do you think it would be useful to handle other content types as well ?

If so, maybe we can create some kind of pluggable content type handler that formats data depending on content type...
also you should use single quotes
uses is no longer needed.
Must be spaces around the points
Why not keep it?  It future proofs the app in case you later do change super.onBind()
Are we supporting only ENGlish?
please provide docblock?
Fail 2: I use :cUncurrently instead of :cOncurrently.
Oh, one small thing: there's a space missing between `;` and `}`. Thanks.
But the changes you are doing in both places in this class are precisely about **not** treating them as entities (mapped superclasses are not treated as entities as they are not entity)
Yes, I kept it, because it shouldn't.
btw, you don't need to use ``else`` in this place as the ``if`` leaves the function because of the exception
確かに！
ありがとうございます :+1:
from vsc import fancylogger
is this correct? the [0] is there for a reason...
This is the name used by TestCase. So unfortunately we cannot change those.
you could use ``defaultTrue()`` here
The package name shouldn't be nested like this - wicket_ear would be conventional.
I know it's only a test, but add a space after the parens
Hmm, yeah, I think I dropped the <ul> tag on purpose because the ul box looks weird when placed with the "this work has multiple chapters" tickybox. The labels are admittedly fudged, though, and I can twiddle with the title.
I thought we didnt need this eventually?
@isratrade I'm not sure, look at the generated query above
In fact, with the case insensitivity, it should be like this instead:

```python
try:
    user = User.objects.get(email__iexact=email)
except User.DoesNotExist:
    raise ValidationError...
return user.email
```

That way, the form will accept "peTErBe@Gmail.COm" but spit out "peterbe@gmail.com"
wrong version, should be 6.1.5 like in all other files
What if the song is played or requested less than an hour ago?
I don't think this method is needed.  running_nexus_pro? is the function that checks to see if we're running nexus pro.
Place this function at the top of the class after `InitializeMappings` Also It'd be useful to add header comment to point out that it's the main entry
can you use double quotes for string literals and the strict non-equality operator is not necessary here (because typeof ALWAYS yields a string)?
This one is my fault...the resource opened by urllib.urlopen needs to be closed by calling .close() on it. Sorry about that, could you fix it while you're in there?
Why you use require_once and below include_once? use the same statement please
"x"? i think that "w" is better
что-то меняет?
The description isn't very clear on it's usage. Do you think you could improve on that as well as adding an example block?
I feel like these should default to `True`, since we're allowing Django 1.4 to continue using the old ways.
So, to clarify, by "these should default to True", you mean we should switch it to JINGO_MINIFY_USE_MEDIA and default the value to True and we should invert the if block of this function. Is that right?
A better locator would appear to be `#page .content`
Why include imu?
Are you saying that we should have a different default for the different databases?  I'm fine with setting the global default to 7 days.
broke methods out of `class_eval`
I can take them out
This is not in line with the API doc. It should just be `{anon: true}`
I'm assuming this is direct and indirect membership. It might not hurt to document this explicitly.
I've already removed them locally. Were some remaining debug statements.
Can instanced of this class be accessed by different threads? My intuition if that it can, if that is the case, then both ``label`` and ``isTerminatedFlag`` should be declared as ``@volatile``.
I'm not satisfied with this implementation, so let's remove this for the time being. Dates are more complex, plus I kinda want to implement this in pure mscript so it's portable.
Noem dit `handleWallCollision`?
Maxim cпасибо, насчет Х процентов учел.

n1oise Capacity из property я просто забыл удалить) начинал реализовывать одну идею, потом отказался) 

P.S: скоро залью новый, без мусора и с другим мутатором
объявление init в этом интерфейсе не нужно, по сколько оно уже есть в интерфейсе супер класса NSObject
The return code from GetFileAttributesEx() should be checked for success/fail.

http://msdn.microsoft.com/en-us/library/windows/desktop/aa364946%28v=vs.85%29.aspx
Comparison against `RACTupleNil` should use `isEqual:`. It shouldn't be necessary, but there's also no reason not to.
Or an `NSRunLoop` (see above about `NSTimer`).
oops forgot to adjust the indentation...  I'm using vim so I think it is actually <TAB> that is being inserted at the beginning
Nei,  det tror jeg ikke..  Kan godt  være en id i stedet..  Må bare huske å
endre det i htmlfila også.

On Sep 10, 2012 7:00 PM, "Jari Bakken" <notifications@github.com> wrote:
>
> In app/assets/javascripts/feedback.js:
>
> > @@ -0,0 +1,14 @@
> > +$(function () {
> > +  $('.slide-out-div').tabSlideOut({
> > +    tabHandle: '.handle',                     //class of the element
that will become your tab
>
> Er det noen grunn til å ikke bruke en id på dette elementet? F.eks.
#feedback-handle siden den er unik på tvers av hele siten.
>
> —
> Reply to this email directly or view it on GitHub.
Scratch that last bit--it should be doctype since it corresponds with the ES index argument.
why not just change this line to `: path.resolve('/tmp', '.npm');`?

Then it works on Windows, and on *nix/OSX.
getByPrimaryKey is too long ;) getByID or getByPK
Globbin vs Globbing
This is already in Prezto, see the Ruby module.
So the render php method also takes an URL?
Each line should be indented by 4 spaces
Can you convert the conditional to an `if`, so it will not look awkward when chaining? My head is almost exploding when trying to parse the `unless ... || ...` condition.
We are still supporting 6. It could be improved to do directory streaming if it detects 7 is used.
You can do:

intercept[CamelExecutionException] { ... }.getCause.getClass must be ...
It has to - it's a camel bean
Can you turn this into something like this?

```javascript
if (!dlerror_msg) {
  console.error('Skipping test, platform not supported.');
  process.exit();
}
```
Btw, I needed to add autoHeight: true here for fill: false to work okay.
Can we add a line about the options available in the docstring?
Could you import multiplicity from factor_ and do this:

m = multiplicity(p, n):
if m:
    factor = p**m
    tot -= tot//factor
    n //= factor
Мы не ориентируемся на идиотов. Но делать сообщение для этого - это просто
полный конец. Я категорически против.
Defaults for the email templates are part of the model and obsolete here.
Make dates consistent, i.e. all "year".
cool. Thats awesome.

On Mon, Dec 10, 2012 at 4:33 AM, Nathan Rajlich <notifications@github.com>wrote:

> In package.json:
>
> > @@ -24,7 +24,7 @@
> >    },
> >    "devDependencies": {
> >      "mocha": "*",
> > -    "wav": "0",
> > +    "wav": "https://github.com/TooTallNate/node-wav/archive/master.tar.gz",
>
> revert this too; i'll publish wav asap
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/TooTallNate/node-lame/pull/9/files#r2359179>.
>
>



-- 
Arunoda Susiripala

@arunoda <http://twitter.com/arunoda>
<http://gplus.to/arunoda>https://github.com/arunoda
http://www.linkedin.com/in/arunoda
You have to enhance this, it is not understandable
What if `watch` is a function reference, not array reference?  Need to do something like
```javascript
} else if (angular.isFunction(watch)) { 
 //treat as fn
} else {
 //treat as array
}
```
I've added a note about this.
I think the move of the add line is not necessary, as index is zero-based and size() one-based
Ah yes!  I never understood why such a frequently re-implemented comparator wasn't in the standard library.  Now we have it.
I think the new package has a RationalCounter interface that mimics this.  Would that serve as a replacement?  As is, this class is very specific to strings, when it could be made generic.

Also, the Counter interface has a getFrequency method which is really the observed probability.  Perhaps it's better renamed to highlight that?
should be `belongs_to`
This cannot be imported when the class is first parsed or there will be errors since instance.models depends on the reddwarf.db. While reddwarf.db is being imported for the first time, it dynamically imports this class (this seems like it *might* be a problem for other reasons...) and so anything from this class that needs reddwarf.db fails.

I feel that putting the import inside configure_db makes the fact we're working around this problem apparent.
This message should only be printed if the size was calculated. IOW, if the agent is in use.
Let's not be too adventurous here, the optional dependency is not ideal, but the consequences of moving classes around at this stage might be a bit too risky.
And does it work?
That just doesn't sound correct. It would imply that any _greater_ number of lines would result in a merged hunk, which makes no sense.
great. maybe you could add a line or two in the main README.md doc describing this behaviour and reference that from here. oh, and describing what exactly router and browser guesser do could be helpful too - but thats not the scope of this PR.
A note in here would be useful regarding ```@cleanup```.
Yeah, this is wrong. This states the same as the default, that the test does not require the emulator. I would recommend a 'camera' attribute for any tests that require a camera. That way when running on an emulator we would do `--type=b2g-camera`
This means any stable version and would automatically bump major and minor versions as well; should be limited to a specific minor (phpunit is wellknown for BC breaks between minors)
Return the execute results.
Elegant solution.
Please change "FIRST", "LAST", etc. to single quotes
type BIAS
shouldn't this be `#{name}-#{number}.#{shard}` ?
Can we add to the comment at the top of this file to give an example of this option in use?
You can use #try for the nil check too:

```
metric_count = record.try(:[], 'metrics').try(:[], alternative.to_s)
```
Why do we only support a single cache pool?
What if we created a new file, then moved it on top of the old one?
I can't imagine why anyone would want to make `package_name` different from `source_name`, especially since your code doesn't support multiple-binary-packages-from-one-source-package anyway.
(On the other hand, I **can** imagine someone who's not very familiar with debian packaging system being confused by these docs, or setting them to different values just because he can, without understanding what's going on. In other words, providing this option may be cheap, but not free.)
Fixed.

On 8/8/2012 4:52 PM, Bennie Leonard wrote:
>
> In docs/dev/windows-configurations.md:
>
> > @@ -0,0 +1,129 @@
> > +---
> > +layout: post
> > +title: "Getting Started Windows"
>
> Getting Started /in/ Windows.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/cilib/cilib.github.com/pull/17/files#r1332874>.
>
Using the "versions" handler here feels arbitrary. Can you explain this?
how about a simple `+`, no need to use the whitespace string concat
Based on the build, this list of valid tokens will be different. Lets list the valid names here based on build output.
``` js
Element.ShortStyles.backgroundPosition = {backgroundPositionX: '@', backgroundPositionY: '@'};
```
Cool, thanks for the explanation. What about introducing a new datastore parameter in the csv datastore that would control what parsing strategy to use. The importer could perhaps recognize the factory and set it accordingly. I guess it depends on how custom you think the csv datastore is already. If it is pretty general i think ti would be good to keep it that way and not have it introduce any specific dependencies on the importer. But if its already custom then i think this approach is fine.
Actually it's ``Class<? extends Input>``. I've added it to the field declaration as well. Doesn't seem to cause any particular ripples.
This should also be `author`, no?
I add $('#id_password2').keyup(checkPassword()); to $(document).ready(function () { but doesn't work
That is in fact a good idea. Can you do the same for Foursquare and Google backends?

And move this `if` part to the beginning (before e-mail). So that all are always in the same order (and the order of values in the model definition).
I would move this to `models.py`, so everything is at the same place.
Indent only once, not twice.
For now you can use our default user image we already have. So that there will be something.
And no, it is not correct to use `../images/logo.png`. Do we use such links in Django templates?
Field access does not cost so much that we would really need a variable. ;-)
OK, I see it bellow. You ask user what to do ...
This works because the framework keeps track of the servers internally. You _can_ assign the reference to a variable if you needed it later. In many cases it won't be needed. If you look at the static variables on X.Server you'll see where those references are stored.
Also, this is sorta fragile. I feel like there could be a better way to do this.
```c++
enum GenericLifebloom
{
    SPELL_TUR_RAGEPAW_LIFEBLOOM_EFFECT              = 52552,
    SPELL_CENARION_SCOUT_LIFEBLOOM_EFFECT           = 53692,
    SPELL_TWISTED_VISAGE_LIFEBLOOM_EFFECT           = 57763,
    SPELL_TWISTED_VISAGE_LIFEBLOOM_EFFECT_H         = 61489,
    SPELL_FACTION_CHAMPIONS_DRU_LIFEBLOOM_EFFECT    = 66094,
};
```
This triggers an error for me, and this appears also if I'm using genemu_jqueryautocompleter_entity :
```
Expected argument of type "string or Symfony\Component\Form\Util\PropertyPath", "array" given
```

If I delete those two lines, everything works fine until the binding of the form and I get :
```
Fatal error: Call to undefined method Symfony\Bridge\Doctrine\Form\ChoiceList\EntityChoiceList::getIntersect()
in vendor/genemu/form-bundle/Genemu/Bundle/FormBundle/Form/Core/DataTransformer/ChoiceToJsonTransformer.php on line 61
```

Any idea what's going on ?
Huh. Okay, let's add this. Its basically the same and unbreaks it for ya.
That does not seem right. If this used as real recordReader, cascading should have access to the reporter created by MR. will look at where this is done in cascading.. I am not that familiar with it.
the metadata we are storing is actually a Protobuf message (has info on number of columns in the thrift struct etc). I was wondering if we should make Thrift RCFiles store Thrift version of the 'ColumnMetadata'. 

Currently there is a protobuf dependency for Thrift RCFiles.
LuceneHdfsDirectory?
awesome. one day I'll get that plugin working, and we'll have moztrap integration! :)
Any reason why this is quoted?
Whitespace `new  cls`
We should access globals with window. Maybe just add `var helpers = window.helpers`.
Maybe merge with `show_resource_for_url` into `show_resource_for_id_or_url`, since they are the same?
remove these extra prints before I merge
Yes, comments are hard to find. The best way to read them is in the Discussion tab of GitHub.

The problem with `import models` is that it depends on the Python path what it imports. If you want to import models from the current module, then do:

```
from . import models
```

This is called relative imports. And this exactly specifies what to import.
I think it seems more confusing to change the language from the API spec (which is "products") to "product_urls" even though product_urls is more clear.  Why do you think it makes sense to change the client binding to product_urls while the api uses products?
Ну вот. Код стал читаемее -- исчезли названия tmp, tmp2.
В общем я думаю можно мержить.
Cool.  I think this is good.
Typo, fix pushed
Right.  I see.

I think you'll get this kind of issue no matter how we do the if statement.  With the if (y<0) version you were getting the artifact at the y=0 line.  The problem is that the input image is intrinsically asymmetric.  So wherever the cut is, there is an ambiguity about what the correct interpolated value is.  Do you use the extra row/column or not?  With higher order interpolants, this ambiguity will be for more that just the outer edge pixels, so I don't think the cut and paste solution is right either.

I think I would recommend explicitly making the size of xtab odd if the input image's size is even.  Then you can explicitly copy the lower left edges to the upper right, and the interpolation can proceed without any if statement at all.  (You can also force the xtab to be symmetric by taking the average of the two relevant points in each case if you want.)
I agree on both points.

On May 17, 2012, at 12:38 PM, Barnaby Rowe wrote:

>> +        message = "Warning: requested pixel scale is higher resolution than original!"
>> +        warnings.warn(message)
>> +    import math # needed for pi, sqrt below
>> +    g = math.sqrt(g1**2 + g2**2)
>> +    if g > 1:
>> +        raise RuntimeError("Error: requested shear is >1!")
>> +
>> +    # make sure target PSF is normalized
>> +    target_PSF.setFlux(1.0)
>> +
>> +
>> +    # rotate
>> +    if rotation_angle != None:
>> +        real_galaxy.applyRotation(rotation_angle)
>> +    elif rotation_angle == None and rand_rotate == True:
>> +        u = galsim.UniformDeviate()
> 
> Agree with Mike, and like the optional paramter option (perhaps a `uniform_deviate=None` keyword that only gets queried if using randoms.  I'd make the same comment about the  random number used to pick out a galaxy from the catalogue in the `RealGalaxy` class...
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/154/files#r839436


-------------------------------

Rachel Mandelbaum
http://www.astro.princeton.edu/~rmandelb
rmandelb@astro.princeton.edu
Multi/single line doxygen syntax comment again.
And entity toString in this log statement as well.
agree in general so long as we don't lose the benefit of tests to show how to write code.  helper methods can obscure that.

bear in mind sometimes showing 4 or 5 different things all in one place makes it easy for people to see the variety of ways something might be used.  when they are in different methods it is harder.  so it depends.
oui c'est mieux
This should return an `id`, not an `objc.id`. The original Java code returns an `id` and not an `int /*long*/`.
Ugh, what is it with people needing to see actual representatives of these sets? This is about getting the correct logic. The correct logic is, at this point, *obviously* what I've been giving you. A representative is any member of the set (Callable `\\` Function), which, as you know, is interpreter dependent. So is this set non-empty in any interpreters? Yes, in at  least a few old versions of the most popular JS interpreters, RegExp instances implemented `[[Call]]` and their `[[Class]]` was not `"Function"`. And there may certainly be other less popular interpreters that provide similar objects. But they reversed those changes, probably because of poorly made choices like the one you're advocating right here. You know what the correct logic is here, but you instead want to make some assumptions that you know may not always be true.

This discussion reminds me of jashkenas/coffee-script#2024 -- just because a language feature is not popular doesn't mean it should be ignored. These kinds of objects are perfectly valid. I *highly* recommend you read the commit comments over at kriskowal/es5-shim@e66ac9e316c1fb72b112e498f586229156fe18b9 where I had a similar argument. If you're not convinced after this, there's just no reasoning with you. I'm done here. Take it or leave it.
Could you explain what exactly is being done here?  Also, since I'm extending the Joomla Platform, you should be able to get the `$_COOKIE` superglobal through JInput (try `JFactory::getApplication()->input->cookie`).
If we don't need this anymore, do we need it at all?
Any chance this test would fail because of the difference between how the test creates the expected values (Date ctor with millis since the epoch) and how the generator generates the actual values (Calendar.setTimeInMillis())?
More like this? https://gist.github.com/3959827
what about a fluid interface "null, false, true` is not really explicit
The style was correct before :)
What about:

init: function calculator_init() {
 document.addEventListener('mousedown', this);
 document.addEventListener('mouseup', this);

 this.updateDisplay();
},

handleEvent: function calculator_handleEvent(evt) {
  switch (evt.type) {
    case 'mousedown':
        var value = evt.target.value;
        switch (evt.target.dataset.type) {
          case 'value':
            this.appendValue(value);
            break;
          case 'operator':
            this.appendOperator(value);
            break;
          case 'command':
            if (value == 'C') {
              ...
            } else {
              ...
            }
            break;
        }
      break;

    case 'mouseup':
       window.clearTimeout(this._timeout);
       this._timeout = 0;
       break;
  }
}


I'm also pretty sure we can simplify the code in general :)
Does this mean that when settings are present in bitcoin.conf that are also set in the Qt settings, the ones from bitcoin.conf are used, but when trying to modify them, they go to Qt settings, where they are ignored?
Please indent properly
machineUtils seems to growing a bit.  maybe we should start refactoring some things into MachineController?
Well, I almost always try to allocate git_vectors on the stack, but for the iterator case, I want to have a vector of vectors so there is no easy way to avoid heap allocation for this case. It is an unusual enough case that I'm willing to move the heap-based vector allocation into a static function inside iterator.c instead of making it part of the vector interface.
I guess at the time the code was written PHP 5.4.0 was not released.  It can certainly be `5.4.0` now.
Not good. This is not assured to merge with the previous bitfield. Plus, it makes no sense to define the field as `enum` when you're performing bitwise operations instead of storing pure enum values.
Fair enough. I'll redo the entire thing, it was a bit hefty in the end :)
Shouldn't this block have a `mkdir_p "#{TARGETDIR}/cookbooks"` before the loop to be sure the directory exists?
Otherwise the first time this directory won't exist and will fail.
Закрываешь System.in
Этот if надо переместить выше, до копирования в resultNotation.
Instead of putting the default function implementation here, it would be better to use the options merging functionality built into the framework by setting the default in the defaults block.
In bug 751949 I had noticed that the initial event that was of interest had a document, not a window, flag set. It seems that this event will be ignored now.
Added because my repo wasn't the original, this'll have to go.
This really doesn't belong in the context of a mock app object...
Place code snippet in double quotes
> Why aren’t you using make_regression here?

fixed
`pl.ylabel('Partial Dependence\nwith house price')`
> That was a bug of the docs

It's been fixed :)
@amueller: I got those seeds by searching for seeds leading to different outputs. Couldn't think of an easier way to reproduce the flipped output, if you do, please give me an idea.
that doesn't look right...
One last thing: use `_call_program` here
Gosh.. avoid spaces after parenthesis.

    is_numeric($parameterValue) ? $parameterValue : $this->quote($parameterValue);
Found it.  Thanks.
I suggest not trying to list the file types it applies to (there's a lot and it could change).  How about:
  preserve source path for output files
or
  place output files in the same directories as their corresponding source files.
Same question as above regarding default usage..
us.
Shouldn't this return the enum type of LSFSharedOK?
Not new, but this should probably call newkeys.ensure(n); for efficiency.
(same for sizes and filepos)
>Extracting the key (and calling this getFlags() function is only ok if selectInterface(TAIhashdedupargs_2) returns non null.
>Otherwise you may have backward compatibility problems with old workunits.

For simplicities sake, do you think if not avail. I should just follow extractKey route, i.e. not pollute code with checks on sizes of key meta vs record meta..
This function doesn't quite feel right.  In one case you are returning 
    %n
in another
    %x = ...;
one is a reference, and another is a definition.  I think you are probably overloading the function for multiple uses.  You really have

expandExprDefinition() - expand if not already expanded
expandExprUse() - expand the use of an expression.  assert if not already visited.
Yes, I think so. We want to stop using that setting.
Take a look at how user messages are issued in some of the other class-based views. There is a new pattern I am following which enables better customization of levels and text. This (and any others) should follow the same pattern.
папку ```.idea``` нужно добавить в ```.gitignore```, чтобы git её игнорировал
Missing semicolon btw, I guess I shouldn't trust that green travis icon so much until we have more test coverage ;)
Wouldn't it be better:
`return (fulfillment) value`
->
`return value (fulfillment)`
?
oh, and I justs tested it: `https://a.pod.url/photos/:id` shows the photo and `https://a.pod.url/photos/:id.json` returns the json-ified photo information.
Actually, I think that this line in the magic: 

https://github.com/arokem/python-matlab-bridge/blob/master/pymatbridge/matlab_magic.py#L238

Might already be taking care of that (?).
You're right. I glanced at it very superficially, and assumed that was the
problem. Here is the error I get when doing a query count of the following
filter:

models = MyModel.objects.filter(id__in=modelIds).filter(outDt__isnull=False
).filter(outDt__gt=inDt)

models.count()

---

  File "/Users//Documents/workspace//src/django/db/models/query.py", line
336, in count

    return self.query.get_count(using=self.db)

  File "/Users//Documents/workspace//src/django/db/models/sql/query.py",
line 401, in get_count

    number = obj.get_aggregation(using=using)[None]

  File "/Users//Documents/workspace//src/django/db/models/sql/query.py",
line 367, in get_aggregation

    result = query.get_compiler(using).execute_sql(SINGLE)

  File "/Users//Documents/workspace//src/djangotoolbox/db/basecompiler.py",
line 360, in execute_sql

    count = self.get_count()

  File "/Users//Documents/workspace//src/djangotoolbox/db/basecompiler.py",
line 421, in get_count

    return self.build_query().count(high_mark)

  File "/Users//Documents/workspace//src/djangoappengine/db/compiler.py",
line 68, in _func

    return func(*args, **kwargs)

  File "/Users//Documents/workspace//src/djangoappengine/db/compiler.py",
line 140, in count

    return len(self.get_matching_pk(0, limit))

  File "/Users//Documents/workspace//src/djangoappengine/db/compiler.py",
line 323, in get_matching_pk

    self.matches_filters(result)]

  File "/Users//Documents/workspace//src/djangoappengine/db/compiler.py",
line 346, in matches_filters

    return self._matches_filters(item, self.query.where)

  File "/Users//Documents/workspace//src/djangotoolbox/db/basecompiler.py",
line 266, in _matches_filters

    submatch = self._matches_filters(entity, child)

  File "/Users//Documents/workspace//src/djangotoolbox/db/basecompiler.py",
line 276, in _matches_filters

    if isinstance(value, (datetime.datetime, datetime.date,

NameError: global name 'value' is not defined

On Tue, May 1, 2012 at 10:10 AM, Simon Charette <
reply@reply.github.com
> wrote:

> > @@ -271,7 +271,7 @@ def _matches_filters(self, entity, filters):
> >                  entity_value = entity[field.column]
> >
> >                  if entity_value is None:
> > -                    if isinstance(value, (datetime.datetime,
> datetime.date,
> > +                    if isinstance(entity_value, (datetime.datetime,
> datetime.date,
>
> That doesn't look like a typo to me -- how can `entity_value` be and
> instance of `datetime.datetime`, `datetime.date` or`datetime.time` if it's
> `None`?
>
> Is it triggering any issue?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/django-nonrel/djangotoolbox/pull/27/files#r755916
>
Im sorry, but i dont understand, how else should it be configurable? Could You explain me? :)
Might make senses just allow a hash and the ability to set any options.
partition is misspelled here
Caps on "Expect" when ever it's in text meant for humans to read.
Which directories count as 3rd-party when not in the gemcache?  Is it anything not under lib/msf?
There is also a ```'raw_headers'``` option which would save you the effort of parsing above
No, and @joshbohde says it's failing for him, I may have to go back to the original implementation in #191
maybe we don't need to worry about this just yet.
I'm pretty much into website making stuff, and as far as I know, "sidhuvud" is understandable. But I'm pretty sure "sidhuvudsbild" doesn't leave any questions for the member (since I know what it means), so go for that :)
Yes indeed.  Good eye.
Why not use `defaultValue`?
I would write above two lines like this:
```JavaScript
opts = opts || {};
opts['isLeaf'] = false;
```
But this is your call.
Not seeing this change in your latest update.
"Type"?  Why not just MapPoint?  Seems odd to add Type to a type name. :)
I have to disagree with 'platform default color' as it's very much a context-sensitive thing. For iOS, the default color of a navbar is a blue tint that is otherwise unattainable. For text it's black, but a background color it's white, etc.
null check on options?
given the static nature of a suite file I didn't think it was strong enough reason to justify getting into code generation.  I am open to further discussion on this though.
I've just updated the commit with it now.
The converse issue is that if one passes "a==b" (without spaces) that also gets uncaught. Comparing the string alias with a string to check for the default is just unprincipled. It's okay to not operate this change in this diff, I'll propose it at some later point.
How did this sneak in here?  node.address.addr does not exist in release/fred/master.
Shouldn' t the version of this artifact remain as 1.0.0-SNAPSHOT ?
Cette étape n'a rien à voir avec la mise en place d'atoum.
Il vaut mieux merger l'étape 1 et 2 et indiquer "imaginons que nous avons l'Entity suivante", là tu mets le code de Car.
Tu zappes donc le truc avec generate entities mais tu peux mettre un lien vers la doc de sf2 vers les entities avec un texte du genre "pour plus d'info sur les entities dans sf2, consultez le manuel sf2"
nit: you don't actually clear `childArray`, so if the caller gives you a non-empty array this will lie.
getModelsForBundle?
And changed to lower case
I removed them deliberately as flush() was empty
this should have a nice name so that its deployment can be overridden in config
Filing an issue is much longer than adding a TODO statement. Besides, VS IDE can display all these statements in the task list.
it actually doesn't really matter, this is just a test of the CTOR. The real test is at ServiceManagementServiceTestBase which instantiate ServiceManagementService for various tests.
I know this is deviating from the ATOM standard and how we suppose to use XML namespace, however, my experience with Azure service bus is that Windows Azure server only respect namespace for element name. We are tailoring our atom implementation for Windows.
I'm too lazy to check if there's redundancy here. So, pointing it out, just in case.
d.totalSize might not be known at this point. However, if it is and does not match the described size, then reject, of course.
I guess you just want to add -Werror? the other one is already there, right?
I added tests to see what the behaviour was.    I didn't change the functionality of serializing/deserializing when expecting numerics.
То же самое про reload_node. Но здесь логично заменить reload_node на reload
Can you make the CSS conform to the new style guide?
range slider settings (enabling + color)
Don't think we use this anywhere
In fact, why do we need two at all

String ck = StringUtils.hasText(this.correlationKey) ? this.correlationKey : "JMSCorrelationID"
return this.doSendWithExplicitCorrelationKey(jmsRequest, messageProducer, messageConsumer, session, replyTo, ck);
"URI Expression cannot **be** resolve**d** to null" ?
fits return code?
GetCaster()-> fail!?!?
not player-> ??
sure but 0.6.10 has security issues, 0.6.10 is needed on windows because of wrench but it doesn't care on non windows platforms, shouldn't limit everyone else because of windows
I'm not sure wrapping in the middle of the link works well. but then it should at least be wrapped before and after the link instead of doing a very long line (you were even putting 2 words after the link)
typo: instanciate
Ah I see; here is where you're repricing the order, which is why it works.  That's fine; as long as it gets repriced at some point. Although, I would move this section up to only save if the Offer was successfully applied. Also, when you set the ```CartState```, you should actually be setting it to whatever gets returned from ```cartService.save(cart, true)```. That save method returns an Order which is the merged value that you get back from Hibernate after it saves everything. If you try to modify the parameter further (and not the result of ```em.merge()``` which ultimately gets called in that ```save()``` method) then Hibernate might complain that you're trying to modify an unsaved object or something.
testable=true & @ArquillianResource URL ?
Because it's wrong.

Take (OPeqeq (OPconst TYcfloat Nan NaN) (OPconst TYcfloat 0.f 0.f)) for example.

i is 0, then because e1 contains nans, i is flipped and somehow `cfloat.nan == (1.0f + 1.0fi)` is true?

I understand that the special case code exists because of past problems using the built-in comparisons, but if you look a few lines down the default case is handled using the default comparison... so it seems it is working everywhere it has been tested.

In short I followed the lead of the existing working code.
the return value of ``findTaggedServiceIds`` is not an array of attributes but an array of ``fos_oauth_server.grant_extension`` tags.

Here, you are reading only the first tag, instead of handling all tags if they want to register the same service several times with different attributes
A test for "Inspect Element" should be added too, that also tests Desktop of course, but still we have to handle it too.
You test whether fields are defined twice
Fixed in the next line.
Don't think you intend this line to be there?
need an update version of this call and the portal entity editor should us it.
It's a little harsh :)
I think that's okay, the word is well established in the computing jargon.
here too: `if isinstance(index, basestring)`
I believe you :) merged!