labofsahil/github-event-dataset-2012 huggingface dataset:
You can use `info.Data().As<Object>()->Get(...)` here, it's a teensy bit faster.
What should catch this error?  Should we also trigger a Lu "error" event?
I would not return this, it seems good to me.
`super` without arguments will pass the same arguments of the method. We don't need to pass it.
Oops, sorry I didn't note that.
Hm yeah, as a non native speaker, I didn't know the word and had to search for it :)
# Add `rack-cache` to your Gemfile before enabling this.
Needs a comment like:

```
// must be a def because the `expr.tpe` might be set to `<error>` during import selector checking
```

While this restores the 2.9 error messages, it effectively stops checking selectors after the first errant one.

```scala

object X {
  def a = 0
  def b = 1
  def z = 9
}

object Test {
  // expect an error at `c`, and maybe at `d`
  import X.{a, b, c, d, z}

  // no errors expected below
  a.toInt
  b.toInt
}
```

```
ticket/6340 ~/code/scala scalac29 !$
scalac29 test/files/neg/t6340.scala
test/files/neg/t6340.scala:9: error: c is not a member of X
	import X.{a, b, c, d, z}
               ^
one error found

ticket/6340 ~/code/scala ./build/quick/bin/scalac !$
./build/quick/bin/scalac test/files/neg/t6340.scala
test/files/neg/t6340.scala:9: error: value c is not a member of object X
	import X.{a, b, c, d, z}
               ^
one error found
```

If this is intended, it should also be noted in a comment here.
> I suspect that if you define an eq then the default hash goes away so if you want one then you'll need to define it? 

This is correct. `__hash__` should imply `__eq__` but not the other way around (Python 3 will strictly enforce this).  If you are defining `__hash__` on a mutable object, then there is a serious design issue, and you can end up with some seriously subtle bugs if you end up mutating an object that lives in a set or a dictionary somewhere. I wrote a little guide on what can happen a while back at https://github.com/sympy/sympy/wiki/What-happens-when-you-mess-with-hashing.
worisome-> worrisome
Thanks, I moved tests around but I didn't mean to remove this particular one.
I do not know them.  Even if I did, I would not spend the tedious time typing them in, since I feel they are useless.

I suggest the write way to fill out this table would be automated decomposition of the Galois groups.  There should be some script that automates this calculation for all 5 Fermat primes, and then caches the results, which would be referenced here.  I am not a group theorist, and do not have the expertise to write this algorithm.
why do we have 3 variables for a simple string?

what's the use of dateString when dateInputArea can be used?
You are right. In first commit clone not exists. I'm add it only for more security.

PS: sorry for my English, if it has mistake.
I added  !.gitignore back into the file, but git still seems to pick
it up.  Ideas?

Thanks,
-Jim G

On Fri, Apr 6, 2012 at 1:52 PM, Robert Martone
<reply@reply.github.com>
wrote:
>> @@ -6,4 +6,5 @@ styles/css/*.css
>>  bin/
>>  !build/bin/
>>  !styles/css/screen.css
>> -!.gitignore
>
> Sure.
>
> The line !.gitignore should be included in master. If you would like to ignore it in your branch that is fine. We occasionally add files that git listed in git ignore.
>
> Ex. I added the file sandbox.html to the repo. Then pushed it. Then I added the file to .gitignore so that changes will be ignored.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Iheartweb/Lu/pull/69/files#r656710



-- 
jimg at yojimg dot net
fixed

On Fri, Aug 17, 2012 at 10:22 AM, Sean Carr <notifications@github.com>wrote:

> In bin/jack:
>
> > @@ -0,0 +1,16 @@
> > +#!/usr/bin/env ruby
> > +
> > +require 'rubygems'
> > +# require 'bundler'
>
> jack doesn't use bundler, right? Might as well remove these lines instead
> of leaving them commented out
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Rapleaf/jack/pull/41/files#r1404909>.
>
>
Example file should be without module names. Remove module BBFS and module FileCopy.
Add many comments to person which sees this in the first time.
Look here:
https://github.com/kolmanv/bbfs/blob/master/examples/file_indexing.rb
Since ````f.object.credit```` appears many times and the lines are long, precede this section with ````<% credit = f.object.credit %>```` and then shorten all the ````f.object.credit```` mentions to ````credit````.

Can you explain what each of the xxxxPartial JS functions are doing?
And will do.
Again, don't know if you're using tabs instead of spaces, but please use spaces and clean up the indentation (want to make it as readable as possible for future coders).
I think this stanza is just auto-generated by IntelliJ
oops, meant to name this ec2
It's weird that the NoopScalingStrategy takes an S3AutoScalingStrategyConfig.
sure thing.  Good eye.  Will make this and the other changes.

On Tue, Sep 25, 2012 at 3:55 PM, Sam Kleinman <notifications@github.com>wrote:

> In source/reference/operator/positional.txt:
>
> > @@ -0,0 +1,82 @@
> > +==
> > +\$
> > +==
> > +
> > +.. default-domain:: mongodb
> > +
> > +.. operator:: $
> > +
> > +   *Syntax*: ``{ "array.$" : value }``
>
> should we use angle brackets. around <array> just to make things clear?
> I'm leaning towards yes.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mongodb/docs/pull/261/files#r1688796>.
>
>
s/naming it to/renaming it/
This isn't a question?
This won't support the "py" linker as it don't support c code. But we need c code anyway for the GPU at many places. I don't think it is a problem do don't support it for the GPU.
Same comment here.. Can we take this out and move these swell comments down the #loaded_attribute? ?
`$this`
That was not a typo.  I was putting a reminder to add the way to do about windows on Mac.
OK, to be honest, the whole file is messed up, not just the part I changed. What's the correct way to indent? Everything indented with 4 spaces? Or use real tabs?  I will fix the whole file then.
In most cases we try to follow English alphabetical ordering in all-packages.nix, so ubuntu_font_family would come before vistafonts.
We want to have a provider here as well: private Provider Provider
Again, not a massive fan of the added whitespace.
i'm not so sure we should have default settings
Why not raise a particular exception?

Shouldn't filtering a `float('nan')` or similar be OK?  Or is this type meant to have no satisfying elements? If so, since there are already valid non-numeric types in Theano programs, how about renaming this to "NullType" because it represents the null set of possible values.
Sorry, but I don't have time to try to optimize it now. As you don't need it now, I'll put this aside for now. If this become a problem, just tell me at that time.
why is the request factory called requestContext it sounds confusing
i don't think so, the test name again.
Seems like the sentence cut off prematurely.
Thanks.
1. As per discussion, QA can sort the pre or post column to get the stable result for each running.
2. Yes. And the performance of compressed bitmap will be better than svec. We will think about that.
Hi Hitoshi, something like the following? But it looks like that the postgres cannot find this aggregate to use.

m4_ifdef(<!__HAS_ORDERED_AGGREGATES__!>,<!
CREATE
m4_ifdef(<!__GREENPLUM__!>,<!ORDERED!>)
AGGREGATE MADLIB_SCHEMA.array_union(anyarray) (
    SFUNC = array_cat,
    STYPE = anyarray
);
!>)
Also, I think we should make `LocalCollection._selectorIsId` handle this case too, and also use it in this function instead of not using it.
We should do the full gamut here: text, text_phrase, and fuzzy.

```
    query = dict(('description__%s' % field, search_query) for field in ['text', 'text_phrase', 'fuzzy'])
    search = search.query(or_=query)
```

We can see how well that works. Later we'll probably want to boost text_phrase a bit so it weights higher than the other two.
Don't use `#{HOMEBREW_PREFIX}/share/sip` as `brew uninstall` won't be able to remove the sip modules if they are installed directly to the top level prefix.

Use `#{share}/sip`.
`depends_on` should come after the checksum and a blank line, i.e.

```rb
homepage ...
url ...
md5 ...

depends_on ...
depends_on ...
```
Save this for a little bit later unless you want to tackle it but it needs more fleshing out.  For instance can we have separate help when using an alias for :run?  Perhaps we want to setup a resource_summary, resource_description, etc. class methods to be more expressive but I feel that using summary on the default run method works well for this.
Vodacom Messaging uses a similar system. I think there's scope for some kind of menu-style message format, and I'd rather implement the whole spec than part of it.
Should we also assert something about the nack reason?
That's being deprecated by #281, so there isn't much point in replacing it twice. :-)
Docstring with configuration options needed. :)
yet again, this shouldn't be a class, not even a singleton. The only pattern that applies here is the factory pattern (similar to the rest of the connect middleware), since connect applies the **filter** pattern which uses a set of methods (also known as filters) to gather data from some object (in our case the request) and construct an other object (in our case the response).

So for this use case the singleton pattern is redundant, and in my opinion applying the right patterns is more important than a "uniform" codebase.
Necessary in most situations, no - but in the case of trying to debug this (especially when the error was occurring in a continuous integration platform's inner build, and couldn't be replicated on my mac), this actually made it possible to see what the error was, and the binding the error was occuring in.  The stack-trace was insufficient, as it didn't tell me anything about which binding.
To save three characters? Compiler won't let me instantiate a SetBinding<?>(blah);  What three characters are you talking about?
c:\Documents and Settings\This Is A Long Username\Application Data\Mozilla\Firefox\Profiles\12345678.default\zotero\storage\ is only 125 characters, so there's no particular reason not to go a bit longer.
we already have `queryFromParams` in this class, is there a reason the `queryString` method doesn't use that instead?
Is it possible for a document to remain loaded, even after its project has been closed? If so, this check will fail and the listener won't be removed. It should be safe to just unconditionally remove the listener.
Good answer! I removed it.
Yes, I think I dragged that from the other branch where I was trying to reuse some code and not in the best possible way, might I add :)

I'll remove the panelResizeEnd trigger.
This is a hard one... I did some free translation here because I thought that the direct one sounded a bit too harsh. 

It could be something like "Puede que las acciones que buscan archivos en el índice funcionen de manera incorrecta". I'm changing it to this for now.
See comments above on `createMenuFromJSON()`. The parameter here can't be an Object (which takes key/value pairs)--I'm assuming you meant an Array; and this doesn't actually create the menu (since you did that already), it creates menu items, so should be named accordingly.
I think getQueryString could be updated to pass in the cursor position and tagInfo since almost all hinting providers will probably want this anyway.
My misunderstanding, reverted removal of method and it's call from `tearDown()`.
Hmm? [Boost](http://www.boost.org/doc/libs/1_49_0/libs/math/doc/sf_and_dist/html/math_toolkit/dist/dist_ref/dists/pareto.html) and [Wikipedia](http://en.wikipedia.org/wiki/Pareto_distribution) seem to agree. And since the parameter is not just a horizontal shift, I agree with both sources.
wait i think that's needed in the JS for survey
Det här kommer ju inte kunna gå att köras.
As this operation is optional, just say it won't be supported because it's not mandatory.
Fixed, now grey without dots bellow.
Don't the loaders have other defaults in place? This looks ugly as is IMO.
And should I put them in different git submodules?
This is weird.  If I run this line and replace `$func` with a regular function, everything seems to work just fine.  When I run `all_groups` I end up with hundreds if lines of the error above.
It's unnecessary clutter. If File.symlink doesn't work, there's nothing this spec or a Ruby program can do about it. Nor can rm_r be changed in a way to avoid that possibility.
Add a TODO comment: now the ID could be fetched from the server argument. This session ID could be equal to the server ID.
zero 大小 等同于 cpy 大小
或者这样？
Return types should be generic and not tied to the implementation.  scala.collection.Set is the generic set trait. Alternatively you can rename the redis set or scala set via imports.
ZIPKIN_TRACE_URL should be a setting and not a constant. Must have missed that in another branch.
Wrap immediate function definitions in an outer set of parenthesis as an indication to the reader.
Sounds like you are following a pattern .. ACK
We can always try F# :wink: Honestly, tried indenting the code to make it more readable. I don't know if splitting it into some smaller helper methods will make it more readable/understandable, though...
Maybe this should be called `log` instead of `logger`?  It's likely to be typed a lot, and it actually *is* the log...
If you use ``_ASTROPY_SETUP_`` at the top of the module, you don't need this.
Ok, that's what I figured - I agree it makes sense internally, but a string-based scheme I think makes more sense for the user-visible interface.
debug comments are stil left.
Please move this implementation (and associated includes such as `sys/prctl.h`) to the .cpp instead of the .h, there is no need for inlining here.
You may want to use an auto_ptr to make this cleanup happen automatically.
Badly I think, I did relaxed the test here (not complex regex) because:

. the function it is called before calling ```isEnumeration()``` which properly tests for a valid format (I think... ) https://github.com/cakephp/cakephp/pull/1011/files#L1L685
. the function is called with a valid PDO object https://github.com/cakephp/cakephp/pull/1011/files#L1L320

I will revisit this though (because it can be called from externally), I think I can just call.```isEnumeration()``` from inside :).
BTW, thanks for the hint!
`skillpoints` (we already use this elsewhere)
I think these two variables don't need to be defined up here -- even without these lines, they will be defined before being used by anything else.
Calling shutdown during init doesn't look good. Just add a __UtilityShutdown() and call them from there.
The `out = ''` immediately above should probably be `out = b''` to be fully consistent, or put the conversion in an else block.
If we make any other changes this should probably be changed to `ip.run_line_magic('load_ext', 'octavemagic')`, but there are enough other instances of `ip.magic` in the test routines where it's clearly not actually an issue.
Will $/ be unset in the exec'ed perl code later on?
Remove all the debugging code (i.e. lines 141, 142, 146)
__send__ shouldn't be overridden here either.
Since this is an internal error message, I'd shorten this to indicate the Mod and Fun and details specific to the error.
Solved... well, "solved" :-)
The problem was the comparation is_a($query, 'Elastica_Client'). If I build a Elastica_Query_Term, then the compartion will return false (yes, obiously) I possible to ask for "any elastica query object"?
This is not DRY (Don't repeat yourself) anymore, as used in Plate and Flowcell.
should be (1..8)
here "5" => [...] mean the fifth lane, not the 6th.
You should mention that you throw exception if no response was returned.
what is this ignored file ?
I would call this method `reset()` instead. That being said, why not just creating a new instance of the builder?
Oh, that's indeed a mistake that slipped through.
wouldn't `=` have thrown more meaningful exc in the former code ? (in `Comparator::setOperator`)
In general, the best is to not touch the original cosmetic things like this and simply implement the needed functionality. And then sent a different pull request with just the cosmetic things, since those are unrelated. I think I wrote most of these import lines (at least "git blame" suggests that), and I am personally fine either way, so whatever works for you is ok with me too.
those are deleted lines.
fine.. could you please cleanup your commented line ?
Ok. I would assert at the very end of the check that none of the tags is
None, to catch possible issues.

On Thursday, September 13, 2012, Remi Hakim wrote:

> In checks/db/mcache.py:
>
> > +        self.counter("memcache.bytes_read_rate")
> > +        self.counter("memcache.bytes_written_rate")
> > +        self.counter("memcache.total_connections_rate")
> > +
> > +    def _load_conf(self, agentConfig):
> > +
> > +        # Load the conf according to the old schema
> > +        memcache_url = agentConfig.get("memcache_server", None)
> > +        memcache_port = agentConfig.get("memcache_port", None)
> > +        memcache_urls = []
> > +        memcache_ports = []
> > +        tags = []
> > +        if memcache_url is not None:
> > +            memcache_urls.append(memcache_url)
> > +            memcache_ports.append(memcache_port)
> > +            tags.append(None)
>
> If we do not append "None" there will be a gap between the url_list and
> the tag_list that we don't want.
>
> The "None" tag won't reach the backend as if it's None, the default tag
> would be added which is instance:host_port.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/DataDog/dd-agent/pull/184/files#r1600748>.
>
>


-- 
*Alexis Lê-Quôc *+1-917-512-6452

*Try Datadog for free (http://goo.gl/swO1h) <http://goo.gl/swO1h> no cc
req'd*
And follow @datadoghq <https://twitter.com/#!/datadoghq> on twitter
why changing the Server header here ? Can you revert this change for the merge?
I would just increment to 0.9 - even though the change isn't a big one and it seems like we're running out of space before 1.0, I'd rather not add lots of version parts, and 1.0 isn't the end of the world
how so?what was happening is that the code was creating its own open  file
state but then was getting the openstate manager to close it. because that
was happening during index creation I had loads of extra open states being
cached...

Chris
On Oct 30, 2012 12:55 AM, "Douglas Campos" <notifications@github.com> wrote:

> In
> src/main/java/org/crosswire/jsword/book/sword/state/GenBookBackendState.java:
>
> > @@ -42,7 +42,16 @@
> >      private RandomAccessFile bdtRaf;
> >      private SwordBookMetaData bookMetaData;
> >
> > -    public GenBookBackendState(SwordBookMetaData bookMetaData) {
> > +    /**
> > +     * This is default package access for forcing the use of the
> > +     * OpenFileStateManager to manage the creation. Not doing so may result in
> > +     * new instances of OpenFileState being created for no reason, and as a
> > +     * result, if they are released to the OpenFileStateManager by mistake this
> > +     * would result in leakage
> > +     *
> > +     * @param bookMetaData the appropriate metadata for the book
> > +     */
> > +    /* default */GenBookBackendState(SwordBookMetaData bookMetaData) {
>
> this comment is weird
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/crosswire/jsword/pull/13/files#r1974139>.
>
>
I should only be responsible for the load, the new instance to be tomcat and jboss to do so in a timely manner, the error reported to the developers
On second look, I think they're probably different enums, which makes some sort of prefix even more useful. SERVICE_DHCP, TYPE_EXTERNAL, etc.
See comment on line 263
the url of the sprite is wrong IMO
Please do. Apologies for sending you off in a wrong direction. I thought the AS was directly using guava. Also, in a chat, Stuart was thinking about eliminating the transitive dependency via weld, so we don't want to require use of guava elsewhere.
These are small, why not just set them inline when defining `feedback`?
really don't like to do work in constructor... but here it is :)
nit: cant really see why you dont just use this._db
It'll be our "little secret"... :-ppp
@etiennesegonzac according to the description, dialer does not use `mozApps` to get itself ~?
typo on this line
Would [] return true then?
Damn it! You are very good ;-) Thanks!
Is it a leftover?
nit:
return (aacExtensions.indexOf(extension) != -1);
`app.ondownloadsuccess = null;`
Same thing here.  This needs its own l10n id.
var unlockCpuWakeLock = function unlockCpuWakeLock() {
"project" (c missing)
This can go when we use the LXC driver
With the current implementation all network-related errors wouldn't be bubbled up, as `err` is always `nil`. Why not assign the returned `error` from `conn.Get` to `err` instead of `e`?
why are you returning a list of one element?   presumably you either want 

    list(self.col.find({'obj':obj,'user':user,'version':0}))[0]

or 
    
    self.col.find_one({'obj':obj,'user':user,'version':0})
I agree lists are easier to manipulate but in case of duplicates it might cause unexpected results.
I think the API should be strict as it is low level stuff. Not being strict might hide some errors. Don't you think?
Ok, we need to make the group binders robust enough to handle that situation. Ideas off the top of my head are to add listeners that bind new `<input>`s when the DOM group grows, or to add delegated listeners for when the user (un)checks something in the group, but I don't know off-hand if either are possible.
это и в контроллере такой же копи паст. Почему не воспользоваться из контроллера Video.yt_session ?
as discussed in IRC... why? atm you are manually mirroring the chat if you have an IRC redirection or want to log chat into a different medium. With being able to talk into more than one channel you don't need that anymore (as long as you create a "listener" for the additonal channels.

but, as we can change that if needed later on I will just implement that restriction.
the comment refers to whether in XML it is an attribute or a node -- wasn't clear though, nor really needed here
This class appears to duplicated a lot of the functionality in ``client/tests/virt/virt.py``
Am I right in thinking that with the `expPkgName.charAt(expPkgName.length()-3) != '.'` test, you want to check that the char before the final `.*` is not a `.`? 

If so, that would imply we ignore a wildcard Export-Package declaration like `com.acme..*` - Is that even legal syntax for an export package? :-) I thought it had to end `.*`.

Thinking about it, there is a bigger hole - the current code does not handle a declaration like `Export-Package: *`
``true`` is the default value here so it is not needed
You can just remove the second argument here, then no need for the version parser.
there is one missing thing: passing the delimiter to preg_quote so that ``#`` is also escaped as you are using it as delimiter
again, what's this for?
It seems you forgot to also add it to the [diff inline form](https://github.com/NARKOZ/gitlabhq/blob/9c75fcbef16e68dd3898545fc5d11b1261de1a26/app/views/notes/_per_line_form.html.haml#L33)
Why as :admin ?
You forgot about this method
This should probably be :validate => :hash, then you can use @index_table_keys.each |key, value| to get the key name and the string value to sprintf against.
Yeap I've seen test failures because of that and took me a while to figure out this was a reason :)
an orthogonal change to the PR which makes `./run_saucelabs` execute individual tests in parallel.  This imposes greater load on sauce but get's er done faster (the slowest test is now total test time which is about 123s for me.  awesomesauce.)
onComplete should have been called after the poll function completed.
Since we plan to ignore failures to this call, we probably don't need this error message.

We don't want the dialog to fall over while we do minor house-cleaning.
```
for key, name in namespaces:
```
Actually, maybe `mark_object_complete` - DatazillaModel has so many methods, we need to be careful to name them clearly, and "row" is a pretty vague term (it could be a row in any table), whereas "object" is more closely associated with "objectstore".

Really we need a better term for the things we put in the objectstore - generally we've been calling them "JSON blobs". I suppose we could call this `mark_blob_complete`, but that seems kinda weird.
minor nit: shouldnt this be on extension since you updated the install.rdf?
Umm, for maximum compatibility, I think `ENV['DISPLAY'].scan(/\d+/).first` or even `ENV['DISPLAY'].scan(/\d+/).first || '0'` is better. This will handle the cases where `DISPLAY=':0'` or even `DISPLAY` is unset.

The `.` in original regex code does not make sence to me, I believe it's a typo. From line 240 of `dbus-java-2.7/org/freedesktop/dbus/DBusConnection.java` , there is some similar logic:

```java
               s = System.getenv("DBUS_SESSION_BUS_ADDRESS");
               if (null == s) {
						// address gets stashed in $HOME/.dbus/session-bus/`dbus-uuidgen --get`-`sed 's/:\(.\)\..*/\1/' <<< $DISPLAY`
						String display = System.getenv("DISPLAY");
						if (null == display) throw new DBusException(_("Cannot Resolve Session Bus Address"));
						File uuidfile = new File("/var/lib/dbus/machine-id");
						if (!uuidfile.exists()) throw new DBusException(_("Cannot Resolve Session Bus Address"));
						try {
							BufferedReader r = new BufferedReader(new FileReader(uuidfile));
							String uuid = r.readLine();
							String homedir = System.getProperty("user.home");
							File addressfile = new File(homedir + "/.dbus/session-bus",
									uuid + "-" + display.replaceAll(":([0-9]*)\\..*", "$1"));
							if (!addressfile.exists()) throw new DBusException(_("Cannot Resolve Session Bus Address"));
							r = new BufferedReader(new FileReader(addressfile));
							String l;
							while (null != (l = r.readLine())) {
								if (Debug.debug) Debug.print(Debug.VERBOSE, "Reading D-Bus session data: "+l);
								if (l.matches("DBUS_SESSION_BUS_ADDRESS.*")) {
									s = l.replaceAll("^[^=]*=", "");
									if (Debug.debug) Debug.print(Debug.VERBOSE, "Parsing "+l+" to "+s);
								}
							}
							if (null == s || "".equals(s)) throw new DBusException(_("Cannot Resolve Session Bus Address"));
							if (Debug.debug) Debug.print(Debug.INFO, "Read bus address "+s+" from file "+addressfile.toString());
						} catch (Exception e) {
							if (EXCEPTION_DEBUG && Debug.debug) Debug.print(Debug.ERR, e);
							throw new DBusException(_("Cannot Resolve Session Bus Address"));
						}
					}

```
Why not just setting $this->_rules and avoid the overhead?
This is because of the `AbstractOMBuilder` type just before
there is no parameter here
Someone needs to change the name for the function from `notice` to `function_notice` before it lands on the scope.
Also, `block([self.array objectAtIndex:i])` may return `nil`
With my comment above, it will git rid of all these conditionals. Conditionals are bad! :)
I did this in my pull request to Ira's branch.
nah. i didn't mean that but the semi-colon :D
Instead of using regexes to check for join tables in a query, just specify it from the start
Add support for typed arrays like `string[]` or `Object[][]`
actually the true change of this PR is here
@ralphschindler Interesting. I'm whonder if that could alter the the tests results.
fix alignment in this class
That's not "ruby way" to do things.
```ruby
prefix.blank? ? {} : Dictionary....
```
Replace all tree lines to the code above. Of course, you can format it as you'd like.
BTW, do you know that RubyMine knows to format code for you? Don't forget to do it before commits.
( I mean spaces around = sign)
Yes I was actually thinking about making private methods and fields in all classes. But privacy is for others libs, so I could make all of them private... Which is not very clear. WDYT ?
Il reste encore ```mobicheckin-server```
Needed to change ports as saucelab proxies only work with some predefined ports.
@anti $browkieli-muuttujaa käytetään vain esim. login.php:ssä missä kukarowta ei vielä ole. Kun kukarow on setattu niin normaalisti t-funkkariin ei laiteta kieli-parametriä.
Is this what you're supposed to do? Seems weird to be using a global variable. If it's a hack, I'm fine if you just comment it for now as being potentially problematic.
Looks like : [php.net](http://fr2.php.net/manual/en/function.is-callable.php)
Actually, I did not make a lot of investigation, I just check on which version this function is available and it seems that it's ok. There also might be another solution to get the method's visibility value but I did not find it.
But a ValueObjectVisitor might be triggered on it while there is no more visitor for Location, right?
Better use `putenv()` instead I think. Safer.
Actually takes longer to check and remove than just remove every time.
most of the code uses self.log
you should set the timeout according to the value configured in the client (inherited from AbstractClient)
Here you can make a verification to see if the background color has changed.
Clicking aurora changes the background, use that to your advantage :)
Django uses `_` in its ids/names, but other than that I always used `-`.
Dsafe would get a laugh out of this :)
Moved start/end time out of delivery format params and into query.
I can't figure out how to remove parameter dictionaries here, .... it's too nested for me to trace it out. I would need someone who works on this part to go through it and realign it with stream defintiions.
Yep, but my idea was to start progressively moving "canonical" extensions to stdandard library into stdlib (if you agree of course...)
what do you think about something like ``if request.path.startswith('/manage/')`` ?
This doesn't actually make any difference at all.  It just felt icky to return the secret key when you initialize the function.
Even though I don't think this will cause a parse error, I think it should still be in a comment.
The comment says it all, but i could keep the same name.
читаешь и сразу понятно.
I like not relying on settings. I hate huge settings files.
So Ideally we would do this with the render_form(form) function which not only handles this for you, but also handles placement of validation errors.  New_tournament_step2 is a good example of that.
Oh, yeah... that's true.  Thanks.
Or accept a FALSE value to not add a prefix. Because we can have a prefix on `Predis` or `PHPREDIS` on the connection.

We should not require a prefix imo.
Increate the indentation a little bit.
Shouldn't this get just 1 comment? We're only using the first one that's retrieved.
Would we ever want more than 2 keyspaces (1 for the actual data and 1 for running tests)? Feels like it would be easier to just change CONFIG.keyspace when running tests and have it work automatically for all tests.
Check TODO.
Ok. Maybe worth a comment? It's up to you...
move requires into field_selector file
Let me think more and get back to you. I will probably pull your changes in my local branch and merge them in.
comment about search bar applies to monumentsList as well. Makes sense for monument detail, but still shouldn't be generic.
I like this, simplifying code is always good.
В смысле, его не нужно объявлять в интерфейсе а достаточно написать реализацию? Это я наверное по аналогии с С++.Учьту, спасибо.
Спасибо. 
А что мне возвращать, когда length меньше 0 ?
Is this `todo` done?
Why is this in `lib`? This should not be in this top level directory, regardless, IMO. Why can't you just do it as before (as a global)?
Needs to be rephrased to not talk about "sending."
I have a feeling that robot.brain.data.users is _every_ user the bot has encountered, not just the ones in the current room. Have you observed that at all?
Refer to last comment.
This is the cause of #128.

If `parties` is an empty array, we're dividing by zero, which raises the exception.

Two other comments:

* Rails adds `Array#sum` which can be used over `#inject` to sum the score here.
* If we were to use `#inject`, the `+=` can be replaced by simply `+` since the result of the block is used as `score` in the next iteration.
Call the new tags FIFF_MNE_<something>
don't use absolute import
Should we deprecate this in  light of `build`?
Why to do this assertion?
on -> for
what about `answer = STDIN.gets.chomp.downcase` instead? It would simplify the regex later.
SSH Agent
I don't understand the problem.
This should be `// ...` (as wel as all the other `// --` below). You can find these rules here: symfony.com/doc/master/contributing/documentation/overview.html#standards
I think this shouldn't be here.
Just curious--where could I read some more about the performance optimizations that could be done if C API hid more internal details? I'm intrigued, but not even sure what to google.
Я не люблю auto. его удобно использовать в некоторых местах, но юзать его
везде мне не нравится. Питон какой-то, блин.
I want everything :)

setHiddenColumns(array $ids) and setVisibleColumns(array $ids)  = mask functions with exception if the two function is used

and

showColumn(string $id) and hideColumn(string $id) = simple column action (#81)
Indent

```php

$tsbas['b' . $sbas_id] = array(
    'sbas_id' => (int) $sbas_id,
    'tids'    => array(),
    'domct'   => null,
    'tvals'   => array(),
    'lid'     => '',
    'trids'   => array()
);
The localization message should be in HTML, not in exception
This is a git file that keeps git from tracking 'generated' or compiled files.  It'll help keep your history clean by only tracking changes to actual code.

The bin/ and gen/ keep folders where compiled code are kept out.
My eye twitches at the sight of `**args` but I see what you're doing there.
Kappas, tämä kommentti olikin ilmeisesti tarkoitettu permutations -funktiolle?
Why not get this value from http://docs.oracle.com/javase/6/docs/api/java/sql/DatabaseMetaData.html#getIdentifierQuoteString() ?
I did @mmarkus , look right below in the constructor javadoc :-)
These changes make no sense. `composer.lock` should be in git, `vendor` is just fine.
I am not a fan of adding a plotting function-specific rcparam.  Perhaps we just need to step back here and recognize that this is completely solvable by just simply passing the correct norm in as a kwarg?  Addmittedly, it wasn't immediately obvious to me to do it that way, but that is a documentation issue more than anything else, right?
What's the difference between this and running gaiatest as above?
Nevermind, we include it in ext; we might not even need to install
python2.7-dev.

On Thu, May 3, 2012 at 9:38 PM, Wils Dawson <
reply@reply.github.com
> wrote:

> > @@ -6,7 +6,7 @@ if [ $# -ne 1 ]; then
> >  fi
> >
> >  PACKAGES="build-essential cmake git-core \
> > -python2.6-dev emacs cmake-curses-gui ccache curl aptitude \
> > +python2.7-dev emacs cmake-curses-gui ccache curl aptitude \
>
> 12.04 doesn't have it. Should I look for it elsewhere?
>
> ----- Reply message -----
> From: "Octavian Neamtu" <reply@reply.github.com>
> To: "William J. Dawson" <wdawson@bowdoin.edu>
> Subject: [nbites] Updates Linux Setup Script (#280)
> Date: Thu, May 3, 2012 9:37 pm
>
>
>
> > @@ -6,7 +6,7 @@ if [ $# -ne 1 ]; then
> >  fi
> >
> >  PACKAGES="build-essential cmake git-core \
> > -python2.6-dev emacs cmake-curses-gui ccache curl aptitude \
> > +python2.7-dev emacs cmake-curses-gui ccache curl aptitude \
>
> I think we still use python2.6
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/northern-bites/nbites/pull/280/files#r771939
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/northern-bites/nbites/pull/280/files#r771954
>
Почему TypeHinting закомментирован? Если его раскоментировать, то он будет пропускать или объект существующего класса, или null.
Отлично )
(To support both wsdls from the plugins at the same time)
IStoppable seems to generic for this method.
it's better to move it after the next if statement, for readability
Jordan, can you throw a comment above this option:

# Virtual CPU to Physical CPU allocation ratio (default: 16.0)
Maybe add `#!/bin/sh` as the first line.
I have noticed that .on doesn't work when the html content is generated by the script. In all my widget I didn't have choice : I had to use .live.
@adrexia can you clean up the whitespace problems here please? :)
should be Newscoop\Subscription\SectionFacade
noted :).
I'd suggest a call to __wt_err() here so we know balance returned an error and what that error was?

We probably don't need WT_ERR or the "ret" variable, then.
yea lemme change it to concat.
I understand the conversion  `a_req' and I usually use it
but here, to have short signature, and still readable, we decided to use just   req, res , and ctx when relevant.
so  please, keep this convention, otherwise we would need to update all the interface that use them .. to get coherent.

in addition, this makes your patch longer to review.
Are you sure ``count($drivers)`` has the correct type as ``integer`` is not a sub-type of ``boolean``?
Like I said, I'm fairly new with concurrency. Do you want me to wrap calls to it in a `synchronized(map){ ... }` block or somehow make the entire class it is in synchronized?
Personal style preference, but:

```ruby
offset = (position - 1) % page_size
```
Another nitpick: you have many lines like this introducing tailing spaces.  Could you eliminate them?
> uniqn();
    'identity'
    > uniqn();
    'identityy'
    > uniqn();
    'identityyy'
    > uniqn();
    'identityyyy'
    > uniqn();
    'identityyyyy'

I was just being silly. :) The reasoning is that it makes the code harder to read due to being recursive via self-modification, and it is a good way to be an asshole to future maintainers.
Please use `$::lsbdistid` instead.
I could move $region and $weight into settings, to keep it tight I suppose.

I think it would be a bit fruity if *all* the parameters where in an array.
demo seems to crash without this line
мы уже говорили про модель. во-первых необходимо переименовать и вынести отсюда лишнее.
You could replace the calls to `reverse` and `first` with `last`:
~~~clojure
(last (sort (map pred a-seq)))
~~~
Or you could use `filter` and `empty?`:
~~~clojure
(not (empty? (filter pred a-seq)))
~~~
Nyt käy ohrasesti jos esim. `(pred nil)` on `true`. Korjaus on triviaali:
~~~clojure
(pred (first (filter pred a-seq)))
~~~
```js
if (this.nodeType == 1){
		var children = clean(this).getElementsByTagName('*');
		Array.each(children, clean);
}
Element.dispose(this);
return null;
```
Good point. will do.
I'm not sure, if that's correct. I guess we need to check with our legal guys.
I know, I just wanted to check if formula si correct and only stations within a map are chosen. But still, I don't quite understand how to do it. Should I calculate NW and SE points based on node and zoom level inside a panel.js in a map panel, and then use:
> var bounds = new google.maps.LatLngBounds();
> bounds.extend(NW);
> bounds.extend(SE);

And how should I access these two points to query the stations with "within_box" ?
I would add that they can simply reply to the e-mail or use our contact page.
Go into new line after first `{`. See how we have elsewhere in the code structured `context.update`.
I was thinking of that but I think we do not need to convert full URI to pathname and check that, but to convert pathname to full URI in the same way browser would do it and then check that. So you can create `<a>` and then query what is the full URI as browser sees it? I think this would be the best way to approach the problem.

I could imagine that someday we will run on multiple servers, so it would be important what is full URI to the post. But this would be probably ugly. Hmm.

Yes, the other way is to change both URLs to pathnames and compare that only.

But I am not sure if we need whole library for this? Seems DOM already supports that.
Please use ` self.request.user` here.
Potrditven**i**
I was thinking the same, sorry for confusion.
No, we will make sure that username is unique automatically. There is no reason to make people do manual work.
Don/t catch all exceptions!
And maybe add a comment what is this. ;-)
This is so that we do not have to rewrite the shaders for each platform.  This will be changed to be something like MONOGAME_DESKTOP.  Then in each module we can use the compiler directive to use precision for ES 2.0 as that does not work on desktop systems.
Minor fix, this should be <%= fqdn %>
>are begin/end for rendering? than i would call these methods: renderBegin and renderEnd

Done =)
I used the same functionality as all the other "Search" functions
With processors having 32- or 64-bit word length, performing arithmetic operations on all bits "at once", and disk memory aligned to the 32th / 64th bit, I can hardly see any difference, practical or theoretical. If you would be so kind to explain these basics...
he meant, I guess, you weren't initialine object instance as Global variable -.-
Change to CSMat.
there were no need to add an else here as the previous block returns or throws an exception ;)
its ok if the rearrange was intentional.

I think fail fast is ok. I am not able to think of a case where the user might legitimately use stale or old names. In that sense casting to String is a not required. We can alway relax the restriction later if we need to.

I think this patch is fine.
+1 for deleting the tables before restoring from backup.

On Wed, Dec 12, 2012 at 12:48 AM, Kiyan Ahmadizadeh <
notifications@github.com> wrote:

> In src/main/java/org/kiji/schema/tools/MetadataTool.java:
>
> > +public class MetadataTool extends VersionValidatedTool  {
> > +  private static final Logger LOG = LoggerFactory.getLogger(MetadataTool.class);
> > +
> > +  @Flag(name="backup", usage="Output filename for Kiji metadata")
> > +  private String mOutFile = "";
> > +
> > +  @Flag(name="restore", usage="Input filename to restore Kiji metadata from")
> > +  private String mInFile = "";
> > +
> > +  @Flag(name="confirm", usage="Must be set to use the restore feature")
> > +  private boolean mConfirm;
> > +
> > +  // The following flags specify whether only certain parts of the backup should be restored.
> > +
> > +  @Flag(name="tables", usage="Restore table definitions")
> > +  private boolean mAllTables;
>
> My conception of the restore-from-backup functionality is that it's
> something a user will employ when either their meta or schema tables have
> been irreparably lost or corrupted. If we work under this assumption, then
> this tool could wipe the meta table / schema table if they already exist
> (with the user's consent) before performing the restore. This would avoid
> the delete masking problem you encountered earlier as well, and allow us to
> write the layouts and key/value meta data at their original timestamps.
> Also, appending backup values to an existing meta table may result in
> confusing column histories containing many duplicate layouts or key/value
> pairs, and wiping meta data first avoids this.
>
> In this world, an option allowing the user to select specific tables to
> restore makes less sense (which is my excuse for putting this long comment
> on this line).
>
> If we decide to go with this option, we'll have to ensure (at least down
> the road):
> 1. The user can roll back a table's layout to a previous layout in the
> history. This is so they can easily roll back layout updates that proved
> erroneous.
> 2. The user can roll back the value associated with a meta data key
> easily. Again, roll back erroneous settings.
>
> 3. The user can "undelete" a table in the sense that the table's meta data
> can be restored. The delete-table operation would delete the hbase table
> corresponding to the kiji table, but only write a marker in the meta table
> (a "deleted" column) instead of deleting the kiji table's row. The meta
> table implementation would have to be modified to respect this.
>
> I'm in favor of this redesign because it scopes down the features
> implemented by this tool (backup in case of disaster, restore in the
> aftermath) and separates the concerns of recovering from more minor
> disasters (bad table layout changes, bad table deletes, bad meta data
> settings). Thoughts?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/kijiproject/kiji-schema/pull/18/files#r2389975>.
>
>
typo: "object" ;)
I don't know how we lived all that time without it.
will fix is to proper name.
Add explanation about the value.
This is quite hot code, i guess?  If you don't know how to cache then store 'helpers.eq("classname", CLASSNAME_WAITING)' in a scope variable, it returns always the same function.
I did get a 204 resource from the network_logger. IIRC it was for a URI of some stats/tracking service.

Trying to display such resource is fun. It goes through all the normal netwok/resource Scope API calls and eventually falls back to a window.open(url) which is also empty since the resource has no content. Good times.
Space around the "+". Won't comment on these kind of issues anymore, all should be fixed. :)
@sligocki 
Yes, but in Apache the factory doesn't own the fetchers. In nginx, the fetcher are currently global and owned by the factory
Done: d75ce36
Ok, then I would also move the first line down
This is updated during the optimization correct? I think it should be passed around then rather than attached and read. It's a bit confusing to follow where things are getting changed and what's a set attribute.
I don't like positional parameters.  I'm going to add an option parameter to replace `required_host`.
You need to buildrequire that as well. See:
http://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations
ooops, unnecessary hardcode ?
But you probably were able to figure it out yourself?

https://docs.djangoproject.com/en/dev/topics/i18n/
Hm, since when does Django renders static JavaScript files?

You have to put those constants into the template (store them into global JavaScript variables) and after that load those external JavaScript files.
I think it should be `.*?` as well in case we have multiple links in a piece of text.
also, *html4eva!*
Same cast problem.  See comment below.
Minor - code indentation.
Header again.  Pls check eclipse settings.
typicallly -> typically
This padding is part of the reason that Quintic works for the interpolation.  Apparently, the extra padding is what lets you get away with a more compact interpolant than the "mathematically optimal" sinc function.  So maybe we should add a comment that lowering this value should be coupled with using a larger interpolant like Lanczos.  But that this is not recommended.
you guesed it
I wonder if the code could be simplified significantly by separating out the templates list from this class.

It looks to me like the template field is only used in the log statement in refresh(), and in the log statement in registerNewNodes.
For code outside of this class using getTemplates and getTemplatesMatchingInstance, they could do this with a separate template tracking class.

But I haven't finished reviewing the rest of the code in the pull request so will postpone judgement :-)
This doesn't look right.
The URL constructed below shouldn't have a suffix of the groovy path (because that's not the app name).
Same for json: the suffix is not the path of a json file.

Presumably the "app" argument should be the name of the app, which currently defaults to the fully qualified classname of the app that was instantiated.
why not use the logger for this?
heh? 0 if it worked, and then 2 and 3. Where is 1?
Also, with 3, we should send back what was the problem. Now you're just assuming it was only because of using both slaveok and read preferences... I can imagine there will be some other cases?
but this > is for this estructure   grandfather > fater > child, it's not a clouser of html tags
Hmm, where did this setPointSize code come from? It looks like it doesn't exist in master anymore either