Improved error message when trying to use a modifier twice in a shortcut
Merge pull request #1856 from DennisKehrig/dk/key-bindings

Improved error message when trying to use a modifier twice in a shortcut
Fix bug #1627 ("Go to Definition" prepopulated text doesn't work when
activated via menu) -- There are two problems at play. First, smart-autocomplete
only listens for key events, not programmatic or other textfield changes,
so we need to kick it to generate results for the prepopulated text.

Second, the results are generated asynchronously while QuickOpen's auto-"focus"
is synchronous. That bug is not fixed here since it's related to a whole
tangle of async issues in #1855.

Fixing the first bug alone means that hitting Enter now goes to the correct
result (instead of doing nothing), but that the editor doesn't auto-scroll
to that result as soon as the search bar is opened.

This commit also cleans up QuickOpen to use KeyEvent consts for key codes.
Fix bug #1849 (Incremental Find doesn't clear highlight when search changes
to no results)

Clear selection when no results found in file. Leave cursor where selection
used to be, which typically was the location of an earlier matching result
from before the query was done being typed. (This seems consistent with how
incremental search works in other editors & browsers).
* Simplify command name:
  Delete Selected Line(s)  ->  Delete Line(s)
* Fix several bugs in JSDoc type annotations
* Add WinXP instructions as a comment inside setup_for_hacking.bat
Return an empty tag info for an empty space entered inside plain text.
Merge pull request #1865 from adobe/pflynn/issue-1849

Fix bug #1849 (Incremental Find doesn't clear highlight when search changes to no results)
Fixed a typo. coment --> comment
Fix unit tests.
Merge pull request #1871 from adobe/glenn/fix-unit-tests

Fix unit tests.
Merge pull request #1867 from adobe/rlim/hint-issue-1519

Return an empty tag info for an empty space entered inside plain text.
Fix problem where _currentDocument.file.fullPath was being updated twice.
Merge pull request #1872 from adobe/glenn/issue-1870

Fix problem where _currentDocument.file.fullPath was being updated twice...
Get the html tag name from token.state.html for php documents, not from token.state.htmlState.
Safer focusedEditorChanged event:
* Revert main-editor-swapping codepath back to how it used to work, mostly
disentangled from focus events.
* Don't fire focusedEditorChanged on the many times focus returns to the
same Editor that had it last (due to window reactivation, closing a dialog,
closing a search bar, etc.). All the current use cases for this event don't
care about those cases. Add more detailed docs on event cases.
* Simplify how Editor signals focus: trigger only from "onFocus" (a superset
of the other case), and remove _internalFocus flag that was guarding against
the overlap.
* Don't call resizeEditor() on every editor swap just because statusbar
*might* have been shown/hidden: only call when statusbar actually did
change (going to/from no editor). Fixes scrolling issue in #1864.

#1257 still isn't 100% fixed: there are at least two cases where getFocusedEditor()
lags behind the focusedEditorChanged event: opening an inline editor; and
moving focus from open inline editor to its host editor. These same cases -
and a number of others - were broken before this change, however.
Update CodeMirror SHA
Code review fix: focusedEditorChange was passing wrong last arg to its
listeners.
And add a couple more docs.
Code review fix: move XP-specific setup_for_hacking instructions into XP
error message that the script prints, and move check for missing argument
before XP check to ensure that XP message doesn't print misleading paths.
Merge pull request #1877 from adobe/refs/heads/pflynn/focusedEditorChange

Safer focusedEditorChanged event
Merge pull request #1875 from adobe/rlim/code-hints-for-php

Get the html tag name from token.state.html for php documents