labofsahil/github-event-dataset-2012 huggingface dataset:
Develop

1) Add a hook up to in updateAnnotation() to also update storage usage.
2) Add retry (max 3 times) to calling S3.  This is a simple attempt to overcome eventual consistency.
3) Fix a bug that, when the list of locations is empty, update is skipped.
Korrekturen am algd1 Skript

Hoi Jan,

Kenne mich nicht so aus mit LaTeX und Git. Eigentlich habe ich keine Ahnung was ich hier mache. Ich habe jetzt bis 7.3.5 gelesen und korrigiert.

Ich hab geforked, commited, mich gewundert wieso die Sachen nicht auf github sind, gefetcht und gepusht.
Jetzt versuche ich das mal mit dem pull-requesten.

Ich hab noch zwei PDFs aus meinem ersten Semester eingefügt.

Gruss,
Claude
claude.martin@students.fhnw.ch
https://www.facebook.com/DulcetAirman
Clean newCommentCache every 6 hours instead of 24

Clean newCommentCache every six hours instead of every 24. Just for paranoia.
My attempt to improve status code parsing

I have a lot of emails like this:

Final-Recipient: rfc822; xxx@example.com
Original-Recipient: rfc822;xxx@example.com
Action: failed
Status: 5.2.2
Diagnostic-Code: X-Postfix; Mailbox is full

The parser did not return any smtp_code and did not return any std_reason. There were two reasons as far as I can see it:

1) Usage of Mail::Header instead of Mail::DeliveryStatus::Report - the status code was not stripped and it was not possible to compare.
2) If no diagnostic code could be found, Status is not used as fallback.

I made some changes to make it pass, but I'm not sure about the various-unknown.t.
[JENKINS-12488] Exports TRIGGERED_BUILD_TAGS env variable, which lists c...

...omma separated list of triggered build tags. Also, add "Lines from file Parameter Factory"

This request is a replacement for this old pull request, which I've closed based on feedback - https://github.com/jenkinsci/parameterized-trigger-plugin/pull/15

Adding a general purpose ParameterFactory which triggers a build for each line in a text file.  The same effect could be achieved with the FileBuildParameterFactory.  However, using FileBuildParameterFactory would result in having to write 200 property files to the workspace.  I think both are useful and should be included.

Combined with JENKINS-12488, which sets a list of triggered build tags (build name and build number) to an environment variable, we were able created a pretty cool way to parallelize automated tests. Will you please accept this pull request into the plugin? It includes the "Lines from file Parameter Factory" and the fix for JENKINS-12488.

More background - Instead of running of tests (JBehave->selenium) sequentially, we were looking for a way to:

1) Determine which tests need to run (applying meta filters)
2) Dispatch the execution of each test to it's own build so that Jenkins can queue and distribute to slave nodes
3) Aggregate test results after all tests are complete

We tried different things. Triggering a Matrix job seemed promising. However, with a Matrix job, it seemed to us that the values for an axis are pretty static. They are decided when the configuration is saved. We were able do this more dynamically, by first writing the tests to be run to a text file and then, in the second build step, triggering a "worker job" (able to run concurrently) using a "Lines from file Parameter Factory" and blocking. A later step copies the artifacts from each triggered build (possible because of the fix for JENKINS-12488).

Anyway we are really happy with how it works and want to share with others! Please let me know if I can do anything else.
slimmed down the camel case utility method
batString migrated to qtest2

As per step 4° of qtest2 migration.

(note: logically, this pull request should be dealt with *after* rixed's)
Add target and append options

This adds an option to add the counter to a specified target instead of inserting it after the textarea (the default behaviour), and an option to append/prepend the counter.
added pr2_plugs to interactive manipulation launch

pr2_interactive_manipulation_robot.launch now has a plugs:=true option which will start up the launchfiles for plugs. default is false.
Pretty sure you don't need the ` || {}` here, unless a falsy value passed to `Y.merge()` takes a code path I don't know about…
in PISM-PIK killEasyIcebergs was split into 1) delete ice noses before the iceberg procedures and 2) delete lonely partially filled cells after iceberg procedures. This makes sense.
(As elsewhere)
Just a note, you can also use two dots instead of the parentheses: 1..day + 30..seconds etc.
Indeed, initially I was using `qDebug()`. Rapidly, I found it overwhelming to have the text displayed on the right side with everything else.

This convenience method allow to dump the `metadata` and only the metadata !
It has been added in 2.11 only (https://github.com/contao/core/issues/2890) so it's not a feature of a previous stable version that has to be backward compatible ;)
no need for this as cl-oauth can use the :parameters in drakma..
Good catch, I missed that one. Fixed in 4e52477.
We should probably make this an assert with a name like `@assert_approx` or something like that. I've also thought about adding `@assert_equal` for unit tests because that allows printing both the expressions that weren't equal and the values that weren't equal, which currently doesn't happen when a test fails, requiring instrumenting the test code with `println` just so you know what values were failed for. This path leads to an explosion of annoying `@assert_...` macros that duplicate all sorts of things that logical operators in your language are for. So I hesitated to do it.

In this specific case, an alternative would be to get values from Mathematica to full 64-bit float precision and just check for equality.
Is there any chance that this issue gets looked up and re-opened? Otherwise ```rake test:units``` is simply not usable.
Thought, If I disable to force "*" characters in copyright, the "*" will not be lined up here automatically.
@BDQ: Can you please back-port this to master? Thanks
I think you don't have to expose the show_text() API to callers, this is just a convenient wrapper for Sonata, not something general.
Are you reading the bytes in as a "string" or are you converting the bytes from bigendian to the correct integer types?
Wait, why was that a bad idea?
It's an interesting idea, but there are some invariants in the current Network.Wai.Parse.Sink that don't exist in Data.Conduit.Sink:

* Pushing never returns early
* Pushing never returns leftovers
* There's no SinkNoData constructor

Switching over would mean putting in runtime checks that these rules are obeyed. For now, I think we should leave it as-is.
1.
In the new code, I would suggest to use the short form of the debug message ('normal' level):
 sc_log(ctx, ...
instead of 
 sc_debug(ctx, SC_LOG_DEBUG_NORMAL, ...

2. Errors when compiling on Windows
reader-pcsc.c(1719) : warning C4018: '>' : signed/unsigned mismatch
reader-pcsc.c(1708) : warning C4101: 'dbuf' : unreferenced local variable
reader-pcsc.c(1962) : warning C4101: 'card_handle' : unreferenced local variable
reader-pcsc.c(1961) : warning C4101: 'protocol' : unreferenced local variable
reader-pcsc.c(1963) : warning C4101: 'rv' : unreferenced local variable
reader-pcsc.c(1961) : warning C4101: 'active_proto' : unreferenced local variable
reader-pcsc.c(2277) : error C2065: 'SC_READER_CAP_PACE' : undeclared identifier
These are windows only settings, please ifdef them for it.
@acoulton Yes, please do both and I will get this merged in.
Thanks Adam :)
Das habe ich so gemacht, damit auch im Callbacknamen rekursiv weitere REX_VARs verwendet werden können. Wie sinnvoll das ist, das zu nutzen, sei mal dahingestellt, aber ich wollte es einheitlich haben, dass es theoretisch überall möglich ist.
Also dadurch ist das möglich:

```php
REX_ARTICLE[callback="REX_CONFIG[field=article_callback]"]
```
А почему не генерировать уникальный Id проще? http://www.php.net/manual/en/function.tempnam.php
It might be better to move the if statement inside the error handler so that xhr.abort() is also called when options.error hasn’t been set.
I think replacing '/' by '-' is a reasonable attempt at trying to create ID-like token. In some VCS, tags cannot contain '/', etc. I'm going to merge this as-is.
locic may be fixed, but all area quest-dependent spells stop working. check before commit, please...
can someone take a look to this changes, can i commit this?
http://paste2.org/p/1873083
If it doesn't exist, it will be created above (wouldn't it be nice if github had a 'show more context' feature?).
this import is unnecessary
Another thought is to search the content of the style block and look for ``premailer:\s*ignore``. So you'd write:

```html
<style>
/* premailer: ignore */
.this-stays
</style>
```
Should this read: (or (:metadata obj) {})  ?? (:metadata obj) is ignoring the {} arg at the end?
文件末尾要留一空行。
The `Events::filterCoreController` purpose is to allow for changing the controller.
Should this bare 16 be the block size of the cipher being used?
I ended up reverting this commit and making 2 commits instead. One for adding basic keymapper support for iphone (keyboard) and one for adding gesture support on top of that.
Just set max to 0 and a CommandUsageException will be thrown form SimpleCommand before even invoking this method.
Why? :O
Jeg vet ikke hvorfor den ikke ble med i den committen, men den ser ut til å være oppe nå.
That will be fine I think.  I'll put it together and style the page so it
looks more like it belongs

Tony




On Sat, Jan 28, 2012 at 12:15 AM, Brady Miller <
reply@reply.github.com
> wrote:

> Then how about make the link:
> "Copyrights, Acknowledgments and Certification information"
> Then can place all of the information and links on the copyright file.
> OEMR needs to to in the contributions list. Then at end can make a
> certification section with needed statements and link to OEMR.
> There is no reason t place something like this on the login page. Note 70%
> of downloads of outside US and not pertinent to them; also adding a very
> hard statement to translate. Regarding link visibility, I also don't think
> it's appropriate to place a link to open-emr.org on the login page. This
> stuff belongs in the copyright page or in an about page.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/tmccormi/openemr/commit/38c6ddf0a22113fc1205c585c7f10c17f96b38f2#commitcomment-910589
>
>
return SYSTEM_SEPARATOR;
Don't have to do string operation again.
(http://omploader.org/vY3Z3aw)
one new line too many
:thumbsup:

On Tue, 28 Feb 2012 12:57:21 -0800, Evan Phoenix wrote:
> Yes, I'll be sure that we get your functionality in.
>
>
> On Tuesday, February 28, 2012 at 12:53 PM, Justin wrote:
>
>> Is this eventually going to fix the "missing subset of sources" 
>> issue? Because these changes break my tests: 
>> https://github.com/rubygems/rubygems/pull/105
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> 
>> https://github.com/rubygems/rubygems/commit/eb1bc0ffdb190426f36f28c69cd0a91e3d9f478c#commitcomment-1023058
>
> ---
> Reply to this email directly or view it on GitHub:
> 
> https://github.com/rubygems/rubygems/commit/eb1bc0ffdb190426f36f28c69cd0a91e3d9f478c#commitcomment-1023071
Hi Dimitry,

I updated Dozer to use comons-lang to 3.1.

Following the version convention of major.minor.patch, I believe with the
changes I have made over the past few days and the move to GitHub as well,
the next release of Dozer should be 5.4.0, as we have changed dependencies
and added at at least one new mapping feature (non void setters).

I think a new release soon would be good, as 5.3.2 was almost a year ago.

Cheers

Alan


On 24 January 2012 21:29, Dmitry Buzdin <
reply@reply.github.com
> wrote:

> yes, I have renamed the repository to dozer as it is github best practice.
>
> Dmitry
>
> On Tue, Jan 24, 2012 at 11:39 AM, Alan Stewart
> <reply@reply.github.com>
> wrote:
> > Actually push just worked after I changed the DozerMapper/Dozer.git to
> > DozerMapper/dozer.git. Did you change this?
> >
> >
> > On 24 January 2012 20:36, Alan Stewart <alankstewart@gmail.com> wrote:
> >
> >> Hi,
> >>
> >> I added a new new unit test to ReflectionUtilsTest and also cleaned up
> all
> >> the calls in GranularDozerBeanMapperTest to getMapper so that just a
> string
> >> is passed as suggested.
> >>
> >> Having trouble pushing at the moment. Getting
> >> ERROR: DozerMapper/Dozer.git doesn't exist. Did you enter it correctly?
> >> fatal: The remote end hung up unexpectedly
> >>
> >> Another advantage of commons-lang is that the Validate class can be used
> >> to enforce the contract of the public api by calls from users.
> >> Anyway, I have time tonight and tomorrow morning to do the commons-lang
> >> 3.1 upgrade, but since this will affect a lot of classes, do you want
> me to
> >> wait until the morning for you to apply any other patches?  I don't
> need to
> >> do any more tonight.
> >>
> >> Let me know
> >> Alan
> >>
> >>
> >> On 24 January 2012 19:48, Alan Stewart <alankstewart@gmail.com> wrote:
> >>
> >>> Will have at look at it again soon - just out at the moment. Will also
> >>> add a unit test for the the new ReflectionUtils method.
> >>>
> >>>
> >>> On 24 January 2012 19:20, Dmitry Buzdin <
> >>> reply@reply.github.com
> >>> > wrote:
> >>>
> >>>> I would add a separate unit test on this one in ReflectionUtilsTest
> >>>>
> >>>> ---
> >>>> Reply to this email directly or view it on GitHub:
> >>>>
> >>>>
> https://github.com/DozerMapper/Dozer/commit/59513a3e91791671b2475a46655ee81fcc038c5b#commitcomment-895341
> >>>>
> >>>
> >>>
> >>
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/DozerMapper/dozer/commit/59513a3e91791671b2475a46655ee81fcc038c5b#commitcomment-895503
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/DozerMapper/dozer/commit/59513a3e91791671b2475a46655ee81fcc038c5b#commitcomment-895662
>
Thanks guys, sorry about that. I'm still kind of new to this whole GitHub thing.
Agree with sarahmei.  But if you're sure you're only going to have nil or valid data. then this is simplest/best:

     if authors[conversation.id]
This line removes all test titles on the qunit result page. I guess it would be better  if you'd make a more specific lookup on the page, not just $('span'). Could you please use the second parameter to limit the scope (see jQuery selector API).
Tried this out today, it generates the following sequence of url's (assuming the random # starts at 5):

ps5, ps6, ps7, ps8, ps9, ps1, ps1, ps2, ....

Note that "ps1" is used twice. My colleagues say that there is no channel 0 (no "ps0"), and that there are really only 9 channels (ps1 thru ps9). If that's correct, this can be fixed by changing where "ori" gets incremented:

'pubsub', 'ps' + (++ori < 10 ? ori : ori=1)
Tässä muutoksia riveillä 32 - 38
It would be nice to briefly document what this method does. It's not clear that task_with_params is a string for instance.
good idea. But this will be for V2 as mentioned, right?
Got it. There is also another problem here. If a person wants to book more than 1 slot for a certain venue, our booking page does not allow him/her to do so. We need to modify it, for example, put a '+' beside the time slot textbox. Will work on that later.
WTF%^
I just found it odd that you went that route instead of just denyng the nodes.  I know negation works in 1.17 for PEX.  :D
See cmdSpeedTest in trelby.py. Modify it to call whatever you want to time (what it has there now, reformatting entire script, etc).
I'm not convinced that I like the in-selector `.foo { @silent; ... }` either, but `@silent .foo { ... }` has its own problems. In particular, I'm not sure it makes it clear that a ruleset is being defined. No existing directive of the form `@DIRECTIVE X { ... }` defines a ruleset; `@media all { ... }` doesn't define a ruleset for the selector `all`, nor does `@mixin div { ... }` define a ruleset for the selector `div`. This is mitigated somewhat by the fact that `@silent` will usually be used with class selectors, but I'm still not entirely comfortable with it.

I'll continue to mull over this issue tonight, and hopefully have a better-developed opinion tomorrow.
In 2.2-style controllers: 

    public function getLanguageTopics() {
        return array('frontdeskman:default','frontdeskman:property');
    }
Already merged!
This misses `:decimal`, you can also consider just doing `safe_columns.select(&:number?).collect(&:name)`.

Cheers!
Great. Thank you Bill, that's exactly what I was searching for :) I'm
pleased you are still around man ! Thanks again
Le 2 mars 2012 19:02, "Bill Crossley" <
reply@reply.github.com>
a crit :

> Something about this block of code doesn't quite look right to me.
>
> Is the call to inode_dio_done() supposed to be commented out?  and is it
> the only thing that's done if the flag is set?
>
> It looks like, from the indenting, that all the "wake anyone waiting on
> unwritten extent conversion" stuff was intended to also be in the if
> (io->flag & EXT4_IO_END_DIRECT )  block, but is not actually due to no
> curly-braces.
>
> I won't pretend to know what this code is doing, but since we're having
> issues in recovery with backing up an ext4 partition (/data), it might be
> worth making sure this code is actually doing what it is supposed to.  I
> did find out that the TAR command used for backing up data is going into an
> un-interruptable sleep while waiting for IO to complete, and it seems like
> it is never woken up.  Since that looks like something this code here could
> be doing wrong, maybe it's worth a look....
>
> Sorry to be a PITA :)
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/GlitchKernel/Glitch/commit/adb6ff1367f2b02e5b33790a9c9731382b34bacb#commitcomment-1036798
>
May I ask why? Is this just a style preference or is there a reason for doing it this way? :)
不过，我现在想想， SiteConfig.save_default 放 seed 里面确实是不错的...
para que las letras no funcionen
This is incorrect. RunningMode.ADMIN_ONLY does not disable Stage.RUNTIME for sockets.
Oops!  I've told git to ignore the bin and the obj folder. Not sure why it didn't ignore.  

On Feb 6, 2012, at 9:25 PM, "Marc" <reply@reply.github.com> wrote:

> Did you mean to commit the dlls and pdbs? They can't be merged :(
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/ptran123/Conceptual/commit/7610c2109f1539956674edbf6be58948cc0348ef#commitcomment-939515
Just to note - these properties are already defined by the driver.
Transmission intercepts SIG_KILL, and do a clean shutdown. But this may take some time, and if the NAS powers off too early, the settings file is lost. This code was to prevent this.
Als jij geen toffe programeur bent weet ik het ook niet meer.
What is the purpose of reversing twice the content?
Here is the bug :)
I don't think that we can remove it ever. But I'm not sure, in which way Groundspeak localizes its content, so handling both would be a more secure way.
Hahaha

On Sunday, February 5, 2012, Adolfo Fitoria <
reply@reply.github.com>
wrote:
> LULZ best README evar!
>
> ---
> Reply to this email directly or view it on GitHub:
>
https://github.com/igorgue/deployinator2/commit/52d8609b5a12783501316466258246032ca991bd#commitcomment-934949
>

-- 
Thanks,

Igor.
prefer: 
if (something wrong test)
  { 
  success = false;
  }
emit this->stopped(filename, success);
if (!success)
 {
 break;
 }

even better:
success = (something wrong test)
meh, not really, but if you're returning in the first else clause, the else is not needed, since it returns in there too.  Save a line :P
What? I'm pretty sure you're wrong. Parts of stdlib are standardized, so forcing to use any kind of licence is nonsense.
Example usage for Doubleclick

    google:
        analytics:
            trackers:
                default:
                    name: default
                    accountId: xxxxxx
                    domain: .example.com
            js_source_https: https://
            js_source_http: http://
            js_source_endpoint: stats.g.doubleclick.net/dc.js
Can you add a comment here mentioning how this will be used?
zip does not give all pairs, it gives an in-order list of pairs.  Use itertools.product.
Hi. There is no method "runningInTestMode()" in Play class, just "runingInTestMode()". Why did you change it?
You can keep the CSS all in the same file. When you make a commit it will preserve the history.
codestyle :P
```SQL
DELETE FROM `smart_scripts` WHERE `entryorguid` IN (@ENTRY,@ENTRY*100+0,@ENTRY*100+1);
```

Not a proper delete.
Hi Richard.
I'm implementing an internal app for hr, and some of the attributes that
they need to access are: assistant and employeeid . They are not
implemented as separate methods. Most likely cause they are  not used a
lot. So this allows for a quick access to those values without implementing
a separate method. Maybe a more appropriate thing would be to make them
attr_reader at this point to avoid screwing up the record accidentally.

The proper solutions is of course to implement proper methods just like
User.manager but who has time? :-) May be I'll do that and do another pull
request in the future.

Nick

On Wed, Feb 8, 2012 at 1:58 PM, Richard Navarrete <
reply@reply.github.com
> wrote:

> Hi Nick,
>
> I haven't had a need for this - can you give me an example of how this is
> useful for you?
>
> Thanks,
> R
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/konung/active_directory/commit/2325f1875cc12fc363c1db4c8c8dda1bce00691c#commitcomment-946679
>



-- 
--------------------------------------

Nick Gorbikoff
nick.gorbikoff@gmail.com
@mmarkus could you fork my topic branch and make this fix and issue a pull request to my fork, so I can merge it in and continue my testing?
This should really go with commit 82f2e7fe52faefdba72a14d87fdd57bf9e852421
@campbeb Two pleas:
1. Please introduce two new constants in GCConstants for the geocode and the travelbug patterns
2. Please use ```BaseUtils.getMatch()``` for the pattern matching ,-)
Te ha faltado el .sql de ICC, súbelo cuando puedas ;)
On Thu, 5 Jan 2012, Florian Sesser wrote:

> Maybe my Unit test isn't OK, not sure on that either.

I'll have a look then.

cheers,
Derick
Yeah, that's a good point. Will update and redo the pull.
Note that I have to apply this to the sendMessage functions serverside.

Also, some packetisation could be done for channel lists or player lists. Imagine:
- Channel lists: When sending the channel list to somebody, instead of sending it, check if a packet for the list is available, if yes send it, if not prepare it and send it. When list updated (channel removed/added or name changed), invalidate the packet if one
- Player lists: Tougher. Try to mark the inactive players (as in don't change ratings/tiers/profiles) and group them and use above method.
Meh, dangling preposition.
Ahh, I didn't know about that.  Will do.  Thanks!    Although,  I wonder
about what interface this should have.

Do you like the names I've chosen?  Can you think of better names?
Why did you get rid of all these?
I still seem to be getting an issue here even on the lastest develop branch:

callisto:ahn_liquid_call jsgoecke$ ahn -
Starting Adhearsion server at /Users/jsgoecke/Dropbox/Development/ahn_liquid_call
/Users/jsgoecke/.rvm/gems/ruby-1.9.3-p0/gems/adhearsion-2.0.0.alpha2/lib/adhearsion/configuration.rb:103:in `
охуеть.
еще странное место, тут есть и has_and_belongs_to_many :items, и has_many :items, :through => :items_orders
надо определиться :)
Lou,

I found this link http://comments.gmane.org/gmane.comp.python.bugs/162506 that may explain the problem that you are seeing on windows. It looks like the log use of lock maybe causing the problem.  A possible solution, as noted in the link maybe,  to instantiate the log variable in the in the run method instead of the top of the change_monitor file.

I don't have windows environment setup to test it try let me know how it works.
Oh, you didn't know about Ruby's dodgey name setting? For shame! ;)
Am assuming that you can sort by score on the front end though?

The judges won't be using the admin direct so this is a better option already :)
I'm skipping these tests temporarily simply because they're failing, and they also fail on the origin's master branch. I'm sure it's probably something in my setup or environment, but the tests seem very unstable so it's hard to pinpoint (same series of tests repeatedly yields different results). I'm planning to stop excluding them once I understand the test setup better.
I didn't know about it either, but it seemed to be a case where there'd likely be something implemented C-level in the core already.  Never hurts to do a little blind function searching through the array_ functions sometimes.
Il va certainement falloir modifier le son du bloc (mettre le bois au lieu de la laine) et calibrer la résistance du bloc
Just testing things, as you can see.
# CHANGELOG #
* build.sh:
	- Cleaned paths.
	- Added MAKEOPTS variable from start in all compile options.
	- Added Keystore info and sign functions.
	- Added Kernel variables for better display info.
	- Removed .tar file creation.
* /scripts/mkcompile_h:
	- Modified to support Kernel variables from build.sh.
Даа, връмя не стоит на месет.
В принципе, енто было давно и неправда, я про ентот трим в скрипте и забыл совсем.
Хорошо бы самому протестировать.
To avoid build error on other targets, should we also add #ifdef USE_MAGURO_LIBCAMERA here?
https://github.com/cgjones/android-frameworks-base/blob/gingerbread-b2g/services/camera/libcameraservice/CameraService.cpp#L141
thanks to: Mikadmin
Hi,

Thanks a lot for the explanation. I did not take `:checker` for what it should be, that's why I did not expected it to have to be writeable.
I think I should find my way through, will have a StackOverflow question if not!

Thanks again,
Romain
Hi,

Could you help me understanding the reason for this line? I have not looked at the whole source code of your nice gem, but I migrated from 1.3.2 to 1.4.5, and I'm pretty sure this line is breaking the thing. I now get an undefined method error (in my case `prevent_geocoding=`, because I've defined `prevent_geocoding` as the `checker`).

I had no problem before, geocoding was performed when my `prevent_geocoding` method was returning `false`. Looking at the code, I don't understand why it's needed to set `checker` to `true` here (whichever the old or new version).

I can't see why there the `checker` should be set to `true`, but the new way of performing it seems to be the cause of the break.

Thanks in advance for the explanation, and help to get over the bug with the new version!
Regards
This changes the size the image gets changed to, but not the rule that determines if an image is eligible for resize—someone could upload a 1030x1030 image and the site would offer to resize the image, and then blow it up to 1600^2.
s/Sass/Less/ :)
Hi Nico,

It's seems it's a good feature for the next version. Do you think you can make me a pull request when you think it works ok?

Thanks!
Seems like multilevel interrupts need some testing, so I have reverted them for now
Is this working ? No need to edit additional files ?
No Problem. If you come up with a better way to get the current connection's encoding please share your findings. I'm currently starting to understand rails basics. Official support for the sqlanywhere-adapter seems a little dead however.
Yes, I just commited to cm gerrit

well that guy is working with me, we made patches to frameworks and phone
there are few because we were working live and didn't test offline :)


On 02/22/2012 09:13 PM, 0002647302 wrote:
> Actually I intend to fix it and move it in one step. Don't you already have this?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/TwistedPlayground/android_packages_apps_Phone/commit/0047e42249cb801d605d786304bbddd2d1e3a19b#commitcomment-997823
>
Метод проверяет линки только в одну сторону или в обе?
You have 4 expectations defined for this test so I gather you intend that firing 'fat.foo' will trigger the event twice on that same element. I would think that firing just once would make more sense. Makes it a bit more complicated internally though.
Shouldn't this be in the `render` method of the View?
I think we always want to do this, because `free()` deletes the model instance from the array and replaces it with `undefined`, therefore `model` will be falsy, but there's still something at that index which is being spliced out of `_items`.
Wrong copy from my own workspace. Do I have to combine my commits in one ?
I don't like the default message returned to the end user. I would prefer something like : "A technical error occured (code: XXX)".
What do you think ?
idk, those are more of implementation notes for 'wtf did i wrote there' moments than API descriptions.
Loading the DTM but not freeing.
This is required for the documentation generation. Please do not remove this.
this could be F::app()->wg->Memc, right ?
please add package declaration (docs.pattern)
They are only needed for sbtosgi < 0.3.0. It has been upgraded to 0.3.0 which is the latest stable.
moved into encoders/decoders
Fold this one inte the previous if.
Just a spontaneouos reaction to the name mangling. We have tests that will cover this.
I saw that - I like that!
This doc was written before that was decided.
> This seems weird, what's the difference between success(Fail(e)) and  
> failure(e)?

I shouldn't have used failure(e). The status itself can be Fail(e) and  
Invalid(e) in case of errors.
no, it's not used in `:+`, it's only used for "messages" and it should be extremely rare that they have the same hash as the nodes
is it a "capacity" or more commonly referred to as a "buffer"? (i think the latter)
But this fails because it wants to create a lock down in /var which is protected. I suspect there is a command line flag to solve this
:) I've fixed this but not pushed it yet
Am I right in believing this is new functionality and so renaming these functions has no backwards compatibility issues
For consistency, it might be nice to not mix single and double quotes.
To poor some more oil on the fire :)

@huceke Why is this conversion stuff needed? Ie, why should the codec convert to float? If CoreAE needs float for some odd reason, wouldn't it better to do that there?
Ah! Very nice.
Don't know why it still appears here... I've fixed it.
Looks good, minor things I'd change for JSLint is to use `!==` (I think `grunt lint` does this). Could cache the regexps but I think that's overkill.
Should these be user-scoped?
I remember the print issue you mentioned. can you add a TODO to check this or create an issue ? 
also, if we don't need these lines, please remove them.
fix comment formats. add doxygen comments here and on other structures and function declarations below.
Remoting is only initialized once. That said, extra precaution could be  
useful.
you're accidentally reverting @davidaparicio's commit
Indentation looks weird from here on down... might want to switch this to 4-spaced tabs.
Space after if. The same goes for all the other conditionals in this class.
Damn wikipedia. Actually fixed in 61a3221.
This check is redundant.  The method is only invoked once, in the static initializer, and so osName is guaranteed to be null.
Probably slightly better to use PyErr_WriteUnraiseable here?
I'd rather call this enum `php_password_algo` (singular) as it fits in better with parameters and return values. Also I don't see why you removed the `PHP_` prefix for the enum values. Those are global, so they should be prefixed too. (Only C++11 has proper non-global `enum class` values.)
И константных ссылок бы не помешало.
I think is better to leave this as `:options` since we have the SPACIAL indexes too.
You don't need to change quotes here.
Can change to `nil` instead of empty string:

```ruby
>> helper.content_tag :p, nil, {}
=> "<p></p>"
```
I think that'd be called CacheKeyTest, righ?
yeah, it probably doesn't need to be. I was cribbing off of `resque_mailer`. I'll update.
CoffeeScript inside a tag script is not valid. If we are going to show CoffeeScript we should not put it inside a tag script
`short-hands for...`
Guys, I suggest some middle ground. 

George, could you please add a guard against crashes, which throws a ToolBoxError for unsupported cases instead, then write failing tests, put them into `test/pending/run`, write an umbrella bug to incorporate all of them, and then we'll move on.
Ok, this seems like just a left-over debugging aid.
no longer relevant (this function has been simplified)
actually, ```self._new(rows, cols, data)``` is the preferred method for this. It's possible that the subclass of Matrix won't have the same input structure. _new maintains the type while providing the common interface. 

In particular this would come up if you wanted to compute the eigenvectors of an optics system using gaussopt. 

Where should development documentation like this go?
uses -> use
returns -> return
What's the point of this weird nesting?
please watch the pep8 sorts of things, too: `x**2+y**2` -> `x**2 + y**2`
We only need to call `Factory(:definition)` when we want to build or create a new instance, so there's no need to call it in this setup.

And we should use `FactoryGirl(:definition)` because the other syntax is already [deprecated](https://github.com/thoughtbot/factory_girl/blob/master/lib/factory_girl/deprecated.rb#L4) and will be removed sooner or later.

Thanks for this changes. Fixtures was making me sick already :wink:
If this isn't intended to be a test on its own, but instead just have things derived from it, it should probably be using the `__test__ = False` class property.
Do we have a story in pivotal for this, with an appropriate due date?
You must replace `:: ` with `:`
whois information on the domain suggests that `US/Eastern` is an appropriate time zone. Care to add it?
Why not use the
```
@Test(expected=classOf[InvalidChangeEventException])
```
?
Good point:  recursively listing all nodes is much worse than "not ideal", I will change it.
As discussed, moving to a more symbolic representation of restarts will make the tests easier to understand.
well as its in a file he edits I dont mind it.
Simply deleted should be sufficient given the *_deleted columns further down.
Why are you treating it as an expression if the variable $is_expr is false? The function documentation should at least explain under which circumstance an empty string is returned.
Suboptimal variable name.
`$root_path` -> `$phpbb_root_path`, otherwise it isn't clear what this is the "root path" off.
As i've mentioned, this should probably be moved to its own function or method.
update_user_name. And I didn't combine them as the vars being passed in talk about name, not user name. And its the user's name. Hence update_user_name.
This is one of the 5 most downloaded MODs, I doubt anyone ill complain.

People expect things to change when they update from 3.0 to 3.1
line 55 has the emit for the startup check
This feels more like it should be "hasOrderedContents(Object... expected)"
I've removed ATTRS.
The second library here should be able to use $$config.lib$$
Я что-то начал сомневаться, мой вариант выглядит значительно сложнее. Надо немного поисследовать. Проблема с батчевым апдейтом - для 100+ баннеров по одному баннеру за запрос обновлять очень плохо. Это можно решить например таким методом - http://www.kavoir.com/2009/05/mysql-insert-if-doesnt-exist-otherwise-update-the-existing-row.html, надо проверить насколько он будет медленный. Плюс продумать на будущее, в каком варианте легче будет развивать. В общем завтра точно скажу свое мнение что будет лучше и почему, но наверно твой вариант все же предпочтительней.
I think you should be using the STASH code here?
These seem to be useful outside this test.
Consider refactoring, ready for use elsewhere.
This section for deriving `r` and `r_unit` should be moved within the main spherical code path.
I amended the commit. github strangly moved your comment to the new commit.
the look behind allows me to key on our extensions in a narrower fashion. I'd rather not use create as it is ambiguously associated with many valid DDL statements. The up to 1024 spaces specification is unfortunately a java regular expression engine limitation, in which it forces you to specify pattern sizes for look ahead and look behind patterns.
is there start-date-field class required too?
Because it takes forever to scan through a multi-MB or -GB file searching for data that may or may not ever be there, and to avoid data that looks like an intra-record header but is really part of some value.
You should remove this handle_cast clause, since it's no longer used.
Something's wrong with this flowchart. `get()` is called right after the `dispatch()` method. `http_method_not_allowed()` should never be called, as mentioned in another comment above. get_object should be a function and should be executed after `get()`.
Rather have undefined instead of yet another atom to do what undefined does very well.
Can this be changed to just ``$code = $statusLine[1];``
Actually, it looks like astyle doesn't agree with the 'enum/struct/class on its own line' paradigm. I don't see any parameter to address that
0o... was for debugging... still needed for debugging.
Rewrote this to Debug.Assert(world!=null);
"On" and "Off" is the raw values sent to the amp. I used a bool first, but changed it to this because I want a third value `None` which makes the mixer not care about changing the setting on the amp.
NSInteger is a different type on OS X than it is on iOS, so the format strings have to be different
The template for this message is the same in all three cases, so you could make it a class property.
This is wrong; the correct formulation would be something like


```rb
if Hardware ...
  url ..
  sha1 ...
else
  url ...
  sha1 ...
end

devel do
  if Hardware ...
    url ...
    sha1 ...
  else
    url ...
    sha1 ...
  end
end
```

or

```rb
if Hardware ...
  url ...
  sha1 ...

  devel do
    url ...
    sha1 ...
  end
else
  url ...
  sha1 ...

  devel do
    url ...
    sha1 ...
  end
end
```
Simplicity and beauty are always important.
This isn't a stable (versioned) download, so the formula will break each time this file is updated.
I have no idea, I just use Command Line Tools for XCode which doesn't include autoconf at all. If there's a better way to check for this, I'll be happy to change it.
Could we get a docstring that describes what the migration method is supposed to do and what it's supposed to return?
Good point. I knew there was something like that floating around, but a cursory glance through the docs didn't find it.
Sequence numbers exist to match messages with replies. Since we already have a reply for that sequence number (with the `ESME_RTHROTTLED` status), we need a new sequence number for the next message.
There's a lot of copied code in EsmeTransmitter and EsmeReceiver. I think maybe these could be written better by overriding handle_deliver_sm in the transmitter and handle_submit_sm_resp and handle_submit_sm_multi_resp in the receiver (instead of copying and overriding handle_data). The implementations of all three should probably just log that a message was received and discarded.
{@link InetAddress}
okay, now I got it too...
You need to do this.  btw.
No reason for the shadow, either, it's not getting rendered (also, lots of overlapping box shadows really slows down webkit rendering and should be avoided).
This is hit when the selector is preceded by an at-rule. For example:

```
@import url("charset.css");
a {
	color: pink;
}
```
Given this refactoring, it seems a little weird that you now have to call `addBinding()` with a null/undefined `keyBindings` in order to get the default keybinding applied (in other words, the default keybinding happens as a side-effect of the associated menu item being called or someone explicitly calling `addBinding()` on the command). It would make more sense to just have some separate place during initialization where we load all the default keybindings.
Cool. I just reviewed the pull request. Looks great!
But I think we could run into issues later on if we equate an error with was_handled=False because then the wrong handler may end up processing the message.
not used any more?
I still don't understand what schema changes you made... can you explain this to me?
Rename to B1
I know it can be done. It is even in the [tutorial](http://mongoengine.org/docs/v0.5/tutorial.html#posts). This is one of the main features of mongoengine. Because MongoDB is schemaless you can store there anything you want. Those fields are just so that mongoengine knows how to map values in MongoDB to Python object values and to do validation and such.

So you should really be able to simply extend provided User document with additional fields and make our own. And then add additional methods (you can simply hijack original methods) there.
Why in search bar code?
Yea, `head` should have basically everything except for the popcorn scripts at this point ( if it was snapshotted ). If it wasn't snapshotted then everything just goes along as normal, so this is fine.
"it's" shouldn't have an apostrophe here.
ah I see what that span was being used for now
stay away assassino
Yep - I think you got lucky because at the time of you setting up the app we weren't actually using migrations...
so? and not sure what do you mean about duplication
I notice that here and elsewhere we've lost some of the json-formatted responses.  Is that deliberate?
ApS
はい。手元では引数の 1文字目だと 1つ前の indexが返るのですが、
2文字目以降だと正しい indexが返るということになりました。
jediが正しい現在の indexを返せばこのコードで良いかと思います。
That's probably a better check anyway, but that wasn't the original code.  Happy to change.
Since this is specific to the systems page, could you put this in the systems.scss file to keep what's defined here as general as possible?
I think the \N are for the precision field. Is there ever actually data for that? Can totally replace with empty string though. 


On Nov 7, 2012, at 9:53 PM, Aaron Steele <notifications@github.com> wrote:

> In test/fossa/core_test.clj:
> 
> >    "Test read-occurrences using sample dataset"
> >    (read-occurrences)
> > -  => (produces-some ["Acidobacteria" "242135095" "9.93166666667" "0.896666666667"]
> > -                    ["Acidobacteria" "244666043" "47.166668" "19.583334"]
> > -                    ["Acidobacteria" "244664083" "-40.8747" "170.851"]
> > -                    ["Acidobacteria" "244662123" "15.509722" "73.88306"]))
> > -
> > -(fact
> > -  "Test latlons->wkt-multi-point"
> > -  (latlons->wkt-multi-point [1 2 3] [4 5 6]) => "MULTIPOINT ((1 4), (2 5), (3 6))")
> > +  => (produces-some ["Acidobacteria" "242135095" "9.93166666667" "0.896666666667" "\\N" "2005" "3"]
> I wonder if we can drop these "\\N" values and replace them with empty strings? It'll be another big character saver. Maybe?
> 
> —
> Reply to this email directly or view it on GitHub.
>
I think we can remove the ```unit_id 42``` line since the next line generates a unit to be set for the attribute.
Yes, I forgot to removed it.
I used it in a previous version.
The variable should be named ``skipCreate``.
No dead code, let's remove it.
That's what I figured, makes sense.
I'm sure it will not be used. Looking in the generated makefile, CFLAGS is only used for .c -> o compilation.
No please... outpoints shouldn't know whether they are part of some wallet structure!
// Check if we have a new address or updated label
fieldList == whiteList though.
Nothing, bad copy paste :)  Will fix it.
I don't think this needs to change.
Too many spaces to my taste :-)
also another one of those IDE suggestions.

What does everyone else think about it?
Cheers Craig

Noted. Coding the state machines now.  Agreed should of waited on the pull
request.



On Wed, May 30, 2012 at 9:28 AM, Craig Ambrose <
reply@reply.github.com
> wrote:

> > +    @membership = Membership.find(params[:id])
> > +    @membership.access_level = "member"
> > +    @membership.save
> > +    flash[:notice] = "#{@membership.user_name}'s admin rights have been
> removed."
> > +    redirect_to @membership.group
> > +  end
> > +
> > +  def approve
> > +    @membership = Membership.find(params[:id])
> > +    flash[:notice] = "Membership approved"
> > +    UserMailer.group_membership_approved(@membership.user,
> @membership.group).deliver
> > +    # TODO: this logic should be moved out of the controller
> > +    # and into the membership model (acts as state machine)
> > +    @membership.access_level = "member"
> > +    @membership.save
> > +    redirect_to @membership.group
> >    end
> >
>
> I think an approve method should look more like this:
>
> ```ruby
> def approve
>  @membership.approve!
>  flash[:notice] = "Membership approved"
>  redirect_to @membership.group
> end
> ```
>
> I can see you have a comment there to much the same effect, but I don't
> think we should get in the habit of merging in pull requests that still say
> something like "TODO: refactor this". Refactoring the code into the design
> you want is a key step in coding, and shouldn't be separated from the other
> steps in case it gets forgotten.
>
> Drop me a line if you need a hand understanding the acts as state machine
> library. Basically if you define a transition called :approve, you'll get
> an approve! method for free.
>
> You'll note that I also didn't have the @membership =
> Membership.find(params[:id]) line in my example code. That's duplicated
> across all these methods. You could move it into a before filter, or into a
> lazy-loading method like the "resource" method that inherited resources
> uses.
>
> Same ideas can be applied to remove_admin and make_admin.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/enspiral/loomio/pull/172/files#r895975
>
They aren't. What's happening is that the minimum size of the main window is being computed based on the minimum size of the central widget plus surrounding content. You should still be able to resize the window larger (but not smaller).
I think I'd side with doing that.
detachVolumeFromServer(volumeId, serverId)
http://validator.w3.org/ and my browser (Firefox) complain about this.
This does not seem correct. Why don't we have the liveStreamDVRPlugin override the timeDisplay ? Instead of doing this conditional return inside timed text. This could have negative side effects, like .o == null now instead of $jQuery object.
Settings に追いやった方が良いか微妙なところですねえ。provider が増えそうなら追いやった方がよさそう。
lololol bracers. Sorry. I swear I'm working on the styleguide.
@jimmyhchan 


i forget this


{>"tl/apps/demo/embed/base_embed" test="FOOOO"/}
{>"tl/apps/demo/embed/base_embed" test="BARRR"/}

{>"tl/apps/demo/embed/base_embed" test=foo/}
{>"tl/apps/demo/embed/base_embed" test=bar/}


the above output for test is always the value for "bar" in the JSON

is this expected?
uh, afaik models.py is *the* file django looks for to make sure an "app" is legit. But I have no proof. @ubernostrum?
Take out the onclick part and use string substitution to add it in; it doesn't need to be localized.

You should store the string on a module-level variable to avoid the mess that will result if you try to keep it inline after the 'mzl.la` link below.
I like this indentation a lot more than the previous one.
I'm basing this primarily on sheer experience from having been through the errors and obscure bugs in the past. But also on the core principle of Python's ideology.
those == the methods names that you proposed
I'm +1 with implicit expiration on lookup for now.

On a related note it would be interesting to have a `React\Dns\Query\RecordCacheInterface` so that it will be possible to implement different cache backends in the future (even persistent ones based on the filesystem or a database).
@stof @hason  opened a PR to fix inconsistency - #5879
the name is weird as the function is not only able to collapse the menu but also to expand it
We usually have throws after the return with an empty line between.
you should not comment old code but remove it
This is not correct. Min enforces a value to have a minimal numeric value, for example Min(100), but has no relation to lengths.
thought about that as well. for consistency I picked the chars