labofsahil/github-event-dataset-2012 huggingface dataset:
Can we wrap these duplicate invitations in a `2.times do` block?

Might make the intention clearer (e.g. we are inviting someone twice).

Other option is to define a method at the bottom of the class.
- h! 表示尽可能放置在当前位置，应该基本符合毕设论文要求，比设论文没有要求浮动的吧？（至少本科没有）
- 其实这段话我也是在网上找到的解决方案，说实话不是十分了解具体实现……
- 你有没有什么检验的好方法？或者就像你之前在开头说明中提到的，我们可以把一些有疑问的可能会出现问题的地方列出来，如果sample的生成没有问题就可以暂时不管……
Updated this call now to take options={} instead of options=""
This looks like an extensions test.
Again, I/O and wrapping exception into Failure
Except here.
Braces are on the same line as the method declaration, not the line after.
null-servlet or Null-Filter? please pay attention the letter case.
You can substitute the whole function by:

```python
littlechef.lib.get_roles_in_node({'run_list': run_list})
```
CS issue here and all over the patch (spaces)
You should add couple of lines to explain the setting, since all others have it.
Sure we could change that, but now it is part of API for few months... 
So if we do it we must do it quick :)
Fixed. Waiting a few minutes before committing and pushing since I seem to get every comment individually.
Well, look at it from "the debian world". You would release "version 1.2.3" of your python package. Debian maintainer pacakges it up as "python-specialunderwear version 1.2.3-1" the "1" is the 'package revision' or 'iteration' - essentially a meta version for the package. If there's a typo, said maintainer releases "python-specialunderwear version 1.2.3-2" which still points exactly at your version 1.2.3 but fixes a typo in the package process itself, not in your code. Thus, in debian's world, it is expected mostly that any "version 1.2.3-xxx" includes the same version (1.2.3) of the software, but simply has small fixes in packaging (dependency, description, etc) by the maintainer between package revisions.

Does this make sense? I think that's why this must be the default behavior.

However! What you are asking for is totally reasonable - I myself do not care about debian's practices.

So I propose the following - Add a new flag to fpm's deb package plugin that allows "exact versioning" as you are wanting here and would disable the current behavior. Would this be OK?
Right, I was only suggesting a map to use for the loop, which I went back on. So this is fine. :)
1.  Why is that a convention, for my edification.  I personally like it but have been unable to influence others at work to adopt it,  so I'm curious
2.  I did not use grunt, i just use jslint in my editor.  I didn't see anything about running grunt in the README.  Ought it be?
Collection method getItemById returns object instance if found and null otherwise.
Your code will return Mage_Sales_Model_Order_Address instance in any case.

So you need to change if statement to be something like this:

if ($address->getId() !== null)
My bad. Forgot to mod .vimrc
Ugh! A non-localized, hard-coded string in Homescreen. Glad you remove it. :-)
This is a bit weird that this file pretends to be lists.css but contains other declarations.
Right, unfortunately we will need to reload the list always :(
did you bind .cancel? It uses a reference to "this"
I don't understand why we need this here? Can't you create a statusbar-theme.css file for your sprites. Use it here.
Once this is done you can move icons.html in UI tests if you want and duplicate your theme file there.
If you have `left: 4rem` and `width: 100%` you have 4rem of extra width, that it may cause extra repaints when using transitions or animations.
I suggest to use: `widht: auto; right: 0;` or `width: calc(100% - 4rem)`

PD: Just seeing the code (not live tested on the phone), if do you think this not applies, just say it :D
In most of the case when you pan duration will be 0. I wonder if it will not be better to create 2 separate moveBy function, one with a duration and the other without. That will avoid the cost to if (duration) and to always set MozTransition.
I don't have to, I'm just listening to the |downloadapplied| message, and there I remove all the callbacks.

Perhaps your test is not working cause you'll need two platform patches to try this code (yes two :( )

https://bugzilla.mozilla.org/show_bug.cgi?id=815547
https://bugzilla.mozilla.org/show_bug.cgi?id=816535

I think they already landed in aurora, can you retry an confirm @julienw ?

Thanks a lot!
How hard would it be to put this?
Does it look horrible to lazy load calendar color? (after everything else) Ideally we should not load account/calendar at all during first run if possible otherwise we are not going to get a big improvement during startup.
Cannot find any reference to sendWallMsg in the PR, what is this, is being used?
I assume you're passing ABC to test if it calls image.format to convert it to RGB; that should happen in a separate test.
bumped speed from 8 to 12 which is more realistic. Small change in priority to only take 30% detour over track/path which seems reasonable. Change the priority change back, if you feel that this is wrong.
Space needed after the last comma.
That's alot of state in this constructor. fwiw, anytime I use more than 3 ivars in an object I stop to think if maybe there are objects or abstractions that are missing.

It's true that there are some cases where you do need more than 3 separate pieces of data in an object (like when constructing a SELECT statement that has 7-10 distinct parts), but I think it's an edge case.
nah that should be fine I wouldn't worry about that for now. As for the UUID yeah I personally wouldn't worry about something too crazy, we should be pretty low on collisions since we're not spinning up several sockets per second or anything, we can probably just combine the PID / timestamp and some other random junk
And remove moderator check from here.
just getName
This var is not needed, you can just use the string as it is.
I use TortoiseGit and SmartGit for Windows. And sometimes I use the bash.
On Wed, 26 Dec 2012, Stefan Lorenz wrote:
>    I have implemented this file manually on a Server with some Joomla and
>    WP-Installations and changed the fail regex a little bit.

>    suhosin\[\d*\]:.*\sASCII-NUL\s.*\(attacker\s'<HOST>'.*
>    suhosin\[\d*\]:.*configured\srequest\svariable\sname\slength\slimit\sexceeded\s.*\(attacker\s'<HOST>'.*
>    This way most of the CAPTCHA-attackers get blocked.

>    Should i resubmit the suhosin.conf to get at least this one in the next
>    release?

that would be great

also please provide coresponding examples under 
testcases/files/logs/suhosin

-- 
Yaroslav O. Halchenko
Postdoctoral Fellow,   Department of Psychological and Brain Sciences
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834                       Fax: +1 (603) 646-1419
WWW:   http://www.linkedin.com/in/yarik
same here. logic to role
is just removing from the repository name the ".git" extension
Suppose it makes sense to move this in with `FixturesController`. They are still separate objects there, though, when there might be a good case for merging them in one `FixturesController` object.
What's the point of these changes?
"which documents PageMod should be applied" is a correct from I think.
What is `_` ?
Please use relative require forms.
Please use relative require
There are two things I hate about this

1. The signature (`ACCOUNT_CANCEL`) has to be entered and be consistent across all other account cancel events.  Since our wsapi modules do one thing, I'm hoping that the module name can be used in some form as the signature.

2. The awkward merging of http request and additional params.  I'm thinking I want to hide all this in the logger function and let you pass in the http request object and additional params as separate and optional arguments.  That would remove the `mergeEnv` call.  On the downside, it would be potentially more confusing when looking at function calls and wondering why they had different argument types.
This function exists also in `db/json.js`.
Looks like browser.js would also benefit from such a check. Could be done in a follow-up bug.
please move this up so it doesn't intersect the code flow.
It should probably be a reported error to supply arguments *and* a block, otherwise this silently ignores some user input:

`export File["foo"] { file("bar", :ensure => :present) }`
@zaphod42 just that when defining an action via ActionManager#action we check for duplicate default actions. But when defining an action via `#script` we don't. So you could end up with multiple defaults. Should I file a bug on that? Though I think the real bug is that shouldn't be multiple ways of creating actions (one uses an ActionBuilder, the other doesn't).
i can't imagine what you could be doing for it to make a difference.

w/ the old school `$.fn.live`, jquery defaulted to binding to document. still a fine delegation context.
In my opinion, it's a hassle to match tags manually to the image elements. However, if more feel the way you do, I'd be happy to change this.
I see - we need to skip the test of the method in this case, and just call the callback. Thanks for the fix!
CS -- whitespace:
```
do {
    /* ... */
} while ($mask === null || stristr($mask, $char));
```
What use cases do you have for this event?
I'm confused by this test. Can you add comment explaining how this test works? Unit test normally don't load the real config file either.
UTC timestamp maybe?
Meteor is bundling everything into a client.js and server.js file.

since the code wrapped by Meteor.is_client is intended to run on the client, we have to wrap it... (also refer to the official leaderboard example: https://github.com/meteor/meteor/blob/master/examples/leaderboard/leaderboard.js).

if the code is not wrapped, Meteor will try to execute the code and throw an error, complaining "Handlebars is not defined" (Meteor doesn't support server side rendering at the moment).
Cool, thanks :)

Keep us updated.
Unnecessary constant, just compare against an empty string directly.
+1 for the commit regarding the line break changes.

While looking at the commit, I found a potential license issue here. The file contains references to two files that do not exist in the Contiki tree: copying-gpl.txt and copying-liquorice.txt. The latter is supposed to contain exceptions to GPL, so it is important that it is included to make the legal status clear for AVR firmwares.
eventually we definitely need to make these so they don't always go through every document
i would remove $fetchDepth > 0  - imagine i have normally a depth of 2 but for this call i want to set it to 0 because i know i don't need those children?
I think that the best you can do is to create a small java app and run it on Jenkins. This java app will try to create directories by using `mkdirs(path)`. Then you need to understand when and why this doesn't work by varying the `path` that's being passed to `mkdirs`.
I don't think this should generate an error, since this PR aims to support author-less articles, but we can emit a warning (may be this was what you meant).
remove VSC
break long description across multiple lines
This has been added meanwhile and is no longer needed.
Add a link to the [project page](https://github.com/zaach/jsonlint) and remove the npm link.
Let's also make sure that somebody who has no profile picture shows up in peeps but not peeps_pp
Interesting way to do async in series. You should check out functools.map.async, I use it in other places. You use that to replace all of this with:

map.async(client.query, statements, function(err, results) { /* error handling or process.exit(0) or whatever */ } )

http://io.kodfabrik.com/2012/02/13/functools.html

I've also been toying with the idea of adding `async` as a dependency (https://github.com/caolan/async) because it's well used and well known. I've been getting along just fine with `functools`, but using `async` would help the casual observer make sense of it.
Ah, true :) Thanks for explaining :)
Do you have to force this to `2`? If so, the type of the source should also reflect this constrain..
Oh, good catch. Intent here was to print full stack trace of `e`, as noted in pull req description.
Good catch, I've pushed a commit to fix that.
I'm confused.. are a point's angles are just other points? Maybe `angles` is the wrong name for whatever this is?
Awesome. Thanks a bunch.
That would seem better - let's keep the API as close to the model as possible.
"Guide on installation" -> "Install guide" (although it might just be better to link "here" to the document).
Is this necessary to go in? I suspect it might break some of QE's tests so we might need to notify them if this is required.
Porbaste en IE??? hay una coma al final, posiblemente no funcione en IE
IIUC, this represents a modification to the `IExecutable` interface (it now returns something, rather than returning `None`).  Would it be worth adding that information to the `IExecutable` docstring?
Ok, almost there.
I found this bug only in the 'original' CodeMirror with IE8.
Indeed, there are ZIP builds for other channels (i.e. types) besides *daily* (although not for *release*, as far as I can tell; at least not for Firefox). So commit 67d85302038f3fbe5cb346fd3a7fcd1b6d8a183b makes it possible to specify an extension for all channels, both by moving the parameter back to `Scraper` and by making --file-ext a general option (previously it was part of the "daily builds" option group).
Ditto above regarding `assoc-in` vs. `assoc`.
Order is wrong here.
I'll remove this function since it's only used for getting the log in strategies (single module).
I was thinking the changes for just the RestAPI could be made as part of this PR. I could follow through with reordering and removal of lastName and firstName as part of the ID management PR.
Order is off here.
Line 215 using $this->_time()
slanger is a namespace
you mean like 
  return entry =~ /(.+)~/
?
Nice, I like that.
Ik zou dit in de init toevoegen nu:

```

  init: function( x, y, settings ) {
    this.parent( x, y, settings );
    this.addAnim( 'idle', 0.1, [0] );
  },
```
brilliant idee deze class. Erg cool
@samxli  I was able to confirm that I had that column referenced for debugging. I've updated the code to remove it. Thanks!
Something is wrong... I'm looking at it.
взгляните в пример лекции повнимательнее, if (self) там присутствует не просто так.
функция мутации должна принимать ПРОЦЕНТЫ т.е. если у вас ДНА будет 50 значений а в функцию придет 100 это должно заменить все 50 ячеек, а не выбить программу.
you can simply check that `callback` exists.
is this the async for each art you were mentioning? I'd definitely rather not add big deps but we could easily add a little setting to Batch to make it optionally sequential or a separate `each` package that is more declarative, that's probably taken in npm though
So, you can use coffeescript's truthyness here. Also string interpolation. Also also if/else being expressions. Basically, lay on some coffescriptisms :)

    query = if msg.match[1]
                     "matching/#{c}/#{new Buffer(c).toString('base64')}/json"
                   else
                     "random/json"
Thanks ndeloof, but I guess that this gradle job is broken because it returns "> Could not find group:org.jenkins-ci.tools, module:gradle-jpi-plugin, version:0.1-SNAPSHOT." and http://download.eclipse.org/jgit/maven a 404... :-(

(BTW, I'm a gradle dummy and maybe I doing something wrong...)

With maven I success build it.

Thanks for your support! :-D
I've updated the pull request, this should be fine now (changed concatenation)
hmm.. while I like the idea, a problem with a sparse matrix is that it wouldn't be clear in what order the connections are in the output (unless we return idx, which makes having a matrix in the input pointless)
line did not break, although displayed as if....

On 24.12.2012, at 18:08, Alexandre Gramfort <notifications@github.com> wrote:

> In doc/source/python_tutorial.rst:
> 
> >      - detect heart beat QRS component
> >      - detect eye blinks and EOG artifacts
> > +	- compute SSP projections to remove ECG or EOG artifacts
> > +	- compute Independent Component Analysis (ICA) to remove artifacts or select
> > +	  latent sources
> > +    - estimate noise covariance matrix from Raw and Epochs
> > +	- visualize cross-trial response dynamics using epochs images- estimate power in the source space
> indent + images- ?
> 
> —
> Reply to this email directly or view it on GitHub.
>
console.errno ?? 

Please log the error console.error(err)
I am not sure why the newlines are coming. I remeber not doing a format.
But if you look at the method postUrl i have added a deprecated annotation.
if (containsAddress) break; ?
`to to show` => `to show`
Hey!

I'm not sure I understand this. `$this->file` should be the uploaded file object, not the absolute path to the file. In the current code, `$file` is a variable that's temporarily set to the absolute path, which we then unlink.

What problem were you seeing?
常规版本 => 新式的
"successfully"
even stronger language would be in order. "mandatory" comes to mind.
I think this needs some try..finally magic to close open streams if there's an exception
AFAICT, this is no longer used.
`xit` is used to temporarily skip tests, in the same way `xdescribe` can be used.
Sorry, my mistake. It came as a copy-paste, but then I decided it would 
be good to raise the `ValueError`, because the results aren't 
meaningful in any way. So yes, the message should go to the exception.

I propose to change the behaviour in the `RectBivariateSpline` as well 
to raise an error, because also there, the results are meaningless if 
`ier > 0`.

Am Sa 25 Feb 2012 18:01:52 CET schrieb Andreas H.:
> That's a copy-past from the RectBivariateSpline class.
>
> Am 25.02.2012 15:13, schrieb Pauli Virtanen:
>>> +                            'elements as u')
>>> +        if not v.size == r.shape[1]:
>>> +            raise TypeError('v dimension of r must have same number of '
>>> +                            'elements as v')
>>> +        if pole_continuity[1] is False and pole_flat[1] is True:
>>> +            raise TypeError('if pole_continuity is False, so must be pole_flat')
>>> +        if pole_continuity[0] is False and pole_flat[0] is True:
>>> +            raise TypeError('if pole_continuity is False, so must be pole_flat')
>>> +        r = np.ravel(r)
>>> +        nu,tu,nv,tv,c,fp,ier = dfitpack.regrid_smth_spher(iopt,ider,u.copy(),
>>> +                                                          v.copy(),r.copy(),r0,
>>> +                                                          r1,s)
>>> +        if not ier in [0,-1,-2]:
>>> +            message = _spfit_messages.get(ier, 'ier=%s' % (ier))
>>> +            warnings.warn(message)
>>> +            raise ValueError()
>>
>> Here the message should be given to ValueError, rather than in the warning.
>>
>> --- 
>> Reply to this email directly or view it on GitHub:
>> https://github.com/scipy/scipy/pull/117/files#r488632
Wait, for that matter, isn't `e.pageX - window.pageXOffset` equivalent to `e.clientX`? Or is that buggy?

```js
return [e.clientX - rect.left - container.clientLeft, e.clientY - rect.top - container.clientTop];
```
if you use a tuple you don't need the `\`. 

e.g., 

```python
tightest_box = traits.Bool(argstr='--tightest-bounding-box',
                           desc=('computes tightest bounding box (overrided by '
                                 'reference_image if given)'),
                           xor=['reference_image'])
```
Is this PDF doc available somewhere?  If so, could we put an @see here?
Entendido. Por alguna razón tenía fijo la idea contraria. Lo arreglo y lo mando.
Do you know what breakage required this?  Now I'm mauling it over again, I don't think this is required, as outdata() takes care of setting DECL_SIZE in ```relayout_decl``` as per below comment.
In fact, I think this change is our big speed gain. Need to do more rigorous tests, but it looks like a 5x speed when using `alt_split_delimited_line`.
Same comment around `final`.
Is there any way to edit this or do i just make a new Pull request?
Hey, good idea. I'll get to this tomorrow.
Hi Renee,

I meant to say that an object is an instance of a class. I wanted to say
something along the line.. for example a Large Blue, fast bike is an object
of the class Bike in a succinct way.

Couldn't find the words...I apologize for the confusion.

Thanks for checking!
On Oct 17, 2012 12:56 PM, "Renée De Voursney" <notifications@github.com>
wrote:

> In week1/homework/questions.txt:
>
> > @@ -1,6 +1,14 @@
> >  1. What is an object?
> > +  Objects are subgroups of a class.
>
> objects are instances of a class. I'm not sure what you mean by subgroups.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/UWE-Ruby/RubyFall2012/pull/43/files#r1871305>.
>
>
please rename `config_taskmanager` to `task_manager`
i suppose images.fetch _could_ change in the future to download a directory instead of a file, but glance is all file oriented right now.
Removed all the conf we don't need
I'm not sure this fits here, but I see your point, since the guest client stuff lies in here.
As suggested in the 1st comment, what about a simple array?

As far as I can see, segments could be an array of size of keys. Owners could be yet another array, or segments size. Finally, you convert the owners array into a set (if that's more friendly for the clients of this api - note: i have not checked the uses of this API).
What does this Create do? Create what? Caches? Keys? Values? :)
You probably have your IDE set to automatically add "final", but it makes the patch a bit noisier than it would otherwise be.
Manik, if the removal is normal removal (i.e. cache.remove()), it's all fine, but there can be a removal triggered from within the container (i.e. an entry has expired, the segment size has exceeded...etc), so to be able to update that counter and if you wanna keep the counter in the interceptor, the data container must have access to the interceptor. There's not a single way in which data can be removed.
It's a feature, I add this after that as @klaussilveira accept pull request.
You are correct; well spotted!
Можно просто массив заменить на ассоциативный. Типа
```array('ids' => array($id), 'workerUncacher' => $workerUncacher);```
Честно говоря не нашел пользы от такого вариант для внутренней реализации класса и не сделал. Стоит сделать?

Про отдельный класс не совсем понял, но попробую ответить про использование сеттеров вместо конструктора: сейчас $id и $worker нужно в объект добавить лишь один раз при создании, а потом только объединять анкешеры между собой в один.
@drak I do agree that a standard should not be unreadable or confusing; with all due respect, the existing PSRs have clearly failed in this. There have been a number of emails on the list regarding ambiguity and this is simply another instance of such. Essentially, in an attempt to avoid being overly-verbose, the exact opposite has occurred: the standards as they exist are **underly-**verbose, leaving too much open to interpretation. It should not be necessary to consult a massive amount of email discussion in order to determine the proper interpretation of a standard; if this had occurred with HTTP, I believe it is safe to say that the web would not exist as it does today.
Same `<h*>` comment from `email.admin.tpl` applies here.
No, I wrote that. This is creating a neighbor-value from a single forma-value. With one value, average and min are the same.
We should default the `lang` attribute to English. User agents should be better at interpreting if there is a `lang` supplied. We should probably do that in the HTML though and overwrite it when the code comes to this point.
This shouldn't be done now but it would be good if we could logically divide the image directory into sub-directories at some point.
Is it compileable?
@clarkepaul / @adrexia do we have a good reason why we are changing this file & UploadField.scss as part of actions-bottom? Just asking internally before Ingo has a chance to complain :)
I hear you - this feature could do with some architectural thinking beyond the frontend. History.js and cookie support would be great additions.
Let's get rid of this global, I would suggest to use APPLICATION_PATH instead
This makes the configuration class more complicated with no real benefit. It does not harm if the other keys are there if we don't need them (for instance, the handler key can contain many useless keys as most of them are used only by one handler type)
what was wrong with the original implementation of this?
The arguments are backwards here.
Why do you never use send_multipart?
created bug https://jira.appcelerator.org/browse/TIMOB-10339
Das ist eine Empfehlung... Wie im Domainmodel. Die hat halt ein Bier, welches sie empfielt und einen user der die Emfpehlung bekommt. No Magic. Wie genau die Bewertung gefunden wird steht in der Doku, oder was meinst du?
In der Resource hat man immer Zugriff auf den Request
Wir (Chrigi und ich) haben es beim Erstellen der TestDB anhand des Designdokumentes so erstellt, darauf habe ich überall durchgängig alle Properties vereinheitlicht. Von mir aus kanns auch firstName lastName heissen, ist vllt. schon eindeutiger. Aber es solllte einfach durchgängig (inkl. Doku) gleich sein.
Die Cypherqueries sind einfach cool :)
Isn't `$.isPlainObject( key )` better in this case since `typeof null === 'object'` is true?
Sounds good. Now that I think about it making a clear intent to check validity is probably best. :+1:
Definitely. The push summary should suffice here anyway.
Have fun on your vacation but please don't mind if I bother you with my questions.
Very nice. generic views rocks!
Should be capitalized?
Я только опасаюсь, что gcc с ключем -O3 сделает нам одолжение и оптимизирует эту переменную.
There is a better version of this elsewhere:

"Sets a search query to filter the response. The response matches field values against the search query. For example, "foo" matches any object that has "foo" as a substring in a field, and "field_name=field_value" restricts the match to a single field." Be good to reuse.
I guess there it could be only one level of try, catch. 

If user said he want to use i18n without having the culture or the fallback, he should have an exception.
Good question,  I was rather thinking about `TRAVIS_SECURE_ENV_VARS` as a way to tell if you can have them, not if they're actually available. If you have a travis.yml file you should know if you have them or not.

But after your question I guess it's not good - I think we should do what you suggested. I forgot that in travis you can have builds with 2 sets of `ENV` vars, like:

```yaml
:env:
  - [{secure: "..."}, "FOO=bar"]
  - "BAR=baz"
```

and in such situation you can't just say: ok, I put secure env vars, so I have them.

I'll fix this.
Is there a reason you're using HumanEval instead of ClockworkRaven?
I had to remove parent because I don't have access to these artifacts ;)
Add probably also:

```
{% block extrahead %}<meta name="robots" content="NONE,NOARCHIVE" />{% endblock %}
````
You are forgetting to validate if user is really authenticated and staff. Otherwise somebody can fake this request (especially because we are an open source project and can see how the request should look like).
`message`? Not post?
Indentation (tabs)?
`post` and `i`? The idea is that it is understandable what are you iterating over. So what are those `objects`?
Just decide for one. :-) It can probably be also verification? What do "big sites" have?
Indent one less.
$model_path/$m/$m.aql is empty
Yeah good call, added on 8564884
Generally I prefer `source ve/bin/activate` because the full-stop is easily overlooked when reading. `.` is only used if you're in `sh` whereas I think generally most people would have `bash` at least. That said, I know Ubuntu's a little funny about this at times.
There is also a similar class, [AbstractTypeWithNonDefaultConstructor](https://github.com/AutoFixture/AutoFixture/blob/master/Src/TestTypeFoundation/AbstractTypeWithNonDefaultConstructor.cs), in the TestTypeFoundation project.
`createFilterChain`
Nokogiri should already be loaded here afaik, should be able to remove that require
yep, good spot.
Debug code? :)
I think we should talk to the PaperTrail project about this, and get them to fix it so that whodunnit always returns a User object.
Could you please tell me more about this? How did you discover this was happening, and do you think it could be caused by a bug in our code?
I am not sure which one is more complexe actually.
Feel free to rewrite this part of the code.
> Also, a .jsm will generally export only one symbol which will act as a namespace. Perhaps Promise?

Quick MXR search indicated bunch of modules that don't follow this pattern:
https://mxr.mozilla.org/mozilla-central/search?string=EXPORTED_SYMBOLS

Also this maps much better to the way CommonJS modules work, so I'd rather leave it as is. Specially since it's always possible to import JSM into `Promise` if desired so.
so what that does mean? That the client can register himself an mixin-event-handler?
Could you just use ui._os_sep?
@mancdaz: this will fail as split is not a recognized method

release = node['package_component'].to_s.split("-")[0]

That should work
Will look.
The screenshots section is missing. See one of the other themes.
in influence_outliers we called this summary_frame, is that appropriate here ?
nose will not recognize these as tests

``test_l1_....`` as method name

(as check, put in temporarily a mistake and verify that nose raises a failure)
importpaths is pretty basic also for newbies, 
the argument for pitfalls higher up is mainly to get users to be aware of this even if they skip reading it in the first round
Two empty lines is a bit too much for separating regular methods of the same class, don't you think?
The current solution enables the user to define the complete name, which is equal to the description's display name. This possibility vanishes, when we provide the brackets ourselves. Therefore I prefer to not supply the brackets.
Butter
------
This is expensive to construct.  Recommend the following:
LOG.info("handleMessages() invoked");
if (LOG.isDebugEnabled) {
  // big expensive string construction here
}
Using load instead of get would be fine. See its single purpose (so far) use at https://github.com/Connexions/rhaptos2.repo/pull/43/files#L3R106
Removing, happened to be the first enum i opened was RedemptionType and it had Description nodes.
maybe put it in init, cause native is loaded by soundsystem..
I guess i could have did : if (!Page.Enabled)

Don't know why i didn't, maybe because it's going late around here ...
This is fine.  the draft and ready versions always have the same live_datetime now.
Added DFS traversal. Are cycles possible?
this seems odd to be part of the asset pipeline changes
File name typo: ind**i**pendent_payment_strategy.feature
I had some unknown problems with the first release, so I tried to minimize changes in .pom file. Maybe now on we could try to use the latest version :)
I think one trailing newline is sufficient :)
nao pula linha
@parndt If this is indeed used, adding a post counter on Refinery::User might be a better way to do this.
I suspect this one, and below, regexps need to be adjusted too in order to work in windows / with windows paths, but I didn't put the effort into fully understanding all the code so I didn't want to go rouge
I really think this kind of rule worht an image. If that's a UX issue, fluid layout issue, they should take into account mobile constraints :)
Should we make this settings.WEBTRENDS_METRICS_REPORT_URL and do the same thing as WEBTRENDS_WIKI_REPORT_URL?
Removed the file. Should be gone.
Not sure the factory should be instantiated or extend anything, the methods should call `new Client()`
Tha's the part which masks out organs with ORGAN_DESTROYED bit set
You're right, too many magic is happening behind the scene here and *we* took the shortcut internally the MapJobRegistry was the only implementation that we use so we could just as well make sure it implements StepRegistry and be done with it.

The thing is that this feature is highly optional: if you don't deploy your jobs on remote nodes, you'll never need this so changing the code broke some API such as the ability to create a JobLoader with *only* a JobRegistry. I don't think it's wise to move forward. I would consider three options:

* Keep the existing code and address the Javadoc. I am not sure I understand your problem with the exception but maybe a third setter with a kind of composite interface for both registries that set both fields would be more straightforward?
* Deal with the fact that StepRegistry might be not set in DefaultJobLoader
* Create an extension that is aware of the StepRegistry

Thoughts?
I was actually originally going to, but it looks like it's not developed anymore. Last release more than 2 years ago, PHP6 support in roadmap...
```path``` might be a better variable name.  I think a URL has a protocol and a domain.
Здесь многократно вызывается word.toLowerCase().
Для этого есть статический метод Character.
Не работает. replaceAll возвращает новую строку
Название пакета должно соответствовать директориям.
Название по-прежнему не отвечает на вопрос - а что, собственно, тестируется?
Надо System.exit(1) делать
Prefer the predefined constants i.e. MODE_PRIVATE
This isn't consistent with any of our other providers, which take the API key as a parameter in the provider constructor.
how about: 
`return [app in self.results if not app.is_app_purchased]`
This method will always return True, I think it would be better to return the outcome of the Assert.
Also the name is not accurate, because the page doesn't change, only the open/close condition of the basic info form, Ex: is_basic_info_form_opened.
s/retrival/retrieval
Maybe: `addStatusCode`
Nope, I'll remove it. thanks.
DroidGap class is now in ``org.apache.cordova`` package
One point here:
An additinal differnce between diffusion maps and laplacian eigenmaps is 
a renormalization of diffusion maps to make them less sensitive to data 
sampling.
See http://people.ee.duke.edu/~lcarin/data_fusion_by_diffusion_maps.pdf, 
section II.B for details.

The difference between the two is just one line (a renormalization). 
This means that it should not be more than a keyword argument  in the 
function

HTH,

Bertrand
maybe just call this ``learning_rate``?
> There's already a deprecation warning for p (below in the code)

ok my bad
On my box (with nosetests version 1.2.1)  it does not seem to be necessary as long as it's already there in the `setup.cfg` file of the project. Furthermore it used to be there in the Makefile initially when travis use to fail taking the fixtures into account so I don't think re-adding those commandline options here will help.

Maybe the travis runner has also some kind of `~/.nose.cfg` outside our control that overrides those options? I wonder how we could check for that.
We don't usually put LabelEncoders on estimators as public attributes. Instead, I'd prefer a property

    @property
    def classes_(self):
        return self._label_encoder.classes_
yeah should be. but I think this is very much work in progress...
> Your model is still learning?

LOL. I'm at home relaxing now :)
Thanks @dalen - I'll test both pull-req's together tonight, but it looks pretty good at a glance :)
return value. just added a comment to clarify that.
What did you use commons-lang here, instead of just Integer.getInteger() ?
Is the Push command really not working?
This is what Port::isNan(double) is for.
This was an unconditional error, leave it that way, please.
Comme tu vas utiliser la même méthode (newBug) pour ajouter un Bug et en modifier un, va falloir trouver un moyen pour b.save() quand on ajoute un bug, et b.update() quand on en modifie un.
Sinon,  you're gonna have a bad time.
Extra .str() on the end isn't needed.
Can you use the apache license for newly created files please
Why would there be a leading ~ ?
Shouldn't this be "LINKCOUNTED" now that it's user visible?
Not 100% sure about the swap.  I realise it minimizes the changes to the rest of the code, so ok.  
Not for this commit, but there is a nested variable called msg in the following code which is confusing.
Mmm yes.. I thought about that too. I've included it only for testing purposes, but it's a good reason to separate it in a different method anyway. I'll do it now.
Do you really need the whole of Mustache just for this?

Also, are you sure these URLs are still correct? To me, looks like a hell to maintain if/when we change URLs.
why was this bit changed?
This would be great to see moved into a private method that names what it is doing.
I think nobody will do it
In the meantime, I've added a parenthetical statement indicating that the configuration refers to the layout template as the "baseTemplate".
I also caught another subtlety: we should allow `false` as the `secure` option.
@christianv Ah, it was referenced in two places and I only caught one, thanks.
Can you please use your real name instead?  And then you can put your organization in a comment.
I did not know Msf::Config.install_root existed.  I'll use that instead.
repeated_permutation is 1.9.x only.  Rewrite for 1.8
Nah, forget it, I just found out enum_domain.rb .
My bad, I didnt look existing modules properly.
I'm trying to decide if it would make sense to allow for a zookeeper instance to be passed in to this class...

If I'm already using zookeeper in my processes, does it make sense to have twice the connections?
This does not work on Cython 0.15.
yep, just saying we have to document this to make people understand how it works :-)
You think so?  I didn't actually test on Rails 3.0, since I don't use it.  Honestly, I didn't figure it could cause any issues, since the message is only modified if Rails > 3.1, else it is passed through vanilla.

But you're probably right.  I'll go double check and write some test cases for that scenario.
Strictly speaking you don't need the quotes around non-reserved words and I think it's nicer without, but it's a nit and I don't care much. Just sayin'
OK I'll update to match your logic
``[Edgar]`` ? What ?
Is the `imageryLayerCollection` argument useful?  When do users have an imagery layer collection before constructing a `CentralBody`?
Are we calling this too often?  Don't we only need to call this if billboards were added/removed/changed?
Nope, I took it (and one other usage) out.
You can probably get right of the last line here "If the initial..." This is an implementation detail and probably doesn't need to be in the API documentation, but that could just be my personal preference showing as well.
This should be `typeof updatedFunction === 'undefined'`
OK.  Moving discussion to #86...
The ADL repository is the place we can share our code. When people feel uncomfortable to push such a "refactoring-in-progress" code to the master branch of the main repo, a common practice is to put it in a branch other than master of the main repo.
どれが必要な指定がわからなかったのでとりあえず全部・・・

ドキュメント http://rubymotion.jp/RubyMotionDocumentation/guides/project-management/index.html 読み直しましたが、「アイコンに使用するリソースファイル名のリスト」を指定するよう書いてあるので、"iTunesArtwork.png", "Default.png" は明らかに不要ですね。

他はどうなのだろうか・・NotificationCenter用のアイコンとか確かに不要なのですが。
I do too...and the implementation isn't hurting anything, I guess, other than not being the standard these days.  Not to make this into a "Hey, while we're here let's update everything to > iOS 4 patterns!" review. :)
Is this true? Table views contains sections and rows, which are also views. I guess it is true that devs are supposed to use addRow instead of add, but they basically do the same thing. Ideally we would change addRow to add, since it's kinda strange to not follow the convention.
We may package the Anvil tool itself with CLI (when we get to that) but the tests I would like to keep associated with a titanium_mobile version since the tests should always reflect the git hash in question.  There was just no strong advantage for distributing tests from the hub upon further review.  As you could have 50 instances of the driver running on various machine against various SDK versions you then have to worry about test version management being hosted form the hub, etc.  Just represents a lot of complexity for no clear gain IMO.  This can be revisited in the future though of course when the hub is being built out.
Not sure but it's not new and since this is destined for 2.1.1, I'm hesitant to do anything that has a chance of introducing something subtle.
Okay that's fine in that case.
Старайся избегать try catch вместо них лучше явно проверять значения и реагировать на них каким-либо другим образом. В нагруженных скриптах блок try catch может внести деоптимизации JIT и вцелом замедляет работу функции.
objects default to null, can just do int interval;
Does it still make sense for us to do this? I don't understand the big
picture of who runs the tools and how .js files get checked in. Perhaps we
should remove .js files from .gitignore, use Dart Editor to just compile
everything, and then check them all in. I guess the problem is that the
project doesn't have any notion of a build step that people will remember
to run. It's also weird to check "compiled" code into Git :-/


On Fri, Dec 21, 2012 at 12:27 PM, adam <notifications@github.com> wrote:

> In bin/build_web.dart:
>
> > @@ -0,0 +1,85 @@
> > +#!/usr/bin/env dart
>
> @jjinux <https://github.com/jjinux> This is 'old' code by now. The intent
> was to help with the javascript deployment of the samples. I know @kevmoo<https://github.com/kevmoo>and
> @justinfagnani <https://github.com/justinfagnani> have both been working
> on build tools. Long term we might want to employ buildtool<https://github.com/dart-lang/buildtool>or
> bot.dart <https://github.com/kevmoo/bot.dart>
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dart-lang/dart-html5-samples/pull/52/files#r2492467>.
>
>
I'm guessing that since you're including your Dart file at the bottom of the page, you can just use "new TodoList().open()" directly without having to use window.on.load.add.
hmm, i wonder how easy all this is to maintain (more a general comment about Shrinkwrap and co)
On your example, it's using `version` and `label`. For `versions`, we're actually using tags or branchs and formely naming it `ref`. For `label`, it was formely named `description`. I'm changing, so if you wanna revert any please advise.
Same comments about condition ordering and strengthening the check for all non-numerical values.
Hmm, `lowe <= upper` is checked abobe, then tranlatedLower <= translatedUpper is also valid in here, isn't it?
Yep.
It's really rare when I don't test my changes before sending a pull (especially because lots of my pulls require other pulls and autotester just fails without giving any useful information).
didn't think of that
Which one? self.debug? Used by max to log gesture values I guess...
Ah!, thanks for the clarification, I didn't realize that we were basically overriding the same variable. 

The change looks good then, in fact, we could possibly move the OUTFILE definition outside the if/else
add an internal interface containing this method; while the ConnectorManager is deployed as service to OSGi the new interface will only be used for internal bean injection
sub method
would be great if you used ofLog here instead of cout. :-)
Why not Ubuntu 12.04? It's listed as a supported platform in the README, and is the current LTS.
Just a missing semi-colon according to my JS Lint.
@Shagabutdinov This line should be:

    "sublime-anyword-completion": "Anyword completion",

Unfortunately I merged your pull request before spotting this, so I'll need you to submit a new pull request with this change. Please do so ASAP so we can get your package listed with a nice, readable name.
Can we potentially read that off the certificate?
do not understand ... why are we hiding it?
note that you're losing this piece of logic in your refactoring
2012. Probably should read Caffeine IT, naughtyProd Limited and contributors, with a link to the contributors for the site (which should be easy enough to generate as a git shortlog -sn? Not blocking for this pull request though.
смотри в других плагинах как правильно #ifndef делать
That was akward.
This is not right. As far as I know the second level namespace is not enforced by PSR-0, and many many libs out there just have a vendor name namespace containing core classes. The key thing is that you don't have anything in the global namespace to avoid collisions & improve autoload-ability with prefixes.
Yes and there is a test for it
_text.css.scss.css? I think you messed up the name. :)
Yes it was a bit awkward, I've tidied it up.
Constant string?
Please refer to the 2.0 documentation http://zf2.readthedocs.org/en/latest/modules/zendservice.amazon.html
Good point, maybe leaving this as a class is a good idea
I think the global property you want to reference here is actually cccgenerator.CCC ... but check with the CCC Generator Module to be sure.
verify that the synapse client is called with the updated profile
That's a good catch.  Although it looked like it was customizable by the user, the value passed in the constructor was never used.  The constant was always the one being used.  I'll also fix it in storage API where the same issue is present.

Although I'm not so sure that having this customizable is very useful, because it is unlikely that the library would work well with an xml schema different than the one it was designed for.
What does this section of code do?
On Mon, 20 Feb 2012, Hannes Magnusson wrote:

> > @@ -383,14 +430,30 @@ static void add_md5(zval *zfile, zval *zid, mongo_collection *c TSRMLS_DC) {
> >      add_assoc_long(zfile, "length", bytes_len);
> >    }
> >  
> > +	// options
> > +	if (!options) {
> > +		zval *opts;
> > +		MAKE_STD_ZVAL(opts);
> > +		array_init(opts);
> > +		options = opts;
> > +		free_options = 1;
> > +	}
> > +
> > +	// force safe mode
> > +	add_assoc_long(options, "safe", 1);
> 
> Don't you need to separate the zval to not modify the original array here?

Hmm, good point :-)

> Infact.. I don't see where the input argument is ever forced as array?

Also a good point. I noticed that in a lot of cases just a "z" is used 
and not the actual. In this case however, changing "s|az" tp "s|as" 
would be correct.

cheers,
Derick

-- 
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug
I don't see any 'predicateWithSubstitutionVariables' tests?  Did I just miss them?
Still a typo in specifies
I guess you can now remove the same min/max/step initialization params which are still present later in the file? (same for other controls)
В пайтоне можно так писать:
a, b = b, a
Sorry to be picky but it is somewhat important here: user's subscriptions
Should probably read:

> Returns the order in which properties must be set on the proxy object. Properties which are not in this list are set in an undefined order.
Might as well roll these up into a single catch for <tt>Exception</tt>; the handling (and even the logging!) is the same for each.
except that we now have bound_t
I agree completely that this is hardly optimal, or beautiful (or even endurable :). However, I fail to see how it's model's business to know which jpg relates to which idea.state. IMO, it is always View's business. Only reason I can come up with why to pick it up from Model would be the need to use dynamic URLs, or URLs that are based on models state. Now they are not.
clean that please.
Вынеси dateValidator отдельно (Event.dateValidator) проблема в том, что при каждом вызове  Event будет создаваться эта функция.
no it does not. my line removes comments from status div
Got rid of xq and renames variable *dataSource* addresses both issues ;)
you are passing true to all the wrench.rmdirSyncRecursive calls for failing silently. Why do we want these calls to fail silently? If build script was unable to accomplish this we should probably tell the developer. Am I missing something?
grid view widgets → widgets
"volontaire".

My bad...