labofsahil/github-event-dataset-2012 huggingface dataset:
> This code would cause power menu never works when lockscreen shows.

That exactly is the idea. The power menu doesn't work on Android when the screen is locked. If it's accessible even when the screen is locked I might accidentally power off my phone in the pocket if I somehow press the power button. That's what screen lock is for, isn't it?
I thought we monkey-patched stuff so this was marked as safe already?
because i've delete'd the document in ES, not the record in MySQL, that's what the test is checking
`dump` doesn't append a newline, so you need to append one yourself (the `stdout` and `stderr` functions are exceptional cases, as they dump `data` values that embed their own newlines).

However, the good news is that you don't actually need to use `dump` in this case, as the Add-on SDK platform (with which this addon is built) has a built-in `console` object that does append a newline. So this can be:

    console.log(executable + " terminated with " + result.exitCode);

However, `executable` is an *nsIFile* that stringifies to `[xpconnect wrapped nsIFile]`; to print the actual executable path, use `executable.path`, or for just the filename use `executable.leafName`, per [nsIFile](http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsIFile.idl).
It all makes sense now :smile:
Relying on Directory.GetCurrentDirectory() seems quirky. I have no idea what the current dir is when tests run.
This should just be `"Propel": "runtime/lib/"` - the path you got there probably works from inside your project, but will break once added to the propel package itself.
look at improper indent comment above -- git-core is now explicitly installed, so it is no longer a useful fix or fallback, right?
I tried removing all the arity stuff, and it works great in 1.9... breaks in 1.8 . Looks like it's necessary for compatibility.
eher in das dazugehörige Template!?
A `stub` has to be restored. Use a `spy` instead (gets restored automatically).
Why are you importing types?
What is gzip is null?
Like before, the next line explains what you're doing. Your comment should explain why you're doing this, because that's not clear.
I have no idea why I did this way :D . I'll fix it.
Thanks
what do you mean by that... I copied that from the EconomyService class.
I doubt you use `while True...if not` struct to simulate `while condition` struct here.
I could be mistaken, but I think logging the exception results in it being printed twice when running in --verbose mode.  Not a show-stopper though.
The difference is in how you read "returnValue" - is that "set the return value" (no) or "return this value now" (yes). I actually got this wrong in the docs (http://buildbot.net/buildbot/docs/latest/developer/style.html#inlinecallbacks, although I'll fix that now).

At any rate, those docs do say to use it, and IMHO over-communication is better, so please add the return statements.
This should probably just return `invalid_params`, right?
isDot checks for "." and ".." http://php.net/manual/en/directoryiterator.isdot.php
Instead of using a second context here and going for the chain... use the variable 'capture_peer_cert' and the 'peer_cert' response: see: http://lxr.php.net/xref/PHP_5_4/ext/openssl/xp_ssl.c#533
Adding tilde support
Any reason for returning false here, or returning at all?
I find this a little ugly.  Can we just make a __native_client__ version that memsets and leave madvise alone for all NaCl archs?
I don't quite get what you are doing here:  you inherit from str but don't call the superclass constructor.  i.e. what happens to the 'sequence' variable in the __init__ below?
But it will reject with an nsIFile exception instead of a normalized addon manager error code (here: ERROR_FILE_ACCESS) ?
We end up with string using `'` and `"` next to each others, it would be better to use`"` as this file tend to use it.
No both `globals` and `modules` are just for the illustration purposes.
We can't do that as it would mean exposing our method `f` to content and overloading method set by the page itself.
We we set `window.onload = f;` in content script, `f` is set in expando list of the xraywrapper, so that the page itself can't see this expando, nor that the content script erase page expandos.
You no longer use `tabsNS`, but you still use `tabNS`. Please get rid of this dependency in this module.
I'm thinking that we should make a `xEmitter` object which is the event target, and explain that this is done so that outside code cannot emit on it.  I think this is the case even when the `exports` object is used, but I'm not certain.  If `exports` can be emitted on from outside code in other modules, then that possibility should be described imo.
I use something when I think is right. I prefer using an explicity "everything" when I do not care about the what I should actually have in the structure in accordance to the specs. Otherwise I prefer a regexp that match the specs. To me, find in a regexp something like `[\s\S]` tells immediately that I want everything. Found a dot could be not exactly "everything".

Because to me this is not really an issue, but more a matter of past experience and personal taste, I already modified that regexp in the last commit I did the other day.
@seanmonstar - Is there any way of testing whether an environment supports signals before wrapping this with a try/catch?  I am worried that this may swallow valid exceptions thrown on *nix based systems when shutting down.
Since emails no longer have a stored type, we will now have to do a user.addressInfo to get the type to send to the KPI data.
This is something I want to do as well. I'll make sure it's in the next commit.
Renamed as you suggested.
That threatening message was previously discussed, and I thought it was decided to tone it down to something less frightening...
Yeah, they should be somewhere else, but I think in the end I was manually starting the servers, instead of having a script.
it "resolves a built-in type"
Let's not try to commit these types of changes in the future, otherwise we will just be stepping over each other. git stash is probably the best way to keep these local
Both, ```MSTransitionEnd``` and ```transitionend```, do exist in IE10 but the former won't be ever called!
Mi è rimasto da prima
Also, space missing after "if" and after the first comma.
In Update.php, you created docblocks for these properties...
Never use System.currentTimeInMillis, especially when you're trying to get the elapsed time (this is what nanoTime is for); use the GameEngine's getTime method instead.  This allows us to change how the entire application keeps track of time, so we can always make it more accurate, whereas using System.currentTimeInMillis can cause a hardware poll (which is extremely slow), and would require us to make changes throughout the entire application.
Yeah, that is true.  I wind up patching the queue on nearly every test.
@KushalP  Such a change wouldn't really belong in this branch, unless problems were introduced here, which they weren't.
Minor point: don't think you need the left join, as the WHERE condition will remove the extra rows in any case.
I agree that this merge might be a bit "incorrect" — I wasn't entirely happy with it. It passes the tests but this doesn't mean it's good. I think this is fixable.
Ah, that.

I needed to be able, after calling the visitors, to send the status code as a distinct, integer parameter. I did consider parsing back the Status header, but preferred this way. It didn't feel like it didn't belong here.
All exceptions in InMemory stubs have that error message, so I was just following :)
I see, there is one more locale encoding.
what is this for? Already defined in doc format above
spaces around '%'
This is now implemented.
Why does this module get three parameters, and all of the other modules get two?
so would it just be <%= partial: "tags/embedded_form", :locals => { :tag => Tag.new, :contact  => @contact } %> ?
This can just be `if @contact == current_user`, I believe.
Yes, in this case it's fine. But `libs/` will match all directories named `libs` and not just the one in root.
And if you dont write `*` after `libs/`, then next two rules has no effect.
Try `--pre-js` a file that contains

````
Module.preRun = function() { SDL.defaults.copyOnLock = false }
````
Need a return here.
Does doing this override the value set in the properties file? I swear I added a config option for explcit hostname definition.
Why don't you just write

```php
$req->responseHeadersRaw = $raw_headers;
```
...?
Probably doesn't need the trans block, not that it matters that much. (`_('No Tasks')` would be fine.)
Per discussion on IRC, let's defer to your branch
Nit: Replace this empty line ;)
The use of rightZ here is incorrect.  We shouldn't ever fail with mzero in this function.  It should always end up running one of the supplied success or failure handlers.
Correct. Can this instead be gotten from event.target / event.currentTarget?
Can you find outside dicussion of this bug?
Well, if cloudname fails due to network etc, it is not really in use. This might be set a bit early?
What do you mean? I thought that's what this was for?
Right, but before it was bounding the values of A, B, and SOLUTION (via data-ensure) rather than drawing not-to-scale. We would never ask [a question like this](http://sandcastle.khanacademy.org/media/castles/xymostech:geometry_fixup/exercises/alternate_interior_angles_2.html?debug&problem=0&seed=91545758) where the angle is actually 178º. But this is probably better since it will lead to more variety. Ship it!
i think the break is not indented correctly
This fails because it can't find rake. I don't have 1.9.2 installed locally to test, but I imagine adding rake to the development dependencies would fix it.
但是效率低啊
Is this correct?  This seems to be an off by one error:  I think it should be

    subsequence[window_size // 2]
Please just get rid of the `<head>` tag here and have the two scripts together
"apply", right
I don't think this code should need to be copied into everyone's settings file. Can you put that into django_sha2 and then tell people to use ``PASSWORD_HASHERS = django_sha2.get_password_hashers()``? If they want to change that code they are more than welcome to, but most of the time they won't need to.
the `search_term=` in here I tihnk should be removed
Aceptado y en camino :)!
Yeah, I don't think I tested this part at all. I'll just remove it.
Noted.  I'm looking at the tmpfile.d as well for when this is ported to Fedora and RHEL>6
You should also add a gunicorn-del package to the project with an update and check that the project dependency still exists after the deletion (hint: it does not :þ)
I don't think this method should trust that the consumer will delete the temp file after they've had their way with it. For example, I *think* the temp volume will fill up in the current implementation, as the cropAndResize process does not delete the source file after.

Perhaps this method can have more of a `do with file` contract, where it downloads the file to temp, you do something with it then call a `done()`, and then the temp file is automatically cleaned up after. I don't have a clear picture of how this works exactly right now, but I think it is rather dangerous the way it is if it is publicly exposed.
Having a cassandra query here doesn't seem right to me. Would we not have an API method somewhere that removes a user's rights to be a tenant admin?

At the very least, if we need to go straight to Cassandra, then this should probably be in something like `node_modules/oae-principals/tests/lib/api.js`
```} else if (_.keys(members).length === 0) {``` makes the code more readable (imho)
Very good point, there was a bug in the compiler that I fixed a few years ago. It could come again, so a check here definitely wouldn't hurt.
We don't really need the 'type' parameter.
I'll be honest, I have no idea what RedirectableUrlMatcher does.

FinalMatcherInterface doesn't have to be used on a class extending UrlMatcher.  Drupal is going to have its own version here too, probably just extending the CMF UrlMatcher class.  Using UrlMatcher as a base is, architecturally, just a nice convenience.  If there's a sane way to compose it instead I have no objection to that.
This shouldn't be ignored for gems with executables.
And adding () to the function name in here would be nice. :)
остаток от деления на 3 не можеть быть равен 3
У массивов есть методы, позволяющие возвращать их элементы, объединенные разделителем. Можно было бы использовать componentsJoinedByString, поищите вот на этой странице: http://goo.gl/x6spV
A little confused... If requiredFields is explicitly provided, it has to be a string, but if it's not, we generate an array? Interesting...
Like this example http://www.phpunit.de/manual/3.2/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.exceptions.examples.ExceptionTest.php ?
does not support blob URI scheme
I think that's wise. Its critical that it we're confident it behaves correctly especially for remote observers.
This isn't intended to replace the `+deferredScheduler`. See my message in 8824b5a3abf0d21ab5cfdf22585cf07c78fc1a75 for why I removed that.

Rather, this is to "fix" `+iterativeScheduler` to actually do what we need for things like `-repeat`.

In order for `-repeat` to actually return a usable disposable, we have to be able to back out of the _complete_ call stack, not just to wherever the `+iterativeScheduler` was first used (which is what the previous array-block-queue implementation did).

The only way to really do that is to enqueue blocks on the current scheduler for after the calling code completes. That, in turn, requires that we _have_ a `+currentScheduler`, which is the cause of most of the documented complexity.
I think these responsibilities should be split into separate objects. It's weird that the singleton uses only the subscripting method, while instances are used only as keys.
please put here the providername as parameter.
This is here because one of the new plugin versions (I think) has a transitive dependency on version 0.6.0 of `cc.spray.sbt-revolver` which isn't yet in the Typesafe repo.
Zie mijn vorige comment ivm RedirectResponse.
I'd remove 42 and replace this line with

log.Printf("server: client cert chain: %#v", v.Subject)

which seems potentially more interesting than a bunch of binary.  If you want to keep the PK bytes, make it log.Printf("%x") to compress them and make it more friendly (but it's pretty long).
You should remove the commented out code.
So it should be safe to delete this check, right?
If I run "lprun" on one of my raw.fif's (of which there are typically ~10 per experiment), the time to run the line with np.dot (or p_fun) goes from to 22703079 to 11855005 (each taking > 90% of the time) when using n_jobs=1 versus n_jobs=6. So, essentially 22 down to 11 seconds, multiplied across the number of files I use by the number of subjects, plus gains I'd get from doing the other projectors in parallel would add up to some time saved. Especially these if processes are iterated to see if there are problems being solved (or caused) by different projectors, which is something I tend to do.

I imagine other people have additional bottlenecks that may be more problematic. I run SSDs and preload data, so my processing tends not to be I/O bound. There does seem to be a decent amount of additional time taken extracting the epochs even for preloaded data, but I'm not sure there's much to do about that.
many people use logratio for baseline correction
option 1 : assume people have properly baselined the data first
option 2 : add 2 parameters baseline and baseline_mode to be passed to mne.baseline.rescale
I'm quite limited with this... 
Do I have to add a other example with 2 TransportChain with the same tag ?
Why using an image to show code ? Using a code block would be better IMO
I like breaking it onto 2 lines, but I don't usually add extra spaces on the second line of a chained call. Any reason why you're doing this - is it in the core code somewhere?
I like that-- it makes it more concise and all the tests still pass. I'll update the pull request with those changes momentarily.
Он может стать валидным, если я уберу несуществующий итем. А я это врядли
сделаю
rm 25
should we make this a sort of ```error```-field in base? Does that make any sense to you?
`_highlightsBy` should be a mask with bits set like `CPPushInCellMask` as set up in `setButtonType:`, shouldn't it? Nothing calls `setHighlightsBy:CPOnOffButton`?
Please remove the index variable completely and instead have currentItem=names.size(); You need to move the line for adding before the comparison for that to work, of course.
Oops, this needs rework.
shouldn't we be testing that the property is also "no"? I can just see Drew changing it to "yes" and spending half an hour figuring out why buildbot isn't doing what he wants. See also buildbot.py:66
typo: networks should be network
is this expected behavior?
Is this missing some implementation? If not, could you fix the comment and explain why the method should be empty?
@galderz this was a requirement from certain management tools and scripts.  I don't see anything wrong with providing both options.
yes. Look how it's being used ;-)
What about you release a 4.2.0-Alpha1? :)
arugments -> arguments  This appears to be a typo inherited from the ffmpeg case above sine the same is in the lines above. 
ffmpeg should also be changed to avconv here in the comment.
version number is wrong. Should be 1.2
To clarify, currently when creating a PolarAxes with a theta_offset kwarg, ```Axes.__init__``` uses setp to set the value, but ```PolarAxes.gca``` wipes it again. This fixes this behaviour and is tested in my new ```_as_mpl_axes``` test.
I would phrase this as:

"After you've tried a release, you can decide to raise the version to the latest stable version."
Perhaps change the method name to <code>click_first_non_empty_signature</code>?
Nit: I know we don't conform the to line length limits of PEP8, but it might read better if this was formatted as:

    _expected_products = [
        'Firefox',
        'Thunderbird',
        'Seamonkey']
Move this to the end of the test, that we we don't need tearDown at all, and the if is unnecessary
Remove the commented-out code.
Worrrrrrd.

On Mon, Oct 22, 2012 at 3:37 PM, Robin Kraft <notifications@github.com>wrote:

> In src/clj/forma/hadoop/jobs/forma.clj:
>
> > @@ -150,8 +151,7 @@
> >        (??<- [?end]
> >          (src ?series)
> >          (series-end ?series start-idx :> ?end))
> > -    ;=> 6
> > -"
> > +    ;=> 6"
>
> I know, but it's actually just a usage example in a docstring. Totally
> kosher.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/reddmetrics/forma-clj/pull/274/files#r1910323>.
>
>
Your indentation on this public: is incorrect.
Absolutely agree with this notice. Thank you for mention this.
But is there general rule about platform dependent paths(probably stored in some entity), or should I just solve it like:
CONFIG =\
  if RUBY_PLATFORM['win']
    RightSupport::Config.features('c://unknown_path.yml')
  else
    RightSupport::Config.features('/etc/rightscale.d/right_link/features.yml')  
  end
@christianv : This should probably not be removed as it used to reset the contacts form
I agree. Strings should be escaped when they need to be and not before. (Carl recently had to fix an bug in the deleted-path cache caused by premature escaping.) If there's any code out there that's not escaping "authorizable ID" before inserting it into a query string, I would call that a bug.
could you please use SGVector as (return) arguments?
mmh, why are you using std::map here?
You don't need to depend on the driver here, you could take the Selenium::WebDriver::TargetLocator instance instead (i.e. pass in ```driver.switch_to``` and save it as ```@target_locator```).
On Wed, Aug 1, 2012 at 7:43 AM, Michael Cahill <
reply@reply.github.com
> wrote:

> >       (op);                                                           \
> > -     F_CLR(session, WT_SESSION_SCHEMA_LOCKED);                       \
> > -     __wt_spin_unlock(session, &S2C(session)->schema_lock);          \
> > +     if (__needlock) {                                               \
> > +             F_CLR(session, WT_SESSION_SCHEMA_LOCKED);               \
> > +             __wt_spin_unlock(session, &S2C(session)->schema_lock);  \
> > +     }                                                               \
>
> I tried to avoid this, so there was only one place where the schema lock
> is needed and may or may not be held (when opening a handle for the first
> time).
>

I backed out this change.

--keith

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Keith Bostic
keith.bostic@wiredtiger.com
On Thu, May 17, 2012 at 8:39 AM, Michael Cahill <
reply@reply.github.com
> wrote:

> > @@ -56,11 +56,11 @@
> >               (void)__wt_cond_destroy(session, session->cond);
> >
> >       /*
> > -      * Replace the session reference we're closing with the last entry
> in
> > -      * the table, then clear the last entry.  As far as the walk of the
> > -      * server threads is concerned, it's OK if the session appears
> twice,
> > -      * or if it doesn't appear at all, so these lines can race all they
> > -      * want.
> > +      * Replace the session reference being closed with the last active
> entry
> > +      * in the array, then clear the last entry, packing the active
> sessions
> > +      * at the start of the array.  There are no memory barriers here,
> which
> > +      * means a reader may see both NULL entries or sessions referenced
> more
> > +      * than once.
>
> If we can use `session_cnt` to avoid scanning the whole array, is there
> any need to maintain both `conn->sessions` and `conn->session_array` any
> more?  Could we have the hazard validate code scan `session_array` directly
> and get rid of conn->sessions?
>
> As a general comment, I would feel more confident about this change if we
> never decrement `session_cnt` -- in other words, if it takes the place of
> `session_max` from the first commit.


That means if we have a lot of sessions at some time, and the number of
sessions decreases, we're still looking at those empty session slots --
but, I agree that's a NULL vs. non-NULL test, maybe we don't care?

That said, I don't see how we can go wrong if we decrement session_cnt in
session close?

Let me know which you prefer, I'll code it up.

--keith

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Keith Bostic
keith.bostic@wiredtiger.com
nemishe az 50% ke bishtar bashe !
va az tarafi be px bede % hameja kar nemikone
Are you sure you want to override the parameter ``$collection``? This often makes code less readable.
In other windows almost everywhere button width is set ~200, and multiplying with 2 it's enough not to be truncated.
For this particular window buttons length are 50 in original code so for them not to be truncated they should be multiplied by ~8. this is just an empiric number 7. 
some general solution should be found later
Maybe "fetch organization info from github"?
Najo, wiegesagt... Innert 4min nix gefunden. Das heisst für mich, gibt es nicht oder selber machen ist schneller.
this use statement is useless. The class is already in the same namespace.
This is also not totally clear: is it a messageType or is it an action_type? what is the difference?
Where is MVC?
Почему не 1 ИД
Although I could also blame the noise of the diff. In any case, I spoke too soon.
Thanks @arian for the research. @chrispitt just update the PR, and fix the small optimization and LGTM.
Good point, order isn't important here. The easiest way I can think of right now to assert this is to use sort: `expect(result.sort().join(' ')).to.be('1 3 4');`. What do you think?
Nit: Break long line.
Never ever just hide exceptions. No. You do not want this.
Because in our case there is no reason to provide a template. Form is not linked to any particular page.
*mojo*
Please use `staticfiles` instead of `static`. Crazy Django thing.
(Here is maybe clearer, but in general is better, so let's use everywhere keyword based interpolation.)
But be careful, code for `CreateView` looks a bit strange. :-)
If you'd leave the old check for OpenLayers.Symbolizer.Text, we would not need the hard OpenLayers/Symbolizer/Text.js dependency. But I leave it up to you if you prefer having this dependency or not.
I should confess that I do not use pypy; I'm just trying to make sure that we aren't alienating any users.
It is only used in external libraries and very specific to FatZebra. It constructs a hash which can be sent for customer data.
I think that I might split this method up into two parts, `PerformUpload(..., Action<ProgressStatus> progressCallback)` and then have the UI update kept separate in that callback.
Did you try this one? Since `setObjectManager` and `setObjectRepository` are type hinted, I don't think it will work nicely with an array config.
This is my comment to your code
Please delete this file :P
Thank you for accepting this pull request! 
I'm working on application where I need more control on how SendgridEmailRecord is created. In my case it has additional field - `user_id`. 

For instance,  if mailer has the next method

```ruby
def send_mail(customer, user) # user has many customers
  to customer.email
  from user.email
  ...
end
```
then I'd like to have SendgridEmailRecord linked to user by user.id



I'm going to send another pull request shortly.
If you have some ideas about that, we could discuss them here. 

I'm thinking of something like:

```ruby
# in mailer
def send_mail(customer, user) # user has many customers
  to customer.email
  from user.email
  ...
  uniq_args :user_id => user.id
end

# in mail_with_record_email
# Users of the gem can redefine this method then.    
id = SendgridEmailRecord.create_from_headers!(headers, sendgrid_header_data)

# in SendgridEmailRecord
def create_from_headers!(headers, sendgrid_header)
  create!(:to => headers[:to],
          :from => headers[:from],
          :subject => headers[:subject],
          :user_id => sendgrid_header.data[:uniq_args][:user_id]
          :status => 'processing')
end
```

I have other thoughts - like a lambda in Configration. But I didn't decide yet how to do that.
ah - thanks, paul! fixed it. don't know what i was thinking... =/
should change the test name ;)
I think it's a bit misleading, one might look at those generated files instead of diving into documentation.
We definitely don't want to wait for the whole file before sending out anything: not only is that going to use extra memory but it's slower.

CollectAccumulatedWrites() should still pull into nginx all content that pagespeed has buffered.  There aren't memory savings in calling CollectAccumulatedWrites() one buffer at a time.
There are conflicting lines here still.
Hash!
Yep, just saw the pending test.  The implementation looks solid and, as usual, very neat and compact.  See my last comment for details.
Any time you have a set of test cases like:

class A(TestCase):
    def test(self):
        pass

class B(A):
    pass

-- that will break. Current behavior would be to run A.test and B.test, but with this change, B.test would not be run (unless I'm mistaken and this block of loader code does nothing). This is a pretty common pattern for parameterizing batches of tests by adding flags or settings to the test case that the tests then use. For instance if you have a bunch of identical tests to run against several versions of an api, you might put them all in the base test class with the api version as a class-level attribute, and have a bunch of subclasses that just override that attribute without defining any tests themselves.
the only test method in this class is ignored...
You could maybe make this a mixin instead?
this can be refactored:

```objj
- (void)isNestedVirtualizationEnabled 
{
    return ([[self getCommandLineArgumentOfCPU] value]).indexOf("+vmx") > -1);
}
```
My main concern is that I don't know exactly what Python is doing when you set `__class__`.  If it's not somehow magical, it's not doing enough to really change the type of an object - but maybe the Python devs expected this usage and it *is* sufficiently magical.  And if our classes had different metaclasses or descriptors or complicated inheritance, I imagine it would be very hard to get that magic right, so I'm inclined to believe it's probably not intended to be used that way.  But I guess the bottom line is that it's working now, so it doesn't need to be a super high priority - even if it puts our objects in some sort of a halfway state between two different classes, our classes are simple enough that this isn't a problem right now.

I was most worried about the SBTransform case, because I don't really know how to get rid of that and keep the in-place transform functionality we want.  The bottom line is that I don't think you can really, completely change an object's type after it's constructed.  But if all we're hoping to do is improve the exception message, that might be fine (assuming it doesn't break something else (I'll have to do some experiments on that).  And even if it does break something else, we could come up with another way to fix the exceptions, even if they're a little more verbose.

I opened an issue a while ago about improving pickle and copy support, and I think we could probably eventually use that to make a safer and simpler implementation of the copy method.
I understand, but it was deemed important enough for the GREAT3 webpage description of GalSim (http://great3challenge.info/?q=galsim), so I think it won't hurt.
empty lines :)
"fraction" rather than "percentage"?
I used to have that same opinion: only allow sub-classing for things that are designed for sub-classing, otherwise people can break things in their sub-classes and make subsequent refactoring "impossible" without breaking their code.

However, I've since been convinced that for many cases it's worth the risk to allow power-users (e.g. PS) to extend the class, without them having to use SNAPSHOT or to wait for the next release.
Can combine into a chained if check with the next check.
...to explain the gist of [d3.js](http://d3js.org/)...
Line is too long, split it right around the ||
Please add an issue to JIRA, and change the test name (and filename) here too.
I can't read this. Please add some comments and blank lines.
at the end of the discussion is enough and ease the code review.
- parenthesis different from rest
- whats pzpStatus doing?
you should not link to your fork of the repo
The convention in Gaia is to use camelCase for properties name but you can probably rename your properties too, what do you think of:
 dom_display -> display

 dom_clear is unused so it can be safely removed!
You left in some debug text
Initialization of the 'issue_id' field
Hummm... I didn't know that behavior of Git. I'd swear I saw it fail before...
Anyway, good to know! :-)
"employed in the same profession" then?
After all, isn't that all that the BLS data shows?
This is an instruction to *you* :-)
does this work, i would have guessed it needed to be value
I know why you are saying shortly (because you don't really notice it until the next refresh) but for this confirmation I would make it more assertive, ie:
  "Your preferred network is now set to 'MOBILE DATA' "

Same for the WIFI state below.
We should use the `@deprecated` decorator here as well (found in skimage._shared).
I there a reason why you did not add these imports at the top of the module (after the imports already there)?
It seems that it does not improve the speed on this example:

With `n_jobs = 1` I get ~ 55s on my box and the same with `n_jobs = 2` (although both cores are ~95% in this case). I would +1 for setting `n_jobs = 1` by default in this example.
We should keep an import in sklearn.cluster, decorated with the 'deprecated' decorator from sklearn.utils.
Could you add a comment to make it explicit that train and test can be boolean mask if the data is any kind of numpy array or integer indices if the input data is a list, an numpy array or scipy.sparse matrices.
BTW, do we have a way to avoid all these imports in `testing.py`? `testing` is a utility module, so ideally it should not depend too much on the rest of the scikit.
Ah, is this the place where the question about one instance_method from once class overwriting an instance_method from another class came from?

That's right. You'll get "Kitchen goes into the Kitchen" here, this way :)

Instead maybe you want something more like this:


```ruby
class Person
  def name
    @name
  end
end

class Room
  def enter(person)
    puts "#{person.name} enters the room #{@name}"
  end
end
``

Does that make sense?
seems like we no longer use it here anyway as i moved the publish checker to the core bundle .. so i guess i will remove it here.
Idem, crée une issue pour ça. Faut le faire, mais plus tard :)
amount * gen * cpu / 100 * 100

really?
'*' does not have precedence before '/' 
as there is a left asociativity, you are going to divide it by 100 and then multiply by 100 - if I'm not wrong, this should effectively round the expression down to to the nearest 100 multiple - that's probably not the intention.
Everywhere else seems to use `explicit`
Modify static functions to have prefix underscore
Same as TermsOfUse.rst english version comment
Débat autour de l'utilisation du terme item : faut t'il privilégier le terme Enregistrement ou Item ?
this `.pass(drop)` isn't necessary
I don't think dirs should be there.... is this code compiled?
I prefer single var even id there are only two variables. For me it ensures consistency see idiomatic.js 2.B
`&` needs to be replaced with `&amp;`

Also, don't we need: 
```
bug_file_loc={{ request.build_absolute_uri()|urlencode }}
```
Why not just `if (prodVersMap[product])` ?
why you don't allow to declare queues with an empty name?
Why does this method and method_name= exist? I don't see them being used.
I am running that conf (you are right, there's a typo on the file) and nvidia-smi is reporting correctly both cards (as well as nvidia-settings).
nvidia-settings works with optirun as well, and reports (as expected) different values for "OpenGL/GLX Information".
Making ProbeAllGpus false at xorg.conf.nvidia allows our new Xorg to start with the nvidia driver not conflicting with the already loaded nvidia driver, who would already have taken care of configuring both cards.
At least, that's how I managed it to work, and it wouldn't without that setting.
Maybe it would be better to include this option at runtime in bumblebee if we detect that it's a non-Optimus configuration (some flag)?
In the setting example all commas are missing.
were any other tests using this imagesetuppage? i see you replaced it with the uploadimagepage which you added here. Do we need to delete the imagesetuppage?
`hand-has-value?` oli tarkoitus toteuttaa itse. Onko Light Table tehnyt tepposet? Käyttänyt olet tätä apufunktiota aivan oikein.
No `removeAssociation` override is needed, since that is only used from node-openid's implementation of `saveAssociation`.
i think an if else would work better to avoid searching for nothing
these options should be set after foreach or you can overwrite them accidentally
No advice is given. I don't see any more details why it failed.
You're using this method again and again.... maybe should be included in a mixin... Please let me ask a more experienced developer about that.
Not, they are not needed. I will remove them.
Generally it's best to avoid trailing commas.  Sometimes a trailing comma can cause a syntax error in Ruby 1.8.
Not important, but we usually write:

```
(M, N) ndarray
```
:-( indeed. OK, i'll update

On Wed, Feb 29, 2012 at 01:05, Simon Kornblith <
reply@reply.github.com
> wrote:

> >               }
> > -//           Zotero.debug(items);
> > -             if (items.__count__) {
> > -                     // ûѡҪЩ
> > -                     items = Zotero.selectItems(items);
> > -                     if (!items) return true;
> > -
> > -                     urls = new Array();
> > -                     for (var url in items) {
> > -                             urls.push(url);
> > +
> > +             Zotero.selectItems(items, function(selectedItems) {
> > +                     if (!selectedItems) return true;
> > +
> > +                     var urls = Object.keys(selectedItems);
>
> While this would be nice, you can't use Object.keys() because we still
> have to support Firefox 3.6 :(
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zotero/translators/pull/137/files#r500231
>
Even though we have to maintain it when we add new passes (which is rare), I think it is a lot cleaner (and faster, not that it matters), to just explicitly set them to false or have a clear function to do it.
This is a tool like ant, though it happens to be also open source.   The Jetty stuff certainly doesn't belong in the main LICENSE for Cesium.  Maybe for clarity we should have a separate LICENSE.md in the proxy folder.
This needs to be cast as an int I think.
Don't know. The URLs are currently available on the staging server.
I am gonna hold off on any changes related path management for multiple platforms until the future PR regarding windows, etc support.
This may create parity with iOS and MobileWeb. Please check to make sure.
Is it actually useful to have an unbind?
Oh, I didn't see that you were passing two different values, they looked the same to me. Need to read closer, I guess. I'm going to merge this rev (5f73bae) and cherry-pick 1e74291. Any objections?
The "if $memory;" at the end of the string is pointless.
I open a PR on mheap/Silex-Assetic#6
Why? A strict equality check is not needed (overkill) here.
and here too, typo s/widht/width/
size_t at -> immutable at
This should use `format`. It's cleaner and shorter that way.
For various reasons, always leave a blank line at the end of every file.
Ah, I really didn't know what should I put there. The address comes from here https://github.com/alphagov/whitehall/blob/master/app/mailers/notifications.rb

Any suggestions how to fix this?
ここはなんで後置`if`なんでしょうか。
This shouldn't deal with the prefs directly.  Just update the `config` entry and have `SyncConfiguration.persist` write it after the sync is done, same as everything else.
why can the operation name simply cange here? (see the setter). In addition I think a simple direct string might be the option easier to read?
y not injecting the DefaultJPADAo directly?
hmm... does that hook delete listeners to the comments tab as well? the restriction only to the annotationspane which is normally the inner container of the tab is a bit odd to me. If it's part of my initial code from the hackathon, I don't remember what was the reasoning for it...
This comment is a bit off, I think. This listener is to refresh the annotations displayed on the document when an annotation is deleted _as a comment_, that is when it's deleted through the delete code for an object of type XWiki.XWikiComments, which we might think of avoiding...
Where do we typically track bugs? Code comment like this can easily get lost!
This can raise CertificateException which doesn't get handled anywhere, for ex, trying to load a cert you don't have read perms for.
I'd consider the same for users/:id/admin POST / DELETE to add & remove admin.
Early return, err... continue here please to avoid an indention level:
```js
if (downloads[i].filename !== d.fileName) {
  continue;
}
```
Fixed up in 71315fb
Maybe for now, to let the PR happen, let's add an if condition for example something like this:
```sass
@if $opacity <= 1 {
  opacity: $opacity;
} @else {
  opacity: $opacity / 100;
}
```

Should we address this "Issue" to [twitter/bootstrap](https://github.com/twitter/bootstrap)? 

Found [vwall/compass-twitter-bootstrap](https://github.com/vwall/compass-twitter-bootstrap/blob/master/stylesheets/compass_twitter_bootstrap/_mixins.scss#L367) they prefix every mixin to prevent conflicts with compass.
rats.  fixed.
@KingCrush : With you I agree
When running `renderPage` in the `editPage` function above, the placements are reset during the `insertWidgets` call, so I had to re-reset them on save here.
Does `gets` need to be tracked separately since it can be reconstructed using `hits` + `misses`? I'm not sure if reporting mechanisms can/will do this math for us though.
Well, if its the same thread, then yes I agree. But i was assuming that retry attempts are managed by a different thread then the one performing the actual task. If so the basic scheduler would do.
That is what I am doing, right?
````
if (this.contentTypeExplicitlySet){
	// override
	messageBuilder.setHeader(MessageHeaders.CONTENT_TYPE, this.contentType);
}
````
No, I got it, no need to rename. LGTM
seems like this block of code is the same in all 3 methods. May be another private method?
````
executorServices.add(executorService);
			if (this.shutdownForced) {
				executorService.shutdownNow();
			}
			else {
				executorService.shutdown();
			}
````
As I pointed out in the previous code review, it is inconsistant to encode but not decode. I think the partial fix here could be worse than the original problem.
I know it works, but it feels really weird to see assignment to a property of a variable before that variable has been defined. Could you move the definition of the constructor function up above the definitions of the methods?
Same here, please indent for 4 more spaces.
Any of these checks on $db->getErrorNum() can now be dropped because an exception is already thrown.
I think $ZSH/theme should not be replaced by $ZSH_CUSTOM
With inline-block they have gaps between unless we also force the img tags to touch, and I'd have to then explain THAT instead. (The only CSS on the images is the float:left, to force them to touch.)
Oh.
Well, I was using vim, and it was spilling over into the next line for me... So I never really realised the 80-word limit.
Well, sure, if you want to do that, I guess I can re-edit.
i think we should provide this in a template that can simply be included. its 6 css all in all that should be combined by assetic rather than those separate link. i know the sandbox has it wrong atm. i can quickly do that ok?
new pull is not required. you could just update this patch. I will merge appropriately.
yes it is standard phpunit functanality as well as **@expectedException** and etc.
Please add some comments describing what is happening here. And unless you have to, put that import at the top of the file. IIRC your last patch still had imports inside functions.
btw, I would split the sentence:

@ConvertGroup and @ConvertGroup.List can be placed on fields,  getters and method return types. In the latter case the method must either implement and interface or override a super class method.
It was not always able to launch camera again without this waiting might be 2 sec enough but 4 sec will ensure sufficiency.
Can multiple cases happen for this? Could you rearrage it into a single if/elsif statement? It seems a bit dangerous to daisy chain a bunch of if statements which all modify a variable.
Shouldn't this default to nil? Since the ternary in the template will result in true w/ ""
the only actual change is this line here
done this
Hmm, I hadn’t thought of using a `rel` attribute here…

More generally, I like the idea of navigating with links and `href` / `id` attributes. I think it makes sense and as a bonus, it plays nice with the browser history (a.k.a. the “back” button always works, though it’s not our primary concern for the Otoro). On the other side, it can be a bit trickier to use pure links/anchors and `:target` pseudo-classes than a JS-based navigation.

But being a bit old school, I much prefer using a `<button>` element than a link with no `href` (or with href="#"), even if this requires a bit more CSS. And as buttons aren’t links, the `rel` attribute doesn’t apply to button elements…

The navigation issues should probably be part of another pull request anyway (twitter-like `#!/foo` anchors might be another solution).
`transition`
Er, and we want this because the blob creation and saving-to-the-right-place logic is getting non-trivial.
Türkçe karakter girildiği zaman bu alanda sadece harf olmalı uyarısı çıkıyor, regex'i şu şekilde güncelledim hala sorun devam ediyor . [a-zA-Z\ \'\s\ö\ç\ş\ı\ğ\ü\Ö\Ç\Ş\İ\Ğ\Ü]
Yikes, and that's a slide deck from 2010! Well, good to know.. I guess they should update the docs to reflect that. 

In any case, if we know that calcdeps is not the right tool, seems like we should be defaulting the user to closurebuilder?
User-Agent is fine -- the server expects that. UserAgent is what it does not expect, which is why I have a use case for excluding the non-standard header. Unless you *are* saying that the non-standard header is compulsory, and the third party server needs to change so that we can reduce 5 lines of JavaScript to 1 line.
May want to add a `description:` and `example:` which shows how it relates to `startLayout()/stopLayout()` blocks as described above
Dont need this property documented. This is write only and the `setMedia` method is already defined above
I thought this needed to happen before instantiating the webview.
But the net result of this check is simply "Any URL that has an 'ec' querystring parameter with a value of '301' or '302'" (we don't validate the existence of a startURL value).  I'm just wondering if we should pattern check the URL, to ensure it looks more like e.g. https://login.salesforce.com/?ec=302&startURL=%2Fhome.jsp, and avoid things like https://myhost.salesforce.com/apex/MyPage?ec=302&myOtherParam=blah.
Да. Но если у тебя Event вернет объект - ничего не получится. В среду я про это расскажу.
I think we should.  We will do it as part of the API refactor in the next sprint.
Ok, nice. I see https://github.com/doctrine/doctrine2/pull/401#issuecomment-7029552 comment too. Make sense to me to do it in such way in `Tests/autoload.php` . Try to handle that today evening.
read the code! The alarm should stay on even if pressure returns to normal.
Onnistuu yksinkertaisemmin myös näin:


~~~clojure
(if x
  true
  false)
~~~