labofsahil/github-event-dataset-2012 huggingface dataset:
This ensures that the environment is configured so that keg-only deps are found by build-systems. I don't really get what you mean by "leaks in" but it sounds like you are mis-understanding how build-systems find things.
Nitpicking, but now that there are only two args might as well stick them on the same line.
Myself.  Yes, it's artifact 3532323 in the patch tracker on the GLUI SourceForge project.  There has been little activity for a couple of years there, so it may be some time before it is applied, if at all, though.
"deben ser cadenas de texto" ?
Can you provide an example of what you mean? I can't find a way to put an `else` in there that isn't misleading, given the structure of the loop.
Right, but it seems like this mixin and the BufferingTracerTests share a lot of code.  The `self.record_function` for instance can be the mock tracer passed to BufferingTracer's record function.
How are the errors handled? What happens if an invalid sid is passed?
`$ZSH_THEME` should probably be written as `"$ZSH_THEME"` to prevent any issues with weird characters and/or themes with spaces.
rename this to dagger-buildtime or dagger-compiletime or something? "Codegen" was a naming mistake that I made in the original package.
i can add "break" after the object is found.
Yes, I prefer the space before the =, but JUnit style is to leave it out.
This does not compile in Eclipse because @Override is not allowed on interface implementations.
I'm a stickler for uniform style.  I'm working on a style guide--until then, please follow the style of the surrounding code. In this case, please put a space after "if"
ah ok, good eye ;-)
mixed feelings about using this to detect whether we've set up a scroller ... this seems to assume a particular implementation of the scroller. that said, i'm not sure what a better option is.
Seems like this should expect(executed).toBe(false) instead of doing an assignment.
Does index need to be validated?
I don't see where document is used here
since you dont use many things you should not require them
returns true when all points are the same, this might be the reason of the fact that it doesn't recurse forever. I still think we might need a treshhold though, but we'll see.
fixed this line, along with mirror in new_scaling_bloom_from_file
Sorry I'm not sure where I'd need to note that. in the README.  I see that you also have a modification to this file, but I don't see a corresponding note in the README.
What exception is this catching?  Seems like it would only catch trivial data === undefined.
You must use I18n.marktr() in WellKnownName class to do the declaration of string that will be translated.
I'm assuming they are. Since you've only declared a pointer, *something* must be filling it in. Tbh, I'm not familiar with libgit2's memory model (yet), but the raise with no free is a red flag. So, I could be totally wrong. :-)

--
Aaron Patterson
http://tenderlovemaking.com/
I'm on an iPhone so I apologize for top posting.

On Jun 13, 2012, at 12:19 PM, Frederick Ros<reply@reply.github.com> wrote:

>> +
>> +  if (!NIL_P(rb_force))
>> +    force = rugged_parse_bool(rb_force);
>> +
>> +  error = git_oid_fromstr(&oid, StringValueCStr(rb_target));
>> +  rugged_exception_check(error);
>> +
>> +  git_repository_odb(&odb, repo);
>> +  error = git_odb_read_header(&length, &otype, odb, &oid);
>> +  rugged_exception_check(error);
>> +
>> +  /*
>> +   * either a commit or a tag
>> +   */
>> +  if ((otype != GIT_OBJ_COMMIT) && (otype != GIT_OBJ_TAG)) {
>> +    rb_raise(rb_eTypeError, "Target is neither a commit nor a tag");
> 
> Ok. I'm going to implement this... Didn't realize `git_repository_odb` and the likes where allocating memory. I'll have a closer look at the libgit2 APIs.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/libgit2/rugged/pull/72/files#r979057
You know that there is a race condition here?
I stand very weak here. From what I surmised you cannot extend mongoengine Documents(?). The farthest I came in this direction is to add new Class and there referenced user to mongoengine User, but then there are other issues.

Also I want to know if do you think it can be done (extending mongoengine User) or know it can be done? If you know it can be done, please give some advice, because I'm running out of resources on this matter.
In #1486, with the storycamp target, we're changing this slightly:

node make storycamp

This makes buttered-popcorn.min.js, renames it popcorn.js and puts it in dist/external/popcorn-js/popcorn.js
You're referring to the spacing? Is that just a Moz standard or are there other benefits to that spacing?
this doesn't need to be a variable. just pass the object into the call to resizable.
we should probably use our shim for this so once we add IE9 support we don't run into issues
can stack be in the following form: `num1 num2 'div' num3 num4 'div' ...`

please add: a) check and warning about this; b) double skip 'div' items.
`newObjs = [];` will look better
+1 for this solution. Works for android too.
Refactored it to not use conn_returned. 13d0d6e09404d567a8883b5eec34e7d7095698f0
major_version -> major, minor_version->minor
why do you need to def/val in a trait? if something brings code, you should put it somewhere else
what about using `concat` here instead of `+=` :smiley:
See d4c3f90 and a7ff9e1. I changed my local variables to comments, because I hate seeing arguments like `true` and having no idea what they mean. If folks don't like them I can remove them, but IMHO the added clarity is worth the slight ugliness.
I’m still not sure we can modify the stylesheet here. We want Gaia to work with 320px screen width, too.

@etiennesegonzac what do you think? Is that an reasonable CSS change? (I mean, for the whole stylesheet, not only this line)
I think you can safely remove bind here.
I _think_ this is a feature.

@philikon ?
Sadly this code won't work for the moment because bug https://bugzilla.mozilla.org/show_bug.cgi?id=731746 needs to be resolved first. You have to use settings.onsuccess = ... with all the problems coming with it. I suggest to use the SettingsListener.observe helper.
Actually, this is turning a bit tricky because of import conflict among ```utils.xml``` and ```xml.extree.ElementTree```
how about this instead:
[item for item in open("requirements.txt").read().split("\n") if item]

that way there isn't an empty string at the end of the list.
I'm sure it could, but that'd be a huge change to the core (and things like balance would be invalid for the duration of the rescan!), whereas this is a tractable UI feature addition.
Right, I see this was the original code. Never mind, let's fix this up later...
I'm not sure what you mean.
This `debug()` statement is part of the test to display validation errors generated by the model.

Please tell me how to change it to make this code meaningful to the test.
Well IntelliJ is to blame then :-)
It is defined on the MockWidget class
this one belongs at the top level, not in output
There is already unit test through the init-branch unit tests. But you're right, I will refactor all that!
This is totally private, so I don't care much what it's called.  Any suggestions?
... can be found [in the PHP manual](http://php.net/manual/en/pdo.setattribute.php)
Sorry, why are you creating a temporary directory here?
@peff - as always, you have a way of putting things that clarifies the issue! Thanks.

So, yes, now that you put it that way, I see this is essentially a micro optimization saving loading a single large object into memory when there is a loose object that is over the size threshold and averting a diff in the rare case that the binary detection fails to flag a large object as binary. Hmm.
There is  no slash at the beginning of the names and neither are they folders. They're namespaces which happen to be directories if stored as loose references (but that's an implementation detail).
If possible, use the php_url method instead of hardcoding en-US in all these places
I find negative numbers so depressing. Please can you redo everything so that everything is a positive number?
Do we need to undo this to clean up from the test? Seems like it's changing global-ish state.
hm... just curious as to why you didn't just change the args for `save()` from `no_update` to `update`?
Really good comment!
Hmm most of the lines do use it, e.g. line 88:
                 db.execute('DROP DATABASE %s' % self.databaseName,
                             ['database "%s" does not exist' % self.databaseName])
Shouldn't that be `except IndexError, x` ?
One space! :D
Won't this cause any problems with existing code that uses it?
Maybe we should add validation because the url fields needs to be unique.
this.get('product')
Yeah this calls down into native code that's Android-specific. Since the actual call itself is nested a few anonymous classes deep there's no a lot of reuse potential between the JVM implementation above.
This docblock is misplaced. It should be before the class declaration line.
``$schemes = array_flip((array) $constraint->schemes);`` would be shorter
`elseif` according to CS
style:

```scala
class AuthenticationProxy(
    underlying: ServiceFactory[Request, Result], 
    username: String, 
    password: String,
    database: Option[String]) 
  extends ServiceFactoryProxy(underlying) {
```
```ruby
raise e
```
would be more informative
Sorry for that, I have no idea! I commited a fix already
Not on the Events#new page
kolan say kon ba 2 space kar nakoni hamaro tab bezar va 4 tayi
azin be bad
farda ye dasti be saro rooye style ha mikesham ;)
@JosephPeng 好的，马上修改
Yes thank i do it
This would benefit from rewording.
Sorry, I should have made that a separate commit.

It is overlooked dead code.
Correct. 2.5 is  still supported in 2.3
In order to support the following example:

``` js
filterProperties: [['isNew', false]]
```

I think that it is as follows:

``` js
if (arguments.length === 3) {
```
Uff! We talked about this with @emuckenhuber and this sounded as best solution for the problem.
I will take a look to so how to solve this in way that will work for every use case.
left + targetWidth - elemWidth
I thought I was following it, can you explain which comments break the convention?
because of it is not needed. you can see in contacts html as they haven't got either and it works fine without hidden attrs
Just curious. Why do we have emptyList and then listFull? That does not sounds symetric naming :)
/!\ merge issue
non-newsletter mode will return at line 345
`radios[i].checked = (sound == radio.value);`

You don't need to use `? :` for returning `true` and `false`.
* why a `<form>` here? there’s no input, just a button
* why this `class="clear"`? is this a kind of `type="reset"`?
Is init at L234, after the localized event
id is a string?

message is an object?

Do you mean `parseInt(message)` or `JSON.parse(message)` here?
can we have something more generic and easy to be read like 

var listeners = [
  { 
    selector: 'mySelector', 
    handler: myFunction  
  }
]
nit, double quotes everywhere else in the HTML file
Should you just remove the ratings and shuffle buttons?

Maybe remove the repeat button too, unless you are going to use it to indicate to the user that they are in perpetual repeat mode.
why include this? it doesn't get used in this file. And the extra whitespace changes at the end could be dropped too.
I'd definitely argue that this makes oauth2 much easier to use.  An OAuth2 library like passport will give you back the tokens, and it's nice to be able to use them directly.  I'm not planning to revisit the original OAuth any time soon though - the only reason I would have needed it was for GMail, and (not realizing that I needed to have encoded the xoauth setting) I couldn't get that to work.  Now that Google has made OAuth2 available, I'm not really looking back.
best comment ever ;)
Added reason for test not being run.
Hooray for tests. Maybe add a readme type file in tests/ describing our testing strategy and how to run them, etc.?
I think it would be handy to set `:authenticate => false`, too. I've discussed an internal use case where I'd like to configure a token at the module level but make a one-off unauthenticated call.

I think we could go ahead and remove `:version` as an option, expose `:raw`, `:authenticate`, and `:media_type` and use this style to grab them:

```ruby
options[:octokit][:media_type] = options.delete(:media_type)
```
no reason, changed to itervalues in c5cc4a33424e1e97ff0f245b5475dbfc9cb7c973.
I put in `Ormigo\Model\BaseObject`, the default value is `propel.om.BaseObject`.
Don't forget they have to run pulp-manage-db to install the types and bounce the server to pick up the changes.
Given that this method is called twice for each example, it concerns me that it re-checks the condition every single time, when the list of signals supported by a particular host computer is never going to change between examples.

I'd prefer to see the signal list checked once, at startup time, and the signal/message values stored, then re-used for each example.
「」いらず
prefix with edts-debug-, use two dashes (--) if the function is private to the package, eg. edts-debug--handle-state
Can you add a TODO that we should fix ```Mappable```?
Can we check this? Would Manifest magic help here?
мелкая мелочь. Этот метод не айдишник же ищет, а event. Так пусть тогда его зовут find_event
It is using the asset pipeline, it's just using `frontend.js` as its main manifest instead of `application.js`
Yeah, I can use it, but it seems I can't run ./utils/run_pylint.py for a specifying .py file, it's not flexible for me. thanks.
Yea `list_to_existing_atom` would probably be the right thing.  I plan to refactor the query engine to realize this stuff one time up-front so I'll keep this in the back of my head.
Yeah, probably :(
I think this moves too much of the logic of `Trigger` into `Triggerable`. I'm not entirely convinced that any of the logic needs to move to `Triggerable`, but I understand that if `Triggerable` is to honor `self.codebases`, then some logic needs to move.

Even in that case, it would probably make more sense to just pass the list of source stamps, and still have `Trigger` figure out which sourcestamps to pass.
A few comments (beyond the fact that monolog has no bugs;): 

- Please use 1.0.x-dev as alias, I think it's better because then if it's required as non-root package, chances are likely it'll at least match a branch, if you require 1.0-dev it parses as 1.0.0.0-dev and you'll most likely not be able to install.
- The real necessity here is to alias to something that matches a constraint of one of your dependencies that also requires monolog, if you just require monolog, it's kinda pointless to alias since whatever you require will be installed. I think this could be made a bit more clear.
this test is not valid, you need to add:
new WebDriverWait(d, 5).until(ExpectedConditions.titleContains(strToSearchFor));

when you do, it then works.
should include "index" in the error
Are you sure that it's null-terminated string?
@ariejan is it ok?
at one point, you're using `ipi`, and for this function, you're using `IPI`.  If we choose one, lets just make them all lower-case
Actually I'm talking bollocks, misread that code. I think it's down to the fact that we set the link's `href` with JS once initialised but we should be able to do this in the template. Will look at now.
should we set ring_buf to NULL here?
this assumes the field is an array, which isn't true all the time.

Also it only works on "fields" try just event[fieldname] instead of event.fields[fieldname]. The former lets you access top-level things like @source_host or other goodness.
Both. I would love a better name. activeValue and inactiveValue?
Still nothing, bug 748086.
can we remove the require('metrics') line at the top of this file now?
As talked on irc, will leave this check as is.
Do you need to eval a string here for this?  I would think you could just do `object_singleton_class.send(:remove_method, @method_name)`.

In general, I try to avoid eval'ing string unless it's really needed.
it make twice error in form when setDate is passed to form
See above. This is why all constructors throughout the framework are documented with "@return void".
`la "location" appendendo` -> `l'indirizzo aggiungendo`
I think that is better if `->format` share the line with `return`. IMHO is more readable since I don't expect find more lines after the return
For consistency, since this is for a boolean type, just name it "allowNonSepa()".
Lines 610 and 611 -- please change tabs to 4 spaces.
Same comment as for filters -- add a break after line 182, and then you can drop the else statement.
Fiiine. Protect users' settings, see how I care.
need to define ether user uppercase first symbol for `bundles` or lovercase, compare with lines 27, 55, 63
I am not entirely sure why that piece of code disables auto-migrations, but I'd rather not change it. That said something does kick off migration. @half-ogre  \ @jeffhandley  might have a better understanding of how that works.
but populate is also missing

/Users/mjobin/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require': no such file to load -- facets/kernel/populate (LoadError)
	from /Users/mjobin/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
	from /Users/mjobin/.rvm/gems/ruby-1.9.2-p290@imedidata/gems/unroller-1.0.0/lib/unroller.rb:5:in `<top (required)>'
I think this may not work in the edge case where a historical, deleted tree associated with a plot had one of the specified pests, but the current tree does not. This may be a larger problem with all the filters. If it is, it should be moved to an issue and not block this merge.
I am aware of this. I'd first working on have a stable patch then we can optimize into better strategies.
shouldn't it return a *list* of generators?
_combine support value=None; is this similar?
value=None will have implications on all derived classes
Two empty lines before class definition
Doesn't need to be _lazy because it's called after import-time. Assuming it is, in fact, called after import time. Same reason `subject = _('Become a Mozillian')` doesn't have to be lazy.
The __ lookup only works for list_filter unfortunately. I'll change the ordering and submit a new pull. Thanks!
an here
expect の中に直接入れるには post 結構重い気はする
oh, so the jquery matcher was simply wrong?
I think this should be -min-moz...
I added this method to avoid clients from being aware that if the platform is nil they should look for ```:ios``` and ```:osx```.
Does pulling this out blow anything up?
I still think this needs to stay at -8px or else there is a weird ghost border near the top of the card.
@ehelms You are right.
Whoops, forgot to change Vim's JS indentation rules to our new style. Glad this file is now conforming to our new JS guidelines too.

Yeah, agree that '(s)' is a little awkward, fixed.
Is the purpose of this to always return `false` for the given?
I dunno, it just seems a bit confusing especially if the sentence is not in a direct if-then form.
more foo here please
typo: ``archivedLogFilenamePatter``
cs (missing whitespace and missing new line between blocks)
прелестно. лучше не придумаешь просто. Радуйтесь все, кто заинклудил
что такое notPath?
за V^2 * E --- это сильно...
при вложенных namespace не делают отступы
тут нужно нормальный интерфейс сделать.
but why...it seems it doesn't work here. Wow, my math was bad last saturday!
Can you point me to the documentation for this?  I'm having some difficulty making it work with your recommended changes.
I couldn't use the gecko and ie_lt9 variables here since they're in a different scope.
isnt this duplicate of line [1858](https://github.com/mikea-imh/silex-imh/pull/32/files#L0R1858)
Oh ok cool, please can you change anything according to your guys' conventions, and I'll stick with them in future
Assuming modules will call this in their require statements which get executed at server startup:
I think we should complain pretty loud at this point if the moduleId isn't specified. Otherwise an undefined function `getValue` would be thrown when trying to execute `error.getValue`  somewhere at runtime.
Be sure to also unit test this function appropriately
You forgot your top line here.
Should be folded into config testing
Is using `Content` valid since it's not a type?
We don't use SVN anymore; we use Git and Github.
Выбор последнего объекта при count == DNA_CAPACITY будет занимать несколько сот проходов этого цикла и (теоретически)  может никогда не произойти.
тоже не самое удачное решение с циклом для получения случайного числа, отличного от имеющегося. проще было бы сделать так: new_letter = rand()%(letterLast - 1); new_letter = new_letter == [letter intValue] ? (new_letter + 1) % letterLast : new_letter;
Согласен - изменю
Is it necessary that the polling transport reports what sequence id it's flushed? If you think about it, the `Socket` should know this, as the polling buffer won't keep growing, the `writeBuffer` at the socket level will.
Just a nit, but I'm sure there's a better name for this variable. timestammps_list1 is a bit constructed :)
Sure, though I thought that class was going away soon-ish?
Alright. I think the comment should be updated to reflect that, then, because that's the real purpose of this method.
There are quite a few of these where the description for keys is removed. IMHO it might be good to keep these somehow. Either as they are (with the config vars) or in the Notes section.
```ruby
g.should_not be_valid
I think this test would pass on a typical Linux machine (or anything else using `UTF-8` by default) without the source code change, meaning when run on `ci.jenkins-ci.org` or the like it would not defend against regressions. To make it a stronger test you would need to call e.g. `System.setProperty("file.encoding", "ISO-8859-1")` very early in test VM startup, perhaps in a `static` block; or even pass this system property in Surefire configuration to make sure it is set from the start.
Could you please give me some more context about this?
When would this check be required?
right, thanks!

On 05.12.2012, at 21:55, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/epochs.py:
> 
> > @@ -159,10 +165,15 @@ def __init__(self, raw, events, event_id, tmin, tmax, baseline=(None, 0),
> >  
> >          self.raw = raw
> >          self.verbose = raw.verbose if verbose is None else verbose
> > -        self.event_id = event_id
> > +        self.name = name
> > +        if isinstance(event_id, dict):
> > +            if not all([isinstance(v, int) for v in event_id.values()]):
> > +                raise ValueError('Events must be of type integer')
> checks also that keys are strings otherwise it will conflict with the getattr that are integers or a slice used to select some epochs
> 
> —
> Reply to this email directly or view it on GitHub.
>
Hehe thanks, I like `mock.patch` too.
Yes it worked for me too. :)
i think apply is a little strange as a  method name if actually it just returns the concept for the name, how about getConcept
The tests are passing by accident. Add a new test that inherits from the Admin model and changes the value of confirmable_attribute and you will see the change won't propagate.
I need to do more number crunching but the large approximate error of this may be due to small sample sizes. Any thoughts on how to improve testing?
I prefer, it is not the standard yet, to break this into multiple lines to avoid horizontal scrolling:

    <service id="..."
        class="..."
    >
php cs fixer was used
It's not your foult, but can you please remove the space around the dot operator?
It is actually better *without* the comma - it's just one straight thought, similar to `I got to the hotel using a taxi`.

But, the vast majority of what you had here is perfect.

Cheers!
same here:

     ->register(
        '...',
        '...'
    )
well I guess because it's used as a prefix for attribute names like "User[username]" where User is the model class
Because 'newMemberSet' is a Set but I need it to be a SortedSet. See the comment about bug in Scala. There is no CanBuildFrom for SortedSet.
command name is already accessable view `$event->sender->name` so it would be redundant.
If you name the file "settings.py" instead off "openslidessettings.py", python has to import it with "import settings.py". So we have to assure, that our settings.py is the first one on the pythonpath.

An alternative solution would be to putt the settings in another directory "openslides", in this case we could use "import openslides.settings" which should be well-defined.
Do we have urls for the prerequisites above? Please include them.
`addr` parameter is missing
This is already done in the Twig Service Provider
Don't use magic constants. Always define named constants for menu entries if you like to reference them this way.
(and again for 0.2.4 as well)
`spread` and `blur` are different things. I think everyone supports blur, am I wrong? The issue with IE, as I understood, is that they are adding spread. So we would need to output one more variable than we have been, not one less.
Just use =default now that we're C++11 only anyway.
Deleting a FreshInstance in this case is a desperate move, as we created one just moments ago as a handle on an existing but damaged instance that we need to delete right now. As such, there's no guarantees, but it can't hurt to try.
That is the default marshaller for the HotRod client
You also need to read all the LockSupportStore and AbstractStore configuration
what about backwards compatibility and live/rolling updates in the future. Would it not be better to swallow this problem and log a warning instead?
I guess it would be nice to "force" a migration by disabling such a check
I tried switching to 1.2 but it didn't work. I've created a new bug to cover updating the HR test client: https://issues.jboss.org/browse/ISPN-2670
this file is used in the testsuite.

the reason why the testsuite is still passing is because the expectation is not specific enough. It expects that a ``Twig_Error`` is thrown, but the missing template now triggers a ``Twig_Error_Loader`` whereas we were testing that the AsseticNode was triggering a ``Twig_Error_Syntax`` properly.
I kind of feel like `weak` is a justifiable argument, but I'm fine not doing it yet.
@mdboom: Would you know what these (```get_patch_transform``` and ```get_data_transform```) are for? I would like to get a one liner for their purpose.
After we do the action, phone still needs a little time to really do the action.
For example, after create alarm, the phone has to wait few seconds then new alarm can show on the screen.
Deleting alarm and turning on/off alarm are the same.
Initially I wasn't sure how the user should indicate,
that she's finished adding tags, I thought `^D` was a good option.

In the end I saw that an "empty" tag serves just as well as an
"I'm done with adding tags" indicator.

So the above code are odd ends, that could be removed.
I've seen the above `if` structure recur for at least 3 times now, can we make it into a consolidated function?
if (..)
with space
Hey Ingo, 

I wasn't able to get the customizations out entirely. It's not even possible, since the file is already somehow customized with the .cms prefix. I put the "old" contextmenu styles outside the .cms {} and put mine inside.

I cannot see any other method, except for adding a custom class with javascript to the contextmenu. However, i didn't find a hook for it in the contextmenu source, so i went with this. 

If you know of anything better, i'd be glad to hear it :)
Probably can be, yeah.
Why do we need to include any changes to the upload field in this PR?
Yep, use curly braces always
It is correct to set `first_id` here.  As above for `page->modify`.
I think I can get rid of the `rendering` var here and just check `children.push(f) == 1` .. would also protect against a race cond.
Are you sure you want to override the parameter ``$dataField``? This often makes code less readable.
- Are you sure the variable ``$fields`` exists, or did you maybe mean ``$field``?
- Please always use braces to surround the code block of IF statements.
Don't keep commented out code.

Ideally the changes you make should all be in blackberry specific code paths, so they don't affect the other platforms and when the blackberry implementation is fixed, we only have to delete the BB specific portion.

This applies for the use of data[e.index] instead of e.rowData also.  I believe they don't want their main sample application to be using this less direct construction.  Please isolate it to BB only.
Remove this bracket.
I still think we should provide a simple, easy interface for plugins to do things when you join a server or start a server. Of course they can manipulate the events of objects, but still.

http://www.ganggarrison.com/forums/index.php?topic=31977.msg1087221#msg1087221
Seems like:

```php
<?php
if (isset(self::$_parentTokens[$token['id']])) {
    return false;
}
```

would be a pretty obvious win.
Cool beans! Part of my slowdown with this project is figuring out ReST, which is a language until itself. Good to know.
Would you make this mixed please. Also please spell out integer and boolean.
Considering one of your previous comments I think this would be a good compromise:

``` js
return result.replace(/(top|right|bottom|left)/g, function(position){ return namedPosition[position]; }) || '0px';
```

Now only the named positions are replaced with their respective percentage values.
<h1>{{ _("That's a "
             "wrap!") }}</h1>

C'mon. Do it.
type_match ?
I also tried defining the method as "response=nil" but that also doesn't seem to behave correctly
Understood.  If the test requires the use of `bedType`, we should add `supplierType: 'E'` to the search parameters... this way we expect the results to have bedTypes.

>[Note that bed types are not returned on Agency availabilities but are typically present in the room description. ](http://developer.ean.com/docs/launch_requirements/Agency_Hotels#roomratedescriptions)
Please use infix notation. Also, please use a speaking name, i.e. instead of `lf` use `folder` or `linkedFolder`.
I am not saying that you are lying. I am saying that also I don't know what is happening. ;-)

What does `git log` says about the file? When it was last time changed? Can you checkout that version of the file? Where have you copied current version from? How do you copy it? Maybe close your IDE. ;-)
This code is strange. ;-)

You could do all this in one pass. You know that similar stations are close together. So you can use this property and simply compare it with previous. And if new one is newer, you use new one, otherwise you keep as best found match the previous one. It is like searching for max number in an array. Just that you do that for subruns of numbers.

So:

```
if not stations_nearby_all:
    return
newest_station = stations_nearby_all[0]
for station in stations_nearby_all[1:]:
    if station.station_id != newest.station_id:
        set_possible_old_flag(newest_station)
        yield newest_station
        newest_station = station
    elif station is newer than newest station:
        newest_station = station
set_possible_old_flag(newest_station)
yield newest_station
```
I would everywhere remove S from locations in LocationsForm and others.
no idea, probably something with auto pushing and deleting text from textarea.

ive just removed it
`key` -> name it better. `panel` is a good candidate. :-) `panel_name` maybe, too.
Indentation. Indent once.
Because I want it to be in special div alongside with button.
What do 0 and 1 mean here?
Can all of the uploaded files be added in a hook implementation instead of here?
nop, ill check it
Does the line 56 (stores:MemberStore) actually don't do the job (updating the store)?
I didn't see the template referenced in any of the recipes.  Looked like a rogue file.
double quotes here, please.
That makes sense; in that case how would feel about not making <code>SignIn():</code> a subclass and simply treating the methods therein as part of the <code>class Bid():</code>? I know this would add work and force a refactor of other components of this pull but I'd feel more confortable if we nailed out a clean api for <class>class Bid():</code>.

Unless I'm missing something clever that you're doing (which could be the case ;-) ) I think creating this subclass just add complexity and potential for confusion.
I assume that tryGetValue returns the default value specified as third parameter. If this is not the case, you're in trouble, and non-null $callback values will be overwritten here.
`display: block` in conjunction with `border-collapse: collapse;` makes limited sense?
I think this is meant to be attribute `node['mysql']['client']['packages']`?
I saw it as useless since it is used only once. Consider it overlzealous code optimization. I will revert it if needed.
I opened an issue for langmore/statsmodels and assigned myself to it.
using sqrt would be more readable I think. And,I guess, computationally more efficient which might not matter in this case.
Do we need to add the HCID prefix?  Or do we want to just record whatever value is available in the message?
Is this class a straight copy/paste from direct?  Or did we modify it?

If we have modified it, I would prefer to see the direct copyright/license moved into a top-level file called "LICENSE-DIRECT.txt" with the content from them.  Then our license file can say something like "portions of code modified from NHIN Direct Project.  See LICENSE-DIRECT.txt."
have you rewritten the route in FLASK to do this - otherwise needs to stay in /static/ - thats a always there route in flask along with tempaltes/
Can't we just bind to the model's "error" event?  I think the `check` stuff get passed to it.


http://documentcloud.github.com/backbone/#Model-validate
`_gamma`
Unused imports Course, AnonymousUser, Institution, Group. :)
this seems an odd syntax -- would   byon:hosts="1.1.1.1,1.1.1.2",name="myname"  be better?  that's not actually very nice, hmmm
and is byon confusing with jclouds:byon which ofc is different?  (i think i like it but let me think about it.)

maybe take it like this but mark it experimental / subject to change?
I understand. It should change to cocoa.id.
Looks like you missed this port.
Is this a new test?
OK, I'd like to know what it broke then. If it is a bug, then we should fix it in the other SDKs as well for 1.0.
i added the command to do this, can you please remove the submodule again?
however i think we should add Resources/public/vendor/hallo to .gitignore
So that the dashboard user can discern categories when adding a new one. 
And so that we enable the projects based on oscar to use category slugs in urls.
add method getText() to DataCell.java IF DataCell is changed to NOT extending a JTextComponent.
Hm, any reason you can't use m_weakSelf here?
```javascript
myNew(A, [1, 2, 3]); // Не будет выглядеть как new A(1, 2, 3); -- new A([1, 2, 3])
myNew("Im Hacker!"); // TypeError выброшен быть должен
```
There are a lot of different ways to do this: the application can handle datagramming, we can add a new layer between the session and application, etc. My preference is to make as minimalistic of an API as possible inside of the session. If we need a full-fledged datagramming stack, we can add it in a separate layer.
Unfortunately not, $string instanceof Type does not work
```
$ php -r '$c = "DateTime"; var_dump($c instanceof DateTime);'
bool(false)
```
One for mobs, one for objects. In every single test round I've observed, someone has always tried to scan crystals and strange rocks, and I guess it's only a matter of time until they try scanning other things.
Might be nice to set affected.amputated = 1 here, so if nothing is attached, at least the pain will stop.
I only did this becaue "connect" was getting confused by the compiler with the signal slot "connect".
license header :)
Does a trimsplit on an empty string not generate an array with one option (the empty string)?
We prefer to set the path for the default `Exec` resource globally.
Hm, if you're concerned about it being closely-related to the regex in [here](https://github.com/rstacruz/better_errors/commit/691b7ced9c96145f8ae47ace3199be7d2032f129), I think we just be adding too much complexity just for the sake of DRYness. A better-designed pattern may be to make an exception presenter so we can make our own helpers related to exceptions (like `exception.syntax?`, `exception.filename`, `exception.line`...)—but I think that may be overkill for now.
Ja aber ich meine die FaxAnalyse braucht n paar sekunden, Google braucht n paar sekunden und wenn ich jezad ma im Funkloch hock und das dann noch ma 1 2 sekunden später mit bekomme dann is das besser als nix ...
Dann schau dir mal Firemergency + aPager an ist das komplettpaket mit allem sums was dazu gehört ...

ja is recht^^
why would this be needed.... md4 is never used anywhere
Исправил но получился следующий топографический косяк:
if (typeof gps !== "undefined"  && 
    typeof gps.x !== "undefined" && 
    typeof gps.y !== "undefined" && 
    typeof name === "string") {
    alert();
   bigbigbigbigbigbigbigbigbigbigbigbigbig;
}
- на мой взгляд выглядеть стало не на много лучше.
Обычно я такие большие условия выношу в отдельные функции. Но в js как то не рекомендуется это делать или лучше в функции выносить?
Оберни весь модуль в IIFE и тогда придется написать `"use strict";` 1 раз.
I would take it out then.
Правильнее, в качестве сообщения писать что-то своё (поскольку сообщение будет в стек-трейсе). Например, ```throw new RuntimeException("An exception occurred within serialization of " + clazz, t)```
У тебя в случае extendedMode не выравниваются параметры.
Здесь закрывается System.out?
Вообще, если на вход приходит стрим - обязанность на корректное закрытие стрима ложится на вызывающий код.
Есть метод ```TimeZone.getAvailableIDs()```
Because there *is* a possibility for floating point precision errors, I do rejection sampling and generate a new point if it is not in the distance range. This is messy business, and is possibly a sign of a bad model. The problem is that the borders between the regions in the game are zero-width, and so a rounding error that causes a point to be placed at (0,19.99999999997) instead of (0,20) could end up in a completely different region.
I'm using job and occupation or profession interchangeably here for the sake of brevity and simpler language, and I don't think it's misleading, especially given the further explanation on the page.
Total yuck. I'm on the fence about whether to make this suck less or not.
I think we shouldn't include hints if Foundation doesn't support it by default.
Really minor: maybe `r_scale`/`c_scale` or `row_scale`/`col_scale` instead. (more readable in my opinion)
Is it a numpy convention? In English, I thinks that there is no space before ":".
``%s/leafs/leaves/g``
Wait, the person now is an instance of `Room`? :)
That's worth a comment or an output validating unit test.
This function doesn't seem necessary.
Can't set this value (creation only)
Why do I feel someone was using vim...
Which tag ? is there a dedicated tag for pro tipping ? O_o

2012/10/12 Sanne Grinovero <notifications@github.com>

> In
> hibernate-search-documentation/src/main/docbook/en-US/modules/spatial.xml:
>
> > @@ -260,6 +260,12 @@ List results = hibQuery.list();</programlisting>
> >      </example>
> >
> >      <para>Sample code is at SpatialIndexingTest.testSpatialAnnotationOnClassLevel() and in Hotel class.</para>
> > +
> > +    <para>Pro Tip : For advanced usage, there is a Coordinates interface that can be used to pass latitude
>
> you could use the tag if you want to. Up to you, make sure to render it to
> see how it feels.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hibernate/hibernate-search/pull/332/files#r1831059>.
>
>
"Like" ?
I think would have been clearer as 

```
   if ((left->getOperator() == no_null) && (right->getOperator() == no_null))
    return recordTypesMatch(left, right);
   else
     return false;
```
This may requires some more thought.  hthor became unresponsive when allocators were added for each time round an iteration loop - I suspect thor already reuses them in this situation.

Also, when the allocators are destroyed (e.g., subgraph finishes?) then they should be removed from this list.  Otherwise the roxie memory manager still has them on a list of active heaps.  The main problem with that is it leads to O(N^2) time when they are finally destroyed.

You also want to consider using packed allocators in thor - though whether to use it may depend on the number and likely lifetime of the rows.
Minor nit picking:  Slightly strange using a StringBuffer to build up a string, and then using %s to quote it.

You could say

````
        ActPrintLog("HASHAGGREGATE: Table before after distribution contains %"I64F"d entries", localAggTable->elementCount()));
````
instead.
Perhaps look at 
https://github.com/mozilla/socorro-crashstats/blob/master/crashstats/crashstats/models.py#L164
for some ideas here. 

* takes care of `datetime.date` and `datetime.datetime` instances
* is able to handle UTF characters

Also, I don't think you should ever create a query string manually. The right tool is this:

```python
>>> import urllib
>>> data = {'a': ['1','2'], 'b': 123}
>>> urllib.urlencode(data, True)
'a=1&a=2&b=123'
```
Oui pourquoi pas, c'est vrai que c'est un gros travail. Après une recherche sur " !", " ?" et " :" **devrait** suffire.
I'd suggest to define `USER_SHEET` constant at the top of the file, which makes it easier to read.
from https://github.com/Inori/InoriTwitterAppBundle
Actually I used notepad++, and I didnt change the settings there. OK.  Will try to rectify it in new update.
!= true == false
similar comments as above in this method
I would love comments in downcase and just one # in functions, seems like the general style over msf code.
Maybe this and the previous instance of `ref_white` can be moved to the module level and be renamed `lab_ref_white`?
It's not indented enough
You can extract this inner function out to a local private scope as well, so we don't recreate a new function every time when we don't have to.
We don't need to setup an inner path here since it won't be used. We use clipRect() in our draw method.
We should test and see what the other platforms do. If they support it, then so should we. If they don't, then we shouldn't either. I think the latter is the better option ideally, but we do need to document it because the documentation implies that the dev can set these values after show is called.
If the idea is to pad the text, why would you need to change the bounds of the backgroundView?.
Can you put a ; after )
The proper way to do that would be to define a function in this file that allows to register a hook and then call all registered hooks at this point in the code. We can change that later. For the moment, I'd say leave it as is.
I bulleted it because it's a testable assertion. But np. Will unbullet.
I think the user should have an option to extend ````Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand```` otherwise it should default to  ````Symfony\Component\Console\Command\Command````
А так и есть, просто текст ошибки неправильный.
I'm going to move these commits into a separate pull request
No, I have no idea why that happened :P I don't think it's in the latest commit (6633557)
Honestly, I would think that it would be a bug for an output range to be a value type. By their very nature, they need to be passed to functions and be altered by those functions in a manner which affects the original. So, I don't think that the `ref` should be necessary. If it is, then we need to fix it so that it isn't (e.g. by fixing `Appender` if it requires it for some reason).
The logic is the same, however, enforcing _last, and then asserting _first: That makes more sense. Might as well keep the version that makes sense.
The fact that it uses reference semantics must be emphasize and discussed with examples. Documentation should also mention that this semantics is different from all other types in this module.
copy() should work here
Remove autogen. attribution, please.
I can merge this in when John commits, just trying out the format and workflow.

Changed to including the issue number.
This isn't formatted properly. Can you reformat the file with a 4 space indent?
Add a note to this Javadoc that the response can thus cross domains (server clock to local clock), which is a Bad Thing®.
I can try BGRA again -- but in my testing I remember clearly having to go with ARGB. 

I think YUV is actually better but the manual conversion process is too since we aren't uploading directly to texture but need pixel level access. this was the best simplicity/efficiency trade off.
As long as it does not leak from compojure-rest it is ok for now.
This is mainly driven by what applies on my comment with regards `5.3.2` ;). I still don't feel strongly on dropping this all together.
Let me piece the logic of this back together. There was a spot I came to where it was critical to determine if the Authz's ID was equals to ADMINISTRATORS_GROUP. It seemed illogical to make this check if the Authz is *not* a group, so I promoted the method and shielded it with an isGroup() call.
This step is somewhat confusing, and seems to me that it might end up performing excessive code gymnastics to get the test to work.

How about using a table to set up the initial registrations? This particular scenario could then be implemented in a separate feature file with its own table that has no registrations "today". To get the effect of setting the day, you could stub `Time.now` and make it return a particular time.
Uff let's not add more design-by-contract. Programmer error is programmer error - better to add tests, they are also documentation
why do you use `by referance` for the last param?
generell möglich, vllt. findet sich auch einfach eine auf allen Computern bereits vorhandene Datei?

(EN: maybe there's a file already present on all PCs which could be used instead?)
It seems like an incorrect change to the two submodules crept into your branch. When you merge from master, it doesn't automatically update the submodules, so the submodule shows up as an uncommitted change. It appears you committed that change, when you should have done a "git submodule update" instead.
Can't we replace this line with:

`columns += left`

Or am I missing something?
Changing the signature would break all kinds of code.
You could do the same tricks as suggested for rt_init.
making sure the current query string of a date is formatted nicely. So no [2011-01-01T00%3A00%3A00Z TO 2012-01-01T00%3A00%3A00Z] as value, but 2011 - 2012.
This bean was added by me in the my last mentioned PR.
It is used in the JpaOutboundChannelAdapterTests
I think you've removed it accidentally ;-)
sorry, i missed the fact that it was no identityHashCode and not IdentityHexString. Changed
Not necessary - always assigned true/false below.
77c72771e
It is fairly standard to numerically encode unicode, it is easier for customer to trouble shooting their problems when all the unicode are encoded numerically.
Isn't it idented ? (red means removed :))
Is that '8' a typo?
Prepend command with php for consistency

$ php ./composer.phar update Trsteel/ckeditor-bundle
I dont think you wanted this to change right?
yes - typo
It allows to avoid repeating the code that:
1. gets the object name
2. injects it in the translation
3. sets the flash message in session

Did I miss some on-liner that would do the same thing?
make this an abstract method.  also, make ageGroup a property on the class with a getter and setter -- we can set it before calling eligible()
(synapse.version should not point to develop-SNAPSHOT)
Should we do a `toLowerCase()` call prior to checking the value? Incase the user enters `Dark` etc.
$HOME/nova_locks
Because working dir could be something completely different.