Add *explicit* keyword to constructors in WebCore/accessibility
https://bugs.webkit.org/show_bug.cgi?id=93067

Reviewed by Kentaro Hara.

As a step to add *explicit* keyword to constructors which have a parameter,
*explicit* keyword is added to Source/WebCore/accessibility in order to avoid
implicit type conversion.

No new tests. Covered by existing tests.

* accessibility/AXObjectCache.h:
(AXObjectCache):
* accessibility/AccessibilityARIAGrid.h:
(AccessibilityARIAGrid):
* accessibility/AccessibilityARIAGridCell.h:
(AccessibilityARIAGridCell):
* accessibility/AccessibilityARIAGridRow.h:
(AccessibilityARIAGridRow):
* accessibility/AccessibilityList.h:
(AccessibilityList):
* accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
* accessibility/AccessibilityMediaControls.h:
(AccessibilityMediaControl):
(AccessibilityMediaTimeline):
(AccessibilityMediaControlsContainer):
(AccessibilityMediaTimeDisplay):
* accessibility/AccessibilityMenuList.h:
(AccessibilityMenuList):
* accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
* accessibility/AccessibilityProgressIndicator.h:
(AccessibilityProgressIndicator):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilityScrollView.h:
(AccessibilityScrollView):
* accessibility/AccessibilityScrollbar.h:
(AccessibilityScrollbar):
* accessibility/AccessibilitySlider.h:
(AccessibilitySlider):
* accessibility/AccessibilityTable.h:
(AccessibilityTable):
* accessibility/AccessibilityTableCell.h:
(AccessibilityTableCell):
* accessibility/AccessibilityTableRow.h:
(AccessibilityTableRow):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
V8Proxy::retrieve(*) leads to really obfuscated code and should be removed
https://bugs.webkit.org/show_bug.cgi?id=93072

Reviewed by Eric Seidel.

Source/WebCore:

Once upon a time, V8Proxy::retrieve did a bunch of checks before
returning the V8Proxy object (such as checking whether script was
enabled). Over time, we've removed all of these checks in order to fix
various bugs. Now all it does is check whether the Frame is 0. However,
because the function ends up returning 0 when its argument is 0, the
caller sill needs to have a null check.

This patch deletes all the variations of V8Proxy::retrieve(*) and
inlines them into their callers. In several cases, inlining the
function call showed that we were testing the Frame for 0 twice, and
I've removed the redundant null checks. In other cases, I've
uncontorted the callers to make the code more readable.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
* bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* bindings/v8/ScriptController.h:
(WebCore::ScriptController::windowShell):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/V8EventListener.cpp:
(WebCore::V8EventListener::callListenerFunction):
* bindings/v8/V8Helpers.cpp:
(WebCore::toV8Proxy):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::callListenerFunction):
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::V8Proxy::retrievePerContextData):
(WebCore::V8Proxy::mainWorldContext):
(WebCore::toV8Context):
* bindings/v8/V8Proxy.h:
(V8Proxy):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
(WebCore::toV8):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):

Source/WebKit/chromium:

* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::didCreateScriptContext):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Make textModel private to textEditor
https://bugs.webkit.org/show_bug.cgi?id=92999

Patch by Jan Keromnes <janx@linux.com> on 2012-08-03
Reviewed by Pavel Feldman.

Source/WebCore:

Making textModel private to the textEditor ensures that it is accessed
only through the textEditor, making the latter more modular.

Tests were changed accordingly.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._lineNumberAfterEditing):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.replaceAllWith):
(WebInspector.SourceFrame.prototype._collectRegexMatches):
(WebInspector.SourceFrame.prototype.addMessageToSource):
(WebInspector.SourceFrame.prototype.removeMessageFromSource):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.commitEditing):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.setText):
(WebInspector.TextEditor.prototype.text):
(WebInspector.TextEditor.prototype.range):
(WebInspector.TextEditor.prototype.line):
(WebInspector.TextEditor.prototype.get linesCount):
(WebInspector.TextEditor.prototype.setAttribute):
(WebInspector.TextEditor.prototype.getAttribute):
(WebInspector.TextEditor.prototype.removeAttribute):
* inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype.afterTextChanged):

LayoutTests:

Tests no longer access textModel directly from sourceFrame.

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* http/tests/inspector/live-edit-test.js:
(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):
* inspector/debugger/pause-in-inline-script.html:
* inspector/debugger/script-formatter.html:
* inspector/debugger/source-url-comment.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening, adding text failure expectations for 20 MathML
Presentation tests that started failing after r124512.

* platform/gtk/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124585 268f45cc-cd09-0410-ab3c-d52691b4dbfc