labofsahil/github-event-dataset-2012 huggingface dataset:
Fixed it!

Turns out I had to install the openssl-ruby package for ubuntu/debian and then recompile ruby. Luckily this was pretty simple thanks to using rvm with the rvm reinstall command.

Here's a link to the fix in case any other/future mentees have the same problem: http://www.ruby-forum.com/topic/90083
you should look at your .gitignore file and add the autogenerated folders to it like bin.  It makes it easier to read commits
OK, I will stick to the new naming then.
This is confusing me, you have method-level constraints but these are not constraints applied on a given parameter? So this is to support cross parameter validation in the future?
I don't understand why the property path is considered complete in that case.
Ah foi mal. interpretei errado. Acho que o seria então have_at_least(1).items (porém ele considera que nil é um item). whatever, o que o camata disse já resolve.
Question: will this break existing launch direction signs I fixed some weeks ago?
(backward compatibility with pre-existing signs)
This part of the code looks weird:
bearing + 180 + 360 = bearing + 440 ?
Genial! Esto era algo necesario!
Why not use a Map<Command,String>? You already use a Map<Command,Property> to associate the CSS style property to a command. Why can't you do the same for the property value?..
I know, still need to update other changes.
Your sources really helped me a lot!
cant use compiled FileManager.apk with ics source..
parsing error.
This appears to me to be presentation logic specifically for the HTML output format. Which parts do you think should go into the model?
Need to revert quite a bit of this... too many silly changes by over zealous use of grep > sed
Yes, `local_checkout` does work, it just introduces nondeterministic behavior in the tests (because sometimes they actually get the repo from the network, and sometimes they use a locally-cached version), which makes it hard to get reliably stable test results. So I'm trying to avoid use of it in new tests in favor of having everything local whenever possible.
Same thing here, declare variables at the beginning of the containing function.
I've further updated the list, and identified some that are only available to jobs or services.  Technically this list is incomplete, but I believe this documents any useful properties on these objects.
I can turn off the initialization. I needed to change to forName otherwise [B does not resolve (loadClass failed)
yes, that contains strictly more information. I'd like to use FiniteDuration more in method signatures which expect finite durations …
Great. It's one of those things that could just silently break
false == Directive.Resume?
Why Object?
ah, okay. Just wanted to know the reason and whether there should be a FIXME in there somewhere …
0.8 == 80% in this case. we use random.nextDouble
I suppose it doesn't matter as much for this project, and at this point, but convention is to defer that to install so that DATADIR can be defined for some binaries or templated config files etc and is correct for the installed version
Should probably add a docstring for private_ip.
Debug code, should only be called in logger output, etc.  Can remove on release merges.
why did this get moved?
Sure, here it is.
https://github.com/fuel/docs/pull/427
This would highlight the issue, instead of just silently fixing it but could this break existing
 code for people? Should we just spew a warning and add it any ways?
This builds a new list of all keys from self._trigrams and returns 0th item (and would fail under Python 3.x by the way, because keys() is not list under Python 3.x); self._trigrams.max() may be IMHO a better idea because it may reuse FreqDist._max_cache, and the intent of the code would be more clear.
this is silly if we are using %s at least pass something - do we have anything we can pass in I think not also is this even relevant message should be cannot CREATE organisation
Да, loadLyricsFor(track) звучит охуенно, я все понимаю, но loadLyricsForTrack(track) читабельнее
Instead of catching NullPointerException, parameter should be explicitly tested.
Right, you want (Any * -> Any) for the type here.


On Sat, Dec 1, 2012 at 3:00 AM, Eric Dobson <notifications@github.com>wrote:

> In collects/typed-racket/base-env/base-contracted.rkt:
>
> > +  (provide default-continuation-prompt-tag)
> > +
> > +  ;; default tag should use Any wrappers
> > +  (define default-continuation-prompt-tag
> > +    (contract (-> (prompt-tag/c any-wrap/c #:call/cc any-wrap/c))
> > +              -default-continuation-prompt-tag
> > +              'typed 'untyped)))
> > +
> > +(require (for-template (submod "." contracted))
> > +         (submod "." contracted))
> > +
> > +(provide default-continuation-prompt-tag)
> > +
> > +;; set up the type environment
> > +(define-initial-env initialize-contracted
> > +  [default-continuation-prompt-tag (-> (make-Prompt-Tag Univ (-> ManyUniv Univ)))])
>
> ManyUniv is misused here, is only valid in the result type of an arrow
> type. ManyUniv corresponds to any, while Univ corresponds to any/c. This
> isn't actually implemented though.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/plt/racket/pull/182/files#r2285415>.
>
>



-- 
sam th
samth@ccs.neu.edu
i see, phpstorm makes a tab instead of 4 spaces
These constants should be named as well.
what was the reason to use run-time module loading instead of linking to advapi32.lib ?
missing @return
That makes perfect sense.  Thanks, Tom.
Oh I see, I didn't realize that this only removed dead workers. I thought it removed all other workers on this host.
It is just a stub!
This method should not be used by Server or Client Handlers
can we have a test for this?
Wouldn't this give a combination of affine trasformations ".nii" extension?
There should be a '$' in parameter name :)
работу с репизиторием тоже выпихнуть в файл?
а в человечей кодировке можно?
Can we create a private method to do this?

Something like this:

```ruby
def merge_hash(target, base)
  base.keys.each do |k|
    sym = k.to_sym
    target[sym] = base[k] unless target.has_key?(sym)
  end

  target
end
```

and call it like this:

```ruby
symbolized = {}
merge_hash(symbolized, options)
merge_hash(symbolized, url_options)
_routes.url_for(symbolized)
```

What did you think?
Removed deprecation from master, added PR #6221 for 3-2-stable.
Why not a `Repr: IsTraversableOnce` here?
All looks ok to me, thought.
I've reverted this change.
`rep` is not defined...this must be an uncovered line. pylint (or similar) might catch this.
RStudio中按Ctrl+I缩进这一行。
It's safe not to check for `$_SERVER['SERVER_PROTOCOL']` and always respond with `HTTP/1.1`. Browsers are supporting HTTP 1.1 for 13 years already :)
Fixed GWTP
this no longer applies
Is there threadNum != 0 somewhere so we don't have to do this?
Couldn't you reuse the Symfony 2.1 feature allowing to set options, defaults and requirements on a RouteCollection instead of re-implementing this in Silex ?
From what I can infer from the controller, the user (admin) is supposed to set this in a form, so attr_accessible should be fine for deprecated.
Just say checkbox_options ||= nil at the top of the partial.
What is the thing that `subtractOneUnit` returns?
a0a9f79 adds alternate wro.properties files for the packaged war versus local development. This simplifies the file quite heavily, and also means that we can disable caching and minification in dev.
it's upto what is in the coordinate points index setup. 

From the wiki:
All distances in geospatial queries are specified in the same units as the document coordinate system (aside from spherical queries, discussed below ).  For example, if your indexed region is of size [300, 300), representing a 300 x 300 meter field, and you have documents at locations (10, 20) and (10, 30), representing objects at points in meters (x, y), you could query for points $near : [10, 20], $maxDistance : 10. The distance unit is the same as in your coordinate system, and so this query looks for points up to 10 meters away.
comment? :) add and then merge!
Yeah I saw this...not sure why it came up. There must be some white space after the line in the original...
Removed it in 02e5a3576a01e3384b577770a3926419d696be1c.
Ok, I don't have problems with this change, if anyone complains it's easy to change :)
Sorry, editor tabulations set differently than yours.
for consistency with below statements, I suggest:

```
var alert = {};
if(providerSent==null) {
  console.log('Requires providerSent');
  return;
} else {
  alert.providerSent = providerSent;
}
Use the Util function here rather than hardcoding in your uuid
We don't yet have a standard here: https://raxaemr.atlassian.net/wiki/display/RAXAJSS/Coding+Standards, https://raxaemr.atlassian.net/wiki/display/RAXAJSS/Code+Style+Conventions+for+JavaScript
Can we instead include Ext.ux.touch.grid as a git submodule (I've forked to Raxa repo here: https://github.com/Raxa/Ext.ux.touch.grid). This will allow us to link back to the original and get upstream changes, if the author adds them, or similarly track changes that we've made to our fork.

http://git-scm.com/book/en/Git-Tools-Submodules
http://chrisjean.com/2009/04/20/git-submodules-adding-using-removing-and-updating/
return after System.exit()?
The reason is historical ... 
I used to print all the messages out ( messages with diff and without diff ). And at last I need to output the messages to a file while also need to figure all if there's any diff. I think the following code is better
for( String msg : messages ) {
            if( msg.contains("diff") || msg.contains("Diff") ) {
                noDiff = false;
                break;
            }
        }
        m_diffMessages.addAll(messages);
returnsAnnouncedJobsForGivenCompany(){...}
I think `value` needs to be escaped here, otherwise this isn't safe against injection. The URL validator is perfectly okay with e.g. `http://example.com/"><script>...</script>`.
Reading the php.net documentation, it looks like ``false`` is meant to be returned in case of an error too, meaning it does not allow any error reporting if we consider that a query returning 0 results may be a valid use case (which it is).

So now, I'm wondering why you guys choosed to use the ``pg_*`` functions to connect to your system, given their poor API.  Would it work to use the PDO PosgreSQL driver instead ?
Jeff,

I'm sorry. This is the morning and I haven't got my coffee, so I jumped into the issue of detecting dead connection without answering your question regarding the "short" timeout.

The fact that this is a short timeout doesn't change anything to your test. Its goal is merely to provide a good reactivity when streaming the output of a command: As i'm requesting a lot of bytes in one chunk, slow outputting commands could take a while to display the first 4096 bytes. Setting a short timeout allows to dump the first bytes as soon as the first timeout without having to wait for 4096 bytes to be ready.

A diagram because what I'm writing might be not clear.
We assume the command run is outputting bytes 1 by 1 bytes every second (so this is a very not-verbose, very slow command)

setTimeout(0.1)
```
Time
0                           1s                 100s         4096s
Number or read() completed
                             10                  around 1000 around 40960
Number of bytes printed by the command so far
                              1                    100          4096
Number of bytes read (and printed) by fabric
                             1                      100         4096
```

with setTimeout(None) blocking mode
```
Time
0                           1s                 100s         4096s
Number or read() completed
                              0                                       1
           (waiting for 4095 more bytes)
Number of bytes printed by the command so far
                              1                    100          4096
Number of bytes read (and printed) by fabric
                             0                      0              4096
```

Note also, that there is no "normal" timeout as you said. We usually go blocking (```None```) or non-blocking (any other value that's chosen by the lib user). The main goal of my patch was to read by large chunk rather than byte-by-byte while maintaining the reactivity of the tool: this is esp. important to detect interactive prompting and behave accordingly. If we set the timeout to None and the 'sudo prompt' arrives in the middle of a 4096 bytes read (which is likely to be the case), fabric will wait indefinitely for the remaining of the 4096 bytes before prompting the user: a dead-lock. 

So we need to have a timeout. If you find 0.1 too small, we can put 1, or even 10 but this will not change the unplug-cable behavior, I think... Moreover, this will change the time fabric "lags" behind an interactive sudo prompting (0.1 s is cool, 1s is acceptable, 10s... will feel slooow).
I added a todo in the test .
Can you expand on this? The HACKING file says only 3 year old GHC's are supported, so I think it would be nice to clean up all the CPP pragmas to be the same LANGUAGE CPP rather than OPTIONS -cpp.

Is there a policy to support older ghc's too?
This one makes sense I think.
Remove unused code instead of commenting it out, please.
add space => `css: {`
Why not BIGINT?
Np, don't be sorry. ;)
Speaking of which, I think I'm still not out of it as for the client part. :S
We could perhaps just wrap `sed` for this instead with superenv rather than doing it for all commands.
you could just use `which 'python'` where you need it.
All dead code
There is a test for non-ascii data, so I think we're fine.
> Терминология. Всё-таки тема про git, и здесь существует своя устоявшаяся терминология.

Я не особо понимаю к чему это. Что-то не так тут с терминологией?

> Слияние коммитов.

Я уже говорил, что лично мне вполне ясно, что "слияние коммитов" подразумевает слияние двух историй соответствующих коммитам. Если вам кажется, что "слияние коммитов" недостаточно понятно, то можно расшифровать, я не против.

> Исправленная версия уже не допускает двойного трактования — можем на этом и остановиться.

Это про какую из исправленных версий? :) Мне кажется, что их уже штуки три как минимум.

> Что касается теории графов, то в git, на мой взгляд, удобнее закрыть глаза на реализацию

Нет нет нет, так не пойдёт. Можно просто избегать какой-либо терминологии там, где можно это сделать, но закрывать глаза не надо.
package.json is assumed to always exist and have a version property. it's a safe bet, sure, but a little defensive programming wouldn't hurt :)
Extra mapper needed for the completed signal.
Please don't randomly remove lines here ;)
This should go to Example code. Library should be agnostic to such thing.
Having 3 constructors seemed like overkill.  I've plumped for the 2, since the second works for me.  Did we want to deprecate the int one or leave as is?
Another possible race condition here...the reload of the CSS from the previous call might not complete before we send this next request. (Though I guess it's likely that the browser serializes the inspector calls so they happen in order.) Not sure we need to fix this, just pointing it out.
Is there a way to print the link of this ``dev`` that we're deleting?
This call to _doFocusedEditorChanged() *should* hide the status bar. The problem is _currentEditor is getting set to null in _destroyEditorIfUnneeded(). As an alternate fix, you can store the value of _currentEditor *before* calling _destroyEditorIfUnneeded(), and pass that stored value to _doFocusedEditorChanged()
we prefer to explicitly call out 'window' instead of 'browser'
This should be followed by a return null;
We should add a test where the cursor is in the middle of an existing attribute value, to verify that the resulting list is being filtered on chars to the left of the cursor.
That IE-only file doesn't exist, so I removed the reference.
If we don't change this to apply(), should probably add a comment that `ensureVisibility` is an arg added by the subclass -- otherwise it looks like a bug that it's not being passed along.
Why the name change?  Not saying it's bad, but curious as to why ...
I didn't change the inner loop other than unindenting it by one level, hopefully the added comment will make it a bit clearer.
I'm curious about this change. Why?
also,

    if 'actions' in doc_dict:

is considered more idiomatic than

    if doc_dict.has_key('actions'):
Oops, not sure why that got changed. I'll change it back.
Why is so much being commented out and not deleted? The beauty of source control is that you can go back and get deleted code later.
Remove it or leave it. Not just comment it out (especially not without an explanation).

Probably there is nothing wrong with this left as it is, it is then a fallback URL to redirect.
We are putting commas at the end of last elements when we are listing them on their own line.
Unindent the last `}` one level to the left.
Is this XHTML valid?
Fixed automagically with get_or_create().
I can move mongoengine.connect(MONGODB_DATABASE) at the end if you wish.
Interesting this about `.prop`. I didn't know that. ;-)

I agree with dashes, just make sure that also other IDs are consistent with this style.
I'm fairly certain I can't use track.getTrackEventById here. I don't have reference to any track events so I don't know which one that's on a track is opened.

Still, this can be improved.
Fix your camelCase in `spawniFrame`.
This isn't really setup, it's `onEditorOpened` or something.  I'd rename.  Setup implies that it's being run once at the start to initialize things.  This happens whenever it's opened.
I suspect this is the issue with cornfield not running on botio preview?
Probably needs a better message than this :P
function name => `CFFStringsClosure`
misspelled `internal`
Similar to connect -- this needs to be a payload, but it shouldn't be linked to a message.  I suggest you have this take in a "user" and build the payload from the user.  There is no text associated with a nick swap -- the only thing you need for a nick swap is a nick and a userId.
HTTP_SESSION_STICKY_SHARED这个变量名也改成HTTP_UPSTREAM_SESSION_STICKY_SHARED
其实这个也不是必须的对gcc,只不过为了安全期间加上去的。
So i wonder if we should use the label of the views for a tag, since you can have multiple ContentView Objects for the same "View" (spanning different environments).   We either need to do that, or create some overarching CV object.
Is this really configurable? I was expecting to drop thin support and your patch really looks like it does not support thin anymore.
^ This does not go well with description of this commit.
This is also probably better defered to the top plan.
I have just opened bug 736628 for that. If MozKeyboard is moved as a separate xpcom component we could get rid of that.
`table/tests/test_table.py` uses `np.allclose()` so I'm going assume that it works with 1.4.1.
Had to take a minute to parse the list comprehension to determine that `DAM1` was an "empty dictionary adjacency matrix; mapping all possible pairs to the empty list". Might make sense to add a comment here, and possibly even move this into a separate `empty_adjacency_matrix(Members)` function.
Let's format these better and try to at least be close to 80 character lines. Also, you can pass an array of hashes to create instead of making separate calls. Look at the examples you deleted.
It's confusing to have 2 variables called CURRENT_VERSION. Better would be: CURRENT_TX_VERSION and CURRENT_BLOCK_VERSION.
Why not use isset() here instead of array_key_exists?
this is not quite correct
Numerically close to their address while being physically close to the actual router.
very keen to try this out :-)
this looks fine
space after comma in function declaration. 

Try to keep docstring 'one short line, one empty line, longer description'.
No it wasn't purposeful. When i get home i can change it, or maybe i can
take a look at that 3.2 failure and fix that miss along with it.
On May 4, 2012 4:27 AM, "Thomas Kluyver" <
reply@reply.github.com>
wrote:

> > @@ -69,7 +69,7 @@ def write(self, string):
> >          else:
> >              # Make sure that we're handling unicode
> >              if not isinstance(string, unicode):
> > -                enc = text.getdefaultencoding()
> > +                enc = encoding.getdefaultencoding()
>
> This is the only instance that didn't get converted to use the constant.
> Is that deliberate?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1245/files#r773316
>
I thought this PR was resolving the issue of cells being coupled with execution requests.  Now, you don't need a cell to execute some code and get a result.
The reason I went with ~/.cython/magic is that I could imagine that
this extension might someday be maintained and shipped with Cython.  I
am fine doing ~/.cython/ipy_magic though as it is more specific.
@minrk are you OK with this or do you really think we should stick
within the profile dir?

On Tue, May 29, 2012 at 7:39 PM, Bradley M. Froehle
<reply@reply.github.com>
wrote:
>> +        else:
>> +            module = import_module(module_name)
>> +            self._reloads[module_name] = module
>> +        self._import_all(module)
>> +
>> +    @magic_arguments()
>> +    @argument(
>> +        '-f', '--force', action='store_true', default=False,
>> +        help="Force the compilation of the pyx module even if it hasn't changed"
>> +    )
>> +    @cell_magic
>> +    def cython(self, line, cell):
>> +        """Compile and import everything from a Cython code cell.
>> +
>> +        The contents of the cell are written to a `.pyx` file in the
>> +        `~/.cython/magic` using a filename with the hash of the code.
>
> Well in that case maybe we should use ~/.cython/ipy_magic ?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1770/files#r897576



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
have this just call the one with RunScriptOptions, passing new RunScriptOptions();
Should this be `@param  mixed  $arguments`? :)
Sir! You're right, Sir!
 
On it!
for completeness then we should also check `null`
Nope, can't use Django TestCase because it requires a database. I have to file a bug to Django to get this fixed but you know, lots of stuff to do…
No need for &nbsp; here, just an empty block will do.
Shouldn't we also move this into the if block? Right now we would even run into a timeout if the processNextEvent() call it taken longer than the delay. I think the final end time should be the time when result is set to true and not for the last wait() call.
__whimboo__ wrote:
> Which case is it? I'm kinda interested in more details.

As I recall that was related to restart, but I'm not sure.
Will check today!
This file should be called ``products_service.py``. It does handle the ``/products`` entry point, and not ``/products/versions/`` (as explained earlier). Sorry that I missed those when I reviewed your previous pull request...
On Fri, Dec 21, 2012 at 04:31:59PM -0800, Rob Hudson wrote:
>The above won't catch this? Or you don't trust the header?

I don't trust the header. As far as I can tell, `requests` 
doesn't pay much attention to it.

-- 
Kris Maglione

APL is a mistake, carried through to perfection.  It is the language
of the future for the programming techniques of the past: it creates a
new generation of coding bums.
	--Edsger W. Dijkstra
每行新起var name 来声明变量比较好，至少删除的时候只需要变更一行就可以了。和nodejs源代码保持一致。
the row 271 has been reviewed ( a test condition is added )
`p` --> `package`, and Align `==`
This one didn't pass after my change, foo2:command doesn't trigger any suggestions even though similar namespaces exist, because there is no command named or similar to 'command' in those namespaces.

It doesn't look wrong to me, even though you change the namespace then, the command still won't be matched.
Should be you (and maybe @stealth35 and/or @igorw) ;)
Not sure I understand this - this change is already in the debug.xml file...
Why not set that to `!defined('PHP_WINDOWS_VERSION_BUILD') && $this->isSigchildEnabled()` by default? Because with the current patch it seems that in most cases you'll anyway call that method to check if it's enabled at some point or another, so you might as well just enable the workarounds? I think getting the proper exit code is a more common use case than getting the pid.
Well, what if I have an heavy calculation returning a boolean ? I may want to cache the result. The Cache component should not make any assumption about what is stored (well, except required assumptions like the fact that object cached need to be serializable).

And indeed, your CacheProxy solves the issue when using it. But you seem to consider it like an optional extra feature on top of the driver whereas the discussion was suggesting to separate totally the cache frontend (used by userland code) and the cache backend (your drivers here).
If we keep the driver as is for the backend, I would personally vote for using ``null`` instead of ``false`` (which is what you do in the implementations already)
Sure. What about other parts?
1. Yes it is tested.
2. Do you think we should introduce protocol for things which are not going to be reused in the app?
In this case, its ok to make puma be in the project's env because the resque_web code is part of the project's gemfile, not a standalone project like graylog_web
Well this is strange.
it still says "binary"
Oh, I suppose it does.  Though I wonder if *this* one is the normalization that should be eliminated. Hmmm.
mit diesem key wird der remember_me cookie encrypted
This should be `downvoters` though still I think.
Are WMS servers always ```'image/jpeg'```?
No problem, will fix. I don't really understand quite when Rails needs telling to reload objects and under what circumstances it'll figure it out for itself - this was just copied from the line above.
When we did this test without the prefix, we got 404 errors. When we added the prefix, the 404 went away...
Could be written as:

````javascript
@search_field.value = if @show_default_text_always then @default_text else ""
````
.setDefaultValue(new ModelNode(false))
should this be self.filename = filename?
Those two options make more sense.  Note though that prefix is either / or /something/like/this.  And I'm also doing no validation on prefix -- I assumed it was already done elsewhere.
Why does draggable need position?
Thanks for the explanation, I think that convention makes a lot of sense.
console log here? we should remove this
Add `var`
I understand but that problem can be fixed by using a library such as https://github.com/telefonicaid/B2G-Utility-Libraries.JS/blob/master/logger/logger.js . However, as you don't like libraries I will not introduce it in this module unless you want it
Yes, but this refers to "native" apps (like Music, Settings, Browser, etc.).
If user clicked on such an app- we launch it using the homescreen's Applications object.
yep, thought I removed that. Do you you want me to change the pr to remove get Midnight?
I'd use hasOwnProperty here unless name is guaranteed to have a slash in it or something that means someone who thinks 'watch' is a good name doesn't footgun themselves.  (Maybe SpiderMonkey removed that now, though?)  If it's safe, add a comment about why it's safe, please.
fist -> first
Ok, let me think about how to rewrite this.
It's only a local test, and I shouldn't submit this.
Sort usings :smile:
I hope you can see that this is turning into whack-a-mole.
I would be careful using `options.delete(:model)` here. This code modifies the arguments to the method, and if you're using the object elsewhere, it's now been modified. In general I think it's better to assume every argument to a method is immutable; unless the method's purpose is to mutate the argument (which is really, really rare in good OO code).

Another thing I would suggest is looking at the immutable stuff in Veritas. I've found some amazing benefits working with immutable objects, and being forced to inject everything into the constructor, and having to explicitly "mutate" state by returning a new object. There's an article about this that's great if you haven't read it yet: http://www.harukizaemon.com/2010/03/functional-programming-in-object-oriented-languages.html
do you want to leave this in here?
This could backoff for a very long time. Perhaps exponential backoff to a limit?
Document each of these globals and consider making them class constants.
Very good point. I've implemented and pushed a check for the Android UA so we're not affecting anybody else. From what I've read this bug seems to affect any and all Android WebViews at this point
As you see with the TODO, it doesn't actually remove it. This is one of the serious problems with QtTest: it's not clear how widgets should be interacted with. It's an issue I wasn't able to resolve and therefore remains as a TODO.
> commenting on the compiled js file

i shiggy diggy
No apology needed. You'll find that the absolute best time to write comments is during the initial phases of trying to get things to work. Use comments to organize your thoughts and map out code structure, and your code will not only read like something a human wrote, but you'll get to "working" more quickly. Typing time is basically never the bottleneck.
Yikes! Trailing whitespace is evil!
@ytsarev, Adding cdrom under boot variant means this cdrom will be attached in  boot test every time.
Though I don't know why SLES needs this cdrom, adding the cdrom config for boot test seems can't help anything. Please consider this test config:
"only unattended_install, reboot" <- run reboot test just after installation test.
If SLES acutally needs cdrom image, any test case following installation case will fail.

I doubt a better way to deal with this problem is add some more steps in unattended_install script, and make the installation process fully complete in it.
One thing at at time. ;)
`json_last_error()` wouldn't be better check here ?
rather than this being an option, maybe lets just always be explicit about making it desc id?
Not sure if we should be using `update_all` here (or anywhere), since it bypasses all AR callbacks and validations. What do others think?
this is just to allow the old minimum interval of 800ms
Would it make sense to also include `:confirmable` here?
@randx  If we use satellite repo , I think we should keep the satellite repo up to date.

Satellite repo didn't pull unless it has a merge request and do merge.
Ok great, I'll merge that this week so. Thanks!
minor thing, function name is part of SCLogDebug output
this name is probably (much) too long. Think it's cut off by the system at something like 12 or 16 chars.
`baseURI` doesn't seem to be used
In most of the cases it's easier to wrap value into `promise` and treat it as such than do a branching depending on if it's a promise or not. In fact this library itself makes intensive use of this, for example see join https://github.com/mozilla/addon-sdk/pull/350/files#L1R180 which is pretty common use case of this feature.

Also `future` is similar but for computations from value that is can be either promise or not. You can think of it as a sugar to

```js
promise(maybeValue).then(function(value) {
   value + 5
}) 
```

Also both have additional feature that allows you to define prototype of the resulting promise that is not covered by an example above.
@jedp - Here is the change I made in the tests - instead of depending on the "resize" event to be called, I pass a callback to the open function which is called once the extended info is open.
Would you mind starting to use JSdoc comments? http://code.google.com/p/jsdoc-toolkit/w/list
In retrospect I'm not sure what I thought the problem was here. Carry on.
I'm betting you could refactor this to something like
```
[:v1, :v2].each do |v|
  namespace v do
    # define the common routes
  end
end
```
There's no need to wrap the attributes in `"#{}"` here.
I wish you had left a blank line at the end. I mean, really.
s/date/data/
Apparently yes. This is a first pass, but it would probably look something like this:

(\s?([^:\"]*(:(\"[^\"]*\"|[^\"]*))?)*

Do you think it be easier to maintain/debug as a regex?
This is a super-simple abstraction. I had a bigger one originally (which also refactored the WebMatrix Curator) but I decided against it, YAGNI and all. In general, I totally agree with you @half-ogre
k, I'll fix that
The back ticks were good to add, but the brackets are supposed to be there, to indicate that parts of what's presented need to be replaced with user-supplied values and not interpreted literally.
yep that looks good
and you need to escape the ``#`` in the filter as you use it as regex delimiter
don't do this, unless the buildsystem is not fixable to use the user provided FC and F77. Please use fortran-2.eclass to set this.
I think we should only need: http://jinja.pocoo.org/docs/extensions/#i18n-extension
```javascript
if (typeof($) === 'undefined')
```
introduce a (global) constant you can use instead of ' ', e.g.

NEWLINE = "\n"

or group parameters together, and create a double loop over them:

order = [['name', 'version'], '['homepage', 'description'], '['toolkit', 'toolkitopts'], ['dependencies', 'builddependencies'],
['sources', 'sourceURLs'], ['patches']]

Add toolkitopts and builddependencies as well. And patches? And pkglist, pkgpatches, pkgnames, ...

Actually, you should just ask for the order of things to the easyconfig module.

There's a ticket for categorizing easyconfig parameters. That needs to be done first, (grouping + giving groups a name, like on the wiki page), and then this script can simply request for the available keys + order.
spaces and two spaces before #
When new commits are added, we don't get an email about that, so you need to add a comment to get our attention.

It now looks great, except for the fact that you don't close the list, i.e. there's a `]` missing at the end.

Fix that, let me know, and I'll merge it in.
is this available everywhere?
Why only after, and not before ':'? Also, most current code uses "key:value" instead of "key : value". PEP8 doesn't require it, and I think it only makes lines needlessly longer.
Doesn't have to be malloc'd.
You need to add this:
const Main= imports.ui.main;
This is not necessary, "toolbarLocation" attribute will be also available to ngxCkeditor directive (after recompiling element with ngxCkeditor directive). Please remove this.
I have to say... that's pretty tidy! (And I actually understand it which is different)
My bad - I forgot that the inherited save method has a 'user' argument.
https://github.com/mozilla/mozillians/blob/master/apps/phonebook/forms.py#L96

I should have recommended:
```python
def save(self, user):
    d = self.cleaned_data
    if username in d:
        d['irc_name'] = d['username']
    super(RegistrationForm, self).save(user)
```
Nice catch @AlinT -- @Sakshiarora oop wrong language :-)
I think you can use the simplified syntax here too - by default render will assume it's a partial, and if followed by a hash it will use the things in the hash as locals.

So, render :reading_blurb, :work => reading.work, :reading => reading
I think we should add that the check for "is None".

That way the trading_day_distance method's implementation can heed to the case that we are finding. (i.e. no distance), instead of having how it's called leak in.

Thanks!
With that in mind, the binary search use for finding the trading day distance between two days is great.
${MONITORIP}
I'm sure you want to get the archived workspace via the SCM settings of the workspace plugin. We should get rid of the Copy Artifact plugin.

But it looks like that it doesn't work if you depend on the workspace of multiple other projects. There is no way to add more than one. Would be a nice addition for the plugin. Mind filing it as an issue?
Name is not declared in this method.
Shouldn't this be "growstuff_staging" or something?
If `min`, `max`, and `target` are equal because the range degenerated to a single value, then it's better to just return that value rather than sitting in an endless loop trying to return something other than that value.

Yes, I could add a check where I call this to handle this case and not call it, but I couldn't imagine a case where we'd want this function to sit in an endless loop, so it seemed better to fix it here.
I dunno.. I liked the look of a blank line at the end of the output?
transform -> translation
In theory you don't need to include the `KhanUtil` in `guess`, `validator-function`, `show-guess`, or `show-guess-solutionarea` since they're all eval'd inside a `with KhanUtil {}`
switch the order of your operations around. you're passing control on to the next step (which is your callback) before marking it as initialized.

```js
initialized = true;
originalInit.apply(this, arguments);
Note the way that a connector can obtain the properties from the ExtraPropertiesStore instance and simply add them to the document currently being written. By doing this late in the method, some of the extra properties might overwrite the non-extra properties (which is likely a good thing).
Same issue with the change in visibility of this method as with `JcrRepository.start()`.
Right. Especially with how many times I call this method and how the tests basically require it. Its cumbersome at a minimum.

On the other hand, the tests also require that their order be maintained -> I need to have my test artifact PUSHED before I can DELETE it, and I can't PUSH again on another test run unless the artifact isn't there in the first place.

IMO kind of a necessary evil at the moment.
this *isn't* the last argument?
жалко, что память каждый выделяется при копировании. может попробовать сделать только перемещение? ну или перемещение тоже
объявлять столько всего в функции -- это очень усложнять чтение
Kept explicit check for `12.04`.
This was to deal with a bug that occurred in the original CodeMirror code as well as in the new scrolling code--when scrolling through long documents, a scrollbar would sometimes appear on the main browser on IE when it shouldn't.
I'm still not 100% clear on the value of creating a new server class every time this is invoked. What's the idea behind that?
Yes, a command line option was [previously suggested](https://github.com/mozilla/Addon-Tests/pull/427#issuecomment-4975840)
This might be better as a `getPrincipals` API function in the principals API
``tpt.original`` should be wrapped in a ``askOption`` call as it could suffer of thread-visibility issues, i.e.,

```scala
for (original <- global.askOption(() => tpt.original)) yield original match {
  ...
}
```
Ok, I can remove `batchSourceFile` and add it back only in the worksheet. Yay for thin interfaces! :)
There's a bit of duplication in this method. Could this delegate to `ScalaReferenceType.fieldValue`, somehow? Maybe if `ScalaReferenceType` is a trait, it could be mixed in in `ScalaClassType` and `ScalaObjectReference`. Same for `invokeMethod` (though I realize it's more complicated, because one is for static methods, and the other for virtual methods).
Ah, I forgot about Mirko's comment about the hints parameter. Anyway, now I created a hook for subclasses to provide hints and MoveConstructorToCompanionObjectAction is already using it. For refactorings that operate on the method signature I don't see a way to come up with useful hints, as one has to track all usages of the refactored method, so they will be slow...
Add the plugin hook to this list - https://wiki.ushahidi.com/display/WIKI/Plugin+Hooks
agreed. That's a mistake. Want me to commit amend?
We have a similar script in WikipediaMobile too :) This runs without dependencies (except python), not the case for nodejs/rhino/flavor-of-the-month-js-engine.

And yes - currently only 20 campaigns will show up. I expect a lot more to. Plus the categories will change soon - the current ones mention 2011. Are you really suggesting hand-writing data instead of doing a script that generates it?
I was hoping we could avoid generic empty list messages and add additional ones for other things...
Move these to ApplicationController. Then ignore them where not necessary (i.e. sessions controller). This is a more defensive way of doing it. That way adding a new controller will not introduce a back door to the system.
same as enums, finder can accept such parameters. I will implement if after Enums for states and types
is nu allemaal main_character
Will do! It seemed strange to me as well, I just didn't want to change more than what was necessary.
Also, please don't do these casts.
I'm not quite sure of this logic, since I don't have SQL Server to personally test with.
Это ошибка :(
Проблемы нет. Это скорее "плохая привычка". В других случаях getter свойства может что-то делать, кроме как отдавать ссылку на _DNA, т.е. будут side effects (работа с другими переменными и т.д.)
В задании говорилось о переменной, а не свойство. Не думаю, что критично, но все же.
В задании сказано "Создайте категорию mutator", а не cellOperations!
need to fix this oops.
Since this will start tracking and processing resources (not only remove redundant resources) can we change the name to something like 'trackAndProcessResources'?
Done, btw
Ah, yes. Consider this:

```php
<?php

$mongo = new \Mongo();
$db = $mongo->test;

$persons = $db->persons;
$persons->insert(array('name' => 'Joe'));
$persons->insert(array('name' => 'Sally'));
$persons->insert(array('name' => 'Dave'));
$persons->insert(array('name' => 'Molly'));

$cursor = $persons->find(array())->limit(2);
echo count($cursor) . "\n";
echo count(iterator_to_array($cursor)) . "\n";
echo $cursor->count() . "\n";
echo $cursor->count(true) . "\n";

$db->persons->drop();
```

It outputs:

```
1
2
4
2
```

Is the Iterator type-hint there to satisfy something? Otherwise, we could type-hint with the Cursor class and use `count(true)`, which should be more efficient.
This loop should probably be `@synchronized` too.
%s/; /;\r/g
Why do you need these two constants `REFLOW_MODE_ON/OFF`? Do you expect modes other than ON and OFF? If not, then your boolean variable `reflow_mode_enable` is perfectly sufficient.

Btw, don't forget to initialize it in the :setDefaults() method (where all boolean configurable are initialized) when you make it user-configurable.
哦，好像core里面都是这么搞的，不过我试过把语法转义去掉也没问题
What's the purpose of this here?
Why would you like to disallow the access to site media? I could imagine that this even leads to problems, e.g., when viewing a META-SHARE page in the Google cache or the like.
take a look at mne.minimum_norm.inverse._get_label_sel
that looks like duplicating this function. If it does we should rename _get_label_sel to a more meaningful name, make it take a src space as parameter and move it to mne.label or mne.source_space

wdyt?
So you expect the user to set this depending on the DB they are using, ok! then that makes sense
slightly more idiomatic form would be:

```
case ej:get(Key, Data) of
    null ->
        undefined;
    Value ->
        Value
end.
```
Antislashes are now escaped
Didn't love the name, but anyway heh
Replace with ErrorHelper.ThrowCustomWin32Exception();
I am more than willing to change it to whatever you recommend.
using statements go outside the namespace in MA.M
You could remove indent with such code
```php
if (!$this->isEligible($app, $record)) {
    continue;
}
```
multilines are great
**OCD:** can cut down the line count by doing:
```
text = ...

...

return text
```

Rather than putting else-cases everywhere (in case we add more cases later).
manually changing something kinda makes using pull requests pointless =p
This the bigger all-encompassing package?
It's worse than that. He's dead, Jim!
No problem with bumping it to 10.7, though I thought we agreed not to do that unless we needed to.
NIce dude, keep us posted.
this one should be a boolean
I would think that would be somewhat repetitive, since this function is essentially meant to sanitize nodeValue input, irrespective of elements/attributes.
Are you sure you want to set the IDENTITY here?  Setting identities causes the socket to become durable, which is rarely desirable, and is the only difference between setting a random identity and leaving the default.
i dno, to me it kinda makes sense how it is... but i'm way past my bed time so can't think str8 :D
Why not just `var object = { hasOwnProperty: null };`?
sorry to be picky, but ... ;-)

I would have put the =args= after a line break, because it's hard to see on what your map is applied
I don't think that's the correct exception. From the PHP doc:

    Exception thrown if a callback refers to an undefined method or if some arguments are missing.

The bad thing about semantic exceptions is that we can argue about the semantics :P

Maybe this should be an UnexpectedValueException since it will most likely occur when an unknown value for $type is set. If a file is missing it should probably be a RuntimeException.

Argh. Just do what you think makes sense ;)
Não me parece que seja apropriado, é mais global que os locales.
Esse try/except deveria ficar dentro do bloco do ``if dom.getElementsByTagName('erro'):`, concorda ou não?
You should initially hide with CSS. Not JavaScript.
Maybe just use `UUIDField`?
Where is `DoesNotExist` defined?
How it is going finding another solution?
Where is the new "remove" argument being used?
Testing this overwhelmed my Firefox installation and polluted those results, but I'm willing to declare real-world performance a draw—at least on Chrome. http://jsperf.com/2012-03-07-jquery-clean-11325
Oh I see, you've moved the functionality into the dense arrays.
_Reset();  + _summons.DespawnAll(); + _events.Reset(); = wtf :-/
why did you delete this?

you should use EFFECT_MOTION_TYPE, and it will work
Find a way to make this either `private` or `protected`.
Ditto re the use of file:./ for importing.
catch the NSUndefinedKeyException instead
Here it is:
https://github.com/infinispan/infinispan/tree/master/cachestore/cassandra

Or just checkout `git://github.com/infinispan/infinispan.git` and move into `cachestore/cassandra`
Are the numbers guaranteed to be consecutive?
I know this is just for debugging purposes, but It might be more readable if the sections are formatted so that each section lines up when printed.
I'd prefer to do less changes like these in the future as id specifiers, and more as variants of existing form classes (form-sectioned or something).  Fine for now.
Would be nicer to read with constants.
should we bump the version number for this change?
Agree.
C'était mis de coté au cas où, mais visiblement cela n'a aucun intérêt.
On Jun 4, 2012, at 8:43 PM, Barnaby Rowe wrote:

>> @@ -13,6 +13,15 @@
>> 
>> namespace galsim {
>> 
>> +    namespace sbp {
>> +
>> +        // Magic numbers:
>> +        
>> +        /// FT must be at least this much larger than input
>> +        const double oversample_x = 4.;
>> +
> 
> This seems high (although I see it was there in the original .cpp file too).  Perhaps question aimed at @gbernstein ... What's the rationale?
> 
> Also, are we jettisoning the convention of capitalizing magic number constants, e.g. `OVERSAMPLE_X`?  For the record, I like that convention, it highlights the special status of these variables on the code... (otherwise as a developer I spend minutes scratching my head wondering where they have been set...)
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/176/files#r926499
> 

The rationale for 4x oversampling is that 4x oversampling with quintic-polynomial k-space interpolant is the recipe found in Daniel's and my investigation of what's necessary to get ellipticities correct to 1 part in 1000 when doing shearing with interpolation in k space.  If objects are already small compared to the input images (as in some of Rachel's COSMOS galaxies) then this would not need to be as high.

It is something that could be fiddled with when someone is doing very careful tests of accuracy vs speed. But changing may void your factory warrantee :)
Sure, but do you want me to do that as well once i'm making all these other little changes?  Either way is fine, just LMK.
My only concern is about the return here (and above).  Is there any documentation of HSMShapeData?
You might want to add another function clause here to either cause a `badarg` exception or simply ignore unrecognized options (your choice).
ah ofc.  shame.  okay.