labofsahil/github-event-dataset-2012 huggingface dataset:
Это упрощение. Попробую пояснить ход мыслей, когда именно так сделал
Реально классу нужно иметь именно DB под рукой, т.к. именного у него вызывает begin, commit, rollback. Но обычно мы работаем с объектами и у них под боком есть DAO. Из DAO можно вытащить DB, вот так: ``` $db = DBPool::GetByDao(TestObject::dao()); ``` На N'ый раз уже жутко раздражает этот копипаст.
Можно было бы всегда принимать только DAO и из него доставать DB, но это не хорошо, т.к. нет нет, да захочется вдруг передать именно DB и тогда жуть как сложно придется выкручиваться. Сделать два метода с чуть разными названиями и разными аргументами тоже не хочется, т.к. это вносит лишний копипаст и путаницу.
Будь в php перегрузка методов с разными аргументами - не было бы проблем. Собственно по этом и делаем в этом методе вид, что какая-то перегрузка методов есть.
Обий интерфейс придумывать и вешать на классы тоже не хочется ради какой-то новой фичи. Так классы глядишь и обрастут дясятком других интерфейсов. Поэтому я сделал так как оно есть сейчас и усложнять как-то совсем не хочется.
Does this means it can't be disabled - when in-use by a filter?

I'll make a case that it's OK to allow admin to DISABLE it as away to turn off a canned-auto-response used by multiple filters for example.
Again, don't we just want to use `(thrift/unpack)` here?
Retificar o comentário,
Is it possible to change the validation to avoid doing this?  This feels janky.

If we can allow password to be blank if a registration _token is set that should suffice.
Why it needed?
okay but is that necessary, i mean i always followed the other style.
but for now i have done what you said
Parameter name must be $values
Shouldn't this be `if (!Object.isString(madeClipping))`? If it's a string, it means we've already made this element clip, and so we're doing extra work for no reason.
Predtim to bylo tady void schedule (void), protoze se to volala primo z interrupt handleru. Ted se "mezi" vlozil ten Timer, kde se z interrupt handleru vola void timer_callback (void). No a API interrupt handleru mi kaze, ze callback bude vypadat takhle.

Uplne nevim, jaky mas konkretni pripad, ale vzdycky muzes udelat:

void my_schedule(void)

schedule (timer, data) { my_schedule(); }

...a jinde v kodu zase: my_schedule();
Ah okay. It's fine then since it's only used in the media queries.
Good catch. RSpec was my original plan, but I changed it to work around warnings that were cropping up and didn't get back to it. A fresh set of eyeballs this morning helped, and fix is in a7f0414.
I think it would be good to rename this `part_number` instead of sequence as sequence really means "a continuous or connected series" instead of the sequence number.
I've updated the code to use `session_cnt` and do explicit word-sized reads during the copy.

While the code looks similar between those two functions, there are important differences because __wt_txn_get_snapshot does not allocate an ID.  I've updated comments to clarify -- I don't expect to need this logic anywhere else, but if we do we can look into refactoring then.
This is still used for physics problems & exercises. Did you recompile ccap-physics and test before making the pull request?
- overrides https://github.com/Connexions/oer.exports/blob/master/css/ccap-base.less#L21 I think that rule was from biology 2 column design. If that is correct, it should be removed from base as opposed to overriding in book specific styling.
Should the type for parameter ``$parent`` not be "null|AbstractContainer" instead of "AbstractContainer"?
This fails when an object has a property named `hasOwnPropertyName`.
Extra space in here
I agree, that some consistency between these and cm_tools_block_position() would be pretty sweet actually.

Not to mention moving that function *also* into profile.inc.
This code is part of Scala IDE code, I just copy pasted it :)
I copied it from your code :-) and you copied it from StdLib's one :-) So that, I don't know, what's missing :-D
You're true, we could add a generic JIteratorPages able to iterate over any iterators.
Please remove the spaces around you argument. We generally don't use them. (same in line 769 and 767)
I think this has extra spacing, also remember to add a space before the following if.
is there a B/C isssue if a 3rd party dev has used

    if (defined('JROUTER_MODE_RAW'))
    {
        ...
    }
code will wrongly enter here when `result && !Element.ShortStyles.hasOwnProperty(property)`, you only need to run the `getComputedStyle` part if we got no result from the `this.style[property]`

Even better, I'm also not sure if doing: `var result = this.style[property] || this.getComputedStyle(property);` would break anything, current specs pass but that doesn't say much. Any reason to give ShortStyles precedence over trying to getComputedStyle on the element?
hardcoded attribute
Please write javadoc comments when describing new functions.  I know some of these functions have them and some don't, but I'm trying to work toward a fully-documented API.  Also as above, please describe which parts of "event" are used, as the mouse position is obviously not used.
So yeah, I was wrong : the reason why it crashes is the fact that self.rwdb, as a NoneType object, has no member nor functions called get_current_channel().
Order imports properly by sections.
` and hasattr(request, 'user'):`
All this could be simplified: `$(':checked', element).change()`.
Please check that pressure is not in the results
`Don't use 'with'.`
Might be an idea to take out empty lines after and before brackets, yeah. I do personally like whitespace, but yeah, may be a little much :D

(rather too much than too little though, easy fix!)
Why is key `@""`?
ah ok, will change that
wrapped the reference inside a check, also did the same wrap inside the DIC Test.
The SetterTest will be skipped on versions below 2.3.0-DEV.

Tests pass for 2.3 and 2.2, though 2.2 now has two skipped tests (XML + YAML).
It seemed to me, that skipping would be the best way to go for this.
_path='/tmp/sample.text' or '/tmp/my.jpeg'
Please replace these hardcoded values with expanding variables or at least placeholders.
This actually doesn't match the our current thinking about Django's release policy any more -- the plan is to always be backwards-compatible, at least as much as possible. So let's nix this whole paragraph.
For reference, you can also use a method marker such as:

    @pytest.mark.xfail("config.getvalue('browser_name') == 'internet explorer' and \
                       int(config.getvalue('browser_version')) == 9", 
                       reason='IE Local Storage https://github.com/mozilla/browserid/issues/2265')

See other examples [here](https://gist.github.com/2988477).
It's been optional for a while.
But yes, fixing.
Whitespace after `:`, throughout the file.
Just window_id as parameter would be a bit more precise.
shouldn't this be ``beta_k neq 0`` and ``beta_k = 0`` at the end of the lines
Ah good point.  I'll update the code.
I like the idea with overriding `default_format_options_for` in every subclass, but I think this `2` should be moved back into some constant because it looks too much like a magic number here.
logs need to go
The integer parsing & property constant feel like they are at a different level of abstraction than the other code.  Do you anticipate that the property will be changable at runtime?  Or should maxNumberOfMsgsToHandle be extractable up to a final field at construction time?
Maybe the dropbox url should go here too?  Or if we are worried about dox getting out of sync with reality, maybe make a wiki page that has the link and talks about what the contents of the download are, and then we can point to that wiki page.  Then if the location of the training galaxies has to change, we would only need to update one link rather than search through the code and tex files for the relevant links.  For example, I quote the link in the demo scripts now as well.
`Something along the lines of a Great08 (Bridle et al 2010) image`?
We've been keeping this "backwards compatibility" class around for a while now.  I think we should retire it.  We don't use this for anything.
This should not be inside the `split_privmsg` function. It should be located in the `parsemsg` function (probably near the end).
Indeed, this was a bug in opam. This should be fixed by https://github.com/OCamlPro/opam/commit/17da0bf39e5fe7aa3caa817da401c2e6ecb31cb0
Separating out entity-based connections from using the connection gets my vote.
"alias"? I don't think I understand.
Interesting!  The 'next billing date' title for the date column doesn't cover it?  But not a big deal.
This doesn't work - the variable is $puppet::agent_params (or $puppet::server::agent_params). You need to do something like:

    $params = $puppet::agent_params

in config.pp and then use the local $params variable in the template.
Oh, it doesn't move it binary into `bin`?
Homebrew has the `mv` directly:

```ruby
mv prefix/'Ray', bin
```
should work.
Where is `shunit2`?
Moved AdapterFactory out of Pipeline folder, change visibility of AdapterFactory to default and change visibility of restAdapter to public. I think AdapterFactory die soon :)
trying hard to understand that
This won't work as the maximum has been updated.
I've been getting a lot of negative push-back on this one example, so I've removed the `filter_input` within the `bindParam` method in a recent push. If you want to add an additional example here or in the Data Filtering section that demonstrates other scenarios that should use `filter_input`, feel free to do so.
Название класса - не очень информативное сообщение.
Вы про имя?
Почему здесь file.separator? Мы здесь строим вывод команды "dir". Все вложенные файлы и папки - с новой строки.
True, the main reason I had to switch it was because I now override the _default_manager in addition to objects, since Django 1.4 has things like get_object_or_404 which use the default manager instead of objects.
This is the problem. You've delayed the load of GCLi, so when you come to require it, it's not there.
If you push the require into the function, then this lazy load will make sense.
oups this is a radio button so we have only one option :D
It could be nice if it can read a file type object (ie: a open file) as well, ie:

if type(bind_zone_text) is file:
   bind_zone_text = bind_zone_text.read()

(probably need a better variable name).
hm... you mean in the case where the estimator doesn't have a score function but a loss function was specified (and not a score function)?
That is true...
"unfortunately" all estimators have a score-function... I'll have another look again. I'm not sure how it is possible to use the two lines below....
self.classes_ and self.n_classes_ are not documented.
The tests don't pass: spectral embedding doesn't fail gracefully on
sparse data (I think that it should work on sparse data, without
conversion to dense):

<pre>
$ nosetests sklearn/tests/test_common.py:test_transformers_sparse_data
======================================================================
ERROR: sklearn.tests.test_common.test_transformers_sparse_data
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in
runTest
    self.test(*self.arg)
  File "/home/varoquau/dev/scikit-learn/sklearn/tests/test_common.py",
line 225, in test_transformers_sparse_data
    raise exc
IndexError: tuple index out of range
-------------------- >> begin captured stdout << ---------------------
Estimator SpectralEmbedding doesn't seem to fail gracefully on sparse
data
Traceback (most recent call last):
  File "/home/varoquau/dev/scikit-learn/sklearn/tests/test_common.py",
line 214, in test_transformers_sparse_data
    trans.fit(X, y)
  File
"/home/varoquau/dev/scikit-learn/sklearn/manifold/spectral_embedding.py",
line 433, in fit
    affinity_matrix = self._get_affinity_matrix(X)
  File
"/home/varoquau/dev/scikit-learn/sklearn/manifold/spectral_embedding.py",
line 386, in _get_affinity_matrix
    self.affinity_matrix_ = kneighbors_graph(X, self.n_neighbors)
  File "/home/varoquau/dev/scikit-learn/sklearn/neighbors/graph.py", line
49, in kneighbors_graph
    return X.kneighbors_graph(X._fit_X, n_neighbors, mode=mode)
  File "/home/varoquau/dev/scikit-learn/sklearn/neighbors/base.py", line
315, in kneighbors_graph
    n_samples1 = X.shape[0]
IndexError: tuple index out of range

--------------------- >> end captured stdout << ----------------------
</pre>

The solution to the problem above is simple: just use 'n_samples1 =
len(X)', however there might be other problems related to sparse
matrices.
I just figured that that expression will take O(`n_samples` × `n_classes`) memory, which @mblondel will probably not like...
what is X is 2d. Do you do an isotonic regression on each column?
you need validation functions to check that you work with proper numpy arrays
see as_float_array in validation.py
got converted to pyplot? :)
If you require the first argument to be the command line options, you might as well change the wrapper definition to:
```python
def wrap(opt, *args, **kwargs):
```
Ah, now you shed some light on this. Windows has only 3GB address space for 32 bit applications.
You can't pass an rvalue (`new Object()`) to a ref parameter.
No because the first one is the header of the current cpp
remove spaces in `Handle < String > ::`
Instead of repeating all the checking if file exists and deletion code, we should probably just grab the cacheURL from the cacheSchema and call `deleteFileFromCacheWithURL:`
Why is the "returning" view displayed in this case?
I was also torn on this solution, but the alternative was to write a HelperSet for the ServiceManager and add wrappers for all commands.  The wrappers would extend off of an abstract class that would read the InputStream, take the ServiceManager and pull the appropriate EntityManager and Connection.
"the compiler" I meant the C++ compiler
The change to not use boundCount.expr means that a few of the examples aren't as good as they were.  I think you need to evaluate it before the test condition, and use boundCount in both places.

I was going to merge it anyway, but one example (uk4) shows it could be significant.
> --numRows 
vs 

> if (htPos+1>numRows)
>            numRows = htPos+1;

Does look wrong..
Please use off_t for a file size, not size_t.
Shouldn't that be:
```
<li><a href="?{{ request.META.get('QUERY_STRING') }}&amp;format=csv">csv</a></li>
```
?
Search and replace all `self.assertTrue(` with `ok_(`
Can we switch this to localStorage instead?
broken HTML.
`r.body or ''` should probably read `r.body or None`.
Yes, but not all user-agents will properly quote them. Trying to be liberal in what we accept but strict in what we produce.
The option itself should not be necessary (I am running it as is), but I'd rather have it there commented, so if itr doesn't work I'll already have some Options there to look at.
@christianv So apparently there's no way to request the inverse of a filter's output from HTML, but here's an interesting solution: http://stackoverflow.com/questions/13464809/reverse-polarity-of-an-angular-js-filter wdyt? Too elaborate?
Was a tad frustrating that the default args would be overwritten with empty string/no inputs.
there's not a direct connection there.. one possibility is to move the setting from the proxy model into the parent source model, which is directly responsible for creating the children

then, in the source model, when we create people, we can also simply do:

connect(this, sortbyfieldchanged, person, recalculateDisplayLabel())

and I guess it works out of the box
Done with 1ffa0b2.
My concern are only minor. I did envision to use the fast-export package
for other uses. In ours use case we are not affected by this limitation
since we make heavy use of temporary files. I can also fix it after merge.
Disk space usage is a huge consern in the case of huge repository. I do
plan to use this software on gigabytes history repository.

Again thank for your contribution it ils really appreaciated.

Steve Tousignant
Le 31 juil. 2012 05:45, "Li Zheng" <
reply@reply.github.com>
a écrit :

> >
> >                       try {
> > -                             int fileStatus = f.getStatus();
> > -                             if(Status.UNKNOWN == fileStatus ||
> Status.MODIFIED == fileStatus) {
> > -                                     // try harder
> > -                                     MD5 localChecksum = new MD5();
> > -                                     java.io.File aFile = new
> java.io.File(System.getProperty("user.dir") + java.io.File.separator +
> f.getParentFolderHierarchy() + f.getName());
> > -
> localChecksum.computeFileMD5Ex(aFile);
> > -                                     fileStatus =
> f.getStatusByMD5(localChecksum);
> > -                             }
> > -                             if(fileStatus != Status.CURRENT &&
> fileStatus != Status.MODIFIED) {
> > -                                     java.io.File aFile =
> java.io.File.createTempFile("StarteamFile", ".tmp");
> > -                                     aFile.deleteOnExit();
>
> Because the file is checked out to some like
> /tmp/StarteamFile991088520690484824.tmp, then commited into git, so I don't
> think it's important for user. I removed `aFile.deleteOnExit()` here and
> add `file.delete()` there just for reduce the user's disk space usage,
> otherwise, I just test again with that 2.6GB git repository, at the Java's
> `OnExit` time, there were more than 16,000 StarteamFile*.tmp files in /tmp/
> with 6.1GB total files' size.
>
> Anyway, maybe there's some mechanism I haven't understand from your
> concern, so I can fix it if you don't agree my description about disk space
> usage. Do you?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/planestraveler/git-starteam/pull/21/files#r1271535
>
Same question in auxiliary.
Why not `env`-based?
->language needs to be renamed to ->languageId and we need to verify that no code assume it is something else because of missing documentation.
I go over rendering tile front-to-back in a quadtree in our book.  It's pretty simple and really fast.  Did you consider it?
The `typeof` check is because there might not be a central body, right?  This is a potentially important case, for example, if we just want to use Cesium for previewing a model.
Oh yes, I see now.  I didn't realize that `u` was time.  Good change.
where you in the middle of a comment?
shouldn't this have a platform tag?[iphone, ipad]
Why can't we just move this line before if(passwordMask) ?
what is this `(paredit-mode +1)` ?
you should initialize it to an empty array, not to ``null``
Could you be able to fix-up and push the changes? They will be added automatically to the pull request.
Does the DummyHttp stuff have anything to do with removing easyXDM, or is this a separate issue in the test suite?
ну почему не сделать один файл со всеми видами файлов? в тот момент когда у кого-то возникнет вопрос "а какие вообще есть виды файлов"  он скажет тебе спасибо
Некоторые внутренние, но вообще нет. На них могут вешаться энд-юзеры. Некоторые прямо предусмотрены, чтобы на них вешались, и позже будут документированы.

Красивую структуру внутри не используетм — меня, в-основном, беспокоит возможность клэшей наших ивентов с нативными. Как вариант, можно сделать что-то типа `uploadcare-dialog-open.uploadcare`, тогда и клэшей не будет, и удобный неймспейс есть.

Вообще, это не столько неймспейсы у жкуери, сколько теги. Потому что повесившись на просто `click` мы всё равно получим `click.foo`.
ты уверен что false в конце недостаточно и нужны эти бесконечные е е е?
> Your change doesn't just fix isSafe, it changes its semantics

I never said otherwise.

> This is why I think we should be clear what we are doing…

I don't see changing `isSafe` as being a problem even with your proposal, since it would just end up doing what it does now anyway, since `@trusted` would be identical from the perspective of the function signature. The problem is that it introduces `isSafelyCallable`, which currently is _better_ to use than `isSafe` due to how `@safe` and `@trusted` work but which becomes completely pointless if we go with your proposal. So, we'd end up adding a function, essentially telling you to use it instead of `isSafe`, then turn around to deprecate it and tell you to use `isSafe` again, because `@trusted` will now mean `@safe` as far as function signatures are concerned. That's the only real problem that I see here. But if we don't end up going with your proposal, then these changes are exactly what we want.
> Yes, after all operation, assert(translatedLower <= translatedUpper); should be always true and can be added to make the code stronger.

It is that I was intended. You can embed an explanation about this bug with such assertion . It will increase code robustness.
Where does this address come from? Should we be setting up a separate Google Group for this?
should this return a tuple?
C'est extremement moche de devoir ajouter le class loader, l'instancier et enregistrer le namespace pour chaque classe de test, non ?
I feel calling this method CreateFromHttpContent would be more clearer.
How are these tests intended to be run? In a metro app? Then you could grab these from a text box input. From a unit text framework? Then perhaps could grab these from the environment.,
Manik opened a issue about it: https://issues.jboss.org/browse/ISPN-1841

The write skew check is not needed for all the written keys. It should be performed on keys that are read first and then written. I implemented a mechanism that detects if a key needs to be check for write skew or not.
fair enough.  removed.
This logic isn't right. The value of localeProp should be String.valueOf(properties.get(LOCALE_FIELD)).
This was on purpose so that it's known that the scope is meant to be class-wide, not instance-wide.
I wouldn't do these ```Function``` to ```Method``` replacements. We use ```Method``` for classes (things created with ```OpenLayers.Class```).
`.hover()` is actually a wrapper function for `mouseenter` and `mouseleave` callbacks, so you can't translate this to `.on('hover')`. This should be fine as-is
Hardcoded versions...
Add one more UT for both origin and azure and see that it picks the azure one.
@stof reverted, thanks for your advices
Should this still say `udp-data`?
Maybe this paramater should just be "virtualization_type"? Do we need to expose in our public config API that it uses libvirt in the backend?
as all you need is the key, wouldn't it be more efficient to flip the array instead of combining ?
Just make it Your correct way ;) I see a bug, because, I tried to move this env.py script to lib dir and so line:
    from lib import env
is wrong ;)
This does nothing though, right? happiness is commented out?
一つ上の import は不要では。
Not actually an array.

Might be cleaner to define as:

supportedProperties = {
  left: lengthType,
  ...
}

svgProperties = {
  cx: true,
  x: true,
  ...
}
aș păstra silent=True aici, poate omul nu vrea să configureze nimic.
Just curious, why setting the user agent header?
I say kill it here with "exit".
I like this idea a lot. Maybe make this a config so people can opt out? So by default the config is set to true to allow the masking, false to not mask. Will need to check this config in the this.init callback also.

Also, knowing my code analness, can you align the colons?
Better change.  Let's nix this file entirely and update `requirements/dev.txt` to not include it.
Probably better just to send the error message, if you want to log the trace it should be fine to do so if it may be necessary for debugging issues. @nukulb to confirm.
I have a slight preference for `binary`, but I don't really mind.
A better location for this comment might be up by the #ifdef _WIN32 directive. It could also be that use_threads is false because the user is processing one file on a system which does, in fact, support threads.
You can skip the isset I think, since you set a default value in the Configuration class it should always be there.
By changing this to an `issubclass` check, we now have to load both `armstrong.apps.content` (and therefore `armstrong.core.arm_content`) to create a test case for the checking of defaults.  Are you sold on the `issubclass` being far superior to the string check that was originally used?
Ahora lo agrego en el README
This was removed because its called from view controller before webview init (it was a bug on ios5.1 to change this after webview is created).
Still, although I am 99.999% sure this is correct to remove I wonder if it shouldn't be put into another patch just in case.  Calling it twice will no-op and hasn't been a problem till now.
Any positive assertions? Feels these tests are testing whether associations or polymorphism work. Are there any model specific methods (like Idea#add_comment) that should be tested?
"that that"
I think you forgot to use your message, NEW_UNIT, instead of NEW_WORLD.
who can call this when not initialized?
what is the purpose of isInitialized?
Why no CC field and why not attach an actual file?

I would update the instructions to explicitly call out which fields the tester should expect to be populated.
well, it is sort of implicit in the assumptions that this won't happen. But we want as few assumptions as possible, so this might be a good addition.
more descriptive names.
Incorrect indentation from this block and the private block