labofsahil/github-event-dataset-2012 huggingface dataset:
We'd better follow the naming convention of properyExists, propertyValidIn to name this function as "propertyVisible"
ah, wasn't that because of the special optimization that is done when type is not specified for final val. would be awesome with a comment about. I forget it all the time.
Alright. Tackling Java documentation now?
Evernote was unable to submit your note for the following reason:
The storage limit for this account has been reached.

Original message information:
From: =?UTF-8?B?VmlrdG9yIEtsYW5nICjiiJop?= <notifications@github.com>
Delivered to: thanhbv.fa84f@m.evernote.com
All recipients: akka/akka <akka@noreply.github.com>; giabao <giabao@sandinh.net>; 
Subject: Re: [akka] Minor cleanups in new remoting (#981)
Sent: Fri Dec 21 08:45:34 PST 2012

To prevent excessive emails, you may not receive another error reply
for the next 360 minutes.
s/Scalatest/ScalaTest
just FYI (i.e. no need to change): `expectMsgType[InboundAssociation].handle`
toSeq.head? Just use: y.invoke(sigar.get).asInstanceOf[Array[Double]](0)
Uses shared-state concurrency, don't do it.
How about moving these into akka.util?
You want the same name treatment for Html and Xml ?

I guess this is where an admin/wagneer would turn this on/off as an option.  In effect, by customizing their local install.
I have, and yes I need to retest.  It isn't ATP until you've done a setup/signin test after wagn:create, as well as some other account controller tests.  We need to finally get these tests into the full test set.
Gnif! Welcome back! I'd look forward to some debate team-wise as to how all the settings for AE are handled.

I know the prevailing logic is to minimize accessible setting and relegate them to as.xml rather than the GUI to reduce apparent complexity for the end-user. I had two motivations for moving these:
1) for testing purposes it's easier for users to access from the GUI and
2) for this setting specifically it's very system-dependent. The setting may need to be different for WASAPI vs DS, and within the system-specific allowable range balances audio stability (low figure) with responsiveness on seek/skip (high figure). Every capable Windows media player exposes it to the user, including Winamp, Foobar, J River, etc for that reason. I think that if properly documented (yes I plan on producing an AE How-To and Guide) we do more of a service to the end-user by exposing it with a midline default,
If have the same feeling about accessibility for other features such as audiophile mode, transcode, up-mix or anti-audiphile, etc. If we add log-entries from SoftAE::OnSettingsChange() and proper interlocks for incompatible settings it's actually a debugging tool, and a lot more user-friendly than as.xml, which is suffering it's own bloat issues.
This returns a scheduledFuture that can be canceled is the GC is killed or stop otherwise the run method will still be called periodically
m_lastReadTime was uninitialized at first call
lock before the condition so it's locked while being sorted
Is it really okey to process keypresses here? If not we should possibly pass true for the renderonly parameter, but maybe that negates the whole patch?
Then you actually want to do this:

```python
boto_logger = logging.getLogger('boto')
boto_logger.disabled = True
```
Call it "named". Check the EntityPlugin
Wonder if we really need this class
Well it will load the composer.json above the directory it is being run in. As it normally installs to bin/behat, that should mean it looks for the file in the project root, shouldn't it?
Splitting out the Upd and Tcp versions will greatly reduce the complexity of this class
At the moment, for my two apps, both pretty large scale, they seem to solve pretty quickly. But, on the other hand, perhaps a boolean property to enable parallelization for those whose layouts are more massive would seem to be better.
Yes, it doesn't try to un-serialize empty request struct.
I do wonder why you are modifying this part of the logic rather than here: https://github.com/seebees/node-1/blob/13e47b299dfcd2685aadc7d6fffb8de79efc1f61/lib/repl.js#L166-178

Any reasoning behind that?
Well, it's a bugfix too :) https.request wasn't checking server's authority even with `rejectUnauthorized===true`.
Should have checked if trait's can have default impl - I went and added {} to all implementations except for yarn scheduler !
Will do.
We tried to stick to a 100-character line length limit. If it's not much hassle and you can change stuff back, it would be good to stay with that.
Additionally: are you certain this works on any platform we support?
!fileName.isEmpty()
Ops, just noticed the constant name is wrong here, should be `ActiveRecord::RecordNotDestroyed`, right?
I will changed this then, so it will cache the connection in klass, and propose this functionality with different pull request, after that one will be mearged
I don't know if this works for all the databases, but if it is mysql specific it should not be here.
I would personally rather see

```
@env["action_dispatch.request.request_parameters"] = encode_nested_param_keys(normalize_parameters(super))
@env["action_dispatch.request.request_parameters"] ||= {}
```

But I'm not sure what the official stance on this kind of thing is. Regardless, the extra spaces around the `normalize_paramters` call is strange.
I would use `exists` here instead of creating a temporary list of which I only need one element, although I don't think this is on a hot code path.
A little scaladoc would be warranted for these attachments.
```
from boolalg import (to_cnf, And, Or, Not, Xor, Nand, Nor, Implies, Equivalent,
    ITE, POSform, SOPform, simplify_logic, bool_equal)
```
I'll change it to what you suggested.
It is not really the "matrix format".  I would call it the outer product format.
Ok that's good then.
This comment is apparently obsolete.
Nice but it should be mentioned that it is this or the others, not all those arguments at the same time.
all throughout this file I think the formatting makes it clearer what the result is. This is a case where whitespace is effective, I believe.
My guess is that if someone had an immutable matrix somewhere that they wanted the immutability for some reason.  If they just use the defaults, everything is mutable, and remains that way (especially since he made it so `scalar*MutableMatrix` -> `MutableMatrix`).
Is there any merit to having full_cyclic_form1 and/or cyclic_form0 defined?
also as i believe this type of approach would be helpful in further implementations of sin*tan,sin*sec etc.
Yii convention says the prefix “$_” is used for any not public property, this means both “private” and “protected”.
I do not like to declare anything as “private”, unless there is a very good reason for it.
“Private” directive creates a lot of problems, while extending the class and in unit testing. 

For example:
Lets image, I will declare “CManyManyRelation::_junctionTableName” as private. Now if someone wishes to create his own relation based on “CManyManyRelation” he may like to redeclare “CManyManyRelation::initJunctionData()” to specify his own logic for junction table data extraction. But he would not be able to do so, because the “CManyManyRelation::_junctionTableName” is private and can not be used in the child class directly.

Also, perhaps you do not know. Unlike such program languages as C++ and Java, PHP does not allow to overload methods or fields declared as “private”, this creates a lot of trouble while performing the unit testing using the mock objects and stubs.

If you browse the Yii issue tracker carefully, you can find a lot of requests, which sounds “change method/field from private to protected”. “Private” policy makes framework extension more complicated.
this may not be boolean, but string. You should test it on real soap server before you ask for change. it has been tested on our real project.
Now that's change, not enhancement.
Version should be in a variable on top of the class
What I'm saying is that catching TestRunnerException and then immediately writing it out to stderr and exiting... is basically the same behavior you'd get if you just didn't catch it at all and let Python handle the uncaught exception.
Why are these functions "private" (single-underscore), while all the others are public, despite the fact that only `parseDegrees` is in `__all__`?  That is, I'm not understanding what distinction you're making here
Another tweak would be to register some plugins via `Swift_Mailer::registerPlugin()`.
Extending the service looks like the right place to do that.
It would work fine with the current setup.
This sentence is not clear to me. What is "the wrong way"? Why trimming something that does not exist is a problem?
Style: split up the assignment.
add description that $0 is the executable name
I've reworked this section.
La raison pour laquelle nos pages ne sont pas etires de bord en bord est que j'ai un "container" dans le navbar au lieu d'un "container-fluid".
override vs overwrite: choose one please
Needs doc block: `@param`
Needs the phpbb_ prefix in the function name.
As per IRC: Instead of doing this, Plupload should have its own language file. The User class should have a method for returning the array of a specific language file.
$message is not used anywhere. And I don't think having a custom message makes sense here.
Actually, this shouldn't need casting to int as it does it automatically when you attempt to access an array.
It's not doing the same thing twice. One pass does a bundle upgrade, and the other does a binary upgrade.
Its not actually a packaging file, the RC file is compiled into the binary
I don't think we should put format strings like \n in a message.
Cred că putem folosi all_caps pentru constante, iar lista ar putea fi tuplu.

`APP_ON_CHOICESS = ((...`
It was name but that caused strange problems. But you are right. to_sym doesn't feel right. 


Am Freitag, 13. Juli 2012 um 22:38 schrieb Daniel Harrington:

> > @@ -8,7 +9,17 @@ module Adapter
> > #
> > # Adapter for the Net::HTTP client.
> > # http://ruby-doc.org/stdlib/libdoc/net/http/rdoc/
> > - class NetHTTP
> > + class NetHTTP < Base
> > +
> > + def self.require
> > + Kernel.require 'net/https'
> > + end
> > +
> > + def self.to_sym
> > 
> 
> 
> `to_sym` is not really intention-revealing. what about changing this to something like `name` or ... i don't know.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rubiii/httpi/pull/57/files#r1162088
> 
>
Ideally yes.  Hopefully that happens as the tests are ported to the new testing framework.

I'm punting here/now since I'm concerned about this redesign work growing in scope...
I think this is now uneeded
If it ever gets noisy, *then* we should take action to ensure we notice what matters.
If you just show the first one, then any others that you miss will have the same cause?

The reason I suggest this warning is a form of protection.
If we don't warn, the user will think they've loaded a grib message that is "handled".

@esc24, why have warnings *"...not been working well for highlighting load-time problems"*, and do those concerns apply in this case?

I strongly believe we need to keep the user informed about this issue.
Import the package for the CV class
I think we need a better way to have separate class instances in separate instances of app-cache. We probably wont get anything like this into 1.5, but that is another issue...

Really, what we want is to have an empty app-cache where we can load clones of existing class instances by something like app\_cache.load\_models(*models). Currently, the only way to do app-cache loading is by meta class \_\_new\_\_(). I think app-loading should be launched by meta.new(), but it should just _launch_ it. The actual work should be done by some other method which could be launched by other means, too... We would also need to clone the _class_ of the model, and this could be problematic.

If we got something like this in there would be the possibility to alter model clones in-fly whenever we want. This would be a huge bonus for testing. We could probably also use the core ORM for schema migrations, which could be a nice feature. Just unfreeze + load to temporary app-cache and give that app-cache to the developer. Could work, no?

To actually do the above is a lot of work, and seems to be closely related with the app-loading refactor. So, for the time being lets try to invent something as-simple-as-possible that could work for this feature's needs. I still do think the code as-is looks scary.

Sorry if this got a bit off-topic...

(And thanks Github for not confirming close of this form when pressing Esc, very user friendly feature)
Hmm... well it is working fine for me on two machines: my main desktop and a VM running a pristine copy of SL. Got GIMP 2.8 up and running using #8835---although I am not a heavy user so I didn't do much more than load up a few images and paint around on them and apply some filters.
probably, git wanted to be smart.
I'm not really sure what you mean.

The 'mock agent' is literally just a mock.Mock().
When logging you should add some sort of information that helps identify the source of the message. E.g. `Session store: destroying expired session: sid`
Is this comment still relevant? Can it be removed?
This does some bad things to the method cache in MRI. Is there another way we can do it without extending objects on the fly like this?

Maybe we can use a proxy object that wraps the Hash instead? A Hash subclass would also work, and might be better.
what about trying ` if [ !isMac &&  !isLinux ] ; then`  ?
I think the Hamcrest syntax is better. That being said, I've never needed
to have a test assert that some value is less than another. Perhaps this is
more common with Theories.

From what I understand, getting Hamcrest to work with JUnit could be
non-trivial. I haven't seen much movement on that front. If we believe that
these kinds of assertions are useful and common, and we don't have anyone
actively looking into getting Hamcrest to work, then I think we should make
another iteration on this pull request.

On Mon, Mar 19, 2012 at 2:05 PM, Marc Philipp <
reply@reply.github.com
> wrote:

> > +             assertLessThan(NULL_VALUE, NULL_VALUE);
> > +     }
> > +
> > +     @Test(expected=AssertionError.class)
> > +     public void assertLessThanShouldFailWhenReferenceNull() {
> > +             assertLessThan(null, REFERENCE_VALUE);
> > +     }
> > +
> > +     @Test(expected=AssertionError.class)
> > +     public void assertLessThanShouldFailWhenActualNull() {
> > +             assertLessThan(REFERENCE_VALUE, null);
> > +     }
> > +
> > +     @Test
> > +     public void assertLessThanShouldPassWhenActualLessThanReference() {
> > +             assertLessThan(REFERENCE_VALUE, LOWER_VALUE);
>
> Sounds fair enough. I'm still in favor of using Hamcrest though because
> it's already build-in:
>
> Compare
>
> ```java
> assertThat(x, is(lessThan(y));
> ```
>
> to
>
> ```java
> assertComparable(x, LESS_THAN, y)
> ```
>
> I would prefer the former version as I find it more readable.
>
> @kcooney: Which would you prefer?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/KentBeck/junit/pull/376/files#r576819
>
Why do we check for err here, but not in the call to currentRevision? Seems like we should be consistent about how we handle these errors.
Huh. Was wondering about that. Figured it was legacy code of some type.

I can imagine bad things happening with this setting... say I wrote a quick plugin to double Ender Pearl damage, or make each use summon a dragon, or whatever. Shouldn't there be a change made in VoxelBorder to allow TeleportCause.PLUGIN?
It's just for tour.js—the "blessed" tour is the main tour that drives the app, and gets to write its config settings into mulberry.app.Config. (Basically, it should only ever be set true here.)

There's a comment in toura.adapters.tourjs to that effect.

On Wednesday, September 19, 2012 at 12:22 PM, Chris Barrett wrote:

> In app/toura/Bootstrapper.js:
> > @@ -20,11 +20,12 @@ var bootstrapper = function() { > tour = new toura.adapters.tourjs({ > remoteDataUrl : app.Config.get('updateUrl'), > remoteVersionUrl : app.Config.get('versionUrl'), > - source : 'main' > + source : 'main', > + blessed: true  
> What is blessed for?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/Toura/mulberry/pull/572/files#r1641572).  
>  
>  
>
These alerts should be changed to console.logs or just removed entirely.
I'll remove it. It was there because there are now View menu sections yet (since we won't have a lot of menu item there). 

-----Original Message-----
From: Peter Flynn [mailto:reply@reply.github.com] 
Sent: Thursday, May 24, 2012 4:27 PM
To: Ty Voliter
Subject: Re: [brackets] Menu and Command and Shortcut Extensibility implementation (#936)

> +     * in terms of a menu section rather than a specific MenuItem. This provides
> +     * looser coupling to Bracket's internal MenuItems and makes menu organization
> +     * more semantic. 
> +     * Use these constants as the "relativeID" parameter when calling AddMenuItem() and
> +     * specify a position of FIRST or LAST.
> +     */
> +    var FILE_OPEN_CLOSE_MENU_SECTION         = "brackets-file-open-close-menu-group";
> +    var FILE_SAVE_MENU_SECTION               = "brackets-file-save-menu-group";
> +    var FILE_LIVE_MENU_SECTION               = "brackets-file-live-menu-group";
> +
> +    var EDIT_MODIFY_SELECTION_MENU_SECTION   = "brackets-edit-modify-selection-menu-group";
> +    var EDIT_FIND_MENU_SECTION               = "brackets-find-menu-group";
> +    var EDIT_REPLACE_MENU_SECTION            = "brackets-replace-menu-group";
> +    var EDIT_SELECTED_TEXT_COMMANDS          = "brackets-selected-text-commands";
> +
> +    // View menu edit group placeholder

Not sure I understand this comment.  Was it supposed to get replaced with another constant?  (Placeholder for a placeholder, if you will :-)

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/936/files#r878933
Other places in this function return a boolean value, so I think the end of function needs to ``return false;``
Sorry, I missed this. I should have synced and ran JSLint. ``else if`` should be on the same line as the close brace.
Moved event triggering to the command itself per Ty.
Actually, getSelectedRange **is** correct here, since it returns and object and not an index. Underscore added and unit test updated.
I guess another side effect is that, for now, there are two different possible return values of _getCodeHintList() when no list is open: either null, or a CodeHintList instance where isOpen() return false.
Yes, this bails if we find more than FIND_IN_FILES_MAX in a single file, but it should not ignore subsequent files.

With that said, if I search brackets/src for "e" I get:
- With my fix: 63932 matches in 937 files
- My fix commented out: 684037 matches in 1106 files

I am not seeing the problem where it only searches 1 file. Any ideas why it would search less files?
We should probably improve this configuration so that the number of threads can be specified per client type. Also, its not entirely obvious that this setting is per client which might be a bit confusing. I'd just add a comment to that effect (Ie, "Total number of threads is client_threads * num_client_types)")
It's the only way.
Can do you `b = -1, r = -1` here?
Not that I don't like Virtus, but I would remove the word "nice" and link Virtus to its source.
Lol nice.  I just realized that /nav returns the topmost layer of the menu items.  I'll just use that.
OK thanks. :)
Makes sense so i changed it.
Why don't you move this out of the if-clause and you will have to have it only once in the template?
Name of the language displayed to the user should be in that language, not in current user's language. (How does an Englishman know how English is named in Slovene?)
Use maybe `fb.get('id')` so that it does not throw an exception (and 500) if it does not exist?
Don't hardcode. Or at least move to settings (or use existing settings).
This is my interpretation of your previous comment. I guess you meant that we should modify the model to use `uuid.uuid4` as the default for the field. This is a good idea. Will it require a change to the DB? I don't think so. I hope not because we don't have south yet.
we should make it so we can do this in a loop as well
Why mix synchronous XHR/returns with an event dispatch?
Any reason to not use the existing requirejs text plugin to load HTML?
You probably want a period at the end of this sentence.
Why do you need this inner closure?  You're already wrapped in attachInputChangeHandler, so local variables will be bound after it exists.
Again, another general curiosity. Is this something needed for such a small amount of tests? If so, I need to get this in for mine as well.
I'll file a bug for 0.6
Actually, nevermind. https://github.com/dseif/butter/tree/t685 looks fine.
move `mozL10n.get(..)` expression to previous line -- don't disconnect mozL10n.get call and fallback text.
We no longer want/need examples in the `standalone` dir.
might make sense to make this into a function so it can be called prior to the SSL call and again after without needing to open code the checks in both places.
fail is a bit harsh
This import  breaks on App Engine
```python
ImportError: cannot import name wrap_socket
```
Minimálně ve Windows se "špatný" nemá používat a malformed se navíc má překládat podle kontextu jako "chybný ..." nebo "poškozený ...". Ještě lepší než můj původní překlad by asi bylo "Chybný formát hlavičky: '%s'"
Spec without version tags should be added as 0.0.1. You are also responsible for asking authors to add version tags. We have [template](https://github.com/CocoaPods/Specs/wiki/%22Please-add-semantic-version-tags%22-issue-template) for this in wiki
using d_cdb right after cdb_free is probably illegal. Other way around would be good.
Any reason you had form submit to begin with?
why the name "CustomInfosMethods"?  Is this just a helper? this looks like it should just go in src/app/helpers/custom_info_helper.rb

also, why the plural of CustomInfos, seems like it should just be CustomInfo like everything else
We need to have consistent indentation: 4 spaces each time
"astrono" -> "astronomy" ? Everything else looks very nice!
I don't fully understand the intricacies here... but when I just copied and pasted your code, one of the tests started failing.  @iguananaut, do you think you could issue a PR against this branch ("coordinates" on eteq/astropy) to do what you're suggesting here?  Or @demitri, perhaps you can shed some light on this (I think you wrote this part?)
``rehash`` doesn't work in bash
I get it, but why remove call to register stats mod? If the stats sup crashes and is restarted it won't be able to restart the core stats unless the mod is registered.
Sorry, was trying to be funny and failed: http://www.endofworld.net
I would prefer not to have to access pWalletMap->wallets directly...but using BOOST_FOREACH like this is quite convenient.
Alright, that can be changed and thanks :-D.
My point was MAX_URI_LENGTH is used in qtipcserver.cpp and qrcodedialog.cpp. Now both of them include guiconstants.h., which seems just fine, no? qtipcserver.h is of course not included in qrcodedialog.cpp.
this is a neat trick, but why the Yoda commenting style?
I don't think the JsHelper version is the better of the two.  I've yet to ever see a single additional method call that basically does an unset() be a big problem.  I'd rather have a simpler less redundant API.
Would adding stuff to configure not work at this point? Or is it to dirty?
yup.  i thought of that too but wanted to avoid introducing a new option.
but i agree it's cleaner and less hacky.

I'll adjust the PR.

Thanks.
I'm interested to know whether `ID NULL` is standard SQL, or a mapserver-specific thing. Just for my personal knowledge.
why the empty line before the closing bracket?
Sounds good to me to unset it, it's not meant to be used. In the same point, I think $_GET['value'] can also be unset.
Eventually,
```php
elseif (isset($_GET['filter']) || isset($_GET['value'])
{
unset($_GET['filter']);
unset($_GET['value'];
}
```

The other issue, with $filter not initialized, will need it set from the start and the rest of the code fixed to check for empty() because (much of) the rest of the code checks for isset($filter)
(example [L61](https://github.com/Spuds/Elkarte/tree/880383526a244fae1c1a7e2f77922b5a4d084830/Sources/admin#L61))
You're right, I was a bit too much focused on shell. In the shell move up won't work and now I know the reason multi-line prompts in Terminal.app won't work.

I'll change the move-right/left to you suggestion.
I am aware that a tick != a second and that the code you suggested should work, as that was how it was in my original implementation. However, doing that causes every game I can find that uses the call to set ticks to something so high that localtime and mktime can't convert it to a date. This leads me to believe one or more of the following are true:

1) that we need to make a function to manually convert from ticks to ScePspDateTime as the games try and set the data to something stupidly in the future
2) the games are not expecting that 1 second = 1000000 ticks. Maybe the tick res needs to be calculated some other way?
3) It needs some sort of error checking and failing if the dates are wrong.

So that's why i've marked it as a hack. If it's a problem I don't mind at all if the changes get backed out.
I am sorry for the ambiguous name, rename_existing_notebook, it creates a fresh copy of the existing notebook with timestamp appended, but also saves the file which was being renamed by the same name

So, where should i use os.rename? for the existing (older) file, or for the file which is being renamed
These functions were added because there is shared functionality (parse, highlight, generateHTML, callback) between them within the body of process.stdin.on and fs.readFile. There are three options I can see

- Repeat the code
- Move the branch and `process.stdin.on` and `fs.readFile` upwards into the caller, changing the `generateDocumentation` filename parameter (`source`) to a code parameter (`buffer`)
- Move the shared functionality into a seperate function (basically as above but changing `document` less)

Is there an approach I'm missing?
removed it altogether, no need for eq/hash here
This is a good point, but still it is not completely clear to me. As you can see there is a check 

if (session.getState() == SessionState.Locked) {
             // Remove session lock taken by launchVmProcess()
            session.unlockMachine();

that passes correctly, but probably another thread after that asks the same question and the answer is different. In other words we need to test the state from an external thread cause ISession.getState and IMachine.getSessionState() return different values.
my bad, forgot about __call($method, $arguments)
Same here about outputting the form input as above:

```jinja
{{ sms_form.optin.label_tag(sms_form.optin ~ _("I'd like to...")) }}
```
I know! It's making me crazy and resort to these last-minute hacks. Blargh!
Empty rule.
It isn't using KBox now, so you can remove it from the list right?
I wouldn't mind if this is moved into some private utility function as part of the class. It repeats itself a lot.
Thanks, this was added
Yes, that is more efficient, and in keeping with the ethos of PyroCMS.
Inside the class that is throwing em should be fine 

-- 
Phil Sturgeon


On Thursday, 6 December 2012 at 13:44, George Petsagourakis wrote:

> InstallerException
Shouldn't it be getting `'Content-Type'`?
I only have ORM projects with this use case ATM but could set one up tonight for the ODMs if needed.
Twig expects a `Twig_FunctionInterface` object here, of which Twig itself only provides two implementations:

* `Twig_Function_Function`
* `Twig_Function_Method`

Your argument applies for both. The only other solution is to provide a custom implementation of `Twig_FunctionInterface`.

My conclusion is that, should Twig ever implement stricter checks here, we can still create a custom implementation of that interface to fix the issue for us.
removing the `logout` method is not BC.
`0 === stripos($authorizationHeader, 'basic')` ?
should be `hasDefaultRouteSet` (no `s` at the end of Routes).
I like the suggestion and will add the new message.  The thought did cross my mind.  I was thinking I would have to worry about too many types.  The new method will not handle primitive types so objectForKeyOrNil will be used for those cases.
You have to add handle the exception where it happens - or at least, the nearer to where it happens. Concretly, we don't use exception in Scala safe to stop the program (i.e: when it starts with a bad config, or something really bad happens - but theses cases are rare, for example a "thread kill exception" or something like that). 
And perhaps the previous code was not OK, but that's no reason to mimic it :)
@ctosco El id lo tenés que traer del form no del request. Por eso, dentro del `if ($form->isValid())`deberías hacer un `$form->getData()` (o un método similar, ver en la documentación), y de ahí traer el id, que está en el campo id. Si el formulario no está asociado a ninguna clase, con `getData()` debería devolver un array, tal como lo hace en los filtros del *index* de **Destinos**.

Si realmente querés complicarlo un poco más hasta podrías hacer un DataTransformer y asociarlo al form para que transforme el id en usuario y de usuario a id pero, por ahora, con solo traerlo desde el formulario y no del request alcanzaría. Otra forma sería asociar el formulario a la entidad User, de esa manera esquivarías el DataTransformer y con `getData()` traerías directamente el usuario y no solo el id, el cual podrías pasar directamente a `deleteUser()`. Además, de esta manera, si uno ingresa un id de un usuario inexistente el formulario no debería ser valido, en el caso de falsear el POST.

Para esta última opción tendrías que modificar el método que crea el formulario para aceptar la entidad User y, de no haber un user se puede usar un form vacío poniendo en la definición `function createDeleteForm($user = Null)` y omitiendo el `array('id' => $id)` (en este caso $user) del `createFormBuilder()` en el caso de que $user sea Null. No entiendo porque en el BackendController de DestinosBundle y TestimoniosBundle al deleteAction se le pasa el id dos veces, en el POST vía formulario y como parámetro de la URL. Se supone que el POST es para asegurarse que no se ha modificado la información en tránsito (con el csrf_token) pero si estás usando el id de la URL mucho sentido no tiene usar el formulario.

Pero igual, si estás siguiendo ese ejemplo (de pasar el id en la url), entonces quizás tengas que agregar el id al `path('fos_user_profile_delete')` de **edit_content.html.twig** y volver al ponerlo en **profile.xml**.
@skelterjohn The `Log` method returns an `error`
Yeah, sure, my mistake
ids are never reused so you don't have to worry about it changing out from underneath you.  And if you enter an invalid id, then access::can("view") will fail.  But I agree that if we get an id of a non-item it'll screw up the underlying search.
hardcoded python executable? Uhhhh...really?
Reverted line back to 1.8.24 version.
You can tell me I'm to late ( ;) ), but can we have just 1 `while` loop and add the `if-else` around the `newPhoneNumber =...` line ?
Sorry about that, that's my pre-2000 skills that comes back ;) I will address the comments except the one for /shared/ since it works and I don't want to generate a new copy.
There you go, if was not only JavaScript... :-p Thanks!
To make this easier to review, here's the code that interprets this, showing it looking for "textLayoutOverwrites": https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/keyboard.js#L628
"unknown" instead of "unknow", please.
$body === document.body ?
I think Latin1 is only considered safe to do this if `charcode < 128` (this depend on exactly which Latin1 encoding you are working against)
localize it please, in other PRs could be as well
Can use l10n functions here?

@etiennesegonzac already applied the l10n functions to the rest of dialer and makes sense to not to miss any string here.
ok, will be changed
always `AM`?
Yeap, right! Including it right now :-)
You accidentally a a word.
if-statements should have a space between 'if' and the opening parenthesis.
UploadToken(args) , args 能改成opts {key:val}形式更好
qiniu.token 改成 qiniu.auth 比较好，后续重构 digestauth 也方便整合下，比如 qiniu.auth. UploadToken({...}), qiniu.auth. AccessToken({...})
since we're calling the file .rspec-local, I think we should rename local_options to project_options and use local_options for .rspec-local - WDYT?
Actually, the more I think about this, I'm not sure it makes any sense (even though I said it should).

Here's the issue, if the HLLInstance has a different size, then after the hash of an item, we compute j differently, i.e., we use a different number of bits to represent j (the bucket we are putting the \rho into).

If the other, larger, instance already saw the item we have hashed in the smaller, they will have different values of j. We can only guess which buckets j in the smaller will correspond to in the larger.

You might be able to prove bounds on the error introduced, but I think the safer (and more computationally efficient) approach is:

assert(v.size == other.v.size, "HLLInstances must use the same value for m")
Document what this is, as well as any other variables at this scope.
Needs investigation
After playing around a bit with the client, I think there's not much need for a Start/Stop button. Why not start the client as soon as it's opened and stop it when the window is closed? It will make the client easier to use. Also, the current implementation is buggy, so if you eliminate it then you get rid of the bugs without having to fix them. What do you think?
Both the generic groups and the MOUL groups are stored this way. I was constantly confused by some of the flags being the bitmask, while some just store the offset. Also, the generic member group property does *not* store, for example, 0x02 for some group, but 1, i.e. the offset of the group this object belongs to.
If you broadcast the message to every channel the player is in the player will get duplicate messages. This should probably only broadcast in the default channel.
'that have currently been moved over' ?
All right, opened #541.
more like "zeige {:current} von insgesamt {:count} Einträgen, beginnend bei {:start}, endend mit {:end}"
I will make a PR in the next few days. I've some ideas to develop ;)
this is not needed. $output will be deleted anyway at the end of the function as it is a local variable
it is not valid in package names, but here, it is the pattern entered by the user. and nothing forbids the user to enter an invalid input.
you forgot ``RC``: https://github.com/composer/composer/blob/master/src/Composer/Package/BasePackage.php#L41
`var` declaration needs to be done at the beginning of the function. Variable hoisting does it anyway.
See above. This is the correct code.
Better to use: `previousBuild.getResult().equals(Result.ABORTED)`
Wouldn't it be possible to simply output `key` here?
what's the point of this method? Why not just inline this in `bind_port`? It doesn't appear to be called from anywhere else.
I think it would be better to define this array at the top of the file as constant 'LOCAL_URI_SCHEMES' or something.
This does not looks necessary
can we add this to the const statement above?
By reading your code we can see what it does but not why.
Why are you adding an empty string in this parametersList variable?
I suggested you to write the response to this question in a comment ;)
what does "TEMPORARY" mean?
@lloyd - good eye - this console.log message is intentional since it is in the tests.
author of jschannel is a doofus, he shoulda taken a page from vows, perhaps.
Fix this :)
After removing the properties for tag_results.py what can I use for the Assert.contains outside of expected text? I have no page attributes to reference.
maybe getClassName of  Propel\Generator\Model\Inheritance could be renamed to getClassname ? 

Do we want to normalize Classname vs ClassName (maybe another issue for that)
Maybe it's better to write:

```
$object     = $this->context->getRoot();
$peer       = $object->getPeer();
$className  = get_class($object);
$queryClass = $className . 'Query';
$filter     = sprintf('filterBy%s', $peer->translateFieldName(
    $this->context->getCurrentProperty(), BasePeer::TYPE_STUDLYPHPNAME, BasePeer::TYPE_PHPNAME
));

if (0 < $queryClass::create()->$filter($value)->count()) {
    $this->setMessage($constraint->message);
 
    return true;
}

return false;
```
I am wondering if this should not be part of the execute method. Facter 1.6.x already sets `LANG=C` on a global scope in `facter.rb` and in Facter 2.x `LANG=C` is set in the execute method (https://projects.puppetlabs.com/issues/12012). So if `LANG` alone does not do the trick, why not changing the other locale (like LC_CTYPE and LC_MESSAGES) as well?
Good catch on adding `@name` to the error message.  I totally should have done that and will add it.
This is the kind of line where I feel like a comment explaining why you are doing this would be helpful to the next person.
Might as well call the new class directly
In the Ruby DSL I can do this:

<pre>
# at the top level in site.pp
$resolved_hostname = generate('/usr/local/bin/rdns-lookup', $ipaddress)
</pre>

That will be evaluated in global context for each node, and allows users to create a "fact-like" value at the top level.

You should, at least, make clear that the restriction only applies to *Ruby* manifests, not to Puppet DSL manifests.  Ideally, of course, you would allow the same behaviour. :)
You can actually take out the deprecated invocation bits that triggered the warning while you are in here.  That helps eliminate the entire ugly code path that triggered the original need for this. :)
@vrthra same comment as above
as the `i`s have the scope of the for loops, it wouldn't save memory declaring the `i` before, would it? I think scoping it to the `for` loop is cleaner
This line caused textfields that use a display filter to be overwritten with the filtered content. This is problematic with password fields for example as the password is overwritten with the password replacement character.

After all this line is a left-over of the old text box and serves no real purpose anymore as the text does not need to be initialized again.
This should be `JsonException\ExceptionInterface`
I like ternary operator for assignments.

If there is a problem with this and the metrics then (IMO) the metrics should be fixed to understand this kind of syntax correctly
The additional code is introduced because it mimics the url() behavior. When `$this->getRoute()` returns `null` the url helper uses the set routeMatch to identity the matched route name. Because the router needs the route name, the MVC page has to get the name from the routeMatch object self now.
Thanks, updated to new format header
Oh, no, you're right.  You can set Explode's composed validator to anything.
This comment seems out of date now.
Indentation formatting.
Nah, please don't, soft wrap will do.
and btw, you should generate the ETAG before building the whole feed to do the logic only when really needed. Generating the ETag should be possible as soon as you know what should go in it. No need to wait after doing all the ``Zend\Feed`` processing.
@anti Kaikki meidän indeksit tilausrivi-tauluun joissa on tuoteno on tyyppiä "yhtio_tyyppi_tuoteno". Voisko tähän ottaa ton tyypin mukaan? Eiks toi oo nyt aka hidas?
Can't we use a switch true here and avoid all this if/else?
``break`` is useless here. It is a dead statement as you return before it
Should be a join.
To be honest, I have no clue how it ended up in here.

It's only a change in the documentation string for the 'type' option for CP2K, and it's a correct change.

But, if you insist, I can get it out to keep this pull request clean, and then open a different pull request for this minor fix (which seems like overkill, but fine). 

Let me know.
You need to revert all changes here and start again.
We don't want to have any non-ngx stuff here. Put it in your local ignore/exclude file.
part b - line 71-77
Something in my head about ensuring that it didn't alter the list in place but made a copy, without realizing that the addition probably already makes a copy.

A more esoteric reason would be for in case CSP_FRAME_SRC gets any more magic on it in the future and is no longer a tuple, this will work with any iterable, but that wasn't why I did it. Oh well! :D
So we don't see the Bookmark External Work button on the top of other users' bookmark indexes, because that was kind of weird. It will still appear on your own bookmark index, the main bookmark index, and the bookmark index in a collection.
@podviaznikov Thanks for the pull request, Eveything looks good except this line. As you can see from here http://developer.github.com/v3/orgs/members/, this thing is wrong.
Whoops... this should have been `localFileExtensions.add(...`
fnameescape has more bugs that can't really pass to the original
argument to command(without !). This is famous issue in japanese vim
plugin developers. So they use:

```
:e `=file`
```

to avoid strange behaviour. I didn't know this way also have problem. Thanks.
As you point, my solusion is NOT best. It's bits longer. And it change
wildignore even thought it's in temporally. If the script contains
code that check wildignore, it won't work expectedlly. :/

So... pass to @thinca 's judgement. :)


On 6/8/12, Ingo Karkat
<reply@reply.github.com>
wrote:
>>
>>  function! localrc#load(fnames, ...)
>>    for file in localrc#search(a:fnames,
>>    \                          1 <= a:0 ? a:1 : expand('%:p:h'),
>>    \                          2 <= a:0 ? a:2 : -1)
>> -    " XXX: Handle error?
>> -    source `=file`
>> +    try
>> +      execute 'source' fnameescape(file)
>
> @mattn: What's so bad about `fnameescape()`? It was created explicitly for
> this use case; I use it in almost all of my plugins. The bug with `!` isn't
> that serious (would be great if you could actually fix it, though :-)
>
> Your alternative is long and cumbersome, and you have to put the last line
> into a `finally` clause to be sure that it gets executed when the sourcing
> causes errors.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/thinca/vim-localrc/pull/2/files#r950964
>


-- 
- Yasuhiro Matsumoto
@acidmoose I have tried Jetty and start() is not blocking, i.e. it runs the server in another thread. Therefore calling base.shutdown is not a good idea, I conclude.

If Base requires that base.shutdown is called than it should likely add shutdown hook to the JVM, similarly as Jetty itself does.

I consider this topic closed.
I ended with a different implementation that bypasses the need of an external file.
fix function bracket alignment
Wrapped to the same line; intentional?
это не лучшая идея для многопоточных приложений. const метод не должен менять переменные
тут не достаточно оснований на это мне кажется
代码和注释之间也应该留一个空白。
It’s used everywhere in the tests, so I just copied it. I’ll change it then.
i think your missing a closing `</ul>`
run thru validator prior to pull request to catch these things
Since your success and failure cases are almost identical, I'd suggest a `goto OUT` model instead:

      gboolean success = FALSE;  // at top of function

      success = TRUE;  // at end of processing
    OUT:
      // clean up
      return success;
They actually used to be in the test tree, but we moved them because benchmark uses them to tweak the catalogs it submits.
@phiggins you were quite correct; I have updated that.
So in that regards, I think for this example, `>>` is more appropriate
This can probably be checked in the createFile function
A line of documentation here.
I would make it so that:

* global admin UI
/api/config --> global config
/api/config/:tenantId --> tenant config
* tenant UI
/api/config --> tenant config
Will need to !hide this header.
Mention official binaries for the projects, and that they are all named to correspond to how the python.org binaries are named?
I'm using base64 because quoted printable created problems in the past for certain MUAs.

For quoted_printable, quoted words had to be encoded seperatey for some reason. I don't know if that is still the case for base64 headers. That's why the fixme is there. I guess I'll just have to try it.
might as well do `if (app.settings.etag && len > ..)`
I think I'd rather the entire details section be in larger type; it's a bit small and anything tappable is a tough target right now...
Oh jeez, that's way better. Works with {error: @cohabitant.errors.any?} Thanks!
It seems that setting HttpOnly=true on this would be a great mitigation against XSS attacks.
Как уже написали выше, здесь тоже можно использовать arc4random_uniform([dict count]).
Вы немного отступили от задания
```
6. Создайте категорию mutator класса Cell. В ней опишите метод mutate, который возвращает void и принимает int.
```

у вас mutate не в категории
А есть гарантия что рандом не сгенерит один и тот же индекс 2 и более раз?
не знаю точно как корректнее обрабатывать сравнение в obj-c, но так работает, проверено
`[Cell getRandomDNAMark]` может вернуть тот же символ, что уже был на этом месте в ДНК, таким образом мутации не произойдет. В итоге число мутаций будет ориентировочно на четверть меньше, чем требуется.
Hmm... Methinks you be wrong. GenericItem, GenericTool, etc are all just stubs.
Any idea on why does HTTParty define methods to the class instead of to the instance? Moreover, if it defines methods to the class, why not use `extend` instead? It's ugly to call `self.class` each time!
As you might have noticed, I don't like lingering TODOs in the codebase.

What can we do to remove this guy? :) Do we care about *undefined* values?
Mmm, does it come from -ruby or -jvm?
Feel free to merge fix some cosmits and merge upstream
Er, in what way?
This has been moved to onAttach
@killme2008 应该是unsigned
faces : int array, shape=(n_faces, 3)
";" :) ... matlab user :)
> .... There already is a copy arg set to False in Epochs.crop

arfff I thought Epochs.crop was not returning anything. So let's do
the same here and return a new Raw instance with copy=True by default.
I'll delete this expression
I don't agree with the %Q{} syntax here (and later in the code) because there's no string interpolation. I prefer:

```ruby
'checked="true"'.html_safe
```
You should remove the parentheses
位置统一成路径吧，就是location=>路径

一个上下文里的请求在处理结束的位置会被记录。
实际上类似这个意思
请求在处理结束时，按请求路径的配置上下文记访问日志
If I replace shoulda with shoulda-matchers the tests fail.
https://github.com/thoughtbot/appraisal/blob/master/features/gemspec.feature asking for shoulda explicitly.
doesn't seem to work. get errors when only including `cucumber/rails`
Do you want to publish prior to register?
Ну и нахрена тогда вообще этот деструктор?
Ftp address is missing
please fully open and close html tags, this is not legal to write `<td/>`
see http://www.whatwg.org/specs/web-apps/current-work/multipage/syntax.html#start-tags for more informations
Fixed 'text-only' into 'text-summary' as noted.
This looks like a micro-optimization, as an accessor costs virtually nothing compared to other operations. Moreover, this fix shows that this micro-optimization was done wrong once, and can be done wrong later, because nobody may update the map view without also updating the map controller, and we have no way to enforce that if we keep two separate fields.

Without any evidence that this solves a performance issue (and I doubt we could show that), I think we should remove it without any hesitation. This makes the code simpler, easier to understand, and more solid, by removing an inter-dependency that it very easy to break inadvertently.
We've got to get some kind of lintroller to update these dates everywhere.
Why not batchQueueSizeThreshold?
This should be moved to a @Start method rather than @Inject since the cfg may change between injecting and starting.
This wasn't a good idea, was it. I will return it back.
Agreed. See ccce78f.
> Why not just np.min(n)?

This would work as well, but for a small number of bins (default is 10), the min of mins is faster.
Ну собсно о чем и речь, и лучше всего думаю это сделать интерфейсами.