labofsahil/github-event-dataset-2012 huggingface dataset:
With the option `collapseEmptyLines` is set to true value, the editor will discard the auto-inserted indentation spaces when `<Enter>` is hit. For example, type this (without the line numbers):

    1 function foo() {
    2   var r;
    3
    4   r = 13; 
    5
    6   return r;
    7 } 

Starting at the end of line 2, I type `<Enter><Enter>` to get to line 4.

Without `collapseEmptyLines`, lines 3 and 5 will contain space characters which were inserted to indent the line.

* Applies both with and without `smartIndent`.
* Does not apply when replacing a text selection.
it is not really about preventing conflict. It is about identifying the type to use it.
BCC should not assume an array either -- perfectly reasonable for a single BCC to be provided:

```ruby
options["Bcc"] = Array[message.bcc].join(", ") if message.bcc
```
Then set it to "warning" and not "warn" in the first place! :)
In general, class variables should be defined at the beginning of the class, before methods.
Same comments than https://github.com/KnpLabs/KnpLastTweetsBundle/commit/01eabeb5797ff58f67c8c69df5c729d6a89e7a63
funciona pero peta a veces se como hacer no pete pero no me gusta como queda lo testeare a fondo antes y intentare arreglar otro bug del arena score junto

http://img692.imageshack.us/img692/7047/screenshotxbl.png
You can't depend on the default module. The default module can't depend on other modules since it doesn't have a `module.ceylon` file, and if it did, it wouldn't be in the default module.

The default module can't be published to non-local repositories, but local is fine.
If you'd have time that would be great. Code is our strongest bearer of knowledge ;-)
Thanks Ross
Hello Nathan,

thanks for the feedback.

I've been away and I havent looked on the points you make till now.

I was a bit concerned about the naming conventions but I never got to ask.Ill change that.

In your second issue are you suggesting to create a class hierarchy whit a base class called FieldValidator and a number of derived classes for each type (like IntegerFieldValidator or DateFieldValidator)?

I see what you mean in your third point. But, in any case, I think that I need to have of the profile fields related somehow (and the equipment and sport). I mean the fileds cant be tested independently. Imagine they are two wrong fields, after fixing one you should still be able to show the message about the other field.

I dont really understand your suggestion about custom widgets. Can you elaborate a little bit about it?

I'll try to do some code refactoring and make a new proposal.

RODOLFO 


________________________________
 From: Nathan Jones <reply@reply.github.com>
To: rgonzalez72 <rgonzalez72@yahoo.com> 
Sent: Monday, 30 January 2012, 9:52
Subject: Re: [pytrainer] Working on issue 81 (4234291)
 
Hi Rodolfo,

I have three main issues with this code.

Firstly, your naming conventions are not so good. Python variable and method names should all be lower camel case and you should avoid using non-descriptive names. For example, "validateFields" should be "validate_fields" and "retVal" should be "is_valid".

The second issue is use of the "type code" anti-pattern. Instead of passing around type codes and looking up related properties in maps you should just have different objects for each type which contain the properties directly.

The third issue is that you have unsuccessfully tried to make a generic input validation framework but have only made the code more complicated in the process. "FieldValidator" sounds generic but it should actually be called "ProfileFieldValidator" because it has built-in knowledge of those specific fields.

I would expect a better generic approach would be to create custom widgets which implement some validation interface and fire "validation_state_changed" events to indicate when they become valid or invalid.

--- 
Reply to this email directly or view it on GitHub:
https://github.com/rgonzalez72/pytrainer/commit/4234291653c4447c5cae56a45c1844f93798eb37#commitcomment-913474
I'm just worried that evaluating the SearchQuerySet is going to throw 500 errors, the way it was before when the indexes were down.
This introduces two changes: First, it prevents people from using the localtv/feed/title.html template; second, it doesn't mark the video title as safe, as the template does. This part of the commit should probably be reverted.
Since both Java and Python supported nested classes, and because
that's the way it was in the Java Source, I did it this way. But
you're right, not only your IDE, but even Pickle freaks out with
nested classes. So we can feel free to start un-nesting classes. I'll
create an issue on git hub for this and we can all start working at
it.

Timothy

On Mon, Feb 20, 2012 at 8:11 AM, John Jacobsen
<reply@reply.github.com>
wrote:
> Sorry, couldn't find where Frame was imported from -- but I see now it's defined above as an inner class (why?), which my IDE freaked about.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/eigenhombre/clojure-py/commit/bcdb394f50c33bc697fcf434c65d0535373210be#commitcomment-985732



-- 
“One of the main causes of the fall of the Roman Empire was
that–lacking zero–they had no way to indicate successful termination
of their C programs.”
(Robert Firth)
I kept the migrations in the host so as to keep Enki-Engine simple - you might not want to force an author_id - and the engine has support for simple authorship info (via the config file).
Oops, typo! Can't believe that made it past for so long (I've been using the same `utopia.js` in other projects.
Or chara db is broken from https://github.com/TrinityCore/TrinityCore/commit/65d269f6de2da9c7c26e9177d7cfcb0498782089 :-/
```SQL
(@Bag,4,4,1,0,-@RefC,1), -- one from Scepter of Beckoning
```
This is not how you should code commands >.>
Please try to write commit messages that describe the actual change :)
Bit growth?
On IASKPSTitleValueSpecifierViewCell.m

Should add to correct background color problems in iOS 4.x

-Left Title
self.textLabel.backgroundcolor = [UIColor clearColor];

-Right Label
self.detailTextLabel.backgroundcolor = [UIColor clearColor];
Because people have been whining about it always choosing the top job forever.  It does not effect your selections, merely the order in which it picks them.
esse texto foi modificado e agora
this fixed Issue #172
CCDB http://www.ccdb-home.org/
Checked and agree.
Good catch. Just fixed the README. Thanks!
You could just chain this:

```javascript
$('#browse_overlay').css({
    top: 60,
    height: '100%'
}).show();
```
why so worried?
**Note** : plot_cv_digits - gamma is replaced with parameter C for the plot.
plop

Il faut faire un compte rendu pour que quelqu'un puisse reprendre ce que l'on a fait ou au moins le modifier
Pour la présentation je pense qu'un diapo suffit car on le fait a l'oral
Unless you can convince me, I won't merge this, as die in constructor is not a nice thing to do for the caller. Additionally, I'm going to get rid of die's as much as possible. It should be up to the caller to handle exceptions and die if appropriate.
Should it be public?
i cant have an empty line at the end if this have to be there.
removing it does not have any negative effect, letting it there and add an empty line causes output like an echo, which causes a notice because we send output before a header gets send.
Please add documentation in the .h. Otherwise, this is mostly unusable.
Ah, nice. That does look much better.
changing GL_UNSIGNED_INT to GL_UNSIGNED_BYTE compiles ok
but not sure how that would effect what you're trying to do...
@jimeh pull requests are welcome :)
SYNTAX ERRORS EVERYWHERE
test ur code bro
would it be overkill to prefix the exception throwing messages with _throw_, eg _throwInvalidMethodParameterIndex_. I don't think this is done like this in other projects, but log.something() means to me it logs something. _throw log.something_ seems odd to me. WDYT?
Cool =)
Please remove this commit from the pullrequest, or rebase based on our master.
Thanks, glad you like!
Next time please send a pull request if it's not too much trouble.
I believe this should've been `def all(filters = {})`
design element accessions and gene iDs
it could be helpful to mention that `TestFileEnvironment.assert_no_temp` gets called and throws an exception if the tmp is non-empty.
that will make people feel better that this test can actually fail.
Make sure `opts` is an object here, before passing along to protected/private methods.
@ewinslow no security issues; but changed $value to $display_value for the right value
That's in there twice.
So I get a bonus point anyway?
Because it makes sense, I don’t see any value in hiding it. The rest of the ActorPath handling is also not private.
I am not really convinced about this one. What would it improve?
if it's configured and fails I think we should throw instead of defaulting
For the change in the *self rules to look like traits.  Not sure now if we need the read_rule update part, or if that was other issues.  I will test that at some point.
mail_from is set_from_args and mail, since it always did  that immediately after anyway.
Why is this separate class ?
haha, good catch :)
setdefault only sets the default value into the dict if the key does not exist in the dict. In this case, it is very likely that the key will exist and either be None or have a user-supplied value. So the way I did this accounts for the key either not existing at all or having a value of None.
why the identifier difference here? `COMPILER` is preferred
I thought this was needed to run zookeeper related test so that they do not clash?
The one liner.
720i display resolution does not, nor will it ever exist :)
I don't think this can just be renamed; it's saying that privacyMode is a BooleanSetting, which it's not.
again, simplify
It also says ‘no letters’ when the name is a number.
I corrected the others things mentionned, i'm just not sure about this. I cannot see if there changes have consequences not expected. Have you an opinion about those?
I'm working on bringing customizability back without creating a custom class. i.e. background bezier path, content inset, etc. using blocks instead.
Is this class private? If so, that would be an exception to the header exporting I mentioned above.
The unnecessary space can be removed, but aligning them is fine.
I'd simply write "32 and 64 bit (.pkg)" (what does the "Universal" mean, or what does it add as additional info?)
It saves you a lot of trouble (i.e. the headaches of encoding/decoding surrogate pairs manually) if you’re working with strings that possibly contain a non-BMP Unicode symbol.

This is useful in many cases, e.g. if you need to get the number of characters in a string. `'\uD834\uDF06'.length == 2`, but `punycode.ucs2.decode('\uD834\uDF06').length == 1`.

Similarly, `ucs2.decode` is useful when you need a `String.fromCharCode` variant that doesn’t require you to deal with the surrogate pairs individually.

```js
punycode.ucs2.encode([0x1d306]); // '\uD834\uDF06'
punycode.ucs2.encode([119558]); // '\uD834\uDF06'
```

Punycode.js uses these methods internally, and they’re exposed for developer convenience. I can remove the documentation if you want, but it seems useful to me.
Good question. I would go for asking the number of cores per worker as a command-line argument instead of setting it to Runtime.getNumberOfProcessors as you do now, just because the latter might be extremely high. Shouldn't be too hard to change.
I think he is still finishing this --- going through the logs to make sure we include all the changes....
That's core `crypt()` code that exists right now (as of 5.3.0). The reason for the change here is that I refactored it into two functions so I could call the implementation from C.

But now, the salt will not change (assuming that you're comment is ment for this line)...
Please use snprintf or spprintf, never sprintf. Also, in this case probably smart_str_append_long would be appropriate.
Ok, tak to je v pohodě.
Please use engine.execute
И сюда foreach.
сдвиг 2 таба
Sorry, just noticed this could be a 1.9 hash style :)
change `--editor` to `<tt>--editor</tt>`
Feel free to submit a new pull request with the proposed changes if you want it to go into the milestone. I'm off the grid for a few days, so Alex would be a better reviewer for this one.
`MacroContextPrefixType` means "a PrefixType member of the MacroContext class". It goes along the lines of our usual naming scheme that says OwnerMemberName. So it does make sense in its context, but looks weird in itself. I'll probably stand by this name. Changing it would introduce an irregularity, which is arguably worse than the potential confusion.

Same for `getMemberType`. It makes sense if you look at its brothers and sisters (the `getMemberXXX` family of methods), but I agree it's very confusing. I'll try to come up with a better name.
Ruby has a `loop` method that gives you an infinite loop.  It's intended for cases like these :).
Need a space here after the =>
Handled. I now use measure to determine whether an interval is bounded on both sides
I think your class could be simplified as follows: 

obj = Union.__new__(cls, map(FiniteSet, args[0]), evaluate=False)
super_set = Union(map(FiniteSet, args[0]), evaluate=True) # this will reduce to a FiniteSet

if len(super_set) !=sum(len(s) for s in args[0]):
    raise ValueError("The partition provided is not valid."

obj.partition_list_form = [list(set) for set in self.args]
return obj

This would require that Partition inherits from Union (which I think makes sense). It would also require the evaluate=False keyword which isn't currently in Master but should be in 20 hours or so 
https://github.com/sympy/sympy/pull/1164

I think that much of your code can be simplified with this change.
What's up with this? If you always convert bodylist to a list, then how will your "not and instance" ever checkout?
I wonder if it might be worth turning this into `polys` code.
this line is not covered with a test
@angadhn, this applies I think.
a "strict=False" option could be added to `fuzzy_bool` which, if True, would end with `return None if strict else bool(foo)`. Note: I moved and consolidated teh fuzzy functions in #1616; it would be nice to have that committed so this change would be made in the new location for that function. I think there were two versions floating around.
By the way, now it should work with symbols starting with a "C". I have fixed the issue in master related to this problem (at least I think so)
Why `Dict` and not simply `dict`? You may need to check out the `abc` module in the standard library.
> I didn't realize until now how similar subs and expand are. This is
the same sort of approach taken in subs. The user only writes an
`_eval` routine if it makes sense (e.g. only log will have an
`_eval_expand_log` definition). The `_eval` routines do exactly one
thing: apply the expansion to the top level expression. This makes
them very easy to write, get right, and maintain.

I think you may be right about that.  One question: any reason why you call expand on each element of .args instead of _eval_expand_hint?  Your way processes all the hints at each level before moving on to the next; the other way processes each hint entirely before moving on to the next.  Any idea on why one might be better than the other?

> One area of confusion (and perhaps area to agree on) is that perhaps a
distinction needs to be made between recursive and deep. Elsewhere in
sympy, deep refers to entering functions where here deep means "enter
args". 

Actually, `deep`'s meaning through SymPy is usually somewhere in between.  It usually makes it enter more than just functions (e.g., a nested Pow), but `deep=False` quite often goes below the top level.
* You should show what the partition looks like (```print a``` or something).
* The second example doesn't show anything new (exact same partition).
C -> JavaScript
I added that to inherit ```__eq__``` from LatticeOp instead of duplicating the code here.
we use Apache License v2.
buna gerek yok.

direkt olarak this.contentArea.innerHTML = contentElement diyelim.
Sorry, misspelling. Of course `is_numeric`.

Counter columns has sence only for integer, float and decimal field type.
Once `typecast()` is executed, `$value` must be a right type, however if other field type is used, it would be good idea to enforce the check by `is_numeric()` and cast value to integer.
This value is 0.8f in the OpenURU PR, is this intended?
I think it's weird that this file contains a test which is dependent on the number of other tests in the file. I could see this being pretty confusing for an innocent user who adds a test to TestSuitesTest and triggers an error down here in ListSuitesTestCase. I think it would be clearer to use a dedicated file, like you did with test_suite_subdir, containing a static number of tests in dedicated suites.
Its needed for the output buffer.
Importing a package from its own setup.py script could lead to problems if the import resulted in the package's dependencies being imported (since the dependencies might not be installed yet), but this is not an issue our case.

An answer on StackOverflow (http://stackoverflow.com/a/7071358/590203) suggests that importing a package from its own setup.py script can lead to problems with some tools like py2exe, but the example described in the comments might be a rare edge case.  That answer uses regular expressions to parse the `__version__` attribute from a file, but I thought that `execfile()` was a simpler alternative.

`sys.path` manipulation should work, as long as an older version of py4j isn't imported before `sys.path` is manipulated (I can't think of a realistic case where this would happen).

I'm not sure if the relative path to version.py (or py4j) is a problem.  One of the PyPi tutorials (http://packages.python.org/an_example_pypi_project/setuptools.html#setting-up-setup-py) has an example of using `__file__` to open a README file relative to the setup.py script; perhaps I should use the same approach.
Why is this still in english?
Why the unnecessary double empty comment lines?
This table is not in the migrations. It either needs to be there or removed from the schema.
I take it (via IM) that you're putting in a check for this.
Perhaps add a parameter of the number of things in queue?  That way the strategy can be smart about perhaps firing up more or less at a time?
probably not, because it's all in :dbcommand:`getLastError`
Basically all our projects follow the same pattern for imports:

```python
stdlib

django

3rdparty

localapp
```
That's [bug 759356](https://bugzilla.mozilla.org/show_bug.cgi?id=759356), mentioned in a comment later
I would prefer all warnings (this PR and everything going forward) to be written to the error log. However if someone wants to implement the conventional approach of echoing spam into the markup I won't object.
I spoke to @naderman about this and he said template events should work in a standalone template engine with an extensions manager if I recall correctly.
Use `if ($start && ($start >= $total_match_count || $start < 0))` which is easier to follow.
I believe by $is_expr it is checking if it is a 'S_FIRST_ROW' expression and if so, it can't be used in this way and therefore returns an empty string. I was just preserving the behaviour that existed before. I will add documentation though.
This isn't the effort to investigate any further in my opinion, keep it as it is.
@naderman do you agree with this? (imo it's fine)
@p Could you please type out this line as what you would see as correct so we can understand what you are trying to explain?
whats this function doing in here?  it probably shouldn't exist since its only called once.
I was thinking about the future and custom plugins. For example, in cloudkick land, custom plugins outputted a string to stdout, something like `metric name type value`. In cases like this specifying a type makes sense.
since every adapter inherits from the base class, i would probably have the base class implement the `inherited` hook to register adapters.
http://www.ruby-doc.org/core-1.9.3/Class.html#method-i-inherited
Aand the same here.
good point @padolsey. I totally overlooked that one.
Лучше использовать unix timetamp. И может быть какой-нибудь рандом добавлятью
There are a few things wrong here.

The first is that the SPL is GPL-licensed and you appear to be relic ensuing it under the CDDL, which is not permissible. As a contributor to ZFSOnLinux, I have not given consent for a license change and I doubt any other contributor has.

The second is that as far as I know, the only license conflict is when the ZFS code is a part of the kernel binary. There does not appear to be a problem when it is a separate module. in particular, no one who claims that there is a problem has done anything more than say that they do not like CDDL licensed code. They have offered no explanation of which terms of the licenses are in conflict, even upon request.
Just added in the new commit: https://github.com/diegodayan/raxacore/commit/cfc507bf1051e253370580e6f6bdab18e9208b57
That does look like magic. Bad Magic. I've tried disabling it and raising an exception instead and all the tests still pass. Looks like Unwanted Bad Magic. @bblay (or perhaps @esc24) ... I think you made the original change. Do you agree with getting rid of this?
I'm not sure that inputs are guaranteed to be leaves of the graph, so in fact this might be the wrong logic.

If you implement this as a simple FGraph feature then all you have to do is raise an assertion on import if the owner is a BadGradOp. That will be more surely correct, and easier to work with going forward.
use something more Array and sexy--like `.foreach`
concurrent is fun Programming systems.
concurrent fun is systems Programming.
Programming concurrent systems is fun.
I'm using tabs to indent, sorry :(
Do we need this defined globally?  I think only InstallController needs this value.
Can we possibly avoid importing this here? My concern is with the nescesary zeromq library to import raven.contrib.transports
could you remove these extra new lines?
Since you are doing this before the if, you could just use the variable `cmd`, or since it has such a generic name, you could remove line 211 perhaps?
See other comment about replacing `.` with `$`.
It's not shown here, but the other `return` in this function is an undefined `return;`
Should test against the message, not css class.
This issue asks us to change the error message. The css class hasn't changed.
It helps to have the breakdown by label, but since all these things come from the same middleware, seems like a good idea to have them grouped into one attribute. Maybe create a Browser namedtuple and put everything in that?
Can't seem to find a versioned URL—this is such a tiny tool anyway. Feel free to close, I suppose!
This can be done as a subformula instead, so that it will be protected by a checksum. See e.g. the `git` formula for how this is done.
I'm not sure if this the right place for this.

@jakobsack What's your opinion? - THX.
This makes me sad. The aggregator should be doing it for us. :-/
Could you please remove the whitespace around the `=` here?
我用着mac呢。
I suggest to flag.lower() and compare to "on" and "off".
I don't think new <code>DirectoryInfo</code> will throw an exception if it doesn't exist.  I use it sometimes just to say <code>if (!di.Exists) di.Create()</code>.  Also, shouldn't the if be more like <code>if (directoryInfo.Name.Equals(".git", StringComparison.OrdinalIgnoreCase))</code>?
Can you cut down the line length here?
Please add a description for what the "massaging" entails.
We try to use nesting as much as we can, so this should be an `a` style within the above `li`.
deviceType is not used yet in ios, but will be once I finish with my changes in the admob-ios branch. 

As far as an options bag, I was thinking about it but just hadn't made that change yet.  It's something I can do in the admob-ios branch as well.  Keep in mind the android implementation doesn't use an options bag, so we'd have to unpack it in that case and use the array. It seems simpler at this point to leave it this way.
"Wollen Sie die Änderungen beibehalten"
Now that I think of it, `currentSize` may be a better name for this...
Do you want to add a new Sprint DoD task about updating this value?
Yes, makes sense. This wasn't implemented by the time I added the examples, though. Will switch to `resolveNativeFileSystemPath` here.
@conradz (on behalf of @peterflynn) Did you read the comment in utils/Async.js line 130? doOpen will show error dialogs for each file, so I think you just need the results from the master promise. I think you want to use failAndStopFast = false so that each file is attempted to be opened.
bind is needed because the enable doesn't take arguments, but expected to be able to access `this.nodes`
Did `labels` use to be called `label_hierarchy`? Also, is there a reason this is a method and not just a direct property (`labels = [...]`)?
Hey I just noticed this is all in `{% block js %}` instead of `js-inline`. Pretty sure that wasn't you originally, but the `js` is for script imports and `js-inline` is for this stuff. It puts the two in the correct order to optimize load-time/responsiveness.
.btn-next
.btn-prev
But if you would put class on this, as it was done before (`form_textbox`), you could have all `ul`s child of `.form_textbox` be inline, no?
No, you cannot. Check the parent `validate`. You will see that there it allows both.

Now I see what you want to do. Don't use exceptions for normal program flow. In this case, simply check the type of the value and do one thing or another. Without exceptions.

You do not need to complicate with `FUTUREDATE` offset. We just want some preliminary check on the birthday.
I get that, but we only use the variable once, so really no need for it at all. As far as readability goes, you either have to read it where you are assigning it to the variable or where you call the function. Still going to be the same either way.
Why did you remove that comma?
My concern here was that appending to the list would put both of the caching middlewares at the very end. The FetchFromCacheMiddleware definitely belongs last in line. From the docs it looks like UpdateCacheMiddleware needs to go early, though ... and yet seems like it probably needs to be after the LocaleURLMiddleware at least, so I couldn't drop it onto the front of the list either. Wasn't sure there was a more readable way of putting those two pieces in exactly those spots, short of bringing that whole funfactory middleware list here in order to override. Is there a better way somewhere?
why not return TimeStep object?
ok, fair enough.  You could use `response.should redirect` just to make sure it's a redirect response.  I'm not sure if the Location header is specific to redirects.  At this point I am getting pretty pedantic, though - I would not anticipate any real-world bug which involves an edge-case response like that.
okay : )
I'm a little concerned this logic has spilled out of state.py without much commenting. Its also not really clear to me why we need accumulators. Computing state as a side-effect is not ideal.
Is `true` intended here?
可以保证不为NULL
换一下行
Souhlasím, že můj překlad je ošklivý. Originál ovšem nemluví o chybách; tohle rovněž udělám lépe v 1.6 (zřejmě odstraněním).
I would use a for loop here as well
suggestion:

    if line =~ /^\s*name:\s*(.*)\s*$/
      @name = $1
    end

This reduces the duplication of regular expressions.
see the pull request comment : fixes a headpin-only nav issue
Yes these sure are "unnecessary changes" :).  Can you revert them?
```
`operations on masked arrays <numpy:operations-on-masked-arrays>`
```
Is there a possibility to display a message box before the GUI is initialized?
Missing line break before and after `@return`.
I am logged in should be the first step.
root is the root MockWidget of the client view. The widget() call returns the dictionary with send from the server. It smells. I should probably expose the widget type at the MockWidget level to check it properly.
I'm not sure if this is really correct in all situations. For example, $type might use DC namespace, and the collection children might use SIOC or whatever, so in this situation name resolution would fail. 

We can of course force parent types to declare all namespaces for all possible child types as well, but this will just add to the clutter in the rendered HTML. I'm not categorically opposed to doing this, but I thought I mention it at least, seeing as there was some grumbling about the unreadability of the rendered HTML :-)
As discussed earlier, I'm a bit unhappy about the fact that we added stage to a project, rather than passing it in at this point as a Stage object, and then parametising the Task objects by Stage at construction time. @gklopper has already agreed to fix this, just thought I'd keep a note of our discussion.
Thanks for noticing, it seems that my IDE was replacing tabs automatically.
This shouldn't use `getattr()` b/c the attribute itself should *always* be present. [Our policy](http://ipython.org/ipython-doc/stable/development/coding_guide.html#attribute-declarations-for-objects) is that *all* attributes that an object is meant to have through its lifetime should be declared only in one place, the class specification.  This makes it much easier to reason about the structure of the object, without having to go through every single method looking for who adds what.
If you're going to change the text, it should be 'method selection.' Not the larges of deals... also, `describe` is better here, i totally agree.
this pattern of creating builders is unnecessarily different than others.  can you please use formatting ordering and style like Tag (https://github.com/jclouds/jclouds/blob/824ea1fd0a25fdd825abd89927d875f358d4a69f/apis/ec2/src/main/java/org/jclouds/ec2/domain/Tag.java)

for claims, prefer ImmutableMap.Builder vs linkedHashMap
FYI in canonical python style, saying (arg1) doesn't actually add any information since argument names can be introspected at runtime. I'd just remove all (arg1) in your docstrings.
`HTML::entities()`. That's what I meant. Brilliant. :)

Just look at the implementation of the function, the parameters are quite important.
Unless I misunderstand the line you are referring to, I believe this error check is just making sure that the `git__strdup` calls didn't fail, so I think it is acceptable by our coding standards to simply return -1 on failure. Generally, if an allocation fails, we don't require code to free other memory that was allocated within the function (hence the `GITERR_CHECK_ALLOC` macro which just returns -1 instead of jumping to a `cleanup` label). Of course, if the failure is for a reason other than allocation failure, then it is important to free any memory that was allocated before the failure.

All that being said, if it doesn't make the code messier, I agree with you that it's nice to free up memory before exiting even for an allocation failure, so I'm open to adding this `git__free` call before the return statement.
For that reason, I usually use:
```
#define WIDEN2(x) L ## x
#define WIDEN(x) WIDEN2(x)
```
( which originally comes from MSDN )
I feel like this should be a part of the form so we can use the form to validate the newsletter id. Otherwise, we could be attempting to sign up people for the wrong or invalid newsletters (this would require another failure to get the user to POST invalid data unknowingly, though).
Don't we call that "extension". To be a suffix is just a word at the end. Nit-ignorable.
this idiom always bothers me because you end up stripping whitespace twice.  I don't have an alternate suggestion, though
probably say something more like:

if( data.hasOwnProperty('_err') && data._err === 1 ) { 
return...

instead of nesting the if's
You should probably put something like
  if (this.scheduledFunctions[funcToRun.timeoutKey] == jasmine.undefined) {
    continue; // Timer has been cancelled by another timer
  }
before calling 
funcToRun.funcToCall();

since a timer might get cancelled inside the callback of another timer
Just spoke to @phoebesimon about moving `getUsers` outside of `loadDBFromFile`, and using `function getUsers(filePath)` instead of a var assignment.
Good catch on these
@fabpot had the same problem on multiple ubuntu vps already
the XSD file must be updated too to allow this new setting to be used in XML configuration files.
Shouldn't we check for trait support fore running this loop?
As this loop only checks for traits.
To be consistent with https://github.com/vkaravir/a-plus/commit/2413b1a385f69c81b1799a41aac3ff46a6b447d9 we could ignore admins and allow this only for the teachers and assistants of that course. 

Also, can we skip the group size requirement? Why a teacher cannot belong to a group?
I consider it good practice to have named urls when reserve url resolving is used. It's not a big deal but for instance, if you would change the name of the view, your IDE wouldn't automatically change in your reverse url code line because there, the reference to the view is done through a string instead of function reference. Also, in general situations, one might add another url to refer to the same view. In that case, if you have the existing url as named url, the reverse url code isn't accidentally broken.
I tried that it breaks all the other tests. It gets us into a circular reference somewhere for some reason. We get stack overflow exceptions if we include it.
Rather than call `.deliver` whenever using this class, can you add a `deliver` method to the end of each of your ivar setters (`invitation` and `reminder`)?

Aside: I definitely prefer having two separate methods to handle these different flows, as opposed to passing in the symbol and splitting behavior based on it's value.
@JosephPeng 
是我失误，之前没注意，这个留给我来修改吧
（P.S. 以后这种问题应该在merge之前说清楚，不然就失去pull request的code review的意义了）
对于verbatim，我觉得首先他的作用跟listings并不一样，其次我们的要求应该是提供可行的解决方案即可
如果考虑太多的话，可能会越做越杂了，目前应该主要集中在两件事情上一是文档，二是实际的实例，然后就是针对文档和实例来修改模板的细节
Ah, right...  *that* thing >.>
I've been starting to sort these for sanity reasons. We did this at Ohai and it worked out well. My personal preference has been alphabetized requires followed by alphabetized constructors
Really good :-)
We temporary don't modify this file. In the future, we should package dragon into a RPM file, not a single jar.
Not as far as I know..
It is possible to disable entirely on a content type or on node basis, but it's not a field, so you can't disable it on /admin/structure/types/manage/ding-event/display/teaser_highlight
isn't it possible to ``create_page`` with ``settings.CMS_TEMPLATE_INHERITANCE_MAGIC``?
not sure that `helpers` method should be memoized. @steveklabnik, there was an issue with it, wasn't it?
Yes, exactly. Tab drop is an editor_area functionality and hence should reside within the editor area pane and not the editor task. If I remove it, I won't be able to drag and drop tabs from one pane to another.
Is all use of this field thread safe?
Count the number of transactions at the start of the method and then assertEquals against that at the end:

int txnCount = txn.txCount();

...
Assert.assertEquals(txnCount, txn.txCount());
Ahh sorry: https://github.com/jquery/jquery-ui/pull/492#issuecomment-9994772 and following
Definitely the second case, we should never sleep in the specs if it's not needed.
I don't understand the 729 line, when I implemented it the code was:

https://github.com/benfrancis/gaia/blob/f3b4cc5d202af2b81197047adc587ffcd93e27cc/apps/homescreen/js/grid.js#L658

Always installed apps go to first page with empty slot without exceptions
I just tried and I can scroll down to the bottom and see all fields and buttons. You can also give it a try and apply the patch yourself to make sure this does not regress.
Should we create an index to speedup the retrieve process?
Brilliant! Love it :)
nit: wording ;P
yes I don't disagree but I think that should be part of a follow up PR. Could you open an issue to track?
Yes, same gap.
Are you refresh the entire UI just because one tiny toggle?
@vingtetun Fixed until having a better solution.Now I'm using origin, so there is no possibility that other app use this app name.
Right, the function should do what its name says. Will fix.
Do you mean that check the API is avaiable first?
Should It be as following:
if (!navigator.requestWakeLock) {
  console.warn('WakeLock API is not available.');
  return;
}
In this case I’d really prefer such a structure:
```html
<form role="dialog">
    <header> … </header>
    <section> … </section>
    <footer> … <footer>
</form>
```
I will not review L415-441. Please rewrite this part.
Not really but nothing prevent us from opening a custom dialog and do an action based on the result (followup)
shouldn't this be photo.originalBlob?
Is there a Gecko bug filed for this? If not can you file one? Then put the bug number in the comment next to the workaround so we know it can be removed once that bug is fixed. Thanks :)
wouldn't be enough to assign unSelectContacts = existingFbContactsByUid
Indeed I see even System.out there :)
感觉tpl这个参数也有点奇怪，使用场景？
~~~
オプションをどうやってジョブへのユーザインタフェースの一部とするか考えることに時間を費やす価値があります。
~~~

~~~
オプションをどのようにジョブへのユーザインタフェースの一部とするか考えることには時間をかける価値があります。
~~~
修正案も微妙かも
On Dec 4, 2012, at 2:07 PM, Martin Hurton <notifications@github.com> wrote:
> Yeah, the case for non inproc enpoints should be fixed too - perhaps in another commit.
> 
> As for the errno value, I would prefer ENOENT.
> 

I would have preferred ENOTCONN but sure. It's all part of the pull request now.
  Stefan
document this method - what is client?
Sure. I'm sorry for the possibly naive question, but I've never worked with this before. This modification (and all the other you might request) imply a new pull request?
@zxiiro Is it feasible to create a link to the "clear" warning popup inside `talk_editor`?

If not, a hacky solution would be to click on a predetermined location where you expect the buttons to show up. I'd avoid this if possible.
Write object literals on one line if they can fit.
yep agree to leave this, it's remove some headach when try to find why apc adapter does not works
I think this isn't used anymore..?
it probably needs styling to let the user know that it's not clickable
It seems to be doing proper escapes on its own. If I try to use a regex with unescaped slashes, Ruby throws an exception. When I put the match string in a variable and use that variable in the regex, the match works.
it work correctly
It just in case, you can use it without checks ;)
Note that we deliberately no longer do `updateVerticalScroll()` here--we want to delay all scrolling until `endOperation()`.
Style: need space between docstring and code
I think I must have commented out a bunch of lines while debugging and then left an extra space when I uncommented.
This is fixed on the branch.
These activeClass settings should NOT be required. activeClass is a way to tell h5Validate to start helping the user more interactively, and it is applied automatically by h5Validate after a field is marked invalid for the first time.

Please remove the activeClass changes.
Just call 'scripts/regenerate-profiles' if you changed menuconfig files or pinnings.
longterm it might be nice if this was smarter (eg works out which block should be the middle one rather than hardcoding it to CiF) but for now let's leave it.
why not
```
ConverterClass = None
if format = 'py':
    ConverterClass = ConverterPy
elif ...
   ...

if not ConverterClass:
    raise

converter = ConverterClass(infile, output_dest=output_dest)
```

That would result in smaller diff if we change api, add arguments.
`JSONFormatter.fromJSON` is a GemFire thing, it uses a special serialization / marshaling that makes it possible to query over JSON fields.

E.g. after this, you can run a query like:

    SELECT * FROM /Logstash WHERE event_name = 'blinkenlights'

and assuming you have a field named `event_name`, that will be processed by nodes in the grid.
The cool part is that if the region is partitioned, this will be automatically turned into a map-reduce job!
You need to specify an `updateLabelOn` parameter with value `name` for the label to reflect changes in the model correctly.
This should document why the backslash is escaped too. A backslash is not a quote to me.
This assertion is meaningless.  It cannot be safely checked, because the target landing page redirects.  Now instead of testing for this language inside the page, we test for successful redirection inside CompleteRegistration().  This is sufficient and more robust for the purpose of this test.  (if the page successfully redirects, then and the email is displayed on 123done, then all the mechanism must be working).

Useful to note that we hope to completely eliminate user visible elements of the landing page that performs the redirect, so this change future proofs us a bit too.
another case of the fallow mgmt commands.
if there's a limited set of valid batch names (defined in `BATCH_NAMES` on the management command base class), those should be set as `choices` on this field to guard against getting invalid batch names in the database. (And we should run `full_clean()` on `DataSource` instances before saving them to validate that no invalid batch is set).
Please remove the listener in `init()`.
alphabetical order should be apply ?
@pcarlisle since the fact value is just the output of the command, you probably want to just pass the command as a setcode argument `setcode('cat /sys/power/states')` though this isn't as common as facts that exec and then chomp/split the output, regex, etc.
Does it make sense to move this to a compiler spec helper? it seems like this is valuable enough to use in other places.
done

On Tue, Nov 13, 2012 at 8:25 AM, Evan Phoenix <notifications@github.com>wrote:

> In lib/rubygems/specification.rb:
>
> > @@ -611,18 +611,25 @@ def test_files= files
> >
> >    attr_accessor :specification_version
> >
> > +  def self.stubs
> > +    @@stubs ||= gemspec_files.map { |file| extract_basic_info(file) }
>
> @@stubs will need to be reset the same as @@all
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rubygems/rubygems/pull/396/files#r2111723>.
>
>
We should ignore this file because it can contain sensitive data that can be inadvertently published.
Cool, updated
you could just do `if not name or name == 'upload_file_minidump':` if that feels more pythonic
Maybe, we should do it in `_download_tarball`? These vars are needed only for `repo` object creation.
Why remove this param tag?
i think its used to avoid that changesets from the server are being applyed while the editor is in "internalCompositionState"
looks like you better change the include path in configure.ac?
For consistency use `todo` instead of `task`. And use `completed` instead of `done`.

`todocompleted`
` autofocus />` -> ` autofocus>`
sure but it's still more readable in code to include the multiplier
Line space between assignment and control structures.
if you add this to `config/application.rb` you shouldn't need these require statements:

```ruby
  config.autoload_paths += %W(#{config.root}/lib)
```
If the type of doc[k] is off, should raise:

"Mongo::OperationFailure: 10140: Cannot apply $inc modifier to non-number"
Agreed. Good finding :)
add a line of comment here, it's not clear to me what's going on; what is this patch needed for?
It is no longer necessary to test for a specific mode. This test should have included Expo and Alt-Tab, IMO.
because otherwise it would need the same __init__ function that page has
i've never done a singleton class in python. would it be possible to do 

PageProvider.provide_kb_new_article(mozwebqa, do_login, user)

def provide_kb_new_article(mozwebqa, do_login=True, user='admin'):
    yada yada
If you're going to be returning a double (which might not be necessary), the make sure you convert the get() and the 10 to a double before you divide.
should we audit this?
That matters because then you can use the same form snippet of HTML in multiple places.
Comments here as well.
Right on. Check out @prsimp's factory use, I think that'll clean up our suite a ton.
Sure no problem. Yeah I agree logs is in the right place. No tablet, just my SGS2 :)
Can put finals on declarations inside for as well.
Please don’t use exceptions for control flow. (Unless it is related to the Help/Informative classes.)

The problem is that, first of all, exceptions are meant to be exceptional, a perfectly valid case like this is not. Second, in this case you are rescuing **any** type of exception, which means that any exception that is caused by a bug will be masked.

```ruby
last_check_file.exist? ? Time.parse(last_check_file.read) : (Time.now - 60 * 60 * 24 * 15)
```
Are there plans to use CoffeeScript in this app? If not, we may want to rename this file to `updates.js`. If there aren't plans to use JavaScript at all for this controller, we could just delete this file and add it when we need it.
nit: A couple months ago, we decided to not use the extra whitespace around brackets and such to be consistent across the codebase (see https://sites.google.com/a/khanacademy.org/forge/for-developers/styleguide/javascript)

We used to use the extra whitespace, so you'll see a lot of exercises that still look like this, but we shouldn't be doing it for new stuff anymore.
Do not omit the stacktrace
Do we care about uniqueness of a game name?
I'll fix this and submit a new commit in this pull request
@pbras Fixed :smiley:
Enhancement : `testBlobSQLDeclarationWithLengthLowerThan266()` => `testBlobSQLDeclarationWithLengthSmallerThanMysqlTinyblob()`
That would improve a little what the test is about.
IMO you always need loops, whether handled here or inside some magic function.

I think the problem you said with your code is caused by `QTextCursor.WordRight`. If we want to eliminate that, it's gonna take much more effort than before as you need to check a bunch of different conditions like check if line starts at 0 col. Also IDK if this would work with double home tap.
Thanks! 08417f0b1a18f2fa9c44179a5c709dcabfe8aebe
This is just checking that we have a :where key, yes?  As long as we're bothering to check it, should we perhaps go ahead and check its type as well?
Right; that works fine as it's always defined
An explicit check for === 0 is a bit more readable here.
I'm inclined to say that the principals module would be the best place for now.
I think passport takes care of this. I think it'll send a 401 if it didn't get an object in the second parameter
It was darn-near impossible to create a tenant with a tenant admin in a test from the REST APIs with recaptcha enabled -- probably something we'll have to address at some point.

I think we have 3 options:

1) Create a global REST endpoint and supporting API that allows the global admin to create a user in a specific tenant
2) Create a TestsUtil method such as "createTenantWithAdmin" that will create a tenant, disable recaptcha, create a user, enable recaptcha, make that user tenant admin
3) Leave it as is
Any reason to not use 1.0.6 here?
Should we use more native word `ветка` instead? It's widely used in relation to git so it might be better than a calque that is `бранч`.