labofsahil/github-event-dataset-2012 huggingface dataset:
The change is for consistency with other `...Utils` classes. Having a private constructor is a safeguard to prevent from instatiating a class with static methods only. Users can still extend the class as it is not final (in such a case the safeguard will not be useful any more, is that really important ?)
this method leads to a E_STRICT error
I think tahat this was my line. Should be `isKindOfClass:`.
Perhaps `raise Failure` here as well, for consistency.
Correction: previous statement still holds, although this variable is for the `staging.yammer.com` accounts.

Yes, we have sched.do staging/prod and yammer staging/prod and all combinations must interact.
This line is intended to display either the guests name (if it exists) and failover to display the email.

This was a product design decision by the client.
Is `tap` required when setting an instance variable?
We are using the user-env-compile Heroku labs feature which makes ENV variables available when Heroku bundles. This is a temporary solution until we get the okay from Neil to open source the gem.

https://gist.github.com/4048732
New hash syntax preferred.
valid options?
This does not match the behavior of maketx, which used the source file time in update mode.
Looks strange.
We only hide the stuff that needs it rendering altered.
This way fields added later will be automatically rendered.
at some point you should wrap all this indexing and magic string stuff in a helper class
i don't understand the (Solr 1.4, eZ  Find 2.2) part...
the changelog is not maintained here
this wont let a user change a data list that was All Data to something else, and will only let a data list be come named as All Data if it was, or ifi t was Untitled Data List. this is not perfect prevention of tampering with the all data list but might be goo denough for now.
this connects up the unload of the page (when the user Refreshes, closes the tab, or closes the browser) to the new save functions, and the new warn functions. the names of the functions were changd becase we cannot actually save anything in the beforeunload because we cannot run async code in the exit of the browser (which protects users from virus etc). so instead, we warn the user if they have unsaved changes.
Some if these modules are marked optional="true". When you build a custom/minimal runtime using [build-module|https://github.com/jbossas/jboss-as/tree/master/build-modular] optional dependencies are not included by default. The code above would only add a system dependency for a module that can actually be loaded.
Good catch! You are right, part of this is leftover from migration process, I will address this in new PR.
tnx!
The conventions for package names is all lower case. However, it looks like our checkstyle doesn't force that?
I have to look into this. But since the string that are concatenating contains the username I think it will be difficult and second I don't think it will give us much, because AFAIK users and user roles are cached, so this is only called the first time or when the cache is flushed.  right?
I kind of hacked around that in https://github.com/josevalim/dynamo/pull/9/files#L5R27
I'd be happy to work on that, though I'd also love some suggestions as to what to check. I set up a simple demo of stacking, modal dialogs and didn't have any issues - I think it must have been targeting something more complicated.
indentation, overly long lines?
We have this in the shared folder now, no need for duplication :)
1234567890 is a default value?
Oh god thanks!
Just noticed that we're fairly inconsistent with responder event names across the calendar app - we may want to standardize. Unless there is some meaning to the difference.

E.g., 'syncFrequencyChange', 'selectedDayChange, 'missing events', 'recurring end'
I think after apply the new delete method, it will be much more easier to use... I should commit the logic earlier for you to implement edit :(
Yes, an utility library can also reduce some code redundancies for the the media apps. Maybe we can discuss on how to simplify this.
I was talking with her last week about SMS App and she discovered this functionality! Main problem is that for updating the height UX Team has to give us rules for:
- Max height allowed and step size
- Once we reach max height, What happens? Should we include a scrollbar inside input as iPhone?
- 'Send' button has fixed height and gradient background... what does it happen? It should grow up also...?
- Could we navigate with 'caret'/'cursor' inside input text as Android?
- ....
Due there are more things that they have to think about it I've removed this functionality (only the listener, code of updating height is still in 'sms.js') because without it is quite close to the visuals, more than with height update. I will try to talk with UX Team today again and I will try to send you an email with the answers of these questions. Could you add this functionalitywhile we will be working on 'Edit mode'? Thanks Steve!
should this be in rem's?
I think your right; it probably shouldn't raise an error. The first test is not so important. One possible fix is something like (untested):

     def apply(self, args, evaluation):
        'BaseForm[args__]'
        seq = args.get_sequence()
        if len(seq) != 2:
            evaluation.message(...)
            return
        expr, n = args[0], args[1]
No specific sharing exception you could catch? Also, does the Exists call need to be in the try?
should remove the console.log
I do not know. Personally, I prefer method name to start with "to be" verb in correct form when it returns `bool`. 

It is a pity that Python does allow to put question mark at the end of method names, such as Ruby:
```ruby
def gc_enabled?
    true
end
```
hammer hart!
This test does that because drop/scan are now implemented with mapStream.
Pick a consistent e-mail address to use - presumably your @appscale since that's what your other files have.
Could you change this to is_int? It's practically the same thing (alias) but easier to read and why use the alias? Thanks!
=> il_has_missing
Why does this need `/token` appended?
I don't think `pb.Referenceable` objects *have* a `callRemote` method.  In the old code, this called `shutdown` on the top-level Perspective (`self.bf.perspective.callRemote).  `Bot` doesn't have a `bf` now, but its parent is the `BuildSlave` instance, so the perspective could be reached at `self.parent.bf.perspective` -- but it's probably better to add a Bot attribute for this purpose.
Curious about this too, and I think @coderanger is the one to vet it since he's more intimate with the vanilla implementation.
I've removed the function and the static variable. Is it OK now?
Oops, I accidentally deleted the first one, could you please
re-send it? (The one with "Thanks..." at the top).

Ian
I Agree too :)
Agree, we need to look at all of those buttons if we are letting more
people into that ui.



On Sat, Jun 2, 2012 at 4:53 AM, Sander Potjer <
reply@reply.github.com
> wrote:

> > @@ -51,7 +51,7 @@ protected function addToolbar()
> >       {
> >               require_once JPATH_COMPONENT.'/helpers/menus.php';
> >
> > -             $canDo  =
> MenusHelper::getActions($this->state->get('filter.parent_id'));
> > +             $canDo  = MenusHelper::getActions();
> >
> >
> JToolBarHelper::title(JText::_('COM_MENUS_VIEW_MENUS_TITLE'),
> 'menumgr.png');
> >
>
> The Rebuild button in the toolbar is now visible for users with access to
> the component but no edit/create/etc permissions. I suggest to show the
> button to users with core.admin permission, so it is in line with the
> com_categories for example. Line 68-72 of this file will become:
> ```
>                if ($canDo->get('core.admin')) {
>                        JToolBarHelper::divider();
>                        JToolBarHelper::custom('menus.rebuild',
> 'refresh.png', 'refresh_f2.png', 'JTOOLBAR_REBUILD', false);
>                        JToolBarHelper::preferences('com_menus');
>                }
> ```
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/joomla/joomla-cms/pull/212/files#r918892
>
I think it could be better if it is "namespaced", to avoid potential conflicts. "GtwBeforeWikiPage"  and "GtwAfterWikiPage" ?
to rodando os testes aqui.. com "bocado" ainda sim vc tá sendo humilde
`obscure` is a fun name, but I'm not sure it is a good one?
a usefull name would be similar to ES5 ones, a long and complex one, like `makeNonEnumerableOwnProperties`.
There might be place for improvement in between.
@Mossop Would you have any suggestion based on your native english skills ?
The simplest way to find out the latest version of a package at PyPI is just to visit its page (e.g. http://pypi.python.org/pypi/oauth2). It looks like the current version is "1.5.211". They have some code that joins the "manual_verstr" with a "build number" to construct the full version number, which is a bit unusual.

Given that they seem to release to PyPI quite frequently, it probably doesn't make that much difference whether we go with a PyPI release or github. But all else being equal I think I'd prefer the PyPI release, just because it makes our `requirements.txt` more explicit and readable. Git hashes are a bit opaque and take more research to decipher into something meaningful.
Shouldn't we also use this.count everywhere? If the implementation changes we would have to update a lot of instances.
Can't we do this check in the startup method for the extension? That way we could get rid of initialization code in the main function.
Yes you must be right!  Unfortunately I am about to do all the semester's grading now so don't have time now to fix it.  Thanks for finding this.
-Alex

On 19/11/2012, at 5:09 AM, "Jeremy R. Gray" <notifications@github.com> wrote:

> In psychopy/visual.py:
> 
> > +                       numIntersections =1
> > +                    else:
> > +                        numIntersections=2
> > +                        ySquared = b*b*(1.0 - (x1*x1)/(a*a))
> > +                        if ySquared < 0:
> > +                            print 'point1=',point1,' point2=', point2, ' a=',a,' b=',b
> > +                            raise Exception("Have miscomputed intersections of vertical line with ellipse")
> > +                        y1 =  numpy.sqrt( ySquared )
> > +                        y2 = -y1   #  -y1
> > +                else: #not a vertical line so can use y = mx + n 
> > +                    m = dy/dx
> > +                    n = point1[1] - m*point1[0]
> > +                    result = 0
> > +                    discriminant = (a*b)**2 * (b**2 - n**2 + (a*m)**2)
> > +                    if discriminant < 0:
> > +                        numIntersetions=0;
> typo? numIntersetions
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
I would also add a comment stating that it will be removed from the node after the run
no need to specify type here and elsewhere
I will put performance tests online, so everybody can compare the speed difference.
Generally I like that we have a central place, where we care about this php bug. Also we provide a zf-way for end-users, so they know how to handle the situation with this specific php bug. They can just use a static method call until 5.4 is the minimum php version and the class is removed.
It's not necessary import this interface with using the FQDN name, the old line was good too.
you mean to change to :
sort_column + " " + sort_direction
Agreed.  Setting an instance's field to persist across method calls without an explicit setter/getter doesn't make sense in this case.  It's specific only to the individual call itself.
From where this is ? I don't see it anywhere in query.
Should be `private`.
Also please disable minification in debug mode.
We don't want to save the password in the gallery db. We always want to go against the current LDAP password not the one that was active when the account was created. In essence, the only information we ought to have in the db is a stub for the user (so the foreign keys work) but the rest of should be values that LDAP provides.
I can't get it work with Jquery
> Use a constant instead of the keyCode directly: var ENTER_KEY = 13;
```js
localStorage.setItem( 'todos-knockout', JSON.stringify( data ) );
```
I would rather see `selected` class applied to the filters.
we like to keep migrations runnable in the future (e.g. when the EditionMinisterialRole model class may no longer exist). You can do this by including skeleton activerecord model classes in the migration itself. See e.g. 20120124130407_add_cabinet_member_to_roles.rb or for an extreme example 20120911152726_copy_consultation_responses_to_responses.rb .
Nick was very insistant to go by days, and very insistant on 1825.
Yes, you are right, I forgot about that
Missing line break after throws and before return
Actually, this is trickier. Because setting a flag in the regex should not affect the return type of the function. For instance, it is weird that `Regex.scan` may return a different structure (in this case a list of tuples) just because the regex was compiled with the group option. Let me think more about the topic.
- preco je tu tento komentar?
- nie je to vlastne nieco, co chceme pouzit namiesto toho aktivneho cakania?
Before license, so that LICENSE,SLOT, KEYWORDS,IUSE build one block of code.
we have utils and ldap_utils. is one supposed to replace the other? if so, move/rename one to legacy/utils or ldap_utils_legacy.py ...
use 'rb' ? i don't known how much it will differ though
oh. this is not any different from before.
using this method this way  we have some false positives 
we should use:
<code>return self.is_element_present(*self._preview_features_locator)</code>
It's in `funfactory` -> `helpers .py`
again you need the prefix of `_` to get gettext to work.
That's a weird class name.
`skillz` is used elsewhere as well.
Same as above, use `getElementById` here
if you change to a property then remove the `get_` as get implies some action being done whereas a property is more passive
I'm actually a little confused by that... it's not amongst what I changed (or intended to change).
TODO to do.
i think you can simply add another attribute to url_for and that would be added as a parameter
e..g

   url_for .... :token => @host.token
just use 'il' for length
Is it really necessary to restructure imports?
Do we definitely want to make everyone use Postgres in dev as well?
- Moved the drupal specific hooks to the top. hook_theme, hook_permission, hook_forms...
...  Or, just instantiate CollectionPolicy (from the islandora_solution_pack_collection), getModels(), and go on my merry way...  Actually, that'll work...  Never mind me, I guess.
With regular expression to swap expected and results...
So need to check if all call are made on same pattern + make noise on commit.
But It is possible to make a second commit...
So I did. Fixed.
dude, revert this part of your commit, you're breaking `5.2.x` support.
Inside `set()`, all of the magic happens. From the passed `breakpoint` value, it figures out the `src` value to use by looking up the corresponding `data-*` attribute on the image and falling back to `options.fallbackSrc` if no `data-*` attribute was defined for the given `breakpoint`.

If the breakpoint has changed since the last time this image was updated, it runs the `options.callback` function, passing the image as the `this` context along with two arguments: the breakpoint label and the chosen `src` URL. Based on the breakpoint label and URL, the callback can decide whether to hide the image, fade it in, etc.
Merge conflict indicator here..
Does this hash end up being the same string as it would for the previous version of this code?  Your pull request description implies that it might not... in which case, we will eventually need to deal with migrating existing data to use the new hashes, right?
Sorry to nitpick on doc strings ;P  I think it would be helpful if you specified the units of 'bound' here; it's not entirely clear whether it's count, byte size, etc. w/o reading the code. so maybe say "the cache will be reset if the number of entries exceeds..."
sure, that seems reasonable... will do.
So these tests are now only testing that the correct nodes are returned, not testing any of the actual data returned... right?  I think we might want to either change the let statement and the is-query-result method so that we are actually testing the data that is returned, or at least add a few additional tests that are testing the data with less focus on matching the queries.
`manager` can probably be changed to `ContentConstants.roles.MANAGER`
We have:
`/api/content/c:cam:foo/download` for the latest version and
`/api/content/c:cam:foo/download/rev:cam:bar` for a specific version

I didn't want to create 2 separate endpoints handlers that essentially run the same code.

We can't use `/api/content/:contentId/download/:revisionId` as that would force the link for the latest download to be:
/api/content/c:cam:foo/download/ (note the trailing slash)
Can just pass `callback` directly into the callback for getUser
If we really need to make a copy, I would prefer using https://github.com/pvorb/node-clone
замість ```\Stfalcon\Bundle\PageBundle\Entity\Page``` можна вживати ```Page```
Yes please, keep it. I thought we could remove it but it will be done in another PR. We should discuss this stuff before :)
I did. I wasn't able to complete the build, but that was for another reason (complications over me trying to get it to work in Win7 [not the best platform for Ruby, but currently what my dev box is])  If I leave it as `git rev-parse` etc rake simply aborts off the bat.

What I'll do is actually is close this pull request to not risk breaking master branch, fix what needs to be fixed for it to go through the whole build on my machine, and then resubmit.
Does i get used?
Something funky is going on here
Поправил. Это РНР меня испортил. Спасибо!
Да, в категории они совсем-совсем ни к чему.
Да, большое спасибо, намного практичнее и быстрее идет изучение с таким подходом, когда код просматривают и оценивают другие люди.
I think there is a better way to do this. grep for '= get_current_submisssion' in our code to find examples. Not sure if it's current_submission_used or current_submission over get_current_submission.

Once you've got the active submission, you can use that for comparison or whatever you need it for.
Good catch.  Just pushed an update.
This is subject to skew, if each scheduled interval actually runs slightly after when it was targeted. `NSTimer` isn't guaranteed to be invoked right on time, but it's guaranteed to reschedule at an exact multiple of the interval from the original scheduling.

We should consider using `NSTimer` instead.
No need to save `result` here – we can perform our `expect` check directly on `x` within this block.
I'd combine them into a single printf at the end; concurrent requests would get mixed up this way and be difficult later to track down if for some reason a request returned the wrong answer.
Gotta add these (as well as TFMxNE) functions to python_reference.rst, right?
I think these three lines (79-81) can be more compactly written as:
```
            fnames = [op.abspath(fnames)] if not op.isabs(fnames) else [fnames]
```
I can add the commit for that if you're okay with the change.
nope, i think they fulfilled their duty

On 19.10.2012, at 20:49, Martin Luessi <notifications@github.com> wrote:

> In mne/artifacts/ica.py:
> 
> > +        if sdim:
> > +            sort_args = sort_args[0]
> > +        if sort_func not in (self.sorted_by,):
> > +            self._sort_idx = self._sort_idx[sort_args]
> > +            print '    Sources reordered by %s' % sort_func
> > +
> > +        self.sorted_by = sort_func
> > +
> > +        return sources[:, sort_args] if sdim else sources[sort_args]
> > +
> > +    def _pre_whiten(self, data, info, picks):
> > +        """Helper function"""
> > +        if self.noise_cov is None:  # use standardization as whitener
> > +            pre_whitener = np.std(data) ** -1
> > +            # std_chan = np.std(data, axis=1) ** -1
> > +            # pre_whitener = np.array([std_chan]).T
> is there a reason to keep the commented lines?
> 
> —
> Reply to this email directly or view it on GitHub.
>
python caches imports so it's no big deal.
Elsewhere in the guide you've used `rails console` so you should probably use it here too.
Just generating an element with variable name and text content doesn't cover much; there are loads of subclasses of `NodeSeq` that could be represented here.
<value>connections</value>参数设置每个进程与后端服务器keepalive的连接数最大值，这些连接会被保留并缓存下来。
<value>connections</value>参数设置每个worker进程与后端服务器保持连接的最大数量。这些保持的连接会被放入缓存。

如果连接数大于这个值时，最近最少使用的连接会被关闭。
如果连接数大于这个值时，最旧未使用的连接会被关闭。
如果不希望过速请求被延迟，应该使用<literal>nodelay</literal>参数：
Ok I'll update. I copied this from the "process.versions.uv" code directly below. You want me to update that as well?
The argument to PyArray_malloc should be ok, since the sizeof operator returns a size_t. The error check, and returning an error code from this function are definitely necessary though
What does getnewargs do? Is it necessary?
Thank you for pointing out these details.  Now that you've said it, I can remember that I did read about it a while ago :-)
потому что все, что не сделано, должно быть OFF

2012/5/7 Georg Rudoy <
reply@reply.github.com
>

> > +     ${MOC_SRCS}
> > +     ${FORMS_HEADERS}
> > +     ${RCCS}
> > +     )
> > +
> > +TARGET_LINK_LIBRARIES (leechcraft_blogique
> > +     ${QT_LIBRARIES}
> > +     ${LEECHCRAFT_LIBRARIES}
> > +     )
> > +
> > +INSTALL (TARGETS leechcraft_blogique DESTINATION ${LC_PLUGINS_DEST})
> > +INSTALL (FILES blogiquesettings.xml DESTINATION ${LC_SETTINGS_DEST})
> > +
> > +SET (BLOGIQUE_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
> > +
> > +OPTION (ENABLE_BLOGIQUE_METIDA "Build Metida, LiveJournal blogging
> platform support for Blogique" OFF)
>
> А почему off?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/0xd34df00d/leechcraft/pull/113/files#r780329
>
Поиграйся с перентами и свойством modality.
Ah. Ya tengo el código nuevo, fijate el otro pull request


2012/12/6 Andres Moschini <andresmoschini@gmail.com>

> No lo genera
>
>
> 2012/12/6 Alpha <notifications@github.com>
>
>> In source/CommonJobs/CommonJobs.Mvc.UI/Views/MyMenu/Order.cshtml:
>>
>> > @@ -11,32 +12,38 @@
>> >
>> >      <div class="alert alert-error alert-block" data-bind="visible: isOrdered">
>> >          <div class="row">
>> > -        @using (Html.BeginForm("GenerateOrder", "MyMenu"))
>> > -        {
>> > -            <div class="span3">
>> > -                <strong>Pedido ya realizado.</strong>
>> > -            </div>
>> > -            <div class="pull-right">
>> > -                <a href="#" data-bind="click: toggleProcessButton" style="color: #B94A48;">
>> > -                    <small>En casos excepcionales, es posible volver generar el pedido teniendo en cuenta los últimos cambios<span data-bind="visible: !isProcessButtonVisible()">...</span></small>
>> > -                </a> <input type="submit" class="btn btn-danger btn-mini" style="font-size: 85%;" value="¡Generar ahora!" data-bind="visible: isProcessButtonVisible()" />
>> > -            </div>
>> > -        }
>> > +            @Html.HasActionPermission("GenerateOrder", @<text>
>>
>> Mi idea era simplificar la escritura de HTML dentro del método, en este
>> caso parecería que estarías envolviendo un form (seguramente esta función
>> sería un wrapper de BeginForm), y si bien soluciona ese problema, ¿aplica a
>> las situaciones que necesitás? Por otro lado, ¿qué pasa si no tiene
>> permisos y por tanto no querés generar un form?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/241/files#r2335389>.
>>
>>
>
>
`Recibir` en lugar de `reciver`.
Actually it's pretty bad because it will break the navigation to other systems subtabs.
No problem! ;D

Why a hook?
This is the $modSettings['disabledBBC'] code that has been moved up a bit, nothing more (well, plus a bit of "compatibility" thing to match the codes from the editor and those from SMF).
You set the disabled bbc from the admin panel.

...fact is that this code would not disable predefined tags...but even the aviour of the current editor (i.e. strip the tag) is not exactly the best...

meh this needs to be fixed somehow.
can stay on the same line
Vladimir, I'm not sure what you mean by a stack trace tricking me :)

I'm looking at DES.failoverExecution. There we call DistributedTaskPart.get(), which throws ExecutionException, and we wrap that ExecutionException in `new ExecutionException("Failover execution failed", new Exception("Failover execution failed", e2))`. This is recursive, so if failover fails 4 times you get 4 ExecutionExceptions wrapped in Exceptions.
It's not necessary, but it's more from a style POV. @Inject methods should do as little work as possible, only caching stuff. Any use of the passed values should be deferred to start(), where you can control the order.
I believe the content of the HttpMockRule should be tested here as well, not only the existence.
@mdboom wanted to replace "descent" with "inherit" in the warning text.. you could change that in this PR so mdboom doesn't have to do it
I can actually shift this comment by one space, but I'm not sure it is worth the trouble (there's 3 spaces here).
Please include your own name on files where the code was principally written by you, and leave others' names if their code is present as well.
no we need len == 2 as well since the other code path only accounts for len > 2
Actually it's about access -  we'll discuss it on Monday.
@bp323 Can't we make these 2 lines part of the above requireJS statement?
@gsilver missing `;`
@bp323 I made these changes.
Any comments about the carousel changes I mentioned about in the jira ticket?
"A single component often uses a number of interfaces."
This is one of the more interesting changes: now that it's possible to reference a checkpoint by more than a single name, we can't do normal name matching on the checkpoint name.  So,  if someone repeats the following commands a few times:

```
update
checkpoint
cursor = open_cursor("last")
```

then each new cursor open call has to re-evaluate what the last checkpoint is, which means we can't do name comparisons at the btree or connection cache level, the matching name will potentially have been from a previous checkpoint.

I used the WT_BTREE_DISCARD flag to do this, which I'm not sure about.  That means that if you have two separate cursors on the same "last" checkpoint, they'll be entirely disjoint, but I'm not sure if that's a bad thing or not?   It doesn't seem likely in an application?

To avoid that we're going to have to come up with some unique name, which is probably doable -- if we concatenated the checkpoint name with the checkpoint's order number in the schema file (and also changed that order number to be unique, which isn't hard to do), then we'd have a unique checkpoint "name".   We have to lock the schema file, create the name, and then do the connection/btree handle cache searches, but that shouldn't be too difficult.

We don't have this problem with named checkpoints because the fact that a cursor has a named checkpoint open prevents further checkpoints of that name being created, which means a matching name is the correct cursor, that is, the existing open cursor must be the last checkpoint of that name.
It was added because of the suggestion of replacing all of ini_get() calls with phpbb wrappered one. Don't know if we're going to do that.
you should set the property to ``null``, not unset the property from the class
This is the only remaining unclear paragraph. Including Devise code could clarify it, but could also complicate it. I have no strong preference, and think it is good to go as-is.
Looks like there is a trailing comma here.
Id prefer not to have these comments in the code, I don't think they add any value
Wouldn't that mean that activating such a plug-in causes jQuery to always load?
This shouldn't be hardcoded and should be pulled from the request object.
The magic number is there because I copied the original code from the update_thumbnails command; I'd be fine with removing it.
I guess that the 3DO profile must also follow the 3D profile (which is why it's not listed as listening to point clouds for example). It would be clearer if the inheritance was explicitly stated (the same for all other derived profiles, as opposed to the two base profiles above).
You don't need to indent. Only indent based on levels in the file, not on how it looks in the output (we can die trying to achieve consistency there).
I would rename it to `unique_username`. But as I said, you will not do it like this. :-)
Wouldn't it be better to name first variable `date_string` and the other `date_parsed` or something?
I've just removed this spinner.
Add a `.lower()` so we catch `VAR` etc? What's the worst case if this misses? I assume that any errant `<script>` tags would still get escaped if they're not whitelisted?
this statement is in the wrong place, it should be on line 36
Strange, i dont.
I'd like to make all of the lines with trivial changes the same as before so they don't appear in the diff. 

I realize this is a product of startproject, but I don't think we should commit changes that do nothing, like " vs. ' or adding/removing periods from comments.
fixed in 1fade0bb09c823beac78c5bebbbec6f5e64a6583
Ah, of course. This has also been optimized. Unfortunately, the make_key function requires an instance. It could probably be converted to a static method, but then we'd need to import settings to pass in things like SITE_ID. Let me know what you think about this commit.
This validation is for public API
Should that be `DEPTH_INDENTATION`?
That's equivalent to the following and more simple condition ;)

    return (event.interval.start <= x1 || event.interval.end >= x0)  && event.time > this._min_event_time;
Unusual formatting for these two objects above. Don't line up the values in the first one, and the commas in the second one, and no space before the colon.

In order to always keep them in sync, it would also be nicer to do:
```javascript
cls.HTTPHeaderTokenizer.classnames = {};
cls.HTTPHeaderTokenizer.classnames[FIRST_LINE_PART] = "first_line_part";
...
```
`!empty()` is probably better than `size() > 0`
Oh, ok, that makes more sense. I don't see why there would be any stale state - essentially init and get_margeff do the same thing. Except init attaches the results instance. I guess I should clean up the args/kwargs thing.
or is eta1 the value of lambda ?    (both sound Greek to me)
Ah ok, no worries then :)
np ^^
I think a better name for individual, user-created "apps" is probably "project" -- thoughts?
Why construct the factory each time?
This definitely needs a check on the kind put in.  Otherwise I can just start deleting any random entity I want.
Is this the right exception to catch?   Usually it's Video.DoesNotExist
have put in a loop without a big synch block
I don't think this should be needed with the latest TomcatServer and JBoss6Server code. Was it those that were failing in WebAppIntegrationTest, which motivated this change? Worth retesting without this on master...

This code change risks setting the port to the wrong value, as it just takes the first port in the config's range, rather than the one which is actually being used.
The exit code contains the status of the 'apache2 status' call.
이 부분이 어색하네요. [내용 라이선스](http://developer.android.com/license.html) 약관을 참고하세요.라는 부분요.
D'oh! (notes to fix in the morning wtf am I doing up this late)
Have you tested with sideloaded `ResourceCollection`s? I am not sure if we can instantiate them this way.
good call. I cleaned this up as well as the defense clause in `updateSideloadApiData`. Much better, thank you.
Good spot.  I was using ``request.basket`` in ``oscar.apps.checkout.session`` but it's better to put that logic here.
Note sure if we want to document that usage. In the future we may want to add arguments. Maybe.
the same holds here too,

var params = goog.array.map(this.parameters, function(p) {
    return '$' + p.paramName;
});

return params.join(', ');
push your code again.
I just want you to return `null` instead of `false`.
Also - DataSource here
I commented out the call to #invite below, and all the tests passed.  This test doesn't seem to actually test anything other than that none of the code here throws an Exception.
against decorator, I highly recommend presenters instead
Фигурные скобки обязательны.
Так здесь выводятся все слова подряд, а выше только уникальный. Не совсем понял при чем тут компаратор.
i'm kinda surprised the Page object we inherit from doesn't have a type() method that does clear() then sendkeys()
ummm. this looks like a test that we've navigated away from a page that has a save button, not to a specific other page. what if there are other routes to get to this page?
this new locator I can't see it being used
ok, ``rank.py`` is now ``rank.pyx`` (idem for percentile and bilateral)
Or we could change the default value....
[Pep 257](http://www.python.org/dev/peps/pep-0257/): First line is one sentence describing the function, then empty line and more elaborate description.
Hrm, is this intentionally empty?
Seems to be more standards compliance; could probably be changed.
is there way how to get more useful reason why it failed? Simple error usually don't help much.
looks like this was left in by mistake
No. "g" option applies regex to the target string repeatedly.
What's going in the body of this function?  If it's filled in a subsequent patch then ignore this comment, otherwise i think a quick comment of what goes here is in order.
Property names ought to be capitalized to be consistent with the rest of the API.
Le refactor est prévu mais à la fin, étant donné que je me suis calé sur un exemple (http://www.playframework.org/documentation/2.0/JavaTodoList) les noms sont inadéquats ;)
Please add new line like for the warning tag
Delete commented gems!
Wow. I didn't get it at first, but then I realized HoloEverywhere relies on ABS dirty hidden classes instead of extends SherlockActivity.
Whoops. Valgrind broke on OS X 10.8, so I haven't been as good at catching leaks like this. Good find.
I suppose I could turn off calculation when compressed (though it's fairly marginal)
This test has changes to expect the whole number, but I think it may be wrong. However, it was also wrong before (the real number didn't match the expected, so I'm not sure if the conversion is wrong or if the floating point representation stored a different value.

I prefer to make it fail now, and fix later, than to mask it now and never fix.
lastPos is an unused local variable - I'll remove
Please double-check this but this should work:
```
range_unit = form.cleaned_data['range_unit'] or settings.RANGE_UNITS[0]
```
There isn't any `bar` here?
Hum, I don't know how to phrase it otherwise, but a toolbar sounds like a 100% width toolbar where you can add buttons inside of it.

  * Create a complex/advanced/HTML toolbar item
  * Display an HTML document in toolbar
  * Display content in toolbar
  * ???
This example is wrong, you are passing {close: false} to newTopWindow.
I didn't said it is going to be hard to factorize l10n usage, but bootstrap one ;)
So if we have a chance to factorize it and avoid using sync-XHR, please go-ahead!
(it might be relevant to decouple this from this pull request?)
Firstly, we have to understand where put this function: I proposed `url` module because seems suitable, but if there are better place where put it, I'm open to suggestion! Also, I need to save somewhere the `DataURL` as well for clipboard APIs. I could simply store in the clipboard module and don't expose it, if there is no better options.
@yuhunglin one line comments should be with `//`
ylimääräisiä hakasulkeita
Good catch, I'll fix the debug message in #48.
Let's have a slightly nicer description please. :)
How about adding that it's about cache warming? Something like ``cache_warmer_blacklist``?
``preserve_shape == False`` suggests that the input and output dimensions are the same.  How about ``resize=True`` or ``grow_shape`` or ``shape_detect``?
i think the solution in the context of the simple cms bundle as we merged it here looks fine to me.
it should be fine
Would this be better as a switch block?
I wasn't aware we had any kind of convention at all.
Remove these.  They are no longer used.
@kring do you want to have a quick look at this function since you are the original author?  I don't believe we changed much.
I'm not really sure why it's necessary in this case. This site has a search option where you can enter the imdb id and it will only show movies that match with that imdb id. These are all entered by the uploaders so there is never a bad result. So that's my reasoning for dropping search.correct_movie for this provider since it doesn't really matter whatever is in the title because it will always give a perfect imdb match.

The score is also used btw, I fire score.calculate and I add 50 to the score (arbitrary number really) since a perfect match with imdb ids warrants a large bonus score in my opinion. Let me know if you want me to lower that bonus or if you feel it's not necessary.
It's common in the JS world to use a single var keyword, e.g.

var oldestDirIndex,
    dirTimeStamps = [],
    disMap;
Shouldn't we mention the "to and from" like the old summary did?
Yes. The update method only works if the field exists. If it doesn't exist, it won't add it. By using update, we would need to do more queries (or store database values locally) to check  if the field exist in database. If it does, use update, if it doesn't, use newInsert. As you can see, the complexity for using update is far more than just delete/re-add new values.
Should translate `>1.0` to 1 and `<0.0` to 0.
Not necessarily true...if height is not specified, then the height is calculated from these two values (as mentioned below), but the center does end up at center.y
great to get more tests enabled - but how does this relate to this fix ?
This text is hard to read on device, and it looks like those are all disabled or not interactive at all.

Aside from making the text darker, is there something that could be done visually to make it obvious that these should be clicked?
We COULD.  Back before modern processors I think they recommended 1000, and then as computing power increased so did the iterations value recommendation. It'd probably be better to document directly that as you increase this value, so do you increase the potential CPU cost on your compilation master.
Exactly. I got it from http://vstone.eu/why-not-to-use-puppetparserfunctions-autoloader-loadall/ and use it instead of #loadall because it seems friendlier to not force a #loadall on everyone using the module. Maybe it doesn't matter?
semi-colon at the end? May be lint is pending?
Same here. `X1 - H`
Add more info about the main idea of the gem. Especially how it compares to cancan and acl9.
This also strikes me as a very specialized routine. Do we want to have many of these in the standard library?
All of these don't check anything particularly useful aside from compilation.
The object correctness here doesn't depend on postblit being run. The dsitructor doesn't kill state etc.

A better way is to use a struct with dynamically allocated payload. Say RefCounted or a simpler malloc/free wrapper.
At least it will *sometimes* blow things up if something wrong is going on with postblit/destructors in the appender.
Is there another opinion on this? I find the version identifier useful but I will removed it if no one else find it useful.

An example of such an restricted environment are Windows kernel mode drivers.
But they've been deprecated for a while now. You'd have to be building with -d to even use them.
Since this is non-public, ddoc should not be generated for it.
Putting it in the user namespace made sense to me because it is only influenced by methods inside this namespace. Although methods outside it do use it, too. I can see both ways, with a slight preference towards sticking it in Users.
Slices return copies.  No need to copy the copy
Ajoute un petit lien vers la doc composer du chapitre 1 s'il te plait (je crois que c'est vers #compose)
aren't those already defined in the root pom?
`phpbb-blog/phpbb-blog`
as it will be that at some point in future.
thanks for advice!
I'll rename package name!
It would also be nice to allow periods to be used.  The YUI library uses callback names that are stored within the global YUI variable - like `YUI.Env.JSONP._12345` - http://yuilibrary.com/yui/docs/jsonp/#timing
Too tricky, because they require a kernel module part as well. Same for BLCR.

We can build hwloc ourselves though, so I'm adding that.
Spaces around = and %
Could you directly set the properties instead of adding specific setters?

Or, do you have a use-case where we need to set the properties after construction?
should we not remove this change and just rely on the component content_id thing? i think this is duplication of the same feature.
`s/just like that/like this/`
by the look of code this should never happen. If so just adding an assertion(check with runtime exception) would make the code more readable.
OS X defines `Posix`.
never mind; I see now - would have been obvious if you'd said we now subclass AT     :-)
Actually, we will make it PRIVATE and not just "final protected", correct?

If so, then I think deprecation is appropriate since a private method might as well not exist (from the perspective of the "public" API, even for subclasses).
Shouldn't we just make this fatal in 2.2?
I would change this to just `#update` since it does actually update all the possible fields, not just the password. This would also be more RESTful.

At the same time we could let users edit their email address too (and their names, I guess?)
numero não está sendo atribuído a lugar nenhum.

Mas o principal: 

a questão do número é conseguir instanciar o seu enum sem eu (ou o programador que for utilizar sua lib) precisar fazer ifs ou um switch case. Sabendo que:

- em sistemas o banco provavelmente estará armazenado como int ou String. 

ISTO É

Escreva um teste do tipo:

int bb = 1;
BoletoBanco res = BoletoBanco.meuMetodWhatever(bb);
res ==== BANCO_BRASIL;

etc...
can you fix CS ? fix spaces
Wow, I didn't realize that puppet would convert that to an actual boolean.  Are there any other types that we need to be aware of?  e.g., an Array?  I'm pretty sure an Array wouldn't make sense so maybe we should put something in the validate logic to prevent that.
Should this be `>= 0` ?
Use json.signature instead of normalizedNotification.sig
Actually we don't need this method since we can get all necessary information from fieldDescriptor. 
It is here just for the the consistence with the signature of ProtobufToPig.messageToFieldSchema.
You're right, that's a better option, particularly if we do it in a similar way for each transport type.
does "@wraps" modify f so that it calls set_flow_control? or is that function not necessary anymore?
Still a real_widget here
-1. KISS.
це має бути сімлінком на behat.yml livestreet'а
when zaim was stuck on saving
Ah right, missed that one :-)
why a separate method for task?
#done, good advice @wireframe this is much cleaner b356f0e9d8673b97018c11ba673d578b57344982
GP.
You're right. I can only speculate that the original author didn't want to add a functional pdb instruction, so new users won't get confused if plone stops working and halts. So this line should be deleted.
The cap descriptions are not accurate. See the documentation for `-[UIImage stretchableImageWithLeftCapWidth:topCapHeight:]` for what these parameters represent.
The indentation level is off, here.
`the application's primary window`
Comment on compatibility should be in description, not return value
@joshcooper I'd really like to avoid putting the main service run loop to sleep for this long.  Did you consider inverting control by registering a Timer thread to kick off the Puppet runs periodically?

It seems we won't catch a change in the service state for a long time if we're putting the main thread to sleep for such long periods of time.
Are we generally okay with the fact that we don't explicitly confirm the validity of the query syntax we would want to allow?  The current syntax can be manipulated for purposes other than those it was designed for.  While SQL injection isn't much of a concern in this closed system, I just want to make to acknowledge that developers can be pretty loose with what we give them.
The new push shows that this line was changed. It was for the sake of using add_query_arg(). There is a generalized code for building URLs in the zero-config branch, but it sounds like you don't want to move to configuring through the header and supporting multiple Git hosts all at once. It will take me some time to rework those features into smaller portions.
Yea, the afterEach approach seems safer.

From: Jeffrey Heifetz [mailto:notifications@github.com]
Sent: Monday, October 22, 2012 2:04 PM
To: blackberry-webworks/BB10-Webworks-Packager
Cc: James Keshavarzi
Subject: Re: [BB10-Webworks-Packager] Changes the packager to accept the folder location instead of zip and (#96)


In test/unit/lib/file-manager.js:

> @@ -218,4 +220,39 @@ describe("File manager", function () {

>          fileMgr.cleanSource(session);

>          expect(path.existsSync(session.sourceDir)).toBeFalsy();

>      });

> +

> +    it("prepareOutputFiles() should copy files if a folder is sent in", function () {

> +        var apath = session.archivePath;

> +        session.archivePath = path.resolve("test/test-path");

> +        spyOn(wrench, "copyDirSyncRecursive");

> +        fileMgr.prepareOutputFiles(session);

> +

> +        expect(path.existsSync(session.sourcePaths.CHROME)).toBeTruthy();

> +        expect(wrench.copyDirSyncRecursive).toHaveBeenCalledWith(session.conf.UI, session.sourcePaths.UI);

> +        expect(path.existsSync(session.sourcePaths.LIB)).toBeTruthy();

> +        session.archivePath = apath;

Try/Catch should already be done by Jasmine. If post setup is crucial probably the best thing is to wrap in a describe and use afterEach.

—
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-Webworks-Packager/pull/96/files#r1906947>.


---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
nice catch, I will fix it
it needs to use toHaveBeenCalledWith because we want to check the arguments passed to JNEXT rather than simply checking if it was invoked or not
We use xui all over the UI controls
In my brain you should need to call success all the time, but I don't believe thats how it works. @rwmtse what is the correct behaviour?
`cond` is very useful to avoid nested `if`s.

~~~clojure
(cond (number? x) (* 2 x)
      (empty? x) nil
      (or (list? x) (vector? x)) (* 2 (count x))
      :else true)
~~~
(meant to insert the previous comment here)