labofsahil/github-event-dataset-2012 huggingface dataset:
This just got removed recently in root/strings.js. Can you remove it from your string file also?
This variable isn't used.
Actually I don't need this anymore, so removed it.
Or at least for <script>.  I can see the appeal of indenting after block, but not at all for <script>.
Is this a constant ? Does it deserve the capital letters ?
... and refresh the list of functions through {@code refreshFunctionList}.
Может тут что-то вроде force_unicode ( см. https://docs.djangoproject.com/en/1.4/ref/unicode/ ) использовать? 

unicode нехорошо, т.к. упадет, если txt будет байтовой не-ascii строкой (хотя тут не будет), и еще тем, что в 3.х "unicode" не определен.
You need to run 'make install'.
I thought import prefix imports go first.
Changed to fields.GenderField, implemented in fields.py.
Why span here?
Actually it's problem with SSL certs on user machine.
If you're using rvm you might be insteresed in https://rvm.io/packages/openssl/
Please remove skipping verification.
You could just store the butter instance you receive on line 218.
Should mention that these require you to run 'node make server' first, and then navigate to localhost:8888/test
Rather than using arbitrary strings the whole time for states, it might be a good idea to have them declared at the top so they are easy to change:
```
var prefix = "controls",
    stateClasses = {
      ready: prefix + "-ready",
      active: prefix + "-active"
    };

...

controls.classList.add( stateClasses.ready );
```
You don't need this check anymore, it will always be track events
Do you need to variables, or can you just use `_currentMouseDownTrackEvent`? When `mouseup` occurs, `trackEvent.selected` should still be what it was on `mousedown`, right?
Agreed - all of these thing should improve:

 Option to override a cert too far in the future or expired if it was from a pinned CA.
 Reject weak keys; that is keys with less than 1024 bits.
 Disallow signatures with md2 -> md5.
 Checking revocation (only) against a cached CRL - perhaps having a cronjob that regularly downloads them?
well duh :) even worse then
Never leave _any chance_ for shit to hit the fan.

Here, you would have it, if -- even if there is a minimal chance, but there IS a chance -- to deploy file "id" and have nanoTime as 12345... and then in very next moment deploy of file "id12345..."... kaboom, collision might happen.

Why not _always prefix with same content_? 

Even something like `return "aaa" + prefix;` would work, as with this you effectively "translate" the space (which is a "space of possible file names" here) to have it's border above minimum required (minimum name length of 3 characters), but since translation is "rigid motion", you _preserved uniqueness too_, unlike the solution in this pull request (and hence, the minimum chance to something smelly hit the fan is present).
没有判断NULL？
对于 reload 成功时的 old_cycle, 这里有机会清理么?
This seems generally useful so we may want to put it in a different namespace.
Weird, this must have been a merge error on my part. Intended to remove this
What's the difference between AsyncJob and AsyncTask?
Is there a current way to do that?  I have a future enhancement planned to utilize Elastic Search to handle the searching better, but with current functionality only saw a limited name_search available given the restriction that the only piece of information is a package name.
btw, you could use ``{@inheritdoc}`` for this method too
Yep, I'll remove that stuff and just set the view model locally to the view
Fixed. But yes, it's happening on each request...
Yes, i later found that according to the SQL standard, the union schema
(display column names) is taken from the first expression. As far as tuple
shape goes, I found out that HSQL parser does some validation - number and
type of the selected columns across the entire union must match. Should we
do an additional validation?

On Fri, Sep 21, 2012 at 5:28 PM, Paul A Martel <notifications@github.com>wrote:

> In src/frontend/org/voltdb/plannodes/UnionPlanNode.java:
>
> > +            child.produceCopyForTransformation(childCopy);
> > +        }
> > +        return copy;
> > +    }
> > +
> > +    @Override
> > +    public void generateOutputSchema(Database db)
> > +    {
> > +        // Should be at least two selects in a join
> > +        assert(m_children.size() > 1);
> > +        for (AbstractPlanNode child : m_children)
> > +        {
> > +            child.generateOutputSchema(db);
> > +        }
> > +        // @TODO MIKE - what should be an output schema for union?
> > +        m_outputSchema = m_children.get(0).getOutputSchema();
>
> I think this works. Somewhere there needs to be a check that all of the
> unioned tuples have the same shape -- if that isn't flagged by the parser,
> it would have to happen here by comparing the children's outputSchema.
>
> OutputSchema is generally an area that I think needs work.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665958>.
>
>
I should leave a TODO comment here instead. I'm not yet sure how to handle that flag properly.
No issue number is available nor was there any response on the numpy-discussion list.  I added a comment in the code giving information on the original email reporting this issue.
you can't set ``USE_NUMPY_FFT`` like this, because it's a `ConfigurationItem` object, not a constant - you have to *call* it to use it later on.  to get the behavior you want, though, I'd suggest just replacing everywhere below that you have ``use_numpy_fft`` with ``(not has_fftw) or USE_NUMPY_FFT()``, or alternatively replace this line with ``USE_NUMPY_FFT = lambda:True``, and then you can use ``USE_NUMPY_FFT`` here as you're supposed to for a `ConfigurationItem`.
Should be uppercase.
A log message about restarting the pool might be nice, even if it was at the debug level, like when a pool is originally started.
Thanks, I was really unsure about %p as I never used that before. Pull is now updated!
This can probably be abstracted into a common function later. What about an operator< / operator== for CBlockIndex ?
This is actually useful for people overriding the method
Inline comments are discouraged.  Write more clear code if a comment is required.
No blank new line needed here.
With more tests its relay difficult to reproduce (one time in 5 minutes of hard usage) ...
get rid of the ```this.`` prefix.
missing type (``array|string`` here)
Hey Andrew we are still working out what the activity in the groups drop down will represent. thats why it has been commented out.  Our current thinking is that it will be represented by number of loomios with activity since last you looked.  There is overlap here with the new notifications so we are going to have to user test it.  We don't want to add unnecessary confusion in this area so this code will need removing until we have this functionality sorted.
@ellisonbg yeah I  didn't have that good of an understanding of how the whole tornado notebook web application + handlers worked, I think the new commit is the solution you were looking for.
We can pass the layer that we need to work on into the function.
imports should be at the top of the file.
Is this check needed? Given that we don't include the jQb2 plugin, maybe we can test for that and return early.
Hardcoded URL. This is python now, right?

{{ url('firefox.mobile_aurora') }} 

Or whatever the name of the page is.
Extra print.
Damn straight. (Insert something about Java here)
Given that it became a huge discussion here and we are limited in time I think we should go ahead without the special test if data is corrupt. I don't think that we will ever hit this case when the method gets called from controller.screenShot() directly. So lets focus on the code changes which will let us save valid screenshots and the test update for those.

The invalid case we can follow-up on in another bug if necessary.
I believe we can only do it all or nothing. So Dave is right regarding restart tests. That would make a lot of sense. So I would say lets keep those in and ask @k0s  for his opinions.
for the same reason that one would use 'const' in C++.  I'm not fearing modification, but signaling my intent that the consumer of these values are not going to modify them.  a list would likely work just fine.  The consumer is just really wanting an iterable.
Can we get rid of these `osModule` tricks? I know it was for testing purposes but these days we've become much more comfortable with `mock`.
The other one has () around it due to being a multiline string, this one is single line so it doesn't need the () unless you are going to wrap it with `_('string')` for l10n. Since this is returned to the user, it and the other assignment to _m should both be l10n'd.
This gradient is actually fixed in master.
Yep, then we have at least one to decide on.
i think this file was affected in the upgrade to 2.1 and is generated or created by Symfony, so in theory this is not really copyright to ProTalk anyway.
CS: add a line break before `return`.
should maybe be moved to a different interface?
This is a wip. Please reade lines. above
you are doing the is_callable check twice in the method
this is wrong. ``$options['query_builder']`` can be either a closure or any sort of QueryBuilder (depending of the type extending the abstract class, as there is no common interface for them between the Doctrine projects). The only valid way to document it is probably ``mixed``
you don't need the elseif, just if
should that read `family_replacement` or `device_replacement`?
Also, you need to convert days to hours. I guess using Calendar will solve.
Unindent this comment
das ist quasi der ersatz fuer deine getLastLeague(), durch das max aber ein bisschen kompakter und schneller
Nor is this code path *possible* during initialization...
"django CMS" without the dash
Good point, I was afraid to do more changes, since the DragTool is used in a good number of tools (new commit pending)

It would be nice to spend some time to cleanup the DragTool logic I will open a task issue for this later.
I still think it is beter to stick with Object. I foresee user complaints if we don't, as returning ManagedReference violates the contract because what we return will never be assignable to ManagedReference.
On Mon, 19 Nov 2012, Rob Allen wrote:

> > @@ -0,0 +1,12 @@
> > +#map {
> > +	height: 200px;
> > +	width: 350px;
> 
> On my browser, the "Powered by Leaflet — Map data © 2012 OpenStreetMap 
> contributors" text wraps onto a second line. If you make the width 
> 360px, this doesn't happen.

Shouldn't be necessairy now, as the "2012" is gone.

cheers,
Derick
Sorry, I meant that last comment for the lines above... look up.
extractthis typo
I don't think this should be checked in
It's O.K. for me, 
(nevertheless I am afraid the UX finalization has slow but same design I heard from them now.)
Damn, caching it is an option but maybe we need to look at structuring the html/css differently so we can avoid these issues...

I am ok with the patch in its current state but we need to mark a big `//TODO: fix this so its not hardcoded` on that 5px.
That seems useless as we only accept html files, so that these folders will be ignored.
I would say that HOME bring you back to the main lockscreen view too (ESCAPE is only a second class citizen)
`this.alarms.addEventListener('mouseup', this);`

Same for line L161-L163
how about:

    case 'ready':
    default:
      this.reset();
      ...
      break;

?
0 is enought, not need for rem.
ok I could use a id only
We'll want to do this for other utilities too (e.g. ps).  Instead of doing this only for rm, can you do it for every element in a list, which we can update as necessary?
This is not blocking the pull request anyway. So don't worry. We can check this together tomorrow.
This needs a comment about ?time= too since this could also be about creating some kind of unique-ish thing (which would be dangerous without some additional entropy.)
Nit: remove
I'm wondering why this didn't cause an wrong number of arguments (4 for 3) error. The database connect only accept three options:

https://github.com/puppetlabs/Razor/blob/master/lib/project_razor/persist/mongoplugin.rb#L23
Does not break previous versions as long as first_checkin is handled well if null
probably micro but might be worth benchmarking with a .call() in there since that's a bit more expensive
Both public methods in this class are now tested in TestAtlasMAGETABLoader
`Nginx.reload()`
Plus you should get rid of the underscore "_" in protected/private method names
Can just be ChatComponent
This seems to be used in every action.  Might be worth extracting into a before_filter.
^ Here, by default install_server_url is an empty string, which will try to instantiate the install server with an empty string (found this while working on the unittests)
Well it is a fact at this point that local repos have to be writable. If you can't write you can't install packages, so I think that's fine. If this assumption changes we'll need to revise a lot of other code anyway.
if `middleware` not exists or empty, just `return fn(req, res, next)` for high speed, no need to  call `routeMiddleware()`.
Its impossible to cover all with tests. And it useless. Its enough to write good code
ok. lets go with window.location
@ahume ok, going to review & merge tomorrow AM. Can you commit anything you need to please?
Can then move declaration of `authorities` below this test.
nm, I see the change; github wasn't showing it very obviously ;)
Is "the pagination" a `PageSelector` object?
This side effect here is really unexpected.
`manifest` isn't used anymore.
Wouldn't it be better to use this form instead?
`let module = cuddlefish.Module('api-utils/cuddlefish', cuddlefishURI);`
@lloyd - this is the important part - pass the password along with the email.  The password makes its way to the "check_registration" controller who will use it to log the user in if the status to "email_addition_status" is "mustAuth"
Adding something higher level like testidp.disablePrimarySupport would make the intention here easier without having to read the name of the test.
I like the name change.  GenerateAssertion is more granular and clear to me
@Evan-Pierce that should be `C:\Documents and Settings`. It looks like commit 9f3d8a94e719104b23db41cfc5d7a22912a45133 accidentally truncated it to just `C:\Documents` Can you fix that?
It lists only the latest

    | pkg list -Haf mypkg
    mypkg (puppet)                                0.0.4           known      -----
    mypkg (puppet)                                0.0.3           known      u----
    mypkg (puppet)                                0.0.2           installed  u----
    mypkg (puppet)                                0.0.1           known      u----

    | pkg list -Hn mypkg 
    mypkg (puppet)                                0.0.4           known      -----
I think that is wrong, eh.  We don't want to lie about our copyright dates. :)
Do not call any GL functions from GLWT unless necessary. Especially legacy GL functions that are deprecated and do not work with GLES.
No need for a `File.join` here, it's only one argument.
you're leaking this binding through the closure... so between assignment and return, another goroutine could be setting this to 'nil', where you'll get a 'return nil, nil'... unexpected.
oops if sys.version_info < (2, 6, 5)
When the SendResponseListener gets instantiated, the response object given could change, e.g. the controller returns a newly created response object. The concrete response sender is selected, based on the classname of the current response object. If you return a custom response in your controller, the send response listener would not be able to send the correct response.
Alternative implementation would be: make this class ServiceLocatorAware!
remove the initial slash
Please convert $tableName into a string and check if it's empty:
```$tableName = (string) $tableName;
if ($tableName === '') {
    throw ...
}```
All this elements must be in the same line
yup!

On Mon, May 14, 2012 at 10:15 AM, Irakli Gozalishvili
<reply@reply.github.com>
wrote:
>> @@ -26,6 +26,10 @@ function normalize(uri) {
>>
>>  self.port.on('pathChange', function(path) {
>>    let SDK_ROOT = path
>> +
>> +  if (SDK_ROOT.substr(-1, 1) !=== '/')
>
> Do you plan on updating this BTW (Asking because you closed pull request) ?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Gozala/scratch-kit/pull/1/files#r817713
Yeah, no need to tie stats to home in this manner.
It was duplicating the test above it. It looked like copy and paste without removing the extra stuff.
should we be checking for `$item->scalar` directly?
This can just go in the Sheep's component since this will only be attached to sheep ;)
this is what validation groups are for: choosing which constraints should be applied. the issue with your code is that the validation errors will not be displayed in the form
Yeah, probably doesn't make much of a difference here, it's just my default when I don't know for sure that the number's really small, since I don't think it hurts.
can you move everything starting at the '?' to the next line with one level of indention .. same goes for the next line.
+1, a link to this: http://popcornjs.org/popcorn-docs/popcorn-constructor/
Version control is your friend here. There should be a really compelling reason to leave something as a commented line instead of just removing it. Generally, you just remove it and if you need it back later you just get it back via your repo's history.
It's not being triggered because only RestContent value object visitor triggers other visitors and in this case it does not do it for location.

I don't think it's going to be changed any time soon, since Content resource does not include embedded Location resource, but only link to it.
I don't think I know how to do that - so what exactly do I have to run? running "repoman full" in the pybrain dir just gives me some complaining about metadata.xml
use "tmpl" (template) instead of "temp"
hmm seems like other quickstarts need update also :)
in my case i had MySQL installed, but no libmysqlclient-dev

    sudo apt-get install libmysqlclient-dev
whitespace is all off here.
Agree that the names are confusing, just tried to get it working with minimal changes.  For now we can just rename the var and leave the refactoring as a TODO item?  

-----Original Message-----
From: Ryan Brainard [mailto:reply@reply.github.com] 
Sent: Thursday, May 03, 2012 3:49 PM
To: Mahanthi Gangadhar
Subject: Re: [axiom] JIT Changes (#4)

> @@ -168,7 +171,7 @@ protected Subject buildSubject(String nameIdentifierValue)
>      protected abstract Subject buildSubject();
>  
>      protected AttributeStatement buildAttributeStatement(
> -            List<Attribute> additionalAttributes) throws IllegalStateException {
> +            List<Attribute> addAttributes) throws IllegalStateException {

This is confusing having both an `additionalAttributes` and `addAttributes`. In addition,  `addAtrributes` sounds like a verb, not a noun. Beyond just renaming the var, this probably should be rafactored to have the injection of both kinds of additional attributes be cleaner. I know the original code was a bit messy though :(

--- 
Reply to this email directly or view it on GitHub:
https://github.com/ryanbrainard/axiom/pull/4/files#r770318
These files should be in your [global .gitignore file](https://help.github.com/articles/ignoring-files), not here.
Based on new evidence, I think this might be related to the Ruby version rather than the Puppet version, but I can't be sure.

For safety, I think we need to drop this test, and just check for both formats in the case statement below.
What are the units for running time? This is in seconds.
For your example `EllipticalAnnulusAperture(1.5, 2.0, 1.0, np.pi / 3.)` above and the "world" or "sky" coordinate case, how is the orientation on the sky actually defined? I guess it depends on the coordinate system used in my image, e.g. if it is `Galactic` or `Equatorial`, right?

Does the orientation / shape of that aperture also depend on the FITS projection of my image, e.g. `AIT` or `CAR`?
If the answer here is no, then I agree, there is no third `sky` case besides `pixel` and `world`.
This is locale dependent. Not sure if it matters here, but could be odd if running under an odd locale
Ah sorry haven't seen that, my bad!
On Sep 8, 2012 5:26 PM, "Michael Krasnow" <notifications@github.com> wrote:

> In web/concrete/core/models/block.php:
>
> > @@ -733,7 +733,7 @@ function getBlockUserID() {
> >  	}
> >
> >  	function getBlockName() {
> > -		return $this->bName;
> > +		return t($this->bName);
>
> This is not the Block Type name this is used by methods such as
> Block::getByName($name). making this translatable will break this
> functionality any where it is used. (you can see where this is used by
> clicking on a block then selecting custom template.)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/concrete5/concrete5/pull/654/files#r1560706>.
>
>
you may need to do it locally, pull your branch (patch-4), add that code and commit it, then push it and it should show here,
Do these really need to be treated differently?
are these django settings (if so should it be django.conf?)?
http or https . https must also be allowed
+1

In fact I'd go as far as taking the opportunity to introduce an ini setting with the url of online docs.
Advantages:
- can be changed in 1 place only if site changes again
- can be pointed at local copy of docs if there's a firewall problem
Could you please commit .submodule file?
если это не подразумевается, то это его проблема.
выглядит, конечно, порнографично...
opening curly should be on the next line
This feature was for my own needs. As I stated in my original comment, I will not be storing the private key in my app's code.

I needed a way to display the encrypted data to administrators (via Base64 or PGP's Armor format) so that it can be copied/pasted into an offline application (i.e. desktop app) for decryption. I will make this 'feature' more clear via inline documentation in the code.

I know this is not the functionality everyone will want but it is great for those who are (very) paranoid about storing public/private key pairs within their app's code.
OH HAI OOPS LOL BUT CUZ I KNO THAT MAY B I STILL THINX ITS PROBLEM!!!???

http://cl.ly/1E2p2b3j1B1X051h0H3j <----

CUZ LAST EVALUATED STATEMENT IS ====== NIL LOLOOPS I SAID 'NULL' BUT REWBY
SO I GUESS I MEANT 'NIL'

On Sat, May 12, 2012 at 1:40 PM, Jose Diaz-Gonzalez <
reply@reply.github.com
> wrote:

> >    message = "What is #{something}?\n"
> >    message += "[#{default}] > " unless default.nil?
> >    print message
> >
> >    it_is = STDIN.gets.strip
> >    it_is = default if it_is.empty?
> > +  return it_is
>
>
> http://en.wikibooks.org/wiki/Ruby_Programming/Syntax/Method_Calls#Return_Values
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/josegonzalez/cimino/pull/1/files#r812587
>
Is rba.length even gauranteed to be 4 here? I worry that we haven't created any unit tests for bad inputs and define those behaviors. Ideally, we wouldn't be worrying about this at all. Gzip is a cruel mistress.
put real img urls in. converted footer icons to list. removed targets.
No, I just prefer it this way :)
`rel.trim()`?
I forgot to mention this last time: `g_prefix_error()` only works if the error has already been set, so this needs to be after `inflate_buffer()`.
We've changed the terminology from "layer" to "level" throughout the OpenSlide codebase, since "level" seems to be the more widely-used term.
We probably need an updateRole function as well.
module.exports.removeRole = function(principal, subjectPrincipal, callback) ?
Can we move this into beforeTests.js and override the config value in there with the other test-specific overrides?
I renamed it `isMainTenantServer` since that's even more appropriate.
This could be ``e.asInstanceOfOpt[ISourceViewerEditor]``. But I really don't feel strong about this, I just wanted to mention it.
can you use a truthy here or is it b/c you count null as valid?
If options passed in to function is {} then this will break
The app gets here pretty much straight away, so maybe waiting should be the default state.
This is a separate issue and some would argue if there should be a prefix for it or not ... let's keep this one limited to the query string part.

P.S.: Just commit and push the changes to the same branch, you don't need to close and create another pull request.
Разные методы под разные задачи и условия, но один мне нравится больше всех:
1) Формируем массив индексов длиной
Подскажите, пожалуйста, я не могу понять загрузились изменения в основной репозиторий или нет
Ага, вижу, спасибо. 
А если я сейчас загружу новую версию кода, то эти все коментарии сотрутся или их где-то можно будет прочесть ?
окей, буду знать , спасибо. А какой алгоритм  лучше использовать в этом случае ?
Exactly, nothing is persisted on server side. I'll open a ticket for persistent preferences.
the purpose is to never store a full X with n_sources, n_times but just the non zeros. In other words we should never have to do : np.zeros((n_sources, n_times))
Perhaps drop the ```show_``` and rename the action to just ```topics#votes``` - seems more Rails-like.
If this fails?
why is that commented?
Happens in the assert below
if 'subject_his_id' in info:
remove ``so``
Yes, check for it -- was a bit late yesterday ;-)
lowercase r (resolved)
I think so, i'll try it.  I was initially using it to test the sub_command steps
I left that in to remove the ambiguity with `::I18n` which is also a constant.
Typo: *notificaitons*
change "thrown" to "dispatched"
I copied the `<container>` element and doctype from examples in the `book/service_container` article, I included them to make consistent XML code examples.

I doubted about the underscore/dashes in XML, underscores are used in the `book/service_container` article, but after some research I found that underscores can be replaced by dashes in XML and that is the preffered syntax, so yes, it is better to use dashes.
please wrap lines after the first word crossing 72 chars
而不是常规文件
以替代普通文件
`groupName`, `domainName` and `serverName`
This line too.
lib/Subway.js doesn't need to be changed.
Please exclude 'lib/subway.js' in the commit.
This file is out-of-date. It is missing the:

    "url_processor": "s/http:\\/\\/news\\.google\\.com\\/news\\/url\\?(.+\\&)*url=([^&]*).*$/\\2/"

FAIL: Update the fixture to match the model in the code.
No problem! Thanks for figuring out this hairy bug. I really appreciate it!
I changed it and added a note about it.
Rather than using the magic getters / setters, in the framework code at least, you should always spell out the full method name, so in this case:
<pre>
$class=$model->getModelName();
</pre>

This is slightly faster than using the magic methods
Variable naming needs to be checked here in the whole function.
please add a line feed before `INNER JOIN` with 4 spaces
Oh, right. I got what you mean. Of course, you are right!

I have fixed and pushed that and other issues.
We are now at 0.5.0.1 and not 0.5.1 as written here
$sources.source | foreach is actually
$sources.source | foreach-object

I could never figure out why one works and one doesn't...
Please  update the docs above to include the `type`
But one strack trace is not going to prove my hypothesis - I will just trick you potentially. Look in detail at current innerGet and see how ExecutionException is never raised. Unless of course it comes from clients Callable. Failover in turn executes same innerGet until it either succeeds or fails (failover count exceeded) in which case we finally raise ExecutionException to client.
Why create this tmpCacheConfiguration if in line 91 you're only gonna use it if getCacheConfiguration() returns null? If the cache is already defined by the user, then the call in this line is wasteful, isn't it?
Can this be part of the constructor?
*-findSimilarWithOptions:
Actually it's just doing a list of valid languages from the browser (since we need/want a fallback for non-intl.) Got the logic out of the anon function
Even simpler:

```
plt.axes()
ax.arrow(...)
```
?
As far as I can tell, this isn't a fundamental property of this approach (i.e. in the future, we will be able to blit). Is that correct?
I thought it didn't matter where `kwargs` were placed. Am I not understanding something?
Can we make these touch events synchronous? I think either making the long_press wait the hold time would be better. Optionally, instead of the hold time, we could pass a callback which must evaluate to true, and the holdtime could double up as a timeout. I'm happy for this to be a followup bug, but agree that we should at least wait here and not sleep.
Can we use argument unpacking here? `*contact_locator`
I'm not sure that bootstrap (process) should declare dependency on these listed services, but I see how this is useful to have the service clients defined. It will bite us once we enforce dependency when starting a service/process.

FYI for now
Good point. With a bit of effort, we could move this code to deprecated.js. I'm adding a TODO.
update overrides.py in qa (than in stage) for filertags.urls
Done. Also added tests highlighting this. d98c9d6
@arnodeclercq missing space after :
These changes register the old ResultProcessor classes as ResultWriters as well. The ResultWriter interface has been refactored out and is now a super-interface of ResultProcessor. This will allow us to use the ResultWriters when needed (eg. in the Servlet render chain) and to ignore them when all we need is the RestulProcessor.
please use SG_ERROR instead ASSERT
ASSERTs are a nightmare for users, error messages tell them what they did wrong :)
The loop is to remove the title attributes from the ss-tooltip elements.
The reason for this is because the default title contains all the HTML which looks messy.
Try not using class names in their plural, gets confusing. Maybe "The FormField classes"?
@hafriedlander any idea why this doesn't trigger in IE8? Checked in debugger. What am I missing? Thanks :)
It did on Ubuntu. The packages I installed were:

- nginx
- php5-common
- php5-cli
- php5-fpm
- php5-gd
- php5-mysql

I didn't have to make a key + cert.

Similar information is out there on the Web, but not nicely combined into one server.
Yeah, just realised I didn't change form_id values from 0 to 1 when I made the change in https://github.com/ushahidi/Ushahidi_Web/commit/087a2cf56ac64aaee5f42c572ec835064552053d. Will handle during upload, but also create another upgrade file that changes incident form_id's from 0 to 1.
I don't see a use case for a generic filelib "not implemented" exception. If the plugin needs one, it should be in the plugin's own namespace.

If something is not implemented, well then... it's not implemented.
closing must be in finally block
Are you sure you want to override the parameter ``$content``? This often makes code less readable.
there should be a link to that section up toward the top of the page in the Events section
Sure thing, updated.
You never use elink_eve here
this code suffers form the same bug than Twig 1.7 and lower related to timezone changes. the best way to fix it would be to replace this duplicated call by a call to the function introduced in Twig 1.6 to parse dates
@gaffneyc it is the same intent in this instance. :typecast should always be a class or nil. If you use an empty string you deserve to get a crappy error message. :)
Yeah we do. We could move the to the import.legacy.php folder, make them aliases of IS_WIN and IS_MAC and deprecate them. What do you think?
Do you mean

    $tmpl = JFactory::getApplication()->input->getCmd('tmpl');
We should really try to make these autoloadable.
This test case should equal `0`. `keepid` is false, so it should remove the IDs.
The question is why you would ever want to render an XML node with an
attribute present but empty.

Regards,
Ben Langfeld

Em 13 Jul 2012, às 19:05, Aaron Patterson
<reply@reply.github.com>
escreveu:

>> @@ -258,7 +259,12 @@ def [] name
>>       ###
>>       # Set the attribute value for the attribute +name+ to +value+
>>       def []= name, value
>> -        set name.to_s, value
>> +        if value.nil?
>> +          remove_attribute name.to_s
>
> If we wan't this to quack like a hash, shouldn't we implement `delete` rather than having a magic value *mean* delete? I'm not really excited about the idea of calling a setter that could possibly have the side effect of deleting something.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sparklemotion/nokogiri/pull/729/files#r1160798
I prefer, when possible to avoid `>=` dependencies due to the risk of unintended upgrade. What versions were you hoping to use specifically and I'll try to make the dependency specification more specific?
I've tried to avoid saying "Documentation" because that implies software documentation, and our lesson materials aren't that.
You could turn around the if. You can do that when one part is much shorter than the other. So here you can simply set the context in the "else" case and return. And then do the rest if it is available.
What is this `width:40px height:90px` I see there? Why `</img>`?
You could use [simple_tag](https://docs.djangoproject.com/en/dev/howto/custom-template-tags/#simple-tags) decorator. For this template tag there is no need to do custom `Node` class.
Yes I did try that earlied, but than somehow forgot. Fixed
Also should let upstream know that their Makefile is broken on Darwin.
Fourth bit: RatedBGsEnabled
Fixme needs to be fixed?
Should this be the current working directory for this task instead of a jvm temp dir?
2 points:
- This method doesn't look atomic ( another call at the same time can generate the same key before it was used by the first call)
- Maybe adding a prefix could be usefull ?
don't think we need to require 32 chars. can we figure something out to generate what's needed while supporting variable input lengths?
I would just remove the number of classes here
As above, we need to use the 'service[nginx]' syntax.
That would be good.  Now that we're inside an anonymous namespace there's no need to keep on with the full `ngx_http_pagespeed_` prefix.
Same here: add ini_get('session.cookie_path') as default value to get()
Did you consider making this a convenience method, e.g. `HighVoltage.use_root_routes`? I don't mind either way, and actually this is nice because it makes it obvious how it works, but worth considering I think. Up to you.
Okay, I had omitted it in the spirit of wanting a very short README, but it's fine if you want to add something short.
Both this and the `BuildMultiFits` function have `Build a regular fits file as specified in config` as the opening line, same as `BuildFits`.  Not sure if that is intentional, although but multiple FITS files and even FITS cubes are very definitely still "regular" FITS-compliant objects.  But it might be an opportunity to say, e.g., `Build multiple regular fits files as specified in config` and `Build a multiple image fits data cube as specified in config.` above and here, respectively.
Function has updated comments below.
If you don't know yet what the link is going to be I recommend using `#` as a placeholder. Prevents you from accidental clicks.

`<a href='#'>foobar</a>`
The guides tool seems to be broken.

also ": The Image Plugin" is wrong -- should be "Aloha Editor Guides: The Image Plugin"
is vs == is an interesting one. The fact that they have different meanings in python (value versus identity equality) slightly bothers me. 
The larger issue here is that I'd rather have my operators not look like variables (or function names). `==` does that very well.
Now you check for 1 anyway? I don't see that being returned at all.

Why is there a "?" in the exception message?
This should be "phpunit" like in all the other tests please.
On Mon, 3 Dec 2012, Hannes Magnusson wrote:

> > @@ -37,8 +37,8 @@
> >  #define BSON_INT 16
> >  #define BSON_TIMESTAMP 17
> >  #define BSON_LONG 18
> > -#define BSON_MINKEY -1
> > -#define BSON_MAXKEY 127
> > +#define BSON_MINKEY 0xff
> > +#define BSON_MAXKEY 0x7f
> 
> This looks like a purely cosmetic change.. so why change all MAXKEY but not all the others?

Didn't want to change the others as they are fine. Only 0x7f and 0xff 
can potentially cause issues.
`if not settings`?
I'd probably personally use a stub here, for the same reasons as you and @dchelimsky mention. That said, I don't feel strongly about it in this case.
That's exactly what I'm testing.
Isnt' csrf token check enough? Also - we don't check that/sanitise for ``HTTP_REFERER``, where such redirect to a third party site may also apply...
Not sure about the language's creation date, but it was not 2001 - but way later...
The designer had switch to Open Sans for homescreen.

But developers are welcome to keep it own design (and interaction) for now. It's WEB after all.
typo: `require`
When registering a Job, we throw a DuplicateJobException if it has already been registered and put the onus on the caller to unregister first.  I'm not arguing one way or the other, but I would expect the behavior to be similar across the two calls...
To be consistent with other "get a single instance of *[x]*" methods in the content API, I think this should use the `get_json` method rather than `get_json!`, and so return `nil` if the tag doesn’t exist.
Our [style guide](https://github.com/alphagov/styleguides/blob/master/ruby.md) suggests we should be using `do...end` syntax rather than braces here, since it’s executed for side effects rather than return values.
I agree with Alex.  Serve consumer web's deal page was broken for a while after the gem upgrade because of the model_for being removed.
reverse twice? seems like you should be able to achieve that with a different regex though I can't read this current one.
Спасибо :)
good coverage.  for the sake of readability, though, I would wrap tests of related options into distinct nest "describe" blocks.  for example, this (and the below test for the invalid case) could be wrapped like this:

```coffeescript
    describe "#greater_than", ->
        it "should validate a value greater than the limit", ->
            ...
        it "should error on a value less than the limit", ->
            ...
```
Unfortunately, DEBUG is a compile time constant (This is good, it actually optimizes away when we build with DEBUG = false)- however, it means that customers using our binary distribution can never set DEBUG to true.

Also, we have a *lot* of useful output when DEBUG is true that would be meaningless to users. This switch is both accessible at run time to user code, and allows us to still have lots of noisy internal debugging output that users don't have to see.
Please check out these sections for an example of the nsautorelease pool when accessing renderer member vars question.
ok. 

-- 
At.
Carlos Antonio


On Friday, June 29, 2012 at 4:45 PM, Paul Kmiec wrote:

> > @@ -27,7 +27,7 @@ def html_classes(input, options)
> > css += SimpleForm.additional_classes_for(:wrapper) { input.html_classes }
> > css << (options[:wrapper_error_class] || @defaults[:error_class]) if input.has_errors?
> > css << (options[:wrapper_hint_class] || @defaults[:hint_class]) if input.has_hint?
> > - css
> > + css.compact
> > 
> 
> 
> But yes, this is needed to make the wrapper case pass.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/plataformatec/simple_form/pull/606/files#r1078484
> 
>
On 10/15/2012 06:32 AM, Gael Varoquaux wrote:
>
> In sklearn/grid_search.py:
>
> > @@ -449,9 +442,5 @@ def _fit(self, X, y):
> >      def score(self, X, y=None):
> >          if hasattr(self.best_estimator_, 'score'):
> >              return self.best_estimator_.score(X, y)
> > -        if self.score_func is None:
> > -            raise ValueError("No score function explicitly defined, "
> > -                             "and the estimator doesn't provide one %s"
> > -                             % self.best_estimator_)
> On Sun, Oct 14, 2012 at 11:43:32AM -0700, Andreas Mueller wrote: 
> "unfortunately" all estimators have a score-function...
> Awesome! I am surprised, but happily surprised. Even the clustering 
> ones? But I guess that our code should also work with estimators that 
> we did not design. These might not have a score method.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/scikit-learn/scikit-learn/pull/1210/files#r1838742>.
>
I can't find these comments anywhere on github... so now an unordered 
email reply.
Most clustering algorithms **can't** have a score, because they don't 
support ``predict``.
the nested for list comprehension is a bit hard to read, that is true.
What it does is:
```python
for clf_params in sampled_params:
    for train, test in cv:
         out.append(fit_grid_point(...))
```
Is there a reason why you changed the name of the parameters from alpha, beta to l1_reg, l2_reg?

I indeed tend to prefer your names, but it brings in an API change, which we try to avoid.
Please document such API changes in the whats_new file.
I would rather use the standard import to make it easier to understand. In particular there are different kinds of ``bool``.
Tiny nit pick: I like to break up list comprehensions by expression when I need to split it across lines. Go ahead an just use the variable name ``u`` as well instead of ``u_id``. My rule of thumb is that variable name length should be proportional to their scope. So tiny 1-2 line scopes can use 1 letter variable names without angering anyone (in fact it's kind of nice to see a 1 letter variable name and_know_ that it's a short lived variable).

```python
ids = [u for u in user_json
        if u['user_id'] not in user_ids]
```
This one too.  The else block is now dead code.
dmc produces a warning for this expression.
removeListener will e called when removeEventListener API is called from JS, but it is not implemented yet
Fix order. Also, please correct N_PROP_DATA below while you're at it.
That means we not going to support textAlign: 'center' format?
I agree - these files are dependent on other ISO 19139 schema pluging - it may have been done this way so that they can include these files. If I get a chance I will test changing it to see if it breaks anything....
Three times is the charm, could this be commoned up?
:D I hadn't spotted that! ;)

Is there nothing of value in there?
Technically this should only be set if we are using gcc/clang (though I don't think we ever compile this component on a system where that is not true)
udesc not used/needed here by the looks of it.
I suspect it should assert that not a dictionary
Maybe not any more... I might create a new transformer type for dumping purposes on the new module hqldump (which might even not be called hqldump, but hqltext or hqlexport, or hqlir).
Comment should also say "and so no extra padding is added to sizeof(class)" or words to that effect.
Yes, as you need it to have released file links before flushing the cache
Just curious, why doesn't MidoNet support disabling DHCP? I assume that's a limitation by choice - of our integration, not of the MidoNet core.

I'm probably missing a lot of context... would that imply having to provide a different way to allocate the VM instance's IP address? Or raise other issues that I'm not imagining?
Ah, I must have overlooked that document, I didn't know it was possible to configure opscenterd with cluster information from a file.
I'll do that after this PR gets merged
What is this `else` used for?
It's better not to access private methods or instance variables during a test.

A better test would be to confirm that the server is available at the returned host.
Indeed, now will correct
Fair enough, I just thought it would be kind of cool if you can really sum down the whole install process to a one liner. Maybe do it with a --install switch?
There is a typo, you specified `target` instead of core.
`let { emit } = require('api-utils/event/core');`

I think it would be usefull to add a dedicated paragraph about `emit`: 
"# How firing events on an EventTarget object? #"
Removing this method breaks the tests. Could you update also the tests? Run rspec on the root folder to check it.
@WarnOnly and remove the try catch... it will do the same thing for you.
@shacker Can we prefix this and use a full name?
e.g. `cc-widget-main-nopadding`?
Server also needs the SFML path.
devops track I believe.
I usually prefer ```when``` to be aligned with the associated ```case```.
[*] Checking locally..
[-] Error accessing C:\windows\SYSVOL : stdapi_fs_ls: Operation failed: The system cannot find the path specified.
[-] Post failed: NoMethodError undefined method `split' for #<Msf::ModuleDataStore:0x7beb290>
[-] Call stack:
[-]   C:/metasploit/msf3/modules/post/windows/gather/credentials/gpp.rb:82:in `run'
[*] Post module execution completed

Should be datastore['DOMAINS'].split?
OK, that definitely simplifies the smoothing operation, but I still don't follow this implementation. Shouldn't you be saving
```python
prev_image = resized
```
and yielding
```python
yield resized - layer_image
```
(In this scenario, `prev_layer_image` is no longer used.)

Also, it might be a good idea to rename `resized` to `resized_image`---the one-letter difference between the variable and function can cause confusion.
This import (and calls below) need to be updated to match the rename; i.e.: `adaptive_threshold` -> `threshold_adaptive`
Is the use of this variable thread-safe?
What is this about? No javadoc.
etefaghan dishab dashtam be in fekr mikardam :D
shoma erade konin project tabdil mishe be .less :heart:
Same comment as OrthographicFrustum.js
It took me a minute to realize you meant the variable was misnamed, I assume that's what you meant anyway?  This is TAI, but julianDateTai but I renamed it to thisUtc to be clearer.
Maybe we should catch a general exception instead of CharacterCodingException.
Think you can just remove this line lea
It's a bad commit... This file should not have been commited so that's why I closed the PR and reopened a new one. But thanks for the hint :)
let's do multiple test.ok - it makes it easier to know what failed.
Ну ты же не ему сделал `new`.
Hrm, I meant "It's not a hard and fast..."
> I'm not asking it again. Judging by the discussion, the = T.init should be there.

But **it will not compile because of [Issue 8902](http://d.puremagic.com/issues/show_bug.cgi?id=8902)**. Are you judged me to fix a compiler?!
what's with this alignment? we'd use 1-level indent for this
The decimal tests in my thing test behavior for Python's implementation of IEEE 854 decimals, which is a feature of Python's json module (to allow loading numbers as decimals rather than as floats), but that's not something that is specifiable at this level, so these tests are basically all just going to be duplicating the float type tests I think.
ここの変数名も
On devrait pas plutôt hériter du pom global ?
* tableView cellForRowAtIndexPathメソッドは、セルの描画の度に呼ばれるデリゲートメソッドです。
  * セルの描画の度にdateで現在日付を取得すると、セルの描画中に日付が変わった場合に不具合が発生します。メソッドの外に出しましょう。
* weekdaysは不変の値なので、メソッドの外に出して定数にしましょう。
You should add _Independent_ too for candidates that aren't part of a registered political party.
How about injecting this?
Oh merci beaucoup pour la relecture :)

En fait là l'idée c'était vraiment de "s'être fait ses preuves" dans le sens d'avoir pu vérifier nos compétences chacun dans nos coins en tant qu'indépendants mais c'est vrai que c'est pas évident en première lecture, je vais essayer de reformuler en gardant cet esprit là.
Хуита. Это одна из тех ошибок, которые вполне можно избежать.
инит лист
Maybe rename to `gallery_template` to contrast it with the new templates you added?
No need to use the full `sakai.data.me.groups[index]` here -- you have that in a local variable in the `$.each` called `group`
Should be single quotes here and below
No translations provided for these two? Also `CHAT_STATUS` is probably not used anymore
What I don't see very clear then is what should be S? The covariance matrix of lhs or of rhs or something else? I think that for (x-y)' S^-1 (x-y) to be valid x and y must be from the same distribution.
When clicking edit page, the system will already retrieve the page content at `currentPageShown.pageSavePath + "/" + currentPageShown.saveRef`, so this code would cause it to retrieve it twice. Please restructure so we only retrieve that data once.