labofsahil/github-event-dataset-2012 huggingface dataset:
OK, should I make the change here or in the following pull requests (I
would prefer the following pull request. It will save me some
rebasing.)

I will try to clean up and post the next pull request today or tomorrow.

On 15 June 2012 16:27, Matthew Rocklin
<reply@reply.github.com>
wrote:
>> +
>> +    Specify a starting point and a vector field:
>> +    >>> start_point = R2_r.point([x, y])
>> +    >>> vector_field = R2_r.d_dx
>> +
>> +    Calculate the series:
>> +    >>> series = intcurve_series(vector_field, t, start_point, n=3)
>> +    >>> series[0]
>> +    [x]
>> +    [y]
>> +    >>> series[1]
>> +    [t]
>> +    [0]
>> +    >>> series[2]
>> +    [0]
>> +    [0]
>
> I personally find it more intuitive. I would suggest a flag return_sum that defaults to True. Not a big issue either way though
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sympy/sympy/pull/1316/files#r992929
On Thu, Mar 29, 2012 at 9:38 PM, Tom Bachmann <
reply@reply.github.com
> wrote:

> >          denom_others = []
> > -        newargs = list(args[:])
> > +        newargs, numer_others = expr.func(*args).args_cnc()
>
> Are you allowed in python to grow a list you are iterating over?
>
>
yes...this is a beginner's gotcha, too, since if you append or modify the
list while iterating you may get unexpected results:

```
>>> l=range(10)
>>> for li in l:
...  print li
...  jnk = l.pop(0)
...
0
2
4
6
8
```

A for loop like `for x in list: print x` is essentially sugar for

```
i = 0
while i < len(list):
    x = list[i]
    i += 1
    print x
```

So whatever you do to the list in the loop, the next iteration will simply
look at the next item in the dynamic list:

```
>>> for li in list:
...   print li
...   list.reverse()
...
0
8
2
6
4
4
6
2
8
0
```
"Represents that the" (this sentence was confusing me without the "that")
Is there any reason not to make this (and other is_foo's) a property?
终于安全了……

这里用`if ... else ...`，前面[解释过原因](https://github.com/yihui/knitr/pull/315/files#L2R125)了。
Huh, they were... That must have been messed up in a rebase somewhere. I'll fix it.
I actually removed this in Hoikas/Plasma/5464a2f477874b9adf210ce1a1f1f88bea948b08. It's just a stupid cache and serves no purpose.
Forgot to mention this.

First, this data should be part of the dataset  (@dataProvider bit) if it is legitimately needed.

Second, my feeling is the style tree should be derived from something else rather than specified like this. E.g. from a filesystem tree via a mock class.

Third, as we are in the test suite $phpbb_root_path cannot be here, path inside the test suite should be used.
Space after if and ).
The avatar driver should define if it needs custom HTML. As the property $custom_html is not part of the interface I'll remove $custom_html and change the behavior of handling custom HTML as follow:

* if get_custom_html() returns empty, the HTML will be created as previously, therefore this will get rid of $custom_html
* if get_custom_html() doesn't return empty the returned string will be used as the avatar driver's HTML representation
@erikfrerejean did you reply to the wrong comment?
It doesn't necessarily have to be an entire DSN string like that. If you set up named ODBC instances, all you need to provide here is its name.
Escape the second period and put this into a function.
Use a ModelForm, not this.
Alternative (maybe clearer): `let up = decode . S8.split ':' . S8.drop 6 $ authStr`
Oh... my expectation is for this to look something like this:  `Y.mojito.perf.instrumentMojitoRequest(appConfig.perf, req, res);`
Punting on this for this PR, since the issue is broader than the resource store redesign.
I would declare these vars first (before the comma/period reassignment).
Placeholder for now (work in progress -- will be fixed in later commits)
Okay. This is the user uuid of the provider. OpenMRS is weird that it requires the person uuid, not the provider uuid, when making an encounter.
add a space after this else block, to clarify that there's a separate if/else block below
uuid -> would be good to clarify if this is a personUuid or patientUuid. I see below that you are calling with the argument ```localStorage.person```. (I have seen this issue in other places, where we write provider but actually need to pass the personUuid)

encountertype -> prefer not to name it exactly the same thing as the field name. (I see below that you are passing the argument encounter*T*ype, with a capital T, instead of encounter*t*ype . Would be easier to tell what's going on if this variable had a different name altogether)
Please run code through jsbeautifier.org to keep indents, spacing legible
I understand that it makes the tests pass, but if x_data.dtype == 'float32', then node.outputs[0].dtype should also be 'float32', which is not the case.
Hmm, how is that a bug fix then?
Yes, Paul suggested that in merging his changes we needed to add an explicit flag to indicate when to infer single partition work or not.
generateOutputSchema is recursive in parent nodes. If you defer calling it until the PlanNode tree is completely built, you only need to call it once at the top.
This order of calls is consistent with that in SubPlanAssembler.addSendReceivePair which is now used for DELETE and UPDATE and will probably be used by "INSERT INTO ... SELECT".
Используется. Bundle вызывает.
I think we can achieve a more efficient implementation of `next_replication/2` here.  The use case where it matters is the one where we've got lots and lots of active databases.  In that case we're usually going to find that `is_running/3` returns false for the first item in the queue, and we'll win big if we use `queue:out/1` instead of `to_list/splitwith/from_list`.

In the event where we do have to dequeue multiple items before we find one that isn't running we should be able to use `queue:in_r/2` or maybe `queue:join/2` to re-insert the running ones at the front.  Or heck, maybe we just insert them at the back so we don't bump into them right away again.

What do you think?
the presenter has setPresenterToView that does not have any arguments ? first why this method is in the presenter ? second thing, a method called set has no arguments ??
I think this is unsafe - this way the _deleted_object_pks is class level variable, not instance level variable. Add this into __init__ instead.
I think this can also be expressed with a `.. versionchanged:: 1.4` directive.
doesn't this duplicate some logic ?
We need an absolute 100% *known* coverage.  We are unwilling to accept any lower percentage.  By this I mean all code has to either be covered by tests, or explicitly marked in the source code as uncovered, thus making it clear to all buddy checkers, and future developers that they are touching untested code.

I am perfectly happy to report in any way that the code is 20% covered if that is the true fact, but I want to be able to fail the build if any single line of the uncovered 80% is not marked with a source directive.  In other words, I trust my developers (and buddy checkers) not to sneakily get around the system, but I don't trust that they will remember to test everything.  Maybe we can have red for not covered (illegal in our code base) amber for excluded, and green for covered.  I really don't have a preference, as long as we can fail the build on "red".

mchr3k, The only change I would be very keen to have, is that we can insist on a specific comment.  So for checkstyle we force people to give some reason by having the regex // STYLE reason: (w+)  If we just let people turn it off and on, we don't encourage them to justify their reasoning, if we insist on some reason, in my experience people at least put something down.
NPM will also export `package.json` values so we can use package's version here.
Yes, but only as a schema qualifier. I think PG would update that properly?
Yes, it is assumed that the featureset table is empty, though this doesn't seem to be addressed in the CRF documentation.  Perhaps updating the documentation reflecting this assumption would be sufficient?  Otherwise, we could have the CRF module create the featureset table itself and let the user know where it is stored (I think Kun let the user specify it in the first place for simplicity, since it contains useful information for the user to look at and can be passed into the CRF test function easily).
This supports paths with spaces. :)
Just for testing. 
I must override Brain Think() method for some monster and create better AI. Using random powers is not a good solution for all AI.
For spawing monsters we got to create some time limiting spawning.
err actually I think I shouldn't change it, the array is given by the actual headers x.x
To deal with quoting issues, the correct way to do this is now

```rb
system "./configure", *std_cmake_args
```

Assuming `configure` is some wrapper script for the cmake build.
I suggest replacing *It knows about* with *It's role is to be aware of* sounds better
initiale default sortierung -> query - danach per URL param sorttype je column..
der patch ändert den default wert für sorttype von `desc` nach `asc` ..
/me scrolls down one line to read comment `# Revision does not belong to page`

(I think the problem is that the `form.` stuff in the `try` clause should probably be move to an `else` clause of the `try`
Oh, maybe i missinterpreted the sentence. „Den Proxy als Socks Proxy statt als HTTP Proxy verwenden“ would be fine :)
this method is useless. Inline that shit.
Nope, will fix
Not used in this scope
`return description[1] || '';`
The indexOf() here is required in case the path being changed is a folder. For example, if you have the following tree:

```
folder1
    foo.js
    bar.js
```

Renaming "folder1" needs to update the `fullPath` for both foo.js and bar.js, not just the `fullPath` for "folder1"
Since site relative path is not supported yet, you need to check whether query.Str starts with "/". If it is, then just return here so that we're not showing incorrect code hints.
Naming nit: would be more grammatical as "sidebarSnappedClosed" (not "Close").
Add ``TODO (issue #2166)`` comment
Put this `5` in `settings.py`. If it's `0`, there should be no throttling.

Also, throttling should be when confirming listings, not when originally posting them. Let people *save* a draft and make them wait before confirming it.
Split into multiple lines, because there very probably be more values (so that we prepare for that, otherwise, for only one value, it would be OK like this.)
Order!!!
I added the :first-child selector so it only applies the style on the first label in <li> and it is not messed with radio labels.
Changed text to Register.
Is it possible to use native tags without doing new template? so it is in the same code?
Thanks, btw
Can we iterate over all of the fields instead of doing it line by line? If you name the elements according to the fields we should be able to do that
Get rid of this, see guid() above.
Because you pass these in as args, unless you're changing them, you don't need local variables (i.e., the arg will always be available to functions inside).  Same with url/_url.
whitespace `))` -> `) )`
It did go through an indentation change in comment #r985775 above
Probably a pain to change this now - but I assume that should be `team_description`?
Same for this string as above re: length.
You can move this line as well
Covered by ops array remark, I think.
also, this made me realize that I need to update the session in the view after successful pin creation
Hier fehlt noch die port angabe falls != 80
@jcredding - yeah, but you are right - that sentence is still confusing.
As said in #500, here we should pull ` ` and `.`. (My fault)
Windows platform data gets grabbed as part of the ```platform.uname()``` in ```os_data()```.
Is there a tab(\t) in this line(35)?
And since it appears that nothing else is done if `salt.utils.is_windows()`  and `not has_dependencies` could this become:
```python
if salt.utils.is_windows() and has_dependencies:
    return 'pkg'
return False
```
What is all this "TODO Auto-generated method stub" for?
Since all the values are going to be `Some(..)`, you're better of just using `.map` rather than `.flatmap` and returning the boolean in the closure rather than the `Option`. It reduces some overhead
`PATH.resolve()` лучше делать от фиксированного места, например `__dirname`
is it really problem? If so, then why continue with execution?
Oh. Good to know. I actually made these pull requests by simply pressing “Edit” in the web interface, though. ;)
TextS ?
This ought to go a few lines down (after M303).
Then you should use only a NormalizerFormatter and still pass ``$record['formatted']``. ``$record`` itself is not safe to encode (you can have resources in them and so on), and in ``write``, it would contain duplicated info (as the formatted record would have been added in it)
Ok, will move it to where it was before for now. Will do some perf tests to see whether there is a difference and we'll see.
Hey :)
Could you insert the code directly in the repository instead of referencing this external website?

This way everybody can contributes fixes/reviews.
https://bugzilla.mozilla.org/show_bug.cgi?id=757859
Can this be an explicit import list, or possible and an `__all__` to `core.py`?
In the coding guidelines (http://docs.astropy.org/development/codeguide.html) we put:

*The package should be importable from the source tree at build time. This means that, for example, if the package relies on C extensions that have yet to be built, the Python code is still importable, even if none of its functionality will work. One way to ensure this is to import the functions in the C extensions only within the functions/methods that require them*

This is what we did for example in nddata.convolve - we just import the cython extensions when they are needed. We definitely need *some* mechanism* though, as astropy should be importable without building.
My intention was to have a function that cleaned the data directory but not the configuration of a number of nodes, although here I'm using it to wipe out the entire cluster anyway. How about refactor to have: clean_cluster() with the git reset and make it public (setup_harness is marked private), then make a clean_node_data(Nodes) with that I have in clean_cluster(Nodes) now?
typo: "a URL"
I realise that :)
@cordoval The php-cs-fixer does not enforce this blank line. but it will align the grouped annotations. Separating params and returns allow to align them separately (if you return ``\Doctrine\Common\Collections\Collection``, it will avoid moving the param names far away on the right
You're sorting in ruby here. I think you should do this with an order statement on the query.
the problem is that sometimes we will have the name and sometimes a real object. i just pushed a big commit that makes this explicit and lets the factory use the driver to translate. getTypeByName / getTypeByObject / getTypeByRdf
Ah, vlastne hej. To je specialny pripad z XML-ka (ale vzdy je to jeden znak)
That is the only other way really.  In the long run we can't really assume that the notebook directory is served by notebook server in library code.  In contexts where the kernel runs on a different host than the notebook server, this directory won't be available.  Because of this I think that using `display.HTML` is a better option.
Maybe a bit more detail on who is the "me" that is closed.
I'd refactor this to follow most current conventions, in the openstack-keystone project.

ex. properties in PooledComputeServiceProperties in the config package
I can easily move this functionality down the stack to be supported as part of the swift api implementation. Is this middleware available on all Openstack Essex Swift providers? I will check on HPCloud and report back. @adriancole how can we handle / discover optional features?
hmm, good point about users going offline and making edits.

Maybe we could add a time limit and only delete operations older than an hour or two?
I like the approach you've taken to defining an AmigaOS specific version of p_readdir_r below. I think if you take that idea all the way, you can get rid of this #ifdef. See further comment below...
It does, but I'm not sure that it will correctly parse multi-line comments on values. I think it just handles the:

```c
enum {
    GIT_DIFF_NORMAL = 0, /** This is a one line comment */
};
```
For some of the longer explanations, I'm not sure what it would do...

Of course, the advantage of inline comments would be that the comment header block would not get out of date with respect to the values, as I have apparently allowed it to do in the last commit to this PR. :wink2:
The `name` is not necessary. Either remove it or add the corresponding `%s` to the string.
FieldAwareQuery could return empty string, consider moving the colon to the super.toString(), only when not empty.
add a template file `mailer.yml.template` and version it
I would like to note that this line generates an int with a value ranging from 0 to 99, which effectively increases the chance of a drop by 1% based on the values you were using in the configuration. To correct this, you would need to add 1 to it after generating the random int.
Instead of storing a keycode, you can just `return true` here to exit the function early.
My mystake, I correct this.
Why don't you re-use prefs_file here?
This is kinda like a unit test so we wouldn't need all the UI stuff but could directly operate on the `utils.saveScreenshot()` method. So the `check_screenshot` method is not necessary. Put everything which handles saving the file in the test method. Other code can go away.
and same efficiency note here
I think this docstring means to say `PATCH`, not `POST`
since this is LESS, you could put all the following under `#tutorial`
Would make sense to remove this change since it is whitespace only.
You're falling into a boolean trap. In your simpler example the false `((0))` only prints return because you've got `||` in there.

~~~ { .bash }
function do_discard() {
  ((discard_sources)) || return

  echo 'discarding...'
}

discard_sources=0 # False

printf "%d\n" $discard_sources
do_discard

discard_sources=1 # True

printf "%d\n" $discard_sources
do_discard
~~~

More of your fixes also suffer from the same problem.
yeah forget to remove :/
but we got that problem covered here
https://github.com/pyrocms/pyrocms/blob/2.2/develop/system/cms/themes/pyrocms/js/plugins.js#L13
ill push a fix in a minute
So true, please see the new commit that actually deals with this.
Actually when I send an array  (query->toArray) and I pass it like you can see in the code, the result after build the query is something like this: "filter":{}}} 
So, I think that I need a string because it's the only way I found to make it work. I have tried with term queries and string queries, and no way :-/
Usually boolean methods are prefixed with `is`. `getStrictParameters` sounds like it would return an array of parameters.
It's because of merging min into pattern. But if it's useless i remove it
it should be ``0 === $i``
I'm not sure whether the comment is to json or urlparse. I committed an update to use the Django's json implementation instead of the json (which was only added in Python 2.6). urlparse has been in Python at least since 2.2 and we probably don't need to support anything older.
I think this might be replacing tabs with spaces.  Not sure.
What are all of these imports for?
They'll be in the category once that refactoring is done (see comment below)
I like the cleanliness of this. Maybe more descriptive names like `invited_groups` and `yammer_embed_feed`?
嗯，我正在一步步修改这个....
i would also maybe put a comment in here like,

```ruby
# Purpose of this is to keep additional tagtical class level methods grouped together with the acts_as_taggable call.
```
Is it needed? Couldn't someone save tiff file to the file 'exr'? Or this situation doesn't matter?
It's totally right Jonathan, thank you very much for your work.

I would prefer to move the special case from `Hookable.add_hook` to another place like https://github.com/codegram/spinach/blob/master/lib/spinach/runner/scenario_runner.rb#L45.

I guess it won't be easy work. I was waiting for this pull request to make a new release but since it's a bug fix, I will probably release the new version and then add this as a patch when ready.

Cheers and thanks again!!
with and height user definable in the plugin ... aka 2 new fields.
> What version of PySide do you use? I have a setContentsMargins method on the QVboxLayout object :

I fixed that comment line in a later commit :). Thanks for the review,
Didrik
This is a really, really good step. It indicates intent with no mention of implementation.
i htink these were duplicates, thats why i wanted to add some tests in our test suite in #460
these changes turn the data list icon secont into a button bar
You're right the attributes have the flags :-) Sorry about that!
Removing the variable sounds good
In most cases this will have no effect, unless the bean that is being picked up has interceptors or decorators, so WARN is probably a bit too verbose, DEBUg is probably fine.

Also I just realised I need to changed how this filtering is done, as someone may have say created a producer method with the same type and qualifiers, so hold of merging this for now till I update it
The only place this set is updated is when the receiver is started and that's done by a single thread.
This field should be volatile
This should follow our normal creation syntax: `$( "<span>", attrs )` or `$( "<span>" ).attr( ... ).addClass( ... )`.
I'd like to deprecate the hash signature anyway.
Please review our [coding standards](http://docs.jquery.com/JQuery_Core_Style_Guidelines).
I wouldn't recommend accessing the DOM elements via the L10n code strings since these may change on the UI side (HTML + locale files) causing this code to stop working.
Sounds a good comment to add to the file :)
@etiennesegonzac the concept behind this is not only picking a contact but also  to show FB information in the Contacts app and enabling certain additional communication operations (send message to the wall, send a message to the contact etc.) FB information is persisted in a separate DB because of FB requirements for information quarantine and to avoid that other apps may get access to this info.
same thing applies here, sigh
Sure, wait for your reply. Thanks
nit: operator at the end of the line
```javascript
        throw new Error('Unable to add following directory in zip: ' +
            file.path + '\n' + e);
```
This looks weird, you probably want to remove the whole setTimeout instead.
good catch; i think the frequency here would have mistakenly been the count of the word that occurred latest in the sort. looks like you already fixed it in 5be197b26e7ff9dc22f869edac03cbe712173154 :)
I get that if the check has a key='' the check is passed - but the:
- ['', '', '']
- ['', '', '']
- ['', '', '']
pattern reads disconcertingly like there is a mandatory 3 checks per question.
I would set this only if the `setPath` succeeds - makes sure the states are consistent.
`minimumLengthPerPoint` please :-)
What's line?
What happens in the `else` case here? Do we need to send back an error response of some sort?
Does it make sense to add classOf[Writable] here? Will this scheme actually work if cascading doesn't know exactly what class it should return?
Like for `client`, you initialize `ret`, but then immediately initialize it again a few lines later. Why?
Good to put references like this, but this one is very "thick" for anyone not already versed in statistics.  Might be nice to put a short one-liner here summarizing what this is, so it's a bit less 'magic' :D
We want to retain these tests.  Your refactor seems to have lost them in the shuffle.
Actually, what you want is IMHO done in the abstract public void load(BrixNode node); function as this one is responsible to be called upon loading and can also be triggered manually uf required;
D'oh!  Removed as part of an upcoming commit.
It wouldn't be possible for `check` to be `null` here. And I agree; `check?` is more idiomatic than `_.isUndefined check`.
Non ! C'est une faute courante de mettre un chapeau à tout bout de champ. En l'occurrence je vous assure qu'il n'y en a pas.
« dites » sans chapeau, c'est l'indicatif ou l'impératif (ici, Edas parlait à l'impératif).
« dîtes » avec chapeau, c'est le passé simple. « En ces jours sombres, vous vous dîtes que blablabla. »
http://leconjugueur.lefigaro.fr/conjugaison/verbe/dire.html
Try to around such expressions by brackets for better readability
For the time being I'm working with setting destination == CAP_FREE to leave the option for capability number reuse. This may not be desirable, and it would be fairly easy to replace with CAP_FREE meaning that cap_num >= ncaps.
!important¡
It's probably worth logging something here to notify the user that there was an error. Otherwise you might end up with "auto-exit" behavior if something breaks, which is possibly even more frustrating.
You may have to refactor things a bit for this, as doing a per scan malloc is undesired. Maybe a thread local prealloc'd buffer or passing detect engine ctx.
this is like 60°, I think that's not possible any more for the soft casing. Why do you need to extend the range of the pan joints? If it is just for the homing, then let's set them to a resonable value close to the homing switch.
Joomla! standard validation errors:
 256 | ERROR   | Whitespace found at end of line
Would be better to extend `EventTarget` instead.
I don't quite follow what's the point of this, you newer refer to `this`. Please remove or explain in comments.
getOwnPropertiesDescriptor is strange as far as English is concerned. Even though it doesn't return an array it's still returning a collection of property descriptors so I'd lean towards getOwnPropertyDescriptors myself.
I'm not worried about database traffic right now.  In all of our load testing it's not yet on the radar.

I *AM* worried about the fact that the write will never succeed.  It's being performed in the `browserid` process which has read-only access to the db.
This sentence isn't entirely clear. Is it looking for a parent that itself passes the test (relative to what threshold?) or is it looking for a parent that, when used as threshold, causes the current revision to pass the test?

What happens if there is no parent in the system at all? How do we handle the bootstrap base case?
Well then in that case: your solution is better :-)

Matthew Riley MacPherson | http://lonelyvegan.com


On Tuesday, 5 June, 2012 at 4:08 PM, Piotr Zalewa wrote:

> > @@ -132,6 +133,29 @@ function getRecommendations(dbClient, categories, callback) {
> > });
> > }
> > 
> > +function addClick(dbClient, slug, callback) {
> > + // increment the number of clicks for the webApp
> > + // TODO: we should somehow pass this info to the Marketplace
> > + var clicks = 1;
> > + dbClient.get('clicks:' + slug, function(err, reply) {
> > + if (err) {
> > 
> 
> 
> reply is a string containing a number > 0, so yep - if (reply) will work well
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/newnewtab/pull/24/files#r928852
> 
>
Do you have a bug open for AMO to support changing the pref? If not i would like to file one.
It doesn't appear that this method is ever used.
Referring to ParseError: I just moved it.
Missing something here, right?
try...catch的粒度是否可以更小。
The order of the attribute definitions in a FG definition does not technically matter, so we get to sort it as we please.

The attributes are seldom related to one another in a useful way, and we seldom deal with tables with so many required fields that these definitions grow unreadable. I'm fine with ordering attributes alphabetically.

The argument in favor of ordering factory definitions semantically breaks down when we consider nested definitions. For example, `:admin` should be defined near `:user` and `:moderator`, and because of nesting it will be:


    factory :user do
      email 'h-dog@example.com'
      password 'v3n3zu3la'
    
      factory :admin do
        admin true
      end
    
      factory :moderator do
        moderator true
      end
    end

And that's why I'm OK with both of these guidelines.
I'm going to overlook this for now, as there's quite a few places we're already doing this... I haven't seen anything in our CS about this, but it's possible I missed it or forgot. Perhaps it's a good meeting or mailing list topic.
...
$error = ErrorHandler::stop();
if (false === $fileHandle) {
    throw new Exception\UnexpectedValueException("Cannot open '$this->filename' for reading", 0, $error); // previous error
...
это новая фича, см пулл https://github.com/BrandyMint/investcafe.ru/pull/669
@cordoval put with comment like, complete, done the commit hash code it's will be help to easy recognize what for this fix
It's confusing that Test extends the Example class, they represent quite different things. The only thing I can see they both use is `wrapWithPre`, but it doesn't make any sense to me that `wrapWithPre` is a method, it should just be a normal module level function.
For me it's ok, to use the dafaults if no settings file is found. But if it's causing syntax errors, i think we should `process.exit(1)`.
This should be in the template, not in the code.
Ok, so I made an attempt at using the function, but am still not successful. I am not sure what constants to pass the function, I think.

So here are the code snippets in LapPainter:

CExtendedLap* pLap = lstLaps[x];
...
float* r;
float* g;
float* b;
MakeColor ( pLap, r, g, b); // Final color to use.  Tells opengl to draw the following in the colour we just made up
...

Down where other Void functions are defined:

// Function for setting highlighting color, making sure that there is enough contrast to a black background
void CLapPainter::MakeColor(const CExtendedLap* pLap, float* pR, float* pG, float*pB) 
{ 
	srand((int)pLap);	//  <-- makes sure that we randomize the colours consistently, so that lap plots don't change colour from draw to draw... 
	do { 
	*pR = RandDouble(); 
	*pG = RandDouble(); 
	*pB = RandDouble(); 
	} 
while(*pR + *pG + *pB < 1.5); 
glColor3d( *pR, *pG, *pB ); // Final color to use.  Tells opengl to draw the following in the colour we just made up
}


And in the LapPainter.h header file:

private:
  void DrawGeneralGraph(const LAPSUPPLIEROPTIONS& sfLapOpts, bool fHighlightXAxis);
  void DrawLapLines(const LAPSUPPLIEROPTIONS& sfLapOpts); // draws laps as a map
  void DrawSelectLapsPrompt() const;
  void DrawReceptionMap(const LAPSUPPLIEROPTIONS& sfLapOpts) const;
  void MakeColor(const CExtendedLap* pLap, float* pR, float* pG, float*pB); 
private:
  ILapSupplier* m_pLapSupplier;

I am getting this error after compile completes, runs the EXE and I click on a lap:

Run-Time Check Failure #3 - The variable 'g' is being used without being initialized.

leading to:

Unhandled exception at 0x01303751 in PitsideConsole.exe: 0xC0000005: Access violation writing location 0xCCCCCCCC.

Any ideas what I am doing wrong? I am thinking it's something in the way you (I think) are using dereferenced pointers for your arguments into MakeColor, and I am using and open float* definition for r, g and b.
Is this TODO now done?
you could simplify it:

```yaml
packagist.form.handler.registration:
        class: Packagist\WebBundle\Form\Handler\RegistrationFormHandler
        parent: fos_user.registration.form.handler
        scope: request
```
We cant move PersistentCollection, that can be considered a BC, since i know enough people doing instanceof PC checks in their code (yeah go figure :()

Also this has nothing to do with Collections\Expr. It is used inside the Persisters not only for Collections but also for the EntityRepository.
where are those coming from?
you should not use the underscore IMO. New classes don't use them in Doctrine
You really need to add documentation here, describing what this does, and how it works.

Maybe also information on how to change this if you're using a different directory structure to organize the easyblocks in.

Is there a way to make this more generic, so that it works no matter what the easyblocks subdirs are? E.g. use `os.listdir`, and extend `_path_` with that?
should update dictionary returned by parent instead of creating new one
How kontrary.
As a general rule, please remove trailing slashes, unless it won't worth otherwise.  The point is to try to ensure that trailing slashes are being added by Apache/.htaccess
No entirely my mistake.. I thought it was a class locator and typo missing a `.` but whenI checked the html it's a tag. We're happy with tags, they're pretty reliable :)
What qualifies as "necessary"?
This test should probably be in the module Popcorn plugin, and not cure track.
Don't do copy/paste?
doesn't look too robust a ckeck... and I'm not sure that DEVSERVER is the only exception and why at all we need exceptions :)
file wildcard != wildignore, and this is not a Vim bug, just a peculiarity of backtick-expansion.

If you have a local config named `.local.foo.vimrc` and `:set wildignore=*.vimrc`, this should trigger the error when editing a filetype `foo`. The filename gets passed into the function, but backtick-expansion, as it observes the `'wildignore'` setting, fails to expand it, so the sourcing fails.
Instead of `isTopLevel` as you previously suggested, what about adding the view that triggered the event in the options? Then we could do:

    if (options.triggeringView === this)

or similar.
Ought we have a story to make tests, or should they be added before the PR is merged?
somewhere in `setup()` we should add `Khan.scratchpad.disable();` Otherwise people that have the scratchpad turned on will just end up scribbling all over the code editor rather than being able to click on it.
this line of code needs work
Absolutely similar. I found that this way only is working. Any tries to isolate those methods to dedicated place and share between component and binary store cause random failures during value set procedure.
This and the two below. For example:

this is on line one
this is on line two
Two things:

1. I'd prefer an ``ImmutableLIst`` over just a ``List``.
2. Could we name it something besides ``connectionInitSqls``? I'd rather have a longer property name which folks don't have to squint to understand. Maybe ``connectionInitializationStatements``?
unwrap does this internally i believe, so you don't really need this if/check ... just straight up call `unwrapObservable`
you should not set the second parameter to false because doing so prevents the in memory cache from being used, as  a result, you might fetch from the database the same section several time in the same page.
What changed here, did you add whitespace?
Not in my tests. It just limits the amount of time for the respawn to occur to a sensible level.

Maximum time for a respawn = 2187 seconds.
Dave, have you had a chance to get this information? If not we should get this pull merged because we have to release a new version of mozdownload today.
Single character variable names?

I hate you.
I would replace all this code with:

        cursor = self.textCursor()
        position = cursor.position()
        self.movePosition(QTextCursor.StartOfLine, move)
        self.movePosition(QTextCursor.WordRight, move)
        if position != self.textCursor().position():
            return True

It has the same functionality, just with a little problem, when a line starts at the 0 position in that block....... for example:

from StringIO import StringIO

if you press "home" is going to place the cursor here: |StringIO import StringIO
And after press it again is going to be here: |from....

That's the only problem it has, but maybe there is someway to fix it, and we avoid the need to use loops.
Wouldn't hurt to make `xml` `const`.
Having multiple widgets with the same id is probably bad form. Would it perhaps make sense to share the same class name but have distinct ids?
needs docstring update
Ok cool, I'll update and push.
Shouldn't this be inside some sort of Ruby block?
Uploading and cropping need to happen in two separate requests as the UI cannot show a picture that sits locally on the client.
Flow:

Show upload form -> User selects local picture -> Upload it -> UI shows the <img src="..." -> User selects the area he wants as his profile picture -> Crop it out.

That requires the generateSizes to be exposed so the rest handler can call it
Sorry, my misunderstanding. It's ok as you suggested!
No, this can't happen, the index is only used in the call to `occurrencesIndex.occurrencesOf` a few lines down. But we can still add the assertion as a means of documentation :)
What is the codepath for not using a self-signed cert?
This one hasn't been updated for 2 years and there is no support for Ruby 1.9 code coverage, so I assumed it was dead. If you still use it as-is, nevermind. :)
Thanks, added a couple of ignores.
If it's not within dependency manager, every single inherithing sample will have all those dependency.
This one looks weird - use a tab for the indentation.
This looking good, but can you follow the style guide? Brackets on the next line, variables as snake_case, etc.
Because we can! :)
Ну, мне сначала показалось, что это будет круто выглядеть, типа `mutateWith:percent`, а теперь правда уже так не кажется.
Настройки клиента? Настройки игры?
This line and the one below need to be out one tab
this one is the most impressing picture i have ever seen.
Antes retornávamos um array de models de Manager, agora retornamos um array que o paginator retorna. Mas este array é um array comum ou um array de models de Manager?
gh deleted this line automatically but it seems that it didnt changed anything
因为跟原来的range的使用差异还是蛮大的，为了不增加大脑负担，还是取名为ranges，也是工厂函数的意思。
Heh, I figured gofmt would fix it, guess not.  Fixed.
I agree with @dahlbyk - for the common case where the amount of content is going to be small, does it hurt to leave the `Content` property? I like the suggestion to add a comment to the API regarding using `ContentStream` when the memory pressure is not acceptable.
Sounds good

Sent from my iPhone

On Dec 7, 2012, at 4:52 PM, Matthew Grigajtis <notifications@github.com> wrote:

> In spec/lib/easystats_spec.rb:
> 
> > @@ -5,6 +5,8 @@
> >  
> >    it { should respond_to :average }
> >  
> > +  it { should respond_to :wma }
> Should we simply remove the wma alias?
> 
> —
> Reply to this email directly or view it on GitHub.
>
:-) I must have been tired when writing this ;-)
We have to use the `global` instance provided by the application at Runtime.

```
val global = play.api.Play.maybeApplication.map(_.global).getOrElse(play.api.DefaultGlobal)
```
On the very first request, the session will always be empty. If the first page contains a Form, you'll need a token to be there.
Bad i18n. Please include all the parts of the sentence within the internationalized text.
won't this catch if the repo value contains any of these characters anywhere in the string? like, `hg://gitastic` might cause RTD to think it's a `git` repo instead of a `hg` repo?

also why unwrap the `repo` element?
Bad i18n. Whole sentence, please.
Ditto this with parentheses.
Is there a benefit to not using Timecop for this?
I simply got it backwards.
I don't mind getting rid of it
This is also a regression.  In master:

```py
In [34]: solve((a**2 + 1) * (sin(a*x) + cos(a*x)), x)
Out[34]: 
⎡ -π  3⋅π⎤
⎢───, ───⎥
⎣4⋅a  4⋅a⎦
```

(and by the way, shouldn't the `a**2 + 1` make no difference?
I suppose that in this case you can just skip the doctest (using #DOCTEST +SKIP or something like that, I do not remember the exact string). If the others find it appropriate you can add a test (not a doctest) using `raises` and setting all warnings to errors.

Also you may find gist to be a superior alternative to pastebin (check the link at the top of the page).
Что бы полное имя помещалось же. Иначе оно как говно выглядит
Verificado, el id no es necesario, lo quito, hago otro pull request y lo mergeo.
En los métodos de MVC, por lo general, ControllerName por defecto es null y corresponde al controlador actual
Me gustaría modificarlo por :

* Tenemos problemas de organización en nuestras reuniones con Gabriel, creo que tenemos que tener en cuenta sus necesidades y opinión, pero que no puede cumplir el rol de _Product Owner_. En ese sentido opino que el uso real que se le dará e involucrar a otras areas de la empresa será bueno para el avance del proyecto.
Default?
PRINTLN!
+1, extracted in a different commit.
(this issue doesn't exhibit on 5.1 though, but makes sense from a history POV)
Galder, interruption doesn't fit very well here because this is a task that is submitted to an executor, and it doesn't hold a reference to the thread it's running on or to the Future returned by executor.submit(). 

Another issue is that an interrupt() call during serialization results in a completely different exception from jboss-marshalling. So we'd still need a flag of our own to know if the task has been cancelled.
Not sure I understand... this is two line of code that you want in a function?
no I just moved the include to the header
I would prefer to see more than one column of groups. This will make the page shorter and make the configuration appear less daunting should there be several groups available to pick from.
Add docblock comments to methods
@apex13 Can't we remove all the CSS that contains `context_menu` (also in `sakai.base.css`) ?
I didn't found any references in the HTML or JavaScript.
`__MSG__OTHER_DOCUMENT__`
@jsloane Thanks for catching - should be fixed in my next commit
well you cannot use cblas_dgemm then but have to manually consider vector / by vector
Can you do an assertType here? It could just be a new instance of UnsavedRelationList, and your test wouldn't notice :)
what about ViewFactory class name, that would be more descriptive..
please use camelCase for valiable name
Ternary operator is simpler when placed in a single short line (withou calling several functions) without wrapping, for example like you mention "return condition ? x : y;".
It is not just formating issue, if simply to debug step by step and you can set breakpoint to "if" or "else" part.
I think we're saying the same thing: writes for eviction could return early but sync writes would continue.  I'm going to add a a note about this to #218: it sounds like we should wait until that is fixed before making this a more common case.
Please review: the code in this file up to this point are the 2 functions that support walking a tree with unread (and potentially deleted), nodes, and decide if the node can be skipped for a read cursor, or can be fast-deleted for a truncate cursor; the 3rd function is the one that unrolls fast-delete operations if the op aborts.
I'd separate the API issue from the flag, which we can change in whatever way we like.  I'll switch the API to default "transactional=on", we can worry about the internals later.
Removed not used uses.
one small nit! :) set $('#map') in a var so it's cached once and not called twice. e.g. var map_el = $('#map');

new OpenLayers.LonLat(map_el.data('lon') ....
Could be improved
We could check for this.
Should the type for parameter ``$testMessage`` not be ``string|null``?
", DO IT." (Comma, not period.)
break this up with a newline?
How about CFBridgingRelease here instead?
should we be using $.ajax for the error handling?
CS

```php
<?php
public function getError()
{

}
?>
ahh, thanks. fixed and pushed.

- Nathan


On Thu, Nov 29, 2012 at 9:59 AM, rick <notifications@github.com> wrote:

> In services/asana.rb:
>
> > @@ -7,32 +9,49 @@ def receive_push
> >
> >      user = payload['pusher']['name']
> >      branch = payload['ref'].split('/').last
> > -    # rep = payload['repository']['name'] + "/" + payload['name']
> > +
> > +    branch_restriction = data['restrict_to_branch'].to_s
> > +    commit_restriction = data['restrict_to_last_comment'] == "true"
>
> It'll equal "1", not "true".
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/github/github-services/pull/460/files#r2265581>.
>
>



-- 
Nathan Potter
VP Engineering, Chartbeat
--------------------------------------->
@mr-lee When will this exception be thrown?  It concerns me that a create_index call may appear to succeed even though no index is created.
Fiksa!

On Sat, Sep 22, 2012 at 4:56 PM, Jari Bakken <notifications@github.com>wrote:

> In puppet/modules/munin/manifests/init.pp:
>
> > @@ -0,0 +1,6 @@
> > +class munin {
> > +  notice("dette er i init")
> > +  exec {"ls":
> > +    command => "ls"
> > +  }
> > +}
>
> Hva er dette? :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/holderdeord/hdo-puppet/pull/1/files#r1667703>.
>
>
Any changes to JHttpResponse that came about when JHttpFactory was added?
We should have requests==0.11.2
So actually, we don't support the `unpaid` status any more, now that we have a separate `/quote` call; can you use `status="pending"`as an example instead please.
Eventually we'll probably separate out the breaking changes in the release log. Just an FYI.
We should use a StringBuilder here.
Don't we have function names with underscores?
ok i figured out, will make pullrequest
*emailReg* -> *emailRegex*
In password checking, there we do not know if `password1` is available, so we try to get it with `get` and if we get something, we check it.
Fixed.  Turns out that that back end was so old that it didn't have the proper callbacks
or args in the correct order or -spec's or ... silly me.
Can this change be backed out now?
Please change this to return true for better readability, and do so for the rest of the file as well.
Have they dropped the aqua support? Is this `depends_on :x11` also needed if `--enable-aqua` was given?
Have you tested aqua support?
This is the data sent from Shopify which was generating the bug. I'll trim out the unused options.
packedGuid is usually 6 or 7 bytes, uint16 takes 2 bytes (just a fyi, no need to change)
if (path[node_Idx].actionFlag == 2)
    t -= time_step / accelRate;     //deceleration

ofc.
Please don't do it. Let it default to ``null`` (which uses the default manager) instead of modifying the default values. Avoiding changes in the definition in unexpected places would make the maintenance easier
I guess making "size" 32 bits will be another change?
This isn't any clearer than a ```def``` named ```UserAgentHeaders```. Lambda isn't a net win.
We can't do this: ``DateFormat`` is not threadsafe.
Formatters should either
 - be handled in a ThreadLocal initialized by your custom constrictor
 - created on-demand for each conversion
 - synchronized for exclusive use

This might appear to work, but when used under load the conversion might result containing partial fields from other dates being converted by other threads.
Wat mij betreft skippen we de tests of de service manager is geconfigureerd. Dat kunnen we wel testen in de Module class test oid
After browsing java concurrency in practice it looks like yes, that would be right thing to do.
As API, it wasn't possible to use kwargs instead of dict args ?
Just to instantiate it in simpler way:
```python
my_database = models.RedisDatabase(host="localhost", port=6379, etc=etc)
```
This sentence does not mean anything.
A private member starting with underscore should always only be accessed on the this, everything else is basically wrong. But if request_id is only something which you have define as internal helper, then it would perhaps make sense to expose an according method to check what you need to check here? I don't know the details of your design well enough to say if that would make sense or not though.
You would get that check a bit cheaper with a reg exp.
firstElementChild might be safer, unless it's guaranteed to be an element.
I think we should remove this altogether. It's an  incomplete implementation of `classList`, ci 167 has `classList`, and further down in this file we check for `document.createElement('div').classList` again. AFAICS that following code would actually fail because of this incomplete implementation here.
As previous note but for Enabled rather than Disabled
IIRC robn picked up a complex collision there a long time ago. I'll rename it planet_.
Done. Emacs gets confused by Javascript...
The head is separated from the body here — is this supposed to symbolize decapitation?