Unreviewed, rolling out r123182.
http://trac.webkit.org/changeset/123182
https://bugs.webkit.org/show_bug.cgi?id=91863

Causing ASSERT crashes in tests accessibility/canvas.html and
accessibility/canvas-accessibilitynodeobject.html (Requested
by jernoble on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-20

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* accessibility/AXObjectCache.cpp:
(WebCore):
* accessibility/AXObjectCache.h:
(AXObjectCache):
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
(WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
(WebCore):
(WebCore::AccessibilityARIAGrid::create):
* accessibility/AccessibilityARIAGrid.h:
(AccessibilityARIAGrid):
* accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::create):
* accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::create):
* accessibility/AccessibilityAllInOne.cpp:
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::create):
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::create):
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::create):
(WebCore::AccessibilityMediaControlsContainer::create):
(WebCore::AccessibilityMediaTimeline::create):
(WebCore::AccessibilityMediaTimeDisplay::create):
* accessibility/AccessibilityMenuList.cpp:
* accessibility/AccessibilityMenuList.h:
(WebCore::AccessibilityMenuList::create):
* accessibility/AccessibilityNodeObject.cpp: Removed.
* accessibility/AccessibilityNodeObject.h: Removed.
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
* accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::create):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::create):
(WebCore::AccessibilityRenderObject::detach):
(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
(WebCore):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
(WebCore::AccessibilityRenderObject::ariaRoleAttribute):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::setRenderer):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::create):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore::AccessibilityTable::~AccessibilityTable):
(WebCore):
(WebCore::AccessibilityTable::create):
* accessibility/AccessibilityTable.h:
(AccessibilityTable):
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::create):
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::create):

LayoutTests:

* accessibility/canvas-accessibilitynodeobject-expected.txt: Removed.
* accessibility/canvas-accessibilitynodeobject.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK][jhbuild] Switch to GStreamer 0.11 build
https://bugs.webkit.org/show_bug.cgi?id=91727

Reviewed by Gustavo Noronha Silva.

Switch build-webkit --gtk to GStreamer 0.11 support and build the
necessary GStreamer git modules from JHBuild.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
* gtk/jhbuild.modules: GStreamer build support.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Rebaseline failing test svg/as-image/svg-non-integer-scaled-image.html

Unreviewed test expectations update.

* platform/chromium/svg/as-image: Added.
* platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening, adding platform-specific baseline that's required
after changes in r123145.

* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: disable fake workers inspection.
https://bugs.webkit.org/show_bug.cgi?id=91867

Reviewed by Vsevolod Vlasov.

'Fake workers' is unreliable error-prone way to debug workers. There are a
lot of frameworks supporting it. Inspector should not do that since it has a more
powerful native worker inspection capabilities. Port owners should enable it
in case they want to provide workers debugging.

* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::InjectedScriptHost):
* inspector/InjectedScriptHost.h:
(InjectedScriptHost):
* inspector/InjectedScriptHost.idl:
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::enable):
* inspector/InspectorAgent.h:
(WebCore):
(InspectorAgent):
* inspector/InspectorInstrumentation.cpp:
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
* inspector/front-end/InjectedFakeWorker.js: Removed.
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane):
* inspector/front-end/externs.js:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
* workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::contextDestroyed):
* workers/AbstractWorker.h:
(AbstractWorker):
* workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
* workers/Worker.cpp:
(WebCore::Worker::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, managing a few more unexpected passes for the GTK port.

Remove a few expectations for tests that were passing, reclassify some failures as
architecture-specific and add PASS expectations for a few tests that pass even though
they test features that are currently not supported on the GTK port.

* platform/gtk/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Enable GPU-accelerated skia implementation of
feDiffuseLighting, feSpecularLighting.
https://bugs.webkit.org/show_bug.cgi?id=91865

Reviewed by Dirk Schulze.

Translate the light parameters into the appropriate
SkLightingImageFilter calls.  This path is only enabled when
the filters are created with the Accelerated flag set.

This will be covered by tests in svg/filters/* when they are
added to the virtual GPU tests.

* WebCore.gypi:
* platform/graphics/filters/FELighting.h:
(FELighting):
* platform/graphics/filters/skia/FELightingSkia.cpp: Added.
(WebCore):
(WebCore::FELighting::platformApplySkia):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening, rebaselining a test after r117477.

* platform/gtk/TestExpectations:
* platform/gtk/tables/mozilla/bugs/bug10296-1-expected.png:
* platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r123220.
http://trac.webkit.org/changeset/123220
https://bugs.webkit.org/show_bug.cgi?id=91880

broke Debug build (Requested by philn on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-20

* Scripts/webkitdirs.pm:
(buildAutotoolsProject):
* gtk/jhbuild.modules:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Port bugs.webkit.org to mod_perl for new hardware.

Reviewed by David Kilzer.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Added/updated missing fast/table results after rebaseline
https://bugs.webkit.org/show_bug.cgi?id=91621

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-20
Reviewed by Noam Rosenthal.

The following tests were failing after r122985:
  fast/table/003.html = TEXT
  fast/table/colspanMinWidth.html = TEXT
  fast/table/spanOverlapRepaint.html = TEXT
  fast/table/text-field-baseline.html = TEXT

This patch includes/updates the missing expectations.

* platform/qt-5.0-wk2/fast/table/003-expected.png:
* platform/qt-5.0-wk2/fast/table/003-expected.txt:
* platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.png: Added.
* platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.txt: Added.
* platform/qt-5.0-wk2/fast/table/spanOverlapRepaint-expected.txt: Added.
* platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.png: Added.
* platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix missing css1/text_properties/text_transform.html results (txt)
https://bugs.webkit.org/show_bug.cgi?id=91875

Expected txt result was added.

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-20
Reviewed by Noam Rosenthal.

* platform/qt/css1/text_properties/text_transform-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Baseline align text in the flakiness dashboard toolbar
https://bugs.webkit.org/show_bug.cgi?id=91784

Reviewed by Ojan Vafai.

Baseline align the flex items.

* TestResultServer/static-dashboards/flakiness_dashboard.css:
(.forms): Add box-align: baseline
(.forms > *): Use block display to force flex items rather than box.
(#tests-form): Add box-align: baseline
(#tests-form > *): Use block display to force flex items rather than box.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
CodeGeneratorInspector.py is unnecessarily chatty
https://bugs.webkit.org/show_bug.cgi?id=91758

Reviewed by Vsevolod Vlasov.

The code aded in r123091 included a "print" statement for each written
file. This makes for noisy build output, especially noticeable in the
Chromium ninja build (where build output takes up a single line of the
console).

If this print statement is generally useful, it should be
hidden behind a --verbose commandline option, as we do for the binding
generators.

* inspector/CodeGeneratorInspector.py:
(SmartOutput.close): Remove print statement.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening.

Generating baselines for two input placeholder tests that fail. The image
baselines used are from Chromium Linux that clearly denote what's missing
in the GTK port's output for these two tests, ignoring other marginal
rendering differences.

* platform/gtk/TestExpectations:
* platform/gtk/fast/forms/input-placeholder-paint-order-expected.png: Added.
* platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt: Added.
* platform/gtk/fast/forms/textarea: Added.
* platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
* platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Make WTR use the same color palette as DRT
https://bugs.webkit.org/show_bug.cgi?id=91870

Reviewed by Noam Rosenthal.

Make sure that WebKitTestRunner and DumpRenderTree use the same palette: the
standard from QWindowsStyle.

* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts): Moved code to platformInitialize since setting style is not
exactly font related.
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::InjectedBundle::platformInitialize): Force the usage of the style's
palette.  Because at this point QApplication was already instantiated, the
default palette was already initialized to be the system one, so we need to
explicitly set the palette to be the standard from style. This is not needed in
DRT because there we set the style before instantiating QApplication.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Unreviewed test expectations update.
Un-marking various tests as flaky on WIN following rollback of r121610
in http://trac.webkit.org/changeset/123110. Investigation documented in:
https://bugs.webkit.org/show_bug.cgi?id=90469

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix more -Wunused-private-field violations
https://bugs.webkit.org/show_bug.cgi?id=91876

Reviewed by Adam Barth.

As of http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120716/061102.html
the warning finds more bugs. Fix them.

* html/FTPDirectoryDocument.cpp:
(FTPDirectoryDocumentParser):
(WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
* html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
* html/shadow/MediaControlRootElementChromium.h:
(MediaControlRootElementChromium):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
* inspector/InspectorDOMStorageResource.h:
(InspectorDOMStorageResource):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(Settings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
* rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::RenderSVGTextPath):
* rendering/svg/RenderSVGTextPath.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91847

Reviewed by Adam Barth.

This allows for including the TestIntefaces.h from content shell
without introducing a dependency to WebCore/wtf

* DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
(TestInterfaces::Internal):
(TestInterfaces::Internal::Internal):
(TestInterfaces::Internal::~Internal):
(TestInterfaces::Internal::bindTo):
(TestInterfaces::Internal::resetAll):
(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):
* DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
(TestInterfaces):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Add WebView::zoomToFindInPageRect for Android
https://bugs.webkit.org/show_bug.cgi?id=91801

Reviewed by Tony Chang.

On Android, when you find in page, we scale the viewport to reveal what
you've found (because the screen is small). This function instructs the
WebView to zoom to display a given rect.

* public/WebView.h:
(WebView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animateZoomAroundPoint):
    - This function is a bit more general than necessary for this patch
      because it is also used in other cases for animating a zoom
      around a given point (e.g., double-tap to zoom). These uses will
      be upstreamed in later patches.
(WebKit::WebViewImpl::zoomToFindInPageRect):
* src/WebViewImpl.h:
(WebViewImpl):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123241 268f45cc-cd09-0410-ab3c-d52691b4dbfc