labofsahil/github-event-dataset-2012 huggingface dataset:
This doesn't actually work. When `.puppet` is a file the target_dir will be '/home/me/.puppet/modules' and that file does not exist. So to make this correct you need to do something that looks at each element of the path and raises if any part is a file. At the moment I'm getting: 

```
me@pe-ubuntu-lucid:~$ ls -la
total 28
drwxr-xr-x 3 me   me   4096 2012-06-28 11:47 .
drwxr-xr-x 4 root root 4096 2012-06-28 10:49 ..
-rw-r--r-- 1 me   me    220 2010-04-18 18:51 .bash_logout
-rw-r--r-- 1 me   me   3103 2010-04-18 18:51 .bashrc
drwxr-xr-x 3 me   me   4096 2012-06-28 10:49 .gem
-rw-r--r-- 1 me   me    675 2010-04-18 18:51 .profile
-rw-r--r-- 1 me   me      0 2012-06-28 11:37 .puppet
-rw------- 1 me   me    853 2012-06-28 11:47 .viminfo

me@pe-ubuntu-lucid:~$ puppet module install --trace lab42-foo
Preparing to install into /home/me/.puppet/modules ...
Error: File exists - /home/me/.puppet
/usr/lib/ruby/1.8/fileutils.rb:243
/usr/lib/ruby/1.8/fileutils.rb:243
/usr/lib/ruby/1.8/fileutils.rb:217
/usr/lib/ruby/1.8/fileutils.rb:215
/usr/lib/ruby/1.8/fileutils.rb:215
/usr/lib/ruby/1.8/fileutils.rb:201
/usr/lib/ruby/1.8/fileutils.rb:201
/usr/lib/ruby/1.8/pathname.rb:1028
/usr/local/lib/site_ruby/1.8/puppet/module_tool/applications/installer.rb:98
/usr/local/lib/site_ruby/1.8/puppet/module_tool/applications/installer.rb:48
/usr/local/lib/site_ruby/1.8/puppet/face/module/install.rb:122
/usr/local/lib/site_ruby/1.8/puppet/interface/action.rb+eval[wrapper]:208
/usr/local/lib/site_ruby/1.8/puppet/interface/action.rb+eval[wrapper]:208
/usr/local/lib/site_ruby/1.8/puppet/application/face_base.rb:239
/usr/local/lib/site_ruby/1.8/puppet/application/face_base.rb:239
/usr/local/lib/site_ruby/1.8/puppet/application.rb:350
/usr/local/lib/site_ruby/1.8/puppet/application.rb:342
/usr/local/lib/site_ruby/1.8/puppet/application.rb:436
/usr/local/lib/site_ruby/1.8/puppet/application.rb:342
/usr/local/lib/site_ruby/1.8/puppet/util.rb:529
/usr/local/lib/site_ruby/1.8/puppet/application.rb:342
/usr/local/lib/site_ruby/1.8/puppet/util/command_line.rb:74
/usr/bin/puppet:10
Error: Try 'puppet help module install' for usage
```
What happens if the title is set to an array?
params can be accessed from top level scope too, so I can't pass it to a block. And I was inspired by Sinatra framework.
It seems, that I can remove the first check. I thought somehow it could be useful, but it isn't.
Also the last. I included that, because it caused a weird behavior in Rubinius. It returned a string, which for the encoding says that it is ISO-8859-5, but the output of that string was clearly UTF-8 in my console.
The comment should be replaced with one that explains why we remove gem more verbosely.
we can probably move this to the top of the file.
I was asking about the `bare: true`.

Having the IIFE is a good thing, and I'm not sure we should remove it, even though it was the previous default.

Any downsides to not including `bare: true` ?

// @mklabs @addyosmani
But foo.bar will be stored as foo.rst when the script convert that file, so the previous processed included (from the other file) now is invalid

Foo.bar has xi:include=FoU.baz

doc2rst(Foo.bar) => Foo.rst (with ..include=FoU.baz.rst)

doc2rst(FoU.baz) => FoU.rst (filename mismatch with the ..include)
I think that you can use here `$length - 1` instand of use `rtrim`
On the subject of `git flow init`:

1 . Do I need to run it on my existing repo (I finally managed to get the github develop branch fetched and checked-out) or will the changes it makes come automatically when I pull from upstream/develop?
2. It asks me "Which branch should be used for bringing forth production releases?   - develop   - master" Which should I choose?
Goutte is used in `Finder\Google` so as said it's not Mink dep. here, also for me it's working correctly. (for [travis](http://travis-ci.org/#!/stloyd/KnpBundles/builds/956724) too, failed steps are from last merge with solr changes)
Could you kill these spaces?
You might want to wrap these at 80 chars?
avoid extra empty lines at the end of the files :)
Would prefer it it could be one type enforced by signature, array basically, instad of having to check type. Or is there a reason why several type are allowed?
What do you mean?
pep8 states: You should put a blank line between each group of imports.
Let's add the `getUsername()` to this message too (should make debugging easier).
I would add an `only: [:action1, :action2]` to restrict the unnecessary routes.
@kripken : Because the variables were set independent of one another anyway. So in case more than one is set, the order in the if statement will take effect. Which would be very confusing. I think either we should ensure that only one is true, or we should accept the setting of multiple and handle them independently in the "if". I also made it like this so that I could share the code for WEB and WORKER [here](https://github.com/kripken/emscripten/pull/634/files#L1R83), and the style of coding would fit with what was right above it. It would be weird if the first block (the if-else) assumes only one can be set, and the second block accepts WEB and WORKER. Better if every check is independent then.
Sorry to bother you, please use double quotes ;-)
I'd avoid using "better" - We say something like that: "Most of the times when you write a pattern match on an option value, the same expression can be written more concisely using combinator methods of the `Option` class. For example, the function `getMapValue` can be written as follows:"
i get why this changed.
Do this with an each
再定義可能な演算子もブランチかな？
Any number of channels will do, I just don't know how to do this properly...
Na utilização do método serialized
Yeah, I ended up needing the const_get stuff.  Otherwise it was looking in the current module and not finding it.
Use _ for variables in a python class. So use:

self._name instead of self.name
Two questions here:
1) For assignee, do we want personal names to be displayed as firs last or last, first? last, first is clearer that it is a person, but idk how this works with CSL
2) If the inventor is listed as an assignee, do we filter it out?
Brain fart. Will fix.
Should this live in partials/_mixins ?
I'd go with "not congruent to triangle A."
The "storage/connectors" nested document shows how to configure a connector; multiple connectors can easily be added under "storage/connectors". The `mock-source` is used to configure the source, although the MockConnector class still currently hard-codes this and still contains the constants used by the ModeShapeFederationManagerTest case.
`{include uri='design:dashboard/maintenance.tpl'}` concat is not needed
top два раза не очень красиво. можно в переменную
Yeah, I was looking into that.  I'm a little rusty on rails, so this was an easy way to get it done.
`#!/usr/bin/env python`
This stuff should be refactored into an application_controller method. I'll do that now, actually.
Is there a need to get 2 comments here? It doesn't look like the second one is being used, so wouldn't 1 be enough?
The thinking behind this was to avoid sending all configuration values to an unauthenticated user. Only requesting the available log in strategies would be safer. I'd be fine with changing this though.
The tests should be marked with '@ignore' if there are not passing, with a comment linking to a ticket. Or removed if they are no more relevant.
The spacing change here is unecessary.
Allow for localized names for 'stars'.

The value, that is passed is in the form of '5 stars', '4 stars', …
http://about.travis-ci.org/docs/user/languages/php/

Yes :)
Shouldn't this be set based on config?
Кто-нибудь объяснит почему замены не происходит, но условие, что А != А дает истину???
Посмотрел в документации — действительно лучше. Правда она работает в версиях os x, начиная с lion
Спасибо, что заметили. Я вечно путаю в каких местах нужно считать от нуля, а в каких от единицы.
- Метод -(void)mutate:(int)percent не являеться категорией. Он является приватным методом класса объявленым через интерфейс категории;
- нужно освободить массив indexes после использования.
А так все работает правильно.
Давай удалим этот файл из pull request
Updated : I added explanations on the management of the 3 changelogXX files.
If the user cancels the dialog, is the return value being set to ""?
causing the filter
Again, this was left as is from the slidebox x-tag.  

I'm not sure what the argument/justification is for including the 'data-' prefix to attributes.
CS: alphabetical order for `use` statements.
this is not safe - if ```cr``` is empty this line will fail with ```KeyError```
Can you please [add a space after the "for"](https://github.com/github/objective-c-conventions#control-structures)?
[Whenever possible, omit them](https://github.com/github/objective-c-conventions#blocks).
We never use the Readline History so i removed popping empty lines
Why is this better than the redirect? If I'm not mistaken the ```#create``` action is a POST request, so if the user refreshes the page of this response this will then cause a re-post of the form. That won't happen with the redirect.
Got it, agree :)
you should propose this modification in the gitiwiki project. And see if all tests passes.
@arrbee Should `GIT_DIFF_LINE_[ADD|DEL]_EOFNL` also be taken into account, similarly to [diff_helpers.c](https://github.com/libgit2/libgit2/blob/new-error-handling/tests-clar/diff/diff_helpers.c#L64-96)?
I see, always wondered about it and thought it could be a good target of a unification / simplification camaign ;-) But makes sense then.
I did it in master but it should have been called test_transforms.py for consistency.
This is great! So clean.
@stof Thanks for you help with this, I have changed the errors you have pointed out. I can't link to the HttpKernel documentation yet though as it still needs writing.
How about:

> Now, try the code in action.
Please indent 4 spaces inside a block, like you do in PHP.
You should also mention that `relative` is supported to.
需要
应

创建此类日志文件
创建文件
The class used should probably be configurable
shouldn't this be `ensure_loaded` instead?
Moved this from the dev server module because it should be up to the main application to stop execution, not a module.
Please add such statements in all remaining workflows __init__ packages.
That is a neat idea! Actually, I found it works in everything except - you guessed it - IE9! It executes the prefix code, but then rendering is broken. I'm guessing it does not recognise the DOCTYPE tag unless it is first. But not a problem with AppJS of course.

However, this is such a good idea it's tempting to take it further? I'd certainly want to make ```useJavaSaver``` preemptable - currently AppJS (and Safari) is broken on the Mac - it renders the Java object as an unsightly error message when the TW is loaded via drag-and-drop (i.e. on a 'file:' url). I'd like to be able to set ```useJavaSaver``` unconditionally false in AppJS. It would also be good to have a preemptable hook function executed at the top of the ```//--Main``` section that could be used to tweak ```config```.

EUREKA! I've just realised that we could make ```getLocalPath```, ```saveFile``` and ```loadFile``` preemptable in this way. Then we would not require an AppJS plugin at all and it would work with an out-of-the-box TW! This would be fantastic because at the moment a user with no working save method has no way to install the plugin (except knife-and-fork editing). Would you support this, or is it going too far?
should send an email
The min engine file includes SimpleAudioEngine file. So, plea remove this line.
The constructor handles this.
Changed these fields to be nullable.
yeah it's all confusing... but I understand... ok
I have some time this evening, then i will put in some code based on your feedback and update the request
Some high level comments about cache wouldn't go amiss here.
Again, the original was better.
Is there any point in checking for the _as_mpl_transform attribute?  If it is not None, and it is not a Transform, and it can't be made into one, shouldn't it just raise an exception?  Or is the idea that something not inheriting from Transform can still function as if it did?
s/_alrarm_name/_alarm_name
The "destination" should actually be managed  by the bridge I think.
The domain-type should not be required in this method.
no need mix ```dump .=``` and dots at the start of the lines, just start each line with a dot, it'll look neater :)
I've made some changes to this which change this now.
__MSG__OTHER_DOCUMENT__
Needs `_t()`. Please go through all templates and PHP changes and look for those.
What means "Stg"?
Alex, this is a bigger change than you might like, but did you consider adding the WT_CACHE_POOL_ENTRY fields to the WT_CACHE structure, and only having a single structure?   Both are "cache structures per connection", and I don't see the value in having both of them.

Obviously, you've thought about this a lot more deeply than I have,  but it seems like a simplification: the balance code operates on both which makes me think it's really one chunk of information, there would only be one per-connection cache structure, not two, and the btree/bt_cache.c code goes away and all the cache code is in one place.
Are you sure ``$validator->isValid(array('value', 2, 'a'))`` has the correct type as "Boolean" is not a sub-type of "Boolean"?
This is documented in the README as "add an index to a node".  What does that mean?  I can't find any corresponding entry in the Neo4j REST API.
This should be ``2012`` :)
Yes, it should be there.  The per-user token will still be required from the user.
I'm a little hesitant to have these methods in the factory class itself.  What happens when we add additional plugins?  Is there a way to either move them elsewhere or, potentially, mix them in?
I think we've adopted using #pragma once, at least I have ;)
Why are you adding this method when it isn't used?
Could this URL be relative?
spaces around =; what does the comment mean?
Either a separate CL or this one is fine.
Let's actually put quotes around the part that is supposed to be in quotes (line 24). Other than that, the docs look good.
Hardcoded URL? Please build it pragmatically. (You can for example add comment to newest displayed post.)
This is needed to avoid creating markers that do not fit in shown area.
You found this somewhere? Then you could add attribution in the comment above.
Yes i was. Fixed.
One empty line more here, please.
No, not good. See how other subjects in Django are made. Especially see this setting:

https://docs.djangoproject.com/en/dev/ref/settings/#email-subject-prefix
Probably it should be keyup, because otherwise there is one character of delay.
I do not follow. We have multiple ready events. If openhours event is triggered before map is rendered there is a problem. How do you intend to prevent this? Can you delay some ready events but not others? I know how to catch on Map ready event:

```
google.maps.event.addListenerOnce(map, 'idle', function () ...
```
Can I use this and call panels depending on map from there?
full models.py
import mongoengine

class Weather(mongoengine.Document):
    created = mongoengine.DateTimeField
    latitude = mongoengine.DecimalField
    longitude = mongoengine.DecimalField
    model_name = mongoengine.StringField
    meta = {
        'allow_inheritance': True
    }

class Precipitation(Weather):
    dateFrom = mongoengine.DateTimeField(required=True)
    dateTo = mongoengine.DateTimeField(required=True)
    precipitation = mongoengine.DecimalField
    symbol = mongoengine.IntField(min_value=1, max_value=23)

class State(Weather):
    #at = mongoengine.DateTimeField(required=True)
    temperature = mongoengine.DecimalField
    windDirection = mongoengine.StringField
    windAngle = mongoengine.DecimalField
    windSpeed = mongoengine.DecimalField
    humidity = mongoengine.DecimalField
    pressure = mongoengine.DecimalField
    cloudiness = mongoengine.DecimalField
    fog = mongoengine.DecimalField
    lowClouds = mongoengine.DecimalField
    mediumClouds = mongoengine.DecimalField
    highClouds = mongoengine.DecimalField
    precipitation = mongoengine.DecimalField
I'm not sure either. The main reason why I've done it this way is that I currently use ex falso as my main tagging tool. :-) Is the "<program>::<tagname>" style used by other programs, too?
I would also be ok with including the prefixes, and let the application using Taglib decide how to handle them.
Indeed for default modules of PHP rather strange to add it. 
But for example we're whitelisting modules instead blacklisting. Probely there will be more out there. 
Is not a idea to put it by the notes which php modules are used. So you can easily check your server configuration against the requirements?
maybe an aura script with AURA_SCRIPT_HOOK_EFFECT_CALC_SPELLMOD is better

maybe i post my version, tomorrow
I see you worked on strings, but you could cut down on the number of required strings if you made them "Godmode: %s" and 2 strings "Enabled" and "Disabled"
Yes overkill for the book

On 21 October 2012 18:46, Pawel Kozlowski <notifications@github.com> wrote:

> In src/common/services/exceptionHandler.js:
>
> > @@ -0,0 +1,12 @@
> > +angular.module('services.exceptionHandler', ['services.notifications', 'services.localizedMessages']);
> > +angular.module('services.exceptionHandler').factory('$exceptionHandler', ['$injector', 'localizedMessages', function ($injector, localizedMessages) {
>
> Regarding what to show: $exceptionHandler deals with really fatal
> exceptions so there is not much we can say, apart from 'Sorry, sth went
> terrible wrong, we are working on this' or sth along those lines. Basically
> it is not recoverable. Also we should not be showing any raw exceptions /
> messages from an exception (as it might "disclose" technical details).
>
> As for logging - yes, let's add this. It will be opportunity to show usage
> of decorate + $delegate. Cool! As for pluggable strategy for the actual
> error handling - why not in general but might be an overkill for the book.
> Don't know...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/angular-app/angular-app/pull/72/files#r1898928>.
>
>
This is becasue in community the user don't confuse with original plugin in my fixes that way i will removed
This should be `if not proceed`, as should all of the corresponding lines in the other methods.
Is there any danger in updating the max/min if it's outside the viewport but still within the extended bounds?
sounds much more complicated.

The usage in 80% of the case will be to just use httpd=True
in 19% of the cases you may want another port
in 1% of the case another host
I know we've generally not added docstrings to our code (might be worth a discussion) but this feels like a case where they could be helpful particularly because you're doing something clever with restmail.net which is new for us.
Also, a .jsm will generally export only one symbol which will act as a namespace. Perhaps `Promise`?
this happens so often, you should have a dumper function that handles the json.dumps in a try: except then returns the encoded response or a 500 error...you should also log stuff on an error.
Don't indent namespace contents.
Done: ad8a5eb.
After thinking about it some more, I'm not sure what's the correct thing here anymore. After calling 

    QSObject *myNewObject = [[QSObject alloc] initWithArray:myArray];

you should have `myNewObject` with retain count 1, which you need to release yourself (because it's an `init...` method, it should not return an autoreleased object). 

Inside the `initWithArray:` method, an autoreleased object is created with the line:

    QSObject *existingObject = [QSObject objectWithIdentifier:thisIdentifier];

(because that is using a convenience method, not starting with `init...`)

Now you want to autorelease `existingObject` object again, decreasing the retaincount once more?
I think you might actually need to retain `existingObject` at that point, taking ownership of that object.

But by now I'm confused, so I'm not sure about anything anymore. Maybe I'm just confused.
Also, it doesn't matter that they're single lines, but please make it:

```python
try:
    localfh = open('./catalog.rdf.bz2')
except:
    return False
```

If you decide to keep that.
"coversting" or "converting"?
Missing newline before comment according to [our coding standards](https://github.com/xp-framework/xp-framework/wiki/codingstandards#wiki-comments): *"The line above a comment has to be an empty line.*"
Ok . I initially had that, but thought that the concrete classes may implement that method. Will override.
Or we could leave them as ```atmospheric.psf``` and so on for now, only changing later once we have another model atmosphere?
I looked at that briefly, but didn't get around to trying to use it.  Rather than the easy_install (adding another dependency), we could use optparse for <= 2.6 and argparse for >= 2.7.  I think they have basically the same functionality.  In fact, if optparse does everything we need, we could just use that. Even though it is officially deprecated, it is still present in 2.7.
I would agree with you Mike, except that `import numpy as np` is *so* ubiquitous a re-labeling (i.e. suggested and used in many textbooks / references for scientific use of python) that I don't think keeping `numpy` has the effect you desire here.
`RadialProfile` is now gone and `_parse_sizes` is a bare function.
ditto apostrophe comment
如果请求失败，用`*`而不是版本为空。
Notice that you deleted the only real use of firstTime, which was to control insertion of horizontal rules.  So, at this point, you might as well eliminate the variable entirely including this conditional setting of it.
Good to note that we prefer symbols over strings for keys in attributes
This is fine, but the preferred way is to pass these in as instance variables, so the logic of accessing the node stays in the recipe. For example

    template "#{node[:bluepill][:conf_dir]}/nexus.pill" do
      source "nexus.pill.erb"
      mode 0644
      variables(:pid_dir => node[:bluepill][:pid_dir], :bin_dir => node[:nexus][:bin_dir])
    end

And then use \@pid_dir in the template.
unused import TestCase
I was actually going to bring this up - I only kept config.rb around and moved that block in there since conditional logic was already present in the file. Given the related comments I'm not sure we have any reason to keep that file around at all.
possibly needed for some initialization reason but if so looks like a hack -- remove it.
keep an eye out for any group-size oddities just in case, and we can fix it properly (and comment it)
Why are you using enumerate here?
the field doesn't seem to be used anywhere
Why two `.row-fluid`?
Oops, Sorry!
This isn't really relevant because the browserid part is all managed by bidpom.

We can remove this bit and then just use `home_page.login()`
Make sure that my settings doesn't get uploaded
Verdade testei o método dic.get e não gera um exceção com um chave inexistente, criei esse método com a intenção de evitar exceções e termos um valor padrão, mas a linguagem já oferece.
Ops. My mistake again. Consider them removed.
What is this? You changed API?

I am not sure we want to allow this officially! We have unofficial `_time_offset` for tests and dummy data.
you're going to have to back out the `README` changes before I can merge: perhaps put your `README` text in `finagle-protobuf/README.md` instead?
Sure that can be done later.

My main plan was to add asserts in case we are not in release mode, so that we can detect badly behaving client code. That said, your comments don't seem to make any connection to isalpha etc., thus this magically makes our client code behave not that bad anymore, since by the description it is pretty clear on what is to be expected and what not ;-).
Just to make sure I was parsing this right: The "That would be good." refers to the idea of putting the isFOO functions into namespace Common, right?

And ye, Doxygen comments (perhaps based on the man pages) would be good. Shouldn't be a problem.
Where is the xml_string actually getting used?
This listener is not used, you should delete it
alias de escape_javascript : j
So, for this pull request, OK to leave the TODO line as is?
Might want to change it to something like 'I enter "foo" into input field with id "bar"' for consistency.
Так ты генерируешь строки только в нижнем регистре! Так нечестно - toLowerCase() ничего не делает.
Скобка на предыдущей строке
Названия класса и файла должны быть одинаковыми.
Configure your IDE to not do wildcard imports. These are dangerous if we switch to a newer version for any library. For example import java.util.* and java.awt.* both have a class named List.
I still don't feel great about the forTab/getRemoteWebPages discord, but I'll live.
We should use triple double quotes(" " ") when writing doctring. http://www.python.org/dev/peps/pep-0257/#one-line-docstrings
really you should have a class that describes the app object. you shouldn't repeat all of the keys
This test and the two following can actually be run on big images, since they only attempt to open a small fixed-size piece of the images.
the `+ center_r` and `+ center_c` are now removed since, we use a function to check if the pixel is in the mask and no more an extented mask (emask)
Done in ndawe#5
By 'no weights', I suspect that you mean 'equal weights'.
cv_scores here too
In this case this is called 26 times. I think it's better to keep it factorized this way.
I now use ``out`` consistently  - thx!
внесені правки теж відкоти
I didn't change that behavior.
While I also found this to be confusing at the start, the reason behind this is, that at some point, only the header part of the payload is to be retrieved.

This flag indicates if only the headers are to be returned or the whole request.
This flag does not indicate if there is a body or not.
On Sun, Mar 18, 2012 at 08:03:21PM -0700, Walter Bright wrote:
> This is meant to discover HTML comments. That isn't discoverable using escapes.

My gut is saying giving html syntax special treatment is
wrong because D code and comments are not HTML.

For example, consider I have a html builder library, and one
of the functions is addComment and I document it like this:

/**

    Creates a comment for an HTML document in the form of
    $(OUTPUT <!-- commentText -->).
*/
string addComment(string commentText);



I don't want that <!-- commentText --> to be invisible
in the generated docs. It should come out as
&lt;!-- commentText --&gt;, regardless of where I
write it. Whether it is in a comment or a code
sample, it should be encoded the same way.
I deleted the systemd files because my pull request with puppetlabs has
been aproved and they are in the tarball provided by puppetlabs.
If you look at the PKGBUILD they are there.

Oh, indentation, sorry eclipse of course....... :)

2012/10/3 Greg Sutcliffe <notifications@github.com>

> In puppet3/puppetagent.service:
>
> > @@ -1,13 +0,0 @@
>
> Why are you deleting the systemd files?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/GregSutcliffe/aur-projects/pull/1/files#r1755283>.
>
>
I wanted to but there are general places that use "emulator" so I can't. It's unlikely that BB will have both an emulator and a simulator so I don't see this being a problem.
the intention of this class was to fix an issue with framework. Framework crashed while parsing Date type . e. g. 
var d = new Date(...);
as was discussed in the  TIMOB-9390 task, we are waiting for 9398 to for fixing this issue, and i will clean up this code.
please add a wait to every method that needs a wait depending on something that has to happen and not waiting for the same amount of time always.
Off the top of my head, I think it would feel best if anything someone could attend (be it online or in-person) were in there. So basically we should cut out the `posts` from the `resources` and `trainers` pages, but have everything else be in the feed. Does that make sense?
This looks weird. Seems to be assuming ```flags``` already exists (by appending the OR).

Also, wouldn't this overwrite the default getFlags with whatever default argument it has?
everything below this line should wait until remove is inside transactions.
This function should be called by getOperatorText() for the values that aren't special cased.
this is wrong. It is not a hard dependency. You don't need DBAL at all when using the library for MongoDB
After reading it, I've still idea what Joanna's code. AFAIK `MIDDLEWARE_FILTERS` doesn't exist in the core settings, and I've no idea what `filter_init()` is about.

Are these middleware filters a MicroTardis thing? Because the core filters are handled by:

```python
# Ensure filters are loaded
try:
    from tardis.tardis_portal.filters import FilterInitMiddleware
    FilterInitMiddleware()
except Exception:
    pass
```
same comment here, this may cause collisions between this module and other modules.
So something like: 

```
ensure_resource('package', 'python-pip', {'ensure' => 'latest'})
```

would be acceptable?
same here,  should be `==`
$tableName = $this->getTableName()
You're right that this isn't too scalable... is there anything else we can do? Maybe check if it contains the string '/wiki/'? Is this something common to all wikimedia projects? All the projects on http://wikimediafoundation.org/wiki/Our_projects seem to follow this convention, but this might be something to ask about on IRC.
yes it's used in tests.
其实，自己意会的。profiler像是测速之类的装置，所以就。。。

在其他领域有把他叫做“剖析器”，我问过一些人的意见lisp-cn，也有人选择把他翻译成 “剖析器"。
is this verifying the date is sorted in reverse order? would you please rename the method to be more descriptive?
@shacker thanks ;)
@christianv Done. Updated PR.
@christianv That change is not mine.
Msf::Encoder::Type::AlphanumMixed while badchars are "\x00"?..... uh, ok.
I don't like the idea of be confident about external URL's / java applets. Ideally create a fake/dummy applet and use it from the metasploit module. Is there any reason to not do it?
I'll make sure to fix that before pushing in.
I think wchen-r7 meant "'vars_post' instead of **'data'**"
Maybe not.  If they don't, just ignore my comment.  Pun intended.
I think so. 

When morphing to 2D, what would be the bounding sphere for 2D is the same as Columbus view except for the z component. But when going from the perspective to orthographic projection, the camera is looking down the z axis and moving away from the center.

When morphing from 2D, it switches abruptly to Columbus view but looking down the z axis before doing any morphing.
Looks like this is to make the logic in `PositionVertices.prototype.update` happy.  Let's remove the `positions` argument from that function, and instead make `_createMeshes` return undefined if there are no positions or extents.
Let's not make this optional.  For example, down the road materials may need the context because they compile the shader, which is then linked with the primitive's shader.
Well, returning a specific type of object helps a bit with documentation, and Matt is right that if you're always returning the same set of properties, a named constructor will probably be slightly faster to construct and use.  On the other hand, doing two levels of property lookup: `textureCoordinate.bottomLeft.x` instead of one: `textureCoordinate.x0` probably negates any gain.

Maybe we could be all satisfied by just returning a more general Rectangle instead.  BillboardCollection manually computes width and height anyway when it goes to use these values.
Well, it looks like twitter button is not flexible enough for our project:( Maybe we could try other JavaScript GUI libraries in future, like YUI
While you're at it, add detab and tolf too.
return ErrorHandler.createDefault.... here
loginImage doesn't appear to be used.
since 2.2.0 not 2.1.1 and add since for mobileWeb. Ask Bryan
updateRoute is only called once when the mapView is created. Perhaps the name is misleading, but this is a small memory optimization.
For an immediate customer need this may work, but if this is eventually going to be cross-platform, we can't send Android key codes back to the app--we'd need to provide some kind of Titanium class to map keycodes.

I think if we need to include this for this release, we should make a note that this API is experimental and subject to change. Or words to that effect.
We've been using "// " for copyrights in Dart files. See the others. Sorry for being pedantic!
use `import org.scribe.builder.*` etc
should be named "data-translation-id"
What about `-z "$shortenedUrl"`?
And could you explain in what cases could this be empty?
I originally wanted to have Tic Toc as a separate library.

The reason for attaching it to window is for easier calling syntax. Since calls to tic() and toc() wouldn't be in production code (as you wouldn't put console.log in production code), the global functions only exist locally for profiling purposes.

In regards to the Utils library. I think it's a great idea, especially since I've been thinking about AMD support for different data structures and groups of functionality. My only hesitation is that if you look at Underscore and Jquery, they're single scripts. Do you know of a way to retain the same ease of referencing a single script? Perhaps we could do some precompile step to combine and minify the scripts.
OK...that works for me...will run a quick test and, if it passes, merge these changes.  Thx for being patient with me on understanding the details in this pull request ;)
Sweet. Looks great and should be merged. Thanks, Horia!
Good point. It was probably just how the condition came out in my head that made the double negation more natural, but it would be nicer without it.
Also, why migrating the name outside of `Impl`?
Worth noting that array copy syntax could be used here, though:

    chunk[0 .. T.sizeof] = typeid(T).init()[];

As far as I know, `typeid(T).init()` can never return `null`.
Instead use `assertThrown(singleSpec("%2.3eTest"));`.
Put everything in the same line please.
It is just how the data is posted to it.
That should really be done with CSS
Agreed, took me a little while to figure that $success is passed in by reference, but I think you're spot on there.
Bobo reglé... :poop: is now :cupid:
Next two lines are kind of ugly, but I couldn't figure out a better way to express: "By default, use 443 or 80 as port for nginx depending on https set to true or false. But if the port was set to something else as normal or override attribute, then use the port that was set there."
Plain string interpolation in the attributes file didn't work for me, as https flag always seemed to be false, even it was set to true es override.
This code will not do what you may expect.
The _ReturnCode is still bound.  So the line on 177 will throw if the code does not match.  You really should be checking the actual return vs. the expected return,  Then you can chose to throw (not my preference) or return something that can be inspected.
`abstract = False` is default for models inheriting from a `abstract = True` class. So we can omit this line.
I was trying to get the "use the macro" part out of the way (I'm bleary-eyed from that) first, then think about whether the definition of that macro is precisely what we want.  Once the macro is used instead of doing the idiom separately in each file, it's really easy to change exactly what the namespace nesting is.

But also, I'm not sure why it isn't ok as it is, at least for now.  We don't have a good reason to introduce a "version number" level of namespace at this time.  So it's always "OSL::", with an optional app-specific wrapper.  Is that ok?
this could be simplified with ``Doctrine\Common\Annotations\AnnotationRegistry::registerLoader(array($loader, 'loadClass'));`` as Composer already returns the boolean. And btw, it will also handle the annotations of the bundle (as Composer also autoloads the bundle) so the next piece of code can be dropped too
I prefer we do this for the entire CSS file so we con't have to revisit it again.
Lines 1897-1905 are the same as 1877-1885 - can we put these in separate functions?
"Thrown on POSIX systems when a SIGSEGV signal is received."
It's one thing to have a breaking change that impacts some people that use {url} compared to changing a constructor - a much bigger breaking change IMHO.

I suppose we could leave the old constructor and just have it create a LiteralExpression from the String.

wdyt?
if-else convention
Is there a way to query the release number or flavor (oneiric, precise, etc)? We  could use that.
This was taking a vector of the form `[:selector-literal sel]`, which is why it was written that way, but I think this change is a good idea (I was on the fence when I wrote it). However, `objc :message-expr` will need to be updated to match.
Another possible test: ``!(extension_loaded('intl') && null === new IntlDateFormatter())``, by relying on the bug itself.
@fabpot What do you think ?
and then I forgot to change it during the merge...
Actually--the second \S in the SETTING_REGEX makes perfect sense.  But the first \S in the SETTING_REGEX and the one in the SECTION_REGEX I would still be interested in considering a less permissive approach.
Нужно показать, что подключение `jQuery` явно не подключит `jQuery` два раза.
I'm not even sure how to parse these - is this an old-school hash syntax? Or a block?
add fail case to presenter.apply
This is not necessary in this case. In the case of embedded documents we have to fake primary keys, so some ugly stuff has to be done in `to_class`. Here this is not necessary.
Looks good.  Noticed there's also one other place this occurs.
Ideally submit as a separate pull req (with test if you're feeling supersuperkeen!)
Otherwise I'll make the fix direct to master sometime over the weekend.
Hmmm, fail() would be better here IMHO. And not setting $pkglist in this case would provoke a hard error and would be safer.
This sentence sounds great, but is quite vague in what it means. Could we come up with an example. Two objects, each using different groups and one object reference the other. Something demonstrating the problem and how it can be solved with @ConvertGroup.
Here's where the failed object was getting attached.
Убрать composer.lock
valueError or typeError noted
Here, I changed things so that setting the `curSyncSlice` and related bits happens *after* `_startSync`. I'm not sure this is sensible, though it should always work as long as the callback in `syncDateRange` doesn't happen immediately. It just seems weird to have so many nested layers of callbacks... maybe something completely different would be better here?
The better fix for this is to move the assert calls into the exec block. I had to do the same thing in the Python3 fork.
There must always be a user agent. Not having one is considered a Very Bad Thing (tm) in the browser world.
I don't think we do in any of our code.  Looks safe to remove.
Open up a new INT JIRA; let's just go with this for now and we can migrate the samples to the new class when it's in a release.
<img src='http://rghost.ru/private/42511872/97ba3c40e208d671bccce2c38663b0bf/image.png' />
Just a thought but how do you feel about integrating this with jake deploy-tests?
since you can check whether the agent is there or not might as well integrate it with jake deploy-tests.
Yup, we talked about it. We could put an enum in utils.
instead of depending on the query services for this count get it from entity manager.  Do now worry about filtering out the count base on permissions.
Maybe nicer variable names
The `true` and `false` should not be there. This returns `false` every time because it is the last expression in the function body.