Refactor picker tests to fix flakiness and share code
https://bugs.webkit.org/show_bug.cgi?id=99671

Reviewed by Kent Tamura.

Source/WebCore:

Disable transitions until the picker is fully ready. This should fix flakiness.

No new tests.

* Resources/pagepopups/calendarPicker.css:
(.preparing .unavailable): Disable transitions.
(.preparing .available): Disable transitions.
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker): Set "preparing" class.
(CalendarPicker.prototype._handleWindowResize): Remove the "preparing" class when the window finishes resizing.

LayoutTests:

Refactored so picker tests share code and structure.

* fast/forms/resources/picker-common.js: Shared by all picker tests. Requires js-test-pre.js. Sets up an asynchronous test.
(openPicker): Opens the picker for the given input and calls the callback when the picker did open.
(popupOpenCallbackWrapper):
(sendKey):
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium/TestExpectations: Marked all tests as not flaky. Marked all pixel tests as need rebaseline.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step.html:
* platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt:
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html:
* platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.txt:
* platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html:
* platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.txt:
* platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html:
* platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.txt:
* platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html:
* platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.txt:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.txt:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.txt:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance.html:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute.html:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute-expected.txt:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html:
* platform/chromium/fast/forms/suggestion-picker/resources/suggestion-picker-common.js: Moved to resource directory like all other js files.
(valueForEntry):
(highlightedEntry):
(entryValues):
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.txt:
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.txt:
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl.html:
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.txt:
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html:
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance.html:
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-key-operations.html:
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute.html:
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html:
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] introduce a public API for the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=99904

Reviewed by Adam Barth.

The API decouples the public API from the underlying implementation, so
embedders can depend on it. I'm also changing DRT to consume the
TestRunner API through the public API, except for DRTTestRunner and all
places that require Task.h. These two will be migrated in later changes.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/DRTDevToolsClient.h:
* DumpRenderTree/chromium/MockSpellCheck.cpp:
(MockSpellCheck::fillSuggestionList):
* DumpRenderTree/chromium/MockSpellCheck.h:
(MockSpellCheck):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
* DumpRenderTree/chromium/MockWebSpeechInputController.h:
* DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
* DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
(WebKit):
(WebTestRunner):
(WebAccessibilityController):
* DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
(WebKit):
(WebTestRunner):
(WebEventSender):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
(WebKit):
(WebTestRunner):
(WebTestDelegate):
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h.
(WebKit):
(WebTestRunner):
(WebTestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::makeMenuItemStringsFor):
* DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
(TestDelegate):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
(WebTestRunner):
(WebTestRunner::WebAccessibilityController::WebAccessibilityController):
(WebTestRunner::WebAccessibilityController::setFocusedElement):
(WebTestRunner::WebAccessibilityController::notificationReceived):
(WebTestRunner::WebAccessibilityController::shouldLogAccessibilityEvents):
* DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
(WebTestRunner):
(WebTestRunner::WebEventSender::WebEventSender):
(WebTestRunner::WebEventSender::doDragDrop):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Added.
(WebTestRunner):
(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::testInterfaces):
(WebTestRunner::WebTestInterfaces::Internal::accessibilityController):
(WebTestRunner::WebTestInterfaces::Internal::eventSender):
(WebTestRunner::WebTestInterfaces::Internal::Internal):
(WebTestRunner::WebTestInterfaces::Internal::~Internal):
(WebTestRunner::WebTestInterfaces::Internal::setDelegate):
(WebTestRunner::WebTestInterfaces::Internal::clearContextMenuData):
(WebTestRunner::WebTestInterfaces::Internal::clearEditCommand):
(WebTestRunner::WebTestInterfaces::Internal::fillSpellingSuggestionList):
(WebTestRunner::WebTestInterfaces::Internal::setEditCommand):
(WebTestRunner::WebTestInterfaces::Internal::lastContextMenuData):
(WebTestRunner::WebTestInterfaces::Internal::setGamepadData):
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::setWebView):
(WebTestRunner::WebTestInterfaces::setDelegate):
(WebTestRunner::WebTestInterfaces::bindTo):
(WebTestRunner::WebTestInterfaces::resetAll):
(WebTestRunner::WebTestInterfaces::accessibilityController):
(WebTestRunner::WebTestInterfaces::eventSender):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::eventSender):
(TestShell::accessibilityController):
(TestShell):
* DumpRenderTree/chromium/WebUserMediaClientMock.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::finishLastTextCheck):
(WebViewHost::fillSpellingSuggestionList):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, suppressing failure until I can figure out what's going on.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Page popup: Fix crash by events after closing
https://bugs.webkit.org/show_bug.cgi?id=99951

Reviewed by Hajime Morita.

Source/WebCore:

WebCore should provide a way to uninstall a DOMWindowPagePopup supplement.

No new tests. The bug is timing-dependent.

* page/DOMWindowPagePopup.cpp:
(WebCore::DOMWindowPagePopup::uninstall):
Added. Calls Supplementable::removeSupplement.
* page/DOMWindowPagePopup.h:
(DOMWindowPagePopup): Declare uninstall.
* platform/Supplementable.h:
(WebCore::Supplementable::removeSupplement): Added.

Source/WebKit/chromium:

- We should not handle events after closePopup call.
- We should uninstall a DOMWindowPagePopup supplement in closePopup.

* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::WebPagePopupImpl):
Initialize m_closing.
(WebKit::WebPagePopupImpl::handleGestureEvent):
Don't handle events if m_closing.
(WebKit::WebPagePopupImpl::handleInputEvent): Ditto.
(WebKit::WebPagePopupImpl::handleKeyEvent): Ditto.
(WebKit::WebPagePopupImpl::closePopup):
- Uninstall a DOMWindowPagePopup supplement.
- Set m_closing.
* src/WebPagePopupImpl.h:
(WebPagePopupImpl): Declare m_closing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] QNX build fails when building against Qt without clipboard support
https://bugs.webkit.org/show_bug.cgi?id=98040

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-10-21
Reviewed by Simon Hausmann.

Gracefully handle QT_NO_CLIPBOARD and do not try to access qApp->clipboard()
in such cases. Instead, return false to indicate global selection is unsupported.

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::supportsGlobalSelection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] V8EnablePerContext shouldn't require document() accessor to the native object.
https://bugs.webkit.org/show_bug.cgi?id=99954

Reviewed by Kentaro Hara.

It now refers ScriptExecutionContext of the creation context instead of document() of
wrapped object.

No new tests. No behavior change at this time.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[TestResultServer] Move the resource loading into a dedicated class
https://bugs.webkit.org/show_bug.cgi?id=99246

Reviewed by Ojan Vafai.

A new 'loader' namespace is created, containing the request method (previously located in dashboard_base.js)
and the new Loader object, which handles the loading of all the necessary data the dashboard might require.

* TestResultServer/static-dashboards/aggregate_results.html: Include the loader.js source file.
* TestResultServer/static-dashboards/builders.js:
(requestBuilderList): Use the request method located in the loader namespace instead of the removed doXHR method.
(onBuilderListLoad): Now parses the response text of the passed-in XHR. When all the builder lists are loaded the
resource loader object is notified appropriately.
(onErrorLoadingBuilderList): The partial function that calls this function also adds an XHR parameter.
* TestResultServer/static-dashboards/dashboard_base.js: Much of the resource loading-related code is moved to loader.js.
The Loader object is now used to load all the required resources.
(parseParameters): Don't push the 'builder' parameter into the current state if the unit tests are being run.
(resourceLoadingComplete): This method gets called when all the resources are loaded and the dashboard should
proceed with generating the page.
(handleLocationChange):
* TestResultServer/static-dashboards/flakiness_dashboard.html: Include the loader.js source file.
* TestResultServer/static-dashboards/flakiness_dashboard.js: The request method has been relocated to the loader namespace.
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: The affected test cases are modified appropriately.
(test):
* TestResultServer/static-dashboards/loader.js: Added.
(.): A new namespace is introduced, publicly exporting the request method that performs an XHR operation and a Loader object
which oversees resource loading. The loading is done in steps, first loading the builders list, after that the results files
the current dashboard needs, and lastly the TestExpectations files if they are required by the dashboard. When done the loader
calls the resourceLoadingComplete method located in dashboard_base.js. This signals the dashboard all resources are available
and it can proceed with generating the dashboard page.
* TestResultServer/static-dashboards/loader_unittests.js: Added. Contains unit tests for the Loader object, covering the
incremental loading and the loading of results files and TestExpectations files. The builders list loading is currently not
tested as the unit tests page overrides related methods that possibly affect other tests' behavior.
* TestResultServer/static-dashboards/run-unittests.html: Now includes the loader.js and loader_unittests.js source file.
Refactors the code a bit due to changes in how onBuilderListLoad behaves.
* TestResultServer/static-dashboards/timeline_explorer.html: Now includes the loader.js source file.
* TestResultServer/static-dashboards/treemap.html: Ditto. Also refactors the code to take into account
that all the test files are now loaded before generating the dashboard page.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, a follow-up to r132034 where I forgot to address
Ojan's review comment about the race condition in handleLocationChange.

* TestResultServer/static-dashboards/dashboard_base.js:
(handleLocationChange):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed Chromium rebaselines.

* platform/chromium/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening.

Adding flaky crashing expectations for fast/dom/gc-acid3.html
and http/tests/misc/acid3.html.
Removing timeout expectations for tests that were fixed in r131942.
Reclassifying svg/animations/animate-css-xml-attributeType.html
as a non-flaky failure.

* platform/gtk/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed follow up to update test result after r132033.

* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::installPerContextProperties):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Rebaseline pixel expectations after r131941 and r131991, part 1.

* platform/efl/fast/repaint/4774354-expected.png:
* platform/efl/fast/repaint/4776765-expected.png:
* platform/efl/fast/repaint/absolute-position-changed-expected.png:
* platform/efl/fast/repaint/add-table-overpaint-expected.png: Removed.
* platform/efl/fast/repaint/background-generated-expected.png:
* platform/efl/fast/repaint/background-misaligned-expected.png:
* platform/efl/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/efl/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/efl/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/efl/fast/repaint/block-no-inflow-children-expected.png:
* platform/efl/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
* platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.png:
* platform/efl/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
* platform/efl/fast/repaint/block-selection-gap-stale-cache-expected.png:
* platform/efl/fast/repaint/border-fit-lines-expected.png:
* platform/efl/fast/repaint/border-radius-repaint-expected.png:
* platform/efl/fast/repaint/border-repaint-glitch-expected.png:
* platform/efl/fast/repaint/box-shadow-dynamic-expected.png:
* platform/efl/fast/repaint/box-shadow-inset-repaint-expected.png:
* platform/efl/fast/repaint/bugzilla-3509-expected.png:
* platform/efl/fast/repaint/bugzilla-5699-expected.png:
* platform/efl/fast/repaint/bugzilla-6278-expected.png:
* platform/efl/fast/repaint/bugzilla-6388-expected.png:
* platform/efl/fast/repaint/bugzilla-6473-expected.png:
* platform/efl/fast/repaint/bugzilla-7235-expected.png:
* platform/efl/fast/repaint/button-spurious-layout-hint-expected.png:
* platform/efl/fast/repaint/canvas-putImageData-expected.png:
* platform/efl/fast/repaint/caret-outside-block-expected.png:
* platform/efl/fast/repaint/change-transform-expected.png:
* platform/efl/fast/repaint/clip-with-layout-delta-expected.png:
* platform/efl/fast/repaint/clipped-relative-expected.png:
* platform/efl/fast/repaint/containing-block-position-change-expected.png:
* platform/efl/fast/repaint/content-into-overflow-expected.png:
* platform/efl/fast/repaint/continuation-after-outline-expected.png:
* platform/efl/fast/repaint/control-clip-expected.png:
* platform/efl/fast/repaint/create-layer-repaint-expected.png:
* platform/efl/fast/repaint/delete-into-nested-block-expected.png:
* platform/efl/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
* platform/efl/fast/repaint/erase-overflow-expected.png:
* platform/efl/fast/repaint/fixed-after-scroll-expected.png:
* platform/efl/fast/repaint/fixed-and-absolute-position-scrolled-expected.png:
* platform/efl/fast/repaint/fixed-child-move-after-scroll-expected.png:
* platform/efl/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
* platform/efl/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
* platform/efl/fast/repaint/fixed-expected.png:
* platform/efl/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
* platform/efl/fast/repaint/fixed-move-after-scroll-expected.png:
* platform/efl/fast/repaint/fixed-position-transparency-with-overflow-expected.png:
* platform/efl/fast/repaint/fixed-scale-expected.png:
* platform/efl/fast/repaint/fixed-scroll-simple-expected.png:
* platform/efl/fast/repaint/fixed-table-cell-expected.png:
* platform/efl/fast/repaint/fixed-table-overflow-expected.png:
* platform/efl/fast/repaint/fixed-table-overflow-zindex-expected.png:
* platform/efl/fast/repaint/fixed-tranformed-expected.png:
* platform/efl/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
* platform/efl/fast/repaint/float-move-during-layout-expected.png:
* platform/efl/fast/repaint/float-new-in-block-expected.png:
* platform/efl/fast/repaint/float-overflow-expected.png: Added.
* platform/efl/fast/repaint/float-overflow-right-expected.png: Added.
* platform/efl/fast/repaint/gradients-em-stops-repaint-expected.png:
* platform/efl/fast/repaint/iframe-scroll-repaint-expected.png:
* platform/efl/fast/repaint/inline-block-resize-expected.png:
* platform/efl/fast/repaint/inline-color-change-expected.png:
* platform/efl/fast/repaint/inline-horizontal-bt-overflow-expected.png:
* platform/efl/fast/repaint/inline-outline-repaint-expected.png:
* platform/efl/fast/repaint/inline-vertical-lr-overflow-expected.png:
* platform/efl/fast/repaint/inline-vertical-rl-overflow-expected.png:
* platform/efl/fast/repaint/intermediate-layout-position-clip-expected.png:
* platform/efl/fast/repaint/intermediate-layout-position-expected.png:
* platform/efl/fast/repaint/invisible-objects-expected.png:
* platform/efl/fast/repaint/japanese-rl-selection-clear-expected.png:
* platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/efl/fast/repaint/layer-full-repaint-expected.png:
* platform/efl/fast/repaint/layer-hide-when-needs-layout-expected.png:
* platform/efl/fast/repaint/layer-visibility-expected.png:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Rebaseline pixel expectations after r131941 and r131991, part 2.

* platform/efl/fast/repaint/body-background-image-expected.png:
* platform/efl/fast/repaint/layout-state-only-positioned-expected.png:
* platform/efl/fast/repaint/layout-state-relative-expected.png:
* platform/efl/fast/repaint/layout-state-scrolloffset-expected.png:
* platform/efl/fast/repaint/layout-state-scrolloffset2-expected.png:
* platform/efl/fast/repaint/layout-state-scrolloffset3-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-1-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-10-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-2-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-3-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-4-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-5-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-6-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-7-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-8-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-9-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png:
* platform/efl/fast/repaint/line-in-scrolled-clipped-block-expected.png:
* platform/efl/fast/repaint/line-overflow-expected.png:
* platform/efl/fast/repaint/lines-with-layout-delta-expected.png:
* platform/efl/fast/repaint/list-marker-2-expected.png:
* platform/efl/fast/repaint/make-children-non-inline-expected.png:
* platform/efl/fast/repaint/moving-shadow-on-path-expected.png:
* platform/efl/fast/repaint/multicol-repaint-expected.png:
* platform/efl/fast/repaint/nested-iframe-scroll-inner-expected.png:
* platform/efl/fast/repaint/nested-iframe-scroll-outer-expected.png:
* platform/efl/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png:
* platform/efl/fast/repaint/opacity-change-on-overflow-float-expected.png:
* platform/efl/fast/repaint/outline-child-repaint-expected.png:
* platform/efl/fast/repaint/outline-inset-expected.png:
* platform/efl/fast/repaint/outline-repaint-glitch-expected.png:
* platform/efl/fast/repaint/outline-shrinking-expected.png:
* platform/efl/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png:
* platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
* platform/efl/fast/repaint/overflow-delete-line-expected.png:
* platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
* platform/efl/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png:
* platform/efl/fast/repaint/overflow-hide-expected.png:
* platform/efl/fast/repaint/overflow-into-content-expected.png:
* platform/efl/fast/repaint/overflow-outline-repaint-expected.png:
* platform/efl/fast/repaint/overflow-scroll-delete-expected.png:
* platform/efl/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png:
* platform/efl/fast/repaint/overflow-show-expected.png:
* platform/efl/fast/repaint/reflection-redraw-expected.png:
* platform/efl/fast/repaint/reflection-repaint-test-expected.png:
* platform/efl/fast/repaint/region-painting-invalidation-expected.png:
* platform/efl/fast/repaint/region-painting-via-layout-expected.png:
* platform/efl/fast/repaint/rel-positioned-inline-with-overflow-expected.png:
* platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
* platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/efl/fast/repaint/repaint-during-scroll-expected.png:
* platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.png:
* platform/efl/fast/repaint/repaint-resized-overflow-expected.png:
* platform/efl/fast/repaint/scroll-absolute-layer-with-reflection-expected.png:
* platform/efl/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKitTestRunner needs testRunner.queueLoadingScript and testRunner.queueNonLoadingScript
https://bugs.webkit.org/show_bug.cgi?id=42675

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added implementation of testRunner.queueLoadingScript and testRunner.queueNonLoadingScript.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::queueLoadingScript):
(WTR):
(WTR::InjectedBundle::queueNonLoadingScript):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::queueLoadingScript):
(WTR):
(WTR::TestRunner::queueNonLoadingScript):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/WorkQueueManager.cpp:
(WTR):
(WTR::runJavaScriptFunction):
(ScriptItem):
(WTR::ScriptItem::ScriptItem):
(WTR::ScriptItem::invoke):
(WTR::WorkQueueManager::queueBackNavigation):
(WTR::WorkQueueManager::queueLoadingScript):
(WTR::WorkQueueManager::queueNonLoadingScript):
* WebKitTestRunner/WorkQueueManager.h:
(WorkQueueManager):

LayoutTests:

Unskipped corresponding test cases for WK2. Put those which still fail to appropriate
groups.

* platform/wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Move OBJECTS_DIR and friends to default_pre.prf

The introduction of load(qt_build_config) in .qmake.conf meant
that we started loading qtmodule.pri, which in turn set both
MOC_DIR, RCC_DIR, and OBJECTS_DIR.

We were setting OBJECTS_DIR in default_post under a isEmpty() guard
so that project files could override the objects dir. Instead of
using the isEmpty() check we move it to defaul_pre, which will
override the qtmodule.pri settings, but still allow project files
to override it.

Reviewed by Ossy.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Move LayoutTests/fast/css3-text-decoration directory into LayoutTests/fast/css3-text directory.
https://bugs.webkit.org/show_bug.cgi?id=99948

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-22
Reviewed by Hajime Morita.

css3-text-decoration is one of the feature under the ENABLE_CSS3_TEXT flag,
it should be maintained in the css3-text directory with other features under the same flag.

* fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt.
* fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html.
* fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt.
* fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html.
* fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js.
(testElementStyle):
(testComputedStyle):
* fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-style.js: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-style.js.
(testElementStyle):
(testComputedStyleValue):
(testValue):
* fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png: Renamed from LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png.
* fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-expected.txt: Renamed from LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.txt.
* fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line.html: Renamed from LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line.html.
* fast/css3-text/css3-text-decoration/text-decoration-line-expected.html: Renamed from LayoutTests/fast/css3-text-decoration/text-decoration-line-expected.html.
* fast/css3-text/css3-text-decoration/text-decoration-line.html: Renamed from LayoutTests/fast/css3-text-decoration/text-decoration-line.html.
* platform/chromium/TestExpectations:
* platform/efl/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png: Renamed from LayoutTests/platform/efl/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png.
* platform/mac/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Renamed from LayoutTests/platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt.
* platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Renamed from LayoutTests/platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Rebaseline pixel expectations after r131941 and r131991, part 3.

* platform/efl/fast/repaint/scroll-fixed-layer-with-reflection-expected.png:
* platform/efl/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
* platform/efl/fast/repaint/scroll-fixed-reflected-layer-expected.png:
* platform/efl/fast/repaint/scroll-in-clipped-layer-expected.png:
* platform/efl/fast/repaint/scroll-in-fixed-layer-expected.png:
* platform/efl/fast/repaint/scroll-in-transformed-layer-expected.png:
* platform/efl/fast/repaint/scroll-inside-table-cell-expected.png:
* platform/efl/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
* platform/efl/fast/repaint/scroll-with-transformed-parent-layer-expected.png:
* platform/efl/fast/repaint/search-field-cancel-expected.png:
* platform/efl/fast/repaint/select-option-background-color-expected.png:
* platform/efl/fast/repaint/selected-replaced-expected.png:
* platform/efl/fast/repaint/selection-after-delete-expected.png:
* platform/efl/fast/repaint/selection-after-remove-expected.png:
* platform/efl/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
* platform/efl/fast/repaint/selection-gap-overflow-scroll-expected.png:
* platform/efl/fast/repaint/selection-rl-expected.png:
* platform/efl/fast/repaint/stacked-diacritics-expected.png:
* platform/efl/fast/repaint/static-to-positioned-expected.png:
* platform/efl/fast/repaint/subtree-layoutstate-transform-expected.png:
* platform/efl/fast/repaint/subtree-root-clip-2-expected.png: Added.
* platform/efl/fast/repaint/subtree-root-clip-3-expected.png: Added.
* platform/efl/fast/repaint/subtree-root-clip-expected.png: Added.
* platform/efl/fast/repaint/subtree-root-skipped-expected.png:
* platform/efl/fast/repaint/table-cell-collapsed-border-expected.png:
* platform/efl/fast/repaint/table-cell-move-expected.png:
* platform/efl/fast/repaint/table-col-background-expected.png:
* platform/efl/fast/repaint/table-collapsed-border-expected.png:
* platform/efl/fast/repaint/table-extra-bottom-grow-expected.png:
* platform/efl/fast/repaint/table-outer-border-expected.png:
* platform/efl/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png:
* platform/efl/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png:
* platform/efl/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png:
* platform/efl/fast/repaint/table-row-expected.png:
* platform/efl/fast/repaint/table-section-overflow-expected.png:
* platform/efl/fast/repaint/table-section-repaint-expected.png:
* platform/efl/fast/repaint/table-two-pass-layout-overpaint-expected.png:
* platform/efl/fast/repaint/text-append-dirty-lines-expected.png:
* platform/efl/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
* platform/efl/fast/repaint/text-selection-rect-in-overflow-expected.png:
* platform/efl/fast/repaint/textarea-set-disabled-expected.png:
* platform/efl/fast/repaint/transform-absolute-child-expected.png:
* platform/efl/fast/repaint/transform-absolute-in-positioned-container-expected.png:
* platform/efl/fast/repaint/transform-disable-layoutstate-expected.png:
* platform/efl/fast/repaint/transform-layout-repaint-expected.png:
* platform/efl/fast/repaint/transform-relative-position-expected.png:
* platform/efl/fast/repaint/transform-repaint-descendants-expected.png:
* platform/efl/fast/repaint/transform-replaced-shadows-expected.png:
* platform/efl/fast/repaint/transform-rotate-and-remove-expected.png:
* platform/efl/fast/repaint/transform-translate-expected.png:
* platform/efl/fast/table/border-collapsing/cached-69296-expected.png:
* platform/efl/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Added.
* platform/efl/fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
* platform/efl/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
* platform/efl/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: merge "docked" state into the "dock side" enum.
https://bugs.webkit.org/show_bug.cgi?id=99717

Reviewed by Vsevolod Vlasov.

.:

Otherwise, it is hard to manage these inter-dependent flags.

* Source/autotools/symbols.filter:

Source/WebCore:

Otherwise, it is hard to manage these inter-dependent flags.

* WebCore.exp.in:
* inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::requestSetDockSide):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
* inspector/InspectorFrontendClientLocal.h:
(InspectorFrontendClientLocal):
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::requestSetDockSide):
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/DockController.js:
(WebInspector.DockController):
(WebInspector.DockController.prototype._updateUI.get sides):
(WebInspector.DockController.prototype._updateUI):
(WebInspector.DockController.prototype._toggleDockState):
* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.setAttachedWindow):
(InspectorFrontendAPI.setDockSide):
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):
* inspector/front-end/externs.js:

Source/WebKit/chromium:

Otherwise, it is hard to manage these inter-dependent flags.

* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::requestSetDockSide):
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Don't build any of the tools in production_build

Reviewed by Simon Hausmann.

* Tools.pro:
* qmake/mkspecs/features/configure.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Shadow] ASSERT triggered when we try reprojecting fallback elements.
https://bugs.webkit.org/show_bug.cgi?id=99815

Reviewed by Hajime Morita.

Source/WebCore:

When fallback elements of InsertionPoint is reprojected, they were attached twice.
We have to skip attaching them if they are attached. We also add a few ASSERT not to
allow attaching twice if not necessary.

We have confirmed that this patch does not regress the performance. The summary of the
performance test is the following:

Dromaeo/dom-modify.html [runs/s]:
                       median stdev    min    max
   without this patch:   3928   184   3655   4361
   with this patch   :   3925   178   3652   4350

Parser/html5-full-render.html [s]:
                       median stdev    min    max
   without this patch:   3821    17   3811   3850
   with this patch   :   3838   4.4   3833   3844

Test: fast/dom/shadow/content-reprojection-fallback-crash.html

* dom/ContainerNode.cpp:
(WebCore):
(WebCore::childAttachedAllowedWhenAttachingChildren): If true, children of this node might
be attached in advance because of ShadowDOM attaching process.
* dom/ContainerNode.h:
(ContainerNode):
(WebCore):
(WebCore::ContainerNode::attachChildren):
* dom/Element.cpp:
(WebCore::Element::attach):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::attach):

LayoutTests:

* fast/dom/shadow/content-reprojection-fallback-crash-expected.txt: Added.
* fast/dom/shadow/content-reprojection-fallback-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132047 268f45cc-cd09-0410-ab3c-d52691b4dbfc