labofsahil/github-event-dataset-2012 huggingface dataset:
Weird triple tick in github markdown means a code block but in other markdown viewers it means “preview as html”. I ended up using single ticks to avoid this issue since we don’t know how users will preview this file locally on their system.

From: Jason San Jose [mailto:notifications@github.com]
Sent: Thursday, August 23, 2012 12:06 PM
To: adobe/brackets
Cc: Ty Voliter
Subject: Re: [brackets] Plugin localization example and documentation (#1424)


In src/extensions/disabled/LocalizationExample/README.md:

> +

> +## Adding new localized strings to Brackets

> +Add new English strings to the file brackets\src\nls\root\strings.js. Translations in other languages should be added to the strings.js file in each of the locale folders inside the “nls” folder. For example, modify brackets\src\nls\fr\strings.js for French

> +

> +## Using Localized strings in Brackets modules

> +

> +## Strings JavaScript

> +1. Load the Strings module in the file where the string is to be used

> +Strings = require("strings");

> +

> +2. Reference a string by selecting a property from the String module. For example, Strings.NOT_FOUND_ERR yields the string “The file could not be found." for an English locale.

> +

> +## Strings HTML

> +Localizing HTML in Brackets requires use of the templating framework mustache.js since HTML cannot directly reference properties in strings.js. Strings for both JavaScript and HTML are stored \src\nls\root\strings.js, but in HTML they are referenced using the template syntax {{stringKeyName}}.

> +For example,

> +<h1 class="dialog-title">{{SAVE_CHANGES}}</h1>

Use triple-back-tick for these code blocks.

—
Reply to this email directly or view it on GitHub<https://github.com/adobe/brackets/pull/1424/files#r1448085>.
Actually, if a new load is started before an existing one completes, `onCursorActivity()` will only be called once. The first time the `done()` function is called, the `pendingCursorActivity` flag will be cleared, so the cursor activity will be ignored on the second call to `done()`. This is a real edge case anyway, and the worst thing that can happen is the wrong selector is highlighted. 

Assert removed.
@jason-sanjose 

Actually... promises have a problem where if a 'done' listener throws an exception, then any later 'done' listener won't get called, and the promise is sort of broken. (Additional 'done' listeners are never called, even though the deferred is resolved.)

I don't know if we should worry about this or not. But my current solution doesn't have this problem.
Triple `=`'es!
Currently showDetail as it doesnt need to show services not present uses the model as it is. It will be change.

For the second issue, a method will be created.
What happens if we add another playback type? Is there a way to have the % 3 a %<number of enum options>?

I know I recommended that playbacktype should be an enum, but maybe it's worth having a PlaybackTypeUtility class that has an enum and a utility method for determining toggle behavior.
It's up to you guys, but it seems to me like you could benefit from having a private method that would set the pause and play button visibility to avoid duplicating code. 

For readability it probably makes more sense to have a ShowPlay and a ShowPause method.

Then, using btnStop_Click as an example, you would just have ShowPlay() instead of both visibility setters. You could re-use these methods in all the places you're c/p'ing code.
And where do you call this function? ;-)
Thanks. Did you really think I could come up with that? :) Even now that I see it I vaguely know the princip of `default_error_messages`.
Then just do `list(map(...))` I like the mode condensed version ;-)
Can we pass it in the same way we pass in cert_reqs and ca_certs?

I'm fine with assuming it's SSLv23 if ssl_version is `None`.
这里判断一下是否等于NULL
Yep, completely forgot to clean up this class.  Much nicer now.
can you remove inmobi specific path here?
Don't get me wrong. I really like the idea and I agree with you, we should lazy load them APIM properties when we can. I just can't commit this patch until checks are added to make sure the other properties are initialized.
This should be replacing configuration file (%config) rather than ordinary file.

http://www-uxsup.csx.cam.ac.uk/~jw35/docs/rpm_config.html
> no real point in keeping things lined up this way...

I find it easier to read, but YMMV of course. I'll mend my evil ways some day.
Given the title is part of the max message length, I think maybe just Monolog would make more sense as a default value. Especially since it's possible to log warnings/info/debug messages that are not errors per se.
change  `d` to `hub`
._. This is where I feel like you're overreacting to formatting: when you're worried at little things such as this.
let callback = {
  handle: function handle(name, result) {
    Setting.counter--;
  },

  handleError: function handleError(name) {
    Setting.counter--;
  }
};
Should be Pivanov test :)
I don't like putting logos into empty divs.  Should probably think of putting this into the h1 or the header as a background via css
The default format applies to the input format.  The output is explicitly set by the attribute that gets used, e.g. `c.deg` or `c.rad`.

Fair enough about the config stuff.  I haven't gotten used to thinking about changing global config items but I can start.
This should be fixed in 7168cd01b7150b2c74507594766fdf3b2d3f40a6 (and I added a test for this exception)
@laanwj You suggested to use .data() instead of .c_str() for this here, but I'm not sure, why we don't need it to it be zero-terminated, can you explain please :).
See `.. class:: FeatureSelectionModel` in the same pull request.
I think width and height are setting the width and height of the window. It is likely that the window width is being set in a convoluted way that I dont understand yet.
`QImage()` should be returned from the `create_widget` method instead of being assigned here, and this method should call `super`. The docs in `QtObject` explain this.
Still unclear. The line needs to be explained better.
If we put it in `<namespace:devtools>` then the modified version of `system.file` will be used by devtools functions, but not by anything else. Is that what you have in mind?
Again, no camel case.
Why is this line here? It looks like a leftover from some refactoring?
OK, I removed the installation of `readline` in the latest `.travis.yml`.
The problem I ran into is that you have to do something now if text == '\r', is the last line of the pre-existing content needs to be erased, so you can't just return anymore in that case.  The line removal could be done later, I suppose, if all we had was '\r', but care would need to be taken to not throw the '\r' away.
For a time, I was using `git apply --reject` to get partial applies.  It's not used, currently.
```python
interval = os.environ.get('COLLECTD_INTERVAL', '60')
```
Though I'm suspicious of using a string for a numeric value...
This is to line up with the other colors on the lines before/after.
Just formatting. When there are multiple variables I like putting each on its own line but that's not necessary for singletons. Fixed.
Just for local dev. This isnt about the connect to twitter. It is where twitter redirects back afterwards.
Did this pass pyflake?! I can't see it being used for anything.
gross. r-
I had the impression that streams were left in blocking mode in react, but I don't remember what made me believe this. It made sense because if one reads a stream only once after a select(), it will never block. Obviously it's safer to put streams in non-blocking mode.
$OS is still used on this file.
I am not a fan. Files are pretty racy; if the user clicks 'Clear Data' then this fails (though we have other problems there too). It would be stronger to pass an InputStream. The caller could pass a FileInputStream if they really wanted to.
I just see the double `e`
"If we did not find anything in the themes of the current view," should be removed
please revert all permission changes
``elseif`` should be written without space
I recommend, that you do a PR if this is till an issue. Also note, that you have to do a PR against the branch this feature was introduced in.
As you are already removing the functions, I think they should be twig tests, not twig filters.
Actually, I wasn't commenting on your work, more on my change to the work. I wasn't sure if there was a better method than adding a whole bunch of chatter to your otherwise clean code. I'll look at @log.warn as an option.
scrooge worked OK for me. I think it's important that the scrooge docs mention they need sbt v0.11.2 (or is that fixed by sbt-scrooge?). sbt v0.11.3 did not resolve when working against twitter dependencies.
This is, of course, far too simple. I would argue that regular expression substitution is itself too complex to be part of this library though, and should be delegated to something else.
It does appear to get forced. Not opposed to being more explicit too. What's the standard?
If this is a module, shouldn't it go into a modules directory?
I can configure it to add the new line. Sorry for the brevity, iPhone.

Sent from my iPhone

On Dec 6, 2012, at 5:01 PM, Adarsh Pandit <notifications@github.com> wrote:

In app/helpers/mail_helper.rb:

> +  end
> +
> +  private
> +
> +  def poll_link
> +    link_to(
> +      @invitation.event.name,
> +      event_url(@invitation.event, guest_email: @invitation.invitee.email),
> +      html_options = { style: 'color: #EC6E4D' }
> +    )
> +  end
> +
> +  def sender_name
> +    @invitation.sender.name
> +  end
> +end
> \ No newline at end of file

SublimeText fails to add newlines to the end of files (Vim does this
automatically).

No functional impact but it is a style issue.

We had a hilarious 37-email exchange on the topic which I won't forward to
you out of kindness.

—
Reply to this email directly or view it on
GitHub<https://github.com/yammer/sched.do/pull/245/files#r2343866>.
已修正。
problem fixed, delete it to clean the code.
Есть, но хочу их делать отдельной задачей, когда этот метод будет в коллекции.
Don't forget to remove `-init`.
Waarom staat hier een ID=content bij? We kunnen de selector simpeler houden en laten werken zonder aanpassingen op elke pagina.
Exception should surely contain meaningful message.
Name changed from "resize" to "pow2resize" for a bit more clarity.
This will conflict with #119. Not sure which test is better...
which would you use?
You could do something like:

```js
typeof module == "object" && typeof require == "function"
```

or:

```js
module && module.exports
```

But honestly, I'm not sure we should be landing environment-specific implementations right now.
Using `on` changes the context of `this`, so this line breaks the keyboard handler. Test by moving the keyboard focus to an item with a submenu and try to open that using cursor-down etc.

The focus handling is broken, also in the menubar branch, maybe something you could look into later as well? Moving focus to the first submenu-free item should also bind cursor left/right to move focus inside the menubar, and the tabindex accordingly. Currently you have to activate with the mouse first, before being able to use the keyboard, and even then there's two items that can be focused, not just one.
I think so. kill -9 xxx will ignore any xxx that is not an actual process id. resque-worker will kill its child processes. There may be a problem if the child tasks does not die in a clean and recoverable way but I am not sure how we can solve that problem at the cascades level. Thanks.
Because objects comparison would not be true even if the objects contains the same properties, I've rewrite some part.
what if settings or request fails? I miss an ONERROR state, or ELSE for the IF. I understand that wallpaper is 99% probable to be found, but anyway.
This is not needed. The name of the file is good enough :)
nit: you can omit the false, this is the default value now.
Same here, `forEach`
I'm finding that search results are incomplete on my phone. It finds some results correctly, but doesn't find others.  I suspect that is a result of the TypeError above.  (This may mean that  my MediaDB.enumerate() function should include try/catch around the callback function so it doesn't abort the enumeration on those errors.)
1. You can use `document.getElementById(id)` instead of `querySelector`
2. L721-732 should be put into the `init` function of each view.
Is this needed?

Take into account that the entry point for the dialer adds in the launch path the following:

"launch_path": "/dialer/index.html#keyboard-view",
The `#TODO:` should be removed when translating a file, I probably should add this recommendation at the top of each file.
I added clearInterval/setInterval in 'screenchange' event for removing animation when screen of, so i wouldn't remove this.
Isn’t `role="listbox"` redundant with `<ol>`?
Should be `this.currentVolume / 100` if `currentVolume` is retricted between 0~100.
I've done the pending deletion ability in message manage deleteMessages https://github.com/mozilla-b2g/gaia/pull/2612. Hope that will not conflict with what you are doing.
i guess haz_topic is cute and all but... well... up to you :)
Found it. I don't think we need a custom exception type if nobody ever catches it.
Is this for when dylibs might be included in the Frameworks directory, like sometimes happens? (e.g. libqscintilla2 does this)
does tap work on all rubies?  i thought it was 1.9...
because you removed this in the current change set ...
Please fix all these old-style function specs. You can take them from edts_server
Can you put the RAND just in scope inside this block:
```scala
val hashes : Seq[CMSHash] = {
  val RAND = new scala.util.Random(seed)
  (0 to (depth-1)) ...
}
```
That way, there is no member variable handing around that anyone can touch.
I am not convinced about modes of operation. It makes the model a bit confusing IMHO.
On Dec 4, 2012, at 5:31 PM, Martin Hurton <notifications@github.com> wrote:
> In src/socket_base.cpp:
> 
> > @@ -1012,6 +1011,15 @@ void zmq::socket_base_t::terminated (pipe_t *pipe_)
> >      //  Notify the specific socket type about the pipe termination.
> >      xterminated (pipe_);
> >  
> > +    // Remove pipe from inproc pipes
> > +    for (inprocs_t::iterator it = inprocs.begin(); it != inprocs.end(); ++it) {
> > +        if (it->second == pipe_) {
> > +            inprocs.erase(it++);
> > +        } else {
> > +            it++;
> Just drop the ++it from the for statement.
> Or split it into two parts. Find the element you want to remove. If found, remove it. This can be done as at most one such element can be in the map.
> 
I went for the while loop - if you insist on the for loop, I will change it accordingly. Thank you for spotting this, I always iterate my STL containers via while, especially when erasing items so it's rather hard-coded in my brain.
Fixed the spacing - I was accidentally doing a tab instead of four spaces. I think the second point is particularly interesting, so let's chat about it at Monday's scrum.
Logged in the app manager
it is always set as you set it in the constructor
Put `data`.
This is totally independant of the unread feature.
Aren't event listeners registered in Sburb.initialize? This race condition shouldn't exist.
@lorenzo sorry for the old stuffs. Forget about that . This is just my doubt to learn the language :) .

In English if we have 100 pages and if we are seeing the 10th page , we say `Page 10 of 100 pages.` .  So in Brazillian Portuguese message it will only say `Página 10 de 100`
Yes -- and the default should be [], not None, right?
Yes, that is sensible.
But win32 port is mainly for debugging.  Developers usually put cocos2d-x engine to a non-C dist.  And some writeable config files can easily be found at the root directory of Debug.win32 folder.  They may want to modify these files for debugging.
In your case,  developers will need to find their config files at a very long path(C:\Documents and Settings\username\Local Settings\Application Data\....). Is there any other ways to achieve that?
A base class used by only 1 of the 4 implementations looks useless. You should define the method directly in the PharArchiver
Okay; I'll ponder that. It's a json object, so it looks pretty gnarly when
it's not a neat Base64 string, but that's probably irrelevant.

In this case, it will always be converted to Base64 because the server
never uses it (it's only used in the browser). In that sense, decoding it
to store in the DB seems like an unnecessary step.
On Jun 8, 2012 4:25 PM, "Maxwell Salzberg" <
reply@reply.github.com>
wrote:

> > @@ -10,4 +10,6 @@
> >    <Link rel="http://schemas.google.com/g/2010#updates-from"
> type="application/atom+xml" href="<%=@person.public_url%>.atom"/>
> >
> >    <Link rel="diaspora-public-key" type = 'RSA'
> href="<%=Base64.strict_encode64(@person.exported_key)%>"/>
> > +  <Link rel="scrypto-encryption-key" type='text/html' href="<%=
> @person.key_ring.encryption %>">
>
> Generally, if you are posting stuff out, you know you need to base64
> encode/decode things before you post it... not having the actual value come
> out of the database seems like something you have to remember before using
> it, which seems like it could lead to more mistakes.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/diaspora/diaspora/pull/3312/files#r954818
>
sorry, I couldn't figure out, how this m4 stuff really works and interacts with the rest of the code.
could you please give an actual example how this RS485_USART_INIT should look like.
I think I then can implement the rest of the code.
Actually there is a comment in the next line :)

But I agree, I will move it to variable
This space needs as separator between text and link.
> I explicitly try to avoid the ternary operator in Ruby ... I think they are bad style.

Don't worry about it.
It's a good practice in Ruby, tho.
Still todo or forgotten?
I have changed variable identifier(file -> path).
no problem.

-- 
Renaud Gaujoux
Computational Biology - University of Cape Town
South Africa


On 20/06/2012 15:39, hadley wickham wrote:
>> @@ -235,7 +235,13 @@ to_html.link<- function(x, package, ...) {
>>     } else {
>>       topic<- to_html.TEXT(x[[1]])
>>       label<- topic
>> -    t_package<- opt
>> +    parts<- str_match(opt, '([^:]+):(.*)')[1,]
>> +    if( is.na(parts[1]) ){
> And you don't need spaces inside `()`, but you do need them around `}{` - so it should be `} else {`.  Sorry to be so picky, but it will really bug me otherwise.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hadley/staticdocs/pull/22/files#r1017590
But thanks for adding tests in the first place! :+1:
In general I try to make low level util APIs like this one unaware of high level ones. In other words preferably nothing here should be aware of of our window wrappers or `windowNS`, instead caller of `setPBMode` should just pass it `windowNS(window).window`.
I do not see this function called anywhere.
Maybe. It would make addressInfo depend on the state of storage, not sure if that is a good thing.
Ok, works for me, particularly the latter rationale :-) If we were trying to do this "right" I'd probably advocate for not testing equality of the entire JSON blob at all but rather spot-checking particular values in the data-structure (and avoiding checking anything that relies on auto-increment IDs).
Just noticed that we have broken behavior here. In the constructor of the reporter we always register our own listener, whether of the enabled state. Therefore we shouldn't add this if condition here and always execute the unregister/removeOberserver code.
Yeah, issue #13 is now filed and closed. Reader's digest version is: record all clicks; possibly a percentage of ads served. Total views will be a Very Big Number™.
Is "starts with a dash" really the right thing here?

Also, this seems like a big and frightening change to make in the semantics of modules in a stable release.

At the very least this needs documentation to explain *why* this is the right thing.
That makes the code a lot uglier in return for slightly easier testing.  That isn't a good trade-off; please rewrite it.
bugzilla reference?
Cool. Thanks Marc!
`Tipicamente c'è bisogno di modificare questi altri file per modicare` -> `È necessario modificare questi altri file qualora si volesse alterare`
I didn't find any reason why `PHP_EOL` was being appended here, given that the interface says `format()` should return a "single line". Please let me know if this needs to be restored.
To clarify -- the @namespace annotation specifically? the commented out code? both? or something else?
use <TodoElement>[] instead of
new List<TodoElement>
should I modify that and re-commitl?
whats this for exactly?
optionsObject should link to what it's talking about
I agree with most of these points but not all.

Esp. point 2: I would not let the developer "dig through the code" to find out where signals are handled, but make sure instead that introspection is possible, and provide him with nice consoles/gui to let him get the complete picture at a glance.
And of course to be able implement debugging/tracing slots, being able to use a single slot for any signal is a must.

Other that that, we could copy your response in a "best dev practices" guide
I suggest we only add them as needed, as otherwise intermediate releases of the quickstart are wrong. This quickstart is included in the Quickstart set today.
...which doesn't negate the comment I added about the inconsistent spacing I noted, right?
Can you make this an object with functions, rather than a switch?
Ok, if you’re not that familiar with git, the one merging should be able to fix it. :)
Update the pid in the transform resource.
exists() ?
You're right. Removing them now.
When needs confirm plugin uninstall, it shows plugin name, not id on message
Lowercase p in please
Should this be True by default?
Maybe just a local? `var requestUrl` inside the `pjax` function scope.
Nice catch ! Previously the code ran into all SSO handlers without breaking the loop if a user was found.
тесты нормальные
переименую в wawVertex
надо научится удалять и вообще использовать vector
Nice! I'm still not sure how I feel about conditions on the right side of expressions, but there are definitely situations where it makes for pretty code.
You may notice that the diff shows that video_data['data'] is being used for the fields key in both the develop version and the ticket branch version. This wasn't a change introduced by the branch. The change you're suggesting is to the ``Video.to_json`` method, which is completely unrelated to this branch. The only reason I changed the from_json method is because the way that a video is best instantiated changed significantly.
There doesn't seem to be any way to shut down this executor.
Don't think so, imagine the delete() fails for some reason we would kill kill the `update` column for no reason
Was the newline intentional? (I know you usually like 1 line comments :-))
This method was fixing a bug that no longer existed when I upgraded to the latest Active Merchant + braintree gems
we can drop this method, it is replaced by getRouteCollectionForRequest
my phpstorm is happy with the use statement and then local names. but whatever, i will merge anyways, its better than what we have now and we need to go through with the cs fixer and make it consistent anyways.
Yup, both would be swell.
We should filter on IP addresses here, and throw an exception.
I don't get. What do you mean?
And you should only write from settings to store if the settings are present and the store is blank:

```javascript
_.each( [ 'username', 'password' ], function(property) {
  if ( this.settings[property] != null && this.store(property) == null ) {
    this.store(property, this.settings[property]);
  }
}, this);
```
Yeah, the backslashes were getting confusing so I moved to the more classical `[.]`. (I'm under the impression that `[.]` used to be the common idiom and the backslashes were introduced as a shortcut.)
Again - just 1 tab, don't replace those.
Круто. Буду знать. Спасибо.
Если ещё не смотрели лекцию 3 - самое время это сделать, тем более, перед 4 лекцией. =) Есть метод description, реализация которого для своих нужд даст то же самое. Можно переписать, используя новые знания для закрепления материала.
По поводу проверки на -1 и 123424324 процента не очень согласен, т.к. параметры мутации не запрашиваются от пользователя а зашиты  в программе. А вот то, что может random может несколько раз вернуть одно и то же число, и соответсвенно мутирует меньше Х элементов - с этим абсолютно согласен
Мне эта переменная кажется лишней, оптимизация понятна, но чаще всего она не будет использоваться.
I'm good with the way it is. As you said, they're close and it's a one liner. Not an issue to update both if ever a change is needed. 

Sent from my iPhone

On 2012-12-02, at 11:04 PM, Dan Panzarella <notifications@github.com> wrote:

> In lib/alertify.js:
> 
> > @@ -195,10 +195,12 @@
> >  		 * 
> >  		 * @return {undefined}
> >  		 */
> > -		close = function () {
> > +		close = function (elem) {
> > +			bind(elem, "click", function(){
> > +				logElement.removeChild(elem);
> That's your call. Both instances of that are very close to each other (so presumably hard to miss if updating one) and wrapping it in a function might even take more space/size than just leaving it. But if adhering to DRY is important, it wouldn't be a crazy thing to change.
> 
> —
> Reply to this email directly or view it on GitHub.
>
That sounds better :) Just awkward having the same const refer to two different things depending on scope.
Could we overflow the stack here? If we had an unlimited `-repeat` for example.
不想引入日志库，类似反射警告也是输出到标准输出，用日志反而可能掩盖了。
deremo
I will see why the whole file changes and update the PR to fix this issue.
The surrounding `<ul>` is missing to make this valid HTML.
I think this function could be made public and include in its name iir. Maybe design_irr_filter ?
It should also have a docstring.
could you check that removing the space before the ":" keep the doc formatting correct in the reference doc generation?
also restrict the example to one channel type as they have different orders of magnitude
Please don't use initials. Use full meaningful names
Definitely not on my part :-)
Thanks for your notice. I did push the change again.
Don't need these two lines since my way is simpler/cleaner.
This is probably not needed
Ты меня доебать вообще решил?
Pequeño typo: debería ser `Skipped`.
No lo veo mal, pero podría tener problemas si el deadLineTime es una hora cercana a la media noche.
You are the man when it comes to this stuff. But since we're paying for data uploads and downloads, I found it prudent to let google do some of the work :)
This change will break caching on the API. You've got to move `$language` to the end or update all the API scripts to make a differently formed call to this class.  See [L1101 of PublisherApi.php](https://github.com/GroupCommerce/sdk.php/blob/master/PublisherApi.php#L1101)
Alright. Turns out that this change does increase speed a lot, but only when processing lots of different lines rather than one long line.
Oooh, Jeff will not be happy about the braces/brackets falling on a new line.
Kelsey just came running in "What???"
Sorry for missing this before. ^ same as above.
please move the statement creation outside the loop
Please concatenate var declarations into one block.
Yeah what's up with that
does this exist on coordinator only or on all members? I imagine the coordinator is the active one, how do we replicated the state/handle coordinator crashes?
undo ? ;)
put what in an end event? the exit call?
is this a package on packagist? I cant find the dependency.
Ah yes, I see now. Thanks.
Agreed. Lets stick with this until it causes any *actual* problems...
I don't know what pytz is. Any insight on this ?
Sure.  Will fix.
We should be able to get everything we need in a single execute script. For example, you could return a date timestamp and use `date.fromtimestamp`, or return an object containing the various components from a single date object.
Eww. Best case, this is "only" blocking the entire UI while the image is decoded (at full resolution). Worst case, it'll do that and then decode the entire image again.

I guess this can pass for now if you can't come up with a way to get rid of this requirement (which did exist before, to be fair), but I'll have to file a bug on it when merging and we'll need to figure it out later.
Actually I think "stopping" the connector should not delete it.
It should only be deleted when it is not going to be used anymore (ever!).
The status needs to be a number.  It should also return something when it is failing.

```ruby
  {status:  connect ?  connect.gets.split.first.to_i : nil}
```
In output elsewhere in square brackets there are listed transitions of type, so it's seems a bit inconsistent here to display transition in column description. Maybe let's just skip square brackets parts or " M .." message at all? 

I don't really know, it seems nice to give some feedback about that it happened, just seems a bit inconsistent.  Any ideas welcome, it's not really bad as it is, just a thought.
That's not a bad idea ... If we did that, would `EditorWithToolbar`'s name stay the same, or would it change too?
Agreed - are you happy for me to merge the other changes?
I'll leave out the commit to update the tests, I got too far down the rabbit hole with this.
I might need to roll another minimal fix since I think I've changed the CSV output slightly.
why `set_enabled` instead of `enabled=`?
I am not sure this is the recommended solution.
If we setup the router as following

"/abc" [GET]  -> do_get_abc
"/abc" [HEAD]  -> do_get_head

Then the application's code is not respected.
And I think this could be a valid choice
Are you sure ``null`` has the correct type as ``null`` is not a sub-type of ``string``?
Forgot to add the return type lol :P
Is it a problem that all of the old hooks still have the 'domain' property?
You could also do `(every? (set->predicate (:awards book)) awards)`.
Can you show both options here?
put back the @return that was there before
Ah, sorry. Do you mean to use `squeeze` and `rstrip` together?
Import only modules. Import with relative or absolute. Never like this (what if there is some other module `models` somewhere else in the Python path).
Add units into a comment at the end.
Use `user._key`.
No spaces between commas?
I would move this to models?
This variable is probably not needed, you are using it only once?
Why this div? `content` block already has a div.
[One example](https://github.com/wlanslovenija/mainpage/blob/master/mainpage/wlansi/static/wlansi/js/map.js).
```
connectWith: '.panels_column',
```

into:

```
'connectWith': '.panels_column',
```
assetStream.CopyTo(effectStream)
yes,

But we will need to add Lots of "IFS" in the code.
Actually, only two minor changes were necessary (But my tests do not cover
lots of scenarios).

Directx and Opengl are quite different and probably some stuffs that are
Reach in DIrectx arent necessary reach in Opengl.

Some stuffs like "custom shader" should not be Reach (it is a "sacrifice"
done by microsoft because of windows phone 7), so in my opinion the
MOnogame REach should not be equal do XNA Reach,
Our reach must constains things that runs in almost all plataforms (THis is
just my opinion =P)

Att,
Thiago Dias Pastor


On Wed, Feb 29, 2012 at 3:36 PM, Christopher Chambers <
reply@reply.github.com
> wrote:

> > @@ -65,21 +65,49 @@ internal void Apply()
> >               {
> >                       GL.BindBuffer(BufferTarget.ElementArrayBuffer,
> ibo);
> >               }
> > -
> > -             public void GetData<T>(int offsetInBytes, T[] data, int
> startIndex, int elementCount) where T : struct
> > +
> > +        public unsafe void GetData<T>(int offsetInBytes, T[] data, int
> startIndex, int elementCount) where T : struct
>
> Yes, I think we'll eventually want full support for the Reach profile.
>  I'd be interested in seeing those changes and working with you to get them
> integrated.
>
> I think they should be fully selectable at runtime, like XNA does with
> GraphicsDevice.GraphicsProfile.  Is it possible to do it that way, rather
> than with a compilation symbol?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mono/MonoGame/pull/324/files#r502689
>
I don't see a `_constructorGroupBy` attribute, so this won't work.
Why not actually use a specific eception btw? It may make other people's life easier in the future if they want to catch it (not saying it has to be done though, but at least to keep in mind in the future for similar situations).
you don't need this

chH == *handler
Why are you sending disable gravity on roots? Using a frost nova on jumping player should not cause him to be frozen mid-air
You can use CharacterNameData here, and spare the SQL query
This namespace needs to change to either pubchemsubstance: or pubchemcompound:. See other comments also.
Remnant from uploading files without a key, I believe
should check here, setNamingStrategy if version > 2.3.0-DEV otherwise, remove all naming strategy related services from DIC
if we want to be really compliant, this regex is invalid because PHP allows more than ``\w+`` as method name.
However I'm not sure that sane devs would go outside this range, especially as some IDE (PhpStorm for instance) fail on unicode function names (you can test your own IDE by looking in the Twig testsuite which contains such a name). So it may be fine to keep the regex as is. @fabpot thoughts ?
Is there a way of doing this in one query and avoiding the `order_by`?
Wait, same what? This one is not deprecated.
This syntax is a bit weird, the way it is never used after being instantiated. At first I did not realise that the registration process was being completed.

I guess it's tricky because there's no need to use the page object after this step. 

I'll have a think, I may add a comment and an assertion just to make it read more like a manual test case would and thus be more intuitive to a fresh set of eyes.
Ah, I get it now, a comment would be nice.
This too, it's basically just an other template, i don't see why this is defined inline.
Why you remove the api tag?
I think the indentation is inconsistent…
Could you amend the commit and force-push it to your branch?
Small note, `if ... && options[:versions]` is redundant with the if above it. This block is executed within the same if already.
Probably unnecessary comment, anyway, start it with a upper case.
P.S. Sorry, dumb question but how would you use grep to check for the wrong amount of whitespace?  That would be really useful!  grep \t * seems to dump a LOT of output...
I have to say here that I prefer my old way of putting the Ifs at the start of each line.  Since the backticks made the lines wrap, I'd even indent the wrapped portions to make this look more like a bulleted list.  (I think actual bullets are probably overkill however.)
I think you mean Ubuntu, not linux.  Also it's LTS, not LTE
If you're checking for null here, why is there [ValidateNotNullOrEmpty] on the property?
This line may be unnecessary... see astropy/astropy#387
Once again, this is all projects code and not frontpage
thanks -- i agree with aled.  only use final for immutables or very public classes that would be stupid to extend.

too many times i've wanted extensions (or even found bugs, one in sun's java) in classes that were "defensively" marked final.  i think s/defensive/antisocial/ .  someone who subclasses might conceivably create a broken class.  that's true of anyone programming.  but we don't stop people from programming.  more likely they're trying to improve it or get out of a jam (like someone not wanting to work off snapshot builds). </rant>
You should not call `.id` here. It should be `cocoa.id` or `id` In the signature of `accessibilitySetOverrideValue`.
Like seen at http://docs.pylonsproject.org/projects/pyramid/en/latest/narr/hooks.html#view-and-route-predicates ? That's nice, i wasn't aware of this new feature to the current/upcoming 1.4 release. Do you think it will fit well together with cornice? If you propose going this path, i can give it a shot in the afternoon. Or should we just get rid of the boolean return values?

Personally, i would favor reusing Pyramid infrastructure rather than reimplementing stuff in Cornice, for sure, so thanks for the hint. Let's see if this works out. If you have further or more specific advices, please go ahead.
does this mean a blog post can only have a single author?
das isch scho im thesis.tex (hani döt anetue damit me alles wo titel, etc het wome selber apasse mues i de gliiche datei isch)
This check does not match the comment above it. Update one or the other.
а просто getProjects() в сутності $category не простіше буде? там можна прописати сортування
Tu as oublié d'enlever l'alerte !
thanks, I noticed it very soon after submitting the pull request.
We don't use this style. Please revert the indentation changes
Doh! Fixed. And no worries, I'm happy for all the feedback.
these only need to be one var. instead of doing if(is_floaty) do if(floatiness > 0) or even if(floatiness) as long as var/floatiness is always greater than or equal to 0
If you see "Symbol not found" errors, either change this path back or copy the built version over `./binding.node`.
you should keep ``5.3`` to test on the latest 5.3 (if you want to drop something, drop the old one IMO as people are expected to use a recent version whenever they can)
ServiceTestUtil.getSearchContext() does not exist.
Oh, I didn't mean to completely merge the `jquery_datepicker_settings` into `javascript_heads`, just call it from there :-)

Anyway, if you think it shouldn't be included in the `javascript_heads` at all, just take out the last commit.
Это не будет работать во многих браузерах. Лучше наследуй через оператор new (см слайды лекции)
i think these method could be instance method.
```
$params += array('access_type' => 'offline', 'approval_prompt'=>'force')
```
If my memory serves me correctly, this is required when we try to get the access token the first time - otherwise google doesn't give us a refresh token to use when the access token expires. I think it gets ignored when you refresh a token.

Personally, I think using a switch here is probably okay, I'm not sure how I'd abstract it further without bloat -- any ideas?

(Also, just fyi, I created a package to handle Google API requests via OAuth2 https://github.com/carswellgould/fuel-google-oauth2 it has support for auto-refreshing tokens (allbeit with a few bugs))
Sorry, I meant the values, not the name of the constant. OAUTH_URL = "media.oauth.uri"; or something along those lines.

I could see multiple services using oauth all wanting to set the property oauth.uri to something different.
no @toolbarbuttonCornerRadius@ on Linux.
Please indent this line too :)
more commented out code...
how about `@link.user_id == current_user.id`, in one line?
Hm, I don't understand what you mean here. Could you please provide an example?
Set `penalty=None` here.
`n_iter` is more ambiguous, I think. Even if "epoch" is jargony, it refers to a full sweep through the dataset, whereas "iter" could mean number of [stochastic] gradient updates.
I don't understand why either :-(
Leave it like this, we can iterate on this later.
I would rather do that in model and have App#collaborations and App#invited_collaborations
Also looks like isrec should be an enum.
Should not be removed
Would the preference be to make the check over in search.c, around line 237, before we even get to the file loading?
`Query` is misspelled
what's changed here? nothing right?
I am not following? Which tools? I think this is not the first javadocs with space between @param and @return.
What this has to do with this change?
I don't think this is needed - because you have already flushed 2 lines earlier.
Now this is an exceptional error, and warrants the exception.
what happens if a spill is required while reading the keys?  I think this needs to happen earlier.
(It could happen if a subsequent activity was holding onto rows or some other activity was also keeping rows)
Write the last bracket on the last line like this:

```python
response = api.get(
    product='WaterWolf',
    ...
    date_range_type='report',
)
```
Can I get some alignments here? :)
Changed in $writer.
i added 'register' here to support omniauth-identity
It's more readable this way. `Validator` will bring confusion with Validator component.
Typos: s/do not exists/does not exist/
We'll have to do the dual setup here too.
The line is actually removed, and as you told we are handling the scenarios the new code.
@yuhunglin Can we write the `return ...` on the next line?
s/PUT/POST on this line.
it should be a warning IMO, as updating requires time (especially once 2.1 is out)
because I think Python returns a copy of the collection and not the reference but I'm not sure.
Ideally you actually want to validate this datastore option with some regex fu... you know, better programming practice.
why not make_nops(4) ?
Only references to the specific technique used in the module, pls.
This looks wrong.  modifcation_time should probably be a Time, not a module type, no?
Actually, there's no need since PR#260 adds bool support. I did, however, remove the `dtype_range` hack and, instead, use the new bool support. I [pushed directly to master](https://github.com/scikits-image/scikits-image/commit/2c84a2135f8d3c566c9b9970544794e52262fb48) because it seemed minor. Let me know if I shouldn't have done so.
This comment is probably unnecessary since it's already in the docstring (and alos, none of the other properties have comments).
That's a good approach.  It's true that this check is often used to catch invalid usage--typically 0-255 intensities stored as floats.
Use ``::`` to have this formatted correctly in the generated docs.
OK. I suppose these tests are actually testing two things - first, that an exception is raised (meaning `#matches?` returns false) and that the error is correct. I will split these into two, one testing that `#matches?` is false and that `#failure_message` is correct.
Sorry for typo ... I will fix it soon ...
You can just add another commit on the same branch (master), push it, and it will magically show up here.

It's better to send pull requests from branches than your master, yes.
"letters, numbers, and basic punctuation"
Do you want a class level comment here?
seconds is allowed to be greater than 60, see my comment below.
What if the date is December 47?  You'll move to month 13 (Febtober) and then index outside the valid part of the daysInMonth array.
If we do that, does the camera need a frustum? For picking we have a frustum for culling and a frustum for rendering. Is this the only case? Now that I think about it, I don't think this will work with the strategy of "update once, render multiple passes". How are we going to update once culling with a off-center frustum for a picking pass and still render the entire scene in a color pass?
You're converting UTC to TAI, so `julianDate` is expected to be in UTC, right?  But getTaiMinusUtc seems to assume the date is in TAI.
I would use ||, not &&.  Also we might want "< 1" instead of "=== 0".

`if (width < 1 || height < 1) {`
Should this php content be in this PR?
don't need to check for factory == null here, your (factory instanceof AuthSchemeFactory) already takes care of that
Ah, that's fine then.  Just wanted to make sure you weren't about to go crazy and start doing this for every new type you create.  ;)
Should be >= TiC.API_LEVEL_ICE_CREAM_SANDWICH
If you have html that contains an <img> tag, the image might not be loaded before the size is measured. Not sure how to fix this. If you resize the browser to trigger a layout, then it works. Any ideas?
This used to serve the purpose of protecting `children` since it was possibly a live reference, but now it guarantees the immutability of the internal `children` array while processing is going on (since it's working with a copy). So, unfortunately still necessary.
If this isn't in iOS and Android, why is it marked as deprecated in 2.0.0? Just curious ...
Replace this with a data attribute and make the cache lookup here.
Probably so as I am not really testing it and just need it as a control variable.
same for most other headers. will not repeat
What is that weird character after 'chartbeat_apikey'?
meh, just get rid of the slashes
I'll roll this back, and put it into run.sh and another pull request.
Ok. That's easy to extract to a BOM. Will do one today.
The game wasn't fun when I didn't include this. You could've gotten an insane amount of hits in in a short period of time.
Note that `getContentValues` can throw a runtime exception, for bookmarks at least… think about how you want to handle that.
Source formatting note: these should be using A.config.win (which should be added as a constant at the top as WIN).
Also, instead of doing two window.open calls, it should be in a format like so:
```javascript
    var encodedMapAddress = encodeURIComponent(mapAddress);
    var url = 'http://maps.google.com/maps?q=' + encodedMapAddress;
    if(directionsAddress){
        url = 'http://maps.google.com/maps?f=q&hl=en&q=' + encodeURIComponent(mapAddress) + '+to+' + encodeURIComponent(directionsAddress);
    }

    window.open(url);
```
D'oh, I can see how that would be what you'd think, my bad. While I'd argue that the default should be as a "daemon" (for lack of a better term), this is your patch, so sure :) maybe some of the Opscode people have a stronger opinion on this, or can resolve this obviously intractable debate? (sarcmark)

I probably won't have time until this evening to work on this.
I don't see the point in this.  Could you please explain a bit more thoroughly how this resolved the bug you found?
It still seems excessive. What about binding these event handlers in the `drawTimeGraph` (or similarly named) method?
Is een  hexkleurcode hier niet mooier?
Nit: Same thing here, it would be cleaner to just let the JSON deserializer do its thing, and skip the non-scalar results.
At some point, should we change this to be an object instead of passing a list?
Habe ich für diese beiden gemacht -> aber habe keine weiteren schlauen gefunden, die ich gleich mit dem Konstruktor initialisieren könnte. Höchstens noch das Pricing Schema, aber das ist ja zur Zeit des "Offers" noch nicht bestimmt, oder? Oder wäre jede Pricing Alternative ein neues Offer?
This also doesn't need to be an array because its state is never used outside of any loop and is always initialized at the beginning of any loop.
I think we want OSM.js instead of XYZ.js.
Do we need to return false here?
WTF I didn't knew that, but you are right, _d_arrayliteral is called and gc alloc.
Now that it's clear there are multiple uses of this idiom, it's worth making it a function. We'll need one that has delete's semantics anyway so we can direct users of delete to it (instead of asking them to use a two-liner).
some validation on the exposed result limits.
Also, as a comment. . . I can see how there is 4 levels of IF (if you add 'while'), but I don't see any reason for factoring it out into a private method since its going to be used only here and keeping it in one place makes it easier to follow IMHO
Should we mention that most pull requests will be reviewed by two people before being merged? This might set up an appropriate expectation for contributors in terms of what they are waiting for.  How about something like:

At this point you're waiting on us. We like to at least comment on your pull request and may suggest some changes, improvements or alternatives. In general two people will review your request and once it meets all the requirements it will get merged right in.
Added and pushed
@eddiejau - 

The execute method only appears in three of the drivers (mysql, pdo, and sqlsrv.) I changed two (pdo and sqlsrv) removing the JError side of the logic -- and now it matches the MySQL method. (which has both the log and the throw error, as I posted above for Rob.)

All other drivers extend one of these three and therefore have the same code in the execute method they use.

Unless I am missing something, I think this is consistent for every driver (after this PR).