labofsahil/github-event-dataset-2012 huggingface dataset:
>Yes, I saw all this... what I commented is that the official documentation does not mention it...

Okay. :-) Anyway could be helpful for other people.

I will try to work to make it was added to the official documentation.
1. Checked. It's not overridden anywhere else.
2. Even if somebody already overrode it in it's own application code there won't be PHP error. Proof: http://codepad.org/69sPcG0a (BC is okay).
What kind of troubles exactly?
so I know you just copied this from the other code, but... why `#ifdef CLIENT`? if we're popping a message box on any executable we should be verifying that the main window doesn't need hiding
This should probably be `versionchanged` instead of versionadded.
same here: "est **de** trouver"
I think you should have not deleted this!
The reason is that renaming temp files leaving yucky setuid.  Granted, the mktemp call should be making a file right there to prevent any cross-filesystem hierarchy weirdness.

chown medical experimentation on various platforms:

Lucid works fine:

```shell
Using /home/ballard/.rvm/gems/ree-1.8.7-2012.01
~  ᐅ ( umask 777 ; touch ✪ ; ruby -rfileutils -e "FileUtils.chmod(0444,'✪')" ; ls -l ✪ ; rm -f ✪ )
-r--r--r-- 1 ballard ballard 0 2012-03-13 19:14 ✪
~  ᐅ rvm use 1.9.3
Using /home/ballard/.rvm/gems/ruby-1.9.3-p125
~  ᐅ ( umask 777 ; touch ✪ ; ruby -rfileutils -e "FileUtils.chmod(0444,'✪')" ; ls -l ✪ ; rm -f ✪ )
-r--r--r-- 1 ballard ballard 0 2012-03-13 19:14 ✪
```

Lion works fine: 

```shell
~  ᐅ rvm use ree
Using /Volumes/Users/barry/.rvm/gems/ree-1.8.7-2012.02
~  ᐅ ( umask 777 ; touch ✪ ; ruby -rfileutils -e "FileUtils.chmod(0444,'✪')" ; ls -l ✪ ; rm -f ✪ )
-r--r--r--  1 barry  admin  0 Mar 13 12:15 ✪
~  ᐅ rvm use 1.9.3
Using /Volumes/Users/barry/.rvm/gems/ruby-1.9.3-p125
~  ᐅ ( umask 777 ; touch ✪ ; ruby -rfileutils -e "FileUtils.chmod(0444,'✪')" ; ls -l ✪ ; rm -f ✪ )
-r--r--r--  1 barry  admin  0 Mar 13 12:15 ✪
~  ᐅ rvm use jruby
Using /Volumes/Users/barry/.rvm/gems/jruby-1.6.7
~  ᐅ ( umask 777 ; touch ✪ ; ruby -rfileutils -e "FileUtils.chmod(0444,'✪')" ; ls -l ✪ ; rm -f ✪ )
-r--r--r--  1 barry  admin  0 Mar 13 12:15 ✪
~  ᐅ rvm use rbx
zsh: correct 'rbx' to '.rbx' [nyae]? n
Using /Volumes/Users/barry/.rvm/gems/rbx-head
~  ᐅ ( umask 777 ; touch ✪ ; ruby -rfileutils -e "FileUtils.chmod(0444,'✪')" ; ls -l ✪ ; rm -f ✪ )
-r--r--r--  1 barry  admin  0 Mar 13 12:15 ✪
~  ᐅ rvm use system
Now using system ruby.
~  ᐅ ( umask 777 ; touch ✪ ; ruby -rfileutils -e "FileUtils.chmod(0444,'✪')" ; ls -l ✪ ; rm -f ✪ )
-r--r--r--  1 barry  admin  0 Mar 13 12:16 ✪

```

Windows (tested on Windows 2003):

Cygwin: Was able to chmod and create a unicode character filename under cygwin.  Windows could not display it, but it appeared correctly over a share.  chmoding change NTFS ACEs mapping to (current user, Everyone and pseudo-real user None) per whatever mode is passed.

RubyInstaller 1.9.3: chown throws Error::EINVAL, even running via a unicode script with the magic header.

Cygwin looks like the best way to support unicode Ruby on Windows.
The port fd is never closed. This looks like it needs a check in `uv_loop_delete()`.
Similar to the xthread.h change, 'struct thread' is found in system headers.
Sorry, I made it wrong. Fixed.
Why isn't this using some method on the Config object instead?
this sentence needs a full stop at the end.
Maybe https://github.com/emberlabs/gravatarlib/blob/master/Gravatar.php could  be used too.
Please change the mode back to 644 and check the other files.
The phpbb object only becomes available in core.js which is included in the overall_footer and after this code.
While this will probably always work, it should really either be `>= 0` or `> -1` or `!== -1`
You should use something like logmagic instead of console.log. That way you get log levels and a module prefix.
what's this TODO for?
This suggests that we support `package.yaml`, is that true?  Does npm support that?
see other comment about `cmp()`.
libutils perhaps? it'd be nice to be consistent and it seems many other files here use libutils.
I think it's GitHub's fault. When I was syncing there was some errors.
Let me know :)
Adding `propagatedBuildInputs` allows us to simply some Nix expressions, but it won't do anything for users who want to run `asciidoc` after having installed the package into their user profile. IMHO,  a superior solution would be to wrap the `asciidoc` binaries in scripts that configure these dependencies in the run-time environment.
Please use Sencha (ExtJS/Touch) default formatting where possible -- don't add lots of padding,borders, etc unless absolutely necessary. CSS and styling will be done consistently throughout the entire application (every module) in a single effort. So we'll likely have to undo any unique formatting added at this point.
I guess, you forgot to remove this!
probably fine, but be careful of global vars. 

In general, should tag all variables with "var" keyword, i.e. "var MODULES".
Potentially better to wrap such a variables in a closure and make it accessible via a getter method.
Can we ditch the `units` keyword - CF mandates the radius and major/minor axes are expressed in metres. And the GeogCS constructor should probably cast to float to be on the safe side. That would give:
```
lat_lon_coord_system = icoord_systems.GeogCS(6371229)
```
多想想怎么用事件来解耦组件内与组件外的关系。
valueCount meaning indexExpressionBasedValueCount is a bit weird and deserves at least a comment.
Not allowing NOT NULL to be dropped seems arbitrary and wrong.
added self.model = create_model()  # u'Model1' (default value)
as per #132, the thing we're editing is a property, but its name is still a `predicate`
not helpful.
The example could refer to .jsp or .asp
You're right. I did it copying from tabular.html considering that it was the same behavior. Actually now that I see it, maybe both templates should be using title instead of capfirst.
There's no need to move validation here, keep it in `validation.py`.
Two spaces after the dot.
I agree we should either remove this method entirely or return something like a 501 Not Implemented (HttpResponse("", status=501)), rather than raising an exception which will 500.  Otherwise this looks good to me.
We can't put jquery-rails or underscore-rails in the assets group because
that group is not available in development (unless you explicitly start
your server with RAILS_GROUPS=assets.) We should only put gems in the
'assets' group if they are only needed to *compile* assets, and not used
during development or production.

On Friday, 9 November 2012, Sergey Nartimov wrote:

> In Gemfile:
>
> > @@ -104,4 +104,5 @@ group :assets do
> >    gem 'uglifier',     '>= 1.0.3'
> >  end
> >
> > +gem 'underscore-rails'
>
> I think that underscore-rails and jquery-rails should go to assets group
> as they have only assets, pjax_rails should stay outside any group. I
> guess if we do so we won't need to modify config/application.rb.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/errbit/errbit/pull/327/files#r2072372>.
>
>
Well, this is just a standard behavior for network oriented interfaces. I've merely implemented this the way the SSH library is meant to be used (see https://github.com/bitprophet/ssh/blob/master/ssh/channel.py#L490).

As a matter of fact, this indicates the resilience of  TCP connection and I'm pretty sure you could do the same test without ```fab``` and just with ```ssh``` and get the same result (ie ssh hanging out and waiting a looooonng time).

If this is not behaving the same way, then: 

- There must be a way to probe the SSH library for its internal state and find out it's now disconnected from the network (after we get a timeout) : This is the most likely situation...
- Or we're screwed :(.

In any case, getting disconnected should raise an exception from the SSH library that we should be able to catch, while the  read(n), catch timeout is the usual way to do the stuff with network libs (this is how people usually do in all langages, in fact)

I'm not at the office this morning, but I hopefully will have some time to investigate a bit...
how do we decide where the mnesia db goes? can we make a ?BOFFO_AUTH_PASSWD_DB setting for it?
Extra tabs all over the place.
Why don't you use '+' instead of svec_plus, '-' instead of svec_minus?
0 would be the result immediately after the seeding phase. No need to disallow that.
Nope, it shouldn't. Actually, I briefly thought about this earlier today, but didn't take the time to address it.

What's a reasonable behaviour? If after the end of the playlist, append to the end of the playlist.
ホワイトリスト…っぽくしてはいるつもりなんですが、今見たら判断している場所と代入している場所が離れてて気持ち悪いですね…。
We iterate over a list of row values, e.g. [[1,2,3],[4,5,6],[7,8,9]]. The DB insert expects a flat list of parameters, e.g. [1,2,3,4,5,6,7,8,9].
I understand, though we favor a solution that works on 98% of installations :) Thanks for your work and thoughts into it, I'm confident to look into it more closely today. Let's see to make the fix rock solid.
Здесь ещё кавычки английские (“”). В других местах по тексту встречаются симметричные компьютерные ("").
Если уж требовать длинного тире, наверное, стоило бы и кавычки заменить на наши ёлочки («»).
perhaps in the future we can add a way to list contracts per spider
For consistency, can you move this to where the other ```setHandler``` calls are in this file?
Yes, as mentioned in other update I will revert to deferring to == overload from != now that you raised the issue of the null LHS ref.
This doesn't actually test removal behavior. Either `callCount` should be 1 (which would require a code change), or you should fire the the events again, and make sure the call count doesn't change.
The comment says that the method will return the plugin. Is there a reason why this line was deleted?
Lol. Well whatever is consistent.
The text input field is pretty broken:
* This handler crashes because it wasn't wrapped with bind() like the other handlers
* It only runs on blur.  Should probably use `.on("input", this.colorSetter)` instead so it updates as you type
* It crashes if the color typed isn't a perfect valid hex color.  Seems like maybe it should be calling setColorAsHsv() instead, to ensure it always sets the color to a string value.
* The name is a misnomer, since it take no args.  Something like "handleTextEntry()" seems better.

That's a lot of stuff, so feel free to comment out this line and file a bug for later.
This could be `brackets.getModule("document/ChangedDocumentTracker").ChangedDocumentTracker`, so you can just call `new ChangedDocumentTracker()` below (that seems to be the pattern we're using for NativeFIleSystem and other similar cases).
I think splitting the code for collecting the value(s) into 2 functions (_getPrecedingPropValues() and _getSucceedingPropValues()) and then being careful not to overlap between the 2 adds unnecessary complications to the code. Is there a reason why you can't do it all in a single _getPropValues() function?

It also seem tricky to collect the values in reverse in _getPrecedingPropValues(). You could write  _getPropValues() so it:
1. Scans backwards until the start of the values
2. Collects all values while scanning forward
The function is designed to take two different types, MouseEvent or a object page. I realize the parameters in both cases are the same so I guess I don't need the if since the same code will run on both types.

-----Original Message-----
From: Randy Edmunds [mailto:reply@reply.github.com] 
Sent: Tuesday, June 12, 2012 6:52 PM
To: Ty Voliter
Subject: Re: [brackets] Context Menu API, partial implementation (#1012)

> +     * @param {MouseEvent | {pageX:number, pageY:number}} mouseOrLocation - pass a MouseEvent
> +     *      to display the menu near the mouse or pass in an object with page x/y coordinates
> +     *      for a specific location.
> +     * 
> +     * @param {?number} x - page relative x coodinate
> +     * @param {?number} y - page relative y coodinate
> +     */
> +    ContextMenu.prototype.open = function (mouseOrLocation) {
> +        var pageX, pageY;
> +        if (typeof mouseOrLocation === MouseEvent) {
> +            pageX = mouseOrLocation.pageX;
> +            pageY = mouseOrLocation.pageY;
> +        } else {
> +            pageX = mouseOrLocation.pageX;
> +            pageY = mouseOrLocation.pageY;
> +        }

What's the purpose of this condition? It seems to execute the same code in either case.

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/1012/files#r973147
Syntax error again -- Brackets fails to start up because of this.  Please correct the code, and test to make sure it runs before submitting the update.
`if(packed)`
is there a reason this is used over @memoize?
Provide attributes here as well.
I think he means that the class has been moved to a new location but the package name has not been change :)
Although I have no idea how "autoformat" would say that... ;)
Well actually this function was auto generated by Google CSE, I also checked if there is any way to make this shorter, but there is no inbuilt function for parsing parameters from URL (or at least I din7t find one).
The way you're using `disabled` is meant for attributes, I believe. Inputs expose a `disabled` property for you to use, and it should take a boolean value. Just to avoid confusion, let's just use `true` and `false` instead of strings.
Do we need an alternate format to support all browsers?
the inside of the above for..in should get wrapped in an `if( _manifest.hasOwnProperty( item ) ) {}` block for good measure
This is friggin' awesome. However, let's add your stuff before popcornString happens. Then, plugins that want to use it will have it available.
I've never seen prefixed CSS written like this before, but it's clever.
Do you still want the message?
As I understand it the message when debug level is on has additional detail (the exception message), so in general that's ok. should have a comment.
dynamic -> dynamically
`.unit`?
Quand c'est multi-line comme ça, même le premier va sur une autre ligne. Donc AutoloaderProivderInterface => à la ligne.
At any rate, this could just be `auto holder = Holder(writer);`?
Correct, code clean-up from previous refactoring of subscriptions to two-pane views. Noticed during this fix since the areas again overlapped by code search.
I  could not find by which magic is changed path
``` public/javascripts/converge-ui/vendor/jquery```
to
```public/javascripts/vendor/jquery```
I don't think it's a big deal, because creating a template with package, that is not yet in the environment, is more an issue for the users,that prefer the CLI (templates created thought the UI won't have that problem,  because they add the packages by clicking, not by typing, right?)

So when the template was created by CLI, the fix will be probably to change the script, that was creating it, and rerun it - scripting is why the CLI is there.
yes, conventions
please add the curly braces. We always use them even when there is only a single line (Monolog follows the PSR-2 coding standards)
```php
if (!isset($connection)) {
```
I would use `getDate()` in this case but its fine if you don't agree.
You are right, I just commited some changes to load the iframe into the keyboard_manager instead using a background service: 4cd9260
done (for both `long` and `lng`)
The outer parentheses are unnecessary here. Also another space before a comma that needs to be removed.
是不是索性把areas和categories一起放进去？
I've always put functions like this in the helpers, where are they supposed to go instead?
There was a discussion on IRC recently, and it seemed most agreed to start using a less strict coding style (inspired by the Qt coding style). I suppose we need to change the doc/coding.txt document, though.
I think you'd better use items.getCount() here.
I'm sure what this ```FIXME``` is about. But I think there's a problem here - multi geometries aren't supported.
this is wrong. You should not document it as being a DBAL connection as it is only true when using it for the ORM. When using it with the mongoDB ODM, you will have a Mongo connection in it
[MEDIUM] : Should we set day component to "1" here?
If not, please leave your comments here
Use either 

    sort!{|a,b| b.score <=> a.score}

or 

    sort_by!{|a| a.score}.reverse!
This sort of migration may not run in the future if you remove or rename the Event class. I'd try and get in the habit of not using active record classes in migrations unless they are defined in the migration itself.
Let's add a comment to explain why we're doing this.
We should probably add getBooleanProperty or something to configuration, but this is OK for now.
If changing how defaults are passed will require lots of changes elsewhere, then just have a static module-level `default_encoding` variable, rather than calling `getdefaultencoding()` each time.
This should return after handling, in case of something that has both PNG/SVG reprs, you don't want to display both.
oh i see. weird. we can give this a try then. minus the print statement ;)
does it have to be inline JS like this? if we ever turn on CSP (https://developer.mozilla.org/en-US/docs/Security/CSP), this wouldn't work.
add `git-core`
Replace ``dumps`` with ``fake_dumps`` and this works. :)
Maybe a comment like: # do something with portal_catalog
Thanks dude. I don't want test data going into the core.  

--  
Phil Sturgeon


On Monday, 20 August 2012 at 10:45, Salmane wrote:

> In system/cms/modules/blog/config/routes.php:
> > +<?php defined('BASEPATH') OR exit('No direct script access allowed'); > +$route['blog/rss/all.rss']='blog/rss/index'; > +$route['blog'] = 'blog'; > +$route['blog/positive/(:num)?'] = 'blog/category/positive/$2'; > +$route['blog/positive/(:any)?'] = 'blog/view/$1'; > +$route['blog/positive']= 'blog/category/positive'; > +$route['blog/beautiful/(:num)?'] = 'blog/category/beautiful/$2'; > +$route['blog/beautiful/(:any)?'] = 'blog/view/$1'; > +$route['blog/beautiful']= 'blog/category/beautiful'; > +$route['blog/animals/(:num)?'] = 'blog/category/animals/$2'; > +$route['blog/animals/(:any)?'] = 'blog/view/$1'; > +$route['blog/animals']= 'blog/category/animals'; > +$route['blog/environment/(:num)?'] = 'blog/category/environment/$2'; > +$route['blog/environment/(:any)?'] = 'blog/view/$1'; > +$route['blog/environment']= 'blog/category/environment'; > +$route['blog/food/(:num)?'] = 'blog/category/food/$2';  
> Right... random categories should be removed... it was from a test installation ... will amend..
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/pyrocms/pyrocms/pull/1707/files#r1412410).  
>  
>  
>
Sorry, you lost me here... what are pippin events?
Please remove this docComment.

And btw, it is wrong. this is not a boolean
I've added this because people might want to send raw commands to the caching driver much like you can to the with Doctrine to send raw SQL.
It it written into the interface so that you always have access to the driver, no matter what implementation you have.

If it's not deemed useful, I'll remove it from the interface.
you should remove the extra spaces around the ``!``
You mean cases such as using PHP 5.4 callables?
missing `( )` around the second condition.
``} elseif () {`` :)
I agree. Maybe add special handling for E_USER_DEPRECATED?
kill extra blank line
Ok, keep it as it is now. Merging.
Looks like `event_owner` local can be removed. Not used in / unimportant to the test.
Yes I also improve the test ;)
for my curiosity, why the hash? Is it a convention?
Are you sure these aren't legitimate bugs? I don't think negative shifting is allowed by the C standard.
The comments describing these parameters all came from the maketx ArgParse descriptions.
Could use ```:class:`matplotlib.Axes` ``` or similar.
C'est surtout cette ligne que je cherchais. Par contre il faudrait faire pareil pour le nom/prénom de l'utilisateur. Ou alors on pouvait juste interdire le HTML dans les Tweets, c'est peut-être plus simple et plus "normal".
Just a thought:

pushChild(...) and pop()

I think addChild() is better than pushChild() but I intuitively get the push/pop idiom.
Yes you are correct, I've updated that line to use the appropriate attribute.
Yes, `grunt-cli` takes care of both versions. As for `npm test`, I don't care about that. I consider the `grunt` binary a system dependency, just as we expect `node` and `npm` to exist.
That's not a slight flag, that's a force flag. You change the signature, but didn't change the calls to it.
Then I'd vote for not touching the file, so we can see it's old and we should pay our test-debt :)
nit: i would add a break just in case
I had to comment out "display: -moz-box" because with the -moz-box rule the text goes beyond the edge of the window.
nit: fix the indent here.
Also remove the section header copied from `bootstrap.js`.
this has been solved by PR #3991. Once it lands in contacts I will update import to use the common component
@jlebar @benfrancis @daleharvey The above code set an attribute on the iframe to know if the iframe has been is loading or not. Something similar will be needed for the browser application. Do you know if there is a better way to do that, and if not, should the browser API expose something?
Filed https://bugzilla.mozilla.org/show_bug.cgi?id=815484
add a default `data-state` and point out the following two labels are controlled by the state.
why == and not ===?
The reason we want to specify output is to be able to control this later on and either capture or reroute output.
It would probably be good to use, eg, `mktemp` or `mkstemp` to create a less predictable directory under /tmp to work in, rather than operating directly in there.  Even `$RANDOM` would be a step up.
Indentation is messed up, also missing a test :)
我一直对小说中出现这种东西感到很不理解。scence的交换应该用文学本身的方式，或者让读者自己体悟。
These two translations are in English.
I would prefer if this where called something with encode, convert or some such. "handle_*" to me is a convention that suggests that there is some action being taken on an event, whereas this just converts between data representations.
Put this file in your ~/www, and change this line
This should only drop those in common, not all of them.  Note how it computes the intersection.

I thought the comment was clear.  Do you think not?  Also, previously, this was a bug, so this will not effect any running code (unless I wrote something incorrect).
Yeah, agree having a bunch of parameters is gnarly (and I just added more :(), but I don't really want to make these constants on JoinAlgorithms. (because they'd be random and dangling) Other suggestions welcome.
I don't understand this, especially in the context of the name of this variable.
No need to compare with false here...  Just "if (!sf.open(...))" is good enough
This should be "Cod post, Tref neu lle"
Agree!
Thanks.
Did you some other opinions about my other changes.
I like std::vector more than CCArray too. But I don't want to make lots of changes in this release(Next Tuesday).
Eek. Good call - they shouldn't be able to. What's the best way to authenticate such a request? Feel free to point me at a FAQ if there is one that's applicable.
Say we have section A with 8 fields. Of which 2,4 and 6 are set to hidden.

We return count: 5 in numberOfRowsInSection.

If we didnt filter here we'd return the 'hidden' fields 2 and 4. instead of 1,3,5,7,8
Yes, it is related with ````rinda_ring_finger_patch.rb:18```` - unfortunately it will raise a ````RuntimeError```` and nothing more specific.
Shouldn't these be in () btw? (1<<0) etc?
I don't know what these are even doing but no subproject files were changed.
"Calls to this function will dispatch the unload notification that modules can listen to as described above." Ditch repeating the rest of it here I think.
this event was already being emitted by the error module.  Harmless via phantomjs, but as I'm typing this, I wonder whether people could be resizing their browser when running interactively in 10002/test right when this test was being run?  Seems unlikely, but also not completely water-tight.
could a username also have a dash? e.g. some-name?
```
E           IOError: [Errno 2] No such file or directory: './y_pred.png'
```

I'll fix it in master.
I think that adding the exception as a parameter for the log would be more helpful as it would provide the entire stacktrace to the logging system
Why is this better than specifically catching enoent for this case?
Currently the master stores it's pid under `/var/run/puppet/master.pid` should we change this to:

    pidfile=${PIDFILE-/var/run/puppet/puppet.pid}
Rather than this, it will be a lot more robust if the value of `@should_fork` is passed in as a parameter to the initializer (without a default), the accessor for `should_fork` is removed, and the logic in the daemon for setting should fork is consolidated to the point of construction of the `Puppet::Agent`. This would get us a much clearer code path for that configuration of the agent run and make it much harder to accidentally drop this in the future.
You can avoid conditionals in the specs by using "exclusion filters" (RSpec won't run them) with the `rails_3_0?` method.

https://www.relishapp.com/rspec/rspec-core/v/2-10/docs/filtering/exclusion-filters
```js
css: {
   compile: {
     'styles....
   }
}
Maybe you want call one argument $a and the other $b if the order doesn't matter.
Renderer points to RendererInterface so this is not correct. Also the import (use ....\Renderer) is not needed anymore
It looks like `assembleSetter/Getter` methods are not really needed anymore, could be moved to `__set/__get`
`quale metodo HTTP è stato utilizzato`,
`base`
hmm yes, but there is a simple code to address that [in Stdlib\Options](https://github.com/zendframework/zf2/blob/master/library/Zend/Stdlib/Options.php#L68)
s/Form/From/
A lot of the CraftBukkit implementation relies on obfuscated names, and overall it's better in my opinion to not duplicate code like this - what if the way of sending the information changes?
This empty line should be here, escortkeel, as the next import line is of a different base package.
First `*` leads to render this as paragraph which is invalid in this case.
He means you should factor out that string into a static final variable. For example, `public static final SERVER_ADDRESS_MATCH="oc.tc"`
Then I'd suggest to use `$obj->events()->trigger()` explicitly instead, and drop this method...
Ah yeah, not my bad, but I can fix that.
Hum, I confess that no. I though PhysFS_Mkdir() is able to understand an absolute path, even it's not explicitly specified in the documentation.

I did this because with this commit, the path can't be longer relative on OSX, since the current location is halfway between the result of getUserApplicationSupportDirectory() , unless I'm wrong.

Is it really changing application's behavior on non-OSX system ?
I did not know; because you feed it an array I assumed it was escaped by Doctrine
dont you want to ```make install``` in $(DESTDIR) ?
you need to update the phpdoc for this
expiry time should be configurable?
What is this needed for? Isn't this already done by the legacy kernel?
except what?
Try and add an example of a crazy name and how it's encoded, e.g. like the one we had on the whiteboard.

Maybe something like `0_foo+0x0x#-$__`.

We should also try and add a unit test that checks this encoding function, because it's too important.

Check `easybuild.test.filetools.py` for that. If you can't figure it out, let me know, but it should be doable I think (see how `convertName` is being unit tested).
Two empty line before class definition
cp2k has the same problem.
maybe we should add an option to download an svn revision and use this as a source
see internal ticket #317
For clarity, I'd prefer if you make it explicit what you're doing and not one-line this; i.e.

```
// make line-endings consistent
actual = actual.replace(...)
expected = expected.replace(...)

try {
  actual.should.equal(expected);
} catch (error) {
  ...
}
```

Notice how the replacement is also moved out of the try block so as to ensure the error caught is from should.js. I also believe you can use `.equal` instead of `.eql` (this was my own fault), as you're comparing strings.
My editor messed around that. Removed spaces.
Nuke this comment.
should be in numpy (in a wrapper), this Cython function would be more "low-level":
Python => Cython => C with clear interface/abstraction
Yes, Spotify is such a special little flower that it requires both the https and the changed prefix.
also you don't "throw" `NoMethodError`... you raise it! :trollface:
Because it was done like this in ladspa :)

I think that the reason is that plugins are loaded at liq's startup, even before the script is loaded!
It seems like rubygems does provide a gem() method. `irb` and then method(:gem).source_location
So we currently get the following subject: 

Firefox Nightly 20120515030518 mac en-US: mozilla-central_l10n finished

Seeing the status at the end makes it hard to spot and we should move it into the front of the subject. Also I don't see a reason why to include 'Nightly' because the version we directly see in the job title. Also I would reorder the items a bit to move more important information to the front.

So that we get a subject like:

[finished] mozilla-central_l10n: Firefox mac en-US (20120515030518)
i merged the other pull request. please clean this up against latest master.
Added this method so that routes file churns out something like this,

![Better Routes File](https://www.evernote.com/shard/s92/sh/42ca2bf8-0ee2-4064-b112-3ed3550bd021/2d8fd96a9a78ce659693406a3d657dcf/res/c402ae90-532c-4cb2-8580-cc740b024422/skitch.png)

And not like this one before,

![Bad Routes File](https://www.evernote.com/shard/s92/sh/fcc6b622-af24-48be-b8bc-cc4b6e560605/6aacfae9f4a8dde2ed5814fa55ee12d2/res/551759ff-87f6-46ee-b043-7c5275f0ba4e/skitch.png)
Change S_DRAFT to S_UNASSIGNED
Line 966 should be: propPath = field.split(".");
Filtering was broken for me till I fixed this.
какое минимальное количество параметров у данного конструктора?
почему тут все указатели?
I think there's one more step missing here. I think git tag will only create the tag in the local repository on the build machine, so you'd need to follow this up with a "git push --tags" to push the new tag back to the remote repository, right?
There isn't now, but we could add an option do to so.  Probably better to use an ignore by file extension declaration.
This doesn't perma-fail?
This curries function arguments and is used to simplify a few patterns in `$.fn.breakpoint(...)`. Here's an example:

```javascript
function f(a, b, c) {
    console.log(a, b, c);
}

f(1, 2, 3);
// output: 1, 2, 3

var g = partial(f, 4, 5);
g(6, 7, 8);
// output: 4, 5, 6
// note that the args 7 and 8 were ignored, because 6 and 7 were "curried" in as the first two arguments to f(...).
```
The notifications hash is only manipulated by this class and this class doesn't put nulls in there. Because of this the comment does match: a notification can be considered to exist if notifications.contains(id).
Not quite sure why loginId would have this properties property.
Fair enough. Given that it's supported in IE9+, we could start using it elsewhere as well.
Again here, I don't think this should be going back to disk to get the list of modules on every request.
This function is publicly exposed, so shouldn't have the `@api private` or the underscore in its name.
The list of valid escape sequence is fairly short (§ 1.3.6 in the spec). Wouldn't it be possible to highlight only the valid ones?
You can also do `behaviors +:= newBehavior`. That's the same as `behaviors = behaviors push newBehavior` (since `+:` is the same as `push`), but the advantage is that you can't forget the assignment. Me personally, I'm on the fence here, so would be happy either way. But the more I use the operators with built-in assignment, the more I realize that they're quite nice when used with immutable collections, since you can't "forget" the reassignment.
Any reason you aren't using super? `super(InvalidCertificateException, self).__init__()`
I don't think this decorator is needed at all. See my notes in spree/spree/#1764.
Context I included because the parent class had it, but in our usage since we're always assigning it anyway I think it's safe to remove. The logger is used by the parent class in methods we're not overriding so we have to keep it.
sws_scale "Returns: the height of the output slice".

So in that case we should break the process by throwing an exception.
BOOST_THROW_EXCEPTION( exception::Failed() );
camelcase :D
You can do that, but "*/*" means they'll accept anything, if they wouldn't accept anything they wouldn't send that. In 3.x there's also:

```js
res.format({
  json: function(){

  },

  html: function(){
    
  }
})
```

which will respond with 406 not acceptable if it really doesn't match
В этом месте логика неправильная: замена ячейки ДНК происходит только в случае, если генератор выдает число, которого еще нет в словаре. Но ведь никто не гарантирует, что на выходе генератора находятся уникальные числа для каждой итерации.
Собственно, как и не понимаю, зачем нам нужна переменная len
Все понятно, спасибо
Выносить такие числа в константу — всегда хорошая практика, даже если этого не требовалось в постановке задачи
@khudenkon ну с float я поторопился конечно, есть вероятность что таки да, цикл уйдет в бесконечность

кстати, интересный момент: компилятор xcode игнорирует бесконечные циклы, при этом радостно рапортует, что build sucsess и даже не намекает на ошибку
Хм.. Пропустил грубый недочет.. Учту в будущем
The only other way would be to call one of the VideoCore programs and check for a good return code. Would that be enough?
I don't think we should hard code the version in here. Can you please update this to follow the same process as we use when updating the version on manifest.json (https://github.com/blackberry-webworks/Ripple-UI/blob/cce755e8b7afdcb30b2473ee9a1d090fa89b994d/build/build/chromium.js#L43-44). This way we only need to update the version in one place (our package.json file).
I'd prefer the formatter to follow the naming conventions of the other formatters. This should be `JsonFormatter`.

The Gherkin formatter constructor could be known as `GherkinJsonFormatter` in Cucumber.js (and its instances would be `gherkinJsonFormatter`). I think it would clarify things.

```javascript
var GherkinJsonFormatter = require('gherkin/lib/gherkin/formatter/json_formatter');
var gherkinJsonFormatter = new GherkinJsonFormatter(process.stdout);
formatter = Cucumber.Listener.JsonFormatter(jsonFormatter);
```
this.log returns undefined.  A throw is a better idea.
Ok, Im gonna add notifications again and this PR will be ready for landing right?
This is going to result in unnecessary delays, since we're already dispatching to the global GCD queue. Maybe it'd make more sense for this method to accept a GCD queue on which `dispatch_after` should be invoked.
@Coneko GCD queues aren't guaranteed to be pinned to a specific thread. It may change between the execution of a given block, so any thread-local storage is usually a bad idea.
Yeah, I'd like to hold off.
I was even thinking on a larger scale - implementing everything of the
input layer (and maybe in the more distant future, everything of our C glue
code) via LuaJIT+FFI.

For this issue, I would consider it being unnecessary. It's hard to
understand if only used for this single thing.
[comment] What's the difference between that and:

```objc
enum {
    ZincConnectionTypeAny,
    ZincConnectionTypeWiFiOnly,
} ZincConnectionType;
```

?
Isn't x assumed to be real?
Should we not expose the object functionality here (but leave it in for development purposes)? I can't remember what we decided to say.
[cp.deepcopy(r.info['projs']) for r in raw)]
you will have a problem if key is a tuple

I would just do:

key = np.atleast_1d(key)
epochs._data = self._data[key]
It should probably be create_index. I probably wasn't thinking about it.

Also, "doctype" should get changed to "mapping_type" since that's the name we're using now.
I'm using the maximum possible cache lifetime here because, as far as I know, users can't update published pages.
What if the body is application/json?  text/xml?  This is saying that for an application to have CSRF enabled, it *cannot* accept anything but multipart/form-data or x-application-urlencoded submissions, otherwise it will fail to parse them.  Many applications support both REST APIs with JSON, and web requests.  Have you tested this with a JSON POST?

CSRF attacks are able to exploit x-application-urlencoded, multipart/form-data and text/plain, since these are the three valid enctypes that browsers will allow.  To submit anything else via a browser is only possible using AJAX, which as explained above, implies an XSS vulnerability to exploit, which means game over for any CSRF protection.

Hence, this must filter those content types, and only those content types, and leave everything else alone.

With text/plain, it's a bit of a weird one, but it's very important from a security perspective that we filter it.  In that case, I would suggest checking for the token in the query string, and documenting the fact.

Also, we probably don't need to filter the body if there's no session, since there's nothing to protect.  Perhaps we should add an option to say whether things should be filtered if there's a session or not (this would help in the case that other things, eg SSO cookies, could be identifying a user).
You can use Q.delay (just to avoid mixing in 2 types of async implementations)

return Q.delay(delayBeforeRetries).then(retryAction);
I think that this could be achieved with ``orm['shop.Product'].objects.update(sku=F('id'))`` which would be more efficient than a single update for each row.
I like what you're doing here, but I think we can explain what this `$attributes` variable is even more. Specifically, `$attributes` is an array of all of the tag details for each `acme_mailer.transport` tag that the service has (because a service may be tagged multiple times with the same tag). With a few more details, I think we'll have a better idea of why we have 2 foreach nested statements here.

Also, be sure to break your line after the first word that crosses the 72nd character :)
This should be `...,`
You should indent the 2 above lines with one space
已调
Hey @filmaj, so are you expecting values with gravity from native now?
this._button.reset();
Move these two into one `describe 'toKey'` block
Put the statements on a new line, like so

    if (no) {
        do_whatever;
    }
Оно ж и так `CaseSensitive` по дефолту.
auto же.
Πως γίνετε αυτό αφού είχα το kostas_test_branch?

On 11/10/12 00:27, Spyros wrote:
>
> In admin/controller/class.HackademicBackendController.php:
>
> > @@ -40,15 +40,21 @@ public function __construct() {
> >  		HackademicController::__construct();
> >  		// Login Controller, do nothing
> >  		if (get_class($this) == 'LoginController');
> > -		elseif (!$this->isLoggedIn() || (!($this->isAdmin() || ($this->isTeacher())))) {
> > +		elseif (!$this->isLoggedIn()) {
>
> Γι αυτό δεν έχεις κάνει ήδη ένα pull request και το έκανα merge??
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/Hackademic/hackademic/pull/25/files#r1812210>.
>


-- 
*Petros Andreou* UnderGraduate at Technological Educational Institute of 
Larissa. Department of Computer Science and Telecommunications 
www.petrosandreou.com <http://www.petrosandreou.com>
There seem to be "is online" and "is offline" hardcoded too in this line. Might want to fix that too :)
Is this right? Don't make "/sdcard/mfmaps/_themes/theme.xml" the path for Theme or Mainthem fix?
Sass will treat a single value as a list with one element in an `@each` loop.

```scss
@each $foo in 2px { div {width: $foo; }}
```

outputs:

```css
div { width: 2px; }
```
Call Statistics.sum(column);
These string properties should be `copy`, or else a conforming class could accidentally use a mutable string and expect it to work.
Don't think that's needed. You are already in a if block for volume_support.
Use Test with expected IllegalArgumentException annotation?
Either one is fine, I just thought a little note for devs would be nice. The error Django throws regarding not having `TWITTER_CONSUMER_KEY ` set is fairly clear, but it takes a little digging to figure out how you're setting that variable.

Which would you prefer this be? `secrets.py` or `settings_local.py`?
Overly complex statement, needs split. (Generate a list, then get its average)
w.r.t. not being able to access the axes's log base, we are assuming base 10 throughout this part of the code, and we have always done so before.  We could always look to future PRs to address the handling of arbitrary log bases.  I see this more as a good bug fix to an outstanding issue.

I guess it would be smart, though, for future developers, to somehow comment the spots that are assuming base 10 so that they know to change it if/when we extend the interface in the future to accept arbitary log bases.
Agreed.  Created issue #1386
Where is this new image? I don't see it in this PR.
I hope this features stays stable. Nice job of testing for this.
Why is *request* declared here and not with them middleware that makes use of it?
Well CloudService has lot of things that are common between different test harnesses (like the mock channel), so if we did that we need to move other parts as well.
Да, действительно, не помню уже почему. Вроде должно работать, попробую раскомментировать.
Ура )
wrap those event delegations into sub methods making the tests better readable letting only here creation methods and making the tests easier to read.
Whoops! :) Good catch. :+1:
As far as I know, this should not be a problem.  The entire table is only rewritten if you add a not-null constraint or change the type of an existing column.
Why does this request need to be synchronous?
we weren't using initTuid anywhere anymore
@bp323 I think it's more efficient to use $newaddcontentContainerSelectedItemsContainer because it's already selected, and only has the one child element to select, rather than searching for a new id.
Does this sound right?
Why are the parameters order for addQuestion different from updateQuestion?
That'll break if more than one editor is used. I guess you tried to fix the "call method on null" error? Needs to be excluded from merge, I've fixed that differently in master.
iz not :(
I wanted to say "typing error" ;)
Are you sure ``$max`` has the correct type as "integer" is not a sub-type of "array"?
The assignment to ``$localeInformation`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
Pleas try to maintain the original formatting
if 'change' event is not implemented for basicSwitch, this will fail due to the custom events not being supported at the moment
You can remove this line, i don't think we are using attribute_normalizer  anywhere.
@fabpot should we rename them to ``localized_currency`` and so on ? It would be more readable
Yes i understand but the django behavior with empty lines in template is a real pain so, the result email is more important than the over-readability of the source code (which will be readable anyway)
Tá errado isso!
I'd rename this to proxy now that it's clear what it's doing
Prefix those variables with `TWITTER_` please.
Dot at the end. *a* before *case-insensitive manner*.
Sorry, I noticed that we are using url elsewhere. (I edited my comment on GitHub, you might not noticed it.)
Probably better to use true and false values? Especially if you pass this through JSON?
Hah, I had to change this because I forgot the password. It's now "test".
this part was already in script file, only reordered, so diff looks very colored :D
This 7 here is supposed to be the index where 'level' is stored in characters table, are you sure it is 7?
Don't hate me, but codestyle should be applyied
Filesystem? Kind of confusing since I thought this is about supported NoSQL stores
Is there any reason don't use this ?

https://github.com/scala/scala/blob/v2.9.2/src/library/scala/math/Ordering.scala#L147-L149
Whitespace around operator, many more in this file.
writeFile won't create the directories, right? So I don't think this can work? Unless you create by hand all the directories first :-)
See f22401af4193
Nice catch. That's a subtle one.
I cannot at the moment. I am not familiar with compctl. I will have to read up on it. You can always ask in #zsh on FreeNode.
above shadow() call was copied from here :)
The g0 and g1 services seem to be implemented differently.
Did we modify this class?  There's a lot of magic constants and other code here that make me want to isolate this.
Could add (LHS) and (RHS) in brackets to the comments for extra clarity, as first and second are used elsewhere in the script.
Here again, jslint would complain about the space between bind( and 'mousedown'
Or perhaps `UIDSpec`?
can this be a Function or dedicated interface (ie non-groovy) ?  and/or do we type-coerce correctly?
(if required to be a closure for now i think that's fine, we can address closure uses within specific policies at a later time, i think.
same for closures used elsewhere, eg follow-the-sun)
This doesn't actually check that the count of search results is greater, it assumes the database has stuff in it that makes it greater. It should at least verify that it is greater (somehow). Perhaps this should be fixed in a latter pull request instead of redoing this one.
There is no guarantee that there will be 0 collisions. Bloomfilters are probabilistic data structures.. It is *highly unlikely* that you will get a collision with your configuration, but *it is* possible -- which makes for some great heisen failures in your test suite. :)
Yes, see OSGi Enterprise Spec section 132.5.6: 'Whitespace around the list and around commas must be trimmed."
I think we'll have to do something else with this cookbook instead of runit
Not needed, checkNotModified does it for you
Shouldn't it return an ProfilePage() object here?
Do you have an idea how to allow people to use a custom (subclass) of the requirements in the check scripts? DI needed here, but this would probabily go beyond the scope of it.
Maybe we should just ignore this use case. There is one unsupported thing anyway: Users cannot delete individual requirements in their projects (and I don't know how it should be possible as one cannot access an requirement by name or something).

Overriding config.php and check.php is still questionable. It means that these files are reserved for symfony and cannot be used for a project for any other purpose.
please remove this debugger line
how about changing to something like this instead:

  except self.config.db_connection_context.conditional_exceptions, x
      self.config.db_connection_context.act_on_exception(x)

That way all the postgres specific code gets consolidated into the postgres external module and this module remains generic.
Why are you not adding the events to |this| and redirect them into the handleEvent method of the object like the others? It will avoid the need to use bind.
Why did you remove this? It's the part of a weapon holster code.
Why did you re-add this? According to the documentation, calling ..() will cause the machinery to be removed from the processing list, causing it to be processed never again.
Исправим на Runtime. Вы так и не сказали, если я словил исключения при method.invoke, после того что я его закину в буффер, что должна вернуть функция? Прокинуть исключение дальше или что-то еще?
@christianv does the calcentral.js module still need to fire first? if so, relying upon require_tree and calcentral sitting high up on the directory tree to cause require_tree to load it first makes me queasy. Here's what sprockets doc said about require_tree:

- The require_tree Directive
-- require_tree path works like require_directory, but operates recursively to require all files in all subdirectories of the directory specified by path.
Yes. Although two are displayed on the screen, they are both generated from the image that is uploaded (i.e., there are not two different images uploaded) so I am assuming that we can just look at one of them to determine whether it has been updated or not. Does that seem reasonable?