labofsahil/github-event-dataset-2012 huggingface dataset:
Unfortunately, I chose the name of the setting that does not fit in the table. Should I:
1) change the length of the lines in the file for more than 80 characters,
2) change the simple table to grid table,
3) choose shorter name (````kott.url_normalizer.map_char```` will fit; Any other propositions?)
oh, my bad. it still looks fishy. are you sure? it's inheriting from TestCase and doesn't have any assertions or anything there.
This should be a regular service. So use share instead of protect and return an instance of ResponseListener.
Is this commented out line necessary?
This would be a change to existing behaviour as well - since we'd start rejecting scan results and change events that contained excess attributes. Do you see any problems with that?
not a command.
typo? I'm not sure what the intent is here...
Per discussion in the ticket, this is in fact the behavior we agreed on.
This row should have its text centered.
Actually it can happen _(can be traced back to `load_and_render`)_, so a check is in place here.
Error made unconditional, $user is passed down and is used if not null.
page_footer displays template, everything else is extra. If you need to run cron/exit handler, factor those out in separate functions and call them appropriately.

Also, page_footer does a lot of setup for template rendering. If you are not going to render the template it's pointless to do that setup.
I guess its an example variable definition for config.h.in, right?
> CMake is a family of tools designed to build, test and package software.

Its more likely to be used in deployment process, not in development. So AUX_SOURCE_DIRECTORY isn't a bad option.
I like 3, but maybe call it `enableOutput`.
I don't thinks `cfg.id` contains what you think it does.
Is `existsSync()` being called during runtime?  That might have bad performance implications.
Что-то я подумал, а почему просто в sql не писать NOW(), не придется вычислять дату
Here instead for the link to bitstream I added tracking event to count downloads and views in GA.
This line was giving a segmentation fault.Tried to correct it using a .ptr()
suggest rename ```k``` to something more meaningful -- it's not a temporary iterator but rather is the ```numberOfLoadedDrugConcepts``` (something like that)

could also write as
 ```numberOfLoadedDrugConcepts++;``` 
of course
I'm still having doubts about the worth of this, in place of a simple "try.. finally" block.
@rhattersley put me up to this, but having done it, I'm worried it adds very little in this case, and is considerably less transparent.

It doesn't even simplify the usage code that much : Compare
```
with Fakeup_Gribapi_Context():
    <stuff>...
```
with
```
try:
    orig_gribapi_module = iris.fileformats.grib.gribapi
    iris.fileformats.grib.gribapi = Fake_GribApi()
    <stuff>...
finally:
    iris.fileformats.grib.gribapi = orig_gribapi_module
```
Same comment as in the copy of this code in modes.txt (messed up indent, probably caused by tabs).
missing EXPORT?
On Thu, Aug 2, 2012 at 5:59 PM, Łukasz Langa
<reply@reply.github.com>
wrote:
>> @@ -124,8 +124,10 @@ def export_csv(self, query=None):
>>                  dev.created or '' if 'history' in show_tabs else '',
>
> Instead of using `or ''` all over the place you should simply replace line 64 in src/ralph/util/csvutil.py with:
>
> ```
> self.writer.writerow([(s or '').encode("utf-8") for s in row])
> ```

This code is not part of this pull request.


-- 
Radomir Dopieralski, http://sheep.art.pl
Thanks!

On May 1, 2012, at 5:59 PM, Paul Miller
<reply@reply.github.com>
wrote:

>> @@ -29,7 +29,7 @@ module.exports = class SourceFile
>>       moduleName = JSON.stringify(
>>         @path
>>           .replace(new RegExp('\\\\', 'g'), '/')
>> -          .replace(/^app\//, '')
>> +          .replace(/^app\/|^(\.+\/)+/g, '')
>
> this one is a bit tricky, i'll hack around tomorrow to find great solution.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/brunch/brunch/pull/264/files#r758873
Can this become ``$statusLine``?
This is using spaces as indents, please change to tabs
Why not simply passing ˙jQuery.trim` to `.map()` directly?
Are you not going to define SQL functions for new distance functions?
If you prefer, I can make changes on my end and update the pull request, just tell me.
What does signature mean? You probably don't need to have a comment in the code, I'm just curious.
I'm not sure how this should work. This is a universal mathematical symbol encoded as an HTML character entity. Ditto for the `&raquo;` below.

@jsocol : Does it make sense for those to go through gettext?
i <3 the simplification of the template code
I feel like these should be pretty guaranteed to be zero. I'd probably tend to do something like

```python
assert not models.SimpleEmail.objects.exists()
```

to verify the test environment (i.e. that there aren't any records).
The stacktrace is useful if the problem is in the formula itself (i.e., somewhere in the Ruby code). (And the e.inspect gives the exception class, which is useful to know.)

The basic idea is that if something is failing, more information is better than less. (And if it's not logged, the whole error-pipe is kind of pointless.)
Use headline style "Global Options"
contributute
no varargs in beanshell?
中英文之间暂时不要空格吧，将来xeCJK可以自动调整空格。
In these tests where the URI string is expected to be the same on the round trip, can we put the string in a variable and reference it on both lines? it makes it clearer at a glance that the test is expecting the exact same thing back.
This should be in Config/defaults.json
This could just be `-sequentialMatches`.

But actually I think it'd be nice to share code: there are three very similar calls to unshift().  How about wrapping them up in a utility function that's local to stringMatch()?
Good catch. The old command APIs were using "commandStr" for the id, I searched and fixed them all.

-----Original Message-----
From: Narciso Jaramillo [mailto:reply@reply.github.com] 
Sent: Wednesday, May 23, 2012 10:55 AM
To: Ty Voliter
Subject: Re: [brackets] Menu, MenuItem, key bindings, and Command API (review only) (#927)

> @@ -87,10 +131,58 @@ define(function (require, exports, module) {
>          _enabled = value;
>      }
>  
> -    
> +    /**
> +     * Add some key bindings to _keymap.
> +     *
> +     * @param {string} commandStr

Is this the command ID? If so, it should be `commandID`.

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/927/files#r869667
Done. Should I add that is dispatches a `workingSetSort` event to the comment at the top of `DocumentManager`?
I don't see where ``editor`` would be passed as an argument. Is this necessary?
If command is passed into the constructor a few lines above here, why do you also need to call setCommand()?
Unfortunately, RequireJS i18n isn't smart enough to pick sibling translations. For example

* User locale is "fr-US" (french language UI with US regional formatting)
* /nls/fr/strings.js does not exist
* /nls/fr-FR/strings.js does exist

In this situation, RequireJS would see that "fr-US" and "fr" don't exist and fall through to root/strings.js and use english instead. Not good.
I'm pretty sure it's just bash quoting. If I do `foo="~/Desktop"` then `echo $foo` shows `~/Desktop`, whereas `foo=~/Desktop` actually expands it.
You should broadcast before join on every iteration.  There is no guarantee the thread in proper place to see shutdown bool or signal.  There might be a guarantee if you moved the l(threads_lock) object to precede setting both shutdown and sending the broadcast.  I would do both, this code does not need to be high performance.  Safety first.
Please change `m` to something like `vertex`, assuming I'm reading this correctly.
I'm interested why it's bad? I think the toolset of a lot of devs includes rbenv and it could be helpful not to think about a untracked file in your git workflow.
Thx
Please line these guys up and have one constraint per line.
`open-stdin!`?
Options are the options passed to the validator. Like min/man if you were doing length validation. Don't think required would be good to add there. Originally I had this as doc_attrs and decided that it didn't seem appropriate to pass that around. Could expand required to a different set of options though?
was not sure about being strict on value: if someone enables it by $bulkDelete = 1; it would work… 
perhaps I should change that
Be careful. Then you have to implement all cleaning/checking methods. I would still extend from UserCreationForm just check in the code which methods access database and override them with our own implementation.
This was copy paste from the previous version not done by me; will change.
wlan slovenija copyright? Or we just remove this?
> But if you would put class on this, as it was done before (form_textbox), you could have all uls child of .form_textbox be inline, no?

No, definetly not. Or I don't understand what you mean. If I have a list like before
`<ul>
<li class="form_label"></li>
<li class="form_field"></li>
<li class="form_label"></li>
<li class="form_field"></li>
</ul>`
and make all `li` inline they will appear next to each other, but they should be each in one line. A standard way and better I think is to have field and label in one `li` and no classes is needed. I only add a class to radio buttons which are special, I don't see anything wrong with that.
And if we are here. Can you just put the template into its default location and get rid of this argument?
I read that in newer versions of jQuery prop is used for DOM element attributes, but I can use attr if you like. 

I would use underscores like "open_in_google_link" because it is more readable then dashes if you agree.
Bad habit I need to break!
add `wrapper.classList.add( "popcorn-fade" )`
add a new line above
Yes. In this case ANE behaves as simple SWC. All of my AIR-mobile projects have SWF packaging. Or you're mean that will be cool to check that project depends airglobal.swc?
Yes I now but a just created the v0.1 tag so nobody used It :)
This is a regression.
I would probably recommend using `alias_method` instead of `alias`.
nm, this is provided by another RPM.
QQ. Are we making sure the id is accessible by the user before doing this call?
It is very, very strange to continue to use an object after calling its Dispose() method.  Makes the logic difficult to reason about.

Also, Wait()? :)
Brackets >.>
I wonder whether these kind of regexp patterns should be defined in module-level constants? I guess it would make the code harder to read though.
Maybe instead:

```
_orig_logger_cls = logging.setLoggerClass(AstropyLogger)
try:
    log = logging.getLogger('astropy')
    log.set_defaults()
finally:
    logging.setLoggerClass(_orig_logger_cls)
    del _orig_logger_cls
```

As long as Astropy will only have a single logger instance (which I'm fine with) there's no reason to leave `AstropyLogger` as the default logger class once that instance has been created.

Or is it intentional that we send all logging in some software through the Astropy logger?  I think that could potentially cause problems, and shouldn't be the default.  For that to work you'd also have to ensure that astropy is imported before any other module that uses the logging system.
Aiight. I'll throw that in with the stop_and_wait change, lulz and all
As I said, treat me as a newb, so ... what you mean by Windows-only?

I read through the boost docs and found no other way to get the current path and filename to the stale file. We have a condition here, that causes problems and I'm only trying to fix it ...
Still no need for a function...
You could add (#ifndef AI_ADDRCONFIG #define AI_ADDRCONFIG 0) to compat.h, it has other such special cases.
Personally I prefer keeping a blank line after the topmost docblock. Makes it a tad easier to spot where the docblock ends and code starts.
Also we should consider trimming down the topmost block a bit for all files. eg. The statements for copyright, license are duplicated.
Try `/:\/\/|^(javascript|mailto|tel|sms):|\#/i`
Agreed, I too was going to ask for suggestions for a more appropriate name.
Can have default content as:
```
Ext.each(data, function(key) {
    if (['mnt', 'mns'].indexOf(key) < 0) {
        result[key + '_value'] = data[key];
        result[key + '_label'] = OpenLayers.i18n(key);
    }
});
```
A viewer can theoretically include multiple instances of the same plugin. With the above adding multiple instances of the `MapOpacitySlider` may add to the DOM multiple DOM elements with the same id. Can't you create an `Ext.Element` object and just give `renderTo` a reference to that object?
Hmm... Yeah, makes sense, but I don't like that either... Also, modifying the `MemcacheCache` adapter would break BC... :(
Yeah, you raise a good point. I was just thinking about this now, haha.
Probably - it was likely a property at one point and I missed changing it over.
not really, the mapping still happens in the RdfMapper implementation. but we create the same property twice. i check now if there is already one.
>`Path.GetTempFileName()`

:+1:
Wait, darn, maybe this should've been dest not src.  Doh.

-[Unknown]
We should add that as an include path on Windows and just include "zlib.h" so that we get the system zlib on systems that have one.
Just occurred to me that this is more-or-less equivalent to `eval(input, self.shell.user_ns, local_ns)` (with the exception that it'll raise a NameError instead of a KeyError if the key cannot be found).

But I think I like the extended try/except block better.  Certainly it's faster to execute.
But wait, unless I am misunderstanding something, I think this property has the same problems as before:

1. Each handler instance will have its own Environment.
2. That environment is recreated *everytime* the property is accessed.

I think the environment creation logic needs to be moved to the Notebook Application object, and the handlers would then access it as `self.application.jinja2_env`.  Does this make sense?  I want to make sure that one and only one of these environments is created per notebook process.
can you discuss w/ vcloud, cloudstack testing guys?  ex. @andreisavu @andreaturli @richarddowner @digitalsanctum @grkvlt  I know we need to have a nice plan for admin vs api tests, but there's not enough discussion, yet to make a decision.  I'd ping folks until there's actionable discussion here, and in the mean time, just use test group annotations for lack of decision.

https://groups.google.com/forum/?fromgroups=#!topic/jclouds-dev/o-e_jE9rXe4
you are right I forgot to update the docs, thanks jimmy
This is a shortcut for if label == True:
Rik mentioned this elsewhere, but I agree, just remove the whitespace in the CSV file and you won't need to add the space here.
The `os.path.join` is a subset of the `path` variable on line 84. Could you add an intermediate variable earlier to keep them in sync?
I had lots of cache issues while running tests, I can try again without it. This one might not be strictly necessary either. But since it is called infrequently (during editing documents) and important to get right, it might not hurt to leave it.
BTW, good call on switching all of this to redis.
what does it mean to write to stderr when an app is running as a daemon?  It would be better to see this written to logging instead.  Since the only place that this class is instantiated is in the App class, and that class has a logger available to it, you could pass the logger to this class via a constructor.
What is the purpose of introducing a new public API for reading configuration?
This line was in the file as tab, not spaces. Fixed it to spaces now.
Ah! Missed the reversal, thanks.
hmm, nvm
It was my first idea but moving this to ``FormType`` will lead us to situation where placeholder is available also in checkboxes and its passed to view as attribute in selects. So maybe its better to leave it in ``TextType``? 
What do you think @bschussek ?
This class does not belong to the EventDispatcher component. It has a hard dependency on the HttpKernel component: it is about integrating the profiler (provided by the HttpKernel component) with the dispatcher and it relies on events dispatched by the HttpKernel class.
My mistake fixed, the type was meant for something else to implement photos to be distinct from user photos.
yep.. your right.. apologies.
Before you ship this, run through and see if you can sub in `build_stubbed` for `create` where possible. Makes a 5-10x speed difference.
I'm going to go with scheduler.
测试回复评论的评论，另外，建议三国杀也放到 github 上进行 design review
there is conflict from this line
running /ac will tell you to run /ac? I am confused on this.
Can we get a better description of the functionality?

For example, "When specified, convert the input image to linear assuming this as the input colorspace".
(Not sure if this is an appropriate description, please clarify to match intent).
Default is 1, the same as FeatureArtist, Patches and Collections. The grouping in ```Axes.draw()``` means that they are drawn prior to custom artists.
would be helpful if we turned the above 3 lines into a little "new" helper function to be used here and internally by `deserialize_alloc_set`
No worries mate :) - You'll soon get the hang of it :)
``:py:meth:`menus.base.Menu.get_nodes` ``
to localize the tooltips instead of .html(xxxx) you can try .attr("title", xxxx)
I see that the comment rightly says that this should be setAllowNull(false) but I don't understand the rest of that comment. Did you run into some problem when this was set to false?
anonymous function here
leading # + typo: s/Paramères/Paramètres/
`turnOnFlightMode`
@alivedise I didn't consider the race condition, so what you said is correct.

Note that "Music" string is already localized so we don't have to call changeTitleText() again while Music app is starting.
So I decided to keep the original calling sequence and try to see if title exists or not, if title doesn't exists, that should be the first time launch of Music app,  so we can just ignore changeTitleText() and there will be no "undefined" title.
And if title does exist, the title should be the localized string of "Music", it will still show the correct title even the new title is same as the old one.

I have update this patch, please review this again, thanks.
months are numbered from 0 to 11 and days from 1  to 31
I think it would be confusing to have a notification that says "You have new voicemails" after you've already listened to them :)
nit: Add some comments about why this works instead of using localized event handler.
Yeah. ES docs say "periodically".
just some sample data, key is optional for some fields
Each parser should take tracer in case it need to verbose trace something.
This reminds me of the time I designed my own board game.   It was a cross of Mega Man and Monopoly.   The goal was a cross between acquiring as much stuff as possible and destroying as much stuff as you could.
container有含义么？和$this感觉有点重复
Why was `#optimize` removed here? In general I would recommend calling `#optimize` on every relation before you store it inside another object's state. If the relation is optimized it will just return self, otherwise it will simplify it's internal structure; and that's probably what you want to store.
Whenever keeping options, it must be cloned as the object can change reused) outside.
Like in comments from earlier diffs, why do you do a `next` here? Calling `ea.generate()` doesn't seem to actually start the app, so how does it get started?
What is the replacement ?
This is clearly pretty broken. You can't just treat rst source as HTML.
This will return a URL of the jar file the current code is running from.  Since we're packaging the `equipment.item` files inside the same package jar as this bootjob, this works perfectly.
like `ls()`'s version in ShellJS, it'd be nice if the result was an array of directories. it's more useful in JS land, and most likely people would be converting it to an array anyway (e.g. as you do in the tests)
Better yet, put them in astropy.sphinx.ext - I'm not sure how easy it is to include css files through extensions, but it would definitely be useful to see these sorts of tweaks in the astropy core package's docs.
Yes. I was thinking about how to say this clearly given the ambiguity between `subpixels` (e.g., 5) and the number of "subpixels" in a pixel (e.g., 25). It scales with the number of subpixels in a pixel, which is `subpixels ** 2`. I think you're right though, just saying `subpixels ** 2` makes it clear we're referring to the parameter `subpixels`.
even better

    client.virt.storage
    client.virt.network
    client.virt.cpu

And so on and so forth...
I suspect that it would be easier to make the default codebases value `{'' : { } }`.  Then there's no need to special-case `if codebases` (or `if codebases is not None` as @jaredgrubb suggests) all over the place.  As far as I can tell, this will lead to identical behavior -- we're treating the no-codebase case as equivalent to a single codebase named `''`.  There is some trickiness with argument-checking in `SingleBranchScheduler`, but that can certainly be worked out.
branch is listed twice here (and was in the original, too)
And, incidentally, MySQL counts three characters per byte, so varchar(128) is about 40 characters, ascii or not.
"Bearbeiten"?
Maybe clarify a bit?

you may commit the `composer.lock` file to improve working in a team, too. But it will not ...
is cleaning actually tested here?
> The function definition must precede the first call to it. There is no method of "declaring" the function, as, for example, in C.

Good catch! Yep, this is a mistake due to refactoring ;-)

> I'd prefer 'abort' instead of 'aborting', but that's a minor point.

Will change.
It was intentional, I was trying to keep things close to where they are used. 

It made sense to me, but 1) I'm no bash expert, and 2) maybe it made sense to me only :-)
could you please provide an example? i'm not that expert in 10-fold nested C preprocessor defines...
`padded` should be out of `%small`
Why the string 'block' here ?

&lt;p id="p16">...&lt;/p> or &lt;p id="paragraph-16">...&lt;/p> reads better IMHO
OK, will try to find something not stupid to not forget to update the macro when the structure change.
Oups, I was just a bit generous.
This should just go in libmaple_types.h. Note that with the proposed [exti_attach_callback()](https://github.com/leaflabs/libmaple/pull/53/files#r1476943), this should only need to contain the `.instance` and `.classFunction` fields, AFAICT.
Same as @prefix; use the :default feature of the 'config' method.

```config :value_split, :validate => :string, :default => "="```
put all 3rd party requires in the 'register' method.
essa chamada estilo script é necessária msm? ele não chama automaticamente essa função test_*?
For anyone interested in why this block exists:

If you have several frontNames and 'gaps' in the hierarchy, you may erroneously match a module that does not exist.  In this case, you actually want the longest possible VALID match.  So, we need to then back off the frontName segments until we hit a valid frontName.

For example, this is the Mage_Adminhtml route frontName
```
admin
```

But if I add a route for My_SuperSpiffyModule and use this frontName
```
admin/system/super-spiffy
```

Then we have a situation where a partial match of my frontName would hide the system controller in Mage_Adminhtml.  Since the viable frontName at this point is
```
admin/system
```

And that is an invalid frontName, we need to back segments off the frontName, adding them back on the path stack, until we get a valid frontName or run out of segments.
why not ?

```js
if (data)
  child.textContent = data;
```
recorverd -> recovered
Would it make more sense to push this call down into user.addressInfo?
that's a fantastic idea.
rats.  yes, thanks.  fixed.
How about the name 'check-sdk' and the description 'Ensure that the Addon SDK is active'?
Good point. I'd prefer `Redis` and `redisClient` or `db`.
^^ Still a tab
Since we are just using doctype we can leave the w3.org stuff away.
If returning :undef and returning nil are considered equivalent, then yes.
@jeffweiss same comment here
Somewhere inbetween?
see fastutils, as noted above.
I agree, which is why I like them in Rails projects and other final products. In libraries I try to avoid them, because it ties you into one ecosystem. E.g., by using ActiveSupport you cannot use any of the other core extension libraries in your project anymore.
Although we construct the URL and FileName ourselves, maybe we could use String::Quote function just to be sure. 

Additionally, I know that we've been using these -s -S ... parameters for a long time, but from the new point of view, it's better to use --location instead of -L just to have a better-readable/understandable source code.
I'd put it in the writer, myself -- the formatter is giving us a line of input, and it's up to the writer to do something with it. Considering the stream writer could be writing a binary stream, the separator character between log lines really can be arbitrary.
Zend\Form\Element\ValidatorInterface !== Zend\Validator\ValidatorInterface ;)
Many of your methods do not have the author and since doc tags
а если в параметрах exclude_users не будет? params[:exclude_users].include?(user) вызовет ошибку
logic of `map` could just be moved to the predicate of `filter` here? Also, more `a`s...
This should be on a new line.
Yep -- fixed.
What's the diff between this and the other index.html?
Agility.js • TodoMVC
could be... i think it's a matter of taste...

anyway, we could actually remove ie.js at all, because Meteor is shipping all the stuff...

agree?
Removed in [e6d72f2].
Just a quick style fix. Can you change this to:

```javascript
  (req.headers['x-forwarded-proto'] && req.headers['x-forwarded-proto'].slice(0,5) === 'https')
```
This would mean they can place cards for free until the end of their turn. Is that the intention?
Maybe clarify what this means? Prints the DOM tree code as text in HTML format?
can node.nodes ever be null?
@anti joinista puuttuu yhtiö
Split the operation in 2 lines:

```php
$resultCache = $this->_em->getConfiguration()->getResultCacheImpl();
$profile     = $profile->setResultCacheDriver($resultCache);
```
Yeah this is what I was thinking.
override init to initialize self.bindir = None
Should be in the -with-hibernate bom
Not sure what was going on there.. works fine here on my laptop now. It was late, what can I say :confused:
Good call; I will move this earlier. Actually it should probably be as early as possible.
Why do we need 19 blank lines here?
Set boolean to dialog options, based on "dialog-modal" attribute. This code sets string to options.. modal: "false"

Like this:
modal: (angular.isDefined(attrs.dialogModal) && attrs.dialogModal !== "false")
Should this be *self._perf_hardware_ico ?
Django uses `functools.update_wrapper` to preserve the metadata about the view function when wrapping it: https://github.com/django/django/blob/1.4.2/django/contrib/admin/options.py#L364

You should probably do something similar here as well.
More context: [backbone's sync](http://backbonejs.org/#Sync) is what we're trying to support, although without the read/GET for now.
The isReady function only requires duration to set up correctly, which is available in readyState 1. 

There's a case in Firefox, in the destroy tests, where the video was in a readyState of 1 when this if-else is run. It added a listener for "loadeddata", which had already fired on the video, causing us to have a dead instance of popcorn with no time update loop.

I can bring this out into another ticket, I just did it here because the bug crippled the test suite in Firefox, and I couldn't test the changed I had made to destroy.

It's already a recommended practice to wrap your code in "canplay" listeners before trying to change something like currentTime, so this won't break anything that's already using such listeners.
I think you might need to prefix the string with ^ like above, because of some other processing we do later on the chain with error messages.

Also, if we don't allow the comma at all in a collection title, the reserved string ',,' doesn't make sense, since two commas are just as illegal as one comma. *g*
That's a good point. Maybe the thing to do is leave it as-is and we can get some more input on the workflow after more people get to play with the feature.
i think it makes sense to refactor this a bit, and maybe move this into a separate dashboard class, so we dont have to repeat our fetching?
I was unable to use any other version (due to conflict between mocha and
minitest). I took the first match from google/stackoverflow.
I am not sure I understand the previous two ```if``` statements. Is the intent to ensure that only one of serviceLocation and affinityGroup was specified? If so, the right place to enforce this constraint is in the checkParametersSpecified() function below, similar to what I currently do for https://github.com/johnnyhalife/git-azure/blob/625ac6b6808c68d4545ce4cb56ea4e2f33667bd3/src/cli/commands/init.js#L1114
Actually, it would make sense to have this baseline app include some of the real-world concepts we have found in sylfide. Such as how to configure the base-URL, and how to use it to make absolute links. There was also recently added configuration to honour X-Forwarded-For headers, that should be in general use.
Why you annotated all of those with Deprecated.
Indeed! From `/usr/include/sysexits.h`:

    #define EX_NOINPUT  66  /* cannot open input */
(If it didn't, that's a bug.)
This is purely to allow panopticon to keep track of the new `VideoEdition` model. The model itself doesn't directly store a video byte stream, but instead holds a link to a URL such as a YouTube video which we'll wrap with the accessible video player.
Para más adelante seria bueno colocar este archivo en la carpeta "logs" que está en "shared"
Use a label ID
Well, this is not what I was meaning (my fault, sorry, when I wrote it it was 2am here: I haven't been clear).
What I was suggesting is to remove constructor, $compression property, setJpegCompression setter and so on, and just have a 6th parameter for the create function.
In this parameter (that I called $saveOptions) we could specify save-specific options. One could be the jpg quality. Another could be a value to override the file format to create (eg at the moment the created image is of the same type of the original image - jpg to jpg, but we may want to create another file type - jpg to png for instance).
It is a bad habit to name variables like var1, var2... Try to give them more descriptive names
CS: space inside parenthesis needed.
What happens if $uri is empty ?
Nice idea :+1: In this case, the code should be moved to the abstract platform.
explicit SetNode(const T&)
универсальность --- это хорошо.
но тут ты проигрываешь в производительности просто в несколько раз. так не пойдет. мы пишем алгоритм за O(E)
Good catch.

Will a `Set` silently ignore dups or throw exceptions?
Why is this entire file commented out?
This kind of stuff should really be in people's global `.gitignore`, fwiw (if we put this here, why not `vim` swaps or `.Thumbd.db` too?).
If we are standardizing on this mapping from exception types to HTTP response codes, then yes, this should be moved up the stack.  I'm pretty sure that @grimradical had some concerns about whether this mapping is general enough to do that, though.  If we think that it is then I can refactor this to move it up.
All the others have default values of I18n.locale but not this one?
I'm still convinced this isn't running against my branch mrvisser/issue-284 :( I logged and manually inspected all the search results in general search, none have the `extra: null` values above, and all users have `resourceType: 'user'`. An `extra` property no longer touches the content and group docs, it is now called `_extra`.
Can you keep jsdocs on a single line per param/return? Multiple lines aren't parsed properly.
In case we do end up having any ids that have ":" inside of them, we can probably just take whatever is left (rather than only 1 element) for the 3rd element.
Documentation is required.
ми сонату з dev-master тягнемо. там нема вже цього стилю
https://github.com/sonata-project/SonataAdminBundle/blob/master/Resources/public/bootstrap/css/bootstrap.css#L759
That's a tad nicer. :)
:+1: for the yoda syntax
So glad this finally got fixed!
Niet een goeie naam. Beter: `healthBar`
- (BOOL)isEqualToString:(NSString *)aString
Returns a Boolean value that indicates whether a given string is equal to the receiver using a literal Unicode-based comparison.

We can't use this method on objects of NSMutableArray. Also, hammingDistance should be incremented when two elements of DNA object are NOT equal. So, in your case you should use: 
        BOOL equal = [self.DNA objectAtIndex:i] != [cell1.DNA objectAtIndex:i];
Думаю, невнимательность. XCode предложил дополнить как NSMutableSet, и человек не заметив подмены, нажал Enter.
I will do so ;-)

Meanwhile I hacked toward a more failsafe serialization routine that
certainly get's the types right (apart from callables).

``` Python
import json

def _serialize(dict_, outer_sep=';', inner_sep=':'):
    """Aux function"""

    s = []
    for k, v in dict_.items():
        if callable(v):
            v = v.__name__
        for cls in (np.random.RandomState, Covariance):
            if isinstance(v, cls):
                v = cls.__name__

        s.append(k + inner_sep + json.dumps(v))

    return outer_sep.join(s)

def _deserialize2(str_, outer_sep=';', inner_sep=':'):
    out = {}
    for mapping in str_.split(outer_sep):
        k, v = mapping.split(inner_sep)
        vv = json.loads(v)
        out[k] = vv if not isinstance(vv, unicode) else str(vv)

    return out

```

Wdyt?



On Sat, Dec 15, 2012 at 5:19 PM, Alexandre Gramfort <
notifications@github.com> wrote:

> In mne/preprocessing/ica.py:
>
> >      max_n_components : int
> >          The number of PCA dimensions computed.
> >      verbose : bool, str, int, or None
> >          See above.
> > -    mixing_matrix : None | ndarray
>
> Feel free to merge fix some cosmits and merge upstream
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dengemann/mne-python/pull/3/files#r2428528>.
>
>
As above, `error` may be `nil` here, which would cause a crash.
The implementation of this method is extremely complex. It'd make more sense to me if it were implemented similarly to `combineLatest:reduce:`, with any common bits factored out into a single method.
It does not work because there's no JDatabasePostgresqlQuery for that INSERT INTO statement, so "insertid" will crash.
If you change this code with that already present inside platform it will work.
I would use the listview object to trigger the event, because the prefix is dictated in the widget definition. So I would do something like:

```javascript
listview._trigger( "beforefilter" );
```
Can you markdown-format this file?

Summary
=======

This is a simple...

To run...
    go run...

etc
God I love powershell. ;) `!$?`
"Whenever these submodule projects are updated, we updated..." should be "we update"
I've removed the whitespace changes.
You should remove the space around the `.` operator
是这样
去掉
如果所有服务器都返回失败，客户端将会得到最后通信的那个服务器的（失败）响应结果。
What type do I get back here?
Have you checked these doctests. I am not sure that they would work on all platforms.
Can any of it run at all without it?  If not, you can probably just leave this as it is.  Otherwise, import only in those places where it is needed.  

Or you could use import_module, which lets you do things like restrict the version, and lets you enable warnings using the Python warnings mechanism via global hooks.
По другому никак. Было раньше без него. В результате не понятно было куда
урл вставлять. А теперь ок и понятно
Почему бы тут везде не юзать operator[]?
一般可以直接用複數就好了 `.dists`
除非 body class 也有 dists 不得已
假如要加 `_list`, 物件名稱用單數 => `dist_list`
ah.  "is done getting" wasn't reading like english to me.  thanks.
I added a check for the parameter image to be null and return a null image in this case.
Modified comments of method and add class comment.
"för" (for) and "från" (from) isn't the same thing, neither in english or swedish.
Remove Lite, and make the other Detail
I went ahead and changed it, but I still think elif is clearer. We can talk about it later.
Why don't you want some elements to inherit from the default cache? Examples?

It kinda breaks how the rest of configuration works, so it's worth taking a step back and thinking through whether this is really needed.
Why not volatile? Also, this flag is not transferred by state transfer.
There should be a blank at the end of every file.
Hmm, must be a new feature.  How about for consistency's sake with the rest of the documentation you provided?
I'm not sure why this line exists? Initial testing suggests colour names are case insensitive. Does it fix anything?
I do not think this import is used.
But it prevents people from extending it to add levels without having to duplicate all the existing levels.
Done.

On Mon, Jul 9, 2012 at 11:26 AM, Robin Kraft <
reply@reply.github.com
> wrote:

> > @@ -225,10 +225,9 @@
> >  (defn FireValue*
> >    "Create a FireValue."
> >    [temp-330 conf-50 both-preds count]
> > -  {:pre [(every? #(instance? java.lang.Long %) [temp-330 conf-50
> both-preds count])
> > -         (every? #(>= % 0) [temp-330 conf-50 both-preds count])
> > -         ;;(or (= both-preds 0) (= both-preds 1))
> > -         ]}
> > +  (prn (class temp-330))
>
> drop this line
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/reddmetrics/forma-clj/pull/64/files#r1124742
>
The existing way is idiomatic, and means -- "is this dataset in the set?"  

You could also just make a single preprocessing step and switch based on which data set came in. Or make a helper:

```clojure
(def already-modis?
  (comp boolean #{"vcf" "hansen"}))
```

--  
Sam Ritchie
703.662.1337
@sritchie


On Tuesday, August 21, 2012 at 9:31 AM, Dan wrote:

> In src/clj/forma/hadoop/jobs/preprocess.clj:
> > [dataset ascii-path pail-path s-res & countries] > - {:pre [(#{"hansen" "vcf"} dataset) > - (string? s-res)]} > + {:pre [(string? s-res) > + (#{"hansen" "vcf"} dataset)]}  
> I see. Well, I'd still change it, maybe, since it's easier to understand. Your call. On Tue, Aug 21, 2012 at 9:30 AM, David Petrovics <notifications@github.com>wrote:
> … (#)
> In src/clj/forma/hadoop/jobs/preprocess.clj: > [dataset ascii-path pail-path s-res & countries] > - {:pre [(#{"hansen" "vcf"} dataset) > - (string? s-res)]} > + {:pre [(string? s-res) > + (#{"hansen" "vcf"} dataset)]} Hey-- not sure if I'm missing something here -- , but preconditions dont need to be have a value of 'true' , they just need to be truthy. If you do (#{"vcf" "hansen"} "vcf"), it will return "vcf" since its in the set (otherwise nil). It doesn't actually have to be 'true' to pass the precondition. The function true?, on the other hand, requires a value of true. user> (defn foo [dataset] {:pre [(#{"hansen" "vcf"} dataset)]} "it passed.") #'user/foo user> (foo "vcf") "it passed." user> (foo "somethingelse") ; Evaluation aborted. — Reply to this email directly or view it on GitHub<https://github.com/reddmetrics/forma-clj/pull/203/files#r1426240>.  
>  
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/reddmetrics/forma-clj/pull/203/files#r1426258).  
>  
>  
>
I think this could be done with some general for machine prepare_for_ms method. However this shouldn't be done now
you have to be extremely careful with expressions like this new SGVector: Where is it deleted? Who handles this new vector on the heap?
Also, except for the serialization, this is done nowhere in shogun.
Isnt there a way avoiding this? All pointers should  be already in memory and you just have to fill in the data.
please add some `test' for slicing with positive/ negative indices for 1d and 2d array access (with and w/o colon, single : ) etc
please add brackets around the if (,,,) { } to increase readability.
Hrm, that gets us closer towards 2.x style of "let's hack magic numbers until it works" - what's the purpose of this? Can we move it to CSS?
`/home/yoursite.com/httpdocs` makes it clearer that its a path requiring adjustment. "silverstripe3" looks like it might have a special meaning.
1. Sorry, I couldn't understand the filter purposes. Is it some kind of defence from attacks?
Exactly, if someone will ever need to open non-public method, he will have to ensure that it wouldn't break anything. I agree with that and from practical point of view I vote for lazy development when nothing is made for imaginary needs in future. I don't know if public access support will ever be needed, so I prefer to defer publishing to future. Forcing everyone who extend that class to keep in mind that methods are public and do some additional work to support public access may be more expensive in average. Mostly it will never become needed.

2. Method is virtual without any necessity and R# already warns me that virtual method is never overriden :)
Why do you think that extensions methods are bad practice? At first, they allow you to avoid inheriting and get more simple code. At second, they allow to reduce testing units size because extension methods cannot access private members and can be tested separately (here are no tests at the moment, but I'm about general case).
If different inheritors will have different ToLine implementation (that we don't know certainly yet), the method can be implemented in each inheritor. Currently the class looks like Fowler's lazy class.

I feel that we have different views on these questions and I don't want to force my approaches.
Described things seems to be reasonable and if you agree with them but something isn't clear I can try to explain more detailed, otherwise it will be better to keep disputable things untouched.
It's what github web hooks do by default, too, btw.
Is it possible to define the element type for the array of parameter ``$evaluation`` (using ``array<SomeType>``, or ``SomeType[]``)? Please also check line 95.
Yep, the updates just committed include this.
I don't think you need this docstring/comment in the code (though thanks for explaining why you made this a class decorator)
I'm not 100% sure, but from what I was able to gather, this just joins the room so that deliver_deferred works. The deliver_deferred type is :groupchat, and the conference (actually a JID). It seems that you have to be joined to the room before the deliver_deferred works with MUCs.  My change was just to make it not try to maintain a connection, I assume the code before worked.
This might be better to extract into a query object. Please read examples and info here: http://blog.codeclimate.com/blog/2012/10/17/7-ways-to-decompose-fat-activerecord-models/ (#4 Extract Query Objects).
You are right (I was wrong).
useless double parenthesis here
makes me wondering why there isn't a space between `filter + opacity` at https://github.com/mootools/mootools-core/pull/2411/files#L0R57
This should probably be called maybeResetPref or something similar.
Is this the right documentation (the parameter is named webauthtype)
I made it v3 only on the off-chance that it wasn't safe and since v2 is known to always read the system-wide puppet.conf.  It probably is safe to override, but not sure it's of any benefit.
In `ready` you do not have to unbind anything! This was OK.
Before. ;-) Not after. Sorry.
Yes, almost exactly like that. :-) In fact it could be even simplified, because you don't need a class, just an object with given property. But is nicer this way, especially if you will comment those classes in docstring and explain it.

You should not return `constants.QUERY_TERMS` because that is for SQL (obviously) and not MongoEngine.
Google that? Try it in Python shell?
I don't mind what we use, so long as it returns true or false as expected. In the original instance it returned false or a hash.
whitespace messup.
The same remark from default_request_encoder about randomly rearranging symbols applies to this encoder/decoder pair.
You probably don't need to pass this around. Since Configuration is a singleton you can reference directly in the templates  conf.Configuration.stage


if you are going to use it in a lot of templates you can do the following in the sbt build file to make conf available to all templates...

templatesImport ++= Seq(
        "conf._"
 )
NoSQL **solutions** or **engines**
Tried:

@opts.fetch(:id , latest_id)

# ./bin/heirloom show -n test 
{:help=>false, :level=>"info", :name=>"test", :id=>nil, :version=>false, :name_given=>true}

but since ID is present and points to nil it return nil rather than pointing to latest.  Thoughts?
Except index 0 doesn't create a new table. It doesn't do anything at all, though `lua_absindex()` results in `m_index` being set to 1 even though there's quite possibly no table at that stack position. Hilarity ensues.

Overall I think I want it to be impossible to create a LuaTable object without a real table backing it. So I'd like to see two constructors:

```
LuaTable(lua_State *l);            // Creates a new table on the stack and uses it
LuaTable(lua_State *l, int index); // Uses an existing table on the stack. Dies (`assert()`'s) if its not there.
```

Far less confusion that way.
Move these into `LocalizedDateTime#until` and `LocalizedDateTime#ago`.
Nice, thanks for changing this one!
can this be private ?
can you use a sha512 hash, instead? it's more secure.
Are you referring to the unit circle rejection sampling method that was placed within an `#ifdef USE_COS_SIN` construct above (in OneDimensionalDeviate I think)?  Is it worth putting in the same switch here too (until we discover which is faster)?
I didn't try to follow all the math here, but might it be better to stop when an interval is nearly linear, rather than nearly constant?  Linear can still be done analytically, right?  And I would think it would be more accurate and faster than trying to get intervals that are piece-wise constant.
The config stuff does not need to query whether or not an object will accept a transformation, as all the GSObjects do, so I don't see how it is needed for that.  If you are uncomfortable with commented tests for this branch I can do the work here. But because 
1. These specific commented tests are far from massively discriminating (the number of lines of code they actually test in `galsim/` is small) 
2. The same effect of interest (i.e. passing tests in the interim) could be reached by simply putting in a discrete switch to each object that is set on the application of a transformation and queried by the descriptors. But this would be as incomplete as the commenting.
3  Commenting out the code made it all the clearer that work was still to be done here.

...I preferred to create a separate branch (finished quickly) to better document the different pieces of the change: I do find huge pull requests become unwieldy.  But it is not really that big a deal for me (and I see via my email that Jim already responded saying he doesn't care either way) so I'll do it as you suggest.  I have a relatively clear run at this tonight, so I'll push the changes later on.
will add something here to at least mention the real space convolution
As has happened before, I have to confess to not feeling very qualified to comment on this Tree stuff, having not coded up anything similar in the past myself...
File removed in 2576220, logic moved into recipe.
good diea
Number of retries should be zero if `noRetry`; number of "tries" would be 1...
Better name for method test()?
bah non tu peux pas comparer en absolu mec c'est pas possible. si ca se trouve ils auraient gagne 100millions avec la voie classique.