labofsahil/github-event-dataset-2012 huggingface dataset:
Why do you think it's a costly overhead for union all? I agree, that there is an overhead in case of UNION_ALL associated with the one time instantiation of the  multimap which is useless in this case, but that's about it. The needToInsert specialization will be optimized away and replaced with the boolean TRUE instead.

OK, I see, you are referring to the next line m_tuples.insert(tuple);. My bad. This must be moved inside the specialization for UNION needToInsert only:
    // UNION Specialization
    template<>
    inline
    bool UnionSetOperator<SetOperator::TupleSet>::needToInsert(const TableTuple& tuple) {
        bool result = this->m_tuples.find(tuple) == this->m_tuples.end();
        if (!result) {
             m_tuples.insert(tuple);   
        }
        return  result;    
    }

    // UNION ALL Specialization
    template<>
    inline
    bool UnionSetOperator<SetOperator::TupleMultiSet>::needToInsert(const TableTuple& tuple) {
        return true;
    }

and the while loop
                while (iterator.next(tuple)) {
                    if (this->needToInsert(tuple)) {
                        // we got tuple to insert
                        if (!m_output_table->insertTuple(tuple)) {
                            VOLT_ERROR("Failed to insert tuple from input table '%s' into"
                                       " output table '%s'",
                                       input_table->name().c_str(),
                                       m_output_table->name().c_str());
                            return false;
                        }
                    }
                }

Does it seem reasonable to you or do you still prefer non-template variant? In the latter case, all other Operators should be also non-template variants, right?
Would it be more concise/clear to set only variables (result, msg1, keys) in each branch and only assign to the three dictionary[e] values after/outside the "if/else" block? To save lines, you could initialize/default keys to None before the "if" since that will be its final value in most cases.

An alternative would be to establish the convention that all assert... functions must return (result, msg, keys) and make most of them return 
(result, msg, None). 

From there, long term, it's a small step to replacing the if/elif with a lookup into a function dictionary which would be easier to extend to new tests.
Better yet: ``return not self.id or 'status' in self.dirty_fields``
Не хватает точечных комментарий про стадии актуализации, типа «добавляем новое», «удаляем устаревшее» и тп
Should this dispatchEvent be here?
You need to use `@world` etc not `@t1` here.
A validator class like the others woud be nice.
``` clojure
(seq [this] (keys m))
```

keys already returns a seq, no need to convert it.

``` clojure
user=> (class (keys {1 1}))
clojure.lang.APersistentMap$KeySeq
user=> (class (seq (keys {1 1})))
clojure.lang.APersistentMap$KeySeq
user=> (instance? clojure.lang.ISeq (keys {1 1}))
true
```
You should use llvm's `outs()` and `errs()` and `raw_string_ostream` instead of `iostream`. For interactive input, use `fgets` instead of `cin`.
The above code has the same functionality with the following code. However, according to my previous testing, the performance and scalability of cross join is bad. Therefore, we use a table to store the join relation, and then join the three table together.
```sql
           INSERT INTO assoc_loop_aux(set_list)
           SELECT DISTINCT ON({0}.svec_to_string(set_list)) set_list
           FROM (
             SELECT
                {1}.svec_minus(
                    {2}.svec_plus(t1.set_list, t3.set_list), 
                    {3}.svec_mult(t1.set_list, t3.set_list)
                ) as set_list
             FROM assoc_rule_sets_loop t1 cross join
                  assoc_rule_sets_loop t3
             WHERE t3.id > t1.id
           ) t
           WHERE {4}.svec_l1norm(set_list)::INT = {5}
```
I see. But for float number, we can't count on = for equal operation.
The TransportPublisher needs to fire the callback with the actual message after its been router / modified by the middleware.
Hmm weiss nicht ob 'null' hier passt,.. Ist aber nur bauchgefuehl,... Vllt 'false'?

Hier host und port stehen? Proxy.abc.de:88...?
I think this should still throw e at the end, like the original code did, so that other rules (and the top-level framework) are unaffected.  What do you think?
Done in the overriden validateFields method ;-)
Remind me again why you're suggesting using java file names?
![](http://i.imgur.com/p0Dc0.gif)
IMO we should also resp.data[base].push(post) for all of them too, so that /services/facebook/feed stays the same as it is now too and is the same as what facebook returns.  It's double-storing everything, but we can optimize that in a later refactor (I'd TODO that fact too)
this line : Chunk chunk = world.getChunk(i, j, k);
I just want to get the instance of chunk, to to access to the data, i need the lock ?
Nice clean up!
+1 to @gruehle
Add

``"i18n" : "thirdparty/i18n"``
Fixed.

Changes are pushed

From: Jason San Jose [mailto:notifications@github.com]
Sent: Thursday, August 16, 2012 10:48 AM
To: adobe/brackets
Cc: Ty Voliter
Subject: Re: [brackets] Fix code hinting that broke due to localizing index.html (#1378)


In src/editor/CodeHintManager.js:

> @@ -421,6 +422,13 @@ define(function (require, exports, module) {

>      function _getCodeHintList() {

>          return hintList;

>      }

> +

> +    // Initialize variables and listeners that depend on the HTML DOM

> +    $(brackets).on("htmlContentLoadComplete", function () {

> +       // HintList is a singleton for now. Todo: Figure out broader strategy for hint list across editors

Fix indent these 2 line comments

—
Reply to this email directly or view it on GitHub<https://github.com/adobe/brackets/pull/1378/files#r1395428>.
Typo? should be данные
In the Windows editors I've used, this shortcut usually seems to be Ctrl+Up/Down (without the Alt).  Is this version a Mac-ism?
It doesn't point in JSLint if I didn't mixed both in a single line and it happened because I forgot to change between projects. 

That's is a issue in Brackets, it doesn't keep your indenting by project. I commited again solving this indenting problem.
I think you just want truthy here.  Otherwise values like null and false will get interpreted as checked instead of unchecked.

Also, I think this needs to be split into an if/else using addClass()/removeClass().
right. this shouldn't be here.
should i rebase this onto master, omitting quicksearch commit?
This block should be removed as users probably don't want to route "/subpath/.../" by default. We should create some documentation, or maybe leave it in commented out as an example (but update the text so that it matches; it talks about "report" but routes "subpath")
Thanks, @seancribbs. Have time for a quick +1? basho/riak_kv#430
s/employees/employs/
All these `term+...` recipes depend on `term+`, right?
"folders"? really? ;p
I cannot. This pull got broken somewhere in the meantime.

https://github.com/mitar/PiplMesh/pull/93#issuecomment-4858365
(This has not been finished because we were waiting for change to MongoDB.)
Are you sure that it is still XHTML valid once you change `p` with `span`? Why use anything? `span` by itself is useless. You use `span` only when you want to style something inline in a different way.

I could simply use one `p` around everything. Or do a `ul`/`li` thing where you change it inline.
Code where Language field is defined:

`class LanguageField(fields.CharField):
    def __init__(self, *args, **kwargs):
        kwargs.setdefault('max_length', 5)
        kwargs.setdefault('choices', language_choices)
        kwargs.setdefault('default', get_initial_language)
        
        super(fields.CharField, self).__init__(*args, **kwargs)
        
    def get_internal_type(self):
        return "CharField"`

Is this wrong?
Why overriding fulltitle? Why not setting only title to *Registration*?
Why is this in two seperate var blocks?
Please modify the path so that it points to your plugin.  Our build system uses this info to create the complete popcorn.js file.  Should test it too `node make buttered-popcorn`.
Later we should just load this for them.  Not worth fixing now.  Can you file a bug in 0.6 for this?
Change this to just "Popcorn Maker"
never mind I see it being used later in the actual dialogs, my bad.
Is this based on anything official like the youtube stuff above?
Again: probably easier to read on one line.
`createLayerRenderer` is the function where I can think `goog.functions.NULL` can be used.
this is a good question.  I assume this helps one debug global interpreter lock problems.  Doesn't appear to be used much anymore.
I had tried this originally, but binding to document did not work.  The trigger was not executed.  Not sure why, but body works.
In case of oauth, they should always provide something (katello itself provides it's values here https://github.com/Katello/katello/pull/837/files#L3R17).

If we wanted to generate something, we would need to store this information somewhere (so that it doesn't change anytime this module is run with defaults). Which is quite overkill for default value.
Right, symbols are much better.
Its a historical artifact. All data was previously accessed through the job object and this provided a consistent way of ensuring access control. 

For the love of all things holy do not unwind that code.
I mean we shouldn't raise reconnect on the server or client unless it's a true reconnect. i.e failure.
Actually, this isn't going to work because it doesn't play nice with metadata reconciliation.  The short story is that you can't just remove the meta entry.  Depending on the state of cluster ring reconciliation might make it reappear.  I think you can achieve your goal with `riak_core_ring:update_meta/3` and using an empty list as value but I would have to run through the code to verify.
No, it doesn't. As for IPv6, that only has a single loopback address. (::1/128).

And while I agree that that ^^ code doesn't address all loopback cases. It *does* address all loopback cases covered by the previous version of that code.

That being said, I'll gladly add another commit to improve the IPv4 case (using a netmask check against 127.0.0.0/8).
With the correct german translation a resize of the main Window would be needed because of the string length it's not shown on the tab bar :-/. 3 options, find a better suiting name, revert to Messaging or resize main client window.
This is not our indentation style for comments.
That's because this stuff is dangerous. People should use it only when they really know what is going on.
There's a good reason for that: `all_of_type` (and `_popuplate_content_type_caches` behind the scenes) take care to not hit the database more than required. This line only fetches content types which do have a `process` method from the database, and postpones the loading of other content types until the render stage.

Example: This means that if an application content issues a redirect, rich text contents etc. will not be loaded from the database.
OK, tak nech to zatial zostane takto a ked sa to eventualne bude menit, prihliadnime na to ci by sa to nedalo zjednotit.
Doing this can be tricky. If you just define a function `system.file` in the devtools package, that function will be called when you run `system.file` from the R console, and it will be called when you call `system.file` from devtools. But this version of the function won't be called when other packages use `system.file`.

Suppose that you want to call `system.file` from inside of a ggplot2 function. This is the environment hierarchy:

```
> print_envs(ggplot2:::qplot)
<environment: namespace:ggplot2> 
<environment: 0x1028b0f10>     # imports:ggplot2
<environment: namespace:base> 
<environment: R_GlobalEnv> 
<environment: package:devtools> 
<environment: package:ggplot2> 
<environment: package:stats> 
<environment: package:graphics> 
<environment: package:grDevices> 
<environment: package:utils> 
<environment: package:datasets> 
<environment: package:methods> 
<environment: 0x10093a2e8> 
<environment: base> 
<environment: R_EmptyEnv> 
```

ggplot2 will find `system.file` in `<namespace:base>`, and that version will be called.

To override the copy of `system.file` that is used by everything in R, you'd have to replace it in `<namespace:base>`, as well the copy in the base _package_ environment. I think this can be done base the base namespace environment is special in that it isn't locked.
You're going to have to declare this function as void and RETURN values manually (which means changes to __KernelWaitSema). Can't RETURN values in functions that may reschedule, as they will write the return value to the wrong thread. Need to come up with a clean way to fix this...
It's quite new, possibly added after you forked.
If you're build your own clone command, you need to figure out what the remote HEAD is, so a function that implements the logic for you is quite useful. It should be called `_guess_head` though, as that's what we're doing. Our clone command has its own implementation in its `update_head_to_remote` function. One of them should use the other (I'd be in favour of making clone use this, as it should mostly be a consumer of the API).
There is a lot of other functions that are not Jinja helpers in that file so I don't think it's appropriate. Could have been appropriate for the misc file, but even there, I'm leaning towards "Explicit is better than implicit".
add_new_product() doesn't insert anything into rapid_beta_version -- is that a problem?
Wow!! "Once you register a signal handler, however, then it will always be the main thread that will run the handler interrupt. "
Is it that simple?!  Again, thanks for teaching me.
You still have some whacky whitespace on a lot of this. Can you make sure it's all just one tab for each indentation?
I haven't heard anyone complain before, but yes there is a chance that it could be little endian and therefore backwards. Would it be OK to add another wrapper for the two-byte constants? (Any name suggestion?)
yep, just noticed that the assertions after the first deprecated function call aren't executed...
``files does not`` ? You should choose between the singular and the plural
missing empty line (same below method).
The class should be called `MongoDbSessionHandler `
If that works, that sounds great! Didn't know you could do that in Play.
The first parameter is the postedObj and the second is the author. In the case of posting on a user's wall, they're both the same. I wasn't sure here whether a poked post should appear on the poker's wall or the pokee.
have you removed `!` from if? Else I don't know why it does not work, try to debug it.
Separate this Exercise phase from the Setup and Assertion with a newline
Can `yammer_staging` be based on the environment?
Since Tree Remover is already in the code: let it be in there!
oh, I mean the /*default */ comment
(copy of comment on now-closed #1472)

tbh, I'd prefer the verbosity of something like "child_plugins" to the orthographical wrongness of "childrens"
for the sake of consistency, make spacing the same as in the rest and give it its own block, even if its just one line - will be more readable in the long run
No, this does not run when a selectmenu is disabled as the selectmenu is closed on disabling. So do we need suppressDisabledCheck here?

I've added a _documentClick method.
Some text here.
This is horrible code. It's full of lint errors. :/ Not saying you should fix it, but ... seriously.
display current image
quick question: do we need to gitignore this?
Add comment on why > 27
I can't!

/me push a small commit under the carpet
@vingtetun has landed one piece of buttons, the ones that we are using in cost control has not landed yet :(
Done! Thanks for the tip!
humm, I misred the code. I thought it was the end of the function. So you're right!
wrapper {
nit: space before brace
The way I'm reading it is setting `per_page` instead of `self.per_page` is setting a local variable, not the configuration option from [lib/octokit/configuration.rb](https://github.com/pengwynn/octokit/blob/master/lib/octokit/configuration.rb#L17). When we reference `per_page` here on 44 we're reaching out to the config option, which is set to 50 in [spec/octokit/client_spec.rb](https://github.com/pengwynn/octokit/blob/master/spec/octokit/client_spec.rb#L33). We then set a local variable `per_page` to 100, because `auto_traversal` is true and `per_page` (from the config) is not nil. The local variable gets pushed into the hash and we've now overridden the value we set when we fist configured the client.

The spec mentioned expects a `per_page` value of 50, but here we create a local variable with value 100, which gets past on to the next loop when doing auto traversal. When we use `self.per_page`, we continue to use (and set) the configuration option, so the per page is in fact persisted across all the subsequent requests when using auto traversal. 

In short, we should be using the client's `per_page` via `self.per_page`, unless I'm missing something. Which I haven't ruled out ;)
Having the filter in a separate method is good
Why delete those? I know there were disabled because they were dangerous and erases @davidfowl's hard drive :smile:, but the eventual goal was to get coverage here.
Per discussion, we should retain comment.
There were a few more changes beyond what's displayed here, involving passing things around and using different methods. When compressed like it is here, it looks like the comment was just deleted, but there was way more happening during development than that.
also ... you open a `<h3>` and close a `</h2>`
Maybe rename to format_test_result? As it is eunit will think it's a unit test ;)
_comment is out-dated_
Although I know it hasn't been discussed in detail, I don't think the text-shadow fixes the WCAG 2 constraints for color accessability. While I believe it "helps" the failing white-on-orange, this brown-on-orange won't pass at < 18pt.

I'm going to completely overlook the yellow background as it is merely a focus grabber.

Tested at http://snook.ca/technical/colour_contrast/colour.html
"stops all its running process instances" is clumsy - just directly say what you want to say, which is probably "stops all AppServers hosting this app".
Good point. Will have to push to later sprint.
Should be ``And I should see the following:``
In my experience, having lots of shift operators everywhere makes it easier to introduce bugs than having pre-calculated masks (though replacing 0x100 with (1u<<8) is certainly a good idea)...  Is there some specific reason you changed this behavior?
you don't wanna move this up to the previous line?
Wouldn't the user object only be in the session if the current user had logged in to that user account? The profile I add to the session here is from the new user that was just created from the "Create new user" page, so the user that submitted the information to create this new user is not logged into that new user's account, but rather, the user would be logged into their own GitZen account or just be an anonymous user. The user object in the session would refer to their user account and not the one just created.

Also, does this process put the actual profile object in the session? I thought it just put a reference to the profile object into the session that could be used to access the profile's information in the database.
Maybe

<T> List<T> getList(List<T> def)

That will incorporate the default's typing into the return value.
It is possible to put something other than `True` here, which gets passed as the `options` argument to `getChanges`. I think it would make sense to allow passing a list of allowable pollers to trigger.
split it in 2 lines via haml
1. its more readable
2. its easy not to noticie html_safe and add some bad data
This doesn't look good.

`temp` is a very unenlightening name.  Does this replace the sched notifications structure?  For some reason I thought you did the *right* thing and made this only included in scheduling components.  What is the point of this change?
We better be plenty sure these 'temporary' things we're putting in do turn out to be that. :/
Is this really needed?  - especially as its hashed
No!!! :) If we pass loader than it means that you can get access to the loaders by listening  to `sdk:loader:destroy`. That would be a disaster as you will be able to do whatever. This way you can't get access loader unless you create one or someone gave it to you. Not to say that non of other modules have access to the loader so they won't be able to do an assertion.
No sources is an array. I don't know what mozilla specific code you refer which can help. I could concat array in separate line if that would help.
You forgot to define `prefKey`
why contract, when the below party involves expansion?  so confused.
orthogonal change, improves generation of debug lang for ephemeral deployments.
splitting this into two separate lines really helps make this clearer in my mind.
Uh. Re-reading the code now, I think I understand it better. Ignore my comments. It changes from a basestring to a list.
Unneeded newline here.
Email可以唯一，咱木有验证email的
Param name before type - again, not going to mark each occurrence.
Might as well add "@name" to this error message, right?
Let's not suggest active record. We could suggest the puppetdb-terminus.
@ahpook Whoops, yes you're totally right. I'll fix that before this is merged, I imagine I'll have some other changes to make too.
Changed to 'kitchen'.
we generally have not listed author names in the past in the source code. So, pls leave it out.
Please document what you are trying to do here.
Why? I don't like the idea to use abstract here. Abstract is ment to define an class that implements some functionality, but needs more behaviour (added via inheritance) to function properly. If you want to prevent the possibility to instantiate the class you should protect the constructor, but this is not the case. I don't want to prevent evolution of this component.
The $elementHelper could end up using a FormMultiCheckbox based on the element type. 
https://github.com/zendframework/zf2/blob/master/library/Zend/Form/View/Helper/FormElement.php#L84

Both MultiCheckbox and FormRow would be using the same $element->getAttributes().
The order of the arguments for assertEquals 'expected' and 'actual'. So you should change the order for this assert
Should be "ModuleAutoloader"
Use annotations: "@group ZF2-489", etc.
connaissances
No,

It's the objectify (or twig persist, etc.) job to set properties to the appengine entity by reflexion from the POJO. But this metadata extraction step isn't generic. In objectify 4 for example, they use their own annotation (com.googlecode.objectify.annotation). Thus, at the low api level, we cannot know which field had been @Ignore etc.
I've normalized all suid to lowercase.
I've used an active record callback before_save + migration for any existing data in production.
Did you tried this? Are indices removed automatically?
I think that this glob would also return spec/helpers/* files, which we don't want here.
There should be a space between `)` and `{`. Looks good otherwise.
This prevents Nether Portals from being created in the End, but leaves the fire. (Same as Minecraft)
You are absolutely right; nice catch!  Fixed in [08e3f2a7410adce7dff41b54cb7faca019a50fdd].
and be explicit that its a query builder to find documents of the class this repository is for.
Okay, I just did this a bunch on a newer branch, I'll use migrations from now on though, it always seemed simpler/cleaner to change the migrations themselves but that makes sense.
Open to XSS?
Everytime ??
Fixed in ba4e200fdfe0a2b7e91c0d5d55cc4a70dba82f93
No, please. This project is actually used only for running tests.
Change to newline copyright lines
Lacks **kwargs?
give id attributes for the links
Why do we have to declare the nav in every single template? That is an annoying amount of repetition and what base templates are for.
General Python: You don't need to treat a string and its unicode version separately for things like this. Python does the right thing.

```python
>>> u'/about' + '/'
u'/about/'
>>> u'/about'.endswith('/')
False
```

`reverse` returns a string, not a unicode object, so appending a `u'/'` is actually converting it to unicode, which is fine when it's all ASCII but technically I'm not sure URLs allow unescaped unicode.
can a checkbox be optional, doesn't seem to make sense.
This loads stuff from aeolus?
Make it max_length=300. You never know and it would be a massive pain to have to fix it later.
FYI: as an alternative you could also consider Fletcher Nichol's knife-server plugin: http://fnichol.github.com/knife-server/

Awesome stuff...
return in_array($lang, $this->rtlLang);
Why did you use the non translatable makro here?
The mover is no longer inside the scrollerInner, so we don't have to consider that case. The only children of the scrollerInner are widgets. (Oddly, the widget doesn't scroll with the scroller, but that's true in master as well. Not sure why that is.)
Hi the name of this refers to the link but it returns the text so it would be best to suffix this with `_text` . That way from reading the test you can see exactly what this property is returning :)
if this is intended can you change the test name test_that_up_and_coming_is_present_and_had_4_items
please use ```value="45" unit="deg"``` instead of RadOfDeg
yes, but the delete deletes all PackageVersion and due to the update = ForeignKey(PackageVersion) it will cascade and drop all ProjectDependencies, do we have a test for that?
Done++;
Reduce Indentation. I will fix so this can be merged.
Right, but at this point we should have the "global id" of the user, so we should be able to use that against the REST endpoint instead of going through `getTenantUser` with the username.
I don't think this code can be executed by multiple threads, there's only one reconciliation thread. Otherwise, you're right.
You mean an implicit from `Array[DebugEvent] => Unit` to `IDebugEventListener`?
Have the link inside the localized text.
This should rather test, if the tilde is at the end of the line.
style! and 2 lines down
Really bad :(
This should just be `user.profile` -- which is defined as the `related_name` of the foreign key on the profile model here: https://github.com/350dotorg/localpower/blob/master/rah/models.py#L150

Since there's a `select_related("profile")` in the queryset here, we know that `user.profile` wouldn't cause any additional database queries.  I'm not sure whether the same is true of `user.get_profile()` since that's some kind of magic Django method.
We should really start using JText::sprintf() which accepts parameters and get rid of all concatenated strings.

    MOD_KUNENALATEST_POST_COUNT="Post count: %s"
    echo JText::sprintf( 'MOD_KUNENALATEST_POST_COUNT', $this->topic->posts);
that would be possible, if you wrap the require in a try/catch statement and tell users that they need to import the policy file or they are going to spam us with bug reports :p

On Friday, April 6, 2012 at 11:40 AM, Nico Kaiser wrote:

> > @@ -4,6 +4,7 @@
> > */
> > 
> > var http = require('http')
> > + , policyfile = require('policyfile')
> > 
> 
> 
> Ok, sounds good. And remove "polifyfile" from the dependencies?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/LearnBoost/engine.io/pull/19/files#r654435
> 
>
МАМА!!! don't repeat yourself :) вынеси в spec_helper, а еще лучше в файлик который там будет подключаться, и больше никогда не копируй одни и те же методы
this doesn't appear to do anything...
I think ``xtag.query(this, 'ul')`` will do what you want.
This block should be manually copied.
Why is this tied to the main queue?
This is my favorite line!  Line specific comments and code review.
Nah. The commanline option is minutes between cycles. So we convert minutes to seconds for time.sleep() here.
好主意！
No, it doesn't! I tried using the default value returned - which is in fact what what "get_absolute_url()" returns. Nevertheless, it returns an incorrect url:
http://repository/browse/accurat-bilingual-comparable-corpora-for-under-resourced-languages/35af3494cd0611e1bb3b842b2b6a04d7350a0db24f64427799a7b788c373032f/

Now, concerning the second comment. Please checkout the following site which contains directions for creating sitemaps. They recommend using the full url for the "<loc>" portion of a sitemap...
http://www.sitemaps.org/protocol.html
Whoops! That was an error on my part, but now it's just convenient  since I don't have to change it :)
Makes sense, picks is fine and if none misc with me. And let's hope for the future:)
yep, I agree

On 23.10.2012, at 09:23, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/fiff/raw.py:
> 
> > +        times : list-like | float | int
> > +            List of numbers or a number representing points in time.
> > +        use_first_samp: boolean
> > +            If True, time is treated as relative to the session onset, else
> > +            as relative to the recording onset.
> > +
> > +        Returns
> > +        -------
> > +        index : list
> > +            Indices corresponding to the times supplied.
> > +        """
> > +        if type(times) in (int, float):
> > +            times = [times]
> > +
> > +        offset = self.first_samp if use_first_samp else 0
> > +        index = [int(t * self.info['sfreq']) + offset for t in times]
> would be nicer to return an array with dtype=np.int
> 
> times = (np.asarray(times) * self.info['sfreq']).astype(np.int)
> 
> if use_first_samp:
>     times += self.first_samp
> —
> Reply to this email directly or view it on GitHub.
>
nice one :)
i will use it
i have switched to Mockito.eq(), thanks! i didn't know this
Yeah, I agree w/ that. I left the title the same. Its mine due to the shuffling of the order.

I'll change that.
Sure, unresolved sounds better, same name should be used also in che controller and in the view.
Why did you need to remove the `private[this]` qualifier? It allowed to reduce the number of transitive recompilations performed by sbt.
maybe here you can pass an ExecutionContext to execute the .next
可以从这里获取更多参考信息：
If we don't need it, just remove it.
[Yup](https://github.com/intridea/omniauth/blob/master/lib/omniauth/strategies/developer.rb) thats what it is
There should be an empty line here.
Fixed: it was <exclude>**/WorkspaceManager</exclude>, without the ".java" extension.
Seems like initializing `d3_nsPrefix = Object.create(null)` also fixes this one. ;)
That should be fine.  I've been experimenting with numpy.deprecate on some other functions, and so far it hasn't triggered a deprecation warning.
Што-то у тебя тут отступы поехали.
И жирный — говно, курсив полущ. Жирный не рекомендуют юзабилисты.
Вызовется деструктор lock'а, который роллбекнет транзакцию (а если бы
Good() было вызвано, то деструктор ее коммитит).
"Consideramos que las tareas que se indican a continuación no forman parte del criterio de fin de proyecto." ¿Qué opinás?
My apologies... I use StyleCop on default settings and resharper... normally I take the time to fill in the comments fully as I prefer them to having random methods with no documentation. 

As for the copyright... yes that's mine, an Irony of the MS-PL license is that if I insisted you would have to make a decision between accepting the changeset and keeping the header... or rejecting it on that basis alone. Fortunately I could care less, but I do find that amusing.
As far as I remember, when I tried to download js data as JSON, it worked only on certain results (I think I have had problems with nested list of list of list, for example in package search).

And this works really well.
There needs to be an option to not check if something exists. It is a huge waste to have to do that for most people.
Can I ask why you decided to deprecate this?
make order consistent with the toc
Actually it should be %u:

```objc
typedef UInt32 FSEventStreamEventFlags;
```

Change that and I'll merge it.
Oh I was saved. The only reference which might trigger ist is in  loadCaches(final Set<String> geocodes, final Long centerLat, final Long centerLon, final Long spanLat, final Long spanLon, final EnumSet<LoadFlag> loadFlags) but there you cannot input geocodes and coordinates.
Please do not initialize `result` here. The `null` value is overwritten in every case, and this prevents the flow analyzer from warning if one code path forgets to initialize it as it as already a legal value.
Just use =delete as we're C++11 only anyway.
Why would we be passing these in here instead of init?
Tarkoitusena oli toteuttaa maksimi itse rekursiolla.
On 18 April 2012 10:02, Sanne Grinovero <
reply@reply.github.com
> wrote:

> > @@ -22,6 +22,7 @@
> >   */
> >  package org.infinispan.atomic;
> >
> > +import com.sun.tools.javac.code.Flags;
>
> Not this one!
>

IDEs suck!  :)
Please use logging instead of System.out.
Is a small refactor, I think is more clear to have creation logic in a private method.
Yeah... I don't know why I did that.
@WeatherGod: This is really off-topic, but is there any chance that Matplotlib will migrate to Numpy's docstring standards?
Already fixed, but will merge nicely.
Same comment concern as above here too.
I thought about this originally, but here's why I put them in the same file:

Every time a user searches for an app, the next step likely is to install that app (which is probably called out in @krupa's smoke tests). Even I split the tests up, the tests would end up being like:

1. The old search marketplace test
2. The old search marketplace test + now actually go and install the app

However, I do understand there's a series of combinations that can occur with marketplace post searching for an app. So I could refactor the logic out for searching for an app and installing an app from the search results page (i.e. page objects for starting page and search results). I could probably break off of the generic install app piece as well into it's own file.

Would that work? So the refactoring I could probably do here is:

1. 3 python helper files - MarketplaceMainPage, MarketplaceSearchResults, GaiaSystem
2. 2 python test files - test_search_marketplace.py for a search only test and test_search_marketplace_install_app.py for a search and install test
думаю, abstract здесь можно убрать
Right.  We want to return nil, so that it doesn't break the process, but Cascalog filters out the "bad" values.  I originally had a (singular? ...) if-then statement; but this would suppress the error in the logs.  @robinkraft suggested that I put in the try-catch statement for the logs.  It makes sense to me.  I will add a note.
@christianv This should be indented 4 spaces.
Sorry James, I didn't read the comments through, doing that now.
Why the inner loop? This is called for ALL elements on every individual onmatch
This is part of the reversion of commit 9bf3ae9a190effe: check http://open.silverstripe.org/ticket/7461 for details. Also this was not intended to be included.
This part of the implementation is not speced but both Firefox and WebKit behaves like my implementation.
You can do `Metriks.timer('build.start.delay').update(end_time - start_time)`
You can probably replace most of this with a call to simplePopulate and/or complexPopulate.  See test_truncate.py for an example, basically, if you're just building a file or table in the test suite, you can use those functions instead of rolling your own.
I will merge for now and eventually push correction
The class name is not autoloadable using a PSR0 autoloader. It should be in the sub-path "ZendTest/Paginator/TestAsset/InvalidAdapter.php".
Esto obviamente es cuestión de gustos, pero se considera mejor/más idiomático/good practice en el ecosistema Node hacer, en lugar de:

```coffee
if err
  console.log 'Hubo un error'
else
  console.log 'Todo funciona bien'
```

Algo de este estilo:

```coffee
if err
  console.log 'Hubo un error'
  return

console.log 'Todo funciona bien'
```

Es más legible, te ahorras un nivel de indentación (que con la cantidad de callbacks que hay se agradece, especialmente porque estos ifs se acaban anidando de más) y queda más claro que es una condición excepcional que "bloquea" la ejecución normal de la función.

Véase https://github.com/alvaro-cuesta/nerdobot/blob/master/plugins/quotes.coffee#L25-L41, imagina esos 4 ifs anidados :P

Sólo por informar. Esto si no quieres no lo hagas, es cuestión de gustos así que te aceptaré el PR igual.
Nice use of emojicon!
Reading a cookie with options:

$.cookie('foo', { path: '/' });

So now when JSON is defined this is going to be a write instead of read.
You might want to specify to get a cookie with `raw: true`. Or specify the path.
You could just pass the `whitespace?` function as a parameter: `(every? whitespace? string)`.
Is there a compressed version of these files? (assets/js/bootstrap*). It will make your site load noticeably faster.
From what I remember Adriaan has fixed it long ago.
Nit: Unnecessary extra level of indentation.
we usually break lines after about 80 characters in files so they are readable in the diff. can you do that please?
add the last period.
Yes. But here there is newline always, in both cases. You have it only in one case.
Combine classes.
So restructure this e-mail a bit. Now you added some parts and some parts are a bit confusing now.
In anonymous functions we put space around `()`. Write out all arguments this callback receives, so that future developers will know what is available.
Maybe this shows that list of notifications should not be in the User document. Which is also reasonable. If you think, much better is to have a separate collections of all notifications, with reference to user and comment. And then do a query on it when you want to display notifications. Why would you get a list of ALL (past and current) notifications for the user everytime you access user object?
It's considered a best practice to never use script tags. Instead, put your JS in its own file. You can use application.js as a catch-all, but it's usually good to divide the JS into individual script files to be used by various parts of the app. (see the Rails guide about the asset pipeline)
Why don't you use CSimpleFileFind or CDirFileEnum here?
You can also use the keyword 'is'; e.g. if(other.gameObject is Enemy)

I might email everyone about switching over to this convention after I test that I works well.
The column of stars should line up with the first star at the top.
For some reason, the split on string doesn't take a Regex, you need to use the split method on the regex. 

The pattern I provided though isn't for splitting, it's for use with findFirstIn.  More info at http://www.scala-lang.org/api/current/index.html#scala.util.matching.Regex
Test it out, no it's not needed. Make a file less.sh with only four chars
in it: "less" then do "cat somefile | sh less.sh"
On Dec 11, 2012 12:52 PM, "James Pearson" <notifications@github.com> wrote:

> In pipe-to-graphite.sh:
>
> > @@ -19,9 +19,20 @@ if [ -f graphite.conf ]; then
> >     source graphite.conf
> >  fi;
> >
> > +# '-' indicates we should read from stdin
> > +if [ "$1" = "-" ]; then
> > +   # Get a timestamp for sending to graphite
> > +   ts=`date +%s`
> > +
> > +   # Pipe the output through sed, using a regex to
> > +   # append a $ts timestamp to the end of each line,
> > +   # and then to the correct server and port using netcat
> > +   sed -e '/ [0-9]\+$/!d' -e "s/\$/ $ts/" |
> > +   nc -w 1 $GRAPHITE_SERVER $GRAPHITE_PORT
>
> We don't need to explicitly read from stdin?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/iFixit/pipe-to-graphite/pull/1/files#r2384516>.
>
>
I really like the idea of having a class that handles partial dates. The reason why I didn't add one in the first place is, however, it raises the question: How can two partial dates be compared? For example, when looking at all releases by the same artist with the same name which one should be considered the oldest release when some only have a partial date. This class should override toString, equals and hashCode, and probably implement Comparable. It should mostly be enough to delegate to DateTime.
methods ;)
you should order imports like this:

1. python stdlib
2. lib you installed
3. stuff from circus

You can add a blank line separator between those
this is a good way to save some database writes...you could also optionally set up celery at some point. celery is an offline job system. it adds some setup stuff to the infrastructure, and means having another thing to monitor, but it gives you an easy way to dump offline tasks into a queue.
Again, don't do this without -p.

I it arguable that you should still setpgrp() without -p, that has general value.
Coding standarts:
```
if (...) {
  return;
}
````
We normally support a few client versions back, so should include prefixed.
Maybe make a `var CONTENT_LESS_RESPONSE = 204`. Have you tried if you actually get resources of that sort from the network logger?
One space before "return". Also, maybe "header" (or "h") instead of "e"?
Extra spaces around the argument.
Almost the same code as an existing function, we should refactor to avoid duplication.
cosmetic/readability: I like empty lines to separate logical parts (setup, estimate, print and display)
a nested function might make this function more readable
lol, En même temps ça fait quand même 2 points non perdu à Epita !
faute de norme : -2
+ it seems like it ought to change
This log is not very explicit
Ok.  I'll modify it.
It's actually `Death to "Israel"`. Are those quotes meant sarcastically? There is typography for this: [⸮](http://en.wikipedia.org/wiki/Irony_punctuation)
Fair enough, but as for the comment below, I'm so tired that I can't promise to do this right now without breaking it.  I'll do it tomorrow, or you can do it if you're willing.
As the status of `_fluxConserve` is not changing, would it be faster to move this `if` switch outside the `while`?
As long as these match what's on the API side, looks good to me.
`JSON` is a pretty generic findlib name and would probably conflict with one of the many other json libraries. Would you consider calling it something else like yajl?
@zoltax , I see, that this file is for testing only, let's remove it after you make things that @fosils asks done
No really good reason. I think what I was worried about was that we might end up with POST.get('parent_id') returning only parent_type, and not a comma-delimited item. Perhaps I was feverish.
nope, this is a miss; I *was* using it and changed the inheritance.
ObjFlags has a similar setup. The ObjSystem object seems to work fine with or without it.
Is there no `getCatalogItems()`? Then one could use guava's `Iterables.filter(getCatalogItems(), filter)` and all the other cool stuff, so we could get rid of this method.
Notice that I said `cc._p`  (which is part both of cocos2d-JSB and cocos2d-HTML5) and not `cp._v`
var $el = $('.cordova-required');
    $el.hide();
    $el.closest('.ui-btn').hide();

OR

    $('.cordova-required').hide().closest('.ui-btn').hide();

Either of those would be less costly.  `closest` also (performs better)[http://jsperf.com/jquery-parents-vs-closest].
Yeah, I didn't actually change anything here, but agree, this is prime for a refactor. Added to PT.
Copy from Twig  https://github.com/fabpot/Twig/blob/master/lib/Twig/NodeVisitor/Optimizer.php#L59
nice tip, I wasn't aware of it.
Why the whole file has changed? This is strange.
You actually don't need those parentheses around "token, url" there.
Did the version of this from Tim not work for you?  If we have to hack Ares (which we do, if we keep using it, I looked into it), it would be nice if w could at least do so consistently.
better invert this to avoid NPEs
+1.
```php
return ($a == 5) ? true : false
```
is one of the most awful practices ever.
Принято делать так, чтобы у каждой сущности был отдельный файл. `Event -> Event.js` `Model -> Model.js` и т.п.
has_many method calls #{self.class.path}, without this line, my rspec will fail with ctiveResource::InvalidRequestError:

```bash
ActiveResource::InvalidRequestError:
       Could not find a response recorded for <GET: //deals/d02k49d/locations.json [{"Authorization"=>"Basic Zm9vOmJhcg==", "Accept"=>"application/json"}] ()> - Responses recorded are: ["<GET: /api/v2/deals/d02k49d/locations.json [{\"Authorization\"=>\"Basic Zm9vOmJhcg==\", \"Accept\"=>\"application/json\"}] ()>"]
```
because self.class.path is nil.
Небезопасно закрываешь стримы.
Лучше в комментариях к коммиту.
Eclipse ругается нехорошими словами на неосвобожденный ресурс.
you should indent the comment
is there a reason some of these methods are still using is_element_present rather than is_element_visible? some days i wonder why we even still have is_element_present...
We don't need 'return' in this context.
Need info: Why is one null and another an empty array? Guess content will be an an array and contentMeta will actually contain an object in the end...
i't there now

2012/8/30 benkonrath <notifications@github.com>

> In bluebottle/urls.py:
>
> > @@ -26,6 +26,9 @@
> >      (r'^projects/', include('apps.projects.urls')),
> >      (r'^members/', include('apps.accounts.urls')),
> >      (r'^albums/', include('apps.media.urls')),
> > +
> > +    (r'^api/', include('apps.projects.apiurls')),
>
> I think you need to add the apiurls file. Other than that it looks good.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/onepercentclub/bluebottle/pull/96/files#r1495067>.
>
>



-- 
Loek van Gent
1%WEBMASTER

*1PROCENTCLUB.NL* <http://1procentclub.nl>

*1%Facebook <http://www.facebook.com/onepercentclub> +
1%Twitter<http://twitter.com/1procentclub>
 + 1%LinkedIn<http://www.linkedin.com/groups?home=&gid=1071287&trk=anet_ug_hm>
+ 1%Hyves <http://eenprocentclub.hyves.nl/>*

* *

's Gravenhekje 1a

1011 TG Amsterdam****
T -  (+31)20-7158980
E - loek@1procentclub.nl
xbmc ok, but we don't need two flags here?
Just a heads up that Bootstrap has stuff for this as well should you want it: http://twitter.github.com/bootstrap/javascript.html#modals
Please add 2 blank lines to seperate top level functions or classes as per PEP8.
I'd love to find a better name than J. Any ideas ?
more phantom whitespace removal
The go convention is to have the function be "String()"
This will break the build on openJDK
Thanks Alex,

This should be in the fontSize specific description.  As for the fontWeight, it matches what's already in the description.
Very good point.

![I do not think it means what you think it means](http://files-cdn.formspring.me/photos/20120825/n50396750cd1ec.jpg)
self.intransitive is too vague, can you change it to a name that specifically indicates that this is for the dep checker?
I don't really understand the logic here, but if you have pulled SOME of the entries out of the table but not all, I don't believe you can guarantee you have left it in a valid state.
you should simply use ``if`` instead of ``elseif`` here
Also encouraged style is using .forEach / .map and friends:

```js
styleRules = contentStyleFile.map(read).join('');
```
bootstrap [gonna be hard to factorize] and l10n ;)
We should discuss with @weierophinney first about removing usage in Zend\Mvc before completely removing this from Zend\Stdlib.


PS @Thinkscape:

> You're twisting my words a little bit, but it's ok :-)

If so, know that it was certainly unintentional! Sorry about any misinterpretation on my part. Such a thing is inevitable in such a multi-lingual community like ours.
we're not using a real thing. this could be random values. the test doesn't actual connect to the service.
Pourquoi tu as besoin d'un text-align sur une classe destinée à une image?
You're right, on top of that it's probably slower: http://jsperf.com/jquery-grep-vs-each. I think I was trying to fiddle with something that automatically did searching (ie grep) and got sidetracked.
@christianv My original thought when building the dummy json was that  URLs could be constructed in DOM based on IDs in the feed, making for slimmer JSON. I agree we should be consistent, but if you prefer full URLs, that's fine.
This is just

~~~clojure
(and (>= (first rank-freqs) 4)
    (>= (first rank-freqs) (second rank-freqa) 2))
~~~