labofsahil/github-event-dataset-2012 huggingface dataset:
Given it's the only code I've got on github, thought it was probably a good idea to have a green build :)
(and yes, the broken build was playing havoc with my OCD)

What you up to these days, anyway?

-----Original Message-----
From: jimbutler [mailto:reply@reply.github.com] 
Sent: 17 February 2012 16:35
To: Matt Richardson
Subject: Re: [bounce] Added framework property to NUnitTests task; (76ac9c8)

Surprised you're still working on Bounce!


> Date: Fri, 17 Feb 2012 08:33:12 -0800
> From: reply@reply.github.com
> To: jimbutler@hotmail.com
> Subject: Re: [bounce] Added framework property to NUnitTests task; (76ac9c8)
> 
> If the FrameworkVersion is not supplied, it will be null, so the build had broken. I've committed a fix that ensures that frameworkversion is not null before accessing FrameworkVersion.Value.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/refractalize/bounce/commit/76ac9c829cf6bc982dc11bbb3ae0f88bc2492226#commitcomment-978784

--- 
Reply to this email directly or view it on GitHub:
https://github.com/refractalize/bounce/commit/76ac9c829cf6bc982dc11bbb3ae0f88bc2492226#commitcomment-978790
Nice to see work being done in polish items like this.
No, it should be ===, because if the root (the canvas for the features) is invisible (display:none), getFeatureIdFromEvent should return immediately. At that point feature is still undefined, so any select/click control won't pick up anything.

I'll look into writing a unit test for this.
looked awesome in email though
Is there a lesson 7?
i will prepare a jsfiddle...
It works, I have it done locally, will push later to my fork.

AP


On Tue, Feb 14, 2012 at 10:05 AM, Tim Jones <
reply@reply.github.com
> wrote:

> Wouldn't that only work if `IFileSystem` was an abstract base class
> instead of an interface?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/AppSpaceIT/dotliquid/commit/454a299a80602930bdb3cee1d0304d63fc9d081f#commitcomment-963740
>
Correct (but this bug also happens before this patch)
Кстати была ещё идея перенести кнопку быстрого отключения в меню, т.к. она реально подтормаживает на многих сайтах.
Name the variable - template
Argh! http://stackoverflow.com/questions/2956464/where-do-i-set-my-company-name
It's fine.  Like I said I'm using my own manifest now anyways.  If anyone else has issues feel free to use it, bye.
…And again…
eventmachine-0.12.10 has been released 2 1/2 years ago, I remember encountering some weirdness when using it with EM::Synchrony.
![ಠ_ಠ](http://stickerish.com/wp-content/uploads/2011/04/LookOfDisaprovalBlackSS.png)
Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios  i love you Kiss you :D that's enough :P ?
1 per line
You kids play nice. Else your both going to your room without dinner!
Is this some kind of Maven integration?
ignore R.java just now
Argh. Should not do changes late night in weekends. Thanks for the heads up.
El dbprefix deberá ser "fire_tail_" o dado por el usuario y con la sub string replace reemplazar el valor $db_prefix -> $db_prefix_en_instalacion
Didn't experience any issues w/o it, didn't test exclusively.   How's it help? Is it something experimental, or should be done in all cases?
Sorry about that. I had forked for my own use at first and forgot about the readme change. I will revert that file.
Не очень понятна логика по которой убрана валидация наличия album_id (возможно это оправданно, тогда возникает вопрос почему подобное не сделано с аналогичной сущностью video? там данная валидация осталась)
There is never any donation for SkyFire. We don't need money. I pay for the Github and website out of my own pocket. I decided to only release the full DB to the public. If you don't like it. Don't let the door smack you when you leave. However we may release smaller patches in the core repo.
Thanks, do you think it will work with 1.3? Then we could just have Django>=1.3 in requirements, instead of having link to Django 1.4 RC1 tarball.
These version numbers shouldn't be repeated here. They are defined once in one of the parent poms. Please extend the parent poms to also define the version numbers of the new Maven projects you add.
Wouldn't it make more sense to call this tile.accelerate_object?
I've committed a fix, sorry all.
There is indeed a difference between the two lines (edited for readability)
Before (works):

    mencoder -ss 0 -quiet Sintel.2010.1080p.mkv -quiet -quiet -oac copy -of mpeg -quiet -quiet
    -mpegopts format=mpeg2:muxrate=500000:vbuf_size=1194:abuf_size=64 -ovc lavc -channels 6
    -lavdopts debug=0:threads=8
    -lavcopts autoaspect=1:vcodec=mpeg2video:acodec=ac3:abitrate=640:threads=8:vrc_maxrate=54000:vrc_buf_size=7000
    
    -ass -nofontconfig
    -subfont /System/Library/Frameworks/JavaVM.framework/Versions/1.5.0/Home/lib/fonts/LucidaSansRegular.ttf
    -ass-color ffffff00 -ass-border-color 00000000 -ass-font-scale 1.0
    -ass-force-style FontName=Arial,Outline=1,Shadow=1,MarginV=10
    
    -quiet -quiet -sid 100 -quiet -quiet -ofps 24 -sub Sintel.2010.1080p.srt -utf8 -mc 0 -noskip
    -af lavcresample=48000 -srate 48000 -o - -really-quiet -msglevel statusline=2

After (doesn't work):

    mencoder -ss 0 -quiet Sintel.2010.1080p.mkv -quiet -quiet -oac copy -of mpeg -quiet -quiet
    -mpegopts format=mpeg2:muxrate=500000:vbuf_size=1194:abuf_size=64 -ovc lavc -channels 6
    -lavdopts debug=0:threads=8
    -lavcopts autoaspect=1:vcodec=mpeg2video:acodec=ac3:abitrate=640:threads=8:vrc_maxrate=54000:vrc_buf_size=7000
    
    -ass
    -ass-color ffffff00 -ass-border-color 00000000 -ass-font-scale 1.0
    -ass-force-style FontName=/System/Library/Frameworks/JavaVM.framework/Versions/1.5.0/Home/lib/fonts/LucidaSansRegular.ttf,Outline=1,Shadow=1,MarginV=10
    -nofontconfig
    
    -quiet -quiet -sid 100 -quiet -quiet -ofps 24 -sub Sintel.2010.1080p.srt -utf8 -mc 0 -noskip
    -af lavcresample=48000 -srate 48000 -o - -really-quiet -msglevel statusline=2

I have singled out the different bits. Looks like the `-ass-force-style` uses a different font name and the `-subfont` is gone.
That excludes attribute looks like a stray.
Can be done in EventAI?
Btw Decimate doesn't work yet, if anyone has sniffs for this encounter? fix it or mail me pleas.
@vallettaventures thanks for the reply, very interesting. I'm just starting to learn about threading/GCD/operation queues and it's pretty cool stuff.
@FernFerret git blame ftw
Ah, I missed this in the spec!

I think this should be added to the client_outgoing tuple though?  Perhaps we should be looking at the same reference code base :)  I've been looking at the python and java libraries
load default view
use createChild method to create view instance. this method will return the view instance if it is loaded, or return a load deferred.
@bodepd I put this in because create was being called regardless if the network existed or not

I have just removed it to double check, see error below

err: /Stage[main]/Nova::Controller/Nova::Manage::Network[nova-net-11.0.0.0/24]/Nova_network[nova-net-11.0.0.0/24]/ensure: change from absent to present failed: Execution of '/usr/bin/nova-manage network create novanetwork 11.0.0.0/24 1 256 --bridge=br100' returned 1: 2012-02-15 09:15:04,177 CRITICAL nova [req-4ac02e11-c49c-4d10-9e2a-6d07f3b20dc8 None None] cidr already in use
Command failed, please check log for more info
You've tried to repack a ICS kernel?
Confident this will prevent Chrome from running on all builds.
I would suggest more proper name for this command: "sonata:admin:create-cache-class"
I believe every command of bundles should be in it's their namespace so there is no confusion where the commands came from. Or is it something that I'm missing here?
then how can i to update vendor/cm? i have used repo sync many times and got same error.  thanks
Need to get this test working...
Looks good.  Is there anywhere where we list the main classes that you can apply to CMS elements?  Even comments in the relevant .scss file?
I have compiled it with
 #undef COMBO_DEVICE_SUPPORTED

I think this bug related to:
http://r.cyanogenmod.com/#change,11919

Wait, i will test it.
The description for this method is confusing. The method *retrieves* Purchase object and passes it to callback. Also please review the rest of this the description, what does 'All "Refunded" SKUs will return false immediately' means?
Yep, that is definitely a fair pro vs con.
adb logcat? 

if bootloop, you can still akses logcat via adb,
The logic above is what was causing the issues I saw. Previously, there was code to adjust the popup from being fully centered over the input, if that would result in the top/bottom being off screen. I noticed the logic didn't account for headers/footers (and my site uses the new fixed approach in the 1.1 nightly builds) so this code adjusts in the event a header/footer is present.
Hehe. I guess I missed something simple :) Glad it is working :) 

`no crash for 4 hours` - Awesome!!!!
Wait... If the server hits the max amount of connections, the whole thing shuts down, and kills them all?
I'm not that fussed really if we want to try and follow the openstack standard then we can just have a metadata parameter that defaults to empty hash and get assigned to the metadata  data['createImage']['metadata'].
 I just created something similar to the hp_fog implementation
see https://github.com/ack/fog/blob/hpfog/lib/fog/hp/requests/compute/create_image.rb
 they are coding 
   create_image(server_id, options = {})
and 
  if options['name']
            data['image']['name'] = options['name']
          end
I suppose to be compliant with hp_fog the name should go in the options to ie 
def create_image(server_id, name, options={})
     'name' => options['name']
 and we should use strings instead of symbols.   
  data['createImage']['metadata']['ImageType'] = options['image_type'] unless options['image_type'].nil?
  
at the moment there is no standardization between hp, rackspace and the generic openstack implementations in fog.

Maybe all method calls and parameter names match the openstack api as per http://docs.openstack.org/trunk/openstack-compute/developer/openstack-compute-api-1.1/content/Overview-d1e71.html ???

or should the rackspace try and be consistent to the hp_fog implementation that is being contributed by hp staff? 

I guess this is a decision that we need to make.
Can you think of ways to get read of the for loop? Perhaps use VertexPointers. glDrawArrays or glDrawElements to draw all QUADS at once?
Short story: if there is a validator, for instance Y.Lang.isNumber, and the default value is NaN, the model is not reset. I mean, when the reset method is called, the validator is called and if an attribute does not pass the validation, the model is not reset, that is the attributes do not contain the default values.

I do not know if it is the expected behaviour for a reset, I mean for a reset, maybe the validation step should be ignored.
My workaround was the setter use.

I will try to remove the validator or to change it: maybe Y.Lang.isNumber is too strict, accordingly the default value.

*tl;dr;*

However I recap my attempts, because the path, I think, may be interesting for other users.

*Attempt #1*: At the beginning the validator was Y.Lang.isNumber and the default value was zero. I didn't reset the model and cleaned (in the view with the method clear)  the inputs with an empty string when the value was not a number.
*Problem*: If the user types the same value of the default one, the conversion does not work because there is not 'change'.

*Attempt #2*: So I set the default value to NaN and the validator was always Y.Lang.isNumber. When the user cleans the input, the inputs are cleared with an empty string, but the model was not in sync with view. So the attributes contained the last value and not the default one. 
*Problem*: If the user types the same last digit in the last input field where she typed in, the conversion does not work because there is not 'change'. For that attribute the model saved the last value, that's the last digit.

So I recognized it was a bad practice to clear manually the view. If I reset the model, there is not need to use a clear method in the view: change event and the rendering of the view do the work.

*Attempt #3*: We have always NaN as default value and Y.Lang.isNumber as validator. I removed the clear method in the view and I added the reset of the model when the view is updated.
*Problem*: When the user clean an input field, the model is not reset, because the default value is NaN and this value is not validated by the validator method. The input fields are not cleared.

I tried to fix it with the setter approach. See the short story above (and this is an infinite loop). :)
utils is not imported.
forgot to verify `lastSender == testActor`?
the outermost wrapping parens are not needed
Shouldn't we say how we want the branch to be named? Like the old text did? Having a meta-description like "it's up to the team" is not helping the contributor to do the right thing.
From user api, its:
Companion object providing factory methods.
I usually use `val idCounter = Iterator from 0`
I prefer

  filter { case (t, _) => t.isResponsibleFor(remote) }
What is this intended to be used for? I'd like to avoid duplication (Why isn't it an ActorRefFactory?)
ok I'll just use get
Three is a magic number? Why 28?
why the constant?
Yeah, that was a bit dumb, but I'm unclear how it breaks anything.
should be $replace_options or empty($this->options)
according to coding standards
Yeah - would like to combine all the various options to one logging section when more are added. There's a lot of "mess" still left in this stuff for debugging, that's why the new branch. Actually only branched it for pike to download so I would take this commit seriously for final code....more a hodge-podge of WIP.
I'm confused. Why would it be `all` instead of `__all__`? Or were your instead referring to the missing comma, which is what turns the variable into a tuple rather than an ignored parenthetical (the above will be evaluated simply as a string)?
FTR, this has nothing to do with python 3, but rather distros not adhering to [PEP 394](http://www.python.org/dev/peps/pep-0394/)
Just tried testing this but it fails on one of the existing xmlpoke tests.  Did you test this before requesting the pull?
Ya, the std(rician) isn't exactly sigma, it's pretty close to sigma, especially as sigma gets small (snr gets big). The exact form is on Wikipedia.
Wouldn't you rather import numpy as np and then call np.array?
You're right, it was because of the default argument.  But also because I don't want to modify the query list that the caller passes in.

I'll fix up the default arguments, but leave in the list-copy.
I thought I needed to clear this on depenents, but it turned out I didn't.  Will remove.
Like any good validator, just add your errors to the object.
It's not yet really defined how I'll implement the consistency manager. The reason it's in the abstract class is that I'll try to inverse the control for the concrete consistency manager, so it would be the abstract that does that. Let's keep the debate for the next iteration? ;)
You might wanna cast the return value of asInteger() to (int) because it returns int64_t which doesn't match %d (same further down).
use a cevent, it can handle the sleep too and is thread safe.
is this one needed too?
IsURLEncoded is a really bad name since only parts of the url can be urlencoded like hostname/password/username/options.

The function should return if the protocol in question has an encoded path. Noth if some sub-protocol has it. Feel free to add some other helper function that handles the stack complication.

We should strive at not mixing things that apply to the protocol itself and things that apply to a combined url.
I checked some places and K-9 doesn't do anything with these flags so it's not a bad thing, they just get synced now. It's good for when we would add support for them.
this should be a separate scenario.  You should not have a ``Given`` section after the ``Then``
Why is this a default value? I can't see but one use case for the default, which is the seed of the AtomicReference, where I think it should be explicit?
remove the trailing comma, please
@galaxas0 so what you're saying is we should change it to "OHMYGODMYNAVIGATIONCONTROLLERISDYING?" :+1:
Perhaps we can talk about this at a later date, I was thinking more of another method that took a completion block `- (void)pushViewController:(TUIViewController *)viewController animated:(BOOL)animated completion:(void (^)(void))completion`.
I wonder if it's a good idea to rename `isReadable()` to `readable()` so that it's consistent with `ByteBuf.readable()`.
"path" and "ext" are never used - use "_" instead
@emboss Thanks to you for reviewing :)
There's no need to assert for nothing raised, just make sure you're getting the right response from the sql piece. Try to test some different sql as well.
We shouldn't be referencing the bug here. There's no more bug after the code is done. ;)
Probably, you can replace 'type' with +type+ for code formatting.
Maybe we should do it just if the given key ends up with html? We could even use the logic in: https://github.com/lest/rails/blob/53df3a9b198d902300d7555cd5b1dbd347f397d6/actionpack/lib/action_view/helpers/translation_helper.rb#L84
The method itself is pretty much self explanatory.
Also, in my opinion it's good practice to use perRunCaches whenever possible.
Because I inherited it from the previous implementation and didn't notice.
Any comment here?
That's a nice one! Thank you.
I hope you called it MAGIC_NUMBER, for clarity, and this test becomes:  `if(MAGIC_NUMBER is magic)`
Why has this method been removed?
Indeed, I meant to add 

    "The `n` frequencies are equally spaced and range from two orders of magnitude before the 
    minimum pole (slowest) to two orders of magnitude after the maximum pole (fastest)."
i don't care too storngly
cool, removed (I'd seen Bob's around ;)
Thanks for finding this. Duplicate test removed.
Okay.On other function, I am not able to see how can I have the functionality of finite_diff() with existing sympy code, it's necessary for further work in kauers algorithm. Can you please tell me how to do that?
:math: is not needed here.
And it would look better as before but properly aligned.  

But if you insist on making the lines shorter than 80 characters, perhaps you could indent the `[` lines.
sorry not nil ... but raise an exception because of
```
raise "Missing specified file_path" unless @file_path
```
Remove space after commas.
use getType(additionalNAme); Remove the try, the getType function does everything for you
clean out thees log before you mark this for release. When you feel that it is ready mark it with an @version x.x.x
Could we wrap `closeWithFadeoutDuration: with backticks? Ta.
In particular, it seems it's failing with ENOENT.
Longer oplogs aren't really a solution to repl lag, just a way to either delay the need to resync, or for sets that have a "bursty" usage pattern, make it possible to support longer bursts of high activity.
what happened to this section, it looks like it kind of got lost...
db.printShardingStatus()
Yeah, I alluded to it in the PR description, it was triggering ruby warnings that were tweaking my code OCD.
Shouldn't we also change phpbb.add_ajax_callback to phpbb.addAjaxCallback?
@igorw Do you know of a way to setup the YML config better for this?

Also, is there any way to, for the different drivers, allow sending different parameters to their constructors without defining each cache driver type in the config (if we can remove the cache directory handling and leave it just to the file cache)?
Should probably be `Are you sure that you wish` - while it isn't strictly necessary these days, it sounds better. `extensions` also needs an apostrophe, I think (possession).
The description should probably contain "Globally recognised avatar".
Yes you are correct. Not sure why this version ended up in my repo :/.
Yes it is needed, see https://github.com/phpbb/phpbb3/pull/1082#discussion_r2130850
You can remove this comment too.
Function is lacking tests.
jslint will give a warning on the last trailing commas. not sure it matters to us, though.
Is this required? Is this for cygwin or for 64 ->32 building?
@KevinVdV, one minor comment.

I'm assuming that we should also remove the "VersionHistoryForm.title" and "VersionHistoryForm.trail" from the corresponding i18n messages.xml file? 
https://github.com/DSpace/DSpace/blob/master/dspace-xmlui/src/main/webapp/i18n/messages.xml#L2259
Type: Science -> Since
this is not true!
the break here has no sense, because LOG_TEST_RET will always return SC_ERROR_NOT_SUPPORTED before
-----------------------------------------------------------------------

shivam shah wants to stay in better touch using some of Google's coolest new
products.

If you already have Gmail or Google Talk, visit:
http://mail.google.com/mail/b-f7a4bf86c5-e8b8288e3a-Fo7oe5m46ORbws7bhgLomDhwkX8
You'll need to click this link to be able to chat with shivam shah.

To get Gmail - a free email account from Google with over 7,500 megabytes of
storage - and chat with shivam shah, visit:
http://mail.google.com/mail/a-f7a4bf86c5-e8b8288e3a-Fo7oe5m46ORbws7bhgLomDhwkX8?pc=en-rf---a

Gmail offers:
- Instant messaging right inside Gmail
- Powerful spam protection
- Built-in search for finding your messages and a helpful way of organizing
  emails into "conversations"
- No pop-up ads or untargeted banners - just text ads and related information
  that are relevant to the content of your messages

All this, and it's yours for free. But wait, there's more! By opening a Gmail
account, you also get access to Google Talk, Google's instant messaging
service:

http://www.google.com/talk/

Google Talk offers:
- Web-based chat that you can use anywhere, without a download
- A contact list that's synchronized with your Gmail account
- Free, high quality PC-to-PC voice calls when you download the Google Talk
  client

We're working hard to add new features and make improvements, so we might also
ask for your comments and suggestions periodically. We appreciate your help in
making our products even better!

Thanks,
The Google Team

To learn more about Gmail and Google Talk, visit:
http://mail.google.com/mail/help/about.html
http://www.google.com/talk/about.html

(If clicking the URLs in this message does not work, copy and paste them into
the address bar of your browser).
again - can remove store from view and create a store file -- better in the long run when we tie this into database of pharmaceuticals
Please be precise in your strings. 

* Why is REGISTRATION all capital letters but "REGISTRATION Desktop" in both capitals and lower-case? -> Strings which a user sees on-screen should not be all capitals (unless there is some exceptional reason). Please update the text to "Dashboard", "Screener", "Registration", ... etc
* "You Dont Have Permission *ToAccess* Any Module". -> "to Access" should be two words, separated.
try to be very specific in your language when writing tests. These are the errors others will see when something in the product breaks. which response? which ajax call? there are a TON of responses and ajax calls throughout Raxa :)
nit: 2 lines extra whitespace
+here
I've used the term 'Python package' above to try to separate python modules from other libraries.
The situation with the type of w is somewhat complicated.   Numpy's linalg use a private method (_commonType) to determine the type of output and a comment there says: "in lite version, use higher precision (always double or cdouble)."  I checked in a solution that simply probes linalg.eigh to determine the correct type.
There's no reason for it to be an inner function. Move it to module level. If you consider it an implementation detail, rename to "_normalize_name".
The parentheses are redundant.
Why bother doing an explicit match against `ok` here when the 2nd match does the same thing for any reply.  I.e. nothing different is done between these two matches.

```erlang
{Reply, State2} = do_get_lock(...),
{reply, Reply, State2}
```
In this test here you test that there is a company returned or that the behavior tested is returning some job or jobs, right ? I don't where you verify that there is returned job, the returned job is not null, and that the returned job is the job that you want to be returned no any other one.
"An not None" should be "A non-None"; but the whole sentence is a bit confusing anyway. Consider rewording the whole sentence. "An empty ``update_fields`` iterable will skip the save. A value of None will perform an update on all fields".
This section should probably note that using the various variables in the py3 module is preferrable to branching on `if PY3`
Good point - I've just implemented this.
I guess there is no need in `and return(false)`.
Unfortunately, we need to know that our conditions pass before requesting `callbackName` from a function (because of side effects on `s`), and we need `callbackName` for the regex replacement value, so the order really does have to be 1) test url/data; 2) get callback name; 3) replace.

That being said, I am still performing a redundant check on `hasCallback`. Fix forthcoming.
So, I'm guessing 1.7.2 just didn't have the context check?
Change note to doi. The url field then redundant. Not sure if it shows up a second time in the bibliography, if a doi field is already there.
Adding a reference to Matlab would be good.  I'll add a reference into the source.
This is a no-no. You shouldn't run gettext on variables--only on strings. Otherwise the script that extracts the strings to be internationalized doesn't work correctly.
Spaces after commas here, thanks.
I was thinking about that, but then thought it was better not to because we can't handle the import checkbox inside MusicSetupVBox.  It seemed like if one gets handled outside the class, both should.
That's a notification that the RLIMIT stuff is done and real data can be sent to the sandbox. I'll add a comment.
Hier koennte man auch wie bei einem array mit doreach die public properties iterieren,..
this signature is QtCore.Signal(str,dict); 
so this should be 
self.contactsRefreshSuccess.emit(self.mode, {} );

I'll update it.
Hash code collisions: two methods with different names can have the same hash code (e.g. the strings "FB" and "Ea" have the same hash code).  See: http://en.wikipedia.org/wiki/Java_hashCode()#section_2

Before my change, methods named FB and Ea would be sorted lexicographically by their full signature, so if FB was declared as "boolean FB()" and Ea was declared as "void Ea()" then FB would come first because "boolean" comes before "void."  After my change, Ea would always come first.
it's better to create the file once and reue it in the loop.
Would you agree?

I am afraid that people in the first looking without the code may not understand the use case when it happens.
Hopefully the Java API guarantees this behavior in run5, however the IntrruptedIOException in run6 (FileInputStream, FileReader, etc.) is thrown only on SUN machines.
This file is unnecessary since you've just pointed to the root English translation. Without this ``urls.js``, Brackets will default to the english translation. Feel free to remove this file from your pull request.
I started to move *some* of this into ProjectManager. And I agree that there's a better way to announce/notify that the resize is happening. Once ProjectManger gets refactored I'll see about fixing this but for now I think this is the best way (if I understand everything)
Does that need to be configurable a la APP_NAME and APP_TITLE?  Is there a separate Edge Code Twitter handle?
I was thinking of DocClass === null where a document does not have the extension and explicitly checking for that. But yours is better and also covers that case.
I am pretty sure "Go now!" is wrong in this context.
The current sentence is directly translated and valid.
It may say instead "Last ned nå" -> "Download Now". I see often see MS uses this label text on their links for downloading products.

http://windows.microsoft.com/nb-NO/windows/downloads/windows-xp
I removed the "g" global from the rexeg expression which seems to fix this since the matcher for the list only does prefix matching right now.

-----Original Message-----
From: Randy Edmunds [mailto:reply@reply.github.com] 
Sent: Wednesday, July 11, 2012 7:35 PM
To: Ty Voliter
Subject: Re: [brackets] HTML Tag Code Hinting (#1236)

> +            this.editor.document.replaceRange(completion, start, end);
> +        } else {
> +            this.editor.document.replaceRange(completion, start);
> +        }
> +    };
> +
> +    /**
> +     * Adds a single item to the hint list
> +     * @param {string} name
> +     */
> +    CodeHintList.prototype.addItem = function (name) {
> +        var self = this;
> +        var displayName = name.replace(
> +            new RegExp(StringUtils.regexEscape(this.query), "i"),
> +            "<strong>$&</strong>"
> +        );

I notice that this can highlight multiple substrings in an item, which seemed a bit weird. Is that intended?

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/1236/files#r1146530
Should that be `waiver` ?
loose coupling, `List<FunctionElement>` is enough :-)
This code, which skips over a string[] without deserializing it, was wrong and was throwing the DeserialiationState into the middle of a field.  Fuzz tests found this.
Combine into one import line.
This is interesting. Moving the declaration of `i` into these functions would be good practice. Right now, there's a risk that `i` will get stomped accidentally by code that isn't related to these loops (e.g. if you run a function inside this loop that, in turn, uses `i` again).
Why not check the name here too since it's what you've been changing the source for?
It ends up having our license more than once, plus any license block in any of our files.  The result is a mess of 40+ lines of comments that look weird.  This was a nice way to dump it all.  If we don't do this, we need to do some work to clean-up our license header end-result.  New bug or leave this?
`_this` confusingly refers to an instance of an object, usually created by a constructor. Instead of referring to `_this` at all, just create some variables, and return a literal (`return { ... }`) that exposes them here https://github.com/mozilla/butter/pull/1069/files#L9R107.
you can just call 'return;' and drop the 'undefined' bit. or even drop the return outside of the  check completely?
Actually, since "if no id is  specified" is a dependent clause and "then return a list of all objects" is an independent clause, the comma is not only grammatically correct, but preferable.
The shas coming from git tools are always lowercase, so we could remove A-Z in that character class if we want it to match fewer things. Although the git tooling handles uppercase shas.
pointless guard
Longer term thinking here - how would this, and other, fields get updated on underlying data changes?
this option should probably go - or change meaning, of course
I don't think this simplifies the code -- it makes it much more difficult to read.
Question for msuchy - dont we need to do proper package rename for this
case? Because alchemy replaces converge-ui, therefore we need an upgrade
path. Or not?

LZ

On Thu, Dec 06, 2012 at 04:56:47AM -0800, Eric D Helms wrote:
> > @@ -114,7 +122,7 @@ BuildRequires:  rubygem(fssm) >= 0.2.7
> >  BuildRequires:  rubygem(compass) >= 0.11.5
> >  BuildRequires:  rubygem(compass-960-plugin) >= 0.10.4
> >  BuildRequires:  java >= 0:1.6.0
> > -BuildRequires:  converge-ui-devel >= 1.0.1
> > +BuildRequires:  rubygem(alchemy) = 1.0.0
> 
> I agree with you, the problem is if you look at the line where we copy the files in from the gem - the folder there includes the version of the gem and thus needs to be sharply defined :/
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Katello/katello/pull/1209/files#r2334388

-- 
Later,

 Lukas "lzap" Zapletal
 #katello #systemengine
please don't do this in the composer.json. We don't want to pollute the autoloader of all people using the library with the test namespace (the autoloader is faster when you don't add useless stuff in it)
am confused: why are these necessary?
You don't need ```connectionIdField``` at all here.
For consistency with other `setTimeout(foo, 0)` statements elsewhere. I realize now it was the only one in this app… :-/
I prefer leave it so we don't have to write it when addEventListener is fixed.
Bad indent again :(

Set your editor to auto-expend tab to two space please.
Actually, our API supports both - I know it's long, but you should read it closely :).  `convert_to` will do the actual work, but `c.galactic.l` will call `convert_to` behind the scenes.  We will want to support user-defined coordinate systems and transformations to/from them, and we don't want them to have to require them to register the names of their coordinate systems in all classes of relevance.

We had indeed planned on caching, but the points raised here about scaling are good ones.

Here's my proposal: for scalar or small array instances, the caching is done. An `astropy.config.ConfigurationItem` sets the upper-limit on the size that can be cached.  If an array larger than that is done as `c.galactic.l`, a warning is generated saying something like "caching can't be done for this size array". The ``.galactic`` syntax is intended mainly for convinience in our API.
Should this be ``USE_NUMPY_FFT()`` and ``NTHREADS()``? Also, do we want them here in addition to the configuration file?
Just to clarify what I said above - the templates were originally in the sphinx source tree, so it turned out the easiest thing to do was just move them to our source tree rather than try and have a mechanism for specifying custom templates. If you look <a href="https://github.com/astrofrog/astropy/blob/9780c533874a7e1da3f366cbf4a430fd312cb9b2/astropy/sphinx/ext/automodsumm.py#L294">here</a> you'll see that there is no mechanism for adding custom templates if a builder is specified (which it is) so if we wanted to have a mechanism to replace the autosummary templates, we'd have to implement it (hence why the above was simpler). It's just the only way I could figure out without more extensive changes to the template infrastructure in this file. I might be wrong though!
Should the download URL then be set manually on PyPI?
I think that

```ruby
class LoadBalancer < AccountResource
  PROTOCOLS = ['http', 'tcp'].freeze
  SECURE_PROTOCOLS = ['https', 'ssl'].freeze
end

if LoadBalancer::PROTOCOLS.include? protocol
if LoadBalancer::SECURE_PROTOCOLS.include? protocol
```

What do you think?
Looks like mine is supposed to be different actually, since I added a new migration (...210730_create_listings.rb) and ran it.
Im assuming it does, but this does call message_queue::remove, correct?
I'm not sure I agree with removing this. The "..." here imply that more information is going to be asked (ie, beginning and end of range).
@markstory There are checks on related table fields

@dereuromark This does not check data, it checks what the field is setup as.
Yes i have a whole bunch of these, was not sure about it, but i can convert all the array_keys uses in foreach.
This might be nit picking, but wouldn't the HTML formatting be better placed in the TimeHelper class?  Usually we try to keep the library files free of HTML and keep all the HTML related features in the helpers.  They have a number of method for building attributes, and creating tags that reduce repetition of HTML generating code.
unset will unset the properties of the class, not the values of the properties
current_training()
Why use the fully qualified class name when you have a use statement  for it?
if there are variables describing these numbers, those should be used instead of 6 and 7.
As far as I know 2to3 just checks for the presence of the `from __future__ import print_function` line.  If it is missing it blindly follows the conversion rules (even if they are totally silly).

This begs the question of whether or not to include the `print_function`.  I guess I'd be for the inclusion as this will prevent developers from accidentally using Python 2 print syntax, but I'm pretty indifferent overall.
only one test needs an instance, create it there in a try/catch block
interesting :) maybe some javadoc at the head of this file explaining usage
At this place we could probably use CanCan to authorize.

    authorize! :read, @child
I don't know off hand either, but it won't hurt.
As I haven't found a proper case when this wouldn't be required, I tend to generate the solution with the `-DTHREADSAFE:BOOL=ON` option. ;-)
this one you actually *can* remove altogether, yes :)
nit: inconsistent blank line at the beginning of the block.
I'm not sure what to do here. This appears to be required by our very old pager library, and I suspect it would be a lot of work to figure out how everything works and separate it into another file.

At least it's not tons of js. When we CSP-ify the site, we'll have to fix the pager library anyway, and then we can remove these things across the entire site.
can you create a new bundle for these two files and only include it on the edit/new/translate pages?
It seems like there would that tastypie would use the ProductVersionResource to create objects, instead of doing it this way.  I'm not remembering.  Is this because we do some special handling in ProductVersion.save() ?  And TastyPie won't call that?  Just checking.
Actually it's correct. I was confused by the docstring for the resource itself, which I think is misleading - I'll comment on that where the resource class is.
null case: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/FormFactory.php#L336
btw, your tests should cover such cases :)
Is it save to call a class String? as this may interfere with type-hinting for basic types.
Yes, this can be solved by precomputing the size the parameters will take and using 1 buffer writer. This would eliminate the copying and the object creation.

In retrospect, I am not sure how I reasoned that all this object creation was okay.
prefix all these with "profile."
这个是draggable运行的demo页面，可以不review，发布前会制作更好的demo。
Moved, good point
Oh sh*t, it was for our own server. I'll revert and push again.

@mazdak

Sent from my Mac

On 2012-03-13, at 1:06 PM, Benoit Chesneau wrote:

>>         def clear(self):
>>             old_clear(self)
>> -            self._headers["Server"] += " (Gunicorn/%s)" % gversion
>> +            self._headers["Server"] = "RTB"
> 
> why changing the Server header here ? Can you revert this change for the merge?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/benoitc/gunicorn/pull/312/files#r552654
RT's core language is English, and "Leiras" won't localize well.
Le sigh, I fail at copy/paste :)
Apologies; I said I'd comment again with a link, and then got distracted and didn't. :(

At lines 64 and 66 above, the expression is now getting resolved. But at lines 80 and 83 that resolved value is being written back into the model, which means if it was an expression, that will now be lost.

That's what I was going to try and deal with in a possible fix -- keeping both the resolved and unresolved values around -- but as I started working on that just now, I don't really understand how the stuff between lines 69 and 76 are meant to work in all the various cases.
I changed the xsd instead, since I like this attribute last.
For legacy stuff mark the attribute as .resourceOnly()

and when you register it, do something like this
registration.registerReadOnlyAttribute(NAME, ResourceNameOperationStepHandler.INSTANCE);
Fo your information:
<blockquote><b>Notice</b>:  Undefined variable: authUserName in <b>/Users/krinkle/Development/github/jquery/testswarm/inc/actions/WipejobAction.php</b> on line <b>74</b><blockquote>

Don't worry about amending right now, as I'm including this in #209 (keeping you as committer in the metadata).
能拿到，不过这个controller里面没得用到。一哈我把它删哦。
nit: remove -moz
Working on it! I'll keep you posted ;-) Thank you everyone.
At the moment, I leave the script but with no backup section due to the commentary I did few moments ago (see next). I think this is useful enough to be included and tested and If it result stable and very useful we could add it to <tt>make install-gaia</tt>. Don't you think?
you mean "removing the mouse2touch.js doesn't work"?
I've been meaning to write a utility function like this..  Having to remove the listener after it fires is the thing that makes these events annoying.
add return; and remove the else.
to which this corresponds? I don't see it on the actual PR
Where does the |1200| magic constant come from?
Of course, I'll remove this.
Ugh, this should be equivalent.

If this really fixes the homescreen, then we have a serious platform bug on the navigator.language side.
please 80 characters
can remove anyway given above comments :)
Yes, CustomBuilder will be removed once the transition completes.
`sjsServer` and `sjsConfig` are refactored out of the `EventBusBridge`. The `DefaultSockJSServer` now uses `installApp(new EventBusBridge())` instead of just using `new EventBusBridge()`
what about calling `didCreate` ?
klaro ;-)
I think i was confusing... it always added the ca to the end even if there was one there so "Hayward, ca" became "Hayward, ca, ca"
It appears you're still discarding the new page and returning the old one...  To properly /replace/ the page, its plPageInfo should be replaced in the ResManager as well.
Maybe `github_oath_confirmation` would be a better name?
What is a .env file and why do we want to ignore it?
I am not sure what the intention is here.  Wouldn't a player really only be talking in 1 chat channel?  "Broadcast" seems like the wrong term.
it'd be nice to test the `-n` option
Builder name is still unique, but it's not something that can be used in a routing key (since it has arbitrary length and is Unicode).  We've gotten ourselves in trouble already by using builder names -- they cause problems if they contain slashes, they run into string-length limits in databases, round-trips can change unicode normalization, etc.

It'd probably be useful to have an Endpoint that can lookup a builder (or master) id by name, though.
Stupid question, how is this different from indexOf() is 0? Does it stop searching if it couldn’t be found at 0?
What @Flaburgan said.

Also I'm missing the update for  the new `.get_location` in `_publisher.html.haml` to `en.yml`  ;)
no! last time I say this, I don't know how post.haml works but it's not invoked on the followed_tags page, I suggest adding gon to application.html.haml
オーバーライドすべきコア関数である。**render**では常に`this`を返すことが一般的に行われている。
I suggest to add a link back to main page, i.e.

<a href="idx.ht"> Back </a>

See other pages for examples.
may be "Contact asks for your attention" ?
Only anonymous function need space.
Had named function no need space before `(`.
This should be on your personal (and global) `.gitignore`, please do not commit platform/ide specific elements here.
This and other regex is  taken from [JQuery combobox demo](http://jqueryui.com/autocomplete/#combobox) and by my experience it works good. Basically, if we do not need all cases covered with it we can make it more simple, ie. to just escape parentheses and dot. what you think?
Does this work on the production server as well as on the developer's machine? Let's try a test script on the production machine before we change anything else.
Vamos colocar ao contrario: wres.tour é dependencia de wres.policy.
It isn't very clear when `selection` won't be a `nsISelectionPrivate` and what will happen if it isn't.
Before we listen to select event, now we don't.
Shouldn't we still listen to this event -or- throw exception or display an error if selection doesn't match this interface?
I'm basically pointing that this code and related comments don't reflect the reality.
It seems to be designed for the future manifest. 
`isPseudo` and `isBuiltin` names are misleading. I'm wondering if it wouln't be easier to just move their implementation here instead of finding correct names.
isPseudo matches pseudo modules (@packaging, @loader/options), but not all of them: chrome. And it matches future system modules.
isBuiltin doesn't match anything else except `chrome`.
It may be relevant to use similar names to your upcoming manifest work: https://github.com/mozilla/addon-sdk/wiki/JEP-Linker
The most important is to be consistent to the current file style, but this one is using both :/
Otherwise I talked to @Gozala to suggest using `"` over `'`, as mozilla codebase suggest them:
  https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#Literals
But nothing concrete happened.
I can at least convert to a unique style for this particular file?
I don't think you even need this `destroy`. You could just use `unloadSandbox(Object.getPrototypeOf(cuddlefish))` from here and have hacks limited to bootstrap.js
since this is for QUnit tests, should add "module" to this list.
Yeah, I understand that in theory if everything is done right the additional check is not needed. I'm just wondering if there is any downside to having it anyway as a safeguard - since if there is a bug in a higher-level method it could perhaps call `mark_complete` with the wrong id - if we had the safeguard in place that would become a no-op rather than a data-loss bug. Does that make sense.
With this sample crontab, any projects in the "medium" batch would never get run? That seems problematic.
It's not something I can find in the `getWindowTitleForBrowser()` implementation of the tabbrowser.xml file, so my request still stands.
This method should remain protected.
I think there was confusion, because you called your variable "v". I would suggest to call all helper variables "u" instead of "v" if they mean "u".
For example, also in Boris, use
double ux = getVx()
instead of
double vx = getVx()

Also, in calculateGamma(), first you calculate the square root, then you calculate the square of u (I'm using "u" here instead of "v"):
double u = Math.sqrt(ux * ux + uy * uy);
return Math.sqrt(1 + (u / c) * (u / c));

You need one square root less if you write directly
return Math.sqrt(1 + (ux * ux + uy * uy) / (c * c));

The comment of calculateGamma could explain more, for example:
"gamma = sqrt[1 + (u / c)^2]. This expression is obtained by solving gamma = 1/sqrt(1-(v/c)^2) with v = u/gamma for gamma."