labofsahil/github-event-dataset-2012 huggingface dataset:
did you mean to not replace the symbolize with a call to intern in this spot?
It doesn't seem like the constant really has much value here.  Just inline the string.
@vrthra Can the should value be an array? Related to this, can multiple versions of a package be installed, like the gem package provider?
Could you explain the problem a bit more?
It might be nice to include some sort of bare-bones example of how the router interacts with apps. This is a little too verbose, but I was thinking something along the lines of this:

```python
from rapidsms.apps.base import AppBase
from rapidsms.router.base import BaseRouter
from rapidsms.messages import IncomingMessage
from rapidsms.models import Connection, Backend

# a very simple app that replies "pong" after receiving the messaging "ping"
class PingPong(AppBase):
    def handle(self, msg):
        if msg.text == 'ping':
            msg.respond('Pong')
            return True

# create a new base router
router = BaseRouter()
# add our PingPong app (defined above)
router.add_app(PingPong)
backend = Backend.objects.create(name='fake-backend')
connection = Connection.objects.create(backend=backend,
                                       identity='2223334444')
# create a new incoming message
msg = IncomingMessage(connection, "ping")
# route the new incoming message through the router
router.incoming(msg)
# inspect the message responses to see that our app handled the message
msg.responses[0].text
"pong"
```

This is just a in-depth view of how the router handles messages. ``receive`` and ``send`` hide most of this.
Please use a before and after block for setting these up. It probably means that the spec should be encapsulated in a describe block, so something like this:

```
describe "with a different $/ separator" do
  before do
    @old_rec_sep = $/
  end

  after do
    $/ = @old_rec_sep
  end

  it "uses $/ as the separator when none is given" do
    ...
  end
end
```
This isn't a good idea. When using the active class, one would need more css properties to override from .carousel .active, then just having active-pill as a seperate class.
This one does not already exists ? The ProvidesEvent trait ?
Then there must be a pull request with that somewhere.. in current master I can find 118 constructors with "@return void"
Can you updated this do a null comparision? ```$yamlDecoder !== null```
Hmm, the whole point is to put it in consistency with the rest of Zend\Crypt
@ezimuel introduced [this flag](https://github.com/zendframework/zf2/blob/master/library/Zend/Crypt/BlockCipher.php#L47) to control binary/string output.
Also native PHP hash/hmac functions have this flag, so while I agree that constant is self-explanatory, should be no problem for developer to figure out what the flag means
Misssing new line?
Pranav IS our StyleCop :)
Remove ^
These types are all confirmed to be ok with SQLite?
lines 162-170 could be something like that (i think :) ):
var bool = !!url;
if (!bool || format === "bool") {
    return bool; // Return early.
}
Making absolutely sure we're starting off with an element with enough precision to handle tz shifts.
@vesak Turhan else-haaran voisi mielestäni poistaa.
Myyntipvm lisätty queryyn. Querylla halutaan panttituotteet, vanhin ensin.
Why do you leave it commented ? This is the main entry point for configuration
if you use <<- you can indent the EOF as well
But 4 hours later, it seemed now.
Are you saying I should not put "This client calls..." in a new paragraph?

Most of the quickstarts have one paragraph with the technologies demonstrated and a new paragraph for description of the quickstart.
Newline before this `click_button` action since it's the "exercise" phase of the test. Same for the rest of these.
+1, it should be `slug`. It isn't a URL or a path.
Thought about that. Figured I'd file another bug just to double-check and let people comment on that.
That said, one advantage of `$` is that it can also imply any jQuery-compatible API, such as [zepto](http://zeptojs.com/).
spacing here as well
actually, there are several spots in this function that need some whitespace
Cool. Adding a R2.1 task for this.
Do not use `assert`, use `validate`.
The classes here should be landmark heading.
Changing this to `it 'increases the interval by 5 minutes if given a confirmation status of :confirmed'`
are we sure to avoid printing 'null' here?
AFAIK bundle exec doesn't load the rails environment, only required gems. Almost the same code is used when calling rails console for example. But maybe there is a bundler feature I'm not aware of?
I cannot remember either, but it happened, and this fixed it.  I am sure if you leave that out someone will file a bug report later.
Mmm. I'm pretty sure a "bundle exec rake" can be flagged to load the rails environment. (Might take a little longer to run though.) See http://erik.debill.org/2011/12/04/rake-for-rails-developers
what do you thing about this one @ohadlevy ?
I did not want to remove the base error, there can be some dependencies on it. But I wanted to make it clear what type of error it is. 
see https://github.com/theforeman/foreman/pull/95/files#L0R19
Could this be solved with less restrictive use of locks? Like having a trackedConfigListLock to lock on.
`Modernizr.addTest('audiodata', !!(new window.Audio()).mozSetup);`

excessive parens
03e5f824d07d7699171876b03cf4b75f3f0f5602
I think @adrn was just showing that the second keyword is a unit. In actual code this would still be required right? e.g. `def __init__(self, value, unit):....`
sorry, didn't explain properly. there is file config.cluster.php that is there to duplicate the the file.ini settings, since the cluster stack doesn't use .the ezINI() settings(eats too much performance) the best place to put them is not an .ini setting, is a declaration in the config.cluster.php (the config.php-recommended has the description to create the file when setting the cluster). 

in versions <4.7, i guess they should land in the index-cluster.php(and we're going to need backports all the way to 4.5)
какую информацию дает слово calculate?
что ты имеешь в виду под словом coloring
This is a much better way to write the graph than alexey and I had...
It's bad style to put parentheses on a method call without arguments in Ruby - they're necessary for some languages, but not this one :-)
For internal code, I agree, it's not worth it. For stuff users access in `config.rb`, setting the scope for them makes sense.
Perhaps we need https://github.com/dbrady/scrapbin/blob/master/stupid/hash_with_indignant_access.rb
It is indeed possible according to the spec, but I haven't seen it on any of the pages I looked at. The only link that tends to be duplicated is stylesheets, and you won't be trying to paginate those.
Is there a good reason not to just wrap this around our top-level HTTP handler, rather than individual apps? Also, I'd prefer it to be written as a higher-order function like our other middleware (eg. `wrap-with-http-error-handling`) rather than a macro.
Grammar etc but I wonder if the semicolon is misleading as it could be interpreted as syntax required.
I agree with this but this is the opposite of a comment in previous reviews and is also why I didn't add it in here.
We shouldn't expose low-level file-system layout details like `node_modules`, and even `oae-core`. We could establish a URI scheme instead to identify the resource of a particular widget. e.g., 

`widget:/<userFacingwidgetId>/javascript/entity.js`
I don't think we should specify which methods will execute the documented method in jsdoc. That feels like something that could get stale real fast
I wonder if we should make this an UPDATE query and explicitly pass in the key to the method.
When you use an INSERT the first column name in the insert list must be the name of the cf key. It feels a bit brittle to rely on the key order of a hash object.

ie:
```javascript
var metadata = {
    'title': 'Foo',
    'description': 'Bar'
};
var contentId = 'c:sfsdf';
Cassandra.upsert('Content', 'contentId', contentId, metadata);
```
아 그리고 보니 option은 accessor로만 정의한다고... 이미 말했던거 같은데....
It's not an expected outcome, that should really not happen. I don't think we elide assertions even in compiler release builds.

I am not sure what to do:  throwing an exception would not convey the underlying assumption of the code. On the other hand, maybe the calling code wants to be able to recover... hard choice.
Why ````jdkEntries`` is not a ``Set`` already, i.e., why ``jdkPaths`` doesn't return a ``Set`` instead of a ``Seq``?
The logic is the same, but it is applied on elements which are not on the same part of the class hierarchy. JDI Type and Value have only in common the fact that they extend Mirror.
There is no problem to put the code in a trait, but I would prefer to keep the type vs value split.
ah, the semicolon
absolutely not, you should be able to explain conceptually how something will work before writing a single line of code.
makes sense. Will update
I have to do this for extracting file name easily.  Ok, this means It can be no quote with file name. Maybe use this regex: 

``subconf\s+(['"])?([-\w.\/\\]+)\1``  to get the valid file name


btw the include directive is the same way:

https://github.com/sitaramc/gitolite/blob/master/src/lib/Gitolite/Conf/Explode.pm
```perl
 /^(include|subconf) (?:(\S+) )?(\S.+)$/
```
A space needs to be put between keywords and parenthesis (and this has already been discussed in the thread) - same goes for line 393.
Also, you're not using `$callable` anywhere else so it might as well be just:

    if ( ! is_string($val) && is_callable($val))
Правильнее сказать не округлённое, будет использована просто целая часть вещественного числа, остаток проигнорируется.
P.S. Прежде чем вы углубитесь сильно в код - оказалось что я не синхронизировал вчера последний коммит. Только-что сделал это.
Обновите, пожалуйста, код.
Does this always raise an exception? I'm asking because of this: https://github.com/shairontoledo/rghost/wiki/Converting-PDF-into-other-formats See the checking for errors section. Thoughts?
:)  Nevermind, this isn't JS.
Actually, the initial declaration setting i to zero could be dropped instead.
That's not actually true, though. `BOOL` is `signed char` and can have any of the values in that range. For example, this "boolean" expression:

```objc
BOOL b = (flags & NSMinXSizing);
```

… might actually result in `b` having a value that's not zero or one.
Vim's autoindent-derps. doesn't seem to like functions within lists within functions, I'll go over these manually.
I recommend using different argument name for nojump here. When reading this definition, it might gives people a illusion like goto a specific page but not jump to it, which might brings in confusion.
When creating and updating client indentifier information, you are quering the database to check for uniqueness. The majority of the time this check would not be needed which is why its typicaly to use the 'optimistic' approach in these type of things and try to save the client identifier and let integrity constraints on database throw back an error if uniqueness condition is broken. 

This type of pattern was prevelant through old mifos code and the preference is not to do this but to use 'optimistic' approach and lean on database.

Is there any specific reason for having it this way as opposed to unique constraints on database?
Your right about authors file, but applications template and settings.less have been changed
The OrderValidatorTest already has this test since OrderValidator checks it
btw it's never enough to synchronize on writes and you also must synchronize on reads.
typo: The vs They
I've tested this, and it does look to be an issue.  Constructing two MongeezDao objects with the same Mongo instance and a non-null MongoAuth results in an exception:

java.lang.IllegalStateException: can't call authenticate twice on the same DBObject
	at com.mongodb.DB.authenticate(DB.java:430)
	at org.mongeez.dao.MongeezDao.<init>(MongeezDao.java:36)

You'd get similar behavior if you had a Spring config that includes both Morphia and Mongeez, used the same mongo for both, and provided the authentication information to both.
This should be reworded to ```The general purpose ``GenericEvent`` event class has been added in Symfony 2.1```
should be 0 based
Инвертируй условие и сдвинь на уровень идентацию же :3
Sería `staff` cuando se refiere a un grupo de gente asociado.
Tal vez en una migración, pero no me parece grave que el menú por defecto se genere ahí, yo lo dejaría así.
Doncha love it.  How's your schedule looking for Tuesday night?  I'll be available
You can see the apps you have access to in the status bar. I don't this this should be in the widget. (Norman too.) Can you remove the lines 8 to 13?
Ok, that's right. I only talked about general method chaining.
What was going on here that partnerLogin() would need to be called outside of the constructor?
Don't do changes like this, without knowing the code.
I've re-read this yet again, this does not make any sense.  Line 1731 is only hit when you have a remove() and *not* an activation.  So there is no need to "activate" anything or update any counters; all you need is a simple `cachestore.remove()`.  You may wrap this up into an `evictionListener.removeFromCacheStore()` method to prevent the cache store leaking into this code.

Looking at your code, activation only happens on line 1606 which does not trigger anything in `datacontainer.remove()` at all.
You can remove the `get` when accessing a property (see #95)
My point was that they are not relevant to the pull request -- they are in files that don't even contain other fixes.  Generally, I think white-space only fixes should be in their own commits and PRs.
this inspired me to make  #1475 to have plt.subplot() work just like plt.axes().

I'm happy to change this to just be plt.axes()
Now we are having to call get_subplotspec_list twice, once to figure out whether to issue a warning, and a second time inside of get_tight_layout_figure.  This is not good at all.  Either save and reuse the calculation here, or maybe move the warning into get_tight_layout_figure.
Hmmm....I realize this is from a previous commit that I must have missed but we set self.running_test and never unset it.  IMHO we should unset it in this method
таки фикс на это ждать/не ждать что б мержить можно было?
"charg**er**"
size attribute!
That is, check this out:

```clojure
(true? (#{"vcf" "hansen"} "vcf")) => false
(contains? #{"vcf" "hansen"} "vcf") => true
```
@jsloane I had a similar problem like this before, adding `width: auto` solved it for me. Can you try that out?

http://stackoverflow.com/questions/1771176/ie8-non-compatibility-mode-image-with-max-width-and-heightauto
Can this be handled some other way? I can't think of an occasion on which commented-out code in a shared repo was a good idea.
Yes, I might have been over-anticipating here. I'll try moving methods around a bit & see how it looks.
Are you sure ``$route->getDefault($token[3])`` has the correct type as ``*`` is not a sub-type of ``string``?
I removed `namespace` on JS-side :)
Соединение с БД (и все параметры для этого) так же должно храниться отдельно.
У вас в следующем маппере создается точно такое же соединение.
Fjern utvkommentert `notice()`
Is that right? Doesn't make sense to me.
file:// fails under windows and under linux

[ERROR] Failed to execute goal org.jboss.shrinkwrap.descriptors:shrinkwrap-descr                                                                                                               iptors-metadata-parser:2.0.0-alpha-5-SNAPSHOT:parse (executionJ2ee13) on project                                                                                                                shrinkwrap-descriptors-gen: Invalid URI syntax: URI has an authority component
This key is ignored by the Java SDK. Not sure if we want to mention it in this documentation.
OK. Then do concatenation.
I would do only account, to simplify.
Just instead of numbers, use some common string constants. For example, lower case English names. And then use that as a key.
There is difference between displaying error messages and selecting dependencies automatically. So this is needed to be able to select dependencies automatically. But I am just wondering here why it is necessary for it to be here and not for example to copy this in view or form constructor.
Of course also function could be changed to something a bit more intuitive. :-0 I am not sure where it came from. Maybe poedit program added it?
David, if there is more than one variable, then that case gets handled well. I have a test method in the test module which handles the case of more than one variable. We cannot have the yield at the end of the variables loop, because a variable's data may not get exhausted after one concatenate_block is taken out... Several iterations may need to be done (of concatenate_size lengths) before the data of the variable gets exhausted. So we need to keep the yield statement where it is.

We have some test methods for more than variable names and also for more than one files and they are getting handled properly. So this part is working as far as I know.
Давай уберем
Ahhh - I always forget about the initializers that inject things according to interface. You'll still want to follow the pattern they use throughout the framework when something implements EventManagerAwareInterface:

https://github.com/zendframework/zf2/blob/master/library/Zend/Code/Annotation/AnnotationManager.php#L40-L69
In that case, maybe you shouldn't have a constant in this class, otherwise you'll end up having circular dependencies (ContainerCommandCompleter depending on ArquillianPlugin). You could consider moving this attribute to ContainerCommandCompleter then.
Ah, que no escapan html, perdona. Me refería a que un tag ul solo puede
tener tags li como hijos, no puede tener por ej un tag strong.

También asegúrate de actualizar el enlace al wiki que en la versión 1
aparece el link a lastinieblas en lugar de a gm.

2012/9/17 Leandro Crisol <notifications@github.com>

> In app/views/layouts/_footer.erb:
>
> > +       <li><a href="/site/netiquette">código de conducta</a></li>
> > +       <li class="last"><a href="http://wiki.gamersmafia.com/">wiki</a></li>
> > +   </ul>
> > +</div>
> > +<% end -%>
> > +
> > +
> > +<% show_ab_test("mostrar_redes_gm_en_footer", 1, opts={:add_xab_to_links => true}) do %>
> > +<div class="mcontent">
> > +    <ul class="second">
> > +       <li><a href="/site/faq">Ayuda</a></li>
> > +       <li><a href="/site/netiquette">Código de Conducta</a></li>
> > +       <li class="last"><a href="http://wiki.lastinieblas.com/">Wiki</a></li>
> > +    </ul></br>
> > +    <ul class="second">
> > +       <strong>Síguenos en: &nbsp;</strong>
>
> Lo siento, pero no entiendo lo que quieres decir aquí, a mi me sale esto :S
>
> Un
>
> solo puede tener
> como hijos, ¿puedes añadir
> a esta línea?
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/gamersmafia/gamersmafia/pull/198/files#r1616753>.
>
>



-- 
Juan
radius, http, https capitalization
Doesn't maven put all changes inside "target"? Why are we using a "build" dir?
$node -> $title
Nitpick: `contentmode` and `mime_to_content_mode`. Could use `content_mode` instead.
line too long; 80char max
There is a better way. From the Zsh man page:

```
       %d
       /      Current working directory.  If an integer follows  the  `%',  it
              specifies a number of trailing components of the current working
              directory to show; zero means the whole path.  A negative  inte-
              ger  specifies leading components, i.e. %-1d specifies the first
              component.

       %~     As %d and %/, but if the current working directory has  a  named
              directory as its prefix, that part is replaced by a `~' followed
              by the name of the directory.  If it  starts  with  $HOME,  that
              part is replaced by a `~'.
```
+1, that's clearer.
I guess this doesn't need to be here, seeing as there is no database.
Renamed to drawHighlightPointCallback
It doesn't seem to mind a `git_treebuilder` that much (it doesn't crash in the tests). Some example code must have been wrong about `Py_XDECREF`. I saw it being used with a guard. I'll update shortly.
This should be getBeta().
You don't need to use np.testing.  You can just use python's assert:
```
assert not ((g1[0,0]==g1new[0,0]) or (g2[0,0]==g2new[0,0]))
```
Done and pushed!
Done for next push
I think we should make this change after the networking exam closes.
you'll probably write a `save_feedback_log()` and call it here?
Do you really want to synchronize on this while calling ensureUnclaimed? That will potentially create new machines, which I presume could take minutes.
This is a different slf4j.version. Can we define this at a top-level, and just inherit? Or do the other new dependencis require this specific version? From memory, 1.6.6 is the latest 1.6.x version - should we be using that?
This should probably be null by default so as to not change behavior unless requested.
`achieve` ne se construit pas avec un infinitif, et faut faire gaffe a ne pas rajouter des `achieve something` quand le simple something marche tres bien.
ici prefere `Fab communicates their beliefs with such a passion...`
Aren't all-caps variable names used for constants by convention?
Yes, diff got confused. Basically, I pulled out most of the behavior of Collection into ReadOnlyCollection, since I needed it for modular inputs (which are read only). Then I had Collection inherit and add the create and delete methods.
same here, you may want to check to see if options['yes'] and if options['no' ] is defined before calling them.  you previously check for 'yes' OR 'no', not both
Ah - there may have been a mix-up here.  I was asking for you to *add* i18n tags, not remove them.
Actually, to be honest I do not see the difference between `XMLFetcher` and `WalkScoreFetcher`. I.e. I see that they do different things, but both are tightly coupled with WalkScore API. 

I think refactoring into `WalkScore::Fetcher` and `WalkScore::Response` is the pattern you are looking for here. 


Same goes for `WalkShed::Fetcher` and `WalkSher::Response`. `JSONFetcher` is too generic of a name and too coupled with WalkShed.
Die INIT_PATH_LIBRARY wordt nergens gebruikt omdat het een INIT is :p Er is nog altijd  PATH_LIBRARY uit de globals die in de eigenlijk code kan gebruikt worden.
Don't remove this empty line.
:hand: :heart:
It would be better to make the class HeadersAndBody and have the Map as a member.  I don't know what i was thinking ><
Wdyt about?

private IdGenerator idGenerator;

	/**
	 * This will default to {@link DefaultStoreFactory} if not provided.
	 */
	private StoreFactory storeFactory;

	public DataManager() {
	}
Можно это оставить так?
Main reason was I had a ModelForm I wanted to use already, and get_moderated_form was ignoring it purposefully. I then tried deriving my ModelForm from BaseModeratedModelForm, which worked, but then I couldn't use that ModelForm elsewhere. This way, we automatically add the initialization code to a dynamically generated subclass based on the existing specified ModelForm.
@ctweney shouldn't this be a part of the `test` or `development` group?
Is it ok having `<code>readme.txt</code>` as part of the translation string? Should that be split out into a `sprintf` arg with `<code>readme.txt</code>` not translated?
Yeah that's it, sorry i forgot that there's variables on top.
The ajax wait in `click_payment_menu` is just not reliable enough when it is followed by the asynchronous query of the page title. 

I've experimented iwth chaning it to wait for the element with id=purchases and it is more stable. Can you give it a shot yourself?
We should use triple double quotes since they are used even though the string fits on one line according to Python Docstring Conventions . This applies to the below comments as well.
s/library/classpath ?
Это ошибка. Кажется, здесь был промежуточный код, который я изменил не полностью. Потом был рефакторинг для лучшней минификации…
Maybe `ar_relabeled` -> `relabeled`?
`ax.set_zlabel('Partial dependence')` => `ax.set_zlabel('Partial dependence\nwith house price')`
I've changed this to `boost_weight`. Commit coming.
can you also check that the size of the two sets together gives the total training set size?
And that training and test don't overlap?
pep8 blank line at end of file
Is there as reason you're not including `$this->getClassName()` here?
It is not good practice to have method with 6! parameters. Maybe potential target to simplify.
Accepted and modified
dmc has a bug where you also need to #define __STDC_LIMIT_MACROS to get inttypes.h to work.
same comment. Leave as long.
I think you're missing a check for whether **s** is a template declaration. Also using a goto like that creates an error:

```
expression.c(6046) : Error: initialization of 'IsExp::semantic::t' is skipped
```

I'll figure something out, thanks for tips.
HTML elements shouldn't be used here, please change this line to 

### Example of Advanced Query
Might wanna use a var name that differs from the member name by more than just the '_' suffix, to avoid confusion in the future.  I'd be ok with gt for the local var.
github is :)
I don't agree with you about this one. This is not premature optimization. We don't need to load it, why loading it ? This is just good sense :p.
Can we boil this down to one flag? This is really confusing. Surely we do want to check java/jar deps as well as scala deps?
I was meaning that the >0 test already covers the != -1 case

Unless the double test makes the code clearer (which I don't think it does)
I am pretty sure all it needs from the environment is that IP of the ldap server, perhaps we could pass it on the command line?
I don't think so, I don't think I even want this method in CThorSpillableRowArray, it's not in use.
I'll remove.
I don't want this to be permanent... It's just for me to debug while testing on multi-node environments... But I guess I could leave something decent for future tests...
People often struggle with running specific tests, so add

```

To run a specific test file, use for example::

    ./manage.py test crashstats/crashstats/tests/test_views.py

And to run a specific testcase, use for example:

    ./manage.py test crashstats/crashstats/tests/test_views.py:TestViews

And lastly, to run a specific test, use for example:

    ./manage.py test crashstats/crashstats/tests/test_views.py:TestViews.test_plot_summary

```
The URL is already `/query/` isn't it? If so, change this to `action=""`
You can just call it `response`. It's not a json thing. :)
Tried to do that, but there are complications. I recommend we live with your autodeploy workaround until we decide how to reconcile socorro-crashstats with the rest of the code base. This becomes easier to fix once we integrate with the rest of our build system.
wont nil === false in the logical OR pipeline?
Why not do that automatically?

chdir() + the install command should do.
No real reason, I think I was just trying to be consistent - I wrote the util/processor.rb bit first and copied the relative path style of 'lsdev' and 'lsattr' in the AIX function.
Most other code I'd looked at seemed to use relative paths too, so I probably just figured that was the way to go.

I'll happily adjust either way. Is there a preference for absolute or relative paths?
Could this just be `bound_column.render_args = spec(bound_column.render).args[1:]` ? Also perhaps it'd make sense to put it on `bound_column.render._args`
this seems to be equivalent to return actualTitle.equals(titlte)
Branch for the code without Deferreds: https://github.com/yuhunglin/calcentral/tree/CLC-122-1
What does this do? I started getting this left and right when passing in fetch parameters after upgrading to 1.0.2.
I think you can remove this line, since the configuration class validates this.
Andreas, what is your personal opinion on this kind of change?
I'm quite sure I did this. Maybe there were too much changes in the new file?
That makes sense.  I was thinking we wanted to make sure it's not shown, but it's no longer in the DOM at this point so I was just being stupid.  I'll change it.
Why is this specific to Columbus View?
I think the right way to do this is to add a `specularExponent` field to `czm_material` and modify `czm_lightValuePhong` accordingly.  For example, see the [C4 Engine](http://www.terathon.com/wiki/index.php/Material_Manager).

Do you want to give this a try?  If not, we certainty can consider it outside the scope of this pull request, and I can do it afterwards.
Yeah, you're right, I'm going to get rid of it.  We shouldn't be calling it anywhere anyway.
Yeah, I see your point. I will promote InR and Inner as algorithms.
Ok, I will look into this  

--  
Huascar A. Sanchez
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Saturday, October 20, 2012 at 12:02 PM, Zhongpeng Lin wrote:

> In js/botprint/util/AlgorithmUtil.js:
> > > - } else { > - cell.corners.each(function(p){ > - if(p.isInside(path)){ > - result = true; > - } > - }); > - } > + var counter = 0; > + cell.corners.each(function(p){ > + result = p.isInside(path, p); > + if(result) counter++;  
> This logic is still wrong. result becomes true if ANY point is inside the path. Given this, #L2R51 doesn't have any effect
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/AugmentedDesignLab/botprint2/pull/46/files#r1897638).  
>  
>  
>
I don't see why this should be in the updater script. mw.loader.load never supported protocol-relative links. So why would we need to migrate from that?

If something just needs to load a semi-random/unrelated script without ResourceLoader, just use $.getScript or $.ajax or whatever is appropiate. I'd say this is one of those cases where manual fix-up is more valuable.
Does vars could be renamed to something more self explanatory?
Default should be specified as using the default: tag. This tag is free text, so you can include a type, a description, or both, such as:

default: true (Navigation bar at the top of the screen.)
use isDef instead (in lang I think)
> what this means is that the signature should contain only FQSEN since I cannot think of a situation where you'd want to indicate that you use 'an integer'

Right... that was exactly my point. :+1: 

I said an FQSEN can also be a type, since an interface/trait/class name is also considered a type name.

I guess you're right in that the opposite isn't true (not every Type is an FQSEN), and what I said implied otherwise, which would be wrong.
Agreed on "JavaScript". It seemed more appropriate to specify JavaScript rather than "language" since the spec is for JS promises.
I can. lol.
But that doesn't really matter. It's just the way it's implemented in every shitmod and it looks like it works good.
Please add issue number as a comment.
the other ditto
Maybe comment what this does?  Probably most people aren't that familiar with the set flags.
I also remove the aINames list : now the names are included in the new AnalogInChannels object.
あ、でもその場合はconfigErrorにしたほうが良い気もしてきました。
どう思われますか？
+1, as long as we don't forget about it.
On Oct 8, 2012 9:15 PM, "Felix Mayerhuber" <notifications@github.com> wrote:

> In
> components/ekb/persistence-persist-edb/src/main/java/org/openengsb/core/ekb/persistence/persist/edb/internal/EngineeringObjectEnhancer.java:
>
> > +public class EngineeringObjectEnhancer {
> > +    private static final Logger LOGGER = LoggerFactory.getLogger(EngineeringObjectEnhancer.class);
> > +    private EngineeringDatabaseService edbService;
> > +    private EDBConverter edbConverter;
> > +    private TransformationEngine transformationEngine;
> > +    private ModelRegistry modelRegistry;
> > +
> > +    /**
> > +     * Does the Engineering Object enhancement of the EKBCommit object. In this step there may be some inserts updated
> > +     * or new objects will be added to the updates of the EKBCommit object. Throws an EKBException if an error in the
> > +     * Engineering Object logic occurs.
> > +     */
> > +    public void enhanceEKBCommit(EKBCommit commit) throws EKBException {
> > +        LOGGER.debug("Started to enhance the EKBCommit with Engineering Object information");
> > +        enhanceCommitInserts(commit);
> > +        enhanceCommitUpdates(commit);
>
> Ok, I'm not quite sure if the removals really need to be enhanced. Need to
> think and discuss about that I suppose. So I suggest to put that also to a
> separate issue. WDYT?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/openengsb-framework/pull/776/files#r1787930>.
>
>
I don't understand what you have against me getting all of these emails?!?  Fixed.
Per https://developer.mozilla.org/en-US/docs/Components.utils.import, they're singleton objects per program, even if they were imported into multiple scopes (in contrast to the sub-script loader, which does not maintain singleton object identity).  So `ConversationKeybindings` and `CustomizeKeys` should be unique objects no matter how many windows we have open.

I do have a function similar to `initializeKeyBindings` -- it's `CustomizeKeys.enable`, and it is called by `bootstrap.js` at the right point in the sequence.  If I've misunderstood how `Cu.import` works, then *that* is the only function we'd need to change.
i would prefer to use descriptive names instead of "foo" and "bar". how about `original_param_key`, `original_param_value`, `mapped_param_key`, `mapped_param_value`, etc.
Need initial cap for QueueInfo
can't we ship these?
This code will only be executed once, when the file is parsed.
On 20 June 2012 22:34, Alex Rønne Petersen
<reply@reply.github.com>
wrote:
>> -    bool isX86_64()         {return (amdfeatures&AMD64_BIT)!=0;}
>> +    bool is64()         {return (amdfeatures&AMD64_BIT)!=0;}
>> +    /// $(RED Scheduled for deprecation. Please use $(D is64) instead.)
>> +    alias is64 isX86_64;
>
> So wouldn't `has64Bit[Chip]` or something like that be ideal? It'd even be x86-agnostic.

In full it would be more like hasNative64BitInstructionSet().
But Itanium could be running x86 code, and would not return true, even
though it is a 64 bit chip...
So I don't think it is possible to make it x86-agnostic.
Can't say I fancy this. May be refactor AbstractConnectionFactory by removing Runnable from its hierarchy while adding it explicitly to Caching, Failover and TcpNio CF?
Do we need to pull the "cancel" string to the resources to make it localizable?
Stupid question, what do you mean with CS
I think you could argue in both ways here. This is more performant this way, so I'd like to keep it as is. You could still get the listener instance if you need it, vice versa it's not possible though.
I am saying remove parameters completely, though we need to publish a complete list of supported tokens for use in the URL.  I think @shunter would agree, Scott?
please rename the file to lowercase letters
Is that meaningful?
I don't want to separate, in my version of symfony  (2.0.16) parent::supports does not recognize the type 'be_simple_i18n', i am telling if ask for be_simple_i18n accepts if not just ask the parent.
Je rejoins JB sur ce point. Détail également : je ne formulerais pas "sur mon temps libre", mais plutot "je partage mon temps entre ces deux activités" qq chose comme ça.
Same as above, should be static already. And its a property of BlockRanges so I think its fine in here
I added one more sentence.
oh oh !!!
vaghean ke
I prefer that style for endless loops. for(;;) == forever. Purely a matter of taste.
This would ideally be inside the app in some admin panel as well.
Minor style change request: use YES and NO for BOOL values.
I just noticed that this change (removing the removeClass invocation and doing it later) is not related with the issue being fixed. This has to do with keeping the last element as the active element when prev() is called while at that situation (active == last).

After line 373 of this new version there should be a: 

``javascript
if(active.length) {
    return;
}
````

So we don't do anything if we are at the last element and calling prev().

I should have removed this change as I did with the mentioned code... :-(

However, I'll take the chance to ask if something similar is done in any commit in the 2.0 branch or if there's an issue related with this (I believe that in the previous version of this file, pressing down arrow while in the last element of the list would leave the list with no item selected).
Nit: please rename to ModuleMap
아니 숙제를 이렇게 해오다니!
넌 나에게 모욕감을 줬어!
Might also want to explain why someone would want to use start_request/end_request here.
This is inaccurate. Functional descriptions of which delegate methods _do_ are not particularly useful (as this behavior is determined by the implementation). Descriptions which emphasize _when_ the delegate method is triggered. In this case:

`This method is called when the object is attached to a toolbar`.
`getClientsCount`, `setClientsCount`?
It may have just been me, but logging the function made it look like it wasn't firing at 10. The problem seemed to be that the plugin was running `__construct` on `init` priority 10. (In the current master plugin.php: `add_action('init', 'github_plugin_updater_test_init');`)

So, plugin initializes at init:10, then tries to hook `delete_transients` onto init:10, but that priority is already running. Upping to 11 resolved the problem for me.

Has anyone else had this issue?

PS: This line as-is probably isn't running anymore again, because in this version the plugin is initialized on `admin_init` to save processing and remove the requirement for `is_admin()`. `init` runs before `admin_init`, so if the priority issue exists, it should be `admin_init: 11` anyway.
ErrorException: Warning: Invalid argument supplied for foreach() in /Users/user/git/rockshop/repo/dev/vendor/sonata-project/notification-bundle/Sonata/NotificationBundle/Backend/PostponeRuntimeBackend.php line 56

I guess it should be
protected $messages = array();

BTW, why I have this error when I set runtime backend

sonata_notification:
    backend: sonata.notification.backend.runtime
Lol!! All this time, and nobody had pointed out the double nano.
This card does not support sending html body content.


From: Nukul Bhasin
Sent: Saturday, November 17, 2012 6:56:54 PM EDT
To: blackberry-webworks/BB10-WebWorks-Framework; Hasan Ahmad
Reply To: blackberry-webworks/BB10-WebWorks-Framework
Subject: Re: [BB10-WebWorks-Framework] Adds three new cards to the card extension: (#271)



In ext/card/client.js:

> +    }
> +    if (!window.webworks.event.isOn(_calendarComposerCancelEventId)) {
> +        window.webworks.event.once(_ID, _calendarComposerCancelEventId, cancel);
> +    }
> +    if (!window.webworks.event.isOn(_calendarComposerInvokeEventId)) {
> +        window.webworks.event.once(_ID, _calendarComposerInvokeEventId, invokeCallback);
> +    }
> +    return window.webworks.execAsync(_ID, "invokeCalendarComposer", {options: options || ""});
> +};
> +
> +_self.invokeEmailComposer = function (options, done, cancel, invokeCallback) {
> +   /*
> +   * options = {
> +   *    from : accountId this message should be sent from
> +   *    subject : message subject
> +   *    body : plaintext message body


how does this work?
What if I want to send in HTML body?
can it handle it?

\u2014
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/271/files#r2160512>.



---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
This found it var at several places. I just toke the first place which I saw, so that you get a notification :-).

I expressed my self a little bit bad. I wanted to say non-type declaration. With var, the type is present will be know at run time. Well sometimes it is easier to use var but if you know the type then please use it. It makes it easier for C# programmer to read the code. 
However, you could use VB as well, if you prefer non-type languages.
instead of "in columnar form" maybe it's more user friendly to use "in a table"