labofsahil/github-event-dataset-2012 huggingface dataset:
It was probably included to support other devices in the same family, if it doesn't adversely affect us, keeping it would make life easier for other ROM builders like edowar or that guy who runs the Triumph ICS on his Huawei device.
Got late to report the status: Tested and working with no issues in production env
What do you mean, should I clean it up?
Had to solve a local conflict. Just to have said it: This was created by LorDClockaN
We definitely must fix this.
Why can't we do this with metadata?
don't add global vars. elgg_get/set_config or an OO solution
Cool beans :)
I moved the check up top and not as part of the else. 

```
if (svc == null)
    throw new IllegalArgumentException("Service id " + id + " cannot be found.");
```
For the message bundles, I think you should also set the property to not fallback to system locale, much like the other pull request.
And replace it with what, exactly?
well, 2 lines above it checks number 1, which is the initial resize, and then continues here from 2
Are you sure you want to completely remove this? I know users still on 1.x that want to upgrade to 2.x.
no, it is actually using the real cluster Ordering via Ordering[RoleName] which is defined in MultiNodeClusterSpec
apply(emptyArray)?
indeed, thanks
No, because the change cannot happen in that direction as a race: the only entity removing a child is the actor itself, and the only entity which could be racing is somebody who calls `attachChild`, and there we are guaranteed that that child cannot yet have died (since it has not yet been created).

I’ll put the above in a comment.
two bools with bad names: while you’re changing this, I think it would make sense to switch to an `enum BarrierOp` here which has four cases (enter, fail, succeeded, failed). In principle these could all be mapped onto a single bool, because the different meanings occur on different message directions, but that would be ugly for no gain (the enum takes exactly the same space).
ouch, debug residue
Well, these aren't supposed to be here ... I'll fix
A few tests at the ObjectContent interface.
Forgive a silly non-native speaker, but shouldn't written "formal" text fully spell out things like "you'll"?  Also, perhaps "e.g." should be spelled out (I don't mind it, but to my surprise, I have experienced several native speakers from non-academia background who confused it with "i.e.". But perhaps I just had bad luck?).
should these be logic.get_action('activity_create')(...)
I added a parser call for positive int and applied it to all suggested options.
yea, i was thinking about something along those lines.

Given that rpi will need it too, i think that's a great idea.
Could we make this an implementation-dependent configuration as well instead of using this #ifdef?
The problem is that the number of SQL queries during a directory fetch jumps from 1 to 1 + n where n is the number of items retrieved. If you retrieve 1000+ movies you'll end up with 1001 SQL queries instead of 1 which obviously results in quite a noticeable slowdown.
Please resolve conflict!
We make a distinction between "cls" and "self"

For member functions (like this one) that are part of a class that is instantiated, we use "self"

If this was a @ classmethod then you would use 'cls' to imply that there are no instantiated member variables that you can use.
I know we group by `dest` when we reproduce passthrough options, so that might affect it. When I originally tried with `-M/-C/-R` I did something with callbacks, so maybe I can simplify and make it work. If it actually is a problem, I'll ticket and fix in another branch.
Is this that there are cases where you don't know if it's appendable?
Should you get rid of this situation instead?
`action.assignedTo` это значит, что оператор должен это действие делать, если оно `closed=true` значит уже сделал, если у действия ещё и `name=orderService` значит это заказ услуги.
При этом в `case.actions` должны быть только не закрытые действия (сейчас это не всегда так -- это ошибка).
Думаю, можно сейчас сделать соответствующий sql запрос, а вообще в комментарии к #272 я высказал сомнения по этому поводу.
Thanks George, good point!
Enum values should be upper cased
From #43, not a fan of defaulting to 0 instead of None.
Is the operation required to be synchronous or can it be asynchronous or any?
should have been on line 491 (right line count column)
Minor stylistic thing: rewriting this line as

    exports.post_stats = function graphite_post_stats(statString) {

will show the name `graphite_post_stats` in stack traces instead of `<anonymous>`, which will aid in debugging.
You must remove the `\` here as we need to be 5.2 compatible.
Split some common keywords as secondary for a more recognizable coloring. (This is inspired by SublimeText2 & Cloud 9 IDE)
Wait, I lied, `cString` was the deprecated one. I'll fix that up.
I believe both 'imposter' and 'impostor' are correct. The latter is more 'ye olde spelling'.
I guess changing the context is the lesser of two evils because no sane person uses `this.x = 42` to set a global variable's value.
So the second call to featureStore.save() would not issue the Delete request.
Wow, that's a pretty crappy feature of the docs API...
нужен  отступ
нужен был для отладки - уберу
это примитивный тип. как double или float. наверно, лучше оставить
нет, потому что это сделано для красоты. чтоб не было такого: http://s1.hostingkartinok.com/uploads/images/2012/10/9fc2e4646c154b4543fec15d80c25e8e.jpg
Should be "Active Record".
Yeah got that. Please go ahead and make the fix. Thanks :)
I forget what we decided about the final value of `update`, `update_attributes`, `update_attribute`.... etc. @jonleighton ?
also `build_default_scope` is not used in any place inside the framework. I don't know if it is there for historial reason.
HTML5 spec says fractional seconds are supported, too
buildMessage is not meant to be called by the user, but instead here with JSON returned from rosbridge (see description in pull request for an example of the JSON).
Thanks!  My first hand-made tree *EVAR*
I think it will be helpful to add this comment to build.xml.
I am accessing it within the same package: https://github.com/dotta/scala-worksheet/blob/issue/move-worksheet-support-in-%2391/org.scalaide.worksheet/src/scala/tools/nsc/interactive/ProgramInstrumenter.scala

But keeping it package private may not be worth the hassle. If that is what you wanted to suggest, I am happy to change this.
What's wrong with something like `def debugString`?
Fine, I didn't figure out that the default was defined through the ones of minimize.
I prefer Google style, i.e. wrap at braces. I've fixed instances where I didn't do so.  I can change them if you disagree.
Thanks for this. It was quite interesting read.
"hat" in place of "wird"
"Configurator" looks like it has been copied from "Constructor".
Think we do not need this funny headline ;-)
https://github.com/ArcBees/GWTP/issues/66
oh god, I wish we had the old VCS logs... whoever wrote this file originally makes me very, very sad
Does it have to check the entire page content? Feels like this test wil fail on any small change to that response document.
Valid points all; I just tend to err towards maximal support (it drives me crazy, for instance, that jQuery doesn't tolerate forms with elements named nodeName or nodeType, but fixing it isn't worth the bytes). Regardless, `typeof x !== "undefined"` is more in line with the current style of QUnit (cf. https://github.com/jquery/qunit/blob/master/qunit/qunit.js#L24), and adding it to the closure is a good idea that should come in its own code sweep and corresponding commit.
I think that the grouping of data points, constants and functions should be orderly and not intertwined with each other, otherwise it is less easy to read.
This seems like a strange method for the ValidationUtil. It tends to have more descriptive methods around validating properties of a provided string - not validating specific types (for example, methods like `requiredAndNotEmpty`).
these should be wiki links. 

     :wiki:`foo`
I would tend to separate the example from the explanation. as in: 

    from one server to another, as is the case when deploying migrating data from a staging environment to a production server. 

staging also sounds more authentic than development, which would pretty much never happen.
Ah okay. Should probably be moved to phpbb_gen_download_links().
You don't need to check the length. If it doesn't exist, it won't be focused.
Fixed. It shouldn't have been there anyway.
Fix docblocks here.
How do you want me to deal with this?
- Change the commit messages to show what was fixed?
- Merge commits?
- both?

Anyway, pls specify what should be done.
Try getting rid of `global`. Use dependency injection instead and pass dependencies via parameters.
See other note about checking for a post variable being set.
Set `$path` as a class property so it can be reused. The value is the same everywhere and doesn't change so it doesn't really make sense to redefine it every time it is needed.
Here is an example of how to document callbacks for the new yuidocs:

https://github.com/yui/yui3/blob/master/src/app/js/model.js#L375
Вообще правильно было бы сделать ещё один сервис конфигов, к которому можно было бы обращаться за параметрами.
You are seriously? One space?
Actually it's not.. have a look https://github.com/dot-i/Nancy/blob/0d0a0bbf0a804216fe1829995b1cd79c1c11293a/src/Nancy.Hosting.Self/UriExtensions.cs#L12
Why ensure it starts with a forward slash only to split, and remove empty entries on the next line? Am I missing something here. Can't see that _modulePath_ is used anywhere else?
using statements should be inside the namespace declaration
Or re-write `IsCaseInsensitiveBaseOf` so it is aware of `+` and performs
different comparison.

On Sun, Sep 23, 2012 at 12:55 PM, dot-i <notifications@github.com> wrote:

> In src/Nancy.Hosting.Self/UriExtensions.cs:
>
> > @@ -11,7 +11,7 @@ public static class UriExtensions
> >  	{
> >  		public static bool IsCaseInsensitiveBaseOf(this Uri source, Uri value)
> >  		{
> > -			if (Uri.Compare(source, value,UriComponents.Scheme | UriComponents.HostAndPort, UriFormat.Unescaped, StringComparison.InvariantCultureIgnoreCase) != 0)
> > +            if (Uri.Compare(source, value, UriComponents.Scheme | UriComponents.Port, UriFormat.Unescaped, StringComparison.InvariantCultureIgnoreCase) != 0)
>
> Darn, I needed to remove the Host part since the self-hoster uses a + for
> the host name now (to allow for remote access). My bad that I forgot to run
> the unit tests :-(
>
> So I guess the self-hoster needs to use its own private
> IsCaseInsensitiveBaseOf() which is different from the one in UriExtensions.
> Or we create a second IsCaseInsensitiveNoHostBaseOf() extension (bad name
> perhaps)?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/NancyFx/Nancy/pull/737/files#r1668825>.
>
>
style nit: please keep braces around all if statements, even one-line ones, to prevent accidental confusion in the future.
Perhaps we could add a warning to discourage the use of this function.
what is the gradient on x?
Beautiful, this fixes the constant folding problem. My functions now compile nicely.
Yeah I don't think it worked before. We didn't notice because nothing actually consumes that state right now. When we do more discovery via SiteTracker in the future it will be useful so I don't think we should remove it.
Seems odd and arbitrary to validate AFTER serialization.
``synh`` --> ``synch``
The thing is, because the adapter receives the type/class, and not an instance, I can't just put it as a property of the model. It has to be on the class.
There is no need to put the `TestName` in the spec.  Since sometime in release 14 edoc is smart enough to match specs and function arguments up automatically.
its not job adds its job ads.
This is mostly a style issue and not a pull-stopper. (hot-fix)
This assumes that remove_comp is normalized - is that always the case?
strike "in the tutorial"
Wrong indentation (using tabs ?)
If you only mention it once, then it's actually more typing if you first do a 'use' and then only mention the class :)
What are `asset_ouput` and `bcr_distribution_id`? I can make a guess about `bcr_distribution_id`, but I don't have a clue as to what `asset_output` is supposed to be.
Предлагаю отказаться от брани и смайликов.
Un-assigned vars need to go above assigned vars ;)
Also we should put in a link to the new documentation site and a mention of the mongo-users google group.
It should be all okay now.
I don't like these public accessor fields being defined right along side the various private variables, put them with the public methods.
as it turns out, this was also a misnaming. "headers" is actually just content-type. I'll change that :D
We can't do this, because we don't require php from Homebrew.
If requesting ``/alias/dir/index.php/pathinfo`` or ``/alias/dir/index.php?param``
``scriptName == '/alias/dir/index.php'``
Als default ist es denke ich so ok, man sollte aber die Möglichkeit haben mit `->filesOnly(false)` die Ordner mit in die Ergebnismenge zu bekommen. Dann wären im Ergebnis zusätzlich:
dir1
dir1/dir
dir2
dir2/dir3
dir3
works and seems much safer!
I try to use it, but the actual code is complicated.
i have discover that this snapshot is use only to create a ChunkSnapshotModel who need snapshot of the chunk and is neigbours. Need lot optimisation...
Yeah, I didn't write them in the last story. I'll add some in for this one.

On Monday, September 24, 2012 at 10:15 AM, Dan Imal wrote:

> In spec/app/mulberry/adapter_spec.js:
> > @@ -0,0 +1,51 @@ > +describe("base _Adapter class", function() { > + var c, C, t, mockjax, ajaxMocks; > +  
> There's no actual test in here?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/Toura/mulberry/pull/572/files#r1673334).  
>  
>  
>
This logic isn't quite right: if you select a new track off the list while the audio is paused, it restarts the paused audio instead of playing the new track.
With the updated rotation logic, if nothing is selected then up/down navigation will always cause something to be selected. If the user presses tab/enter and nothing is selected, the default handler won't be prevented because the final else-if branch won't be entered and instead the final if-branch will return before the prevention.
I'm okay to keep it as is since our special handling of "N" key has nothing to do with mnemonics in the dialog anyway. When we make a big change to support the mnemonics in the dialog in the future, then we can limit it to the actual text field elements only.
What about using “weiter verwenden”?
I doubt this `this` is the `this` you mean.
ok. wasn't sure. fixed
Same for after_pause
this should probably retain the original indentation, and also if the whole thing was wrapped in parentheses it wouldn't need line continuations
Yes, but that's a roxygen2 bug, so you should complain to the maintainer ;)  (But seriously, that's on the list of things to fix, and don't worry about the bad ordering for now)
I wonder if fill should just equal `alpha(colour, alpha)[!end]` - i.e. it's always filled with the same colour.  I think it should at least do that by default.
ah cool, thanks!
Can you undo your pom.xml changes? I don't want to merge changes to the version or the name
`span` is now unnecessary: you can do `<li class="username">` now.
Display current language differently (maybe even not as a link, just text).
I think just `raise exceptions.PermissionDenied` also works? (Without `()`.)
spacing at right bracket
Is there even a reason to put this `nop` here? Just to curb lint? I'd rather just have a bit more explanation about why there isn't any real code.
`-( @_mediaStatusContainerHeight / @_scrubberBarHeight ) / 2` is probably easier to read, and I think they're equivalent.
Could put this else on the line above for consistency with other changes in the file.
Yes - now wondering if it's supposed to be the Firefox or Mozilla Marketplace...
Remove Math.ceil from here. The ceil can be applied at the canvas creation.

This adjustment calculation belong few statements up; and will let to remove the TODO comment and will add MAX_PATERN_SIZE check.
case 'thumbs':
        if (...)
            break;
        ...
        break; // again
    case 'outline':
        if (...)
            break;
        ...
        break; // again

But this is perhaps just my taste.
Please tell me if you want me to remove this, I am updating the PR now (must go to sleep :-) )
m_progItem is a CFileItemPtr...nothing to delete here.
It also prevents users from overriding `#synchronize` and being done.

I'd prefer seeing something like this (inspired by the implementation of `#multi`):

```ruby
synchronize do |client|
  client.call [:watch, *keys]

  if block_given?
    begin
      yield
    rescue ConnectionError
      # Do nothing
    rescue RuntimeError
      unwatch(*keys)
    end
  end
end
```
strip the spaces between '|'
This is using a write-access version of the repo URL, please use a read-only version.
Why was this file added back?
I think the deleted version was cleaner than the new line. The old one was saying: "This fileuploadfield.css is part of the geonode css, where you put it now can clash with any other django project." Namespaces are a good idea.
To be clear, I've no argument against `show_sexpr()`, which is grand. I'm just not convinced about `@sexpr`, which will encourage Lisp-confident people to write macros in a language that's farther removed from Julia.
This line is good .. You shouldn't need to do organization = Organization.find_by_id(org_id). Here is my proposed change
{{{
unless org.nil? || !org.readable?   
    self.preferences[:user][:default_org] = org.id
 else
    self.preferences[:user][:default_org] = nil
}}}
I don't know how much this falls under the category of "doesn't matter, don't care" but it could be nice to render the base template instead of just outputting the body.

Out of curiosity, why is `output` a list instead of a string?
Dislike this kind of code. I prefer and if with 2 that excludes the where:

    var hubs = _hubProviders.SelectMany(p => p.GetHubs());

    if(predicate != null) 
    {
        return hubs.Where(predicate);
    }

    return hubs;
I have the Autofac-based resolver in the back of my head all the time, so maybe I'm biased :smile:. Will do some checks to see if it's really a difference. For now - I moved the code back here.
against  = against  || window.location;
Sure, can rewrite it, no problem.
Ok, I will separate it.
In the code, if I use

```from xml.etree import ....```
it clashes with
```libcloud.utils.xml```

That is causing the conflict.
Does it have to be J2000? (same for Dec)
Should ``__base__`` be surrounded by double tilted quotes instead of single straight quotes?
oops, more like no level. DELETED!
I'd use the exact same message here as on line 752 as there is no real need to distinguish between "URI handling and URI handling - drag&drop", and no one drags more URLs at a time. Saves the translators some work.
What's an extracomment?
The purpose of CBlockStore is to act as a hub (oops, I was gonna rename it...) between p2p, wallet and the block storage.  The block storage (including being told about new blocks, holding the chain (or not, if SPV)) will be hidden behind CBlockStore.  Eventually, you could even run p2p and wallet clients in separate processes for additional security, that is the long-long-long term goal.
In terms of exposing threads, that is more for added functionality later which cleans up the API a bit (when you need to run n regular threads, and possibly multiple callback threads).
How can you pass a constant by reference? it is not clean code. this was flagged by the hiphop compiler as an error. Better to have explicit variables passed by ref.
ternary might be too long here regarding the line length.
I don't understand the first "..." in your example. Do you mean that we could have "0.1, 0.25, 0.5" as well?
Was this intentionally left commented out ?
Right, it would be the same as $("#a1").add("#a2");
remove debugging please - does gpg output anything when encrypting a file, we may not need to handle this event at all.
No problem. 
I should have fixed all the remarks (I think).
great method names!!
in this case, it is ok to do provider.get(), however, most of the time you want to avoid calling .get() on a supplier insider a constructor, as it may be coming from a network source (ex. extra i/o) or you might want to be able to change the value at runtime
あ、俺か。遅れてすんません。

`Hashie::Mash`を使いたいという強い意図のみなもとはここです。
https://github.com/kentaro/triglav/pull/41/files#L0R14

developer strategyでは`auth_params`に`update_image(auth_params['extra']['raw_info']['avatar_url'])`という物が入ってこないので、
```ruby
update_image(auth_params['extra'] && auth_params['extra']['raw_info'] && auth_params['extra']['raw_info']['avatar_url'])
```
といったことをしなくちゃいけなくてだるいなあと思ってドットでつなげて`try`とか`present?`とかを使えるようにしたかったです。
（その他の場所でドットを使うようにしたのはほとんどおまけです）

で、
> 何かのライブラリで依存しているものを暗黙的に利用すると見通しが悪くなる気がするのですが、

なんですが、OmuniAuthが渡してくれる`request.env['omniauth.auth']`（`auth_params`はこれを返すだけのメソッド）が
そもそも`Hashie::Mash`なのでテストデータの方でそれに揃えるのは妥当か、（だから↑のように楽しても許されるよね）と思って使いました。

OmuniAuthが`Hashie::Mash`への依存をやめたら（例えば組み込みの`Hash`を使うようになったら）
developer strategyを使っている上記箇所などは、運用時にもエラーになるので、
テスト時に依存関係の問題で死んでくれるのはうまい検知役になってくれるかな、とも後付で思いました。

ただまあ、こんな長い説明を要するのを見るに、すっきりしたストラテジーを自作するべきかも知れません……。
And in all fairness, I'd also leave `origin_remote` and `local_path` in the function signature. They are not optional, and they are not going to change. So why not leave them there?
`git_filter_blob_contents` [at your service](https://github.com/benstraub/libgit2/blob/09a03995e00605c9b23f799673b7ccb304506e5b/src/filter.c#L179).
How? My cmake gives me only `"Visual Studio 10"` and `"Visual Studio 10 IA64"` (that's for Ithanium) generators. `-G "Visual Studio 10"` generates 64bit binary on my system (using the process I described it). If there is another way, feel free to describe it :-)
Since it's possible for this form to be re-rendered after an error occurs, we should populate the data from `params` in each input so the user doesn't have to re-key all the fields. For example:

```haml
%input#description(name="description" type="text" value=params[:description])
```

Also I've never used that HAML syntax before. I'm more familiar with the hash version:

```haml
%input#description{ name: "description", type: "text", value: params[:description] }
```
That looks like something to fix IE. But given some other styles that use multiple classes and data-uris, I'm not even sure this works properly in old IEs. So if this doesn't work in IE already, please remove those lines.
yeah, there is a bunch of very similar views and templates. i didn't
go through trying to refactor but this case is easy. i am open to
other suggestions as well
Nit: --screen -> --dbgport
it's an artifact from the future.  This code came from my branch with the storage system.  That system has the quit detecting callback system so that multithreaded processes can shut down promptly.  It was easier to leave this in than to try to back it out. For your use in this code now, you can ignore it as it defaults to doing nothing.  Multithreaded users of this class will provide a more functional callback.
You can just define a 'title' field in the View
Assign the factory to a `$factory` variable and then call `$factory(...)`.
alpha/beta/etc unmentioned
That's why this class `ContainerAwareTraceableEventDispatche` has been moved into the HttpKernel.
Yep, you're right. I didn't think it was because it's only in the template. What is the correct course of action from here?
fixed and added test
this does not respect the interface either
So should i make it `__construct(UrlGeneratorInterface $generator, ContainerInterface $container = null)`
and then assert that the container is set in `getSubPath`?
It does not return anything. And Symfony does not use ``@return void`` in such cases: http://symfony.com/doc/current/contributing/code/standards.html#documentation
FYI, Twig_Function_Node is available as of Twig 1.4
`disactivated` should be `deactivated`
What are my other options? I can't define a class constant after the compile time.
there is no bridge bundle
What about `'0'`? Should be valid I guess but isn't due to `empty()`.
Where did they do?
To clarify what I was thinking, old:

```ruby
render partial: 'title', locals: { title: "#{@voter.name} voted on your #{@event.name} poll!" }
```

Suggested:

```ruby
render partial: 'title', title: "#{@voter.name} voted on your #{@event.name} poll!"
```

I thought there might be a Rails shortcut allowed there but I can't find the docs on it at the moment.
I had a mess in private repo, it resulted in overwriting changes file.
social ro ke felan hazf kon
I just don't agree that this is preferable. 95% of the time, the user will want to define the extent of their map in "lat lons" not in the native coordinate system.
I think he's trying to say, what if you click a wall (vertical) of sand, and not a floor (horizontal) of sand. It appears your code is only checking to see if the block they click is sand, not the block where the dead bush ends up on (1 block underneath it, hence "y - 1").
nah, if it's really important we should assert that all tasks are strings at initialization time... (i don't think its necessary at this point)
Isn't that very similar to the first test? Maybe merge?
We put this in because the code uses `Ember.$.Event`.
I would prefer to keep it the old way for the sake of readability and to be able to debug it easier.
Perhaps this dependency should be made optional? That way we don't force people to have system-jmx available if they don't need to use it
Let's change this to either `.hide()` or add `display: none;` to `.ui-dialog`.
not: retrive -> retrieve
Idem. Through `CallScreen` and `fake-info-primary` everywhere.
changed all ... to proper ellipses
Thanks for your reminder.
The issue won't be happened.
Because there is only 24-hours input format now.
I just remind myself to care about the real input of alarm-edit page in the future.
I think you will save yourself pain later not to use PX but we dropped responsive design so not sure how much it matters now.
Add 'use strict'; to all your JS files.
Yes, I think what I have implemented for the search is just the basic, there are still lots of improvements I can do.
I will file a issue for the searching enhancement after this merged. If you have more ideas about this, maybe you can just comment on that issue, thanks.
Maybe my bad but I do not see where localization takes place there. It is just composing a String with the name of the contact (or "Unknown" if no name, this is the localized part) and the number of calls in the group.
The same bracket positioning style as commented above.
You are not using closure here... please don't copy comment as-is, read them!
it's needed for packaging, yes
This is to avoid a disconnect with low bandwidth (for example a simulated speed of 8 KiB/s or possibly as high as 32 KiB/s or higher) because `RTMP_PACKET_TYPE_BYTES_READ_REPORT` is sent too infrequently.

10000 is an arbitrary value high enough to fit the handshake so that a `RTMP_PACKET_TYPE_BYTES_READ_REPORT` is not sent too early and interrupt the connection establishment.
I'll undo that, it isn't really necessary.
This should read: "Unable to connect to RabbitMQ". Should the program then backoff and retry periodically?
Replace `ii` wit something more descriptive.
That's related to my comment in the DB module. Here you could do something like:

```python
   types_stopHaltedInstance = [ StringType ]
   def export_stopHaltedInstance( self, vmId ):
     result = gVirtualMachineDB.getImageNameFromInstance( vmId )
     if not result[ 'OK' ]:
      return result
     imageName = result[ 'Value' ]
     #TODO; Instantiate the image module based on the flavour. For now just "hack in" occi
     oima = OcciImage( imageName )
     return oima.stopInstance( vmId )
```
The names are missing the 'k' prefix (to match the actual enum name)
I would only show COM_KUNENA_INSTALL_DOWNGRADE_NOT_ALLOWED if someone tries to install too old version.
```coffeescript
if threadID is 'new'
  threadID = null
  etc...
```
QuickSWF shouldn't have to worry about the bytecode itself.
Just save it in the actionrecord for SWFCrew to deal with later.
Do you expect this can be different with every single SHKItem, or it always the same withing single app? If the latter, it should be in DefaultSHKConfigurator only. We should avoid bloating SHKItem.
We've gone for consistency with RecordNotFound from the root controller.
that would mean adding it to the form and playing around where the form gets handled, right?
What is 15?
I like this. All of our modules should initialise themselves.
This looks like a copy/paste error:  Should be `$tags_not_in[] = $temp->name;`
Nit:

```js
.then(null, function failure(error) {
```
Does this really makes any difference ? Ensure will unload this loader only after the whole thing is unloaded, but then firefox to be closed anyway no ?
It was grabbed from `chrome://global/skin/about.css`. Interestingly Songbird doesn't have one.
__xabolcs__ wrote
> Will check for the others.

All other method is mandatory too, except `getLevel()`, `tree.xml` throws `NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED` if it miss something from [`nsITreeView`](https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsITreeView).

In short: I wouldn't like to cut out `getLevel()`.
My intent was only to remove lines from 245 to 247. I removed also line 249 by mistake and then I added it again.
Should I modify this line, too? Imho it's not needed by now.
@mmoll yeah, we're slowly cleaning up the other places as well.
I was a bit concerned about that but wasn't sure how to tell what I'd be missing.  Also, the type of the `conn` object is different now; it's no longer a Net::HTTP, it's instead a Puppet::Network::HTTP::Connection.  So it may be that if this cleanup is important then it needs to go inside of the Connection class, rather than here?
Travis is failing because the default source seems to be " ", not "". How about:

```ruby
lambda { |_| "" }
```
It's not excessive when someone comes along and removes that because they don't know why it's there
I'm curious why we don't use Python True/False instead of strings.
does it need to be done at the end like this? can't we do it in a similar way to the others as the events come out? that'll remove some duplication
You can supply the indentation to stringify: JSON.stringify({}, null, '  ')
for `$current * 2 + 1`
Yes, that's true. I'm reviewing the code of Zend\Crypt\Hash and Zend\Crypt\Hmac to remove deprecated stuff.
This should be `[0-7]`
@DASPRiD I don't see a reason to -- it falls under 100 characters, and fits within the GitHub UI without scrolling.
Add some test cases like upper case letters, words with 6, 7 and 8 characters
AbstractMessage
```callable``` is actually the correct term, as it is the valid typehint as of PHP 5.4.
I changed to suggest and create the require-dev section
So, I added the dot since @forsetti mentioned some tickets are generated of the form ST-1234-login.example.com.  The spec doesn't seem to dictate that it be alphanumeric (just "Service tickets MUST contain adequate secure random data so that a ticket is not guessable"), but most implementations seem to stick to alnum.
Well, skip the else thing then. But please send in the whole msg structure, not just the payload. That way you allow for the most flexibility in plugins, and it doesn't cost much.
I made the same change, must have forgot to push,
Can you fill out the missing props and remove unused ones?
'alright :)
Will do later!
this looks like a syntax error. can you move the expected exception insde the comment and close the comment before the test function please?
Fixed this in new commit.
Our goal is to kill the zepto/jquery requirement since the ajax/each code should be minor, and we dont need dom/etc
just warning about it isn't strict enough

you should either throw an error here or check for the return value of verify_homepage(), and allow overriding the error for software for which the name isn't mentioned on the homepage (e.g. by provide an alternative URL or pattern to search for)
Po angielsku jest w liczbie pojedynczej. Po za tym podajemy nazwę tylko jednego konta. Choć też się zgodzę, że można połączyć dwie rzeczy ze sobą.
Normally the build section goes below dependencies...
````js
this.code = code;
````
We're not, but on second thought I can use that anyway (I originally switched because the tests didn't have it set on the locale, but I just realized why).
I think this is a typo - it should be <code>_email_field_locator</code>
On second thought, I don't like this. Lets leave it the way you did it by filtering in the python code.
and this changed.
Because really this whole test case needs clean up. For loops to find two things, each of which has a special case?
Why are these lines being crunched together?
Still looks good! (I'm not going to nitpick indentation, I'm not going to nitpick indentatio- oh well. Nitpick: indentation doesn't seem even on these li tags. ;-) )
Hi Jules.

Before I pull this code, can you tell me why you commented out line 366 here? The class loading code is pretty tricky to get right. Are you fixing a bug by commenting out this line?
You are absolutely right. 

The issue is, if kata.source is a plain string, for example, "Todd Sedano", link_to will still generate a link by Rails magic like so:

http://craftsmanship.sv.cmu.edu/katas/Todd%20Sedano

But this is an invalid link and it shouldn't be there.  (example: http://craftsmanship.sv.cmu.edu/katas/coin-change-kata)

On the other hand, if kata.source is a link, it will still be nice if it's clickable on the view. 


So the solution is:

if kata.source is a link
    generate a link on view
else if it is a string
    display the plain string
Spacing again. Probably tabs...
It would be great if you could create "proper" javadoc and remove this comment. From below, it looks like the class doc comment is the only thing that needs some more javadoc.
Three parameters were added and one was removed. As @FunkyLoveCow said, they're already in `master` so that doesn't matter for your pull request.
_footer.scss should be included in the login composite.  If this is a variable that is used by more than one component then I vote put it in the main _vars.scss
it's the key for the projection (aka. the "fake" nodekey which contains the identifier of the external node).
Hard coded StartDate and EndDate
Capital letters and quotes, please.
secure AND scalable, or something along those lines, would be better - they're not usually mutually exclusive.
80 characters (yes, it was a problem before by that's no reason not to fix it)
Typo on "everything"
commentId should be the first parameter.
The logic for removing from both CFs is a bit hard to read, but I can't immediately think of a way to make it better.
It doesn't feel right to copy the getMeFeed logic in here. We should try and find a way to re-use the me feed logic
Any thoughts about having an event emitter that spits out events that can have multiple listeners?

ie:
```javascript
// The ContentApi would inherit from EventEmitter
// In _createContent
emitter.emit('newContent', contentObj);

// In _updateContent
emitter.emit('updatedContent', contentObj);


//..


// Then you would have listeners

// In the Search API.
ContentAPI.on('newContent', function(contentObj) { 
    reindexContent(contentObj);
}

// Another API could pass the event over RabbitMQ to the preview processor
ContentAPI.on('newContent', function(contentObj) { 
    RabbitMQ.publish('newContent', contentObj.contentId);
}

// etc...
```

Not too sure how feasable this or how cross dependant we might become.
Profiles don't get applied on dependencies, so the *default* parameter is used. But I'm getting rid of this section anyway.
Going from this paragraph, where the focus is on the reader ("you"), to the next paragraph to where the focus is on us ("we") is a bit abrupt. A transition, like the following, at the end of this first paragraph would be nice. "And, we'll show you how."
Can you explain me in few words why?
Hi Vinoth,

This method is the only one not synchronized accessing clientRequest. I've the impression that with "real-life usage" there's some request that arrives too late (maybe some timeout or something else)
Space after `foreach`.
Can you note the list of available timezones on the upgrade guide, so people know how to upgrade their applications. If they need to pick one, they need to know what is available to pick. 

-- 
Phil Sturgeon


On Friday, 8 June 2012 at 16:29, Iban Eguia wrote:

> > |
> > */
> > -$config['time_reference'] = 'local';
> > 
> 
> 
> There is no equivalent for local. The point is that you can put any timezone you want. If there is a need for a local timezone, it could be done, but is it necessary?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/EllisLab/CodeIgniter/pull/1223/files#r954158
> 
>
I don't see why you would do this though, I don't have line ending problems
Данный метод работает, но при большой ДНК и высоком проценте мутации, количество "пустых" проходов будет огромно. Рассмотрите пример с 99%, ждать пока выпадет в функции arc4random нужный нам(последний) индекс массива прийдется долго.
собсно да, leter=leter =)
Не очень хорошо изменять переменную которую передали в процедуру как параметр
Лучше для этой цели использовать внутреннюю переменную
В данном случае ошибки нет, но подобный стиль использования входных переменных - это дурной тон
Missing a </div>
Sorry, I think I was talking at cross purposes there.  I thought you meant the inclusion of tables in the json output.

The simple.feature is plain old cruft.  Will delete it now.
Cool! Should be pretty straightforward.
Rails core suggest you use `Array` not `Array.wrap` - they had a reason which I can probably dig up if you're interested.
Works for me, I wasn't sure if json.dumps preserve the original order of keys and whether that would be useful or not.
Yes, the lines 1038, 1039 and 1040 have been removed, sorry!
I think using a tuple for the index is more common, i.e., data[:, (0, -1)]
Please merge all tests in on test file and call it jobstest.js
httpclient is still required for fetching the stylesheet links.
Did you remove this behavior? That doesn't seem right.
The thing is that some things i can't do with plain Mockito especially when it comes to static methods and for some reason i realized that if i use PowerMockito to create a mock then things would fail if i called Mockito methods.
For static imports, it is because i have methods line any or when that are in both PowerMockito and Mockito so a static import would confuse eclipse.
As for Mockito.eq, i didnt know about it, am still new to mocikto but i will for sure give it a try. But i tried the Equals matcher but i didnt like it because it also uses the '==' operator which would fail some tests.
Should `non-default` be `non_default` with an underscore to match the other `non_default` values?
Will do this next commit.
Please fix the coding standards in the example
Please keep this together. These are all imports from the same module.
If we're suggesting `Phone.dataset.help-content` (or `Phone.data.help-content`), then I think this makes sense. If we're suggesting camelCasing the attribute names, that could get hairy IMO.
Because this file can't be in multiple packages simultaneously, it'll actually be touched and generated dynamically.

The reason is because there is no possible way to have two packages that give you the 'gridcentric' module. So horizon and nova would need a common dependency with just this one file in it. Instead of that (because it was nasty) they just touch __init__.py if necessary. Because this file isn't being shipped, I wasn't to make sure that it reflects what will actually be present on the system, which is just an empty __init__.py.
I think this code makes sense in the model. The json part is to send it back and forth to the agent.. shouldn't have anything to do with the service.

But yes the methods can be abstracted into a common one, so we don't have duplication. The reason it was first added here I think, not sure but we didn't want to import the extensions in the instance models.
I wasn't complaining about performance Galder, it just looks way too complicated to me. E.g. if you used a for loop you wouldn't need a `from` parameter.
Shouldn't it work with just one cache manager then?
I guess you consider `object.ordinal()` too unreliable to be used? I mean, not safe that people might change the order?

isn't a good warning enough about it?

If you don't like it, what about adding an externalizer id field to each one, so that we can control the mapping explicitly but avoid the case operation?
If I add a dev-requirement into composer.json, maybe I can remove the setUp() method no ?
Please use sphinx rest notation.
```
:meth:`~MovieWriter.saving`
:meth:`~MovieWriter.setup`
```
should work.
Indeed, but I'm afraid, if the test suite is not extensive enough, to add bugs to matplotlib. I'd rather avoid any none trivial change.
What should be used instead of 'plot3D'? I don't use `mplot3d` myself.

I also prefer "x.flat" or "x.flatten()". This is what the Cookbook recipe looked like. I might change it.
For consistencies sake, have a look at the way UrlName is handled for products (https://github.com/mikehadlow/sutekishop/blob/master/Suteki.Shop/Suteki.Shop/Models/Product.cs). UrlName is { get; protected set; } and every 'set' of Name updates UrlName. There's also an extension method (https://github.com/mikehadlow/sutekishop/blob/master/Suteki.Shop/Suteki.Shop/Models/ModelHelpers/UrlNameHelperExtensions.cs) that does the conversion of name to urlName.
It is useless to assign a var with `d` and to return it as you can return d directly
Nit: You can ditch the outer set of parens here.
you can use rspec's syntax sugar, `some_value.should be_true`
Document @throws
Thank you for the integration test!
Why is there only one header name but two columns?
another comment that should go...
Specifically not doing this sort of thing. I want to hook into the _public_ versions of these methods so that people can (for instance) monkey-patch `removeClassName` and know that their monkey-patched version will be used by `toggleClassName`.
What about not using mocha (in relation to #93) ?
I was anticipating it wouldn't be an extra path, it would be an early return.  Note this will expose a different problem if we every actually run the code, I think this will trigger issue #218 (reconciliation object tracking can't handle reconciliation failure).
Not a huge fan of these switches. Maybe have an array or classes instead?
Starts the server.
This appears to be a bug in the bb implementation as opposed to a something not supported yet.  Do we really need this change?
Perhaps something like `plugin_onstartgame(script)`, `plugin_onstartclient(script)`, and `plugin_onstartserver(script)`?
Er, dunno how that happened.
```
if ($config && in_array(
        get_class($exception),
        $config->get('silentExceptionClasses')))
{
```
No problem, I wasn't sure what to call it. I will change it to iterationModulus
identação e formatação
Not necessary. If it's a removal, then _enqueue_removal will be called. _enqueue_update is only called if it's an update. If the instance is deleted from the database before the update goes through, then the update will fail silently, and the deletion will queue a removal anyway.
Oops small error from my part
Done  in 08fef20
Can you wrap/refactor this? It's something we'd want to do often.
Rename this to `HOROSCOPE_PROVIDERS`
Heh, I thought you will just delete this line. It is more readable if this is in else.
Please use jQuery.
You don't want to send 2D arrays. But you can unzip them and then zip them again.

jQuery:

```
{
    'name': ['a', 'b', 'c'],
    'column': [1, 2, 3],
    'order': [1', 2, 3]
}
```

POST:

```
name=a&name=b&name=c&column=1&column=2&column=3&order=1&order=2&order=3
```

Django:

```
zip(request.POST.getlist('name'), request.POST.getlist('column'),
request.POST.getlist('order'))
```

BTW, you should be sending panel names, without `panel-` prefix, this is something you are using in DOM, this should not go to the server.
processdata.js?
What all is available in the result?
`system "#{bin}/freeswitch -version"`
These methods act in the same way that HttpResponseRedirect does, in that you can either have it display text or a directory which leads to an html file. I haven't been able to get my VM to work to see, but that's how it works.
What's the intent with this line? Seems odd to set the money to 100 if it's 0.
use stricmp
aight...hold on i'll rip that shizzle out
@davidwhogg I changed my mind... see my comment _above_... :-)
Think it can be done also with `object_repository`?
You can simply add a new commit, and push it to your `feature_add_gender_to_contacts_and_leads` branch. Any new commits are automatically added to this existing pull request. It is also possible to edit an existing commit, and 'force push' to the branch.
Bet that hurt. Sorry.
I copied this code from another file , so i kept the comment
Space after ":".
[Done](https://github.com/pagespeed/ngx_pagespeed/issues/12)
`float(M_PI)` would do just as well.

Someone remind me: if we defined both `float M_PI` and `double M_PI` would it choose the right one, or would the implicit conversion confuse matters?
what's with the comment here?
we might need another option, if we want to use a global option dict
None would be for "use global/default settting",  (so we know that any other choice overwrites the global default)
"none" "no" or "no_check" for explicitly want that no nan checking is done
Looks like it went wrong when performing rebase. Thanks.
Oh, definitely not. The plugin is in tip-top shape. 

Even without the ```set_timeout``` on the event, I wasn't noticing any sluggishness whatsoever. 498455 was merged to master, but if you think the first way was best, let me know.
How about `||` for consistency?
This file should probably not be hanging out right inside `lib` - consider moving it into a child directory.
I'd rather explicitly use MessageFormat.format here, rather than statically importing the method.  I know this is a change from precedent, but I think it's an improvement.
it would be reasonable for the generate class to have some awareness of the different dirs it might target, based on the root project dir
As pointed out in other comments, I see no reason for this change.
Please do docstring comments for classes.
How do you define a reasonable amount of time for a demo script?

I just ran with the faster version, and it takes 14s to run script 1 on my machine.  This is an average of 0.14s for each pair of galaxy and PSF images, which is not bad considering how little work we've put into optimization.  However, I'm not sure we want to make people run a script that takes 1400s to make a 100x100 image... my assumption is demo scripts should be something people can play with, change inputs and run and see new results in a minute or so.
Strange indenting of comment.
Same as above.

```
_.any([null, 0, true, ""], _.isObject);
=&gt; false
```
Couldn't this be:

```ruby
@_slug ||= app.blog.path_matcher.match(path)["title"]
```
I believe I originally created this for 1.2.x, so I wasn't aware of any constants not already in the documentation. I think the test is helpful as the values were added to the documentation and it might prevent someone from haphazardly changing these in a C/H file.
nao precisa colocar a nota ```@Test``` em cima do método. Quando vc coloca em cima da classe, ja "diz" ao java q todos os metodos desta classe sao de teste e devem ser executados.
We shouldn't remove the references to the emulator projects here..
You are absolutely right. I modified the code to use `updateWithApiData`...no infinite loop. Also, now `updateSideloadApiData` can now handle collections. Check it out and let me know what you think.
In the toolbar folder there's only one other coffee file, which is for the current position. I think we could load both of them but it's not necessary.
Common pattern is one class per file. Also, please add basic documentation on what is the purpose of the class.
I think so better to put then in update function. bear in mind update is called several times. so intiailized only when undefined.