labofsahil/github-event-dataset-2012 huggingface dataset:
I made it a combobox because it was suppose to have all the available IP addresses and the user would have chosen the one. I didn't had enough time to implement the function to look for all the ip addresses available and load it into the list and to the combobox. Joseph asked me to do this. 
On 2012-08-22, at 5:22 AM, Dennis Ideler wrote:

> In src/freeseer/frontend/controller/Server.py:
> 
> > +        logging.info("Logger initialized")
> > +        
> > +        self.server = QTcpServer(self)
> > +        logging.info("Starting Freeseer Server")
> > +        self.startButton = QtGui.QPushButton('Start Server', self)
> > +        self.startButton.move(25, 90)
> > +       
> > +        self.statusLabel = QtGui.QLabel('Server status:' + self.status, self)
> > +        self.statusLabel.move(25, 15)
> > +        self.statusLabel.resize(200, 25)
> > +        
> > +        self.iLabel = QtGui.QLabel('IP:', self)
> > +        self.iLabel.move(25, 40)
> > +        
> > +        self.ipComboBox = QtGui.QComboBox(self)
> > +        self.ipComboBox.addItem(QtCore.QString("0.0.0.0"))
> I'm curious why you made the IP field a combo box (it wasn't at the midterm stage). Looking at the code, right now the IP address will always be 0.0.0.0. So a combo box will give the user a false sense of what actions are possible. Did you intend for there to be more IP address options?
> 
> I recognize that the current IP address is just for testing. But how will the user enter their local IP address in the future? (I'm assuming they'll be using it over LAN, not WAN.) Or will the program auto-detect the local IP?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 

Bora Sabuncu
Should be `string|boolean` according to note
и еще, current_user может быть nil? разве не только залогиненый пользователь может их аплоадить?
Currently small enough that we don't mind, but if it's a trivial change then feel free to patch it.
why is `getopt` in the list twice?
I wonder if the argument name should reflect that it is jinga loaders, or template loaders? (Or both, maybe?)
I need to read this several times to figure out what it is trying to do. I'd rather have duplicate code and easy to read tests, than clever tests without duplicate code.
This is the same technique we use in other places in the DB API.  In fact, I had a commit somewhere to abstract it.  I think it's in one of the pull reqs that are pending this pull and buildsets getting merged.

It is tested - in RealTests, since it requires a real DB to see the race.
SOMETIME?
Might get a bit messy with lots of variables declared at the top for individual command processing.  Would it be better to move the /window/:windowHandle/ code into a separate function?
The original wording of the last sentence was tough to comprehend so I took a stab at re-wording it a bit.
It's ugly that we have to alter the meaning of the buildTransform methods and then patch it up in other places to match expectations, makes for brittle code that will be harder to maintain (the next person making patches migth forget about this assumption).

As far as I can see we end up hitting this portion of JTS.toGeographic:

 if( crs.getCoordinateSystem().getDimension() >= 3 ){
            try {
                MathTransform transform = CRS.findMathTransform( crs,  DefaultGeographicCRS.WGS84_3D );
                Geometry geometry = transform( geom, transform );
                
                return geometry; // The extra Z values will be ignored
            } catch (FactoryException exception) {
                throw new TransformException(Errors.format(
                        ErrorKeys.CANT_REPROJECT_$1, crs));
            }
        }

Soo.. can't we simply chain the above transformation with the ones that are already in buildTransformation and centralize this 3d transformation handling in a single place?
Same test twice? A typo me-thinks! :)
dunno how that slipped through. cheers!
why `qwery` here, but `document.querySelectorAll` above it?
Can you do this after `wp_head` now?
Did this new test consistenly repro the issue (before you added the fix?)
This actually changes the log to include more identifiable data. Before, `m[1]` would have just been the primary domain. perhaps more than a nit?
0 is valid here? It's different to the constructor. :)
Again, it's nothing we want to declare globally. It's data which is only necessary in the onload method.
Fair enough. I think 'release' could be misleading though.
I guess the QueuedConnection flag was there for a reason... AFAIR the reader emits the signal from a thread.
This also checks my .tox directories. What do you think about ``pep8 ./rapidsms``?
This is part of our SIS integration work and can be ignored for now.  Safe to pull in, but not absolutely necessary.
It is undefined because the parent assumes ``err`` is an ``Error`` object with a ``.message`` property. This creates an undefined reference when someone just throws a string.

```js
runner.on('fail', function(test, err) {
  console.log("##teamcity[testFailed name='%s' message='%s']", escape(test.fullTitle()), escape(err.message));
});
```
`function askFor(argument) {`
hm, yep.
Suspect a regression from a stale branch. Needs reinstating.
This method should be added to ElementInterface.
We need to start using phpunit.xml for this kind of stuff, TestConfiguration.php is legacy.
Auto generated messages removed. 
Advantage: no faults due to auto generated files with potential local paths
Disadvantage: must be compiled twice.
Good catch. I copied from the existing test. :) Will fix it.
Sorry about that @windwaker 

And @znickq I was asking why use this instead of GameMode#valueOf
"*Ctrl" is an Angular convention. I can't change it if you really want me to.
Should that be Edition.published.count?
Looks better to have ```addEnvironment()``` aside ```getEnvironment()```.
Did you test the package on all those arches? If not, please only add what you tested.
line to long (also in rest of file)
Toon Willems ook.
Alternatively, you can use Maven to obtain the internal components. For example:
The punctuation aren't right here, it reads as "JBoss AS 7, Maven user settings not configured, or JBoss Enterprise Application Platform, Maven uer settings not configured". Maybe use parentheses?
space by right bracket
If we remove these, then the user could specify these options themselves. Is there a reason that you don't allow it?
I want to merge this but the marshal things confuse me - does this mean we're not going to memcache some things, or is the marshalling not needed any more?
A humble request to change this class name to TestBatchTransformMarketAware.

To follow conventions in the unittest docs and to make it easier when scanning code to see this is a test case.
消しましょう。
Yeah, I definitely need to document it.  I added a travis flag to the DB config which I subsequently forgot to check.  I'll check that (maybe change it to mock_database) and raise an error if it's not set. These migrations are only in the test/dummy app and the db names in that database.yml should indicate test (sfxlcl41_test, sfxglb41_test).
I'll additionally comment the test/dummy/config/database.yml with the purpose of these.

Other thoughts on ways to make this less harmful?
i know it was here before, but do we actually use login anywhere?
FYI ruby allows oneliner ifs
e.g.

```ruby
config.middleware.use Rack::JSONP if SETTINGS[:support_jsonp
nit: Simplify this to nested if block. The outer calls the super long name and then the inner handles if (collection)
If we receive a null move then we don't have to move. Period.
I'll clean all of these replyTo things up.  I was confused about an earlier comment about referring to self inside a closure.  I think I have a better understanding now (we'll see).
I'm not sure I follow -- this code doesn't qualify as "embedded JavaScript" as it's not actually inside a var or script tag, correct? And either way, it won't affect the generation of a solution as all whitespace is stripped out any way.

And you're correct, these exercises (and all CS content) don't work in IE 8.
It makes the acceptable answer types popup pop up
Gotcha, that makes sense. I just did what was easiest to reason with while testing honestly.
You could do `options.keys - VALID_OPTIONS` to get all of the invalid keys they specified, if they have more than one.
You should be able to use the same method to search for a value in the huffman tree, regardless of type
to get the resource, you have a method in GenericKarafCommand you may found useful:
getResourceFromFriendlyId or comething similar. ;)
プロパティが挿入され次第、以降のdefaults引数は影響を受けません。
Makes sense. But is max_length really being used on eZHTTPersistence::fetch ? 
Adding 'max_length' => 50 on eZContentClassAttribute identifier definition seems to work for attributes
But adding it to eZContentClass identifier definition doesn't seem to make a difference
Can you just use `pathinfo($file->getFilename(), PATHINFO_EXTENSION)`
компилиться
Please, avoid direct usage of Hessian2Input. Look at LogReader interface.
I do know that's what http://qt-project.org/doc/qt-4.8/qtsql.html says but it just doesn't work for me. QT += sql and #include <QtSql> just results in fatal error: QtSql: No such file or directory
We should stop doing this and user "super", qt now supports super, i already change it in several places
This doesn't feel right. Login strategies is specific to oae-authentication. The goal is to have generic config files that don't require adding new functions in the configAggregator. I don't think we need this function at all.
Agree, it shouldn't. And they shouldn't anymore, all the unit tests are verifying `_extra === undefined` on all models in the general search, `extra === undefined` on all the user models for general search and verifying the resourceType on all models in the general search.

Can you verify that you tested VIA the UI through the right branch, and if so maybe provide a unit test that can expose the issue?
Not at all :-)
But we *want* to iterate over inherited properties! Consider object cloning with `Object.create`: Objects here are being used as maps/hashtables, not as an instance of a class.
Sorry, but the way you have it set up, the only way to sort these is via a TreeMap.
Вот тут не совсем согласен. Хотя возможно этот момент уточнялся отдельно. В любом случае спасибо за замечания.
Кто ж говорит про архисложное? Я, например, не знал о существовании метода copy у NSMutableArray. Если бы знал о нём - применял бы. Только если б я знал уже коллекции Objective C к концу второй Лекции - зачем Лекция 3 нужна тогда?

"Любая задача кажется простой, когда знаешь ответ".
После этого не плохо было бы применить конструкцию if (self) {}. Это поможет избежать ошибок, когда по каким-то причинам self не создался.
у себя поправьте в проекте ) я посмотрел, в аналогичных случаях вы отнимаете 1 от делителя  

best regards,
Evgeny Trefilov


On Monday, 5 November 2012 г. at 22:50, idemidovich wrote:

> In dna/dna/Gene.m:
> > + self=[super init]; > + if (self) > + { > + //init nucleotid with random value out of all possible > + NSUInteger random=arc4random()%4; > + self.value=[Gene allGenes][random]; > + } > + return self; > +} > + > +-(void)mutate > +{ > + //current nucleotid value removed from nucleotids array, new one is selected randomly out of remaining ones > + NSMutableArray* availableGenes = [[Gene allGenes] mutableCopy]; > + [availableGenes removeObjectIdenticalTo:self.value]; > + NSUInteger random=arc4random()%3;  
>  
> убедили:) Туплю. сории
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/Hexlet/osx-project-1/pull/155/files#r2033292).
не вижу где идёт добавление использованных индексов в массив repeatCheckArray
Why did you remove the data folder? It's the folder where repositories and other markus data gets created.
Anything in the directory `old_files` is hidden form normal browsing (if I recall correctly).
Should locale be saved in (App) settings.locale so that we only have to execute this code once? Both Mac and Win.
@Pawel,

Thanks. Is it possible to setup the Travis CI build to cover most/all
supported browsers? Do all the squashing you need, I like to commit soon in
small steps ;-).

@Andy,

Thanks. About the locals: that was my initial idea, but I'm not really sure
how to get this done, especially in cases where the controller is specified
in the included template itself? I'm still in "grokking mode", so if you
know how this can be done, please do let me know! Would be a lot nicer
indeed.

About the promise: there actually is a default '.closed(function(res) {})'
(not then) which can be used. :-)

I also thought about adding an ok/cancel or yes/no by default, just didn't
get to do it yet. I'm thinking about adding a .buttons(buttons) to the
provider that allows you to set app-wide defaults.

By the way, any ideas on the provider-directive conflict?

G.


On Tue, Nov 20, 2012 at 3:07 AM, Andy Joslin <notifications@github.com>wrote:

> In src/dialog/dialog.js:
>
> > +		// I'm leaning towards the first option:
> > +		//	- it does not manipulate the DOM unless it has to, this could be done with the .ctor version as well,
> > +		//	but that feels a bit awkward, I think
> > +		//	- The injected $dialog could also support Prompt, Alert, etc. which makes it defintely a service.
> > +		
> > +		// ze $dialog servize
> > +		return {
> > +			message: function(title, message, buttons, opts){
> > +				if(!title) {
> > +					throw new Error('title is required');
> > +				}
> > +				if(!message) {
> > +					throw new Error('message is required');
> > +				}
> > +				if(!buttons) {
> > +					throw new Error('buttons is required');
>
> It would be awesome to have "ok" and "cancel" as default buttons.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/angular-ui/bootstrap/pull/25/files#r2175914>.
>
>
I'm pretty sure that mongoid is synchronous unless we used em-mongoid (see supported clients section under https://github.com/igrigorik/em-synchrony#em-synchrony).

Regardless, shouldn't this be very easy to figure out by simulating the condition of a slow mongo connection (e.g. putting in a sleep) and a high frequency of messages being published.
:+1: That's fair.
>and thus not all Commits in the enumerable would be checked

Good point.... Ok, let's be optimistic and avoid enumerating the commits twice. We'll check each commit as it's being  pulled.
Could you please reword the test method into something like `ComparingATreeInABareRepositoryAgainstTheWorkDirOrTheIndexThrows`?

It would make the intent of the test a bit more explicit as it's perfectly valid to compare two Trees in a bare repository.
Can the link text here be Media Events instead?
"that" vs "than"?
Same as I mentioned on test/support/integration.rb line
You're right. I've fixed it. The Scala version is ok.
It is nicer :) - but I found out that it doesn't work - either because code can't be inside bold tags *or* possible having the **`` next to each other doesn't work.
在需要代理的路径中，使用<link doc="ngx_http_rewrite_module.xml" id="rewrite"/>指令改变了URI，但仍使用相同配置处理请求(<literal>break</literal>)：
"2"? Really?
can you remove these prints? OK to use logger.warning() though.
Why map?
Плохо, хук для этого не нужен. Можно просто слушать нужные сигналы.
Олсо, зачем это вообще?
Это было бы весьма странно. Перепроверь и убедись, что у тебя там
действительно volume.
А если пустой? Лучше вместо op[] юзать value(0).
Вот уж кого мне не жаль!!!
И вот тут тоже.
I don't see a way for a superadmin to list all surveys. If the user is uperadmin and $suser (variable naming needs to be corrected here) is empty then $current_user will be empty and the subsequent query will return 'Invalid user'
typo: "caese"
Maybe we can cache this low level call too if `probeFormat` / `probeStreams` is called multiple times.
`$f` probably needs to be in quotes here.
abarth asked in the last review if this file should move to WebCore/platform/network.  I don't believe so; a Prerender is more akin to an object or an applet than it is to a network request, in many ways.
thats a good idea since it is independent.
Yeah, I guess it makes sense to me and melange, but not every Mark and Mary Githubber. I'll add in some comments.
If it's a constant (as the "final" implies), please use all caps
@jazminschroeder sorry, looks like my bad.
right now this should only affect dynamic routing after this patch https://github.com/symfony-cmf/Routing/pull/24 since usually there should not be an exception rendering the current route with a different locale. now if this in the end means there are no more links left to display, then so be it. better then rendering lots of URLs that point to broken pages which is what is happening atm.
This is not needed anymore, or is it? Using the asset pipeline and the alchemy_custom mixin should be enough IMO.
You use a combination of `a + b` and `a+b`; I'd recommend sticking to one.
After we dump MySQL... just sayin'
In your examples, best to use a let binding, not def (more idiomatic):

```clojure
(let [beta (to-double-rowmat [0 0])
       ,,, etc])
```
Maybe compose these into a predicate macro.
you should not change the input data
can this be written in a side effect free manner?
just to be clear - the semantics are that this is just a test for uniqueness - it should not modify the data
Can you remove `cachedConfiguration`?
I modified barely nothing from the original implementation. Let
me know if you want to see some of the things changed (e.g
int -> int32_t, float -> float64_t, etc)
sry .. Now i have indented my whole code .. have a look
The `Oembed` class could be rewritten to use instance methods, which would allow dependency injection. One use case would be to conditionally set additional options based on the requested URL signature.
This is your code that I moved around a bit, but I'll fix it anyway.. :)

// U.

On Wed, Aug 1, 2012 at 6:13 PM, Till Klampaeckel
<reply@reply.github.com>
wrote:
>> +
>> +    /**
>> +     * Parse the response!
>> +     *
>> +     * @param HttpResponse $response
>> +     *
>> +     * @return stdClass
>> +     * @throws \RuntimeException When the API returns an error.
>> +     */
>> +    protected function parseResponse(HttpResponse $response)
>> +    {
>> +        $json = $response->getBody();
>> +        $body = @json_decode($json);
>> +
>> +        // evaluate response status etc.
>> +        if ($response->getStatus() != 200) {
>
> Exit early:
>
>     if ($response->getStatus() == 200) {
>         return $body;
>     }
>
>     // error handling here
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/till/Services_Librato/pull/2/files#r1284124
Minor trickiness -- the tree isn't "modified" until the application makes a change, but the page is set up so that reconciliation does the right thing.  In summary, if there's a named checkpoint, we'll dirty the root explicitly to force a write of the tree, but the leaf page has to be dirty too, else reconciliation is going to fail.
Coding style violation.  See apidoc of any other Filelib class.
Why does it have the XHTML 1.0 doctype?
I think you can write this as

```clojure
(try
  (with-open [ss (ServerSocket. port 0 (.getAddress bind-addr))] false)
  (catch IOException e true))
```

The with-open automatically calls the .close in a finally block properly so that you don't have to worry about doing that.

I'm just not sure if the IOException will bubble up, but I think it should.
Are you sure the class "Zend\InputFilter\InputFilterInterface" actually exists, or did you maybe forget to add a USE statement?
It looks like you are building these 2-way named links on each page. I wonder if there was some way to build a global named link file and import that on in each chapter? Ala Django template inheritance, {% include named_links %} or something
I think @tbranyen is referring to astronomical amount of space in the "url" between http and ://backbonejs.org
Please change the type to boolean.
the bundle is also compatible with 2.1 so please use ``>2.0,<2.2-dev`` instead
The coding standard should be 4 spaces. with the { on the same line as the construct, this bundle follows the same as Symfony does.
I think it's "lets"
spaces around >= and <= here and on line 147
I think overall_pay_rate actually better avoid outliers -- a single fast judgement can generate a very high pay rate, but if we take all the times together, it better smooths out outliers.
What is this $arg? Your actions should all take no argument, or the same.
Just change comment to *Celerybeat*. Like it is above for Celery. So we tell who produces the file.
Empty string!
Source: http://jzaefferer.github.com/jquery-validation/jquery.validate.js
ok
For templates for e-mails, be careful to wrap lines correctly. Hm, is there maybe some tag to do it for you? So that output is nicely formatted, but with not too long lines.
This all is completely unrelated stuff and would probably have to be another pull request. But leave it now.
Isn't it better, to have everything in one page ?
Move to top-level constant (`HOME_CHANNEL_ID`).
Is it really necessary to include the .nuget directory with the project?
move to `createParams` and set exception
you sure about this?
This is currently this way due to unit testing - so I don't want change this right now, this pull request is way too big as it is now anyway.
Könnten wir nicht versuchen dies in eine einen Formatter Parent zu verschieben?
I guess this line should be deleted
Once there these are used more widely we will add this to MultiInputFormat. need to enhance MultiInputFormat to handle more formats. currently it reads lzo files. Apart from this, the loaders add following functionality :
    
   1. takes advantage of a short cut where the recordreader directly returns a Pig tuple. skips creating intermediate thrift/protobuf object.
   2. sets required field list for RCFile inputformat (this could be pushed to generic loader).
Agreed. Fixing it now.
Use strrpos/strripos instead and let the lib do the heavy lifting.
Right, I see what you mean.

Nothing in nginx core explicitly mucks with Cache-Control / Expires / etc. headers (I think) but a user can certainly do it from his nginx.conf.

I don't think there's a good way to prevent that, though. nginx doesn't have a filter chain that you can manipulate.
Chris, in my code, the line looks like "error_code ec;", I don't have the "libtorrent::" in front of it.
I'm not sure we should use rcmail object here (in common.js). However, I don't know also how to do this better ;)
лучше че было
This should be a private method -- no one else should ever call it.
And also.
I have to say that I'm a bit concerned about these no longer working correctly.  I guess the descriptors are surviving the change in the `__class__`, so they are still accessible even after a call to `applyDilation()` (et al)?  Is this a fundamental problem, or do you see a solution, and just haven't implemented it yet?
The four links above are not proper markdown links.  Do you intend for them to be?
I see where you're coming from, but that might be a bit of a premature optimization. The network request to get the server version is orders-of-magnitude more costly than a function call, and is already memoized via the `lazy_property` decorator.
I'm not exactly sure what you mean. (TBH this decorator is a copy-paste from an interesting StackOverflow discussion.)
Not sure -- it was in itsisu's static folder, so I just moved it to the new directory structure.
[`_.result`](https://github.com/masylum/underscore/blob/d3fe09c45a03047d01bde63845f267c91b3f09ee/underscore.js#L1059) doesn't support arguments. Then again, maybe it should? #857 got shot down but probably based on the bloat, not the arguments... I'll open a PR.
Don't you mean `if '?' not in failure_url:`?

In fact, I don't think you need this `if` statement at all. This will be good enough:

```python
failure_url = self.get_failure_url()
failure_url += '?' if '?' not in failure_url else '&'
failure_url += 'bid_login_failed=1'
```
hmm, agreed it's redundant since "Delegierte" doesn't change across genders (unlike "Schauspieler/in", etc.).  what about just marking it as "female" and leaving it as one line with "die", or the other way around?
you should not wrap the arguments
Hardcoded to a Linux OS, not sure how this works outside of linux
This looks suspicious...
perhaps we should rename the field ?
I noticed this is a link to svn. Don't think it belongs here. Would you mind removing it?
Если я правильно понял, то синхронизация работает с различными потоками. А тут возможна ситуация getMessage (class User) -> sendAll (class Manager) -> sendMessage (class User, возникла проблема) -> close (class User) -> deleteUser (class Manager)... И все это в одно потоке, таким образом синхронизация пропустит, и кинется исключение про то, что мы пытаемся удалить что-то из списка во время итеррации...
Т.е. в XmlBinder тогда писать что-то вроде (isPrimitiveOrWrapper(clazz) || clazz.equals(Enum.class) || clazz.equals(String.class)) ?
Что за переменная?
Лично для меня этот вариант куда менее понятный чем то что написано, но если вы настаиваете, то исправлю.
If I'm not mistaken, I don't see `isChrome` being set anywhere.
i think that empty line should be put back.
test_users_account.py:107:1: W391 blank line at end of file
PEP8 issue: test_statistics_page.py:61:9: E303 too many blank lines (2)
can we just do ?
    home_page.go_to_homepage()
Confirmed bug - if you choose "View assignments" for Eddy_J1 (via the COM), and go MENU>"Change soldier...", then you'll see your own personas (and not the ones belonging to Eddy_J1).
Elliott says "no full stop bro"
Стоит указать в jsdoc функции, на что в данном случае указывает `this` — из контекста это не очень понятно.  Например
```
/**
 * @this {BEM}
 */
```
Wrap lines in here and PEP8. Sorry for being so pedantic about this...
Yes, I checked. I also check in the SMACOF algorithm that the matrix is symmetric.
This operation is element wise, so I'd expect it to be safe.
Does floating work with memoryviews as well? If it does, then we can skip the pointers.
звісно, в мене працює
Hmmm, `fetch_stick` really seems like it's a behaviour of a dog, rather than a class by itself. `petted` seems to be an attribute of dogs.

I admit that if your dog can do 10 different actions then that will be a somewhat longer class. But it doesn't necessarily seem wrong to me. By learning how to write your class so that "the outer world" can call methods on the object (dog) without "knowing too much stuff" about it then you'll see how your code becomes much cleaner and less complicated.
I remember seeing that in the other files, I'll install 2.7 on my machine to test against as well.
That is not robust at all.  It will fail if the path contains any escaped characters.
why not just return the ThrowException?
NSStringPathExtensions are your friend :)
Renseigner la Pass-phrase, le point de montage des données et le path complet vers les données.
Not it's not the root path
Avoinministerio also checks (in the controller, mind you) that the name contains only valid characters.
the hibernate.cfg.xml has been left in my hibernate-search-spatial repo. We missed it when migrating code with Emmanuel.
I shall see how i can re integrate the whole thing and make benchs easily available. you ll have to download data files from geonames obviously.
Duplicate of code above (line 161), possibly worth commoning up - although only two occurrences, and relatively simple.
What I meant to say was the contents of the hash table are spilled as expected.  However the hash table array should only be freed when memory is critical.
Writing a general purpose function then putting code in to see who called it and act differently - yuk.
yes, I'll check/fix.
this is refactored in reLink branch
А без all не работает что ли? Просто ```@post.comments``` :question:
I remove them using "removeDirectory". Yep this test pass.
Please remove this change from the patch. It's outdated and we cover the 3.3pre version bump in another pull request.
for chipKIT, replace Arduino by Mpide
Sorry, I don't get this.. 
What case this ```foreach ``` catch ? Why using just the first item ?
argh...
I don't like your the approach that you took.
If you create an object like: cc.ParticleFire(), either it should fail (because "fire.png" is not present), or create a valid object.

The alternative is to support a optional parameter:

cc.ParticleFire("fire.png");
We're using single quotes on attributes, thanks.
Would WARN be a more readable equivalent?
@shacker I don't think we've made a decision about that. I've definitely been using px's.
There used to be a big benefit to using `em` when browsers only resized text.
Now they're resizing the whole page so it doesn't really matter anymore.
Agree'd and done.
Watch out for nil
Extra space in between "uses" and "valid"
The rename is cool with me.  We should also mention the `WebMercatorProjection` rename.
This points the camera to geocentric down instead of geodetic down.  The different is subtle on the Earth, of course, but south of the equator it can result in the camera being flipped (slightly) outside-down in a way that isn't normally allowed.  To fix this, I think you can just use the inverted geodetic surface normal as your direction rather than the inverted and normalized center position.
Also, in what case is `frustumsLength === 0` useful?  On the very first frame?

We should "prime" the frustums with some default ones, and then we would avoid the `length === 0` check in `insertIntoBin` and this check.  I'm not concerned about removing the check for performance; I'm concerned about complexity.  Seems like we can throw a little data at it (the initial guess at the frustums) to simplify our rendering code a bit.
If that is the behavior defined in the spec, then your code is OK.  If not,
we need the ||.  We don't need to worry about non-integers until we see an
actual bug that we need to workaround.


On Wed, May 16, 2012 at 3:53 PM, Dan Bagnell <
reply@reply.github.com
> wrote:

> > @@ -1320,13 +1320,18 @@ define([
> >       * @private
> >       */
> >      CentralBody.prototype.update = function(context, sceneState) {
> > +        var width = context.getCanvas().clientWidth;
> > +        var height = context.getCanvas().clientHeight;
> > +
> > +        if (width === 0 && height === 0) {
>
> This might just be for Chrome because I haven't checked other browsers
> yet, but the canvas width and height properties must be integers >= 0.
> Also, we use && because if you set one of them to zero, both are set to
> zero.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/AnalyticalGraphicsInc/cesium/pull/28/files#r834415
>



-- 
www.seas.upenn.edu/~pcozzi/
The idea was to get the large images out of the way first so it could minimize the number of resizes. The benefit of not sorting is I can avoid having a hidden argument (or separate _addImage method). I'd actually prefer avoiding the sort, but I'm not sure if that's a good idea.
Yes, there is one. the twitter button functionality (the one that I used for the buttons) takes only strings and an no classes. Then, since I was passing strings, I chose a switch statement. If you want to extend the twitter functionality, so that it takes also classes, then feel free to make the changes.
The case here would be for the exception route which would not have a path, as in [test](https://github.com/danbev/aerogear-controller/blob/AEROGEAR-426/src/test/java/org/jboss/aerogear/controller/router/DefaultRouterTest.java#L126), is that not correct?
nothing in particular really.  Just continuing the general camelCase that everyone has been using thus far.  I can change it to --log-level no problem
I actually removed the references to "web color names" and instead used the term "color names" so that users would not expect identical functionality with the web. No-one can argue that '#0f0' is green. Surely all we need to ensure is that we implement a consistent color scheme across our platform.

With this in mind, could you clarify what action is required to complete this PR?  Is it...

* test whether hex quadruplet (to include alpha) and (r,g,b,a) formats work across platforms and document
* test and add explanation of how to use the 'stripped' name on iphone and ipod, and make it clear that it;s not supported on ipad

If so, I will do this Friday morning, and work with you later in the day to complete it.

btw, can we fix the misspelled "stripped" value by deprecating it, and adding the correct spelling? We can then remove "stripped" in a later release.
Insert newline before return statement
Agreed, I like the separate summary and description clarifying each case best too. Fixed.
Are the T and . literal?

Format is kind of confusing... Might be worth inserting an HTML block to distinguish the variable and literal portions:


<i>yyyy</i><b>-</b><i>MM</i><b>-</b><i>dd</i><b>T</b><i>HH</i><b>:</b><i>mm</i><b>:</b><i>ss</i><b>.</b><i>SSS</i><b>+0000</b>

Lotta markup, but might help. ;-).
Never return null.

Instead throw an exception, like:

`throw new OAuthException("Echo Api only supports two legged OAuth calls");`
Good point, I'll change it back to the fixed name.  The only niggle I have is the underscore in the path `/etc/foreman_installer` compared to `/etc/foreman-proxy` - despite it being the exact module name, do you think this should be standardised?

It might also be good to make foreman_installer parameterised itself, with these two paths becoming the default locations.
А если он невалиден?
Please view example 1.3
http://www.duke.edu/~hg9/ctex/Math.pdf
копирование лишнее происходит
Yes. And where is the problem?
I don't think we really need this test either for the same reason as the comment for the test above.
yes, that works :)
Currently under discussion, but probably.
Can this ever race?
You can save work here:

```
ArrayList<BookmarkRecord> destination = waitingForParent.get(record.parentID);
if (destination == null) {
  destination = new ArrayList<BookmarkRecord>();
  waitingForParent.put(record.parentID, destination);
}
destination.add(record);
```

*but* -- note that you should be using a `Map`, not an `ArrayList`, to implement set-like semantics (because we can't use the database to reconcile colliding inserts), or at the very least have a big comment explaining that we're never expecting two records with the same ID to appear in the same `RepositorySession` store sequence.
Nit: cleaning.
Isn't the comment attached to the wrong branch of the condition here?
My view on this is a bit different: I can instruct Chef to setup a service and the platform specific implementation uses the most optimal way. For an "interval" based setup like chef-client, I dislike resources to be wasted on a process that is idle most of the time so I choose to delegate to launchd.
I've added basic support now: https://github.com/benmatselby/sublime-phpcs/tree/fixer Let me know if that matches what you had. There is more work to be done, as we could integrate with the sidebar to fix a directory. Also need to inform the user in a better way, currently using the status bar.. Let me know and I will merge to master and then carry on
remove item(0) from here !!!
This nodes= should have been deleted.  Should not cause harm as is.
I agree the removing of .gitmodules however should come after all this is solved.
Falscher Klassenname!
I thought Nico had indicated that this was automatically applied in the API?
TransactionTable.localTransactions already contains all the transactions existing in the system. It would be more efficient if that Map would be re-used (fewer contention points, memory footprint). In order to use that, you'd need to keep a reference to the corresponding Transaction object though, perhap as a field in  the SingleThreadValidation).
Do we need to format this date in a certain way?  If so, sounds like a good method to add to the TemplateFunctions
please remove "pseudo" anywhere it's used other than the PseudoTransactionManager and the PseudoTransactionalMessageSource
What happens with 0 results? An empty list or an exception?

The result is a list, regardless of the number of entities returned.
Good evening, Gary!

I've thought about `MessageStore.removeMessage()` before commit this changes, but I found it a bit artificial.
So, I'm glad to see that sometimes I think as you. And now I realize using here MS will be only one workaround which makes this feature work.
Thanks a lot. 

It will be pushed with other comments for a few minutes.
I would have to explain it in more details, and I will (as well as adding a comment in the code) but for now the 15 pipeline tests that were added make me feel confident that it is the right thing to do.
Actually this is a good catch, but instead of  using 'LIST_MESSAGEIDS_BY_GROUP_KEY all I need to do is 
````
List<Message<?>> messages = jdbcTemplate.query(getQuery(LIST_MESSAGES_BY_GROUP_KEY), new Object[] { key, region }, mapper);	
````

As far as AtomicReferences we need to set the values inside of inner classes and make them available from the outside. How else would you proppose to do it?
We have used in the adapter some features introduces in JPA 2.0. Shall we mention at the beginning of the chapter in a note or somewhere, that the persistence provider used should be JPA 2.0 compatible?
Uh, no idea.  As you can see from the diff, it was there in the old production code.  I didn't put it there.  Fine by me to remove it.
Why? Would this improve anything? From the API I would assume there's no network talk to create the receiver... (otherwise, why not have Begin... End...?)
This line is to long
the message is not the right one. I'm not sure the WAMP x64 builds are fine for 5.4 either (I haven't checked). and it should be ``if your project uses intl``
"muß" sollte in "muss" geändert werden.
This is a weird class name.
we are just deleting all the records not the database so its better to name the method accordingly
Define failcallback here.
Never user plural words ($properties). They confuse developers.
Prefer a suffix line *List.
Why did you comment out this line?
the above two strings are not being used
when you said: 
"src= part gone from url new .md file is showing",

you're using  your own code without the "?src=" part specified in action form  ?
Actually, as I now do the download non-embedded attachments work, I am thinking we actually want do_download to be a mix-in.  Ideally, I think we could move _downloadAttachments onto ActiveSyncFolderConn and have it be named just like ImapFolderConn's downloadMessageAttachments method.  The signatures are already basically the same (if you ignore my prior request to use the unused messageId :)
It dose seem a bit off here on git but that indentation dose not show up when i open the local file.
Or just "In parsed mode"?
```if (this.overlay != null) {```
or
```if ( this.overlay != null ) {```
That was the old logic, I assumed there was a good reason
something weird is going on here with the line indentation
Check that mockS3Client archives mockFile
vus