labofsahil/github-event-dataset-2012 huggingface dataset:
spacing: yep, will do.  Hmmm, hoisting p, normally I'd say yes, but in this case, it's the *only* var in the function, and it'd need to be hoisted quite a distance.  Ah, maybe hoisting p plus moving the new Date constructor to the bottom would help.
swissknife_lsrepo
IMO it's much more readable and explicit.
It should also be faster, as in the average case there are less conditions.
how about not creating the `lookup` variable? that way, we could have `var lookup = require('./lookup.js')` in the top of the file, and just `data.lookup = lookup(file, query);` here
Why remove the content view controller?
Gotcha.

I see it now, it was just one up of setAlwaysBounceVertical:

-(BOOL)alwaysBounceVertical {
  return _scrollViewFlags.alwaysBounceVertical;
}
sorry about the typo -- I like your suggestion about the implicit
paramMaker, I will make that change.

How do you feel about taking this one step further, and adding another
implicit paramMaker for anything with a += and ++= ?  I think we would need
to add a new trait, but then you also automatically get the accumulator
param for anything with the trait declared.  I suppose implementing
Growable and Traversable is only a little bit more work, so maybe its best
to just push the standard scala traits, but I wanted to see what you
thought.

On Sat, Aug 18, 2012 at 9:52 PM, Matei Zaharia <notifications@github.com>wrote:

> In core/src/main/scala/spark/SparkContext.scala:
>
> > @@ -253,6 +253,10 @@ class SparkContext(
> >    def accumulable[T,R](initialValue: T)(implicit param: AccumulableParam[T,R]) =
> >      new Accumulable(initialValue, param)
> >
> > +  def accumlableCollection[R <% Growable[T] with TraversableOnce[T] with Serializable, T](initialValue: R) = {
>
> This is misspelled -- accumlable instead of accumulable. However, I'd also
> like to find a way to not have a special name for this. We might be able to
> do something like this:
>
> def accumulable[R <% ..., T](initialValue: R)(implicit paramMaker: () => AccumulatorParam[R, T]) {
>    new Accumulator(R, paramMaker())
> }
>
> implicit def growableParamMaker[R <% ...](): AccumulatorParam[R] = new GrowableAccumulatorParam[R]
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/mesos/spark/pull/175/files#r1409673>.
>
>
No space after 'one'
desc. not really appropriate for N4BaisFieldCorrection
indeed - perhaps bvecs was a bad choice as an example. but the mapping idea would then allow extracting information that could then be used to generate other pieces of info.
The PyDataMem_* functions are for allocating array data.   This is allocating a c-array of pointers to ArrayObjects.  I don't think it would be helpful to track this in the same way.    

PyArray_malloc/free seem like the right approach.
Тут проблемы с мержем. Не доделано
да, лучше в начале файла завести нормально названную  константу и присвоить ей нужное значение
Agree, a 404 is best.
"Enable the debugger"
Please put these CHANGELOG entries in the top of the file.

PS: I thought this one was added when merged.
Do we expect people to use `scope [:v3, :admin]`? Otherwise I'd say `flatten` would not be necessary.
Do we need all this setup?
In Akka they now use an event stream for unhandeled messages. What do you say we use the System.err? 
I think that it is an OK alternative for the migration purposes only.
I created the `scala.util.hashing` package, but did not yet move `MurmurHash` there. We can do this in a separate commit.
Btw, `MurmurHash` is deprecated in favour of `MurmurHash3` - which does not inherit anything yet. Perhaps it should inherit `Hashing`.
also, since `parents` actually does some work for existentials, maybe it would be cleaner to compute tpe.parents only once
OK, I replaced the `CheckCPSMethodsTraverser` with an additional `isAnyParentImpure` parameter on the transformer methods (`transExpr` and friends). This is definitely simpler and it resolves some of the other issues that you pointed out.
Remove this `TODO`, this implementation looks more efficient that the superclass impl.
I don't understand this change - it appeared that non-symbolic terms were pulled out to guarantee that they were first in the exprlist (but then all terms were included again in since expr, not d, was fed to makeargs). So I would have left the if block intact but changed expr to d in the first part and (perhaps) add the self identity in the second half for non-Adds.
Please just use removeO and getO with regular subs. IMO, this is just too much code to look at for doing such a simple thing.

```

>>> sin(x).series()
x - x**3/6 + x**5/120 + O(x**6)
>>> _.removeO().subs(x,y)+_.getO()
y - y**3/6 + y**5/120 + O(x**6)

```

If it's not that simple then at least some explanation with inline comments as you go would be helpful. If you look at the Mul.flatten code (which is quite long) you will see that there are little comments explaining what is going on in different if-blocks as I recall.
This makes me think that `S` is expected to contain at most three elements.  If this is so, it would be great to document the meaning of `S` here (and possibly change the parameter name altogether), because in line 443 `S` is defined to contain all non-zero elements of `G`, which I'd expect to contain more than 3 items in general.
On 17.04.2012 11:12, Christopher Smith wrote:
>> +        That is, if ``self`` is the ideal `I`, computet the set
>> +        `I : J = \{x \in R | xJ \subset I \}`.
>> +        """
>> +        self._check_ideal(J)
>> +        return self._quotient(J)
>> +
>> +    def intersect(self, J):
>> +        """Compute the intersection of self with ideal J."""
>> +        self._check_ideal(J)
>> +        return self._intersect(J)
>> +
>> +    def saturate(self, J):
>> +        r"""
>> +        Compute the ideal saturation of ``self`` by ``J``.
>> +
>> +        That is, if ``self`` is the ideal `I`, computet the set
>
> computet ->  compute?
>

absolutely.
You can get that through `exhaust(flatten)` . I've tried to make each rule do as little work as possible and left questions like this to the use of strategies. It's pretty easy to get either behavior by using or not using `exhaust`.
I'm not sure the previous additional lines were necessary but if you added them to make 3 blank lines between portions, then you probably don't want to delete this line here.
Can we deal with this in a separate PR? It appears this PR is the first time that people are really looking at blockmatrix. I'm really glad that this is happening but would prefer to deal with preexisting blockmatrix issues separately.
Not really. `Point` does save internally some coordinate information, however on the outside it behaves completely independent of coordinate systems. And I am not sure why the clash is a problem when they are in different namespaces.
how is this ever supposed to work?
No I mean `terms` comes from a call to `_eval_nseries`, which should never return anything containing log(x) (if `logx` is passed):

```
In [1]: log(x)._eval_nseries(x, n=3, logx=y)
Out[1]: y

In [2]: log(1/x)._eval_nseries(x, n=3, logx=y)
Out[2]: -y

In [3]: log(1/x**2)._eval_nseries(x, n=3, logx=y)
Out[3]: -2⋅y
```
As long as the tip is handling the hover/click logic - this can be Abstract.
Handle errors in middle of connections?
Yes, it works on Linux testing machine.
It's a non-null field and the `PairActor` doesn't know how to populate it - this will be populated by the `ScanActivityStore`.
It is used to construct a "signature" of a method. It is generated in `generator/classes.lua` in function `fill_wrapper_code`, and subsequently used in `print_metatable`. The main idea was to use only a single overloaded function where there are multiple C++ versions that do not make sense in Lua. As an example - `fun(char)`, `fun(int)` and `fun(long)` would all generate "integer" signatures, but the `long` version would get the least "defect" and therefore be chosen, the others will not be generated.

It is not actually used in any checking during runtime (there is another mechanism for that).
Only the authentication credentials are transmited in cryptographically secure exchange. No other exchange, including configuration, oplog entries, or heartbeats are encrypted. 

(caveat: SSL)
Should probably use document.is_template here. It gets updated by the model on save(), and has an index
Can be simplified.

```php
$sql = 'SELECT t.teampage_position
	FROM ' . TEAMPAGE_TABLE . ' t
	WHERE t.group_id = ' . (int) $group_id;
```
The user needs to be informed one way or another that their request was either approved or denied. If I am supposed to make emails optional and not send a PM, how are they going to know?
This seems incorrect to me.
bbcodes as its for custom bbcodes. custom_tags is part of the custom_bbcodes system. Its not an event just for custom_tags but it is for custom_bbcodes.
You should use `e.preventDefault()`, not `return false` - returning false prevents the event from propagating, which we don't want.
Please make this an ELSE to the BEGIN, so that the explanation above and the table headers are always shown.
No inline assignments please.
You mean you want to rename the $row variable throughout the mcp_forum_view method? That would be for a separate PR.

In my opinion, if there is any confusion about what a variable being passed into an event contains, we should add comments above the $vars = ... call, rather than changing the variable name in the rest of the code just so it is clear in the event call what the variable contains.
sigh - so much for that macro. It seems there are several places it's done this in previous PR's. I guess I'll fix those in a new PR and I'll update this one shortly.
I'll look into this... I'm sorta scared to modify this code.
processVersion isn't right for the bundle, right?
There's probably a bug in aspect ratio calculation. Discussed personally.
I think so. There are few "mark" actions as part of the legacy that need to be reviewed. Marks should be really important moments rather than start/end, you're right. I will start changing some of them.
значит поставь версию 0.6. Подождем когда автор плагина доделает его. Или, может быть, поискать плагин другой
Code style - space after the if, no space after the ')' and before the ')' and but { on a new line
damn Esc removed my comment before I pressed a button ;)

I have reported to numpy:  http://projects.scipy.org/numpy/ticket/2188

I think we should do again try:/except: and only then ndarray.flatten() -> set -> ndarray in except    and all that only if preliminary check shows that we deal with a buggy numpy

would you mind sharing again your timing scriptie?  I will do it
do or add sub-ticket to RAXAJSS-324
text is wrong. 
* not a drug purchase order - this is a BillItemAdjustment
Good comments breaking down all the regexes would be useful.
これが問題になるのって、　インストール第2ステップ完了したあと、ログインした時ですよね。

可能性として、　X-updateの oninstall　にメソッド積めば確実にできるな。　とか思ったけど、その時点ではFTPアカウント未入力だから操作できないですね。　残念。。
These two lines solve the compiler problem, the rest are cosmetic details.
Ditto. If necessary, context may be passed in and out, or control may be inversed, and xmlSaveFile logic may be passed as a callback to the SaveAsFile function.
if workflow= presenter why the parameters of one of the presenters are (factory, view ) and here are (view, factory). Isn't it better if they are in the same order in every presenter? I suggest that the parameters start with request factory
Just wondering id there is any particular reason we pass the new route and new params?
Why not just `return False` immediately whenever any of these conditions becomes true.
I'll just point out that it's spelled "pseudonym".
Why did you add it for Gtalk integration?
RespBody can be undefined though.
I would expect us to merge the code for sandboxing into the current code for e.g. `configure`, `build`, and `install`.
This behavior now in done function, not in complete method, dataFilter function will be already applied, if specified.  This is why none of the test is broken
@curiousdannii thanks!
I am not sure that having feed(x, y) and feed(other) the same function name "feed" is good. Although you can think that both are feeding something into the accumulator, the former one is essentially a transition function and the latter one a merge function. I can't quite get the necessity of hiding the differences of the two by assigning the same "name", though different signature.
Should be a temp table. Done. Thanks.
mmmm ok, but can you put it in #region with a note then?
Make sure you keep the comment related to neon next to the neon code.
let's use error_msg here.
The empty jed instance should be created only once.
Any reason this can't be done as a `ThingJsonTemplate`?
https://github.com/andre-d/reddit/commit/20345bd280dd430e2159588065209dc1ba427059#commitcomment-2179577
Let's keep the URL in the message, if we can.
ahh so it's actually the same thing, but just a different syntax for it, basically the same length too :)
this could be very verbose, maybe debug?
This could be scoped to within `.component.audio-player`.
Is this needed anymore?
This seems like a reasonable modification of the existing code, but I'm curious -- couldn't we replace the whole loop with just:
```
var foundMenuItem = menuItemMap[this.id + "-" + command.getID()];
```
It seems reasonably safe to have this depend on how MenuItem sets up its ids, since they're both impl details of the same module.
Our class name conventions should be ``sample-localized-dialog``
Should add an instance var for promise, too (can default to null)
This doesn't do any escaping, so it could break the HTML if there are quotes/etc. in the string.

Why not do it the same way as \_launchFind()?  That should work just as well for the Replace dialog.  And since \_replace() only does anything when there _is_ an Editor available, I think you could ditch getCurrentEditorSelectedText() and follow _launchFind()'s example there too -- i.e. simpler logic for getting the initial string.
This looks good. My only comment would be to break this condition on the && to make logic easier to read:

    if (editor.posWithinRange(ctxPos, sel.start, sel.end) &&
            (!endCtx.token.string.match(lineExp) || editor.indexFromPos(sel.end) >= endCtxIndex)) {
This occurs when you type @ plus something else and then delete backwards. It's triggered when the @ is deleted since no plugin will match. This code gets hit more when the filename@symbol is enabled, but since the code requires the matching character to be first.

The matching chars are like a state machine for quick open causing the current plugin to change as chars are added and removed.
I added special cases for LESS and PHP.

Note to see PHP, you need to add a PHP block of code something like <?php echo "hello"; ?>, make sure file is in the working set, place the IP inside the PHP block, switch to another file and then switch back.
This code should not be here, it should be handled by the `save` plugin that does the actual saving (it's there already as well so probably fine).
Why is this `!user` check? If user is null it will throw anyways.
But this directly reflects the language typing and it may not be noted as deviation from the design.
It is just a bit smart to show you the completion you'll use is a method, variable or a text completion (no icon, like a keyword)
hehe I totally missed that you made the config file optional. mentioned this below.
`m` ->  `vertex`?
not a fan of this markup style. anything that belongs in html should be in a django template. we need to start moving away from large chunks of mark_safe text in our code.
is this ID not used anywhere ?
Here, the same thing is happening as the report value tag, where if we created a custom tag where we could set an HTML element property, then we could just invoke the tag and set its attrs directly without manually printing a bunch of HTML into a string.
should use Ext.create here
Name the exception here.
Not good. You change `default_error_messages` in `forms.DateTimeField` here! Don't do that!

You can try something like:

```
default_error_messages = forms.DateTimeField.default_error_messages.copy()
default_error_messages.update({
    'bounds': _(u"Value is out of bounds."),
})
```
It is a good question if we really want to use size argument. Because if we request just 50x50 always, then we will be able to cache that and then resize it to smaller in browser. Or we could always request exactly the requested size, but it is a question if this is reall better.
Often you use classes for initial state. Afterwards you simply show and hide with jQuery.
You should set the value here! Also, why `id`?
Also shouldn't be a type number as we allow smpte type strings
Use protocol-less or https-only URLs
Also, use the actual CDN server, `http://videos-cdn.mozilla.net/serv/webmademovies/legorough02.webm`
No need for the ?butteruid either.
Better? (see below)
I can add a "Scheduling update failed" message, since the actual update is done async
Hrmph, I should have paid more attention. I thought it would convert the null to -1, but it doesn't. Stepping through, the difference is that MAX(id) returns a row so rs.next() is true and the JDBC driver converts NULL to 0. I will fix the code so that it starts with ID 1
dlopen(3) required by dso was not found
I used blockquotes instead of code quotes/format because I had some issues in markdown :-)
Actually i'm glad you pointed it out, this really needed to be in  after_suite  not after_suites, so i moved it just below.
Ah good catch.  There are no permissions directly related to content
search, it is based off visibility of Providers and Environments.  So
we do need to fix that.

-Justin

On Tue, Jul 17, 2012 at 4:14 PM, Brad Buckingham
<reply@reply.github.com>
wrote:
>> +#
>> +# This software is licensed to you under the GNU General Public
>> +# License as published by the Free Software Foundation; either version
>> +# 2 of the License (GPLv2) or (at your option) any later version.
>> +# There is NO WARRANTY for this software, express or implied,
>> +# including the implied warranties of MERCHANTABILITY,
>> +# NON-INFRINGEMENT, or FITNESS FOR A PARTICULAR PURPOSE. You should
>> +# have received a copy of GPLv2 along with this software; if not, see
>> +# http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
>> +require 'util/package_util'
>> +class ContentSearchController < ApplicationController
>> +  before_filter :find_repo, :only => [:repo_packages, :repo_errata]
>> +  before_filter :find_repos, :only => [:repo_compare_packages, :repo_compare_errata]
>> +
>> +  def rules
>> +    contents_test = lambda{true}
>
> Will we have a permissions model for the content search?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Katello/katello/pull/327/files#r1182571
This PR is getting old, I like what inecas recommends.
Yes, the potential for embedding images via jammit requires them to have 'embed' somewhere in the structure.  

See: http://documentcloud.github.com/jammit/#embedding
Java interop MASTER!
I thought the usual deal is that you only want to treat `undefined` as "absent". The documentation (in the README) says this an optional string or buffer. I would think that `null` should be counted as none of { string, buffer, absent } and so should be an error.
or just if (totalLength)

(this would fail if totalLength == '' for some odd reason. Of course my suggestion would fail if it were < 0 too, among others.
path.normalize不能满足需求么？
+1 - the default should be the best (even if computationally most expensive) algorithm
Oh, sorry, I meant just `AstropyLogger` - ``automodapi`` does *not* document `log`, because it's an instance rather than a class, so right now there's no `AstropyLogger` API in the docs.

But now that you mention it, are there any other classes you define here that are taken as parameters or return values in  `AstropyLogger`? if so, they should be included, if not, just `AstropyLogger` (and `LoggingError`, of course, which you already have)
Right, didn't see this and Qt GUI stuff is still sometimes weird for me :D.
Conventions have class names using `-` so `time-ago-in-words`.
"coloring" is not an accurate word. The wrapper div gets the `error` class, you could have any styling for that class.
Just FYI, copyright doesn't exist in France. There is no legal value.
this kind of an error message will not explain anything to anyone who is trying to debug an issue.
any* project
What? Why do you need this.
when you're working with a specific type of document it's better to use SMSBillable.get_db than the dimagi utils one (which makes it impossible to split the database down the line)
should be ``array``
Yep - it's particularly a problem for non-Declaratives, since I'd like to write:

    image = FileImage(location='foo.png')

rather than have to do a multiline:

    image = FileImage()
    image.location = 'foo.png'

Plus it also breaks your Pythonic syntax for declaratives somewhat.  You can no longer say:

    button = PushButton(text='foo')
    form = Form(children=[Label(text='bar'), button])
I appear to have discovered a hidden feature - constraints on the central widget do indeed take effect.
Have you verified this works as well for certificates that depend upon other certificates?
Good ideal, will.
P.S.: Just noticed that I got the terminology a bit mixed up in my reply 
(shouldn't be reading github at this hour...). What I meant was, we 
could keep the *Definition interfaces separate from NodeInterface, and 
have Entity/Collection/Property implement it. I think that would already 
go a long ways in clearing things up. But again, it's you call. I'll 
merge whatever comes next :-)

Am 30.07.12 22:45, schrieb David Buchmann:
>> @@ -0,0 +1,111 @@
>> +<?php
>> +
>> +namespace Midgard\CreatePHP\Type;
>> +
>> +/**
>> + * Common base interface for all type definitions
>> + *
>> + * @package Midgard.CreatePHP
>> + */
>> +
>> +interface NodeDefinitionInterface
>
> ok, pushed an update with the separation between node and rdf concept in the interfaces. also tried to make the metadata loader handle the distinction. the tests still pass, so it should work with our implementation.
>
> i suggest we do the cleanup of children / collections separatly. the current state there is not worse than before and i really start to lose the overview with this pull request. currently the entity is rendered with its collections and properties, so getChildDefinitions does not seem too wrong to me.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/flack/createphp/pull/12/files#r1267497
>
Om de een of andere reden vind ik dit vies. Zou dan eerder hierboven een andere var gebruiken, maar dat is persoonlijk
We'll handle the versioning. Can you please remove this from your commit?
You're effectively recreating `shell=True` by using `bash -c`. But the vulnerability the docs mention is about untrusted input injecting shell code - which we don't need to worry about, because the notebook exists to let the user run arbitrary code.
Probably we have different purpose. You want to hide a proxy layer behind standard Net interface and I want to build a toolkit to use HideMyAss proxy lists. 

I agree with you, my implementation is not the right way to accomplish your purpose. Unfortunately Net::HTTP.start is not flexible enough for my requiements so I think is a good idea to use your gem as source and build a separate toolkit.

Thank you for your explanation. It has been very useful :)
please remove all use of wildcard inputs from this PR
You can write this more cleanly with two tests, one which you expect to succeed and one which fails.  The latter can use @Test(expected = AuthorizationException)
I believe this line will modify `settings.DOTLANG_FILES` by adding things to it. Which will grow requests after requests, like in https://bugzilla.mozilla.org/show_bug.cgi?id=760570. You should make a copy on line 110.
If the code below is working correctly, will this ever be True? If not, we won't ever get emailed about it right? It would be nice to get an email when we fail after max retries.. Maybe?

Or maybe just some statsd calls will give us some insight into what is going on with retries in prod?
Oh I see... Some tests are done on a thread without any posts, which is actually not valid. So you probably just need to add a `post(thread=t, save=True)` in those tests.
it is a secret :-)... damn i grepped for print statements but forgot to remove this. it is my quick and dirty way of running just one test (passing -axx)
true true.  ok, corrected this.
use `source_list = source.splitlines()` which is better protected against `\r` stuff
same as above, this seems like something site-specific
yes, if you have permissions otherwise github complains. For read only access you don't need anything I think.
I think the comment serves its purpose.
Align `==`
Yes, renaming to `matcher` is a good idea.
this is indeed wrong. The page is in English
The phpdoc is wrong as there are 2 arguments to the method.
Where are you using this???
in marboot be layoute
To allow for version numbers like 4.10.0, perhaps this should use `r"\d\.\d+"`?
A blank line before this would help.
It seems odd to only subclass `Ember.Control` in one place. Were you intending for other controls to subclass this as well?
Pourquoi un POST et pas un PUT comme avant ?
$newParentTag here does not need to be instance of eZTagsObject, in that case, this would fail with fatal error. The usecase is moving the tag to the root.
There shouldn't be a comma here!
changing to increments of 100.
All loggers should be i18n loggers. A static logger from the ControllerLogger should be used. Also categories shouldn't really use the class name, a more generic category is better.
Just checked the code on master and @bstansberry is correct. It has been modified there appropriately. I was simply following the original PR for consistency. Also, @jamezp, what you suggested is the update on master.
This will not allow runtime modification of the default, as the EJBDefaultSecurityDomainProcessor will always use the service that was passing in at bootstrap. 

I don't think it is actually necessary to make this a service, instead you can just create the DUP in the Resource class and pass it directly to the write handler. Have a look at org.jboss.as.ee.subsystem.EeSubsystemRootResource for an example.
Is this necessary? From what I can see it looks like hibernate should not be adding a transformer in this test?
El shift() me parece que tendría que ser por fuera de la iteración.
Mixed tabs and spaces, always uses tabs on these projects.
Note that this unset() is somewhat important, because it makes sure this property is not changed in the database.  

When an admin decides to change a users password, but does so by entering the old password (above statement evaluates to false), this property would hold that old password in plaintext form and the save() below would commit that to the database, causing a major security risk (exposing the admin's password) and effectively rendering the account useless because it would become impossible to login again with those credentials.

Ofcourse changes of that happening to another users account are small, but it may very well happen when updating his own account.
for debugging not used anywhere right now. Useful when need to compare spans which only contain the MS
if (scrollX == 0) {
  this.container.style.MozTransform = 'translateX(' + (scrollX + (this.posLeft <= scrollX ? 10 : -10) ) + 'px)';
} else {
  style.MozTransform = 'translateX(' + (scrollX + 0.001) + 'px)';
}
dom_container -> container
It looks like the text indent is wrong
The indentation seems broken.
we need to convert the style of the file from ,foo to foo,
here we need a comment indicating that we are updating those friends that are potentially selectable
It was just a lint fix.
alternatively it could be also used:
```str.gsub(/'|"/) { |c| "\\#{c}" }```
which is probably nicer looking.

should backslashes `\` also be escaped?
s/informations/information, it's an uncountable word.
These lines are so crazily long that I missed the whole `circular=grib._x_circular` thing the first time through! I know you can't reformat because of the limitations of the file format (that's another story!), but perhaps the refactor you mention later would help.
I think it adds complexity and is a little weird to support `format_docstrings false`.  I think it's fine for users to use `format_docstrings { |s| s }` for the "identity" formatter...and the false case would only be useful if the format block is already set to something else...but given that we don't set it to something else, it would be the user who would set it to something else....so they could just remove that.
`Ctrl-Z` already has a well defined behavior of suspending the foreground process.  Overriding it here could be potentially confusing for end users.  Thoughts?
Why is this section moved outside of the if statements above?
>> +                     if (pcrcompositeSetPcrValue(hPcrsWrite, selectedPcrsWrite[i],
>> +                                                 pcrSize, pcrValue)
>> +                                     != TSS_SUCCESS)
>
> same here, the above 2 lines should join?

  Yep, I can fix these, thanks for the review.

Kent

> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/srajiv/tpm-tools/pull/4/files#r722923



-- 
IBM LTC Security
We should probably make args an optional argument
Same comment as above: this feels useful for all joins, not just matrix joins. Pull it out into a separate file?
Why is this extending Mappable? Would we ever use it for a non-FileSource?
"existent" is spelled wrong.
To be fully API compatible with Google App Engine, I think we should just show the user the error message and not add our own stuff around it.
Where does APPSCALE_HOME get defined?
What is the "current" machine?
Yes, sorry. Please see commit cf883a0
Should I add the license in a text file to the root folder of that algorithm?
&view=karma has been deprecated after K1.7.
Can you just fold these functions into measurement.py? There's no need for this to be a separate source file.
мама! что это? :) расскажи какую ситуацию ты хочешь обработать
In EntityComponent, there is an onSpawned but its only called ONCE in an entities' lifetime (even between sessions) and unless its attached before the entity is spawned, onSpawned may never be called.
hmm the chatComponent and broadcast is nice... thanks.. concerning the name... there is none required atm.. do we need to implement it?

would that be the name of the channel or the name PERHAPS displayed in front of the message?

what I also think about atm is that we would probably like to move the formatting off <player> into the chatchannel format too... that is done atm in PlayerChatEvents
This and the next two methods are Vanilla-like...don't belong in SpoutAPI
Er... That's not what's currently there: https://www.gov.uk/jobs-jobsearch
In normal usage , pFontName is family name, but Freetype need a full path of font to pass to FT_New_Face. So we need a function to handle font info, e.g.  get full path by family name or style stuff...
To make this testable, and to make things cleaner, I suggest you extract the logic into a `command` method.
Until now I had no problem with it in production mode.   

I've made the suggested changes on javascript  but I can't make  
the tests because this editor is an iframe and I can't figure out a way  
to send key press events instead of using fill_in.  
If anyone can help me with that it would much appreciated.  

I can make  white background  on preview no problem.






On Wednesday, October 17, 2012 at 4:40 AM, Valeriy Sizov wrote:

> In app/views/wikis/_form.html.haml:
> > + .input#em_content > + .input= f.text_field :content, :type => "hidden" > + :javascript > + var opts = { > + container: 'em_content', > + basePath: '/assets/', > + clientSideStorage: true, > + parser: marked, > + file: { > + name: 'epiceditor', > + defaultContent: '', > + autoSave: 100 > + }, > + theme: { > + base:'/themes/base/epiceditor.css', > + preview:'/themes/preview/preview-dark.css',  
> are you sure that it will work in production mode?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/gitlabhq/gitlabhq/pull/1708/files#r1865167).  
>  
>  
>
@jnicklas done.
http://ariejan.net/2010/12/15/why-did-errormessagesfor-disappear-from-rails-3/
Yes, to me deprecating means "mark as deprecated" as well. I had thought we would have an alternative at the time we deprecate something. Then the purpose of the deprecation period is to give developers time to migrate to the new code. If we don't have anything to offer developers as a migration path, what good is it to deprecate?

I don't really think it's a good story to tell developers to stop using an API and to migrate away from it, without offering them a replacement. But maybe I'm confused about this?
Should I add that comment in the previous code then?

https://github.com/mozilla/addon-sdk/blob/master/packages/addon-kit/lib/selection.js#L345
https://github.com/mozilla/addon-sdk/blob/master/packages/addon-kit/lib/selection.js#L370
`language` sounds good to me.
You should be able to pass `null` as `prototype`. Also why do you need `if else` here ? Original prototype normalization had no branches and was simpler.

```js
prototype = typeof(prototype) === 'object' ? prototype : Object.prototype;
Object.create(prototype, { then: { value: then } });
```
> Something I forgot and don't know if we talked about already, why don't we need the height?

Yes, I left it out. See below!

>Is it set automatically based on the number of maximum visible rows of the tree?

Yes, it is set automatically.
Or just the base httpbackend, since it can handle incoming messages. @tobiasmcnulty updated the Kannel docs to the use the *preferred* backend reference with KannelBackendView.as_view(backend_name='foo'). We should use that here too.
any reason to have both 'i' and 'currIndex' ?
if you move it to own method, then also udev_string should be defined here, if there is not some demand for it and if so, then document it.
Component allows to disable host by `$uri->setHost(null)`, but yes `$host !== ''` is wrong here
I'd create a new test file for the Message-Id header, and move these tests into it (and have the tests simply directly work with the header object).
nit: (feel free to put this off) Is there a URL for latest version?
Why are these hyperlinks without any href attribute? Should just be a `<span>` maybe?
where's the inherits fallback?
Don't make this public
-> autofocus="autofocus"
@samiluukkonen Fail.
btw, why not allowing an array here whereas the query allows it ? It is inconsistent
Aha :) Then add a comment on the end of the line please ;)
Any reason to get those services via the container instead of injection ? (sorry if we already discussed it)
Yes indeed. 

Proposal: Application -> EasyBlock and EasyBlock (the current) -> EasyBlockConfig ?
See, here you are using (key, val):-p
Should this use shared.PYTHON as well?
Yeah, its not a big deal, just me being fussy. I'm sure that brings back 
some memories.

On 03/04/12 09:39, Jason Paige wrote:
>> +     * Denies access to all resources for all roles
>> +     * @return \xframe\authorisation\Acl
>> +     */
>> +    public function denyAll() {
>> +        $this->rule = array();
>> +        return $this;
>> +    }
>> +
>> +    /**
>> +     * Denys all access to a resource
>> +     * @param string $resource
>> +     * @return \xframe\authorisation\Acl
>> +     */
>> +    public function denyResource($resource) {
>> +        unset($this->rule[(string)$resource]);
>> +        foreach ($this->resource[(string)$resource]->getChildren() as $cResource) {
> Can do, if that improves readability a bit.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/linusnorton/xFrame/pull/4/files#r637882
Since `.thumbnail` is defined by bootstrap I think it might just be easier to leave it the way it is - if we were using less and we could do it in a DRY way I would agree with you. Does that make sense?
Input in the label eh? I find that kind of weird, but I forget if it's allowed (it probably is?). Does twitter encourage it or do we just like it?
yeah, cosole.log-tracking leftover. I can take it out, since it doesn't really do anything.
для sortable. підсвічує місце куди можна перетащити <li>
I think, homes_file should be in the world folder.
This requires that the master can SSH into the slaves. I can add configuration for that, just remind me next week :smile:
pass the element itself as function parameter instead of passing the element attributes.
css和jquery的选择器是不是样的
I think using a different word/shortened variable name is preferable to using an underscore. Underscores are ugly
Label hardcoded???
Yes. Currently CakePHP is the only one that inflects package names to be StudlyCaps. I'll fix the variable names (it's a cake convention where we case the var to match the type).
Lower than the default calculated value.
But yes, you're right 'low' is better here.
All method names must be declared in `camelCase()`.
а защитник где?
Stupid JS/Ruby context switching :)
blank lie contains whitespace
I would call it `Username basic HTTP Authentication`. Same for the password.
Should this verify that the keys in the JSON are the same as from `items()`?
Good point. But that shouldn't be changed on this branch.
Mmmm, it looks a bit contrived the code here. And I'm wondering if the ``None`` message could be somehow get lost with a bad timing?
I think we want:

    zeus rake "$@"

To pass all of the arguments along, instead of just the first one.
Great example of low level API usage!
`@staticvar`
Can you make this array use logical indenting? You seem to be pushing it even further to the right.

	protected $valid_drivers 	= array(
		'cache_apc',
		'cache_file',
		'cache_memcached',
		'cache_dummy',
		'cache_wincache',
		'cache_redis',
	);
Put `{` on the next line.
I have same question why the default value is 0 on session library and captcha helper.

So we can remove the default  0?
Зачем нужен метод, когда поле и так доступно внутри класса?
Вместе неизвестно откуда взятого числа 100 лучше использовать длинну имующегося массива (не забываем вынести это за пределы цикла, чтобы оно постоянно не считалось
```
int n = self.DNA.count;
for (int i = 0; i < n; i++)
```
ну или использовать какую-то константу везде.
The extra space needs to be removed from here as well
Yes, I don't think we really need to understand it for now.
Yes, looks in lowercase better.
To prevent race conditions, this should probably return a `BOOL` indicating whether the subscription should complete. Then the checks in `completeSubscribable` become unnecessary.
This should just be `return new GitHubClient(hostname);` here
Presumably you are going to do something with `x_offset` and `y_offset` (like what we do in `djvu.c:drawPage()`) and not just keep zeros stored in them?
Zelfde als eerder aangegeven, moet die 200 niet dynamisch zijn?
Antes tomaba un timestamp y iba fijo con Exists = True y el campo timestamp.
Cmo lo usé para chequear condicional que los usuarios nuevos, que no existen, también actualicen le di la opción de poner Exists = False y de canto entró la opción de usar cualquier campo para el futuro.
This is a bit dangerous. It dereferences without resetting `mMyRepo`.

`mMyRepo = NULL;` should do the trick.
every thing is dense why do you need this?
sure, go ahead!

On 01.12.2012, at 23:04, Eric89GXL <notifications@github.com> wrote:

> In mne/fiff/raw.py:
> 
> > @@ -75,7 +76,12 @@ def __init__(self, fnames, allow_maxshield=False, preload=False,
> >                   verbose=None, proj_active=False):
> >  
> >          if not isinstance(fnames, list):
> > -            fnames = [fnames]
> > +            if not op.isabs(fnames):
> > +                fnames = op.abspath(fnames)
> > +            fnames = [op.abspath(fnames)]
> I think these three lines (79-81) can be more compactly written as:
> 
>             fnames = [op.abspath(fnames)] if not op.isabs(fnames) else [fnames]
> I can add the commit for that if you're okay with the change.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Sure, im very sorry about that i didn't notice it till the commit is done. Will make sure to handle in in future commits.
The 5 if clauses above should have one outer if(isNameFieldClause) and then have multiple nested if (!includeRetired) clauses
and the all the code for all the  will end up in the outer if clause
You mean if the rule is needed or not? or the ExpectedException.none() is required? A rule is something that wraps around the execution of the test and for it to work you need to delcare a publicly accessible field. This is not the annotation based check that is usually put in the expected attribute. A rule is being used here so that I can assert in the messages returned by the exception too.
You should remove the spaces around the `.` operator
@marekkalnik yes, you're right. I readed something else (I was thinking of the `symfony/form` package)
you should use ``.`` instead of ``:`` IMO
Will `user.password` always be correct here? I feel like it could be nil/blank in some scenarios.

Since this is only used by the method above, what if we delete the `sign_in_as` method so developers aren't tempted to use it as a public interface, and define the above method like:

    def signed_in_user
      password = 'password'
      user = create(:user, password: password)
      sign_in_with user.email, password
    end
Extract variable via `let(:name)`
Что-то я с инклудами стал лажать сильно
Пусть будет. Я сверяюсь постоянно с ним
Я бы не пробрасывал тут исключение дальше (и вообще в этом классе) — вряд ли его еще кто поймает. Уж пусть лучше пустой список драфтов будет и месседжбокс, чем упавшие личкрафты.
tag 用 partial, 之後很多地方都會有類似這樣的顯示
Create a PrimoCSF subclass to handle this exception.
You shuld add braces
please use standard doc blocks
Please use http://developer.android.com/reference/android/os/Environment.html#getExternalStorageDirectory%28%29 instead of the "sdcard" string literal.
That's what I was originally doing, But with that restriction, but then we'd _never_ be able to compute the kl divergence of any sparse vectors, which kinda seems like a deal breaker.  I looked at some other KL divergence and this is the trick they did to make things work.
`/etc/libvirt/qemu.conf` is rarely a source of useful information. But looking at specific files would be optimal. E.g. `/var/lib/libvirt/qemu`
i moved these settings out of the constructor in my previous commit for a reason.
by passing these settings in via attributes it was possible to set them dynamically in side a route definition.
i am ok with allowing to set defaults in the constructor, but imho the attribute approach must remain, f.e.:
https://github.com/symfony-cmf/cmf-sandbox/blob/master/app/config/routing.yml#L6
Well it should be static and public because it should be possible to stop the bridge from an other thread.
For example, the bride retries 100 time to reconnect and is in a endless loop. To stop it, we just have to set handling to frowardException
I ended up having to modify most of the code to work properly, and still need to remove some unnecessary code from the class
Oh, also, if the frequency is correctly specified then (count nil) will return 0, which will trip up the first precondition.

I guess I can just drop this.
please follow shogun naming, i.e. get_train_function would have been the correct way. however this function should just go away and merged with the train_machine one.
If number and shard is present it will result in what you wrote - I just need to cover the case where `queue_number` is `nil` and then it will be just `logs.#{shard}` and when the `queue_number` is given.
This is okay, but it will be rewritten because it conflicts with changes I've got to generalize the schema layer.  I'm a little uncomfortable about maintaining this code that includes different data sources depending on the operation, but we already do something similar for checkpoint of LSM trees.
agreed, any suggestions?
if的括号 前后都影噶有一个空格。
Du meinst "no recommendation needed" statt "no rating needed"?
I did it this way because I needed to be able to call it recursively depending on the answer.
This won't work on every dell machine, at the manufacturer string changes from model to model. The `match(/dell/i)` was on purpose.

    $ mco facts manufacturer | grep -i dell
        Dell Computer Corporation               found 5 times
        Dell Inc.                               found 30 times
        Dell Inc.                               found 1 times
why ``again`` ?
I'm not certain, but I think the purpose of this variable is to prevent altering the API for `on`.  I think it's rather nice, actually.
I've tested all transports against invalid url and var_dump'ed the result:
* for socket it was: `""`
* for curl and stream: `false`

So I've checked for empty response in the request method to be able to throw an exception in about the same place as in other transports.

Probably emphasizing an convention may not be optimal here as every transport is different.
Can we remove all the commented out code ?
do we want to handle the empty string directive differently from the non-existant directive? <div contents=""></div> is different from <div></div>

For now, let's leave it this way, but keep an eye out for potential problems
Yeah, that's why I do `(old) ? (old + 1) : 1` on the line bellow.
Added CSS file and images.
Fixed to 240px.
Here at the end is one unnecessary line break.
Is not this a boolean value?
I really do not understand why you need multiple views? Why is login not enough? It is very simple. If `request.user` exists (which it will always with lazy login), then you link it. If username is temporary (with lazy login this will be like that), you override it. If any user profile data is missing, you fill it in. Why is there difference between linking and login?

You should only add unlink (good idea). Maybe login should be renamed link?
No need for parenthesis. Write:

```
assert language not in languages, language
```

In this way error will also contain value `language`, so it will be easier to understand where exactly is a problem.
I path now okay? Or should it be just piplmesh/images/logo.png
yeah, that confusion came with the naming of the methods: begin/end should really be called renderBegin/renderEnd otherwise you could think that "begin" begins the animation and "end" ends the animation.
removing "extra" ws
has already: AttributesEx5: 0x00060008 (SPELL_ATTR5_USABLE_WHILE_STUNNED, SPELL_ATTR5_USABLE_WHILE_FEARED, SPELL_ATTR5_USABLE_WHILE_CONFUSED)
> copy all the dependencies from the distribution in the directories: 

copy all distribution dependencies from the directories: ...
classy test data!
The preferred way to force it is to make the particular node's `isStatement` check return `true`.
"aide" should be "aid" without the "e"
PigStorage is a much bigger beast. It is a full featured loader and storage. RCFilePigStorage is a drop-in replacement for PigStorage.
I misread I thought it was use in arbiter
Nit: Spacing off.
Maybe make it more clear what "resource" is, looks like it can be passed as url or id?
I think it won't change anything, since the delegate actually ignore it. But I will fix that anyway in the name of consistency ;-).
I would prefer to keep importpaths and pitfalls higher up in the page.

Some information on the theme "Understanding the structure of statsmodels" 
Something that users should read after their initial time of quickly running some examples is over.
Ie., it's not the constant that gives the -1 it's the dropping of the base equation.
I've seen it in coolaj86/node-bufferjs, and decided to add it. 

I found it useful in my code. (I'm faking the net module in the browser and manually emitting data from "sockets". Some of that data is emitted as a string.) But I could definitely move the conversion into my own code and out of here.
This isn't exactly pertinent to this pull request, but any reason to use console.log() instead of toura.log() here?
I think that leaks memory in an appserver env.  I found this:
http://stackoverflow.com/questions/817856/when-and-how-should-i-use-a-threadlocal-variable
Just instantiate the new one each time.
I don't want to use hte's versions.
columsn -> columns
+this
Duplicate implements ConfigMap (can remove second declaration).
Spelling, "only"
This seems like an odd addition for this pull request.