labofsahil/github-event-dataset-2012 huggingface dataset:
I'm thinking of this branch to change the highlight 
 - for raw cell. (that don't need cell magics prefixes)
   you could match on a git diff patern, or else. maybe even `#!something` that should be handeled correctly by normal modes. 
 - Tex for example that see `%%`as comment
...
Is it wrong for Python 3? It looks OK to me. I'd forward it upstream, but it's up to you.
I could change it to an `is` check.
This is likely better an enum
my 400 and 201 disagree with the status codes specified here: https://wiki.mozilla.org/Privacy/Reviews/KPI_Backend#Server_Component

The 400 might be wrong, but I think the 201 may be more what we want?  I don't have strong feelings about it.  I'm happy to change it either way.
Best would be to have unit tests for this stuff. When will those be added to this repository?
:sparkles: This makes me happy
I'd like to freeze this too. I don't see what else could be added to a signature, and we use it aaaall the time.
![one more time](http://3.bp.blogspot.com/_lnVFiWAf6WQ/TTTfWN5jPtI/AAAAAAAAARw/DW992SFi-RQ/s1600/onemoretime.jpg)

Oneee moreeee timeeee.

Two paths, a goto for failure, and the default success path.
When comming here, on Windows, `HTTP_PARSER_ADDED` is still `false`.
needs I18n
Is there a reason not to take these from the environment?
Do this |if verbose|
IMO a better alternative would be to mcok the PROD_DETAILS_DIR setting and instantiate a new product_details object:

```python
with patch.object(settings, 'PROD_DETAILS_DIR', blahnewdir):
    PROD_DETAILS_DATA = ProductDetails()
``` 

Of course the best solution would be to have the constructor take in a path, but oh well. :P
s/dllname/pk
Oops I meant to copy the equation/algorithm from the bug comment. Basically it is a measure of how many translations are up to date weighted by the traffic that locale gets.
This needs `#egg=configman` on the end.
Feeling dim... 
I really don't understand the difference? Can you elaborate?
this is legacy - I'm not going to justify or correct what clearly seems wrong to me too.  I want this system to slip seamlessly into the current system as I can.  I don't want to muck about changing types and then have to track down the consequences.
Ok, super, tohle je stejně interní věc, takže není třeba to předem zbytečně optimalizovat. Ale myslím, že nakonec chceme zveřejnit nástroj pro veřejnost, ne?  Pak by bylo pěkné, kdyby to fungovalo na principu pluginů. Pro kurz s želvičkou předhodíš turtle.js, pro jiný si napíšeš vlastní modul, který implementuje nějakou eval funkci.
Jo, tenhle segment mi zrovna několikrát nešel ani zkompilovat a museli jsme si s tím s Jablíčkem nějakou dobu hrát (v jednu chvíli jsem posouval tím whitespacem a sledoval výstup z compile-on-save). Výsledná podoba je pak dost omezená těma whitespace pravidlama. To volání playbook[name], případně toho setTimeoutu, se můžu pokusit nějak obalit do závorek, ale zatím dostávám samý parse error. :-(
There are no guarantees about what surface you get from lockScreen(), 8-bit graphics or not (as the comment for pitch warns, pitch is not the same as w * bytesPerPixel). Doing it in a line-by-line loop like the other engines you adapted is the easiest approach I think.
@everzet is the check for ``..`` really needed as you are using ``\FilesystemIterator::SKIP_DOTS`` ?
Added a custom error handler now to catch E_USER_DEPRECATED errors. It falls back to PHPUnit's error handler if it's a different error number.
Maybe is one word.
Similar to /etc/hosts that way I guess - always end up with problems like this when bootstrapping :)
How about making this

const ImageSpec& spec = in->spec();

(taking a copy seems unnecessary if we only want to get at a few bits and pieces)
Aha, I'd forgotten about the divide issue, I will do that.  I really hate computers sometimes.
The preceding underscore doesn't tally with the documentation above.
Added a comment to this effect. This is linked to issue #66.
why is it actually called "sayuri"?is it more readable if we would call the function sayRequest?
This feels a bit ugly to me, but it is the same approach we use in `eachComputedProperty`. I wonder if there's a way to clean this up a bit. Maybe a `getComputedProperties` function that can be used by both. @wcyats, @tomdale, any thoughts?
are you sure these lines need to be there? i think they are left overs from a merge conflict?
these are our new save and sync functions on the navbar so that the user can hit the buttons and happily see the unsaved changes in the progress bars go away.. and know that their data has been saved and they can leave the app.
as otherwise tests fail with: "JBAS014873: Model contains fields that are not known in definition, fields: [launch-type], path: []" 

proper fix would be to cleanup root definitions...
Move undefined vars to first line.
Yes, I've checked and my changes in toolbar.html fixes the same main issue that the toolbar background looked all weird.
Although the original code "fixed" one more issue (in the button css), i.e. that the buttons were not lined up properly, it also introduced a new bug that made every `<button>` with more than 1 word unusable (e.g. the button in the split button demo was running over 3 lines).
This should be handled in _refreshValue, rather than duplicated in both _create and _setOption
can you put the cleanup() call on its own line?
Let's not name a function the way a variable named. Use `_getCurrentEngine` or `getCurrentEngine`.
The agreement is that the Activity will be removed in this PR as it has issues with FTE. Instead we will have a further PR that will allow the user to sync their FB Contacts the first time he opens contacts in the same way as import SIM contacts has been implemented. This option will only appear if FB extension is enabled on settings.
Small doubt... do we need to change the inline JS in order to deal with CSP policy? (same in all 'onsubmit')
In visuals there is no special style for 'pending' messages, only a gif icon until this 'pending' is sent... We have to change this '.gif' for the UX final '.gif', but as we dont need exactly when we are going to have this gif I've created this one ;).
Including a '.gif' decreases  performance in transitions even when it's hidden, so when message is sent I remove the DOM node directly in order to avoid his performance penalty.
I have to check with UX this issue, but by now I think this solutions works (I've tested in the devices and It looks like really nice! ).
Why not leave it with the rest on the localized event?
I agree - I was seeing some weirdness before - but it seems to be better now. This is now fixed.
No. What apparently happens in your code is that `apply` gets applied all the time - `MakeBoxes` is not even called on `BaseForm` when you turn it into a string first. Or are `BaseForm` numbers correctly displayed with subscripts in the visual output of Mathics in a browser? To get the desired output in the console, you probably have to define `MakeBoxes` for the `OutputForm` as well. I just don't think you can use `SubscriptBox` to achieve that (because it should not render as "..._..." in text mode), so you would have to implement that behavior yourself. It basically boils down to running the code in your `apply` method when `MakeBoxes` is applied in `OutputForm`.

Just watch out that you don't repeat so much code twice. I think it should be one method with two different cases in the end depending on whether its `OutputForm` (-> string containing "_") or another form (-> `SubscriptBox`).
DEMO_DOMAIN = "csharpbucket.dn.qbox.me";
Done. Thanks for the help!
I've also thought of renaming ``mock_server`` to ``pretender``, as we did not like the similarity of names... what do you think?
Since we "socks" for everything, we dont have to delegate anymore based one "type". Just works either way.
A better name for this would be `DEFAULT_APPSCAKE_PORT`, since `APPSCAKE_PORT` implies that this is always the port we run appscake on. Also, document this global.
Change to 'cp_result != 0:'
Move as constant.
Well, `self.schema` is set in `__init__`, which means in turn that `_schema` should be present by the time anything wants it.
Would it be better to check if "arrayanynomousbox" isn't undefined before trying to get index of it?
I was worried about this also, even if this is a really rare case. Setting them to range+1 should be enough. This is also the case for tMaxX, tMaxY, tMaxZ.
Oh I see, the new queue is created and then the action is performed in that queue on line 602.
Did you consider using ActiveModel::Validators for this? http://api.rubyonrails.org/classes/ActiveModel/Validator.html
It's an error to return None, so this *should* fail, loudly.

At a guess, was this due to not yielding `wfd` somewhere?
thus, this use statement is useless
"Using these hooks Composer can have tight integration with git thereby easing the project workflow." ?
Of course, a std::pair would make much more sense. I'll update the pull request with that.
but, `Converter` as a global variable set as `default_encoding = 'utf-8'`! 
so do we want to force everything as utf-8 ? and use `io.open` everywhere ?
Well, the reason I did this change is because AFAIK, the INFO column can be empty (if you have nothing to say over a given record) in which case you would want to distinguish: "A\t\tB" from "A\tB"
I'm not sure, see if there's anything you could reuse from ````Control````. It doesn't have to be that, but if it makes sense then i don't see any reason, why not.
algum motivo especial pra chamar o debug_init no /Templates (e não no root)?
Nice re-use of templates.
that should be 
```
for v in cls.get_required_config().values()
```
since you're not using the `k`.
Really all these should be consolidated somehow. That means making some calls on which border is most appropriate and works best across all relevant components. We just need a default border color and that be it.
You can't right now, and it has to be changed in the generator system, so I think we can live with this for now and do a change later on when we have a good solution for this in the generator system.
No reason for an else here -- if the condition previous matches, you'll be returning from the method.
it's never used in the code.
This test -> testExcludeConstructor has sense because call the argument "exclude" as the same way of testExcludeWithStringNoRecord but with the result changed (has record)




>________________________________
> De: Roman Vidyayev <reply@reply.github.com>
>Para: Maks <github.maks3w@virtualplanets.net> 
>Enviado: Viernes 4 de Mayo de 2012 18:50
>Asunto: Re: [zf2] Refactored Zend\Validator\AbstractDb to compy with the latest Zend\Db changes (#1054)
> 
>> -     * Test when adapter is provided
>> -     *
>> -     * @return void
>> -     */
>> -    public function testAdapterProvidedNoResult()
>> -    {
>> -        //clear the default adapter to ensure provided one is used
>> -        AbstractTable::setDefaultAdapter(null);
>> -        $validator = new RecordExistsValidator('users', 'field1', null, $this->_adapterNoResult);
>> -        $this->assertFalse($validator->isValid('value1'));
>> -    }
>> -
>> -    /**
>> -     * @return ZF-8863
>> -     */
>> -    public function testExcludeConstructor()
>
>Oh, I think its just an inverted version of testAdapterProvidedNoResult,
>Set the default adapter:
>AbstractTable::setDefaultAdapter($this->_adapterHasResult); (which doesn't exist)
>run without an adapter:
>$validator = new RecordExistsValidator('users', 'field1', 'id != 1');
>therefore also irrelevant
>
>--- 
>Reply to this email directly or view it on GitHub:
>https://github.com/zendframework/zf2/pull/1054/files#r775304
>
>
>
Semantically, even if it's a DateTime field internally, it's still something representing a specific timestamp. I'd argue we keep it as is, which prevents a BC break and allows this PR to move forward. We can revisit names for a 3.0 release (remember, shorter timeframes between major release versions!)
あー、ここは、どちらかというと <repotitory> というより <branch>  が良いかもですー。
Don't forget type hints on those :)
`.keys()` is not necessary
If a software package name is supplied, you need to check which easyconfigs are available for that particular package.

Say I have .eb files for XYZ for the goalf-1.1.0 and ictce-3.3.2 toolkits, and I want a .eb file for ictce-4.0.10 (while the ictce/4.0.6 toolkit is also 'known', but there's no .eb file for XYZ), then you need to pick ictce-3.3.2 as reference point.
Comment needed here.
IMO the previous version was better than the new version in terms of understandability. This set logic is clever, not clear.

I'd actually like to get a second opinion, though. I summon @pmclanahan!

If you do stick with the set logic, you don't need to wrap the whole thing in a list, as sets can be iterated over. Also, instead of passing a list to set, pass a tuple, since the list of fields never changes you don't need to use a mutable list.
Could we patch `render()` to change the status to 400 if unspecified and the form has error??
Oh, nice. Actually, I kind of like that. Makes it really apparent how thin a wrapper this is.
This assignment is unnec.
once you log in, the url changes to https, and if you then do a selenium get of a url with http, it un-does the login
in other words, the tests started passing when i changed to the ssl version =)
PageProvider needs to be able to control the browser, so it needs a reference to the Selenium session, which is in mozwebqa.
you should remove this file
Also, "as this wraps the foo, you are able to wrap the foo" could be phrased better.
this kind of stuff can be shorter - e.g. options.try(:dup) || {}
Why was it calling this twice before but only once now?
Override kinetic scrolling in that case. There might be others though.
Without the blanket *="_icon" won't ones like .warning_icon_triangle be missed?
The extracted text actually can be quite large. Why not store the extracted text in the same blob cache, just with slightly-modified keys (e.g., append "-text" to the binary key)?
Use the PATH_SEP constant
you still need to check if this is an object, I could pass 10000000 and it would error cause its calling a function on a non-object.
@dpinte If you look at the changes I made a new block is generated whenever the user changes the code.
Info?
why do we need to do load again? mongo-store just sets the new id and returns the input ent
may be `:format` should be deleted from required parts only when `default_format` is specified.

What do you think?
Callback should not be optional here. There's no point in calling getGroupMembers without expecting the results.
The javadoc for ``eventQueue.remove()`` state: _Waits forever for the next available event._ So in the unlikely case it never returns, the thread would be stuck and never released.

You are right for ``InteruptedException``.
It is set only once, in ``intialize()``, and should be private. But it is used by the tests. I'll check how I can improve the tests.
Not old
да это тоже вариант, спасибо slebedev)
Да, можно. Вариантов достижения "эффекта" много. На помню почем точно я решил не использовать componentsJoinedByString. Но вы правы, этот метод довольно удобен.
Insert variable for toolchain location here.
CSS Lint was complaining about the lack of missing vendor prefixes :( Should I add that to the ignore rules in .csslintrc?
Unless the scheduler is synchronous (`+immediateScheduler`), only the _scheduling_ recurses. It won't be invoked immediately, so it flattens out.
This should probably be an `NSParameterAssert` instead, unless we really want that custom message.
Can you please add spaces inside this literal, like so:

```objc
NSArray *streams = @[ streamOne, streamTwo, streamThree ];
```
If the `blah` work need to be serial wrt to each other?
You could probably put the description here to be "Returns a random meme image", but not a huge deal I think.
same here use np.array_split
Ok, so thanks for the review. This means you like it that way?
I updated the code and will look into some of the frequency processing
examples later.

- D

2012/10/11 Denis-Alexander Engemann <denis.engemann@gmail.com>

> Ahh, good to know.
> Indeed I was trying to catch None-picks...
> Smart numpy.
>
>
> 2012/10/11 Alexandre Gramfort <notifications@github.com>
>
>> In mne/fiff/evoked.py:
>>
>> > @@ -314,6 +314,18 @@ def plot(self, picks=None, unit=True, show=True,
>> >          plot_evoked(self, picks=picks, unit=unit, show=show,
>> >                      ylim=ylim, proj=proj, xlim=xlim)
>> >
>> > +    def to_nitime(self, picks=None):
>> > +        """ Export Evoded object to NiTime
>> > +        """
>> > +        from nitime import TimeSeries
>> > +
>> > +        if picks is None:
>> > +            picks = np.arange(self.data.shape[0])
>> > +
>> > +        evoked_ts = TimeSeries(self.data[picks], sampling_rate=self.info['sfreq'])
>>
>> by doing this "self.data[picks]" you do a copy even if picks is None. Is
>> that on purpose?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/142/files#r1818082>.
>>
>>
>
>
is time spent in loading the data or computing the np.dot?

a tiny example below shows that we're taking about 1 or 2s of computation.

```
In [21]: epochs = np.random.randn(200, 306, 400)

In [22]: %timeit sum(np.dot(e, e.T) for e in epochs)
1 loops, best of 3: 1.5 s per loop
```

how much time are we talking about?
isn't this buggy we had size / 2 before?
Actually though, we're not adding anything in the function, we're just taking it as a default value, and not appending, so I think we're alright (in this case) but generally, yeah...that makes sense. Not a good habit to get into.

example,

<pre>
In [8]: def f(i=['chirs','camri']):
   ...:     return i
   ...: 

In [9]: f()
Out[9]: ['chirs', 'camri']

In [10]: f()
Out[10]: ['chirs', 'camri']
</pre>
Since all we are doing is a length check, I still think using the fun_match would be easier.
This should be devel_repo now, or devel_repo should be devel. One of those.
Just curious, what are the tags?
Again, useless test
Are we still using that gem? This seems a little funky
@WouterJ : i fully agree with you comments. I am a newbies with github. What should i do for making these changes ? 

Must i pull a new request ?
I'm -0 on rem units. I know that I'm usually all for things that makes it easier to be lazy, but rem units scare me. I'll probably learn to love them once IE8 goes away, but IE8 is around to stay for a while, and typography css is not something I like to live on the bleeding edge on.
Way too much internal blocking here. Use Future Composition instead.
Instead of timing out on failure, I suggest replying with an akka.actor.Status.Failure if akka.util.NonFatal so the client can react to errors.
I have not understood where this change should be made
Точка лишняя.
Cambiaría el nombre de este label a algo que indiara que se está construyendo un nombre único. Algo como GET_FOLDER_NAME.
Ah, no, perdón. Era porque en algún momento estaba usando esta clase en lugar de BaseParameters (porque estaba usando la búsqueda de Employees). Pero cuando cambié la clase de búsqueda que uso, esto quedó abandonado. Ya lo arreglo.
Minimal scoping.  You can always increase visibility later, but you can never revoke it.
Биндится, но я вешаюсь на событие change дочернего блока, там контекст будет другим
I'll fix this
On 25 Oct 2012 13:01, "Galder Zamarreño" <notifications@github.com> wrote:

> In
> cli/cli-client/src/main/java/org/infinispan/cli/connection/jmx/JMXConnection.java:
>
> >        sessions = new HashMap<String, String>();
> > +      cacheManagers = Collections.unmodifiableMap(cacheManagers);
> > +      activeCacheManager = serviceUrl.getContainer();
> > +      if (activeCacheManager == null) {
> > +         activeCacheManager = cacheManagers.keySet().iterator().next();
> > +      } else if (!cacheManagers.containsKey(activeCacheManager)) {
> > +         throw new Exception("No such container: "+activeCacheManager);
> > +      }
> > +      activeCache = serviceUrl.getCache();
> > +      if (activeCache != null) {
> > +         try {
> > +            getSession(cacheManagers.get(activeCacheManager));
> > +         } catch (MBeanException e) {
> > +            throw new Exception(unwrapException(e).getMessage());
>
> Hmmm, you're only throwing the exception with the message, but no cause
> stacktrace, which might hinder error debugging. Was this done on purpose?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/infinispan/infinispan/pull/1411/files#r1939360>.
>
>
Dan, not 100% sure but I do not think that ExecutionException is ever passed to this method. And also why the last two, selecting the last two for Exception selection....root cause is NPE. See that is why I was leaning towards maybe giving clients a chain of Exception and let them do whatever they want!
Sounds good, but what collection can we use that's both memory efficient and cpu-efficient?

Note that the size of this collection is directly proportional to the size of the keys collection, so we shouldn't use something that's O(n) like ArrayList. The comment above is referring (a bit obtusely, I admit) BitSet, which would be more efficient when keys.size() is comparable to numSegments, but is a little inefficient when the input is just one key.
Did that via compilerpass in 88fee5814a7feff92e835cc83d6daeba2c9287f8

Do you really think we should give every guesser an own service xmlfile?
This docstring needs a little massaging to work better with sphinx. I may be wrong, but I think `update_ticks` needs to be encased in asterisks. And when referring to the `update_ticks` method, one usually uses `meth:update_ticks`. I'm mot entirely on the syntax of that, though.
maybe it is just the github diffs throwing me off.  But, definitely having just the "s)" on its own line right before an "else" statement just doesn't seem more readable to me.  Of course, others may disagree.
That was not Google Translate, I just had no idea how to translate that.
Perhaps you could give some ideas about what to replace it with? Such as @gorhgorh did?
wuha?
generated? own?
`class="form-actions"` on the li
@bp323 Won't this be fixed by the minification process? I removed it anyway.
@stuartf could we use single quotes for all the lines that have changed in this commit?
"Custom Service Staging" は、"Custom Service" のほうが良い。
this should probably be a `job_id` and `sequence` combined index
yah agreed
Iz integer now.
Can I supply `{id: 1}` as relationship object here, if I know the rel id and just want to clear out stuff?
it is unless code
I guess it's just my poor understanding of JS, but how can this work?  Wont `for(attribute in options)` also get you things that are functions on the options prototype?  I.e., shouldn't there be a `hasOwnProperty` or `typeof .... !== 'function'` test around what follows?
isn't it a static method?
Nope, inline scripts will be executed as soon as they are encountered. Async really shouldn't be used to load frameworks. An earlier draft of HTML5 actually allowed defer on inline scripts which made sense to me but was dropped for some reason.
Inject prism script and css resources into the document here.
my tests took 11 second to run this command for a machine which is up
for example:


nmap -sn -PR -PE -PP -PS22,80,443 host
```
Warning:  You are not root -- using TCP pingscan rather than ICMP

Starting Nmap 6.01 ( http://nmap.org ) at 2012-12-02 10:55 IST
Stats: 0:00:07 elapsed; 0 hosts completed (0 up), 1 undergoing Ping Scan
Parallel DNS resolution of 1 host. Timing: About 0.00% done
Nmap scan report for file (10.35.255.8)
Host is up (0.00034s latency).
rDNS record for 10.35.255.8:xx.yy.zz
Nmap done: 1 IP address (1 host up) scanned in 11.23 seconds
Error should be *Passwords don't match.* -> this is the only thing we are checking here.
But channel is irrelevant here. This is just tracking if user is connected to the site. You do not need and much less want to track every channel so intensively. If you still insist, I will of course put channel here.
so if starting at 0, i'd just use [0,15]
What I have in my mind is that if we can create the proxy then Equals using Likeness must work (else a lot of existing tests should fail).
Change "and place it in" to "and placing it in".
I've wanted to provide a demo first to obtain some feedback on the looks/functionality of the UI then move on better SQL handling.

I'll update the matching part once the UI is OK .
No, won't be packaged with the gem when it's built.
I do not know if you want to to look like mozilla-central code, but if you do, the curly brackets are recommended, for the reasons mentioned previously.
This `scalaVersion` is sbt's internal Scala version.
All sbt 0.12.x is depends Scala 2.9.2 (FYI, sbt 0.13.x will be depends Scala 2.10 )
Is this "if statements" necessary here?
Maybe add a comment when calling forEach about what it will modify. Because it's so unusual in templates.
we really check this often :)
$('<div class="line-hl">').css({ top: pos.top - 1 }).appendTo('body');
...should we remove this commented out code?
Good job you indented those <br />s, otherwise this code would be impossible to read.
Yes, I think so, thanks for the catch.  I just pushed a fix.
OK, I hadn't realized that, will update...
Shouldn't this be
   return self.SBProfile.draw(dx=dx, wmult=wmult)?
Mike, I'm happy to make the CorrFunc a container for a GSObject, simply to mark it out structurally as *not* in an *is-a* relationship with this base class.  Would anyone else object?
Heh.  My rule is people who are doing tons of work don't have to apologize for these little things that don't break anything... :)
Barney: I'm not sure we're talking about the same things.  You said you never wrapped those methods, btu I'm saying they don't exist at all in the C++ (except for the ones for Moffat that I mentioned -- no other SBProfile has code that lets you reset the size parameters, unless I'm completely missing something).
I think the same issue occurs for ```ReferenceTarget.transform```, below.
http://guides.rubyonrails.org/active_record_querying.html#eager-loading-associations

Sorry, try includes(:donation)
Is error message misleading? Would this be better:
("Could not claim all requested machines; failed to claim "+unavailable)
remove altogether, left over from debug
Actually we were not having migrations initially in the application. This was a drawback since its not possible to expand the app on the db level.
In django-south [ most famous application for migrations ], we have the leverage to fake initial migration. So, this would do.
Yeah I'm in the camp of not needing it, it was common practice with codeigniter, but rarely done with Laravel.
this should  be removed
see docs: http://api.mongodb.org/ruby/current/Mongo/Connection.html#from_uri-class_method
Get rid of the first 'gist' here?
what about `return Object.isArray(propList[property]) && propList[property].length > 0;`?
And when you do the above changes, you can Deliver this Pivotal Task:

https://www.pivotaltracker.com/story/show/40137761
It may be nice to have decorators be a part of galaxy-client. y/n?
That sucks

On Tue, Oct 16, 2012 at 1:18 PM, Zac Horn <notifications@github.com> wrote:

> In lib/galaxy/deal.rb:
>
> > +        subtotal = price * qty
> > +        total = subtotal
> > +      end
> > +
> > +      [credit, subtotal, total]
> > +    end
> > +
> > +    def starting_price
> > +      price
> > +    end
> > +
> > +    def discount_percentage
> > +      discount.to_f/value.to_f*100
> > +    end
> > +
> > +    def number_sold
>
> this will actually error during compile if you try to alias it as
> num_purchased is undefined.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/demandchain/galaxy-client/pull/33/files#r1859469>.
>
>



-- 
Alex Okolish
Ты кидаешь checked-исключение.
Вопрос: может ли здесь при использвании SyncronyzedMap возникнуть небольшая утечка ресурсов?
(видим, что нет известных extension`ов для другого класса, создаём новый экземпляр, в это время управление передётся другому потоку и он делает то же самое, в итоге ничего страшного не случилось, но один из двух созданных экземпляров просто пропадёт впустую)
Если да - правильно ли я понимаю, что отловить такое можно только через DoubleCheckedLocking? Или можно слегка подзабить здесь на производительность, всё-таки создаём форматтеры мы не так часто, как занимаемся собственно форматированием текста, и просто сделать synchronyzed по knownsExtensions?
ÉÓÐÒÁ×ÌÅÎÏ

2012/10/9 Dmitriy Komanov <notifications@github.com>

> In src/ru/fizteh/fivt/students/yuliaNikonova/wordCounter/WordWorker.java:
>
> > +				if (!mAggregation) {
> > +					System.out.println(mFilenames.get(i));
> > +					printResults(words, lines, unique, uniqueNotCaseSens);
> > +				}
> > +			
> > +			} catch (Exception e){
> > +				System.out.println(e.getMessage());	
> > +			}
> > +		}
> > +		if (mAggregation) {
> > +			printResults(all_words, all_lines, allUnique, allUniqueNotCaseSens);
> > +		}		
> > +	}
> > +
> > +	private void putValueInMap(HashMap<String, Integer> myMap, String key) {
> > +		if (myMap.containsKey(key)) {
>
> íÏÖÎÏ (ÎÕÖÎÏ) ÏÂÏÊÔÉÓØ ÂÅÚ containsKey:
>
> Integer count = myMap.get(key);
> if (count != null) {
>   myMap.put(key, count + 1);
> } ...
>
>  --
> Reply to this email directly or view it on GitHub<https://github.com/dkomanov/fizteh-java-task/pull/16/files#r1795211>.
>
>



-- 
ó Õ×ÁÖÅÎÉÅÍ, îÉËÏÎÏ×Á àÌÉÑ
API is now more abstract - doesn't need to know about any url config files.  All browserid and verifier urls are passed in from the app
Suggestions welcome for dealing with this. Read in _config.yml, perhaps? It seems a lot of work just to get a variable. It's a pain because the theme is jekyll-land, whereas the Rakefile is JB-land.
Those are good tests, thanks for adding them!
[pep 257](http://www.python.org/dev/peps/pep-0257/): first line after ``"""``` is short explanation, such as this. Afterwards comes a bit longer one, i.e.
Forms an affinity matrix given by the specified function and applies spectral decomposition to the corresponding graph laplacian.
The resulting transformation is given by the value of the eigenvectors for each data point."
or maybe something more accessible ;)
Also do not use `"""` for multiline strings as the new line char and indentation of the second line will be part of the message. Instead use:

```python
   error_msg = ("Input must be both positive integer array and "
                           "every element must be continuous but %r was given." % obs)
```

No need to add `ERROR` inside the message as the exception is a `ValueError` which is already explicit enough.
I don't think this is necessary as `set_verbosity` is always called at the beginning of the `fit` calls.
It find **a** low dimensional representation of the data using **a** spectral decomposition of (?) **the** graph laplacian.
We should make a helper function around requests at some point so we don't have to keep typing the url. *shrug*
So I didn't re add it on purpose. Maybe it's cause you removed it while I was working on this and it re put it back in?
its, not it's

Also, a little more clarification what this is, please.
If `nativeLogger_` is null then you didn't call `initialize()` first or the factory is broken so a crash is appropriate.
For whatever reason, when starting PWT with the winpdb debugger, the startbutton would be set to 'None' initially, crashing here.
please specify and encoding so we don't relay on platform encoding
The result type is always the type of a node.  

For a no_graphloop argument 2 contains a no_loopbody(body), so selecting child 0 gives you the result of the graph - which you then query the type from.

I don't understand the second comment.
although correct, brackets would be clearer IMO.
I'd use a more restrict approach, like regular expressions... checking weather it is entirely valid, rather than a few special cases where it is invalid.
Yes - the conditional APPLE statement is in the lib2/cmakelists.txt file.  I suspect this approach will get cleaned up in the next raft of changes, so I wouldn't worry about it for now.
I've thought about this a bit, and I think the most useful default behaviour is something that immediately shows the user what the app does. That is, settings that are useful for a developer. It doesn't make sense for anyone to be running "default" settings in production - they will always want to customise them. So automatically creating experiments, datasets and users, and allowing updates (ie, extremely permissive settings) make sense.
Yeah I've missed the *var* keyword here. The paths in *options.partials* are replaced with their corresponding template string from the cache/file.
I'm really unsure of some of the terminology here. Originally, I was excited to remove the concept of "layout" from the view layer, but as we've improved things and added access to the "root" view model, the concept of "layout" has snuck back in,largely because we all understand that concept.

So, probably, the appropriate action is to rename that configuration variable. I'll wait to confirm that with you over IRC, though.
what about empty string, would Long.parseLong("") return a viable result?
@shacker indeed, have a look at http://labs.voronianski.com/jquery.avgrund.js/ for the reason why. (click the show it button)
@christianv Yup, good - the fewer px references, the better.
Its not the name of the file to delete I think it would be

<pre>
@clean_files = ["{php_fname}-000}"]
</pre>

Need to check with @wchen-r7
I already did for RFC (direct not via SOAP). But you guys didn't want those. When these are all done. Maybe I will. But only so many hours in the day :(
this is too awesome.
Yikes... these are unicode characters.  This script won't even run in Python.
I included the coordinates of the hand plain text in the code - thought this would be the better approach with such a small array.
This is a general known algorithm for testing wether a point lies inside a polygon which can be found on several different sites (e.g. http://en.wikipedia.org/wiki/Point_in_polygon).

So, I thought we can leave out the attribution here as it is totally rewritten in Cython now. Or do you have a different opinion?
In my opinion the implementation would be quite confusing if we combine the similary with the projective estimation. But feel free to convince me of the opposite ;-)
Is Rails 3.1 no longer necessary?
Do these methods belong on the controller?  I sort of expect the controller methods to generally "do" things to the camera, whereas the Camera methods provide answers to questions about its state.
Hi Ping,

Is EVENT_PROPERTY_PLAYBACK_STATE used anywhere else?

I think the actual error is in on line 276 of TiC.java:

	public static final String EVENT_PROPERTY_PLAYBACK_STATE = EVENT_PLAYBACK_STATE;
This should be `TAG`
I've given this section more of an advisory tone. Please check that you are happy with it.
That was a joke btw. ;)
Should enclose in a `try/catch` so that the driver bails if the configuration has some kind of error in it (and maybe provide a backtrace if we can?)
Right, sorry I missed that. I think using the string makes more sense.
What do you think about:

```php
$all = new BoxCollection();
$all->merge($this->findLocal(), $this->findRemote());

return $all;
```

That's similar to the function signature of `array_merge` and avoids a `clone`.
right, changed
And you have a typo, too: `typo`, not `type` :)
set 
```python
COMPILER_OPTIMAL_ARCHITECTURE_OPTION = None
COMPILER_UNIQUE_OPTION_MAP = None
```

and replace test with
```python
if 'optarch' in self.options and self.options.options_map.get('optarch', None) is None: 
```
Set both 'constants' ( ;-) ) to `None`, and adjusted test to

```python
if 'optarch' in self.options.options_map and self.options.options_map.get('optarch', None) is None:
```

(not exactly the same, but probably what you meant)
тут часто пишут на одной строчке virtual ~T() {}
And if we keep it like that, does that mean that only adding 'continuation=enable' at in the general preferences is not enough to enable continuation for all projects, the right -Xpluginsdir needs to be added. And user cannot know the right path, it needs to go look for it in a project's preferences.
So this is defined inside the reduce template. How come the eponymous trick works? It should only work if reduceImpl is private. Also, this should be just called "impl" because it's already inside reduce.
sgtm. adding
Btw,I don't think that the spec explicitly states when _releaseInstance_ is supposed the be called. Didn't we have an issue for that as well?
pls all constants as constants (static final TYPE_PARAM)
Thanks. Yeah, variables don't need uppercase. For instance, $phpbb_root_path is all lowercase.
Because of the way this is implemented, I think you might want to validate the parameters in a way that makes them mutually exclusive--otherwise someone could specify both "export" and "sparse" and be thrown off by the behavior.  Alternately, maybe those three params could be combined into one, and it could have an enumerated list of legal values?
Should be commoned up with the other code.
I imagine this can be shared with the dataset builders + some of the other functions.
We don't need to set a constant here.
okay, merge for now. fix after deadline
It's either allowing exceptions or updating each line in the file when a new constant exceeds the allotted line. I prefer exceptions.
If the application does not have fontawesome: `couldn't find file 'fontawesome'`
0/1 point

1/2 points
And `AnswerPresenter`, of course.
No, xq acordate que el vip no filtra las super ofertas, es el unico que las
puede ver
El 13/06/2012 09:41, "Clara Allende" <
reply@reply.github.com>
escribió:

> > @@ -0,0 +1,18 @@
> > +package edu.utn.dds.aterrizar.usuario;
> > +
> > +import edu.utn.dds.aterrizar.vuelo.filtros.FiltroAsiento;
> > +import edu.utn.dds.aterrizar.vuelo.filtros.FiltroSuperOfertas;
> > +
> > +public abstract class TipoDeSuscripcion {
> > +
> > +     final Double RECARGO_DEFAULT = 0.0;
> > +
> > +     public FiltroAsiento getFiltro() {
> > +             return new FiltroSuperOfertas();
>
> esto no debería estar en el vip?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jvillarejo/elSuperArchiRepoDDS/pull/9/files#r975523
>
wouldn't checking for the service fail, when the SonataDoctrinePhpcrAdminBundle is loaded after this bundle?
need quotes around $secret
You can leave the double quotes in the license.
That's a really cool idea, and I didn't even know backbone allowed this.

I'm personally going to opt for not making this change along w/ my others, at this point, unless I feel like doing so will greatly reduce the complexity of my changes. I'm already bumping up against the boundaries of comfort w/ the breadth of changes I'm making, and I'm going to try to somewhat limit it. But I *really* like this idea.
You missed to check the return value of GetModuleFileNameW and risk a buffer overflow.
Why long and not ulong?
Incorrect SpEL syntax

    removeFromIdCache(headers.id.toString())
Hi Gary, iv got another PR 451 open which is for the JPAExecutor class. I'v made the suggested change in that PR and pushed.
I will check again. But what is the code-coverage percentage you are getting? The problem I remember seing was that the coverage was 0% when using **${buildDir}**. It took me a few minutes to figure out the issue. I don't think there were any errors or warnings.
But, of course, if you leave the TBD, we need another JIRA so it's not forgotten.
Using __a__ native query is ~~very identical~~ similar to using
Oleg, 

Looks like you missed Diego's change to getHandlers(), which is where all the performance improvement comes from

````java

    /**
     * Returns a copied, unmodifiable List of this dispatcher's handlers. This
     * is provided for access by subclasses.
     */
    protected List<MessageHandler> getHandlers() {
        return handlers.asUnmodifiableList();
    }
````

That said, I don't see unmodifiableElements ever getting updated in the OrderedAwareCopyOnWriteArrayList
I think we should try to have just one spot where we switch on the env, and then just define separate functions for `getToday` and `fetchres` within the `when` blocks. It seems more readable to only have one configuration zone. At the very least, we should do all our switching at function definition (like in `fetchres`), not at function application (like in `getToday` as it is now).
leave a comment here
I don't understand what you are calculating here. Please elaborate.
If I'm not mistaken this needs to be initialized in the ``visitPhpFile`` method, otherwise it would fail as soon as we have two form types, or mix the message up in a weird way.
(You can define both base.html and then demo page template.)
Oh I see it got moved here.  Still, we could probably get rid of it now.
Can you remove `babel_number` for this? I forgot that it will format the number in such a way that the `parseInt` in the Javascript won't work.
Yep, backticks are not allowed in the compiler, and ideally shouldn't be used in any of your code either. There's *no* need for them. If there is, it should be an open issue.
Are polygons allowed to cross the international date line?  I'm guessing not, but if they are, this method is probably going to get a lot more complicated.
Yes, I do it now.
your right. i was thinking form state was getting passed on when we were rebuilding. i like the idea of using call_user_func_array in that case. It would make the code cleaner.
adding a power-users-link so we can hide it if the user is in the user dashboard
Hum I misread... But it would be useful to state that "ovr" stand for "One vs the Rest" and that it is a reasonable default in practice.
add `div.slideshow`
For now, it's like this to preserve the behavior for ActiveSync, which is to always consider the existing data as good. That's not the right way, and I plan on fixing it, but I didn't want to do too much in one commit for fear of causing regressions.
тут ничего не понятно. нужно разнести кусочки по функциям с понятными названиями
We may want a bug filed for moving these properties off of the proxy and into the `Ti.UI` namespace, or somewhere else relevant.

The documentation uses `Titanium.EmailDialog.xxx` instead of `Titanium.UI.EmailDialog`.
Replace leading spaces with leading tabs.
Couldn't mock require without doing this.
This change is coming in the new commit from qnxCar, I am almost done it. Should I add it to the same branch?
should be /activity