labofsahil/github-event-dataset-2012 huggingface dataset:
Your comment explains what you're doing, but I'm trying to understand why it's necessary. Would small, non-zero values distort the transform somehow? Maybe something along the lines of "Set small, nonzero values to zero to prevent image distortion"? "Distortion" is probably not an accurate description, but something similar?
my bad this needs to be removed. That was from before we switched to using a leave event.
remove all unused methods
Why clone and then modify the result?  It seems like it would be easier to do a `new` here and then add two extra else blocks than just assign the rect values.
Yes, this is for concatenation with built files, now that there are several of them.  I don't know about making it a markdown file, because this has to be JavaScript copyright comments.

Alternatively, I could move it into Source and maybe call it copyright.js if you think that's better.
Same comment as above for bounding volumes.
Actually, let's not publicly expose `boundingVolume` to start.  Instead let's return it in an object literal from `update`.  This way, primitives still only need to implement `update` and `render`, and the dependencies are cleaner (right now, `boundingVolume` is only trusted right after `update` is called).
This same object has getValueCartesian and getValueCartographic, so getValueRangeCartesian seemed appropriate (in case we ever want to add a getValueCartographic).  Though you make a good poin that maybe things using cartesian should just be getValue since it's the standard for us.  There is a good chance a lot of this object will change when we add terrain support for CZML (since we have to deal with height references and the like) so my inclination is to leave the names as they are for now and revisit the issue when that happens.
We ported (or will port?) the fancy code Frank wrote in Components.  I believe it's equivalent to slerp, but can also do higher-degree interpolation than linear.
I agree and simple function wrapping is probably the only place I condone it  I'll add that developers should always run coverage after they change code anyway, and whomever is merging to master should run it themselves to confirm as well.
Fixed in next update
I assume it should be logical &&
Something also doesn't smell right here. Disabling the fade functionality instead of fixing the issue will cause a regression among other things.
We should always have a "listener wrapper" object here. Did you determine why sometimes only the listener function
is present?
I had a look at `peek()` and I think this is a really good point.  I'll have more to say in a general comment.
Да, так подойдет. https://github.com/cripi-javascript/dz-2-basics/pull/2#issuecomment-9454873
do we really need to check for that ourselves or likes will do that for us?
That "if" is not my code, but preserved from the old RandomSample. :-)  I'm presuming the assumption is that users will use randomSample to return the sample, rather than RandomSample directly; randomSample does perform these checks.

I'll happily make your suggested tweak, but can we wait for Andrei's input before doing so, as this was his code?
Here and later, while somewhat outside of this pull but I'd love to see CTFE support. 
memmove/memcpy don't work at CTFE. Probably we just need a general D analog for memove (array ops are fine for memcpy).
Instead use `assertThrown(singleSpec("2.3e"));`.
I do it for you :-). Fixing the last violations and then I will push another commit
bad bad formatter ;-) no fair enough; as long as such changes are not too
plenty full in a pull request

On Thu, Oct 11, 2012 at 5:29 PM, Felix Mayerhuber
<notifications@github.com>wrote:

> In
> components/edb/src/main/java/org/openengsb/core/edb/jpa/internal/dao/DefaultJPADao.java:
>
> > @@ -395,15 +379,32 @@ public Integer getVersionOfOid(String oid) throws EDBException {
> >              Predicate p1 = criteriaBuilder.equal(subFrom.get("oid"), from.get("oid"));
> >              Predicate p2 = criteriaBuilder.le(subFrom.get("timestamp"), timestamp);
> >              subquery.where(criteriaBuilder.and(p1, p2));
> > -
> > +
>
> why ups? the formatter has removed some blanks : )
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/openengsb-framework/pull/776/files#r1819825>.
>
>
Tentei colocar mas o teste não passava.
Pretty much to allow this to be protected when it's all sorted out. I've been switching from `_protect_identifiers()` to `protect_identifiers()` in DB forge/utility for each of my driver-related contributions, but most of them are still pending.
It's probably a good idea to just move the logic to the public method and remove the other one ... now that I think of it - I'll do that in a few minutes to finally sort this out.
Tricky this one. From a rest perspective it probably doesn't make sense at all to support a parameter coming from both?
fixed, i'll squash my commits when this pr can be merged
should we replace headers here or just set the location?
is this ``E-mail`` normal here ?
Same for font sizes.. is this a value we use all over the place?
I feel like the original "the the" may have been a typo of "that the"
Agreed it doesn't make sense to maintain that, since it's all in git history.
Do you think this might be an improvement in clarity or efficiency?

``` haskell
X.intersperse '\\' . X.breakBy  (\x -> x `elem` escapedChars)
```
Changed and added list via git shortlog.
yeah .. now the above code is kind of iffy too .. maybe we need to move this out into a method.
I think you double-tabbed the body of this method.
Пробел перед this.
i forgot about that, maybe it's just better to assume jquery exists by the time khan-exercises is loaded in test mode (and why not if it is on the site? i'm scratching my head to figure out a reason for it to not be loaded by the time this is run)
label aligns at scope level (i.e. is outdented only once here)
ditto - and the next one
Hmmm... the more I think about it, this is a problem because there is the general assumption that returning an item releases a permit; returning arbitrary items will increase the permits above the specified pool size.

I don't really want to add the complexity of tracking in use items and enforce only they can be returned. Maybe keeping the method named returnItem() implies a previous get().

Or, I could rename to releaseItem() and change releaseAll() to purgeAllIdleItems() or similar.

WDYT?
Fixed all occurrences in JpaParserUtils with commit 8b689fe
Thanks for the feedback. I have made those changes. :)
MongoDB IDs are alphanumeric strings, plus that MongoDB is vulnerable (its PHP driver at least) to **SQL-like Injection** attacks and so we need to make sure that all input data are typecast-ed to strings. (I should also add this typecast stuff to model's `where()` function)  
  
But on the other side there are relational databases, I forgot to check if we're interfacing with MongoDB or not. I'll push a fix, thanks.
@blowmage what is the status of all of these commented tests? Is this functionality not yet added to the gem (in which case, these should be removed) or are these failing currently (in which case, these should be corrected to pass)?
Alignment, your email address, remove Kyle :)
I think we could entirely rely on composer here and remove the code for the old testing setup.
Sender is not mandatory and depend of the Transport protocol. At this moment for SMTP is needed at least one receipient and the body, also at least one header but that not implies the subject header
Segment route named "contact"
Here you're returning a string that has a semantic meaning of "nothing was found". So this method could either return:

* string with "Not Found"
* Movie object with information

I think either raising an exception, or a specific NilMovie would be more expressive of what happened.
Should the K be lower based on the new rules?
just use ``$this->trans('my key')`` in the admin
Ahh I see.  The debug lines are generic thought and just report out the response from the mandrill handler.

I can't use Logger I don't think because this gem isn't guaranteed to be used within a Rails app.  What if we're using a simple ruby script or a sinatra app?  Is Logger built into Ruby and isn't from ActiveSupport?
need to regression test this method
well, actually, it already is in a form array as '#value'. I guess it's ok.
broke the delete out
doesnt look like this is used maybe it should be for the "\r\n" instead
Indeed, this can be removed.
Hmm, can you move it into a separate JS file / a mobile lib? This is what @christav is planning to do for the ServiceBus functionality.
I should clarify, the method is needed, but it doesn't need to return a custom page object.
beyne selector va { yek fasele lazeme
this one should be change to 2.0.* to test the latest 2.0, not an outdated one
Aha! That's how you do that...
I find it a bit confusing that `customDisplayPrefixes` is not in scope
in this file.  It might be more obvious if you passed it in as an
argument...?
We've already got two standard sizes for user images and this is introducing a third by overriding the standard size that the `user_thumbnail` class is supposed to imply.

If we want to have a third size we should do the job properly and come up with three names with the corresponding helper functions and CSS classes rather than having a context specific rule like this.
We're already using the `diary_entry` class on the create/edit page so using it here as well (with CSS rules attached) may lead to unintended consequences?
Что здесь проверяется? Нужна проверка участка:
```
<div title="всего проголосовало: 0" class="vote-item vote-count">
     <span id="vote_total_image_11"> 0  </span>
</div>
```
и
```
<div style="display: none;" id="vote-info-topic-11">
                        <ul class="vote-image-info">
                            <li><i class="icon-synio-vote-info-up"></i> 0</li>
                            <li><i class="icon-synio-vote-info-down"></i> 0</li>
                            <li><i class="icon-synio-vote-info-zero"></i> 0</li>
                        </ul>
                    </div>
```
same as above, should not be required
I must have had a typo selecting the branch to rebase onto or something... this seems too far off.
When would this return false?
Is this false if it's a directory? If it doesn't exist?
Hi Stephen,

If you specify the full path (relative to Resources) in the Info.plist file, as detailed below, placing the fonts in Resources/fonts works on iOS.

If you do it this way, you only need one copy of the font in the project, so I have favored that approach.
I just created ticket TIMOB-7930 to implement those accessors in mobileweb.
Is anyone else having a hard time to parse this summary? To convert to from? How about "The desired unit for the conversion result"?
- remove default tab
- thus, entire admin page/file
"first line"
Shouldn't this be *{global,$env}.config.php ?
String formating is not exactly exotic :)

My feedback is that this function is more complicated than it should be, if what it is doing is generating a random  css color, I find it simpler if it actually does this 2 things:
- generate an int between 0 and 16777215
- return it formatted as a css color

But you're free to ignore it :)