labofsahil/github-event-dataset-2012 huggingface dataset:
This should probably get the runner as an argument (even though we only support one debugging session at a time in JS). Shouldn't it also use a callback instead of the "dbg.attached" event?
these two instance methods should be `under_score` style instead of `camelCase`
Why did you change from copy to insert?
I think we want *E-mail*. No?
semi colon at the end.
We filter this on the server-side when exporting a project, but you're right, we don't filter it when loading a project from `/api/projects/:id`. I think using innerText here would do the trick?
item.default
Code duplication from editors/default-editor.js.  If you're going to do this in order for us to land on 0.5.x, you need to file a bug in 0.6 to refactor so we don't have duplicate code in the tree.
Needs icon
Can you brush over this file once and look for these small spacing inconsistencies? There are some inside of brackets, like `(0,0,0)` instead of `(0, 0, 0)` and it looks like this form (`.pipe{`) is the minority wrt the other (`.pipe {`).
Move to .css file.
I don't like the "AllItem" method names. Could you change it into something more meaningful that describes this.

Also, shouldn't you just take the stuff after the last slash and compare that?
I was hoping that Open would return an IO_Object() child and then there'd be another virtual class for IO_Object so that all of the functions in IOStore that take an fd argument would move to IO_Object().

We'll need that basic functionality for the FILE * Store and the HDFS Store, right?

How hard would it be to add that code?

Also, would it be possible for the IOStore functions to always go through a shared parent class like:

int Foo(arg,arg) {
  shared_code
  ret = child->Foo(arg,arg)
  shared_code
  return ret
}
Do you need to redefine these accessors?  attr_accessible should given them to you, right?
Hm, didn't realize that. Does that cover 2.x.x, or is that `~> 2.0` ? I'd rather keep the requirement as loose as possible so we don't have to update this every time capybara is updated.
IMO, no, as token acces is meant for "automated clients" (like Maven is), no need for remember me stuff
yes, was waiting for 2.1 to be released before potentially destabilizing a bunch of tests. I'll move this task to my short list.
path, name
add some description for Tengine?
indentation needs fixin'
Is the order correct here?  

It looks like it should be: 
repo = get_repo(self.org_name, options['name'], prod_opts['name'], prod_opts['label'], prod_opts['id'], self.env_name)
Agreed.  We will likely want to have access to this type of info elsewhere.  I decided to go ahead and do that refactor now vs later.  The changes are in fe21aa084630a23b2cf83826790475609b063906
you should use ``$record['formatted']`` here, not ``$record``
I think there is a way you can add a class to the body tag from inside a template. (See https://github.com/alphagov/static/blob/master/app/views/root/_base.html.erb#L41)
Forgive me if these questions don't make sense as I'm by no means a Qt expert…

You're hard coding this to 72 dpi in the case where `Q_WS_QPA` is defined, which I guess is always true for phantomJS on linux now that qt is embedded? My concern here is that to match the mac, you're changing the linux value to be a constant that just happens to match the mac version. What if the mac version is different? Do all mac's report 72 dpi?

Wouldn't a better solution be to allow configuration such that the result of the `Q_WS_QPA` `screen->physicalSize()` call can be defined by the Qt install? Is there any existing way to gain control over the assumed dpi of the renderer?

Also I noticed that you're modifying `qt_defaultDpiY` which is used by `qt_defaultDpi` but you're leaving `qt_defaultDpiX` to report the old value. I'm not sure who calls that but shouldn't it be similarly modified?
See my comment above - I left it in here because I am almost certain this one will want a second directory, while I'm not so sure about `utils`.
That's correct.  The question is what is the best concise way to say this without confusing newbies who don't know what an iterable is?
Fixed in a49832a.
Nevermind, ignore.
Haha we did already :).

Blog.bitcast.io

Removing the route on my next push

On Saturday, December 22, 2012, Luke Steensen wrote:

> In config/routes.rb:
>
> > @@ -2,5 +2,5 @@
> >    root :to => "users#new"
> >    match 'success' => 'static_pages#success'
> >    resources :users
> > -
> > +  match 'blog' => 'http://bitcastio.tumblr.com'
>
> On second thought, maybe putting the blog on a subdomain is better. This
> makes me cringe.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/landing/pull/13/files#r2495529>.
>
>


-- 

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>
That doesn't seem very necessary.
You're technically correct to remove this, but I had a report from another project that some version of gcc (I forget which) complained when TINYFORMAT_WRAP_FORMAT_EXTRA_ARGS was not defined during the definition of the other macros (don't ask me why ;-).

Anyway, for that reason this needs to remain as-is, but I'll certainly be happy to have a comment explaining the weirdness.
Updated to call ui.showHelp() directly
For clarity, can this subclass `unittest.TestCase`?
hmm  I guess PathParam doesn't work?
```c
const wchar_t *ua = L"git/1.0 (libgit2 " LIBGIT2_VERSION ")";
```
Doesn't belong here. Move it to `tree.c`, and document what does this function do exactly. This function cannot be exported as long as it returns a pointer, so rename it `git_tree__entry_bypath` and keep it in the internal `tree.h` header.
Like this:

```
import logging

from django.core.management.base import BaseCommand, CommandError

from search.es_utils import es_search_cmd
```
Extra parens here not needed.
We were actually wondering what was the best way to deal with this.

another reason to move away from .filter.exists() is that you can have race conditions between the moment you fetch the queryset and when you do the .exists().

Chaging this bit of code, thanks.
Are we assuming that people will be starting fresh and these don't need to be a 002 migration?
wat. I recognized it as such since it was located in the index.php function, and since we are striving for modularity, we shouldn't exactly put stuff in the index.php
you can remove the ``else`` here as the ``if`` returns
This is russian grammar. The use of two adjectives in a row (Максимальная допустимая) in not correct. The second adjective relates to the nout "width". But the first should be describing this adjective, not the noun.
For the record, this was introduced in #4524
@henrikbjorn This is a problem of documentation. UPGRADE is meant to facilitate *migration*, which is shown here.
So, you understood my intention. I think that is more intuitive use the same function name at Twig template and Controller class.
I didn't understand if Twig path function generates a relative or absolute path.
But the third parameter at my path method can be excluded.
If Twig generates a relative path, I can pass false to $this->generateUrl method,
otherwise, I can pass true.

What do you say?
This should be placed inside the loop and apply to $file not $iterator, $iterator is \RecursiveIteratorIterator object that returns \SplFileInfo on calling current().
what about drivers with dependencies ? For instance, a cache implemented with a database and needing a DBAL connection ?
Thus, I don't see how it relates to the description of the PR :)
I don't understand the value of that particular test, but if there is
value, you can't have enough tests. Unit tests should ideally ram some
bad/unexpected data into functions and see what breaks but we should be
sensible about it all the same.
It's fixed now, i will squash and make some PR into others Repo who depends of this
Oops, yes, we need $name.

As above, I wasn't sure about splitting the array merge logic across two methods.  Two methods explicitly doesn't make sense to me, though.  New version coming momentarily that makes it a single array.
what motivated the removal of the canceling logic?
Change /ac to /# like I requested
Could this be shortened to ``requester``?
Happy to remove it - I've seen that elsewhere and it's quite neat
occasionally when you want to ensure people understand that it's package
private...

What was happening is that the backend instances were creating instances of
OpenFileState but releasing them to the OpenFileStateManager. During index
creation, this happens an awful lot (as in thousands of times!). So what I
was getting on unix is a "too many files open" and on Windows a heap
issue...

Chris


On 31 October 2012 04:16, Douglas Campos <notifications@github.com> wrote:

> In
> src/main/java/org/crosswire/jsword/book/sword/state/GenBookBackendState.java:
>
> > @@ -42,7 +42,16 @@
> >      private RandomAccessFile bdtRaf;
> >      private SwordBookMetaData bookMetaData;
> >
> > -    public GenBookBackendState(SwordBookMetaData bookMetaData) {
> > +    /**
> > +     * This is default package access for forcing the use of the
> > +     * OpenFileStateManager to manage the creation. Not doing so may result in
> > +     * new instances of OpenFileState being created for no reason, and as a
> > +     * result, if they are released to the OpenFileStateManager by mistake this
> > +     * would result in leakage
> > +     *
> > +     * @param bookMetaData the appropriate metadata for the book
> > +     */
> > +    /* default */GenBookBackendState(SwordBookMetaData bookMetaData) {
>
> oh, I mean the /*default */ comment
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/crosswire/jsword/pull/13/files#r1988094>.
>
>
Is there a reason behind removing the caching?
`deserialize`? yeah, maybe. i'm pretty sure `serialize` and `connectOutlets` were called with different types of second arguments (contexts), which was pretty confusing to me
I don't think this line is relevant :smiley:
Well, I don't like hardcoded stuff too. The lower limit can be removed without any side effect (it was my "imposition" to avoid micrometrical zoomout), the top one is necessary due to your zooming schema: since you move the viewport by half of the size, when the zoom factor is more than twice the viewport size calculation is totally screwed up.

Option 1:
The two hardcoded values can be transformed in two constants (changed the form but not the substance)

Option 2: 
I can try to remove the upper limit changing the viewport calculation based on the zoom factor detected but let me know if you think that it is really useful to zoom in/out by a "unlimited" factor.

You are the boss here, I'm your servant. Let me know your thought :-)
We need a fair bit of code to handle it, if it's not going to be use I'd vote for a removal.
`md_confirm`
@timdream Why? My 'gjslint' is not so happy with it...
What means selunset ? Reading at the code it seems to select all
Yes, this part is not localized yet because is almost completely new. I'll take it in count.
Better! `UninstallDialog`
As a polyfill, It works pretty good now in Music app ^^
Let's wait for the bug to be landed.
There should not be any Firefox references now.
purprose -> purpose
0rem -> 0
Let's bump the version to 0.2, since this is a pretty significant restructure.
ahh okee
Just a minor issue: this will return the index as a string, right? However, it should be C[1] (with 1 being an Integer) and not C["1"]. You could add a (hidden) test `Cases[DSolve[f'[x] == f[x], f, x], C[_], Infinity] // FullForm` that returns `List[C[1]]` as opposed to `List[C["1"]]`.
AbortRebase?
It would be good to have a rate-limited warning that this is set, so that users know to update.
Like this too.
It won't be invalid args, but missing slice and the help will be printed in that case. Let's go over this on our call next week.
This fails if answer is nil:
 
    err: undefined method `empty?' for nil:NilClass

empty? is also not defined for TrueClass or FalseClass it seems.
Need the full `?.` here instead of just `?`.

It would be nice if this construct parsed like `fn a ?. b` rather than `fn(a ? b)` though. Maybe open a coco bug for this.
Why you put ```:js```?
What happens when there are more creatures than images?
Would be nice to update the doc. Yes I didn't do it initialy, but that's not a reason
20e78b7
running execution の訳が混在してるので統一した方が自然な気がする（実行中コマンド、コマンド実行）
Ah, I misunderstood you, i thought you meant the function name. I will fix this.
Is this a typo?

In most places it's TALK but here it's Talk.
Also change variable to singular.
You could just return the result of the function call in every one of these methods. I may not have done that with the first few, but we should change it.
Why did you comment that out?
The map should be final
@W1ndwaker

Did you forget to store them based on priority?
Space after fields
I only found out that it was supported while writing this code. I'm not  really sure what the browser support is like.
My fault - we agreed to make the change and haven't yet.
If 5 worked before, does it not now?  does Math need to be fully-qualified?  is there really a change here other than the whitespace?
We could mix them, but then `controller` and `action` will get reserved words in the context of fixed params.
Because I got some undefined references while building libcocos2d (my
machine is a Slackware 64 bits):
---
../../../lib/linux/Debug/libcocos2d.so: undefined reference to
`XRRSetScreenConfig'
../../../lib/linux/Debug/libcocos2d.so: undefined reference to
`XRRConfigCurrentConfiguration'
../../../lib/linux/Debug/libcocos2d.so: undefined reference to
`XRRSelectInput'
../../../lib/linux/Debug/libcocos2d.so: undefined reference to
`XRRFreeScreenConfigInfo'
../../../lib/linux/Debug/libcocos2d.so: undefined reference to
`XRRConfigCurrentRate'
../../../lib/linux/Debug/libcocos2d.so: undefined reference to
`XRRConfigRates'
../../../lib/linux/Debug/libcocos2d.so: undefined reference to
`XRRQueryExtension'
../../../lib/linux/Debug/libcocos2d.so: undefined reference to
`XRRGetScreenInfo'
../../../lib/linux/Debug/libcocos2d.so: undefined reference to
`XRRUpdateConfiguration'
../../../lib/linux/Debug/libcocos2d.so: undefined reference to
`XRRSetScreenConfigAndRate'
../../../lib/linux/Debug/libcocos2d.so: undefined reference to
`XRRConfigSizes'
---

Att,
Rodrigo

On Sat, Oct 27, 2012 at 11:28 AM, James Chen <notifications@github.com>wrote:

> In cocos2dx/proj.linux/Makefile:
>
> > @@ -205,7 +205,7 @@ STATICLIBS = $(STATICLIBS_DIR)/libfreetype.a \
> >  				$(STATICLIBS_DIR)/libtiff.a \
> >
> >  SHAREDLIBS =
> > -SHAREDLIBS += -lglfw -lGL -lcurl -lfontconfig
> > +SHAREDLIBS += -lglfw -lGL -lcurl -lfontconfig -lXrandr
>
> Why do we need to link Xrandr?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cocos2d/cocos2d-x/pull/1502/files#r1959860>.
>
>



-- 
Rodrigo Gonçalves de Oliveira
Manaus, Brazil
rodrigo@thecoreme.org | rodrigo.golive@gmail.com
+55 92 82599445
http://br.linkedin.com/in/rodrigogoliveira
shouldn't you check the ``addedMap`` to avoid enqueuing a package that has already been processed ?
Why are these files duplicated, can't we just reuse the resteasy dependency that they are in? Furhtermore, is RestEasy ASL, otherwise we can't just change the license.
my ubuntu hasn't  addmod, 'sudo usermod -a -G gitlab git' is OK
|  From: wiktr
|  Date: Dec 30 08:55:06 2012 -0800
|  
|  > @@ -1 +1 @@
|  > -Subproject commit 23cd38db9498a293d819f1e81aedf5596b9cdd49
|  > +Subproject commit 30060ef746275b635a3b48e50717833f853cd7aa
|  
|  I don't know what these are even doing but no subproject files were changed.

Maybe somehow the changes to $Id$ have gotten mixed up with those for
versioning?  I noticed that the versioning pull request was also
changing the Id lines for the files it modified, and the $Id$ tags are
still in the param and imagen modules even though I merged your pull
request:

hebb:~/research/topographica> grep -r \$Id external/param | grep -v Binary
external/param/param/__init__.py:$Id$
external/param/param/parameterized.py:$Id$
hebb:~/research/topographica> grep -r \$Id external/imagen | grep -v Binary
external/imagen/imagen/audio.py:$Id$
external/imagen/imagen/boundingregion.py:$Id$
external/imagen/imagen/random.py:$Id$
external/imagen/imagen/__init__.py:$Id$
external/imagen/imagen/patternfn.py:$Id$
external/imagen/imagen/sheetcoords.py:$Id$
external/imagen/imagen/patterngenerator.py:$Id$
external/imagen/imagen/opencvcamera.py:$Id$
external/imagen/imagen/image.py:$Id$
external/imagen/imagen/transferfn.py:$Id$
external/imagen/numbergen/__init__.py:$Id$
hebb:~/research/topographica> 
hebb:~/research/topographica> grep -r \$Id external/paramtk | grep -v Binary
external/paramtk/paramtk/__init__.py:$Id$
external/paramtk/paramtk/odict.py:__revision__ = '$Id: external.py 12024 2012-05-02 21:13:18Z ceball $'
...

Also, there are still a few stray $Id$ tags left even in topo:

Hebb:~/research/topographica> grep -r \$Id topo | grep -v Binary
topo/transferfn/misc.py:$Id: basic.py 10790 2009-11-21 17:51:33Z antolikjan $
topo/analysis/vision.py:$Id: featureresponses.py 7714 2008-01-24 16:42:21Z antolikjan $
topo/tests/reference/lissom_oo_dr_reference.ty:$Id: lissom_oo_or_reference.ty 5436 2007-04-15 08:54:08Z ceball $

-- 
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.
should be <machine name="pc1" address="$(arg pc1)" default="true"/>
Seems like an issue in my IDE (didn't see it there), but I'll fix it.
This isn't really logging related, but PEP8 does recommend using "is" to compare to None rather than ==.  (Because people can override \_\_eq\_\_)
All recent experience with plugins has shown that 'required event fields' is actually something bad. It's really awkward and such. I don't like it (in the nagios output, for example)

Instead, make the 'required event fields' settings in the plugin. For times hwen you don't want to emit an event to cloudwatch, logstash has conditionals like types and tags that can be used to restrict output.

Does this make sense? So instead of 'CW_metric' as required field in the event, have this in your plugin config:

```config :metric, :validate => :string, :required => true```
We should drop this if it is not being used.
This should be `once` instead of `on`
I got really get this indentation; the keys look like they're lining up with the method as if it's a method chain and it's odd to read. Maybe just one level of indentation here?
and so what?
not realy, a dirty code duplication (copy and past from behavior class)
we could probably add this 2 classes to `.author_info`
wouldn't it make sense to make it available for the other dialects as well?
I'm not sure I like the goo.gl links, as that means I can't tell where we're linking to when editing the document.
I know, just following PEP 8 (well that's what my IDE does) - see the part "Avoid extraneous whitespace in the following situations:"

http://www.python.org/dev/peps/pep-0008/#whitespace-in-expressions-and-statements
Can you rename this test to CamelCase?
Abstract of original doc

`
 <programlisting language="php"><![CDATA[
prompt> git clone --recursive git://github.com/zendframework/ZendSkeletonApplication.git my-application
]]></programlisting>
`

https://github.com/zendframework/zf2/blob/master/documentation/manual/en/module_specs/Zend_Mvc-QuickStart.xml#L31
Switch these two lines around, so that the last case is the default.
Oh I see, it make sense, so my next question, is there that much classes in widget to justify a ui package?

shouldn't this be profiler/ui instead of profiler/widget/ui?
Yep, thanks. Fixing...
What does "better" mean? Isn't <tt> the tag to use for inline code?
It seems like it'd be better to do a emulateUser.isEmulating() rather than exposing the internal state like that.
Removed this line. 
But instead, the fill down ids in the embryo transfer page won't work properly... there are two workarounds.. either use a ui:param to pass to the animals page, or duplicate the code explicitly for embryo transfer page.
Look at lines 105 and 108 of the DocumentWorkspace class. They're used outside of the BaseTool class, so yes, they need to be public. Also, if I change them to private/protected in the child classes, C# gives me an error because [A.] They don't match up with the public declaration and/or [B.] Virtual/Abstract variables can't be private.
hate to be a stickler, but star imports are bad.
I just realized that that would also call the Tome constructor, which is probably undesirable. A bit of refactoring might make it more manageable?
can you provide a test based on unitests modules ? Otherwise the patch is OK for me.
Missing line break between assignment and control structure
Please add an empty line before and after the if block
There is no param ``exclude`` here, isn't it?

May be we should move the ``Generator.get_files`` method to ``pelican.utils`` (and refactor it a bit: ``extensions=self.markup`` could always be passed as an argument to the ``get_files`` method so that ``get_files`` does not need to be a method of ``Generator`` class anymore) instead of duplicate the ``get_files`` method here.
Because the string split. Try without it:


>>> "foo" +\
... "bar"
'foobar'


>>> "foo" +
  File "<stdin>", line 1
    "foo" +
          ^
SyntaxError: invalid syntax
>>> "bar"
'bar'
There are some non-ascii hyphens in the docs of this file which was why Emacs was automatically adding this encoding hint. I have committed a version with ascii hyphens instead
`return http.HttpResponse('Event not scheduled')`
if about_page.header.are_tabzilla_links_visible prints out messages for the broken links, and the overall test fails, this output will be visible for more detailed information. the assert's message could say 'check stdout for more info'.
How about:

```python
filtered_message = message.replace('&#34;', '"').replace('&#39;', "'")
double quotes around `message`
We don't have a standardized set of taxonomies *yet* so I'm making the assumption that there should be a field called `time`. If there is not a field and it's not filled with a numpy array then a generic timestamp is used.
I suspect this could be made DRY-er, but I'm not sure how.
sign_user ??
Por que esto?
hmm.. maybe i'm missing something?

Host.joins(:fact_values).where(:facts_values => {:value => fact_value}) ?
view.el
islandora_post_delete_object() just takes the ID and the models.
The issue is clarity, the worry is that users of the code won't know to look for the functions in global.inc.
I don't really like this method being public, since it provides a backdoor around the state management operations in `ModeShapeEngine`. I understand that changing the visibility was required when we move the `RepositoryFactory` implementations into the `org.modeshape.jcr.factories` package. But I think having a cleaner API is more important than having that separate package.
Ah I understand now. My comprehension was slightly marred by github hiding the end of the line.
Anyway, you could do this: {%if%} permission then place anchor and classes {%else%} place normal stuff.
This would means some replication of the definition list stuff.
I'd rather not have 5 files named "Base". I wish something could be a Class and a Namespace, because `Middleman::Sitemap` would be perfect.
is this loop necessary then? We already have the segment at t and we are sure it's a chordrest. we can change the loop by sCr = s
Check this out for the read buffer: http://doc.qt.digia.com/qt/qabstractsocket.html#setReadBufferSize
As discussed on the mailing list, I'd probably use `static const xmlChar[]` for the property names.
It was fixed on #48
estimator, uart, downlink, messages and math includes are not needed, same for DOWNLINK_DEVICE defines
Doh. My editor apparently indents this differently than everyone else's. I've fixed it to not do that now, so hopefully this won't be an issue in the future. In the meantime, I'll clean these up.
When looking at a tenant via the global server only the tenant's data is requested.
In that case we'll request more data about all tenants when the footer needs to be rendered.

If we're on a tenant server the footer doesn't need to be rendered and the data isn't fetched.

If we're on a global server looking at the global administration the data is already cached and we don't fetch it again.
https://github.com/sakaiproject/Hilary/pull/122/files#L2R52
This test should be in the oae-config module. It should also test the response.
I think we'll need to check if the current user has access to content item as you would otherwise be able to post comments to a piece of content that you can't see (given that you know the ID)
Then queries while the schema is unsynchronized will result in something of the form of a "SchemaAgreementException" returned from Helenus.

Waiting a second is not ideal. Nor is how Thrift handles creating schema elements in general. There is no way to be certain it has propagated across the cluster, without checking a method called "get_schema_versions" on a periodic basis and continuing when it is successful. I grepped the Helenus API and we don't have access to such a method :(
It should also be a synchronous function if it's just being cached eternally.
``ScalaSourceLookupParticipant`` may return ``null``, which could cause a NPE from what I can see in ``AbstractSourceLookupDirector.addParticipants``
I wonder here if typing ``foo`` or ``this.foo`` would give you different penalties. Maybe worth adding a test for this?
@dragos Good. I see you have already fixed this :-)
if $name can be the route object in CmfRouter but not here, i would have to figure out the name of the object, pass that to the parent only to have it retrieved from the provider again. that sounds awkward. 
and anyways in the url generator you assign the route object to _route which would make me expect we can generate the url again from the route object. it would just wrap the route retrieval into a `if ( ! $route instanceof Route)`
Right, but it won't run the same task twice. For example, if you run `rake db:migrate routes`, it will only run the `environment` task once, despite the fact that both tasks depend on it. If you run '`rake spec spec`, it will only run the specs once. I think your command above won't actually run migrations more than once.
Remove the method above that is commented out.
needs to be moved to `bozo/preparers/common_assembly_info`
Hrm, this should actually be:
browserWindows.getNext().QueryInterface(Ci.nsIInterfaceRequestor).getInterface(Ci.nsIDocShell);

to be on the safe side and not rely on xpconnect interface flattening.
Does this really require a new GUID and cookie?  ASP.NET has already assigned a session cookie to the client, hasn't it?

For example, DotNetOpenAuth's OAuth 2 client class uses the preassigned session ID for this exact same XSRF protection.  [Check it out](https://github.com/AArnott/dotnetopenid/blob/master/src/DotNetOpenAuth.OAuth2.Client/OAuth2/WebServerClient.cs#L106)
false -> FALSE
Yes I did, I don't see a thread pool here....
Да, поскольку было передан указатель, то получался бесконечный цикл, сейчас действительно создал копию старого массива и все работает как надо.
я понимаю, что такое свойство. задание к первой лекции не подразумевает, насколько я понимаю, переписывания сеттеров. в данном случае можно было вообще указать DNA = [[NSMutableArray alloc]initWithCapacity:100]. но я подумала, что в дальнейшем размер массива может быть использован, и решила объявить его как свойство класса.
Я раньше использовал метод 
- (NSString* ) randomCharacter {
    int i = 1 + arc4random() % 4;
    switch (i) {
    case 1 : return @"A"; break;
    case 2 : return @"C"; break;
    case 3 : return @"G"; break;
    case 4 : return @"T"; break;
        default : return @"Error";
    }
}
но потом нашел метод substringWithRange который елегантно решает задачу со случайным символом :)
Я привел тот же довод, так как сделал также, по сути конечно, это верно и оговорок в условии нет, но если посмотреть другии обсуждения в репозиториях, то предпочтительными явяляются более универсальные решения -  различное число нуклиидов и длина цепочки ДНК.
Переменная percent в этом методе это процент от количества элементов в _DNA, а не просто количество элементов, которые должны мутировать. Этот метод будет работать неправильно, если к примеру инициализировать Cell 9-ю элементами и при этом передать в mutate значение 73.
если размер массива заведомо известен (а в нашем случае он известен), лучше инициализацию производить с указанием размера  

dna = [[NSMutableArray alloc] initWithCapacity:100];

Правда в вашем случае, поскольку вы начинаете с еденицы, а не с нуля, 
нужно писать

dna = [[NSMutableArray alloc] initWithCapacity:101];
Это не лишнее. Если вы создадите новый файл в Xcode, и выберете из параметров категорию к классу, то он за вас создаст два файла:

Интерфейсный файл Cell+Mutator.h
и
Файл имплементации Cell+Mutator.m

В лекции был рассмотрен пример, так в тех же самых графических программах не поступают (я имею в виду программы с GUI) - каждая категория, каждый класс и каждый протокол там будут указаны как отдельный файл. Так удобнее.
Категория должна называться Mutate
If there's a new packet that we didn't send it to client
This line seems a bit long. Could you reformat it to <= 80 chars?
Only one "--with-driver=" line allowed.
и toggle этот не нужен :) который не работает )
That would change the function signature, which would break existing code. I updated the JSDoc to clarify that the parameter is not used.
If we don't delete directories, then why don't we simply rename the function to DeleteFile()?
I think `ns-resize` would be more appropriate here
These need changing to match the style of other scripts.
Fix is here! :)
Thats really nice. I'm still thinking though a (set of) function(s) would give us more freedom to explore new smart features in a more context independent manner than a method does. We can then later put it in context. this way we might be inclined to add new methods for each of the possibilities discussed in #133. besides this, i apprciate the direction.
Move this logic to a special function (better readability and code maintenance) and use return to minimize the use of if and else
In AMO we index by highest id first, I believe. But like you said, this is easy to override.

For the autofield thing, it looks pretty simple. Given a model object...

    >>> addon._meta.has_auto_field
    True
    >>> addon._meta.auto_field.name
    'id'
returns a list of tuples with those fields in that order in the tuple?
What is @Attribute for?
I think this should be handled through the config library (which already has this kind of logic built in)
Hi John,
that line fails for me when I run an application from within Eclipse. The build path though has correct ordering (i.e. ERJars comes before JavaFoundation). Is that working for you? In what environment? I commented these lines out in a commit until this is resolved.
So you tried it without the closure and it didn't work?
I disagree that it should be called Zikula_Doctrine2_Entity_AbstractCategoryAttribute. While it is true that the discriminator map only has one entry, it could be further refined to be utilized by other entities if one wishes. For example, there are entries in the attributes table upon install for the Users module. If when the Users module is written for Doctrine2, this abstract class could be extended to include information for that as well. or other modules. Ideally, it WOULD be extended to cover any object currently using attributes in a similar way to categories.
why lowercase?
K, r = divmod(n, J)
if r:
    K += 1
2 колонки. выделяет row
Не все, но если тебе понятно, что метод не будет (и не должен)
использовать методы/функции твоего класса, то зачем делать его членом
класса?
Yes 
```php
$iso_code = null;
if($id_lang)
      $iso_code = Language::getIsoById((int)$id_lang);
if (!$iso_code)
      $iso_code = Context::getContext()->language->iso_code;
```
you should use braces even for a single line
review this class
This whole block is a large code duplication.
I knew that you would reply that :)
Maybe. Here we go deep down into the mess that arises from trying to use to implementations of  a similar Api that unfortunately bases on derivation. I tried to get as little implementation into the specific map view implementations as possible and to keep things in the common classes.
Probably there are other architectural schemes to allow one map-(pseudo)-activity implementation (and view and overlay and ...) that derives from two different classes, but that was what I could come up with.
I would be more than happy to explain the basic architecture and my reasons for implementing it in order to get ideas for an overhaul that makes the maintenance easier.
This should call something like Statistics.sum(column);
I kinda see what you're trying to do, but it feels rather odd. And why have two onPreExecute() methods in the lifecycle interface? I wonder if you really wanna have different interfaces for callable vs mapper vs reducer? So, 3 interfaces, rather than a single one? 

I don't have an exact answer on how you can do this alternatively (I'd need some time to think about it), but seems to me that you're trying to bundle too much into a single interface. You should think about the type of callbacks each type really needs.

Alternatively, email the dev list to discuss this. Interfaces like this really need everyone's eyes on them in order to make sure they're the best that we can come up with.
Gnah, you´re so right :(
The curly bracket should be on his own line :)
If we have to cast this, either we're wrong, or libgit2 is. One of the two needs to be fixed.
But with this change, the warning itself is now incorrect and must be fixed. @leejjoon, should it say something like "This figure includes Axes that do not inherit from SubplotBase and/or were not created using axes_locator; tight_layout will not take such Axes into account, so its results might be incorrect."
Why don't we make this a DeprecationWarning -- indicating that it may become an exception in the future and the user is encouraged to change their code.  (And same for the warning above).
for all classes we used to have a link here can we add it
So we get a script timeout? Could we return false instead?
Use "return window.navigator.mozWifiManager.enabled - no need to test for equality against true
Better yet, do the try-catch on the specific piece of this that throws an error.
Boxshadows acima em apenas uma linha.
Hi - I just followed that pattern used to add the class to the container. Should that be changed as well?
Missing `;` and spacing throughout the function above.
Damn, fixed!

On 16/05/2012, at 11:45 AM, Sean Harvey wrote:

>> @@ -30,6 +28,18 @@ Data is escaped when saving back to the database, not when writing to object-pro
>> *  FormField->saveInto()
>> *  DBField->saveInto()
>> 
>> +Data is escaped when saving back to the database, not when writing to object-properties.
>> +
>> +Example:
>> +	
>> +	:::php
>> +	// automatically escaped/quoted
>> +	$members = Member::create()->filter('Name', $_GET['name']); 
>> +	// automatically escaped/quoted
>> +	$members = Member::create()->filter(array('Name' => $_GET['name'])); 
>> +	// needs to be escaped/quoted manually
>> +	$members = Member::create()->where(sprintf('"Name" = \'%s\'', Convert::raw2sql($_GET['name']))); 
> 
> Isn't that supposed to be `Member::get()`? `Member::create()` will give you a new instance of Member I thought.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/silverstripe/sapphire/pull/451/files#r830081
`call_user_func_array` is very slow.
Either `self` or `that` is fine with me. I generally use `that`, but I wouldn't reject code for using `self`.
@vicb ``UsableInterface`` sounds good? is that what you mean?
I'd call it CLI Examples
How about making the return type a bit more specific; maybe use ``integer|double|string|boolean|null``?
The assignment to ``$t`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
Just to be clear, this is inside the app-specific dir yea?
What is lalal, this is a testing file ?
Yes sorry that was a typo
OK, thanks. In that case can you abstract the code into a new `getDefiniteTypeForDisplay(ProducedType)` method and add your reply above as comment to explain why we can't use the stock `Unit.getDefiniteType()` because we _will_ forget ;)
Agreed. send_emails should be send_messages instead.
why do you need to require rubygems, it should already be loaded at this point ?
This is not cluster safe. You should after that make use of `eZClusterFileHandler` in order to properly store the file in the cluster, and then remove the local file (still with `eZClusterFileHandler`)
do you know which version of sinatra changes this option? I'm concern it might break older package based deployments
I figured out I could do something very simple like this:

```python
class Query(object):
    def __init__(self):
        self.query_terms = constants.QUERY_TERMS

class QuerySet(queryset.QuerySet):
    def __init__(self, document, collection):
        self.query = Query()
```

Not sure if this is the right way but it works if I put it in MongoEngine library. But I can't find a way to extend this from our TastypieMongoEngine because this QuerySet object is not defined there, it's not even used. 
So many complications :/
Define a top-level constant variable for this. Give 5 days.
Yes I just added that also. Hmmm, than confirmation/{{token}} isn't really the best url. Can I change it, so /confirmation/ and this are totally different urls?
But we need it. Otherwise information is useless. We could predict future wrong! For the wrong day!
Move all this to main docstring documentation for this backend. You can also create some initial description (like, "Foursquare user fields are:").
Ask around! :-)
`get_nearest_stations` is not really a good name. Nearest is really only the one (it would be really strange coincidence to have more than one nearest). You are not search really for the nearest, but all in some close proximity, range.
Done https://github.com/SocalNick/ScnSocialAuth/pull/35/files#L1R52
If there would be a spell, I wouldn't need this. But the chest has to disappear completly after looting. Without this line it will respawn after a while and never disappear from world.
2012 :D
please change the method signature to:

    - (void)navigateTo:(NSString*)route navigationController:(UINavigationController*)navController query:(NSDictionary*)query;
It's the one we're currently using in the GitDownloadController so I assume it's been tested thoroughly with real apps. The older implementation didn't work well though.
I see, my mistake - the Predicates and SemanticArguments are larger than a single BaseToken, so the code I proposed wouldn't work.

Basically what you really want is an index from BaseTokens to the Predicates (or SemanticArguments) that contain them. You can get one using JCasUtil.indexCovering(JCas, Class<T>, Class<S>). However, for efficiency, you really only want to call this once per JCas, not once per token. I guess one workaround would be to cache it somehow.

Well that's all pretty complex. Don't worry about changing this code for the moment, but please add a comment something like:

// TODO: don't iterate over the entire CAS for each focusAnnotation; use JCasUtil.indexCovering and cache the results so that we only do this once per CAS
Finde das Flag irgendwie irreführend, bzw unnötiger Overhead, da das unknown ja selten sein soll.

ok. Hättes es irgendwie so gemacht um es lesbar zu halten:

static final int UNKNOWN_BEERTYPE = -1;
if(beertypeId=UNKNOWN_BEERTYPE){}
As said above, I would strip this method entirely and use a fatter `authenticate()` method, or a protected method `getIdentityObject` that does what this one does, but also creating the eventually required query in it.
this was not necessary :)
same here: close the method at next line and add a comment
For consistency, may want to add another entry to dependencyManagement element to specify default version of this new module, though I doubt any clients or sibling modules will depend on this one.
Does this need <scope>test</scope> ?
Yep, you're absolutely right, let me fix it right now!
inconsistently defining mocks. above you call double, here you call mock
Nit: in mozilla-central, we generally write

    if (!pending) {
      return;
    }
It works:D. I think alpha ends up clamped between 0 and 1 (it seemed the twinkling was different) and requires a post-multiplication in the shader to scale it.

> I'm not sure what this does :)
You want the twinkle state (brightness) to be different from star to star and the twinkle state to vary in time according to a different pattern for each star.
A 2d noise sheet is used to calculate brightness (imagine a height field over a plane) with the 2 dimensions of the plane representing star id (y axis ) and time (x axis) and with the brightness represented by the value of the noise function at (x,y). Moving through time is picking a y coordinate corresponding to a star id and moving in a line parallel to the x axis (time)
I do not understand why you add code to modify ```__file__``` attribute when ```__file__``` attribute is already patched several lines above.  Why haven't you modified the original code with ```__file__``` attribute?

Change the ```__file__``` attribute is a fairly fundamental change. Have you run other tests that they still pass?
ditto as above, will fix
result of `grep -riHn "urn:xmpp:ping" *` in xmpppy source code is empty, so it seems that answer to your question is: no, there's no "urn:xmpp:ping" declaration in xmpppy.
Multi line comment
I might suggest removing the optional seed parameter.  You've already got a pretty busy list of kwargs, and I think it's probably more natural to just take an input random deviate or None, rather than also a seed value.  Also, I'd allow the input random deviate to be any BaseDeviate class and make the GaussianDeviate from that if it isn't already that.
Might want to comment in how this works so that newer guys reading this can figure out what's going on. Otherwise, nice job!
Could you also translate these?
Yes, synchronous.  For both command line case (see what's happening) and celery worker case (only mark job as done if it succeeds)
Rekelvinate is just manage.py stuff.  The kelvinate primitive itself won't change.
This looks like a syntax error with a missing `}`
One photo for a user? Should we keep track of all of a users previous photos?
Could declare spec as final?
Looking at the code, it looks like you're right.

In AutoScalerPolicyTest.testResizeUpStabilizationDelayTakesMaxSustainedDesired, it attempts to test that we resize to the "most stable" request (e.g. if 10/11/10 then shrink to 11). But that test is for POOL_HOT messages, rather than when using a metric with high/low threshold.

Suggest that I merge this pull request, and then add a similar test to AutoScalerPolicyMetricTest. And then fix the code...
This conflicts with @raphink's syslog commit - could you please rebase on my current master, which should solve the conflict?
Merge will be difficult ? or i will make a PR post 0.26. I wont remember it. I remove it.
조금 더 생각해보니 여기에선 작업이 더 자연스럽네요. 그대로 가겠습니다. :)
in fact, i'd inline the 'REXML` call from `load_xml` into the sole call site.
Go ahead and remove my quotes. But note to ourselves for 1.1: this sample might have to be updated anyways. AND it appears several times in client.py and binding.py (6?)
This seems like a weird signal name, since it's used for both starting and stopping notifications? Why not call it "stopAfterTrackChanged" ?

Also for pedantry you could add a if ( m_stopAfterTrack != query ) check to the start of the method too :)
On Thu, Feb 23, 2012 at 1:44 PM, Dan Yamins
<reply@reply.github.com>
wrote:
>> @@ -862,8 +866,52 @@ def checkpoint(self, result=None):
>>              handle = self.trials.handle
>
> Are you saying:  don't use checkpoint to insert results at all anymore (even the "first one")?

No, I guess checkpoint still makes sense for updating the result of
the job that launched the evaluate function.

I suggest to not use checkpoint for all the other new documents.
document.write really? :/
No real issue but I usually prefer guarding clauses in general since there is less indent and lines in the code:

```js
if (borderWidthDecls.length === 0) return 0;
// No support for left-top-right-bottom separation yet, so we just take the average
var borderWidth = borderWidthDecls.reduce(function(prev, decl, i, a) {
    return prev + convert(decl.getValues().first()) / a.length;
}, 0);
return borderWidth;
```
Even I have to say it might be nice to have a comment here what this large block of graphics code does.
Yeah, I was a bit confused as well
2 Гб файл потребует столько же памяти?
@ctweney rvm use jruby-1.7.0@eggshell --create
`DOMContentLoaded` is probably better in this case.
please add a comment about what's being generated here so there's no need to go read through method "generate_test_app" to understand what this is.
Why are we setting this expectation in the page object?
We already have a method defined for title here https://github.com/mozilla/marketplace-tests/pull/196/files#L2L38 We don't need this one.
s/sort_filers/sort_filters
And `fit` is not in the mixin. As you wish. Maybe introducing new mixins would be cleaner though.
If I am not mistaken, `SVC` and `NuSVC` are also impacted. At least the dtype of the prediction outcome is now integer instead of float.
The file name should be more explicite: `passive_aggressive.py`
It is not checked that X and y have the same shape, right?
"core::{0}".format(node.type.id) ?
Tu remarqueras que ça te fait sauter le str(...)
Please use the `io.File` class for this, and think about using `io.streams.TextReader`.
How about just putting the options on one line: "Attempt to fix NaN/Inf in the image (options: none, black, box3)".  We can make the printed docs give detailed explanations of the options.  I fear that as the help screen gets longer and more cluttered, people will be able to make even less sense of it all.
This should also be final
Personally I don't really see much value in mock based tests like this. In my experience they are fragile and don't really do that good a job.
Should also test that v8value is indeed an array before casting it.  So the above would test for `!IsArray` instead of `!IsObject`
Since this is a fully static class with no members or data, the default implementations of ctor dtor and = are all fine and won't create weird behaviour. there is no need to declare them.  Less is more.

I can still add them if you insist.
Still see no reasons to do that, though changed, since its the same
I have no problem with formatting, the line was too long for my screen so i splited it.
no need for break, or on the pre-existing line above.
sorry, my mistake, it isn't
Could combine this with the previous scan to avoid a rescan.
In the other pull request, your comments on ```createkey.ecl```.

Compiling that file with ```-legacy``` gives me several errors, while without it works.
What happens if ldapsecurity->addResourceEx returns false?
Does that mean it already exists?
I still believe (and I suspect you disagree) that the serialized dictionary format is - and should remain - the same as the serialized dataset format.
As a short-term workaround it sounds fine, but are you sure you can't use the core methods yet?
There's no need, it's not used any more. I'll remove it.
I don't like the hardcoded strings here. With my above proposal it should be possible for us to have dynamic tooltips kinda easily.
It's based on what's in ZF1, and all of these are still present. We should definitely review either for beta4 or before we go to an RC, however.
updated. thnx
Indeed, first instinct is a test lamba (with default of `exists`) for use in the loop. The `find_file` could then set that lambda and handle the file read after the return of `find_file_or_dir`.
HEARBEAT is spelt wrong, should be HEARTBEAT
It isn't a registered datastore option, and really it's not an option that the user can set, so just use a local variable pls :)
Something like:
```ruby
print_warning("Failed to delete #{@payload_destination}, manual cleanup may be required")
```