labofsahil/github-event-dataset-2012 huggingface dataset:
however, it does look to me like approving account requests would be broken.  doesn't that go to this form, and in that case, don't @account and @card need to use the params?
Where did you get all the math from? It's a bit hard (for me) to follow, so it would be useful for me to have a pointer to where I could read these formulas.
In other places in the REST APIs this is referred to as "retrieving" instead of inspecting. Not a huge deal, but mentioning for consistency so there's a common tone.
something is not right then. the problem is that `NaN` doesn't equal zero, it just means that IE isn't telling you the width. the whole reason i added those rules was to prevent this situation, so apparently this function is now getting elements that don't match that css rule. that's a problem.
it's cool to propose bigger changes, but first we have to unbreak this one so we can keep rolling.  caching is broken as described.
I think you can do a keys.map(key => (key, scn....)).toMap instead of creating a map and populating it
This is a bit tricky because we can't assume that the filesystem structure has an extra directory for the movie set. Not sure what the best way to go is though.
Bad indentation (only 2 spaces per level)
i've removed the file
instead I would pull up readFields() here
These should remain constant now.
Again with printk. Also the line should be broken to not exceed 80 characters.
If these changes are then only required for migrating to rhino 1.7R3, could you publish this artifact on maven central repo? Thanks!
Ew. This param definition is nonsensical. I know it's not part of your pull request, but I didn't notice until now. Bummer.
Oh, that looks really crazy :)
Why would the hover be ended? Isn't the mouse still inside the view?
Because it would be very awkward if the delegate was told it *will* lose responder, and then *did* lose responder, without a moment's hesitation. That would break things like table views told to reload in very intricate ways (like mine) based on this this.
Ditto on the temp dir
Why not use the UnknownSocksRequest that you declared before ?
Could `FileHandler` be static?
Why not use the msg that you declare above ?
I'm not sure about that, as I think the information that should be printed is exactly what PyErr_PrintEx(0) produces.  Is there some other reasno to prefer PyErr_WriteUnraiseable?
While I'm making you make fiddly changes to this file anyway... this line should just be removed, there's no such thing as an `NA[...]` typestring in this branch of numpy, and this isn't the right place to test random syntactically invalid type strings.
Let’s not change this. It might lead to strange behavior in browsers where browsers set it as a second cookie. Cookie handling in browsers in widely inconsistent and we should try hard not to break something by accident.
сначала методы/слоты, потом поля
I don't think that this will work. We really need to pass Rails.root to the initializer?
Perhaps we can extract this conditional to a method. Also, I think that we should add the possibility to the user change the `:include_blank` options even if this condition is true.
Is not better use the `:polymorphic` options here?
I was following the logic from here:

```scala
if (overlapping.isEmpty && currCase.guard == EmptyTree) currCase
else collapse(currCase :: overlapping, currIsDefault)
```

But collapse doesn't rely on this, so this isn't important. I was actually wondering whether down below `freshSym(binders.head.pos, lub(binders.map(_.tpe)))` and wondering whether it keep the existing binder name if there is exactly one.

I was wondering whether
duplicate comment from the Notes section
Yes, it was never used in SymPy, and it was documented in the issue that it has to be removed.
On 12.06.2012 19:04, Sergiu Ivanov wrote:
>> +    commutative in a :class:`Category` by supplying the argument
>> +    ``commutative`` in the constructor.
>> +
>> +    Examples
>> +    ========
>> +
>> +>>>  from sympy.categories import Object, Morphism, Diagram, Category
>> +>>>  from sympy import FiniteSet
>> +>>>  A = Object("A")
>> +>>>  B = Object("B")
>> +>>>  C = Object("C")
>> +>>>  f = Morphism(A, B, "f")
>> +>>>  g = Morphism(B, C, "g")
>> +>>>  d = Diagram([f, g])
>> +>>>  K = Category("K", commutative=[d])
>> +>>>  K.commutative == FiniteSet(d)
>
> `K.commutative` gives
> ```
>   {Diagram({IdentityMorphism(Object("A"), ""): EmptySet(), IdentityMorphism(Object("B"), ""): EmptySet(), IdentityMorphism(Object("C"), ""): EmptySet(), Morphism(Object("A"), Object("B"), "f"): EmptySet(), Morphism(Object("B"), Object("C"), "g") * Morphism(Object("A"), Object("B"), "f"): EmptySet(), Morphism(Object("B"), Object("C"), "g"): EmptySet()}, {}, {Object("B"), Object("C"), Object("A")})}
> ```
> Should I still go for it?
>

Hm. Well obviously you should not go for this. Might this be an 
indication of poor printing? Does it come out better if you pretty print 
it? I mean surely "checking which commutative diagrams are set in my 
category" is a reasonable thing to do, and the answer should look 
reasonable as well, shouldn't it?
The docstring looks good. Before your rebase and commit, make sure that the formatting of the text is taken care of.
`_random_gens` is for internal use; the method `random_pr` produces a random group element using product replacement.
On Sat, May 12, 2012 at 6:44 AM, Stefan Krastanov
<reply@reply.github.com>
wrote:
>>
>> +    If you do not have control over the class definition you could also use the
>> +    `converter` global dictionary.`The key is the class and the value is a
>> +    function that takes a single argument and returns the desired SymPy
>> +    object, e.g. `converter[MyList] = lambda x: Matrix(x)`.
>
> I left this out because Matrix works on iterables. However if you think it is better with a more explicit example I will add it.
>
How about make something like this the new doctest?

`
>>> class MyList(object):
...     def __new__(self, dat):
...         etc...
...     def data(self):
...         return self.dat
...
>>> converter[MyList] = lambda x: Matrix(x.data)
`

(That's not production quality, but that's the gist of my idea.)
No, just pasted into the wrong function and forgot about it.
Or "used in determining"
error_reporting not affects @ behavior, scream does http://php.net/manual/en/scream.examples-simple.php But its since 5.2 http://www.php.net/manual/en/scream.requirements.php

I think you should check chmod and other file operations in requirements script, and warn user. As @rawtaz said, user should know if something fails, and why, or debug will be a great pain, especially for newbie.
I was getting permission errors so I decided to put in both and then come back to it. Shouldn't need both, though.
Why both internal and external?
I think I would call this variable MIGRATION_TXT_TEMPLATE. That would make it a lot easier to figure out where the results are going.
I would prefer to see this method on each service. There are two reasons for that:
- One can define the @return Type for each service (syntax highlighting)
- It shows the developer that he can not have a ServiceMethod, which is called "Simulate"
(The current implementation would hide a Simulate-Method on the Service; but only from the controller-level)
Please use a space after commas. :-)
Parenthesis not needed. Apply to all code where possible.
@zapcannon99 should look at this, because he was just thinking about adding this capability back in (may have already done so).  Wonder why we took it out in the first place.  @Dantemss do you recall?
this should probably go in the introduction section
revise as above.
Also, I am still not clear whether or not mod_rewrite or similar is *required* for phpbb to work. This needs to be clearly stated.
Same here, you need to count before deleting the user so that you have known before state.
hm... yeah
phpbb_ prefix.
send_404 would be an improvement.
Changing this to read causes SQL errors (on creating the table)

PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have a
n error in your SQL syntax; check the manual that corresponds to your MySQL serv
er version for the right syntax to use near 'read tinyint(1) UNSIGNED DEFAULT '1
' NOT NULL,
        is_enabled tinyint(1) UNSIGNED D' at line 7
Should take a list of permissions for efficiency reasons.
You should check that the error is what you expect. The assertions are the same in this and two subsequent tests. If this cannot be done for whatever reason a comment should be added explaining the reason.
Consistent case would be nice, maybe?
If by every other javascript function you mean the other functions in phpbb, they should similarly be refactored.
*from* the database
I really really REALLY dislike refactors in the middle of a feature request. But I will let this slide.
а реально будет 100+ баннеров?
по поводу обновления баннеров по отдельности. 
для счетчика показов/кликов отдельная таблица вида unit_name|shows|clicks
обновлять только ее

http://www.kavoir.com/2009/05/mysql-update-multiple-rows-with-one-single-query.html
есть вот такая фигня для обновления нескольких полей, только не знаю как у нее с производительностью
logic backwards? should just be (isNaN) instead of (!isNaN)?
shouldn't all lines 510-516 be commented?
Might be preferable to name these in a more generic way, in case you add more later, to clarify that they retrieve strings. 

```
getString('LoadErrorMessage')
getString('SyncErrorMessage')
```
or
```
getMessageLoadError()
getMessageSyncError()
```
It's not a functional change, but this would give more helpful errors if written as: `self.assertEqual(weights.shape, self.cube.shape)`
Good point about the line number. I'll make sure the error reported has it.
なるほどですね。
Why not use jquery for this?
We should add this to our style guide... from GoogleStyleGuide: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Header_File_Dependencies#Header_File_Dependencies
the method is not static
Can you move the result of $this->getConfig()->getAll() to a temporary variable so that it can be used here and in the following foreach loop? That way the method only needs to be called once.
Yeah, I figured there's no point in having buildArrayList, buildLinkedList etc. if you could just pass the class.
Unwinding this one a bit, let me see if I've got this right:

The `style` value must be (since it contains `^` and `$`) some combination of units that can be:

* One of the characters in set(`"-:,;#%!` + any character (`.` is unescaped) + any letter + any number). - OR -

* Any 3 characters in the form `\w-\w`. - OR -

* Any single OR double quoted string of `[\s\w]+`. - OR -

* Any number of digits, commas, and whitespace within parentheses. - OR -

* Empty.

... What? What is this testing?
It should not be null here. Null means no features. I add the check in function "MADLIB_SCHEMA.__check_training_table" before encoding.

We have 4 places need to use quote_ident and quote_literal. All of places were changed. I use the following table to do the test, it works well for training, classification, score and display. Please help double check the correctness of the changes. If I am wrong, please correct me. Thanks.

```sql
testdb=# \d golf_2
           Table "public.golf_2"
   Column    |       Type       | Modifiers 
-------------+------------------+-----------
 id          | integer          | 
 out,look    | text             | 
 temperature | double precision | 
 humi'dity   | double precision | 
 win'dy      | text             | 
 class       | text             | 
Distributed by: (id)

```
OK.  So NewDelete.cpp overloads new with palloc.  But I'm not quite sure if this new calls palloc...
True, but I don't think the number of groups will ever become significant (but rather be in the single-digit range, or at most two-digit range). Otherwise, you are right, and I made a wrong assumption. Are you aware of use cases with more groups?
The motivation here was performance of the wrapped function which includes a membership test in the loop.  In the (unlikely) case of a huge number of parameters, this could become an issue.  Is there a potential problem?  (I know: I have not profiled, but I have been bitten by sequence membership testing before.)
Lets keep it this way for now, and see if we still observe tracks that forever remain loading. Please remove the comment.
… we don't have any circular dependencies.
I wonder if we really want `onoe e.inspect`. This results in (for example)

```
Error: #<RuntimeError: foo>
./librsvg.rb:14:in `install'
/usr/local/Library/Homebrew/build.rb:105:in `install'
/usr/local/Library/Homebrew/formula.rb:226:in `brew'
/usr/local/Library/Homebrew/formula.rb:511:in `stage'
/usr/local/Library/Homebrew/extend/fileutils.rb:22:in `mktemp'
/usr/local/Library/Homebrew/formula.rb:507:in `stage'
/usr/local/Library/Homebrew/formula.rb:221:in `brew'
/usr/local/Library/Homebrew/build.rb:82:in `install'
/usr/local/Library/Homebrew/build.rb:44
./librsvg.rb:13
Error: foo
```

The two `Error:` lines aren't ideal from a UI standpoint.
is it possible to install the python bindings into `lib/which_python()/"site-packages"`?
Then (at least for a brewed Python) you don't need to amend the PYTHONPATH.
Nevím jestli máme sjednocenou terminologii. Já se na to dívám tak, že náš web bude obsahovat několik kurzů a každý z nich bude složen z několika (asi) lekcí. Lekce může být buď povídání/ukazování, nebo cvičení (tzn. odpovídá jednomu okýnku/dvojokýnku jak je v course.js).

Takže buď bych přidal položku lectures a smazal courses, nebo nechal courses pro seznam celejch splněnejch kurzů.

Další otázka, jestli by to mělo být formou pole. Spíš bych čekal slovník.
One other approach would be to move this to a constant like:

```ruby
# Remove after Rubinius ?? is released
DATETIME_FORMAT = RUBY_ENGINE == 'rbx' ? 'Q' : '%s'

# ...

def self.to_datetime(value)
  ::DateTime.strptime((value * 10**3).to_s, DATETIME_FORMAT)
end
```

You can replace the "??" with whatever the next planned stable version of Rubinius is. Alternatively, you could even include the version in the conditional so it's absolutely clear what versions of rbx this applies to, and at some later point we can remove it.
You already defined this on line 136
i don't know
python or system
i think strip() eats it, i removed it for tests
okay, i found more easy and better way, will make changes tomorrow

for observing garbage you can look my next comment on this code
Missing compilation directives:

#ifdef FPM_ENABLED
boost::thread FlowTable::FPMClient;
#else
boost::thread FlowTable::RTPolling;
#endif /* FPM_ENABLED */
The subclasses should do the validating such as StorageUnit and ProductGroup. Since the data is stored in the subclass its self there is no way for the superclass to do any useful validation. This is here simply to enforce the api.
I know this is technically the "wrong" spelling, but it still gets used a lot.
Should set a configurable max size to the queue so that the memory usage is bounded, and also do put_nowait() so that if it's full the put call won't block.
Is this safe everywhere?
I strongly advice against concatenating HTML strings :tongue:
Without the lock, there's a race condition: We check if `_entities` contains `rowKey` and see that it does. But before we can return the entity with that row key, it is deleted on another thread.
I don't think this really breaks the idea of components. The only odd thing is that you're doing a query on the entire dom to get the region to cover. If there was a method on Screen to get the region you want even if it's by classname, I think this would make sense. I think this could be the basis for a general solution for modals, and this logic could be moved up to Screen now. I think as long as all dom stuff related to regions is controlled by its container screen in a reasonable way, it's ok.
We do still want to write browser into the class list. It's probably appropriate to add device.environment as a class.
Good idea -- done
Why is this one named "*Changed" when the others are "handle*Changed"?
Agreed: ``project/WorkingSetSort``
Please add {'s here, it's incosistent with the else branch
Shouldn't both values be the same ?
I probably wont keep this example, but just write a wiki page with some info instead.
In an earlier attempt, I had put it in `coord_train`. One drawback is that you need to do it for each type: `coord_train.cartesian`, `coord_train.trans`, `coord_train.polar`, `coord_train.map`, and so on. The following two lines would go at the top of each of these functions:

```R
  scales$x <- coord_expand_defaults(coord, scales$x, "x")
  scales$y <- coord_expand_defaults(coord, scales$y, "y")
```

There's a bigger problem with this approach, which is that facets don't use the expansion values properly, as shown here: http://stdout.org/~winston/vtest/diff/guide-axis.html
This does fuzz testing, setting random fields in events.  It also compares the MapEvent and ArrayEvent implementations for compatibility, and tests [de]serialization.
What happens if any of the attrs values are undefined?  Does initing the path with 0 values prevent that?
I was trying to fix this with with tag, but it's not working.
OK. Then leave it as it was. So let it throw exceptions. Will somebody else check/test this. Then do not convert to `get`. Or at least make smart decisions when to do get and when not.
Ugly. No HTML in Python code, please.
This class is actually never used. When a user logs out, they go to "logout" url not "facebook_logout".
Or a method which returns URL based on the given size. Or something.

So please make only a method to User class and one template tag for displaying that. No need to keep things separate.
Changed `self.error(self.error_messages['bounds'])`to `self.error(u"Invalid upper_limit argument.")`
Ok but then I should change COMMENT_MAX_LENGTH  to COMMENT_MESSAGE_MAX-LENGTH ?
I need a hint please :) I can't figure out how this works. Right now I was literally trying every combination I could think of, but id didn't work, also tried to do like it is done on wlan site but no luck/knowledge. :) It is working in a way that if the user logs out display language is set back to browser settings and that is it. If the user logs in display language stays the same as current display language.
Ohhhhhhh I see what's going on here
add the flag for userCapture here please, as I don't think all browsers default it to false
Just the whitespace, and this is good.
let's change the `custRect = null` to `rect` and execute the else branch when rect is not set (`!rect`)
@kellyredding - "against using target settings" wording, probably wanna drop the 'against'
```file = @bucket.files.create(:key=> 'other-name', :body => 'pdf_content')``` is unecessary. Taking it out
odd that rest model uses hamcrest
This library depends on the CoreText framework.
what about:

def sniff_date(datestr):
    for f in ('%Y%m%d','%Y-%m-%d','%Y-%m-%dT%H:%M:%SZ','%Y-%m-%dT','%Y/%m/%d'):
        try:
            return datetime.datetime.strptime(datestr, f)
        except ValueError:
            pass
I'm storing these things as variables because it should save a method call to mustDo which is a lookup in a map. 
Is that correct?
See updated commit that adds the check for this and updates to display "Manage Environments" with a direct link to the current organization.
Does the 'if AppConfig.katello?' fencing need to be here or is it safe to call if no pulp or foreman exist?
The 'releaseVer' value is added to the system json in the call and is not part of the system itself.
String is probably better then :undef
This way is used everywhere in KnpMenu because PhpStorm 3 does not support use statement fully in phpdoc (it looks at them when generating the phpdoc but not when reading it), and I wrote the library using PhpStorm 3. I think the version 4 fixes it but I haven't switched to it yet.
and anyway, changing this is out of the scope of the PR as it affects the whole library
Why no underscore? Do we expect people to call this? Also the name is terrible.
Yeah right :(
somehting -> something
Minor: why not just call the argument ``x``?
This is currently always taking the *first* entry that sesame gives, right?  So even though it might match both NED and Simbad (with different coordinates), it'll give whichever comes first in the file.  Maybe you should make a way to choose which one if both resolve the name?  Like a preference-ordered list somewhere (as a configuration item, at the risk of sounding repetitive...)
Bitcoin-Qt already uses the generic Bitcoin icon, so it makes sense to provide at least a little more detail in the tooltip IMO ;)
Ouch ^^, will be fixed later, I'm off now for a few hours.
Position 1,1,1 is "magic" in FetchInputs to refer to the memory pool. Otherwise, it will try to find it on disk
BTW this <= here is interesting.

hSocketMax is the *maximum* socket number. Which means that, if it is 0, we still pass 1 into select (which  has a parameter "number of fds", not "maximum fds"). 

So what happens if there is nothing to do? hSocketMax will be 0, however 1 will be passed into select, even though no fds have been set with FD_SET.
I prefer NotFound as well. It means fewer exceptions are required and more accurately expresses the situation.
I went with four o's to match the existing convention in the README, but I think five could really work here.
Heh, a very tiny note that you've used "shoulc" instead of "should" in some of these instances. =P
These changes are not related to the test, but I think they can be also committed.
> this list of possible rev sounds like the right approach to me. on
> creation we would have to cicle this list until we find the rev that was
> used here.
>
> this can also handle multiple rev attributes for the same type of
> parent. but in that edge case the collection would still need to specify
> the rev so things can be rendered. what exactly is the type of the
> parent used for? to infer the right rev to use? maybe we could reduce
> this to a list of rev to check and if multiple the collection must
> specify rev as well? or the child could specify a default rev. listing
> all parent types in the child sounds unflexible to me.

I have to say, the longer I think about it, the more confusing it 
becomes. I mean, when we know the rev attribute, we can get the parent 
identifier and thus the parent object from storage. The question is, is 
that enough to determine the type that should be used for the parent 
(which would be relevant e.g. for the minimum/maximum number of allowed 
children)?

But on the other hand, even if we have the possible parent types 
available as well, what do we do if each of the relations uses partOf 
and our storage object would theoretically work with each of the types?

AFAICT, in plain createphp none of this would be a problem, but I'm not 
sure how this would fare with the storage layer. Maybe the different 
relations need to be stored in different formats.

>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/flack/createphp/pull/28/files#r1960139>.
>
wat als de talen anders zijn?
This is fairly dirty, but had to be done because Spoon gets loaded in autoload.php (where it belongs). This means the moment our container is initialized we would no longer be able to overwrite those constants with the app/config/parameters.yml values. By not setting those constants in Spoon, we can.
If `show` is TRUE, is it run and displayed but commented out?
If it's FALSE, then is it run and not shown at all?
Nope, upstream still has `file(`: https://github.com/dottedmag/path.py/blob/master/path.py#L641

We could update the file, although there hasn't been an actual release for some time. That would be a separate PR, anyway.
Because `mv != git mv` ?
no, the code [is here](https://github.com/ipython/ipython/blob/master/setup.py#L200).  What's the syntax for an 'all' target that cleanly includes the others?
Semicolon? Braces. (Just trying to avoid confusion :) ).
please add more tests

more than one { }, it been a object, missing in context
My spacing from that previous pull request was off again? Are you using a formatter to fix that?
Thanks!  ok, yeah, I'm caching those now.  I had some tricky problems upgrading to Django 1.4, so I'm holding off on that now.  But made @@@ comments for it for when we do upgrade.
It can return `None` too. 
Which appears to lead to `return LegacyThrottler.IGNORE` on line 274
Sure, good point. Done in fe404a2.
typo: "Confirm your new password by entering it here."
Yes we must have the .crn one in refs so its downloaded from correct url etc, but the "internal" name .dds injected into the Ogre material content.

Ogre is very picky with this. I also assumed we could load .crn named texture into Ogre as DDS and ref to the .crn in the material. But if this is done Ogre will throw exception each frame "cannot use texture x not supported image format" etc. So we need to lie about the .dds extension into the material file. This is unfortunate and ugly, my main problem with this whole code.
Got it)
still not implemented
I've made the change after merging.
ubuntu php package don't show configure command options in phpinfo, dunno if sigchild is enabled in repo package but you can't know it with this method.
For reference there is also another syntax `git push tobion +branch_name` which also forces the write.
@fabpot how do you test this? on your local machine?
what about ``-webkit-linear-gradient`` (for Safari 5.1+ and Chrome) as the syntax you used here is the old Webkit one, used by Safari4 (older Webkit builds) ?
and what about  ``-o-linear-gradient`` for Opera 11.5 and 12.0 (12.1 supports the W3C syntax) ?
This should be refactored in the same way than https://github.com/symfony/symfony/pull/4862
There's a lot of these sorts of lines.  Could we collapse them all by having a $this->request property, and then if we actually care about a difference in the interface for it we can instanceof at that point?  That would be fewer of these conditionals lying about.
How about we leave this for now, but remove it when we get OAuth workin?. I should note that the old way of storing a token was just as insecure as this, as the token allowed essentially the same access as a password.
in general you want to avoid type(foo) == concrete_type and instead use isinstance, e.g. isinstance(classifiers, list).  of course, there are other iterable things that are not lists, so to be fully compatible, you might want something like:

```python
def maybe_list(value, expected_type=str):
  from collections import Iterable
  if isinstance(value, expected_type):
    return [value]
  elif isinstance(value, Iterable):
    real_values = list(iter(value))
    if not all(isinstance(v, expected_type) for v in real_values):
      raise ValueError('Element of list is not of type %r' % expected_type)
    return real_values
  else:
    raise ValueError('Value must be a %r or iterable of %r' % (expected_type, expected_type))
```

then in several places in twitter-commons, we should just be doing, e.g.

self.classifiers = maybe_list(classifiers)
I think this is only on the initial photos, like background photos and the default profile pic.  All users need access to those.
@jtessler , I would say try one of these and let's see how it would work. It would be better than the current model I think.
I forgot to add copyright.  Is it too late?


//  Copyright (c) 2012 Coffee and Power Inc. All rights reserved.
We have to track if the user has ever logged in so we stop omitting the name validation post login.
backpath -> Backpath
Maybe something to phase out later?  I'm keen to make this transition as easy to adapt to as possible for apps that embed OIIO.  Those that are already using a lot of references to OIIO_NAMESPACE should not suddenly stop working, I think.
i actually dont think we want to specify a default here
Ok, @ebryn.

1) It can be confused to me as Ember user, i usually use mixing to share behavior.

2) do you want me to do a clean pull request with your suggestions?
This (and below) should probably be Ember.Route.transitionTo, right?
I'll fix that when I process this.
I'm not sure to understand why you need that instead of calling a dedicated method by yourself?
ok, thanks a lot, I try to remember for now on
nit -> space after the `,`
I am fairly sure ttabuert's technique here is the same used in gallery/music (and I stole it from there for calendar) if that makes a difference.
This is a former change. I'll remove it.
Nice catch! fixed
Points de suspension = un seul caractère (…), sans espace avant.
Casey and/or Josh will probably wordsmith these anyways, but the phrase from the wireframes for failure is "Send Message Failed".  For success, I think "Message Sent" is probably more likely to fit in the allotted space.
Just to be consistent: I think we should use

```css
[role="tablist"] > [role="tab"]
```

because we could use another HTML markup than lists, and because the validator requires the `[role="tab"]` element to be a direct child of `[role="tablist"]`.
You don't need to get displaying `frame` here. You can just use `if (origin == WindowManager.getDisplayedApp())` where `origin` is previously mentioned `evt.target.dataset.frameOrigin`.
Never mind, I see what's `children` means :)
oooh, i like that.


On Fri, Dec 7, 2012 at 1:55 PM, Nic Pottier <notifications@github.com>wrote:

> In smartmin/views.py:
>
> > @@ -681,6 +681,20 @@ def get_is_active(self, obj):
> >          else:
> >              return ''
> >
> > +    def render_to_response(self, context, **response_kwargs):
> > +        """
> > +        Overloaded to deal with _format arguments.
> > +        """
> > +        # is this a select2 format response?
> > +        if '_format' in self.request.REQUEST and self.request.REQUEST['_format'] == 'select2':
> > +            json = dict(results=[ dict(id=o.pk, text="%s" % o,) for o in context['object_list'] ])
>
> No need to change but one pattern I've been using is:
>
> if self.request.REQUEST.get('_format', 'html') == 'select2':
>
> Just a bit simpler and deals with the default case.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nyaruka/smartmin/pull/23/files#r2347476>.
>
>
I'm pretty sure these headers are set directly in RAD via the test client and not necessary. I'm going to guess that this change is to be nicer for http_spec. I can definitely get behind it however.
Just implement Matcherinterface directly, as predicate matcher is surely not basic :-)
I'll handle that after I rebase.  Hopefully a heroku deploy will let me look at the output so I can catch that stuff for myself.
Changed in this commit:-

https://github.com/skyluc/scalatest/commit/71ef710745f16d6afa2497291496e4c45479c3f3
got it, so you're suggesting we keep response type agnostic (flashes/messages work well for html, but not json)
Eliminate `env_vars` and just do `return {'MY_IP_ADDRESS': public_ip....}
Will up updated when app-manager is merged in.
Don't use quotes for object keys, format objects into multiple lines for better readability (e.g. like options).
``if (strpos($table_id, 'view-') === 0)``
`function write` should be changed to `function writeIf`
Then you should either:

- stop the function as soon as you know this post doesn't exist in an archive
- get the path only when you know you have to get it, since there's a valid value

Did you check what the post object contains?
shouldn't this be filled with item.title?
I don't think we should be adding tests with actually wrong results -- this is obviously not the correct behavior.
Let's rephrase the message a little... 

"No keyspace directories exist in configured cassandra data directory.  Unable to capture snapshot."
I like factoring this out.
missing ``is`` before ``available``
In other words:

```
input[type="checkbox" binding:click=@something]
```
A lot of these libgc files have extra whitespace changes in them.  Please clean these up to minimize the diffs.
why you don't use the coffeescript?
Ok cool, I can see it's more straight forward. 

I think it was mainly that I don't think the 'business' logic of what competitions to display on this page should be stored in the view and really belong in an Array in the controller
In fact not overridden anywhere here, so perhaps this should be a separate pull request with justification?
This one should have been left out of the repository
Not super important but maybe we should have an pref with max number limit.
That seems fine.
I think we should read files async.
We should rather have a macro cast for that like:

```
res = AMQP_RPC_REPLY_TO_CAST amqp_simple_rpc(...)
```

And then set `AMQP_RPC_REPLY_TO_CAST` to `(amqp_rpc_reply_to)` if != Windows
Fixed...now
Maybe the `@see` should be after the description, and before the `@param`/`@return` statements
is it necessary or is is it double with the fixNamespaceDeclarations() ?
Its not, I tried that. For some reason is Hash mot available at this point.
Changed in #bef6bee1, is this the way?
Also fixed unnecessary #dup
I think this would be better described by: `only allows Socket constants as symbols`
I don't see this method in the class, and looking at the tests, this line would never get exercised. Can you please test this permutation?
@EvanDotPro I just remembered that in this refactoring I had moved the setTranslator (and other) methods into the Helper\HelperInterface, since the base AbstractHelper contains these methods (so all helpers would have them). Would this TranslatorAwareInterface still be needed? Or was it wrong of me to move those methods into the AbstractHelper? I had consolidated the translator methods into AbstractHelper since there were a handful of helpers that needed them.
Mmm, this change the Exception from Stdlib to Eventmanager
is not necessary import this because there is in the same namespace
CS, abundant whitespace
Suggested CS is to keep the first condition on the line with the opening brace, and put the operators on the next line:
```
if ($x1 < 0
    || $y1 < 0
    || $x2 < $x1
    || $y2 < $y1
```
What is this? !! = true?
I agree, but I just moved this code from `CldrTest` to `CldrCachedTest`. You can fix that in new PR ;)
The Ruby way:

def get_catalogs_from_matched_description_patterns
    @descriptions.select {|d| !d.catalogs.empty?}.first
end

Not it doesn't deserve its own function...
Huh, I put the same thing in on the actual commit...
I would just pass the original settings object.
Decided to call this something different, --name for naming the instance
i've copied/pasted the test above, anyways I fixed it now.
Attempted to switch, things started looking odd though, I'll keep that in mind for the future though
Facebook 対応と含めて、 `og:url` あたりは自動で入るとかするようにしたいところ
Could you attach this callback inside the `Connection#connect` method? As a general rule, my constructors are kept as dump as possible, and this is where all the other Protocol event handlers are defined.
I think that testing that the structure is what we think it should be is good. I also think we need tests that make sure that it works. IE now we can have a null bag OR an empty (but not null) bag. We should test this.
That could work - in which case, I think we should use a different class of exception for the detect_server_error! exception.  Unless we assume that a detected server error should always show up as a 500.  I think UnexpectedResponse should always be expected to indicate the actual response.
It appears as though the above two lines aren't used.
Yep. I don't know why, though. I used the django serializer to export a datetime to a JSON file and used that format for all the datetimes in our fixtures.
The /b/ part makes  things a bit more complex. This is a stop gap fix
On second thoughts, we should probably check that the build number is a sequence of digits:

    pattern = re.compile(r'(?P<version>[^#\s]+)(#(?P<build>\d+))?')
Just checked it is a property, popcorn extends it
Can you move the sort button for Date so it comes before the hit counts logic? It wasn't in the Google Code issue, but it is a bug related to stats navigation, so it would be awesome to sneak that in here instead of making a new issue.
Not a typo. I'm building the expectation the same way the method that its testing does:
https://github.com/reenhanced/audited/blob/master/lib/audited/auditor.rb#L58

What do you mean by hidden failure?
Although I guess this file isn't linted :)
так можна
Can you remove this method since it's commented out?
@ohadlevy, since we are in module API:V2, the view rendered by default will be API:V2 which is what we want.
Why you changed the sourcing way?
I think `fnameescape()` has problem.
For example, `:edit fnameescape('bang!.txt')` opens `!.txt` on `bang/` directory on MS Windows.
Because, `fnameescape('bang!.txt')` makes `bang\!.txt`.
`_.each(['itemContext', ... ], forceMissingProperty, this);`
Where does this now happen?
Yeah, that does sound better.
I agree.  The "part of" part can be a little confusing.  I was trying to build on the language already in the exercise to make what's going on a little clearer.  Ultimately, yes, I think writing this as 2^3 would be nice.  I'm not sure off-hand what the prerequisite exercises are on this.  For younger students something like this might work better than the exponents.

There were a couple other ideas I had, but shipping before perfection and all (and I really want to work on that angle addition postulate exercise ;-) ).  Might want to try this to see if it helps and if not, someone (possibly I) could work up a better explanation of the whole divisibility stuff.
Cleaned up with inject.
is this for loop just for iterating over the pool list, or should adjust be accumulating?
different variable, ```mediaType```  and ```mimeType```

maybe rename mimeType to mimeTypeOfFileExtension? it's the parsed type returned from the jetty file extension->mimetype class, same as you had in there before.
Согласен, так, наверно, лучше будет. В таких случаях я должен исправить у себя и сделать ещё один pull request? Прошу прощения, с github ещё толком не общался :(
чего не хватает?
I answer in pull-request comment: https://github.com/harleyttd/auditable/pull/5#issuecomment-4828850
That makes sense to me. Clean it up first so you're in a known state.
Don't we always want to follow redirects?
I'm not sure if Simon would be able to create sentences this long.
The order didn't really have an impact on this decision but is nice to have. A list of values also made more sense as an Array.
You should not need <code> inside <pre>, should you?
こんな単純なバグを生み出すなんて！！！！！
и ещё раз: х - это процент. То, что у вас названо переменной percent - на деле оказывается количеством ячеек на замену, но никак не процентом.
этого не было в тексте задачи. некоторые выносят в main.m, некоторые в одтельный файл, некоторые оставляют в том, где определен основной класс. я не думаю, что в рамках этой задачи это критично.
Если они одинаковы => изменений не было => не было мутации для этого нуклеотида => его можно мутировать, что потом и делается.
Значение должно **измениться**. На мой взгляд, этот глагол можно понять корректно только в одном случае, когда А стало не А, а любой другой буквой.
а зачем вам вообще это фактори? Это же внутренняя таблица связка, ее не надо тестировать
This change has nothing to do with commas.
Don't use camel case, call it QualityDict or QualityMap instead.
mildly surprised you didn't put a semicolon here :P
Personal habit of pre-editor type inference :) Will change.
Might be a better option to rename `Commands:` to `Triggers:` which will cover everything. Thoughts?
After a closer look, the shared gadget is immediately placed on the user's iGoogle homepage. There is a separate process to add gadgets to the iGoogle directory. This process is more involved and is evaluated by Google before being published in the directory. If it doesn't meet their standards, it is rejected.
这个开关在`project.clj`里面已经打开了，不用自己在手动设置了
Hmm. There's no body to the `using`. Should it just look like this?

```C#
using (Proxy.git_branch_create(repo.Handle, name, commit.Id, allowOverwrite)) ;
```
yeah, that's what's been ground into me by my mentors for years, heh.  wasn't aware that it wasn't necessary in sets, but I think I'll keep the habit for clarity's sake.
Ok, I'll try to use what you suggest instead...
in the US or np.arange(50, 50, 300) if you're in Europe.
Really, new method was part of existing code? Or am I too tired and get it wrong?
Would be nice to check that you are getting back the expected results
Agreed, I'll see how best to refactor this.
secret number or string parameter, although it is obvious but more proper
I prefer to capitialize `form component` (it should become `The Form Component`)
this is wrong. The doc is now on ``docs.doctrine-project.org`` so you should link to it properly instead of relying on the redirection
Actually, since you don't get the error, I'll just merge and fix it on my end.
Haven't checked this yet, but are you sure about removing the `body` and `html` closing tags?
Fair enough, but you've to fix the error then. Also in that case, just to be consistent within this PR, please change the two alias_methods below into aliases.
doing it in the constructor seems a bad idea to me. It makes the initialization of the class heavier (it will also authenticate if the client is created to be injected as a dependency in another service without being actually used). It would be better to do it lazily for the first use.

and I think you never authenticate anymore if ``'always'`` is set to ``false``)
¿Creés que esté bueno remover las notas? Me preocupa que no se esté perdiendo ningún texto asociado que sea importante.
Mas o menos, me parece que voy a tener que escribir los comentarios en español.

El tema es que no estoy seguro de que pasa si se agregan elementos mientras se está corriendo la migración, entonces me gustaría recorrer los items de otra manera. Pero creo que ahora mismo eso no es un problema.
Needs refactor.  it's fine to have two separate function promote-content and delete-content, but they do exactly the same thing, the only difference is a boolean, changeset-type.  So they need to just call a function with different arguments.  Pull out the contents of these into a single function.
again, use "for" as above.  No need for mapcat when each result is a list of one item.  Can use "map" or "for".  "for" is preferred over map+fn.
I would refactor it as "pmeta" instead of pm. There's a risk for namespace collision with project/pipeline management which is in the same scilifelab package.
Why this method needs to start with `_`?
Is there anything else you'd like me to do? Or is this good to go as is?
SONIC CLEARED ACT 1
- Fake Availablilty Zone -
~~~clojure
(and (not (empty? coll))
     (empty? (rest coll)))
~~~
But in overall terms Mircea this is orders of magnitude cheaper than remote tasks execution, sending and all. So it is likely negligible.  I admit I was lazy - I wanted to have a list that would be safe for iteration, we could have concurrent reading and writing. There is only one thread adding to cancellableTasks....
It's part of requests and responses

Ben Toews

On Nov 10, 2012, at 16:32, Andrew <notifications@github.com> wrote:

In requests/auth.py:

> +            return response
> +
> +        request = response.request
> +        # initial auth header with username. will result in challenge
> +        auth = 'NTLM %s' % ntlm.create_NTLM_NEGOTIATE_MESSAGE("%s\\%s" % (self.domain,self.username))
> +        request.headers[auth_header] = auth
> +
> +        # we must keep the connection because NTLM authenticates the connection, not single requests
> +        request.headers["Connection"] = "Keep-Alive"
> +
> +        request.send(anyway=True)
> +        response2 = request.response
> +
> +        # this is important for some web applications that store authentication-related info in cookies (it took a long time to figure out)
> +        if response2.headers.get('set-cookie'):
> +            headers['Cookie'] = response2.headers.get('set-cookie')

I might be missing something, but where is the headers dict defined here?

—
Reply to this email directly or view it on
GitHub<https://github.com/kennethreitz/requests/pull/934/files#r2091869>.
maybe the git part should've gone here?
This can use `-copy`.
On 06/01/2012 08:11 AM, Michael Droettboom wrote:
>> @@ -2079,7 +2076,7 @@ def axvspan(xmin, xmax, ymin=0, ymax=1,
>> hold=None, **kwargs): # This function was autogenerated by
>> boilerplate.py.  Do not edit as # changes will be lost
>> @autogen_docstring(Axes.bar) -def bar(left, height,
>> width=0.80000000000000004, bottom=None, hold=None, **kwargs): +def
>> bar(left, height, width=0.8, bottom=None, hold=None, **kwargs):
>
> Ah.  It looks like the new values are better anyway.  We may want to
> keep them.  @jdh2358, @efiring... and others who understand the
> boilerplate generation: what do you think?

I noticed this change here and in some earlier PRs, but since the new 
version is clearly nicer, I did not try to track down what accounts for 
the difference.
I have always interpreted that line in PEP8 to mean any operator like "if", "for", "else", in addition to operators like "+", '/", etc.
BTW: I wouldn't oppose adding this README file if it contained only a link to the online documentation.
Use triple equals here
occured
You're right. I meant to have web uploads below canned attachments. Will fix shortly.
these lines were previously correct, the asterisks should be aligned vertically
I'm sure the tests are failing now. Maybe you and Dave can help tune those babies up, that'd be a great way to get familiar w/ the preprocessing steps
extra ending <br/>
@arnodeclercq use single quotes here
Why is there 2 tabs here?
Should you be able to do write

new QuestionTypeConstants()

?
So get_kernel_matrix allocates a new matrix every time it's called? Oops sorry about that. I'll try to use valgrind to look for memory leaks. Does dsymm have a performance advantage over dgemm?
please use the REQUIRE macro, i.e. ```REQUIRE(feats != NULL, msg);``` for cases like this
But you're already *inside* an onmatch for a single DOM element with the class '.ss-tooltip'. Its bad practice to "break out" of that selector scope into other DOM elements, and a performance issue. If you have 3 '.ss-tooltip' elements, it'll call the inner loop function 9 times in total.
No, because this is just checking that the parameter is not "q", because "q" has a special meaning.
This looks like duplication with the context of the `after_row` functionality. You should reuse the same context. That way we can make sure, that both features have the same information available and we don't miss a spot when changing the functionality.
Please read through this carefully. I convinced myself that it's right, but I'd like another set of eyes.
I pulled this number out of the air -- we could make it public, or your better idea goes here?
Do you want to protect against invalid replies?  If a peer sends a reply of the wrong length here, your stream will be disabled because the exception is uncaught.
$key is quite confusing cause we have key in params array too. Maybe use $keyId instead ? (This same for remove and show)
I don't think it breaks execution though.  alert is good :)
StringBuilder response = new StringBuilder();
use response.append() instead of +=.

String += is really slow.
Should you be closing the socket when the received message code is unexpected? Not clear what the proper behavior should be here.
Wars nicht besser das als Query mit $1 abzulegen? Damit es einheitlich bleibt.
That's not true. It would be the same under ARC to do ` [[NSData alloc] initWithBytes:output.bytes length:numBytes]` or `[NSData dataWithBytes:length:]`. It would return the value autoreleased in each case and do the usual `objc_retainAutoreleasedReturnValue` dance in the caller.
Maybe if the following:

```javascript
this.on('event', callback);
```

where the callback variable is null or something... I could see that happening.
уже обсуждали, необходимо создать разные контроллеры для обработки заказа и пользователя.
Kan vi bruke `require apache` i stedet? Så slipper vi å dra inn hele HDO-backenden.
can you fix the extra spaces before the equal sign?
`throws Exception` should be avoided. Ditto for next 2 methods.
Ah...fair enough. Oddly enough, I originally used that very syntax. That's what happens when one over-complicates a simple thing :)
Hm, wouldn't it be better to have string "23 free places"? Can you format string like that?
This image source is probably not found. :-) Alt should be a translatable string.