labofsahil/github-event-dataset-2012 huggingface dataset:
But since ret is now absolute, there is no guarantee that next will have RBLOCKS_OFFSET_MASK's size, so the OR below could corrupt the pointer?
Well, maybe. I tried that, but the URL for the localized title didn't work when I did it that way. If we were to do it that way, we should also localize the titles displayed in the left column and in the text of the links that those two lines control the URL's for. I'm not sure how hard that will be to do, but I can look into it. I thought this would be a good start though.
And 0 means disabled ?
Could you also add the server name? 
"Official McForge Server" | Version x.x.x | *url*
I pushed up the Graphios mention along with a few other tools to the upstream Bzr repo so you can close this up
I have the .gitignore file now in all my local repos, as well as GitHub.  So, in theory, the next time a PDF file is created via LaTeX, it should be ignored.  Right?

On Feb 21, 2012, at 3:43 PM, Jason Grout wrote:

> I'm not sure how SourceTree works.  You can check to see if you have a .gitignore file on  your local computer, though.  If not, can you "pull" changes from github?  On the command line, you'd just do `git pull`
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/dcernst/IBL-IntroToProof/commit/3dbcc2380f35c4db6c5f5035358258bd6b762e2a#commitcomment-993189
Yes! Copy and past da depressão :)
This code looks strange. Consider re-factoring.
Jump on it Subv.
@jmikola this commit does not add the MappingRegistry, only the tests for it
ilyen tábla nincs :)
lemaradt az 's': ccrequest_to_courses vs ccrequests_to_courses

ezt próbálta meg kifejezni azzal, hogy nem találja azt, amivel bűvészkedni szeretnél :)
Thanks for the tip @betamatt :)
On 6 Jan 2012, at 16:16, Peter Boling wrote:

> I have mad maddening problems with daemons.  I will look into foreman + upstart.  Thanks @betamatt
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/collectiveidea/delayed_job/commit/46533d64383bdec9ac0463c9d5e8a64f03f54d2c#commitcomment-844071
Game & Watch 2 requires 1/2 of clock freq for perfect repro.
Also, here we have applied changes that are very specific to Sacramento Insights to a module that has nothing to do with Sacramento Insights.

A good long-term strategy is to create a hook here that allows completeness data to be altered by other modules.  Something like this:

```php
<?php

// We will call our hook 'hook_content_complete_alter_data()'

foreach(module_implements('content_complete_alter_data') as $module) {
  $function = $module . '_content_complete_alter_data';
    $access = $function($node, $fields_final);
    if ($access === FALSE) {
      return FALSE;
    }
}
```
Good riddance to bad code! ;-)

I do, however, think that we will need to break `GridFieldConfig_RelationEditor` into `GridFieldConfig_HasManyEditor` and `GridFieldConfig_ManyManyEditor` - because HasMany doesn't generally need support for link-to-existing.
- The +10/-10 buttons don't disable properly
- Needs unit tests, but I suppose you know that, and just committed something to get Jeremy onto styling :)
- The concept of "ten pages forward/backward" should be less hardcoded in comments and variable names.  Ideally its configureable, but at the least it should be one variable in the local scope, as opposed to all over the place. Its also not accurate, on the second page the "backward" link will just skip 1 page back, not 10. How about calling it a "skip link", and the actions "action_skip_prev"/"action_skip_next"?
This isn't for 3.6 only, it makes everything work on everything before 3.6 as well (tested on 3.0, 3.5...). Could Konstantin please accept these changes?
Sorry my mistake. This is different to the [released 2.4.7 version](http://www.silverstripe.org/assets/downloads/SilverStripe-v2.4.7.tar.gz)
Poprawki znakowe.
"disappointment" intriguing comment ... are you talking about gae itsel? or xsbt-web-plugin?
so u make cp.sh more better.well thanks
tried to change unknown author commits (bad git setup).  some worked, some did not.
kk, I looked into the change on p5p and now I agree with you. :)  (Reference:  http://www.nntp.perl.org/group/perl.perl5.porters/2012/02/msg183396.html )
Alex beware of being vaporized! :P
Ok. Thanks.

 -- John

On Feb 15, 2012, at 12:23 PM, Drew Conway wrote:

> I didn't actually reset the head, I added a new commit that renamed the file.  So everything is fine.
> 
> 
> On Feb 15, 2012, at 12:19 PM, John Myles White wrote:
> 
>> Could you check this didn't kill my other changes? This could in theory affect both file names and directory layout.
>> 
>> -- John
>> 
>> On Feb 15, 2012, at 12:08 PM, Drew Conway <reply@reply.github.com> wrote:
>> 
>>> Rolling this back so that the file names for chapter 1 are consistent with the book.
>>> 
>>> --- 
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/johnmyleswhite/ML_for_Hackers/commit/3a7a3d52b562b0738de05d23c01dcf888ce34e70#commitcomment-970208
>> 
>> --- 
>> Reply to this email directly or view it on GitHub:
>> https://github.com/johnmyleswhite/ML_for_Hackers/commit/3a7a3d52b562b0738de05d23c01dcf888ce34e70#commitcomment-970251
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/johnmyleswhite/ML_for_Hackers/commit/3a7a3d52b562b0738de05d23c01dcf888ce34e70#commitcomment-970275
I like to bracket things, like;

Log.i(LOG_TAG, "Creating record -> GUID map.");
<stuff>
Log.i(LOG_TAG, "Creating record -> GUID map. DONE.");

Makes sorting through logcat easier.
```haskell
splitEvery 0 _ = []
splitEvery _ [] = []
splitEvery i xs = a : splitEvery i ys
  where
    (y,ys) = splitAt i xs
```

По ссылке почитай чуть дальше (во второй ветке #ifdef), там интереснее.
Соответственно, как только в рекурсивном вызове потребуется ys сравнить с [], сразу же придётся вычислить и y.
А в варианте с let (y,ys) = (take i xs, drop i xs) ничего не мешает take i xs оставаться невычисленным.

По последнему пункту согласен. Однако. интересно бы посмотреть на олеговские iteratees и раздавать данные по частям через Concurrent.Chan.
y es que cuando encontré la opción ignoreExtraKeys no me gustó el 'ignore' . Cuando me metí en la cama le estuve dando vueltas y no me gustó la solución del configurador, la tuya creo que es mas correcta.
au niveau de l'indentation, tu peux revenir en arrière d'un cran ou deux
I don't think that's a good idea to flatten things like that.
Se der merda, voc vai resolver.

On Wed, Feb 29, 2012 at 9:14 PM, Pedro Henrique Passalini Soares <
reply@reply.github.com
> wrote:

> quero ver oq vai acontecer se alguem gerar um scaffold agora, com duas
> gems de form.... ;P
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/douglascamata/Rick-Rocks-Academics/commit/2051dac6f31a7ab08c1a971e3de99f092a05f7c5#commitcomment-1028840
>



-- 
Douglas Camata
Graduando em Cincia da Computao (UENF)

Blog: http://blog.douglascamata.net
Github: http://github.com/douglascamata
Twitter: @douglascamata <http://twitter.com/douglascamata>
<http://twitter.com/douglascamata>Skype: douglas_camata
-----------------------------------
Linux User #509211
The method `getConstrainedConstructors` is missing
This is a note on Devins commit to the README file.
I'm working on getting the Grail project imported and opened... having some issues atm.

Also, wondering how this 'comment on commit works
Three should be subgroups as we discussed earlier
Version with single read and single write replicas don't come here, so only db->split modification is necessary
why fully qualified name here? why not import as we normally do?
is this pasted here verbatim?
We never use relative imports, they are confusing and order-dependent
Nope, because that’s set only during send(), and the point of this exercise was to make something which also works outside of normal remoting calls.
so, hypothetically, if netty catches ThreadDeath on the I/O worker, our thread pool stops working?
no name?
I only noticed because tons of tests failed otherwise ;-)
nice, will try that here
sounds right.

RESOLVED
I'm working on this merge now.  When it is done, these comments may loose their anchor in the pull request.  When it is all merged forward, I think everything you don't like will be gone and if now we can take a second look.
Compared to xz.info rev 1 in our 10.7 tree, you dropped the dependency on pkgconfig (>= 0.20-1) but made no change to the way this package is built. It seems unlikely that this is correct -- most likely the result is a violation of our build invariance policy...
Also the standard deviations needs to be converted from base 10 to base e. Maybe before returning stddevs you can do:
stddevs = np.log(10 ** stddevs)
return stddevs
```
gtab : GradientTable
    Measurement directions.
```

or something along those lines.
Done. Actually there were 7 :)
Yes it is used in line 518. 

I find it most useful to be able to create users in tests, like all the other objects. It's the same principle as all the rest in create_test_data, is a basic principle of OO programming.
Move declaration to where we do the setup, then we can avoid one ifdef
Also, why is it bCustom instead of mCustom or just custom?  We don't use Hungarian notation, so variable types should not be included in the variable names.
Also there's nothing stopping us from increasing the required version of Requests. So if there are other features that should be taken advantage of that's an option too.
v0.1.3 två gånger? Känns som att du missat en ++
Can we talk about this?
Yeah, it would also make it inconsistent with the rest of the class... This was more of a interrogation than a request.
i'll stop commenting on these to avoid spamming everyone :P just check if there are more
This is inside an Actor.
Oddly enough, Xcode told me it couldn't find the variable `_secure`. Weird.
It worked when added back.
This menu doesn't match the built-in ordering.
Use the new keyed subscript syntax: `_stack[0]`!
Use boost::integer_traits<int32_t>::const_max or whatever instead of INT_MAX. This doesn't use macro and also INT_MAX depends on size of int and might not always be 2^32.
Needs
#include <boost/integer_traits.hpp>
Doh, that was braindead. Fixing and adding a test for empty lines.
格式：开头写类名和函数名而不是只有类名
as @groups
please add "newInboundMsgBuf" as message of the NPE.
shouldn't  "%node.config" be here?
Thanks, the symbolizerField here is actually a PointSymbolizer widget which provides an interface for the user to configure how the feed points should be displayed on the map - [screenshot](https://a248.e.akamai.net/camo.github.com/cfeffdc7616d47f8891fd957e39743bb7549d8d4/687474703a2f2f692e696d6775722e636f6d2f356d7076622e706e67)
You should clarify that this is for overriding purposes only.
I think you can use safe_join here.
Notice that since those are class methods, they are not really being private here. You need to wrap them inside a class << self block.

    class Foo
    private
      def self.gotcha!
        1
      end
    end

    Foo.gotcha! #=> 1
@davejachimiak - one reason for the two-way indexes is that at least some DBs can only use multicolumn indexes if the given values are part of a leftmost prefix. See here for more detail:

http://dev.mysql.com/doc/refman/5.0/en/mysql-indexes.html#id593580

TL;DR - only putting one means that either `t1.t2s` or `t2.t1s` doesn't get to use an index at all on MySQL.
i think this example is incorrect. `.first()` would return the `<ul>` element.
typo (or maybe a new subatomic particle for the LHC to seek out?)
It's not clear to me why this is correct.

1. How do we still know there was an error after we change the type of the tree?
2. `sym.tpe` is a code smell: usually you want something like `qual.tpe.memberType(sym)`

I think something like this would show the problem with a straight `sym.tpe`:

```
class Foo[T]
class Outer[T] { class Inner extends Foo[T] }
val outer: Outer[Int]
val y: outer.Inner // need to take `outer` into account to realize this is a subtype of `Foo[*Int*]`
```
which is why I put this comment with the reference in, so that the code can be “normalized” as soon as that issue is fixed
To that end, I will create a function for getting the raw function pointer using the Python code: ctypes.cast(func, ctypes.c_void_p).value.   This is a bit un-pleasant in C and I would rather replace the code with something more direct (like an API that is supported somewhere else --- perhaps in NumPy).
Again needs to be checked/fixed for all 4 methods.
which commit fixed this ? I still see the invalid syntax here https://github.com/spree/spree/blob/1-3-stable/core/app/views/spree/admin/variants/_autocomplete.js.erb#L16
(Not related to this pull) Huh, that's a little odd.  I guess it keeps things simple, but I could see some use cases for producing something abstract or implementing an interface.
All 3 fixed.  Will re-request pull.

On Tue, 21 Aug 2012, Aaron Meurer wrote:

>> @@ -182,6 +184,8 @@ def eval(cls, arg):
>>          if i_coeff is not None:
>>              return S.ImaginaryUnit * C.sinh(i_coeff)
>>
>> +        #return cos(arg-S.Pi*S.Half)
>
> Why is this here? It should either be removed or more explanation given.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sympy/sympy/pull/1502/files#r1430601
Added these too.
Well, right now it looks redundant. But we felt that we can later add more functionality to the 'set' method i.e. having it compute the potential energy due to gravity or a constant force or a spring force, which are pretty standard. SO we felt that it could be useful to have a method to 'set' and then have it as a property.
ditto rewrite -- do you mean Add(y, x, z) or just Add(y, x) in both places?
Agreed with "return self._to_mpmath(prec)" for "to_mpi" function.
I use `pretty` now, so it looks like
```
>>> print pretty(d.premises, use_unicode=False)                                                                                                                       
{A->A: EmptySet(), B->B: EmptySet(), C->C: EmptySet(), f:A->B: EmptySet(), g*f                                                                                        
:A->C: EmptySet(), g:B->C: EmptySet()}                                  
```
and
```
{g*f:A->C: {unique}}
```
But if the args are not sorted how is the key canonical?
This was exactly my idea when writing the function. The only thing I might change is to enumerate over all the StdMethod instances, however, I'm not sure this is going to change from the usual restful candidates any time soon, so the current approach should be okay.

If there is going to be a version that takes a RoutePattern, and one that does not, what names would you give the two functions?
remove comments for testing purposes like this before you push to github
Comparing with NULL character is twice slower: http://liveworkspace.org/code/2tAgbp$2
But i don't think it's a very critical since both ways are very fast. Note about 10 000 iterations in the performance tests above.
I don't know...I'm the noob here!

Can't someone take over my system and do the (for me so hard) job?


On 27-09-2012 15:59, Alexander Makarov wrote:
>
> In CHANGELOG:
>
> > @@ -20,6 +20,7 @@ Version 1.1.13 work in progress
> >  - Bug #1347: CDbTestCase: table name in fixtures list enclosed into double curly brackets (e.g. 'tasks'=>':{{task}}') didn't worked properly (resurtm)
> >  - Bug #1351: CClientScript::registerMetaTag() now allows to register multiple meta tags with the same set of attributes (klimov-paul)
> >  - Bug #1364: Empty CHtml::$errorCss cause class attribute rendering errors (creocoder)
> > +- Bug #1444: Fixed CGoogleApi::register call to registerScriptFile (mdomba)
>
> Why it's here?
>
> ---
> Reply to this email directly or view it on GitHub 
> <https://github.com/yiisoft/yii/pull/1488/files#r1706959>.
>
newline
```
}
catch (Exception e) {
```
This docstring does not match the code.
Change this to

val += 65_536 if val < 0
They also receive the application
Well yeah, if you're gonna follow good practice. :panda_face:
Thanks for the notice and the fix.
Also, take a look at the way that we express global versions of each maven dependency in the dependency management of the parent POM - no child POM should need to specify a POM version, because the version will always be dictated by the parent (for the sake of consistency across the project).
:dbcommand:`replSetGetStatus`
finish this sentence.

also make it clear that this operation actually copies data from one database to another, and that it's not a simple atomic rename.
don't put the options on the directive line, here. The `.. data` directive, unlike `method` can't really parse these kinds of statements properly.
Tu devrais donc tout changer en `row` plutôt que `row-fluid`.
A comment that the value isn't checked seems worthwhile. The nice thing about doing this is that you'll get diff output when you run the tests:

```
Cloning into '/var/folders/c5/_9tvqbxd5730d8pjq9cmnnyh0000gq/T/d20121102-31924-12824kr/shared/cached-copy'...
--- /var/folders/c5/_9tvqbxd5730d8pjq9cmnnyh0000gq/T/chef-tempfile20121102-31924-an4sn7	2012-11-02 13:34:46.000000000 -0700
+++ /var/folders/c5/_9tvqbxd5730d8pjq9cmnnyh0000gq/T/chef-diff20121102-31924-dm4cim	2012-11-02 13:34:46.000000000 -0700
@@ -0,0 +1 @@
+[:before_migrate]
\ No newline at end of file
--- /var/folders/c5/_9tvqbxd5730d8pjq9cmnnyh0000gq/T/chef-tempfile20121102-31924-hnk770	2012-11-02 13:34:46.000000000 -0700
+++ /var/folders/c5/_9tvqbxd5730d8pjq9cmnnyh0000gq/T/chef-diff20121102-31924-1xvxk2e	2012-11-02 13:34:46.000000000 -0700
@@ -0,0 +1 @@
+[:before_migrate, :before_symlink]
\ No newline at end of file
--- /var/folders/c5/_9tvqbxd5730d8pjq9cmnnyh0000gq/T/chef-tempfile20121102-31924-1kn3lea	2012-11-02 13:34:46.000000000 -0700
+++ /var/folders/c5/_9tvqbxd5730d8pjq9cmnnyh0000gq/T/chef-diff20121102-31924-ra1wle	2012-11-02 13:34:46.000000000 -0700
@@ -0,0 +1 @@
+[:before_migrate, :before_symlink, :before_restart]
\ No newline at end of file
--- /var/folders/c5/_9tvqbxd5730d8pjq9cmnnyh0000gq/T/chef-tempfile20121102-31924-16fk0bj	2012-11-02 13:34:46.000000000 -0700
+++ /var/folders/c5/_9tvqbxd5730d8pjq9cmnnyh0000gq/T/chef-diff20121102-31924-xybfwq	2012-11-02 13:34:46.000000000 -0700
@@ -0,0 +1 @@
+[:before_migrate, :before_symlink, :before_restart, :after_restart]
\ No newline at end of file
```

In the case that a code change breaks the order, you would get a hint about what's going on by looking at this.
In text, please use the capitalisation defined by the project: `PHPUnit`
>I don't see why this should hold up the merge

+1
catch on newline?
look closely
You have extra spaces after the comma in the 2nd one.
Can you put everything into agents/monitoring/collector/ and then include those files here. That way we don't ship collector mode with the zip sent to customers using the agent.
De ce ai pus tab aici? e inutil imo, mai ales că lipsește cel privat (care nu ar avea sens), deci nu e neapărat consistent cu arhiva.
Mulțumim! Vezi că ai lăsat ceva trailing whitespace pe linia asta. :)
These comment isn't supposed to be there at all, code is easy to understand. Still its not a corporate code, nobody will complain.
Hahaha..... you overestimate me
Why would anyone want to call ac.partial.compiler() and send the results to the client side?  `mojito compile views` is meant to take care compiling the views, so that nothing special has to be done in the controller.
Can't look at the method name ;)
belongs in a utils file, in case should be reused elsewhere
Nevermind - appears this is standard in openMRS. You should at least have ```setId``` call ```setBillId``` though. (same idea for getId)
Until we can agree on a standard for this I'm going to go with the author's preference. Easy fix if we change our minds.
旧代码不用了就删除掉。有历史记录可以看到的。
See discussion of that problem here: https://github.com/Theano/Theano/pull/813#commitcomment-1668567
That's my typo fault. I will correct it back to :
return new TimestampType(Long.parseLong(longtime));
This looks good. I'll take that.
IntegrityError already does rollback
Я задумывал, что id у ноды должен остаться без изменений (для упрощения отладки), а поменяться должен только путь к файлу
yes. otherwise node.js' `require` function will be called
WorldBorder model -> ``WorldBorder`` model
"no more available" doesn't read particularly well, it'd be better to say something like "no longer available", but I'm not enthused with that either because it seems accidentally punny.
In my description above (and the thread I linked), what part is not clear?

If you want to parse child elements from the "start" of an element, there's no guarantee that the children will actually be loaded. The worst part is, this behavior is unpredictable. :(

We had this problem in past. See https://github.com/gem/oq-engine/blob/a664af2011194ffa4fd42e1ccd55c2399a89c5d6/openquake/parser/risk.py#L85.
nitpick. Why the value got by iteritems is first ignored, then re-accessed from the dictionary?
```
for imt , gmvs in gmf_dict:
   numpy.append(gmf_cache[k], gmvs, axis=1)
```
Looking into that. Odd that its just the beta function which uses 
gamma/exp etc but the results for those functions alone didn't change . .

The beta algorithm was one I pinched from D or something so I may 
substitute it for something more robust.

On 31/03/12 18:33, Joe Groff wrote:
>> @@ -1010,7 +1010,7 @@ beta(3,1) = 0.3333333333333333
>>   beta(3,-1) = nan
>>   beta(3,3) = 0.03333333333333334
>>   beta(3,38) = 3.373819163292818e-05
>> -beta(3,355) = 4.432854008828962e-08
>> +beta(3,355) = 4.432854008828726e-08
> Why did these results change?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jckarter/clay/pull/251/files#r629972
See notes above
Please, read your code carefully:

"Does your \s match \xA0 **and \xA0 only**?"
"Yes, awesome, **let's assume it matches \uFEFF too** and use \s"
"No, too bad, we'll enumerate **all of** the unicode characters we want to trim one at a time."

What happens if you have an implementation that matches \xA0 and not \uFEFF? It may not be likely but better safe than sorry: let's feature detect for real. Why the need for a weak inference like this?
I would prefer to see more comments in the code overall.  A file like this is small enough that it can be understood pretty quickly, but good to have an initial description as well to provide some clarity.  Especially when this file is so similar to loss.hpp, it would be good to more quickly understand the purpose of the file and where it fits in overall.
We don't need this fix on Windows.
Fixing Fibers is not necessary on Windows.
Yikes, I don't think we want to chown the prefix!
On Tue, Jun 26, 2012 at 04:23:44AM -0700, Alexandre Gramfort wrote:
> @GaelVaroquaux : pyplot and not pylab as pl ?

No, pylab as pl
Ditto, not really understanding why we need `RiakDisabledForTest`
^object's
Non-descriptive string constant for an error code again
I don't think the session store should be tightly coupled with the http module (or request in this case), that's why we have the middleware. This should be refactored out of the session store and into the middleware, so that the session store only handles sessions and not requests
Don't really see the difference, I just don't like seeing empty blocks.
Shouldn't it be 'Aloha'?
Dunno - I'd considered whether the dirty flags being set during the constructor should just be cleared (on the assumption that any "dirty-ness" at that point is bogus).  But, since it winds up causing any observers that jump right in to get a full chunk update, I was concerned that it might be needed-if-not-a-bit-questionable.
This is never used?
how about this name "shouldShowHintsOnKey"
It seems like it'd be best to return the cached data here if we have any -- otherwise, I think there's be weird scenarios like this:
1. Brackets runs, checks for & finds an update, update icon becomes visible.
2. Wait 24h
3. Launch Brackets while offline (e.g. on an airplane)

Result: Update icon disappars even though we know there's an update.  Even once you come back online, the icon will be invisible.  Then, 24h later it will reappear.
I don't see any code that's passing parameters to this function. Am I missing something?
Sorry, forgot to uncomment that for IE testing
That will likely cause conflicts.  The mu4e.texi file states:

    After this, @t{mu} and @t{mu4e} should be installed @footnote{there's a hard
    dependency between versions of @t{mu4e} and @t{mu} - you cannot combine
    different versions}, and be available from the command line and emacs
    (respectively).

So the full package needs to be installed to make sure there are not any version conflicts.
Why do we need to override the standard __eq__ method?
The cast is not necessary, we are not using generics for nothing ;-)
Couldn't it be done with a -exec ?
numeric_limits<float>::max()?
Sites are also using relation database.
```
super(LanguageField, self).__init__(*args, **kwargs)
```

It seems I had the bug in original code. ;-)
No need to initialize `wasSelected` since it's set immediately here https://github.com/mozilla/butter/pull/1396/files#L1R109
Can you just clean up the spacing here? Trying to persist with Popcorn style.
wrong spacing and we could totally use a mixin for this
and hur
because it shouldn't be there. Popcorn options inserts it one for us, so having two would be wrong. I just saw it and fixed it, as it's going to have to get fixed sooner or later for the baseplayer to work.
Let's leave this section in.
`The reCAPTCHA wasn't entered correctly.Please Registration again!`

Don't you figure, the second sentence is grammatically wrong?

`The reCAPTCHA wasn't entered correctly. Please register again!`

But, hang on... tell me why are we using captcha, again? :-/
What happens if you call `connect()` multiple times? Maybe keep a global `$this->connectDeferred`:

```php
public function connect()
{
    if (null === $this->connectDeferred) {
        $this->connectDeferred = new Deferred();
        $this->on('connect', array($this->connectDeferred, 'resolve'));

        $frame = $this->packageCreator->connect(
            $this->options['host'],
            $this->options['login'],
            $this->options['passcode']
        );

        $this->output->sendFrame($frame);
    }

    return $this->connectDeferred->promise();
}

public function disconnect()
{
    $this->connectDeferred = null;
    /* ... */
}
```
comment on why _id and name are diff
Type hint avec DateTime. Et ajoute le docblock @param.
These aren’t needed, they are added by default. Looks good otherwise.
Sorry.
I fix it soon.
Sorry. In my mind the message will always be the entry title.  The notification is for a new download; the title defaults to "Download started" with the message being the entry's title.

Make sense?
Remove throws IOException, seems it is not throwing any
This is confusing. It is usually written on single line:
 %attr(600, katello, katello) %{_bindir}/katello-*

Yes I can see you just copied it from %files katello. Feel free to fix it there as well :)

Beside this ACK.
Will this TODO be addressed as part of this pull request or separate bz?
Yea but do you think I should do this instead?

```ruby
def rules
  {:about => true}
end
```
Yes, I saw that pull-request come through and will use that here.
Umm.  That might've inadvertently snuck in when I was just going through my own project configuration.  I don't like hard-coding names.  TARGET_NAME expands to RestKit here.  Feel free to ignore.
What I mean is that Monolog **never** enforces having ``$record['context']['type']``, meaning this will trigger a NOTICE for most cases (for instance all messages logged by Symfony)
Oh i think this is because of https://bugzilla.mozilla.org/show_bug.cgi?id=739452.
Can you check what happens if you comment all the if ('mozTelephony' in navigator) and if it is true that it is the cause of this bug you can keep your code as if and add a small comment with the bug number.
Small nits: for consistency we could

*  use `window.addEventListener('load'...` -> will make gjslint happier
*  we usually don't unbind explicitly...
Remove the "comment out", let's keep this feature.
We should not have the Euclidean distance in there at all. It's very wrong in most cases (near the pole even for small angles). 
+1 to haversines or even the vicenty.
I see your point here (and was thinking about it earlier when I wrote the docs).  I'll change this so that it always has to have units for now.  In 0.3 we can re-evaluate once we have a clearer picture of how to divide up functionality here vs. `parse_coordinates` or whatever.
No, that function would never return `user.avatar_url`. Ever. It's fine now, but you need to know that this is very obviously wrong.
A comment here expressing the security concerns would be nice; maybe:

// Corrections made are very conservative on purpose, to avoid
// opening up the possibility for attackers to replace valid addresses
// with look-alike addresses.
It might be nice to accept a String address or txid to allow simpler locks (lock all to address, or all output from txid).
And I still don't get the meaning in german from that weird english description...
Missing doc blocks for constants
Use [heredoc](http://php.net/manual/en/language.types.string.php#language.types.string.syntax.heredoc) for multi line strings.
this is really difficult to read, is there a better way to format this?
Thanks, I think my brain turned off while trying to think about how to spell "substitutability".
Yes, you're right. I considered that, and it's the least of all evils IMO...
I might change this context to something like "adding a comment (with markdown syntax)". The main reason being that "has markdown support" sounds more like a test in itself, whereas a context is just supposed to be... well... a context!
you could replace the two checks of the dict with:

tk = os.environ.get('ETS_TOOLKIT')
if tk is not None:
    ...

Otherwise, there is no need to call .get() since you already know the key exists...
Can we call this "Allow Clipboard Access" instead?
I don't know if it matters, but this won't remove the object from the new environment; it'll assign it NULL.
Again, maybe a slightly more descriptive name.
Should this be fixed before merging?
Fixec.
I would go with `run_cell_magic`.  That is not too long is is much more descriptive as to what it actually does.
I love that we can pull that condition out now.
Wouldn't this mean we need a `lock_version` field to use this?

* What happen if no such field exist?
* Would be best to document this along with the pull request.
Try `git_path_prettify` for this.
this console log needs to change and say something specific to select helper key
All our HTTP requests are cached 10 minutes by default.
You don't use views, it seems, so no need to import it. Pylint can help, if you want to check this kind of stuff.
Ew. So, the thing with Forms and Models in Django is that it goes and does a bunch of meta-y things. Something like this isn't super. It's probably better to declare a "constant" in `apps/wiki/__init__.py` which gets used in RevisionForm as the value for max_length and passed to the template and used there.
oops, i got caught!
yeah eliminated.  But the KeyError is for any one of  number of required keys that could be missing from the processed crash.  I rewrote the test to make that more obvious.
Makes sense. Maybe the fact that these "queues" are transient in nature, supports the idea that they be separate. Although, the intent makes sense, but IMO adding those adds more questions when looking at it as a whole.
Using a substring seems like it could be brittle. Is there a better way to get the width out of the style attribute?
Actually, you should remove the other one instead.
Artifact of merge conflicts
This breaks BC.
this naming would be logical according to the Sf2 naming conventions
Calling ``method_exists`` or ``is_callable`` would not be totally safe either as they don't bother about the visibility. But we could indeed add it to make misuses less likely
= mapKey
This class is both a factory and a registry (so breaking the Single Responsibility Principle) and does not follow the DI pattern (as much of your Pr actually).

If you want a CacheRegistry, it should receive configured drivers IMO, not a class name to instantiate it. And then, simply create a LazyCacheRegistry lazy-loading them from the DIC for people using the DI component, to improve the performances by instantiating the drivers only when needed.
And btw, if you want  a registry, the class name should reflect it.
The exception is thrown by appy(), which only has access to the name string at that point. We could pass the node along to apply?
Yeah, good point...
The footer was no longer needed in this file. 

I removed this in one branch and put it back in in another in the original stories. My bad.
I know this is all copied, but let's use new hash syntax for consistency.
While doing a quick test I just noticed this is in the wrong place in the oiiotool options list - it should be in the same section as the other actions like --add.  Also the doc string would be more consistent with the other actions if it said "Composite two images" or something.
As we discussed, this is a transform-equality, not projection-equality... but even so it seems to be redundant now so I've stripped it out.
Yes, I downloaded it from the internet. See https://github.com/SciTools/cartopy/blob/v0.4.x/lib/cartopy/data/netcdf/HadISST1_SST_update.README.txt
I think we should be able to directly link to the ``i18n_patterns`` in the django docs via intersphinx:

    :func:`~django.conf.urls.i18n.i18n_patterns`
THis makes sure parser barfs if there is a crap attribute
This is an API change. Needs an @Deprecated getDeploymentMetaData() that calls the new method.
non-sync read and not volatile
This actually adds extra space for two more lines.
Good catch, but I'm lucky here!
lockscreen always starts in locked mode (that might explain why we see it appear half a second on device boot when lockscreen is disabled):
  https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/lockscreen.js#L8-12
so that when is in unlocked on initialization, the `unlock` event is dispatched:
  https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/lockscreen.js#L533-551

I verified and the pin request dialog appear on device boot. If you cancel this first request it will only be displayed when you launch a telephony/sms app. I can add some code if you think I should display it on other cases? Like on screen turned on? Or force displaying on initialization if we see that lockscreen is disabled (might prevent regression if lockscreen code change)?

Note that, you need to apply gecko patch from following bug in order to have correct behaviors:
https://bugzilla.mozilla.org/show_bug.cgi?id=806307
Otherwise MozMobileConnection is completely broken and sim dialog never show up.
more items more time although if you want i remove it
I have changed to use the storage type of "sdcard" for access the received file.
And change the file path to be '/Downloads/bluetooth' + fileName;
But I got nothing in the getreq.result of onsuccess() function.
Do you know why?
Sure, no prob :) was just curious :P
It is recommended to put the class name to `id=screen` element so other elements can toggle their style also.
I don't believe you need any ftu code in the homescreen .Let's remove that.
Pretty cool, @steveck-chung !

One question regarding the search, right now we search each time we modify the input, do you think this is better than maybe waiting a few miliseconds before firing the search, just in case the user continues typing?

Didn't check if that effect is better than trying to fire several searchs in contacts, maybe the UX guys can tell us more.
I think I do not get it... :-O What do you mean "you don't need this"? :)
yeah, my mistake, I always do the l10n changes in different PR (for SMS) and forgot I was in a different app :)
Anyway, got to ask UX on how are they gonna deal with this chunks of text, as they seem all the same along the apps with small changes (calls instead of messages, etc)

But while I do that, I'm modifying this one.
For reasons of consistency we should throw an exception if the `Movable` mixin is not provided ...
I don't think this is needed as much as an `isCurrent` field
Follow proper Python naming conventions here.
This should be named `get_entity_kind`, to follow proper Python naming conventions.
I think it depends on how you're using the message.  You are using the error message to print to the web "console".  I am using the error message in an error binding in the GUI.  If someone types "hello" in the GUI, I think 'Invalid number' is a better error to show right next to the text box than 'could not convert to number: "hello"'.  Maybe we need (the possibility of) two error messages?
It display profile saved successfully even if it's fail, i have fixed  that.
Instead, I would suggest making an actual Python class that represents a measurement type, the set of parameters it can support, and their descriptions. The way you are doing this is a little bare-bones and will eventually be difficult to maintain - since you're in here revamping this code you might as well do it "right" - would you agree?
'scope' is not OAuth parameter. If it is added as OAuth parameter, makes authentication failed.
ok so it still breaks down a bit if there are both detailed guidance and inside government results but no mainstream results
the adapter trick is actually working.

https://github.com/buildbot/buildbot/pull/522
This ad-hoc type factoring doesn't site well with me (but I understand why you did it. The duplication wouldn't be quite as much if there was a single table to query here.
please keep the boolean lowercased
why not using the Process component used by composer everywhere ?
I hear you, but what if there are other validation rules on the field, such as a regex pattern? That could confuse the user. I would separate this from activeClass, at the very least, so that behavior can be controlled individually.
Can you move the strings to PROGMEM please? Do not forget to adjust the debug outputs that use these strings as well.
That link will never be shown (probably shouldn't be in the template then, I guess) - it's hidden by default and only output to the page when there's 1 image in the gallery (bearing in mind it's a "previous" link, so is probably redundant). I might just kill it instead: all the other links are real.
But isn't that a cross dependency too? Then the URL module has to know how to construct/update a gallery URL based on the `index`. Currently it doesn't know anything about the URLs it builds, it gets given a string to put there.

Also, then don't we end up with a URL module full of listeners for each possible thing that makes use of it (plus, presumably, another function to determine specifically what to do with the info it receives based on the individual module)?

Doing it that way seems a bit opaque to me: reading that `modules:gallery:moved` event doesn't imply that a URL change is going to happen.
If the function is called `highlight`, can we call the boolean variable something else, like `want_highlight`?
This says which tab should be active if we just render a form after an invalid submit?
can be just videos_path
Well `path` is only relevant for add-on modules, and there is no path for system modules so it felt awkward to put undefined or `uri` instead for them.
Although in catch you would just did `if (error.cfxError) { ...`
It looks like we need some gradients for webkit, opera, and ms here too.  How'd I miss that?
Has this already been moved over?
There is no need for an if/else condition. Please directly put the code in the above try/catch block.
it is unacceptable small cycle count. Please reffer to http://en.wikipedia.org/wiki/PBKDF2 section "BlackBerry vulnerability", and "Alternatives to PBKDF2"
I still strongly recommend you to use scrypt  http://en.wikipedia.org/wiki/Scrypt
Also done in the fix-proxy pull-request.
It would be better to remove proxy behaviour from this PR, to keep focused on the new container.
Looks like we could use a lockguard here, since we lock at the beginning of the method and only unlock right before returning. If you look at Thread::context, you see it being used this. 

This probably applies for Thread::wakeup and Thread::raise as well.
This call returns a value and a stat? From [the diff](https://github.com/slyphon/zookeeper/pull/25/files#L2R428) it looks like this is only returning a return-code int.
Done. Sorry :)
If the string was converted toUtf8 at the start of the function Why convert here too?
Although yuu both mention different (yet equally important) points, I fixed them both.
Can you remove the unnecesary import? `use Zend\Authentication\Exception`
We should not disable subfolders for controllers.
use `elseif` here
spaces around ..

Apply the same to the rest of the file
To avoid introducing unrelated changes. I'll address that in a follow-up commit though.
Typo, here and below (not camelCased column names)
Personally, I wasn't aware that app.config gets loaded when we use a Test project, so I wanted to make sure it really works. (Otherwise it leads to really inscrutable errors).
This seems wrong..... I suppose it would work for the embryo transfer page, because of the onChange dummy, but all the other pages won't necessarily have the ID submitted to the backing bean yet. Do they still work?
We should probably be checking both, i.e. `case (is_object($item) && isset($item->scalar)):`.
Jurians brought up a good point on IRC... Shouldn't the standard zf2 CsrfValidator always use the session lifetime rather than using a default of 300 secs? Are there any security concerns that the 5 minute default addresses?
actually, that shouldn't have been commented out
use unkown_exit function
Could you get the request by using a typehint method argument for the action instead (line in ``connectServiceAction`` ?
bundle exec rake didn't work
This is wrong, you provide a web.xml
Fixed up in ff4d643
I did it this way because c_str returns const char* and I needed char*, but I guess there is no harm in casting it in this case.
A simpler way to do this replaces the two "if" statements and the "del kwargs['latlon']" with:
<pre>
            if kwargs.pop("latlon", False):
</pre>
In other words, in the original, replace "kwargs.get" with "kwargs.pop", and remove the "del" statement.
Note I changed the version number - you may not want to pull this.
Why two spaces at the end? And shouldn't this just be a list with inline styling? It doesn't seem like prose, which is generally what a `<p>` is reserved for.
it's a good idea to name this function "_packetEndOffset" to aid with debug-ability, I think?

Note: some of @voxer's source code does this for functions attached to prototypes, and some does not, so not clear whether this is actually helpful, @mranney would know however.

Note: (if it was a plain anon function, we would want to name it, but maybe it's different b/c attached to a prototype)
You know... I think this change may have been a bit presumptuous on my part... basically when I had the java version off (I dont recall if it was higher or lower, or different versions of android sdk as a target).

I agree with your concerns, and looking into it further... I woudlnt know how to fix it any better... almost seems like its just another case where java generics fall short. (having "extends Entity" generic constraint I would *THINK* would cover that issue)
This is not something you have to change, since what you have is perfectly fine, but you might find it more convenient to use `Zotero.Utilities.xpath` and `Zotero.Utilities.xpathText`
Yeah, that wouldn't be a problem. I'm just wondering when you cite this in a paper, do you want the english title or the localized one?
Oh It wouldn't hurt to move History from menu Item to the last tab right, considering its probably the 2nd most looked up thing. Logs are staying where they are. MUahahhaha. Do you have a Android tablet? I haven't made any tablet interfaces because I don't own one and have no idea how big they are.
I've added a commit that reduced the line-length to 80 in all files.
Okay, I won't.  Thanks
In `<var>` tags, we have to be careful that the contents are valid html, so instead of `<`, you should use `&lt;`. I know this probably works fine in most browsers, but we have a script that runs when we deploy that will choke if it's not strictly valid.
are both of these checks necessary?
it seems a little odd to me that these wouldn't be two different methods.
hm lowercase ``` uid ``` vs upper case ``` UID ``` in the next line?
fixed there too :)
It's there for a reason. Sqlite crashes the process when opening a database when the disk is full. There's no way to catch this. Since the database is opened at home screen startup, the home screen would just crash right on startup. Some startup scripts would probably try to restart the home screen but it would again crash. A watchdog would probably then reboot the device, but the filesystem would still be full and the device would be unusable.

This was at least very much the reality during Harmattan development. I haven't checked if Sqlite still behaves the same way. I can do that if someone really wants but I hope this explanation is enough.
Increased the font size for nicer shadow. Not perfect but it's a start.
Removed it from the requirements.
The convention is to call these extension classes `Rich*`, but it's not a big issue.
подальша перевірка не стосується видалення. потрібно тільки перевірити чи пост з бази зник. по аналогії з тестами на wallpaper
in the CmfGenerator we also accept the route object in $name (which is what happens in symfony if you set _route to the route object instead of the route name). ok if we do the same here? then the CmfGenerator can extend this one and just add the content magic to find a route object.
Если шаблон только один, то можно переписать на

    block b-text-list, mod type ol, tag: 'ol'

Ну, и кавычки должны быть одинарными.
Are these TODO items going to get done now or later?
Braces should be put on separate lines, see the [coding style guide](http://codeigniter.com/user_guide/general/styleguide.html#code_indenting) for more info.

Additionally, the whole split-escape-and-glue procedure would be better like this:

    $k = $this->_protect_identifiers(substr($k, 0, strrpos($k, ' ')), FALSE, $escape).strrchr($k, ' ');

... and a changelog entry is required before it can be merged.
догадался, но коммент почему то не обновился.
No need to do this. Just stick logtypes[tp] into the send_to_char() call.
File contents
We should probably have a conversation about this.  I'm not sure exactly how pictures are resized, uploaded.  I just eyeballed the 350px height for the hero/featured picture for best look.

Are we able to resize pictures for 'span 8' and 350px-ish height, and still make it look good?
note here that GD doesn't support resolution
I would fix it with a local variables whose value changes according to the $operatingsystem
How often and in what cases would one or the other be used?

Would it make sense to have different command classes for those two cases?
I like that. We should do this with tempdir at otherplaces to avoid cluttering the repo.
I would not store as attributes the sources but just the mixing matrix, the channel names for the col / rows of the mixing.
To get the sources I would allow to return then and add a method to compute it on raw/epochs/evoked/
change "Description" to "description"; it's more standard to start field names with lowercase letters.
it's kind of weird how you have to pass in an empty list if you don't want to exclude anything.
I'm saying that the property is correctly a Boolean, because it should be nullable, and therefore we should have a getDeathdateEstimated method that returns Boolean (and not isDeathdateEstimated method).
Just a note that this is a case where we very much want to allow any other keys and values.
The correct content type for JSON is application/json:

http://tools.ietf.org/html/rfc4627 section 6
Why not use sleep? Since we know for sure it will not be notified by any other process?
Wrap `composer.json` in the double ticks:

    ``composer.json``
Ok, thank you for the tip. A 'return' should do the trick?
I'm tempted to choose another word entirely -- something like `fails` so these scenarios don't blend into each other.