labofsahil/github-event-dataset-2012 huggingface dataset:
Стоило бы вынести этот массив в свойство класса, дабы не создавать его каждый раз при обращении ( как и в категории).
Я имел ввиду:

+(NSArray*)nucleotides {
    static NSArray* nucleotides;
    if (nucleotides == nil) {
        nucleotides = @[@"A", @"T", @"G", @"C"];
    }
    return nucleotides;
}

при этом массив будет выделяться в памяти только один раз т.к. переменная nucleotides - статическая, но доступ к переменной возможен только из метода nucleotides - этот код работает также как и Ваш только область видимости переменной nucleotides ограничена методом и обратиться к ней из вне нельзя
этот тест можно включить в следующий вполне
Using wear weight is clever, but you really shouldn't do that. What if they're wearing something with 0 weight?
Is HAVE_RPI detected automatically, or do you have to pass HAVE_RPI=1 manually?
And it appears my original comment was unclear.  I completely understand what filters are and their purpose, my comment was about the conditional behavior based on which controller we are calling (template controller specifically).  I have to think more about it, but I kind of think any of that code related to one controller only should just be in a filter method on the template controller itself, which can be invoked after this more generic one.
I've added a comment and submitted another commit.
Done:

https://github.com/worldofchris/cucumber-js/commit/73b52b6f9668994317089e358c40326268b8a481
Oh, no, it's not an attempt at solving #94. It's a way of solving the deep stack issues raised in #147.
遗漏。
you should use "is" with "None" and indeed be careful with is otherwise
Yeah, they say it's okay :)
there is some very weird hard linebreaks in this document, like on this line.
yes, sorry for missing that. Added a new commit to the pull request
I think we should change the precedence to use markdown over rdoc.
Ok I see.
But, I'm using 
```php
foreach ($container->findTaggedServiceIds('acme_mailer.transport') as $id => $attributes) {
    $definition->addMethodCall('addTransport', array(new Reference($id), $attributes[0]["alias"]));
}
```

As you said, $attributes is an array of tags with their attributes. 
What's the matter here because I don't understand.
额。。上次改错了，本来对的
PHPDoc for this constructor should be fixed as well
`platform.faq.create.submit`
I know there was a good reason when I did it the first place. It was either related to vertical form standards or to some CSS not properly applying. Unfortunately I don`t remember right now, but I`m not sure it's ok to remove it.
So it only needs _some_ methods from Activation? What's so special about system?
True! 
Will do some refactorings tomorrow! 

Peter Berkenbosch
--------—-------—---------—
Wat niet kan, is nog nooit gebeurd.
-------—--------—-----------—
Verstuurd vanaf mijn iPhone.

On 9 mrt. 2012, at 20:08, "Ryan Bigg" <reply@reply.github.com> wrote:

>> @@ -74,6 +74,11 @@ def state_callback(before_or_after = :before)
>>       end
>> 
>>       def before_address
>> +        past = Spree::Order.order("id desc").where(:user_id => @order.user.id).complete.limit(1)
>> +        if order = past.detect(&:bill_address)
> 
> Why detect here? This is only going to be returning one order. Wouldn't you want to just do `past.bill_address?`
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/spree/spree/pull/1248/files#r540563
Я не решил пока. Оставил на всякий пожарный.
Should probably split the deinitialize code in OnRemove into a new entity function and call that, rather than making the processor think it's being removed.
formatting of this method. Too many spaces everywhere.
I know, it's just a bad habit...
please remove extraline
@return Response
Don't you need to instantiate the StopIteration, instead of just raising the class?
I'll have to inspect imports by hand before commit.
Yeah I couldn't really piece it together, but just ended copying the (working, recently updated) IRC adapter.

FWIW I'm using node 0.8.2
You've gone a bit frenzy on final parameters? :)
Accordind to the declared property (my.string=Hello), the type must be String not int.
Ah right, it's wrong / inverted.
In this vicinity we have 4 repetitions of "10 ** range_oom".  The whole block might be more compact and readable if that were factored out as a variable, in the line following the definition of "range_oom", and perhaps named p10 (for "power of ten").  Minor; just a thought.
I'm sorry for being so picky, but ideally we should avoid bare ```try..except``` blocks. I think your trying to improve the ```IndexError``` which ensues when there are no writers? In which case, would you mind updating this to a ```try ... except IndexError:```.

After that, its good to merge - honest! :smile:
Yeah, forgot to remove them.
Subtle but good catch - I like the refactored name!
I didn't interpret from matt's issue that it had to end in https.
Sounds good. I'll make that change - and then it will no longer be needed in mobile-wmts-vienna.css.
Add `size=16`
Yeah, is this the issue?
No dice man, this same exception happens with 1.0.8 too. I swear it's something about the plugins! Does this work on your setup?

java.lang.IllegalArgumentException: No matching field found: getDirectoryScanner for class org.apache.tools.ant.types.FileSet
Correct. This is still WIP. I just wanted to get an early review in for i18n and the widget loader.
and please always do

```
if (xxx)
{
  ...
}
else
{
}
```
@chillu I have to ask, do you know we are removing double dashes in the middle of a file? It's a trivial thing, but I'm curious.
To avoid making this table too crowded, please move the confirm button out of this index view and into the user show view.  (right below the 'sign in as this user' button).  The need to confirm someone isn't so common that we'd want to be able to do a bunch quickly from the index view.
This was a quick fix because we found that events with a magnitude value equal to m_c were being removed, when they need to be considered. As both mag and m_c must be floats I just reduce m_c by a very small increment (several orders of magnitude smaller than the typical reported magnitude precision) to ensure that events with Mag = m_c are captured in this selection. I am certainly open to finding a better way to do it!
Are you sure ``$input`` has the correct type as ``*`` is not a sub-type of ``string``?
Are you sure ``$this->once()`` has the correct type as "object<PHPUnit_Framework_MockObject_Matcher_InvokedCount>" is not a sub-type of "object<PHPUnit_Framework_MockObject_Matcher_Invocation>"?
CHEEEEECKSTOOOIIIILLLL
It should be removed with the new sbt changes
I don't think we need to default `options` to `{}` here.  Since we're not using it we can just pass the value through to `validate`.
I think we can throw an InvalidArgumentException here.
Lets keep it then
This will never get raised as you're doing a `filter()`
Umm... So just rename the variable or?
Hm, we will only have Post resource in this case. At least in this commit.
Probably you want to use simply `Resource` class, not `AuthoredResource` which defines some its fields.
Read what this method has to return:

https://docs.djangoproject.com/en/1.4/ref/forms/validation/
You can use [get_or_create](http://mongoengine-odm.readthedocs.org/en/latest/apireference.html#mongoengine.queryset.QuerySet.get_or_create) instead.
How to remove panels if horoscope for languages doesn't exits? I try panels.panels_pool.unregister(HoroscopePanel) but doesnt work under get_context function - where try and remove it?
Add spaces around operators.
Move this above, before piplmesh (piplmesh is the last group).
Is this the correct implementation of `Equals`?

What if two instances have the same `limit` array, but different values of `lower` and `upper`? `Equals` would return `true`, but would they really be equal? They have different states.

And what if two instances have two different arrays, but with the same value? `Equals` would return `false` even though the internal state of the two instances would be the same.
Not sure. Posted it in the forum: http://forum.movingblocks.net/threads/terasology-code-style-conventions.501/
Avoid brackets.
AuthJsonHttp in Instanzvariable zwischenspeichern. Muss nicht jedesmal neu angelegt werden
Cosa vuoi dire?
@zenspider I thought `\s` only matched space, tab, and new line. But I'm no regex expert (obviously). What regex would you suggest?
It actually works if I include `nginx` somewhere else... I'll close this PR.
what's with the commented code?
Nothing is guaranteed the end of scan.
I only can check these status:
Scan Pending:  The scan has been scheduled for the Nessus scanner box.
Scan Processing:  The scan is currently in progress.
Generating Report:  The scan has completed, and test results are being compiled into a report.
Scan Complete:  The scan successfully completed and the vulnerability report has been generated.
Scan Cancelled: The Nessus scan was manually canceled by a SoftLayer technician.
And under the Nessus::XMLRPC there is no http timeout, so what is the 'correct' maximum delay ?
Maybe we can change the scan timeout by checking the old scan time + 15% to provide the maximum delay ?
Should this be a header or a note, rather than just an italicized fragment?
but you are calling "Queue.__init__(self, **kwargs)" so it means your custom constructor does not do anything differently from Queue.__init__

unless this is a typo ?
Sorry, I didn't mean "shocking", I meant "surprising".
While I encourage you to not reuse the same variable/argument for two values with different definitions and types, using synonyms is almost as confusing.

So, I would go for `onResolve` => `decoratedOnResolve` => `propagateResolution`, for instance.
+1 on comprehensions lists
The null check is added in the original call

    $entity = TestResources::getTestEntity('123', '456');
Ok update coming.
`name  =`
Wrong alignment.
We can add that back after merging :)
Add a TODO for Jeff to refactor this with the Apache shutdown code.
Oh, right, this change is correct indeed.
Just thought it made it a little more readable than `code_points.size.times do`
These changes are hard to read on git.
I removed getYozioLink(loopName, destinationUrl) and getYozioLinkAsync(loopName, destinationUrl) because they were never being called by Yozio.
Meanwhile, I added getYozioLink and getYozioLink to support async versions.
Actually, no. This is pretty pointless. I was thinking the same thing but left it because I wasn't sure if MAP cared about it. It turns out MAP doesn't care, and I think the only reason it's still there is to satisfy the specs. I'll rip it out.
It's consistent with rails convention when generating a controller. The css it creates is called 'scaffolds.css.scss'. It's meant to be deleted later.
There is no link "collective.quickupload"..?
> Might it make sense for the default fluxes to be 0.5 in each case?  This is motivated by the typical use of the `DoubleGaussian` being as a PSF model, which might not be what people want it for, but I think this would make more sense for a default PSF-type setting.

Well I agree that it makes sense to normalize to 1 as the total flux by default.  But the (0.5, 0.5) mix is kind of arbitrary.  For typical ground-based PSFs the flux in the outer Gaussian is anywhere from 10-40%, so a default in that range might make more sense.  Or we could remove the defaults and make fluxes into required arguments.
May be worth clarifying this (at the expense of slightly longer dox) to something like: "A description of the simulation method can be found in Section 5 of Mandelbaum et al. (2012; MNRAS, 540, 1518), though the details of the implementation in that Section 7 of that work are not relevant here."  ???  Just to be clear that we're using the same procedure implemented in a different way.
> > +  Public Dropbox folder: \newline
> > +  \href{https://www.dropbox.com/sh/ns2yh4q00trqs5r/JypUX8qwLw}{\emph{https://www.dropbox.com/sh/ns2yh4q00trqs5r/JypUX8qwLw}}.}
> > +\item[$\circ$]
> > +  \href{http://galsim-developers.github.com/GalSim/classgalsim_1_1base_1_1_add.html}{\texttt{galsim.Add(\dots)}}
> > +  \newline {a {compound} object representing the sum of 
> > +  multiple \texttt{GSObject}s.}
> > +\item[$\circ$]
> > +  \href{http://galsim-developers.github.com/GalSim/classgalsim_1_1base_1_1_convolve.html}{\texttt{galsim.Convolve(\dots)}}
> > +  \newline {a compound object representing the convolution of 
> > +multiple \texttt{GSObject}s.}
> > +\end{itemize}
> > +
> > +Note that all of the \texttt{GSObject}s except for \texttt{RealGalaxy}, \texttt{Add}, and
> > +\texttt{Convolve} {\em require} the specification of some radius parameter, where the choice of
> > +possible radii to specify (e.g., half-light radius, FWHM, etc.) is given above and in the documentation for
> > +the class.
> See note above... I've tried a compromise that avoids the having the params in multiple sorts of nested brackets, at the cost of there being more text in the body.
> 
I like it.
+1 for cleanup
same comment as in BinaryDiff_diff_File_byteArray_Test
cell is a better name than that (both are ok)
Is this the sort of thing we'd like to re-use (when polling every 500ms)? I think what you have is good for now, but nice to inform the next version of "function-adapter" for the sort of thing that's useful.
Related article http://stackoverflow.com/questions/5560442/how-to-run-two-commands-in-sudo
We may want to dom.setTextContent(el, content) here instead - setting innerHTML can lead to XSS. If we care about that. But maybe once we have collaboration and such we will.
Actually, on a second reading, I don't like the entire sentence. 

* make changes to an existing web application to allow it to be deployed as a hybrid mobile application;

would be more accurate
Again, please use spaces around - (and +).
yah - esp. since the final `elsif comma_position` is by far the most common case.
are you sure you want to comment out policy manager?
huh?  I have no idea ...   I did NOT do that intentionally.
Oops--this is a mistake. I'll remove this. It's slated for another round of changes later.
Why the delta?
if(target.loc.loc == src.loc)
        //place into src.loc
Зачем это нужно? У String есть метод charAt
Что за подчёркивание в названии?
shell/bash работают не так. Они пишут сообщение об ошибке и можно продолжить работу. Мало ли - пользователь ошибся.
If you don't need this code, please get rid of it. Commented out code in the trunk aren't that nice.
Normally we would use the maven exec plugin to allow to build and run in one easy step :-)
Ais line-@ lav@ chi.
Super is not needed... there is no parent class.
this was changed in pull:

https://github.com/mozilla/marketplace-tests/pull/133/files
Can this be changed to only print the resolution information if ```resolutions``` is greater than 1?
@dcampbell-macadamian: It changed when included filename contains directory. See the "if (slash_pos != std::string::npos)" block.
Then please add a TODO comment saying so
Effectivement c'est home et pas var.
Mais le problème des permissions ne vient pas de là (je n'ai pas testé ce code en mode prod).
Lorsqu'on crée une étude, un dossier portant le numéro de l'étude est créé dans /home/jetmenPROMO/login/Etudes/, et c'est là que play n'a pas les permissions.
Basecamp is not ported over from NinjAuth library, so you can actually skipped this :)
These lines are indented using spaces instead of tabs.
I can see you want to present a list of target processes that have logs recorded..
Since you can't rely on the log path for that..
You probably have to get the target processes from the cluster info. You'd then have to tie them to log paths using something like getConfigurationDirectory()
A member that returned # of rows would be more in keeping, i.e. / sizeof(void *)
I've moved it to CRenameFileAction::doRename(), which is where the action happens.
I see what u mean. Yes when we have packet allocators determined by downstream activities, then it is will mean that they are held onto in mem (for some time).

It could still mean that they are are no longer in mem whilst the hash is holding on to the keys, e.g. if downstream was sorting the output from dedup and had itself spilt it's rows...
So could a decent compiler... so unless it makes the code clearer (which is debatable), I prefer not to.
2012/11/25 Randall Leeds <notifications@github.com>

> Can we just remove the user field completely or does that totally break
> the frontend? We can update the front-end code of hypothesis/h so that it
> doesn't assume the acct: uri format.
>
Yes, we could probably do that.

(But need to check whether the client is doing something else that expects
the the user field somewhere else in the code... for example, in the
permissions plugin..)
Это текстовый редактор или IDE так нашалила?
`ditto` == The same as stated above or before.

I noticed the missed phpdoc.
This fails because you only have two components in `ac-version-components`.
@yuhunglin In general I love deferreds as well but it looks like it's adding some more complexity throughout the code.
Would it be possible to see how it looks like with callbacks instead?

If you don't want to do it, it would be good if you could add some more documentation to the code.
You can just do LOGGER.error("Got unexpected exception in service", e) and the logger will unroll the exception for you in the appropriate way. 

I get nervous when I see exceptions swallowed like this. Your method can probably just rethrow e.
Watch out here: The input to delete_temp_files is not the max_file_age it's the cleanup_dir boolean.
are private classes really a benefit in QML, when you have no exposed ABI to keep, rather than a performance overhead due to constant indirections and two mallocs? (but if you want them, keep them, they're already there after all :-p)
I think you would like to use OptEnum for the OS option
Could we randomize the jar name? Exploit.jar seems a little too obvious :)
I really feel like this module is a little redundant with psexec.rb... anyway I'm going to wait to listen feedback from more experienced developers.
we probably dont use address_line_2 anymore, if we use, would be nice to have that in users dashboard as well
Could this method use a JavaDoc?  Would it help out the user to explain what we're doing and why?
nit: pep8 is complaining about this whitespace
Is it sensible to swap the order of the parameters and default to a WGS84 ellipsoid? If not, the exception string is missing a space between "is" and "required". Also, you should add @exceptions to the doc.
Probably should check `typeof position === 'undefined'`.  Ugly, I know.
Do we really need two separate code paths here depending on if the previous frame's frustums can be used?  I envisioned something like a recursive call to `createPotentiallyVisibleSet` with newly computed frustums.  That should be less code and a more cohesive design.  Here, `renderPrimitives` does a lot more than render.  The name is also misleading, perhaps `executeCommands` or `dispatchCommands`.  Eventually, this will be in the `Renderer`, which knows nothing of Cesium primitives, just commands.
I'll double check but if I think this could cause a preflight to fail as the RequestMethod would be OPTIONS and that is probably not the RequestMethod that was specified on the Route.
Shouldn't be _in rows_ when wrap is false.

```
If the `wrap` property is false, the behavior is more equivalent to a vertical layout. Children are laid or horizontally from left to right in a single row. The `left` and `right` properties are used as padding between the children, and the `top` and `bottom` properties are used to position the children vertically.
```
remove this package
I cannot find the reference anymore, but it started changing file ownership for files it shouldn't. If I remember correctly it was some of the /var/lib/puppet files. This led to puppet runs that would flip ownership back and forth from root to puppet back to root (puppet agent changes ownership of it's own files at the start of it's run if they are not correct apparently?)
doing a DELETE on search/jobs/12345 should return a 404, as 12345 shouldn't exist.

Itay
Please use `lowerCamelCase`.
Ещё вариантiк — для пабсаба использовать не жкуери, а что-то другое классное. :smiley_cat:
Souldn't this be: switch(FloatingPointControl().rounding) ?
Instead of line-separator by the comment, multiple `unittest` blocks is better .
This should probably be changed to something like.

> xformat is a version of $(LREF format) whose behavior matches that of $(XREF stdio, writef). $(LREF format) will be changed to use this implementation in January 2013. In the interim, xformat is provided for those who need the improved implementation. It will be scheduled for deprecation once `format` has been updated.
please fix alignment of comments
my point is not to get rid of ```self.cfg['dontcreateinstalldir']``` but to have make_installdir have an option to ignore what is current set and assume it to be True
missing private keyword.
You can hint the `ArrayList` constructor with `unparsedArgs.size()`.
maybe we should extend that it's allowed to modify the EDBCommit?
NEVER EVER provide interfaces without good and complete jdoc
A comment saying what this function does would be nice :). I don't think I want to reverse-engineer this imperative code to understand what it does.
what do you think of this approach? uses the repository path part as static pattern path and just store a field with the variable pattern part.
ups, indeed. @saithis, can you check for Sonata\DoctrinePHPCRAdminBundle\SonataDoctrinePHPCRAdminBundle instead of the base sonata class we check here (which is present even if one just has the orm admin)

i guess the clean way would be to add another compiler pass that verifies everything, but i would not do that here and now (its mainly about initial setup, and if somebody starts from the sandbox or the cmf standard edition he will not have that error)
isn't this an expected (vs. an concerining) situation? If so this should be logged with trace. OTOH if you consider WARN as the appropriate level for the message then the Log interface needs to be used for logging, as described here: http://fwd4.me/0vWM (this applies for all logging statements that have a level higher or equal to INFO)
similarly, calling SuiteImporter a "map" feels strange. decide whether the abstraction is a "map" or an "importer" and stick with one or the other
Ehh...that was weird...there used to be a comment from you about this code, but then I adding a clarifying comment and it went away.

See if this new comment and code makes any more sense? If not, call me out.
that's awesome.  OK.  I used that wherever possible all over the place.
`suite_data` instead of `suite_list`
This line seems to be out of date with the code.
Might be worth checking other sys.posix files too to ensure that Windows targets don't import anything from inside the module.
MINOR: refering to event type, not namespace in comment
Artem, I agree - please open a "Refactoring" issue type in JIRA; thanks.
This class should not use "Pseudo" in the name since it is used for both pseudo and real transactions.
should be **volatile**
you need to add a $parameters options : ``ajaxUrl(BlockInterface $block, array $parameters = array(), $absolute = false)``
On 02/29/2012 09:35 PM, Neil H Watson wrote:

> Are they supposed to be human or machine readable?

I think in the metadata file they are supposed to be machine readable
probably the same classes that cfengine defines so that tools (not yet
built) can search for things or warn when installing if your
installing on a machine that classes dont match.

In the Readme.md I would guess either machine readable or human readable.


-- 
Nick Anderson <nick@cmdln.org>
The alignment here of the if/else seems off.. it was a bit hard to read (obviously not a big deal).
i was assigned to 0 twice. This for loop can just be:

```JavaScript
for(; i < aliasesArray.length; i++) {
```
I guess these debug strings should not stay here?
This hunk reverts my previous change.
OK, I hate to be the grammar nazi, but... please capitalize the comments or you'll drive me to an early grave :)

Also thinking in general that the code is probably a little over-commented; in general we want nice clear method documents, but not a lot of extra comments inside the methods themselves. Feel free to extract helper methods with descriptive names if some areas need more clarity.
There are still lots of `Assert.That`s left.
Mainly so should any failures occur we have a record of which node version is installed
Thanks. Fixed in cff52c0
does this need changing?
i think we need to check one more thing to be sure child nodes get updated too:

    $this->transport->moveNode('/topic2', '/topic1/page1/topic2');  

and then check if the depth of /topic1/page1/topic2/page2 is correct.
pls remove this line
Going forward we're thinking on making this sort of operations split from the commands one. Idea is that we could publish all of these as a module on it's own, instead of part of our CLI so that other modules can use. If you want, you could start this effort here.
What's the motivation for having a separate attribute? I would prefer to set vocabulary_ directly (even if it's not a fitted parameter).
translation.author.name
Relis ça 
http://guides.rubyonrails.org/association_basics.html
dupes `@return`
Yep. In JavaDoc, if you're going to list a literal (classname, package name, parameter name, type, keyword, etc), you should generally use the <code> font.
"this" activity
"this methods updates the current activity" if necessary..
Back button on passcode screen should take the user to the home screen, not display the previous activity (potential security hole).
Any reason why you don't use s proper maven dependency instead of raw wget ?

Like done here: https://github.com/jbosstools/jbosstools-forge/blob/master/plugins/org.jboss.tools.forge.runtime/pom.xml#L27
space after comments
sieht nicht so aus:

>>> c = []
>>> assert text in c[0]["textContent"], "Webview does not contain: %s" % text
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'text' is not defined
Does this method have to be implemented?
Fewer characters is not equivalent to simpler. What's the value in doing exotic things like this in open source work where viewers have varying degrees of skill?