labofsahil/github-event-dataset-2012 huggingface dataset:
Could you disable the automatic refactoring feature of your IDE, this generates a lot of false positive changes that we will not want to apply in the end. 
Undoing these changes will be a lot of work unfortunately.
since this commit no build has ever passed
No, you'd still need to set the trigger to manual, like so:

```
$('.popup-marker').popover({
		html: true,
		trigger: 'manual'
	}).click(function(e) {
		$(this).popover('toggle');
		e.preventDefault();
	});
```
Here I had a bug in my implementation. Needs to read

```
Math.abs(tileBottom.getY() - tileTop.getY()
```

will push this later today
You need to comment out this line. "pip install -r requirements.txt" fails with "ValueError: ('Missing distribution spec', '=======')".
#fail :)
Please revert the commit. I've introduced these checks because sometimes our parsing goes wrong. And those are always the cases where we have _no unit test_. I've done multiple fixes over time which were based on exactly these checks.
I've now rewritten this for correctness, and it'll be available in the next release. Thanks.
would be good to know which charge spells these are that cause problems, or on which npcs :(

A possible idea would be to add
if (obj == this) sLog.outError("Crahed with NPC %u", GetEntry());
before the ASSERT (or use a similar PrintError function for entry, but i didn't find this yet
oh, you meant Travis Vachon?
Should I re-apply all these comments, or will you?
Это перерисовка дерева при клике :)
Сделал два коммита в первом это написал, а коммит не сохранился :(. Вот :)
Riq, can you please change my credentials to:
Dusan Lazarevic (AKA crmagicxxx)
here on this row and downthere for cocos v1.0

Thanks :)
Sorry messed up those commits. Added on the commit before keys.java line 42, InputHandler.java line 35, IUsable.java line 7
It actually seems to work! I've been able to use play with it. Haven't had too much of a chance to smoke test it yet though, but it doesn't crash and burn.

scala precompile works

scala test loading works
Yes it's not related to this test, but I noticed it there. I've added https://github.com/ceylon/ceylon-compiler/issues/331 about this.
Good question. Probably over-thought it! I'll update my fork.
yeah be great thx
this can be done by SAI but if you working on C++ ill wait for your fix.. 
your fixes is alot more better xD
WDB verified?
CRASH ALERT: Player::CreateViewpoint: Player Smetano cannot remove current viewpoint!
Hi Tim,
I'm trying to build under windows and this commit seems to make troubles. Here what I get when I build Foundation only :

Building Framework(s) :
File does not exist : ../library/JamomaModules.vcproj

The problem appends in the build script of Support because it makes the name of the vcproj using the Modules folder instead of Foundation folder now.

best
TO
This `close()` calls should be in a `finally` block.
Should this be deleted since the db is the primary source?
Please remove the `.jar` extension from `build-classpath`. I was told by the developer that this may cause issues.
I think this is backwards.  x_direction=1 is used to go in the positive direction. Should be 

    dda->x_direction = (target->X >= 0)?1:0;

Right?
fix the typo, should be piece
ah, stupid that i overlooked that -.-.
Esto es para que empiece siempre a tope, nose donde mas mirar la verdad :S
Please fix the minor nitpicks above. Otherwise looks good.
Hum, can even move it to sklearn/!
I do not see any reason to include the boost library to the project. As well as libraries for winodws. All required dependencies are easily solved by cmake.
I think the only thing to change is that on this line you should be checking for 'LI' instead of 'UL' because that's what each to-do item is.
You can get rid of checking for null if QueryParseContext will always return a valid object. Instead of returning a null you may return an instance of NoMappers implementation which will always return false for hasMapper(). That instance may be a single one since it doesn't have state, so you don't need to create it each time.
it's working pretty well so far, its ready for version bump + new release :)
The cleverer give in.
msm: cpufreq: Use INIT_COMPLETION instead of init_completion



INIT_COMPLETION should be used for repeated reset of completion

object after init_completion has been done once. init_completion

reinitalizes the head of the list which could be bad if there are

completion objects already waiting.



Change-Id: I0ccd912109eee59b130e8f2303e354f70ee56150

msm: cpufreq: Create cpufreq workqueue for freq changes

Setting frequencies may take unbounded amount of time, use private
workqueues instead of shared system workqueue.

Ondemand governor may post to the kernel workqueue, holds rwsem and
waits. This may cause msm_cpufreq_target to repost frequency change
request to the kernel workqueue waiting on the same rwsem resulting
in watchdog reset.

Change-Id: I34cf264e5f7f2f6aad2d2d2af3e4449233efd7d6
Signed-off-by: Praveen Chidambaram <pchidamb@codeaurora.org>

Hope this makes it clear.

Signed-off-by: Praveen Chidambaram <pchidamb@codeaurora.org>
Similar comment here. If puppet added the confdir fact, so Facter[:confdir] is not nil, then this code could walk facts.d relative to it.
It is probably useful to make this output `title: "#{title ...}"` because the YAML front matter will get messed up if you enter a post title that contains `:` (i.e. Blogging: How I do it). Wrapping the title in double quotes fixes this problem
Why not 

```
if (connManager.getBooleanExtra(ConnectivityManager.EXTRA_NO_CONNECTIVITY)) {
  return false;
}
return true;
```

or

```
NetworkInfo info = connManager.getActiveNetworkInfo();
if (info != null && info.isConnected()) {    // or isAvailable()…
  return true;
}
return false;
```
The installation has completed successfully!. You may now click `Finish` to complete the installation.
Альзо. Нажимаем пару раз на чекбокс Заклинаний:
![http://rghost.ru/36083250/image.png](http://rghost.ru/36083250/image.png)
Также, не работает с первого раза меню "Скрывать изображение".
Вообще, зря вы пошли на столь глубокие изменения в функциях скрытия. Все работало, как часы.
Should getsectbynamefromheader be used for the TLS data as well?
just use the option ...
oh
but i wanna use your repro with your files, no TC repro
Same: git://...{no .git}
when the phone is booted normaly then ro.product.board is sholest and lights.sholest.so is searched and loaded

but when in openrecovery (probably also when in charge_only_mode) ro.product.board is just sholes, so lights.sholes.so is searched

so if it doesn't work as expected in charge_only_mode, a change may be required
https://github.com/CyanogenModXT720/openrecovery_xt720/commit/46122d330c5cfa23851fb02321ca215c58b21e0c
Do you really need it here? What is it for?
Oops. Added assertion to the test :)
Use `../../../build/yui/yui.js` instead.
I tested the other branch ''else if (window.BlobBuilder)", it no problem.
Default value should be false rather than "false"
This is too dense. Build the eval statement in a temp variable.
I thought some of the server management tool stats called it (I could be wrong).  The cleaner could call it if misconfigured (i.e. someone forgot to disable it).

Also, those stats look like they are for the in-memory version only.
Does this still need the class "WikiHeaderRestyle"? Can it just be "WikiHeader" again?
YMCA?
Please try to read which code I show in the doc, and which is for the test.
you could rewrite the 2 lines above as:

case a if (a eq ra) || transport.addresses(a) => Some(rootPath.address)
messages = {
  for((sender, msg) <- messages) aref.tell(msg, sender)
  Map()
}
Yes, but even that is problematic, as the actual half life will be  
dependent on the sampling interval.
yes, I see no reason why not
Ok, I just wanted some confirmation, before I say OK too quickly again :)
which only works for `value==xn`; but you are right, it might make sense if there are values which are always zero.
Moved below to their own subclass that we use for the View declarations.
Test comment
  --Gerry.....2012-11-28 09:37:49 -0600
Anon comment
  --Gerry Anon (Not signed in).....2012-11-28 09:38:26 -0600

Looks good
Quck note on the xmlscan API.

:element    =>  The Xml element we are scanning for (I guess I only support one now)
:key          =>  Which attribute (of selected element) to use as the key to the pairs.
:extras      =>  A list of other attributes to include in the value array (second of a pair)
:substitute =>  The nested elements are replaced with the value of this attribute in the content string
                       Symbols in the substitute string are references to other attributes of the element
Right, as we have discussed before.  Thanks for the reminder.
ok,

I've pushed a fix that stops the tests breaking without changing them
My head hurts trying to think of why there are two consecutive "try" statements here. :)
Should there be an assertion in here that proves if one is rejected, all are rejected? The unit test fixes look almost entirely related to the renaming of the method and not to account for the new behavior.
also respond to your post on mpegts.c

ffmpeg never removes a stream, it just adds new streams. Hence I think a pmt change which removes pids from a program is not a problem and we don't need to reopen demuxer (this takes quite a while to complete). pmt_cb adds new pids to the program and the stream to the context if it does not already exist. Right after we get the pmt change packet the new stream is in the list in FormatContext but not in the list of streams in ffmpeg demuxer (parsed or not).
ffmpeg demuxer already adds new streams or updates existing ones. This works quite well, just the notification to player is missing. I think whenever AddStream (in Read) is called we should signal a stream change.

I have been testing with a mpegts recording which has an original language audio track (set to preferred). When I seek past the show where the audio track is gone, I get the other audio track opened. Seeking back into the movie re-opens the right audio track again. It does not create a new stream, it just reactivates the old one.
This is exactly the behavior I would expect.
Это временно. Надо думать как прикрутить дизайн, без assets или использовать что-то другое.
Please make this more descriptive than "fortune_teller(args)" :)
I think this is irrelevant now.
Thx for the suggestion, was wondering how to do that in bge...
En fait je compte par la suite faire en sorte d'autoriser d'autres formats comme tar et rar
`request.post` is standard http post request object ( & serparated key=value ). We should use `body` to send json or array. So `this.data = this.body` should be removed.
You are right. It's a mistake. I didn't think about this...
minor pet peeve, please keep the alignment of the string concatenation.
Is it really worth it? I know that it was a very popular optimization some years ago, but I doubt that this is still significant enough nowadays (PHP 5.3 and 5.4).
indent looks strange here... not sure
s/bundle//
I don't remember exactly how I noticed it, but while adding button rollover states, the `mouseEntered:` and `mouseExited:` methods were not being called after a button press. Do you think I should just remove these segments dealing with hover (in these two methods)?
I'm just using the same as the existing documentation.
We no longer need Compass???
Removed - fd29c5ab2cb8c0504f07e36c5e73dec97bccb796
I think you meant to write `if (!PyArray_Check(arg_a)) {`.
wrong curly braces style for while and if.
Does that mean that my salt will change depending on the platform?
так комментарии вниз переползают, понятно, что я уже закрыл
для 0x00000003 наверняка есть какая-то именованная константа
Tabbing is off on lines 107-112.
Perhaps just an addition? `This allows to use dynamic inclusion/exclusion values using methods, besides the current lambda/proc support.`
Why `.inspect` rather than compare equality directly?
`if @config.fetch(:strict, true)`
Why not `treeCopy.Select(tree, qual, name)` to get the position and attachments in one fell swoop?
Also when we implement caching, I guess, the IDE might want to plug its own implementation
It's really undesirable to be duplicating all this specificity logic - especially because I still hope to change it someday.  I take it you're doing so because it's bottled up in Infer.  Have you taken a stab at moving it somewhere that you can reach it?
It's cool, all parens and return types added.   I realized my error before in that I was hoping Scala was infering a more specific type than one I could write.  Turns out I was just being stupid.
Using withDefaultValue spares us an extra anonymous class.
Yes, you're right. I looked for that method on `TreeCopier` but didn't find it; but I see it now. (I must have been up in user-land in `reflect.api`).
I think this should be `sprintf('Package type "%s" is not supported', $type)`. Also the `if ($base === false)` statement below should now be removed as $base would never equal false at that point.
should be named gh-issues-milestone
Activators wouldn't still be activated if you weren't including the promo component though. Correct?
I would say yes, but since it is so easy to install suds, we may as well just include it so that most of the functionality in SunPy is usable by default.
Why does it add more whitespace on continued if statements?
this is usually the symptom. And you should enter the code as I gave you since int_tested will raise the error if a != int(a).
There's an extra space around `:` and an incomplete comment.
Are you going to add a docstring about `alias`?
I understand that it comes from the `else` clause, but I am wondering if it should not just return `Basic()` in that case.
This is not what @rlamy suggested. Why?
Yes, this thing I know of; and I have actually run into the problem that assigning to `packages` modifies its value for the following calls also.  However, with this default value I am able to directly concatenate `packages` with another list.  Had this argument been `None` by default, this would have required an `if` statement and +4 lines to work.

That's my argument, but, since I'm not a Python expert, if at least one more person finds this default value to be wrong, I'll change it to `None`.  Not that I don't respect your opinion; I'm just gathering a critical mass of people :-)
I should remove this line
Rename "curTranslator" to "currentTranslator" or use "translators" variable.
Coding standards,, you must have braces as per PSR-2
I would prefer to leave this method in the Wrapper. There are 3 reasons for that ;)
- Syntax completion is already working. See @method annotation in service classes.
- Your scenario of developers implementing a Simulate method and getting confused about it being hidden in one layer and not in the other doesn't sound very likely to me. But if you care, I can implement a Simulate method (which throws an error) in the service base class and mark it final.
- I want the Simulator to wrap around the ServiceWrapper and not the other way round (Simulator --> ServiceWrapper --> Service class). This is easier to achieve if the Simulate method sits in the wrapper.
Don't you want this indented?  That is, if you're using `replicate` you don't want to run the initializer, right? Or is the idea that you want it to still run the initilizer for some reason I'm not understading?
You are right. Fixed now.
Ah I see.  We should have an example xml snippet / file in this repo, then, along with some explaining documentation.  Something better than a link out to a gist with some xml in it.
Oh it's down here hehe
protocol and id parameters should also checked for null
It seems weird to me that we would store a rule object on a per-identifier basis.  An interface where we are passing in the DataSegment would make a lot more sense to me.

In general, I kinda feel like this code has too many Map<> objects being used with only a variable name as context for how they are used.  It would probably be nice to introduce some named interfaces with more meaningful function signatures.  A "RuleBroker" seems like it would be a meaningful abstraction of something that can get a rule for a given DataSegment.
it's a value not a field? or a field holding a bson timestamp field.
Yes -- I wanted to preserve spacing.
It can be elsewhere during development.
C'est l'ensemble du site web qui doit être fluide ou non.
But let's say I do <!-- INCLUDE foo{ --><some html> blah blah...{VAR}. Then that should quite definitely not match? I'd really prefer this would only match actual variable names.
For the config? You did notice that there is `$config_name` in it?
Actually reading further down I get it now. But then you must at least initialise $is_expr to false.
The objective behind those roles is to allow the basic user to use this system without the need of changing the permissions directly in the more "advanced" way (in the more advanced table).
I've added a note.
At ff74f2c I don't see much of a differences regarding with or without transaction.
```
/**
 * @param {object} data {pulls: [...], message: "..."} where the presence of a message indicates an error.
 * return {array} list of metric results, where each result is an object with the following fields:
       name: "..."
       unit: "..." (units of data)
       aggregate: int (total)
       stats: {username: value, ...}}
 */
```
I changed this to period - 500 milliseconds... period is in seconds, so it needs to be converted to milliseconds. Nice find.
This was causing dir to be undefined, a directory is supposed to be passed in from the E2 Browser code that calls OnFileClick.
Please avoid using delays. Should be able to just wait for an adapter to exist.
Tests are missing Given/When/Then sections
This needs a much more descriptive name. Looking at the implementation and you can't really tell what is matches. It could probably also be split into a more readable form instead of a one liner
That's fair about the string to some extent.  Pretty sure List has a reasonable two string, so if you fix that I will merge.
https://raxaemr.atlassian.net/browse/RAXAJSS-206
Nicer, thanks. Better still if it was part of *__init__()*...
Why are we duplicating information? Random numbers in tests are already mentioned in http://deeplearning.net/software/theano/extending/unittest.html#using-random-values-in-test-cases, maybe we should have the information at a single place, and link to it from the other.
I think there are still scripts in tools/ that refer to ~/voltbin  (git grep voltbin)
instead of just star, use the old use case of `jsDAV_Codesearch_Plugin.PATTERN_EXT `
what is the name of the model created? should provide it as well.
missing whitespace between arguments
Formatting is off here
just push your changes to your branch, i'll merge it after indentation corrections
same here, remove models.UserManager prefix
if settings.AUTH_USER_MODEL is set to an invalid value that conforms to the pattern ie: "typodapp.nonmodel" then get_model and hence get_user_model will return None.

I'd propose that get_user_model test for None and raise ImproperlyConfigured
maybe "how does this view get called" as even in the urlconf - we don't actually call the view from our code anywhere.
That needs to be:
LDFLAGS="$save_LDFLAGS"

I fixed it myself.
Should assert the number of cues parsed
I did indeed run the test outside of the jQuery test suite. Because haven't installed all grunt plugins and was eager to make this pr. Should have known better. If something can go wrong, it goes wrong.
yes, I do. I can't do the check for `complete || (quickReady && interactive)`  here because there is no way to set `jQuery.quickReady` before `bindReady` when jQuery is loaded asynchronously. So I just check if it's not loading. This allows the user to set `quickReady` before the `setTimeout`ed function fires. However, if they DON'T set `quickReady`, and we were returning here, the DomContentLoaded and window.load handlers would never be bound, and ready would never fire.
Is it possible that this is a device specific issue... Can anyone confirm 2.3.4 on another device?
If max_split_points is less than 1, then we will not enable the continuous feature discretization. That's why we have to check this.

We cannot truncate the instance table at the beginning. Otherwise, we cannot compute the ACS.

We do not insert into one table from the same table. We insert into a different table actually.
At this line, we don't know which record is of wrong attribute number. We just know how many records are wrong.

I added this general error message because it is costly for us to find which record is wrong. If most records are wrong for a large dataset, the data movement between python and gpdb will be large.
Other signatures will cause a runtime error. This will happen implicitly in the C++ AL.
Ah, yep. I thought I was doing it wrong when I wrote it, but wasn't sure what the write way was. Fixing.
Nice, I fixed that a couple of days ago but must have pushed an old copy.  Thanks for the info.
Maybe it would be better to check "message is None"?
I don't think this 'sent' key is updated any more? Maybe just drop it and live with the backwards in compatibility?
Actually, this particular `raw_search()` is accidental. It shouldn't be there.
Oops, I accidentally deleted my comment here.

As I recall, this should say "Generate a Submission listing function."
I guess I'm used to seeing BufferedX do stuff in groups of M (for max size of buffer) - so that if a bunch of stuff comes in, it flushes M items, and then the next M, etc.  In this case, if you have 49 traces and 100 come in all at once, you flush 149 all at once.  Should this behavior be documented?  I found it unexpected, but my sample size of BufferedX things is pretty small.
``toThrowType()`` would be more appropriate. One small change at a time will eventually lead to all code being transformed.
`Character.toUpperCase` is locale-agnostic (contrary to `String.toUpperCase`), and FWIW it's what `Introspector.decapitalize` uses (actually `isUpperCase and `toLowerCase`)
... otherwise this fails with a usless message

  expected [Object@0x3243, Object@0x32343] but was  [Object@0x3243, Object@0x323423]
好的~我会校订的。
On 2012-3-31, at 上午1:37, Yihui Xie wrote:

>> 
>> 那些Linux软件仓库里放的软件实际上也是通过`make`的方式从源文件一步步编译出来的，只不过是服务器上预先编译好了，省去了用户自行编译和解决依赖的麻烦，直接就可以装编好的二进制包。
>> 
>> -最后是Mac OS，我没什么经验，不多说，好像就是一个文件下载下来打开就可以用，我不太理解Mac系统管理程序文件的方式。
>> +最后是Mac OS，同样可以使用编译安装(此时不含GUI, 但是Mac预先包含的ATLAS库函数明显优于R自带的BLAS).　或者,简答的使用<http://cran.r-project.org/bin/macosx/>　提供的PKG包,32/64/Intel/PPC 版本都包含了GUI. 唯一需要注意的是OS的版本, 10.4以下的会有各种问题.　另外的囧问题就是mac首次加载绘图窗口会非常慢,等待画图的时候可以泡杯茶等带X11窗口出现.
> 
> 好了，我决定接受这一行更改，当然你得帮忙先把标点和括号改过来。
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/yihui/r-ninja/pull/2/files#r629525
Do the following commands actually work? It seems you should wait for nickserv to reply if the login worked or not.
I believe you mean `lutil.jsonErr`. Test your error paths!
I agree about with your thoughts on the fluent interface. It would take more research and time so it's not necessary.

I like the idea of deprecating the old GetRange call and adding a new method.

For supporting both ranges, you're right about performance and not needing it yet. I was thinking we could add it for completeness but without a fluent interface it gets ugly. Lets leave it out for now.
Same with these styles. Were they intended for something else?
seems this may need the same guards as in the `if` statement below; can we consolidate this with the `if` statement somehow?
Any reason this ".button-bar" selector gets a ".color_editor ul" prefix but the other 8 below it don't?
Yeah, this is one of those stylistic things. I don't like just "new"ing something and not assigning it to something. But I should probably just get over that.
I spun this off as a new bug, #1411, since it seems like a pretty separate issue (and higher priority)
Changed the test root to rely on the getNativeBracketsDirectoryPath, which is compatible with brackets running in the browser. Note that getNativeBracketsDirectoryPath actually returns the current working directory (in this case test/).
Looking at addMenuItem(), the node with the id is not actually the top-level DOM node of the menu item: its parent `<li>` is.  So I think you need to do `$(_getHTMLMenuItem(commandID)).parent().remove();` (which is why your unit test is currently failing).
I removed ```Editor._getText()``` and ```Editor._setText()```, but left ```Editor._resetText()``` since it also wraps a bunch of non-CodeMirror logic that is shared by two callers.
in this loop you only add every other word, and we want to add CAPACITY words, so in the current form it adds half as many as we want
Yep. thanks
i would probably do ```datetime.datetime(start_year, start_month, datespan.enddate.day) + datespan.enddate.time()```
This behavior was kind of surprising. Is this a workaround for something or just your favorite way of failing "gracefully"
As said elsewhere `@example` generates an editable and evaluable example, which may not be what you want here.
Minor, but you can mix quotes in Ruby. This avoids those backslashes.

``` ruby
it "should not expose attributes that don't exist on the object" do
```
It would be nice not to change the header by using ALT+MAJ+F. Could you please set them back ? That may ease the automation of changes that could occur in them in the future.
No need for empty files.  You can delete these.
created_time  ... because it means "The time the post was initially published"
Combine into one: `{% load i18n facebook_tags %}`
Please be consistent. If we use `verbose_name`, then use it everywhere. If not, don't use it anywhere. (You can make everything consistent if something looks nicer to you.)
I actually prefer to just provide the REGEX for the user to implement on their side. We should at least avoid having to pass two None values.
carry on.
We can just add our license header to /tools/wrap.start and /tools/wrap.end too
As above - one line per attribute, not all inlined in a row
We do want to strip `opt_` prefixes from variable names in the doc.
Huh, hadn't realized it was 2.7 only. In that case, I don't think it's important enough to care.  the deltas are going to be less than 1 day most all the time.
After the phone talk, i understand it much better, i've changed it for this:
`
    Given there is an Agi Database
    When I start the Database 
    Then the initial state should be creating
    When I refresh the Agi Database 
    Then the state should change to available`
这段逻辑不应该在循环里面
:trollface: khoob shod nagofti ke ...
DONE , TNX
the i need to be initialized to 0 otherwise the cycle breaks
We also need a check if the path already exists. So why don't we just go back to your [original tempname](https://github.com/JuliaLang/julia/commit/d52852208cf0a9f99adc3869615ca4cbdee8767b#L0R255), and move the `tmpnam` call into `tempdir`?
Compare:
```
name=World
perl -e "print \"Hello $name\""
perl -e 'print "Hello $name"'
```
You may want to build rubygem-runcible in our Koji first. So it is available in our repos before this is merged.
works! will  resubmit
You might have to merge up to your master -- after merging your master up to VoltDB/voltdb (such as via my 282candidate pull request) -- to get the new syntax support.
Is the PIN code below the lock screen or above it? It should be above IMO.

If it's below, then Back key should really bring back the lock screen.

(can be done in a follow up)
Forgot about that, will make the changes
I agree, in fact I used that exact terminology in the user docs.
This is the kind of situation where I would just do `new_key = 'validate_' + key`.  It's more readable and much faster.  Using `join` only starts to benefit when joining together more than 2 long-ish strings.
I think @taldcroft raised this on the list, but not sure if there is an issue number.
I think this is a copy-and-paste error.
Oops.   How about

ends = np.cumsum(col_width)
starts = ends - col_width

I think the original [1:] and [:-1] were wrong also.

Anyway, I agree it doesn't *really* matter here.
Do we want to specify a "trusted location" that we'll use in Astropy?
`$node` could be `false` because the `ip2long`... This is why in a separated `if`.
I didn't find the link, but PHP disencourage the use of `{}` for index in strings. They recommend use the `[]` for many reasons.
if I can remember how!
``@return`` should be omitted when there is nothing special to put in it
Not all the msp430's have 3 CCR's. Check for __MSP430_HAS_TA3__ to prevent compiler error for those devices.
These steps need to be indented
Hi,

I get now why you wanted to merge the interfaces into one, because the 
RdfDrivers actually set up both rdf and dom, since they can have all 
those attributes and now also the tag name. I somehow overlooked that. 
Maybe it is actually a bit over-engineering to separate between the two.

I'm not yet sure, but I have a feeling that some the irritations might 
disappear if we change the Driver's expectations slightly. E.g. if we 
assume that they generally deal with rdf objects and then do checks like

     if ($property instanceof NodeInterface)
     {
         $property->set_attributes($values);
     }

This would allow us to evade using getNode or getRdfElement, but I guess 
for the sake of cleanness, they still have to be there. And the "end 
user-facing" interface is kind of shaky (although you could argue that 
the NodeInteface is the low-level api and the rdf one the high-level 
one, since it mostly is a subset of NodeInterface in terms of what you 
can do with it).

Another idea might be that only EntityInterface implements NodeInterface 
(so attributes, tagname etc. would only be set if an entity is 
instantiated, not for the "abstract" type), but I have to admit I'm kind 
of lost in the diff, too. At this point, I would leave the decision to 
you. I can merge as-is or we can go to a different version of your 
choice, just let me know. After all, it's a big chunk and you know 
better how it interacts than I do :-)



Am 30.07.12 22:45, schrieb David Buchmann:
>> @@ -0,0 +1,111 @@
>> +<?php
>> +
>> +namespace Midgard\CreatePHP\Type;
>> +
>> +/**
>> + * Common base interface for all type definitions
>> + *
>> + * @package Midgard.CreatePHP
>> + */
>> +
>> +interface NodeDefinitionInterface
>
> ok, pushed an update with the separation between node and rdf concept in the interfaces. also tried to make the metadata loader handle the distinction. the tests still pass, so it should work with our implementation.
>
> i suggest we do the cleanup of children / collections separatly. the current state there is not worse than before and i really start to lose the overview with this pull request. currently the entity is rendered with its collections and properties, so getChildDefinitions does not seem too wrong to me.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/flack/createphp/pull/12/files#r1267497
>

-- 
CONTENT CONTROL Berlin
Flack & Friedrich GbR

Urbanstr. 104a
10967 Berlin

Mob.: +49 (0) 177 565 1913
Tel.: +49 (0) 30 634 167 58
Fax : +49 (0) 30 843 142 90

Web: http://www.contentcontrol-berlin.de
Also be careful about objects starting with `.`
let's follow conventions and call this notebook_manager_class
This should read `from IPython.lib.xtdksiplay...`
However we implement `git merge FETCH_HEAD`, we're going to need to parse and keep this format in memory anyway, either so we take care of it automagically or so the user can know which commits to ask us to merge (and create the merge commit message).

In the former case, we probably shouldn't export it; in the latter we should open it up (or use a four-argument callback). Don't quite see the advantage of it being opaque.
not sure how hard it is to add but similar to the code in  `@select` and `filter`, it would be great if we can support a` body` inside the `@math` tag that would allow us to show if the math operation equals something.
```
{@math key="{$idx}" method="mod" operand="5"}
    {@eq key="$mathout" value="1"}
     show if $idx mod 5 === 1
  {/eq}
{/math}
```

or
```
{@math key="{$idx}" method="mod" operand="5" isEqualTo="1"} 
   show if $idx mod 5 === 1
{/math}
```
and the id can be passed in as the `pk` kwarg rather than appended later
Ah, I always wondered what out:H was for ;) Fixing
why the com.google.inject.Provider? The description of this pull makes it sound like you want to go javax.inject all the way.
Never mind. I read further down the page :P
Have you tested this change? I'm pretty sure it won't work.
You can simply do `$this->name = (string) $name;` below instead.
it should be $requestOrder right?
Two questions.  Why are you using static's here, and secondly, why are you not using a mock for Mongo?
I don't think it is. The verification is done in LdapAuthenficationProvider.
There is no reason to make it configurable IMO. The Console component requires commands to extend this class.
Ah ok, you misunderstood me.

Basically, keep the entire class as is and just wrap the ``get_class`` calls in ``fromDomainObject`` into ``ClassUtils::getRealClass`` calls. Maybe it makes even sense to move the ``get_class`` call to ClassUtils directly.

Same for the UserSecurityIdentity.
the second part of the check is wrong IMO. It will always return ``true`` as the assignment is done before the condition.
just let these be `None`, and don't create any pidfiles for which filenames weren't provided.

although if `master_pidfile` or `worker_pidfile` (or `notify_fifo`, see comment on line 39) is provided while `management_dir` is left `None` this should raise, since it won't know where to put those pidfiles.
Think you need to call `__chefvm_config $1` at the beginning of this method to get the configuration setup
Yes please!

You can keep it as a private int within the interface declaration in the .m file (as I'm sure you already know). Xcode will automagically generate the required synthesizer.
这一块我之前好像都忽视了，回头看了一下，貌似问题还不少
你可以试着新建一个issue吧，就叫整理bib好了
标准的说法应该独立行公式和内嵌行公式，我在实验室就是研究这方面的 :-)
Use guava Preconditions
s/optional/required
Or should it be a single channel greyscale since all the output channels will be the same?
`this.arch.setNode()` синхронная функция.
Она не в пользовательском коде, поэтому не стоит опасаться того, что она вернёт promise.
ah, got it. i misunderstood the triggering logic. k, merging this in.
@ursm what do you mean? Your comment confuses me.
`self.drag_obj = None`
should also be set in mouseReleaseEvent
Sorry about the comma and formatting changes. I hadn't realized I'd commited that.
It looks like you've taken care of it anyway.
remove these to be like the others
Pour ne pas mélanger le code de test et le code de prod, tu peux peut-être plutôt hériter de cette classe dans src/integration et rajouter cette méthode?
This method isn't called.
This entire class is unfortunate. It would be better to rename "ProcessLogger" to ProcessControllerLogger[1] and then move all of these methods to that class, getting rid of this one. But that would probably screw up the zanata stuff. (Same applies to ProcessMessages/ProtocolMessages.)

Failing that, WDYT about just dividing the 12000-12999 range used by this module into 4 chunks, 1 for each file?

[1] The rename is just me being anal.
Actually, these comments are all technically incorrect. The markup is configurable, use menu terminology, not tag names.
I will do some tests and see whats possible.
if all(isinstance(i, int) for i in (o, x, y)):
Note that these args mean: old_name, new_name, location where location is [row, col]
I was a little confused about what you were trying to do here (why the addition of a path variable??) but now I think I get it. I gather you were fixing a null ref exception? Presumably at some point, getting the parent iter is giving a bad iter result?

If this is the case, I'd suggest checking the return value from store.IterParent() (returns false if it fails) instead because getting a path for an invalid iter is undefined behavior.
This part is for debugging while message creation or text searching, so it will be removed.
Remove this comment, it does not bring much
`ev` -> `evt`
Not a big fan of having this living here especially with the todo L23

Dev-only stuff should not be with production code if we can avoid it.
FTR, most of this file hasn’t been translated.
nit: if you break it in 2 tests we'll have it nicely documented from looking at the tests results that we're dispatching the event *and* removing it from the updates queue.
This causes a weird state when the app frame becomes visible but the sprite opacity isn't full yet. 0.5s and 0.5s feels better.
Because in this case contact.note && contact.note.length was checked previously (L500), so it changes less code. We can add it anyway.
requirements explosion :(
How are we authenticating with this username?
Why didn´t I know about `spyOn` until now? It looks much more convenient than `sinon.spy` ... Is this use case somehow special?
can you remove these from your pull request - thanks!
The style we try to follow is to group up to 6 imports together like this:

```scala
import com.twitter.maple.hbase.{HBaseScheme, HBaseTap}
```
Why does this connect to localhost, when all the other clients always connect to `local_ip`?
Remove + from info file.
Why the empty string?
Indentation seems a bit screwey here..
Added the name of the Item being deleted to the deletion confirmation message.
I guess those errors don't include the effects of the uncertainty on the pixel values. At some point (and it doesn't have to be in this PR), we should figure out what the most general uncertainty is that would apply to data of any wavelength.
Not a *great* reason: to keep this "more modular" (only depending on numpy), and to make it slightly clearer what is being returned. I'm imagining that most of the time these functions will be not be used directly, but will instead be called from the Image class, which *would* output a Table object, possibly with a whole bunch of columns collected from different image finding or photometry functions, and metadata about the image or object-finding parameters. I haven't used Tables but initially it seems more natural to compile the Table and its metadata all at once instead of passing around many Table objects and then joining them and adding metadata at the end. Perhaps I'll have a new opinion upon using Tables though.

[Even if users are using this function directly, it won't impact them if this is expanded later: If we do add a `flags` return value (and I think we should), it would be an optional one that depends on some optional input, so it wouldn't affect existing code (just as bkgerr is now).]

All that said, I'm of course not fundamentally opposed to returning a Table, but I propose we wait and see how this is used by the Image class, if it will be used much directly, and if so, what is the most convenient form in which to return. As we discussed with @bretonr originally, it can be changed easily. It's certainly something we should keep in mind as we go.
`IRCContact`?
Meta is a separate option from + Esc... that confused me a lot
Looks like you moved instead of copied this file ;)
Should be a single & to check for a flag
I'm not sure, I must have misread the implementation of the method. I'll undo that change.
done in 86965c2f50a45c9f83c34d841532c02ef804f32d
Playing catchup, gonna change this again.  

There are new functions in jigoshop.class.php for 1.4 that provide version info that I would want to use instead of the define and they use get_plugin_data.
Alright, I did some homework. YAML.load will only load the first document, load_stream will load each document as separate elements in an array.

That said, I don't read anything that requires YAML files to have document header, so concatenation of multiple files isn't always horrible.

I can restrict YAML to one file only, but would you expect to raise an exception when there's more than one file?
I think my point is that we should make any changes we need on the manifest side + `resolve` function and we should not change loader. I'm also pretty confident we'll be able to do that ;)
ES.next won't allow dynamic properties / accessors as there is no exports object and imported modules  are not an objects. You import objects / functions that were marked for export. Solution there is to export an object with such getters, which may be an option here as well.

As for async API that you've outlined above, I think it would be better to have it from day one, since usually users don't like switching from sync APIs to async. Also implications of such change may be bigger than it usually is.

Finally your `then` callback can return object with getters / properties l10n which may be a good alternative.
> Mind naming it 'openPushlogSinceCurrentBuild'?

Renamed. Others too:
 * `menuitem` ids
 *  entities

Refactored original `nightly.openPushlog`.
We don't use this import in the test, so we can remove it.
oop, can you fix the indent?
Munging the load path in this way is a bad idea. Also, Rubygems already adds the gem's './lib' to the load path. To require relative files like this, its better to do `require File.join(File.dirname(__FILE__), "progress_bar", "base")`.
Agreed, will submit them later this week.
Why is this exposed? It doesn't need exposure.
Thanks, changed the url.
It's for the text color and border color of an invalid input. I'll add comments and/or look at if it can be done differently.
I'm not sure if return Zend\Date or DateTime objects are better here
Suspect a regression from a stale branch. Needs reinstating
Perfect, wasn't sure on the coding standard requirement in this area.
Thanks, Matthew!


Jessie Hernandez


On Tue, Dec 11, 2012 at 3:28 PM, weierophinney <notifications@github.com>wrote:

> In library/Zend/Soap/Client/DotNet.php:
>
> > +        $curlClient->write('POST', $uri, 1.1, $headers, $request);
> > +        $response = HttpResponse::fromString($curlClient->read());
> > +        $curlClient->close();
> > +
> > +        // Save headers
> > +        $this->lastRequestHeaders  = $this->flattenHeaders($headers);
> > +        $this->lastResponseHeaders = $response->getHeaders()->toString();
> > +
> > +        // Return only the XML body
> > +        return $response->getBody();
> > +    }
> > +
> > +    /**
> > +     * Returns the cURL client that is being used.
> > +     *
> > +     * @return \Zend\Http\Client\Adapter\Curl The cURL client.
>
> annotation value can be simply "CurlClient"; they're resolved based on
> imports and/or current namespace.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zendframework/zf2/pull/3202/files#r2384187>.
>
>
I think that a "suggest" is enough
Agreed. Thanks for catching that.
Again, mixed signals. [Here](https://github.com/zendframework/zf2/pull/1118#discussion_r784009) @weierophinney suggests not to split because it reduces readability. I think this is the case
make it a when-case statement
Okay that makes sense, now. So I push feature branches to `origin/feature/<featurename>`, and submit a pull request against that branch. As a GiveCRM contributor, if someone else does that, I do merge their feature branch into our `develop` branch, then (i.e. we don't want the main repo history full of people's deleted feature/hotfix branches)? If so, how? I'm assuming that rules out use of Github's automated pull request merging?
please use a class and move the style to the CSS file.
Whitespace-only change, would be better to delete this
not exactly sure if this change is required...
This will not work for Gedmo as it would only allow to add new children at the top lovel, not to modify existing ones
Well, based on what I could see on their respective trackers, they expect
/** @var $varName Type */, and this is what they generate.

The block one is indeed only @var Type, since it only documents one var
(the one below the block). In the foreach, you could perfectly document
both the key and the value, and this is the reason why the variable name is
added.
Preco je tu *2 ?
It's just an idea =) IMO it would be nice to get informed that I'm doing something wrong ;-)
I love making this configurable the way you did. I'll try and merge this one apart from the other changes.
Agreed! Unfortunately, this string has already been translated in 20+ locales, so I'd rather wait until the fabled redesign before changing it. :(
Ah. That's cool.
We tend not to write methods for functionality we're not using. It comes back to haunt you later when the locator changes. It's just deadweight. Only code what you need, it's faster too :)
Err, that should read Remove Extra Line. Put the comment on the wrong line and then wrote the wrong thing in the new one!
Removed because the temp fix is no longer needed as the x is no longer an anchor. http://code.google.com/p/otwarchive/issues/detail?id=2652
muahahaha, YES you will keep my debugging baggage!!!

I'll get it out of there in a second.

On Mar 26, 2012, at 6:47 PM, Michael Basnight wrote:

>> @@ -178,6 +178,8 @@ def find_image(self):
>>     @test
>>     def test_find_flavor(self):
>>         result = dbaas_admin.find_flavor_and_self_href(flavor_id=1)
>> +        print result
>> +        print instance_info.dbaas_flavor_href
> 
> Do we need to keep these prints in here?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/rackspace/reddwarf/pull/433/files#r606504
Nothing, I have no idea why git marks that as changed

On Thu, Nov 8, 2012 at 2:58 PM, brunoais <notifications@github.com> wrote:

> In jquery.sceditor.js:
>
> > @@ -3458,4 +3469,4 @@
> >  			(new $.sceditor(this, options));
> >  		});
> >  	};
> > -})(jQuery, window, document);
> > +})(jQuery, window, document);
>
> What was changed here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/samclarke/SCEditor/pull/34/files#r2069468>.
>
>
That part is now done.
```/tmp``` is usually cleaned up automatically on reboot; ```~/.berkshelf/tmp``` I'm less confident will be. I'm fine with either; I just transposed your code there.
They might or might not be the same. The problem is that I don't know what a `CircularAperture(20 * u.degree)` means say for the position `(lon, lat) = (0, 60)`. In `sky` coordinates I mean all pixels that have spherical distance less than 20 deg from that coordinate. Is that the same meaning for `world` coordinates?

http://www.astro.rug.nl/software/kapteyn/plot_directive/EXAMPLES/mu_skypolygons_allsky.hires.png
Don't really need this, this is just supposed to be saying how socket.io can be used with Express (you don't do this, though), not how Express works.
you should use ``$db = $this->getHelper('db')->getConnection()`` to get the connection directly IMO
do not hard code 'var', there's a setting for this...
Indeed... Good catch @lolautruche ! Will be fixed at merge time.
обычно не перемешивают приватные и публичные поля. а нужен ли он тебе публичным?
can you remove these comments, I added this field to the db.
are you deliberately ignoring group_id, level and number??? Could you not get 'leakage' form one group_Id to the next?
#后和注释内容之前应该留一个空白
This should use code rather than hardcoded 401?
Pengsu you changed this property name in the page object but it needs to be changed in the test too. Cheers :)
Might want to move this to `app/models/student.rb`.
Where would this url be used?
Absolutely, fixed.
It doesn't look like this is being used
This will need a check for a logged in user as well.
I think these 3 tests (public, loggedin, private) can be consolidated in the same way as what we did for testCommentPermissions
Couldn't this re-use the getRole code?
ie:
```javascript
that.hasAnyRole = function(objectType, objectId, callback) {
    that.getRole(objectType, objectId, function(role, err){
        if (err) {
            return callback(false, err);
        }
        callback(role !== null);
    });
}
```
If allow-tenant-stop is configurable, we should probably have a button where tenant admins can start/stop their server.
Actually, ignore this, I confused it with ``currentProblems``  :)
LOL. Will do.
True, there are no side-effect in this case (but since the method comes from an interface, implementers could have side-effects). Anyhow, I'm still of the idea that ``createSourceFile`` it's a better name, but won't stop you if you feel strong about changing this.
Yeah... I'm not either. lol
Need to factor this constant out somewhere - ApplicationModel?
согласен. со временем набью руку и перестану писать. пока пишу больше для себя.