Alter upgrade notes with changes to _form_is_choice_selected twig function
[EventDispatcher] Adding IteratorAggregate to GenericEvent
Typo in UPGRADE-2.1
[Form] Fixed support for preferred choices in "entity" type
[Form] Reintroduced the option "invalid_message_parameters"
merged branch fixe/patch-7 (PR #5272)

Commits
-------

4b5adcd Typo in UPGRADE-2.1

Discussion
----------

Typo in UPGRADE-2.1
fixed typo in the UPGRADE file
merged branch bschussek/issue5205 (PR #5277)

Commits
-------

3ad3876 [Form] Fixed support for preferred choices in "entity" type

Discussion
----------

[Form] Fixed support for preferred choices in "entity" type

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5205
Todo: -
merged branch bschussek/issue5144 (PR #5278)

Commits
-------

0add23f [Form] Reintroduced the option "invalid_message_parameters"

Discussion
----------

[Form] Reintroduced the option "invalid_message_parameters"

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5144
Todo: -
merged branch TomAdam/pr-choice-bc-doc (PR #5263)

Commits
-------

9e3e589 Alter upgrade notes with changes to _form_is_choice_selected twig function

Discussion
----------

Undocumented BC break - choice field type template

The upgrade notes for the choice field template are out of date. They currently state:

```
The `choices` variable now contains `ChoiceView` objects with two getters,
getValue() and getLabel(), to access the choice data.
```

However these methods do not exist. I assume this is the result of a rollback to maintain BC?

In addition to this, the `_form_is_choice_selected` twig function has been removed and replaced with a filter called `selectedchoice`. This is an undocumented BC break. I have attached an update to the notes to reflect these changes.

---------------------------------------------------------------------------

by fabpot at 2012-08-15T17:20:35Z

ping @bschussek

---------------------------------------------------------------------------

by bschussek at 2012-08-16T17:36:22Z

Looks good apart from my comment. Thanks for fixing this!
fixed typos in the UPGRADE file
[HttpFoundation] fix #5271 (duplicated header in JsonResponse)
[HttpFoundation] fixed undefined offset for assoc arrays in HeaderBag
merged branch Tobion/patch-3 (PR #5276)

Commits
-------

bdaa877 [HttpFoundation] fix #5271 (duplicated header in JsonResponse)

Discussion
----------

fix JsonResponse: duplicate header

fix #5271

---------------------------------------------------------------------------

by Tobion at 2012-08-16T16:50:04Z

Will look into the failing test later.

---------------------------------------------------------------------------

by Tobion at 2012-08-16T23:55:45Z

Finished.
merged branch Tobion/headerbag (PR #5282)

Commits
-------

ccb6dad [HttpFoundation] fixed undefined offset for assoc arrays in HeaderBag

Discussion
----------

[HttpFoundation] fixed undefined offset for assoc arrays in HeaderBag

`get` is assuming the headers are zero-indexed. So something like this would otherwise create a php warning.
```
$bag->set('foo', array('bad-assoc-index' => 'value'));
$this->assertSame('value', $bag->get('foo'));
```
added a missing phpdoc param
[FrameworkBundle] Allow to set null for the handler in NativeSessionStorage
fixes pre for var_dump with xdebug
merged branch bamarni/patch-5 (PR #5285)

Commits
-------

bd9319b added a missing phpdoc param

Discussion
----------

added a missing phpdoc param
merged branch drak/nullhandler (PR #5290)

Commits
-------

8e11aaa [FrameworkBundle] Allow to set null for the handler in NativeSessionStorage

Discussion
----------

[FrameworkBundle] Allow to set null for the handler in NativeSessionStorage

Bug fix: no
Feature addition: yes (ok for RC)
Backwards compatibility break: yes
Symfony2 tests pass: yes
Fixes the following tickets: 5267
Todo: ~
License of the code: MIT
Documentation PR: ~

Refs #5267

Adds the following configuration

```
session:
        handler_id: ~
```

Which allows the configuration of the session not to use any save handler and therefor just use whatever save_handler is set in `php.ini`

---------------------------------------------------------------------------

by dlsniper at 2012-08-17T17:24:37Z

:+1: