labofsahil/github-event-dataset-2012 huggingface dataset:
+1 to forcing tags to start with a-zA-Z. The regex for that would look like 

    tags = re.findall(r'(?:^|[^\w\\/])#([a-zA-Z_\.-][a-zA-Z0-9_\.-]*)(?:\b|$)', update)

Note that the `+` has become a `*`.
map2 { (implObj, implMeth) =>
Mhhh right! To be sure, I'll check the JVM spec, so we don't need to touch this again...
I believe that (at least) `Block` is missing here. Test with `class X(val x: Any) extends AnyVal { { "".isEmpty; "".isEmpty } }`
Suppose Joe comes tomorrow with an idea on how to improve the Scaladoc layout. And makes a change to the common html generation code. Does it make sense that presentation compiler tests start failing?
I changed the code back to using the direct function-pointer access.  It was much, much faster.   It makes me also wonder how much it is costing to do the ctypes type checks as well.
I would re-write this so it is like this:

fig = plt.figure()
ax = plt.subplot(111)
map.plot()
plt.colorbar()
ax.plot([-1000,1000], [0,0], color="white")
plt.show()
Well, no tests are needed now.  If, however, in the future `sdm_to_dict` becomes different from `sdp_to_dict`, then some tests should be added.  I thus think this TODO item is somewhat redundant.
`Basic.hash` doesn't work nicely with anonymous morphisms (note the composite morphism `g * f`):
```
In [20]: f = Morphism(A, B, "f"); g = Morphism(B, C, "g")

In [21]: g * f == g * f
Out[21]: True

In [22]: hash(g * f) == hash(g * f)
Out[22]: False
```

That's because anonymous morphisms store instances of `Dummy`, just as it (now) happens in `Object`.  I can only use `Symbol`'s in `Morphism` at all times; in this case an explicit `__hash__` will not be necessary.  Do you think I should do that?
Is it possible to restore the output as it was (remove unnecessary space symbols)?
If a variable is redundant, the two expressions can still be equal. I think I had an example of that in the branch I referred you to.
If a category can contain any kind of object, then any instance of Basic should work. So do you actually need the Object class at all?
if it's optional, it should start with opt_; such as opt_options. :)
All this IF content can go in the above IF, this way you don't even need the `unselect` variable.
see above .. this would mean that service providers are then bound to Silex .. complicating reuse in Cilex.
"This test take**s**"
Style: no braces for single-line if statements.
Awesome didn't know assets could be .js.erb!
could you check and see if changing the prerequisite or support of a question part actually works?

Qhenever I try to change the prerequisite or support while editing a multipart question, it doesn't let me change it
For common queries....
We do not return NSArray from maccore's public APIs, unless there is a strong reason to.   We use strongly typed C# arrays
Check w/ Craig if we want to double these actions in the menu or leave them as buttons only.
Please respect the 80 char limit. 
You can find more information about the coding style here http://mozweb.readthedocs.org/en/latest/coding.html
That is what I meant yes, a couple improvements though: 

- current might be renamed to currentRangeId so it's clearer what it is?
- current should be set to null after the for() loop is over, just to avoid the last value from leaking to some other current() use that would be at the wrong place. Eventually you could check for null in the fake() method and throw an exception to say that it shouldn't be used out of fixture ranges.
1. The line is too long.
2. Multiple ternary operators on one line.
See https://github.com/phpbb/phpbb3/pull/1082#discussion_r2130850
@nickvergessen @naderman That would be possible if there weren't two paths potentially to look in. It has to take style inheritance into account, so there is at least one and potentially two paths to look in, but looking at set_lang() it can only have one path.
`$return_value` ^^
Same applies to postgres, sqlite and firebird, so we could also just leave this function empty...
I really think things like this should not count that much.

The problem with the cast is the thing that needs to be resolved on this PR, everything else is working and does not need fixing now.
Remove the outer parentheses
Missing a middleware component here. We should be filtering out (at least) cookies before giving the response to the app.
Very good point, I'll add it.  (The old resource store was never really officially public, but we/me should still be careful to enumerate changes.)
agreed, I will adjust it.
This ValueError seems both unnecessary and inaccurate based on code below.
It's not a breaking change, just a \n at the end jrtc27.

It can be ignored.
I do like the fact that it's not a timestamp but a uuid it's a lot shorter too. Not to say that `monotonic-timestamp` is unreadable.
=== por favor
nit: addDrugformButton -> addDrugFormButton (capitalize the "F" to follow camelCasing)
don't need this function
I didn't see this change being done. I'll revert it.
Once ``search_tree()`` is a module-level function, change the four lines above to:

```
response_dict = search_tree({}, root)
```
Добавить `branch`, равный `master` по умолчанию
I think you can throw away `catch` block here
Did you want me to switch it back? Doesn't bother me, I usually just find it more readable with it at the end as opposed to the beginning.
Hmm, We can't really be sure that '/' equals to NodesController/promoted.  There are times where plugin has change the route.
should these links use the :ref:`text <link>` format, instead of trailing underscore?
Fair enough. `url` should never be passed in with a query string then?
"The version string can contain numbers and periods, such as 1.0.0. A gem is a ‘prerelease’ gem if the version has a letter in it, such as 1.0.0.pre." - [RubyGems Specification](http://guides.rubygems.org/specification-reference/#version)

also good to know [RationalVersioningPolicy](http://docs.rubygems.org/read/chapter/7#page26) and [Summary](http://docs.rubygems.org/read/chapter/7#page28)
@RickEyre I don't think the binary flag (a combination of -text and -diff) should be used as we may want text-style diffs instead of binary. -text should be sufficient. -crlf can actually be removed as it is for backwards compatibility purposes.

See: http://git-scm.com/docs/gitattributes (see "Checking-out and checking-in")
* 処理の固まりをブロックに分けて記述がすっきりしましたが、year, monthなどはここで参照されているため、やはり変数のスコープが長いです。例えばラベルのテキスト用の変数を用意し、textを事前に作っておくなどすると良いでしょう。寿命の長い変数は極力少なくします。
This is a nice API.
Since i modificated this method anyway, i decided to yanked some bytes and make a couple optimizations, is it a bad intention?
Totally agreed with you Dave regarding where deprecate.js is to be located. Though I dunno if it's worth the hassle and size bump. I think we'd be fine with deprecate.js containing what can be safely removed without this kind of trickeries involved. For instance, if we had had deprecate.js back in 1.7.x, I wouldn't have ducked punched $.Deferred just to add isResolved and isRejected, I would have let them in deferred.js.
Is there any way to wrap this in a `safe_system` call or anything like that?  I don't like that this is the first `git` call in the `pull` function.....
```
brew audit mariadb 
mariadb:
 * stable version 5.5.27 is redundant with version scanned from URL

Error: 1 problems in 1 formulae
```

version is not needed here. It's parsed automatically. Parsing is preferred because for the next small version bump, you don't have to remember to change "version", too.
But it can happen the displayname is available for reading only by the authenticated user; in this case, being able to find the user by login name is (much) better than nothing...
Supprime plutot que de commenter quelque chose qui ne marche pas
That would also be useful to have. I need support for an ordinary string too because in this case my config is being read from an example file.
That works to, though ^user's

Yes, I agree we should say that running this function when there is no existing vote has no adverse effect.
btw, I'd test for unknown states as well and refuse them
Please never use hardcoded  "/home/user" path, always use paths defined in WAConstants, as they differ according to current user (user/ developer). But don't worry about it this time I'll update them ;)
@fat return this.json.dependencies[pkg.name] or just return undefined?
I know, I understand the consideration…but I must plug my plan to kill the `www.` wherever possible…
As a strategy on general objects, this isn't a good idea, since it will sort ["AB", "Z"] before ["A", "ZZ"], which is usually not the intent.

We might get away with it here, but I'd rather do two different checks.
should be \UnexpectedValueException
Should we include tests to verify this works as expected? (even if they require the use of a fixture rather than a real feed)
JSLint complains about this: needs to be moved higher up the file, and the .replace() lines need to be indented more.
Actually, by passing true, the data is *always* fetched. It seems safest to just call the public API.
These strings also need to be removed from the French strings.js.

FYI, I also see these string variables defined in test/perf/OpenFile-perf-files/brackets-concat.js. This seems to be separated and safe, but I am wondering if this may cause some confusion?
Ooops, I misread this one.
I think the issue is that it assumes the dropdown is itself contained in an <li> (because it's intended to be used inside a top-level menubar).
"NativeApp.closeAllLiveBrowsers" should be "NativeApp.closeAllLiveBrowsers timeout"
brackets.ready() has been replaced with AppInit.appReady(). See #1425 (remove brackets.ready()) and #1464 (final naming) for details.
I'll be adding the `data-minSize` event in the next iteration, then.

About extensions, I also hit that same issue. I think scanning the DOM on `appReady` solves it in the case the extension adds the html to the DOM on `htmlReady` but not for any others.

Please, send me a copy of your extension. I'd love to see it! I'll try to see if the Resizer module can be improve somehow to get a better workflow.
Where was this initiated before?
Looks like you added this to fix an screen-flash artifact that you get if you use fadVisible on something that starts out hidden? Is it possible you could fix this in fadeVisible by having it check whether something's hidden, and then only apply the fade in/out effect if it's hiddenness doesn't already match up with the value? Or is fadeVisibleInOnly legitimately a different desired effect?
```data.extend({'value': self.remote_forms[self.xmlns_app_key(f['xmlns'], app_id)]} for f in all_forms)```
No, the panel should be one, because the data is ONLY in the aesthetics.
You need to free the returned tree entry, after having created the Ruby object.
We should probably just file it, but I have no problems doing it.
Yeah, I'll file another ticket on this
Externalize images so they will cache.  Why embed?
lint error below because you need a comma here
omg. seriously.

This might be what was hurting Scott. :/
Ryan are you going to re-commit with this or shall I merge and that can be fixed later?
Do we still want this?  I'm guessing this is the temporary change we can make to enable the signup page.  It doesn't look like a UI styling kind of change.
I like the idea, i've left it with the non nil way: `@pending_modified_values || {}`
Added the sanity checks!
contains a function named ```foo```, then the function could be called with:
ok would like to avoid
对齐空两个空格就可以了。
nämähän voisi olla refaktoroida yhdeksi metodikutsuksi, joka ottaa requestin ja Stringin?
Do you need elephantbird for the job runner too?
The classname needs a change
Hmm. What to do with `itemat()`.
We still do. Performance is unimportant here. Unless someone is planning on
dumping enormous data structures using this.

On Tue, May 29, 2012 at 9:36 AM, pao <
reply@reply.github.com
> wrote:

> > +            end
> > +        end
> > +    else
> > +        println(io, x)
> > +    end
> > +end
> > +function dump(io::IOStream, x::Array{Any}, n::Int, indent)
> > +    println("Array($(eltype(x)),$(size(x)))")
> > +    if n > 0
> > +        for i in 1:min(10, length(x))
> > +            print(io, indent, "  ", i, ": ")
> > +            dump(io, x[i], n - 1, strcat(indent, "  "))
> > +        end
> > +    end
> > +end
> > +dump(io::IOStream, x::AbstractKind, n::Int, indent) = println(io,
> typeof(x), " ", x)
>
> I thought we still had problems with inlining functional arguments,
> though. Although `dump` probably isn't performance critical.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/JuliaLang/julia/pull/887/files#r892093
>
Sry, this is the place where it will be missing https://github.com/Katello/katello/blob/master/katello-configure/modules/katello/manifests/init.pp#L13
Here is the fix
1. (string concatenation) and 
2. (createElement, setAttribute, and appendChild) were both my choices when I implemented.
3. (Using the HTML templates, cloneNode, setAttribute and appendChild) was also one of my options.
This is a good question that which way to use, considering speed, code management, UI look and feel...
I will take this issue in a follow up then figure out which one is most suitable for Music App implementation.
> this is somewhat tricky at the moment given that the app manifests aren't served from their real origins

That’s the part I hadn’t understood: I assumed we *want* to serve our own app manifests locally.

Now I have to think about it properly, I’ll get back with a better patch proposal ASAP.
Huh... yeah, that's probably worth clarifying somewhere whenever you get around to it... or if there's some clever way you can auto-convert to a tuple if all of the elements are column names (without a major performance loss), then maybe it isn't necessary to put in the docs.

Regardless, I'll update the example.  The odd thing, though, is that this does almost work as-is.  As you can see below, it still works, but the `names` attribute is messed up, even though the array itself is fine.

```
t[['a','c','b']]
Out[24]: 
<Table rows=5 names=('a','b','c')>
array([(0, 2, 1), (3, 5, 4), (6, 8, 7), (9, 11, 10), (12, 14, 13)], 
      dtype=[('a', '<i8'), ('c', '<i8'), ('b', '<i8')])

t['a','c','b']
Out[25]: 
<Table rows=5 names=('a','c','b')>
array([(0, 2, 1), (3, 5, 4), (6, 8, 7), (9, 11, 10), (12, 14, 13)], 
      dtype=[('a', '<i8'), ('c', '<i8'), ('b', '<i8')])
```
I'll add an `__all__`.
The first time they are needed is fine.
The reason for this is so that in a mixed cluster the upgraded nodes can differentiate between old/new status and display both.  If you have a cleaner way happy to hear it.
shouldn't there be a catchall case here for when none of the guarded versions are satisfied, throwing an error?
Get rid of blank line.
A final update, which only removes this line was pushed ^^.
Don't assume error() is simply printf && return false
"Diese Ebene unterstützt die Abfrage mittels Rechteck nicht (WFS GetFeature)."
okay, i will remove it.
CS issue here too
Why not go

```ruby
if @motions_not_voted && @motions_voted
```
This line should not be indented.
It is the context, not an actual part of the patch. This line is not removed.
This is actually not correct, updating spec.
wrong docstring.
> From: Adrian Cole <reply
>
+p-901027-07ff4d2aa6b153e2ad11a7b886410b2a663a0d72-1453210@reply.github.com>
> To: Kenneth Nagin/Haifa/IBM@IBMIL,
> Date: 30/05/2012 06:59 PM
> Subject: Re: [jclouds] Added container handling methods and tests (#654)
>
> >        return metadata;
> >     }
> > +   /**
> > +    * Parse Metadata for the container object from the original
JsonBall.
> > +    * System metadata data is prefixed with cdmi.
> > +    * System ACL metadata data is prefixed with cdmi_acl
> > +    *
> > +    */
> > +   private void parseMetadata() {
>
> I understand what you are doing here.  we need to refactor this once
> we switch to jackson which enforces use of constructors, as this
> should be done only during construction time.
I agree; this solution is ugly.  I wanted to insert this in parseMetadata()
in the method where the raw metadata was copied
but I could not find the hock.
-K
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jclouds/jclouds/pull/654/files#r901027
>
As far as I can tell you never use `req`?
Not a fan. I'm extremely wary of letting the user return arbitrary error codes. Error codes are our own; letting the user override them is asking for confusion and/or trouble.

My suggested idiom has always been storing the user's return value on the user's payload -- that's basically why it's there. Do you have anything against that?
Good point, though we should be able to get this by moving the commit and link checks above the executable bits check, shouldn't we?
Should these strings be localizable?
Remove en-US from this link.
This does an ES hit, but there's no try/except handling here for when ES is down, sad, finicky, etc.

Probably want to either document that it throws all the errors and handle them at the place it gets called, or handle it here and return an empty list or something.
You don't ever use this variable.
I see no ``update_product_adu`` in the list, was that meant to be ``update_adu``?
the investigation leads to PR919.  this change in testCrashStorage will be withdrawn once PR919 is accepted.
Please put these back in the `main` function, for now.
Sounds good. I will try to get it done in the next couple of days
sakai.forums is already in here so nothing to do
For an invalid argument ?
I would vote for keeping the previous way here by not returning anything on success as we don't need to change the status code.
missing `!isset['scheme']` ?
You're right, I made them private now. Also, the environment is now lazily injected into the renderer engine.
Here the function ````is_callable```` will only work if ````$controller[0]```` is an object.
So either the line

    'class'  => is_object($controller[0]) ? get_class($controller[0]) : $controller[0]

can be changed to

    'class'  => get_class($controller[0])

or this line should be changed to

    if(is_callable($controller) || method_exists($controller[0], '__call'))

After the if you can also add the folling

    $r = new \ReflectionClass($controller[0]);

Then you can add the file name

    'file'   => $r->getFilename(),

instead of n/a and for the line you can add

    'line'   => $r->getMethod('__call')->getStartLine()
I will use stloyd's suggestion:

    0 === strpos('- ', $this->currentLine)
I don't think there's another way to do it as cleanly.  Basically my idea was to have Photo extend Commentable, and then create a new post with a link to the photo in the news feed.  That could be a special photo post, which would allow us to cascade delete from the Photo to the photo post.
maybe rename it to `receiveContactsEndorsement:(BOOL)receiveContactsEndorsement`
It's being taken advantage of in the User model. That specifically why I put it in here.
这个在注释里，而且是在listing里，还需要这样么？窃以为在这儿还是没有必要的~
+details 
@see examletoot.cpp
+ cite  DGCI
+ describe template types
Pretty sure you need min=2 here...
Wellicht is `n_sent` beter.
Why do we need this space ?
should `TargetActionSupport` also be ticked?
at travis-ci we're actually using ember.js without using it's router. i guess that's not that an unusual case, so ...
Would this be better implemented in `qt4/mimedata.py`?
I think that from a technical perspective it may possible to use ServiceName here instead of String... but basically that requires the user to put JBoss MSC on the classpath, which effectively bypasses JBoss Modules for it. This class is used to launch the server from the outside, i.e. an environment where you have a simple java app with a classpath etc. I thought it would be better to not introduce the requirement to share JBoss MSC jars across boundaries on the API level. 
Note that this class already requires some other classes to be shared with the outside (i.e. ModelControllerClient) but I didn't want to increase that list for the reason I explained. If you think it would definitely be better to use ServiceName I can see if I can change that
Just realized that before and after also have the new style signatures
stz -> setTimezone
The reason why we add updateInputHeight for updating both input height and bottom toolbar height is for multiline input textfield. You may have check input height and toolbar height in multiline status after removing the height update.
Nope, I used it only for debugging purposes.  it wasn't filtered out. thanks!
IIRC we can unprefix this IIRC ?
|origin| is unused.
`Open Sans`
I think the main difference is if we have an object that inherit Function, called "EvmeFunction" for example,
typeof will return EvmeFunction
instanceof Function will return true
yep and more efficient
OK! Let me try that ;-)
adding a rule for `li:target` would make sense as well
See https://github.com/projectkudu/kudu/blob/master/Kudu.Services.Web/msbuild/Microsoft/VisualStudio/Kudu.targets
This translation is now in english, why?
Good catch - added this in, but I'm not sure about the text on the error message. Any advice here?
So, here's the deal: I need to create a constraint between the scratch and target variables, and creating a constraint requires a proxy.  Right now the `scratch` function creates both the variable and the constraint--so it needs a proxy, but it can't create a scratch proxy until it's done, because the scratch proxy uses the constraint.  So it creates a variable proxy, creates the constraint, then passes the proxy to `makeScratchProxy` which extends it to be a scratch proxy.

I can have `makeScratchProxy` take just a variable if it creates the constraint instead of `scratch`, but that will require proxies for the target and error variables.  Like so:
```function makeScratchProxy(vv, target, error)```
Does that sound better?
Got it and thanks.
In theory, people could append branches that way; in practice, bzr strongly encourages "directory <-> branch" thinking in the way shared repos are set up and in other ways.  I thought the more likely error would be for people to omit the trailing slash on baseURL.  It's a judgment call, though, so either way.

Totally cool with using the join method, though; will push something here in a bit.
I could remove cryptSHA1, its just there to support all but plain of the basic-authentication type apache understands. To just support crypt (max 8 characters) is not nice too. With md5 for mod_svn it's possible to use the same htpasswd for svn and buildbot.
Maybe "if codebases is not None" ... otherwise something like 'codebases=[]' would make it past here and fail strangely later on, since your check for "is a dict" never happened.
Can cache uncompressed_size too?
Argh, this language!!! o_O

Anyway, isn't there an upcast to CCObject * happening, since in this case "this" is a subclass of CCObject*?

Or should I change to something like:

    dynamic_cast<void*>(pTarget) == dynamic_cast<void*>(TARGET)

just to be sure?
... that was the easiest way that I could think of to track the state of the resque job without having to install an additional gem like resque-status. I really just want to avoid running this job twice for the same person, but I guess since I already have to write something in the DB, why not track the status, maybe we want to display it to the user in some ajaxy way...
I suppose that ShowReceiverId is better name for this flag as "uid" is used nowhere in qutIM
Storing a list in `..._length` comes unexpected. What about `..._queue` or just `multi_bulk`
have we started to add `autor` and `since` docblocks?
In any case, if we try to pass `nil` (without existed params entry)

   issues_enabled: params[:issues_enabled]

then we have error `issues_enabled can't be null`.

Any way I change this part of code, so from now it looks cleanest, IMHO.
Needs to go back to checking for id
per our conversation on irc i will review es_http output for guidance on this
faz sentido
You're right, this change is not relevant to this pull request and we should discuss that separately.
Sorry, I meant `require('api-utils/loader').load`. We are not lost ;)
So if they are different instances, it means that we are loading loader.js two times:
One in bootstrap.js, via `Cu.import(loaderURI)` and a second time via the loader itself on `require(api/utils/loader)` in runner.js?
Can't we avoid that?
maybe another `iframe` inside of `iframe`? ;)
this seems confusing and magical to me.  Why do you need to explicitly require algorithms to load them?  Could this possibly happen on demand?
oh, good point.  When I removed the list option, I missed the message in the type error.
We should be able to simplify (and hopefully speed up a lot) this query to group by rev_host. This would obviate the manual counting of urls within a domain.
I don't think we need another level here. Contributors only have a name and nothing else. So an array with strings would be sufficient.
@pcarlisle I removed the duplicate line
@danrasband @justinko Does this need to happen via RSpec config? Any reason not to just set `Rails.application = xxx`?
will remove it. but i see why people would like to have that. but in this case i'm for consistency
this is not the right thing to do… it adds a new instance on each element
yeah, but we support node 0.4.x at the moment
Since you don't enforce the target element as a hard dependency in something like `__construct`, maybe this should be `@return ElementInterface|null`
This is less clear than what is there as `checked=""` is still [checked in HTML5](http://www.w3.org/TR/html5/common-microsyntaxes.html#boolean-attributes). DUEL allows you to pass a boolean value into boolean attributes in order to toggle the result.
I upgraded the es5-shim with a fixed version. Can you remove this fix and see if it works correctly?
remove this file. should be in your global gitignore.
Good point, I've moved this into a model callback as advised. Ready to
review.

On 14 November 2012 13:29, Alex Tomlins <notifications@github.com> wrote:

> In app/controllers/admin/business_support_schemes_controller.rb:
>
> > @@ -0,0 +1,51 @@
> > +class Admin::BusinessSupportSchemesController < InheritedResources::Base
> > +  include Admin::AdminControllerMixin
> > +
> > +  actions :all, :only => [:index, :edit, :update]
> > +
> > +  before_filter :find_all_facets, :only => [:new, :edit]
> > +
> > +  def index
> > +    @schemes = BusinessSupportScheme.asc(:title)
> > +  end
> > +
> > +  def new
> > +    @scheme = BusinessSupportScheme.new(
> > +      business_support_identifier: BusinessSupportScheme.next_identifier)
>
> This is prone to race conditions if 2 people are creating schemes at the
> same time. It would be better to set this in a before_validation callback
> on the model.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alphagov/imminence/pull/20/files#r2123553>.
>
>
This is the right location for these links; it will show up in the Reference/API section when the docs are correctly processed.

Should add a description of 'query' here: i.e., it's a dict?
same as for temp_view. should be renamed `raw_view` imo . (can be prefixed by `get` eventually.
Please don't do this. Renaming a protected property is a BC break (for people extending the class) so it cannot be done until Doctrine 3
Getting a lot of these warnings for the line:

Use of uninitialized value in sort at dw/cgi-bin/LJ/S2.pm line 1975.

That seems to happen when we have the viewing user in a group (@ingroups) but there are no entries with that tag and custom group combination.
I don't get why this uses the amrkdown file header mechanism. Care to explain? Does ascii doc does the same kind of things? If yes, that would be better to not talk about markdown here, as it's a bit misleading :)
Fixed properly by using module generator functions.
I did that already, everywhere where "GCC" and "Intel" is being used.
only print if changed?
Proper link is: `https://dev.twitter.com/docs/auth/oauth`
yes
1) there are not buggy browsers
2) it will work same everywhere.
Yeah. What @Osmose said. It's included in the form media here: https://github.com/mozilla/django-browserid/blob/master/django_browserid/forms.py#L13
I am pretty sure you need to pass in both new and old options, no?

Also, seeing how tests pass and you did not catch it, add that to the test too, that new and old options exist as function params.
Yup, it's supposed to be there. For some reason, it's out of sync with "Chapters" if you don't include the space.
you can use Foreman.uuid method instead
I think you have this flipped. It should be `fr-FR`, but either way, if I recall correctly, and someone else should correct me here, Zotero really only looks the two letter codes (i.e. `fr`) or was it three letter? (`fre`)
I don't think this regex is doing exactly what you're intending. It's trying to match `http://bofip.impots.gouv.fr/bofip/ext` or `simple/recherche` or `simple`, etc. I think you want `http:\/\/bofip\.impots\.gouv\.fr\/bofip\/(?:ext|simple\/recherche|simple|codename|avancee|date)\/.+`
Committed fixes for these copy and paste errors in the function comments.
nit: if you make this `<p class="question">` it will make the question bolded (which we generally try to do to separate the "question" from the rest of the problem)
fruitlessly is a great word.
I haven't looked at the code, but the exercises that say something like "Uh oh, somebody made some mistakes. Fix them" probably use this.
...remove
JavaScript should always be at the bottom of the page - it gives the affect of lower page loading times.

http://developer.yahoo.com/blogs/ydn/posts/2007/07/high_performanc_5/

On 5 Aug 2012, at 18:32, MSuhajda wrote:

>> +
>> +		var http = require('http');
>> +		
>> +That's it. You required the http module provided by Node. Still using the default Node functions, you need to create a basic web server (code always goes below each other):
>> +
>> +		http.createServer(function (req, res) {
>> +			res.writeHead(200, {'Content-Type': 'text/plain'});
>> +			res.end('Hello World\n');
>> +		}).listen(8080, '127.0.0.1');
>> +		console.log('Server running at http://127.0.0.1:8080/');
>> +
>> +If you have any problems with this code, please look into the HTTP module at the NodeJS documentation: <http://nodejs.org/api/>
>> +
>> +Make sure your server is listening on port 8080 (or any other port you want), then move on to the client side and write the socket connecting part.
>> +
>> +		<head>
> 
> Libraries (like jquery, etc) are used to be included there.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/callumacrae/lynx.io/pull/5/files#r1308351
(except ImportError)
maybe can rename this method to "should"?
у тебя же typedef
@stupchiy , this change that cvan has made will mean you can get the logout locator you want :)
Small nit we don't have a test that uses this locator:
<code>
m8ttyb:Addon-Tests matt$ grep -rn relevance .
./pages/desktop/regions/sorter.py:18:    _sort_by_relevance_locator = (By.XPATH, "//div[@id='sorter']//li/a[normalize-space(text())='Relevance']")
./pages/desktop/regions/sorter.py:41:        if type.replace(' ', '_').lower() in ["featured", "relevance", "most_users", "top_rated", "newest"]:
</code>
You may very well be right.  I inherited some other Web code, which I have since discarded, that needed this type of hack since the socket was bound to another object and was being deleted before all data had been transmitted.  I'll remove this patch and verify correct behavior.
and swallow?  or re-throw?  also it would be cool to be able to optionally pass the exception class so that you could limit it as much as possible when appropriate.
The only reason I tend to put those async calls before is because I know what happens in `getUser`, but we can never be sure what code is in the callback. So if someone passes in a bogus callback that throws an exception in the same tick, then we end up with an updated user that didn't get re-indexed. I'd like to keep it the way it is if you agree it is more robust.
This can now be removed.
Only to implement 'scalaClasspath'. I should probably narrow it down from `private[eclipse]` to fully `private`.
I still need to set a timeout for this
added: function checkNotification(service)
hmm you changed this but it does return true below haha
Um, needs to comply with the style guide (http://codeigniter.com/user_guide/general/styleguide.html):

    if ( ! empty($data) && ! is_array($data))
    {
        $data = array('name' => $data);
    }

... also add empty lines after line 448 and before 449/450, for better readability.
Same for `form_button()` and the changelog entry should probably be altered as well.
Представте себе, что наше задание поменялось и теперь нужно сделать всё тоже самое но для массива длинною 120 элементов. Вам прийдётся отыскивать все упоминания цифры 100 и 99 по вашему коду и менять их на новое значение. Если бы вы использовали переменную для хранения длинны масива, то вам пришлось бы изменить только её значение, не тратя время на просмотр кода. Настоятельно рекомендую =)
Спасибо. Уже поправила:)
замена самого на себя - вполне себе замена. Об это нигде в условиях задачи нет. а вот порядок выбора случайных элементов для замены напоминает реализацию random(){return 4;}
:)
@s1dney Gracias ))
Oh! Ok, So please let me to change the variable names.
why this new function here?
can we consider using utils.forEach() here
@rnixx can you please review at this change, since you have refactored unicode support?
@etiennesegonzac In my opinion we should land this PR asap and then we could polish with the ideas that we have talked above, but mainly we have to ensure that it works testing, testing and testing with all SIM Cards available. What do you think?
Can we document this guy?
Two comments on this line:

1. Please call it "toggle reflow mode" rather than "page" because: a) the mode affects the whole document, not just the current page, b) that is what Adobe calls it and c) that is what the variable itsef is called (what is good for programmers is good for users) 

2. It is unfortunate that the `R` command is at the end (even after Exit commands), but I understand the reason. The only way to overcome it would to add it in unireader and delete in all modules other than PDF, but this is a bit ugly.... (the proper place for the command would be to place it before the `Shift-R` command).
Any reason merge_attributes & add_attributes are seperate?  Looks like they are each only used once.
Use explicit imports plox.
What I suggested is that it is more practical to have the slugified part at the end of the url, not that I can't reproduce the short version... :-)
Better not to reshape but rather write multiple nchan x nsamp FIFF_EPOCH tags OR write a 3D matrix. 3D matrix I/O should be already present in the MNE-Matlab code.
It can probably be done, but the code would be much more complicated; have a look at matplotlib.image.thumbnail. I don't think having this dependency on PIL should be a big problem, as it is only needed when building the doc, which is something only few people do. Also, PIL is a part of EPD and most users will have it.
e is not used. enumerate of range is not necessary
I know but It will make examples less readable and I though windows users could edit these lines.
Until we have have complaints from windows users I vote to keep it like this if you're ok.
Also, why do delete explicitly instead of calling `model.unindex` ?
When we add a declarative mapping, we can use the order defined there to dictate the order values_list is returned in. Until then... I'm not sure. Is elasticsearch consistent at all in the way the fields are returned?
Yes I would do that, but my comment was more about adding a ``tearDown`` method that wipes every item that you have created in the database (including the users).

This will increase the test running time but It would ensure that every test has a clean state before it is ran.
Actually it should be if ( ! (name.isFullySpecifiedName() || name.isLocalePreferred() ) { in order to match what was in the validator.
Hey @sadache .  I still can't figure out what you were trying to say.  I think perhaps you don't understand what's happening in this example.  I made a Java controller and named its class JavaControllerInstance.  Then when a request hits /json_java_instance, the JavaControllerInstance class is instantiated and its index() method is called.  I also created a separate controller with a separate class named ScalaControllerInstance just to prove that there would be no problem instantiating either a Java or Scala controller and calling a method on it.

Please get back to me so that this pull request can be either committed or updated as necessary.
Use `this.colCount` and `this.rowCount`
AFAIK, there is an easy way to get the type of vcs with `vcs_info`.

http://zsh.sourceforge.net/Doc/Release/User-Contributions.html#Version-Control-Information

%s
The VCS in use (git, hg, svn, etc.).
发送 =>发生
.....的时间。
强调下时间。
но у тебя так же, емнип
Pero ese no tiene atributo `DataType`.
Guarda con el tipo de `Lisen` por `Listen`.
This method makes a database query for each previous sibling. You can optimise this method by calling a all siblings at once:
```python
for sibling in self.get_siblings(True):
    if sibling == self:
        break
```

But the best way is to make the calculation in the db:
```python
@property
def sibling_count(self):
    return self.get_siblings(True).filter(lft__lte=self.lft).count()
```
CATEGORY, perhaps?
Yup, determined by fair dice roll, guaranteed to be random
I think its because as an interface we're stating that subclasses should have carnal knowledge of this field. Just seems cleaner and more flexible if the _validate methods only edit the version of the dict they get as an argument.

This way if we later change it so that is_valid returns the dictionary instead of true or false code calling is_valid could just read the returned dictionary, and we wouldn't need the instance field. 

It will also make implementations of _validate a smidge easier to unit test.
I welcome an alternative solution.
In C++, Java, etc having the value on the left of a comparison that can't be part of an assignment is hip because it prevents accidental assignment. 

In Python we don't have to worry about that, but I've come to like it this way when the literal is small (i.e. "(0 == some_verbose_system_function(...etc..)") because the operator comes into view sooner making the expression easier on the eyes.  I vote we remain neutral on this.
while (!es.awaitTermination(100, TimeUnit.MILLISECONDS)); ?
(nanos seems a bit excessive, and I'm not really fussed about waiting for too long)
I second @WeatherGod's note above about defaults.  The codebase is not consistent about this, but from experience, having "None" be "default" is definitely the preferred way forward.
I think that's something we'll move to for the next release -- perhaps putting duplicates of the 1.1.1 release there as well at the same time.
Hrmph. Zamboni uses single quotes. Difficult context switch.
consider using named arguments for python formating:
e.g. url('%(url_path)s')
"/* logicalurl('%(logical_path)s') */"
"take the existing ecosystem into account if we are to create successful PSRs."  Hear hear. :-)
This is a test with 3rd parameter $do_it = false. This parameter means that backquoting will . This test is copied from similar one
Correct, this no longer needs to be hidden.
It might be because the save happens too fast.
You really don't like putting them apidocs in, do you? :smile:
Is there a unit test for this builder?
I added the addCACert function which should work for us.
加号前后的空格～
"what"? Ich glaub du meist

![](http://cdn.shopify.com/s/files/1/0070/7032/files/wat_grande.jpg)
yes, `getNonemptySequenceType` I forgot on it
please use 4 spaces per level for the indentation instead of tabs
Oops, yep
Want to remove these commented-out debugging aids before this gets merged?
it's in the test suite, which is linted.
Thank you for pointing me to that. I like this very much. Let me check.

Yes, I think that should be changed too. It is also not named correctly. Much better would be `user_connect` and `user_disconnect`. Because maybe also some other functionality of the webpage will hook to that. Not only user list display.

And the same here. `post_new` will maybe update wall. But maybe something else later on will do the something.

So please fix also for user list. :-) (This all counts towards higher grade. :-) )
Aqui está dando timeout, vou dar uma olhada então.
setHttpCode ?
Unless you're planning on adding/removing pipes to/from the pipeline later, you can just pass the config straight to the Pipeline constructor and skip `add()`.
My bad, I've pushed the Gemfile with no dupe aws/ses entry.

Steve

On 23 July 2012 16:35, James Abley <
reply@reply.github.com
> wrote:

> > @@ -7,6 +7,9 @@ gem "bson_ext", "~> 1.5"
> >
> >  gem 'aws-ses', require: 'aws/ses'
> >
> > +gem 'aws-ses', :require => 'aws/ses' # Needed by exception_notification
>
> Might be just my ruby noobness, but this looks a little odd when compared
> with line 8. Are they both needed?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/alphagov/review-o-matic/pull/1/files#r1216333
>
I believe this is not an abstract class - otherwise it looks good.
You probably don't pass anything to a class. What did you mean here exactly?
It would be great if this method could be renamed so that it was clear that it relates to the gender attribute - `dropdown_list` is too generic. Perhaps `gender_select_options`?
pf::config.
Ok will fix.
I think this file is unnecessary here.
It's there so that checkin does not get called when a timeout is raised. Maybe a comment should be added?
According to python doc, find_library() te library name should be without any prefix like lib, suffix like .so, .dylib or version number. So I doubt os.path.join  with absolute path will work. There has to be a different way how to force find_library() to find lib in right place and not passing absolute path to it.
Is `self.target_attr` useful at this point of the code development? Should we keep that for a further version?
I don't think dummy variables is explained anywhere. Aren't those just internal.

dummy variables reminds me of binary exog, so a better name might be useful in the documentation (if they are user visible)
Could you split this off into a different commit?
Effectivement, pas très familier avec HAML ;-)
Please import this statement rather use the global namespace
It should be `piplmesh.frontend`.
same here (yeah, I know it was already there in the first place)
Actually, thinking about it twice. Setting it to "null" is not required. Not assigning a value results in null as well, so just remove the " = null"
Why not simply extend `django.contrib.auth.backends.ModelBackend` and override `authenticate` method?
blank space :)
This is the legacy version.  3.1 is available.  It uses the new package names.  Is 2.6 required?
I added a comment to this effect in the code.
Personally, I prefer re.IGNORECASE for readability, but this works
This script has been renamed to .py, so the proposed change identifies a file that does not exist. (The file has long been a python file; we just noticed that it was using a perl extension and decided to fix it.)
Although Luwak is EOL'ed, it still exists in 0.14 series, which we need to support until the next major release. I would rather use feature-detection instead.
Perhaps the default domain should be "no domain" (i.e. accept all, rather than inferring from hostname). If there was no domain and the server pool was non-empty then it would be good to not include the 404 section.

What was the error being fixed by removing the 404 section? Any test cases we can write for it?
I'd prefer if we did not have the code commented out. We could have `\@Test(enabled=false,...)` if it doesn't work yet. But at least then refactoring etc will keep the code up to date.
C'est quoi MDN ?
You could take empty.xpi and include it in the repository for testing (or download it in the test) from http://mozqa.com/data/firefox/addons/extensions/. Not sure if this would work, but you could then open about:support and verify that it's listed.
Is there any way we can make this into a configurable option?  That way we can pass the name in from the Journal project, instead of hard coding it here.
I would name this `valid_content_type`
let me answer your question by trying with the next PR ...
argh, sorry, I forgot to repackage the test class :-S
Well, we can do it later when we need I suppose.
Im for a change on this as well. I would like to add three hardware targets so this would bloat a lot.
Also the reference to listClass can be removed
I'd be interested to hear other opinions on this, but it feels like this should be nested within the GdsApi module? Maybe something like ```GdsApi::InvalidEndpointURL``` ?
Переменная объявлена слишком рано.
Должен быть public
understood @bebef1987 ... rolling back...
I know, but I thought this was even more flexible - in case we end up with another child of Page that would like to inherit the methods. I don't know what that might be, but I thought that simply checking for a root element made sense. I can certainly switch it to use isinstance if you'd prefer that.
add the blank line back, this one's required :)
Dont use # for comments, stick to //
The parent inherits from itself now!?
Fewer segments would make this example a bit clearer. For example:

```python
seg2 = slic(coins_colour, n_segments=20)
```
> I commit already not working code so we can agree on where to implement things.

I cannot read non-working code: I would need source access to the brain
of the guy who wrote it(can I get commit rights too ? :} ) to figure out
how he wants to make it work.

Also, I usual understand code by running it, and inspecting dynamically
what it does.
This obsoletes the comments on the docstring for `X_norm_precomputed` but not `Y_norm_precomputed`.
the problem with this is that people who are not multilang do not want to specify any locales. i think the best would be to remove this check again and instead check in the extension class inside multilang > use_sonata_admin if the locales are non-empty and otherwise throw the exception. its only relevant there, not anywhere else in the bundle.
Gotcha, I didn't realize Buffer.concat used copy() under the hood. Figured it just made a new Buffer with pointers give or take to the list items.... kinda how slice() works.

Speaking of slice, I was trying out slice()-ing the [incoming chunks on the Decoder earlier too](https://github.com/gjohnson/super-sockets/blob/performance/lib/decoder.js#L100), it was working pretty well. However it uses concat at the end though too... Have to tinker around a bit more with different variations at some point...
`RZCacheSchema` should be an abstract base class, rather than a protocol, that `RZFileCacheSchema` is a concrete subclass of.  This will ensure that cache schemas are encapsulated in their own objects, making it easier to use them in other projects, rather than just a set of methods implemented on an overloaded object, such as a view controller. This will also allow us to use properties on the cache schema to store values related to caching, such as downloadCacheDirectpry.
Ah, sorry, I presumed you meant that you wanted to preserve the *type* as well. If not the case, then I'll switch this to the simpler change shortly.
I suspect even when left is not equal right above, this could still produce the same selector. Otherwise, you'd have done ```if (right != left)```.
Similar linking issues..

probably want to use getClear() here.
Not newName? Probably right, but looks confusing, a comment would be useful.
This is getting piped directly to the git clone command, so if git clone supports 'user/repo@branch` then that'll work.
I am just curious about where this file is used, seems like it now only contains a closing div
@davelyon this should be `getClosed`!
why not to pass a hash with any params number instead of "name, value" method params?
Is this called anywhere?  It seems like a pretty particular string format that you are returning... I can envision it being useful for debugging but don't see any references to it elsewhere in the code.  Perhaps a little more explanation in the comments would clarify.
irb will throw a fit and segfault if this is not used.
Sorry, it's maybe my bad English.

Can you propose some good naming?
```javascript
else if (!displayed) {
```

On met les accolades  ouvrantes à la même ligne. Meme chose pour le if au dessus.