labofsahil/github-event-dataset-2012 huggingface dataset:
Fix issues from pull request 2

This moves some const data to a more efficient place and uses the appropriate programming style for Gaia stuff.
add unit test for mime-word decoding in addresses, fix by lib updates

r? @mozsquib

Note that I think technically just the mimelib update was required, but my first step was to update mailparser in case it was at fault.  Because we still require a patch to trim strings since the browser's atob() throws exceptions when node's does not (when whitespace/unsupported characters are present), I did this in my branch via a merge.  I did not take the most recent release of mailparser because it changes from using mimelib for filename -> mime type to the npm 'mime' module.  Although that module is more comprehensive, it would need some conversion love for us to use it because it does some node-legit stuff that is not web-legit, (and our shims aren't converting fundamental node-isms) namely:

```
mime.load(path.join(__dirname, 'types/mime.types'));
```
plugin never takes input value

if defaultTime set to false, try to get input value, if present it will be shown, no otherwise
#494 poprawione zadanie i testy
metamodel now raises errors from it's models during training

close #513
close #531
对于高版本的支持

目前已测试3.2.1无问题。
SOS-832

http://issues.liferay.com/browse/SOS-832
latest mouse simulation
Log filename prepended with date and timestamp. New filename YYYYMMDD-HH...

...MMSS-garmin.log Fixes #25
Fixed regression and removed application

1. fixed regression reported on your project
1. removed own application and exchanged it with standard eclipse ide application, which gives us all menus, icons, etc...
Add config glob pattern to application.config.php
Fix BigDecimal TypeError in Ruby 1.9.2.

In Ruby 1.9.2, BigDecimal raises a TypeError when you pass an Integer
(including Fixnum and Bignum) to it.  To get around this behavior you
can pass the Integer interpolated in a string to BigDecimal.

This occurs in the relativity gem when initializing a new BigDecimal
instance.  Specifically, when calculating the seconds from midnight.
As part of the calculation a new BigDecimal instance is created based
on the nanoseconds.  As mentioned previously, the relevant fix was to
interpolate the variable when passing it to BigDecimal::new.
Added show_in_facet_bar  parameter to add_facet_field
(#11706) puppetlabs-apache depends on puppetlabs-firewall

Without this patch puppetlabs-apache does not depend on
puppetlabs-firewall.

This patch solves this problem by updating the Modulefile to specify
the dependency on puppetlabs-firewall.
create a cleanup file for the assembly pipeline
Small but important error with documentation
include request context in order to satisfy sekizai

success view includes request context in order to satisfy sekizai when shop is used in djangocms. without this, templates used for 'paypal_success' will fail when they extend from templates that load sekizai tags.
Winrefactoring

Initial support for Win 7. Mostly works non-natively, but code needs cleanup and native support.
Update README per https://projects.puppetlabs.com/issues/11261

Development in the this repository should move to the mainline puppet repo.
Receita parcialmente feita
Fix for issue #4

Point to /issuechange.php and the cache files will be updated.
Bugfix: User not kicked out if auth token has been revoked
Added root pom, tests pom and modified all tests poms to have proper dependencies

Some tests cannot be built right now, but for now I included all tests in the modules section of tests/pom.xml. At the moment we don't have a requirement to be able to built everything at once. But once we set up a feature and site, we will need to make sure all tests build (and disable those that can't build).
Header Text/Logo Link to Index, About Page Placeholder/Menu Item

Hey guys,

I've never used HAML before, and haven't tested this code as the FB integration totally mucks up my test server when I try running the rails server on a clone of the repo(missing the keys). So test this code, It should work though.

Mike
Default to nova network
test

i added my name
fix for "invalid multibyte char (US-ASCII) " error on ruby 1.9.3

this patch fixes the following error on ruby 1.9.3:

```
$rake db:migrate_plugins RAILS_ENV=production
(in /path/to/redmine/)
rake aborted!
/path/to/redmine/plugins/redmine_hide_emails_by_default/init.rb:5: invalid multibyte char (US-ASCII)
/path/to/redmine/plugins/redmine_hide_emails_by_default/init.rb:5: invalid multibyte char (US-ASCII)
/path/to/redmine/plugins/redmine_hide_emails_by_default/init.rb:5: syntax error, unexpected $end, expecting keyword_end
  author 'Enrique García Cota & Francisco Juan Prieto'
                        ^
```

ruby 1.9+ need "#encoding" setting for non ASCII char in source code.
init.rb contains  non ASCII char, but there is no "#encoding: utf-8" line.
Arrows pattern

Hi Lea,

Here is the pattern I showed you a while ago, the one with the [diagonal arrows](http://dabblet.com/gist/1494163 "Diagonal arrows on dabblet").

Cheers,
Jeroen
LPS-25078 Service Builder no longer allows _ in namespace
Test Fixes

portlet/imagegallery
portlet/messageboards
portlet/wiki
portlet/wikidisplay
add-file-default-permissions-2

Sync needs this in order to upload files with good default permissions
LPS-22920
update readme to show fragment usage
Fixed the README.md

Switched from HTML to Markdown and added Tables to the Features section
Markdown 的转义错误导致 反引号没有显示出来

Markdown 中使用  `` ` there are some codes...` ``  的形式将中间的文本转换成 `<code> there are come codes </code>` 的形式。

但是原来的写法```  ` `` ` ```，Markdown 只能转换成 `<code></code><code></code> `, 看起来样子就是 ` `  ` `(就是一段空白)。

所以转义了一下，修正了这个问题。
SN + QuickInstall

```code
[phpBB Debug] PHP Notice: in file [ROOT]/socialnet/im.php on line 690: Undefined offset: 0
```

on index.php

phpBB 3.0.11, vanilla installation of QuickInstall with subsilver2, AutoMOD, populated board.

It appeared when installing SN from github, including PR #3.

Also, status & comment fix does not appear to be fixed, what is more, it seems to be broken even more. After posting status, it does not display in feed, instead, php error is displayed:

```code
[phpBB Debug] PHP Notice: in file on line : : in file on line : 
```


After I reload entire page, it displays, however 2 new php errors occur:

```code
[phpBB Debug] PHP Notice: in file [ROOT]/socialnet/includes/sn_core_comments.php on line 292:
        Undefined index: userstatus
[phpBB Debug] PHP Notice: in file [ROOT]/socialnet/includes/sn_core_comments.php on line 292:
        Undefined index: userstatus
```


After trying to comment on that status update, it displays comment, however, this php error occurs above it:

```code
[phpBB Debug] PHP Notice: in file [ROOT]/socialnet/im.php on line 690: Undefined offset: 0
```

But after I reload entire page, those php erros about undefined index of "userstatus" disappear, as well as error above the comment.
rscall and rsshell seem stable and portable, so they can go into master

I think our branches are too much entangled, this should be a first step to disentangle them.

Please refer to my recent post on the xkcd forums for a more elaborate explanation.

NOTE: pulling my master master branch might yield weird effects in the network graph. I'm also fine with it if you just repeat the merge without accepting the pull request.

-Julian
Error Dialog when calling open_new_tab() on empty selection.

Hello Grafikart,

Je complète mon ancien commit avec l'affichage d'un message à l'utilisateur lors d'un appel sur une sélection vide. (j'ai également enlevé les parenthèses autour du `if` (question de goût :p))

cf. [a5d82cff](https://github.com/damien-biasotto/Open-Browser-SublimeText2-Plugin/commit/a5d82cff718770f3aace03eb2d0840efc57eaf38)

ça pourrait être plus parlant pour l'utilisateur.
Исправление для функции удаления имён файлов

http://iichan.ru/b/res/2318140.html#2347915
Make the module usable without compiling again

Make the module usable without compiling again, simplify the tiapp.xml, and cleanup
Handles thumbnail images

My first changes in a C5 addon.
It adds support on thumbnails with setting of height and width. It could be published under version 1.0.2.
A Makefile is included to facilitate the gettext manipulations.
The French translation is added.
deleted pages nog in tree for urlbrowser
composer.json for 1.0.x branch

Added `composer.json` to `1.0.x` branch. Closes #31
Timbre municipal

test
added option to configure aws key and secret via ENV

Especially for deployment on heroku this is a nice way of not having your key and secret in the repository.
Remove DonorAddressFormset code

General consensus seems to be that the formset didn't feel quite right.
They're generally used for an unbounded number of forms, where here we
only have two.  This PR attempts to address that issue by removing the
formset entirely.
Swedish translations

Added Swedish translations = a new file called values-sv/strings.xml.
Merged release-1.10
v1.0.8-b2: Recordings ordered by date, and fix for recording list data

Signed-off-by: jfederico <jesus@123it.ca>
french translation updated for JBehave

Ok, it's done and ready for the brand new site .... (a little mention to http://philippe.poumaroux.free.fr would be very appreciated ;-) )

When I'll have much time, I'll start a global review and samples & figs translation....
... thanks again for Thucydides !
Temp compiling fix

This fixes the errors said here:
https://github.com/CyanMobile/android_frameworks_base_cyanmobile/issues/6

Please approve until a solution is found.
Set checked to 'checked'. Don't really use the true stuff.
Update tools includes to work towards #29 getting fixed.

I've re-worked the tool includes to point to the github pages for each project. This should reduce the number of places we can find project documentation
2 minor improvements

Hello,

1st of all thank you all for C5! Best CMS ever!

This pull request offers a fix for a bug with the un-setting of cookie that do not work if the home of the web site is not at the root of the domain (ex. myhost.com/myC5site/)

And it also include an improvement that uses pretty urls (if enabled) when redirecting. 


Thanks,
Tommy
INTSAMPLES-59 - Remove Twitter4j reference

For reference see: https://jira.springsource.org/browse/INTSAMPLES-59
INTSAMPLES-54 - Update README.md

For reference: https://jira.springsource.org/browse/INTSAMPLES-54

* Update README.md to reflect correct classes
* Add documentation for Delayer application
* Add JavaDoc for delayer application
* Delete redundant *src/main/resources/log4j.properties*
* Add logger name to *Logging Channel Adapter* configuration
* Add Maven Exec Maven Plugin for easy execution from the command line
Added section on acronyms to dstyle.dd.

It now explains what case to use with acronyms as it comes up fairly
often in reviews for new functionality. The rule follows what we've
mostly been doing and been insisting on during the review process.

And it's been insisted on several times that this be added to the style guide, so here's the change with it.
Reviewed. Overall looks good.
Echo test.
Adding Speaker Notes

Added some necessary speaker notes for the Linux VM Slides
write the file with binmode to prevent perl from adding \r characters on win32
This can be hardcoded for now, but would be better if a pointer is used so as we can change the font on the fly, but the problem is for now we take the font_height and width & PPCHAR as hardcoded in the file, so write an API for that too ?
The question is whether we want something like "25 27" to return 25 when using CVariant::asInteger() or whether it should use the fallback in that case. If it should use the fallback in that case it will become very tricky to do the check because the second parameter will not be NULL but isspace() will be true. We could do a whitespace trimming at the end of the string before calling strtol et. al. to avoid having to check for isspace() though.
You're missing some themeing in the alot.rc file here. Cf issue #204 and https://github.com/0x64746b/alot/commit/cc3fa74b898bd70ee2b33de18f78dfdd0fd85067#diff-0
Yup - m_vecItems->GetPath() might be empty as well, and some weird case where OnInitWindow() is being called after the windows have been ripped out from underneath the GUI thread - as I say, probably impossible :)
from what I understand ProductPriceHistory is a table that has three columns:
Product ID | DateTime | Price.

So if we store the, say price for product id = 1 for 6 days, then we need 6 rows to store all the information. 

While this is feasible, SELECT will be quite expensive. For example, if we only use product id as the primary key, it means select will go through all the table rows to find those matched with a certain date range. If we use product ID AND datetime as primary key, then storing the database with two-keys chained won't be that efficient. 

If we store everything as a field in the database, something like

Product ID | Serialized Price History

then it would be more efficient for future queries.
Could you change this to self.controller.execute(SortKeywords()) as it reads more nicely?

We also were planning to have some functionality in the controller execute (for example some guard functionality that could protect against unwanted commands)..
mysql2是纯C的实现的gem，性能上比mysql要好一些。我们一般用这个开发和部署。
I don't know if that's feasible. Internally, stdio is in a pretty sorry shape. Fixing that may possibly require API changes.
I think Play Mini is a bad name. But we should talk to Peter about that.
That timeout doesn't seem right.
I've updated it in docrails.
@marcandre you're right html_escape already handles that
@justinko If content-type is application/json, shouldn't jQuery send it as a POST body instead of a query string? What version of jQuery are you on?
This newest software version produces problems on my Fedora 16 System.
After compiling and installation without problems, I get the following errors when starting the gnuradio-companion:

Warning: Block validation failed:
	/usr/share/gnuradio/grc/blocks/fcd_source_c.xml:2:0:ERROR:VALID:DTD_NOT_PCDATA: Element block was declared #PCDATA but contains non text nodes
... <snip>
	Ignoring: /usr/share/gnuradio/grc/blocks/fcd_source_c.xml
<<< Welcome to GNU Radio Companion 3.4.2 >>>

Then the "FCD Dongle Source" is missing in the blocks menue.

When I delete the new  inserted line
    <throttle>1</throttle>
everything is ok again.
Oh, it didn't bother me, just monkey curiosity.
Should probably be changed to "Smith" :).
Consider using `$this->strict_redirect()` here, will allow potential override in subclasses
this really is not that huge there is nearly no new code here, just moving code from many different places into one and deleting the duplicates.
This function should be replaced for other one that calculates automatically its width depending on its gutter-width
Should probably still be a short here, considering that getMaxDurability only ever returns a short?
# On branch enh/TBSS
# Your branch is ahead of 'origin/master' by 16 commits.
#
nothing to commit (working directory clean)

I have pushed but there is no what I added in the github.
What do you mean by "private"?
Do you know what should I do now?
めんどくさかったのでauthorがthincaさんのままですが...
This should call self.addCleanup(shutil.rmtree, target_repo_dir) - otherwise the cleanup won't happen if the test fails.
I think this should be in `stats.urls`?
this seems like something that should live in the `zadmin.views` or `zadmin.forms`. you use it in [only one place](#L0R539).
That properly lives elsewhere in the infrastructure, not hidden in your face.  It isn't strictly, absolutely necessary, but it would be good if it wound up there.
Why? The function returns the string size in bytes.
I'm affraid this broke FALC-support.
Thanks for refactoring it. 
Then we can cancel/close my pull request.
I forgot to test where this is crashing without that part.
I'll do it asap and give you a new patch version.
"ec2.reboot_wait_time" can be set to 40 seconds according to my experience, or this script will fail.
Pretty sure exceptional extracts this from the Exception object: https://github.com/exceptional/exceptional/blob/master/lib/exceptional/exception_data.rb#L17

Is that what you mean?
Great fix!
The _default_ implementation uses a hardcoded class?
Users should _never_ need latches in your Akka AMQP their code. You already have a Future, so just use map/foreach/whatnot.
А еще лучше Iterables.toString(list)
You are correct. I fixed it.
... aber unschön :P
not necessary, because of the hidden aspect of help link you suggest
RTFM by your operation system and debugger.
This all looks great! Nice idea to have the two client middleware entries as defaults.
We're using `@since` tags at a separate line in this case:

`@since` 1.1.11
remove the commentary. the code is the commentary
Success…! When I put man in front of the directory path to the slice command and the slice opts command it finally loads.But now what it still doesn't print.
Should be `@body or= $ document.body`
Very close, just a few style nitpicks
I was curious to see what the actual performance implications would be of making this change, so I put together a Gist:

https://gist.github.com/1628517

The results are a bit shocking: not only is `modifyIORef` twice as fast as `atomicModifyIORef`, but `modifyMVar` is even faster than it! Do you see anything wrong with the test? If not, I think this needs to be mentioned on the cafe.

So yes, I agree that we can get rid of `atomicModifyIORef`. I liked the concept that some operations would still be atomic, but it's actually a bad idea to give a half-guarantee of atomicity anyway.
I think we might have to pass migrations around differently as I think this would imply "all default migrations must be in the root directory".

Technically the fetch migrations stuff should just say "heres the migration file" but it was becoming a bit of a mess when i started passing that around
why not testing it against a list of delimiters ?
why default progress striped is green?
By the way, there is also 'SFC'.
Needs probably to be added to the code also.
i really don't think that we should be adding a comment to the end of the sql statement like that. there are two ways i know of when dealing with this issue. one is to go into the advanced setting of the dsn and uncheck "maintain database connections". the other way involves creating another query with the exact statement and adding the cachedwithin set to zero. i leaned that form the coldfusion cookbook awhile back http://www.coldfusioncookbook.com/entry/72/How-can-I-clear-the-cache-of-a-recordset-created-with-%26lt%3Bcfquery%26gt%3B.
lol i think back to top might be on the login page :P
Thanks very much, I was experiencing the same problem and this did the trick!
Using the loop variable seems confusing to me.  Is it guaranteed by CPython to be the last value after exiting the loop?   `mean /= len(session_files)` might be easier to follow.
Missing a comma after that line, if i'm not mistaken
vmap enableheight fuction?
I didn't push this change but the binary file was alright, btw thanks david
This is a straight translation from Java and I'm sure it's broken in several places. What would be a good way to test it?
It might be sensible if the local storage had the same directory structure as the main URL, i.e.
base + /mapsforge/maps/snapshot/europe/great_britain-0.3.0-SNAPSHOT.map

That way we don't have to worry about clashing names or the directory structure - if it's always exactly the same that keeps things simple.
Correção de indentação  -->
А чего старый мрим не выпилил?
Never mind, that will result in MRE being thrown. Duh.
The $body argument should be removed. If $body is still a stream, it will have reached the end of the stream by now, and is therefore useless.
Will definitely do so at such a time, but it's months off ATM.
Hi @meboz,

The build servers that I'm using aren't reporting and build failures. Can you tell me which unit tests are failing?

Dan..
Can you tell me how to run them though?
Why did you remove this here? I would think the algorithm returns a JSON-LD document in the form of a string with all unnecessary withespace removed.
those changes are independent so git will be able to handle the merging.
you should be able to pull and the push and all should be ok - i'll get
peter check and put those files back if necessary.

On 23 January 2012 19:11, Ed Burton <
reply@reply.github.com
> wrote:

> I think Peter (perhaps) added all the SagePay files to the repository, my
> push promptly removed them all again, how embarrassing!
>
> (All I've been changing lately is LBChooks.module)
>
> On 23 January 2012 18:27, Michael McAndrew <
> reply@reply.github.com
> > wrote:
>
> > no probs - what did you mean/what to do? I'll fix it and let you know
> what
> > I did.
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> >
> https://github.com/michaelmcandrew/lbc/commit/0e3e895a413e76e47d0e623c1127e3e2592ab7f7#commitcomment-893117
> >
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/michaelmcandrew/lbc/commit/0e3e895a413e76e47d0e623c1127e3e2592ab7f7#commitcomment-893297
>



-- 
Michael McAndrew

tel: 020 7183 5828
mob: 07817 802299

Third Sector Design Ltd.
http://thirdsectordesign.org

*CiviCRM meet-ups, trainings, and code sprints coming up in London this
February! http://bit.ly/CiviCRM-Feb-London*
that is ActionController render partial on collection hidden counter
http://apidock.com/rails/ActionController/Base/render
ditto here.  Would it be better if everyone standardized on the nodeGroup item number be the processNumber?
https://github.com/jkp/chromiumembedded/commit/c0aae1e0b85c467053c3f5f7fb12040d5409f16d even :)

--
jkp


On Tuesday, 3 January 2012 at 22:41, Jamie Kirkpatrick wrote:

> https://github.com/jkp/chromiumembedded/commit/def87cd5c4a44f9a324e664d60f8a86100367a44 
> 
> Fixed up now. 
> 
> --
> jkp
> 
> 
> On Tuesday, 3 January 2012 at 17:08, magreenblatt wrote:
> 
> > The check_output function was added in python 2.7. We need to support 2.6 (the version distributed with Chromium).
> > 
> > --- 
> > Reply to this email directly or view it on GitHub:
> > https://github.com/jkp/chromiumembedded/commit/94a2cc8dfa9db63eaeccd942be687ce3fe825676#commitcomment-833942
> > 
> > 
> > 
> 
>
:use is on the path to being deprecated in favour of :require with a
:refer clause. We're not using 1.4.0 yet in which this is implemented,
but I just wanted to get ahead of the game.

http://dev.clojure.org/jira/browse/CLJ-879
oh, and I would advice reading the doc as this is documented
> it's not added, it's deleted.
I am color blind ;)
I wouldn't personally be very interested in hashes in urls in dev mode.
I took this in YTDB
> Is that going to be an easier merge conflict to figure out?

Yes, because now you never have to open the file by-hand, you can fix the conflict in VS (usually showing that a file is missing with the warning "!" sign, instead of making their solution files unopenable)

> Can you open a *.sln file on Linux?

Yes, via MonoDevelop.
Thank you for your review giacomos, i'll work on your recommendations this week end
I agree with Ismayil. The semantics for like are different than recommend. To me, "recommend" means that I have downloaded, used it, and think you should do the same. "like" is more vague.

Also, where else would we use like on the community site? I wasn't planning to turn that plugin on.
Multiple property paths can refer to the same transient entity. Property paths are only needed to provide details for a TransientObjectException.

TransientObjectExceptions should be rare, so in most cases, the property paths will not be used. 

Thinking about this more, maybe it's better to determine the property path(s) only when the TransientObjectException message is being built. In this case, NonNullableTransientDependencies really is not needed.
commit 25d7c8d wykazał, że rozwiązanie jakie jest dostępne teraz na foku s351838 nie przechodzi testów, błąd pojawia się już w 77 linii
There is no need of InnoDB on static tables.
ALTER TABLE `character_queststatus_seasonal` ENGINE=MYISAM; in world misc ?
would not be better to set for all summoned creatures, that they do not give xp/rep and allow it only for exceptions?
this not speed, this delay. see in R2.
more SmartAI power ^_^ thanks for this
> Is this a final release or is it still WIP?

A little of both. We need it thoroughly tested.
per cert has llet el correu que us he enviat! la profe m'han contestat
aquest mat, he acabat els test de prova pero nose si estan b perqu hi
havia coses que no tenia clares, a ms nose com es proven! ho he preguntat
al correu d'aquest mat!

El 9 de gener de 2012 19:06, elena vazquez daza <evazquezdaza@gmail.com> ha
escrit:

> sisi em vaig equivocar!!
>
> El 9 de gener de 2012 18:44, Clara <
> reply@reply.github.com
> > ha escrit:
>
> aquesta funci la vaig fer jo
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/clarabayarri/ProjecteAS/commit/fac73af11469a886758b69afde7bed6584642af3#commitcomment-850282
>>
>
>
TrialOfTheChampion: landing on the mount crash
Maar "typeof" returnt wel een string volgens mij. http://stackoverflow.com/questions/894860/how-do-i-make-a-default-value-for-a-parameter-to-a-javascript-function
For the record, in my opinion having a property setting in this manner is very helpful... instead of needing another property setting to enable verbose output. In way, its similar to having either one variable for a human name, vs two variables (one to hold the first name, one to hold the last name). If you ever need to separate the two, you just read only part of the String. If you have a program that hardly ever reads the names separately, then this type of optimization makes sense. I'm sure this was something reasonable for the developers as they were putting this together. Not only that, but it was probably also an attempt at offering convenience.
Hey, I think this should be for the elevator pitch, but without a headline, so I think we should reverse those changes to the "old" headlines. Approve?
I realized I pushed some major changes with the last release: Spring 3.1 among others (and I'm planning some more).
I might create a BC branch.
#match type 's'
any chances in seeing this one merged?
The comment is not accurate, I'd remove it entirely.
Ok sorry last commit repaire Working Fishing Spell. Sorry...
just did  venugh patch should be fully implemented soon ?
stop to post that...
# Homework 3

> Your ascii, table, and fractions programs were supposed to be in separate files.  On to the grading.

| **Part**  | **Points** |
|-----------|------------|
| base      | 1 |
| advanced  | 0.5 |
| if and while | 0.25 |
| **Total** | 1.5 |

## PrissyBot

Your prissybot program itself is fine overall.  The output is clean, you properly used string formatting.  Your code is easy to read as well (thank you for the spaces.)

## Conversion table
The spacing seems a bit odd (things look like you meant them to be centered but they aren't).  That said, the table is perfectly done and you used string formatting correctly.

## Fractions
To be fair, this assignment for this was oddly worded.  The point of this section was to convert from an improper to a proper fraction, not reduction as I mistakenly called it.  That said, the example I gave was `6/4 = 1 2/4`.  

Reduction is more complicated and used `%` so we'll count it.  Brute forcing every divisor from 255 to 1 is a reasonable decision if you know what the input range.  However, in this case you don't know the input range so it fails for 1268 / 1585.  If you just use the smaller of the two numbers and the upper bound, brute forcing works fine.

```python
numerator=int(raw_input("Numerator: "))
denominator=int(raw_input("Denominator: "))
found = False
factor = min(numerator, denominator)
while not found and factor > 1:
    factor -=1
    if (numerator % factor) == 0 and (denominator  % factor) == 0:
        found = True
print "The fraction %d/%d reduces to %d/%d" % (numerator, denominator, numerator/factor, denominator/factor)
```


## Ascii art
Assignment was: `draw some kind of ascii art based on user input`.  I was looking for something that was generated through programming, not ascii art off the internet.
> thanks continuous integration :)

You bet. It's nice to have tests running on old installs. Elsewhere we
find those problems only very late.
Added attributes for headers and footers.
А, понятно, как решать проблему.
Lmao, well, it's their loss...
On 1/30/2012 12:39 PM, phindmarsh wrote:
> Its working great with Redmine 1.3.
Great.  Glad to hear it.
>
> Where's the appropriate place for feature requests?
Go ahead and register an issue and label it as a "feature request".  
I've put up some standard labels.

--KUBI--

-- 
Professor John Kubiatowicz
673 Soda Hall
Berkeley, CA 94720-1776
Yeah maybe but works for me :)
He removed some of my code that was there for good reason that I even left a note about it. Why remove the code along with the note?
Can we not just merge these things into the main project without discussion?
Just collapse this line and the following.
This looks fine to me… but all the whitespace needs fixing. I will fix it and merge, but please check this before submitting next time!
Changed for consistency.
Oh. I think you're right!

I always tend to make mistakes like this. I'll get the big picture down and worry about fixing all the little details later. Good catch.
I know ;)
On Feb 28, 2012 11:02 AM, "Steve Garon" <
reply@reply.github.com>
wrote:

> I still do. Just trying to help you out :P
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mathkid95/linux_samsung_ics_real/commit/75373c84b9ade2cc5747f316fe7a886c7f09bb1c#commitcomment-1021836
>
this would still be as type safe, no?
Yes, I got this comment.

-Darius

On Sat, Jan 28, 2012 at 2:23 PM, mogoodrich <
reply@reply.github.com
> wrote:

> Test comment.
>
> @djazayeri -- let me know if you get notified that I've made a comment
> here.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/OpenMRS/openmrs-module-htmlformentry/commit/33ba9c4c63538d75365d13fc69883e8c5103f6d9#commitcomment-911369
>
Let me know if I can help with this or when you do it, so I can see how it was done.
зачем такая хитрость?
Looks good! You can remove your <script> tags from elicitation.js you only need them if you want to put javascript inside of html, but elicitiation.js is js.
Compiling the module with 6 and then trying to run it in Cascade with 5 will not work unless you use the `-target 1.5` [option](http://docs.oracle.com/javase/6/docs/technotes/tools/windows/javac.html#options)
You're right - it was a typo - fixed.
Shouldn't we return false when some error happens?
You can just cast $conf to (object) at the top of the function :) Then you only have to verify it has at least one of the keys. BTW throw an InvalidArgumentException for that.
Would the user ever need to alter this line? Could we sniff for instanceof ElggDatabaseConfig in the bootstrap and just do this automatically?
scala.Iterable I presume?
Only used in one place, inline expression there.
I think this should be broken out to a method so it can be reused in cleanup, no?
Yeah, but is it 0.8% or 80% or whathaveyou? :D
yes, I'll name it `pickHighestPriority`
It does (takes (ActorSystem, ClusterSettings) and it is well documented in config already.
Subscribe to ClusterMetricsChanged instead should give the same result, or am I missing something?

/Patrik

17 sep 2012 kl. 22:13 skrev Helena Edelson <notifications@github.com>:

> In akka-cluster/src/main/scala/akka/cluster/ClusterEvent.scala:
> 
> > @@ -89,6 +89,16 @@ object ClusterEvent {
> >    }
> >  
> >    /**
> > +   * Marker interface for cluster metric related events.
> > +   */
> > +  sealed trait MetricsEvent extends ClusterDomainEvent
> If removed, all of the metrics multi-jvm tests fail because clusterView.clusterMetrics.size is always 0. So if we don't want it enabled yet then another test strategy is needed :(
> 
> —
> Reply to this email directly or view it on GitHub.
>
I don't think this needs to be mentioned. Just clairfy "allows actor to" to "allows Untyped Actors to"
After a heated and fun debate with Roland we agreed that "+" would be more awesome, but can't be used because it needs to be a valid path element as well. so "." it is.
should not or must not or can not?
Ah, sorry. Now I get it.

You were referring to the sbtosgi changes specifically. I was talking about our jars in general.

Will double check.
They'll be deadLetters in both cases, wdym?
That is correct, the V should not be there.  I went back and double checked some the toolset information for VS11.  VS11 still uses the 4.0 toolset, however, it loads a sub-toolset based on the VisualStudioVersion build property.  MSBuild checks for this by checking registry keys.  I updated the solution to check them as well.  I wrote it so that if VS11 and VS10 are present on the machine, then VS11 is used.

For the most part, VS11 projects will not get past the previous check of the Target Framework as it does generate that element.  However, this would come into play if someone were to remove the TargetFramework element.  In which case, Visual Studio treats it as having targeted .NET 4.0.  That being the case, should we disregard the registry key afterall and just have it fall through to see 4.0 as the ToolSet and pickup Rosario at this point?
Add shape tests for odf, fa.
Do we have to remember to add this whenever we merge in recline?
if you use `data_dictt,get('offset', default)` then we don't need it in the data_dict

if it is needed then _get_or_bust() should be used as that causes the request to cancel
Here again, the same dilemma. . . .
I'd prefer using GetField(m_field, strType) instead of a fixed "tvshowview.idShow" in the SQL. That makes it more in line with all the other field accesses (except all the *.idFile ones).
.old. hoeft toch niet te worden gecommit?
условие про `'x-ua-compatible' in this.ctx.meta` можно вынести в предикат шаблона
QTimer include is already in `navigatordock.h`, no need to include it again here.
Please use the Twig integration tests (by adding a new file in the ``test/Twig/Tests/Fixtures`` folder instead of creating a different way to run tests.
You might rather use array_map instead.
Good idea, added the link.
Why this test assumes only sqlite driver is available?
Shouldn't this be handled through css styles?
typo => `ActiveRecord`
I guess it should be:

```
self.select_values += fields.flatten
```
The ability of set the mimepart ordering when "explicitly rendering". But I just realized that what is guaranteeing the order is the `default_params`. Sorry
I updated it !
Ah yes, I've seen that, but so far not for implicitly converted stuff. Didn't realize that you also had it there too, it looked like this setting simply truncated. 

I also wasn't aware that the tooltip contained the list. It's not so intuitive. It's better than no doing anything at all, but I totally wasn't aware of the tooltip-- I just kept clicking the thing thinking it'd link me somewhere. Is it possible to get/generate the fully-qualified name and link here? I can make a modal box  (like a pop up, but which sticks around and has an "x" box to close the box) which lists everything. We don't even have to generate extra HTML pages or anything.

Also of note-- the Serializable link you linked me to above contains less than 801 classes/traits in the tooltip. Of course having 801 names in a tooltip is nuts, but it's also no good if you believe 801 classes/traits will be listed and only 42 actually are. Or worse, 750 instead of 801 ;)
Well, that's why I overloaded changeOwner rather than changing the signature completely. I'm not sure if there is any best solution here which would also avoid copy-pasting.
Between this and having yet another subclass of ChangeOwnerTraverser I considered this lesser evil.
don't we usually simply spell `<this mirror>` as `this`?
I'd say this is a bit ambitious for this PR, but we definitely need to discuss and tackle this before reflection gets frozen. It's good that we have a chance to meet next week.

Though fixing the immediate problem of confusing Nils and ListOfNils for just templates seems doable. I'll look into that tomorrow.
is the WS intentional?
The original was like this which we intentionally reverted to speed up unregistration. 'tis a shame to have to re-introduce the slowness (relatively speaking)
Yeah, I did `FOO* foo` exclusive for about 8 years, so i'm somewhat stuck to it but don't feel too strongly these days.
Remove one extra newline.
Technically this line only needs to be indented more than the line with `if`, which is why both of these are syntactically correct (to put it another way, the indentation of line 118 doesn't matter, as long as it is not less than line 117).  I personally think the way it was is easier to read, but I don't feel too strongly about it either way.
space near `-`.
Well, it will give you a lot of false positives in the code, but `set spell` in your .vimrc will always enable spell checking.  There ought to be a way to do it just for strings and comments (I can tell you how to do it in emacs :-)
there should be no space before `:` according to PEP8, I believe
commented out.
I'd much rather we use `factory_girl_rails` instead of fixtures. Would you mind converting this over to a factory?
Explicit space after `if`.
oops, overlooked that. fixed.
Are you sure this define should be removed?
check array extents.
Right now the sessions are only going through when the app is opened with valid credentials. This needn't be the case, and probably shouldn't be.
Aren't variable-length arrays in the C standard now? Is there a better flag to check for instead? (Like `#if C99` or something like that. Sorry, I'm not an expert here.)
It would be best to use the app access token here (which is available via KoalaTest.app_access_token, which you can use in the mock results ERB above as well).  I would then test for the presence of certain keys rather than their values; that way, when the tests are run live against the Facebook API (LIVE=true rspec spec, or however you run them), it'll still pass.

(I still need to write up that section on contributions and mention testing both live and mocked.)
There should be a test case that asserts the correct exceptions is thrown when called with something else than `1001`.
you should probably suggest the other libraries for which a service provider is available.

And ``suggest`` accepts any string. You could give a better explanation than giving a version constraint here
Here is an example of the alternative behavior I've described in the previous comment:


$app['controllers']->value('foo', '1');

$app->get('a1', ...);
$app->get('a2', ...)->value('foo', '2');

// default value for foo is 1 for a1 and 2 for a2

$app['controllers']->value('foo', '3');

// default value for foo and bar is 3
"total data set" is not a specific term that we've used in any context. It's not entirely accurate. The actual compatibility issue, would be good to cover: 

is this operation totally blocked in shard clusters. does it work for databases that don't have sharded collections? that don't have sharding enabled.
This is still there.
This means you cannot go to the full editor without entering text. We might as well keep that functionality.
Methods should go *after* all of the property definitions.
Better wait for that bug to be fixed before merging this, then, I believe...
<code>.</code> added
And? I don't see any reason why we should forbid source building in project root dir. Is that affects building process somehow?
OK, yeah, we (mojito team) will have to do the rest of the validation for this PR.
Вот эту проверку тоже бы вынести в сервис загрузки картинок, о котором я писал выше. А эту функцию оставить проверять только валидный или не валидный урл
Please dont use ':'  in the counter name, as category and counter is also separated by the same seaparator
Probably should make this case-insensitive
`..._subset_subset`?
Or a CoordSystem
This if statement can never be true - but because of the structure of all the if-elif blocks it's not at all clear. Would be nice to clean this up.
Make sure this still works with all the changed values properly
Don't hardcode html structure. Use an atribute with ID of the element to be removed.
I keep going back and forth on this one. My current opinion is hardcode it and QA things against a static value. How much you want to buffer or not has little to do with user workload, cluster size, etc. It's almost entirely just a "magic number" that we want to optimize against Riak / LevelDB.
nitpick: No need to match ReqId three times.
This breaks if you have the string ``"Foo'Bar"`` in the query, as the single quote in the literal will trigger a switch whereas only the double quote should end the literal. You need some more complex logic
Nope! Line 119 is testing for more than one character of whitespace between event types. I should update the content of the comment to be more accurate.
Its safe, at least from a unit testing perspective! I also don't see why it wouldn't be safe. An I missing something?
The following two functions are used to check errors using ereport.
Here's my use case. I'm making a site that aggregates social network data. The user authenticates with my site. After which he can 'grant' access to his timelines on twitter,fb, google+ and the liking. To grant access he needs to use oauth to authenticate with these 'said' services. After which, my site is given an accesstoken and secret (oauth 1) or in (oauth 2) just an accesstoken. After my site is granted access, the site can make requests to the twitter api and facebook graph api to get any information that I need. It may be the timeline. It may be a post. It may be an image. Also, the site can make POST requests to post a status update from my site to these services.

Right now it seems as if meteor is using oauth as an authentication mechanism and just that. Which makes total sense. But what if meteor wants to make a request to another service or api?
Similar to above, these five lines should just be a single line using `.create()`
Let's inline these.
Shouldn't root be appended to the path parameter here
Hmm, this will cause performance problems on SQL drivers. I will look at fixing this directly in DataFrame.from_records instead of right here (I worked on an issue related to this a couple of months ago). An EAFP approach works better
What does Chrome do if the parameter isn't an object? Does it fail silently?
True. I will fix.
this goes underneath the methods definition
If you use single quotes you don't have to escape your escapes.
Is the suffix _2_ intentional? There seems to be no function named `op_fetch_data_hdf5` this would conflict with.
@Parameter(
Not
@Parameter (
Would be nice to hoist out utility functions for computing xOffset and yOffset -- the code for Y, at least, is duplicated in 3 places.
Need to update this name after context menu definitions are cleaned up.

Need a more consistent id naming convention. Maybe "editor-context-menu"?
I believe on Mac Cmd+_Alt_+S is more common.  May want to have the shortcut be platform-specific (see elsewhere in this file for examples).
Doh! I blame that on my lame git/guthub.com diff'ing skills.
This is pretty cool :) I like how it depends on the `if` to recognize a callback scenario. But maybe the match within the if should be a bit more specific? Wouldn't it be fair to require `err` as the argument again? That way you won't match `if (err) log(err)` or some such.
not to be taken into account... I have created the function set_arguments() for my own use (similarly to set_test_options)...
Reference is passed in now
This is blocking, right?  Would a async read do it?
given the fact that this is the init function (and relatively speaking is not a considerable source for optimization) I'm not sure the "cleverness" of the code here is worth it.

the comments help though.

(moved comment to pull req)
yes, I know, I know… any ideas?
Cool. We generally use `dateutil.parser.parse`; can you use that instead for consistency?
does this show up when it gets started then, before it opens the stopwatch, as a transition screen?  i wonder if we could avoid that by not doing setContentView...
extra_info vs extra_data is somewhat confusing to read.  Might just avoid extra_info altogether:

```python
results.append(cls(channel, row, extra_data[i] if extra_data else None))
```
> So, if scales$limits is NULL, and breaks is set, then this will expand the range? 
Yes, it will expand the range. Is this incorrect? Please refer to #552, thanks.
Restore "util/shims"
No space after `onDoubleClick`.
oh man. doesn't removeChild return the elem it removes? thus: `tweetsContainer.appendChild( tweetsContainer.removeChild( elem ) );` would be valid. :P
Wrong method name here
The following code is not wrong, but I don't like to read it. How about:

```
var ops = [
  ['save', []],
  ['setStrokeRGBColor', annotation.borderRGB],
  ...
]
```

and then use a `for` loop to add the entries on the `fnArray` and `argsArray`?
This line should better go in `<head>` section.
Plus, have you thought, that in Index pate, this will be called twice? :-|
without looking into the CFileItem code, I know there must be a better way to check the watched status than like this.
why clear all data before updating? this will make the gui entries for this table empty too until it's updated.
建议 unstyle 改名为 unset_style 吧。
Yes, I agree, we should use the ms functions for this, at least as far as it regards the filesystem (not script ids). Will refactor this in another patch.
Opraveno. Zajímal by mne zdroj.
I'm not sure to understand why we would want to restrict to "local" resources.
Sorry, yes I just missed the zfs side changes you had proposed.  I was a bit rushed on Friday when looking at this originally.
See https://github.com/nxtbgthng/OAuth2Client/contributors
All this was moved to subscriptions controller in earlier pull-request. I had left it here to detect merge conflicts during work w/ other team members.
From a REST point of view, I'd probably only support it on post or put.  Since those represent a change in state of an object.  In this case, it would it would be a change to the user's session.
This isn't necessarily a comment that requires change... :)   I see we use 'embed' in several of the image paths now.  What is the significance of the embed path?  E.g. will all images be under this path now?  Will this path exist in both deployment and development configs?
Thanks for mention that, I committed a fix [here](https://github.com/yyfrankyy/tobi/commit/d8ba9550c5535eaaf03174e02bdd5945a0b31919).
I only coded what I needed for the test, here. This isn't an exposed interface (beyond the `test` subdirectory, that is).
found it.... Nice :) good work!
you should use ``$record['formatted']`` here, not ``$record``, as said previously.
you don't need to return the content of the response here as you don't use it anyway
So can we avoid it?
@bcotton Minor nit-pick: this doesn't close the file. Better would be:

```ruby
spec = eval(File.read('kafka-rb.gemspec'))
```
I didn't really think about the order, I just ended up swapping it when I removed the reference to the current cosmology from this section (see my explanation for this in a previous comment). It's a short section, so I like to think people will read to end of it before complaining "this is way too hard to use!". Maybe that's naive :)   I haven't changed the order yet, but if you feel strongly about this I'll do so.
@adrn @wkerzendorf @kbarbary @andycasey - do you have any thoughts on this? @wkerzendorf, you had done something similar before, so maybe you have insight on the pros/cons of this?
I agree that the format and system attributes should be immutable--in fact that Time objects themselves should be immutable.  As for the "caching" issue, just change property to lazyproperty (from astropy.utils) and you'll be all set.
Missed it in a refactor I think.
done
On Aug 20, 2012, at 8:46 AM, jao <notifications@github.com> wrote:

> lightweight
Perhaps it's better to use an std::deque here instead of a std::vector?