labofsahil/github-event-dataset-2012 huggingface dataset:
So what I mean is:

    QMessageBox::StandardButton buttons = (QMessageBox::StandardButton) (style & STANDARDBUTTON_MASK);
    if(!buttons)
        buttons = QMessageBox::Ok;
    ....
    QMessageBox mBox((QMessageBox::Icon)nMBoxIcon, title, message, (QMessageBox::StandardButton)buttons);

where STANDARDBUTTON_MASK is defined as BTN_OK | BTN_CANCEL | ... | BTN_RESET
I guess this was changed by another dev and we need a rebase for this pull.
This is a very un-C++-ish way of doing this. The C++ Way would be an abstract base CDBEnv class, with concrete subclasses for unit testing (CMockDbEnv or CMemoryDbEnv) and records-to-disk.

But the use of the global bitdb variable is also very un-c++-ish, and if Mike Hearn's experiments with LevelDB and Pieter's experiments with a new wallet storage format go well this whole subsystem might get junked anyway....
You need to set the default value for argument `$path` to `null` to make it optional. Also please update the docblock mentioning the default path used like its done in `PhpReader`.
The feature type is added by hand here because it is missing (default in request config?). If not set, the features are not correctly listed in the feature grid panel. The same workaround is used in QueryBuilder. On the other hand it seems OK with WFSGetFeature (returned features actually have a type property set).
I think "Interroge" is better than "Questionne".
@api is the imported class
``ReflectionException`` is not used
this one is still not fixed
thought you changed it away already the persistence
Usually we don't test permissions in the individual model specs (we leave that to the ability_spec.rb file). So this could be renamed to something like "saves the discussion". However, I think this spec could be re-written to be a bit more specific about what it's testing. Something like:

```
describe "removing a discussion" do

  it "updates the removed_at time" do
    discussion.stub :save!
    discussion.should_receive :removed_at=
    post :remove, :id => discussion.id
  end

  context "successfully" do
    before { discussion.stub(:save!).and_return true }

    it "gives a flash success message"
    it "redirects to the group page"
  end

  context "unsuccessfully" do
    before { discussion.stub(:save!).and_return false }

    it "gives a flash error message"
    it "redirects to the discussion page"
  end
end
```

You'd just need to fill in those pending specs.
We recently switched to a system where extensions no longer need to manage their own installed state. (#2462).

This whole chunk can be reduced to
```py
def load_ipython_extension(ip):
    install_ipython_completers()
```
Sorry for my long absence as well. I understand insane, that's how work was for me a while back, followed by burnout.

I don't think I need major help, probably just some general questions, and reacquainting myself with the changes/codebase.

Should the _getdefaultencoding_ go into an existing module (utils/text.py?) or a completely new module (utils/encoding.py?), and at any rate, is the utils sub-package still the right place?
I think this would be more idomatic if modeled as a Map<String, String>  probably DataBag extends ForwardingMap<String, String> + adds name
Ideally this would return a promise (with abort() tacked on) instead of a Deferred, but that broke a lot of tests.
most Laravel code use own line for semicolon, and condition without  semicolon is accepted by in Laravel (since @taylorotwell use it mostly)
It doesn't show in this diff, but later in this function there's a bit of url-encoding. Do you want `C:\Documents and Settings\user` to be replaced with `C:\Documents%20and%20settings\user`? Or would it be enough to use `cl_fixture` for these paths?
@tanoku
> Is the normal readdir threadsafe in AmigaOS?

How important is that?  I'll have to check.  It might be that I need to write some threadsafe compatibility function myself using dos.library directly.
This behavior is as sane as we can get. I'm OK with this.
why 0.1.4 instead of 0.1.3
Also, they should be grouped into 3 groups: stdlib, django/third-party, and local imports. So it would be:

import csv
from operator import itemgetter

from django.core.files import File
import jinja2
import jingo

from django.conf import settings

Note that you should use the last line to import settings instead of importing them directly. I can't remember exactly why, but it's the Django-preferred way.
I was definitely thinking of creating a util as this is now used in more than one place. Is there a default location that utils lives inside Bedrock
"opt in" two words (though I don't like that phrasing because it doesn't say to opt into what).
Is this newsletter code not in a macro somewhere? Would the IDs here clash with ones in the footer, or is this form not normally in the footer?
If this is really about replacement counts, why not just `if len(original) != len(translated):`? Getting the length should be more fast and efficient than sorting.
This used to be the "searcher". But that was kind of an irritating system and it was easier to make it a class method that I could override from SearchMixin. Rob Hudson gave me this idea.
symbolic links are very different than real files.  They're implemented by putting the referenced pathname directly into a field within a filesystem inode.
Ok. I just didn't see any template changes or anything else on mkt so it seemed out of place. If this change is fine there all looks good to me.
Not sure why you're defauing to `''` here, rather than the default value of `None` that .get will return in case the key doesn't exist.
This should not be relying on the session, but the data being passed in.
Is this in reference to the name of the method?  The parent method I'm calling?  Or both?
But it does have state support... it's stored in _keyStates (which is used below). Perhaps this is a leftover warning and TODO?
Do you have a test for the two confused cases?
why closing the PHP tag and opening again just after ? It seems weird
I've renamed the class back to SecureRandom.
Brace need to be in same line as `while`.
but only the XML ones. And here, I'm commenting on the plain text help
This is not really valid. I guess assertEmpty will pass if getDefault returns null, or 0. I also don't like those "fancy" phpunit method because their behavior is never really clear if you don't look at the implementation. If I see an assertEquals I'm fairly sure of what's happening without having to think too much.
It cannot return null
why would this class talk about a database connection ? This still makes the doctrine implementation special (even talking about the DoctrineBundle configuration here as a standalone use would still need to pass a provider, not a connection)
btw, the node does not compile to a variable. It compiles to a PHP expression. Try my example to see how it compiles.
subject { user }
its(:provider) { should eql auth["provider"] }
its(:uid) { should eql auth["uid"] }
its(:name) { should eql auth["info"]["name"] }
・・・
のほうがいいと思います
It would be nice to comment on why throwing a RuntimeException instead of simply abort.
Um, I'd rather avoid implicit marking the message as HTML safe, it should be marked outside of this function (depends on the context and message passed).
Loading a full Rails stack, which may not even exist since rubber works with any ruby project, is going to be very slow.  We could try to grep the application file if it exists though.
So much cleaner. :star:
changed to 
    def set_token_and_endpoint
+ libboost-system-dev
Else I have an error with cmake.
No check to ensure we're banning a valid nick?
should you just rather remove this line?
Add a test that basic get throws if not found
sure, no prob
Please add a help text so the user know to use for example 150px or 100%.
Done! Commit soon.
Good point about potentially other threads destroying different EJBs.
I don't think that we should have this dependency in the controller module
Hmm, thinking about this. Perhaps we should handle the auto-start property here as well. Otherwise if you kill the host-controller once it would remove the process, the 2nd time it would start the server (since there is no process info any more).

Anyway i guess this more an edge case and should be done in a separate PR / Jira,. It might be tricky to do properly (remove, add the process and start the server).
Changed. Thanks very much.
Did you left this just to see if I was really reviewing? :)
I used display: none on the message element, and changed its id to "nosongs", that will make more sense.
Please remove L241-245.

When the screen is turned on because of an notification, we will not want to turn it off at TOASTER_TIMEOUT. That's too fast. Normal idle timeout or lockscreen idle timeout is fine.
idem -> `7.8rem`
This has been changed in the commit I will make in a minute, anyhow I take note ;-)
I forgot to attach the screenshot I was refering to: http://i.imgur.com/YbHxz.png :D
What about attaching a back and forward method directly on the Navigation object and attach them with: 

var forward = document.getElementById('forward');
forward.addEventListener('click', this.forward.bind(this));

var back = document.getElementById('back');
back.addEventListener('click', this.back.bind(this));

That would leave the content of handleEvent dedicated to hash navigation and avoid the nested switches.
On it... ;-) Thanks!
Could it be img.hidden = true ? Although img.style.visibility = 'hidden' is OK for me as well
If there's some other way to auto-destroy the proxy when no longer needed by any MNotification instance (or on exit), please let me know.
It would be nicer to actually show the properties in the documentation. I guess the list of properties won't change that often, so it should be safe to include the list here (just copy&paste from the output of mathics). Otherwise you can still specify ... here, so the output will not be tested for, but will be shown in the documentation.
When you can make a useful comment let me know.

Sent from my iPhone

On Oct 17, 2012, at 3:33 PM, Yehuda Katz <notifications@github.com> wrote:

> In lib/assets/javascripts/turbolinks.js.coffee:
> 
> >    currentState = window.history.state
> >    triggerEvent 'page:change'
> >  
> > +executeScriptTags = ->
> > +  scripts = document.body.getElementsByTagName 'script'
> > +  eval(script.innerHTML) for script in scripts
> Turbolinks is trying to reimplement enough of the browser's semantics so it can satisfy the goals of being a drop-in. Good luck!
> 
> —
> Reply to this email directly or view it on GitHub.
>
Use only two spaces for indention. Use `X-XHR-Current-Location` as the header name.
This isn't really about Push-State but about XHR. So let's go with X-XHR-Referer.
should be "under the 'sites' directory"
@filipewl, is a class for the element a. This is specific for styling link.
After populate you must run ```bin/rake sunspot:solr:reindex```
Removed the JUnit container in this: https://github.com/skyluc/scalatest/commit/ad354822a5c7644ce575c6f783dba46c1019b6b6
@DominikGuzei: You usually don´t list the properties in rails.
Can we move the toBytes before fn, since it logically happens before ( T=> toBytes => HLL => fn ).
we have to serialize the job in cascading, and objects that are not serializable that get swept up into functions will cause an exception at runtime.
>= would allow for sigma on float.
Add a command-line flag that users can indicate where their appscale tools are located?
Backward compatibility. Can make an issue if we want to change all dbs to do this.
You can make this a docstring instead of a comment, and make life easier for people using this
This check should really be in JSONMaker, not out here. After you build the JSONMaker object out of the dictionary, you shouldn't have to access the dictionary here any more, it should all happen in JSONMaker.

I'd say just call builder.build('all'), and if the 'all' rule doesn't exist, JSONMaker will throw an exception and complain anyway, so this check isn't really doing anything for you.
IMO this `getMetadata()` method should be renamed to not confuse with methods from interface `MetadataSupporter`
hum i dont have it global and it works fine. im pretty sure npm figures that behind scenes.
more than 79 cols / trans block
This will need to be extracted to a common location for all widgets to use.
There is a third use-case involving ```$no-query``` being set to TRUE or FALSE. I think we'll need to expand our validation to include boolean values in addition to classes or IDs.

https://github.com/canarymason/breakpoint#no-wrapping-selector-separate-stylesheet

Since there's no media query "true" or "false" it seems like we'd be ok assuming that TRUE or FALSE is a ```$no-query``` value rather than part of a media query.
agree, will change
No need for the extra newlines here..
again indentation
recreate the docblock
thanks. I dont know it. But lets write simple code :)
To setup a click handler for the link on document ready?
lowerCamelCase function names?
the visible-desktop class here needs to be changed to hidden-phone
Nope... voltarei para o root
Nit: Asterisk misaligned.
no :url
Filter out any "falsy" value from the arguments given. So basically code like this:

```
options = merge({
    charset: "UTF-8",
    sync: false
}, options);
```

Won't throw an exception if `options` is `undefined` or `null`. It's just to avoid to add `options || {}` all the time. I add this not on the commit's comment, but I guess was removed when I re-commit again due some error with git. I can add a comment on the code.
I think stress on `main.js` is confusing maybe something like "You can communicate with your add-on's modules ..." ?
Let me clarify. `EventTarget` can be used to create a message channel that can be shared with others so that they can subscribe to an events. Note that `EventTarget` intentionally has no `emit` method cause subscribers are supposed to listen not `emit`. In order to emit messages on such channels for subscribers one needs to use `event/core` module that is considered a lower level API and is mainly targets creators of event channels rather than consumers. That way capability of listening does not implies capability of publishing, and these capabilities can be required independently.

Selection and Request are fine since they do expose EventTarget's that users can subscribe to but they do not expose API for dispatching messages on them. That being said `event/core` may still be required by a user to dispatch on request / selection
objects but I think it's ok. Reviewers can easily spot if there is something fishy if users require 'event/core'.
Same as in comment for tab tests.
Is jwcrypto used?
To match the way the built-in ones are named (i.e. `NoArgsCommand`), why not just name this `ProjectCommand` and the next one `ProjectBatchCommand`? I don't think the `Base` suffix gains us much here; all `*Command` classes are base classes, because the real leaf ones always must be named just `Command`.
@joshcooper  Sure thing, I'll fix that.
This version seems much better to me.  If we want to be really specific about error handling / messaging, we can catch this in either CommandLine.rb or bin/puppet.rb--those guys *are* responsible for execution.  If this error class is too general to catch in those, we could make a more specific error class for it.
Let's open an issue in redmine about deprecating version in faces
@brixen [here](https://github.com/LTe/rubinius/blob/e6f67e1817131a407be8f560cb773c324b69572f/spec/ruby/core/method/to_proc_spec.rb#L53)
nvm u are right :)
And also no newline at EOF here.
pls add comments on what this interface is, as well as some doc for each method.
Please mark this test as skipped if f online tests are disabled (like de above test)
Moved to #2997
`quando fatto` -> `quando hai finito`
Check all spaces after comma in this file.
wrong desription
no space between brackets
Use `icon-cogs`, not `icon-clock`
I got code for that locally on other machine =] You are just a bit too fast =D
I've had a quick look, I can see that it's a pretty cute way of working with Lucene, and that it addresses your concern of brittle hardcoded field name strings in our code. Also it has neat capability for odata query integration. However, I still feel a bit YAGNI about it overall. It's clearly different but is it better?
Similar to the earlier comment on the pest filter, I am concerned this may match deleted trees associated with plots.
can't we just always reset this to an empty array?
What exactly is being geocoded in this app?
these directories will be non-empty, because you require some files to be there
Didn't realize that. I could never get the cli to work, so I didn't test it.

But if I understand this correctly now: `filepath` is only used to get to the resources folder, correct?
The currently, if you put your file somewhere else, say in resources/lib like many people do, it won't work. The doc doesn't say anything about this but only that it should be the path to the addon.py. Since everything else requires cwd to be root of the addon folder, why not just use cwd for the resource folder too?
Right.  I was confused and thought object refcounting handles that.  Didn't know delete is explicit in webgl.
same as line 96
This means the priority is equal to release-mozilla-release jobs. I think ESR should have it's own value.
in the issuer api, I started returning json errors rather than just plain text. [example](https://github.com/mozilla/openbadges/blob/development/controllers/issuer.js#L264)

        return response.json({ status: 'error', errors: _.map(fields, humanize) }, status);
Could you make this follow the same pattern as the other collections of tests? It's a bit redundant, but it'll make consuming this JSON easier if you don't need to special-case the core tests
More conventional to load plugins at the top of compass config
The whole point of this pull request is to adhere to `frameMax` advertised by the server. Additionally frameMax advertised by the server by default is equal to the predefined `maxFrameBuffer` (ie: 128KiB), so this line is effectively NOP for rabbit with default settings.
Actually, I'd rather have your help on this. The intended behavior is that frei0r_mixer takes two sources and combines them frame by frame. But since I've never completely understood the way breaks work... Feel free to correct this!
this breaks older rabl versions, and afair, latest rabl gem had another bug which we could not upgrade to, @isratrade ?
what exactly happens if we don't pass the conf? I am guessing this will lead to badness.
Hm. I haven't thought about that yet but we should stick to specific versions for all three packages. You an file a separate bug if you want.
Oh, I guess dividing by zero isn't an error in javascript. TIL 1/0 = ∞
the problem was, that a call to $melody->get('people/me') was changed to 'people/default/full'
Why not use something similar to the element's id as l10n-id here? like `pad.permissionDenied`?
Ignore gg's rant, +1 on 4.x url.
Please explain what you mean here.
it's in production ;) might as well be 1.0
Does this line not cover the several preceding lines?
Ah, I see. Yeah, that sounds reasonable...I hadn't considered the issue of a user wanting to go back to a previous version of puppetdb upon receiving a migration error. Fair enough!
[Oh, boy](http://goo.gl/UPOFm).
I think a description of what the inputs and outputs here need to be a lot clearer for this to be its own method. It seems very targeted to a specific purpose, and as such probably shouldn't even be an external API method. To use it, it looks like you might have to get ahold of Cassandra rows (I **think** that's what the `config` object is...) and pass it in, but no one outside of this API should ever access the Config CF directly...

If that's correct, please make this private, and when you're passing around cassandra result sets from method to method, maybe make it clear in the parameter name, e.g., `configRows`, or `configRow`.

I'm also not a fan of how the `tenantIds` parameter seems to need to have some row-ordered syncronicity with `config`. i.e., the `i` variable used to increment through `config` is used directly as an index of `tenantIds`. This makes the method less re-usable and less clear on how how to use it.
This might be out of date now
Can you rename this to reflect that it stores the picture?
Facebook will need a bit of special handling for the secrets. We probably don't want to send these back to the UI but keep them serverside somewhere.
True. I'll make sure that we can configure a server to actually process activities. I'll be changing indexing to be event-driven anyways, so a machine that doesn't handle re-indexing can just not subscribe to that event.
There are no really change on this line, just an extra space char added
I believe you can rewrite this as:

```scala
actor {
  loop {
    ...
  }
}
```

``actor`` is a method in ``Actor`` object (if my memory doesn't fail me). And the actor is automatically started for you. 

As a more general note, I think you should always start an actor *after* it was created, or you may be experiencing threading issues because the *this* reference is not safely published (but this should be double checked).
that's a medium large whoops
I needed the object reference in my project and I was stuck for quite some time. Before I looked it up, I didn't know about ModelForm.instance and probably most template designers will not know about it either.
Unfortunately, the duration of "monthly" and "annually" isn't consistent.

I'm not convinced that there's a good use-case for formally encoding this.
По условию задачи, mut - процентный показатель. Так как вы нигде не задавали константу, в которой хранится количество символов в последовательности, такой подход, как у вас, сойдёт, но нет проверки, что mut>100 (проценты ведь!).

Довольно интересный алгоритм изменения, но вы уверены, что в нём изменится столько, сколько вы захотите? Когда вы удаляете элемент, например, 23, то 24 элемент становится 23, 25 - 24 и так далее до 100 элемента, который станет 99-м. Вы уже изменили последовательность, и неизвестно на сколько процентов.
Any reason to make this "jsonp" instead of the default value jQuery uses which is "callback"?
There are only three files in this project. There are not any files .idea, *.db, settings_add/production, settings_add/local in it. File .svn excluded by default. May be just exclude .pyc?
potentially re-entrant -- two withvars calling `callback` will break plate.
To help clarify, onCreate is called once, but once for each time a new tag is created. onInsert is called as many times as a tag is inserted into the DOM (allows you to act on what's around you at insertion time).
yes in the next update it throws exceptions
else { ? }
I think I'd rather see this managed through like HUBOT_HARVEST_EMAIL and HUBOT_HARVEST_PASSWORD. It's not great to be using chat to set the authentication bits.
If this code isn't needed it should be removed because it only makes things more confusing to leave it in.
i think especially this i would see as acandidate for a -- context independence!!! -- function. it's cool, but what about factors, formulas, what have we? so many ways to merge events. this i would bind later to an instance as we are more experienced, so to say.
forgot to decorate this one?
Maybe we have to use a connectivity class instead of the 2 function pointers. This would allow us to use some more method-specific logic.
n_components should be the first argument and be mandatory to set for the user

```
def __init__(self, n_components, noise_cov=None,
```
if the info dictionary is empty, should an empty FIFFB_MNE_ENV block be written?
Is this a general purpose method to check for duplicate names, if yes, then it should always be case insensitive
this is missleading as ``$attributes`` does not contain the attributes of a tag but an array of tags with their attrbutes
Hm, okay. Off with it's head, then.
"unsuccesfully"
@grzuy is right. If you don't have the double slashes, it will be treated differently. The double slashes simply use the scheme of the page that loaded it.
What's going on here with the curly braces?
Do you mean a new <select>?

Because, in this UI for creating new workspace, I want to add the ability to select the template to use.

One self-critic on this point : you have to use the old WikiManager to set which subwiki is a template.
Style issue: arguments should line up.
I know. I should not have added them yet. Will impl them very soon. 
They are all documented in the specification.
spaces around `+` and `-`
Yep!  It's great for deployments and tests!
Oh, right.  Well, test for that.  Tests are supposed to help us make sure that things we take for granted works. :-)
$options['height'] = $options['width'];
this JS only contains Mustache rendering code, please rename it
Do we need to force synchronization here? Shouldn't it be better to let Cocoa dealing with this?
Is it a private variable? If so, please add a under score at the beginning of the word.
Could you try doing `I18n.load_path = Dir[] + I18n.load_path` instead?

Because:
```ruby
[1, 2].unshift [3, 4]
# => [[3, 4], 1, 2]
```

Also, if you can look into the I18n machinery. I'm concerned of side effects that this could have for other people. We run into so many issues when it comes to i18n.
Hmmm, seems like it currently is. We should consider extending it to other parts if we're doing a lot of these annotation check calls somewhere else.
Yes. As with other tests, I had disabled them to avoid making everyone confused with those tests that fail...
Also, remember the reason for moving away from the activation interceptor for keeping the counters and logic to remove from store: the fact that I need to do activation from within the hash map's put call. 

I appreciate the comments but if you have other solutions in mind, I'd definitely suggest giving them a shot because tests can easily break. A great deal of time was spent fixing this and finding a way to solve it in such way that all tests passed too, code duplication was avoided and logic split was kept to a bare minimum.

Sure, I can understand I might have got some observations wrong above. I coded this a month ago (!!) and so my recollection is a bit buzzy.
Interesting thought… that is fairly easily computed from the absolute URL though.
Casting should be unnecessary with expecta.
The contributions page could probably do with a refresh too.
Could you put spaces around `==`?
space before the "*=" operator
I've added this back.
We *could* compute this file, rather than having to store it. Not sure if we would want to do such a thing (the only reason I have is to reduce the number of extra files needed in the repo). @mdboom : any feeling on whether we need to be particularly cautious of growing the repo too much?
Don't call vec on the output, it doesn't matter, just has to be a sequence
Well, I just looked over [Google's documentation](https://developers.google.com/kml/documentation/kmlreference#when) and it seems that they follow ISO 8601 loosely, the only difference being everything after the year is optional. 

If that is the case, then it looks as though my existing regex split would work as-is, the only trick is that you wouldn't always get the full 6 elements (year, month, day, hour, minute, second). I'm just playing around with timegm, and it seems that it will accept 0s for everything except the month. so you could use my regex as is, and if the result is a list one element long, you'd have to add a 1 and then four 0s, and for anything else you'd just have to add 0s until it was 6 elements long. 

Thinking this through further, one could argue that my program really *requires* the data to have resolution down to the seconds. If all the points only have year resolution (or even just hour resolution!) how are we supposed to correlate that to the photo timestamps, which will always be second-resolution?

For example, if you had some KML data that looked like this:

```
<when>2012</when>
<coord>50 50 50</coord>
<when>2012</when>
<coord>51 50 50</coord>
[etc]
```

How are we supposed to make sense of this? Sure, `dateutil` is parsing this date correctly, but the entire essence of my application is predicated upon being able to track a progression of movement through both space *and time*. All of the `when` tags saying 2012 are going to resolve to the exact same epoch second and there will be no way to determine which one came before the next, once the data is all loaded. 

So I think my preference would be to drop the dateutil dependency, and just use my existing regex as-is, and then in the KMLFile class you'll just have to put in a simple check that the regex got you at least 6 numbers, and just zero-pad whatever was missing.  Something like this I suspect:

```
when = map(int, split(state['when']))
time = [1] * 2 + [0] * 4
time[0:len(when)] = when
timestamp = timegm(time[0:6])
```
Move that if down so it doesn't have to chain so much. Change this line to rubygem.disown and let that decide what do do. Maybe something like:

```ruby
class Rubygem
  #...
  def disown
    ownerships.delete_all if versions.indexed.exists?
  end
  #...
end
```

I still think the versions.indexed.count.zero? is a big smell, but I can't think of how to clean that up right now.

Moving the if inside the Rubygem keeps the logic closer to the domain at hand.
Similar logic is currently locked up inside the LiteCountServlet. When I reworked that class to be more efficient, I couldn't quite justify refactoring it into a service, but the combination of KERN-2841 and KERN-2888 makes it very justifiable. So would you be OK with calling this a MessageCountService instead of just an UnreadMessageCountService, in the expectation that the other message-count code will be moved there soon?
please add an init function which is called from constructors that registers all parameters to shoguns serialization framework, i.e.,

```SG_ADD(&degree, "degree", "Degree of poly-kernel.", MS_AVAILABLE);```

would register degree to be a parameter that is also available for model selection
Hell yeah, `sprintf()` is way better for formatting strings! :)
Yeah, not sure what the deal is here either. Will keep.
Ah, didn't realize ORM has inbuilt mechanisms to handle input sanitization.
This whole block is just a single boolean expression and should be formatted as such.
More of a typo than a type error. I'll fix that tomorrow.
Are you sure the method ``scalarNode`` can be called on ``$rootNode->children()->v...de('autoescape')->end()`` (of type ``null|object<Symfony\Comp...er\NodeParentInterface>``)?
Added but seems to be unused
bold/italic > caps
If and only if. :)  I'll be more clear.
How are we unregister this listener? I'll put a FIXME not so that we don't forget about this.
Good catch... know of a vim plugin for detecting tab widths? :)
if we are moving to <title> you won't need this
it is not allowed
Multiple potential problems here:
 1. `map` is a method available to objects that inherit from `Array.prototype` but only in browsers/engines that support the JavaScript language standard ECMAScript 5.0+.  This therefore [excludes IE <= 8](http://kangax.github.com/es5-compat-table/) when `querySelectorAll` is used instead of Sizzle.
 2. In some (most?) browsers, `querySelectorAll` (i.e. if Sizzle is not available) will return a non-live [`NodeList`](https://developer.mozilla.org/en-US/docs/DOM/NodeList), which does **not** inherit from `Array.prototype` and therefore does not have the `map` method available for use.
Нужно брать лок.
The *The confirmation token was sent to {{ email }}.* part is a bit strange. If they are on this site, they obviously came through e-mail. I would leave it out and add this information to the last sentence:

*If for some reason the input box below is empty, paste the token in manually from the confirmation e-mail you have received.*
You could use [isEmptyObject](http://api.jquery.com/jQuery.isEmptyObject/) then here.
what should I do with google template tag? Should I leave the file without any functions for later usage or delete it? And how do I delete the file after git add and git commit commands? :)
Since these are actually executed on the server, we don't want to start the deployment process until we know it will go well. otherwise, we end up with a codebase that is in a weird state.

basically, since this is a stated up operation, we want to know beforehand if it will fail, not after.
This file has got to have badass code-churn ;).
I made the update, I want to keep this here just in case it is needed in the future with API changes.
Let's just call the `item_id` method here or create an alias to make it clear that the two methods do the same thing
The problem is that delete will be fail if file still opened by other problem, like tortoisemerge. 
There will be race condition when tortoiseproc open and tortoisemerge open at almost same time. 
I agree on add new button on that
That is the Debian based doc... is there anything for RHEL?
practise -> practice
positive test is better rather than '! isNestedLoadDisabled'
> This has the following drawbacks:
>
>   most contributors or users will not be aware of this guarantee, so they will not be able to understand what makes your code
> tick; 

In most the case users don't even need to care about this, as long as they can move from sync to async without issues that's all they need to know really. As of contributors I think I tried to document fact that it guarantee FIFO order pretty thoroughly, if you think of any other ways to make contributors aware, I'm open to that. 

>  in many cases, most contributors or users will have no clue of the order in which handlers have been registered, so this will
> again get in their path if they try and understand what makes your code tick;

If your code does not cares about an order, that's great and there is no problem in knowing which order it works. But if there is a cases where your code depend on order it's really useful to have it deterministic. If someones code depends on such order I expect them to try to learn about guarantees that library they use makes.

> as a former concurrency guy myself, I tell you that this hypothesis is very shaky once you introduce actual concurrency, which I > understand is one of the objectives of Jetpack.

In Jetpack promises just help us to compute and reason about eventual values & computations. Having undetermined handler invoke order will make this harder. That way one can't reason about behavior without finding out if promise is resolved in the same turn of event loop or not.

> I have not been able to find this in the specifications of Q. Could you point me to it? If this is just an implementation detail and
> not a specification, I really suggest we avoid these semantics.

Q has it, as they always queue all the operations so it's never sync, that is why order there is FIFO.
(Copying from above-) Just personal preference. I rewrote the lines in a few attempts so I didn't mean to make that change in particular.
Yeah, it's escaped with `%`
Old comment that you didn't write, but I doubt this is an issue on the web. I would remove this comment.
What do you mean, "That will get stringified later"? No, I think you're right, when it's "" or null I'd rather show nothing than the dash. Changed line to `title = win && win.title && (" – " + win.title);`
Should `FONT_INHERIT` be after an explicitly specified enum value? It'll have the same value as FONT_MAX -- is that intended?
The default value should probably be false here? Why would we want this enabled by default?
yeah we do want to use the jenkins / api module in the other places where the bot is communicating with jenkins.
It doesn't look like this can support multiple variables for one file source.

For example, I should be able to have my CSV file with data like this:

`Branden,Visser,Branden Visser`

Then I can read this file into variables like this:

```xml
<setdynvars sourcetype="file" fileid="file_user_info" delimiter="," order="random">
  <var name="first_name" />
  <var name="last_name" />
  <var name="display_name" />
</setdynvars>
```
I just think it's easier to tell in the graph if the confidence interval straddles zero and contains the point rather than centered about the point estimate and containing zero. Cf. Stata.
why Xj and not x? What's the difference between convolution and the plain kernel? (I didn't read the reference for this.)
No. It works for and is tested for all the discrete models, using the _derivative_predict of the models.
Oh man good catch, this was kind of a hack.  As it turns out, currency is the only number format that specifies separate positive and negative formats.  For example `resources/locales/en/numbers.yml` you'll see this: `:default: ¤#,##0.00;(¤#,##0.00)` - notice the conspicuous lack of a minus sign.  I thought I was doing the right thing at first by moving `get_tokens` into `currency_formatter.rb` and specifically prepending `#{sign}` to the front of each formatted string.  That approach works, but doesn't handle positive/negative format possibilities for other number types (eg. decimals, plurals).  I have moved the sign stuff into `NumberTokenizer` to be more explicit and consistent.  The `get_tokens` function has been moved to the parent `NumberFormatter` class where it should have been all along.
We should have a test for this in the video player spec.
Again, not a substantial comment, but spaces around binary operators make things easier to read (http://dev.lsstcorp.org/trac/wiki/PythonCodeStandards#BinaryoperatorsSHOULDbesurroundedbyasinglespace)
Actually, you're right.  I just missed reading the word resolution.  "higher resolution" is fine.
Too bad.  I couldn't try it myself, since I haven't gotten doxygen 1.8 yet.  But I was hoping that would work, since doxygen usually does look into comments.
This absolute positioning looks fragile. I'd suggest an alternative. Instead of this canvas.add(), do

this.__criteria.getSearchResultsList().getLayoutParent().add(this._noResultsLabel);

This will just add it to the same vbox that the search results list is already in. Since you later hide one and show the other, it will appear right where the search results were.

You may also want to do this._noResultsLabel.setTextAlign("center") so that it doesn't come out right below the "Search Results" label.
Good spot. I'll remove this.
was surprised also
in this case the string is coming from a param. Are you finding params are coming in as ascii, but represented as UTF-8?  That would then be a bug in the rails params code that we'd want to track down and fix.
this block causes issues if no messages param is passed, should be replaced with:
```php
        $messages = $this->container->getParameter('fm_bbcode.config.messages');

        $messages = empty($messages) ? array() : json_decode(\file_get_contents($messages), true);
```
I think this can be changed to `$('.browserid-login, #browserid')` to handle both cases rather than doing a bind below.
I dont quite understand this guard? the original idea whas that 'state' would not exist and None would get passed to refresh which is a nop (IIRC, .. and its quite possible I dont not recall correctly).
Yes, it was kind before name in create on the beta release.
Awesome, glad to get rid of it!
the UX people wanted to do it that way. and i think it indeed made things look nicer and easier to use. if its not too hard to fix, would be nice to get it back. if its really a big pain we should open a new issue for it to not block this PR forever.
yes hopefully.
Really? There was a bug with click events that I have fixed in the git repository. Do you use the last version?
Turns out [InheritedExport] is a bit broken when used with Metadata attributes.

http://stackoverflow.com/questions/6570930/how-to-use-mef-inherited-export-metadata

Calling the base constructor with typeof(ICommand) in CommandAttribute achieves much the same thing, so I have done that.
I'm using windows 7. Not sure what autocrlf is. I'm not experienced with git at all. >.> And when I edited this I used the basic text editor from windows because I couldn't find it in DM. Could that do it?
Wieso würdest du das wollen?
Ох, @denchistyakov вот, что бывает если про innerHTML не рассказать.

```javascript
row.children[0].innerHTML += number + event.locationToString() + event.starsToString() ...
```
Oh, you trying to solve that with super in your find method?
А это называется copy-paste
Please don't use spaces after ( or before ) - that's not PEP8.
I think the SharedPreferences will be shared across tokens, so if someone is using multiple tokens, this will overwrite the first token. And then you'll be writing device ids to the wrong project. Please check this.
We shouldn't return a response status code if we're expecting an app id. Instead this should return None and print the status code to console, or throw an exception with the status code.
we should indent this lines
Можно ли уменьшить объем входных данных? `__button` и `__popup`, кажется, безболезненно можно достраивать из шаблона.
If possible, I'd like to avoid the word "train" in sklearn. We don't usually use it and I think it is a bit confusion to have both, "train" and "fit" methods.
Whoops, overlooked that.
There should be a full stop after results ;)
It would be great if you could wrap this into a ``try: ... except`` to generate a detailed exception if the base learner does not support ``feature_imprtances_``.
Hm, can this be more refactored, so that we don't have code within the catch-block that actually controls the program flow? I didn't check the context, just the diff...

(Note: initially added comment in wrong file)
Same problem as above. Not sure if it should be just dropped or replace with another check.
It should be:

else if (peek(&token)->value == TOKident)
See StorageClassDeclaration::stcToCBuffer(). The implementations should be shared. The storage classes not in stcToCBuffer() should not be printed, they are internal only.
The second parameter needs to be implemented, will implement it in 'part 2'. added comment for TIMOB-9788 task
ARC really spoils me :)
trololo Xcode templates
some of the `@see` or `@param` are followed by tabs, some by spaces ?
Refactored to use rowManager->allocate /
Since it currently processes data from the slaves sequentially this could be implemented as a simple counter. 

However it will allow the code to be parallelised easily so makes sense.
I'm curious why you have chosen se(), not setown(). If you set it twice, both on setown() above and this one, the created constant leaks. If there is no way both could be set, then maybe make it explicit with an "else if"?
No harm though, I missed you were returning 'ipAddress' by reference.
Thanks for improving the code.
Maybe better to make custom Dialect?
This needs to be confgured, it will break the more general case of reglar mysql.
The tests pass without with the signal hooked up and the line removed.  There was a bunch of rework leading up to what we have now, so it's possible that we can just leave the signal hooked up and remove the line.
As above regarding indentation.
It is better to make the language parameter the first one in the route, isn't it? usually multi-lang websites has the language part at first like http://www.zend.com/en/ I think that the route should be /[:lang[/:controller[/:action]]] what do you think?
Details to setup are [here](http://about.travis-ci.org/docs/user/getting-started/). Follow step 1 and 2, the rest I have done. When that is done merge this request and it *should* kick in and do a build
How it is related :question:
Not that I'm aware of. You could create a js file declaring the variable and include it in the header, but it's not worth it.
This needs to be `{% load thumbnail %}`
This is wrong... it should be default["keystone"]["nova_db_server_chef_role"], no?
If the script is evaluated atomically, there should be no need to check the key a second time, correct?
Кстати, JSON.stringify может принимать еще 2 параметра. 
2-й - функция, которая будет вызвана на каждом элементе, 
3-й - формат табуляции для красивово вывода.

```javascript
JSON.stringify({a:1,c:[0,2,3],d:{e:6,f:{x:"123"}}});
// {"a":1,"c":[0,2,3],"d":{"e":6,"f":{"x":"123"}}}

JSON.stringify({a:1,c:[0,2,3],d:{e:6,f:{x:"123"}}}, null, '    ');
/*
{
    "a": 1,
    "c": [
        0,
        2,
        3
    ],
    "d": {
        "e": 6,
        "f": {
            "x": "123"
        }
    }
}
*/
```
same as above. do we need to pass driver around?
проблем не обнаружено.
Tälle olisi voinut antaa nimen `let`issä, kun se esiintyy kahdessa haarassakin
It was put in place to support multiple isoformats being defined.  I think it is not required, so I'll comment it out and consider removing it
This should be `is_sorted_descending` because the higher value (rockin') should come first.
connect sortbyfieldchanged from the model to recalculateDisplayLabel?
Note this was against just any old SSH server, not the vuln software. Tectia's message may evaluate and be matchable (OpenSSH's doesn't).
What happened to the Rulph Franklin license & attribution?
Actually, strike that: You use 'N' below for image sizes. You could the change the docstring to use 'P', but really, I don't think code comments necessarily need to match the docstring.
Yeah I noticed that, but that is how the generated service interface looks. It seems to be a common pattern in the service YAML to have empty dicts for default parameter values, which I don't like. Better to use ``None`` across the board there?
The diffs are messy here after moving some code around.  The line still exists in the mouse handler in its new location.  It's commented out in the touch handler because I'm not sure what its intended effect is (I think inertia).  @bagnell is going to take a look at the inertia stuff when he gets a chance.
For some reason this is being removed and it shouldnt.
In theory, you could check for the existing color and early return if the color value has not changed.  IE:  int currentColor = ((PaintDrawable) tab.getBackground()).getPaint().getColor()
I somehow doubt most users will be Opie. Should have a different default and we need to ensure its correctness.
default:Titanium.UI.TEXT_AUTOCAPITALIZATION_NONE
Sounds good, I like it.
Since the logic here changed, we should also update the comments as well.
Android has this.
Cap. And "layout Child" is puzzling me. Maybe:

"Ignoring new layout values until animation finishes."

? Will guess here, feel free to ignore.
In doc (http://docs.appcelerator.com/titanium/2.1/#!/api/Titanium.UI.TabGroup-property-tabs), tabs is a property but not a method. We should keep "@Kroll.getProperty".
Whut? We don't to always log to screen during a unit test.
I always get confused when I see tuples indexed like a list, but OK :-p
This is a bit too complicated. Can you separate out the nesting and make it a bit clearer as to what's going on?
> In build-bundle-file.sh:
>
> >  [ -n "$GEM_SERVER_URI" ] && GEM_SERVER_ARG="-s $GEM_SERVER_URI"
> >  ./bin/mirror-gem $GEM_SERVER_ARG -d tmp-build-dir/tmp/gem-mirror `cat
> > opt/gems/gem.list`
> >
> >  # Add GemRC file to the ISO to use the mirror
> > +cp -p opt/gems/gem.list tmp-build-dir/tmp/gem-mirror/gems/gem.list
>
> OK...that works for me...will run a quick test and, if it passes, merge
> these changes. Thx for being patient with me on understanding the details in
> this pull request ;)

No problem at all: I am really, really happy to have you here as a
sanity check on the changes. :)
Could you put in a comment on why you didn't just write 'this.autologin = params.autologin || true;' ?
Yeah, trying to loosen up... if you have a catchier one, I'm all ears :)
Ага, я всё время забываю про это. :cry:
Also un-intentional. This was correct before :(