labofsahil/github-event-dataset-2012 huggingface dataset:
hehe. ok, then we'll leave it there for now :)
Or you think there is not good to talk about None where talking about boolean?
It looks like I wanted it. Add some debug in Player and make sure AudioTrack uses the right sample rate?
The odd thing is, I did do that: I noticed that the file occurred both staged and modified. I've just double-checked in my terminal history!
timeout is not gone
<h3>Essentials Day Spa and New Home of Papa John's</h3>
The problem is that `shift` doesn't work with `%*`. Enclosing the parameters with double quote should fix the problem, right?
Ah yes, thanks Stof - totally didn't think about that - I've made the change.
The bundle config is not needed. There is no production environment in grisaille, so we can use a naked `bundle instal` just fine. In the sites, if we committed this file then we'd have problems once we try and push it to heroku and find that the production gems aren't loaded. It's best to keep `.bundle` out of the repo altogether, and so add it to `.gitignore`. Any config should be either saved locally on your machine or handled through shell aliases or something.
its less than 1 mb, so wont matter much lol
I wouldn't be opposed to that.
I'm still a little fuzzy on requirejs. Can you show me how we'd use it to solve this?
Please put test functions into a separate ros package, maybe even in a different package. At least use a different file to indicate that the functions in that file are not necessary for the package do function properly. The file process-module.lisp should only contain functions that are related to the process module.

Please respect the common lisp coding style used above. Your code is really really hard to read. Lisp is not c, so don't try to mirror C's syntax. In short:

 - avoid unnecessary whitespaces and blank lines
 - closing parenthesis are never on a single line.
 - try to avoid abreviations (I know, the code doesn't respect that completely, but I'm refactoring it...). A variable name such as tr is bad because it's not really expressive. Better use something like carry-pose-trajectory
Hi Ivica:
isn't this the default port for solr? Why was it 8983 instead of 8080?
What is awesome is the insane way you are supposed to do it:
http://www.redmine.org/projects/redmine/wiki/Alternativecustom_authentication_HowTo
and specifically for rpam:
http://crysol.org/es/auth_source_pam
It looks like you left the amount limit as $lim in line 448, and as an option in plugins config, but set serendipity_fetchComments 2cd param limit to Null, on line121, which means show them all, right? Did you ask Malte (onli) about this change in future behaviour?
So some retarded developer :(
This time auto merge tool didn't worked for all the changes... so i did my best to fix it... but could have failed... if someone detects something wrong... just yell and --you will be ignored--... ermm... it will be fixed :D
good job - may add Ensorceled Choker recovery gossip script


```sql
-(@NPC_STEFAN,0,1,2,61,0,100,0,0,0,0,0,72,0,0,0,0,0,0,7,0,0,0,0,0,0,0,'Stefan Vadu - On gossip select - Close gossip'),
-(@NPC_STEFAN,0,2,0,61,0,100,0,0,0,0,0,1,0,0,0,0,0,0,7,0,0,0,0,0,0,0,'Stefan Vadu - On gossip select - Say line'),

+SET @SPELL_PUSH_ENSORCELED_CHOKER :=53810;

+(@NPC_STEFAN,0,1,2,61,0,100,0,0,0,0,0,1,0,0,0,0,0,0,7,0,0,0,0,0,0,0,'Stefan Vadu - On gossip select - Say line'),
+(@NPC_STEFAN,0,2,0,61,0,100,0,0,0,0,0,72,0,0,0,0,0,0,7,0,0,0,0,0,0,0,'Stefan Vadu - On gossip select - Close gossip'),

+(@NPC_STEFAN,0,4,2,62,0,100,0,9709,1,0,0,85,@SPELL_PUSH_ENSORCELED_CHOKER,0,0,0,0,0,7,0,0,0,0,0,0,0,'Stefan Vadu - On gossip select - Invoker Spellcast');
```

Patch:

```sql
SET @NPC_STEFAN :=28518;
SET @SPELL_PUSH_ENSORCELED_CHOKER :=53810;

DELETE FROM `smart_scripts` WHERE `entryorguid`=28518 AND `source_type`=0 AND `id` IN (1,2,4);
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@NPC_STEFAN,0,1,2,61,0,100,0,0,0,0,0,1,0,0,0,0,0,0,7,0,0,0,0,0,0,0,'Stefan Vadu - On gossip select - Say line'),
(@NPC_STEFAN,0,2,0,61,0,100,0,0,0,0,0,72,0,0,0,0,0,0,7,0,0,0,0,0,0,0,'Stefan Vadu - On gossip select - Close gossip'),
(@NPC_STEFAN,0,4,2,62,0,100,0,9709,1,0,0,85,@SPELL_PUSH_ENSORCELED_CHOKER,0,0,0,0,0,7,0,0,0,0,0,0,0,'Stefan Vadu - On gossip select - Invoker Spellcast');
```

with best regards
Does this fix https://github.com/TrinityCore/TrinityCore/issues/4847?
meant to reference issue gh-1573

This commit should be made in conjunction with @pschwartz 's corresponding change and @wangkx 's
Oui, je parle un peu. Assez bien que je comprends des méls simples :) Et une petite correction: mon nom de famille est Ledbrook - il n'y a pas de 'e' à la fin. Mais ce n'est pas grave :)
I usually avoid hard-coding the singleton pattern. It is enforced it via dependency injection when necessary. Usually, it is fine to create several instances, even when one would do the job. This makes it easier to use interface and polymorphism.
C'est bon, voir c7156646
Use foreach instead of old school for.
There was no reason for this to be a class variable.
Just tried this out.  Ran into this exception right away.

app[ERROR]: java.lang.IllegalArgumentException: can't serialize class scala.collection.immutable.$colon$colon
app[ERROR]: 	at org.bson.BasicBSONEncoder._putObjectField(BasicBSONEncoder.java:270)
app[ERROR]: 	at org.bson.BasicBSONEncoder.putObject(BasicBSONEncoder.java:174)
app[ERROR]: 	at org.bson.BasicBSONEncoder._putObjectField(BasicBSONEncoder.java:226)
app[ERROR]: 	at org.bson.BasicBSONEncoder.putObject(BasicBSONEncoder.java:155)
app[ERROR]: 	at org.bson.BasicBSONEncoder.putObject(BasicBSONEncoder.java:120)
app[ERROR]: 	at com.mongodb.DefaultDBEncoder.writeObject(DefaultDBEncoder.java:27)
app[ERROR]: 	at com.mongodb.OutMessage.putObject(OutMessage.java:142)
app[ERROR]: 	at com.mongodb.OutMessage._appendQuery(OutMessage.java:85)
app[ERROR]: 	at com.mongodb.OutMessage.query(OutMessage.java:44)
app[ERROR]: 	at com.mongodb.OutMessage.query(OutMessage.java:38)
app[ERROR]: 	at com.mongodb.DBApiLayer$MyCollection.__find(DBApiLayer.java:303)
app[ERROR]: 	at com.mongodb.DBCursor._check(DBCursor.java:369)
app[ERROR]: 	at com.mongodb.DBCursor._hasNext(DBCursor.java:504)
app[ERROR]: 	at com.mongodb.DBCursor.hasNext(DBCursor.java:529)
app[ERROR]: 	at com.novus.salat.dao.SalatMongoCursorBase$class.hasNext(SalatMongoCursor.scala:45)
app[ERROR]: 	at com.novus.salat.dao.SalatMongoCursor.hasNext(SalatMongoCursor.scala:145)
app[ERROR]: 	at scala.collection.Iterator$class.foreach(Iterator.scala:660)
app[ERROR]: 	at com.novus.salat.dao.SalatMongoCursor.foreach(SalatMongoCursor.scala:145)
Before going further in that direction we should have a look at [PyTables](http://pytables.org) / [blosc](http://blosc.pytables.org/trac) to avoid reinventing the will.

Optional support / integration for working with data managed by pytables level would be very nice. This could be  done either at the joblib or scikit-learn level. I don't know pytables enough to know which would make the most sense.
Just to clarify, this was just a random idea: I don't intend to add that to scikit-learn anytime soon :)
Thanks a lot :) you're really cleaning things up at the moment!
This was a multiple change with in framework.  Adding electronic Beam, enable toast to turn off, and minor changes to codecs to avoid overflow.
WITH GALOISE LFSR
If you want to keep having this conversation, can we do so on mendicant-research or via IRC, or some other medium? Commit comments are great for discussing a particular change but you're talking about overall design issues and this is much less likely to be rediscovered by someone else here than it would be on a discussion channel of some sort.
Very nice. This will be helpful for anyone who doesn't understand who php works together to accomplish a web protocol. The only thing that bugs me is your sanitize.php. You should probably never be using mysql directly like that (also mysql_real_escape_string isn't really that safe anyways). The preferred solution is using PDO (prepared document object) statements. For those who don't know about it, read about it here: http://php.net/manual/en/intro.pdo.php
Here's a note: Good Work! :)
Graças ao JavaScript podemos fazer com que os objetos gráficos apresentados na página (como por exemplo uma imagem, um botão ou uma ligação de hipertexto) respondam dinamicamente às ações do usuário. Para que isso aconteça basta adicionar um novo atributo ao elemento responsável pela apresentação desse objeto e escrever o código que ao ser executado dará origem ao comportamento esperado.
'query' is much better keyword then 'sql'
I didn't do a proper concurrency check of this whole thing yet. Looks good in principle, but I'll do a thorough review when my head is clear.
And here:
                  <h4 class="subcategory"><a href="forum/category/view-topic/?t='.$row['id'].'">'.$row['name'].'</a><span class="small"> ('.$row['replies'].' '.$Forum['Forum41']. ')</span></h4>
more dots
Hi Artem,

what fixes this?
Given the current reality of how `.modulebuildrc` mirrors the behavior of the command line and includes the special case of `Build.PL`, the documentation is handing the user a flawed method of setting install paths.  Setting default install paths in `Build_PL` works just like passing them into `perl Build.PL` which is the safer way of doing it.  Setting default install paths at `install` time *silently* overrides what the user might have passed to `perl Build.PL` and that's just wrong.

If you want to discuss changing how `Build_PL` behaves then open an issue about it, and if that gets changed we can change the docs to reflect that new reality, but don't write doc examples based on how it might possibly work in the future.  The user has to cope with how it works right now.

If you want to discuss changing the order of how command line and modulerc defaults are handled to avoid the defaults blowing over `perl Build.PL` arguments, open an issue about it.  That is probably the long term fix, but again, that doesn't mean we can't fix the docs for how reality works right now.

If you disagree and think that setting default install paths at `install` time is safer and more beneficial to the user using the current version of Module::Build, by all means argue that.
Without build output there's nothing to go on. I'm not experiencing any build issues and I try to keep this rebased quite often. I suggest checking what changes you've included in your build and making sure there aren't any conflicts.

Do you know at least where the build is failing? frameworks_base? CMParts? Themes?
By the way when I designed Node, I made sure I wrote a few use case driver piece of code using it. I suspect that using it with your proposal would lead to a complex and hard to read code.
Thanks for this!

Btw. If you'd like me to add your full name [to the AUTHORS file](https://github.com/tomchristie/django-rest-framework/blob/master/AUTHORS#L30), let me know what it is - it's not visible on your github profile.
verdade camata, sintaxe errada. é have(1).turma
Shouldn't it be event.preventDefault()?
This will set self.multiple once for each prop in self.props. Later iterations of the loop will just overwrite earlier ones, which isn’t correct.
"policy" instead of "p" would make the code below easier to understand
get it from cm7 it's on bionic repo
I'm going to do this right.  Revert followed by two commits coming right up.
I don't want to sound like a jerk but the only thing that comes to my mind is that you didn't included the bootstrap javascript in your project. I don't know. Tell me more if I can help.
This file is scary.
the CAS protocol parameter and the value we put in the flow scope are two different thiings.  This muddles the parameters.
Can the people who've thought about the versioning scheme we're going to use write it up somewhere?
You mean like:

    MemberJoined(address: Address)
    MemberUp(address: Address)
    MemberDown(address: Address)
    MemberBecameUnreachable(address: Address)

I'm not sure that adds much value, but if we think it is useful I can do that also.
Viktor is often nagging on me for breaking up lines, but I insist on keeping them below 120, which I think is a nice max. 80 is too short.

I see no difference for java and scala for these formatting conventions.

Doc samples are different.
(undocumented) naming convention is that all args with shall not become fields (i.e. only passed to super constructor) get leading underscore; please add them (no such rule for secondary constructors, because their arguments don’t become fields).
Don't think this line is needed..
I think we have a convention to use max 120 chars lines.
Not followed everywhere though.
it is, the latch must be countdown within the timeout (otherwise it will fail with an exception thrown)
why isn't "v" used here?
Yes. A FIXME should probably be added to the dependencies in AkkaBuild as well.
Open a new Socket on port 0 instead, obtain its port, shut it down and use that one.
I think there should be a one-to-three-word description of the purpose of the branch between X and Y (BTW: I miss that in your branch names lately …)
This method seems _very_ expensive both allocation-wise and complexity wise, IMO needs an overhaul.
I am not an english expert but shouln't this go like this? 

"The WEB-INF/classes directory of a war is a bean archive if there is a file named beans.xml in the WEB-INF directory or  the WEB-INF/classes/META-INF **directory** of the war"

or

"The WEB-INF/classes directory of a war is a bean archive if there is a file named beans.xml in the WEB-INF directory or **in** the WEB-INF/classes/META-INF **directory** of the war"

Same case below.
grammar issue here. "an arguments", and we should use plural if there's just one.
I don't think it needs to, although `optional = value.gsub!(/\s*!optional\s*$/, '')` would be cleaner.
I thought of discount() as a way for the user to retrieve the discount value for viewing/manipulating outside of the class. Should I rename it to 'get_discount()' or perhaps 'show_discount()'
I also thought that since we are referencing all sorts of count dictionaries internally, we may as well avoid the overhead of calling a method. It's not much, but I'm assuming people will want to run the prob() method on large chunks of data, so every little bit may count.

Let me know what you think!
I haven't looked closely, but it seems like "link" is ok here, since this is specifically link parsing.
Bad indentation. Either remove the { and } or fix their indentation.
Вот тут ты закоментил много тестов. Но они ж нужны. Проверяется возможно принять товар используя отсканированный код. Это важная функциональность.
Geen reden voor de dubbele quotes, spatie zal ik aan denken.
changed words.
The folder should not start with a dot, or contain capital letters.  `_git-remotes` would be better.
commenting on 'more things to read'
Let's discuss about the class tomorrow ;) I have question about the way retries are handled
I think this version is better. Any reasons?
this is still a little wonky since the code was all locallized in User before, but I think this will be really the cleaner approach going forward.  This is where a lot of the stuff inside the transaction went.  The stuff in User got way simple, which is very good.
Missing formatting, same for the other methods.
Am I losing it or is this function missing?  Fwiw, it'd be nice if we didn't need both window.postMessage and MessageChannel.  Might be worth testing window.postMessage for speed.   From six months ago: https://gist.github.com/2802407
okay, I keep forgetting that
code is now with positive test and else, with the visibility fixed. Patch is still quite simple regarding the possible code deduplication.

Xavier
Functions the same way as `TUITextView`'s `drawFrame` property, and I thought it would be okay, since the idea already existed in TwUI.
Alright, I'll clean up the code while I've touched it. I'll go with `tab`.
Looks like you have two times this declaration. See Line 1721
Hard to put that as a version number, since we don't know if the version after 1.8 will be 6 months or 2 years after. I'd say 2 years is reasonable.
Thanks. I've updated it to use add_next_index_zval().
I'm quite positive that this needs to be name_cont.
Fix in https://github.com/rails/rails/pull/8584

Let me know if that works. Thanks for the review!
Why are we caching the return value of `klass.connection`?  The connection should be cached on `klass`, and double caching doesn't buy us anything except code complexity and headache.

I'd prefer if this was just:

```ruby
def connection
  klass.connection
end
```
This would better be in a constant.
I think this would compute `tags_text` twice, can we avoid that? How about `lstrip`?
`is_a?` and `kind_of?` are aliases, yes.
I would be happy with any of those. I decided to nest errors inside of another controller partially to show that you can (too many people have way-too many top level controllers) and also to reduce the noise of top-level controllers by not adding in yet-another-to-level-controller. I would yield to this decision, with a preference towards `errors#not_found` if you prefer not to have this nested.
@steveklabnik I wrote this code but I think we don't need to call `to_sym` in the end of chain. Could you investigate?
@josevalim when I was working on this, I had the same feeling, then I remembered that... you'd only want to HTML escape an HTML template. So I think this is actually better than only not escaping text.
Separate `s.add_dependency` reads better and fits in with the others.
ooh! good catch!
If this is doing what I think it's doing, then god bless on this change.   Reflection docs were really tough to navigate before this.
You already have the nesting with the {} around the code, same depth with my proposed solution that doesn't have more than one terminating expression.
That's an important remark. Overall the example is good.
Extra whitespace here for no reason?
>
> I was under the impression that properties should be inexpensive. This
> check need not be.

OK, just checking.
Perhaps you meant to do something like this:

```
    try:
        r = gruntz(e, z, z0, dir)
        if r is S.NaN:
            raise PoleError()
    except (PoleError, ValueError):
        r = heuristics(e, z, z0, dir)
    return r

def heuristics(e, z, z0, dir):
    if z0 == oo:
        return limit(e.subs(z, 1/z), z, sympify(0), "+")
    if e.is_Mul:
        r = []
        for a in e.args:
            if not a.is_bounded:
                r.append(a.limit(z, z0, dir))
                if r[-1] in (S.Infinity, S.NegativeInfinity, S.NaN):
                    break
        else:
            if r:
                return Mul(*r)
        e = e.apart()
    if e.is_Add or e.is_Pow or e.is_Function:
        return e.func(*[limit(a, z, z0, dir) for a in e.args])
    msg = "Don't know how to calculate the limit(%s, %s, %s, dir=%s), sorry."
    raise PoleError(msg % (e, z, z0, dir))
```

Note:

```
>>> eq
x**16/(x**16 + 1)
>>> eq.apart()
1 - 1/(x**16 + 1)
>>> limit(_,x,oo)
1
```
why is there a semicolon added?
The notebooks should stay in version 2.
Oh, yes,
On Tue, Apr 10, 2012 at 1:41 PM, Tom Bachmann
<reply@reply.github.com>
wrote:
>
> To be honest I don't really know when to do something module-wide and when locally. It's not used anywhere else, so it seemed natural to import here.

According to

  http://wiki.python.org/moin/PythonSpeed/PerformanceTips#Import_Statement_Overhead

local imports can cause severe overhead, and I've heard that from
other sources as well.  However, I'm definitely not a Python expert to
give a solid comment myself.
What do you think about idea of separating 1024 (2^10) based sizes and 1000 (10^3) based sizes and their formatters? Right now you're using KibiBytes, MebiBytes and so forth, not KiloBytes, MegaBytes and so forth. (http://en.wikipedia.org/wiki/Kibibyte)
"this." is unecessary

```
AppBlade.endSession(getApplicationContext()); 

```
Also the readme must only link to appropriate sections into the wiki
Yea, i'd see we just extend the current annotation with a string value that identifies the bundle.
You can then use either bundeClass and id or just the value, other combinations need to be prevented by the PresenterInspector.

```java
 public @interface ProxyCodeSplitBundle {
	
     Class<? extends ProviderBundle> bundleClass();
  	
     int id();

    String value();
 }
```
Hi Chris and Soroush,

I may be interpreting this wrong but it looks like currently, the nodal element matrix only builds for the bifurcation nodes. Chris, it sounds to me like you are suggesting that this matrix should include all 1D nodes, rather than just the bifurcation ones. This makes intuitive sense to me and might make things a bit easier in terms on not having to keep track of which bifurcation you are on with bif_idx. Then all nodes would have at least two versions and Riemann variables describing the incoming and outgoing characteristics. Branching vessels would have additional versions and variables, but the number of branches could be arbitrary rather than a fixed 1-to-2 branch type if we are just looping over the versions to make sure quantities are conserved at each node.

Cheers,
David
Please add that the arity of the `StubFun` will be the arity of the expect function.
Seems that with utf8_decode, many encoding problems in tasks name disappear
Should the `superspaceCache` not get zero'ed out as well?
That was my initial understanding, but on re-reading the code there's
actually no mention of an oplog at all.  It takes oplog entries but applies
them against a collection, used to replay the oplog on shards or replica
sets.

ApplyOps itself is a wrapper around applyOperation_inlock.

On Tue, Jul 24, 2012 at 11:03 PM, Sam Kleinman <
reply@reply.github.com
> wrote:

> >
> >     :dbcommand:`applyOps` is an internal command that supports sharding
> > -   functionality.
> > +   functionality.  It applies a command object entry from an
> :term:`oplog` against a :term:`collection`.
>
> sorry, I didn't catch this earlier, but I think we can just say "It
> applies entries from an oplog," I'm not sure "a command object entry,"
> makes sense.
>
> If we want to be really extravagant, we could also say, "It applies oplog
> entries passed to the command in the ``<operations>`` array,  to a
> database, or collection if you specify the ``ns`` option."
>
> Correspondingly, we should probably change the "array of operations to
> perform," to "array of operations to apply."
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mongodb/docs/pull/86/files#r1232017
>



-- 

-ed costello
@epc <https://twitter.com/epc> / +19179752073
no. I think no usecase here is fine.
I don't think I understand what copy change you're asking for in this comment.
I guess then it would be worth adding a test for the name is nil case.
ОК, сейчас поменяю
It should always be a string. I think cullen initially casted it to string in order to make that it's actually a string.
Are these lines any more than whitespace changes? If they are, they should not be in this PR.
It would seem to me like this is a case of "specialisation" so the exact use case for inheritance?
okay.svgz
Probably need the regex(p) flag in a jslint directive if the test code is going to pass lint.
i didnt understand your comment..

if what you meant was to improve the spacing of the code, jsbeautify has done its magic now.
I don't mind making this private now - it used to be part of the public API (equivalent to load_raw), but now it can take a back seat.
Long line (and there are some others later in the file too.)
Doesn't this `else` mean that the method does not exist on the class?
Did you try that on a machine without nvcc? I'm afraid the script would crash.
check -> checks

behave -> behaves
Hi,

This pull request predates our discussions from the SoC checkins, I already
had moved away from this path. It was in a different location. Not in the
condition to post much, hospitalized right now. I'll see if I can continue
may be after a month, post recovery.

Rohan Jain



On Sun, Oct 14, 2012 at 4:14 AM, Luke Plant <notifications@github.com>wrote:

> In django/middleware/csrf.py:
>
> > +                    reason = REASON_BAD_ORIGIN % (origin)
> > +                    logger.warning('Forbidden (%s): %s',
> > +                                   reason, request.path,
> > +                        extra={
> > +                            'status_code': 403,
> > +                            'request': request,
> > +                        }
> > +                    )
> > +
> > +                    return self._reject(request, reason)
> > +            else:
> > +                # Do a strict referer check in case an origin check succeds.
> > +                # As far as CSRF is concerned, attackers who are in a position
> > +                # to perform CSRF attack are not in a position to fake referer
> > +                # headers.
> > +
>
> This is doing a strict referer check if there is no Origin header. That's
> going to cause lots of incorrect failures for the case where the browser is
> configured not to send a Referer header, or where the network strips the
> header. According to Barth et al. [1], not sending the Referer header is
> very rare for same-domain HTTPS (which is why we had it like that before),
> but not that rare for HTTP - probably because the network cannot strip the
> header for HTTPS, but can for HTTP. This could be anywhere between 0.5% -
> 7%.
>
> [1] http://seclab.stanford.edu/websec/csrf/csrf.pdf
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/django/django/pull/95/files#r1836517>.
>
>
My bad. I shouldn't make it in such a hurry.
The name "task_ordinal" can be misleading. 
Maybe result_group_ordinal or source_block_ordinal is a better name.
in cue_testfixture, there is a function called assertEquals that is used to test for specific errors, one overload allows you to specify the specific line number and column of the error
Yeah, this whole change is one indent to many.  I think we'll have to do this with the tool, then hand-fix things it gets wrong.  There's no perfect solution with automation.

Then we'll have to enforce it in reviews henceforth.
this could probably be an ASSERT_EQ? doesn't really matter I guess
Does this really need to parse 2 cues, though?
Ah, I see.  Makes sense.
Why isn't this just '>='?  Operator has more information in the optimizer than a raw function.
This was fixed when we removed this file from the pull request.
This will not work.

The iOS and Android builds #define both OPENGL and GLES....   you have to test GLES first then OPENGL.
First of all ``'uri' in query``, no need for ``keys()``. Secondly, why not just ``for uri in query.get(uri, [])``?
s/cheng/change/
Because we are talking about two different encodings here. The first is the source encoding, i.e. the encoding of the actual bytes that make up the file. This is what the magic comment and command-line switch address.

The second is the encoding used by the Regexp engine when compiling /^\037\213/, etc., which under 1.9 is utf-8. The warnings you see are generated after the source file is loaded.

IOW, the sequence "/^\037\213/" is perfectly valid utf-8 (obviously it's also valid ASCII). The file can thus be read as utf-8. But when those escapes are interpreted later, it generates the sequence 0x001F 0x008B, which is not a valid utf-8 sequence, and under 1.9 the regexp engine is not encoding agnostic and needs to be told to compile them without an encoding, e.g.

```
[irb(main)]$ /^\037\213/
SyntaxError: (irb):4: invalid multibyte escape: /^\037\213/
	from /usr/local/opt/ruby/bin/irb:12:in `<main>'
[irb(main)]$ /^\037\213/n
 ====> /^\037\213/n
```
The description should be a bit more generic for future usage.  "Do not prompt for interactive input or launch the setup wizard."
Nope -- they can't be passed in via command-line options because they're nested inside a resource dictionary and not in the top-level worker config.
$key kann weg, nur value wird benoetigt
Seems like this should be `/types/friends/all` - any reason for it to live in the root namespace?
This isn't being used anymore, is it?
Please call it `eltLose` or something such.
We should add some tests for nested stylesheets that themselves have `@import` statements.
A few more ideas for simple cases: html files, css shorthand notation, case sensitivity, missing percent sign in HSL.
I personally prefer to call the method without "on" since "on" indicates that the method is an event handler.
Sure, I can make that change.  Just thought I would make this "backwards compatible", but if it's only triggered from one place then it won't matter.
Need the comment describing this. Also, it looks like you're missing the `position` parameter.
This should be in the same packed config
Lets call about this.
trying to suppress KeyboardInterrupt didn't work unless its in main(). I feel its good to be able to interrupt the program via keyboard interrupt when running it in the foreground.
but if that's the case that means handlers are depending on other handlers in front of them to protect them from bad messages. as a general principle i think the handlers will be written to be as independent as possible, and reject (or not handle) messages that don't apply to them.

i don't think it's going to be sustainable to let any unhandled exception in any handler (note: even handlers that would not/should not "claim" the message) abort the rest of the processing chain. this scheme has worked for many years in rapidsms; is there a compelling argument to change it?
No. They were intended for future use, but i'll go ahead and remove them…

On Sep 13, 2012, at 3:02 PM, Cory Zue wrote:

> In corehq/apps/adm/models.py:
> 
> > +from couchdbkit.ext.django.schema import Document, StringProperty, ListProperty,\
> > +    DocumentSchema, BooleanProperty, DictProperty, IntegerProperty, DateTimeProperty
> > +import datetime
> > +import dateutil
> > +from django.utils.html import escape
> > +from django.utils.safestring import mark_safe
> > +import pytz
> > +from dimagi.utils.couch.database import get_db
> > +from dimagi.utils.data.editable_items import InterfaceEditableItemMixin
> > +from dimagi.utils.dates import DateSpan
> > +from dimagi.utils.modules import to_function
> > +from dimagi.utils.timezones import utils as tz_utils
> > +
> > +
> > +FORM_KEY_TYPES = (('user_id', 'form.meta.user_id'))
> > +CASE_KEY_TYPES = (('case_type', 'type'), ('project', 'domain'), ('user_id', 'user_id'))
> 
> are these two actually used anywhere?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Discussion in triage meeting: is NaN or NULL the more appropriate return value?
Yeah, you mean the whole file shouldn't be there, right? I think I
speculated that you were temporarily keeping it around for reference for a
little while longer, but if not, I'll just delete it.


On Fri, Nov 30, 2012 at 3:05 PM, François Terrier
<notifications@github.com>wrote:

> In grails-app/domain/org/chai/kevin/Initializer.groovy:
>
> > +import org.chai.kevin.survey.SurveyCheckboxOption
> > +import org.chai.kevin.survey.SurveyCheckboxQuestion
> > +import org.chai.kevin.survey.SurveyElement
> > +import org.chai.kevin.survey.SurveyProgram
> > +import org.chai.kevin.survey.SurveySection
> > +import org.chai.kevin.survey.SurveySimpleQuestion
> > +import org.chai.kevin.survey.SurveySkipRule
> > +import org.chai.kevin.survey.SurveyTableColumn
> > +import org.chai.kevin.survey.SurveyTableQuestion
> > +import org.chai.kevin.survey.SurveyTableRow
> > +import org.chai.kevin.util.JSONUtils
> > +import org.chai.kevin.value.RawDataElementValue
> > +import org.chai.kevin.value.Value
> > +
> > +public class Initializer {
> > +
>
> this class should not be there any more, I guess it was added by the merge
> or something
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/fterrier/kevin/pull/267/files#r2277618>.
>
>
You've used auto-format... and in the end, you introduce some code that is not formatted the same way than the one you changed. :-(
I don't see why this constructor is useful. It's the default one and is empty, it is still public... If you remove it from your code, it will still be accessible and will behave in the same way.
I did this for the sake of making it easier to read. Otherwise I'd be doing data.this.that.......
File a bug on this TODO so we don't lose it.  Put the bug # in the comment.
Hi!

On 08/10/2012 01:20 PM, Peter Waller wrote:
>> @@ -143,7 +143,21 @@ def render(self, canvas, keep_alive):
>>          names, histograms = zip(*self.resource_to_render.stack)
>>          #print "Rendering stack with {0} histograms".format(len(histograms))
>>          
>> +        names = [n for n in names]
>> +        histograms = [h for h in histograms]
> 
> What do these two lines achieve?

They turn the tuples into lists. I needed to do the conversion so that I
can append to the lists later.

names = list(names)
histograms = list(histograms)

would be smarter, indeed.
@kellyredding - "To define a callback, just define a method named after the callback." this is confusing to me, maybe "method named after the action" or something similar would be more clear?
这里似乎没改？
No need for this file to be changed as discussed on IM
because:
```
tito build --test --rpm
....
+ echo Generating API docs
Generating API docs
+ rm -f Gemfile.lock
+ cp Gemfile Gemfile.old
+ echo 'gem "redcarpet"'
+ rake apipie:static RAILS_ENV=apipie --trace
rake aborted!
https://github.com/ruport/ruport (at master) is not checked out. Please run `bundle install`
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/source.rb:572:in `rescue in load_spec_files'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/source.rb:570:in `load_spec_files'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/source.rb:385:in `local_specs'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/source.rb:555:in `specs'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/definition.rb:356:in `block in converge_locked_specs'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/definition.rb:345:in `each'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/definition.rb:345:in `converge_locked_specs'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/definition.rb:143:in `resolve'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/definition.rb:90:in `specs'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/definition.rb:135:in `specs_for'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/definition.rb:124:in `requested_specs'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/environment.rb:23:in `requested_specs'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler/runtime.rb:11:in `setup'
/usr/share/gems/gems/bundler-1.0.21/lib/bundler.rb:110:in `setup'
/tmp/tito-build/rpmbuild-katello-885ebf776fc81fc0900ee1641a9670b950f9a193fZrd1f/BUILD/katello-git-374.885ebf7/config/boot.rb:8:in `<top (required)>'
/usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
/usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
/tmp/tito-build/rpmbuild-katello-885ebf776fc81fc0900ee1641a9670b950f9a193fZrd1f/BUILD/katello-git-374.885ebf7/config/application.rb:1:in `<top (required)>'
/usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
/usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
/tmp/tito-build/rpmbuild-katello-885ebf776fc81fc0900ee1641a9670b950f9a193fZrd1f/BUILD/katello-git-374.885ebf7/Rakefile:4:in `<top (required)>'
/usr/share/gems/gems/rake-0.9.2.2/lib/rake/rake_module.rb:25:in `load'
/usr/share/gems/gems/rake-0.9.2.2/lib/rake/rake_module.rb:25:in `load_rakefile'
/usr/share/gems/gems/rake-0.9.2.2/lib/rake/application.rb:501:in `raw_load_rakefile'
/usr/share/gems/gems/rake-0.9.2.2/lib/rake/application.rb:82:in `block in load_rakefile'
/usr/share/gems/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
/usr/share/gems/gems/rake-0.9.2.2/lib/rake/application.rb:81:in `load_rakefile'
/usr/share/gems/gems/rake-0.9.2.2/lib/rake/application.rb:65:in `block in run'
/usr/share/gems/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
/usr/share/gems/gems/rake-0.9.2.2/lib/rake/application.rb:63:in `run'
/usr/bin/rake:32:in `<main>'
error: Bad exit status from /var/tmp/rpm-tmp.6fYaSZ (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.6fYaSZ (%build)

ERROR: Error running command
```
Are you sure CDN can return redirects? In any case, I am not going to fix this in this pull request, I am filing a new bug, because this particular bit (method get that is responsible for fetching) is both in disconnected script and in katello (slightly different version there). For obvious reasons (see the list) it would be better to fix this in a separate pull request: https://bugzilla.redhat.com/show_bug.cgi?id=860722
Updated to use the param variables
If the enumerator is created with an XDoc.Empty, start will be null.
Nits:
teplate -> template
the the -> the

Perhaps add an example in a new section below showing how you'd specify a plugin.
This class needs some serious comments.
fine -> find
这里是要 array_filter + array_reverse  么？
You're right, I think both should just log and unexpected case and not crash.
Yes but adding that doesn't fully define the behavior, which is why I asked. There are two possibilities:
 
1) If you use socks=4, a socks4 proxy is used for ipv4, and tor and ipv6 go directly, around the proxy
2) if you use socks=4, a socks4 proxy is used for ipv4, and tor and ipv6 are disabled (unless you specify a proxy for them manually)

I think (2) makes most sense. You don't expect connections to suddenly go around the proxy because you specified another socks version.
I think messagepage is still a better name for this. :p
Items aren't ordered but what we want to do is just to select the first tab, the real type isn't important.
Add a line break between attribution and asserting
this would allow a potential size of (1, -1) to pass through, which may or may not fail. Probably better to check width > 0 and height > 0...
ok, moved it to the mapper. feels right, as this *is* a storage related thing. the added benefit of this is that you could do any sort of cleanups about your class names there.
Yup, good catch.  Fixed locally, will push later today.  Thanks!
This could just be replaced with `list(map(glob.glob, args))` below.
uses logging now.
Yes, it works with 2.10
Nah, let's not hide this. Let's change the tests to actually use `GIT_REF_FORMAT_`
:purple_heart:
Since we now have more than one HAML template, it's probably a good time to create a layout for HAML files so we can eliminate the standard HTML boilerplate from our views.
This was taken from https://github.com/mozilla/bedrock/blob/dev/apps/mozorg/templates/mozorg/firefox/speed.html

The only reason it's inline is because of the {{ latest_version }} that's echoed into the JS from the django view, but we could probably define that as a global var inline that the external script could use. The rest of this could all be external (and originally was until I had to get the version number working).
I thought you were having troubles earlier with doing this when the client wasn't authenticated. Did you fix that some other way?
sorry, curly braces not semi-colons :)
not catching Exception.  Now catching Environment.DoesNotExist explicitly
No I was just curious of the reason. I was unsure whether it was a joke or not... :)
Ok. An invalid path is when that happens. Would an admin message and a redirect could be more informative for the user?
That loop iterates through the script in reverse, so it'll stop when it sees the final future statement and insert the activation line immediately after it.
$value is an array here.
you should add an empty line before the return statement, and update the phpdoc
You see a use case and I see another one.. So what do we do? I added it
as an option, because I see why it may not apply to eveyrone, and
because in dev I do want to see an exception, this stuff should be
fixed, there is no reason for it to be a valid behavior ever, but in
production such a mistake should just not destroy the whole page. Your
"use case" isn't a use case either, nobody should rely on this. It's
just a way to ensure higher availability of your site.
Done. This is an issue across all the current validators actually - I'll add another PR for that
I think it would be useful to show people in the profiler which deprecated methods they are using.
```php
if (!$showPrivate) {
    $definition = $this->resolveServiceDefinition($serviceId);
    if ($definition instanceof Definition && !$definition->isPublic()) {
        unset($serviceIds[$serviceId]);
        continue;
    }
}
```

?
Yeah, isn't it adding hard dependency on translator now ? What if I use only security but not translator component ?
True, I will remove the "global" options.
Are you thinking of `$headers`? `$headerNames` is a new variable.
at this point, you are *always* handling a subrequest. See line 162 :)
Setting script.type is unnecessary per HTML5.
whitespace

```scala
// Do ...
```
why `\` on end of line?
Does this have sufficient progress output to keep the capistrano connection open, or should we output the dots like we did for rvm?
Can you clarify the concern during deploy?

BTW - this is a temporary measure. Once we launch the Yam gem, everything after the comma goes away
I'm going to go with "or" because that is what we used in another project and it seems more coffee-scripty
ba chi code mizani ?
ina ye cntrl+shift+a too subline mikhan
做成参考文献的话，那些文档就会比较全面的介绍语法了而不是仅仅公式命令了。这一段先留着吧，等把具体的参考文献数据库弄好了再修改吧。
I didn't rewite your code - I simply overwrote it
I've just tried using `toArray` but that breaks the existing tests with:

    Object ember344 has no method 'toArray' - {}
`mouseUpDelegateBinding `
This line's got tabs. ;)
I added a function in appview that  renders the leftside corpus, leftside session leftside data lists, the datums container, a well as activity and unicode view. this function is currently getting called anytime the user hits the home button or any other time we call show dashboard, this might be render overkill. 

Ideally this should only render if the dashboard hasnt been rendered recently.
This is intentional.  There are overlapping IDs between org.jboss.as.clustering.impl.ClusteringImplMessages and org.jboss.as.clustering.infinispan.InfinispanLogger.  Some amount of message ID shuffling is necessary to fix this issue.
nit: too many extra lines isnt?
That's not a big deal but can we add this test over here ?
  https://github.com/fabi1cazenave/gaia/blob/9b06329a9c3973a24b1a2f3038767bc3ca5bdba1/build/webapp-zip.js#L159
So that `addToZip` is just a ZIP helper and doesn't contain gaia logic.

We might have to ignore this code as well:
https://github.com/fabi1cazenave/gaia/blob/9b06329a9c3973a24b1a2f3038767bc3ca5bdba1/build/webapp-zip.js#L237-L255
Do we still need to ship locales `.ini` files?
I will add tests for the details view, where that will be checked
Yeah, kind of, but we have to do an early stop if we don't find icons:

if(!app.manifest.icons) {
    return;
}

... 

//Iterate with foreach over entryPoints
(non-blocking, need UX confirm)

I would expect to see a Modal Dialog confirming the action before the phone restarts/turned off.

(BUT we are not supporting calling Modal Dialog within System app yet right?)
You were right, I was confused by the ! in the other line. Sorry about that! :)
Fixed. We are going to follow ITU-T standar. E.164 says that 'The minimum number length (excluding the country code) is 7 digits ...' so we are going to apply 'equals' on cases of operators, fixing this issue. (Thanks @dcoloma for the tip!)
Are you checked the framerate using a canvas with shadow? Probably it is the same but I want to ask for it, thanks
Do you need to escape HTML?
These three rules can be removed when #4972 lands.
same as 'self', we'll leave it to a separate refactor pull request
`array.forEach(callback, thisRef);`
I generally avoid `expect { ... }.to_not raise_error` because if an error is raised, the example will fail anyway, and w/ this expectation, it will swallow the original error backtrace and print it's own...which makes it hard to troubleshoot what the original unexpected error was.  This has been something I've been meaning to fix in rspec-expectations:

https://github.com/rspec/rspec-expectations/issues/59

...but for now, I would tend to do this:

``` ruby
list.assert_finished! # should not raise an error
```
> I know spork uses it but it'd be nice to document how to use it w/o spork.

Is there a common use case outside of tools like spork? I also am not too familiar with them beyond that, if so.
Let's revert this so that it stays as stefanvizzari in the repo (just so we don't keep changing the file...
das kommt weg wenn die clock in eigener Klasse steckt
What do you mean?  Can you be more precise?  What can go wrong is that you don't get map-side aggregation if you use this method, but often your ultimate logic could be implemented with reduce.
why did you comment that line out?
Use the more idiomatic way to open files (with) instead of this, to ensure that your file gets closed.
changed to PROFILE similar to elsewhere in the codebase
Use $form['#node']
I deduced it to be 416f77. The diff should be easier to review now.
Marijn had actually removed this "dir" attribute since his new undo code doesn't use it. I reinstated it because Josh's history fix needs it, but we'll need to discuss with Marijn if that's appropriate when we go to submit that change.
In general, I think that the new implementation of `rebuildBuild` is confusing and hard to follow.  I think it would be better implemented using `deferredGenerator` (or `inlineCallbacks` if you prefer), so that it reads more clearly.
some inconsistent tabbing here. (sorry - very minor)
GCC for 64-bit target defines va_list as an array so it can't be assigned directly. _va_copy_ is arch-independent way to copy va_lists in GCC.
How did you test *alignItemsInColumns*? Is lua able to generate C va_lists? I think there's no need in public va_list methods.
...
    if(CC_SWAP_INT32_LITTLE_TO_HOST(magicBytes) != 'ccbi') {
    ...

?

DOne.
Yes, please try to remove the global variable.
Should be `## post-checkout`
This changes the meaning of `this` inside the enter() method. Ditto for exit().
Needs to be pluggable and extensible. I have created an interface for completeness, and made the constructor protected again
Added method, initially I needed it, then I worked it around again. Could probably remove it unless you think it's harmless
the whitespace formatting looks different here than the original
That is an awful lot of path nodes, but nowhere near as many as before I tidied up the bottom.
so it should be reverted to `if @admin_project.save`
Was `cnet` causing you problems?
We used exact same shortcut in other places so I wanted to be consistent. I'm fine with `hasOwn` as well, but after all the mean exact same thing.
I fixed this, patches coming...

--lloyd


On Jul 10, 2012, at 10:45 AM, Shane Tomlinson<reply@reply.github.com> wrote:

>> +      return httputils.authRequired(res, "password required");
>> +    }
>> +
>> +    function postAuthentication() {
>> +      db.completeReverify(req.body.token, function(e, email, uid) {
>> +        if (e) {
>> +          logger.warn("couldn't complete email verification: " + e);
>> +          wsapi.databaseDown(res, e);
>> +        } else {
>> +          wsapi.authenticateSession(req.session, uid, 'password');
>> +          res.json({ success: true });
>> +        }
>> +      });
>> +    };
>> +  });
>> +};
> 
> @lloyd complete_reverify is never used since the add email and reverify email got collapsed into "confirm".  The confirm page calls /wsapi/complete_email_addition.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/browserid/pull/1913/files#r1133346