labofsahil/github-event-dataset-2012 huggingface dataset:
You can't add children to an `Object` like that anyway. Children are defined as a `tuple`. You must go through the formal methods to modify the children of an `Object`. This is the most robust way to handle dynamic children since large optimizations can be made with respect to when and how children change notifications are performed.
Unfortunately this beautiful syntax is not compatible with python 2.6. :(
```sh
$ python2.6 test.py
  File "test.py", line 1
    with open('a') as a, open('b') as b:
                       ^
SyntaxError: invalid syntax
```
I think I'm in the minority on this one, so I will concede if there is consensus against me.
did you erase this by mistake ?
yeah sorry this review was on android.  the best way to avoid NPEs here is to checkNull on the AssociatedWithNetwork ctor, so that you can guarantee networkid is not null.  then you can use the syntax I mentioned above concisely on one line based on that.
https://github.com/kaltura/mwEmbed/commit/df3a0a7886e0ad7617bb5d653085ae79edcf4719#L4R21
oh nvm, that was there before
Maybe sms/sent instead? There seems to be a lack of consistency in the surrounding URLs so I'm not sure if you want the trailing slash on firefox/sms/ or not.
how about a pipe sign  | ?
hm yeah that works. Though that's kind of pointless; it's easy to create the file later.
This is an excellent way to test this, I am jealous. :metal:
This is just a nicety so that you don't need Redis to run a reindexing. It was easy to add, but if it turns out that there's more work needed, then we should just nix the nicety figuring if someone is indexing, they should also have Redis.
generally I prefer tests that just test specific functionality.  Would you mind separating the get, post and delete to separate cases?  In this test, if the post fails, we'd never know if delete still works or not.  

Also, would you add a new test that uses the factory to create a suite, then posts 2 new suites and verifies that all 3 suites still exist.  (verify that adding new suites doesn't disturb existing suites).
then delete
"nose" instead of "node"?
since the manager holds a list of these thread objects and each thread object has a reference to the manager, should this be a `weakref`?  or does the referential loop really matter here?
This looks like repeated code. 
Why not just
```
self.conn = httplib.HTTPConnection(self.host, self.port, timeout=self.timeout)
```
and instead of making it default to 0 make it default to `None`.
Not a good comment.
Oh gross. Also, I just realised you used tabs for all of fov.js. *%s/  /\t/g/*
We need that
"overrides" is overrode somewhere else, I think when you click on graph details. Also it was used in the missing_method and maybe other people/patches expected it. Having a new attribute with defaults was harmless.
> тоді я відключених юзерів буду відписувати тут:
https://github.com/stfalcon/fwdays/pull/85/files#L6R49

я маю на увазі саме видалення
oops forget abpout this comment... the test is below.
in fact, it should have  a use statement (to be consistent with other phpdoc in Symfony)
please use camel cased names for the variables
we don't use these annotations in the Symfony source code AFAIK. Please remove them
Well, throwing an exception with more details than "zomg framework.charset is an unknown config value". I think giving clear error messages goes a long way to help people. Given the size of the user base and that it's most likely going to affect 99% of users (since the value was set in the default config), I think it's worth the 2 extra minutes doing it.
Two spaces here.
Yes, I've fixed that, thanks. I'll do another code push soon but I'm changing the code to avoid the IDs problem right now.
@dr-fozzy It works well in Opera. And bothering about IE < 8 is useless here: we are talking on styling a canvas element, and IE < 8 does not support canvas at all :)
We could add Util(s) at the end, e.g. StringUtil(s).

On Mon, Jul 9, 2012 at 12:23 PM, Jordi Boggiano <
reply@reply.github.com
> wrote:

> > + * This file is part of the Symfony package.
> > + *
> > + * (c) Fabien Potencier <fabien@symfony.com>
> > + *
> > + * For the full copyright and license information, please view the
> LICENSE
> > + * file that was distributed with this source code.
> > + */
> > +
> > +namespace Symfony\Component\Security\Core\Util;
> > +
> > +/**
> > + * String utility functions.
> > + *
> > + * @author Johannes M. Schmitt <schmittjoh@gmail.com>
> > + */
> > +final class String
>
> Agreed, the String name might be dangerous if it is turned into a
> reserved word at some point.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/symfony/symfony/pull/4763/files#r1121253
>
I was noticing in another branch that this class is essentially unused, even in unit tests. Until we decide to remove it we should probably not implement new features like diffState for it (aka, throw 'NotImplemented').
Is it? No, the name of the controller is in conflict with the name of model (they are the same). That;s why I added that.
This was updated. Comment didn't refresh for some reason.
And just for the record, the bang can mean one more thing. In plain old Ruby (minus all the frameworks) the bang indicates that the object being sent the message will be mutated.
Прикол использования модели dashboard в том чтобы не делать этого. А если кастомизировать урлы то можно все и в юзере хранить, не создавая дополнительной модели на бакенде
Agree... I'll fix this ASAP 



Le 12 avr. 2012 à 22:42, Jacques-Olivier Lachaud<reply@reply.github.com> a écrit :

>>     {
>> -      return 1.0/(mySigma* sqrt(2.0*M_PI))*
>> -    exp(  -aDisplacment.norm()*aDisplacment.norm()/(2.0*mySigma));
>> +      return 1.0/(mySigma* sqrt(2.0*M_PI))*exp(  -(double)aDisplacment*aDisplacment/(2.0*mySigma));
>>     } 
> 
> I suggest precomputing the "constant" 1/(sigma sqrt(2pi)) and 1/(2sigma) in the constructors.
> 
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/DGtal-team/DGtal/pull/315/files#r678735
>
> What to you think of having a parent concept "LocalDifferentialEstimator"
> (or something like that, with init() and eval())  with not connection with
> "SegmentComputer" ?
> This one would be a refinement focusing CSegment.
>
> For example, on can derive tangent estimator without using any model of
> CSegmentComputer.
>
>
I see. 'CSegmentComputer' should be a refinement of
'CLocalGeometricEstimator'.
Like models of CLocalGeometricEstimator:
- init ( h, itb, ite ) (since models of CSegmentComputer have begin/end
iterators)
- eval( it )
And in addition:
- attach( sc, b1, b2 )

By the way,   CSegmentComputerFunctor is too generic (any functor on
> SegmentComputer is not necessarily an estimator)
>
>
I agree that the name is too generic. What is your suggestion ?
Just a nitpick but can you space this out to `if status == Status.DOWN`. And the same for any others without spacing. Makes it more readable and consistent with the rest of the code.
unlimited isn't really true. maybe just say "multiple".
But this is just 4 object creations, how can that be failed? And only one ```should``` check.
Should it be rudder.batch.reports.logInterval ?
Added test to ensure single class is passed. Multiple classes gave false positive. 

e.g.
<div id="id" class="class class2"></div>
$("#id").hasClass("class class2") => false
this should be done by CommonAttributes.DEFAULT_DATASOURCE.validateAndSet(operation,model)
```ctx.printLine(line)``` should probably be used instead of ```System.out.println()```.
Rebase conflict + my bad resolving coused that :(

will fix it
It would make sense, given that we already bumb model & XSD version...
Current impl is the same as what we have in web subsystem as was desired behavior.
will fix it an push the change
I have to confess I don't know enough to be able to be certain by inspection alone, but it looks good to me!

Does your htonll function make all longs 4 bytes, if so then I will just merge it!

I couldn't follow when it said:

return (static_cast<ACE_UINT64>(low_part) << 32) | high_part;

I didn't know why it needed OR'ing with the high_part you see? That is not a criticism, I simply couldn't quite follow that bit of the logic.

Also, assuming it does take the lower 4 bytes, we probably need to know what ENDIAN the machine is to know which is the lower part and which is the higher part, or maybe I am wrong?
hm I'm a little bit confused why the viewport calculation will fail when you zoom in too much.
yes, of course it doesn't make sence to let the user zoom in/out without limit but the limits can be quite different. so there should be a posibility for the developer to define the limits (**setZoomLimit(min, max)**). This would be great. But it also should work with a unlimited zoom in.
This is incorrect. You might be searching in a different document.
используя RowMapper можно съэкономить несколько строчек
no need for 'owd'.
Don't get you. currentContact is going to be stored in Contacts API and is waiting for an array. That's the reason photo is an array. Did I answer your question? :S
We should probably add the `pick` case here and just make sure we display the contact list and not a previous contact detail.
nit: add an empty line here please
Yes, I need to receive the event when user toggle it.
It will driving the value.
Yeah don't really need all of these any more, I'll remove the success messages and just leave in the error messages.
do an early return


      if (!addDelay) {
        hideAlternatives();
        return;
      }
      
      clearTimeout(hideMenuTimeout);
      hideMenuTimeout = setTimeout(hideAlternatives,
                                                                 kHideAlternativesCharMenuTimeout);
`#screen > [data-z-index-level="homescreen"]` same below
Here we have a regression, now for example if you go to Facebook from Ev.me search, it's ok but after that, yo go to Twitter and when the wrapper tries to open Twitter the users can view Facebook for a few seconds :)
Warning, this HTML file does not pass the W3C validator. These two last `<meta>` elements aren’t valid, and there are a few other mistakes in the rest of the file.
I think this may be undesirable from a CSP lock-down perspective, although I'm not sure we have a formal policy on this for gaia.  Of course, my code has to pass gjslint now too, so I don't see why everyone else shouldn't also have to suffer! ;)
Sean's snippet did not work for me. Please suggest a better solution
Sure. Ill need to constrain iterables to be of the same size.
I'd do this instead:

    $usercategory = KunenaForumCategoryUserHelper::get($this->id, $user);
    return (bool) $usercategory->subscribed;
Yeah, s/warning/error/.  thanks.
Yes, judge return value is enough, this is replaced with cmd_status in v2.
The cnfProject == null I believe upon review is not required.
Ok, I'll add another test.
Is this going to provide a list or a string?
Better to make this a nested function in `start()`
Problem there is that what if 4 routes have the same name with different param hashes?
Thanks fixe, committed: https://github.com/RobLoach/composer/commit/4cfc9c0c081e58d3d5933b7253d6c58ef5dd6d1b
do you really need 2 different lists of archivers ? composer does not need it for downloaders and installers
you should not unset the property but only its value.
this is not equivalent to the previous code. You should reset the update whitelist to an empty array here, otherwise resetting it is not possible anymore
We need to ensure those are actual numbers.
Yes, typeof(params.width) === "number" is required but first we need to make sure the field is coming back as a number and not as a string.

Maybe we can do in this order:
1) check if it's a string and, if it is, try to read the number out of it => store in the same var
2) check if it's a number, and fail if not
The usage of PROGMEM increases by 20-30 bytes, usage of RAM reduces by 2 bytes. Both resources are limited. So how to set priority?
As I know jasmine also supports "jabber" protocol, why ICQ is hardcoded?
same comment about percpu.
Ok, though we are weaning ourselves from the Makefile and try not to add any new functionality there, using Python instead.  E.g. this won't work on Windows.
axis should always turn around the positive z-axis
No, os.path.splitext always returns a pair (root, ext). See: http://docs.python.org/2/library/os.path.html
I think this should change to take a pointer (or maybe a reference for syntax convenience -- can those be safely cast back to C pointers?) to a user-allocated callback. That would enable use of the `exti_attach_callback()` function I proposed above.
Could `cache_ref_data` return the same data that it caches? This would avoid an extra cache roundtrip, and the zlib decompression overhead, in the nothing-cached-yet case.
So how is it handled if a client is walking through the indexes but e.g. the memory reporter is pushing other values in the buffer? The index referenced by the client would be invalid because it has been moved one item back. Shouldn't we better use an enumerator to retrieve entries from the buffer? We should really bound the entries to a specific state of the buffer.
Oh. And if you open the sprint story management page and know there there are some in the ready backlog that have the sprint marked in the WB, you can just shift refresh and they'll move in via magic :boom:
This reads a little awkward -- seems like except and non-framework are forming a double negative.
Guess not, because if the function was set through the javascript options object, the function wouldn't be a property of the window.
consider changing the name to "OneShardReader" for clarity and not causing confusion with the "ShardsReader" class you have below
perhaps add a newline at EOF :)
This has changed and now you can set your own placeholder (whose default is still __index__, but the variable is called $templatePlaceholder)
I think people are putting Exception interface inside the Zend\Escaper\Exception namespace now.
I can remove these
Again, no globals, don't care whatever else you do.  Please no globals.
ummm, it's a constant, every time a new Villager is created `getVillagerTypeId()` will always return 5...
I would prefer it if the element the plugin selected was the container. So `this` instead of `this.parent()`.
remove these, we only support IE9+
just a naming question: is association about any field, or only about associations with other documents? is `isCollectionValuedAssociation` the right name or should we call this isCollectionValuedField? i see that afterwards we check if this is "assoc" and otherwise its a multivalue field.
? true : false bu kisimlar fazla olmus
use parenthesis instead of line continuation
Needs extra empty line in front of this one.
docstring makes no sense, `pass` should be used
break the loop!
Start header with '##'
Why are you removing this and the other tests? The idea is to give a starting point for ideas for things they can test
What's the conclusion here? Once we resolve this, I will merge.
Do you know what the browser support for hasOwnProperty is? I think it's pretty good, but I want to make sure it works in all modern browsers.
OK I remembered what happens here.  There's a bug in Firefox if the last argument passed to texImage2D is 0 (and not null).  I've fixed that on master now.
spaces would greatly improve readability of this line.
I assume this has or will get merged into something with explicit fields, right?
I'm a little nervous to rely solely on the error message here, unless we're certain that all error responses have sensible messages. I'd either like to beef up the testing around that, or add some sort of "We've encountered the following problem:" text to preface `error.message`. At least that way if it's blank or undecipherable, it's not just totally empty.
The best way to do this is

    file.tags[self.__r_text_tags[name]] = "; ".join(values)
Yeah but our code don't support this since you set `is_ready` to `true` unconditionally. In this case, you can simply declare the source infallible..
Before core install_nrpe(args)
I have no idea what this method does, what does origin mean here?
wouldnt get resource raise before the last raise in this line ?
This will probably have some negative effects for existing users. I can of course test this myself, but just wondering whether this will only change new configurations that get loaded or will it also alter defaults when the user hasn't provided an override? If it's the latter then I'm hesitant about this.
Can we simplify to:

    typeof registerClickHandler !== 'undefined' && registerClickHandler()
It seems the refresh rate change is not always initiated by the render manager. However Recover() is always called after the refresh change. So I just hooked up the delay code here. This is also called after XBMC init, so delay is always inited before the first video is played.
Unit tests for lost lock due to lost network. Does it work? Unit test for lost lock due to lost ZooKeeper?
Why are there two files? Does this file get placed into the 'RAR' file and the next file (`modeshape-jca/src/main/resources/META-INF/ironjacamar.xml`) get added to the JAR?
Explica isso aí Ruan :) Qual o motivo ?
Typo in the first line : rewritted -> rewritten
In the second line : That's -> This will
It makes very little difference, perf-wise: http://jsperf.com/var-in-for

It does save a few bytes in the minified version, though:

4f5421e:

    -rw-r--r--   1 parasyte  staff   57800 Nov 12 22:22 cp.min.js

5a303db:

    -rw-r--r--   1 parasyte  staff   57718 Nov 12 22:24 cp.min.js
@aboudreault, @msmitherdc could you please review this and below at line 2282 ?
hm, why is there an empty div after div.caret? Or should that one be closing as well?
You are right!

replaced with cURL
Use global gitignore for this please. https://help.github.com/articles/ignoring-files
regarding: "Don't think so, imagine the delete() fails for some reason we would kill kill the update column for no reason" -- This would be fixable with proper transaction handling.
forgot to finish your comment here
The JSDocs should be configured appropriately
Perhaps some basic tests for the new validator functions could be added as well?
renaming this to ``preExit``
True. And, admittedly, I'm no longer sure if failing gracefully adds value. So, you can disregard the [below comment](https://github.com/scala-ide/scala-ide/pull/128/files#r1017193).
лінки
Formatting, slap!
Als je de character extend dan is dit niet nodig aangezien dit al in de character staat
Начальный уровень для Objective-C - это C/C++, так как Objective-C - это надмножество языка C++. 

Можете пройти по этой [ссылке](http://unclemif.com/public/objective-c-frame.html), где разбирается Objective-C, так же советую книжку "Objective-C. Программирование для iOS и Mac OS" Аарона Хиллегаса (по это книжке, в частности, ведёт курс Рахим @freetonik
нет метода init
по отступам должна быть понятна вложенность, поправь плиз
These methods should be defined where they are used (in the exports of the object). Only functions that are private and shared should be defined like this.
Please format this, and the other `if/else` blocks as so:

``` javascript
    if (window.Firebug === undefined) {
        window.console = infomaniac.getMainWindow().Firebug.Console;
    } else {
        window.console = window.Firebug.Console;
    }
```
For scripts that are a single trigger, with the help command being enough to explain it, I almost think Description isn't really necessary. It's just copy-pasta, that doesn't add anything compared to the usage.
Shouldn't the Marshal.load be loading into output_settings?
为什么叫range**s**? 干嘛不直接叫range
I would call it concatenate_raws to be more explicit.
Parameters :)
missing doc for returned params
epochs.event_id no s
> Yes, data can be an "n_epochs x n_signals x n_times" array or a list/generator with "n_signals x n_times" arrays (e.g. Epochs) or a list/generator of SourceEstimate.

ok good.

> I can add averaging over frequencies in each band. One problem is that it is possible that the "accumulator" function doesn't return an "n_pairs x n_freqs, .." array in which case averaging won't work. But I can check for this and throw and exception if necessary.

let's see first how all this works out but let's keep this in mind.
I think you miss if (containsName) break; here.
Actually i think that this should be changed as 'should not fail validation if drug is null and drugorder concept is set' as expected by the ticket. Therefore i added the new test to meet that.
You know this is true at this point
that._hInterval = setInterval(that.heartbeat.bind(that), that.heartBeatInterval);
the list of node types should be sent to the 2.0 branch first (with only scalar, boolean, array and variable), then updated in the 2.1 branch (adding enum with a ``.. versionadded:: 2.1`` note) and then again in master (adding integer and float with a ``.. versionadded:: 2.2`` note)
typo "including *a* the doctype"
Preferably use `-fPIC` instead of `-mimpure-text`. The latter is a linker hack that makes position-dependent code work in a shared object.
This for loop is unpythonic. Why not the following
    for var in wrt
        deriv = self.diff(var).simplify()

and then delete the wrt.pop() stuff at the end
Make it private for now. If users request for it to be in API, we can turn it into protected later.
Tiene sentido, el tema es que actualmente van a tener siempre el mismo valor, ¿no?
If you look at the rest of ui_tasks, this function doesn't fit.  

First of all, there's a typo (new-limt vs new-limit, so it can't possibly work right).  Second, whenever we make a function to edit something, we do it all in one function.  So the signature will look something like this

(defn edit-systemgroup [sg-name {:keys [new-limit new-sg-name description}] ... ) 

I'm going to try to merge all this in with the necessary changes.
Fix indent please
With the 13 -- it's really 13 turns in a single match... If you want to do 13 matches, that's fine too.

Also: Try to not use for loops in ruby. If you want to loop over something and get the index, you can do this:

```
collection.each_with_index do |item, index|
end
```
please fix import order
Really? I have heard that the one widely adopted and with a good compatibility backward status is 3.2 / 2.7... The more the better, but I wouldn't put 3.1 a priority, and in fact I would focus on 3.3.
@meshy I see an issue with this. The dispatch method will always return self.prepare() and will never call the correct dispatch methods (ie: get(), post(), etc.).

This method can be cleaned up quite a bit. You could define prepare() as prepare(request, *args, **kwargs) and just return super(PrepareMixin, self).dispatch(request, *args, **kwargs).

Your dispatch method could (ideally) be shortened to two lines.
no harm in full shoulda I suppose, it gives us the matchers too, but not much more weight.  Now I just have to resist rewriting the entire test suite in RSpec.
Space VI: Return of the Space
What I meant was to use cookies for browsers where you don't have `sessionStorage` (or similar technologies). I let you decide if it it worth it at all (as I don't now which browsers actually provide this) :)
Tässä `concat` ja `map` funktiot yhdistävä `mapcat` on kätevä:
~~~clojure
(defn un-frequencies [a-map]
  (mapcat (fn [[what times]] (repeat times what)) a-map))
~~~
damn, forgot to remove ;)
And a reply back...
PEP8 says: "When using a hanging indent the following considerations should be applied; there should be no arguments on the first line and further indentation should be used to clearly distinguish itself as a continuation line."  While I guess it shouldn't be required here, I just simply put myself in the habit of using two tabs in such cases.
> also, does the axes.texts list need to be cleared?

Ignore that, the docstring below explains.
My bad. See #1605.
Presumably this is going to have a global effect, which isn't that desirable. I don't really have a workaround for this, its merely an observation.
This test needs to `switch_to_frame()` at the point otherwise the `disable_cell_data()` will fail trying to run from inside the browser tab. Previously the `kill` switch to the top frame .

The setup of the following will also fail because the `unlock()` method assumes it is already at the top level frame.
use dataExtent variable here instead
When dealing with this many if-else statements, a `switch` case statement is more efficient.  Convert this to `switch`.
For 1, yes. For 0, there's now a precondition checking that both timeseries have more than zero elements. See c493953
I'm not sure if I that'll work. AFAIK "0" is the default value for padding, and it seems any padding value specified will override the cellspacing attribute for the table cell.
What is a type 0? What is a type 1? If I wasn't looking at this specific piece of code, I would have no idea what a "1" is.
Right after that it also says:
```
If hKey specifies HKEY_PERFORMANCE_DATA and the lpData buffer is not large enough to contain all of the returned data, RegQueryValueEx returns ERROR_MORE_DATA and the value returned through the lpcbData parameter is undefined. This is because the size of the performance data can change from one call to the next. In this case, you must increase the buffer size and call RegQueryValueEx again passing the updated buffer size in the lpcbData parameter. Repeat this until the function succeeds. You need to maintain a separate variable to keep track of the buffer size, because the value returned by lpcbData is unpredictable.
```
``UsableInterface``?
from here it can probably be just

return localPackage ?? remotePackage;
Are you sure ``$this->store->lock($req)`` has the correct type as ``boolean|string`` is not a sub-type of ``boolean``?
typo: insteda ==> instead
:bowtie: exakt genau eben das
It's just a poor way of saying 'add this node to an index', or 'index this node'. `seraph.node.index
> ... enlive?!

nope, there's no enlive in prod
changes end here for Swipe.js

notice I kept an event.direction.toString method trying to keep compatibility with older string values
Pq vc ta deletando documentacao?
Related, `fs.exists` is a new API introduced in node 0.8.x, which unfortunately would break any 0.6.x based install. Can you, at the top of the file, do something like:

```js
// other dependencies, next to the list of requires
var exists = fs.exists || path.exists;
```

and then use this `exists` reference instead?
This can backfire if the value returned by `first` is for example `nil` for which `(pred nil)` still returns `true`. This is easily fixed:
~~~clojure
(pred (first (filter pred a-seq)))
~~~
@eddieajau - 

That brings up a question I have. JError is deprecated 12.1 

https://github.com/joomla/joomla-platform/blob/staging/libraries/legacy/error/error.php#L32

Doesn't that mean (I am not certain) that we take out all JError code at that time?
Can you please rename the methods createHook, deleteHook, getHook, testHook and editHook to create, delete, get, test and edit?
investigated this, it's not safe to just integrate the element style inside `getComputedStyle`. Several tests break on different browsers so it seems it is like that for a reason. Removing the element.style querying altogether is neither an option, once again several tests break. Keeping in line with the comment I left on #2417 I think this part of the code should stay with the same logic flow unless we get way more specs to cover all bases.
do you need the explicit copy here?
We need to update this to use the "Deactivate your account" section of /user/account , but that may be outside the scope of this commit.
I like returns in exit points because they glow bright red in my editor. can drop for superagent.
I would have whole form in here. For example, check [how it is done in nodewatcher](https://github.com/wlanslovenija/nodewatcher/blob/master/nodewatcher/frontend/templates/form.html) (the structure is a bit different, but you can get the idea).

Support for fieldsets we do not yet do, I recommend we add support for it to our forms. (There is a [mixin in nodewatcher](https://github.com/wlanslovenija/nodewatcher/blob/master/nodewatcher/frontend/account/metaforms.py#L141) code for that. (This could be done to django-missing, probably.))

Then I think that for `next`, we have named context processor variable `redirect_to`, in above code it is `context_processor_next`, I would in fact rename it to `request_get_next`.

You can then do something [like this](https://github.com/wlanslovenija/nodewatcher/blob/master/nodewatcher/frontend/templates/registration/registration_form.html). (So, using `{% with %}` template tag, be careful, in nodewatcher's there is old syntax.)
Inside get_context function? So I check for every station nearby, if it's fetched time is older than 1 or 10 minutes, save it's station_id into two seperate lists (one for 1 minute error, and one for 10 minutes error), and then use these lists in panel.html  to properly show info?
(In short, `()` + arguments to constructor are missing there in fields definition.)

Again, I am not writing code for you. I just show you ideas. You should understand what code is doing and finish things.
is this one needed? <code>confirmation_token</code>
 It is in user object isn't it?
You didn't have to configure database to sqlite?
pas de tests unitaires sur cette classe.
this should be `{{ invitee.email }}`. it probably happens to work because the `__str__` method for InviteProfiles is just the email.
More Pythonic way would be `if name not in self._retries` or using `defaultdict`
Maybe we should define an interface for this?
Zweidimesionale noch schneller! (oder auch nicht ;))
6ebc991
```ruby
@ invoices.select(&: sent?)
```
Nice, lovely cake ツ
IMO subselect in SELECT clause could break here.
Please use parentheses in the method signature
This could just be `sendResponse(true)` but it doesn't really matter.
if we are going to be adding new classes.. let's stop using the _ suffix. It's a bit of an eyesore.
А для чего вы в каждом файле пишете свое имя? Регалии автора как правило пишутся в setup.py "author" и "author_email".
Если перенести этот except, например, после всех if/elif — ничего лишнего в лог печататься не будет.
this should be `-rf` to remove the directory too
Possible to avoid the double class selector?
It's more flexible when it comes to resizing, and we use that in many other places. Maybe it also solves the searching issues, when the match would be in the shortened part?
Space after `min_width:`
If this commented-out code is a simple port from the apache equivalent it would be better to leave it out and just put a pointer to the apache code along with a TODO and explanation.
Why this change? You setting the default save path for both display and user data. However, we never use the user data AFAIK.
It's a tiny thing, but could you change this path from `css/` to `styles/`? That's more consistent with the rest of the styling.
на мой взгляд, влазит в экран, если можно взглядом охватить лямбда-функцию и быстро понять что делается, лучше писать в одну, тем более там и так такая простыня кода
This and later lines could benefit from a typedef.
```
typedef typename Image<T>::Iter ImIter
for(ImIter it = data.rowBegin(y); it != data.rowEnd(y); ++it) { ...
```
My usual rule for this is that if the for() statement seems like it should be broken up into multiple lines for clarity, there it would probably be even more clear if you introduce a typedef or something similar to abbreviate the code.
Maybe also mention the galsim_yaml executable.  So something like "[ if using the galsim_yaml executable or otherwise plan to parse .yaml configuration files ]"
Because NumberedFile can be used with other things than just the output FITS file.  It can be used for the directory (see below where we use default ext=None for dir), an input catalog, etc.  So it seemed easier to have the default be None. 

But it would also make sense to have a different default extension for different usages.  e.g. for FITS file_name, it becomes '.fits'.  For a InputCatalog, it becomes '.asc' or maybe '.cat'.  For a directory, we leave the default as ''.  Is that worth doing?  Or would that be more confusing?
> "but without ellipticity" intended here?

yes. thank you.
else 和if不在一行 不会出问题？
Yeah, I prefer the previous implementation, due to that behavior... would rather get non-padded number back rather than truncated number... Agreed we should probably land this util somewhere better, but not in scope of this PR I would think
Or remove?
If keeping, then include some more context in the log message?
This seems a strange method to have in a builder.
I'd have expected to instead call `build(mystring).tokenizeAll()`, or something like that.
close your scopes!
Yep, there is it. You could create something like `$mainForegroundColor` or so.

Furthermore, to remove the `!important` will be a win.
yeah, yeah, old habits
crie o ```request.booleanParam()```
This is for the mobile site, though.  Perhaps a wrapper method that doesn't do the logging if you are in prod.  A simple PSU::isDev() check to set a JS var should do the trick.  We shouldn't be dumping to the console in production.
Can you merge this line into "local rsc" declaration ?
What is meant to happen here?
So again, this is just an additional option/command for building the WRT only, i.e., skipping install path creation, `node-gyp configure` and `node-gyp build`. Example scenario: You've changed something in the WRT and don't require `node-gyp` commands to be executed again (because nothing changed there).

Habib: If you cannot sleep with this, we can leave it out (though I will still use something similar locally :P). In that case, just close this.
Hrm, I would prefer if this were a boolean — making it a number is simple but surprising. Along the same lines, I think that it should be named `inverted` (agree that `inversion: -1` makes sense, but `inversion:  true` doesn’t).
(first (rseq ...)) is plenty clear.
Two things:
1- timezone can be None so need to check for that.
2- We have users without a profile, so you should wrap in `try:...except Profile.DoesNotExist:...`
Here you're using variables that you deleted just before. You need to change ``$p``, ``$v`` and ``$pg``.
@henrikbjorn what do you mean ?
you should pass the loader to the method instead of creating a new one
btw.... this is JUST a temp. holder.....
закрывать надо в finally
copy-paste в том, что одна и та же функция в двух проектах?
Т.е. при любых ошибках мы пользователю ничего не скажем?
I think it would still be useful for Windows Azure instances deployed with the same topology as the Windows Azure US. For example, Windows Azure Japan.
Make this a list, like the other caveat defs.
there is somebody around here that likes having that line there =)
i personally don't care that much
この文章は前のコマンドに対する説明と思います。

```
@SimpleController@という名前のクラスに対応する全てのテストが実行されます。さらに、ワイルドカードを利用することもできます:
```

とかが良いでしょうか。
OK.  I'll get rid of all auto release stuff for member vars.
Yes. I built it in an Ubuntu 11.04 VM, and was able to run it up, connect to the backend, retrieve the EPG etc. I'll check it again tomorrow incase the changes in the last few days have broken things. What exactly is wrong with the above?
Наверное `call`?
We can't rewrite history :-)  Let's leave the release notes as a record.
I prefer to have docstring that have oneliner + details:

```python
    def _char_nospace_ngrams(self, text_document):
        """Whitespace sensitive char-n-gram tokenization.

        Tokenize text_document into a sequence of character n-grams
        excluding any whitespace (operating only inside word boundaries).
        """
```
I believe SGD is returning `[n_samples, n_classes]` in all cases now.
I think this could be implemented more easily by using "sort" or "argsort".
Could you maybe add another, more basic example in the doctest style used elsewhere?
Should fit_path be true by default? (that's a real question: I don't know the answer).
The issue is that this attribute only applies to `_RidgeGCV` not the general `RidgeCV`(only when `cv=None`).
how does that work? Write a wrapper function for f that does the check and then applies f?
Если ты посмотришь ТЗ на этот модуль, там в пункте 1 ровно то, о чем я говорю:



Эта библиотека будет отвечать за работу с API Uploadcare. 

> В ней должны быть функции (методы?), позволяющие:
> сделать произвольный запрос к API Uploadcare, как здесь:
> https://staging0.uploadcare.com/documentation/quick_start.html
> параметры: verb (GET, POST, PUT, DELETE...), path, опционально data

Есть ли у тебя веские причины не делать этого?
Ah, I see. I didn't think about writing, just about editing and showing it to the user.
it would make more sense to call it 'xsd' ;-)
Same comment as w/ ISOLATION above.
Removed the parameter - it provided some generalisation but the code was not set up to use it. I have also adjusted the call from MapActivity.
brilliant, I was always thinking on fixing it in scripts/functions/logging while this is the right place

how about:

    { [[ "${TERM:-dumb}" != "dumb" ]] && builtin command -v tput >/dev/null ; } || exit
Add this error message to message strings
Removed the code as it was all rather unnecessary. Types need to match and this is checked elsewhere.
This method is not currently used, but maybe useful in the future to determine the number of events in the event queue.  Currently, all events are flushed.
Why keep this line?
wu->resetWorkflow() is called on line 218 right above this, but based on a flag that may not be set often enough.  I'll look into when/why.
I believe that these were the root cause of a valgrind error report, yes.
I get a link error if you remove the entire function.
я вже казав, що фікстури не мають відношення до behat. це просто фікстури. і юзати їх можна як в behat, так і в phpunit
Ah, I see. Instead of setting it to 0.0.1, then, why not simply return then and there, with either an error message or an "it's not available"?
YAGNI can only be used with an assumption, that `Stdlib` serves **only** the framework's internal needs, not userland code. I disagree on such assumption. The associative/non-associative checks are useful in different contexts and if we agreed to have an `ArrayTools` class, we should make it symetrical (hence isList, isHash, has/hasNon etc.) and covering popular array checks. Actually, there's only a few of those. 

Please see: https://github.com/zendframework/zf2/pull/882#issuecomment-4329815
Same as https://github.com/zendframework/zf2/pull/786/files#r471240
remove all the gratuitous line spacing.
@yuhunglin can we change this to the following:

```javascript
$(window).trigger('loaded.widgets.calcentral');
```
That way it won't be bound only to the `.cc-container` and we'll avoid collision with other events (namespacing)
Why not required?
Why no index? Prevents searching, right?
This shouldn't use a callback.
just use ```self._host```
this file is missing.
I'm a bit concerned about it never matching any search containing a space; that seems unexpected.
```safe_words``` are not actually safe.  Confusing varname.
Yeh, it was when i was experimenting with binary payloads, to separate out the uploading of libraries (so) and executables (bin) - did not work out.  command injection was easier & more reliable.

I'll scrap it together with the postgres_write_data_to_disk_elf
It's already in master.  @pjcozzi will have to fill in more details if appropriate because I don't actually know what that 1.5 means.
I know I'm nitpicking about variable names, but this isn't a direction. In the plane equation ax + by + cz + d = 0, this is the constant d. @pjcozzi started a plane class in the polygonidl branch if you want to add it (not necessarily as part of this pull request).
Now that you mention it, I'm not sure what I would normally name this kind of pattern (basically, public function that does initial work and then calls a private recursive function).  Maybe "Helper"?  combine and combineHelper?  

In any event, Matt is right that you should move it outside of combine, and pass through the deep and allowDuplicates parameters.
Thanks for that, I had not noticed!
what happens if focusable is null. The default should be true.
Works for me!  I won't even start on `uri` vs. `url`! ;)
We just need a 'good' way to handle module names with more than one `/` in them.

The `loaded_modules` function is mainly used to print stuff, it has little functional value.

Remember, these are modules external to EasyBuild for now, so we don't care that much.

When EasyBuild has support for generating module names like `name/arch/version/suffix` or something, then this will need to be cleaned up thoroughly.
same as the last two comments.
Format the SQL statement so it remains readable. See: https://www.plymouth.edu/webapp/mis/wiki/PL/SQL_Formatting_Conventions
That was the intent, yes.
Btw you can have just one function to do all that for all `process***` functions here, like
So I maybe should have put a comment in about this, but here is the BIG idea:

1. We define a utility for each student of sqrt( #hours interested classes received + 1.5*# hours priority classes). This is basically just trying to measure how much each student likes their schedule.
2. We also define a weight for each student of sqrt( # classes regged for). This measures how much we care what the student thinks (we give less shits about students that don't try to select lots of options in the lottery).
3. we compute the weighted sum of utilities divided by the sum of the weights to get an overall average utility.

@jmoldow Yes, I have a wrong comment. I can try and fix once I figure out how to edit git commits. I think that # of classes for the weight is actually about as good as # of class-hours, so I'm not really sure which will get us a better result (and they are super correlated anyways). 

Also, someone should be sure to actually run this code because I don't have a dev server set up (derp), so it hasnt been tested.
Ups... Mein Fehler

Wir sollten hier sogar eher die Methode 
public function activate($acode){
  if($this->acode == $acode){
    $this->setActive();
    $this->resetAcode();
  }
}


Ich werde das beim Annehmen des PR gleich noch korrigieren... um uns eine Iteration zu sparen!!
Préférer la documentation par `/**` quand les informations pourraient être incluses dans une doc externe. Les commentaires `//` sont à n'utiliser que pour les infos niveau programmeur, i.e. quand on a les “mains dans le cambouis”.

(c'est pas juste pour l'idée, c'est parce que la doc est réellement générée à partir des blocs `/**` et rien d'autre)
here and below should be single quotes
Can use the `.toggle()` strategy here as outlined below to reduce 4 lines to 1.
Thanks for the find. Good spot.
@elemoine: Ok, done!
Fixed with commit 780d93c. Also added some basic junit tests.
in /etc/httpd/conf.d/ we have
```
 ls /etc/httpd/conf.d/
charset
mod_jk.conf
security
status.conf
```
and "Include /etc/httpd/conf.d/" in /etc/httpd/conf/httpd.conf

we will have to rename all configs that do not have ".conf" 
charset ->charset.conf
security -> security.conf

and change Include /etc/httpd/conf.d/ -> Include /etc/httpd/conf.d/*.conf

this changes will affect all templates that use web_apache
maybe it is better to fill ticket and create story for the next sprint?
can you compute the hash in the DI Extension ?
Indentation seems odd here.
we also need to `cmd_start` before running the integration tests
We don't need this right?
Can you add a new line after the closing `}` makes it more readable.
While you are at it: `(list([list(x) for x in consumption]), list([list(x) for x in production]))` is where `production` comes from (some lines above this) and it looks like there are two `list()` calls that are not needed.
You convinced me.  No OptIn to the subscription class.  I do think this should be strongly typed with something.
can you move that back to example.org?
idem phrase suivante :  "pendant que certains se font plaisir" plutot "qu'il y en a"
I agree, I will add a link to the facebook group here. Do you think we also want a link to our contact form? Better not to add the link to make it a more community-based, decentralised app?
I thought that was how localization was done, but figured now that {{status}} isn't necessary. I will remove them. But then what the original <div>{{status}}</div> was doing?
This `log` should show the `amount` is been stored
URI does not help here:

    iex> URI.parse("/?search=hello&find=chuck%20norris")
    {URI.Info,nil,nil,nil,"/",nil,"search=hello&find=chuck%20norris",nil,nil,nil}
I think we should remove the fl-theme scoping since it forces people using the video player to use this theme on their page. I feel that the video player should have default themeing on it without a scoping class.
I can't speak for the `chmod`, but the `pear config-set ...` is now a part of the install process. See line 202 of the current PHP formula.
Any idea or reference on what the "crammer_singer" scheme is good / better at?
maybe we should default to GET
e.g. options.type || "GET"
this way we don't need to pass it every time we make a call to makeRequest
I actually removed this timeout because it's redundant; the timeout is set in the request initializer above.  They both point at the same value, so I wasn't sure why the second setting was in there in the first place.
Btw, I don't think that _NoopInterceptor_ means that indexing work should be skipped. IMO interception is always orthogonal to the actual process executed. A _NoopInterceptor_ tells me "Ok, an interceptor is used which does nothing, hence the default indexing flow will occur. It's a no operation interception"
parseInt this since we want the number of bytes as a Number?  (Or if not parseInt, comment.)
Secons on IOS
le tree ne devrait-il pas être plutôt sur la branche gh-pages ?
Can you put this in a `try…finally`? I'd like the sync to continue if something screws up consuming the entity.
Why not yet? File is committed and is correct
phpBB hook is called by ```$template->display``` or ```$template->assign_display```
When we call in our hook ```$phpbb_hook->remove_hook``` than is **not** the hook called by the next  ```$template->display``` or ```$template->assign_display```
So we added ```$socialnet->useTemplateHook``` to call whole hook only once. Than we no longer need the phpbb hook removing.
Its invoked from constructor and a major and it complains with a Major violation saying, constructor calls an overirdable method
nope. "We should do a session.keepSource = true; before we parse."
Lets verify this in the future. Im not sure we need this.
Place this file inside the data directory. Then, this line is redundant.
@tohman  - I thought you were changing this to a new method instead of polluting the trigger method?
Sorry unsure of exactly what you are asking here. Can you please clarify?
change 'getEntity' to 'getJSONObject'