labofsahil/github-event-dataset-2012 huggingface dataset:
Multi currency bulk import fix

Hi Kevin,

Think this should resolve the second issue in #12. There were some describes inside a loop.

James

Move field describes out of loops and use
UserInfo.isMultiCurrencyOrganization() for proper detection of
multicurrency environments.

Also bulk test method attached below but not commited
```
static testMethod void multipleRDBulkInsert(){
//created to test github issue 12, second reported issue - bulk inserts

integer NB_Records = 200;

RecurringDonations_TEST.setRecurringDonationsSettingsForTest(
new Recurring_Donations_Settings__c(
Opportunity_Forecast_Months__c = 12,
Maximum_Donations__c = 50,
Open_Opportunity_Behavior__c =
RecurringDonations.RecurringDonationCloseOptions.Mark_Opportunities_Closed_Lost.name()

));

delete [select id from Custom_Field_Mapping__c];
Custom_Field_Mapping__c cfm1 = new Custom_Field_Mapping__c(
Recurring_Donation_Field__c = 'Name',
Opportunity_Field__c = 'Description',
Name = 'CFMName00001-Test'
);
insert cfm1;

Account a = new Account();
a.Name = 'test Individual';
insert a;

Contact c = new Contact();
c.FirstName = 'test';
c.LastName = 'contact';
c.AccountId = a.Id;
insert c;

list<Recurring_Donation__c> rdlist = new list<Recurring_Donation__c>();

for(integer i=0; i< NB_Records;i++)
{
Recurring_Donation__c r1 = new Recurring_Donation__c();
r1.Name = 'test';
r1.Installments__c = 2;
r1.Contact__c = c.Id;
r1.Amount__c = 100;
r1.Installment_Period__c =
System.Label.RecurringDonationInstallmentPeriodMonthly;
r1.Date_Established__c = system.today();//date.newinstance(1970,6,12);
r1.Schedule_Type__c = System.Label.RecurringDonationMultiplyValue;
r1.Open_Ended_Status__c = System.label.RecurringDonationOpenStatus;
r1.Next_Payment_Date__c = system.today();
rdlist.add(r1);
}

Test.startTest();
insert rdlist;
Test.stopTest();

set<Id> rdIds = new set<Id>();
for(Recurring_Donation__c r : rdlist)
{
rdIds.add(r.Id);
}

map<id, Opportunity> originalOpps = new map<id, Opportunity>([select id,
Name,amount,accountid,CloseDate from Opportunity where
Recurring_Donation__r.id IN :rdIds]);
system.assertEquals(12*NB_Records, originalOpps.size());
}
```
This seems a bit off... care to comment

This seems a bit... off.  Please add any comments that you see fit.
Add support for specifying ORM event listeners in the application.ini
Set DYNAMIC_SHARED_LIBV8SO to 'false'

Fixes build error as a result of commit 8e8c150 on android_external_v8
INT-2465 Fix Temporary File Suffix

<file:outbound-channel-adapter/> temporary suffix (.writing) was
overwritten to null by the factory bean if no suffix provided.
Do you have Flash? Really?
Acl user management

Changes:

- split user form in editable roles and readonly roles
- implement custom voter to deny access for __normal users__ to __super-admin__ users
Catch all errors during file upload

Place holder for #7 for when it gets sorted out.
githubified the readme

I extended the `README.md` and used Markdown to make it appear rendered here on GitHub.
Node version bump

I just successfully ran this tutorial with node 0.6.11 and formidable 1.0.9, so I've bumped the versions in the text.

I also updated the translated versions, though I'm not certain the code in there is the same as in the English version, so the examples may not work...
Deployment docs improvements. Fix for Capistrano deprecation warnings

```ruby
task :after_update_code, :roles => [:app] do 	
  symlink_sphinx_indexes
  thinking_sphinx.configure
  thinking_sphinx.start
end
```

This old way of defining callbacks in Capistrano is deprecated, so I changed it to `before 'deploy:update_code', 'thinking_sphinx:stop'` declaration.

I also mentioned `whenever` gem which can help to control cron tasks.
Added a GetScalar overload for using Sql.Max
cleaner code

cleaner code, + The showing controls method now is based on other method, to make all faster.
Introduced @WidgetGroup annotation for modeler. Refactored some basic code in step-editor to integrate ProcessToolContext.
Feature to ignore building certain native extensions

Added a feature to not build certain native extensions. Edit native-ignore.js and add the name of the extension to the array of the target you would like to ignore.

I also added build output to inform that the extension is currently being skipped.
Add some fields onto the JobSearchResult: HostSite and ONetFriendlyTitle

Also added WhereSiteEntity() on the JobSearch.
createrQueryBuilder -> createQueryBuilder

the syntax are wrong
PLFM-1409: Fix getAllVersions service

Reorganized the commits a bit and cleaned up the history.
Added pt_BR translation

Translation for brazilian portuguese (pt_BR)
prevent Safari from launching when Quicksilver launches

That’s the main issue. There are some small clean-ups in here as well.

Note that there are still tests for `[Safari isRunning]` in some places. The mere existence of the SafariApplication object tells us that Safari was running at some point during the life of Quicksilver. It doesn’t mean it’s still running now, so we need to test before trying to use it.
Mounts removed signal
orthogonalize MIPS version identifiers

The old identifiers suffered from combinatorial explosion. The new ones are closely modeled after gcc options and predefines and are thus less cumbersome to work with when porting headers.

<table>
<tr><th>gdc options</th><th>version identifiers</th></tr>
<tr><td>-mabi=32</td><td>MIPS,MIPS32,MIPS_O32,MIPS_SoftFloat</td></tr>
<tr><td>-mabi=64 -mhard-float</td><td>MIPS,MIPS64,MIPS_N64,MIPS_HardFloat</td></tr>
<tr><td>-mabi=eabi -mgp64 -mno-abicalls</td><td>MIPS,MIPS64,MIPS_EABI,MIPS_SoftFloat</td></tr>
</table>
Zmieniony file_one

Dodana zawartosc do file_one
Support for file attachments

Ryan and/or Matt, could you please review my work on supporting file attachments in collective.salesforce.content?
A couple of small fixes to do with content being rewritten

 ... using HTMLValue->getContent strips all html info from data
now you have to go merge this lol

This is a too much work for a text file. We need some internal wikis for WBF site anyway, I'd say move it there eventually.

But this is a good project to front page and draw user engagement
Windows and Warning Fixes
It's because of post requests in tests, e.g. https://github.com/rails/rails/blob/master/railties/test/application/configuration_test.rb#L281
you could check it into a branch and post that. That is how I am working on Tag. later, when working, you can merge your branch into the master (or branch) you are using.
好吧，你随意...
Why do you free `tmp` while changing `p`? If this is correct, then the code should be fixed to be readable.
thanks.
does "dialog" work for gnome3?
This was intentional (the \a tags `token` in the doxygen comments).
OTOH it looks like you're missing the validate call, which means this is open to anyone to invoke (!!!)
Yay, this is awesome! :+1:
Implementation inspired by (2 process per entity): [gaisler](www.gaisler.com/doc/vhdl2proc.pdf)
TODO: dedicated comb part to be merged into comb process
I will think about this message id problem. I wanted to correct this in the next release version, but I see it has to be done now :D
Woudn't this also compress `src/jquery.scalable.ready.js` though?

I only want `src/jquery.scalable.js` and `src/jquery.scalable.auto.js` to be compressed.

I suppose I could make a `min/` folder as you suggest and then copy the two production minified files into the root of the repo, but I'd rather only minify the files that need minifying. Perhaps this can be done with a variable? Would the % stem notation be usable with a variable?
Why does this fail (I see it doesn't work in master either, just curious.)?
А зачем это нужно?
where do I find where websql is stored on the db? it doesn't seem to be in the default application directory

Thanks!
This should say `The Object we want to convert to an integer`? And the same with the float one, c+p can be a bitch :-P
The CommonJS spec reserves the fourth argument for a progress handler. However, I’ve been toying with the idea of adding .annotation or .progress functions to promise chains. Perhaps this could be sugar for passing an annotation as a fifth argument.

```javascript
promise.note = function (note) {
    return when(this, null, null, null, note);
}
```
Great test case!
Please give unit-test for new feature if possible.
I'm going to roll back the line continuation stuff entirely.
This change would break 2.x support. Can you come with a way to avoid it ?
It would be nice to use QUrl methods instead of strings, e.g. url.scheme().  I haven't checked if QUrl has the right methods, but it would be nice to use them, if possible.
marking arrows - i will use green fill
layouting - we have made a deal about using leftw and rightw instead of invisible node. and it seems to be good to have sets separated.
code reusing - i was thinking about it and came to result that it is more clear when each method is separated
a son of a root, disabling button - yes that will be done
我去查一下……然后好好改一遍先
I'll need to think about this some more. But since ``localhost`` is external whereas 127.0.0.1 is just your loopback device, I'm leaning on your side.
Can we bring the quotes up to the previous line here and below? PEP 257
我不清楚ie现在对html5的支持如何，老师们应该都是ie并且很有可能是老版本的

发自我的 iPhone

在 2012-3-8，1:42，董劭田 DONG Shaotian<reply@reply.github.com> 写道：

> @Asyfupid 这里需要后台传一个评论人的id，这样回复传给后台的时候知道是在向谁回复。 data-xx-xx 是html5的新功能。
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/PKUIRSA/pkuzone/commit/092d779796b16a6f9d55abfd1b4b1c384d8e6432#commitcomment-1054696
http://pastebin.com/zMKsBSVU
@Maibenrai, only manual work, I don't use any progs
ho my god , or . ^^
I don't quite understand what's special about xor:

```
julia> x=int8(-2);y=x>>7;

julia> int8(x+y)$y
2

julia> (x+y)$int(y)
2
```

Could you give an example?
Not sure if this bit is needed, given GetRootDirectory above?  Locks are set only on root sources.
We would need either a different file altogether for cpuflags_multi_host, or find a way to pass parameters to the server control file. The way it is in the current version of this patchset, one would use the migration_multi_host control file and will get the cpuflags test executed. I'd just clone the migration control file and add a very similar one for the cpuflags test, at least on this current iteration.
Updated server from mr1511 to this rev, began to crash in Stratholme.
https://gist.github.com/1594582
Scripts for stratholme are standard SD2 (as in R2). On mr1511 everything was okay.
I think thats related to CPU cost:
with 50: Every 50 milliseconds we calculation the distance to target, and maybe a calculate of new path with mmaps to target
with 100: only half calculation CPU cost
I think every 100 milliseconds one calculation is enough.
Aha, so it is a constructor!
Oups, conflit de merge!
ConcurrentHashMap could be better to avoid too much synchronization ?
That's high praise! Hope I'm not violating published style guidelines... ;)


On Mar 5, 2012, at 12:48 PM, Jon Peirce wrote:

> Looks nice. I've only gone through the gist, not the detail, but I like the structure (e.g. putting it into misc as a private method was a good plan).
> 
> And you used a decorator! I've still never actually bothered to use on in earnest, so that might be the first one in the project! Actually I have used `@class_method` but that barely counts. ;-)
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/kastman/psychopy/commit/3765fbe89468ffa0116598ae67575d5e8af21e5e#commitcomment-1044095
This change is broken in a couple ways. Non-flipbook movies aren't required to be exported, so movie.symbol will be null in that case. References to movies in the XFL are by their library item name, not their symbol, so this lookup will fail if those are different. 

XflLibrary should probably explicitly distinguish between library item lookup and symbol lookup to make this clearer.
getEchoInput.. but meh.
C'est pas sérieux ça!
Sounds reasonable to me too, and as long as it's aliased, it allows both crowds to use it without having to think too much about it.
Any problem using the more generic vm.copy_files_to?
You could use implicit line continuation here
Yes, this would be the best way.
Great ! Working as expected ;)
не знаю почему так написано в книге, но достаточно просто добавить ошибку (errors.add(:base, 'Line Items present')) и все. Не надо возвращать true/false, тем самым тело метода сократиться с 6 строчек до одного:
errors.add(:base, 'Line Items present') unless line_items.count.zero?
merged a simpler&&older version by rumpletux recently.
yep I'm not a C guy... :)

thanks for the tip I'll fix it
,   ,    

2012/2/10 Vitaly Puzrin <
reply@reply.github.com
>

> file seems to be missed
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/shmelev/fontomas/commit/d815ddc460752bebdd9a03684eac5657398280ea#commitcomment-954189
>



-- 
Best regards,
roman.i.shmelev@gmail.com
We need to change versions in almost all sample poms. This is a bad thing. we need to think about some parent pom where we can set the versions. We may also just import the dependencies of our project pom into he samples. Let's discuss this in the chat next week.
feel like this should caps, but w/e
For now the comment in the testsuite is clear enough.

But now that I think about it, maybe I should introduce a hidden flag that signals whether we should call the free or not and use the same behavior as numpy for OWNDATA.

When we will have some official documentation, (which I will probably have to write), I'll put in a section about API differences and it will be there.
If you want to link to the index page, you can link to '/' which is the root path.  For example, when you see http://google.com/  the trailing slash means the root path of google's web server.
Change the default for new files, to be like this
/**
 * @author Marvin B. Lillehaug <lillehau@underdusken.no>
 */
Have you had any luck getting fibers working?  

https://github.com/laverdet/node-fibers/issues/48#issuecomment-3542996
@lloyd - no, addressCache is initialized as soon as the file is run and never deleted.  There is a re-initialization in resetCaches, but that is only used in testing.
I'm all for defining some protocols for working with buffers, samples, wavetables, etc. This would mean redefining our with-meta/map types using defrecord or deftype in order to make use of them. One nice things that falls out of this is the ability to implement `.invoke` on any of them to make them callable. What did you have in mind?
yep et ça rempli nos boites mail aussi ^^
Sry, I meant Firebreath uses ATL ( http://en.wikipedia.org/wiki/Active_Template_Library ), which is visual studio only. This is mostly needed for Internet Explorer's ActiveX support.

Firebreath is a browser plugin framework, which is used by webember. http://www.firebreath.org
Just upgraded from EventStore 2.0 to 3.0 and these static members messed up my acceptance / integration tests :(

Disposing of an InMemoryPersistenceEngine keeps data around. 

Any chance these changes can be reverted?
Ah, ok. Epic Fail von mir ...

Commit kommt gleich :)
Oops, I found the wrong line!  I figured that someone had just patched it
in the interim.

That was why I had updated the user guide in my pull request...

I was documenting the ability to pass a second parameter.  I remember now.
 Ho hum.

On Friday, January 13, 2012, Andrey Andreev <
reply@reply.github.com>
wrote:
> @brodkin This particular line checks the result of a method declared
inside the `CI_Form_validation` class. Native PHP functions are run at line
586 (not visible in this diff as it wasn't written by me) and the docs say
that any of them will work as long as they accept use with only 1 parameter.
> It would indeed be very nice to handle more than one though - I'll try
and implement that. :)
>
> ---
> Reply to this email directly or view it on GitHub:
>
https://github.com/narfbg/CodeIgniter/commit/901573ce19e905ce28a3f3345c33dedf9c703cd4#commitcomment-865591
>

-- 
Ryan Brodkin
Managing Partner/Web Guru
+1.877.620.4522 x101

G LAB Studios
Creative Marketing and Design Firm
glabstudios.com | +1.877.620.4522
If there is code out there that calls `exports.plugin` directly before initializing lumbar then they should be able to access the plugin via the name that they provided. On the topic of naming plugins, I am fine if the plugins define their own name like the modes if they are singletons, but the constructor format that is used here makes me nervious going down that route as multiple instances of the same plugin could cause different behaviors for for the same given name.
That's a little harsh dontcha think?
Surely, just 'options[o]'
The fixed formula for pgplot was committed under 762dc0bece87f69827afb53b4ee4c67406fc7501. PNG works fine, but GIF does not, which also happens with the macports port. Should I delete the pull request and request another one?
o_q
Sure. How does $world get set for the other use of it then?
oh.. ehm..
This is not correct, as this needs to work with RunningMode.ADMIN_ONLY.  if (!context.getProcessType().isServer()) is what's needed.
Heya

ok startuo very good
only 3 errors i hopeu can help me

2012-02-12 19:06:14 Loading C++ scripts
2012-02-12 19:06:14 ERROR: Script named 'spell_gen_tournament_duel' does not have a script name assigned in database.
2012-02-12 19:06:14 ERROR: Script named 'npc_frostwing_vrykul' does not have a script name assigned in database.
2012-02-12 19:06:14 ERROR: Script named 'npc_tournament_training_dummy' does not have a script name assigned in database.
2012-02-12 19:06:14 >> Loaded 2046 C++ scripts in 97 ms
Hi!
these are  error logs from function getDateFromString.

If you look  @ code, if this function return nil, Vienna use an "alternative" method for parsing (look @ line 491 - 495 on XMLParser.m):

	NSCalendarDate * curlDate = [self getDateFromString:dateString];
	if (curlDate != nil)
		return curlDate;

	// Otherwise do it ourselves.

I think we need to rewrite the father function: 

+(NSCalendarDate *)parseXMLDate:(NSString *)dateString

to be more robust.

I'll try extensively the parser to test the strenght.

Salvatore
don't want to bork input
jajaja Github no tiene narices de mostrar los 7393 + 7889 cambios del fichero en español ! :)
Thanks.. good catch :)
Please ignore this, the indentations are f*cked
is it just me.. im still getting this error..
Defo working here - what version of WordPress, and do you have any javascript errors in the console?
Hi Gary,

I saw your screencast on vim file management, where you talked about automatically setting the window height. Any reason you decided to turn it off?
Insert articles with current timestamp instead of the one exported from my database
Ah! You're right! The original code reads thusly: 

                if(v instanceof APersistentVector.SubVector)
                        {
                        APersistentVector.SubVector sv = (APersistentVector.SubVector) v;
                        start += sv.start;
                        end += sv.start;
                        v = sv.v;
                        }

So yeah, sv should be just v
Why not use DoRespawnGameObject(m_uiSaurfangCache, 7*DAY); ?

In your code the chest won't be respawned because you still need the pChest->Refresh().

Anyway, good job with this script. :)
Hi Pavelbrych, you're commit on en_US
Unfortunally the performance drops by ~ 20 % with these changes...
it's done. I made another variable.
I think decorators would be nice here too, but is there a nice way to write one that will work for both sets and commits and without doing the get_object twice?
This breaks the build!
If you would have checked the video at the time i provided you'd see that i'm not talking bout chanelled spells but manaburn in this case, which is a "direct damage" spell and therefore this commit is not blizzlike
At summon an eye falls on a platform and only it is possible it is then risen and to fly
Escaped file names.
Perhaps if you reply via e-mail, it only goes in e-mail to the other people in the conversation, but not onto the website?  Weird.

Can I put in my vote for 5*19?  19 is really a sad and neglected prime number.  ;)

And now for the serious response: Thanks for taking care of that.  The column width is one thing I was thinking of; what about spacing/indents?  

- Rachel

On Feb 28, 2012, at 8:29 PM, rmjarvis wrote:

> Barney, I got 3 code comments in email from you, but I don't see them on the GitHub website.  Hmmm...
> 
> Anyway, my edit was to correct one thing that had 80 and another that had 110.  So I figured I'd do 96 for you.  But 100 is fine too.  I didn't do 2*3*17.  :)
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/commit/129154fb487ffc3a6b3a1471dc60c1635652056a#commitcomment-1023944


-------------------------------

Rachel Mandelbaum
http://www.astro.princeton.edu/~rmandelb
rmandelb@astro.princeton.edu
this breaks sound effects..
Cool optimization.
It's a noble cause but the phrase "red cross" as it relates to disaster relief is trademarked in the United States by the American National Red Cross.
use vim in git bash?
extra whitepace after tab on this line and next
merge both sets of changes back to the main line
rough way to add this. maybe just remove those lines :P
Maybe it should be changed to 'alias' or a local variable introduced with a name that clarifies that this is what it is since it is not obvious as it stands.
Yep, didn't realize this was on a branch. +1

`git push origin :BRANCHNAME`

then

`git branch -d LOCALBRANCHNAME`
it is not important, here is parameters https://github.com/mmxtrem/lge-kernel-msm7x27/blob/android-msm-2.6.35/arch/arm/mach-msm/lge/board-thunderg-misc.c
@normann Actually, I misunderstood your implementation of removeComponent(), as its not actually removing by type, rather than by instance.
So, given that, I don't think we need removeComponentByType (singular) in addition to the existing removeComponentsByType() (plural). All good, no further work needed - sorry for the confusion.
It builds just fine on my machine and on the ci server. Something with your environment is wrong. http://hudson.josefson.org/job/maven-android-plugin-samples-master/
oops.  Should be ${1:-1}
Good start. Feel free to merge it back in to your existing clients branch, and we can iterate there. Or keep them separate; I don't mind :)
О, а кстати, прикольно, спасибо.
Is this event really necessary? Can you do here (and in `canEdit`) anything you can't do in the `didInit` event?
Replacing a non-detached element will place it in the DOM Limbo.
I wish Github had a Like button...
I tested this, it has the same problem as when i tried to fix it.
First, sic 'em rank 2 doesn't proc off.
Second problem, sic 'em rank 1, gives the pet every basic attack to cost reduced focus for entire aura duration.

i managed to get sic 'em rank 2 proc off, but it requires to write code in the core, this is what i've done so far:
unit.cpp
         // Sic 'Em Rank 1
            if (dummySpell->Id == 53340)
            {
                triggered_spell_id = 83359;
                target = this;
                break;
            }
         // Sic 'Em Rank 2
            if (dummySpell->Id == 83356)
            {
                triggered_spell_id = 89388;
                target = this;
                break;
            }

this way sic 'em rank 2 procs off too, but it has the same problem as rank 1, the focus cost is reduced by 100% not just for 1 attack, but for every basic attack until the aura duration is off.

This was one of the fixes i was about to post, but it wasn't complete.

what you think?
Je le précise avant que tu testes : J'aurais du mettre un wip ici, il y'a deux cas à distinguer : 

 1) Le site parent a déjà une balise <link> ( css) dans son <head> , et dans ce cas il faut insérer notre css avant sa première balise <link> pour éviter d'overrider son bootstrap.css.
 2/ Le site parent n'a pas de balise <link> , ( comme sur votrequestion.com ) et il faut prévoir le fallback car son browser retournera une DOM exception.
I'm not sure, but I think to remove bias from the result, one should subtract 1 from the number of items in the array before dividing by the sum of deviations.
removing the sanitize config.gem breaks this extension. You are still requiring it in the helper and radiant rc4 is not including the sanitize gem by default.
Perhaps, I'd better to find some styles from theme. The themes must have a reasonable reason to know how to indicate good/wrong.
I'm unsure about this, but just to confirm with you guys...

For a common use case, I think for `public_ip_address` we must get the last entry for `addresses['internet']`. This is since, I assume, if ever in a private cloud we want to expose an IP, these would be the floating IPs. This is given that in my environment, `addresses['internet']` is an aggregate of all the addresses associated to the server.
Prefere `snprintf` over `sprintf`, or even better `std::string`.
Yeah, now that you mention it 4 and 5 could be combined also. Fewer numbered steps makes the process seem easier.
It's a bit messy but I didn't find any better solution so far. You have :
service.name = oauth.clientId
servce.description = oauth.secret
service.theme = oauth.displayName

I just added the last one for the confirmation screen. So I kept previous ones "as is" for some backward compatibility.
Moreover, I don't think that there is really better mapping.
According to the Javadocs for getSubjectAlternativeNames(), the value can be a byte array in some cases.
Agreed, but I want to avoid an overcomplex pull request trying to do everything in just one step. So I plan to clean properties in a third pull request, with the re-arrangement of the JSP pages and the cleaning of CSS / JS / images.
no, it's the same for all, but that is a possible improvement, as mentioned in the comments about DataStream
Yeah, I'll just add a boolean which will be protected by the lock, and when it's tru it'll just insert system messages after the last system message in the queue.
good catch, the negative check was not done for double, that is important because loadAverage might return that on windows
I'll add test and fix it.
reduce is sort of an implementation detail, can't we just rename it to "getHighestPriorityMembers"?
Yes, please
The purpose of the marker traits is to be able to subscribe to more than one subclass, e.g. MemberEvent

17 sep 2012 kl. 16:53 skrev Helena Edelson <notifications@github.com>:

> In akka-cluster/src/main/scala/akka/cluster/ClusterEvent.scala:
> 
> > @@ -89,6 +89,16 @@ object ClusterEvent {
> >    }
> >  
> >    /**
> > +   * Marker interface for cluster metric related events.
> > +   */
> > +  sealed trait MetricsEvent extends ClusterDomainEvent
> Ok. I thought it was best to use it for >=1. Shall I remove it?
> 
> —
> Reply to this email directly or view it on GitHub.
>
sprinkle "override"
As mentioned in the ab2006 review, please do not use \ for line continuation, as this has the potential to cause subtle bugs in these arithmetic expressions. (Use () instead.)
Hmm, the main thing I don't like about this change is the fact that we are explicitly importing gsim modules here... when we added more, this yet another "registry" we need to maintain.

I think there's a better way, and it would be implemented in the oq-engine.

Factor out the logic from this method: https://github.com/gem/oq-engine/blob/cb9750c0aaa7441e7c934cbbe36ea81e3e6eba26/openquake/input/logictree.py#L916

and create utility function to get the gsim class by it's full path (e.g. `nhlib.gsim.chiou_youngs_2008.ChiouYoungs2008`). The function would look something like this:

<pre>
def get_gmpe_class(gmpe):
    if not '.' in gmpe:
        raise RuntimeError('gmpe name must be fully-qualified import path')

    module, classname = gmpe.rsplit('.', 1)
    try:
        module = __import__(module, fromlist=[classname])
    except ImportError as exc:
        raise ImportError('could not import module %r: %s' % (module, exc))

    if not hasattr(module, classname):
        raise ImportError('module %r does not contain name %r'
                          % (module.__name__, classname))

    gmpe_class = getattr(module, classname)
    if not issubclass(gmpe_class, self.BASE_GMPE):
        raise RuntimeError('%r is not a gmpe class' % gmpe_class)

    return gmpe_class                                                      
</pre>

For the scenario calculator, you'll need to instantiate the GMPE anyway, so this will get you the correct class.
hmm, I like the fact that the filters remain so that they can be used elsewhere. It feelst o me that there is a logical bug here and that we should actually create a data_dict for solr even if it ends up being almost identical to the data_dict that this function receives.

In my mind the logic functions shouldn't be so tightly wedded to the implementation details.  The fact that solr does the work is not relevant to the logic function.
The output during the demo was really confusing. The way render_document was handling it, it was hard to see which repo the action list belonged to. But I do like the idea of stuffing the info into the consumer and letting the normal rendering take over.

I don't think we need to list all of the actions. What I care about as a user is what the last one executed will be and what it's status is. So if I have 3 bind calls on the repo and 1 unbind afterwards, all I care about is that the unbind is pending. When the dust settles, that's the one that wins. Maybe we can consolidate this into a single status of the binding for that repo and not overwhelm the user with lists of binds and unbinds.
Yes. The other function is there. Let's not spread it out.
On Jun 17, 2012 11:47 AM, "arnova" <
reply@reply.github.com>
wrote:

> > @@ -718,3 +721,17 @@ void CURL::Encode(CStdString& strURLData)
> >    }
> >    strURLData = strResult;
> >  }
> > +
> > +bool CURL::UsesEncoding(const CStdString& strPath)
> > +{
> > +  CStdString strPath2(strPath);
> > +
> > +  if (URIUtils::IsStack(strPath))
> > +    strPath2 = XFILE::CStackDirectory::GetFirstStackedFile(strPath);
> > +
> > +  CURL url(strPath2);
> > +
> > +  // For now assume only (quasi) http internet streams use URL encoding
> > +  return url.GetTranslatedProtocol() == "http"  ||
> > +         url.GetTranslatedProtocol() == "https";
> > +}
>
> @elupus: Did you also meant moving the function from the CURL class to
> URIUtils? This doesn't makes sense IMO since the Encode/Decode functions is
> what this going to be used with mainly, which live in CURL:: space
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/xbmc/xbmc/pull/1064/files#r998363
>
=> стабулируй пробелами в массиве, в ряд.
compareWithElementAtPos(val, t, pos) ?
Correct me if I'm wrong, but AFAIK SSL evolved into TLS, so it's
basically the same thing.
@fabpot  Is this right? Where the ```$namespace``` variable is defined?
These were all public to facilitate ease of customising the UI… this change seems to make that needlessly difficult (like AppKit).
this was done because i expect many calls to this function and i wanted to have the if to the debug code branch  as early as possible... but i will think of it.
The default works, but the other implicits aren't used since the types passed are erased. I'll change it to ask for key and value classes.
Should extend SimpleUpstreamChannelHandler
Why free on direct buffer ?
Why split this over two sections? Would be better to copy the new content below to this location (or the other way around).
@nikic Apologies: that should have been `onload`, of course.
@TazeTSchnitzel I guess you also write `window.alert()` and `window.document.getElementById()`?
I think this would be better as follows:

```
min_percent_identity = self.Params['Min percent identity']
if min_percent_identity < 1.0:
    min_percent_identity *= 100.0 
```

as this would allow us to handle the percent either way the user provides it.
Oops, RubyMine autoformat
You need to pass a block, otherwise `assert_no_queries` doesn't do anything. In any case, you don't need `assert_no_queries` since we are already checking `assert_queries` at the top.
It's possible to just set `@errors = nil`, and avoid the variable.
we can remove this `to enable it` in the end of sentence
Missing 2 spaces of indentation here. Put a blank line after the `Example:`
I don't think we need this string interpolation here.

```erb
<%= route[:name] %>
<span class='helper'>_path</span>
```
I just reviewed all methods like `order`, `where`, `join`, and all of them just update `relation` object. So all magic happens inside build_arel(agruments parsing, etc).

So the easiest way is to raise `ArgumentError` inside `build_order` or even `create_order_node ` method(where i build `Arel::Nodes::Ordering` object)
Let's just say that all things being equal it's more likely to be a bad idea than a good one. There's little justification possible here because you control all the types. It is a lot more believable when interoperating with something which is not in your control.
Should the last one be an `IllegalArgumentException`?
Personally I would leave those as `${null}` etc. People might be surprised by the absence of `$this`, but not the others.
I don't know whether heuristic comparison will work once we have adaptive sampling because it is randomized.
you can catch both exceptions with "except (TypeError, AttributeError):" ... at least, I'm pretty sure this works in Python 2.5, check it please :)
On 12.06.2012 13:28, Sergiu Ivanov wrote:
>> +
>> +    @property
>> +    def components(self):
>> +        """
>> +        Returns the components of this morphisms.
>> +
>> +        Examples
>> +        ========
>> +
>> +>>>  from sympy.categories import Object, Morphism
>> +>>>  A = Object("A")
>> +>>>  B = Object("B")
>> +>>>  C = Object("C")
>> +>>>  f = Morphism(A, B, "f")
>> +>>>  g = Morphism(B, C, "g")
>> +>>>  (g * f).components == [f, g]
>
> Because
> ```
> In [13]: str((g * f).components)
> Out[13]: (Morphism(Object("A"), Object("B"), "f"), Morphism(Object("B"), Object("C"), "g"))
> ```
> I think directly comparing to `[f, g]` (or actually `Tuple(f, g)` as it is now) is easier to grasp.  Do you think I should still show `(g * f).components`?
>

I see. I think showing .components is the best solution, then.
This is not how our test runner works. This looks much more like an example that a test. Probably it should be moved to the examples folder.
Maybe call these `state1` and `state2`.  That way the user can at least guess what the arguments should be from the function signature.
for this haskell/ghc problem, I decided to add a chunk option `engine.path` to solve it; e.g. `engine='haskell, engine.path='ghc''`, so you can leave it alone (same on line 32 above)

https://github.com/yihui/knitr-examples/blob/master/024-engine-awk.Rmd is an example
Have you forgot `!empty` or `count` here?
Not problem. Would like to modify this in a way that it recognizes the repo so forks can still leverage the travis badge.
While I know how to represent blank nodes in N-Triples, I don't know whether to simply assign them a random (i.e. non-persistent) ID - @tillsc?
On 4/30/2012 4:23 PM, Jeff Balogh wrote:
>> @@ -0,0 +1,13 @@
>> +APPNAME = fncrypto
>> +VE = virtualenv
>> +PY = bin/python
>> +PI = bin/pip
>> +
>> +.PHONY : build
>> +
>> +build :
>> +	$(VE) --no-site-packages --clear .
>> +	$(PI) install -r dev-reqs.txt
>> +	$(PY) setup.py build
>> +	$(PY) setup.py install
> Is there anything in here that's not covered by the install instructions in the readme?
>
>

Nope, it's optional. As I note in another reply, however, it does reduce 
the number of steps that programmers need to take to get going and 
reduces potential frustration with folks who (like myself) may be 
selectively illiterate at times.

I just like establishing patterns for packages, so that folks know they 
just clone, run make to build and then go. The bonus is that folks who 
may not be familiar with python and are setting this up as a side 
service don't have to spend time thinking about it.
`return uv__set_sys_error(handle->loop, ENOMEM);`
I don't think we want to enforce this. Short usernames are probably fine.

Just enforce that the password has at least 8 characters.

You could write a custom validation to ensure that the password also has at least 1 letter and 1 number, but that's probably not necessary.
We should probably pull the existing behavior straight.
use the foo *command* to transer
we should avoid using parentheticals like this.
Can this query just be page_namespace = 'Template:' ?
Can you use SimpleJdbcTestUtils instead?
perm -> permission or permissions
I don't know why this is here but it certainly looks impressive.
And this looks identical to core.display_forums_row_inject.
Actually looking at this again. Is there a reason not to just always include #preview in the action? If it ends up going to a page without a preview it would just be ignored, no? So no need for inline javascript here.
I think commit message would be the appropriate place for this.
Just because the current code is crappy does not mean you have to keep adding crappy code. Adding a function seems to be a good solution in this case. Especially the sql_return_on_error trick needs an explaination (this isn't really related, i know) and using a function is a good way to make sure this code part is consistent everywhere.
You are right, count is probably ok then.
Latest commit avoids all this to only include tickets that are in Asset State < 128 (Not closed). Defect number is MUCH lower now.
do anything with err?
@rphillips Or perhaps just fix the build system to always put it into the right place? Or a symlink?
Shouldn't this be `if assocExe ~= nil`?
\n here too.
cred că liniile ăstea ar putea fi inversate, pentru a economisi procesarea query-ului din consecutive_chall_won ;)
Won't pass jslint with multiple var statements.
We should use InnoDB here
Kapow! It's gone.
Why those 2 loops? You want to make a copy of the list? This is a better way to do this:

f = list(f)
grads = list(grads)
I think you want instead:

    if any([not (isinstance(i, int) and i <= 0) for i in size]):
what is 100 the magic number?
This is better ... !
Either it's possible or it's not, if you can write a test case for it to happen it's possible and this comment is confusing, if not this condition should be removed.
Same thing as above (with the `MeanCurveCalculator`). Are there correctness tests for both approaches (MC sampling vs. end branch enumeration) to computing quantiles?
I really love this `Globals` system :)
I'm not sure I follow you. The old code was incorrectly translating `[attr="a,b"]` to `[id='ID'] [attr="a,[id='id'] b"]`, which is actually the worst possible outcome because those double-quotes make it a valid selector (versus single-quotes which make it the invalid `[id='ID'] [attr='a,[id='ID'] b']`).

Can you provide an example of input that should be handled by qsA but this change instead drives through Sizzle?
The returned value of "classify_internal" is just confusing.  There's no description anywhere.
I think we may need to enhance the AnyType when isNull() is true. That's we should map the NULL AnyType instance (I mean  the Null() function in the following code) to a NULL Datum ( PG/GP did like this ```#define PG_RETURN_NULL()  do { fcinfo->isnull = true; return (Datum) 0; } while (0)```).  With this enhancement, we didn't to care the NULL AnyType and it would be convenient for the invokers. 

```c
inline
AnyType
Null() {
    return AnyType();
}


inline
AnyType::AnyType()
  : mContent(Null),
    mDatum(0),
    fcinfo(NULL),
    mSysInfo(NULL),
    mTupleHeader(NULL),
    mTypeID(InvalidOid),
    mTypeName(NULL),
    mIsMutable(false)
    { }


inline
Datum
AnyType::getAsDatum(FunctionCallInfo inFnCallInfo,
    Oid inTargetTypeID) const {

    consistencyCheck();

    // The default value to return in case of Null is 0. Note, however, that
    // 0 can also be a perfectly valid (non-null) Datum. It is the caller's
    // responsibility to call isNull() separately.
    if (isNull())
        return 0;
    ...
}


inline
void
AnyType::consistencyCheck() const {
    const char *kMsg("Inconsistency detected while converting between "
        "PostgreSQL and C++ types.");

    madlib_assert(mContent != Null || (mDatum == 0 && fcinfo == NULL &&
        mSysInfo == NULL && mTupleHeader == NULL && mTypeID == InvalidOid &&
        mTypeName == NULL && mChildren.empty()),
        std::logic_error(kMsg));
    ...
}
```
Is the system openssl not good enough?
This can be shortened into a simpler form.  :option_switches seems overly verbose - :switches or :options is better.
^reddit's API overview
You set the ``value`` to ``null`` even if it's already ``null``.
Typical but not actually a requirement.  And not universal, else
dagger would have to be dagger-core.
列表项统一用`-`吧，打字方便，少按一次Shift

而且这里好像不用缩进
The socket object may be executed in different IO thread. This is race condition.
And have a merry christmas ocramius ;-).
We can't have dependency to Spring here, and it's unused.
This will break unless you have your universal repo inside some node_modules directory.
yep, return undefined :)
Is there a list somewhere of the expected format of ids going into this function? It's hard to know if it does the right thing in all cases without knowing the intended types.
isUnbatchedDelete kind of sucks. Would be nice if we could pull the info from the StorageException instead. Looking at the code for StorageException I don't see a good way to do that though.
`founditem` -> `foundItem`
`titem` -> `tmpItem`
Please remove these blank lines.
I like having a src/extensions/disabled folder in my source tree for easily moving extensions between dev and disabled. This change isn't needed as part of this pull request, so I can remove it if you'd prefer.
I am not sure of a good way to do that, so I opened issue #949 and added comments to the code.
I'm not sure if I would translate Inline Editor, but it seems appropriate - just thinking out loud...
add comment noting what keys 188 and 32 correspond to
Yeah... I thought it might be useful in the future -- e.g. we could do simple substring highlighting if item.stringRanges is absent (instead of highlighting nothing like we do now, which is a slight change from the old behavior of defaultResultsformatter()).  I'd be ok with removing it if you think it's unneeded API complexity, though -- what do you think?
Permissions, do check 'em
You should only have either auth or b -- not both
Please add a space after commas.
The documentation for `gtable_add_grob` seems to say that it can take a list of grobs and associated vectors of values. But it doesn't look like it's written to handle this properly. Should I just fix `gtable_add_grob` so that it can do this?
Is this something that we want to move into a configuration file or something? It'd be nice if we could have it default to hudl.com but set it on any development or testing instance.
This shouldn't be a pointer. We want to pass the address of the stack-initialized `git_oid` to `git_branch_create` not the address to the pointer.
Don't edit your comment and you will easier understand what I am talking about. :-)
language is still missing in this pull, sorry.
I don't mean to sound like I'm shy'ing away from more work but how urgent is this?
I don't think loading 100 revisions from a query with two conditions is going to be slow. However, the UI could potentially get unbearable if it makes the screen scroll till it explodes. 

However, a basic pagination feature could be relatively easy to do. Do you think that would solve the problem?
"Mozilla Popcorn" ?
media.popcornString sadly won't do the trick here. It only returns what's neccessary to create the Popcorn instance, not all the trackevent data as well. But I agree that I probably don't need so much stuff to test this functionality, so i'll tone it down.
Is it safe to assume that there will always be a locale string on the front of paths?
I know this is only a comment, but I'm an anal ba***rd - should that say "... from *these* two sites"?
I think we need https://github.com/mozilla/playdoh-docs/blob/master/operations.rst#gunicorn for gunicorn support.
These should be `@param` annotations
this pattern (keypos/keylen/malloc/read/free) happens a lot. perhaps it should go into an (inline?) function or method
Please remove @author tag
Looking at #in_environment, it doesn't look like these are ordered. I know you didn't write it but maybe you could fix it? Thanks.
see http://stackoverflow.com/questions/10048173/why-is-it-bad-style-to-rescue-exception-e-in-ruby?answertab=votes#tab-top first answer, i think it is explained there well and I agree with the reasons.
nit: do

`with open('phab.lock', 'w') as lock_file:`

to ensure that it gets closed. (or a try/finally but that's uglier)
the public keyword is missing
typehint the argument instead of doing the check here
You forgot to rename it to something better like Register subscribed hubs.
Maybe we should report the statusText whether or not the responseText is set.
Change the casing
this is sort of okay.
Is there anything else that access telephony in the homescreen?
Maybe you could use -moz-box-sizing: border-box so you don't have to subtract the padding from percentage widths?
and remove this space
depndcy -> dependency
Ah -- I see why you're doing this -- to set the ID of the table -- but it looks like you're setting the ID of the VOTable file, not the table anyway.  I think the better thing is to add ID support to `astropy.io.votable.table.from_table` and handle it there.
I'm curious why the build is not failing because of this? Will look into this later.
error name does not make sense. I suggest MessageFailed.
Sounds better, will update!
I'm a fan of NOT using ```extract()``` at all, or using it with a prefix in worst case scenarios. I will change this and [this](https://github.com/cakephp/cakephp/pull/1011/files#L1R746) because now that I think of ```$column``` can contain externally created keys, resulting in :8ball:
It would still be better if Description was closer to the program's actual name; it's used in a different way than "description" fields in packages.

In particular, during boot, <i>"Starting CJDNS routing engine"</i> is much clearer than <i>"Starting A routing engine designed for security, ..."</i>.
Is the parameter filename necessary?
so you had to go through the toil of implementing RuntimePublicReflectionProperty just because of this bug?
Typically, "key in dict" is preferred over "dict.has_key(key)"
Creating the child is handled by the builder. Is this being done twice on purpose?
You're right. The feinscms_extra_context was always updated (with good values).
I have updated the pull request.
I didn't. I just created the object `tagNamesToPluginNames`which I loop.
The inlineTextEdit plugin is almost identical to inlineTextareaEdit.
As requested, other services can be registered here.
I'd say that github.user is general enough to stay that way don't you think?
Brian E. Granger [notifications@github.com] wrote:
> In IPython/frontend/html/notebook/static/css/notebook.css:
> 
> > @@ -307,6 +321,13 @@ div.text_cell_render {
> >      overflow-x: auto; /* Changed from auto to remove scrollbar */
> >  }
> >
> > +/* The selected cell */
> 
> This turns the selected cell an odd color. I don't recall discussing this.
> Shouldn't this be removed from the PR?

I've always had trouble identifying the selected cell (the border change is
insufficient...).  Anyway this is unrelated to SVG stuff and shouldn't be in
this PR.

--
Cheers, Bob McElrath

"The individual has always had to struggle to keep from being overwhelmed by
the tribe.  If you try it, you will be lonely often, and sometimes frightened.
But no price is too high to pay for the privilege of owning yourself." 
    -- Friedrich Nietzsche
I guess I meant something like:

```
    @classmethod
    def load_results(cls):
        with open(os.path.join(basedir, 'lastresults.pkl'), 'rb') as f:
            obj = pickle.load(f)
        obj.__class__ = cls
```

But this is totally unnecessary, so let's skip it.
This is added with no other changes to the file - I guess it's a leftover?
Don't catch all exceptions. This is a Bad Idea. Catch the specific exceptions you are concerned about.