labofsahil/github-event-dataset-2012 huggingface dataset:
This is a very obvious example. Here's how I'd write it:

~~~~c
static void ensure_refname_normalized(int is_oid_ref, const char *input_refname, const char *expected_refname)
{
	char buffer_out[GIT_REFNAME_MAX];

	if (is_oid_ref)
		cl_git_pass(git_reference__normalize_name_oid(buffer_out, sizeof(buffer_out), input_refname));
	else
		cl_git_pass(git_reference__normalize_name(buffer_out, sizeof(buffer_out), input_refname));

	cl_assert(strcmp(buffer_out, expected_refname) == 0);
}

static void ensure_refname_invalid(int is_oid_ref, const char *input_refname)
{
	char buffer_out[GIT_REFNAME_MAX];

	if (is_oid_ref)
		cl_git_fail(git_reference__normalize_name_oid(buffer_out, sizeof(buffer_out), input_refname));
	else
		cl_git_fail(git_reference__normalize_name(buffer_out, sizeof(buffer_out), input_refname));
}
~~~~~~~

This way we can skip the `cl_git_fail` and `cl_git_pass` wrappers when calling the functions.
This fails to set an error message, this needs something like `giterr_set(GITERR_OS, "Failed to close descriptor")`
No, we are already calling get_appinfo() at the beginning of start_runner, which launches the application and can cause a framework failure. So we don't necessarily have None here and have to pass in the current failure if one exists.
when port is `80`, should ignore the port.

var jump_url = config.host + (config.port !== 80 ? ':' + config.port : '') + 
  '/active_account?key=' + token + '&name=' + name + '&email=' + email;
The contract of the class has changed as the handlers aren't optional anymore. I wasn't aware of the fact that you could have required parameters "after" optional ones.

So the options now are:
1) BC break and change the order of the arguments
2) Smaller BC break: only remove the `= null` from the constructor. People will still have to update their project to inject the failure/success handlers
3) No BC break by instantiating the handlers when they're not passed

@schmittjoh For the third option, how would passing the options for the handlers work? I guess the listener gets them all and passes them all?
@fabpot Any preference?
I think its inconsistent that default, requirements and options all overwrite existing ones in child routes. But the hostname is only applied to some routes.
Actually I would change the prototype of setFile to this:

```
public function setFile($file, $filename = '', $filenameFallback = '', $disposition = ResponseHeaderBag::DISPOSITION_ATTACHMENT);
```
$filename would default if not set to $file->getBasename() and $filenameFallback to a rawurlencoded version of it.
And then only setting the header in `prepare` (only if the user didn't already set a value). This would need 3 more properties and maybe getters/setters for them.
The autoETag and autoLastModified could be set in `prepare` as well
I wrapped the event dispatcher into an unmodifiable proxy now. I think this is the most critical one.
you should not tag the method as being part of the stable API when it it not even part of the API.
I've done that just for consistency.
The string cast `(string) $child` shouldn't be needed (same below).
Btw, `FormConfigBuilder::validateName` should also accept integer.
move all arguments on separate lines
Sure. I'll throw that in tomorrow. Heading out this evening.
Delete newline here.
Voor deze demo is Form1 wel ok als naam, maar naamgeving zou duidelijker moeten worden naarmate we een product opleveren.
Quadruple complexity is unacceptable for standard function. It's better to add custom implementation for this function in JS runtime later.
This license needs updating to MIT
I'm trying to avoid that kind of change, at least in this PR. Would you be willing to defer this one?
We can save this for later.
```rst
::

    $ pip install arrow

```
What object is should be mentioned somewhere (a comment here). A file path is fine for now; we may also want to support non-file drops (MimeData based) in the future.
Yep, agreed. Just to make sure we're on the same page: at the moment one of the mechanisms is missing (adding buttons to the empty widget), and will need to be implemented.
I don't much like this method, but appears the easiest way to propagate and correctly reset state.

Any ideas for refactoring this?
у пользователя должна быть роль которая написана hasRole, если очепятоться и вместо `ROLE_MODERATOR` написать `ROLE_MODRAOR` то внутренности не будут показаны никому, так как скорее всего такой роли нет ни у кого
FormattedException is a runtime exception so you don't need to declare it.
Is this a try of sanitise the number? We can have also + or #
Now we are dealing with 'error' properly,  rendering properly with 'error' icon
Mr. @fcampo, could you break the line:

if (!navigator.mozSms) { 
  document.write('<script type="text/javascript" src="js/desktopTesting.js"><\/script>'); 
}

;) thanks!
Needs to be l10n strings.
value_selector.js and value_selector.css for keeping the same structure?
err, i forgot to remove that.
All right, it cannot be.
@lightsofapollo do you think explaining here how to use Nightly is a risk?
This code is for getting work the blue highlight, that is being fired by the `<a />`. If not only the `<li/>` element will receive the click.
Check the CSS changes about `pointer-events` in `facebook.css`
I miss to add this line in my previous comment. My fault!
I agree with you on this, what's the alternative?

/me the original hacker of the mouse event approach
get rid of this if. it's unnecessary.
I'm not sure QPointer in a static is allowed, especially in a library. @rburchell?
Vsude jinde nez v konstruktoru by to muselo byt, tady je to IMHO jedno. Ale zmenim.
As near as I can tell, all the code should work correctly with plain jane Ruby `Hash` as well as the `BSON::OrderedHash`, where that matters.  In essence the JSON use would be the way we serialise the data into PostgreSQL, rather than anything fancier - the same way that MongoDB uses BSON serialisation internally.
Cool! Did you see the `cache` parameter?
Just to check, did you simulate the occasion when the JS is not available? Just to see if the page appears as we expect. :smiley:
As you don´t use `data` you can just remove it.
Pass the parameters to verify as a hash, and build the query there.
For readability I think it's nicer to use 'when' if you're only evaluating the 'then'-part anyway. It also eliminates the need for a progn
Can we remove this line then?
Can you comment that you are using the implicit long to bytes conversion imported from HyperLogLog here, and that it is bypassing the hashing, which is why you can see what the resulting value is supposed to be.

(full disclosure: understanding this test took me more than a few seconds, so I felt sad about myself).
Oh, yeah, good point -- the destructor should close it automatically...  I already merged it, but if it bothers you, you can fix it ;)
Yeah, I haven't find it before pushing codes, it should be a variable parameters and be given in subtests.cfg. thanks.
No kidding! I will double check if MySQL can produce negative years. I suppose it's a way of saying BCE years, an odd way of doing it, but maybe that's just because I've never written any web apps for prehistoric customers :)

The year range is 1000 - 9999, plus 0000: http://dev.mysql.com/doc/refman/5.0/en/datetime.html
No negative years yet: http://bugs.mysql.com/bug.php?id=17902
Yes, I'll add that in comments in a followup.

As for adding the id column -- bug 1053 claims Django likes this for its models.  I figured it doesn't hurt.
To add to this, it might make sense to incorporate this into base.Endpoint.
moaar parentheses
Coloca um comentário bem chamativo aqui pra indicar onde modificamos esse js, isso vai facilitar quando quisermos atualizar a versão do amberjack. Ex:
COMMUNIMED: this ... .
Still this is source code, not spoken english. I can easily imagine situation when I expect a list of one item's prices. Then I would name the method item_prices. So, just for clarity I'd leave it as it is.
Are we ignoring .gitkeep (and other hidden dotfiles) when generating FIXTURE_* pig parameters?
@gozala can you clarify the situation above? am I wrong?
can we just mention that a textarea is used in this test here?
siteName should already be escaped by this point - https://github.com/mozilla/browserid/blob/5b1150b3d52c65c1e5e591e5a42474ec508ac68e/resources/static/dialog/js/modules/dialog.js#L201-203

This is going to cause a double-escaping of siteName.

emails are not escaped whenever they are loaded, so they *should* be escaped when they are displayed, siteName will already have been escaped so I do not believe they should be when displayed.

@warner - can you weigh in here?
@lloyd - it is an extraneous field to check to make sure the whitelist is working properly.
nit-pick: Use string interpolation: ``'Writing %s to %s' % (a, b)``
What's the purpose of splitting this into two methods (doValidate()) ?
@zaphod42 Filed as https://projects.puppetlabs.com/issues/18046
it "replaces the only incompatible part" is probably a better description. It "works" is often smelly and can usually be described in a better way.
we should use a constructor with IP address specified, so we bind to only local 127.0.0.1
is this backwards?
this looks pretty yucky, i bet there's a way nicer rails way of writing this. anyone feel free to refactor this :)
Please no assignment in condition
getItem returns null on missing
This is wrong, see the lines 419 and 420. You can remove this import and use Exception\Foo in that lines.
This makes sure that the bridge is initialized if used.
This seems unsafe if tag is small enough ( e.g. #{sOk} )
Maybe use `getHandle().a(url, 16)` instead? (And `try {} catch (IllegalArgumentException ex) { throw new IllegalArgumentException("Texture pack URL is too long"); }`, or a modified `Validate.isTrue` call against the url to account for the 3 extra bytes)
I did it sir. I was trying to implement C language as well. It pushed on github by mistake. It will be reverted soon.
links in them: links to them ?
There is no result property, this should be $Event->data['result'];
camelCased here too
@anti var_dump?
$harjis Tähän kans lasku.myyja in ($laskumyyjat)
oops, new commit pushed
Yes, it would definitely be better to move the Mailchimp's serialiser to libsaas.service.base and make it use a pluggable function for serialization: the default would serialize booleans to 'true' or 'false' and other things to port.to_u(value). You could then use it here, plugging in your own serialiser function.
You seem to use this a lot -- you might want to consider using [`default_scope`](http://guides.rubyonrails.org/active_record_querying.html#applying-a-default-scope).
We probably could name this "OUTPUT_STATIC_FOLDER" or something like that, otherwise it's confusing, no?
Regarding your other comment on namespacing - yes, I agree that we should not pollute the global namespace.

I would just change this line to:
  SmoothieChart.AnimateCompatibility = (function() {

(and change the corresponding call, and move it to after the SmoothieChart function definition).
Uh... is this here so you have the choice of either:

```assert_mental_model_matches(:foo, foos).mapped_by(&proc)```

or

```assert_mental_model_matches(:foo, foos, :mapped_by => proc)```?

Because OH HELL NO.
Won't using interrupt flag also interrupt the player from looting corpse?
If not I will look how flag system work and try to do it.
PEP8 wants spaces around the equal signs.
@Sakshiarora here's what @AlinT was asking for :)

<code>_user_text_locator = (By.CSS_SELECTOR, '#main-content p')</code>
это может быть список полей и групп, но никак не структура, так что я б не переименовывал
looks good, will fix
You can just use opacity - I don't think -ms-transition actually works.
I did not see iam_instance_profile_name in the hash previously in debug output.

I am uncertain what fog and AWS will do if they are passed an empty iam_instance_profile_name, so I put the check here to make sure a blank one is never passed.  I also did not see anywhere obvious to add it in the lib/model/foreman/ec2 class.  If you have further feedback on how to add it there I'll be glad to add it.
Should some of this not go into ScalaDoc for this method and/or class?
12 + 6 * 4 = lol
Woah, woah. What's going on here?
This is the logic that I'd like to have some double-check whether this is acceptable. The problem is that the Aperture often will return a MIME type of `text/plain` for text files, regardless of their extension and thus potentially in conflict with the extension-based MIME type detector. So we need a way to choose between the two results (when they are indeed different).

Any thoughts, @hchiorean?
Actually the run_test() is the fancy pcal() wrapper, so adjust that one and cut out the run_setup() function. That seems the better option then.
Move this to a static function inside Melomel.as.
Use it as an IStaticRouteCapability instead of its implementation.
Ideally, implementation should not be directly used but in tests.
Will fix, thanks for pointing that out. I just didn't know where this option can be enabled.
Add comments explaining what exactly is happening here.
if I'm full of it and getattr does not work, you can use the "new()" constructor (http://docs.python.org/library/hashlib.html)
cast сишный не надо использовать.
good idea, just currious.
Yeah, you're right--this is a bug.
Agreed, was going to move to normal requires. Moving these into the file which uses them was the first step.
Adding ms and opera
this method returns True or False

is_expanded = "expanded"

"expanded" in is_expanded  ==> True
Very small typo: s/hovercar/hovercard
This can just be

    if (project[0] === '#') {
        data.project = project.slice(1);
    }
This should validate `expires` not `signature`
Why is a callback required? If it is, then we should throw an Error object with that message so it has associated error information such as a stack.
Should be tenantId
I was joking. I thought about `NoSymbol` but I didn't think it would be a much better behaviour to ignore it, since the shown code would be incorrect in both cases.
It owuld be nice to have a nice (warning) comment say that this is supposed to be accessed **only** by the companion actor (too bad we can't have an assertion to check this :-))
чому MIT і чому в Resources/meta/LICENSE?
yeah that's a temp placeholder until the other error handling gets refactored to be used in common
This is ZAT specific.  In general, I'm happy to pull these ZAT inclusions out but I'm more interested in code review of app.js.  This is a WIP build for now and will be cleaned up before asking for :+1:
Сравнивать строки на равенство как мне кажется лучше методом ![firstString isEqualToString:secondString]. https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Classes/NSString_Class/Reference/NSString.html#//apple_ref/occ/instm/NSString/isEqualToString:
Я вообще еле нашел описание метода isNotEqualTo: и как он определяется для объектов класса NSString
http://developer.apple.com/library/mac/#documentation/cocoa/reference/foundation/Protocols/NSComparisonMethods_Protocol/Reference/Reference.html
Как я понял, этот метод предназначен не совсем для простого сравнения строк.
This is actually invalid erb syntax.  Comments have to be in tags on their own.  Whether it works or not varies with erb implementation.
`msg.send` is asynchronous, so even if you call it twice in a row, the order isn't guaranteed. I'm sure it will annoy someone eventually. You can pass multiple strings to `msg.send` to ensure the right order though.
Hi Payten - 

Apologies for the eagerness. :) I think the pattern you mention is a good one, but I'm happy to consider other options. I understand that we should be thinking of the two contexts as somewhat distinct. Do you know if it's possible if you're merging a hash in YAML to override a key's value after a merge? For instance, is this sort of thing possible -

```yaml
foo: &foo_attributes
  bar: bar
  quux: quux

foolike:
  <<: *foo_attributes
  quux: blorp
```

so that `foolike` becomes:

```yaml
# what we want
foolike:
  quux: blorp
```

and not 

```yaml
# what we don't want
foolike:
  quux:
    - quux
    - blorp
```
This comment now belongs to the end of line 76 in defaults.lua and not here.
'channel_types' is already set, I would have used it otherwise


On Tue, Dec 4, 2012 at 1:54 PM, Denis-Alexander Engemann <
denis.engemann@gmail.com> wrote:

> I just saw the exception doesn't cover triple mismatch between all three
> channel type dicts...
> Explicitness is an argument, admittedly I always found Python's dict
> handling strange.
>
>
> On Tue, Dec 4, 2012 at 1:51 PM, Alexandre Gramfort <
> notifications@github.com> wrote:
>
>> In mne/viz.py:
>>
>> >      """
>> > +
>> > +    if scalings.keys() != units.keys():
>> > +        raise ValueError('Scalings and units must have the same keys.')
>> > +    else:
>> > +        plot_channels = sorted(scalings)
>>
>> I like the name types so +1 for channel_types and fine with
>> sorted(scalings) although I find sorted(scalings.keys()) more explicit.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/214/files#r2305528>.
>>
>>
>
>
We have this dep for this:

https://github.com/ryanmcgrath/wrench-js
Is it being used? If not please remove.
We need to stub this out so we aren't actually storing it when you run the tests.
It is recommended to put a line between each different annotation.
I'm ok with changing what is linked, but we also need to update the last line of this file so that what is inside the "ticks" here matches up with the external link pointer at the bottom.
Consistency is important here. I've tried to match PyArray_ PyDataType_, etc, where functions fit, but use Npy*_ when introducing something new that has no existing practice. Moving from PyArray_ to NpyArray_ is also an opportunity to improve the API design.
Why did you increase the indentation here?
But the `(x, x > 1)` part has disappeared! *That* is the problem, not whether the "otherwise" should be 0 or NaN.
Am I right to assume that this change is only done to make the `.withValue` sugar available?
И здесь reply утек.
pointless too
I think this might have been supposed to be a admonition, but it's not rendering as such.
Blank line above `for` please.
Sama kuin:
~~~clojure
[(my-take midpoint a-seq) (my-drop midpoint a-seq)]
~~~
what's the point of this comment?
Any custom types we have should really be marshalled using Externalizers, to squezze every single bit of performance out of it. 

Marking them Serializable is lazy IMO and results in bigger payloads, no matter how big or how often they're marshalled.
i have added a comment here .. since i am indeed not sure how this was supposed to work.
as -> has
For information, this method was defined twice.
Also, isn't the kwarg called `stacked`, not `stack`?
What does the ```False``` do? My guess is that it doesn't need to be there.
`mplDeprecation` is fine by me!
Excellent point - fixed
We can simplify this to `'css selector', '.message-block .received'`
Please capitalize "Yes", as it's a dialog choice (though that's clear from the code below)
Probably just because some arguments are already unpacked.
Or something like that string and a hash of some config options.

On Wed, Oct 3, 2012 at 11:07 AM, Graham Christensen <
notifications@github.com> wrote:

> In lib/plugins/sfPropelPlugin/lib/vendor/propel/Propel.php:
>
> > +    protected static function isServerBlacklisted($name)
> > +    {
> > +        if (!function_exists('apc_exists')) {
> > +            return false;
> > +        }
> > +
> > +        return apc_exists("propel-slave-$name");
> > +    }
> > +
> > +    protected static function blacklistServer($name)
> > +    {
> > +        if (!function_exists('apc_store')) {
> > +            return true;
> > +        }
> > +
> > +        return apc_store("propel-slave-$name", "down", 60);
>
> Mmm yeah. I don't know how long the APC key can be, which was my worry.
> I'll do some looking, maybe we can store the DSN in the key.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nationalfield/symfony/pull/4/files#r1750999>.
>
>
Please tell me that one day we'll just use database transactions
Dude, I'm sorry about not giving any more direction on my previous comment. My confusion is over the word **access**. Access is generally a security term; however, here I think you mean inclusion or association. I was thinking it should be worded more like *Place this department in the following groups*.
"les moins douloureuses"? Non.

> The standards we set here should be the lowest common denominator for painless autoloader interoperability. 

Les standards établis ici doivent avoir le plus petit dénominateur commun pour assurer une bonne interopérabilité des chargeurs de classes.
@robinkraft maybe answer this, and then merge?
Since this gets filled by an object can you initialise it as one?
Should say `Discover content or people`
I'm not sure I agree on the readability aspect. I have generally found that the more events attached to a single element, the harder it is to debug when something goes wrong. But often that is because they are being controlled by unrelated things in an obscure js file. So long as they stay in the same file it shouldn't be too hard to follow. If there is actual benefit to this, then do it.
Nit: `0` with units.
It looks to me like you planned to change __wt_compact() to call __wt_bt_cache_flush(), but that change never got made?

(To be clear, I agree with that change.)
Is it possible to define the element type for the array of parameter ``$options`` (using ``array<SomeType>``, or ``SomeType[]``)? Please also check line 83.
A bit unsure about mixing functions that operate on indexes themselves and functions that operate on index content like this.  Specifically, `remove` and `delete` sound like they will cause confusion.

We should throw a bit of extra brain at this and look at some naming / namespacing / thingy alternatives.
I seem to be missing this definition when I try to compile:
```
File "lib/xs.ml", line 99, characters 1-8: 
Error: Unbound value suspend
```

Where is `suspend` meant to be defined?
We'll need to update the index, but we shouldn't need to rebuild it - so people will continue to be able to use the site while the reindexing occurs. (Though since we'll be doing the upgrade incrementally, they won't have access to their site anyway.) We could also ignore datetime.max for 1.9, to make the transition easier.
Нет.
Смотри, что происходит при шедулинге loop:

    inline static void create(
        string_t const &name, bq_thr_t *bq_thr,
        x_t &_x, mfunc_t _mfunc, args_t ...args
    ) {
        (new bq_job_t(name, _x, _mfunc, args...))->__create(bq_thr);
    }

    inline bq_job_t(
        string_t const &_name, x_t &_x, mfunc_t _mfunc, args_t ...args
    ) :
        bq_job_base_t(_name), fbind(_x, _mfunc, args...) { }

Наш ref_t в составе args сохраняется в bq_job_t::fbind и там живёт.

Потом

void bq_job_base_t::__create(bq_thr_t *bq_thr) {
    if(!bq_success(bq_cont_create(bq_thr, &__run_bq, this))) {
        delete this;
        throw exception_sys_t(log::error, errno, "bq_cont_create: %m");
    }
}

static void __run_bq(void *_job) {
    bq_job_base_t *job = (bq_job_base_t *)_job;

    log::handler_default_t log_handler(job->name, &job->log_backend);

    safe_run(*job, &bq_job_base_t::_run);

    delete job;
}

virtual void bq_job_base_t::_run() const { fbind(); }

Итого, наш ref_t живёт в member'е объекта, который переживает корутину (job) и передаётся в корутину непрозрачным для GCC образом, поэтому выоптимизировать его вроде как невозможно.
Юнит-тест, впрочем, можно и написать :)
There was no error because the value was always undefined, which is always false. So my question is, does the logic of your program worked. If it works with this being always false then the question which appears is: do we really need this whole block of code inside the if. :-)
Because we do not have `elif` anymore, there could be a "flicker" for some users which just happen to get online between first for loop and second. In first we would notify all about them going offline and in the second we would notify all the they came online. Let's turn those two for loops around, first for switching to `True`, then to `False`.
Yes. You can assume that `request.node` is always populated with something. How it is done you do not need to worry. :-)

(Currently, we allow only access inside the network.)
And it does not matter. The way I see it, this is just for deducting if user is connected to the site. Channels do not matter here. I would track channels separately and only subscribe/unsubscribe user if she actively decided to do so.
Why this does not work?
Not that it matters *now*, but it'd be cool if this setup a FileSystemWatcher, so you could just dump files in, Carnac would then start responding.
Is this actually guaranteed to be a dictionary? Can't a snippet put anything inside `exit()`? What happens if the resulting hash is `{ success:{}, errors:{}, result:42}` ?
Will check it too... Yesterday my CLI was working with latest master, so I think it needs some better checking
Injecting the helperSet wasn't working, but adding it to the params makes it all go fine.
Now that six is in the production requirements, _str_func() can be replaced with six.text_type()
I have added a comment in the TestCase ASequentialMeasureGrouperShould to make the intent more explicit
The ChoiceToJsonTransformer we have is used to transform view data to norm data. It is taking the ChoiceList as argument and calling this getIntersect method.

If you remove those lines the parent type won't be our one, the one wich adds this custom choice list with the getIntersect method, it will be a choice list from symfony, so it triggers an error because it doesn't have the getIntersect method.

IMO it is wrong to have this getIntersect method in the transformer, the ChocieToJson transformer should only transform json to array, IIRC the choice list we have is used to allow free values (when using ajax), but this should be done in the choice list itself by overriding the methods getting the choices instead of our transformer, then a transformer from symfony will call those methods (should be getChoicesForValues and getValuesForChoices).

I think the part you're working is the part of the bundle having most issues and needing to be refactored :(
This and also 6 lines before it, need spacing inside the function args: `( y )`
Output map entry values can't be `null` in this case-- they'll instead be string `"null"`. Is this change in behavior desired?
Mention in this comment that the key/value pairs give meta data associated with the table.
Something like that :

->scalarNode('transport')
    ->isRequired()
    ->defaultValue('Lexik\Bundle\PayboxBundle\Transport\CurlTransport')
    ->validate()
        ->ifTrue(function($v) { return !class_exists($v); })
        ->thenInvalid('Invalid "transport" parameter.')
    ->end()
->end()
Well, assuming the user read the configuration-sections for plugins (which says, use should be the class) and the user is a developer ... I only added it for easier copy-pasting. Not sure what else to write there ...
I think using `$prop` as name makes the code readable more than if I made it `rawProperties` and then spitted code lines here into several lines because the line character count style rule.
True, it's much better this way, using on_abouttoloaddocument as the name though as that also shows up in a callstack. So that's one more advantage.
I think I did it to repeat less, but I agree it's much shorter and more readable when called directly.
`visible_event_list.contains(event)`
Quotation marks instead of apostrophes.
you might ignore this line, cause I already added this, last night don't know how good or bad the merge handles this
parent_options check can be removed here.
`GetQueryOptions` is badly named because in addition to query options it also gets header options.  In fact, it gets all options set by the request options.

I could see doing either:
 - just give up and call these options `query_options` everywhere
 - in ngx_pagespeed call them request options

I currently have us doing the second one, but if you'd like I could switch to the first.

I don't want to call this `ngx_http_pagespeed_get_query_options` while in `ngx_http_pagespeed_determine_options` calling them `request_options`.
if you use ``on :private, /bb (.+)/ do |m, branch_name) we can get rid of the check for parts.length and the string splitting below
Ok, then indeed `$+commands` is the way to go.
But then you're evaluating it at the left out point. Is this the right thing to do? My impression was that you get the whole density of X_j, something like

density = KDE(X_j)
density.fit(bw=bw)

Then you evaluate the log-likelihood of this whole density.

np.sum(np.log(density.density))

That's one f_i. You want to sum all the f_i, that's the whole leave-one-out likelihood. Am I misunderstanding?
no, that's totally cargo-culted, the suggestion for backbone views is to return `this` to make chaining them palatable, but it's definitely not anything i'm doing (or plan to)
Aha, yes, that then makes a lot of the stuff below clearer!
We do have a Shear class that does this addition.  This would be a good place to use it.
```
fake_gal_shear = galsim.Shear()
fake_gal_shear.setG1G2(fake_gal_shear1, fake_gal_shear2)
targ_gal_shear = galsim.Shear()
targ_gal_shear.setG1G2(targ_gal_shear1, targ_gal_shear2)
final_shear = fake_gal_shear + targ_gal_shear
```
OK, I needed it for gcc 4.4.6.  What version are you using?  (Want to make sure I set a guard with the right value.)
removed this (and from 108.07.00 too)
that is a problem!  the two lines were me testing and shouldn't be there.  but removing them does cause failure.  :(
弄る必要はないです。
ダメではないけど、既にmain.js.coffeeとかをassets/javascripts/ とassets/stylesheets/ に置いてるので。
s/applied/used/
How embarassing!  That's what i get for copy+pasting :(
nm, the assert covers it.
see the next comment: you should probably use only the formatted message, eventually creating a new formatter able to keep more stuff than a LineFormatter
Is this correct?  "effect/effect"?
Пустой файл тоже можно сортировать.
SHould we move this somewhere else in the document?
The URI class will handle the syntactic validation; in general, there's no other way to tell if a URI is valid (has a server on the other end, returns what you expect, is working) without making the request.
coding standards (people loving micro optimizations would tell you that it save a few microseconds in their benchmarks using it 10000 times too, but this is not the reason why I asked the change)
I didn't do this point yet because I wanted to get your opinion of using the sha1 as a slug the way I'm doing it here.
+1, esp. if Contractive Autoencoders are to follow.
Not new but will add a test ;)
I think the plural is always used: ``Laplacian Eigenmaps``.
і цей тест перевіряв?
It is, but that's covered by this change because of how [pessimistic version constraints](http://docs.rubygems.org/read/chapter/16#page74) work. Basically it used to say "allow any patch version of Rails 3.1 greater than 3.1.1 but stop at 3.2". Now it says "allow any minor version of Rails 3 greater than 3.1, but stop at 4.0".

I like to think of each part of the version being written on a number wheel, and `~>` means the rightmost wheel is unlocked to go up, but all other wheels are locked in place (with the caveat that a physical wheel probably only has zero to nine, but version number parts could go to 10, 11, etc.)
Don't loosen these two error cases.  The wording needs to be changed to show they're errors.
It's a little confusing that `@suppressed_output` and `suppressed_output` have the same name, but actually store different types of objects.  Can you name the one that stores the `StringIO` buffer `output_buffer` instead?
platforms lines have been duplicated in this file.  remove them please
Please use forward declaration.
Agree, I'll change
IMHO 
```java
if(!file.delte())  {
}
```
would be less confusing
does it work properly ? ``translatable`` is expected to be a value in the check done 3 lines above, not a key.
Also, it perhaps happened because the indentation wasn't right. The `<ul` part should be indented more than the `{% if ...` statement.
I did that so starting the server could only happen if the cassandra user the correct access rights on the /etc/cassandra directory.
I *think* this is no longer required and will remove it.
この2つの属性を public にしているのには何か理由がある？
I'd try to return the `__CLASS__` here or something – sometimes Mysql or MySQL. I don't think that's too elegant.
WTF ? The phpunit testsuite loads the autoloader in the PHPUnit bootstrap file. Please remove all this stuff
Terrible, terrible code.
No locators in the test. Please define this in the page object as a @FindBy.
@gregmarra I think that also happened a few places in the award name, but @fangeugene should have fixed those.
起始空行的丢失会导致谷歌浏览器无法识别用户脚本
close but double wrong from me

should be a boolean value

replSetServersOptions.read_secondary = (value == 'true');
I did just the same a few days ago XD (https://github.com/david-caro/browserid-certifier/commit/9665d8a3547a90d053ad6affeda90bd30ac2da79)
Also added a default configuration file and changed the config.json to look for a default config file if none specified, I'll test it a little more and request a pull when I'm sure that it will not break something :S
Hi @bodepd, I noticed the ```keystone::client::authtoken``` and just created the ```swift::proxy::authtoken``` class to be able to insert the ```authtoken``` middleware as written in the [Configuring Swift to use keystone doc](http://keystone.openstack.org/configuringservices.html#configuring-swift-to-use-keystone).
Man, I wish these guys had e-mail addresses.
Why is this a separate method?  You could just move the conditional block back into your parsing method.
c3 is not defined anywhere
Remember to specify whether input is RGB or grey.  For RGB, shape is (M, N, 3).
FacesContext is not accessible in Servlet, hence its not possible to queue FacesMessages as Sande asked. Googled a bit and this was one way to solve this, atleast partially.
This causes require.js to fail when I try to run the tests. It should be 'Renderer/UniformDatatype'.
@IanLilleyT we still have to make this change:

> Let's have materials follow the destroy/isDestroyed pattern used by all other objects that hold WebGL resources, e.g., textures; however, let's also have the texture cache reference count its textures. So when destroy is called for a material, if the material has any textures, the reference count for each is decreased. Once the count reaches zero, a texture can actually be destroyed since no other materials are referencing it.
Same answer. ;)
Nope you're right, this code has just been around for quite a while in my branch and I missed it when I reviewed it before opening the pull request.  I'm a big proponent of the one var a line, especially if you're initializing things.
That should be avoided as well.  Changing the instance assigned to the data property can affect the equality comparison of that instance to other instances.  But in limited cases it might be ok.
I moved the check that the vertex array was defined to `update` at first too, but it caused tests to fail that were creating empty `BillboardCollection`s.
Why not just set compiler directly?
xmlns is not necessary with html5 doctype.
New implementation should be consistent with existing behavior.
Current defaults are rowCount = 0, columnCount = kLauncherViewDefaultColumnCount
странное соответствие строк, а главное совершенно не ясно зачем оно нуно. пользователь снаружи может сам создать тот объект, который ему нужен
This indent is spaces, where the rest of the document uses tabs
You might try:

```python
from __future__ import with_statement
```

at the top of the file (for jython use)

and then

```python
try:
    with open('/etc/lsb-release') as fp:
        return 'Ubuntu' in fp.read()
except:
    return False
```

This will ensure the file always gets closed.
No, I mean the slowness has absolutely nothing to do with CTFE. The slowness is the 2500 templates which are created in compiling that function (I'm not exaggerating, it really is > 2000 templates).
I would point out that in general, any addition to the standard library which involves adding a new concept is a much harder sell than most other changes. A greater consensus is also generally required in such cases, since the cost of the addition is much higher, and it could have a much larger impact.
Here it starts : re-designing the AnalogInChannels class. Now each channel is an AnalogInChannels object containing its physical name, some label and a name that is saved in the .csv output file, and its properties (Single-Ended or Differential, enabled or not).
fixed in 12f0c8e
Bitwise not? Seriously?
Do these paths need to be updated?
I do not see how that code is correct.
1. It never closes the block started by "<%=" with "%>"
2. It tries to reference the js variable "test_result_id" inside the Ruby code.
3. It never defines the :test_result_id for the action or the :submission_id, which is needed for correct routing.

The only reason that it did not break anything is because it threw a js errors ( found in error console ) instead of a Rails error.
Also, calculations need to return a value for every patient in the cohort passed in.
From a performance perspective (and it's hard to know what the compiler might be doing without a lot of effort), I'd reconn that a string maybe more often found than the number types. Might be worth moving the System.String code after the System.Boolean code and before the numbers.

May not matter at all.
Why not replace this with optionalElementNS?
Note that there are more ways for "namespace llvm {" to get mangled by whitespace and not to be recognized, than there are for a simple replace of "llvm::".  But I'll give it a try.
Think it'd be o add-wrap openrasta-devtools -sys for people that want the devtools installed.
Wouldn't it be best to store the image url, and use UIImageView+AFNetworking? We get caching for free with that, it's way simpler, and we don't bloat the database with duplicate gravatars.
что там, static_cast<bool>(CryptoSystem_) ?
yep.  fixed.
this comment seems out of date with the code. the TagImporter may maintain a map internally, but calling it a "map" seems out of place when it's named "TagImporter"
can we always use a space after each `:` ? (everywhere in this file)
Ah..., yes. `new` can become nothrow. Thanks.
Please, no redundant comments.
Yeah, I'm inclined to just remove it altogether since we no longer care about Solaris.
Ben this is what meant, i'm adding encounter to the list and then adding both the encounter and the same list to the bindings map, if i don't do this some of the templates am calling fail.
I say definitely NO. If Map is unparameterized than by doing so we'll introduce inconsistent behavior. In other words as soon as a first non-String key ends up in the Map the mapping behavior changes. Imagine the runtime implications.
You might have test suite where you passing Map with key Strings and all is good, but in production such Map may end up with non-String key. . .
By the way, we can't advise the &lt;chain&gt; itself either, because of the way it works - the last element sends the output so we can't wrap the whole chain handler without wrapping the downstream flow in the advice. The chain itself is not an ARPMH so there is no internal handleRequestMessage() to advise.

Bottom line (unless we relax the advising of components inside a chain, as you have done here) is - if you want to advise a handler, it has to be stand-alone.
Check initial bar. Consider comparing full name.
`(!data.datapoints.length)` or `(!data.datapoints)`?
status is allowed only 'new' かな。
page や count が 0 以下の場合は例外を投げてください。
@apex13 We actually need this so we can have 3 items in 1 row.
Without a float it looks like this: http://cl.ly/IXKu
double `(())`
@shunter is right once again. My version of TestDriven.NET didn't support NUnit 2.6. All fixed now.
add isDeleted instead of using name
It's meaning "null return values". I've changed it.
this should be const
Change the setting in the IDE for this
This seems like the best possible solution to an awkward situation, yeah.  I think good JITs can probably inline and ignore this a bit.  In the event it turns out to be horrible, we can have the unit test re-map date.js so that a test-friendly wrapper variant is used instead.
Would really prefer this example uses a post body.
The values `YES` and `NO` must always be used for bools. Using other values can lead to weird behavior (true/false and TRUE/FALSE may flip bits that make an `(x == YES)` check invalid when `x` is a bool that's not coerced)
Returns a list of the current user's Facebook friends who are also using this application.
I also noticed this title changed, not sure if its an issue or not
Should make constants for these backup types. e.g.:
static NSString* const CDV_BACKUP_TYPE_CLOUD = @"cloud";
Das gevaarlijk, ook als de user niet ingelogd is, is er een token en gaat die $user dus opgevuld worden. Alleen gaat er bij niet ingelogde gebruikers "anon." in staan en bij ingelogde de user instance.
Will this cause a double Dispose on the stream?  If you've turned on the latest version of FXCop it'll let you know either way on this one.
Missing space after starting comments
Sounds like there's a view helper to be extracted. Let's look into this when we meet, Aleksi.
Исправьте на note
I don't know what changed that made this necessary, but while utilizing all the open PRs I have right now to do work on the demo the armstrong command was no longer working. It complained about a DependencyError (or something similar?) because I had armstrong.apps.content==1.1.0alpha.0 and that broke armstrong.apps.articles.

I have to admit to being rather flummoxed by the web of dependencies. I can wrap my head around saying "this package won't work correctly without this other package" and I can also see "it needs this package to be at least at this version, so that a certain feature is present", but I'm not sure what our goal is by saying "this package should never have additional backwards compatible changes". The combination of max pinned versions along with having a large number of packages in a .alpha0 status (including in particular armstrong.core.arm_content) just broke something.

All that being said, I have no problem changing it to something more reasonable once my armstrong/armstrong.core.arm_content#23 PR is merged in and released.
Do it like this and lint shouldn't complain.

`var requestObj = request.init(_webviewObj),
       shouldAutoDefer = false,
       features,
       i;`
One variable per line please
This is stolen from the existing example, it could be cleaned up, but probably not for this commit.
maybe reduce logging?
Nope, not until 1.7 I dont think, but then they might have removed it.
I thought underscore would be the nicest way. it is a small mostly standalone function (edited slightly)