labofsahil/github-event-dataset-2012 huggingface dataset:
I added krypt/spec/krypt-core for krypt-core API spec.  And for krypt-core-jruby, to avoid ant/rake integration issue, I switched from 'ant coverage' to 'rake coverage'.  Would you please try 'jruby -S rake coverage'?  You should install rspec first 'jruby -S gem install rspec'.

GitHub Issues for ToDo is good for me. I'll use it.
0 means expires immediately.  Something that lives for 0 millis.  :)

On 20 January 2012 13:01, tristantarrant <
reply@reply.github.com
> wrote:

> And 0 means disabled ?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/maniksurtani/infinispan/commit/f53958a265dc3dcc8ccd0617c1146d90712ff8c1#commitcomment-885042
>



-- 
Manik

Sent from my iPad 4 beta 3 with a telekinetic keyboard
I'd be much happier with that. # is misleading though, so I don't think we should ship with this.
I'll submit a pull request in a bit if you'd like? Right now I removed the functionality to over-ride the config defaults, so I'll add that back in first.
Sure i would like to :)
Ah, dang! Thanks for letting me know, d'oh!
Yup, that makes more sense. I will change it since I'm doing changes around that code.
Oh, apparently jQuery has something just for this.

Instead of .click(function() { .unbind('click'); })...
.one('click', function() { ... })
thanks to: Machiavelli
Not for now... Too many commitments. I'm was trying to get a save functionality working though, maybe you can give it a shot?
So... with this change, it is also possible to put private non-public-pypi-released eggs into eggproxy's cache and it should Just Work?
I used to do this with a couple of lines of apache rewrite lines, but just letting collective.eggproxy figure it all out itself sounds attractive.

(See http://reinout.vanrees.org/weblog/2009/11/09/eggproxy-plus-private-packages.html for what I did)
Excellent commit - using this, an import that previously took around 2 hours now takes about 40 minutes!
It is very dangerous to hard-code term IDs like this.  You are much better off to create a field in one of our admin settings form where this term ID can be set as a variable.  That way if we port this module to another site we will not lose the mapping.
bueno no creo que te mas problemas jaja
Alright I'll give that a try as well.
Unnecessary comma in end of line
I know I'm being premature and you are still early in the process.  I want to make sure that decisions like this early on don't paint you into a hole and prohibit implementing important things like this later on without considerable effort.
we should never do this. instead we should create our own helper that merely operates on arrays.
Depends on the previous commit to function…
Maybe check first what files already exist and then count that up? or use timestamp?
Gives Error on build : "error: /Users/haitham/Projects/World-Travel-Adice/FCOdata/../../../../Downloads/placeholder.jpg: No such file or directory
"

Thanks.
StringTextData was defined two times
first: CreatureEventAI.h:185
second: ScriptSystem.h:63
dont push that...
[Done](https://issues.jboss.org/browse/ARQ-800)
Don't get me wrong but IMHO you should not commit changes to android_device_samsung_cooper before you've checked that they work.
Just my opinion...

BTW. I had to commit these changes because we are compilling on VPS.
What does target.write do?
Ideally, this logic should be in the model (UNL_Services_CourseApproval_Course).
@cjmaclellan 

nested parameter study /optimization problem

for different initial time
Hm, it seems to not want to work on CM7, but it works fine on CM6... I think the difference could be in the TI video stack because we don't build it on CM6.
would rename this to fingerprint_for_local_key as opposed to the remote keys on the server.
`_substituteURL()` should also work with the signature: `_substituteURL(url, [data])`, allowing other data to be used, otherwise it will default to `this.getAttrs()`.
It would be more elegant for the hiding and showing of the "Detail" table to be done via the DT widget's `hide()` and `show()` methods.
¿progresando?
I'm not sure I understand the use case for non-shared services. In that case wouldn't you just wanted a shared ServiceFactory?
I changed it, I don't know if it is more understandable now. Basically, it is not necessary to get `$load_language_files` if we are going to load all the languages likewise.
About code conventions, last update is "Mar 13, 2005" and it talks about commons logging : it looks very old, is it still valid ?
oh, was this the wrong way round before?  oops
Of course not the entire url, but the appropriate part of it.
I'm assuming that the comment is to aid, and as such shouldn't be confusing, if you need to read the code to understand the comment, then I think the comment should be removed.
This should be removed from RemoteTransport. I don't think that the RARP  
should have the right to control clients.
Also in case you need it somewhere else
harm/gain? doesn’t do much …
As we discussed, please reformat this using the established style. See `zhao_2006` for an example.
Nov theme `title` can be translated. Theme `name` is system variable
I don't think it's pep8 compliant no? :) ("make hook" !)
Just prints some info and low level stats. I would like some feedback from you guys about this. Do we want to give some stats out from the class?
why is this commented out in new code?
I think you may need to escape the ~ not showing in git hub
Currently we do not have a use case for it as I far as I understand from our users.  It could make more sense that the organization does not exist to the public if there is no public datasets within it.   Otherwise there will need to be a bit of confusion around a public dataset in a private organization.
I meant to go back and amend this once I saw them in action. I saw you reference Bind.Action.BIND later and it actually read kinda neat. I personally would have gone with constants but that's no reason to change it. The bulk of my confusion was probably related to the fact that I was reading it in a diff.
I added the ! because this method has serious side effects.  I didn't realize that and was getting double renders in debugging and such.
BTW this is how MusicBrainz works. Give the user their original Artists string untouched and simply catalogue the artists from it.
Yep! Effective dependencies would be plugin dependencies that were specified perhaps in a Parent POM file. Does that make sense?
Add a ?s to support SSL?
By default (i.e. without configuration) a table is indexable 15_MINUTES (see ScheduleType comment).
there is another function find_by_view() that should be used if possible for any view operations. It's mostly redundant in intent to the query_view/parse_results and the expected way of doing things.

1: Feel free to carefully extend find_by_view with missing capabilities (without breaking things)

2: This is a potential connection point to custom indexes for objects (we need to discuss how RR and DM index mgmt can be integrated)
Sorry, brain fart. But yes, I was just saying the abstract log method seemed wrong. But I wrong in haste :)
[check](https://github.com/reneme/cvmfs/commits/29cf957a53f86ebf1616a4e85a16dda2c66a97e4)
can you update this to check for xhr.overrideMimeType first before calling it so we wouldn't crash on implementations that don't have this?
shouldn't this rather be `'DEBUG: '`?
I believe `return` is safer because we handle the operation and we bail out. Even if in this case `return` and `break` have the same behavior.
We still make the assumption that the current `plugs/` version has a `pencil.html` file?
I prefer to leave the braces off of the statements if they're single-level single-line statements.
іменуй змінні більш описово, якщо це довжина пароля, то іменуй щось типу password_length і т.п.
Use System.mapLibraryName; you can get rid of libPrefix and libSuffix.
Look at how Lu is required in sandbox.html

Sent from my iPhone

On Jun 11, 2012, at 10:15 PM, Jim G<reply@reply.github.com> wrote:

>>  */
>> -var Container = require( '/scripts/lu-controls/Container' ),
>> +var Abstract = require( '/scripts/lu-controls/Abstract' ),
> 
> I just did a pull from linkedin/Lu and now I'm seeing network requests
> for lu.js at
> 
> http://localhost:1337/examples/lu.js
> 
> which are 404ing.  This is the same problem I was having on Friday,
> and had to revert everything back.  :(
> 
> 
> 
> 
> 
> On Mon, Jun 11, 2012 at 4:44 PM, jim g <jimg@yojimg.net> wrote:
>> Decorators still use full paths, right?  e.g.
>> 
>> decorators.push("/scripts/lu-decorators/positionAbove");
>> 
>> ???
>> 
>> 
>> 
>> On Mon, Jun 11, 2012 at 4:03 PM, Robert Martone
>> <reply@reply.github.com>
>> wrote:
>>>>   */
>>>> -var Container = require( '/scripts/lu-controls/Container' ),
>>>> +var Abstract = require( '/scripts/lu-controls/Abstract' ),
>>> 
>>> with the version of inject I committed on Friday - they should 'work' - fingers crossed.
>>> 
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/linkedin/Lu/pull/153/files#r963723
>> 
>> 
>> 
>> --
>> jimg at yojimg dot net
> 
> 
> 
> -- 
> jimg at yojimg dot net
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/linkedin/Lu/pull/153/files#r965006
First line blank in multiline comments. Yeah, it's a nitpick but in the style guide.
I think this can be called here regardless of the value of `this.commitMsgPrompt`.
Fixed by the next push.
Like this? https://gist.github.com/3352499
The signature can be `(grouped_options, selected_keys, options={})`. If someone pass something different than a hash as options, he's passing the prompt so we should show a deprecation warning.
I think so, should work fine.
Is it necessary to `dup`, since `where` should already be a cloned relation?
Why here it's error and after `reset()` it's fine to call `eval(action)` twice?
One test for ``method="golden"`` would be good here.
I see now this isn't yet covered by qapply. Do you intend to extend qapply to do something like this?
Yes you are right... it is self-explanatory... no need for the additional comment
paremetric => parametric
Maybe add: "This may change in the future if a more advanced default range detection algorithm is detected."
Then I'm afraid to tell you about `yield from`, because you will be disappointed that you can't use it (because it is only Python 3.2+ I believe).
I know exactly what you mean in asking this... What about if expand automatically splits hints into `expand_hints` and `meta_hints` and all `expand_foo` and `_eval_expand_foo` get `**meta_hints` passed?
Ok, I'll keep this in mind.
> `password_hash`? :)

sounds good :)
echo $class===null ? '<tr>' : '<tr class="'.$class.'">';
may be change this line to 
```php
throw new CException(Yii::t('yii','ImageMagick or GD with FreeType PHP extensions are required.'));
```
da fehlt ein "sich"
Fixed in 648529f
the difference is that FrameworkBundle does the check about classes implementing the interface. but it does it when compiling the container instead of doing it at runtime.
This isn't a proper impl of clone().  Sub-class here won't function as expected.  Mark CursorBuffer implements Cloneable and use super.clone() to get cloned instance.

Or change the method name if you don't really want to clone, but you just want to copy.
Bad things, probably. This was undefined before too. There seems to be a bit of a disconnect here, since reports don't tend to make sense for difference events (but can be configured nonetheless).
have you verified that cross referencing works here? I'm concerned that it might not. 

something alternatly we could document this as 

     .. operator:: <array>.$
In a previous comment on this PR you asked for all globals to be cleared after use. So $user is being cleared here.
Comma shouldn't be there.
I can't find this in the coding guidelines, but I could have sworn, we decided that closures and lambda functions should have the opening bracket on the same line.
> Not sure why half of your comments have words that start with capital letters out of nowhere? Also see "Root path" and "PHP Extension" below this line.

The first word following a variable in a doc block is the start of a sentence and should be capitalized. So Root path is correct. But you are correct that:

> "Extension" would be the seconds word so shouldn't it be lower case then?
answer please
You should not be trying to use the first element in $attachments before you know whether or not $attachments is empty. This assignment should be moved.

You can move the if (empty($attachments)) condition above this. Because of the trigger_error, you don't need the `else if()` on the next two conditions. As such, you can move the $attachment definition between the first condition that ensures a nonempty array in $attachments and whenever you first need the $attachment data.
You should not be creating instances of the log class in each function using it if there is supposed to be an initialized instance already. It's one line of code to create a log instance, anyone using phpbb's code can add it.

Also, it's compatibility with an i.
@Fyorl "random" and "unknowable by someone outside the system" are closely related. I agree with Oleg that this is not sufficient. I had actually seen it already and was looking for a proper solution. In the database updater you can probably call `md5(unique_id())`, not sure about the installer. The problem is that mt_rand() only has 2**32 different values on 32-bit system, which is quite easy to brute force and makes the salt useless.
The is_image change has been merged into develop. So this should be reflected in this pull request.
Needs a docblock.
I like it as is.
Why not just `$match = array('#&quot;#', '#[\n]+#');`?
No, the functions that call this are expecting a string with PHP code in to be placed in the compiled template file. If $path is returned here, it would just be a useless string.
Query layout is wrong
The YUI 3.5.1 way is `Y = require('yui').YUI({useSync:true}).use('json-parse', 'json-stringify');`, but **note** that the Y will be "stuck" to useSync mode.  For this case (just using Y.JSON) it's not a big deal.  To be safe you could call `Y.applyConfig({useSync:false})` after.
The `@param {int} type` documentation is left over from an older version of this method.
It's possible to use git to diff binary files, however we must tell git how to do it.
It maybe useful if, for example, DSpace provides the PDF Manual in his bundle (or other formats).

At the moment, i think those extensions aren't used.
You don't need to convert to a string. Just do:
if (AppSettings.Browser == BrowserProduct.Firefox)
Just deleting old files, no longer needed.
This is nice, adding the 2d source coords. Can we set ```coord_system=source_cs``` too?
Should factor this out to a function. Maybe even into cartopy (it will be useful).
I think I mentioned using graph.io_toposort before, but I'll mention it again here - wouldn't this be clearer with something like

```
outputs = [output]
inputs = graph.inputs(outputs)
nodes = graph.io_toposort(inputs, outputs)
vars = graph.variables(inputs, outputs)
return {v: [(node, node.inputs.index(v)) for node in nodes if v in node.inputs] for v in vars}
```
You just make me thik, you need to inref if. Py_INCREF(%(inp)s);
All right, this was expected by John but seems not necessary right now for we can not pack treenode memory. Fix it. Thanks paul.
I am using url.find(x10sion) instead of url.endswith(x10sion), since in some cases the extension is not really the final sub-string of the URL, for example http://twitter.com/script.js?serialize=1&compact=2
Ditto. Use variable and break out of the while loop.
Indeed - I didn't change names of anything.
We should discourage using `datetime.now` given the new timezone abilities in 1.4. Instead use `django.utils.timezone.now`.
Should change "Feb 28 2013" to "Feb 29 2013"
Please don't capitalize function names. Capitalization should be reserved for macros.
Do we contain this kind of reformat in this pull request?  The objective of this PR doesn't mention it and if we didn't it, we could focus on the actual changes we are trying to do.
It won't work in most cases, unfortunately, only if login attribute matches with display name attribute and when there are only ascii-characters returned. 
I'm more interested in why it happens. Because, as said, as soon as a username is choosable, it actually must be in the mapping's table, since they are written thereto when the username is being generated.
iirc, REQUEST_URI is used here to allow linking to/bookmarking an app, so I can go to owncloud/index.php/apps/media, login and go directly to the media app
Probably. I'll add it.
If we're going to write "If logged in" we should do that with consistency for all the decorated functions. For simplicity, I would error on leaving it off.
$key wird in Zeile 169 verwendet..
Hatte ich beim Schreiben auch überlegt. Mir erschien es so sinniger, da die Fieldnames nicht von der aktuellen Row abhängen, sondern für alle gleich sind.
Aber klar, man könnte auch anders argumentieren, zum Beispiel, dass die Fields nun mal eine Ebene unter der Row sind.
wir hatten definiert das "dir3" auch auf unterordner greift. nur ein "/dir3" würde rein den root ordner treffen...
lol.  Fixed.
spelling: annotatedFieldsByParameter
When selecting complete lines, it seems inconsistent that the suffix and prefix are inserted inline. What do you think about putting each on its own line?
Please remove the unused argument
I  think most of Japanese don't care about the space.

![Example](http://www.sarah-sys.co.jp/img2/products/fio_01.gif)

Additionally, most of Japanese don't care whether the colon is single byte (`:`) or multi byte (`：`), too!

If you feel there is no problem, I will do nothing. What do you think of this?

Thank you for checking details!
Adding high ascii and all unicode may be good enough for now. This works for the test cases I threw at it:

(function\s+([$_A-Za-z\u007F-\uFFFF][$_A-Za-z0-9\u007F-\uFFFF]*)\s*(\([^)]*\)))|(([$_A-Za-z\u007F-\uFFFF][$_A-Za-z0-9\u007F-\uFFFF]*)\s*[:=]\s*function\s*(\([^)]*\)))
If you need to require something, you can use `:features'.
Hmm, normally, in Python I like to keep blank lines between the blocks as I can see the scope better. Python does not use curly braces, only indentations, I'm still getting used to it. I can remove some but I really do like to keep some blanks.
is this really public ?
I think we should keep the wise argument, but if it is not NULL, throw a warning: `warning("Deprecated: wise argument to coord_cartesian is ignored", call. = FALSE)`
This actually toggles the visibility of the object denominated by id (specifically, I believe it switches between display: none and whatever the default display value is for the particular Element).
I think this comment is unnecessary. This is evident from the template source.
Just have the youtube video in here
Does this need to show up on export? ...does it right now?
leave the version at `~0.1.7`
I'm guessing these print statements are no longer supposed to be here?
if it were null, wouldn't this throw an error trying to access `should`?
As a quick note, I stripped bootstrap to only what I'm currently using or what I will certainly be using in the future; this is not the original.
File name seems wrong here. Collector name and stream name are separated by -(hiphen) not _(underscore)
Hmm, hadn't looked there myself, so fair enough. The Emacs formatter wants an indent here, though, and to me it's clearer, but perhaps a third opinion is warranted. :D
Today, we do persist the login notices.  Do we want to continue to do that?  I've heard some people mention that they don't find them useful... If we choose that we do not want to, we can add the ":persist => false" option and the notice will flash, but not be stored in the db.
True :(
It must be something else then.
@xsuchy fixed in b7b6da5
This validation doesn't seem to run, I think the syntax might be off.
Why is the name 2588645841ssegtnti ?

Also if we want to install the settings by default at some point you probably don't want to kill b2g for that. Also you should use the python code to install your database if this is permanent.
Changing these cases is unnecessary
There is, and I forgot about it until you mentioned it.  I just updated the PR to reflect this.
Yes, I think we should add this to the coding standards.
Great points.  I've made these adjustments in the new branch.
Why not ~s on both?
Got it. I'll remove all the indexes for now and we can only add them as we
need them.

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>



On Mon, Nov 19, 2012 at 5:35 PM, Luke Steensen <notifications@github.com>wrote:

> In db/migrate/20121114025229_create_users.rb:
>
> >        t.timestamps
> >      end
> > +    validates_uniqueness_of :name
> > +    validates_uniquness_of :email
> > +    validates_format_of :email, :with => /^([^@\s]+)@((?:[-a-z0-9]+\.)+
> [a-z]{2,})$/i
> > +
> > +    add_index :users, [:name, :first, :last, :email]
>
> And you probably don't need to be creating most of these anyway. Indexes
> are for columns you often search by. Premature optimization blah blah.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/bitcast/pull/11/files#r2174567>.
>
>
At least easier, but I hate globals ... sorry. Can you give a suggestion, where to place the initial call to GetClientStartupTime() :)?
out of interest, how come I needed to add this line, but no one else seems to need it?
... and the most complicated to implement. As the Apply and OK button need to be active then and somehow we need an info message that cli options have overridden the GUI settings. Last comment in this, perhaps one should open an issue to track this.
This should just be an inline comment using `//`
You should not need any of these QueryBuilder.* translations now that cgxp uses those from geOrchestra's styler
Yes this is ugly but otherwise PHP fatals. And, some of these could actually be implemented if we wanted to. I didn't :)
But what if we want to run this on punch-card machines? What then?
I'm assuming this was intended to return error to propagate errors from incUses up towards something that can relay them to IRC? At the moment this doesn't happen, and having a function signature that implies errors *can* happen but always returns nil seems... bad.
Are you sure? I'm not using the async feature. I'm just calling the argument name "async". This should be perfectly OK in C# 3.5 as well - this is a plain bool argument that determines if the program should wait for the git thread to return.
This is a C# 4.0 language feature while I was really careful to use only C# 3.5 so it would work on Mono under Linux.
However, I just checked and mono has indeed advanced since I updated it. It seems that we should move to 4.0 at least or even 4.5 language enhancements. But before that, I'd like to revisit the documentation and make sure the install on new mono on Linux is documented and solid. What do you think?

At the least, I need to change the MSVC project to 4.0 since these changes won't compile at the moment with my setup.
Thanks!
:clap:

Very nice work.
The extra parenthesis here (and a couple lines below) are not needed.
Can a method in the DateService or DateUtils be used for this?
why change this from using a jclouds internal dep to an external one that does the exact same thing?
With the current implementation, the PathParam annotation does not work. This is related to the topic you mentioned in a previous comment, about the use of the EndpointLink annotation that we use to extract the Path from the object being an argument.
I have pending in my TODO list to start a discussion in the dev mailing list explaining the details about this and how and why we use it (because it could be reused in other apis and I think it could be very useful).
this should be transient ok based on jclouds-slf4j
component base component <- its amazing what you find reading your own code sometimes =( 
I will clarify the use here by adding a code example (and one to the constructor).
Should probably note that is it possible for this to return NULL if this index object was just created by `git_index_open()` and not retrieved from a `git_repository`...
Update the docs accordingly.
From our missing styleguide: functions that can only fail on OOM do not perform cleanup, because, well, the cleanup will probably fail is we're OOM.

```c
if (git_buf_joinpath(&merge_head_path, repo->path_repository, MERGE_HEAD_FILE) < 0)
    return -1;
```
Alright, I can buy that :)
Ah, makes sense. How about we drop the bottom margin on the UL tag in that case, and have this link bottom margin replace it.
you can go ahead and delete this css file from the repo now, right?
In our code base, by convention, we always include the (ugly) semi-colons even if they are not needed.
Confirmed by Josh on IRC, proc name is "update_signatures".
good point.  This could easily be replaced with something safer.
Does it means that we have a bug? :-D
I think this needs to be reworked a little bit - shouldn't it have == 1 instead of > 1? I'm going to merge and fiddle with it.
I know. So the BC break would then be that there are 3 extra required parameters, but no change of order. The last option wouldn't require a BC break at all I guess.
use ``!==``. It would be more readable :)
``View all`` is weird as it shows only the last 10.
You are just bypassing the validation here, which is wrong. Have a look at the error message. If you want to allow negative numbers, you must change the `isValidName()` method instead.

ping @bschussek
Yes, sorry, as i said it is not a real pull request, I did not put in much
time. Originally I created a script in rosinstall for that, but then
copy&pasted back to vcstool, and must have messed up there.

You are right for both lines, should be _PULL and cmd_install_or_update.

The whole thing is not working perfect yet, I was lazy looking up the uri
when creating the PathSpec, the API contract requires a PathSpec with SCM
to have a URI when creating a config currently (else the .rosinstall file
would be invalid), so some flag needs to be added and set to avoid my fake
url from being used. I'd have to think about this for a little to make the
change, this was just to give you an idea of what implementation I'd prefer.

Since I did not know whether you want this kind of code or not, I did not
want to invest a lot of time, just enough to give an idea. If you ask me
to, I will create a real pull request with some testing.

On Wed, Oct 31, 2012 at 9:32 PM, William Woodall
<notifications@github.com>wrote:

> In vcstool.py:
>
> > +    if verb == _STAT:
> > +        statuslist = multiproject_cmd.cmd_status(config)
> > +        allstatus = ""
> > +        for entrystatus in statuslist:
> > +            if entrystatus['status'] is not None:
> > +                allstatus += entrystatus['status']
> > +        print(allstatus, end='')
> > +    if verb == _DIFF:
> > +        difflist = multiproject_cmd.cmd_diff(config)
> > +        alldiff = []
> > +        for entrydiff in difflist:
> > +            if entrydiff['diff'] is not None and entrydiff['diff'] != '':
> > +                alldiff.append(entrydiff['diff'])
> > +        print('\n'.join(alldiff))
> > +    if verb == _PULL:
> > +        multiproject_cmd.cmd_update(config)
>
> Should be cmd_update_or_install?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/wjwwood/vcstool/pull/1/files#r1997845>.
>
>
extra space before `==`
vali kolan yadet bashe ina modul hastan va albate comment ham mikhan
bakhsh bandi haro yadet rafte
ki morde?
What prompted the simplification back to the original form?
What's the downside of fts2opcorr failing? The code just says FAILED (with a double new line and it should be warning rather than saying) but then carries on regardless.
This function is run after all datum have been rpocessed, either successfully or with failurs. it takes the user back to the home screen and also toasts them about the results of the saves. the savefailedindex in ImportEditView.js can be resused to try to retrigger the saves later on. So far i havent been getting any failure anymore, and technically there really shouldnt be an failures unless pouch dies. I should probably  look into how pouch works because i might need to deal with when it dies and restart it somehow... (currently i just refresh the page...)
Well, it's all contained in a single tick so the user can't get to the intermediate state, so it seems fine. It's not like we're doing any processing to handle this twice, it's just a property set.
New line here?
`registerEvents` -> `attachEvents`
Do we really want to keep this console logging message?
Should we add them as constants? Somewhere else?
this file didn't change more, just indent <body> and <head> block
encoding issue? (ellipsis…)
Why do we have this ugly non camelCase name ? :)
+ add the `type="text/css"` attribute please
Umm..  I think it would be cleaner to do like this.

try { task = base.PutItem(); }
catch (ex) { op.Release(); throw; }

return task.Catch().Finally(op.Release);

just an idea.
I think we have this logic in multiple places, (uri building logic). I think even in this same file. Can you refactor GetSiteUrl so that it can be reused in this method?
They just don't fit well with the other unit tests. None of them run exes or create things on disk. We have a clear separation of what a unit test is and what a functional test is. But this is kinda grey area...
I know that it can be hard to understand, but at least, I keep BC here.

We can't safely rely on the `hashCode` if the object is new because it throws a lot of issues, like really weird issues.  `contains()` and `search()` methods rely on the primary key in the context of the `PropelObjectCollection`, that's not what we want in adders, because there is no pk yet, or not always.
You can turn this into a one-liner:

`eval(script.innerHTML) for script in document.body.getElementsByTagName('script' )`
If we care about `commit` to only have been called once in the `Track` spec it maybe should only been called once here!?
leave this on 1 line please
We actually have a use case, but I agree we should add a comment with proper scaladoc.

The use case is this: we have a compute heavy job, but hadoop won't let us read less than the min-split size. So, we read the data, and then shard it N ways and start the compute heavy job.

This is basically a way around the limit on 1 mapper per min-split size.

A second application (though more dubious in my book) is when you want to do IO outside of HDFS (like hitting a service) and you want to be sure you don't have too many concurrent connections.
Again, rescue `Exception` as a last resort. Catch specific exceptions first.
Is there a benefit to switch over to the other method? I prefer this way
since it's shorter. Previously I was told to use asserts <expected>
<actual> which I changed.

On Fri, Nov 16, 2012 at 9:39 AM, Chris Bunch <notifications@github.com>wrote:

> In AppManager/test/functional/test_app_manager.py:
>
> > +
> > +class RunPythonAppTestCase(unittest.TestCase):
> > +  def setUp(self):
> > +    self.appname = 'pythontest1'
> > +    self.port = 20100
> > +    setup_app_dir(self.appname)
> > +    config = {'app_name': self.appname,
> > +              'app_port': self.port,
> > +              'language': 'python',
> > +              'load_balancer_ip': 'localhost',
> > +              'load_balancer_port': '8090',
> > +              'xmpp_ip': 'localhost',
> > +              'dblocations': ['appscale-image0'] }
> > +    config = json.dumps(config)
> > +    self.pid = server.start_app(config)
> > +    assert -1 != self.pid
>
> Use self.assertEquals, which is the proper way to use Python unittest.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/AppScale/appscale/pull/99/files#r2154377>.
>
>



-- 
Navraj Chohan (Raj)
PhD Candidate @ UC Santa Barbara
http://cs.ucsb.edu/~nchohan
http://appscale.cs.ucsb.edu
http://nlake44.posterous.com
I had it that way initially, but then saw that some didn't follow that pattern elsewhere so I changed it.  Which is preferred?
Do you not see the clear DOUBLE HEADER here...?
They shouldn't come around before search starts, but I haven't 100% verified that yet (just basing it on what others have said about reltool). Either way, if search waits properly for its vnodes to start like KV does, the PB service won't be registered until it's up.

The other aspect is that I wanted to avoid dumping the connection except in situations where the service state is completely broken, so the callbacks should try to return `error` tuples instead of tossing exceptions. Uncaught errors go through a try/catch clause that warns the client of the error, logs it at the debug level and then stops the TCP server.
This is a non-idiomatic way to declare state.  Why not just stick with the typical `#state{}` record idiom?  I see you have to return it the `pb_service` behavior, that also seems weird.  Why is a record defined by this module being passed back to it's behavior?
Hi,

Sorry about that. Yes. It was a typo.

I have pushed the fix.

Thanks!
Adi

On 20 July 2012 19:08, Jared Grubb
<reply@reply.github.com>
wrote:
>>          service.MultiService.__init__(self)
>>          self.basedir = basedir
>>          self.usePTY = usePTY
>>          self.unicode_encoding = unicode_encoding or sys.getfilesystemencoding() or 'ascii'
>>          self.builders = {}
>> +        if not patch_command:
>> +            patch_command = 'patch'
>> +        self.patch_comment = patch_command
>
> patch_commENT?  is that a typo?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/buildbot/buildbot/pull/474/files#r1206647



-- 
Adi Roiban
My first reaction to seeing this, is that the `pathPatterns` should be able to dispatch to different functions. But I guess that is probably too complicated, in general.
“Use `expr?` to compare against undefined or null and `is / isnt undefined / null` if you need specific value” maybe
This will handle the native gesture that pulls the keyboard up (swipe to center from bottom left).
Perfect. Thanks for the tip; I'll experiment with that.
dumb q. does this save the record?
Hmm, this one confuses me, the description says the opposite of what's tested. Since it passes, what's the desired behaviour now?
Good point. If you have some good phrasing in your mind, go ahead. I can't recall what we talked about these. :)
Should we document the real meaning of the replies / retweets here?
On Fri, Jul 13, 2012 at 8:50 PM, Nigel Babu
<reply@reply.github.com>
wrote:
>> +    )
>> +def event_export(profile, event):
>> +    if profile.userid not in g.user.user_organizations_owned_ids():
>> +        abort(403)
>> +
>> +    participants = StringIO()
>> +    fieldnames= ['Ticket Number', 'Name', 'Email', 'Ticket Type', 'Company', 'Job',
>> +    'City', 'Twitter', 'Tshirt', 'Date', 'Order ID']
>> +    writer = csv.DictWriter(participants, fieldnames=fieldnames, delimiter=',', quotechar='|', quoting=csv.QUOTE_MINIMAL)
>> +    writer.writeheader()
>> +    for p in event.participants:
>> +        if p.status == PARTICIPANT_STATUS.CONFIRMED:
>> +            writer.writerow({"Ticket Number": p.id,
>> +            "Name": p.user.fullname,
>> +            "Email": p.email,
>> +            "Ticket Type": "Regular",
>
> Why are you inserting Ticket Type here?

That's what PeopleFlow can import now. Just hardcoded the csv
structure for now.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hasgeek/hacknight/pull/81/files#r1159514



-- 
Sajjad Anwar | W: http://sajjad.in | T: @geohacker
This plugin description seems incorrect :)
I thought we could optimize later :). But seriously let's do optimizations when necessary as necessary and put comments explaining why do we do them. At the moment it just looks awkward and confusing.
maybe add an `\n` here for readability.
5) Kick off a child_process to do the write?
@zaach, this is fixed and pushed into the pull request. Feel free to try again.
Alt attributes shouldn't be empty.
...seems to me that we are much more likely to have changes in the set of attributes from the zfs pool that to make a typo in the set of attributes we support - and the later is much more likely to get caught.

That said, I am not going to fight you on this.  If you feel strongly that we should handle it this way I am happy to accept it.
@jeffweiss minor nitpick, the permissions could change between the time we check and when we actually try to read. Perhaps, we just wrap the `result.read` all in a begin/rescue and warn there?
Lisbon?
need call to bind() to actually see if port is available
Sorry...it's optional in Python 2.7, and I've got into the habit of not using it!

Will put a zero in.
any particular rationale to "reverseBytes" ?
Added convenience functions to FileUtils for that.
I would say use the with statement here, but it looks like gzip didn't get that until py2.7
I guess that this need an explanation. Usually in this cases I guess that $attributes replace or ignore the value of $this->attributes, so I think that is good explain that the $arguments provided are merged with the arguments already setted.
`$this->count` states it is an integer... otherwise, change its signature (same check tbd for other instance properties)
Fixed, thanks :) Wonder if this could go into 2.0 because we really need that.
If you decide move it to the suggest section then add it too to require-dev
WOAAAAH WHA'S GOIN' ON HERE WITH THAT ";" SON?!
Maybe it's time to have an abstract AysncCallbackImpl
Again, why the rename?
Haha, no problem :P It happens to everyone of us.
@spicyj I don't think eater does, he does it all within stable or something.
Not a big fan of `extract()`. It makes code harder to read.
Even though this is correct I would prefer
```java
CraftingTableInventory inventory = new CraftingTableInventory();
inventory.open((VanillaPlayer) controller);
```
missing spaces after ``if`` and before ``{``
you should remove this empty ``@return`` if the method does not return anything, and fix it otherwise
the indentation should use spaces, not tabs
`$trashedChildren` can now be removed from this method, it's not used anywhere else.
Copy&paste ftw! =) (removed now)
I believe that was legacy from vim. I'll remove it, but I had left it originally since I thought it was there originally and didn't want to introduce a lot of ws noise. Apparently, I mis-remembered.
Please add specs for this new class.
Why was it necessary to add this?
we don't need this import.
You can't filter over users this way. Whats the harm in adding an extra field for every group of items?
We are doing that because at present we only have 1 non_vouched user to search. Because of the new code in the search view we would be automatically re-directed to their profile. Therefore we add a new un-vouched user so that we actually get a search results page :)
Shouldn't this be a heading?
s/config/configuration/
environment is spelled wrong here
@abenari any feedback?
I think my question was, can't we simply verify that its https in the first place? why do we actually need to post to the server?
Should perhaps not be named "get", as two invocations don't return the same object, but rather create new objects. newEventBuilder() perhaps?
I think using what I pasted is best. That's what I'm pretty sure is in most of the exercises.
What happens if I configure a projection with a particular alias at a specific internal path, fire up the repository, shut down the repository, change the internal path to a different location, and then start up the repository again? IIUC, the `projectionExists(...)` method does check the projected node key (which IIRC is the internal path), and the projection will be updated. Is that right? But does the projection still exist at the old location?
Damn it Xcode! Why can't you just work?
Hi! Looks like you are correct. The BYHOUR rule is a bit 'weird' anyway in combination with FREQ=HOURLY. The more logical rule would be a BYDAY rule along with an HOURLY.. 

This makes me feel that it may even be better to (for the moment) not support BYHOUR for FREQ=HOURLY, but only for FREQ=DAILY.

Specifically because this opens the possibility of a never-ending loop.. So far I don't think I have implemented any BYx rules for FREQ=x..
Wouldn't an explicit cast easier to understand?
подумай над вариантом, когда пользователь сам создает снаружи, а не передает создаватель
не нужно. сам делает
this appears to have the Final Destination 5 filename, but I don't know the name of the actual file.

please fix and merge :D
Perhaps in the test, but the `search_for` method only needs to use one. If you want to test sending a return key (rather than a submit) then you should do this directly in the specific test.
Wouldn't this be better as an initial assert False so we fail earlier? I'm not a fan of logic in tests.
this should be `header.is_login_link_visible`
should be `throw $e;`
Oh, right.
I 'm not intending to check out git and everything. I installed this and dapper and found that dapper was what I needed, so I uninstalled this.
But I noticed the typos in the docs and thought I might as well fix them quickly online on github.
I believe this route is unnecessary, since the facts app already handles the case where you give it a fact.
Why does `query-execution-limit` need to be an integer?
I see you've added the module logging in this block (re: logging). Would be good if you could log the error here if there as well, if there was one.

```javascript
if (err) {
    log().error({err: err}, 'Error initializing module %s', module);
    return callback(err);
}

log().info('%s has initialized', module);
initModule();
```
Local storage shouldn't be used in production. It is however compatible with a mounted NFS path.
There is a comment in the local storage backend which addresses this.

I think we'll probably be running with the S3 storage. If I got it right you should be able to configure a bucket per tenant in the config UI which allows for separation of the files on a per-tenant basis.
This should probably be an array. I'm not sure the `true`s do anything
An array is created using `array()`
`req.accepts()` with a single string should arguably be removed, since it can't work with Accept's natural or qvalue ordering
Why are you doing the namespaced name here?
Ah nee. `spawn` is logischer.
геттер - когда мы читаем значение, сеттер - когда записываем. 
в принципе, в твоем случае в части self.DNA vs _DNA разницы практически нет - ты не делал свойство DNA readonly и не защищал его от модификации извне (не переписывал геттер, чтобы он возвращал неизменяемый массив). Если бы ты это сделал - у тебя self.DNA вернул бы не NSMutableArray, а NSArray, который не имеет ни insertObject: atIndex:, ни addObject. Так что здесь выигрышь только от мизерной экономии процессорного времени - не нужно вызывать геттер и возвращаться из него. Но я в комментарии выше акцент делал не столько на _DNA вместо self.DNA, сколько на addObject: вместо insertObject: atIndex: - опять же, он быстрее выполняется, поскольку ему не надо искать индекс i и он просто добавляет объект в конец массива
Could you change this to something more generic: username@tests.example.com (for instance). Also, should we have these settings commented out per default?

I'd also introduce a global flag which makes these configs used or not. I.e. if AUTOMATED_TESTS_ENGINE_ON = true then all of the configs below need to be configured. Otherwise, they can stay commented out.
While you're in here, would you mind replacing 1.8.1 in the repo with 1.8.2 and updating all of the other test suites? You could do it in a separate PR if you like or just add to this one.
This could actually be made more concise:

`localItem = !localItem ? {} : JSON.parse(localItem);`
Typo: should be `events can be scheduled`
Collapsed comment here:

----

What if it set up the timer on a global concurrent queue, but automatically `deliverOn:`'d to the `RACScheduler` on which the subscription occurred?

In other words, this would keep delivery on the main thread when `+interval:` is called from there, but allows you to customize that through the use of `subscribeOn:`.

If we do this, we should document it very clearly.
Sorry, I overlooked this. Could you move this type to the main `LibGit2Sharp` namespace?
I think these are \t chars (and should instead be ' ')
The method name `resolve_shake_id` is pretty clear, so I would omit this comment.
I guess if we'd have to hack things anyway it would be better to just replace it. Reachability in its original form was only intended as demonstration code...
For your knowledge, you can use response.json(filteredNewsresult) to replace the above two lines.
no surrounding ======= lines here?
yes, it is a replacement for ``_form_is_choice_selected(form, choice)``
Yep, that's right - we're actually only need a few specific components, but of course we're not teaching Composer or those finer details, so I like how you've bright in `symfony/symfony` via Composer.
当使用的负载均衡方法不是默认的轮转法时，必须在<literal>keepalive</literal> 指令之前配置。
Also, can you unit test these changes in test/geometry_test.rb?
Sorry about that - came along in the copy and paste I did from the reference docs. ( I'm not a Ruby coder :) )

You're right that the verification should not be skipped. Have now changed the pull request.
The `be` is completely optional, to make it read nicer (see [here](http://chaijs.com/api/bdd/#language chains)). If you want I'll remove it.
many ways to be wrong; try

```
e = A*B - B*A
assert expand(e) == e
```

etc... for any other `!=` assertions.
This was for the emoticon fix so ;) or ;D or ;P won't trigger the bot as an invalid command
Por poner algo, quería verificar si se estaba aplicando la transformación.
Can't work with two vector sources on the same page...

You can generate a hash with the name the columns for instance and Maybe add an ID attribute to this source.
You are using a String concatenation inside a StringBuilder append. Performance wise it would be better to also use append here instead of the "+".
Can't you use `mapController.setZoom(Math.min(mapzoom, maxZoomLevel));` here?
Thanks for making changes!
Instead of `cons`, you just need the `concat`:
~~~clojure
;...
(concat (repeat times what) (un-frequencies (rest a-map)))
;...
~~~
I knew you were going to ask this.
This affects builders with inheritance: suppose I have builder A with method x():
A x() {
return this;
}

and B inherits from A with a method y() I wouldn't be able to do:

B.x().y()

because x() returns A which knows nothing about B's methods.
Fair enough, @belaban and Erik Salter had the same suggestion. I've rolledback to the standard scheme in which site backup information is inherited.
I need it in StateTransferConfigurationBuilder.read(..). This is analogous to fetchInMemoryState / originalFetchInMemoryState.
Wow, excellent! <sheepishly> How do I get cache members? </sheepishly>
Should probably be using `lookupObjectBySha:objectType:error:` here.
In predominantly Objective-C code, C functions are usually named with camelcase. Something like `cloneProgressCallback` might be more appropriate here.
intention seems off
As part of this exception message, I would include what value was unknown.
As a side comment I never really had any great success with adding options into testing methods like this. It seems right to make it customisable but in practice you always just end up using the one set of combinations what feels like 99% of the time!
I saw those locally too but only the camera tests, which are failing for me due to a blank screen. It's not the data_layer that's missing, it's the JavaScript it references. I can take a closer look later today.
вот тут можно написать usage, например.
I know we're taking about the namespace and not the class, but it makes no sense, and is quite confusing if we mandate that you must have CamelCasedClasses even for acronyms like `SqlFactory` and then have a free for all on namespaces. It's inconsistent and therefor ugly. We should set an example by naming it `Psr`.
@gsilver We need a space after `__MSG__HAS__`, as you're doing everywhere else.
triple equality operators
@gsilver Don't we need a gradient here?
Out of curiosity, what's up with all the ƒÂ additions?