labofsahil/github-event-dataset-2012 huggingface dataset:
@apex13 Yep that makes sense, just wondering.
Mno, eště pak úplně nechápu, proč jsi přesunul nastavení toho timeru ze schedule (void) sem. Stálo mě to chvíli debugování, než jsem našel, proč mi to po volání schedule sice naplánuje další vlákno, ale pak už žádný..:D
Can we specify category IDs as well as names? 
Category name isn't unique, where ID is
Hrm, it would be nice to eventually use a slab or something instead of allocating 4K on the stack here.
This `isArray` is Array check method discovered by David Flanagan & Mark Miller. And it is guaranteed that this method can check Array properly by [ES5.1 spec](http://ecma-international.org/ecma-262/5.1/#sec-15.2.4.2).
Constructor check (or instanceof Array check) fails when target array comes from the other global (like iframe). It is why Array.isArray is introduced in ES5.1 spec.
Should the return type not be "array" instead of "string"?
Can you please translate these new messages into Japanese
This is more sociopathic:

    var uniqn = function() { var o_uniqn = uniqn; uniqn = function () { return 1 + o_uniqn(); }; return 1; }
@thradec, OK, thanks for trying.
if that's how it's done everywhere else I will go with that. adding commit...
It's a button title, so let's go for the verb :)
same here ;) `protected $output` is a better choice
Use `[]`.
minidom can parse directly from file descriptor, no need for first converting it to string and then parsing it.
Maybe also here import only module.
`debug` is probably unnecessary?
Please add TODOs we have elsewhere.
`settings1`? Please name a bit better.
Can you make model like it is defined [here](https://github.com/wlanslovenija/PiplMesh/issues/278).

So the idea is that you have a list/map of enabled plugins. So anything which is in user object is enabled. Not that you have a flag. There is no reason to have a flag. User adds a panel or removes it. This is it.
Access token is permanent, unless user manually removes it in her settings.
But I'm having some problems with authentication. I don't want our users to authorize our application everytime they go to login view, but I can't see how this works for facebook authentication.
Why GMF_RANDOM_SEED/GROUND_MOTION_CORRELATION/NUMBER_OF_SEISMICITY_HISTORIES are being removed?
Yes. See for yourself: look at the lines I removed.
md5 is truncated here (`brew audit` will warn about this).
Agreed, was lazy.. Want to pull then out or I will and resubmit

Sent from my Windows Phone
________________________________
From: Brendan Forster
Sent: 17/02/2012 04:32
To: Jake Ginnivan
Subject: Re: [carnac] Breaking logic apart, working on testability (#13)

> +                var p = Process.GetProcessById(Convert.ToInt32(processID));
> +                processes.Add(handle, p);
> +                process = p;
> +            }
> +            else
> +                process = processes[handle];
> +
> +            return new KeyPress(process, interceptKeyEventArgs);
> +        }
> +    }
> +
> +    public interface IKeyProvider :IObservable<KeyPress>
> +    {
> +    }
> +
> +    public class KeyPress

Can we get this as one class per file? I'm probably being picky, but 90% of the time it makes to easier to find a specific class.

---
Reply to this email directly or view it on GitHub:
https://github.com/Code52/carnac/pull/13/files#r459146
Note to self: Too much java can damage your C++ standards...
For any question "why": this hides gpreciseVectorData global variable.
Ich glaub sonst haben wir ein Padding von 10dp?
reference to the example!?
Oh yes, sorry. At least that's clearer now.
this line may not be necessary-- you could remove and run `mvn help:effective-pom` to see if it's picked up from parent pom.
yup that's right, we've to validate options along with the name
Later in the code you concatenate title with an other string, that will cast title to a string, so if win.title is null it will add the string "null"? I think it's safer to set here title to the empty string in that case instead.
We always say `Tooltips? without defining that as `window.Tooltips` first, right? Not really consequent.
Passing arguments to a bounced/throttled function is tricky: which set of arguments do you pass to the method when there have been 10.000 attempts to execute it while it was throttled ?

Throttled methods are argument-les, and should use a state/context variable of their scope.

I'll add a comment about this.
`s/res_id/id` then. The code is semantically equivalent (well, almost. This is also assuming `id` can't be `0`). But do what you want. :)
Good point, thx. Will change this.
line 277 in GLS.whiten now doesn't take short cut anymore, I guess
<b> is undeprecated in HTML5 for "content without conveying any extra emphasis or importance, and for which the conventional typographic presentation is bold text" [http://dev.w3.org/html5/markup/b.html]. Author may have intended such use, but in that case the document should be brought up to HTML5 spec.
I'm not sure I like the interface here.
```
cf = image.getCorrFunc()
```
Doesn't read like it's creating a CorrFunc using the given image as the definition.  It seems more like you would get the correlation function of the noise present in the image.

I'd rather just have people write:
```
cf = CorrFunc(image)
```
To me, this reads more like what it is actually doing.
Again, probably worth testing something other than E == B here.  And I'd suggest not using pkflat for this test, since that could probably hide a lot of stuff.  If things change about how the k values are referenced or things like that, this test might not notice.
We only "need" them in Demo.py because you and I put them there.  And we only put them there because they were easy outputs from the HSM code.

You can certainly change what Demo.py reports from the HSM measurements to be just e1,e2,sigma.  Then you can remove the getM* methods.  I think it's fine to consider the M values an "implementation detail" about how the code determines e1,e2,sigma that we don't expose in the public interface.
Can you wrap this?
If this is legacy (i.e. deprecated) then could log.warn about its use.
LocalStorage perhaps? </nitpick>
@octatone: Any object may implement `[[Call]]`. Your logic is just... wrong. Here it is, more formalised:

 * All functions are callable.
 * For all callable objects `x`, `typeof x` produces "function".
 * `typeof y` produces "function".
 * Therefore, `y` is a function.

Don't you see how your logic is wrong?


    +---------------------------------+
    |   Callable objects              |
    |          +-----------------+    |
    |          |  Functions      |    |
    |          +-----------------+    |
    +---------------------------------+

The proper test for a [method](http://es5.github.com/#x4.3.27) (both in es5 and apparently in underscore) is for [functions](http://es5.github.com/#x4.3.24), which would be a test for a `[[Class]]` of `"Function"`. If you still don't believe me, just take my word for it and change it back. Trust me.
That's what I mean when I said change the test ;)
Doc comment for return value
Would then be replaced by `if chebcoeff is not None:`
Hm, Han zerscht gwechslet wil i en abstract brucha. Denn hani gmerkt dassi glich an eigni Umgebig brucha, wil i zwei abstracts ha muass.
Chama vo miar us au wieder zrug wechsla, wobi denn mini /*matter Befehl überschriba werdend.
That's good rationale. Makes sense.
Make sense. Done!
哦，多谢。我基础太差了 呵呵

--  
Yang Wen


On Tuesday, October 30, 2012 at 11:19 AM, tengcong wrote:

> In app/controllers/memberships_controller.rb:
> > def create > - @event = Event.find(params[:membership][:event_id]) > - @event.memberships.create!(member_id: current_user.id) > + event = Event.find(params[:membership][:event_id])  
> 这里的event不需要到view 展示吧？如果不需要，不需要声明instance variables
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/beijing-rubyist/bjrubyist/pull/9/files#r1974840).  
>  
>  
>
One other thing, .find('ul') could find sub-sub menus, although there aren't currently any being using in the main navigation.
OK, scrolling down further reveals one big i18n file and the split ones. What are the advantages of one over the other, and what does upstream recommend/whats the best practice?
I just investigated it, eval seems to cause the method to be defined in the Galaxy::Base, not the concreate Galaxy class.

Here is how I debug this issue, I modified the method has_many to be (just added some puts):

```ruby
    def self.has_many(model)
      p "="*120
      p model
      puts "before eval"
      p Galaxy::Base.method_defined? :locations
      p self.method_defined? :locations
      model = model.to_s
      eval(%Q[def #{model.pluralize}(params={})
                @#{model.pluralize} ||= model_for(:#{model.singularize}).find(:all, :from => "/\#{self.class.path}/#{self.to_s.demodulize.underscore.pluralize}/\#{self.id}/#{model.pluralize}.json", :params => params)
              end
        ])
      p "after eval"
      p Galaxy::Base.method_defined? :locations
      p self.method_defined? :locations
      p "="*120
    end
```

in chase-consumer-web, just start rails console, following output can be captured:

```bash
====================
Galaxy::Deal
:locations
before eval
false
false
"after eval"
true
true
====================
====================
Galaxy::Merchant
:locations
before eval
true
true
"after eval"
true
true
====================
====================
Galaxy::Purchase
:coupons
before eval
true
true
"after eval"
true
true
====================
... ...
```

It shows the locations method has already been defined before we want to eval again in Galaxy::Merchant.  After changed the eval to class_eval in the implementation code above, the output changed to:

```bash
====================
Galaxy::Deal
:locations
before eval
false
false
"after eval"
false
true
====================
====================
Galaxy::Merchant
:locations
before eval
false
false
"after eval"
false
true
====================
====================
Galaxy::Purchase
:coupons
before eval
false
false
"after eval"
false
false
====================
... ...
```

which shows the locations method has been defined in the right context.
The only difference I can tell in the behavior is that the new version can possibly fail with a NoMethodError for calling #map on nil when attributes is something like ```{:some_resource_name => nil}```

My brain is kind of fried at the moment though, so maybe I'm missing something.
@demandchain test
А, я неправильно понял тест. Если исключения быть не должно - ничего не надо делать. Если произойдёт исключение - тест сам упадётю.
Ошибка вот в этом месте. Даже если поле публичное, если оно находится в недоступном классе (а у тебя оно доступно, потому что находятся в одном пакете), то get сделать нельзя.
BTW this is UNSUPPORTED.
Double underline on link ?
easier to read and (should be) faster
Doesn't say anything like that in the paper as far as I can tell and I think I observed divergence in practice.
Could be that it is possible to converge if you decay the learning rate fast enough but that doesn't mean that you converge to a point that is better than the point you started with, only that you stop somewhere.
you forgot to pass ``sample_weight`` - tests do not pass
This would be `comment=()` as the comment has been splited into lines at this point.
Indeed I missed that line. I read too fast...
The comment would be -> "Fixes disabling dbus on soprano when using BUILD_DBUS_SUPPORT=false"
Since I did a fork/edit from within github I cannot patch the formula, should I close the pull request an create a new one
Put all of these in the initialization list.
Is there a Jira associated with that TODO?  Otherwise what's preventing this from being done as part of this patch?  If there's a reason to do it separately, then let's make sure there is a jira tracking that
The compiler doesn't allow namespaces to be forwarded, e.g. class bb::cascades::Container; is illegal
As the api doc specifically has the param for textAlign be the constants you defined as Numbers, parsing string is not needed.  Please revert the changes from ver5.
bb should be above bps
I'm not sure if it's your change or just trace of old commits,
but unfortunately you cannot use references here.

The trap here is that when you assign a value to `&$line` PHP will **NOT** call `Text::offsetSet($index, $value)`
That method ensures using objects for lines.
If you assign value to `&$line`, then `$text[$no]` value will get `preg_replace()` result, i.e. a string.

Therefore you must either assign an object or use `[$no]`.
**Assigning to reference is not recommended.**
Too many "name" in one line. I'm getting confused
Is it possible to quote terminators?  If so I supect the ESCAPE case should get the nextMatch, and the escape code shouldn't be in QUOTE/SEPARATEOR
This looks tonnes better!  I haven't gone through with a fine grain comb, but I like the looks of it.

Can you add a header like this? http://www.haskell.org/haskellwiki/Programming_guidelines#File_Format

Let me know when you feel good about it and I'll merge it back upstream.
If they're `None` should it really become part of the query string?

Ie. if `foo==None` and you turn that into `&foo=` you have converted it (on the next request) from `None` to an empty string `''` which is different.
d5f2f3a5cdef0240d1a737b2def3b536d8df7e1e causes doStart() to start the client.
It's better to name slot on_addButton_clicked() and remove this line
Yes I thik that is correct. Do you move them?
Häiritseekö If-lausekkeet ilman sulkuja? :D
Do you mean to have something like this ?

```js

var TestScene = cc.Scene.extend({
    ctor:function (bPortrait) {
        cc.associateWithNative( this, cc.Scene );
        this.super();    // <-- Add this line ?
    },
```

But as I mentioned before, we can't call `super` on `ctor` in JSB, because it will crash.
Good to see tightening up. We also shouldn't be hard-coding domains anywhere - those should be derived from the current calcentral.properties or some other local settings file, yes?
This definition ends in the top-level, which was probably not wanted. You want to define this in a `let`.
Please remove this.  When it's empty, then you don't really need it.
@todb-r7 : This should never be a file separator. It's a *module* separator, which is always "/"
it could be in the form domain.network.tld etc, I'd would rather the user is kept aware and in control of whats processing rather than having something magically fixed for them.
changed to 127.0.0.1
we could randomize this ip for all I know, but it might have untested side affects.
I just realized that we may be shooting ourselves in the foot here.  What if you want to construct an inverse transform, and then provide it as the reverse map?  (Which is perfectly legal, since tform(...) can be called).

Shall we change this, and simply apply whichever tform is provided?

I.e., ``inverse_map=tform`` or ``inverse_map=tform.inverse``
As you can see in my most recent commit I added support for intensity images.
Shouldn't `toBeIn` use reference equality?  That makes more sense to me and it looks like that's what the old version was doing.  Then again, it's only used in one test, `MeshFiltersSpec/creates attribute indices` and that test looks a little odd to begin with.
Two me they mean the same thing (in 2D) but I could be wrong.  I can change the wording but can you explain the difference to me?
I think there is a faster way to create regular expressions than `new RegExp`.  @mramato?
Shouldn't this require in `Core/FAR`?  We use `500000000.0;` in several places, it should at least be a constant somewhere.  @pjcozzi ?
And yes, passing an array into update instead of returning one would be all-around better for performance if we are OK with the resulting API enough.
can you explain to me why this seems to be a refactoring nightmare?
I am trying to understand the situation you are experiencing. 

Some I am wondering If we have something like this:
- function A(...) {
    var self     = { dragMove: ..., dragEnd:....};
    var other  = Other(....);
    // Note: only one will be return, e.g., either self or other.
    // either this (call X case)
    $.extend(self, other);
    // or (call Y case)
    $.extend(other, self);
    return .....
  }

if use case X, means that the methods of Other are copied to the self object. Therefore, methods that appear in both objects will be affected: the self's methods will be overriden with the methods of Other, right?

If use case Y, then the other's methods will be overriden with the self's methods, right?

then my question is, if we do case Y, would this solve your problem? especially since what you are trying to do is provide a different implementation of the methods in DraggingHandler.
How should I code it to protect against this?

From: Opie Cyrus <notifications@github.com<mailto:notifications@github.com>>
Reply-To: appcelerator/titanium_mobile <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Thu, 4 Oct 2012 09:14:23 -0700
To: appcelerator/titanium_mobile <titanium_mobile@noreply.github.com<mailto:titanium_mobile@noreply.github.com>>
Cc: Karl Rowley <krowley@appcelerator.com<mailto:krowley@appcelerator.com>>
Subject: Re: [titanium_mobile] [TIMOB-10458] Android: TableSection - header views are not sorted correc... (#3033)


In android/modules/ui/src/java/ti/modules/titanium/ui/widget/tableview/TiTableViewHeaderItem.java:

>       public void setRowData(Item item) {
>               if (!isHeaderView) {
>                       rowView.setRowData(item);
>               }
> +             else
> +             {
> +                     setHeaderData(item);
> +             }
> +     }
> +
> +     private void setHeaderData(Item item)
> +     {
> +             if (headerView != null && headerView.getChildren() != null && item != null &&


I am more concerned about the assumption that children array has >0 elements. If headerView is null then an exception will be thrown before we get to this point. headerView.getChildren().get(0) assumes there are children and checking for getChildren() != null just makes sure that the array itself is not null, not that it actually contains anything.

—
Reply to this email directly or view it on GitHub<https://github.com/appcelerator/titanium_mobile/pull/3033/files#r1763609>.
Cap? Not sure what this means.
This should be:

    logger.error(__('Invalid project ID %s', value) + '\n');
Now that this is a normal view, is special handling really still required for handleShow and handleHide?  It seems like it should go through the normal view lifecycle process now.  Most view proxies do not need to override these handleShow and handleHide methods.  Though maybe I'm missing something special about this view proxy?
These double blank lines are unusual compared to the other files.
Should we add a type attribute to this tag?
please use from external source or remove license header if it is our code
thats not how a @deprecated tag works.

See http://docs.oracle.com/javase/1.4.2/docs/guide/misc/deprecation/deprecated.html
It's the possessive. _The dog's bowl_ means the bowl belonging to the dog. Apostrophes are confusing because they're also used in contractions.
In this and some other lines there is a "1 px" statement. That's wrong, it needs to be "1px" without the space.
This is best name i could come up with
Impossible. It is used in many different `unittest`s.
Can rename to `__conv_EmplaceTest` and make `private` to avoid possible naming conflicts and disable access.
I forgot about the init property, thanks. I've renamed init to initialize now. It  should certainly *not* stay a constructor. When Random is not void, using such a constructor to construct a RandomSample instance would always result in a bug that this pull request fixes. If a function can not safely construct an instance of a type, it should not be a constructor.
I don't think that we normally do. If anything, the documentation goes to extra effort sometimes to _avoid_ stuff being highlighted (i.e. by prepending `_` to a symbol in its documentation when it's supposed to be the same word as the symbol but isn't actually a symbol - this happens semi-frequently with range). It's not the end of the world if you tag them, but I'd argue that it's better not to, particularly since I'm pretty sure that we normally don't.
Okay.  I'm deleting this file.  (The other duplicate tests seem to have been an inadvertent copy.)
> I did not remove it so far, because it gives a hint on what we rely on. If you really want to go all DRY we could remove it.
Cluster fields by type.
move into an own repo
still missing a comment of you on that one
Ok to remove this comment block?
Im  a little concerned about the parse order issues here. This defined statement will only work if the memcached class happens to be parsed before this line.

I would prefer something like:

Package<| title == 'memcached' |> -> Class['horizon']
Why did you want to move `isAdmin()` to the superclass?
This needs to be checked before we can merge. There are lots places that use this and none of them can break.
does pulse really run/need its own connection? why isn't it on the session bus?
Also, the $provider variable doesn't work when nothing is specified. The default I supplied of 'default' doesn't do what I had hoped. :( This is a block issue.
Doh!

This seems to do the trick, ya ?
```ruby
    mask_required = (iptables_version and Puppet::Util::Package.versioncmp(iptables_version, '1.4.1') >= 0) ? true : false
No hiera unless required.
`after` and `before` are required params
With 5.4 `<?= ?>` is always enabled. I think this classifies it to be allowed to.
Am I right when I say that position of the the inserterbar widget is currently relative the the complete document?

Can't we set it relative to something else instead? (e.g. the contentauthoringcontainer ?)
This would avoid having to set the `top` in JavaScript.

It would also be more future proof when somebody changes the height of the top navigation, branding widget, ...
Should be String | Array
@croby done in a follow up commit.
Will there ever be i18n keys in the content?
Yikes. I'll fix it. This is why I normall delete examples and copy them from their associated unittest block, but I guess that I didn't do that here.
Should not be part of the doc comment.
I think we use 4 white space soft tab, it seems this isn't the case here.
the indentation of this line appear to be incorrect, I believe the team uses 4 character soft tab.
Can we name this something like `:array-literal` or `:nsarray-literal` instead? The terms in this module should be Objective-C-specific.
This should be $this->getAllowLinker()
We don;t need MSUser.h, but need MSLoginViewController for a block type declaration from there.
Done for the hash in DI, but I don't find the advanced_configuration.rst file
@frsela here I delete the signature from the notification. Should we delete the "messageType" too? And then Gecko should be smart enough to catch this: "if I don't have a messageType, it's a notification".

I'd prefer to leave the messageType to be consistent…
se scrie `if not field.optional`
Oh I understand, the native packager needs java to run. Those are included with the NDK.
yup way more interesting now!
Do we even need authtoken/urls.py then?
Would probably rather see this implemented in the same style as the other mixins/views.
Ie. A mixin class that defines a `redirect` method, then a view that binds all the relevant methods to `redirect`.
next button should be disabled 
-when user enter a date in future for one of the date filtes 
- when start date is ahead of end date
the newCorpus function is now in the Corpus and out of the views.
What is the reason for going via the current table here? Couldn't we save that read by just doing:

    @elements = OldNode.where(:id => params[:id]).order(:version)

Possibly even dropping the order and adding it where `@elements` is used if a sort is needed, bearing in mind that by the magic of AREL the query isn't really run until the elements of the result are accessed.
Missing a space after the > here.
классы с Большой буквы
If the only valid values are "true" or "false", why not just allow the boolean values true and false? It's easy to type cast and this makes life easier for the user. It also allows the user to use the values of 0 and 1, which shortens code which should be the goal of every webdev,
It looks like you've reversed the meaning of this.
Logging out and logging back in resulted in the cached value being used for decryption, thereby throwing exceptions. This needs to be reset upon logout.
I'm a fan of multiple lines here too - mostly because that's the default StyleCop/SourceAnalysis setting and then everything looks delightfully uniform.
This can be shortened to #fff. FYI the way this works is that given a color #ABC, it is expanded to #AABBCC.
There is a describe block with the same title just above this one, is there any reason why you want these specs in their own?
Please type the variable :  `setParams(array $params)`
I don't think we can make any promises about what happens with pointer arithmetic. In C, it's undefined behaviour, and there are plenty of systems where pointers don't behave like integers. There are even systems which will generate hardware traps when assigning an invalid value to a pointer register.