labofsahil/github-event-dataset-2012 huggingface dataset:
Looks good -- my only suggestion is to include the ID of the code list in the function documentation for getters/setters that relate to a specific ONIX field.
Yeah my motivation was to define *temloadall* similarly to *temload*
-- see the next commit http://github.com/nex3/arc/commit/bd234365c8

I wasn't too concerned about reading a sym like *eof* because there's
no way writing a template can ever store a sym, and that's usually all
we care about reading..

But you're right, it's not ideal. I tried to come up with a definition
that didn't have a hardcoded constant like *'eof*, but I want to be
able to read templates written by other sessions. Wait, that's not
right. I can use a gensym and it'll work fine because the gensym's
never actually written. Ok, I'll fix that.

It still won't fully address your concern, though. There's still the
minor theoretical chance that I'd try to read a sym like eof39. I'd
rather leave this hole and simplify temloadall, waiting on proper
interned gensyms to plug the hole.
right. i will merge your new pull request and suspect that fixes these inconsistencies does it?
yeah, thanks. fixed
Why yes, how silly of me.  Go with this instead:

    return Math.min.apply(null, this.values);

Likewise, for `max`:

    return Math.max.apply(null, this.values);
Still fewer Loc:

def receive = Actor.emptyBehavior
def unhandled(msg: Any): Unit = log.error("/system/cluster can not respond to messages - received [{}]", unknown)
@pjweisberg — maybe open a ticket for that?
This is actually incorrect, it should be on separate lines (even though it looks stupid).
`tagName != 'input'` -> `tagName !== 'label'`
Ха-ха )))
One thing to note, I don't know how channel/connection failures are handled in the newer versions.
@jamescasbon while I appreciate the thought could we please not do this again :-) -- it's borked all my indentation (pure vim indentation on JS is often not what one wants)
Thanks,

1. static lookup is nice way of dealing with context injection to custom classes, but I would avoid it in JSF resources if it isn't specified it is available on that place. It just avoids regressions.

2. accessing FacesContext.getApplication().getProjectStage() should not get any extra overhead here.

3. accesing FacesContext.getCurrentInstance() may take some extra cycles (but since you did it in constructor, it doesn't apply here)
Would be good to have a log line that specifies that we chnaged the input target date from XXX -> XX because of such invoice with such targetDate
I'm still experimenting with my theme, i'm probably going to update it a bit. I found most things that people like to put in their powerlines for "beauty" are just a distraction. e.g. do i really need to know that it's a 'unix' filetype if that's all I work with? Toying with even throwing away the scroll percentage :)
Makes the current email functionality fail faster.
Hmm, that has sense. I like the solution with onclick handler, don't you mind?
inorite!
@solnic ok! I'd use `metric_fu` much more, but I'm writing application code almost exclusively for 1.9.{2,3} and waiting `ruby_parser` support for 1.9 syntax!
This feature clearly deserves a few separate tests.

These tests should sit under compiler/testData/psi for parsing, compiler/testData/diagnostics for type checking and compiler/testData/codegen for code generation.
on line 20, you override the id built-in (those things can get you into a lot of trouble...)
it should be "from pbs import id as id_command"
Eh, we should exit().
Oups sorry, you're right!

Le 7 févr. 2012 à 19:58, evert<reply@reply.github.com> a écrit :

> Don't worry, this is the 'php-51' branch.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/evert/SabreDAV/commit/3b8264b2c0993e546632beae52ab60f4a890a709#commitcomment-942224
FastUnwrap added, and Catch tails added to return task on a few methods
Nej, men det ligger på min att-göra-lista!
I end up here.
looks straightforward enough, only thing is that we do need the image-id property in the pom, as this is a generic computeservice thing
naja muss noch nicht die endversion sein. lese ich später nochmal drüber. war nur gerade dank meiner hauptseminararbeit im stoff xD
1.
Do you mean, repeat the lines topics and posts inside two if's and in one closure is for when it's private forum and the other is for the other case?
2.
Done.
This is custom-made for a specific nuget. Let's see what you need and change it appropriately. This task isn't called from anywhere, but is a useful sample for you.
not related to CPU cost. this value has  only 2 sences: "less then update diff" or "guaranteed less then update diff"
@tibbi, no problem if your remove old hack on whirlwind  :) this category correctly set cooldown on whirlwind (same category with bladestorm).
must work under win\bsd also. by solving high CPU usage - may be related, need test. but i not sure.
rechecked. work fully as intended - with this commit spelltab appears only with temporary pet, without - only with permanent. be reverted. check your code differs more accuracy, plz.
PS HNY!
@games chmod 777 /dirtoMangosbin/  P.E: /home/mangosR2/bin/
need a 'var' here to prevent putting CSSParser in the global scope
wow.Does this work? Don't we need a generic visit(ParseTree)?
Pfff te equivocastes Xd las creature text se usan para todo, bueno no se si para eai se podra usar. El caso si lo cambias a creature_text en vez de poner esas ids tan largas usaas SAY = 0, etcc por su group id ;)
Wow, you're fast! Thanks. I'll try blowing away my local .m2 repo to try and repro locally.
Herp nevermind
lol.  should i roll this repo back to 39cb6f3?
@jjhuff Looks like you created the pull request but did not resolve the ticket. http://tickets.opscode.com/browse/COOK-1047

I have set it to resoled so that it gets picked up at the next triage.
I agree, but I've never had the time or reason to be bothered to add one in.
вроде в django1.4 добавили тэг {% elif %}
Parentheses aren't needed. My personal preference is for:

if bsame_hyp_seg and not bsame_ref_seg

if bsame_ref_seg and not bsame_hyp_seg
WTF, dangerous?
It would be good to add ``os.environ.setdefault('DJANGO_SETTINGS_MODULE', setting)`` here, for other parts of Django
Alright, I pushed a hotfix up for that bug.  Hopefully it didn't affect too
many production Ronin applications, but you never know.

So, what's going on?  Are you no longer interested in Ronin or Gosu?  The
short, shitty comments were cute at first, but not really advancing the
ball.  If you are done with this shit (wouldn't blame you, Gosu is a hail
mary pass from a small insurance company) then let me know, and I'll stop
trying to involve you.

Cheers,
Carson

On Sun, Feb 5, 2012 at 7:02 PM, Carson Gross <carsongross@gmail.com> wrote:

> Great catch.  I'll write a test for it.
>
>
> On Sun, Feb 5, 2012 at 6:00 PM, kprevas <
> reply@reply.github.com
> > wrote:
>
>> "is not available"
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/carsongross/ronin/commit/155040afd73773b85846d09214034d6987d40ba4#commitcomment-935071
>>
>
>
I think Christophe committed that one. Mark

On Sat, Jan 14, 2012 at 11:36 AM, elinw <
reply@reply.github.com
> wrote:

> You forgot Brian Teeman.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/joomla/joomla-cms/commit/1de025c11e7429664e2b7887b4f8803e8467439f#commitcomment-867634
>
Please note that it is not enough to separate statements by ";".

For example, the code can be written (or optimized) as
```javascript
var a = require("a"), b = require("b), c = require("c").
```

A simple fix would be to add an extra line above:
```python
line = line.replace(",", ";")
```
where does this column ``min_app_version`` come fom? maybe add a specific table prefix
Change submitted https://github.com/t0mm13b/ics4blade/commit/5890f7b7bbf45ff0411d79db5eefceff1f35fdb1
Looks like this breaks in a few places: http://travis-ci.org/#!/UnionOfRAD/lithium/builds/717785 -- that'll need to get cleaned up before it goes to master. /cc @cgarvis
@campbellbasset remember to put these back
I was planning to do just that, but I didn't want to submit untested code. If you want me to send it anyway so you can test it yourself I can go ahead.
Note that I modified your code a little bit here, the printf is inside the loop, before the div.
This is really minor but avoid using objects when you can use a primitive in general.
Nice patch, but I would have to say that the simpler answer is to just remove the -V completely which is what I have done in 09b39381ecff895d4b3d6f340390ae71af727f2a
To clear this up, SensorKinect is not building with latest unstable from OpenNI.
You're totally right Andreas. I was trying to cut a corner and that's what I get for it. I'll quickly rewrite these formats to use the new readers structure instead.
I think we should clarify the precise semantics of this warning, both in the text of the warning and in the tests. There are two possible interpretations of it; I assumed one was correct based on the description, but it turns out the other is actually implemented.

The first interpretation is that `@extend A` warns if the selector `A` doesn't exist in the stylesheet. This protects against typos and reminds you if you have more selectors to update for placeholder selectors. However, it _wouldn't_ give a warning for `div {@extend .foo}` if the only use of `.foo` was in `span.foo { ... }`. 

The second interpretation is that `@extend A` warns if that particular `@extend` doesn't cause any new selectors to get generated. In addition to the protections given by the first interpretation, this provides the invariant that every `@extend` without the `!optional` flag is actually doing something. However, it also presents more opportunities for unintended errors. Imagine if a mixin containing `@extend .foo` were included in `div { ... }` when only `a.foo { ... }` was defined, for example.

I feel like the first interpretation encompasses all the cases where the user is clearly making a mistake in their use of `@extend`. Certainly `!optional` provides a backdoor for the second interpretation, but I think it's so broad that people will start feeling obligated to use `!optional` much more frequently than would be ideal. I'm open to being convinced otherwise, though.
I saw the @TODO but we shouldn't use cerr for user errors. 
That stream is meant to be used for internal errors (ex: errors with the compiler/parser/interpreter).
echo after add the file, genius
Please add parens for the condition, to make it easier to read.
I'll yank this in...
i see you updated the sql's ty :)
why are you changing the parameter from "text" to just "t" here? This has the potential to break other people's code since the parameter "text" is effectively part of the plugin's API.
1st note: all 3 supported dbs use a syntax WHERE xxx LIKE string ESCAPE 'char'.
I think that one bit is needed for Oracle (the ESCAPE 'char') to do the escaping at all, so I'd recommend to stick to its usage everywhere to make things more uniform, even in the mysql cluster handler

2nd note: this is even more important for the ezimagefile.php file, which creates one sql for all supported databases

3rd note: there seems to be weird issues in mysql when using \ as escape character for LIKE, when the strict mode NO_BACKSLASH_ESCAPES is on (see eg #20103). I'd recommend to use a different character instead of \ (one which is invalid in filenames, maybe | would do)
Just learn how to use git (for real, not through the GH interface). It's not that hard.
When JS is disabled, the default font is larger than expected and wraps badly. Needs white-space: nowrap
It may be duplicate code, but why not add a duplicate comment (or commit message - though that opportunity is past) indicating what physics absurdity it addresses (even if the way it addresses that absurdity is too absurd to describe).
http://pastebin.com/dFjcsRpB
Actually this won't matter to much right now because TYPE_SKARVALD_DALRONN isn't implemented in boss script.
In case it was, then this would have been an issue.
Is it really necessary to add a layout.css file? I guess it depends on personal preference but as the boilerplate uses style.css, I'm not sure if I want to add another css file?
This change causes a segfault.

```
ruby -Ilib:test -rubygems test/xml/test_document_fragment.rb -n test_for_libxml_in_context_fragment_parsing_bug_workaround
```

Previous code was clean under valgrind.
Yeah, that's exactly why we reverted. This was going to cause issues for ThemeRoller. Good eyes!
When the commit says "git status" I actually had put in "!!" but it got auto replaced via git. Weird.
Sorry, I may have misled you with my comment here; I simply meant you could do "from numpy.testing import raises"--the form was perfectly fine!
Suggest just logging it all to one file since you are timestamping everything anyways. perhaps in /documents/couchdb/log.txt files or something like that.
VOR RMI-Implementierung
Thanks, nice script :-)
I am not an admin of any project on Crowdin. I tried with the API key of Diogo for project "ankidroid-current" but it does not work, I guess I need the key for the most recent project... could you please add me as an admin (if that is even possible in Crowdin) or send me the key by email?
Cheers!
PS: Actually it was a CDATA syntax problem
Typo, "safe".
This is wrong from an ABC perspective, too. `init_scope_depth` hasn't been used for a long time, and the latest Adobe compilers just force `init_scope_depth` to 0.

All it's used for is:

    max_scope_change = max_scope_depth - init_scope_depth;
Wow thanks AGAIN Donghwan Kim. I've applied the patch to the 0.8.x branch, will merge in 0.9 after the 0.8.5 release later today.
This doesn't seem to make sense to me - all this patch does is allow for CPU1 to get hotplugged when the CPU is at 200 MHz - but at http://forum.xda-developers.com/showthread.php?t=1275513 you state that this is to be used with your screen state scaling patch - If the screen scaling patch is combined with the patch to disable hotplugging when the screen is off, CPU hotplugging at 200 MHz is still disabled.
Check my #4 out... I'm thinking there's a better way than brute force, but my initial assumptions aren't right
Hmm, the docstring references classes, so I guess this is not a regression thing. However, `OneClassSVM` also needs it, and I'm not sure how that should fit into the hierarchy. Should it be a `BaseDenseSVC`?
I'd prefer if this first tried councilroom, and then backed off to bggdl.square7.ch in the case of failure.

Imagine the councilroom machine was lost, I'd like to be able to just grab the code, run the update loop, and maybe a day later after it downloads and processes everything, have it all back up and running.
This function was moved to rule_mgr.c.
could you please correct also

    page-header

instead of

    page-haeder

in `bootstrap/docs/components` @line 1192?

sorry but I see that error in this very moment and at the same time you commit
Please review code.
Please rename to README.txt for consistency
Attempting to use the tabs blanks the overlay. I think a click handler that should not be firing, is firing.
If memory serves correctly, they're supposed to.  The quest for A-Me is to repair her and then escort her back to Marshal's Refuge.
Take a look at:
http://old.wowhead.com/quest=4243
http://old.wowhead.com/quest=4244
http://old.wowhead.com/quest=4245

The Thunderer next to her was... uh... 'sleeping' with her.  Heh.  It's how they were on retail. (She may still possibly be like that in Cata, not sure)
// getParameter applies quoting automatically
Should owner.tid be volatile ? And if it was would we not need this?
@Lineflyer There is no noticeable deadtime (on my phone).
ViewletBase.portal_url was deprecated, ViewletBase.site_url used instead.
I have better cp.sh now
Aren't you missing a " after the type on this line?
You can go even further in reducing the include in headers by using forward declarations.

For example, in MetaServer.hpp you only ever handle pointers (or references) to PacketLogger, so you don't need the definition of that class to be available. You can remove that header, and add a simple forward declaration just before the class, like this:

class PacketLogger;
`respond_with` will save you here too :)
insertion sort is designed for small sorts only. Anyone specifying both insertion and spill sort should be told to go back and read the manual. If you want to write a query that will work on any size dataset you absolutely should NOT use insertion.
It's a "JAM" packet. By calculating the index you can see that 13022 will be 91 or 0x5B. 0x5Bu is in the switch and it leads to that function.
0755, surely?
Rather, use nsIFile.createUnique
**Part** | **Points**
------------- | -------------
base | 1
**Total** | 1

```python
for i in range(1,101,2):
    oddnumbers.append(i)
```
Excellent usage of range().

```python
if odds == 0:
    only_even = True
```
is very kludge-y. Note that 0 is evaluated as False in an If statement. 

```python
num=raw_input("Count down from a mulitple of 3: ")
num=int(num)
while num%3 != 0:
    num=raw_input("Count down from a multiple of 3: ")
    num=int(num)
```
could be reduced to only:

```python
num = 1
while num%3 != 0:
    num=raw_input("Count down from a multiple of 3: ")
    num=int(num)
```
Btw += is used to add something to an array without discarding previous value where as := is used to discard value and set new one in makefiles.
There are overheads when using the method FlatteningParameterBag::all. This method attempts to convert to a structural view. Extra work for our  purpose
It works only inside threads.

I updated from your master branch and tested it.
http://i.imgur.com/kAwHp.png
Same problem :P
Just do @EventHandler
Yes, I guess you're right. I'll remove that section. After all there is no restriction from the BV perspective besides the restriction to static methods. Even that one is not strictly required, I've basically added it to be consistent with standard bean validation.
Heya
compile error
http://paste2.org/p/1927214
TC fixed that not merged yet
Yeah when I wrote that first part I misunderstood the implementation. ;-)

As for the second part, the way I would see it happening is that, you decide "okay what's necessary is a generic document.  i'll put the first part of that in with this pull request".  One of the motivations for moving to markdown docs was to minimise the distance between a feature's implementation and its documentation appearing.

It doesn't block the pull request, but as a general practise it would be nice to see docs coming along with new APIs.
look at ObsSubmissionElement: 199-202
I would if I could find commits for it, but good god man you have a ton of branches! Also, do you have Fascinate compiling, because I can't seem to make it work on our tree :(
Would you be better off with a try/except here?  Would that result in less overhead?
Best practice in entwine: Only add rules to a file which are namespaced to the specific area, otherwise we'll end up hunting side-effects through dozens of JS files. So $('.AssetAdmin #Form_filter'). Its not so relevant for ID-based selectors, but a good habit to get into. We shouldn't have many ID-based selectors anyway to keep code reuseable
you should require ``1.0.*`` to allow you to release bug fixes for the library without having to release the bundle again
at the same time
Thanks for the feedback.  To be clear what I'm attempting to do is allow for the retrieval of a public_url when all I have is a key (ie path to the file) without having to get the whole file.  The following for example the following works fine for AWS:

directory.files.new(:key => path).public_url

This however fails for Atmos saying there is no objectid.

When you said "previous transactions" it got me thinking perhaps I'm making changes in the wrong place and should be changing the new method on the Atmos::File class so it sets the objectid when a valid key is provided (ie a file that exists on the storage).  Let me know what you think.
(see above note on Request:: usage)
I'm not sure what there is to look into. This will _definitely_ calculate and change the `total` twice and fire the `totalChange` event twice. We should fix this now, and not wait until some future release.
I know what this means, but I think it is not very clear, and also not quite right.  AIUI, the options are:

````
Sparsity(single_map, ...)
````
````
Sparsity((single_rowmap, single_colmap), ...)
````
````
Sparsity(((first_rowmap, first_colmap), (second_rowmap, second_colmap), ...), ...)
````

i.e., there are no lists anywhere in sight (we're reserving that for blocked sparsities).

So maybe use some examples demonstrating what we mean?

We should make it clear that the "tuple of maps" should only be a pair thereof.
Double work, on the line above the address is returned in an option, use a pattern-match on the returned value.
Reading a sentence that starts with _The normal behavior of an Akka actor is to drop a message_ just gives bad vibes.

I would like the first sentence to to be flipped around to something like:

When an Akka actor is processing a message and and exception occurs, the normal behavior is for the actor to drop that message, and then continue with the next message after it has been restarted.
What's the difference between contiguous and compact?
Could also be expressed as

members.find(_.address == address).orElse(overview.unreachable.find(_.address == address)).getOrElse(Member(address, Removed))
This came from @viktorklang 's change to `Try`. Should it be NonFatal(e) or is that already taken care of in `recover`?
just one case would be enough
I'm pretty sure it's covered by the first doctest.
I've committed to this pull a fix to resolve the broken test.
If you have a good initial guess for the starting point, then bfgs will converge faster than simplex (fmin). However, in spherical harmonic models where one has only the coefficients of the spherical harmonics it is not so clear how to choose the starting point for bfgs. With the kernel method, we have a good starting guess for the peaks. 

How are the seeds chosen for models other than the localized kernels? 

The main reason I mentioned using fmin as the default is that it does not require a gradient. But now I see that bfgs will numerically calculate a gradient if one is not given.  Also, gradient based methods tend to be more sensitive to noise.

So, it probably doesn't matter which one is default, as long as we can choose which one to use : )
*Companion
this one worries me
This is different from how episode_number is set in the fill from PopulateObjectFromTag.
Agree - if sink code not correct (can't be paused/flushed/released) or functionality not provided false is safer. Will update. Same might be true for SoftResume() below.

Still no solutions offered for ALSA-based systems. Gnif can't repro and I'm guessing on ALSA fixes...if no solution found before betas I'll setup a Linux box or solicit a forum tester on that platform. Something's borked in that sink or kernal if we can't even pause output.
Zelfde bestand meerdere keren toegevoegd?
We should advertise that environment variables and `~` work.
I saw it, didn't agree with it though :p
Is this param used anywhere?
no need for all the mask/unmask/revert now
You should check the Interface here as well.
Maybe we want to add installation instructions from pypi or source here...
Makes sense. Using `delete fileFromPath[path]` is better, because of the execution cost of `undefined` (which in turn is caused by the fact that `undefined` can be a variable name).
This method (and all of those below) should short-circuit as well. I'll avoid duplicate comments for all the rest.
This should use `CFBridgingRelease` so that ARC takes ownership of the string.
=twitch twitch= Alright, but I don't think imposing a specific spacing/newline format is a good thing... as I've stated before, I don't like spacing my `if`'s... I don't think I've been told to do so on any other PR either. :\
Sure, no prob!
It's not really a GC, but we could do:

    throw new util.YieldIOException (cb) -> setTimeout(cb, 0)

which would at least hand control back to the UI thread for a tick, potentially triggering a JS engine GC.
Use of the STL is proscribed in Node.
Pet peeve: superfluous cast.
Because if you pass string into another string, you should use arguments for formater.
Well, this method is useless now, isn't it?
BTW, once a callback becomes not-NULL, it can never go back via trace_data_allocations().  It can only become None.
I can't parse "operation will be performed on result of operation on previous item."
Looks like idomatic JavaScript code. If you want to convert it to a boolean use

    define('TRAVIS_CI', (boolean) getenv('TRAVIS_PHP_VERSION'));
I think it is better to do var_dump($r) here and then have the string in the EXPECT. This way if $r is something else it is immediately seen in the test diff.
а, я понял, что оно делает. ок, пусть будет
Should ensure the value is a 6 char hex string?  `#123456`

http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#color-state-(type=color)
I think we can just kill this assertion together with the `lines` variable, it doesn't test anything important here.
Agreed on 1.9 hash syntax.
I hadn't thought about it, looks workable, thank you
NameError: uninitialized constant Rails ...

I guess we need this default argument to separate Rails from AR.
`test_requires_symbol_argument`?
don't know :) will change
An ellipses (triple-dot) should be sufficient?
I suggest that because `getOrElse` has type parameters, while the test below does not, and I wasn't sure whether `TypeApply` would match or not the `TypeTree` case. So at any rate, I'd check that the warning happens even when calling methods with (inferred) type parameters.
When could that happen?
OK, I totally got the wrong spot.  I meant to randomly sort the .args :)
We're still sorting, just in a different place.  So what's the point?  It doesn't make it more efficient.  If we used a frozenset() I could see the point, though I don't know if that would play well or not.
I am building this because I need to have permutations of arbitrary/unknown sized arrays.  Do we have permutations that are completely abstract?
On Tue, May 22, 2012 at 12:44 PM, Robert Martone
<reply@reply.github.com>
wrote:
>> +      /**
>> +       * Instance of Tip2
>> +       * @property Tip
>> +       * @type Object
>> +       * @private
>> +       */
>> +      var Tip2 = this,
>> +
>> +        /**
>> +         * Default configuration values for all Tip2 instances
>> +         * @property defaults
>> +         * @type Object
>> +         * @private
>> +         * @final
>> +         */
>> +        defaults = {
>
> defaults can go in the common instance scope with the rest of the constans
>


Fixed.


-- 
jimg at yojimg dot net
I suppose this should redirect to request.application_url instead.  (The application might not be available at /.)
Oh man, that's pretty bad. We should figure out how to sanitize them.

On Fri, Sep 14, 2012 at 11:30 AM, Sean Carr <notifications@github.com>wrote:

> In src/java/com/rapleaf/jack/AbstractDatabaseModel.java:
>
> > @@ -533,8 +533,26 @@ public boolean deleteAll() throws IOException {
> >
> >    @Override
> >    public Set<T> findAll(String conditions) throws IOException {
> > -    PreparedStatement stmt = conn.getPreparedStatement("SELECT * FROM "
> > -        + getTableName() + " WHERE " + conditions + ";");
> > +    return findAll(conditions, null, null);
> > +  }
> > +
> > +  @Override
> > +  public Set<T> findAll(String conditions, int limit) throws IOException {
> > +    return findAll(conditions, null, limit);
> > +  }
> > +
> > +  @Override
> > +  public Set<T> findAll(String conditions, String orderBy, Integer limit) throws IOException {
>
> It already was just as susceptible to SQL injection via the conditions
> string so from my perspective the requirements of the interface still
> remain that all input must be pre-sanitized.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Rapleaf/jack/pull/52/files#r1610375>.
>
>
I think this name is confusing. I kept thinking this method was going to be a rewrite of assert_raises (which already tells you whether a callable raises a particular exception :)).

How about something like assert_raises_and_passes_filter or assert_raises_and_satisfies_test?
You mean this: https://github.com/igrigorik/em-synchrony ?
You're allowed to cheat here: `(uv_close_cb) free`
The future.get() calls are going to end up serializing the cache gets and potentially slow things down.  We'll have to be careful about this and potentially rejigger things to work with bulk gets, but this is good for now.  This is more a comment for commentings sake.
omit or rework parenthicals
it's in it's own directory so you can symlink or use the dir as a mount point for a distinct device, which is our solution for this kind of problem (i.e. directoryperdb)
indent this entire thing after the condition?
v2 looks to be missing from the license line.
Should this not be $db->sql_query_limit?
How would you create new types in extensions then? Are you able to add services in an extension?
unique is wrong here, anyone can upload the same image.

Something like "Gravatar is a service that lets you use one image as avatar everywhere and requires only one update at gravatar.com to update it everywhere." would be more correct and point out the use of it.
This filw should be split up into phpbb_template the way to access the template engine and parts which are really style related. Then one should use the other and provide the backward compatible interface. But the template engine in includes/template should be usable without the phpBB style system.
leaking pid to the global namespace, needs to be:

    local pid = data
It is unlikely that we are going to include a version in the update packet. We should do it the same way that we the check_schedule.

e.g.

to notify an agent the endpoint says `bundle_update.available` and `binary_update.available` then the agent does `bundle_update.get_version` or `binary_update.get_version`. Then after we get the version we fetch it from the URL.

@rphillips thoughts?
Agree. Do you propose to make a separate func for this?
There are several `System` prefixes that can be removed
> would you mind sharing again your timing scriptie? I will do it

https://gist.github.com/3151187
might be good to at least comment "which kind of UUID" in a comment. I think this is a concept uuid (rather than a concept name uuid, for example)
On second thought...you won't be creating a patient anywhere else in CHW, will you? If not, this is fine where it is.
https://raxaemr.atlassian.net/browse/RAXAJSS-316
I could be mistaken, but I'm pretty sure these are required for some reason. I remember taking them out and getting some errors.
I understand the intent of diverging and giving the user the option to install using a package manager or source, but I do have a problem with the way the original recipe does it. 

Namely, I have a problem installing ant-contrib and ivy. One is an optional Ant Library and the other is a separate build tool from Ant.
Yeah, I can read that one in ~2 seconds... improvement :-)

> In case it's not obvious from the tone of my last comment

Your tone was fine, it came through loud and clear. ;-)
This wont work just yet. Additionally, I wonder if the trailing slash is important?
I balked a little at the ZeroType, since it wasn't clear what values should satisfy filter. Would you consider an op instead?  E.g. `grad_dict[var] = GenericZero(var.type)()`
the other changes look great
Oh, please, I forgot to repair the approach here in the same manner as line 52-53 in the same commit
then you should be able to remove [0] from django/contrib/gis/db/backends/oracle/operations.py  too (just so we stay consistent)
Yes, you're correct. Will change.
Right! I did't figure out how to exclude Makefile when doing the pull request :)
oh, right. Change the comments in both c45.sql_in and rf.sql_in.
Yeah. That was my intention. Fixed below
Mhm, the bling factor is important here. I like it as is :-)
This method is now indented an additional level.
Yes, that is exactly what it is for. I'll add a comment.
Would you group this together with the cmake and gnutls depends if there's not a compelling reason otherwise? Thx
Technically (and I should have put a note in about this), we should be doing it on remove instead of change.  But since `message.removed` just has the ID #s, changed was the best thing I can think of.  New items should be fine; they shouldn't be in the cache and that's why I'm not checking `message.added` in this method.
Not sure how that would be simpler since we need to do slicing after the sort?
I think we need some more extensive tests on the JS side, but I'm not sure if this is an appropriate place for them.
TODOs are more helpful if we actually do them  :)
[IBM docs on Fixed width files](http://publib.boulder.ibm.com/infocenter/dmndhelp/v6r1mx/index.jsp?topic=/com.ibm.wbit.612.help.config.doc/topics/rfixwidth.html) show examples using `~` as a pad character. I've no idea how common this might be, though.
We shouldn't commit configuration yaml that has environment specific info, you should commit a template that has example values. Not real values, then add Sakai/CLE-IT/config/*.yaml to the ignore list
@arcade You should be careful when reducing the indentation level. In this case the "return" statement will break the functionality. Use "continue".
This isn't actually true since this is an async method. Also, I think we agreed to try and transition to a promised based API for the majority of our code, and this would have been a good time to do this for the session store since we now control both the store and the middleware.
Why don't you use forEachSeries? This makes doing this a lot cleaner. That way you don't have to build an array with function calls, but can apply a function for each item in an array.

This is what I came up on my own. It is Coffeescript, but very easy to write in Javascript, too:

```coffeescript
iterator = (item, callback) =>
  console.log "Adding file", item.filename, item.path
  zip.addFile item.path, item.filename, (err) ->
    console.log "Done adding", item.filename
    callback(err)

async = require "async"

async.forEachSeries files, iterator, (err) =>
  console.log "Done creating zip file"
  callback(null)

```
Okay ++
Since `type` is defined outside of the block, no need to set in an arg.
Actually, it IS wiring up a graph of bindings.  I'm open to suggestions though - it was off the top of my head.  

Dagger.build()
Dagger.init()
Dagger.create()
Dagger.graph()
Dagger.graphOf()

?
copyrights are okay here?
why would one change this, we could just remove the CRAY ifdef, couldn't we?
I don't think these 'pre_get_posts' hooks belong here. There are a million ways to hook into WP_Query and another million ways to organize those hooks.

For example, I store all the hooks related to a post type in a class.
Is there any way to direct people to github for a comprehensive list of contributors?
Yep, you're right. Changed.
Add `'418': @ImATeapotError`
I say it is yeah, for subclass-ability this might be where you hook in. It's a single place where all automatically instantiated views are actually instantiated, which seems useful to me.
yes that was a mistake because we are 2 working on the same project via saros and i tried to clean some code but didn't write the same line of code, but you have to admit it's pretty close :D
Yeah. I think we duplicated it in the Azure context, but it's not really necessary
Please put the `else {` with the `}`
You don't need `Date.now()`, this is equal to `timestamp`.
I think it would make sense to have a separator after Check for Update, since it's pretty different from all the other items in this group.
Typo: coment
Woohoo. And someday a refactored ProjectManager will fit in here too.
Actually, since the results_path requires the user to URL encode it, I think it's ok if to ask for the spec_name to be URL encoded as well, e.g. ``spec%20name``. Sound good?
auto-complete has autoload cookie, so you don't need this.

https://github.com/auto-complete/auto-complete/blob/master/auto-complete.el#L1384
Without them, I get class / method not found errors when running the unit tests, but only when testing the retry stuff.  Should probably just make sure active support is loaded in the test helper instead.
Could we eliminate some of these given that we now have the visual tests?
Looks like this and other places could make use of the modulus operator.
It seems there are some new spaces her :-(
Or probably you can hardcode one gender as default. I do not know how field works.
Do you remember when we said that GET requests should never change anything? So you see that here we do not do this. So it is wrong. So this should be `post` and we should not use simple links (GET request) for Facebook login, but POST form button (which can be rendered as a button, link, whatever) - the important things are twice: we get POST request and it is checked for the CSRF token.
You don't need `list`, just use `./nodes`.
I agree with Matt.
We're going to have to abstract this into something google maps uses too
Ah, I see why now, we have double quotes in the string. Hm.
What is `1000`? Should be based on something else?
These inputs are missing labels, which is bad for accessibility.
there is no `undefined` literal -- use `typeof`
The try/except should be replaced with an if/else. I think you should be able to do something like `if len(project.releases) > 0:`
Why should this raise?
Not a big deal, but I think this snippet has less code duplication and is a little easier to follow


            // remove context, if it already existed (ctx != null) and any of the following is true:
            // is a group OR repo path changed OR we have an isIndexed transition happening
            if ( ctx != null
                && ( repository.getRepositoryKind().isFacetAvailable( GroupRepository.class )
                    || !ctx.getRepository().getAbsolutePath().equals( repoRoot.getAbsolutePath() ) || ctx.isSearchable() != repository.isSearchable() ) )
            {
                // remove the context
                removeRepositoryIndexContext( repositoryId, false );
                ctx = null;
            }

            // (re)create the context
            if ( repository.isIndexable() && ctx == null )
            {
                addRepositoryIndexContext( repositoryId );
            }
# dso
Fixed in b1a5057
Probably doesn't need to be fixed, but I believe jQuery selectors are evaluated in ascending hierarchy, so for something like `.js-zipkin-navbar > li > a` will get all the `a` anchors on the page, select those that have `li` as parents, etc. This can get pretty expensive if you have lots of anchors on the page. In contrast, if you attach a class to the anchor selector `a.some-class` then there will be fewer objects initially selected.
yes you are probably right. I did not want to interfere too heavily in the structure of the code as I was not sure if it would work at all. I will try now to see if I can get the same results without this method, by using Solution and Solutions...
Fair enough. Thanks for looking into it.
agreed, we can move it to the model ...
inecas++ fixed!
...and phpdoc's specification has been around far longer than symfony's, and matches that of other, older and more mature languages. `return void` has its place for understandability.
Pass items here, it's clearer.
This last one statement is actually doing image composition (like Photoshop layers).  You can simply split it up to `compose()` method which takes `image`, `left`, `top` parameters.

And then, you would be able to build `watermark()` method on top of these smaller parts e.g.:

```python
def watermark(self, image, opacity=0.0, left=0, top=0):
    with image.clone() as watermark_image:
        watermark_image.opacify(opacity)
        self.composite(watermark_image, left, top)
```
We should probably unify the names for persistent_storage_size across that name g_pss and initial_storage_size. This should probably extend into CloudMan itself because its initialize command takes g_pss (as we well as something else)...
The only reason this class was introduced is to minimize the number of the
input parameters to the getBestCostPlan method. When I started refactoring
I thought it may be a big number. But since the latest version has only two
of them, the whole class doesn't make much sense at all. I removed it. Now
the signature is
    private CompiledPlan getBestCostPlan(
            AbstractParsedStmt parsedStmt,
            AbstractCostModel costModel,
            String sql,
            String joinOrder,
            String stmtName,
            String procName,
            ScalarValueHints[] paramHints,
            boolean isPlanFinal) {


On Fri, Sep 21, 2012 at 5:27 PM, Paul A Martel <notifications@github.com>wrote:

> In src/frontend/org/voltdb/planner/QueryPlanner.java:
>
> > @@ -68,6 +70,13 @@
> >      // generated by plan(..)
> >      boolean m_wasParameterizedPlan = false;
> >
> > +    class NextPlanParams {
>
> NextPlanParams is a confusing name considering what Param/Parameter
> usually means in this code.
> Maybe call it SetOperatorPlanCounter?
> Maybe keep the the isFinal flag as a separate input to getBestCostPlan? or
> at least make it a final property -- I think it could also be more clearly
> named something like isTopOfPlan.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665948>.
>
>
can you land this fix separately? its broken right now.

very nice work, I let someone else review in addition
I'm sure you didn't mean to do this :)
Now that the other two functions are private, i think this one should have the longest docstring, explaining in particular that path can be either local or remote...
The only way to check email validity is a confirmation email. If we add other auth mechanisms we can deal with it then, no need for it now.
Should read "Add a n-required...", as "an" goes before words that begin with vowels. Perhaps the devs intended to use the spelling "nrequired"?
@laanwj That is explained in the commit message / pull request message.
this would have to be dataAvail
I know other projects do this but in cjdns all `#define`s have the same indentation as surrounding text.
Can you add example?
Maybe use `system_check` here?
You should create an EnumSet of all elements of the Enum and then iterate over all its elements, and getting the code from them.
Commit in 6cef08f . I'm still learning those git commands , hope not giving any trouble and please correct/advise me if i'm wrong
Should this say `str() or repr()` instead? Since depending on what an object actually implements, the error could come from either, it might be a bit more informative...
``for (...``
spelling: embedded
looks leaky. 

do you need to close the file in that error path? or free `path` on the success codepath? also, is that going to a double free on `path` if p_open() fails and errno != EEXIST?
No count_by_p defined, test won't work.
Python has boolean values so we can just use True and False
need to wrap this in a `gettext()` call for l10n.
__whimboo__ wrote:
> ... at end of the loop, so that we do not spin the event loop if the result is not a boolean value.

If the first value of `result` isn't a boolean value, then the `while` will not enter the loop! I hope!

I moved this call to the start of the loop because I transformed (and moved) the `break` into the loop condition.
ahh, right.  In fact, I should wrap the if around everything following the trigger_id definition.
413 - 416 are tab prefixed and have interspersed tabs
and amo is before apps (although some people but it as the first amo import, but they are wierd :)
Yes, I think that's a good observation on the responsibilities of the ParseAndVerify method. To me, that's an indication that perhaps it shouldn't be there at all...
Nothing was complaining (rake spec or rake quality), but I added it anyway.
One minor gotcha with using #none? (in case you didn't already know) is that it will indeed return true for [false, false, false, false]. In this case I'd probably just use #empty?, although it probably doesn't matter too much in this specific example.
But that wouldn't be a valid IC by definition since the lever needs to be attached to the IC block.
If this check does not happen in will screw up a lot of thight redstone circuits with transmitters for example that dont have a lever attached to them but an other IC is on the back rotated by 90° that has a lever attached to it.

If this code is not there the transmitter will interefere with the other IC.
Should pull in tests. I'm slacking.
Yes. But I re-architected it to just have an already deserialized `Object` instead.
Can you add the reference to the relevant PHP bugs, so that we can remove this when it is fixed upstream? Thanks.
For the second point in the PR ``allow easier overloading of the default behavior``, yes
this should be ``null ===``. And it would probably be even better to make the argument default to an empty array and remove this check entirely
I don't understand the comment. If the separator char mentioned in the comment is the ``_``, the comment is wrong as it is valid in IDs (and there is many underscores in ids generated by Symfony for the forms)
Ok, I think I see your point but then the problem is that even when using Doctrine Common as provider, you'll still need to implement a bridge for it as there's no PSR for a interface nor a most common way of naming the functions. Once a PSR will appear then I'll be able to use it to standardize the interface.
This means that you are saving an unencrypted password. I think that this must be removed.
thanks, this was just a copy paste
redundant empty lines
个人不推荐这一节，本来latex模板的目的之一就是为了让大家可能摆脱word，学习更多latex的知识，这正好是适得其反了
包括前一节同样如此，我觉得只要告诉图片如何插入即可，现在的宏包也支持除了eps以外的其他格式
关于公式部分，我更倾向于提供一些比较精简的教材，顶多加上一些示例即可
Turns out that the legal characters are more than just word characters. It's `[\w.+-]`. I'll fix this and add validation to volume group names, too.
As I wrapped those functions calls in Database manager and surround them in try catch there i thought it was sufficient (as it was done like that before !!) , but if you prefer to have the exception catched directly, I can do that ! 

I'll remove catch from DatabseManager and add them in ReportsJdbcRepository
I don't disagree, Chris. It's just a question about whether this is making the code significantly more complex or less efficient in service to a use case that we are unlikely to ever encounter (and if we do, are easy to fix at the app level).

You're supervising this work, and I totally trust you on both code maintenance and performance issues.  I'm more than willing to let you make the call on it.
a comment to state that this is a publicly hosted open street map server would be helpful here.
I'd leave these out of this PR and create an issue for them to be done.
*the* amount of data
This resolution should be done in JSFSubsystemAdd, and then a String or null passed into JSFVersionProcessor.

.... new JSFVersionProcessor(JSFResourceDefinition.DEFAULT_JSF_IMPL_SLOT.resolveModelAttribute(context, model).asString()) ....

The resolveModelAttribute method on the AD does two things for you:

1) Give you back the default if the node in the model is undefined. That lets you set the default in 1 place only -- the AD -- and everything uses that.
2) Resolves expressions, which the metadata says are supported here.
I'm not sure why there are so many changed lines in this file, perhaps it was using tabs? Anyway, this what I changed in this file
It keeps the public API the same, which requires that the compiled function only takes model as a parameter. The helpers are pulled up from the publicly accessible `vash.helpers` export.

For code generation scenarios the `toString` method of the `shell` function was overridden to still return the serialized code of `func`.
Hum.... sure you're not missing a `!` ?
`var cpuWakeLock = null;`

Add trailing comma!
This doesn't harm since his parent, `#utility-tray` has his z-index value.
But still propose to avoid using a magic number.
Yeah, I realized afterwards but my Lint checker was rising errors locally... ;-999