labofsahil/github-event-dataset-2012 huggingface dataset:
@swanandp @habib Thanks. Glad you like it.
Wondering if it would make sense to only expose "define" since that's all that's required per [AMD spec](https://github.com/amdjs/amdjs-api/wiki/AMD), and then do $.require since it's a jQuery plugin afterall.  Thoughts?
This is a good example of documenting a standard method, since the behavior is non-standard.
Had forgotten to filter unicode string for &lt;, etc and replaced it with corresponding symbol!
"That you can't have XA and batch-mode?" <-- precisely. If the BatchingTM is used then you don't have recovery, so no point in using XAResource enlistment. Also batches don't participate in distributed transactions. 


"Also, this check could be made in the TransactionConfigurationBuilder.validate() and BatchingConfigurationBuilder.validate() since you can then change the config if needed over there." <-- in order to take this decision I need a reference to the TransactionManager which I won't have when TransactionConfigurationBuilder.validate() is invoked.
Made changes to it. SQLite has different queries. Also fixed another bug
for SQLite on users page. However, ranking calculation for SQLite on
contests page remains incorrect. I tried to put special ruby code to
calculate it for SQLite, but it's not working.

PostgreSQL calculates ranking numbers automatically.

On Tue, Jan 17, 2012 at 7:27 PM, Simon Welsh <
reply@reply.github.com
> wrote:

> @ronalchn The migrations do not work with SQLite. Can you please rectify?
>
>
> Yogurt:nztrain-v2 simon$ bundle exec rake db:migrate
> ==  CreateContestsMaxScoreSubmissionsView: migrating
> ==========================
> -- execute("CREATE VIEW contests_max_score_submissions AS SELECT DISTINCT
> ON (contests.id, submissions.user_id, submissions.problem_id)
> submissions.id, submissions.score as score, submissions.user_id,
> submissions.problem_id, submissions.created_at, submissions.updated_at,
> contest_relations.contest_id FROM contests JOIN contest_relations ON
> contests.id = contest_relations.contest_id JOIN contests_problems ON
> contests_problems.contest_id = contests.id JOIN submissions ON
> contest_relations.user_id = submissions.user_id AND submissions.problem_id
> = contests_problems.problem_id WHERE submissions.created_at BETWEEN
> contests.start_time AND contests.end_time ORDER BY contests.id,
> submissions.user_id, submissions.problem_id, score DESC,
> submissions.created_at ASC;")
> rake aborted!
> An error has occurred, this and all later migrations canceled:
>
> SQLite3::SQLException: near "ON": syntax error: CREATE VIEW
> contests_max_score_submissions AS SELECT DISTINCT ON (contests.id,
> submissions.user_id, submissions.problem_id) submissions.id,
> submissions.score as score, submissions.user_id, submissions.problem_id,
> submissions.created_at, submissions.updated_at,
> contest_relations.contest_id FROM contests JOIN contest_relations ON
> contests.id = contest_relations.contest_id JOIN contests_problems ON
> contests_problems.contest_id = contests.id JOIN submissions ON
> contest_relations.user_id = submissions.user_id AND submissions.problem_id
> = contests_problems.problem_id WHERE submissions.created_at BETWEEN
> contests.start_time AND contests.end_time ORDER BY contests.id,
> submissions.user_id, submissions.problem_id, score DESC,
> submissions.created_at ASC;
>
> Tasks: TOP => db:migrate
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/xrymbos/nztrain-v2/commit/fde356ae57afdb6b8e746bd5a95bfaec04b2f224#commitcomment-873167
>
@yellowled YL, is there a nice (de) doku, 
where I can learn the detailled differences and meanings using > between #xyz>div vs. #xyz div vs. #xyz > div etc?
Thank you.
needs min-width: 960px
Still pretty sure I'm doing it wrong... Sorry
I have clarified this in QQ
Интересный момент, почему юзаешь KeyError а не IndexError?
Damnation now .gitignore file :-(
Hey @jsmestad -

I was just curious if you seeing issues with the i18n integration.. wanted to make sure there wasn't something there that needed to be fixed in the library.
s/effected/affected
Опять обход багов Оперы. Блин. Без box-shadow не так красиво смотрится. :(
You might try removing your copy and re-clone it
hm sorry, didn't notice. will fix tomorrow. now sleep for me :)
so, we wanted to write Fifth not Fourth ^^
Again no need of body tag
yeah please do so and sorry for the delayed response
I took the line out and it still worked! I'll fix that with my next push.
:\ still pretty adamant about sticking with idiomatic JS classes

name change from Group to Range kinda works, though Range suggests HTML DOM Range which is from a node to any other node, not just a sibling node. Group suggests and arbitrary set of nodes, though, which I guess is worse. Is there a word for "contiguous range of siblings"?
Could you explain that bit of magic pretty please?
This method was devised based on the white-space hiding that @jonathantneal and I used in [an experiment on containing floats](http://nicolasgallagher.com/better-float-containment-in-ie/). I've been using it for image replacement in production ever since and it has performed well and even avoids certain IE7 bugs when used with `display:inline-block` elements.

I've subsequently found that an early version of this method was documented as far back as 2003: http://www.maxdesign.com.au/articles/headings-as-images/

The `color: transparent` consideration was suggested by @chriseppstein; we could do with some mobile testing to find out if it is necessary.

The super-short font-family `a` in the `font` shorthand property is a clever idea taken from the [BEM implementation of this method](https://github.com/bem/bem-bl/blob/master/blocks-desktop/b-icon/b-icon.css).

And thanks to @scottkellum for sparking another discussion about IR techniques.
Just wanted to update this test to clarify that ``#settings=`` merges in the hash passed to it, it doesn't replace all settings with it.
Forgive me for being a bit sarcastic, but please remind me who was the person who said the socket should not be passed in the constructor? ;)
What if we just say:

Draw the number of Crisis cards shown below. Distribute evenly. Remaining cards are distributed to the Scout's discretion.

    Mon-Wed: 4
    Thu-Sat: 6
    Sun: 2
Very useful shortcut, widely used in DOMRichText code. It creates a node in a HTMLElement, with attributes and content, and can be inserted before or after a reference node, everything in just one line.
Usage:
p_.nodo(
       tag →  str tagName for elements or 'text' for text node, 
       padre → HTMLElement  or id string for set a parentNode, or bool false without a parentNode
       attrib → object with attributes and values, e.g.: { id : 'myelem', style: { fontSize: '10pt', backgroundColor:'#eeeeee'}}
       inhtml → str to convert to textNode or HTMLElement as a child of the new element
       ref →  HTMLElement that is a reference sibling
       delante → bool true: after the ref, false before he ref.
       )
But then there is some "deadtime" while opening the cache, isnt it ?
But I guess the saving into the cache should be quite fast...
Good idea. Glad we could help
Great :) I was digging for this last time i using this gem.
Hi Imayoda,
it should work fine (it does for me) with hcitool and also with bluedevil.
You may check that the basic things to set up are ok:
1) the nvram.txt file from Android copied to /lib/firmware/brcm/bcm4329-fullmac-4.txt
2) the firmware installed by the kernel as /lib/firmware/brcm/bcm4329-fullmac-4.bin
3) the patchram file in /lib/firmware/BCM4329B1.hcd
4) rfkill unblock 0 (need to test if 'rkfill unblock bluetooth' works as well)
5) /usr/sbin/brcm_patchram_plus --enable_hci --baudrate 3000000 --patchram /lib/firmware/BCM4329B1.hcd /dev/ttyHS2
 &
6) echo "1"> /sys/devices/platform/smba1002-pm-bt/power_on

If you sill have problems we can do further investigations. (Now I'm working on a Acer Iconia Tab A500, the mechanism is quite the same, I'm making a unified rootfs to support both of them and will test this on the Hannspad soon).
Never compare a boolean to its true or false value. Instead of "result == true", just say "result". You should also break out of this loop once you find that the ID in particular is blocked.

In this case, "continue" is unnecessary. You can just use

```python
if not result:
	# poke user
```

and it will skip over the if.
GOOD!!!  I have been meaning to do this and always forgetting to do it
I actually only have access to an i686 machine, so I've been building packages for that.  I'll regenerate the packages.
That was on the experimental branch, but i removed it and then merged this branch into the master branch.
Separate issue.
Better to use ``request.GET`` rather than ``request.REQUEST``.  Explicit is always better.
Thanks - have fixed that. Works now.
Still not returning anything?
Yeah i saw this bug, that's why i have reverted it
Il giorno 16/feb/2012 18:55, "Andrew Dodd" <
reply@reply.github.com>
ha scritto:

> Heh, since you already reverted it - keep it that way and be VERY careful
> about messing with it!  :)
>
> I tried making this a user-controllable option - after all "maximizing
> power management" seems tempting - but it actually caused the wifi chip to
> wake the CPU all the time, causing major battery drain.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/simone201/neak-kernel-sgs2/commit/8ce5232a9469c4a29ea0702318ae8050d586476d#commitcomment-974597
>
Lazy to check if it's working...
Obligatorio los mmaps?
Use ``.get('is_new')`` to avoid KeyError exception
Fixed in 437477d61c6459f9b5f15f3e929c75f8ee4b69d5
Forget to sync the file data/cache/config
Another commit comment.
Fixed in the next commit.
Yep ... like you've noticed I was not really sure how to call things ... and at some point I just stopped thinking
Why do you want to protect 32 megs of low address when kernel itself is 2 mb ?
The docblock should also reflect the SessionInterface
This is not high priority right now. If you are busy, you don't have to do it tonight or tomorrow. But if not now, we should do this very soon (perhaps right after the lottery is finished), before we forget.
THIS iS VERY COOL!!!

Boosted my system allot!
Thx will test it today
Will this kernel still be updated in GB branch?
Corrige l'issue #14
Don't know if that don't break compatibility with other devices ...

https://github.com/OpenEtna/android_frameworks_base/commit/17b239e53b959573d3300964c66898de35514cd2#telephony/java/com/android/internal/telephony/RIL.java
and
https://github.com/OpenEtna/android_frameworks_base/commit/bc31a5a76c2511fa278ba0991981ece72f6c4cba

hmm, don't know if your ifdef solve that.
Often through this script you use explicit IDs and string manipulation to identify elements. Instead you should be able to have one function that's called when the widget is loaded (eg. initCGMPWidget($(this)) ) and then all the code relating to setting up that widget can be done in terms of that one reference node.
That's cute. To whom do we owe the artwork?
Add new fetilizer.
Polish names.
you missed the replacement on this part. will do a pull request shortly (after I'm done reading the backlog)
ですねー。`FactoryGirl`では指定せずにしておきましょうか。
Seems like create, get, and delete should all be in their own "test blocks" just to help with understanding the failure quickly.  That will also help focus in on exactly what is being tested vs what is setup.
If this isn't necessary, please remove.
What is the story with this test case? I don't think this should be a valid case (just an empty `<nrml>` element).

I think we should adjust the nrml schema to not allow a file with just the `<nrml>` element (and no content).
the serviceId should be prefixed with ^ to make sure it matches https:// at the beginning of the service. the same would apply to the imap pattern
Agree this needs to go into cas-server-integration-memecached module.
New commit with missing final keyword !
No, they're allocated on the heap.
Shorthand syntax would be better here (if / endif)
I don't think that will work, since what do you do if it is the message that cannot be serialized?
Try to write your writeObject, you'll see what I mean :-)
These two imports should go at the top of the file
"Actors also provides" ? Shouldn't it be "Actors also provide"
That is better. I tested .max before and it wouldn't compile, requiring Ordering but now this does not. thx.
Knee-jerk reaction from Java. ;)
fair enough - it will just box the primitives. Wouldn't it?
RE: the stamper attribute explicit in the version create.  I think I may have had trouble getting the equivalent of this to work right for revisions.  Or maybe I hadn't done it (right) yet.
No, it just tests frozen? and returns self if it isn't.

Unless frozen? calls the db, it's just the test.
Use ObjectProperty() too here
I actually just added OLS in there as an option. I think that it's nice to
have both options. Do you think it's too confusing?



On Wed, Oct 24, 2012 at 8:33 PM, Stefan van der Walt <
notifications@github.com> wrote:

> In dipy/reconst/tests/test_dti.py:
>
> >
> > +    # Test fitting with different methods: #XXX Add NNLS methods!
> > +    for fit_method in ['OLS', 'WLS']:
>
> Can we perhaps drop one of the strings then?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nipy/dipy/pull/82/files#r1936999>.
>
>
Well - in this case, fa.shape == (), because there's only data from one voxel => 1 FA value. 

Should we test that's true, or do you mean we should look at some multi-voxel data here?
Also not a fan of NOT in call capitals. Another pet peeve, it looks like something someone would write on facebook rather than a user guide. 

More generally, pick one. Above uses bold for emphasis, here uses capitals.
Who says this is correct?
GetCurrentPadding in exclusive mode event-driven always returns the size of one complete buffer (there are two) per M$. I did write a very extensive routine that polled the hardware pointer within the current buffer and used that plus the current performance clock to track this very accurately, but never upped it for a few reasons:
1) the required return value for of GetCacheTime() wasn't clear
2) being polled every ~2ms it was just added overhead considering:
3) it seemed to have zero effect on the perceived or reported OSD sync error

Regardless, good that there's some clarity/consistency now as to the purpose of this function - good work.
ah, and I think this is for URLs, not local file paths ;) ..so should work as designed.
I think you could follow the pattern "get ..." in here, as we do with other facets
Enum values should be uppercased
It appears to be a constant in cls. I had to make the change otherwise it fails.
Should we mention here that when the composition of a cluster of nodes must be changed (and you aim for both consistency and integrity of your data), it's necessary to rehash the whole keyspace using external tools that uses the same underlying algorithm since Predis doesn't do that at runtime?
`s/givin/given/`
Here: just comment that it is DFS
Oh, that was my fault. I was testing it...

On another note, now I fully realize why code review is the greatest thing evarr.
I'M SORRY LOL. I had Xcode set to spaces instead of tabs before >_>


On Wed, Nov 21, 2012 at 7:52 PM, CodaFi <notifications@github.com> wrote:

> In lib/UIKit/TUIPopover.m:
>
> >
> > -        self.contentViewController.view.frame = CGRectMake(self.contentViewController.view.frame.origin.x, self.contentViewController.view.frame.origin.y, self.originalViewSize.width, self.originalViewSize.height);
> > +        self.contentViewController.view.frame = CGRectMake(self.contentViewController.view.frame.origin.x,
>
> Jeez, who has time to type all of these spaces?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/github/twui/pull/143/files#r2202098>.
>
>



-- 
Aditya.
Ah you're talking about the method used *in the action*. I misread what you were trying to convey there.
What do you mean by "isolated"? How does setting it here vs. modifying the setters affect anything?
now works if more than one package matches.
added options just like Yum's "available/installed".
Let's also have an entry for compiling for 64-bit Linux.
That import should not be used... use UnsupportedOperationException or IllegalStateException
Changed from "black" to "black-translucent", this fixes possible problems related with items under the status bar
и тут хочется префикс
I think you can `assert_file` only once, with more assertions:

```ruby
assert_file "things-43/public/humans.txt", /Things43/, /Software: Ruby on Rails/
```
Good catch, I will fix it and recommit.
Actually, I was thinking we could be a little more generic here - rather than limiting ourselves to path matching we can return the response from call, e.g:

``` ruby
elsif dispatcher.is_a?(Redirect)
  return dispatcher.call(env)
```
yes you're ritght , also i don't know that If the symbol or string of the key contains special characters such as '-',  I have to use the Ruby 1.8 syntax
`reject(&:blank?)`
isn't this already checked in guides/Rakefile?
ah, I was probably mistaken: both treeInfo and definitions have a isRepeatedParamType??
sorry about that
Yeah, a comment would be very nice if it's something that is required here, with a link to the ticket.
(For Akka we always prefer explicit return types both for clarity and to reduce the risk of inadvertent signature changes)
I think somewhere around here it should be said that the PR doesn't have to be "perfect" in all of these respects --- only that in this case it may require someone else interested in the problem (e.g. module maintainer) to pick up the ball and push things to conclusion, and this may then take longer.
There are 6 scenarios I wanted to explain in the documentation:
1) equal means equal variances (rvs2)
2) equal means unequal variance (rvs3)
3) equal means unequal variance unequal n (rvs4) <- this difference is pretty drastic depending on n. If n1=n2, then the t-statistic is the same whether you use Welch's t-test or the standard 2 sample independent t-test. If n1 != n2 the t-statistic can be very different. I think this is an important point.

rvs5, 6, and 7 are repeating scenarios 1, 2, 3, with unequal variances.

I'd suggest keeping rvs4, but we could lose 2/3 of 5,6,7. I'd keep 7, I suppose.

I've clarified the documentation to explain the point I was trying to make.
I don't think this is the case. Users are now prompted to enter an email when they create an order (if they're not authenticated). Is there a case where an order could be created anonymously?
(That all should be wrapped inside an 'if real.is_number` condition.)
Here you leave symbols in the trace, while at L11, you break up the Mul and return the symbol. I think you should choose one or the other behavior.
I would prefer this without the empty line. Actually, why is this `return` not in the `except` block?
At the moment not, that is why I ask.
This should read `TBaseListener.java`
ich bin mir nicht sicher! Aber wahrscheinlich hast du recht. Man könnte meinen, nach dem Validieren muss man die Werte noch übergeben, dies ist aber anscheinend falsch, weil der Service das für mich macht!

Schon geändert.
Shouldn't we still be doing a `slice(1)` on the arguments since `name` should not be an argument to the targeted function?
Btw single backquote is enough.
Maybe turn this into:

```c
#define uv__stream_fd(handle) (uv_stream_fd((uv_stream_t*) handle))
```

So you don't have to cast to uv_stream_t everywhere.
I'm not wildly enthusiastic about the 5 levels of indent or the many if/then/else branches. Is there a way to flatten / simplify the code?
OK, did you change it because of the squeel syntax eg ````joins(questions)````?
Be that as it may, we can't just leave this code in this state - it looks like you've forgotten to delete something.
I'd rather figure this out earlier.  Can we add a verifyFields(Set<String>) method to the postAggs which will verify that the fields it wants are there and recursively do the same for any other PostAggs they have?
I believe this should be `blank=True` or the user won't be able to submit a form without checking the box.
I'd prefer | over the bull here.
That's the way we use do it inside of [ ]:
Example in profile:
Warnings:
    0 [ View user notes | Warn user ]
I've never heard camelCase before 0_o


On 4 May 2012, at 15:19, David King
<reply@reply.github.com>
wrote:

>>
>>    <div class="indent">
>>        <p><code>$current_user</code> is right, but <code>$currentuser</code> and <code> $currentUser</code> are not.</p>
>>    </div>
>> +
>> +    <p>In JavaScript, variable names should use camel caps:</p>
>
> camelCase is the "official" term (recognized by wikipedia). camelCaps is one of a bunch of synonyms: http://en.wikipedia.org/wiki/CamelCase#Variations_and_synonyms
> I prefer to use the word camelCase because I've heard it before, whereas camelCaps just sounds weird. But since i don't read the coding guidelines very often, I don't much care.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/phpbb/phpbb3/pull/779/files#r774363
All 3 prefixed versions are not needed, FF3+ supports pre-wrap without prefix, so does Opera
You forgot this part:
> Note: Although the values can be set and read using the standard JavaScript property access method, using the **getItem and setItem methods is recommended**.

Why don't we use the recommended way that follows the interface, then?
Even though using the setter as an object attribute may (and probably does) work, I still believe that using the public interface, the recomended way by MDN, is the best way to go.
I read the W3c's page about the Storage interface with some attention and used search to try to find and I didn't find anything about storing values using the attributes of the Storage object itself. It can be a feature that is not stable or available in as much browsers as the ones that implement the Storage interface defined by W3c.
I had issues with comparisons between binary items failing and with converting string input to suitable binary representations for thrift which I believed was down to additional null bytes being read from when the original BytesWritable was used.

Sounds far fetched to me too, and so I'm in the midst of re-testing with this change omitted (I wanted to get a working version up for review asap though).
Nu e nevoie de rândul ăsta liber :).
This function is const, but returns pointer (AFAIK this should result in compiler warning).

You should return either reference or const Projection*
This code seems a little strange -- it seems like mojito has too much knowledge of how YUI works.  Is there a YUI API call we can make instead (loader.addGroup() or something like that) ?
remove comboBase, not needed.
Is there any reason to make this synchronous? The only thing I can think of is getting multiple hits before the compilation is cached.
Ho mark,
I really can't understand CakePHP code stantards... I like so much a better spaced code with comments and other useful code spaces (like alignments).

When writing PR to the CakePHP core I will follow CakePHP code standards... but for outside code I prefer to improve readability.
Yep, thank-you!
Why the space here? I thought mul(sparse1, sparse2) was supposed to look like a function call.
Oops, was meant to read "Theano", thanks for spotting this (fixed).
Comment out this test case. My fault not to bring it back after a small twist.
That's not very Pythonic. Raise the exception by default, and only return a fallback value if a third argument to ``get_prefix_by_object`` is passed, like so:

```
get_prefix_by_object(obj, '')
```

That'll be in the vein of how Python (e.g. ``getattr``) and the standard library (e.g. ``configparser``) behaves.
Can I get some background on this, please? (reason for, observed benefit)
We are thinking about possibility to make promise types loadable in future, it is not possible yet. At the end it will probably be a shared library with a set of symbols exported which describe the promise type. CFEngine will load libraries and discover which promise types are available.

The idea for CATEGORY validation is to call validation functions during parsing, not after. This would require a new set of validation functions though.
I just refactored this from the raven/base:send_udp code - so it's identical behavior, but I do think we should log this somewhere.

Silently eating messages seems really wrong.
This will need a 'versionchanged' directive, as soon below for the recevier decorator.
Nah, lets just do that post-merge in a separate patch. There is no need to depend on app-loading refactor.
Not sure what RUBY_VERSION returns exactly but perhaps `/^1.9/`
the method is always upper-cased, that's why I removed this from the previous PR.
I was a bit worried about it myself, but didn't see any issues during testing.  Can you think of a scenario where this might be an issue?
We use `self` rather than `that` in these cases.

Also, please don't define more than one var on each line.
Indent style?
If they are listed below, that sounds good.
Preferred method is to use a `Requirement` class, and then `depends_on GnupgInstalled.new`. You can copy the GnupgInstalled class directly from the signing-party formula.
Would adding libelf as a dependency be a cleaner way to provide this header?
What's the point of this exception?  find_domain(old_namespace) should already be throwing if you specified the wrong domain.   The exception that throws is going to be more relevant "you passed us domain X, we don't have a domain X" is clearer than the generic exception "hey you don't have any domains".

Also simpler and less code.
I'd use `PERMISSIVE_MODE` here for consistency. Also, it might be a better idea to set a `permissive_mode` flag in the config validation step rather than accepting an arbitrary string (in `_mode`) and checking against constants later.
Thank you Captain Obvious
So, on current code, `link` is the `r2.models.link` module, which does not define `domain_override`. Which means this code was a bit broken in that I don't think it is currently possible to *unset* domain_override on an ad.

I think I'll try and pull this fix in sooner rather than later, so you may end up having rebase/merge issues at that point.
What do you mean. Thats for the GitHub Markdown for highlighting.
We should still register the script. Just not enqueue it.
I think these are two different things! Suppose A depends on B.

Creating the dependency lazily means that A doesn't depend on B until as late as possible.
Making a dependency lazily created means that A depends on B immediately, but B isn't created until as late as possible.

Does this distinction make any sense?
I'm thinking it might be a good idea for this method to set fClazz if this method loads the class successfully. What do you think?
This is wonderfully parallel-safe! :)
`_play` still needs to take a `media` argument. I suppose it's a style point of whether to include it here, since it's not used in this method, but it *is* used in the inherited method. I'd argue for keeping it for clarity.
Don't *you* like single quotes, @thegoldentoilet? It's actually consistency that's important. Most of the other describes use double quotes, so I guess I'd continue with that.
This leads to some inconsistent behavior: e.g. typing extra chars after a 3-digit hex value is ignored until you get to 6 digits, while backspacing from 6 to 5 immediately resets the colorpicker UI to #fff.  We could try to reuse the logic in #2142 to fix that, as you'd suggested, but I feel like the current behavior is probably good enough for now.
I'll file a general issue to move blocks such as this one into a template.
Yeah, let's not have merge conflicts in our source code :)
might be a nice idea to name them like
"winDashboard"
There's no reason to have a doc string for this function. Its not a public API and its name and use should be painfully obvious what its for.
please explain what this is, either here or in the constructor.
Hi kenmazaika!

This is puzzling to me; I'm wondering how tourbus ever worked here. :-) I just tried this on 1.8.7 (the original Ruby I wrote this for) and not only does sub not work, but neither does grep! [:foo, :bar, :baz].grep(/ba/) quietly returns []. On 1.9.3 grep works but the sub does not.

Which ruby version are you working with, and if it's 1.9.x, would you consider moving the to_s to before the grep? E.g. methods.map(&:to_s).grep... etc.

Thanks!

David
`alias` is a Ruby keyword, and doesn't require Symbols, but it will accept them anyways. Also, vim appears to not properly highlight `alias :foo :bar`.

[alias_method](http://rubydoc.info/stdlib/core/Module#alias_method-instance_method) is a Module method, and does require Symbol arguments.
translations (though for a custom report it probably doesn't matter)
you should use numpy.testing.assert_almost_equal taking the time and time_expected arrays as input.
Why then defining design for class and not directly for HTML elements? If we want all to have the same design?
I would like to disagree. The only place it's needed is solely in the `RecentChangesTableView` view. 
The day it's needed elsewhere we can move it and factor that out. This way, I like the "self-containment" of it exclusively to this view. 

Also, the labels there "rule", "permission", "release" is quite exclusive to this view. We could after all freely change this to something more verbose like `"Download Rule"` instead of `"rule"` as this is the word that appears in the first column on the Recent Changes table.
the additional reason this exists is so that the persona tests could figure out what url to use without having to specify one on the command line. if it were specified on the command line, i'd have to start passing around the mozwebqa / testsetup, or have each of the classes' __Init__ take selenium, timeout, and serverurl.

as such, this method is used by the pytest_funcarg__mozwebqa() method in tests/SIA/conftest.py to load the persona server instead of the base_url.
This regex isn't working for link tags properly, probably something to do with how to close it. Maybe `(<\/script>)?` to match it 0 or 1 times?
don't set these to undefined, use null, unless we have code that depends on undefined?  Same with ones below.
Empty anchor tag? What's this doing?
Should probably have units: "%" like zoink does in this manifest, for all the above changes.
Put this on the same line as util/shims so we don't remove them or break things later.  I suggest:

```javascript
"ui/widget/tooltip", "crashreporter", "core/project",

// keep these at the end so they don't need a spot in the function signature
"UAParser/ua-parser", "util/shims"
```
Not a huge fan of this regex, but I guess it is needed.
Again, add some kind of overall discussion comment that explains what a ghost is.
Yea don't worry about this as per our discussion earlier
This file didn't require any change/commit.
well, the if statement doesn't do anything :) if (not equal) make equal;
as i said before i think return_request is not needed
Thanks. I update the code in commit 34d3192.
When you say more explicit, does it mean that all the instance variables used in the view should be set in the controller action method, instead of setting them across different methods?
@plusjade Ah nice catch. I meant to use `scaffold`.  I'll update the code momentarily with your suggestions.
Need to incorporate the same flags as the pip module so that users can specify any optional parameters to pip in the state file.
最后的括号换行
This is getting a little...long. Combined with a lack of spaces it's sort of unreadable. I know Makefile line continuations are painful, too. Is there some other way?
I don't remember moving them out.  I can do that though, as you're right, they don't need to be there.
FYI I am going to refactor this in a different pull request
That's a good question.  It wasn't that way previously (but i'm not 100% sure why).   For other types i think it makes more sense, but does it make sense to automatically be able to delete systems if you can register (within an organization, or environment)?   

It looks like we don't allow update_systems if a user has :create/register  either, so I'm thinking there is a reason for that.  Currently you can only control register by Environment or Org, so if the create/register permission gave update/delete, they would be able to update/delete anything within that environment or org.    This would make the system_group#manage_systems permission and the system_group#delete_systems permission nearly useless if a user had the register permission.  

For some reason I feel like systems are a bit different, but i may be over thinking...
Please wrap the line. if it is over 120chars it doesn't fit into diff on Github.
Calling something like:

repo_ids = gather_library_repos
query = "name:%s" % Katello::Search::filter_input(name)
Glue::Pulp::Package(query, 0, 1, repo_ids)

should solve the problem.  That uses elastic search to do it (there
isn't an efficient way to do that in pulp i don't believe).

On Fri, Jul 20, 2012 at 9:25 AM, Eric D Helms
<reply@reply.github.com>
wrote:
>> @@ -205,20 +205,19 @@ def export_as_tdl
>>
>>
>>    def add_package package_name
>> -    if pack_attrs = Katello::PackageUtils.parse_nvrea_nvre(package_name)
>> -      self.packages.create!(:package_name => pack_attrs[:name], :version => pack_attrs[:version], :release => pack_attrs[:release], :epoch => pack_attrs[:epoch], :arch => pack_attrs[:arch])
>> -    else
>> +    package = Resources::Pulp::Package.name_search(package_name)
>
> Is there a current way to do that?  I have a future enhancement planned to utilize Elastic Search to handle the searching better, but with current functionality only saw a limited name_search available given the restriction that the only piece of information is a package name.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Katello/katello/pull/335/files#r1205223
Or do you mean that after your change, this is now possible? How so, you are filtering you results? In the same line of thought, aren't these list comprehensions a repetition of code?
Whoops, the `name` here shouldn't have double quotes.
what about null?
This phpdoc does not add any value, and will confuse IDE as it is saying that ``pusher`` is of type ``internal``
yep - that seems more natural to me, although that's rather subjective
有url的boot()了是不是可以把replace开发环境host的事情放到这里来做了？
I'd prefer also doing `ui->signature->clear()`, then defining this help message as "Placeholder text" in the ui file. This has the same functionality, but also shades the help text in grey.
I don't like the name "Messaging" very much. I think it will confuse people into thinking it can send messages somehow (like an IM client or email). What about simply `Sign/Verify Message`?
As per Cake's coding standards the variable `$time_ago_format` needs to be in camel backed form `$timeAgoFormat` and so does the options key.
So the point of `ignoreMissing` is that you want to suppress the error that might be generated?
Please check the indentation here.
we typically use `for key, rowset_name in ...`
Could we also introduce a logging system like monolog and use it for all those kind of exceptions handling? But I don't know if one usually do it inside libraries like createphp or if it is part of the good practice...
How's about this for a function body?

```php        
         $parent = null;
         foreach ($type->getRevOptions() as $option) {

            $rdf = NamespaceHelper::expandNamespace($option, $type->getVocabularies());
            $about = $received_data[$this->jsonldEncode($rdf)];

            if (! empty($about)) {
                $parent = $this->_mapper->getBySubject($this->jsonldDecode(current($about)));
                break;
            }
        }

        $object = $this->_mapper->prepareObject($type, $parent);
        $entity = $type->createWithObject($object);

        return $this->_storeData($received_data, $entity);
```

(untested, but you get the idea)
damned, gihub does not notificate me anymore for some messages ! 
Annoying !
I'll look at it tomorrow.
No, because the future is already consumed and the operation needs to be restarted from scratch.
I do indeed, updated.
Where would you like it?
super.toString() can be empty, move the colon there
scope="col" would be beneficial here (and on the other thead th), and maybe just use "Plugin" to better describe the column.
Oh, yeah that makes sense. I keep mixing all these syntaxes, but that looks better here.
@icaaq Yes, it is kind of lame since this piece of HTML is just being used as a template. Eventually, we should use proper templates and not have this problem. But it would be nice to have a fully valid page in the meantime.
Not reviewing this. I can't keep up. Besides, if we do end up with the wrong version when jumping between branches and merges, we'll just upgrade again.
Apparently it's twice as fast to first reference it:
http://peterbe.pastebin.mozilla.org/1968108

If you do it 100,000 times :)
I know this is old code but if `self.crash_store_iterable` is a generator then you can't subscript the last element.
no need to use the `str()` since `%s` does the same thing except that `%s` works better with potential unicode.
I think a helper function that matches on `Index` and does the call might be more clear? Or perhaps move that into chef_db as we've done with create and update? So the chef_db signature would be `chef_db:create_name_id_dict(Ctx, Index, OrgId)`

The multiple fun heads result in more typing, but I think you get better type transparency.
I'm quite busy at the moment, so probably I can't get you too much inputs. Breaking backward compatiblity for something better is good. I still don't understand why you want to build a string :-) This will be done automatically before sending it to the server by the http transport.
Why did you use this instead of `Date.parse(value)`?
check for ParameterizedType and throw a ClassCastException with a message if it isn't one of the two supported types? Make it look like an intentional omission rather than a bug!
I would remove this as the var is private anyway
Note that Drupal cannot use RequestContext because it doesn't have enough data, so putting the useful information on RequestContext would not be useful for us.
`getDate()` always returns a \DateTime instance. So, this cannot be done here.
What about just `runCommand()`?
the only places were we have to use DIRECTORY_SEPARATOR is when we do a string comparison with a path (which is done in FilesystemTest), as string definitely have an issue to consider ``/`` and ``\`` being equivalent :)
probably remove this because we all not use phpstorm :)
If you want to make this more explicit:
````
event = create(:event)
reminder = create(:reminder, receiver: event)

reminder.deliver

event.should have_received(:deliver_reminder_from)
````

Other than that this PR is good to merge!
@AkarshES is this fine or should score have a different implementation?
These should be constants since you refer to them several times in the code
If you want to, feel free. Command helper deals with both just as well, but I personally think this organization scheme (along with segmented .msa files) makes the code more clear and concise.
sieht so aus, als wenn das nur das Training betraf

----- Ursprüngliche Nachricht -----
Von: Daniel Mecke
Gesendet: 29.11.12 11:55 Uhr
An: Pogrim/snowboard
Betreff: Re: [snowboard] fixed training schedule creation (#25)

 null
 In src/Cunningsoft/SnowboardBundle/Command/SetTrainingsCommand.php:
 > @@ -33,6 +33,7 @@ protected function execute(InputInterface $input, OutputInterface $output) > foreach ($allUsers as $user) { > $this->getUserService()->setTraining($user, $season); > } > + $this->getEntityManager()->flush(); 
 Es gab hier gar kein flush() mehr, daher wurde auch kein Training erstellt, wenn man den Command alleine ausgefuehrt hat. Ist das bei den anderen noch drin!?
 —
 Reply to this email directly or view it on GitHub https://github.com/Pogrim/snowboard/pull/25/files#r2263291 .
Any thoughts on how one would add geometries which can influence the dataLim? (just in case: don't do that in this PR :smile: )
Why what? This was auto generated - it follows some simple (yet not necessarily ideal) rules, the main one being no line should be greater than 79 characters.
nit: switch Path to 'var' (following our style guide, we try to use 'var' for local variables.)
Heh, looks like someone was a bit semi-colon happy before.
we dont have favorite buttons abymore, but a short cut ot mark a datum as heckd seems like a useful thing
Attends faut déjà que je merge tout ton bazar avant d'en arriver là... le bordel....
Maybe? It'd require wrapping around a callback that may not exist and would make it difficult to use if you were animating multiple elements at the same time.
Sorry, what I meant was assume that there is a subtree whose root is at /a/b/c/d.  Let's say that e, f, and g are children of d.   Nodes h and i are children of f.  Then


```
chroot = "/a/b/c/d":
    get_children("/") ==> ["e", "f", "g"]
    get_children("/f") ==> ["h", "i"]
```

I don't think that we'll get those results with your patch.
You don't really need te intermediate variable but if you want it you can:

       
      var msg = {
        type: 'user_selection',
        data: uid
      };
nit: scroll is the default, so I think you can omit that here.
we don't need re-slice here, imageblob is what we want here, thanks.
latest decisions where to not show the photo for tight space issues, and show type and carrier for product needs
What about l10n? ... if not using it yet ... can we add at least the string to the properties file so translator can work with it? (maybe is already there :P)
with this requirement no options
Given that we need to load both accounts and calendars to render this view it seems like we can lazy load this immediately after the other views (like your doing now but see comment above) then use a default color for the busybars ( easily done as we have the calendar-color class already ). This will trim off the expense of loading accounts even if we need calendars =/
Perfectly fine with the new behavior of the mozvisibilitychange according to the Communications app (considering the attention screen part of it and not notifying the event). Thanks!
remember we need to kill this...
can you try to use content: attr(data-text); instead?
Yeah they pass because `self.per_page=` is setting a local variable inside the method, instead of setting the local variable in the connection.  

Tests pass with that change because it sets it every time.  


On Monday, August 13, 2012 at 8:07 PM, Clint wrote:

> In lib/octokit/request.rb:
> > @@ -41,17 +41,16 @@ def request(method, path, options, version, authenticate, raw, force_urlencoded) > response = connection(authenticate, raw, version, force_urlencoded).send(method) do |request| > case method > when :delete, :get > - if auto_traversal && per_page.nil? > - self.per_page = 100 > - end > + per_page = 100 if auto_traversal && per_page.nil?  
> If you change this to self.per_page = 100 ... the tests pass again. Still a little confused why :/
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/pengwynn/octokit/pull/124/files#r1369149).  
>  
>  
>
添加了 rs. saveAs(key,source_url, opWithParams) 作为通用方法。

同时，保留了原来的 rs. imgMogrifySaveAs(key, source_img_url, opts, onret) 方法，该方法内部调用 img.mkMogrifyParams(opts) 方法组参，然后调用 rs. saveAs() 执行具体的操作。

img.mkMogrifyParams(opts) 方法生成一个 imageMogr 操作的字符串参数，由于定义了一个有序数组并依此遍历进行拼接，保证了各个参数的次序不会乱排。同时，也减轻了开发者按什么次序生成 imageMogr 操作字符串以及生成具体格式的心智负担。
@Kami fixed in 313ab77
The second line of the commit message states that I also added the collection proxy types.
Removed the junit dependency from pom.xml in this: https://github.com/skyluc/scalatest/commit/ad354822a5c7644ce575c6f783dba46c1019b6b6
new line for consistency
@dkubb sorry man but edge veritas stacks with adamantium breaks DO. see my comment on adamantium's [issue](https://github.com/dkubb/adamantium/pull/4#issuecomment-9859387)
What do you think about moving messages to a different folder instead of deleting them?
Which ones don't? And what would the use?

lib64?
This method should be marked private (renamed to `_movePopup`) because it is not intended to be called directly. Otherwise the pull looks good, thanks!
есть код в контроллере, нет тестов :) непорядочек
It will provide a string, so this should be [ .. ] enclosed
I did, I misinterpreted. My bad. Then it's just me disagreeing with your standards. The reason I use the double parenthesis is because I like to separate the assignment from the assertion. Not to show people that I know why I did what I did. Strictness and readability are key in my opinion here. But if those are your standards, those are your standards.
You mean probably __PHAR__ extension =)
``break`` should be indented
Also, why not just simply:

``` coffeescript
for p in ast.properties when p.name is "name"
  name = p.value
  break
```
Didn't you mean `@attrs ||= {}`? :)
`main` is mandatory. Wouldn't it be better to avoid specifying here so that we have a warning if we omit it?
test-harness ?
This line is from PR #2782.
Though, I see they are pulled from localStorage. Are emails escaped before being placed there? Would my passed the email to `_.escape` be double escaping it?
81c46d5eb7c04bdece490f3c7f28a1430f65404e
There is a lot of code duplication. Mind using helper functions with a loop included?
oups! this seems to be a debug comment :wink:
It seems to me that the intent is perfectly clear when read without it, but I don't care too deeply.
Ugh, that sucks.
alright 75b69eb9bc03d46edc527fbb72fad57150aadb41
I think false is better from a semantic point of view. In this case false means that the error handler has not been registered (because was registered another error handler before).
Aren't we generally using dashes (-) as space equivalent in file names in ZF?
Also, update the preceding comment, as it's now invalid.
I spy missing spaces and use of tabs. You need to rebase again.

// CraftBukkit
if (this. ... ) {
_*Four spaces, not tabs*_    org.bukkit.
How about doing it by default? I mean, we could provide our own base type, which will generate form name from type name.
Is there a reason for swallowing the exceptions here? It might cause us to miss an actual bug since we won't see an unhandled exception while testing.
You do need initial-scale if you dont specify width=device-width for iOS.
Oh, I meant: l 133 and l 231, isn't it the same class defined twice?
please don't add these bundles as they are useless for Packagist.
You can inline this type conversion
WTH is that?
we always used ``{@inheritDoc}``
`$.fn.jquery`

There's no need to initialize an actual object.
Because it's only really needed to facilitate the XHR stuff. It's not used for anything else except $.each, which is super easy to include our own.
since you're using path.join already, don't use '/' in the second part, but join them properly.
you'll notice I copied this from https://github.com/hpcugent/easybuild/blob/master/easybuild/easyconfigs/t/tbb/tbb-4.0.0.233.eb
But yes, will fix...
In the cmt quickstart, Tom said: If you need to redeploy the war then ensure that you explicitly undeploy it first so that databases are cleaned up correctly.

I wonder if he had issues?
Newline before this block
Why is there a // comment below javadoc? Put that into the javadoc.
Nit: but I think it's "non-vouched"? @sammybahamas?
Docstrings are always triple double-quoted.
So, Bobby has argued against doing this since `pointer-events` is technically part of the draft UI spec in css3, and won't be standard until css4 https://developer.mozilla.org/en-US/docs/CSS/pointer-events
If it hasn't been used since 2006, let's remove it.
под убрать ты имеешь в виду Contacts groups API ?
если да, то убрал
I might be wrong, but paranoid: will hit_counter.work_id work when the hit_counter is just being created in the same line?

Or should it be get_stat(:hit_count, work_id) ?
I'm moving everything towards accessors to prevent writing to properties that represent hardware state. An older code that doesn't use that pattern needs to be updated.
I *just* saw the same thing! Should've brought my arduino to the office this morning. When I had createChar working I was also messing around with a smarter way of controlling the rs pin (it was a little too smart so I abandoned it for now)