labofsahil/github-event-dataset-2012 huggingface dataset:
Thats the job of the minimizer. `callback && callback()` is ok in my mind but in general thorax uses WAY too much of boolean conditionals for flow control.

Ex:

    view && this._addChild(view);
    view && view.ensureRendered();
    view && getLayoutViewsTargetElement.call(this).appendChild(view.el);
Should this be ```rdf.defaultUnknownType```?
if two angles is vertical the angles is congruent!
可以在ActionMode.Callback的onPrepareActionMode中去判断。
Nexus doesn't give much in the way of a good, standardized response for bad requests. The next-best-thing is to check what the curl request gives you back and raise an error when its no good.
Good point, how about the update below?
Hmm the idea behind the "import" feature is to be able to import an existing javascript project developed outside of Ares. Which means that the imported project will not have a "project.json" file. Unfortunately, doScanProject will not not import a directory without this file. 

On the other hand, doCreateProject will create a project.json file into an existing project. That's why the button attached to doCreateProject was labeled "Create or Import project".

Did I miss something else ?

All the best
No strong opinion about this :)
Ok, got it. The **order** in which the different calls to eZURLAliasML::storePath() is important. This is not obvious at all ;-)
I agree, but it works, I had to use it for my projects.

I didn't succeeded to point out where the resolution failed for the property file.
don't understand what you were going for here ?
Doh! You are right. :) Sorry for that. Too much regex foo here.
oopsie indent!
Single versus double arrows denote function scope. In this case, the double arrow says that the function is being called on the view. Often it's arbitrary, but if you're running into bugs, scope is one of the first things you should examine in backbone.
As far as I can tell this single class has three responsibilities:

1. It is responsible for storing in-memory, and serializing, commands.
2. It is responsible for the HTTP transport layer that submits commands to PuppetDB.
3. It is responsible for being the queue of commands.

I think that should split this into at least three separate classes, each focused on their individual role in the system.

(I would actually encourage you to differentiate the "PuppetDB command" and the "HTTP layer message" classes, so that the queue can be used for *any* HTTP layer message, and the PuppetDB bits just wrap it to add default behaviour.)
Done. The loop for converting rows to comments wasn't necessary anymore so the userId loop remains.
For users we're only returning the signed large picture url if the user who owns that picture is doing the request.
For groups we would probably want to do something similar.
Only return the large picture if a manager of the group is requesting it.  I didn't want to add that in now, because I think that needs some more thought put into it. Obviously doing a permission check each time we request the group info isn't going to work. Perhaps we can make a separate endpoint for the large group picture which does a permission check.

The large image is only needed when showing the crop widget in the UI, so doing a separate AJAX request for that, wouldn't be so bad.
No space after 'query'.
prevPage is dynamically set, this will just make login's back move to prevPage as it was when the binding was happening, rather than when the click is happening :)
this sorta got snuck in to make compiles thread safe so that multiple executing goroutines on the same template dont blast each other away
...then access it down here as '@mi_attempt' rather than re-fetching it
Where's the changelog?
Please use tabs for indentation, instead of spaces.
Also, `OR` must be used instead of `||` (line 537).
See the [styleguide](http://ellislab.com/codeigniter/user-guide/general/styleguide.html) for more info.

Otherwise it's good - thank you for your effort on this. :)
If you're splitting ternaries into multiple lines - both the possible return values must be on a/the new line, plus their operator:

    // Correct:
    $this->default_controller = empty($this->routes['default_controller']) ? FALSE : strtolower($this->routes['default_controller']);

    $this->default_controller = empty($this->routes['default_controller'])
        ? FALSE : strtolower($this->routes['default_controller']);

    $this->default_controller = empty($this->routes['default_controller'])
        ? FALSE
        : strtolower($this->routes['default_controller']);

... any other forms shouldn't be used.
Okay fixed, committing now
Про красоту алгоритма в задании не было, задача решена методом грубой силы. Но за замечания спасибо.
I'm still not sure this is necessary but we'll see as this progresses
please insert the skip method of PHPUnit : `$this->markTestSkipped('GD driver does not support resolution options')`
Isn't each paragraph supposed to be in a separate `<t>` element?
now avg_obj_time_us.
using {} ?
:+1:  Great!
Beacause it was late and I copy and pasted ;-)


On Thu, Dec 6, 2012 at 7:23 PM, Alexandre Gramfort <notifications@github.com
> wrote:

> In examples/plot_topo_compare_conditions.py:
>
> > +
> > +#   Setup for reading the raw data
> > +raw = Raw(raw_fname)
> > +events = mne.read_events(event_fname)
> > +
> > +#   Set up pick list: EEG + STI 014 - bad channels (modify to your needs)
> > +include = []  # or stim channels ['STI 014']
> > +exclude = raw.info['bads'] + ['EEG 053']  # bads + 1 more
> > +
> > +# pick EEG channels
> > +picks = pick_types(raw.info
> , meg=True, eeg=False, stim=False, eog=True,
> > +                                            include=include, exclude=exclude)
> > +
> > +# Create epochs including different events
> > +epochs = mne.Epochs(raw, events, dict(audio_l=1, visual_r=3), tmin, tmax, picks=picks,
> > +                  baseline=(None, 0), reject=dict(eog=150e-6))
>
> why do rejection for meg channesl?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2338815>.
>
>
For consistency, do you want me to add `mne.read_evoked`?
_preloaded is already set on 952
I am more inclined to use 'auth.User' string syntax because it lazy, and reduces the risk of a circular import. 

Probably not important in this context since User is not importing anything from your project.
You've been removing Refinery all over the place.  Do you need it here?
Agreed - I'm changing to a code block right now on both of these.
Damn. Thanks. New funky 2.0 world. Are they guaranteed to run (being stopped) in order of how stop is called though?
@nateabele  I'll try and add this, and a few other smaller rules, to the rules soon.
¿Podríamos agregar la indicación de "(bug)" aquí como está en los otros documentos?
I was tampering with the wrong branch...
typo here (missplaced space)
Разве колбек не биндится в контекст блока сам?
It's OK to include ampersands in the path part of a URL. http://www.ietf.org/rfc/rfc3986.txt (patch characters are "pchars", which includes "sub-delims" which includes ampersand).

You don't necessarily need to make a change, but you should be ware that this syntax is abusive of URL "path segments". Slash-delimited segments should be the highest-level structure in an URI path. We'd run into trouble if we wanted to support ".." because a proxy could simplify "path1/file1&path2/../file2" to "path1/file2". "file1&path2" is parsed as a single path segment and the dot-segment ".." is interpreted and removed as part of the URI resolution process.

Combobot's interpretation of the URL would be more aligned with the standard URL semantics if we also replaced file-path slashes with a "sub-delims" character, such as a comma.
NGHUTPR (of course)
"raises" instead of throws for or we'll revoke your Pythonista badge.
Shouldn't we check for SKIP_REMOTE_LOOKUP and IGNORE_RETURN_VALUES as well?
Single Phase Commit
Ok Dan, since we already agreed on the approach Mircea suggested I'll add this ThreadPoolExecutor with a CallerRunsPolicy comment so users know about potential side effects. Thanks a lot for this point!
@Test missing...
+1

Also, there is no synchronization around this method, so it's possible that another thread already acquired the same lock and we're overwriting its lock in the container. We should not be removing the lock until we know we're the right owner.
If you use the following instead, you get support for masked triangulations:
`triangles = tri.get_masked_triangles()`
I haven't fully tested this.
Sorry I didn't notice this before, but we need backticks around "pcolorfast".
Yes -- that, in a nutshell, is why I'm not a fan of "log" being a kwarg to this method.  You may want to hold of on implementing any sort of fix for this issue until we discuss it -- it may be best to just leave as-is.

@efiring, @WeatherGod, @pelson: any thoughts?
Couldn't the result of get_aspect be the string 'auto'?
Sure.  But I want this docstring to be human readable as well.
This makes it available in the symfony debug bar, which was useful for testing and debugging. We could remove it though.
Fixed here and in participants, memberships and library
The "administrators" group should have the same access to content as the "admin" user. It no longer makes sense to put Group.ADMINISTRATOR_GROUP ACLs on things.
Isn't this redirecting to install.php now? Probably a good idea to name these rules to what they're actually doing.
left-over from the tester file, I'll change that.
because this is for the test suite, which doesn't need to contact typekit every time we run over 9000 tests =)
After reading through the LESS documentation something like this should work and cover all the cases:

    // The names of these macros are terrible...
    .x-float-prev-next(@prefix-and-dir) {
      float: @arguments;
      &.previous { float: @arguments previous; }
      &.next     { float: @arguments next; }
    }

    // There's probably a better way than enumerating the cases
    // but that may require fancy string-work
    .x-float-build(page, top)      { .x-float-prev-next(top); }
    .x-float-build(page, bottom)   { .x-float-prev-next(bottom); }
    .x-float-build(column, top)    { .x-float-prev-next(column-top); }
    .x-float-build(column, bottom) { .x-float-prev-next(column-bottom); }

    // @scope can be page or column
    .x-float-top-bottom(@scope) {
      .top    { .x-float-build(@scope, top); }
      .bottom { .x-float-build(@scope, bottom); }
    }

    // Generate the floats when in a span-all and when not in one
    // (This macro may be unnecessary)
    .x-floaters() {
      .x-float-top-bottom(column);
      .span-all { .x-float-top-bottom(page); }
    }

    .x-floaters();
See my comment for abstract_request_handler.rb.
Are you sure ``$this->pool`` has the correct type as "string|integer" is not a sub-type of "string"?
В гемспеке явно указано, что require надо впервую очередь из lib. (см [ссылку](http://docs.rubygems.org/read/chapter/20#require_paths))

  gem.require_paths = ["lib"]

ну и

    #gem uninstall uni_sender

    Select gem to uninstall:
     1. uni_sender-0.0.3
     2. uni_sender-0.0.4
     3. All versions
    > 3
    Successfully uninstalled uni_sender-0.0.3
    Successfully uninstalled uni_sender-0.0.4

    # rspec spec
    ............

    Finished in 9.49 seconds
    12 examples, 0 failures
The if and else of this seem to be doing the same thing. Am I missing something?
This is cool, I'm curious if we should put README in this directory explaining that not all the files in here are necessarily used by the code, unless they're explicitly imported into `../badge-ui.less`. I guess I just want to make sure it's clear to future developers that not everything in this directory is "in use", so they don't go crazy wondering why e.g. `pulse.less` isn't used anywhere in the code and end up deleting it from the repo. But perhaps I am overthinking things.
Let me retract that... I totally see the win!  Doing just that!
`service` field should be on its own line.
I must say that I don't understand this method. :-)
No need for extra lines.
Why `?` at the end?
These shouldn't be necessary
I'm really unsure of this fix, because I'm not sure what sub_level is trying to accomplish. 

It does make a bit of sense to me that end == 1, because in all the use-cases I can think of, you're dropping the "/static" portion of the absolute path (ie url("/static/foo/bar.png"))

Ultimately I'm not sure what all the edge-cases are that this code is trying to handle. All of the staticfile regression tests pass with this change, but perhaps it needs more test cases.
As far as I can tell, no.
Why this test has been commented out?
haha whoops!
I wonder if this would read better as just "CreditCard#type is deprecated and will be removed" etc etc.

"Support for x" makes it sound like we're removing a feature, and doesn't immediately make it clear what's being deprecated.
wrong querys?
Wrong order of parameters, you are passing players guid as flags
Also, set flags to 1 if achievement->flags & ACHIEVEMENT_FLAG_SHOW_IN_GUILD_HEADER
Ogod, this is going to make me have to rethink how to handle pre-provisioning. Thanks for pointing this out!
`string.Format`
actually, it would be great to be able to detect it for the closing curly brace before ``while`` in a ``do/while`` construct, but it may be more difficult to detect as ``while`` can also be used alone.
Try to split and comment the deps as we add them. Nessus XML RPC is definitely unrelated. So why is it on the same line? Makes branch / merges / patches more difficult to handle than it should be. It's not the first time I insist on that.
>  You're attempting to shadow. It's discouraged, but certainly possible.
You'll have to do it explicitly

I am trying to do it explicitly but Jeremy is stopping me.  Putting it in
an argument is a much worse kludge than using var.

And why is shadowing bad?  I view shadowing as an important tool.  I want
to be able to write isolated code that doesn't interact globally.  Hasn't
anyone heard that globals are bad?

Right now CS is ignoring common wisdom that is used in most languages, JS
being an exception.
we may as well still include the tests from capybara, even if we're adding extra ones too
I was wondering the same thing. I thought you'd want to create a temp dir under the location "mapred.child.tmp" refers to, but it seems Hadoop sets java.io.tmpdir for the task so you're ok as implemented.


http://lucene.472066.n3.nabble.com/Creating-and-working-with-temporary-file-in-a-map-function-td3893392.html
I'd indent the braces and the body too.
Just link this file from the src directory.
You're right, we can use `c_str` here because `options` is frozen.
UseRandomPort would be better than RandomPort.
This is pointing at the wrong branch.
these are the only two methods that are allowed, not necessary
we should raise a valueerror at the beginning if the method is invalid
It's tested in the discrete models PR for the marginal effects for MNLogit.
I like it. Will put something together for review
Il faudrait vérifier l'existance d'events avant de faire un appel à `date`.

Après un déploiement, l'application ne démarre pas faute d'event présent.
Une bonne pratique consisterait d'ailleur à avoir un `Event.last_date` ou similaire :)
Why not set just `title` to *Login*?
This new line 8 in tests/test_main.cpp gives a warning on my machine:

tests/test_main.cpp:8: warning: unknown option after ‘#pragma GCC diagnostic’ kind
The description node in the sdk we don't normally use.  If you are going to use it, it should prolly be different than the PerMerchant listed below.
You should probably leave these blank rather than have a default that won't work.  Documentation in the README can describe how to use it properly.
If treating as singleton (with static INSTANCE field etc), then should constructor be private?
Well noted. I will fixes it.
I wonder if this should be an atomic operation?
Yep, already there
No, it doesn't, we set it manually anyway, I just forgot to put it back to 0 in designer.
I missed this before but please add an alias to attributes not following snake_case
Please don't do that for all fields, but only specific fields that we know can contain a slash. The problem is that we decode those double encoded slashes on the middleware only for some fields (signatures only at the moment). This should be unneeded here.
this method has the tag `@api` you could maybe use a setter injection ?
As this is a public interface, I wonder if we should not remove it until at least the next major version and instead rather mark it as deprecated.
Maybe is just the lack references on unit tests.
Looks like the live above can be removed.
Не только пробел и табуляция разделяют слова.
Зачем, если это делается в finally?
Название не по СС
I think your example got cut off from the comment, Colin :)
Never had an issue with this type of declaration, would be very interesting to see a "problematic" one.
Some comments in these definitions would help a lot to get people understanding what they are doing here
typo: I believe you meant pending_state
しかし、よく使用されるGORM APIの大部分が
↓
上記以外の、よく使用されるGORM APIの大部分は

意訳ですが、「しかし」だと文脈のつながりが急すぎる気がします。
please don't use upper case letters for variables names (unless they are a 2D datastructure).
`can not` or `can't`
I think that the best way to do this probably to design these matrices so that such logic is not necessary.

In other words: can you make those matrices so that they always have the same number of dimension, with the option of having a dimension of length 1 (i.e. a fill-in dimension).

Please pardon me, I my remark is meaningless, I am still digging in the code, and do not have the big picture. That said, this is also why it is important to have tight code only with the abstractions that are really necessary.
But you've allocating a new array with `zeros_like` only two lines before.
Same remark about moving this in the docstring.
@agramfort I think you might be onto something, especially if we could hide that from Sphinx, maybe via an rST comment...?
* why
* are
* you
isn't this repo automatically added for SBT 0.12 btw?
убрал из ридми
hrrnngghhhh
it seems like here would be a good spot to try/except the ReviewError and raise a util.Abort causing any other wrapped extensions (or chained shell commands) to fail in the normal, non stack trace-y way (unless it's gauche to catch your own exceptions, your call)

```python
    try:
        reviewers = _get_reviewers(ui, auth_token, opts.get('people'))
    except ReviewError:
        raise util.Abort('No reviewers found')
```
ooh one thing here. we should filter the local packages for vcs names before asking the aur for info. try to keep the request minimal. something like

```python
vcs = [pkg.name for pkg in self.repo.packages if re.match('-(?:cvs|svn|hg|darcs|bzr|git)$', pkg.name)]
#...
Aur.packages(vcs)
```
In a way, yes.  But not exactly the same, of course.  This would be list of "only these fields we want to be checked against defaults" while the rest of the fields will appear regardless.
Yes, but that doesn't meant it should not be implemented for BB
You shouldn't need to require this in
Awesome, I was wondering what a nice solution to that would be. You could also replace `let position = bulletPosition bullet` with `let (x, y) = bulletPosition bullet`
These links will be to the EDIF wiki, which doesn't exist - so, could someone create the wiki please so I can get started on it? :)
Gavin wrote:
>What is this static_cast doing? Why is there an OwnedHThorRow here?
indentation slightly out.
This change is unrelated to the previous one
I can remove those changes.
This is not perfect, but creating a new variable just for that is a lot of trouble to the compiler throw away.
platform.h is not directly included, but seems to be pervasive enough.  verifying EE build now.
Am I going crazy or is this not in crashstats/urls.py?
I don't disagree, but i don't know of an easy way to do that. I can change the library location in the project to something else, but that has its own set of problems.

On Sep 19, 2012, at 3:46 PM, Tom Prince <notifications@github.com> wrote:

> In master.cfg:
> 
> > @@ -291,9 +291,10 @@ c['builders'].append({
> >      'factory': BuildFactory([
> >          gitCheckout(),
> >          gitDescribe(),
> > +	ShellCommand( name="link iOS libs", description="add sym link to iOS static lib directory", command=['ln', '-s', 'lib', 'build/apple/ios/lib']),
> As I mentioned on IRC, this would be better handled by providing a way to configure this via the xcode commandline.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Tested on Linux.

If someone sends me a Mac, I will test there.
can you please install to org.nemomobile.qrencoder (name up to you)? keeping everything inside our "namespace" would be nice

also, use $$[QT_INSTALL_IMPORTS] instead of hardcoding /usr/lib/qt4/imports/
setEmailAddressType I think would be more readable naming
this does not look correct. These are osfamily specific param defaults. Why do you have a fact here?
faultstring HTML got stripped I think :/
The Version field isn't needed anymore.
only works, or works best?
You can probably combine the comments into one line:

```python
# CIE LAB constants for Observer= 2A, Illuminant= D65
```
Does this work if PIL is not available?
This isn't a very descriptive test description - should *still* match despite ... what?
Typo: "Du hast also"...
I think that what you're looking for is `pages<i` and for i to go unaltered on line 25
@shunter what do you mean by more garbage?  Memory wise you mean?
http://jsperf.com/isnanfunc-vs-isnan/2

isNaN is slower, but typeof epsilon === 'number' does not handle all cases that isNaN does.  This is right in line with your other error-checking comment.
Make sure you use === instead of == in your comparisons.  JSHint catches these and you should have that configured as per our contributors guid.  Just make sure to check the problems window whenever you are submitting new code.
Nevermind, I found it.  It is `CommandLists.js`, and I was expecting `CommandListsSpec.js`.  In general, we have always added the `Spec` suffix; however, it looks like a few files don't have it.  I guess, I can go either way as long as it is consistent, but I think having the suffix makes identifying files easier when opening files in Eclipse with Ctrl-Shift-R.
Let's leave it as cleanup for a future sprint.
An ERRORLEVEL check would be nice.
This parameter is ignored on IOS. IOS always returns all the people
I would remove the words "after a write" since it returns the browser's user agent before a write too.
What's the reason for the non-zero exit code upon completion?  (There should probably be a comment explaining it.)
Josh: That's what I thought from the bug description, but it is NOT what I saw in testing. The table above describes what I'm seeing in testing on all 3 platforms. Here's my test code:


```
Ti.UI.backgroundColor = "white";
var win = Ti.UI.createWindow({
  exitOnClose: true
});
var mapTypes = [ Ti.Map.STANDARD_TYPE, Ti.Map.HYBRID_TYPE, Ti.Map.SATELLITE_TYPE];
var mapTypeNames = [ "Standard", "Hybrid", "Satellite"];
var currentType = 0;
var mapview = Ti.Map.createView({
  mapType: Ti.Map.STANDARD_TYPE,
  region:{latitude:33.74511, longitude:-84.38993, latitudeDelta:0.5, longitudeDelta:2.5},
  animate:true,
  regionFit:true,
  userLocation:true,
  height: '80%',
  width: Ti.UI.FILL,
  top: 0
});
win.add(mapview);
var label = Ti.UI.createLabel({
	text: 'Standard',
	width: Ti.UI.FILL,
	height: '20%',
	textAlign: Ti.UI.TEXT_ALIGNMENT_CENTER,
	color: '#55f',
	bottom: 0
});
win.add(label);
win.open();
win.addEventListener('click', function(e) {
	currentType = (currentType + 1) % mapTypes.length;
	Ti.API.info("Setting map type to: " + currentType);
	label.text = mapTypeNames[currentType];
	mapview.mapType = mapTypes[currentType];
});
```
why view.getNativeView() instead of v?
The remember and forgets probably should be outside the viewAttached. They represent the relationship of map to annotations, regardless of it it's onscreen yet or not.
I think you can set b.text here instead of b.innerHTML.
Catch ClientProtocolException per the spec. Then use if instanceof HttRestResponse.
Ну можно абстрагировать как упорядоченный словарь. Идёт?
сделай 

> http://cl.ly/image/2D1A2R2R2V0H - эти картинки должны быть бледными, если вкладка не выбрана, и нормальными, если выбрана (уточни у Толи, если че) (Дима С)
There is a useful feature in Guava for this :-)

import com.google.common.base.Strings;

String elementName =
    Strings.nullToEmpty((ComputerSystem) modelToUpdate).getElementName());
By the way, how many functions that do arbitrary type recursive processing are in my pulls? Four functions. And every one uses `asFlatStaticArray` to reduce its complexity (branches count). And `_initializeFrom` without `asFlatStaticArray` will be far more complex.
So, as often last time, I don't understand you opinion at all.
Hum... I question the `isDynamicArray`: Wouldn't this fail on:

```D
join(["a", "b"], "日本語"d);
```

Reserving 5 elements, when you'd actually need 11? or vice versa,


```D
join(["a"d, "b"d], "日本語");
```
Reserving 11 elements, when you'd need only 5?
Not a deal breaker, but consider putting these in your global excludes file, usually ~/.gitignore.  Run

`git config core.excludesfile`

To find out where it is.  I'm fine with having it here, but you can have all sorts of files in your global excludes (*.pyc, .DS_Store, *.o, ...)
This will be able to keep track if it should call the listener ( if something has changed )
Isn't the schema part of the impl? [It is updated](https://github.com/hibernate/hibernate-validator/blob/master/engine/src/main/xsd/validation-configuration-1.1.xsd#L42) in HV 5 already, or are you using some other schema?
Not used => kill it.
maybe we should stick here too to the structure that the services should be passed as constructor argument instead of a setter
Maybe we should make this extensible?
I'm thinking this should probably be WS-Discovery specific?
Should we change ro \PSU while we are here?
space missing after the ``elseif``

interesting .. i never knew about this optional param.
I don't think we should put negative examples in the docs.
Hmm, it does seem reasonable but I will need to think about how to integrate this with the existing clients .. rest of the PR looks good.

I'll take the `.patch` from the PR and create a new development branch to sort out the release/versioning.

Thanks!
Would there be any downside to just setting the width to 9999?
You're right. I got confused by the user comment. I'm leaving now, but I can take another look at it tomorrow.
変数名はローワーキャメル記法で統一しましょう。
cameralabel => cameraLabel
hier würde ich $this->auto = true setzen
Please use Zend Framework or ZF.
Should be on the next line
does it really make sense to use an empty string as node path ? Seems to me it is broken
slider and canvas styling. (this file needs to be cleaned up a bit it seems)
I did it so it rimes with an IF statement since the NEGATIVE is what I care here, but i'll change if you insist
Ditto Document
What if there's an escaped ';' or one inside a quoted block? Is this possible? If so, you'll need to handle this differently.
this is my only concern right now. This may cause the script to break for people who are not setting a floating IP.
my bad, fixed.
Avoid `"#{...}"`; instead just do `self.class.google_secret_column.to_s`.
Im pulling it now. Should I send you a pull request after?
better than including a sqlite file would be providing some fixtures so peaple can use whatever (also no git conflicts etc)
Could use AsyncMockStubber to mock success and failure
Ok, this functions are already present just below in the section "For actuators"
Sounds good. And... done.
This one as well? It should be covered by the later tests.
Same here.. If(o.obOrientationChange) should work
I've now added a library_loaded() function that generalizes checking for libraries in the head section (among a few other features).
URL need to be updated :)
typo: attache
We follow a general rule of having the log tags match the name of the class, and also make the tag constant in the class. This is for easier filtering
Probably the code should be just removed. That looks bad. what was happening, is when you moved your mouse over the line, the border would light up. The broeder was drawn as a line that is slightly thicker underneath the actual line.
Are you objecting to the extra space I accidentally added, or to the safe=True changes above?
this function has been updated with your suggestion
This constant is also used when creating Ti.Geolocation.Android.LocationProvider and Ti.Geolocation.Android.LocationRule objects.  This makes it sound like its only valid to use with preferredProvider.  This is also being deprecated and moved eventually to the Ti.Geolocation.Android namespace
Verify all permissions "were" added correctly...
@joshmoore: Needless `List` import?
hmm, i never noticed this issue, but that might be quite possible. leave it at 11 and I'll play with it when I merge this in
I know it doesn't matter, but if we're duplicating logic might as well move it to a separate function
@kwallis ??
Uh oh. Typo. I'll have to recommit to fix it.
remove all transients