labofsahil/github-event-dataset-2012 huggingface dataset:
Wouldnt hiding the stderr make debugging more complicated (e.g. I dont see a 'command not found')?
It sort of does - `keys` builds on `enum` in a straightforward way.
Then your doing it wrong ;)
you can use vprint_good() next time instead of having "if datastore['VERBOSE']"
Done: 84f8c72a881c3b85461289eadb4d84cb8af38a34

I'm not sure if we should explicitly ban using `;` on a non-empty line, but we could not mention whether it works in the documentation and disable its use.  We could eventually decide we don't need to use `;` and re-enable it.
This looks really great. Fantastic work!
Makefiles here aren't really needed,but currently using them. Need an update.
Changed the name so that you can create a file called CloudyBuild.properties in your home directory
Hey Ed,

What I have implemented is basically when you create the Library it sets the implicit wait based upon the timeout value, this is because in my opinion with webdriver implicit wait functions like what people generally refer to as a timeout.  Then there is also an optional parameter in the open browser function where you can pass in a new implicit wait which will overwrite what was set when originally creating the library, if nothing is specified it will use the original value that is set when the library was created.

Currently the get implicit wait function just returns whatever the last value set for the implicit wait function (i.e. it doesn't map implicit wait to the current browser) mainly because I don't really see a need for it.

Do you think this solution is sufficient?  If so I'll go ahead and check it in, otherwise what do you think should be the correct solution?

Cheers,
Jeremy



On Jan 2, 2012, at 6:21 AM, Ed Manlove wrote:

> On 12/21/2011 08:58 PM, j1z0 wrote:
>> Ed,  I'll pull ur branch today and have a look. I've just finished similar changes more on the implicitly wait side and I just want to make sure they merge with ur changes. One question for u. Originally all the set timeout stuff just set a class level var in the browserManagement class that effected the next browser creation. This obviously had issues, especially with get timeout returning the proper value. But I wonder is there a use case where u might have multiple browser open and different timeouts per browser?  Or is that just a case of YANGNI?
>> 
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/emanlove/robotframework-selenium2library/commit/7a373b99e3e1a0b7789efc25aaa09c226830ee4f#commitcomment-814610
>> 
> 
> Jeremy,
> 
> How is your work with implicitly wait coming along?  I am temporarily 
> diverted working on integrating robotframework with Plone's testing 
> framework and should be back working on implicit wait soon.
> 
> Ed
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/emanlove/robotframework-selenium2library/commit/7a373b99e3e1a0b7789efc25aaa09c226830ee4f#commitcomment-830568
this comment, content and grammar, recaps basically my entire history as a programmer
Yo the git is not letting me edit in browser (it should...its telling me im not part of the branch, if i could get added itd be sweet as id like to avoid dumb commit issues in the future so with that in mind...im adding comments next to some lines that i think should be changed. Setting the Color defaults to white are a bitch because after you fuck with the status bar good luck trying to get it back to ICS grey....thats where these new hex values come in, this is stock ICS grey and i think it should be the default value....
@nvie Yeah I actually like things to be more explicit as well. 

What I don't like about ``@job(connection=Redis())`` is that we're still not telling it which ``queue`` to use, only the Redis database. I think having people write ``@job(queue=Queue(connection=connection))`` is much better.

Also, what are your thoughts about making the ``queue`` argument required?

Regarding ``timeout``, I think this breaks the usual RQ patterns where ``timeout`` is set on the ``Queue`` level, rather than on the ``Job`` level.
Could it be an `array-flatten` submodule in `collection`? I'd use it.

Different implementation without `reduce`: https://github.com/juandopazo/yui3-gallery/blob/master/src/gallery-deferred/js/Promise.js#L155
You mean the theme properties ? Why not keeping the theme concept for UI customization ?

However, I plan to clean CS / JS / images in a third pull request for CAS-1183 : https://issues.jasig.org/browse/CAS-1183?focusedCommentId=27671&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27671
imho it's more legible, but I'm not really bothered.
True. I think I've removed this TODO and updated the docstring to reflect that a default is determined somewhere else. That change is in the tronview_cleanup branch as well.
Yeah, we could always create our own Function0 for the class-case
That doesnt seem to work : stable identifier required, but ConcurrentActivationTest.this.system found.
Doesn't the RemoteSystemDaemon have the remoteSettings?
My explanation was probably insufficient. The only IP I name as "local" is the IP which is accessible from the internet. I am not supporting multiple addresses here.  I am supporting a single address, the one that corresponds to the NAT (my router).  If my internet IP is 74.74.74.74.  This is the only IP I can send to, I cannot receive messages via the IP in my internal network.  If computers in my internal network want to send messages to my NATed ActorSystem then they MUST send to 74.74.74.74 as well.
    
    //This is how I am using it currently.

    //automatically find and map a port on my router, this maps port 2552 for my first PC and 2553 for my 2nd ,etc.
    val routerConnection = new Upnp().routerConnection
    val ip = routerConnection.ip        //74.74.74.74
    val port = routerConnection.port;
    
    //configure to use my modified akka.remote, with the Ip and Port for the Router
    val natConfig = ConfigFactory.parseString("""
    akka.actor.provider = "akka.remote.nat.RemoteActorRefProvider"
    akka.remote.transport = "akka.remote.nat.netty.NettyRemoteTransport"
    akka.remote.netty.force-bind-address = on,
    akka.remote.netty.hostname = """ + ip + """,
    akka.remote.netty.port = """ + port)

    implicit val system = ActorSystem("node", natConfig)

Currently I can already use it to stream voice P2P (both directions). Such that 74.74.74.74:2552 communicates with 74.74.74.74:2553.  If I tried to have my internal network 192.168.10.246:2552 and 192.168.10.248:2553 try to communicate it would not work under this setup, which I think is what you were getting at, I would need to identify a second local IP. I know this wouldn't be sufficient for all use cases, but this was simple to do and is the only way I could get Netty to bind to my external IP.

My main problem at the moment is I feel like my test is terrible.  Since it needs to be manually configured against the router IP and it is just going to fail unless I disable it by default. But if I disable it by default then it will rarely get tested, so what good is it. Maybe I should just be testing that 0.0.0.0 gets set properly so I know "force-bind-address" is working.
The supervisor can also watch the caller and then shut itself down upon receiving the Terminated message. This means that the target cannot expect to do anything after having replied, but that is a reasonable limitation in this context.
Parens?
Can I use pipeTo with failed futures?
Meaning the Account class, yes.  The diff is really weird, here, but I suppose that doesn't really matter.
Yes, and with a small set of cucs that run on the plain (not test data seeded) to test setup and a few other end-2-end things.
If the shape refers to spatial dimensions (as ``X, Y, Z`` normally do), then I think it makes sense.  Otherwise, we should define the parameter or use a different symbol.  Typically, one specifies the dimension somewhere, e.g. "GradientTable with N b-vectors" and then later on use "N" again.  I'll leave it up to you.
@tobes No it hasn't been done if you look at the file, maybe just that the diff is misleading. I think this will get done soon though as I have a ticket to refactor the group activity stream because the page loads for it are ~30s on pdeu's data
No, I think they are just left over from the previous script. I'll take care of them (if you know what I mean…)
Type of what? Need to do more than reiterate the variable name.
Is it the test or the code?  What is the specification for this feature?
faster/easier
Perhaps I'm missing something, but I don't get this logic.
А,,, ты переделал вид. Понял.
Lists are mutable and if I specify `corpora` with default value directly to a list, this list will be created in the class definition and **will be the same list** for all objects! So I need to create the list on every new instance.
An example that can clarify it:

```python
>>> def answer(value=[]):
...     value.append(42)
...     print value
>>> answer()
[42]
>>> answer()
[42, 42]
>>> answer()
[42, 42, 42]
```
`j-EDGARHOOVER`?
Would it be possible to add some installation guidelines and a few very simple usage examples here, for the benefit of R newbies and those not willing (or able) to download the repo and generate the full documentation?  A summary of the features offered by the bindings could also be useful, no? (and, time permitting, i would kill for some graphics as Adam does in bigmlcom/histogram)

(If all that information is in the generated docs, and roxygen can generate html, an alternative is to put those docs in the repo html "pages" and uploading them there by hand, with this readme linking to them).
printk should in general be protected by debug #ifdef.s
Would recompiling them with jarjar work?
looks like nested if-if while being nested else-if, please put else on the next line and omit the braces
what if handle is null?
I'm working on the whole text engine piece by piece. I'm currently factoring a bit of the work into `TUITextStorage` which is a subclass of `NSMutableAttributedString` that can handle itself (much like `NSTextStorage` but more!)
These aren't used anywhere. They shouldn't be defined if they can't be used.
Tabs instead of spaces. Same goes for all the other `move*` methods.
Oops! That was my bad, I'll fix that.
It's in the interface, so I think that would be confusing. These should probably just be removed, but I was more focused on translating them.
I was unsure if sysctl was supported on solaris which is why I didn't use it. I'll modify the code to pull the value from there rather than the static value
I would prefer it if you fixed all of the docs but I won't force you to.
is the unref someplace else in the code?
The rest of the documentation is not in the right place. `prody_blast` needs to be documented.
This should be done with a call to ``os.path.join``. For example:

```
from os.path import join

join(get_qiime_temp_dir(), %s_commands.txt" % prefix)
```
We are missing handling of: "using defaults 'p2' = 'some default'" as specified at this link: https://github.com/ql-io/ql.io/wiki/%5BProposal%5D-Optional-Inputs-and-Errors
вылезли за 120 символов
doxygen-комментарии к методам лучше в заголовочном файле писать
это что-то странное
Dalli's increment/decrement are returning integer values or nil (You don't have to use ```response == Response::NOT_FOUND ? nil : response.to_i``` anymore)
NVM - I see.  This  adds the cloneable class as a parent.  I was misreading what this method does....
I would suggest using one of the Flags helper methods. In this case case it is isParamAccessor.
I'll fix it. Thanks.
Apparently only folks with admin rights to a repo have access to the big "This pull request can/not be automatically merged" bar. It just became apparent to me right now, but most contributors have no visual indicator of whether or not something merges cleanly. Mental note added.
`TODO(jochen):` ?
Do you mean cb3bf49a962925aa9aa4347a06b1669793ae6828?
Wow, I've never seen that operator before.
Would Coord work instead of Point?
I guess I am leaning towards `entropy` being a method of the density op class.  What do you both think?
Often (most often) sympy functions should return sympy object. Why are you returning an int instead of Zero?
Why not make this a `Basic`?
Hi Juicyfruit, why include limits.h here once again?
I'd prefer if all our time options took the same units
Useless empty lines here.
Same here, for `data` and `sismoenv`
> Granted, as far as I'm concerned, "site" is just an index value. I'm using the hostname of the remote service because I figured it'd be easier for folks to work with, but it could be any string value.

If this is an index value for your use, why bother developers with it? You can use the push URL as an index and keep the protocol simpler.
I'm thinking of changing this approach, while it is comfortable to use it seems kinda wrong because we have more and more member methods and functions, i.e., names which parameters cannot be like I cannot make a parameter called parameter:
Params.parameter('parameter', 3, 'desc')
Because it will override the definition function (parameter method).
I think of using simple hash and set and get methods, maybe with []
Params[:parameter]  # with symbols
Params['file_path']  # with strings
Don't know what better.
Test does not work well:
1) it is not being executed from 'rake' command (I will look into that).
2) When executed manually:
ruby -Ilib test/run_in_background/tc_run_in_background.rb
The output is:
<internal:lib/rubygems/custom_require>:29:in `require': no such file to load -- win32/service (LoadError)
	from <internal:lib/rubygems/custom_require>:29:in `require'
	from /Users/kolman/Dev/bbfs/lib/run_in_background.rb:30:in `<module:RunInBackground>'
	from /Users/kolman/Dev/bbfs/lib/run_in_background.rb:26:in `<module:BBFS>'
	from /Users/kolman/Dev/bbfs/lib/run_in_background.rb:4:in `<top (required)>'
	from <internal:lib/rubygems/custom_require>:29:in `require'
	from <internal:lib/rubygems/custom_require>:29:in `require'
	from test/run_in_background/tc_run_in_background.rb:1:in `<main>'
I've refactored the parameter application to give meaningful names to each function parameter.
Yes, this was my concern too and wondered if it were better to cherry pick the data. With that said you would "hope" that users wouldn't install any old style they found laying around ... but ofc "hope" and "reality" are two different things.
You can remove one of the two spaces in front of the "or" since you're touching that line anyway.
It was because a change was made in events dispatcher and in ledges-2 which conflicted which resulted in this. Not much of a problem to be honest?
MyISAM should update some rows, InnoDB won't update any just like PostgreSQL. The default used to be MyISAM which is why this solution worked fine back then.
Yeah best setup your editor to remove all trailing spaces.
You cannot set the style_id. This works on MySQL but not on many other DBMS because it's an auto increment column. You need to retrieve the id it actually got by doing a SELECT after the INSERT.
lang => language
They could be moved to `movie.js`, since they’re only used there. Maybe it was too future-proof to make them available as mixin.
The YUI config object doesn't have a "perf" key, so why are we setting this here?

http://yuilibrary.com/yui/docs/api/classes/config.html
Tssk tssk :)
Don't hard code in user/pass
Yes, I suppose there wouldn't be very much need to POST patientLists, as they would change every day. For screener, at least, it would mostly be GET calls. Follow up question -- 

In OPD module, we need a list of patients assigned with a screener encounter to a particular provider on a particular date

1. would we be able to use this PatientList for listing patients in the OPD module as well, searching for encounterType of screener for that particular day? And then somehow cut the list down to a particular provider?

or can we

2. search encounters by provider uuid, and then somehow cut the list down to a particular date?

I think option 1 might be best, and we can add a provider option in the call like searchQuery=.....&provider=<uuid for provider>
As mentioned by @jaberg, I could use dimshuffle(0, 'x') here, but I found this formulation (1) closer to what one could write with numpy, and (2) more concise ;-)
Try to stick with absolute imports (and to convert existing relative imports to absolute when you spot them).
Implicit relative imports:
   * Can be confusing (see http://www.python.org/dev/peps/pep-0328/ for why they removed them in Python 3)
   * Can lead to funky behavior sometimes (especially when imported within an executable script, which can lead the same module to be imported multiple times)

Although it's probably harmless here, better try to stick to absolute imports everywhere as a general guideline.
We need to support python 2.4. It don't define any(). Can you add this import to enable it:

from theano.gof.python25 import any
I assert m_node->getPredicate() to be null just after I get the m_node initialized and remove m_needsSubstitutePostExpression member. Do I get your idea or not?
I don't think defaulting the hasRank parameter is worth the effort -- make it mandatory. Same comment applies to ...UniqueIndex.
All right, I can change it.
create_*
No ``tracker_name != 'JIRA'`` but ``settings.ISSUETRACKERS[tracker_name]['ENGINE'] != 'JIRA'``
hmmm i'm still a bit not sure on this. we have livescript already etc.

How about reading test root dir and `files.filter((file) -> /^test-helpers\./.test file)[0]`?
You're right in that this code would not work in Python 3. I have another commit which fixes all similar failures to make the code really compatible with Python 3, but I might as well fix it directly in that commit.
no need to use the braces around the condition
Clearly you haven't read http://bugs.jquery.com/ticket/12365 !
That's an interesting observation. I'm going to revert this block, but think it merits more discussion. I'll also readdress the performance bottlenecks, because you do have a point there.
Also Oxford comma and the end of this line:

> swift, secure, and small
This table stores the item id and transaction IDs for this id. We use svec to represent the transaction IDs.  Therefore, we can easily get the common transactions of two or more items by multiply theirs svec.
Actually, construct_array calls construct_md_array internally.
Weird... well that could be investigated and fixed later if need be.
Make this stand out as a warning box perhaps?
I think this should be "Reporting a problem for…".
I think it might be useful to have more than one description for a docurl, and more than one docurl for a config in our test data.
Or it sets the value of `selector` to whichever value happens to be arbitrarily last out of the returned keys, but looking at the return value of `get_properties` there's only ever one key, so it "works". But it's weird. There's no reason for `get_properties` to return a dict if it will only ever have a single key in it.
Always name closures (or unanonimize them if you prefer), it eases a lot debugging :)
Same comment as above - the point of the options array is to pass metadata about a command to this method.  Adding _metadata is redundant.
Be consistent with usage of c.option here (no parenthesis vs. parenthesis) with above
Thanks @evert  :-) I just wasn't sure if throwing an exception would be the proper thing to do here. There's a bad tendency in ownCloud to not use exceptions at all and just return booleans - you're right about that btw. @LukeOwncloud - so I'm trying slowly to introduce it without breaking compatibility ;)

@LukeOwncloud Thanks for catching this. I'll implement it in master branch catching any exception and throwing the appropriate Sabre* exception. I had thought of making custom exception, but haven't gotten around to it. Maybe an OC\PermissionException where the code argument is the appropriate OCP\PERMISSION_* ?
If you're up to it, you're more than welcome to implement it for the stable45 branch?
I spend the better part of a day researching for the best way to do this, and the general consensus on the interwebs was on this approach. For sqlite this was the only way I could find. Certainly not efficient, but gets the job done ;)
But I know preciously little about databases, so I'm open for suggestions.
Yeah, I think this is preferable actually.
Yep! Tx. :)
And another non-descriptive string constant as an error code
should likely be c.is_wiki_mod or something
With ModuleResolver, I think it's Generated, Reflective, LegacyGuice.
Off topic: I'm going to try to remove all of the `@author` tags from our codebase. This is a job much better served by 'git'.
Do you have any idea how I could implement the features I want.

I could like to simulate:

cp *_content body

and

cp document_* body

The problem is if you got 2 or more matches.


On Wed, Oct 31, 2012 at 10:02 AM, Roar Granevang
<roar.granevang@gmail.com>wrote:

> Yes. I agree. Olof just spent 15 minutes explaining it to me.
>
> Please don't accept this pull-request. It is just stupid. :)
>
> On Wed, Oct 31, 2012 at 9:40 AM, Joel Westberg <notifications@github.com>wrote:
>
>> In
>> stages/processing/basic/src/main/java/com/findwise/hydra/stage/CopyStage.java:
>>
>> > -		Logger.debug("Copying field " + fromField + " to field " + toField
>> > -				+ " value: " + valString);
>> > -	}
>> > +    @Parameter(name = "prefix", description = "Input field prefix")
>> > +    private String prefix = "";
>> > +    @Parameter(name = "postfix", description = "Input field postfix")
>> > +    private String postfix = "";
>> > +
>> > +    @Override
>> > +    public void stageInit() throws RequiredArgumentMissingException {
>> > +    }
>> > +
>> > +    @Override
>> > +    public void processField(LocalDocument doc, String fromField, String toField)
>> > +            throws ProcessException {
>> > +        String fromFieldStr = prefix + fromField + postfix;
>>
>> I still don't see the difference. Suppose fromField is the sequence of ["x",
>> "y", "z"] with prefix "pre_" and postfix "_post". You will invariably
>> generate the fromFieldStr sequence of ["pre_x_post", "pre_y_post",
>> "pre_z_post"] right?
>>
>> So why not just use that as the fromField if you always need it to be
>> that way?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/Findwise/Hydra/pull/107/files#r1989349>.
>>
>>
>
>
This name is peculiar - should it have "Source" at the end of it?
Shouldn't this be callback?(error, errors)
I tend not to use unless in my code. I guess if not makes the code more readable. But this is a matter of taste, I can easily change it.
The double quotes are inserted by the code hinting feature though -- it doesn't support inserting single quotes (yet).
It looks like this function is always passed the displayTriangle param. Is this check needed?
@peterflynn currently no, there isn't. That seems a little strange to me, but I think the EC marketing stuff is a bit up in the air. So I coded it in such a way that in Edge Code it just won't appear. 

But since I have a bunch of fixes to make anyway I'll tweak it so that if/when EC gets a twitter account we can add it. 

@njx, cool, will edit.
Could these vars go inside the runs() block?  Then you could combine the declaration with initialization.

Also, savedPos is unused.
I think the pattern most tests use is more like this:

```
makeColorEditor({...});
runs(function () {
    ...
});
```

That has the disadvantage that you have to stash a reference to the inline widget elsewhere instead of passing it directly, but it does match other spec files more closely.  Up to you.
* filter -- seems like an odd name, since it's not given a list to filter down... maybe something like search() or query()?
* match -- is it really optional?  What happens if you don't pass a match() function?
* resultFormatter -- same question
* itemFocus, itemSelect -- we should document that the focused/selected item is passed as an arg
Drop the `is`. Proper grammar and all that.
If I read this right I think its to make sure we override properly. I think this is fixed by re-parsing the command line. Let me know if its missed a case for you.
not a big deal, but generally "bad" to use <br> also, they aren't supposed to have a close tag
I have no idea if it's possible, but having this scroll to a specific item instead of an offset seems more reliable.
Any reason we're saving roamingSettings into a variable below teamID? Seems like we could use roamingSettings.Values["hudl-teamID"] if we defined roamingSettings before we get teamID
I also just saw this which you may want to check out as well, as it relates to requestAnimFrame implementations
http://updates.html5rocks.com/2012/05/requestAnimationFrame-API-now-with-sub-millisecond-precision
loose coupling: `private Map<Option, ArrayList<Option>> categories` seems enough :-)
repo -> git repository. Just for clarity :-)
Didn't know you could store arbitrary data in `git config`, though I never really explored it before. Wouldn't that mean it was tied to the repo? Or do you mean the global git config?

But still, then we'd loose the portability. Currently the token isn't tied to git, which means someone could simple copy our config.json file to another computer on continue right there.
probably. i really did a minimum amount of waits in order to get the tests to run. i ended up using a lot of wait for element to exist *and* wait for it to be visible, because that's what i had to do to get things to work. i'd really like to replace a lot of them with wait-for-ajax calls instead. i would like to do this fine-tuning in a pull of it's own.
Should be 0.
Yeah, it can be override in the runtime.json file.
Doesn't this happen in a different way above in the track? i.e. `trackEvent.update({order: order})`. Is there a reason to have both? If so, why the explicit check for `order` in `manifestOptions`.
might be better do something like

`if ( trackEvent.popcornOptions.fullscreen ) { return; }`
test@example.org
Most of the urls in our css are wrapped in quotes and have proper spacing. Conform!
remove this, it is no longer in the file
butter fails to load because of a missing comma here
don't need this variable since it's only used once
oh oh yah! haha.. ok i can single line. just out of habit from python :)
anything that describes it better will do.
This is not guaranteed. We should not write this specific for video only. We could need parsing on audio too.
Oh sick tetes
compile -> compilation
the path (\"%V\") of dso module
Suora return vain
No probs...I understand...
Sorry, didn’t see this before, but saw it now in the [CI check](https://travis-ci.org/#!/CocoaPods/Specs/jobs/3101791/L111), it is normally not appropriate to disable warnings this way, because that way the end-user might have no idea what kinds of actual warnings there are. Instead, a user can explicitly inhibit all warnings in the Podfile by adding `inhibit_all_warnings!`.
Yes, I like that approach.
shouldn't there be before => [Class["apache2::service"]] as well?, it's done in pulp/manifests/config.pp this way, I'm not sure this one is enough
Use "new SpinWait()" instead of "default(SpinWait)".  The default(T) keyword is confusing when used in this manner.
You don't need this method, move the logic to the ctor.
On 14/03/2012 11:45, Fabien Cazenave [:kazé] wrote:
>> @@ -102,6 +102,19 @@ window.addEventListener('load', function loadSettings(evt) {
>>   window.addEventListener('DOMContentLoaded', function() {
>>     document.location.hash = '#root';
>>     document.querySelector('#root').classList.remove('active');
>> +
>> +  // update UI when the language setting is changed
>> +  // XXX there's no way currently to fire a callback when a pref is changed
>> +  //     so we're using an ugly onclick + timeout :-/
>> +  var languages = document.getElementById('languages');
>> +  languages.addEventListener('mouseup', function() {
>> +    setTimeout(function() {
>> +      var req = navigator.mozSettings.get('language.current');
>> +      req.onsuccess = function() {
>> +        navigator.mozL10n.language = req.result.value;
>> +      }
>> +    }, 100);
> I guess my XXX-comment is not clear… unless I misunderstand your question?

Your comment is clear. But why the value is 100 is unclear to me.
> There’s no way at the moment to detect when a setting has been really changed, but it should happen within a few milliseconds after the mouse click, so I’m using an ugly 100ms timeout here.

But does setTimeout(..., 0) works too?
The way I think of this here is:
  - someone click on a language and the language value is asked to be 
stored in the indexedDB backend
  - once you know the action of clicking has been finished and has been 
caught (even if the value has not yet been written to the database) you 
can launch the reading action and it should return the correct value.

I would imagine that writing/reading tasks are queued in the backend so 
it should work if you do the operation in the correct order. (i can be 
wrong here).
It would be nice to have some input validation in these arithmetic operations.  Otherwise you get stuff like below which will be confusing to users:

```python
In [9]: q + 1
ERROR: AttributeError: 'int' object has no attribute 'to' [astropy.units.quantity]
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-9-513d74adf916> in <module>()
----> 1 q + 1

/data/baffin/tom/git/astropy/astropy/units/quantity.py in __add__(self, other)
    113         with the units of the **left** object.
    114         """
--> 115         return Quantity(self.value + other.to(self.unit).value, unit=self.unit)
```
Can you remove this class (`FlatLambdaCDMCosmology`) from this pull request?  I agree it might be necessary if we include omega radiation, but don't think it's needed at the moment. I think it makes sense to put all the Or changes into a separate pull request.
Oops, yep, I'll check for other commented code as well.
In the case of an exception returning only `Ring` will cause a
`badmatch` down the stack as `add_supported_ring_ring` returns
`{bool(), ring()}`.  I also think it might be better to only do
the ETS lookup in the try/catch...what happens if in the future
`add_supported_to_ring` becomes broken and we always fail and the
ring never gets updated?  We won't know since this is covering it
up.  Finally, you could also use `ets:info` to determine
existence rather than try/catch, perhaps that make the intent
slightly clearer?  Or `lists:member` + `ets:all`.
In ClaimV3 this code path is only really used if the incoming ring is really out of whack and we're going to 'rediagaonalize' we have a go at generating a diverse ring and if that fails fall back to the (improved for the wraparound case) traditional diagonalize
Indentation is changed here. Please restore original.
Sure -- but will that work? E.g. will modifying `fs` in utils.js modify it for each script that `require`s the `fs` module?
Regarding not extending enums: it's perfectly sane from a language semantics point of view, in my opinion. enum A { B, C}, enum D : A { E, F } could define B and C as of type enum A, and E and F as of type D, with an implicit conversion between values of enum A to values of enum D.

Reason for not extending the enum here: I prefer not to clutter the public list of networks because one function needs some special cases to deal with.
It would be cool to see a comment explaining why fc00::/8 means cjdns.
Here is the documentation on why cjdns will never use any addresses outside of the fc00::/8 range.
https://github.com/cjdelisle/cjdns/blob/master/rfcs/Whitepaper.md#pulling-it-all-together

Here is the relevant RFC which explains why it is unlikely to see fc00::/8 addresses routed on the internet.
http://tools.ietf.org/html/rfc4193
You're probably right, it's not the best way. But as I went through the Code I've found ~5 different ways how strings (especially those Table.Field cases) are concatenated, so I decided to use one way pretty consistently: double quotes with all PHP-(Return-)Values in curly braces.

In other programming languages you can't really tell _and_ you don't care if a value is computed ($this->compute()) or just accessed ($this->var), that was my intention.
Could you eventually add a `__construct($redis = null)` constructor and check if the passed in `$redis` is a `Redis` instance? That would probably fix also my request :)
I think @asm89 volunteered to work on this one.
Anyway, since you went ahead and implemented it, we discussed during hack day of SFLive and we brought a better name for this class: *PhpFileCache*

The resolution came after we discuss about the implementation relying on var_export, which partially what you came. This means the code only works with PHP, then it should be named accordingly.

Another thing that I'd like to mention is our possibility to rely exclusively on var_export. You don't need to serialize and de-serialize over and over again. This will be a huge performance gain, specially for caching metadata. Our only needed code would be then to implement __set_state in ClassMetadataInfo and other related classes for other caches.
? true : false is useless
Получение или обновление информации о песне. В основном - обновление URL'ки.
Думал добавить конструктор для AudioItem вида (ownerId, id). Тогда можно было бы адекватно передавать списки через <<
```ruby
@logger.error "Encryption failed with output: '#{output}'" unless $?.success?
$?.success?
```
bad copy-past from `Rpush`. I guess you wanted to write the other way around.
this class has a lot of weird formatting, please reformat.
This is just a general bugfix and had nothing to do with my changes. It resulted in getting strings like nullnullnull in the output XML if you omit some of the values.
Why the subtraction of `frame.origin.y`? This would imply that as the cell grows taller, the segmented control would move farther to the left. I think that we want to keep the control anchored to the right edge of the cell.
Maybe we can put these in helper.js and use the browser version when available? (General comment not for this review)
This is inconsistent with all the other helpers. It should return a negative value on failure.
removing it ;)
We shouldn't. Will need to figure out what tests break and fix that.
oh right, duh. carry on :)
if there's an error on line 107 the variable `connection` won't exist at this point. Adrian's new code usually looks something like this:

```python
connection = None
try:
    connection = self.database.connection()
    ...
finally:
    if connection: 
        connection.close()
```
"Please use set to update the attributes instead of modifying them directly. " -ja
I recommend removing this boolean altogether, and using float3::nan as the initial clientLocation, and using float3::IsFinite() as the check to test whether orientation has been initialized or not.
Plus, this uses crappy nil.  If we don't force hash params, I think you should set it to an instance of a `NullParams` class.  This class would need to implement a `merge!` and `merge` function.  Then you could put nil handling or other handling in there.

Again, though, I say don't do any of this and just force Hash params.
забрав
you could init cacheKey first and save one function call
As the order of the arguments changed, you should update the phpdoc
$iniMax has already been strtoupper-ed
could we use `file_put_contents` with the `LOCK_EX` flag ?
`$p` is used a little down in lines 57 and 65. The property value change was missing when I renamed the class, it's been fixed now.
We don't document properties (except sometimes for objects).
Why removing this ?
あと明らかに model  に付与するモジュールなので 自分なら app/models/concerns/*.rb あたりに置くかなあ。
The reader will be curious as to why you wouldn’t just use a `ChannelBuffer` (why didn’t you?)
This from should be the default from declared at the top of the class.
doctype ro upper bezar va legency compatible kon
for each value @a v ? (and below)
So these tests actually run?  Cool.  Reason I say that is, previously if you inherited a class that inherited Minitest::Unit::TestCase the tests would not run and influenced the original design using a module include.  But if this works, rock on.
I think I have a way to validate the aspect ratio (I'll amend the patch when I have it coded up), but I'm still not quite sure how to validate the angle. 

I agree with also making a test that uses supersampled 0-width lookups and a good pixel filter and comparing that to our results. I'll get on it.

Chris Foster, if you're out there, can we use your swirl image? Or is that somehow licensed in a way that would prevent us from including it in our test suite?
Tidy up the spaces.
This seems to be called still. and it shouldn't be as ss.running is set to false in ss.Stop(), which ultimately causes a service to start back up after it's been stopped
Can try to investigate this further?  Maybe create a test case that isolates the problem?  The only failure cases that make sense to me all boil down to trying to reference a property on an undefined value, which I'm sure is a well tested code path in Safari.  So I have to think there's something else going on.  I'd like to have a better understanding of that before adding a workaround.

In the meantime, can you take a look at the v1.4 branch I just committed?  I've added a test for the presence of the require() method since that's what's being used and will avoid unnecessary exceptions (albeit ones that we catch), but that probably won't help with your crasher problem since I believe require() is still defined in AMD contexts, right?

Also, it has AMD-aware logic for publishing the API , but I don't have a convenient way of testing that.
And fixed: 451ef3d
what was the problem? I definitly agree with @kselden that we should avoid `Ember.Application.APPLICATIONS` and `isApplication` if we can. `Ember.Application.detectInstance` or juste `instanceof` do not work?
Use triple-equals.
All the tests that use embedded XML should really be changed to just use a persistence.xml in the same package as the test. 
I'll still merge this though, as there are lots of tests that have the same problem.
`...available...` ;)
In addition noRequiredTypeOfDataDialog seems to be a really long variable ... noRequiredDialog seems to be a shorter name
If we’re using a `<form>` as a parent, let’s rely on `<button>` elements and forget links. Besides, the rest of this stylesheet doesn’t include any other rule for `a[role="button"]` anyway.
I do not think we would get much advantage out of this since these variables may vary depending on if the ConfirmDialog object is used from the Contacts app running independently or running as an iFrame inside the Communications app. Consequently, we would need to invoke the init() on each show() invocation. Anyhow, with this approach, in init() we should check if the "doc" for the new case is the same as the previous one and if not reload the variables :-) Are you OK with this?
I will check the result and remove the font-family if #2329 could also solve the issue.
Yes, it's abbreviation. Does the naming confuses you?
Can we extract the actions to separte functions and have |handleMessage| just for routing to those functions depending on the event data?

Something like we did for the |handleCommand| in oncall.js
done with moving.
I think a <button> might be better than a <div> here
nit: maybe it should be a constant somewhere?
Also create a |var options = commands.options| at the top of the method and use it.
No dump number here. If no `keycode` turn out to be a problem, update the check in `handleEvent`.
Same thing here: I'd put this call to addEventListener() directly in init() and get rid of this bind() method.
Sorry If I misplaced my comment. I', speaking of the code below the XXX.
Do you mean this?

<pre>
opts.on('-x', '--xarg VALUE') { |val| @options[:xarg] = val }
</pre>

This will take the following value:

razor -x FOO policy

This will create options[:xarg] = FOO and invoke the slice policy.
Why `to_f` here?
yes. There were two bugfixes present already.
Although it works, start and stop are meant to handle what should happen when focus on the current tab is lost.

This should instead be part of the world's tick and should pause the music directly instead of calling start and stop.
The last argument is the bottom of the area to scroll into view, not the height to be added to the second argument. So these two lines should be:

```javascript
var heightForScroll = Math.min(widget.height, scroller.clientHeight);
scrollIntoView(scroller.scrollLeft, inlineTop, scroller.scrollLeft, inlineTop + heightForScroll);
```
since you don't care the output of cmd, `utils.system()` can work.
Ok, added:

    # Replace stdout by our StreamProxy object, so we can supress all output
    # but the one we specifically want.
Combining multiple units into a single latency may end up with reporting confusion, but I suppose that's the current design.
We don't use super in buildbot, so this would be `LRUCache.__init__(...)`
dojo has some stuff, but we would need to integrate it with haml
This is the right technique, since `{}` is mutable, but the `None` -> `{}` translation should be done in `trigger()`.
don't think json supports 'commenting-out'
Indentation is off, we indent each level with 4 spaces.
lol i mean to change the testing one
[USA Today](http://usatoday.com)はBackboneのデータ/モデルのライフサイクルのモジュール性を上手に利用しています。コードを扱いやすく、そして無駄のない形で維持するために、アプリケーションのオブジェクトをシンプルに作り、継承し、分離し、結びつけます。新しいウェブサイトではpushStateに対応したブラウザとレガシーなブラウザへのページ出力制御のためにBackbone Routerが多用されています。最後に、担当チームはBackbone's Eventの利点を用いて、サードパーティー作成のものや解析のパッケージをアプリケーションの心臓部にフックできるようにPubSub APIを作成しました。
Exactly. Sorry, I missed `length`.
I like this, a lot cleaner
are both these methods needed? can we just use the second one and assert the response in the test?
What about whitespace other than newlines? Should it be ignored?
No, it will be used in expanded macro defined a few lines before:

#define SET_ERROR(msg) { error = TRUE; \
g_set_error (error_msg, GDK_PIXBUF_ERROR, GDK_PIXBUF_ERROR_CORRUPT_IMAGE, msg); }
Usually we don't log errors into console we just make that a message of an error thrown.
Shouldn't we use `require("api-utils/timer");` instead?
(It would avoid addon-kit/timers module/sandbox instance)

If there is a reason to use addon-kit one, then we should use `require("addon-kit/timers")` so that there is no possible doubt.

Having said that, it isn't mandatory so feel free to let as-is.
awesome.  thanks.
where does this 'r' get used? Seems confusing to have it overlap with the inner function argument.
Same comment as above to detect whether the environment supports signals.  In Windows, do child processes correctly terminate whenever the parent process does?
Should be called __construct
It would be nicer not to use global variables to pass around state.
Thanks for pointing that out, @dgtized. I pushed some new commits to handle it.
Might be better to revert the whole block from the previous chang
```
if __debug__
```
Actually, the locale isn't invalid in this case, it just doesn't contain a region part.
Rewrite as noted in a previous comment on conditionals (first condition on same line as statement; operators on next line preceding next condition).
Also, if you're going to change anything, s/ot/to/ :)
I think that is best check if `$rightOperand` is zero before invoke to `bcdiv`
You can see that line is added back below. This is VS arguing with nuget(?) about how to format web.config. I would rather not get involved in this fight. But unfortunately it happens without my intention to do so.
If it's "CraftingTable" then there are a ton of errors because its the same name as the controller, so this is what zidane told me to do.
Again, just use jQuery methods. Speed implications here are moot.
rfc5646 not ISO 2
econf dies on its own. So no need for this.
could be useful to have a description here :)
Try with ~~~~ before and after code block.
On Sun, Sep 16, 2012 at 3:58 PM, Kenneth Hoste <notifications@github.com> wrote:
> sanity check paths need to be fixed

Done, please review.

Fotis
Should be of form environment_name, actually. Can you change these?
It's better to handle the errors ourselvel by default imo.
http://stackoverflow.com/a/244858/996876
Can remove this comment, I will be fixing Array_copy.
Not sure. Seems nice to try to execute as much of the template as possible. Let's wait to decide until we get user feedback.
Cool on the alphanumerics but I see a limit of 50 here no? https://docs.djangoproject.com/en/dev/ref/models/fields/#slugfield
You were right about this in irc it should be:

```python
assert u in [p.user for p in peeps]
```
not "date"
Base is a Page, but PageProvider is not, so it should not inherit from Page or any child class. Even if it did, it would still need the mozwebqa in its constructor, just like page objects do (they inherit from Base).
This issue is sort of unrelated, but discovered at the same time. sanitize_date returns an empty string if the input is invalid. In Picard 1.1 metadata['date']="" was a no-op, but with recent changes, setting a tag to an empty string actually removes it.
Hi Jamie,
CC: Dave,

I am copying Dave in this conversation because I think the test failure has to do with how big couchdb clusters work and the pyon datastore, and Dave might correct me if I am wrong.

Regarding the failing tests in UNS in the big couchdb cluster test (coi_testbc), I think this is what happened. I was using events in the test that was of a very generic type, ResourceLifeCycleEvent and an origin (that may have been popularly used in other test modules). I think that in the big couchdb cluster, the events are not cleaned up in the datastore as soon as a test module runs its course, and so when another test tries to use the datastore to search for events it sometimes encounter many residual events (that are hanging around in the couchdb datastore even after those other tests have ended).... Both the tests that failed were using my find_events() method in UNS and this method just uses the datastore's query_view() method.

The relevant code is here:
https://github.com/ooici/coi-services/blob/master/ion/services/dm/presentation/user_notification_service.py#L563-620

Therefore, my test failed saying that it found 151 events instead of the 4 that it is supposed to find (which it does find in normal testing). My tests pass in a normal test:
ex: bin/nosetests ion/services/dm/presentation/test/testuser_notification_service.py

I am confident that if the test was rerun it would show a different number of events found.

So what I have done now is use only very unique event types and more importantly, origin, in my tests. I think this will solve the problem for my test. However, I think that later on it may be good to see whether cleanups of the datastores are occurring in a timely manner after each test is completed in the "couchdb big cluster" test.

I am merging in my changes in coi-services. Please let me know if the tests fail again.

Unfortunately, I am not on a VPN and as far as I know our asascience network has strong firewalls and will not allow me to access the OOICI vpn. It will be great if you can let me know if the tests fail again.

Thanks,
Swarbhanu.
I'm not 100% sure, but I think you might end up with duplicate spaces here, since you have a single space before and after the translation string and a space before and after the words inside the strings, so it would be like spacespaceinspacethespacespace and spacespacecollection instead of spaceinspacethe and spacecollection. 

If you double check the view and find the word spacing is a bit off, maybe change the strings so they're ts("in the") and ts("collection."). (I'm operating under the theory that it would be easier for the translators if we don't rely on them to remember spaces like that, but since we don't have an interface yet, that's really only a theory.)
hit to `"\#{"`
Why splat the args here? Do you prefer that over your original problem in #176 ?
これは結局必要ないんじゃありませんでしたっけ？
Replace with config.get_install_server_ip...
いやこうか。

    @cache_path ||= Dir.tmpdir
@kellyredding - "this will work" or "this will require it in" not both?
We may move to a page object model in the future but at the moment it's not a priority.
This page went away, so I added a new "forthcoming" test below.