labofsahil/github-event-dataset-2012 huggingface dataset:
That's how I got the printer to not strip the coefficient off. There is no leading space in the resulting string:
>>> latex(p)
'2 \\left[\\begin{smallmatrix}3\\\\4\\end{smallmatrix}\\right] + 1.0 \\left[\\begin{smallmatrix}1\\\\2\\end{smallmatrix}\\right]'
The following would work 

    In [17]: x = Symbol('x', real=True)
    In [18]: Intersection(Interval(0, 3), Interval(x, 6))
    Out[18]: [x, 6] ∩ [0, 3]
    In [19]: 5 in Intersection(Interval(0, 3), Interval(x, 6))
    Out[19]: False

The real issue is separate from the "can't compare x and 0" issue. 

I like your idea of using Maxs and Mins to merge Intervals with symbolic values. I think that if this goes in it should be part of a different pull request specifically about Interval. 

Regarding None. 
Calling ```A.intersect(B)``` will never result in None; It will always produce a set. It will either create a set like an Interval or it will create an Intersection object as in my example above. The internal method _intersect produces ```None```s but this will always be handled by the Intersection object.
how about letting pprint do the type setting?

```
>>> a,b=symbols('2,10')
>>> pprint((a/b)**50)
 50
2
----
  50
10
>>> print (S(2)/10)**50
1/88817841970012523233890533447265625
```
changelog lines are ordered by the issue number, please relocate appropriately your line. :)
Extra spare spaces at the begining of the line.
Yes. But see my comment in #927: If memcache fails to build now, we will only notice this by more skipped tests.
minor change - impermeability -> Neumann
Updated. The layout and content have been changed a lot since the initial commit. People from ABI can view the latest html version from file:///hpc/tyu011/workspace/cm/doc/doxygen/Programmer/html/installation.html
Oh, the geometric field lines need to be reverted here too.
Just printing the first element may not be as helpful as seeing all content. If you print the first I think you may as well print the rest. Large containers may be problematic but you already print some value you don't know and that first value may be some large container too.
We should document all the options here.
Typo or by purpose?
You must also mention Finder and Process. I know that almost all my projects use them in one way or another.
Good point.  It appears that we set up the controllers somewhat strangely, so let's merge this in and update our architecture soon.
@hnakamur It's probably safe but pretty hacky too. I suppose you can just do:

```c
HANDLE handles[2] = { bla->foo_event, bla->bar_event };
WaitForMultipleObject(&handles, 2, ...);
```
s/unmatchedOpenTopCount/unmatchedOpenBottomCount/
Is this not the issue we were discussing where a Chef 10 Server using this code would save this key to couch?
This is a sql cache driver, as such the `sql_` prefix can be dropped from all methods. I know this requires some more work in the cache service to keep compatibility.
Yep, those are double language keys.
forum -> item?
Abstract?
is by default accessed
I said it first. :P

Look at the times. ;) I posted this 10 minutes ago, you posted yours 9 minutes ago.
Oh, I don't think there would be 100500 class Light derivatives.
This would be a new coding style.  I see length caching in very few places in Mojito, and I haven't seen it much in javascript programming in-the-large either.

Also, this change, while perhaps worthwhile, doesn't really relate to the resource store redesign.  (That is, length caching wasn't being done by the old code either.)
Опять же оступы
The license restrictions on zfs do mean that we cannot build it on Hydra, since Hydra makes all builds available for download... Thus, "platforms" should be left empty.
move quickly, or create a ticket
Actually you'll still need to POST for screener ... u will need to POST (update the old one with new startDate and endDate) and use that notInList for the other on-the-fly or saved call. So it will be one POST for updating the list of registered patient and then GET on-the-fly for registered-but-not-screened-patients.

the current way should work... since its a small number of encounters per day per person, it should be fairly easy to do that on the client side, since it will already be on the localStorage for screener
I would prefer:
```
lbuser = list(self.template.lbuser)
lbuser[6] = 2
lbuser[3] = 101
lbuser = tuple(lbuser)
```
Its clearer that lbuser should be a tuple.
I believe `@var` is for class variables.  I think a single descriptive block is good for all error constants.
I didn't taught of that case. I would make an if theano.scalar.ScalarType: ... else the decref/incref version.

In that case, if the object is not an python c object, I think it will crash.
takes
that verify what?
I think it should be NPY_CORDER here, as C order is not the same thing as C contiguous, it means that the dimensions and strides are to be interpreted from left to right as "first-to-last indices".
To be sure, can you run some tests with DebugMode.check_preallocated_output=f_contiguous? I think that revealed the problem last time we had it.
This could be written much shorter, something like:
<pre>
try:
    name, version = package.split(None, 1)
except ValueError:
    continue
package_list.append({
    'name': name,
   'version': version,
})
</pre>
This object is unnecessary. You don't hold any state anyway. ``search_tree()`` can be a module-level function.
Are you aware of the result of this expression, depending on the value of type ? http://codepad.org/I9uyOkdR
Классы именуются в `CamelCase`
um... what's the point of this margin-right?
Could you please fix the alignment issues?
thanks for the linting
is this in Spanish? need English translation
http://en.wikipedia.org/wiki/English_compound#Hyphenated_compound_modifiers

But I should probably capitalize Functions.
I prefer to use COALESCE in this case, but not significant difference.
For example, if we use the sql of:

select id from source_table where array_upper(attr_column, 1) <> num_attr.

This query can be potentially costly.
For consistency, this should probably be `background-color`.
Because there's some bug in configure script. Prefix is added to path twice if specified in --prefix. I've sent a message to author.
"when_built" seems redundant, since everything in the receipt is a reflection of the state of things at that time. Could call it "revision" or "brew_revision" or something though.
Ah, I was thrown off by the fuzziness of "this assumes ..."
Frankly speaking I don't know exactly what are you referring to :) Feel free to fix it the way it works best for everyone!
I suspect this will cause an error for any values other than strings, see http://redis.io/commands/get
Хорошо, уберу запятую.
Don't forget to also update the docstring.
It's not my problem that you don't remember ... :)
nach o.g. anpassung wäre es für mich ok.

@gharlan @dergel @tbaddade Meinungen?

Vllt. könnte man diese Anpassung für nach der 1. beta einspielen (zum Test des Upate Mechanismus)
Seh ich auch so.
The point of join is to not use slashes, since they differ between platforms, so remove the `/`
I don't think the right thing would happen if `failed` and `finished` both throw exceptions
it is now, same as the rest :)
I think Dan Imal will ask you to line up the =>, because he likes symmetry like that.
It looks good to me... I'm on an old Macbook Pro (2007 I think...), with Mac OS X 10.7.4. 

I've noticed it lags when I have some other panels such 'Find in Files' with many results opened, but then so does everything else...
Since you're not re-positioning icon (e.g. left/top), then I don't think you need position:absolute.
Should add validation that we actually get an exception.
I think this could be moved into `_parseSelector()`, since we do it both times we use that function anyway.
Can we get rid of this setTimeout?
i'd factor this out into a util function
```coffee
@getRect().intersectsWith square.getRect()
To avoid duplication, could you use `@inheritParams discrete_scale`, and then modify any different params as necessary?
CODE REVIEW HIGH FIVE
it wouldn't, if you use something like:

``` javascript
options = $.extend({}, $.ajaxSettings, options)
```
*users* -> *user's*, *url* -> *URL*
*message* -> *text*?
Ok, I'll change this back. Just out of curiosity - what's the reason?
Actually when i run it trough validator i didn't get any errors regarding footer (but my validator could be mistaken ;) ) , but I can wrap input into div if you like.
two semi colons
All you're fault
Do you need to `migrate` if this is the first time you've set it up?
Lint should pick this up, but the indentation is incorrect here.
Hier sollten wir ein paar webspaces testen ob die REQUEST_URI von allen Servern geliefert wird
I've added div ids all around the database/show page 
```  
    %tr.trstripeshow
    %td.tblshowbold State:
    %td{:id => "state"}= @database.state
```
so i can use css selectors:

```
Then /^the initial state should be creating$/ do
  page.find('#state').should have_content("creating")  
end
```
I'll be adding div ids as i need them in future implementations
Hardcoded values like this should usually be turned into constants.  Normally I'd say it's best to make them configurable, mostly for testing, but with Ruby it's very easy to mock something like this so that's not such an issue.  If this bucket name might change any time soon, though, then it might be better to grab it from a yaml file or something like that, then you can make a configuration change rather than a code change.  Not such a big deal with an internal service product like this, but it matters when making a code release is expensive or slow like with most client-facing products.
Might be worth a bit more detail about why this is needed.
Because there's already a LdapUserManagerTest and it's initializing the whole plexus injection around ldap, starting local LDAP servers etc.
invalid directive -> invalid parameter
Oboje je dobře, i když původní slovosled mi připadá divný, ale to je spíš věc osobního názoru, češtinářsky je to dobře oboje. Jestli použít "problém" nebo "chyba" záleží jestli se dialog zobrazuje i pro nefatální problémy, pak bych nechal "problém", jinak je lepší "chyba".
Just FYI, the ``\`` here should be at the end of the line.  I will correct this before merging.
if statements are a fair point. Do what seems right :)
What about using 'w+:binary' as a mode instread, that seems to work the same both for 1.8 and 1.9
Please put the return on a new line
Ahh I got it now, because I added StartupShortcutPath() to util.h and it is static in util.cpp the compiler gives: "declared 'static' but never defined [-Wunused-function]". Going to fix this, sorry.
There are at least 5 places in where it is if () instead of if(). What 
do you prefer? I'll use that in the future, if we don't get a new 
standard coding style, so that you and I use the same as we often work 
on the same code parts.
Maybe just call it event(). Style should be "severity".
`$someName` is a wonky variable name, perhaps `$currentName` instead?
It does not anymore, it deprecated it for 5.3 but then un-deprecated it again :P
How do you suggest to change this line?

maybe:
} elseif (strpos((string)$this->_rule, '::')) {
> Also, s/wrong/invalid

Good point. I change that (for WrongUrlArgument too).

> include("test", 1) doesn't as much have a "wrong name" as much as it doesn't have one at all (it has an integer)

So why not: "Invalid second argument; expected alias name" ?
Just a small optimization idea: how's about calling jsonldEncode automatically in expandPropertyName? After all, the expanded name is never used without the brackets anyways, so we might as well add them automatically
maybe i miss something, but i think there is no such problem. anyway, lets summarize:

* there are 2 cases: creation of a new entity, and rendering the collection
* creation: we have the type (assuming the createjs bug is fixed). we need the rev: we cicle to get it. then we have the parent id which must be enough to create the parent. now in PHPCR world we set the parent to the new entity and so it becomes a child. if we had to explicitly add the new entity to the parent, we would indeed need to know to which collection we have to add. but in that case we can say that if several collections of the same type exist in one entity, each collection must have a different rev, so we would use the type information plus the info which of the possible rev attributes was actually used to determine the correct collection
* rendering a collection: if all child types have exactly one and the same rev, use that. otherwise the rev must be explicit. (we should sanity check that all child types specify that rev as one of their possible types)
Unused, but doesn't hurt.
Trivial note; let's keep the format of docstrings (I'm sure we violate it somewhere, just trying to keep things tidy where we see it) to 

```
Single-line description
<BLANK LINE>
rest of text...
...
...
```

So this would simply become

```
Kill the running kernel.

This method blocks until...
```

The reason is that we can have popups and other tools in the future that summarize things by culling only the first line; for that to work well, the first line must be a complete sentence and not truncate.

Same reason why that approach is the [recommended way to write git commit messages](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) (minus the 50-char limit).
No, we discussed it and agreed that it made most sense to leave only the original year and stop having to update ranges.  So in fact I've been *removing* end years as I go.
bikeshedding, but probably easier to understand in the negative, i.e `skip_slow`.
update the comment as well, maybe just "Special case items added to the left of everything else
I'm always open for review. I wouldn't have opened a PR if I hadn't put on my asbestos underpants.

I was rewriting the summary, and now I'm not sure if this does the right thing. Currently, it updates the workdir to match what's in the index, but maybe that's not simple enough. I'm wondering if it should be `git_checkout_to_ref` and `git_checkout_to_commit`. What do you think?
In order to do that, I'd need to create a wrapper script in order to put them into the environment and then call the python script. I was trying to make it just be one  script, but I don't mind doing it as 2.
Extra spaces here, around the condition inside the parens.
Why not make this a class attribute instead?
``minus minus`` ?  Whoa, that's a lot of minus...
This will throw an unhandled error in case of bad data (non-existent env id).
I suppose this is ok, although ideally we'd remove without prompting while giving the user a way to undo the action (as does Add-ons Manager when you remove an addon).
Missing new line after before the return, and same goes for line 119 and 156
putting the closure on several lines would be more readable
typo here.

And the phpdoc does not follow the phpdoc standard: you need a short description and an empty line before the long description
It's automatic :)
idiomatic to use traits: `sealed trait State`
Yeah will add when I get home.
I have no issue with the way that code is writeen or anything. Just wanted it to be clear i'm not sure why it works that way.
That's an interesting question. My was it would work there. It did not appear to actually work though. I haven't had a chance to determine if it is an issue with how we have our factories setup or something quirky with factory girl.
Currently I have buffering only enabled for vdpau and xvba. A ringbuffer of 2 textures is too small and a buffer might be overwritten before rendered the second time.
No need to import DynamicIntProperty and DynamicStringProperty from the scala package? Or can we just remove this line?
Yes,os.path.join(test.tmpdir, 'tmp.xml')  is better that it will clean up the "tmp.xml" file automatically.I will change it.Thanks...
myabe replace site_id=site.pk with site=site
There is sadly no switch for the ``push`` subcommand that ask to push only the current local branch to the configured remote tracked branch. So let's override the ``push.default`` configuration variable to mimic this behavior from the git configuration. Hopefully, ``push.default`` will be set by default to ``simple`` (almost like ``upstream``, see man page for more details) with upcoming git 2.0.
I moved the replication from the activyt feed server to outside the to activity feed replication, and commented it out since it at the moment it brings down thousands of unnecesary entries. in #412 this should turn into two methods, one to and from, and with the activty feed of the corpus as the argument.
My initial thought here was that we only cared that it failed. But after considering it for a while I believe that this does not allow for some other kind of unexpected exception invalidating the test. Therefore I will make this change.
Also there is nothing to notify, the other thread is not calling wait
I think we should eliminate the statics, if every subsystem started using statics instead of services then we would end up with a mess very quickly. Other than that I think this patch is ok to merge.
Aren't you using obviously separate names for OSGi services?  Should probably be INSTALL_OSGI_PERSISTENCE_SERVICES
Lint says `cloudCover` and `weatherCode` aren't used.
Here is how to get the full path:
http://jsfiddle.net/aSN73/
z-indexes within the div should go to their respective css file I think,

also `#cardsView .card[data-edit="true"]`
sends notifications
`Embedded Font Test (Open Sans)`
Слово Загрузка мне кажется хуже чем Загрузить..
BTW - we have to support proper JSON response from every CLI exit on a '-w' request before merge. We cannot have an invalid API response merged in.
Move the uninterpretation/interpretation inside the case-statement so that we only do it if the module is actually reloaded
One question, did you cover backface visibility in other browsers intentionally? As far as I remember, I added it as a nasty Android bugfix, so it doesn't need to be used in non-webkit browsers.
Prolly be better to have this take the directory (or full path) as an argument.
Also, see [os.path.exists](http://docs.python.org/2/library/os.path.html#os.path.exists)
This line adds most of the functionality, I believe it will become a very important feature of 4chan x
It would be too wide, and Affiliates convention is that multi-line docstrings use this format.
Does this really work? The dirname should be called on __FILE__, this way, it just removed the '/lib' from the path, doesn't it?
Marijn made a bunch of changes around undo, and I'm not totally sure whether Josh's history stuff works correctly with this new code--it seemed to work in light testing. We might want to get Josh to review it.
commit 41f2396c55725e9e802fc346adcc020018b7b757
Author: lmr <lmr@592f7852-d20e-0410-864c-8624ca9c26a4>
Date:   Mon Jul 4 14:53:51 2011 +0000

    virt: Add more flexible way to specify comm ports host -> guest

....

+# If you need more ports to be available for comm between host and guest,
+# please add them here
+priv_bridge_ports = 53 67

----------------------
you can delete those three line directly, the wiki link is not related with ports map.
Can you change these to `assertCount`?
`config.error` here, too
with unupdated composer.lock file it fails to build on travis. Can I discard travis build failures?
I was faster :)

On Mon, Oct 1, 2012 at 9:51 PM, Christophe Coevoet <notifications@github.com
> wrote:

> In src/Composer/Util/ConfigValidator.php:
>
> > +            $json->validateSchema(JsonFile::LAX_SCHEMA);
> > +            $laxValid = true;
> > +            $json->validateSchema();
> > +            $valid = true;
> > +        } catch (JsonValidationException $e) {
> > +            foreach ($e->getErrors() as $message) {
> > +                if ($laxValid) {
> > +                    $publishErrors[] = $message;
> > +                } else {
> > +                    $errors[] = $message;
> > +                }
> > +            }
> > +        } catch (\Exception $e) {
> > +            $errors[] = $e->getMessage();
> > +
> > +            return;
>
> This return statement is wrong. It does not return a consistent value.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/composer/composer/pull/1170/files#r1732118>.
>
>
side note: with oh-my-zsh and the bundler plugin activated you don't need to do bundle exec.

Are you using oh-my-zsh yet?
making private code protected
You could refactor this to:

``` coffeescript
for p in ast.properties when /^name$/i.test p.name
  name = p.value
  break
```
Enclose this line by brackets
Sure, then use `lists:keymember/3`
Ahh yes, many thanks @jstorimer! Funny that I actually meant to leave that comment about reading your book on another, more socket-related, issue: https://github.com/highgroove/grocer/issues/14 :smile: 

Thanks again.
Why are we returning here? Is there a reason not to handle the original packets in the flow engine?
Can you make the @since for all newly added classes and methods 3.0. Thanks.
Why is updateModel() internally calling updateView()? This doesn't seem like expected behavior.

Ditto for other occurrences.
We already have similar code in [getTabForWindow](https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/tabs/tab.js#L236-253) instead of duplicating it maybe we could unifying the core code?
There is an extra ' on the end of this line.
No, I don't think there's any good reason for this limitation.  If you feel that it should be bumped up, let's open a separate issue.
and i was thinking that line makes my codey sense tingle.
you should probably pass `$code` instead of `0`
This should come in handy in the future. +1
Meaning that you'd like me to go ahead and git rid of that backwards compatibility as part of this change set?
This is not the interface, ``assert_{created,updated,deleted}[_one]`` is.
Why do we have the n column?
This is correct, the method in client_methods is incorrect.
Thanks for the hint! I've just seen in the RFC and will implement that.
Should be protected, not private. (Our convention is that private needs to be justified as a truly internal implementation detail that would result in errors if modified in an extending class.)
Update the docblock
This should be imported, to make it clear that we're utilizing this third-party class.

Question: is FirePHP installable via composer or pyrus? If nothing else, we should have docs detailing usage of this log writer and how to install FirePHP.
String operations are now inlined.
I don't use auto-format per default since it sometimes are not aligned with
the code standard. I'll use form now on.. Thanks for the heads up!

On Thu, Nov 1, 2012 at 8:30 PM, Jay Weisskopf <notifications@github.com>wrote:

> In src/rajawali/animation/Animation3D.java:
>
> > @@ -43,7 +45,7 @@ public Animation3D() {
> >  		long timeInPause;
> >  		boolean wasPaused = false;
> >
> > -		public void run() {
> > +		public void run() {			
>
> It looks like some dead whitespace snuck in. If you use Eclipse, it's
> auto-formatter is pretty good for this sort of thing.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/MasDennis/Rajawali/pull/212/files#r2009036>.
>
>
I know that.  What I mean is that the "or" operator used by Elixir programmers, is `or` and not `|`
Shouldn't this be uncommented, removed or marked with a  "todo" ?
There should also be an 'other' category, because I can thing of others: post-install (e.g. failing to make the module for whatever reason), Python (e.g. typos in Python code), ...

Maybe you should rename 'make' to 'build' and 'make_install' to 'install'.
On Mon, Sep 10, 2012 at 1:33 PM, Kenneth Hoste <notifications@github.com>wrote:

> It now looks great, except for the fact that you don't close the list,
> i.e. there's a ] missing at the end.
>
> Fix that, let me know, and I'll merge it in.
>
OMG :) I've fixed it manually and repushed.

Note that I on purpose didn't pick the ebrepo versions with buildstats on
the other bioinformatics contribs,
exactly to avoid the damned human-in-the-loop...
Needed by the python API, I'll update the comment to mention this.
Am I stoned, or is this `tmp` variable not used anywhere?
I just amended the commit and added the missing file
should be on separate lines
Move this down with your if (global.YT) check below, since they are somewhat paired.
！ってなに？
Makes sense. Assuming the tests pass using Facter.puppetversion then I can't see a problem with it. If they pass, that case statement is working :)
ohadlevy, this is now fixed in a new commit
double&nbsp;&nbsp;space
Agree with you guys. So I will write shared variables into comments as a sort of documentation at least.
Ah. Yes, that makes sense. Fixing.
not the hashes, just the brackets.
yeah, i'd probably make a separate function for each of the actions which can take place here. That way you case on the options and perform a function then output a message based on the success.
From http://www.imagemagick.org/script/architecture.php

In most circumstances, the default number of threads is set to the number of processor cores on your system for optimal performance. However, if your system is hyperthreaded or if you are running on a virtual host and only a subset of the processors are available to your server instance, you might get an increase in performance by setting the thread policy or the MAGICK_THREAD_LIMIT environment variable. For example, your virtual host has 8 processors but only 2 are assigned to your server instance. The default of 8 threads can cause severe performance problems.
Should we have a `registry.get_suite_for_feed_url` method, instead of iterating through all the suites?
Ah man I completely missed .present.  Since it's just as easy to say `@page.content_for(:body).present?` as it is to say `@page.content_for?(:body)` do you think it's worth even adding?
Overall like this but ppl know how to use github - no need to link to the readmes and announce that that's where the links go - just link the projects and leave this last line off and I'll be glad to merge it.
Reason for putting it in there is so that it would be a complete Comment object. I removed it and added the principalId in place instead.
> What about a test when the test class is private? :)

So, I said that *If a test class is private, the JUnit runtime will throw an exception during initialization*. Well, it turns out that this would be true if a ``private`` class is actually kept ``private`` in the bytecode.
Example:

```scala
import org.junit.Test

private class AT {
  @Test def foo() {}
}
```

produces the following (Scala 2.10)

```java
public class AT extends java.lang.Object{
    public void foo();
    public AT();
}
```

:-)
I don't think the super call is necessary, but I wasn't sure.
s/executed/started/ and I'll be fine
Не зрозумів як. В портфоліо та блозі різні параметри в роутінгу, хіба що забрати код який підраховує кількість постів ( проектів)  на сторінці
це стиль для елементів, прописаний в Sonata. вирішив його використовувати
> Instead of communicating between these functions using global state, it might be better to rename RunSpecFile to RunCurrentSpecFile and then have it call RunSpecFile, which takes an argument (the spec file it should run).

The global state is used so `RunLastSpec` can work. I think we'd lose that functionality with the proposed refactoring?
согласен, что это не всегда ошибка, но в таком случае непонятно, почему он просто игнорируется компилятором?

цикл был вроде бы пустой
Старайтесь использовать константы вместо числовых значений. Тогда, если условия задачи изменятся, вам нужно будет поправить одну константу в одном месте, а не делать столько правок, сколько раз эта константа использована.
если не хотите использовать отрицание можно использовать проверку на YES/NO
What is a "tick" ? I noticed the latest version I have does not contain these vars. Btw any chance the gradient you have defined here will make it into the latest code? Would love to have this functionality:)
I've got it pulled down I'll change that and merge it over, thanks man
These commands need to be prefixed with `hubot`. If you just type `torrents` or `where is transmission?`, the respond block wouldn't work for those.
You save the setting correctly, but you do not load it. So, as a result, the saved setting is unused and the flag resets to the default value.
out = np.zeros_like(data)

will also keep the same dtype
np.dot(e, e.T) is fast so I am not sure we actually gain something significant by doing it this way.

1/ I don't like to have to branch depending if n_jobs==1 or not (I know I do it some places else for memory issues but it's not relevant here I think)

2/ parallelizing a fast computation in Python is not ideal. A better way could be to split the epochs in n_jobs chunks (such as done np.array_split). But we might have problems when epochs is not preloaded...
please remove all unneeded requires
Are you referring to useSystemClassLoader that is being used in ServiceContext.setModuleService?
I suggest you to remove `trait JsValueWrapper` and then to rename `JsValueWrapperImpl` to `JsValueWrapper`, so you’ll be able to get rid of those `asInstanceOf[JsValueWrapper]`
only save if whatif == false
I don't think "Yes" and "No" are internationalized there.
@ColinHebert, see http://stevelosh.com/blog/2010/02/my-extravagant-zsh-prompt/.
I think this should be:

    // ... authenticate the user
change to

>
Unless you're documenting a feature that's new to a specific version of Symfony (e.g. Symfony 2.1),
I'd keep this as `user_table_exists` with no arguments, since it's only used once, to check the existence of the `:users` table.
I would probably write this as:

    def done(doneSync: Boolean): Unit = producer.tell( 
        if (exchange.isFailed) FailureResult(exchange.toFailureMessage(cmsg.headers(headersToCopy)))
        else MessageResult(exchange.toResponseMessage(cmsg.headers(headersToCopy)))
        , originalSender)
if a DataGrabber node will have overwrite set to False it will not rerun
In this vein, it would be nice to eventually have the master branch build with -Werror by default, and then turn that off prior to each release.
Олсо, пробелы перед скобочками.
Речь про то, что если у тебя `item` пустым будет, то `item [0]` приведет к
сегфолту.
No sé si entendí a qué te referís. Tenemos ambas posibilidades: limitarlo por X días de antigüedad o limitarlo por X backups anteriores. Mi primer approach fue el último, y ahora lo cambié. ¿Vos estás diciendo que debería apuntar a ese?
Yes, thinking about it you are right. You can submit a patch to my branch or wait. I will make a patch to correct it during this week, but I have all days seminar on most of it.
```php
return $this
Please enable or remove test
I agree. There is no need for "root ems" when you are at the root. Any ems on the html tag are root ems!
Please add * before @
This should be a: `assert.ok(airbrake.notify.called)`
will this load the list correctly? or will it read in the value just as a string and need parsing to make it a list? please verify this.
This could just be `if device_path:`
I think it is fine in commons for now.  We were thinking of a separate module at some point for code that is shared between the Hot Rod client and the storage nodes; this would be one such class that is shared.
How about OwnershipStatistics or SegmentOwershipStatistics? That's even more specific to the actual problem it solves (keeping count of how many segments per each owner).
I think we should also handle the case if a file is deleted.
This indentation of the closing brace looks wrong to my eye; is there actually a PEP 8 edict about it?  If not, I think the original is much better, giving a better picture of the logical structure.
I switched the use_gridspec default to True in #774; I don't know of any disadvantages.  You might take this into account if/when you rebase.
My memory is a little haze, but if you put a double colon, and then indent the code, you will get a pretty code block if/when rendered with Sphinx.
Perhaps I am missing something here, but if x1==x0, then wouldn't the operation return zero anyway (unless xsteps==1)?  If all we are doing is preventing division by zero errors, then wouldn't we rather want to test for xsteps==1?
See note on CategoryController.
I've changed the way this is done in the upcoming pull request for Wifi. The problem here is that if this times out then the event listener is not removed and we will leak memory. I'm happy for this to be merged as is, but we will likely want a followup to fix it.
This bit isn't returning the boolean but I added `return` into the javascript and it returns correctly.
So you mean we should just rename `Format/WMSDescribeLayer/v1_1.js` to `Format/WMSDescribeLayer/v1_1_1.js`?
sorry, i must change setting in sublime. i will fix this.
Woow! really nice catch! I was looking for this!
I'd suggest a comment about why the two calls to __wt_tree_walk appear in different locations, it took me a minute or two to figure it out.
This wasn't related to the test failure.

The eviction code goes to some lengths to avoid evicting internal pages, I noticed that this code would negate that internal page prioritization.
So why is it bidirectional then?
Quoting JP Slavinsky  
<reply@reply.github.com>:

>> @@ -20,6 +21,8 @@
>>      <td><%= admin_only(user.username) %></td>
>>      <td><%= admin_only(user.email) %></td>
>>      <td><%= tf_to_yn(user.is_administrator?) %></td>
>> +    <td><%= tf_to_yn(user.is_confirmed?) %></td>
>> +    <td><% if !user.is_confirmed? %><%= button_to 'Confirm',  
>> user_confirm_path(user), :class => "button_link" %><% end %></td>
>
> To avoid making this table too crowded, please move the confirm  
> button out of this index view and into the user show view.  (right  
> below the 'sign in as this user' button).  The need to confirm  
> someone isn't so common that we'd want to be able to do a bunch  
> quickly from the index view.

Ok
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lml/quadbase/pull/58/files#r497107
>
>
The error message is missing a newline.
Are you sure that ``$hits`` (of type "array|object<Zend\Search\Lucene\Search\QueryHit>") is traversable?
Should the type for parameter ``$attribs`` not be ``null|array``? Maybe you can also make the array more specific, something like ``array<String>``, or ``String[]``?
I see this has been added to add support for array values, what about imploding the values on setProp (if the value is an array) and then use the string value here?
are you sure about this?

# nova-manage network create --help
Usage: nova-manage network create <args> [options]

Options:
  -h, --help            show this help message and exit
  --label=<label>       Label for network (ex: public)
  --fixed_range_v4=<x.x.x.x/yy>
                        IPv4 subnet (ex: 10.0.0.0/8)
  --num_networks=<number>
                        Number of networks to create
  --network_size=<number>
                        Number of IPs per network
  --vlan=<vlan id>      vlan id
  --vpn=VPN_START       vpn start
  --fixed_range_v6=CIDR_V6
                        IPv6 subnet (ex: fe80::/64
  --gateway=GATEWAY     gateway
  --gateway_v6=GATEWAY_V6
                        ipv6 gateway
  --bridge=<bridge>     VIFs on this network are connected to this bridge
  --bridge_interface=<bridge interface>
                        the bridge is connected to this interface
  --multi_host=<'T'|'F'>
                        Multi host
  --dns1=<DNS Address>  First DNS
  --dns2=<DNS Address>  Second DNS
  --uuid=<network uuid>
                        Network UUID
  --fixed_cidr=<x.x.x.x/yy>
                        IPv4 subnet for fixed IPS (ex: 10.20.0.0/16)
  --project_id=<project id>
                        Project id
  --priority=<number>   Network interface priority
Why removing the StreamClient (except for the fact the namespace was buggy) ?
`beforeSend && beforeSend.apply(xhr, arguments)` might be more future proof...or not worth it...just a thought. That and `xhr` is the correct context for beforeSend (just checked).
It should not fail if the file is not there, maybe not even fail if the folder is not there...
you mean Content-**T**ype ?
I found it a little hard to follow how we ultimately ended up populating the ```find_options``` for the query parameters.  Here's a simpler version:

```ruby
def self.find_in_batches(options = {})
  page = options[:start] || 1
  per_page = options[:batch_size] || BATCH_SIZE_DEFAULT
  find_options = { per_page: per_page }

  loop do
    find_options.merge!(page: page)
    batch = self.find(:all, params: find_options)
    break if batch.empty?
    yield batch
    break if batch.size < per_page
    page += 1
  end
end
```
nit: one more space before "fields" to align the text
nit: don't indent this (should be at the same level as l. 132)
Hmm what has happened here? This is not right... my intention was only to add
````
  // The number of spaces to add after the leading * in lines under the first line of each
  // paragraph. This is only used together with automatic line wrapping. For example, a value 
  // of 3 might look like this:
  //
  // /**
  //  * Duis sed arcu non tellus eleifend ullamcorper quis non erat. Curabitur
  //  *   metus elit, ultrices et tristique a, blandit at justo.
  //  * @param  {String} foo Lorem ipsum dolor sit amet.
  //  * @param  {Number} bar Nullam fringilla feugiat pretium. Quisque
  //  *   consectetur, risus eu pellentesque tincidunt, nulla ipsum imperdiet
  //  *   massa, sit amet adipiscing dolor.
  //  * @return {[Type]}
  //  */
  "jsdocs_indentation_spaces_same_para": 1,
````
Doc? You may at least want a `@see {@link #join(String, List<String>)}`
строка ```@posts = Post.all``` здесь лишняя
I removed this line of code.
Start with creating a class and defining some methods in, those you have now all around and are connected with implementation for one given language.
Import only modules. You already have `django.http` imported.
Use tuples for constant length lists, not lists.
Nice, simple template. Good.
You can put more links here. Like to the FSF.
Should be `--with-tests` ;)
GeometriaLab/Api/Mvc/Controller/AbstractController
add 
if (!victim->HasAuraType(SPELL_AURA_MOD_STUN) &&  !(spell->AttributesEx3 & SPELL_ATTR3_IGNORE_HIT_RESULT))
This will be `nil` if the current user is the owner. Is this by design, or should this be the actual `CMUser` instance for the current user? I remember we talked about this but of course I forget the outcome of that conversation.
Like I've said, I want first the UI then the rest will follow, like escaping/sanitization and rest of the functionality.
This file should not be part of the PR
It´s in the case your interface use SNAT, but for one network you want to route.
Exemple, you use multiple inline vlan, but for one of these vlan you want to exclude it from the SNAT and use routed network.
Is it realy important? `code test`
* why do you use \_\_new\_\_ here ?  
* non-object based classes have a constructor
nit: Selenium Grid hub started
I'd prefer
```javascript
var responsecode = cls.ResourceUtil.http_status_codes[entry.current_responsecode];
return responsecode ? String(responsecode) : renderer(entry);
```
You need to modify the testsuite so that these tests are automatically skipped if pubsub/wx is not installed. See buildtests/runtests.py, class SkipChecker.
should be `(( $? == 0 ))` or `[[ $? -eq 0]]`
This is not in the node code. Is there a reason for it here?
Write docstrings with `"""` on its own line. Be consistent.
Why purple?
Well... ```CppHSMShapeData``` is how we call it in the pysrc and therefore python, but if someone wants to refer to it in the documentation, there's no underscore.  So that's why I made this choice.
> view -> viewed (I have a feeling that Rachel is taking care of all the typos, and more, right now...)
> 
No, Rachel is cooking supper and checking e-mail briefly (AND talking about herself in the third person)... fixing typos will have to wait until later tonight.  Or, you can do it if you wish, I won't be touching the files for another ~1.5 hours or so.
Hi Mike,

I've now made this change in the pushed version (as it does not change actual operation I thought it was innocuous enough to proceed on)...

I've retained the `ImIter ee = data.rowEnd(y);` lines as it seemed that this was a slight optimization over repeated calls to the (admittedly likely to be quick anyhow) `data.rowEnd()` method...
bug here too.  should be ready_instance.exam
yup.  that's why i removed it on app100.stage
I think these need to be Erlang strings: `"/usr/lib/riak".to_erl_string` or `"__string_/usr/lib/riak"`
duplicate check of Objects.equal(template,other.template).

template and imageCondition are deliberately excluded from hashCode - with commented out code, with no explanation (why not just leave them out and have a comment saying it's deliberate and explaining why? Most people really don't like commented out code in the code base). Is it right to have them in equals?
No problem. WIll fix.
This is where the old Resources stuff has gone. It is better here since it's only used in this manner for asset handling anyway.
This return document didn't have a errocode (see below).. Only the lastErrorObject subdocument did.. I don't think we should be drilling into it to dig out the code...
Because mongos doesn't have tags, and this would filter out all connections because we were attempting to match the tags.
If `failure_url` is `http://bla.com/fail?` then this produces `http://bla.com/fail?&bid_login_failed=1`
It'd be better to use `self.is_element_visible` here. This is because present will return True even if the element can't be seen to the user! Which is not very useful in this case.
Yes in lasts version of friendly_id, you make me think of [a lost](https://github.com/bobbus/refinerycms-blog/commit/b56e70769792be52e16ca3c26bcc023b57835784) !
Personally, I don`t like the idea to loop through exceptions.
Which config file is that?
For compliance this goes to the next line.
@marcw for loadUserByUsername, we need to configure the property to be able to load it when the interface is not implemented.

@henrikbjorn if you implement the interface, you should not configure the property as it would not be used by loadUserByUsername otherwise
No, you can give up clearHints() method because array is initialized on class variable "hints".
I just thought, perhap's in some context it could be useful to re-initialize array, but I don't need it.
Nu e nevoie de <code>AnalyzerSelector.this.type</code> e ok doar <code>this.type</code>. Nu uita sa pui un spatiu dupa virgula.
looks like this transcription leaves out the 'yes w |' part of the command -- does that matter?
Two lines before, you are using `>>` and `tee -a` to append content to the `$logfile`. However, in this line you are truncating its content with a single `>`

Is this correct?
Wenn ihr meints wurde im Forum gewünscht ich habs realisiert und wieder 1 1/2 Tage in den Wind gesetzt ... :/
Laufzeit ja aber aufrufen nein (geht von selber auf) ... konkurenz (aPager) hats auch ... 
Ja dann wird das aber eh hier noch naja änderungsbedürftig weil die digitale allarmierung würde hier so garnix auslösen sondern auch das fax (was mal ganz am rande auch eine gewisse laufzeit hat :P )
Warum genau die vielen Änderungen (sieht nach ClickOnce aus)?
Зачем Scanner? Достаточно будет BufferedReader (у него есть readLine()).
Перенеси Errors в твой корневой пакет.
AtomicReference - generic-тип. Не надо приведения типов городить, если специфицируешь параметр.
Тип тот: я RuntimeException кидаю.  А как с помощью junit проверить сообщение внутри эксепшна?
@onema: I'll change the function name to set*.  Sound reasonable?
What does this property do? It's not clear by its name...
I think all this could be cached to avoid extra filesystem lookups.
Same goes here, DocumentRepository?
Ah, the phase, right.  But couldn't one find the peaks the standard way and do an extra level of suppression afterwards, based on their locations?
really? Holly crap!  ``np.arange(10)[:, np.newaxis]`` is neither C nor F-contiguous. @ogrisel can you explain?
This should be in the ``affinity : `` line.
Why `None` means `max_features=n_features` instead of  `'max'` for instance? And `default` not equal to `'auto'`?
Sorry for nitpicking.
>    Then what would be the point of "Seeding RNG with seed 4389128" before
>    running the tests? Something is eluding me...

In case people forget to seed everything (it has happened before).
I used `repeat` to make the row sums into a matrix of the same shape as Y. I'm still unfamiliar with all of the available numpy methods, so if there's a better way I'm all ears.

I don't think we should normalize in the multilabel case, since these probabilities should not sum to one. I think these should be the marginal probability that the given sample has the label in question. It is entirely consistent that two labels both have a 90% probability of applying to a given sample.
Ok for embedder.
I think we use ``--`` usually, right?
Could you please use ``n_epochs``?
w should be called 'weight'.
Okay, I was just hesitant to introduce a new parameter.
Ah, well the point of it is to make sure the current parts "buffer" gets empty after end() incase someone were to start pack()-ing again. This would keep it from getting jumbled up.

```javascript
encoder
  .multi()
    .pack('a')
    .pack('b')
    .end()
  .pack('c')
    .end();
```

Now why splice... I figured it was splice vs resetting "parts" with a new array. I feel like I had a reason not to keep resetting the array for performance reasons, but its not clicking right now. :-) It probably depends on the size of the writes though, huh?
Why is `int*(&x)` illegal? Is this a limitation, or intended?
As for `(int*)(&x)`: Wouldn't it be more consistent to make it legal, but to not cast?
This is supposed to be a runnable test, and this test will always fail.
`discus` ? Is that technically correct without a height parameter of the cylinder?
no.  Any expression that is annotated is ignored.
NULL string passed to printf generally works ok (in my experience) though not sure what  the official behaviour is...
It looks like it is never called, so please delete it.
I don't like this boolean flag which changes the return value of the method. You should have 2 methods: one returning the QueryBuilder and the second one executing it. It would be consistent with the NestedTreeRepository: https://github.com/l3pp4rd/DoctrineExtensions/blob/master/lib/Gedmo/Tree/Entity/Repository/NestedTreeRepository.php#L113
How about `invalidate_permissions_cache`?
Nevermind, I see that you just .close() whats returned from .open()..
@Logged
if ret =~ /NI_RTERR/
I had some instances of policy folders in the following format '{policy}_NTFRS_7dc8ba44' and Preferences folders in this format 'Preferences_NTFRS_b871a0c1'. I also had 'gpoFlag' and 'replFlag' in the Policies dir which would throw up some problems.
Goal of the change is to make the order irrelevant
Yeah. There's a couple other unrelated files that use `id` in the same way, so I can change those too.
It's actually constant per draw call, so ideally we'd get rid of this if check in the shader entirely.  Unfortunately, that's tricky because the `CentralBodySurface` knows when it needs this and when it doesn't, but `CentralBody` builds the shader.  We handle this for texture counts but it's not a general solution.  Let's leave this alone until we have a proper solution for shader management.
This whole function can be replaced with:

```C#
return obj ?? new T();
```
Hmm, that is not a good sign. Let me see if I can make this clearer.
It is not clear why we are removing this now from the source rather than accessing and removing a value.
I would like to make this more compact: `return typeof location !== "undefined" && url.indexOf(location.hostname) !== -1` and add comment about node.js
Does `expected a valid path` make sense as an error message?
иначе если не файлапи то что-то происходит что-то нет, ниче не понятно

или мы можем что-то делать если есть файлапи?