labofsahil/github-event-dataset-2012 huggingface dataset:
It looks like numbers only flow here in the demos, but I agree that this looks problematic. 

From:
http://docs.racket-lang.org/mzlib/mzlib_string.html?q=expr-%3Estring#%28def._%28%28lib._mzlib/string..rkt%29._expr-~3estring%29%29

        (expr->string expr) → string?

      expr : any/c

Prints expr into a string and returns the string.


(define (expr->string v)
  (let ([port (open-output-string)])
    (write v port)
    (get-output-string port)))

> so this change certainly narrows the range of acceptable types to the method from any/c to number?. I think this could change semantics, while it doesn't affect any of the code in demos or gui/demo that depends on fred.rkt. 

Racket doesn't seem to have an analogous procedure. Closest thing I could find is: 
(define pretty-format
    (case-lambda
      [(t) (pretty-format t (pretty-print-columns))]
      [(t w)
       (parameterize ([pretty-print-columns w])
         (let ([op (open-output-string)])
           (pretty-print t op)
           (let ([s (get-output-string op)])
             (if (eq? w 'infinity)
                 s
                 (substring s 0 (- (string-length s) 1))))))]))

Could we pull the definition from mzlib/string into it's own module and then require it here and in fred.rkt? Or, we continue to pull in this function-I was hoping to excise all of the mzlib depends haha :)
(Oops.) Fixed.
should we not assign the addresses before we claim to be done?
I took these directly from the original failure detector code so I assumed  
it is the idiomatic way, and has not changed that.
Swallowed? What is that supposed to mean in this instance?
I actually like the explicit nature of the cast… and the `const`.
There is no C-land interface to keep track of a socket once it is sent to a child. We could use `process.send` to send a message to the parent once a socket is destroyed, but that will properly slow down the child in high load cases. instead we will only keep a track of the sockets when `server.close()` is executed. It dose this by asking each child to send a message back once all its received is destroyed/closed. This procedure makes `.connections` an unreliable property (except when it is 0), to indicate that it is set to `null`.
It looks like `mustHeartBeat` becomes stuck in an infinite loop if the call to `syncHeartBeat` fails and returns None.
currently reports error on line 2
Throw an IllegalArgumentException ?
in case you have ZTS and GETSPANAM_R so

    #if defined(ZTS) && defined(HAVE_GETSPNAM_R)

get's execute you have buf allocated. In case php_posix_spwd_to_array fails you are not
freeing buf anymore.
опять же формочкой лучше
K, I was just turning it on so that things actually break when running the specs.  Otherwise everything can be mass assigned no problem (unless attr_accessible is called).
```ruby
class MyLib::Deprecator
  def warn(message, backtrace)
    Kernel.warn message
  end

  def deprecated_method_warning(method_name, message)
    "#{method_name} is deprecated and will be removed from MyLibrary | #{message}"
  end
end
```
I think we should continue depending on  `~> 0.6` for I18n and not on `~> 0.6.0`. The same for `multi_json`.
You mean like this
```ruby
o.each_with_object({}) do |(field, dir), memo| 
  memo[field] = (dir == :asc ? :desc : :asc )
end
```

This will be a little bit shorter, but i thought using native functions will be faster
Can we assert also on the message body? What happens in this case? Because it would be hard for this to render a template.
The second part of the comment add value to the method names which could be renamed getAllGeneralConstraintViolations.
I'd suggest Inf / 0 => Inf instead of Inf/0 => Undefined, consistently with the behavior of /(other: Duration), and being careful with the sign. I'd try to reuse the tricky code for deciding the sign, that is, `(if ((this > Zero) ^ (other >= Zero)) -1 else 1)`.
Free variables are detected and wrapped in symbols of the type `FreeTermSymbol or FreeTypeSymbol`
You are totally correct, my fault. I've fixed the test to assert existence in an updated pull request.
break ties canonically with `default_sort_key`. If `quick_sort` is given an additional parameter (the first key to sort on, default being hash) then you could write: `expr = quick_sort((expr, expr.expand()), key=count_ops)[0]`.
(why) is this commented out?
Sure.

The line !.gitignore should be included in master. If you would like to ignore it in your branch that is fine. We occasionally add files that git listed in git ignore.

Ex. I added the file sandbox.html to the repo. Then pushed it. Then I added the file to .gitignore so that changes will be ignored.
we can just use `.out(arg)` directly now.
It might make more sense to call this `get_spiral`.
Your composer.phar seems to be outdated.

    composer.phar self-update
We used to use `File.readlines`, which split on newlines but still included the `\n` char in the strings. Since our input doesn't always come from a file, I switched it to using `String#split` instead, which removes the `\n` chars. Pushing an empty string on at the end of each line makes up for the missing newline chars.
I find this one harder to read.  I think I prefer the old version.
а в вьюшке храним вьюшку:)
If I'm reading the code right, some pages without an `en/` title prefix (eg. non-english pages, templates, etc) will *never* get migrated: They get skipped on the first pass, in the building of the language tree. Then, if they're never mentioned in a `wiki.languages()` macro in an `en/` page, they'll never get picked up at all.

I guess what I'm looking for is, what's the ultimate use for this look like? And whatever that is, it should also go into the `scripts/migrate_*.sh` scripts
Prevents the need to duplicate the `log_level = :warn if log_level == :auto` code.
Please discuss this on the RFC/ticket and not here.
No it makes sense to break with bad habits and to start doing it correctly.
Does sphinx use mysql, or is configuration hardcoded to only work with boards running on mysql? If latter this needs to be fixed as I will be testing on a postgres board.
I moved it into the phpbb_functional_test_case class, as well as the $sid property, and made them protected. Tests still work, and now login() should be able to be used in any functional tests.
I forgot to mention, this is a weak skeleton code, there was a discussion on the coding guidelines for JS, so I made a WIP to comment on. The issues will be fixed in the next commit.
Are you sure? naderman told me to use `__DIR__` here: https://github.com/phpbb/phpbb3/pull/857#discussion_r1022309
Do you think that just returning the user_id isn't enough?

This function shouldn't generally be used as it's relatively inefficient to select users by their username, it's more meant to be a little helper in areas where users search for a user by username.
Nu cred că în forma asta le va număra și pe cele pierdute. `get_private_activity` filtrează doar după cele cu user la user_from. Atunci când pierde, semnalul este trimis pentru user_to.

Fie modifici filtrul, fie emiți activity (eventual nepublică) pentru 'chall-lost'.
We now support freetext questions. Please update test to only check for single & multiple choice questions. See https://github.com/rosedu/wouso/blob/master/wouso/core/qpool/models.py#L61
Why do messages need to be heap-allocated? I'd prefer if they were used as value types.
Few reasons:

 * in the short-term, we want "dump" to produce a json for the SVG.
 * at some point, someone might want to dump data programmatically to collect the state of the execution. Imagine a mojit that runs last, and print the perf info in the page.
 * it was exposed before, not so sure why :)
needs remove_reference on Type
notice that this file is unchanged (except for an added tab). please remove from pull request
nitpick: spelling error. "cheifComplain" should be "chiefComplain". Recommend changing "complain" to "complaint" while you're at it.
It should be ``in the current working directory`` rather than ``in Theano's path``.
If you actually catchan IOException, here, m_reportWriter will be null and you will get a NullPointerException when you go to use it, below -- you really don't want to continue.
Agreed, I spent a while considering just that as well.

`Last` is a signal that Pipe gives workers to let them know that they are the final entry in the preflist for this `Input`, so no more attempts to process it will be made if this worker decides it's unable to do so itself. Put another way, returning `forward_preflist` when `Last==true` will raise a `preflist_exhausted` error.

I used `Last` here to short-circuit the expected case where failures at other Pipe vnodes means that we should expect those KV vnodes to be dead as well. Checking `Last` here means we can skip preflist generation and such.

We could skip the `Last` check and just call `try_preflist/2`, but we'd want to do a little mucking with the generated preflist anyway, because we always want to attempt to talk to the local KV vnode first, to avoid using network bandwidth if we don't have to. That's as simple as `[{P, node()}|RestPreflist]` between lines 114 and 115, though.
the function is not synchronous so error would be assigned after compilation and lost. And it's not `.map` because you throw away result of execution. you should probably use `async.forEach`.
Added a note on URLconfs that points to docs.
Useless Javadoc.
But this adds a call to the stack for poorly performing browsers :\
Well, I think that shortcut conflict is not only debug or milestone. It could be quite important if your module doesn't have shortcut you want.
Actually, i notice the existing function text_to_cstring. However, there are some error when linkage. I try use text_to_cstring again, it works well. Maybe i have something wrong before. I will change to the existing functions: text_to_cstring and cstring_to_text. Thanks.
atleast -> at least
Accept.
While I agree in principle, one should never have using directives or declarations at file scope in header files. However, using declarations in a definition of a class can only be used to import names from a base class.
Is it worth adding a `strip()`?

    [test.strip() for test in args.testcase.split(',')]
Do we detect and error out in the event of Polymorphism and anon return tuples?  Or what is the behavior?
Also indents should be 2sp
`--with-gmp-prefix` is not needed, it seems. (Same as for isl and mpfr)
Check on type of URL added.
This callback should be passed an error so that the middleware can be able to figure out that an actual error has occured.
Ask kemitche
He has been dealt with haha
+1 for MockOS :(
I'd probably just go with 100 (or maybe 90 plus extension).

Picking random articles off the NYT homepage, I can easily find 50- and 60-character-long filenames. Picking articles off of Gizmodo, I quickly found a 72.

Joliet FS supposedly works up to 103, and I'm not really too concerned about people still using Joliet FS to back up in any case.
What should do the overriding?
It's Wiki, not WiKi, right?
By removing this, you are requiring that all listeners be thread-safe, aren't you? If so, I think we should discuss.
This also needs to check that lconfig.partition.size > 0, otherwise you'll get "Entries_" as the table name.
more descriptive variable names than `k` and `t` would be helpful
Aren't we doing the same thing in some other specs? Can this be moved up to spec_helpers?
All three parameters should be marked required ``!``.
I would think that people know that Google Chrome is a browser, it seems redundant to mention it.
Yes, we do need these quotes. Both Jason and I had experienced with some issues w/o these quotes.
in fact, that suggested `if` could be moved up to the `if (!(ignore instanceof ...` line
Please add a toggle switch. Which I did (you could probably just copy this verbatim)

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="X-UA-Compatible" content="IE=EmulateIE7; IE=EmulateIE9">
    <title>dygraph</title>
    <!--[if IE]>
    <script type="text/javascript" src="../excanvas.js"></script>
    <![endif]-->
    <!--
    For production (minified) code, use:
    <script type="text/javascript" src="dygraph-combined.js"></script>
    -->
    <script type="text/javascript" src="../dygraph-dev.js"></script>
    <style type="text/css">
      body { font-size: 18pt;font-family: sans-serif; }
      .dygraph-label { font-size: 16px;font-family: sans-serif; }
      .dygraph-title { font-size: 18px;font-family: sans-serif; }
      .dygraph-legend { left:70px !important;top: 40px !important; }
    </style>
  </head>
  <body>
    <div id="graphdiv"></div>
    <input type=checkbox onClick="toggle()">Toggle

    <script type="text/javascript">
      g = new Dygraph(
      document.getElementById("graphdiv"),
      [[1,1,1],[2,4,8],[3,9,27],[4,16,64],[5,25,125],[6,36,216],
      [7,49,343],[8,64,512],[9,81,729],[10,100,1000]],   
      {
        labels: [ "X", "X^2","X^3" ],
        dateWindow: [ 0.4,10.6 ],
        valueRange: [-50,1050],
        fullAxisFrame: true,
        axisLineWidth: 2,
        strokeWidth: 2.0,
        title: "Full Axis Frame",
        colors: ["#004080","#800040"],
        labelsDivWidth:80,
        labelsSeparateLines: true,
        drawPoints: true,
        pointSize: 4,
        }
        );

       var on = true;
       function toggle() {
        on = !on;
        g.updateOptions({fullAxisFrame : on });
       }
      </script>
    </body>
</html>
You seem to have removed some of the verifications done on channel and row['parent_id'].  Did you determine that those checks are unnecessary?
Tried to use find_or_create_by but keep getting an undefined method error..
at this point in exam week to be honest I just don't have enough time to spend a couple hours (yeah you're going to laugh but it takes me that long since I have absolutely no prior experience) trying to rewrite this to make it slightly more efficient.
Sorry I just don't have the time anymore given the amount of time I've already spent on this.
Is `f` needed?
It is fixed, thank you
This can be reduced to

```javascript
return TString.replace(/translate\(/gi, "t")
              .replace(/rotate\(/gi, "r")
              .replace(/scale\(/gi, "s")
              .replace(/[)]/g, "");
```
Good but group them into sections. Our imports are a separate section (add just one empty line in-between).
Ok nevermind I think i know what you meant. I don't need a class for radio buttons, actually no classes at all.
This works just fine:
`.form_fields li ul li {
    display: inline;
}`
So I can remove the renderer?
Added `bounds` to `default_error_messages` without overriding.
Second time this has been included, no?  Should you extract the HTML5 Boilerplate into one css file and reuse?
Remove the `EMBED_HOSTNAME` and `EMBED_SUFFIX` var declarations above, and put the variable definitions right inside this object block. This will require some more changes in routes, but it'll be worth it.
or popcornOptions[ item ].indexOf( "data:Image" )
See second down comment on whitespace issues.
+= does not really make sense here (and few lines below), you may just use `= ANNOT_MIN_SIZE`
chrome forbids inline onclick handlers
calling `__toString()` is not required, afaik, as you are using `%s` in your `sprintf()` *(since PHP >= 5.2)*
taghyir dovomi vase in bod ke fazaye khali payine menu he dasht vase in inkaro kardam ke albate min-height ro aslan bayad hazf kard ke lazem nist
```
div.menu_wrap div.menu {
	background-image	: url('./images/menu_back.png'); 
	background-repeat	: repeat-y;
	background-position	: top left;
	min-height			: 480px;
}
```
why do we need to send layername as a param if it is already included in the URL?
cdb.cc should not need backendname; if you really want that string in here, have tinydnsbackend re-raise :)
Request to switch the asserts here and a few below to use the Minitest asserts for cleaner output during failures.
Are you sure you want to change the HTML (.html()) or the TEXT (.text()) or perhaps attr('value')?
If you expand it to multiple lines, I think one arg per line is more readable.
On 15/03/2012 15:37, Timothy Guan-tin Chien wrote:
>> @@ -150,9 +175,11 @@ var LockScreen = {
>>             return;
>>           window.clearTimeout(this._timeout);
>>
>> -        ScreenManager.toggleScreen();
>> -        if (screen.mozEnabled)
>> -          this.update();
>> +        if (screen.mozEnabled) {
>> +          this.update(ScreenManager.turnScreenOff);
> Yes, but it would be brief. And its better than having the homescreen flashes when the screen is turned back on.

I'm not sure I like that but I agree with you that having the homescreen 
flash when the screen is turned on is worse. so r+ with the usual styles 
for functions.
I added it to ``Notes`` instead - is that ok?
You can do this with:
```
starts = np.cumsum(col_width)[:-1]
ends = np.cumsum(col_width)[1:]
```
`isinstance(unit, str)` -> `isinstance(unit, basestring)`
我本来很想换掉，但是怕朝歌的兄弟们迁移过来的时候不太适应。

不过有get()了以后应该还好。
`Mmebers` -> `Members`
Useful function to have for analysis, but I don't think we should run it every time we invoke our eunit suite.
Also add docstring describing what kwargs is expected to have in it
Agree, in this case, it's an optimization not needing to calculate the hash.
I am pretty sure it once was.. :) must have fallen back to a previous version again. I'll fix that!
Oh wait, you mean like the nested if-statements? Then the answer would be probably not :)

When $status is not empty it always needs to set the header. And only when $status is a string it needs to translate it.
I know, but considering the function heavily depends on that parameter, that's a way of making it known. Also, if the default value changes in the (near) future, the test won't break.
This is only a copy of the exiting file. I am not familiar with generator.
Change the name to FixUserName. This isn't specific to OpenID (hopefully).
```if(!extended.Any())```
This method seems to have been duplicated?
there is a retry, as the normal retry handler for S3 retries 5 times on
exponential backoff.  I agree that deleting very large buckets may need a
further batching, but why would we replicate another retry here when
there's already a retry on each request? seems if the retry on the request
is incorrect, fix that, vs wrapping it again.  Wdyt?
On Oct 18, 2012 3:00 PM, "Andrew Gaul" <notifications@github.com> wrote:

> In
> providers/aws-s3/src/main/java/org/jclouds/aws/s3/blobstore/strategy/internal/DeleteObjectsInBatches.java:
>
> > +         } catch (InterruptedException ie) {
> > +            Thread.currentThread().interrupt();
> > +            break;
> > +
> > +         } catch (ExecutionException ee) {
> > +            errorCount++;
> > +            if (errorCount == MAX_ERROR_COUNT) {
> > +               throw Throwables.propagate(ee.getCause());
> > +            }
> > +            retryHandler.imposeBackoffExponentialDelay(errorCount, message);
> > +            continue;
> > +         }
> > +
> > +         // A PageSet always has less than 1000 elements and can be removed in a single call
> > +         Set<String> keys = convertPageSetToListOfKeys(listing);
> > +         responses.put(index, asyncS3Client.deleteMultipleObjects(containerName, keys));
>
> For buckets with billions of blobs, you will accumulate millions of
> Futures here. Also if any single call fails there is no retry.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/903/files#r1884378>.
>
>
I am not a fan of creating an entire `git_checkout_opts` structure on the stack just to do this. Can we not just:

```c
    memset(normalized, 0, sizeof(git_checkout_opts));
    normalized->version = GIT_CHECKOUT_OPTS_VERSION;
```

I know we are talking about a relatively small amount of stack space, but doing this way just galls me.
Fixed and rebased!
How about indicating that `GIT_ENOTFOUND` is being returned when no object matching the resolved oid can be found in the odb?
The getFeatures function returns a feature depending on if we are doing the whole layer or just the selection.
Agreed but this was there before me. I don't even know the different between the two, thus I can't change it.
I think we should use a pep8 style format here to avoid excess indentation. E.g. 

```
    jobs='''
        socorro.cron.jobs.weekly_reports_partitions.WeeklyReportsPartitionsCronApp|7d
        socorro.cron.jobs.matviews.ProductVersionsCronApp|1d|02:00
        ...
    '''
```

This time we were lucky that the variable name ("jobs") was just 4 characters long.
It's right there. So yeah, probably not a big deal. :)
Right but why is there a list of random categories in there already?  

--  
Phil Sturgeon


On Monday, 20 August 2012 at 10:40, Salmane wrote:

> In system/cms/modules/blog/config/routes.php:
> > +<?php defined('BASEPATH') OR exit('No direct script access allowed'); > +$route['blog/rss/all.rss']='blog/rss/index'; > +$route['blog'] = 'blog'; > +$route['blog/positive/(:num)?'] = 'blog/category/positive/$2'; > +$route['blog/positive/(:any)?'] = 'blog/view/$1'; > +$route['blog/positive']= 'blog/category/positive'; > +$route['blog/beautiful/(:num)?'] = 'blog/category/beautiful/$2'; > +$route['blog/beautiful/(:any)?'] = 'blog/view/$1'; > +$route['blog/beautiful']= 'blog/category/beautiful'; > +$route['blog/animals/(:num)?'] = 'blog/category/animals/$2'; > +$route['blog/animals/(:any)?'] = 'blog/view/$1'; > +$route['blog/animals']= 'blog/category/animals'; > +$route['blog/environment/(:num)?'] = 'blog/category/environment/$2'; > +$route['blog/environment/(:any)?'] = 'blog/view/$1'; > +$route['blog/environment']= 'blog/category/environment'; > +$route['blog/food/(:num)?'] = 'blog/category/food/$2';  
> The initial default router is for blog name of "blog" .. this can be changed to any name or left blank in which case new routing is created dynamically
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/pyrocms/pyrocms/pull/1707/files#r1412374).  
>  
>  
>
I will add:
"@since 1.196" for the next stapler version. Is that okay?
To clarify the meaning for discussions elsewhere: `hasSession()` means does this have a session object. Its not a reflection of the state of the session object.
For reference, here is the way Doctrine computes a cache key for the result cache: https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query.php#L596
you should add the phpdoc of the class, including your authorship :)
Braces on methods must be on a new line.
@hhamon It's just like the finder himself https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Finder/Finder.php
Theres no CS rule for this, the same is done all over the codebase.
Migrate to stub file `cascading-ambrose-detail-pane.js`?

I'd thought we might place all runtime specializations of base views in files whose names match `<viewName>-<runtimeName>.js`.
private[this] val fService = factory.apply()
2 comments:
- use private[this] by default
- The lazy feature here is not very useful
LGTM, my only complaint is I'd rather call it `escape` instead of `escapeFn`
Weird formatting here, and in the `Coder` method as well. Can you check this online to see what I mean?
You should do an `exit 1` here so other scripts know that this one failed.
nicely done here.
These two requires will need to be realtive, `./test` to work on 1.9.3
`$_SERVER['REQUEST_URI']` is fine, but it should be called `'url' => $_SERVER['REQUEST_URI']` instead.
I'd leave notes separate from Categories.  I think it will work fine if Notes have Categories --- Categories do not need to have Notes.
Ready. All right!
На стационарном косячило, решил оставить на потом.
e026de5
Looks like we need for configuration another layer:

Common > InstallationBacked > MANAGED|EMBEDDED
Common > REMOTE
Just a minor nit, but this service should just create the map in start(), and then clear it in stop(). At the moment it is never cleared, so if the service is restarted you will still have old service names in the set.

Other than this I think this looks good
OK, I won't deprecate this.

I'm not going to revert the change in the master PR that switches all the subsystems to using the microVersion API though. I want to minimize differences between the branches, and a microVersion in master is legit if the only reason the API changed was because of a microVersion update for the 7.1 branch.
THis map isn't necessary
Same issue as with `EventCommentMapper::getCommentById()` above.
这样不知道能不能拿到，可能需要变成@resource（“userService”）加一个private变量来引入
This really simplify all the list elements related functions.
I do remembered you mentioned to combine all the functions into one in previous PR comments. ^^
You could address both of the above comments by setting display:none by default for #loading. You could then set style.display='block' in WaitingScreen.show() and use a setTimeout(, 300) to set style.display='' in WaitingScreen.hide(). It's not the nicest way to do this stuff in JavaScript but so we'd keep the animation intact and achieve the same result.
Sounds like turning this comment in english would be nice :)
The first page is the landing page so it should be added in index.html (row 33)

<div id="search" data-currentPage=true>
There is no reasons that it is slower. So we likely need to investigate. Also the perceive slowniness could be because the first script is not deferred and use a document.write (which is really a shame but this i would like to keep a way to load a script not based on it's domain name, without duplicating the code and by keeping the compatibility with F5. I'm open to suggestions!)
What about |var options = this.repeatSelect.options| and use that instead ?
Would it be better to change the identifier to `delete-n-items?`?  Also, can you add a comment explaining that 'items' can be photos and videos?
This is too specific. Using `display: block` on an inline element doesn’t make sense for a **generic** dialog stylesheet.
jstut (https://github.com/asutherland/jstut).  The syntax and much of the overall inspiration is derived from Racket's scribble documentation language.  Some relevant blog posts whose live examples are generally dead: http://www.visophyte.org/blog/tag/jstut/

To see an example of some output, visit http://clicky.visophyte.org/live/deuxdrop/docs/docloader.html?doc=protocol/conversation.jstut then click on the first expandy thing "ConvCreate", then on payload, then on addPayloads.

There's probably a bit of work required to make the tool do useful things; I am just happy to have an unambiguous format to describe structured data that looks a bit like jsdoc (but handles structured data better).  Also, it has the smarts/semantics to actually link types across disparate sites, etc.
I know this library is iScroll but we use self instead of that. I don't say: change it :) It's only a suggestion for our code in the future
The `new` activity is handled with `window` disposition, so this line is correct.
This is not posible as an asumption. checks will last longer than 10s, I've got plenty of them :(
i think that will get taken care of in handoff() -> handoffOne(), where it drops items until it reaches maxItems again.
No, you're reasoning makes sense, and I agree.
Could you capitalize this sentence and add a period at the end? And do the same for other sentences in the docstring.
Yeah that was the reason - on reflection it makes sense to put the preset in the base class too, even if it's not useful for smtp.
hrtime has seconds as well couldn't we just use `[0]`? might simplify calculation a bit instead of us throwing 1000 around a bunch
Move to correct modules.
Change this to `{ write: writer }` (mind the whitespace) and pass the unwrapped write function.
> I thought a form was something you filled with according values.

TIL arrays, objects, are actually forms
also here, replace type(balabala) == sometype with isinstance().

FYI:
```
Object type comparisons should always use isinstance() instead of comparing types directly.

Yes: if isinstance(obj, int):

No:  if type(obj) is type(1):
```
copied from http://www.python.org/dev/peps/pep-0008/
If we are going to handle this, then it should be handled in BasedirMixin. Although, if this option is coming from the shell, it will have already had this done.  Maybe loadOptionsFile needs to be taught about directory arguments and handle this there.
If we don't do that, and if we stick to using branch_placeholder for configuring the pattern, then the best way to do it would be have another URL where the location of placeholder is specified, which again means two URLs. Or we might have to move away from using the placeholder. I have not given much thought to how else we might tackle the problem.
Ok, this is totally unrelated to any "external" stylesheet. It's for inlined LESS within HTML, e.g.:
```html
<style type="text/x-less">
@foo: black;
#myelement {
    a {
        color: @foo;
    }
}
</style>
```

This snippet would have a filename equal to the document URL.
抱歉。 I didn't make the change, I pulled it from upstream.  Is there an alternative explanation?
are you sure this works in linux?
can a current_user create keys for anyone but him/herself
This should be imported from Linux as Linux can be compiled to change thsi.
Yep, as long as it's being output in footer.
I thought whole point of system tmp dirs is that system cleans them up itself so you don't have to doi manually.
`promise can be either rejected or resolved only once` sounds good to me. 
But you can use the phrasing you used in your comment:
`promise can be either rejected or resolved and that only once.`
You may ping some native english speaker to get a better sentence :p
I didn't as it became messy with comments.
This was transition code for issue #1000.  No longer needed.
wonky comment
Now I get it! It's no a InnerClassList instance. It's a class. Uninstanciated. The word "keys" tripped me up.
isn't it the case now?
Are we certain gtar is always installed?
If create===false, are we still passing back the last child of the output_block, like it says in the comment at the start of the function?  Or should the else block above say out = output_block.children().last(), or should we just leave the .children().last() in the return statement?
I think its more so we don't confuse the results of an event. Currently, it
seems the before and after of an event really refer to the previous's
events before and after. Its really up to you since you are the only one
using the snapshot now.
On Oct 22, 2012 5:22 PM, "schasins" <notifications@github.com> wrote:

> In scripts/content/content_script.js:
>
> >      curSnapshot = snapshot();
> > -    eventMessage["snapshotAfter"] = curSnapshot;
> > +    eventMessage["snapshotBefore"] = curSnapshot;
> > +    eventMessage["snapshotAfter"] = {};
>
> So do we actually want to just leave this as it was before, recording both
> the snapshotBefore and the snapshotAfter, until we implement better timed
> snapshots? Is there a reason to prefer giving it an empty snapshot?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sbarman/webscript/pull/6/files#r1911083>.
>
>
There were tabs here
This should be indented if you are going to wrap.
just make this a ternary:

```js
this.options.container ? $tip.appendTo(this.options.container) : $tip.insertAfter(this.$element)
```
I wouldn't skip it silently, that can result in awkward error searching.
`sulla istanza` -> `sulla istanza del`
I'd prefer to use the memory adapter on testing cache consumers to simplify things ;)
Missing attribute declaration
See previous notes about foreach statements.
I did not really understand it to be honest. I can't understand the use case nor the test, so I can't really update it :/.
nice I did not know we were already doing migrations with knpbundles, good to know
This should be noted and handled as this is BC break, also you should extend fixtures code IMO.
And by "true" I mean "false", sorry about that.
I share your concern. Perhaps the reason is that we're dealing with updating two separate backing store, the DB and Blog storage. We should add a robust rollback mechanism.
Oui je viens de voir ça


Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Friday, October 19, 2012 at 6:52 PM, Sébastien Saunier wrote:

> In lib/passbook/pkpass.rb:
> > manifest = self.createManifest > > # Check pass for necessary files and fields > self.checkPass manifest > > signature = self.createSignature manifest > - return self.createZip(manifest, signature) > + > + if options[:as_file] > + return self.outputZip(manifest, signature)  
> Tu as inversé les deux conditions en fait. as_file ça veut dire qu'on crée un fichier sur le disque. non?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/applidget/passbook/pull/1/files#r1892127).  
>  
>  
>
ah gotcha, I think we should restrict the range of viewable dates to the largest year
It's named this way in the whole project and I wanted to be consistent. See for example the `WebController`.
the javadoc should not only mention it is "case insensitive" but maybe also tell that the result of the method is always LOWER CASE...
`@type t :: Enum.Iterator.t` ?
if the former purging process is still alive, you at least remove the lock file, and maybe try to relaunch the purge.
Forgot to remove this line (bad copy/paste)
import X before fromX import Y lines. Also, two empty lines before class definition.
Should be JBoss not Boss :-)
This would work very well as an Arquillian test, as it would sort out deploying the app to JBoss AS for you.
Uber-nit: s/bedrock/Bedrock
+1 to this, but a more complete example is to take both of Tim's comments together. Use the constants everywhere, as both "keys" in the `PERMISSION_LEVELS` list (I know they're not really keys but you know what I mean) and as default values elsewhere.

```python
# phonebook.helpers

VOUCHED = 'vo'
PUBLIC = 'pb'

PERMISSION_LEVELS = (
    (VOUCHED, _lazy('Vouched Only')),
    (PUBLIC, _lazy('Public')),
)
```

```python
# elsewhere
from phonebook.helpers import PERMISSION_LEVELS, VOUCHED, PUBLIC, ADMIN

self.privacy_dict = dict(basic_info_privacy=VOUCHED,
                         contact_info_privacy=VOUCHED,
                         tags_privacy=VOUCHED)
````

In fact, that would let us define privacy levels as integers instead of strings, which would let us do comparisons. E.g.:

```python
# Imagine a hypothetical future where we've added ADMIN and, later, a STAFF-only level.

ADMIN = 30
STAFF = 25
VOUCHED = 20
UNVOUCHED = 10
PUBLIC = 0

PERMISSION_LEVELS = (
    (VOUCHED, _lazy('Vouched')),
    # ...snip...
)

# Then in other code we can do something like:
if user.get_level() > profile.basic_info_privacy:
    # Display things...
```
Can these `assert`s have a string as the third argument that describes exactly what they're testing?
we missed this guy. should be "checkbox"
Update the example at the end of the sentence too.
Can you remove this? I assume it was for debugging during development?
isinstance comparison works with both tuples and single types.

I decided to avoid the recursive scenario for this library. I've never encountered the need for the recursive case which isn't covered by `iterate_flatten` or `map` and unfortunately it makes the code significantly harder to follow which is against the project's Philosophy and Organization (see README).

Do you have a specific common scenario which requires the recursive functionality of your version?
I moved those tests to `test/css/test_parser.rb` in 3753f7b4
I tend to agree that the comment is not required, simply because the logic of find_resource is reused across most of the api controllers
Remove this. No need to import it twice.
It's not important but the best practice is to start the doc string with "Return ..." or "Returns ...".
No divide by zero handling?
This has to go.
At least in Harmattan it didn't and since NGF is (AFAIU) pretty much the same it shouldn't now, either. I can check at some point though.
I didn't realize before, but you can't have a dot in the define name, so probably change it to FG_2_4
Is this guaranteed to be an int? Perhaps wrap it in `int()` to be safe?
It was used for debugging of the first version.
The better logging solution should be used in this case, I'll remove console logging.
the _.keys operation should probably only happen once.
If these are the configuration values for the clientId and clientSecret, they should probably be exposed as elements? They should also be renamed to clientId and clientSecret.
There seems to be quite a bit of overlap between this and initializeTenants.
This can be removed once the UI itself is hooked up
OMG, you are right! :) Fixing it.
There is no need to cast this to ``Boolean``, since at line [166](https://github.com/scala-ide/scala-ide/pull/153/files#L28R166) there is already a cast. That way you can simplify the code a bit.
De indenting in deze functie is een beetje overal. Vooral de laatste regel. De laatste `}` moet op een nieuwe lijn denk ik
ACK
On Nov 15, 2012, at 7:42 AM, Andrey Andreev wrote:

> In user_guide_src/source/libraries/javascript.rst:
> 
> >  
> > -To initialize the Javascript class manually in your controller
> > -constructor, use the $this->load->library function. Currently, the only
> > -available library is jQuery, which will automatically be loaded like
> > -this::
> > +To use a Javascript library you will need to set a configuration item for the path to the Javascript library that you'll be using.
> Could you change long lines so that they have between 70 and 80 characters per line?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
а можно уточнить, что не так с DNA_LENGTH (если вопрос к моему коду)?
С названием лохонулся не спорю - буду бдительнее.
А храню чтобы менять можно было - удобно тестировать когда массив меньше чем 100
Тогда уроните программу с помощью @throw или assert (NSAssert).
Некорректное определение кол-ва элементов для замены, для массива со 100 элементами сработает, если указать, например, 170 - то нет.
Do you think it'd be possible (or even worthwhile) to try and do one iteration through the nodes?  Or would it increase complexity too much?
it { should have_content('Wrong') }
Looks like a specific implementation URL.
it should be here.
Cool, will do. I'll add the docblock as well. 

On 21 Sep 2012, at 14:51, Alex Tran <notifications@github.com> wrote:

> In Records.php:
> 
> > @@ -100,5 +100,19 @@ public function delete($domain, $recordId)
> >  
> >  		return $apiResponse;
> >  	}
> > +
> > +	public function update($domain, $recordId, $record)
> > +	{
> > +		$url = DnsMadeEasy_Domains::API_URL . $domain . '/' . self::API_URL . $recordId;
> > +
> > +		try {
> > +			$apiResponse = $this->_put($url, $record, 200);
> > +		}
> > +		catch (Exception $e) {
> > +			throw new DnsMadeEasy_Exception("Unable to put record $recordId from $domain.", NULL, $e);
> minor thing here. i like error messages to be as user-friendly as possible, so i'd suggest you phrase it "unable to update" instead of "unable to put." that way it uses the same wording as the function name and abstracts away the concept of a PUT to the user.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Yes, there are several place where we need to perform sanity checking.  For example, we shouldn't allow bidding on 'accepted' or 'completed' trades.   This would probably make a good chore or story for the next sprint.
Use local scope.
I added filtering through with environments, too, so when I land the next version, it will support {"environments__elements__name": name} in the params.  Please add a #TODO comment here to use that when the new code lands.
It's not safe to use `@synchronized` on two different objects in different orders, because two threads could grab each of the objects and then deadlock trying to get the other.

When using `@synchronized` separately on multiple objects, it should always occur in the same order.
I tried it on line 217 first, but couldn't figure out how to get 'season' there.
logger.warning?
I'm not sure if we should just send warnings to the log, or also emit a warning. I like doing both, but I'm open to suggestions.
Yes, not that handy. I think, as Alex suggests, using a private function should help unclutter this. As to self.sources: but then how to handle raw / epochs sources in one session? Unless you use a dict / Bunch.
makes sense, may i do it in this PR?

On 21.10.2012, at 19:37, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/fiff/raw.py:
> 
> >          indices = []
> >          for time in args:
> >              ind = int(time * self.info['sfreq'])
> >              indices.append(ind)
> >          return indices
> >  
> > +    def index_to_time(self, *args):
> to avoid breaking peoples code can we come up with another method name? time_as_index and index_as_time and deprecate time_to_index?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Extra print statement?
Do you mean letting the tag get the property in this particular case? So, the possible values for the parameter will be:

- global (let the tag find the property if any)
- lowercase
- uppercase
- capitalize
What happens if the incoming time represented by `ENV['BUILD_ID']` is already in UTC?  It appears we get a double conversion:

```irb
irb(main):001:0> require 'time'
=> true
irb(main):002:0> build_id = "2012-12-25_16-41-40"
=> "2012-12-25_16-41-40"
irb(main):003:0> converted_time = Time.strptime(build_id, "%Y-%m-%d_%H-%M-%S")
=> 2012-12-25 16:41:40 -0500
irb(main):004:0> converted_time_utc = converted_time.utc
=> 2012-12-25 21:41:40 UTC
```
We should return nil here.
I forgot to rename it in this place when I renamed it for Ray earlier.
I think this docstring is wrong with the new changes.
Plus, `new_indexes` assumes you're dealing with the users table anyway.
I see a lot of file removals, is this on purpose?
I'd also be tempted to do:

```ruby
send "bump_#{part}".to_sym
```

Here to avoid the `if`s which should be a `case` statement otherwise.
Не уверен, что первая проверка имеет смысл.
¿Y debería ser así?
Me pregunto qué motivo  hubo para no usar un array común y corriente.
Acá pasó algo raro.
Como helper en la vista si lo pensé, pero quería que se pudiera reusar en distintas visats. No lo había pensado como vista parcial, en ese caso podría estar bien ¿funciona?

Intenté usar la carpeta `app_code` pero no me gustaba que tenía que mandar el HtmlHelper como parámetro.
Possible to remove this constructor if from returns `this`
We shouldn't waste resources on people being stupid. I'd rather know that
something is missing anyway.

On Wed, Jul 11, 2012 at 2:53 PM, Marcus Forsberg <
reply@reply.github.com
> wrote:

> >       if (strpos($filename, 'http') === false ||
> !empty($options['local']))
> > -             $filename = $settings[$theme] . '/' . $filename;
> > +     {
> > +             // Make sure it exists, too!
> > +             if(!file_exists($settings[$theme . '_dir'] . '/scripts/' .
> $filename))
>
> I see what you mean, but we should really never add a <script> or <link>
> tag if the file it's pointing to definitely doesn't exist. 404 requests are
> never a good thing for page loading, from what I've learned.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/SimpleMachines/SMF2.1/pull/63/files#r1143278
>
please add this loader
move this to middleware
this inclusion can now be removed
Maybe this should be `LOG.debug`?
it doesn't hurt IMO, as people might want to amend the whole configuration at once instead of doing two calls.
true, good point
@galderz I ran CustomClassResolverCacheRestartTest without your fix, but with fetchInMemoryState(false), and it passed.
You can use address(cache1) (from MultipleCacheManagersTest).
Another option is to break out the conditional logic into a separate method, like sanitize_signed(), and call it from both branches of the if/elif below.
and what if the user set a filename that is an absolute filepath that is outside the notebook's observable filesystem?  I think some more thought needs to go into this.

Plus, I think this whole repr stuff needs to be in a separate PR.
Is it worth turning this into a regression test?
weird, how did this pass on my end, hmmmmmm, fixing
+1 in fact, if we could have a single method for changing a setting that took the name of the setting and the value then we shouldn't be limited to just boolean values. We could also provide a helper for enable/disable.
XHTML requires `alt` attribute for all `<img>` elements
No - the checkbox basically extends department's membership to also include groups with access.  It doesn't change the group access. All it means is - anyone with access to the department will get alerts and such.
@bp323 I couldn't find any that weren't, did you find a talk that didn't work?
They have been converting most (I'm not sure whether all) talks to .mp4 so they play on iPadPodPhone machines.

We're leveraging that to play it within our own app.
@gsilver Since we are modifying this line, could we also add -webkit and the regular version of border-radius?
afaik, we also don't need to repeat if 4 times.
This is kind of a mutant hybrid between the old search template approach and the new refactoring.

In the new approach, this SlingHttpServletRequest-dependent template-oriented method shouldn't need implementing. The goal is to keep these query handler classes available for use by server-side components. The request parameters will all show up in the parametersMap. And the vestigial templates should only have one "property", not multiple.
sounds like a good plan ;)
This is useless IMO as you are moving the id to itself
Just `Silex'`.
- Are you sure the variable ``$domains`` exists, or did you maybe mean ``$domain``?
- Please always use braces to surround the code block of IF statements.
1 char field name, perhaps jettyServer is better?
Sounds rather sensible indeed, but I don't see where/how I could wrap all the Symfony code in a try/catch to catch such an Exception...?
ahh now i see it - clever :)
Keeping a ref to the connection in order to fulfill the interface definition. three's a HPCCPreparedStatement.getConnection() method.

If I declare it final, I won't be able to set it to null at HPCCPreparedStatement.close(). See my changes in the close method.
I replaced some semicolons with commas to combine multiple var statements into one. This is to adhere to the JSLint rule "JSLint expects that a var will be declared only once, and that it will be declared before it is used."

source: http://jslint.com/lint.html
UnexpectedValueException is great here but I don't think the message is accurate. This should only be thrown if no cache handler is set at all.
Gotcha, so one more reason not to subclass OutOfKitchenError :) Glad we
fixed that.

On Wed, Jun 27, 2012 at 10:53 AM, Deepak Kannan <
reply@reply.github.com
> wrote:

> > @@ -20,6 +20,10 @@ class Cook < Knife
> >        include KnifeSolo::KitchenCommand
> >        include KnifeSolo::Tools
> >
> > +      class WrongCookError < KnifeSolo::KnifeSoloError
> > +        alias :message :to_s
>
> my bad. previously it was a subclass of OutOfKitchenError.
> OutOfKitchenError#message is defined with a default message.
> and in the subclass, the specific error message was being ignored
>
> self contained example here, https://gist.github.com/3004559
>
> not needed now, will push a fix
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/matschaffer/knife-solo/pull/73/files#r1060524
>
spaces around operators again
Ha!   I just googled and took the first result :-)    I'll update that.
Enums in Java normally should use LOUD_CASE.

That might be too significant of a breaking change though... I also don't know what the SDK convention is.
What is this file? You should not commit it. Probably you should add this file to gitignore.
Newline before `else`.