labofsahil/github-event-dataset-2012 huggingface dataset:
am I missing something here or did you change only the indentation here? was that an intentional change?
I can see the point of this - initially I had this in enaml.icons, but then it was clear that this fit more into the 'here is an abstract thing that you need to create a subclass of for the backend' so I put it in with the components.  We have abstract item models and so forth in components, and they probably could be moved too.
Maybe "revision contributors" is better? I think that's used elsewhere, too.
"our direct control" should maybe be "under the kernel's direct control"?
> So..... is it alright to keep it as `gfortran` then?

No, when compiling MPI code, one should be using the MPI compilers.
This should return the path to the file without the `Bundler.bundle_path` prefix
to match the convention i will rename to `belongs_to`
it doesn't make sense any longer.  Deal price used to be variable with avalanche mechanic. But that mechanic is no longer supported.
If you guys don't think it's necessary, I will remove the rescue block here.
Я решил теперь записывать в очередь строку + '\n' в методе readFrom.Так что эта строчка теперь работает нормально + я проверял и пустые строки программа выводит
Можно просто a = 111L;
Sorry if my comment is misplaced, but if this is needed for reversion to work toghether with moderation, I would say that this is a ""HUGE"" improvement over moderation. It gives the ability to use both, converting (almost) any django object to behave like a true moderated wiki.
We should not do that anymore. We should name that "windowTarget", and update the rest of the code according to the new way to reach the window.
Oh, it's not. But shouldn't it be?
moved this in the test and also created a new return logic for the submit process
are you sure this works?  I'm surprised there is no need for a space after the LIKE.. ie:

   resolver.delete(APN_TABLE_URI, "apn LIKE ?", new String[]{"relay.nyaruka.com"});
As per our discussion I'll change this to reacting to the `change` event instead of using an observer.
Update link to current sphinx page
Here you are modifying in place eigen_vec, an input argument. This should not be done by default: it creates a side effect that will confuse users. You should add a 'copy=True' argument to the function, and if it is true, copy the input argument in the beginning of the function, as it is done in many places in the scikit.
Do we really need this constructor parameter ahead of time? Adding new parameter is generally not a problem for backward compat. WDYT?
Because options[:independent_lines] could be missing (nil)
Should skip this clause for i==0
Opps, I meant TiPlatformObject.h/cpp, sorry.
Moi je ferais juste un GET pour editbug, qui sert donc à visualiser la page d'édition d'un bug.
Ici au lieu d'avoir int tou bête, il faut utiliser une relation @ ManyToOne (cf. models/Etude.java avec l'administrateur)
Comme ça tu récupères directement un objet Administrateur
Revisiting in the light of day, I'm thinking this would be better expressed as:

```if @local_authorities && @local_authorities.any?```

(ie. prefer the positive case)
`null` ?
If its ok, we'll keep the tutorials as us-east-1 until Martin finishes his microbosh work and ships a new micro-bosh-stemcell, working AKIs, and region-based AMIs. 

As an Australian, I'm very conscious of the existence of other regions :)
Apart from the fact that I hate Windows and want it to fail? No... ;)
This is not catching cases like ```dataset(ROW(myTransf(hundred)));``` where ```hundred``` is a stored value. 

In my exampe, it works, but I'm not sure if the variable is extern, or gets changed along the way, the compiler will understand that this is not the case any more.
Yes but isn't heapsize always 0 entering this method?
so value used to heap.append and heap_push_up, is 'i'
It is a harder to review  commoning up these two functions at the same time as the other changes.  It looks like you haven't followed through by making ensure non virtual and removing the derived implementation.
Moved only to avoid forward reference
Should this ignore rw_crc if compresed?
why wasn't it owned?
Well, I think that the BC concerns for people extending these classes is not so big currently as I don't think so many people are messing with these classes directly, so I think it could be possible to change it for other methods too. But this would need to be discussed with @l3pp4rd first (and should be a separate PR anyway)
Hey this is great; going to make it "test_plot_signature" so the example actually works :)
This ' caused many people grief when setting up Sensu :(
That was one of the questions and I didn't have an aster, it certainly should be added by somebody who knows the answer.
Probably you are right, let's rename it to right_rackspace_thread_storage
turns out whiskers implements `.__express` for express 3.x, so its the same signature, no point duplicating that partial stuff I guess, doesnt have any docs for it though I dont think
This pretty much looks great, but the media box structure is supposed to be
    .media
      .img
      .bd

check out http://www.stubbornella.org/content/2010/06/25/the-media-object-saves-hundreds-of-lines-of-code/
I think this would be a good place. What's about the name, BUF seems a little bit too generic to me. I suggest UIP_IPUDPH_BUF.
Yes， I agree. Could you please update your pull request. So I can merge them to the repo.
do we still need this driver passed? doesn't guice take care of this for you?
@shacker switched to using http://addressable.rubyforge.org/ instead
Can we drop this code? We agreed that the client-side would learn the status of OAuth grants via fields in "/api/currentUser" and that a separate end-point was not needed. The currentUser code is already being used, and below I see you made the one-line change to add Google to the data structure.
Keep for now pending design flux - jira for future: semesters table in db
@shacker Can't we just do `return !!item.start.date` instead?
And if that's the case, do we still need the `isAllDay` method or can we just use it within the html?
making this a bit more specific
@christianv Done in latest amend.
@shacker k
i've left this, the code should be deprecated when editor comes online
Removing; it was there to compare implementations (libexif versus the current one) and isn't needed anymore.
I forgot the most important part. The regpacket is an array of packets and the right packet is selected from the array according to the SID length.
It's like, OSX running a Windows VM. :-p
Why not inject this through regular dependency injection?
``kwarg_name`` should be optional, and by default refer to the first parameter.

We can also add a ``convert=True`` flag, like you mentioned.  That flag should explicitly be set to false if dtype conversion is not allowed.
What's the conversation used for? Would it help out the user to explain what we're doing and why?
Is this extra check to explicitly disallow setting the lookAt while morphing?
No strong opinion.  My weakly held opinion would be to move it into DynamicScene since it's only used there.  I guess that means that the mock sceneState.js should go into Scene too.
If the type is going to be mutable, then we should have a constructor that lets you specify all parameters.  I actually follow that guideline because you said something very similarly to me when I started refactoring other Core types a couple of months ago.  We could auto-compute missing parameters, but as you said, I expect people to use the `from` functions.
I'm not sure how I feel about citing wikipedia, especially for something fundemental like a factorial.
Why is this repeated ?
We need to check whether background is null here.
You don't need the transitionEvents or transitionEnd stuff anymore.
`Ti.UI.TableViewRow` actually does not use the `height` property - it uses `rowHeight`.
Just wrap this check and call to doAnalytics within a private method that gets called at ln 234 and 523
I'm nervous of this use of implicits, this is probably making the code uncessarily complex.

See http://twitter.github.com/effectivescala/#Types and Generics-Implicits for our policy on what implicits should be used for:

>If you do find yourself using implicits, always ask yourself if there is a way to achieve the same thing without their help.

>Do not use implicits to do automatic conversions between similar datatypes (for example, converting a list to a stream); these are better done explicitly because the types have different semantics, and the reader should beware of these implications.

I think this definitely applies in these cases.
we have to remove this mark
(I'm thinking of -, +, and ~)
As it is `package` I also see no problems here.
Hehe, yeah I see your point. Additionally to!string converts both values to "E.x".
Maybe include 'dwc' as well in the printed message or something indicating what this list of options mean?

```
print('dwc ${Strings.join(buildArgs, " ")}');
```
Code coverage shows this is untested, perhaps add an ensure => absent test.
ask feedback and make the preferred method known. actual work can be done later and in seperate issue.
nit: separate log lines, plz.
doh!  I've moved the comment on the master branch.

thanks!
Formatting this query would make it more readable/supportable:

````
$query = "
  SELECT {$options['what']}
    FROM call_log,
         call_history
   WHERE ...
";
````
ConfigureFromParams? :)
Hopefully this doesn't cause issues. In FX35, it didn't have a `Dispose` method.
why do we need to change this? If I understand correctly from this diff, it makes annotations display by default on all the pages where they're enabled. Please correct me if i'm wrong and ignore my  comment.

The thing is, the way the annotations get displayed right now is by reloading the content of the page, with annotations from the REST service. 
This request for the annotated page content doesn't take into account GET nor POST parameters (it  makes the request for the page itself) and doesn't re-launch xwiki:dom:loaded when it's done so that some javascripts don't re-execute (e.g. the javascript that creates the little edit icons for section editing under the headings).
As far as I know annotations are enabled everywhere by default, so this mean that you can never search: since the search string is passed in the get params and when the search results page loads it automatically reloads with annotations, you don't see it. There is indeed a check: if there are no annotations, the js doesn't replace document content, but if ever you put an annotation, the behaviour I just described will take place "by default" and there's no way to prevent it, unless you know the cause.

I don't know about this parameter it's interesting when it's set, to have annotations by default but it has the problem I mentioned above. Maybe we could restrict some spaces by default, like the main, the xwiki, blog where it won't work, etc, since we're providing a customization of the annotations system anyway...
Thanks.  If something happened today, is it 0 days ago?
I don't have a strict preference for empy lines inside a body of a methods, however, I prefer to avoid having too many empty lines in the code because it blows up the document and reduces the amount of useful information that fits into a single screen. I don't think that an empty line here affects readability of the code in any way, so I'd prefer to keep it as is.
is this like other border-radii and box-shadows?
Hum you're right about clear, I've just put it after each iteration or it would cause memory leak issues when using the --no-flush option. Flushing after X iterations is also a good idea, we could add an option for that too, but for the current implementation I think it's a good start?

Flushing in the process method seems weird to me, as you're not really aware of the context and only got the document, what would make you make clear in one situation and not in another one? Can't find any use case, and don't think it's really the processor job to do this.

We could add a the dm as 2nd argument in the interface if it's really needed.
``id`` should be ``jms_serializer`` now.
**/!\  BAD TEST** : tout peut être `false` sauf une seule valeur `true` (i.e. un seul hyponyme rencontré), le test passera !!
ahh, good catch.  updated the code to be more specific.
Do we need a separate function for this?
@alexrp yes, this will be detected as null dereference. Such a code is unsafe and such a pointer can only be forged the way you did it. Except for null, no function will ever give you such a pointer.

@FeepingCreature no. No memory can be mapped at this address. Never ever. The only way you can get a pointer to such an address it either to have a null pointer or to set it manually like @alexrp does.
I think it adds zero value...

````java

				if (this.deletePerRow) {
					for (Object entity : (Iterable<?>) payload) {
						this.jpaOperations.delete(entity);
					}
				}
				else {
					this.jpaOperations.deleteInBatch((Iterable<Object>) payload);
````

Seems pointless to even support it to me. Unless you flush per delete, I doubt it does much different. I am __NOT__ suggesting adding flush() :-)

If we keep it I am not sure what the right name would be - deleteEachEntity makes no sense.

I'd dump it but I'd be interested in what @markfisher @olegz and @amolnayak311 have to say.
You can eliminate this line by
```
StandardEvaluationContext uriContext = new StandardEvaluationContext(requestMessage)
```
.  . i think
Hmmm - now I see this here; I think it belongs inside doSendAndReceiveWithNamedReplyToDestination

That would make it symmetrical with doSendAndReceiveWithTemporaryReplyToDestination which sets it there.
Is MySQL the only database that doesn't have an IP address datatype? If so, this line can be much simplified:

```if ($this->db->platform() !== 'mysql')```
src/Album
I'm a bit concerned that the IP addresses are not being escaped, and in some pathological cases, this could lead to incorrect lines being modified or removed. The following could be used:

    vars:
        "ips" slist => { "1.2.3.4", "5.6.7.8" };
        "esc_ips[$(ips)]" string => escape($(ips));

You could then use "$(esc_ips[$(ip)])" instead of "$(ip)" in the regex line #81, and modify etc_hosts_manage_all_entries_delete_nonmanaged() to take "esc_ips" instead, and create the regex using the escaped versions of the IPs.

What do you think?
Idem. You can simplify the sentence:

if ( !crypto.verifySignature(message, sig, pbk) )
This is my only complaint... can we change this to log.info or log.debug?
Add test to verify that links sent to new method are sent to view
i never used sqlite before so i can only guess:
- is is some sort of locking contention in *-journal file (phpcr_tests.db-journal)
- error message is misleading
- there is no schema change at all (here we can be pretty sure)
fixed and readded test
This is not the right way to document that it was added in 1.3. And this is already documented the right way on the line just after that
Yay to TF! After the holidays, let's look at moving it it's own package.
+1 (with a leading underscore to show that it's a private function)
You catch my drift
Rid the <br>
이거 맞나?
Hum ... doesn't really make sense, you're right. The storage class already declare implementing IOAuth2GrantExtension.
I'll remove this
Actually, I think the first should be "monthly at a certain day of a certain week", and the second is "yearly at a certain day of a certain week of a certain month". Is this better?
`Green`
ayeung: What do you mean it is not used?
I think you need to describe how this is used.  Look for our own examples of use to get an idea.
Extractors are usually overkill. These come out.
Always. VerifyWidth is for some views where width is ALWAYS a set size, such as a switch.
+1 on comment
Can you remove the extra return here ?
Change to other license
When/why did we drop this section?
I used hyphen (`-`) character, becouse:

**1. hyphen is banned from classNames, underscore isn't**

it’s treated as a minus symbol and results in a parse error

so if we used underscore there would be more than one possible meaning:

> if we have `$actionName = 'save_and_list'` then user could have meant:
* both `SaveAndListAction.php` (transformed name)
* or `Save_and_listAction.php` (also valid class name)

useing hyphen can have only one meaning:

> if we have  `$actionName = 'save-and-list'` then user could have meant:
* only `SaveAndListAction.php` becouse `Save-and-listAction.php` would be invalid class name (and cause parse error)

**2. `save-and-list` looks better than `save_and_list` in my opinion**

ofcourse, thats not really important :wink2: