labofsahil/github-event-dataset-2012 huggingface dataset:
This should not be called `createCodeRequest` as it does more than create the request object.  Perhaps `requestCodeData`?  Follow the request/response function naming structure in `Application`.
HACK.  Must be made prettier.
Oh that's a pity. It was very useful.
`s/HOla/Hello/` :D
>> add a context object to these methods
>Do you think about some particular use case requiring such sort of context?

No nothing specific. I'm just planning for the future. I whish I had put a context object in a couple more places in 1.0
Hi. Try add here for FIX GSM Data https://github.com/paul-xxx/android_device_semc_mimmi/blob/ics/overlay/frameworks/base/core/res/res/values/config.xml
thanks..
BTW for that updated skia you need to use platform_external_freetype from google aosp, branch master and not from cyanogen, than it compiles without issues
from first glance it's not immediately clear to me what exactly is failing and/or missing

you can try ask Tk-Glitch and the other devs around Glitch-Kernel

they've been building kernels for the Fascinate since ages & probably know what's missing
Keep an eye on Onecosmic's fork; we might be throwing in some code to scale screen refresh frequency with screen state.
It overclocks the LDI bus, which makes it drop data.
https://github.com/ProjectSkyfire/SkyFire-Community-Tools/commit/4cac9b79e9528f8906158c901d681503efedd68e?w=1
looks ok
Hi Marc,

I'd read somewhere that it was Ok in CSS, but then again an IE8-only (or
"old browser") css that lays out correctly without CSS3 elements and/or
with IE8 quirks/bugs would probably be a good idea anyway.

Cheers, Philip.

On 20 January 2012 23:40, Marc Tamlyn <
reply@reply.github.com
> wrote:

> I may be wrong but I don't this works in CSS files - you'd need to make a
> separate ie.css and link it from the pages inside this comment in the HTML.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/andoverarchers/andoverarchers.github.com/commit/e0b8764d2309f772c33c211e39330f3b0cb5cd1f#commitcomment-887657
>
Great one Micheal. I'll merge this pull.
Opera 11.61:
Syntax error at line 432: expected expression, got reserved word 'let'
This version of the OAuth Server is not finished (i'll create a tag when it is close to a production version), but thanks for the feedback.
This was ported from the original version, I haven't changed the logic yet. I'll take this into account when I do.
@jessehu This implementation of `ready?` is different than the implementation I just merged into master from @ohadlevy.  Ohad is taking the approach of simply testing if the VM is powered on.

I like the approach of seeing if there actually is an IP address, but I think this requires the VMWare tools to be installed into the guest operating system.  Is this correct?

@ohadlevy Do you have a preference if `ready?` should return true after power on or if it's better to wait until the VM is accessible over the network by testing for an ipaddress?
It's worth discriminating between data and statistics ncdf files. Variables in the data ncdf file are slightly different. In the statistics ncdf file, experimental factor is stored as propertyName.
Hmm..

I too have the same error, but after applying the `sys.version_info` check, it works just fine:

    import sys
    ...
    with open(self.config.OUTPUT_FILE, 'w') as target:
        if sys.version_info[0] < 3:
            rendered = rendered.encode('utf-8')
        target.write(rendered)
Can we move this into a constant on the relevant class?
Thanks. I like it :)
why not <style ??
ok, removed NonFatal
because you changed it to lazy val, previously it was 
`val secondAddress = node(second).address` that was performed before the "before-down-second-node" barrier
Name is too anonymous/generic
Why is the queue a List (append is extremely costly)
some `{ }`  could go away
final @inline ?
above is no good.  will break on name change
#has_mi_plans?
having `ace_` prefix in setStyle method makes it less useful 
(if i am embedding ace, and want to add non prefixed class that i know doesn't conflict with anything, i can't!) 

and doesn't simplify things, since one still should add it manually into css
```python
request.response.status = 404
```
should do the trick. ;)
we generally want to push key name sanitization into the backends, since a `.` separator could be completely valid in one backend but not the `_`. So I think we should remove this here.
What about calling it `exists()` (this is the method name we use in the Symfony component)?
this is weird, there should IMO be ServiceDefinition::setTags
Throw an Error sounds not right to me
New reference?
I think you can also just delete this line, no need to care about commented out sections below. Pull Request is good to merge. :+1:
Yes it did. Last time I trust them with my contact list.

This is very irritating, I apologise.

--
Sent from Samsung Mobile
Andrew Faulds
http://ajf.me/

nikic <notifications@github.com> hat geschrieben:

In ext/standard/info.c:

>  		php_info_print_hr();
> -		php_info_print("<h1><a href=\"");
> -		php_info_print_request_uri(TSRMLS_C);
> -		php_info_print("?=PHPB8B5F2A0-3C92-11d3-A3A9-4C7B08C10000\">");
> +		php_info_print("<script>(function () {\n");
> +		php_info_print("    'use strict';\n");
> +		php_info_print("    window.onload = function () {\n");
@TazeTSchnitzel I think your Facebook just went wild ;)

—
Reply to this email directly or view it on GitHub.
thanks for explanation!
Yes I think, It's better to do in ruby-core, but not sure if Matz will approve this :)
A small typo here /recieve/receive/g
`[+notify+]` formatting changed?
huh, thanks :)

should I backport to `activesupport` the `deep_transform_keys` method that goes each `Array` value and transforms it for such hashes

```ruby
{ :a => { :b => { :c => 3, :d => [ { :e => 4 }, { :f => 5 } ] } } }
```
```
if (tpeImplied =:= (if (tpValue) AnyValClass else AnyRefClass).tpe
```
A test testing that broadcasting in the function works would be good. That this works correctly is not obvious from the function implementation.
The same goes here obviously
There's a slight advantage to a longer arrow in the fact that it also works for anonymous morphisms: `A-->B` :-) Here comes a real-life example, formatted according to both suggestions:
```
{A->A: EmptySet(), B->B: EmptySet(), C->C: EmptySet(), f: A->B: EmptySet(), g*f: A->C: EmptySet(), g: B->C: EmptySet()}
```
```
{A-->A: EmptySet(), B-->B: EmptySet(), C-->C: EmptySet(), f:A-->B: EmptySet(), g*f:A-->C: EmptySet(), g:B-->C: EmptySet()}
```
On 10.04.2012 21:06, Sergiu Ivanov wrote:
>> +        remove = set()
>> +        for (a, b, c) in permutations(S, 3):
>> +            A = sdm_LM(a)
>> +            B = sdm_LM(b)
>> +            C = sdm_LM(c)
>> +            if len(set([A[0], B[0], C[0]])) != 1 or not h in [a, b, c]:
>> +                continue
>> +            if monomial_divides(B[1:], monomial_lcm(A[1:], C[1:])):
>> +                remove.add((tuple(a), tuple(c)))
>> +        return [(f, g) for (f, g) in P if (h not in [f, g]) or \
>> +                    ((tuple(f), tuple(g)) not in remove and \
>> +                     (tuple(g), tuple(f)) not in remove)]
>> +
>> +    while P:
>> +        # TODO better data structures!!!
>> +        #print len(P), len(S)
>
> This looks like debugging output and should be removed, I think.
>

Small amounts of helpful debug print statements exist, in commented-out 
form, throughout sympy [and I did not create most of them :D]. I 
personally think it's good to have them.
It would be nice to resolve what the difference is in the "2nd one" that I referred to above. Why does series give extra terms and your method not?
>Thoughts on how this is worded?

In my opinion, good.
This might go to far... But good.
I have explained in the commit message, I had error in starting the server, its a upstream problem, bug in rails probably, please check the last link, the stackoverflow one, it fixed my issue, just in case if anyone else get the same problem they have to look up on the internet, adding bigdecimal to gemfile wont be a problem right?
If possible, I'd recommend changing this loop, which just calls cogroup() on each pair of RDDs, to create a single CoGroupedRDD instead. There's a class called CoGroupedRDD in Spark that takes a bunch of (key, value) pair RDDs and gives you an RDD of (key, Seq[Seq[value]]). That is, for each key, you get a list of the lists of elements with that key from each parent RDD. This is more efficient because it happens in just one shuffle.
oh link to the runtime option for journaling? 

    :setting:`journal`

github butchered the RST
extraneous dot.
this line break is uneeded.

    .. [#fn] put footnote next here
Delete `you` as well.
How does someone get to this view from the site? 

Rather than a general site view, this would work better as an admin action. [Like what I did using smuggler on the snippets server](https://github.com/lmorchard/home-snippets-server/blob/master/apps/homesnippets/admin.py). That provides access control and shows up in the general admin nav for models
why Rails.env ??
For the function, I'd like if the result is casted to boolean and the function should be prefixed with phpbb_
Do we really want to accept up to 255 characters for the link text? IMO we should do some UI tests to see how really long link names affect the breadcrumb display. I doubt we need to allow that much.
There should be a link back to the extensions listing, like in viewtopic there is a link back to the forum.
How would I know if you still remembed that if it's not fixed here. i figured it's safer to leave a comment so there's a record of it?
Also, the entire block should have a comment explaining what it's for ("front controller", etc.).
We currently have no autoloading for test related classes. But I'm not against adding it, perhaps in a separate PR.
Add comma at the end of this line
Don't touch the last line. Make sure there is an empty line at the end of the file.
Same here, $db->sql_in_set
I do not think constants are a good idea, it should return the error string directly, or at least what failed ('php', 'phpBB', etc) so it can be put in a localized string.
is that dash supposed to be there?
hrm, if I am so confident I should remove this and resp check.
it does. it calls client:log which includes the ip, port and hostname.
Also should be discussed in #4.
I like the clever mkDocForInsertTCB implementations, but I'm a bit worried about the default (assumption that may be wrong) case of inserting an unlabeled document will be unnecessarily slow. On the other hand, the security logic is in one location so easier to reason about.
parameter assignments (context, options)
I will argue that this type of rollup process (mojito compile views) should be made by shaker rather than mojito itself. But about the specific feature we are discussing here (partial->compiler), I added to facilitate (in the near future) the use of {{> partial}} for handlebars templates. At this point, mojito-partial-addon is the only external addon that knows how to resolve (based on the name of the view) the partial fullpath, etc. So, if we are going to support this feature anytime soon, we need a way to pre-compute partials before executing the composite view. That being said, we can stick to the plan of having no compiler routine at the addon level if you feel strong about this.
Why limit yourself to that when you could cover all items breaking?
Can you confirm that your autocrlf=false? Hard to spot the changes in the diffs currently.
You are right. The Coverity tool is not smart enough to know that LOG_TEST_RET() will return.

I think it is a good idea to use this patch. Or at least add a comment.
unless it's very important that this is temporary, recommend changing name to be more informative, e.g. registerModel. If temp needed, could be tempRegisterModel.
Please check requirement
ok thanks john
If you want to separate out assigning to ```msg``` from the call to ```warnings.warn()``` I believe it is clearer if the ```format()``` call is attached to the string i.e.
```
msg = 'Ignoring PP invalid units {!r}'.format(obj.value)
warnings.warn(msg)
Well spotted, and the answer is no, it won't. Unfortunately exactly where it goes depends on the type of install. For a default ```python setup.py install``` that creates an egg type install the files end up in the iris directory in the egg, next to ```__init__.py```. If you try a ```--single-version-externally-managed``` install it'll end up in a directory called ```iris``` located at the install root i.e. prefix. This is not what we want. Phil said we're doing egg style deployments so I opted to support this type.
should this be associative?
Sounds reasonable to me. Would you mind adding a comment to tensordot explaining that?
Yes, this could could be cleaner, but 2 is no longer a magic number. It's actually the size of an empty param array.

I'll see if I can make this code slightly better in a short amount of time.
みんなで共有する無視条件は.gitignoreに書いてpush、
個人的な無視条件は.git/info/excludeに書きます。

この差分で意味不明なのは、.gitignoreに.gitignoreを書いている点ですね。
Or possibly 46 is indented incorrectly.
This whole method is commented out, but seems necessary for the tests.
Why does this have its own logging, instead of the usual query logging?
What about `not isinstance(value, models.Model)`? Maybe duck-typing is enough...
There is a pylint warning in this function that could be avoided:

Assigning to function call that does not return
In `sequences.force` there are functions `UnderlyingContainerConstructor` and `ForcedContainerConstructor`, whose purpose is very similar to these—`UnderlyingContainerConstructor` gives the parameterized type symbol of a container type without the parameters, and `ForcedContainerConstructor` gives a new container type that's intended to be like another container type but with a different element type. It'd be cool if these protocols could be combined into one.
Do we support SRF?
This is no good, its enforcing 3+3 damage for *all* elements, so the weapon is doing 3-6 fire, 3-6 cold etc. You can see it in the DPS stat on the char in game, a lvl1 char with no weapons has like 36 dps. Also, right now HitPayload only uses Physical when calculating weapon damage % attacks.
You need to pass in an id here. So this line should be:

```
mapping_type.index(doc, item_id)
```

http://elasticutils.readthedocs.org/en/latest/django.html#elasticutils.contrib.django.models.Indexable.index
Use `head` for moving targets.
Can't assume /usr/local here, and we don't install things to HOMEBREW_PREFIX (usually /usr/local) directly, but rather packages get their own prefixes under HOMEBREW_PREFIX/Cellar and are then symlinked into HOMEBREW_PREFIX.

The correct way of doing this is usually something like

```
system "make", "install", "PREFIX=#{prefix}", ...
```
Not sure, but I think you're right. I will fix the formula.

----- Reply message -----
От: "Jack Nagel" <reply@reply.github.com>
Кому: "Alex Zinchenko" <admloki@gmail.com>
Тема: [homebrew] New Formula: libbluray (#11583)
Дата: ср, апр 11, 2012 23:02


> @@ -0,0 +1,34 @@
> +require 'formula'
> +
> +class Libbluray < Formula
> +  homepage 'http://www.videolan.org/developers/libbluray.html'
> +  head 'git://git.videolan.org/libbluray.git'
> +  url 'http://static.mouseed.com/src/libbluray/libbluray-0.2.2.tar.bz2'
> +  mirror 'ftp://ftp.videolan.org/pub/videolan/libbluray/0.2.2/libbluray-0.2.2.tar.bz2'
> +  md5 'cb3254de43276861ea6b07c603f4651c'
> +
> +  depends_on 'openssl' if ARGV.include? '--with-openssl'

Is the system openssl not sufficient?

--- 
Reply to this email directly or view it on GitHub:
https://github.com/mxcl/homebrew/pull/11583/files#r672585
> there currently is no casper method for removing filters

right, that would be some neat addition btw
It's the default in the server configuration file, but the mongodb store needs network parameters and I didn't want to hardcode them
@gharlan Sollten wir den formattype im formatter umbennen? Passt hier nicht zusammmen.
As said in my Pull Request comment, I would rather use the `:data` attribute.
Same here the diff seems to be changing tabs<->spaces but I want to make sure it's the right way around (which means we end up with spaces only!)
Sure.  I was just starting to put the semver in the couch database. I looked at semver and it seems to be pretty vanilla javascript so it should run in couch fine and be usable in map/reduce queries.  If couch compatibility is the only hangup I can spend another hour on it and will know if it's feasible.
I think we decided the last time we introduced TimeUnit to a class that the benefit to having three constructors wasn't worth the cognitive load of having to choose which constructor. Let's please not add this constructor.
The same thing that usually prompts constants. After I was typing the strings out for the tenth time, I realized how prone to typos strings are and how hard that error is to find. I'm pretty flexible on the names, don't love them myself, but even as it stands, the number of characters should be taken care of in minification.
Same here as above file.
I realize our internal plugins use dot rather than dash in the command id's. Should I recommend plugins follow so my example would be:

author.myplugin.mycommandname

instead of 

author-myplugin-mycommandname

-----Original Message-----
From: Peter Flynn [mailto:reply@reply.github.com] 
Sent: Thursday, May 24, 2012 2:12 PM
To: Ty Voliter
Subject: Re: [brackets] Menu and Command and Shortcut Extensibility implementation (#936)

> +     * @param {boolean} checked
> +     */
> +    Command.prototype.setChecked = function (checked) {
> +        var changed = this._checked !== checked;
> +        this._checked = checked;
> +
> +        if (changed) {
> +            $(this).triggerHandler("checkedStateChange", this);
> +        }
> +    };
> +
> +    /**
> +     * Registers a global command.
> +     * @param {string} name - text that will be displayed in the UI to represent command
> +     * @param {string} id - unique identifier for command. Plugins should use the 
> +     *      following format"author-myplugin-mycommandname".

Also, the core commands in Commands.js don't follow this format.  We should probably mention that (it's implied by "Plugins should..." but easy to miss).

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/936/files#r878146
Could you please translate "Click here for details." as well?
My thought was that `basic` might contain things that also have their own special hint, like


```py
def _eval_expand_myhint(self, **hints):
    …

def _eval_expand_basic(self, **hints):
   return self._eval_expand_basic(**hints)
```

It really isn't the best API, but it's legacy.
Line 740 marks the file as non-blocking.
did this... kinda
Why did using the Linux default path get it to work for Daisy?  Prior to adding that line of code, her Windows machine couldn't handle Facebook authentication, and now it can.  I'll comment the line out for now so you can merge my commits as I've fixed everything else, but we should look into fixing that since Windows users not being able to use the Ride Share would cause problems...
Też mi się tak zdaje ;) Ja teraz zmergowałem Twój request, jeszcze chwilę popatrzę na ten kod. Nie pracuj już dziś :) Idź na piwo.
I've removed the call in the map context... When modifying the extent in the map transform, the bounding box of the map context is set. It's even set when invalidating the image...
Why is this test duplicated?
Noooo. You have this value in `contrib.django.auth.REDIRECT_FIELD_NAME`!
can store a reference to arguments.length for some extra goodness, on line 81 as well
fair enough, was just curious why you were doing it.
paran -> param
OMG SEMICOLONS.
not really, but we may have some additional logic in save/restore()
Yes, I made that for an older version of PDF Viewer where that was still used, so I thought it was acceptable. In my new commit, it has been moved to the JS file.
Is the dot before systemd there intentionally?
Good call, brought up a bug where it wasn't embedding if images links included paths (../sprite.png etc). Have added test for this now.

Did bring up another issue where the tests were failing because the relaxed regex test was picking up font-face src in blog.css and there is no file to embed. I just removed the @font-face declaration from blog.css hope that's ok?
We could also issue "Warning: not-publicly accessible URL found. Changing to ..."
N_("Cannot register a system to the '%s' environment") % "Library"

Added a "to the"
Is controller a good spot for this module or should it be a helper ?? Sounds like helper type stuff ..
Mind making this an assert_equal?
why do we remove this assertion?
1. I change the CSS classes "blue-button" and "orange-button" to "blue" and "orange", these two class are for temporary use only, they will be removed or changed after UX team come out the final UI styles.
2. Yap, if UX will design a panel transition, it is better not to reuse <code>#title</code>, thanks for highlight me this point, I will tray to make some changes in a follow up.
What do you mean by untested? WEP works fine! :)
Again, please document the feature of the Makefile in README :)
What I do in the tests that need to wait for their internal api to be ready is something like this:

  yield until(function() window.Contacts && window.Contacts._loaded, nextStep)
Sounds like a convincing enough argument.  So OK, just stay with your original patch to core.py.
Also, where is it setting the phone number to call?
How to get definitions for struct sockaddr_in and in_addr then?
It does matter ... if one sets an IPv6 proxy address to use for connecting.
See above comment about the NULL as a type.
it will, addEventListener is added since IE9 also audio is since IE9 is supported
http://www.w3schools.com/html5/tag_audio.asp
http://msdn.microsoft.com/en-us/library/ie/ff975245%28v=vs.85%29.aspx
Yeah, it breaks with not found items. Will fix and resubmit sometime.
add `aria-haspopup="true"` to this anchor tag :)
Align `=`.
Ok, but do you need this at all?
Frequency is unstable and I see a lot of jitter at the higer frequencies and inacurracy of about 2% at lower freq compared to same sketch for Arduino UNO. This observation was made with a scope.
hangar_divisions?
In my reading of #2279, since there is no valid case when `__file__` is None, this should instead be
```python
                if save_fname is not None:
                    self.user_ns['__file__'] = save_fname
                else:
                    del self.user_ns['__file__']
```
100 character wrapping here as well.
This looks like a ton of pointer juggling just to unescape a string in place. I'd keep unescaping outside of `git_buf` and apply is manually on its own function.
`realpath` isn't available in OSX IIRC. Here's the pattern we've been following in other scripts:

```
B2G_DIR=$(cd `dirname $0`; pwd)
```
I assume this part isn't done yet, right? Is this going to be replaced with links to the privacy blog or something? Just wondering.
:( All right, leave it in for now. Post-release, we should figure this out and fix the instances of |safe.
So, what's going on here is that we'll continue to define model-specific mappings in the model itself. That's really convenient. Then this function merges them down into a single mapping which is used to create the index. It'll throw an error if it can't merge it correctly.

If you make changes to one of the mappings, the easy way to test whether it'll merge is to run ``./manage.py esreindex``.
Oh, I see where this is going now... I suppose it's a good way to do it given the confines of the existing system, but it sure feels icky.
copypaste engineering :)
Did you mean count/COUNT instead of when?
the row number 140 was deleted...
And replaced `getcwd()` with `NULL` by same reason.
https://gist.github.com/3386926
Node.js is definitely an inspiration, but contrary to popular belief, react is not a port of node to PHP. Unless we implement more options, I agree with @cboden.
same as comment #1
але видалення як такого немає в функціоналі, є відключення з адмінки.
тоді я відключених юзерів буду відписувати тут:
https://github.com/stfalcon/fwdays/pull/85/files#L6R49

а вскріпт синхронізації добавлю вибірку не всіх, а тільки включених, тут:
https://github.com/stfalcon/fwdays/pull/85/files#L4R50

ще можна очищати мейлчімп базу перед синхронізацією, але тоді ми опустимо той момент що деякі юзери відписались через сервіс мейлчімпа,  ця відписка затреться і після синхронізації він знову може бути підписаний.  Для цього випадку можна підписатись на хук, щоб мейлчімп при відписувані юзера присилав його нам, і ми в себе його також відписували.
ок, дооформлю блоки, це була бета тому я не оформляв остаточно, так як здогадувався що буду переробляти, и про ParamСonverter думав, але вирішив що без нього простіше
I've removed the gemspec from the Rakefile and am using a static gemspec on disk, instead of having it generated.
I think you should typehint the choices as array
And btw, you are talking about duplicating the HttpBasicFactory. but your current PR does not support http_basic. And if you go the current way, you would be hacking the existing factory, thus breaking it too.
where is the csrf_token function going ?
no, we should not make the GraphWalker skip this child. It does not make any sense to forbid validating some values because the form has not changed them (what if you have a constraint validating that a property must be bigger than another one and only one of them is bound ?)

IMO, a better solution would be to bind all child forms, but using the existing data instead of ``null`` when the field is not submitted an partial is allowed.
Wouldn't be simpler to implement such count in that `bag` ?
Well, we're not going to run a poll in the community to change this. That was a suggestion, feel free to do whatever your want.
http://en.wikipedia.org/wiki/Magic_number_(programming)#Unnamed_numerical_constants
yes it is. There might be some slips but we can atleast try an be consistent where it is caught :)
This description is wrong. It is a array of file contents, each one being an array of route definitions.

Btw, the extra level of array needed because you use the Config component should be added only inside this methos instead of being added in each child class IMO. the ``AbstractFileLoader`` has no reason to receive several arrays anyway as it is loading a single file
If you want to be specific here, "only available in redis >= 2.1.12 -- http://redis.io/commands/slowlog"
Yea, just a styling issue.  Sorry I wasn't clearer earlier, parenthesis around the parameter and all that jazz.
Include the outputfilename as a member of the parameter structure, which may seem weird since we pass an ImageOutput. We need this for various paths through the write_mipmap function. Search for outputfilename to see the various places (not just error messages) where we use the output filename while writing the output file.
extra unneeded hash
do you actually use/cleanup this memory?
I made a commit that should not have come here. How to cancel, leaving only commit "fix regex again"?
maybe we should rename all specified header vars, because the helper class is now responseable for cookies and headers.
It wasn't actually necessary, but I felt it provided some clarity to the code.
This check isn't really necessary, since ``timezone.now()`` does it already
oui c'est plus lisible!
This and the line above are the real fix; the rest is just some tidy-up I did.
FILE_ALIAS isn't used.
no non-static class imports please
Why is this ignored?
Composites can nest to arbitrary depths. So this needs to be recursive.
Indentation is wrong here...
Variables must be declared at the top of the function.
delete the commented lines
I think we can do this 1px black line without using images :)
I agreed, and I changed "/sdcard/Music" to "/sdcard/music".
role="menu" in a menu is redundant
Take care with the `inheritance`, because any change in 'Settings'  affects directly to FTU App. For example you have `html,body` styles twice (one from 'settings' and one from 'ftu.css') and sometimes the code in `ftu.css` is patching styles from Settings... probably it's easier to create it from scratch. It would be nice to check again the visuals, because styles are not the same of 'Settings' App.
Probably a silly question: when do we need an “opposite” class?
if you're showing a download, I'd call this function `showRestartDownloadDialog` instead.
just put `evt.application` in a local `app` var
Nothing in here run in node, but the l10n library is not loaded in the unit tests.
You would still need to update the logic and the comment here I think.
Is `left` or `center`?
Okay I moved it. It's now here: https://github.com/otherinbox/janky_app/blob/9327ef657cd5d27565ebd3917b7f649e972872a7/config/environment.rb
not required anymore?
This change seems to break something.

Have a look at https://github.com/qgis/Quantum-GIS/blob/master/src/python/qgspythonutilsimpl.cpp#L459:
both the if and else statements return a string containing python code,
in your code the else statement returns a path as string instead.
Maybe rename `IdObservable` into `DidCreateObservable` to be clearer about what this mixin is for
you've already pulled it out as `id`
You misplaced the authors, it's the other way around :)
Also

```coffeescript
$.on el.firstElementChild, 'click', @toggle
```

doesn't work like you'd want it to here.
Damn. I completely overlooked that :/

Will amend commit to fix that in a sec
Fair point. In this situation it doesn't make much difference, but I think it's not ideal. I'll change RecordNotFound on master.
You dont have to do this for this patch, but maybe having a couple tests for: 
* a corrupt JSON structure .. just to make sure buildbot doesnt do something weird
* if properties come as a non-dict .. just to make sure that things fail gracefully that way too
Like `rebuildBuild`, I find this formulation *very* difficult to read, because it is nonlinear.  It uses DeferredList heavily for parallelism, but I don' think that's necessary for this method, which isn't in any speed-critical sections of Buildbot.  I think this would be much clearer written out with `deferredGenerator` or `inlineCallbacks`, and using regular `for` loops for iteration.

The `getChange` nested function takes pains to return a Change object, rather than a chdict, but that doesn't seem necessary, as the chdict has all of the required information in it.

Speaking of which, the variable name `chDict` is confusing, since it's not a chdict.  How about `changesByCodebase`?

There are several missing 'wfd.getResults()` calls in this method.  That tests don't fail also suggests it needs more tests!
why make install? Can't we pull the binary from the build dir?
inheriting from testview

```coffeescript
class NoInitView extends TestView
  initialize: ->

view = new NoInitView
expect(view.dispose).to.throwError()
```
you should remove the extra empty line here
please cast this to bool since the phpdoc says it returns a bool.
hmm, actually, I'm not sure. What if my composer.json would allow updating a package (because it specifies a range constraint) but I don't add the package in the whitelist ?
1) live is depricated
2) live inside ready ????????????
I am not too familiar with whisker templates, so I tried quite a few 
different return values to see the effect on the substitution, and this 
is the one that worked.
It seems that whisker works on list objects only, and everything needs 
to be a list -- of list of list of list...

-- 
Renaud Gaujoux
Computational Biology - University of Cape Town
South Africa


On 20/06/2012 03:28, hadley wickham wrote:
>> @@ -126,7 +127,7 @@ build_vignettes<- function(package) {
>>       str_match(contents, "\\\\VignetteIndexEntry\\{(.*?)\\}")[2]
>>     })
>>
>> -  unname(apply(cbind(filename, title), 1, as.list))
>> +  list(vignette=unname(apply(cbind(filename, title), 1, as.list)))
> What's the justification for returning a list here?  It doesn't seem intuitive to me
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hadley/staticdocs/pull/23/files#r1014991
this stack allocation is too big, 64k... we've switched to heap alloc's elsewhere
This will work on Postgresql, I did [similar change](https://github.com/joomla/joomla-cms/pull/166/files#L47R170) inside my pull request.

Eng. Gabriele Pongelli.
Sure, I can do that. I was trying to maintain consistency with the other sections.
As you wish. This might save us one call to `state.observer = null`, but otherwise, I doubt that this is going to change anything.
Wow, great catch. Thanks.
The function, get_pushlog_count_since_date,  is not found in PushLogModel and causes an AttributeError to be raised.
Please note that `typeof (typeof foobar) === "string"` and `typeof( Array().length) === "number"` ! :)
There aren't any type conversion here ... in the whole `aboutNightly.js`!
So IMHO no changes needed in
 * `typeof aID != "string"` near L72
 * `typeof aCallback != "function"` near L76
 * `aItems.length == 0` near L117

Of course if You ask for it, I will change them.
Is this commit an appropriate place to add this functionality or should it be in its own pull request?
@zaphod42 do we have an official-ish way to deprecate this portion of the pson data returned?
I wonder if it would be worth considering a monkey patch to some File or Stat class to abstract away this windows permissions stuff?  Only worthwhile if this kind of construct is going to appear frequently in our code... but that doesn't seem unfathomable.
Any reason for using a splat here? I only see this being used with a single argument
Oops, I accidentally left these logging lines in, which could be deleted.
i'm not sure i follow, what happened when you added it?
On range errors (no ent for that offset), you'll be failing here, where it isn't a failure.  Best make an integration test where your limit is (much) greater than number of elements.
Same -- I thought the point of this PR is to return the object?
Why is this becoming protected?
The // @namespace annotation is superfluous. I removed also the old comment.
Since we want to actually fetch this object from the controller loader, it must be a `Zend\Stdlib\DispatchableInterface`. The method isn't really used in the tests.
Typo: please rename to ExitApplication (sorry).
also shouldn't you use an enum or some sort of validation to make sure that the correct value was given?
this fails for me because it cannot find the `cube` extension (PG::Error: ERROR:  could not open extension control file "/opt/local/share/postgresql91/extension/cube.control": No such file or directory
: CREATE EXTENSION IF NOT EXISTS cube SCHEMA demography).
Perhaps the tests should use an extension that is guaranteed to be available?  Alternatively there should be instructions in the README about where to get the extensions and where to put them.
This is clearer, but it doesn't match the option to db_bench.cc
I thought that anonymous form controls are not tracked as part of the form controller. Looked at the `$addControl` method:

https://github.com/angular/angular.js/blob/master/src/ng/directive/form.js#L64 and the same check for `$removeControl`:
https://github.com/angular/angular.js/blob/master/src/ng/directive/form.js#L70

If I'm correct then we don't have anonymous controls (inputs and sub-forms) on the FormController level and thus can't reset them to their pristine state. Still individual controls can be reset.

@IgorMinar might have missed something here but at least this was reasoning.
Fixed in next push; quotes are also removed for consistency
this is just refactoring, logic should be unchanged
``combing`` looks like a typo
Restriction no, this was to pass parameters, but your right that I could pass them as a hash instead. Will fix.
`@type` is  The expected type for the parameter
use `@param` here (and below) instead.
filter instance (or also through a derived class)
change to backticks
Ah ok, I see, thanks.
Did a Python programmer write this? :-) But seriously, braceless programming should be outlawed, IMO. The only exception is when you put the conditional code on the same line as the controlling statement.
Same for the other errors.
will do in pep8 pull
We can make this a property because it returns true/false.
ditto rubyrhino, this needs to be fixed upstream
Aca estas excluyendo los links?
ah, i take it back :)
I think this should be `blank()`
@zmoazeni @jlee42 That's correct there is no `doc` that I could find either. Replacing with `invoice` does help; but it isn't needed - see `invoices.rb` after the master-rebase. Unless another object which I am not aware of requires `json_root` be defined, the updated `parse` handles both `invoice` and `invoices`.
the code is "fre" for a bibliographic use (ISO 639-2)
Yes. This one is a prerequisite.
thanks!

On Jul 25, 2012, at 4:25 PM, Samuel Reed<reply@reply.github.com> wrote:

>> @@ -246,14 +249,15 @@ Model.prototype.init = function init (doc, query, fn) {
>>       } else {
>>         self._populate(schema, obj[i], poppath, function (err, doc) {
>>           if (err) return error(err);
>> -          obj[i] = doc;
>> +          if(suffix && doc !== null) obj[i + suffix] = doc;
>> +          else obj[i] = doc;
> 
> Good point. Okay, I will add those.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/LearnBoost/mongoose/pull/991/files#r1240190
If we put the dependency in an upper pom, all lower bundles will inherit it. Hence, require it to work.
It may be more easy to use guava in other bundles (no poms update required), but the cost is requiring guava in all bundles, which I don't like very much.
The pax plugin is already defined in the top-level pom, so you don't need it here.
,后应该留一个空白
I haven't viewed the entire file, and I have to run, but when writing guides, I prefer to avoid the use of the plural second person — I think it's better to say 'Now copy the data to your Heroku app'. Reason? Personal preference, but it's how I've written the other guides I've done.
should be `callback.tempPath` or the variable below should  be renamed.
The indentation is off here as well.
We should be using the native Array.isArray instead of util
I think there's a isResourceId validator that could replace these 2 lines.
maybe same for the other tests below as well. I think the ID here can almost be the same as the comment description.
When moving this function into the main postComment function, this should be `replyTo`, which should be the comment id that we're replying to.
It's fine like this, but sometimes I find it clearer to use one of the helpers in `Exception`. However, if you think this is on a hot-path don't change it, since the elegant way would allocate closures and use reflection when catching the exception.

    Exception.failAsValue(Nil)(classOf[AbsentInformationException]) { method.allLineLocations.asScala }
No, probably scalariform added it..
Use this instead please.

    Configger.prototype = {
        ....
    };
We do :D
Какая интересная стрелочка, не знал! А правильно так?
switch — некрасивое решение, можно было бы создать статический массив и получать строку, соответствующую символу ДНК сразу по индексу
Посмотрите пожалуйста новый вариант :)
1. Вы добавляете элемент к ДНК, следует использовать replace.
2. Случайный символ может совпасть со старым. Нет изменения => нет мутации.
Setting the announcement url from the command line doesn't actually work, for a reason that I didn't really have time to figure out.  There are yet deeper problems here :-(
This comment should be updated or removed.
Okay, I just copied and pasted what was used elsewhere.
You can remove all but the author tag. We're on the MIT license, although it appears many files still refer to LGPL and will need to be cleaned up.
This ``-lm`` is needed here for ``libdylan.so`` to link. That wasn't something that I'd added.
I think it leads to more awkward code than the strong/weak dance does.
perhaps pull these things out into a authutil.js or something.
I could be missing something but is the `1260` meant to be hanging there?
I would go with "go run add.go" and "go run client.go" (though it would make more sense if one had the word "server" in the name of the file.  I think I use "client" and "server" in the other examples) if you do it this way, though the other examples put them in subdirectories (which you might want to emulate for consistency).
make inplace should be done before make test or make test-doc

I personally just run "make" that does everything including download sample data if not present.
can you just add a note why we do this?

otherwise +1 for merge
Instead of saying Mockito.any, Mockito.mock I'd just use static imports and say any, mock, etc.
You're right, I missed the flow throwing exception, but the original code just returns the first visit type if the GP  is empty, is this the expected behaviour ?
there is an `extract_public_key` export that will only return public keys. we should use that.
A way to isolate it is by not implementing the test the way I showed it but by mocking the interactions with FormFactory. Can not do.
I'm not really sure, but I think that doing an stop there is odd. That's why I suggest that. 
If you revert you'll lose the other change, so simple do a different PR.
this should be removed from here IMO as this page is about the standalone component
This should be broken up into >1 line too.
OK, just noting the version numbers in the doc and a bare DeprecationWarning upon usage then?

This behavior of `deprecate` is a little brain-dead by the way.
PostOptionsWidget.
Логичнее. Но мне было лень убирать shared_ptr с трея

11 мая 2012 г., 13:30 пользователь Georg Rudoy <
reply@reply.github.com
> написал:

> > @@ -30,6 +30,7 @@
> >       : Resolver_ (new LocalFileResolver)
> >       , Collection_ (new LocalCollection)
> >       , PLManager_ (new PlaylistManager)
> > +     , PlayerTab_ (0)
>
> Понял твою мысль, но это плохо. Я бы сделал так, что PlayerTab обладает
> иконкой в трее. Сам подумай — это же логичнее.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/0xd34df00d/leechcraft/pull/114/files#r807818
>
En commonjobs.makingsense.com:8888 está instalado este código. El header
está horrible por si lo quieren ver.

On Wed, Mar 21, 2012 at 9:18 PM, Andres Moschini
<andresmoschini@gmail.com>wrote:

> Me parece bien, lo puedo hacer mañana a la mañana
>
>
> On Wed, Mar 21, 2012 at 9:17 PM, Alpha <
> reply@reply.github.com
> > wrote:
>
>> > @@ -0,0 +1,8 @@
>> > +﻿@{
>> > +    ViewBag.Title = "Change Password";
>> > +}
>> > +
>> > +<h2>Change Password</h2>
>>
>> ¿Creés que por consistencia pudiéramos pasar estos mensajes al usuario al
>> español?
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/CommonJobs/CommonJobs/pull/42/files#r588671
>>
>
>
Qué es este elemento? Creo que quizá le cambiaría el nombre. No ví referencias en ningún otro lado. (Al menos no en este commit.)
¿No debería ser un false esto?
what's the point ?
Ack, will keep it.
@rsudev My understanding was that the +1/-1 code was used to make sure zoom level is the same when switching between OSM and Google maps. On my phone, with the code changes I made, the zoom level did not stay the same when switching.
My phone has 3.5in screen, 960x640, 326 PPI.

I'm not sure why the code changes I made fix the zoom out problem on OSM 0.3 when the same code is present on 0.2.4 with no problems.
OK, so the official default shouldn't be to restrict any user, but then specific deployments may choose to separately add root to this list in their deployed config? I think that makes sense since ignoring users is a site-specific policy, not necessarily a needed or recommended default.
I think you might be more comfortable with the `with open(file, 'r') as inf` pattern here and elsewhere.
If you need a marker, why not use annotations? This type of marker reminds me of EJB2 ;).
remove this. It is useless. The ``@author`` phpdoc tag is always related to the documented class, not to other used code anyway.
Check #271, I don't think this is the proper fix. $this is iterable and gives you back the cloned assets already processed.
Sure.  I planned to do this, but forgot to mention it.
Out of interest, does not including the baseline images produce a known error rather than a full blown error in the test suite?
missing line break here?
This might look cleaner

```sql
AND filter.target IN ('Any', "db_input($this->getTarget())")
```
Ok then

Le 12 oct. 2012 à 23:57, Adel <notifications@github.com> a écrit :

> In accepted/fr/PSR-0.md:
> 
> > @@ -0,0 +1,61 @@
> > +La section suivante décrit les exigences obligatoires qui doivent être respectées pour l'interopérabilité avec un autoloader.
> > +
> > +Obligatoire
> > +---------
> > +
> > +* Une classe ou espace de noms complètement qualifiée doivent disposer de la structure suivante
> > +  `\<Nom du Vendor>\(<Espace de noms>\)*<Nom de la Classe>`.
> @willdurand i don't understand, Vendor are the same in french, like in http://symfony.com/fr/doc/current/cookbook/workflow/new_project_git.html
> 
> —
> Reply to this email directly or view it on GitHub.
>
If we start adding helper functions for headers like this, would we not need to start adding a whole lot more? Expiry dates, cache settings, language, etc?
It should be scroller.addView(list)
Am 18.10.2012 20:28 schrieb "Mark Wei" <notifications@github.com>:

> In library/src/wei/mark/standout/StandOutWindow.java:
>
> > @@ -795,7 +795,10 @@ public void run() {
> >  		LinearLayout list = new LinearLayout(this);
> >  		list.setOrientation(LinearLayout.VERTICAL);
> >
> > -		final PopupWindow dropDown = new PopupWindow(list,
> > +		ScrollView scroller = new ScrollView(this);
> > +		scroller.addView(scroller);
>
> add scroller to scroller? Is this intended?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pingpongboss/StandOut/pull/8/files#r1882319>.
>
>
Moved this to a precondition - we shouldn't be seeing any nil ts at all.
@arnodeclercq is there a way we can avoid the negative margin in here?
I've added it in for the global admin server as well.
Will be redesigned
I think this error handling is correct, but it deserves a comment: "whether or not we're evicting, next_page points to the current tree-walk page" (or maybe we should just change the variable "next_page" to be "walk_page" and then it makes more sense?
We should probably just compare the keys, using `WT_LSM_CMP`, instead of trying to compare all of the cursors?
It's graph coloring, as in vertices and edges. White means "not visited or discover", grey means "discover", and black means "visited". Coloring the nodes during traversal is necessary to implement the Psurface maintenance algorithm.
Testing error submitted by my local testing bash script. Last commit should have removed it from the compiled CSS. It appears in the github web view diff but not in source code.

Sent from my iPad

On Nov 19, 2012, at 5:19 PM, Philip Schatz <notifications@github.com> wrote:

> In ccap-biology.css:
> 
> > @@ -0,0 +1 @@
> > +lessc: ENOENT, no such file or directory '/home/developer/oer.exports/ccap-biology.less'
> Something tells me this is a problem...
> 
> —
> Reply to this email directly or view it on GitHub.
>
Are you sure ``$this->_getRawBody()`` has the correct type as "string|object<Zend\Feed\PubSubHubbub\false>" is not a sub-type of "string"?
ah, doch wird ja doch in die Cypherquery eingebaut... Hab ich erst später gesehen.
Better:
if ((*inPixel32 >> 31))
Sorry, don't want to open a new pull request
shouldn't 1 ` be enough?
I'd like to remove the `!cb` check too, but there's a test case that ensures `on` with no callback is a noop...seems inconsistent to me. I think I'll remove the check and the test and see what people think.
We'll need some kind of upgrade script to populate this. For testing purposes only, I manually added the '75' structure under attack message by hand to the database.