labofsahil/github-event-dataset-2012 huggingface dataset:
Nei, vi trenger ikke alias da. Fikset med å bytte docroot og sette en
Location i stedet.

On Sun, Sep 23, 2012 at 12:09 AM, Jari Bakken <notifications@github.com>wrote:

> In puppet/modules/munin/templates/munin_vhost.conf.erb:
>
> > +  ServerName <%= srvname %>
> > +  DocumentRoot <%= docroot %>
> > +  <Directory <%= docroot %>>
> > +    Options <%= options %>
> > +    AllowOverride None
> > +    Order allow,deny
> > +    Allow from localhost 127.0.0.0/8 ::1
> > +    <% allow_from.each do |ip| -%>
> > +    Allow from <%= ip %>
> > +    <% end -%>
> > +  </Directory>
> > +
> > +
> > +
> > +Alias /munin /var/cache/munin/www
> > +<Directory /var/cache/munin/www>
>
> Ref kommentaren over, trenger vi egentlig /munin hvis docroot settes til
> /var/cache/munin/www?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/holderdeord/hdo-puppet/pull/1/files#r1668261>.
>
>
It happens that `every?` returns true for `nil` and `""`.
What's the `true &&` do here?
Corrected in eee474e.
Do we use `startTime`? Why not just do `System.currentTimeMillis() + (maxSeconds * 1000)`
Moved to Util. It's too useful to leave private.
I tried, but that turned out to be the problem in that comment I said about `ValidationError`; `default` gets called before the panels are registered (in validation), so we can't get the list of panels then, only when the User object is actually being created.
You can also move all this to task function.
I would swap this around. First we have current password, then new?
Same here, do you really need to set ID, or you could store div object into variable and pass it to `addMapLayerOption`?
No empty line between imports from same package.
Because I want to have different succes_url for different users: sucess_url should point to user profile (like it is done now)
I can not just decalre "success_url = urlresolvers.reverse_lazy('profile', kwargs={'username': request.user.username})", because  view class does not have request. I need one function to decalre succes_url, initals and user and I chose dispatch. 
Should I try to set attributes in __init__ isntead ?
Most of the types in the TestTypeFoundation library were created to exercise some very specific test cases.

The proposed modification changes the invariants of the class. While I realize that you made sure that no existing tests fail, do we know with certainty that no existing tests were inadvertently turned into [false negatives](http://xunitpatterns.com/false%20negative.html) by this change?
roll_chance_i
Urgh. Good catch. Will add it back in.
Just, thinking about this, would it be better to define an interface and pass a class name, rather than passing a callable? As it stands, the arguments for the callable are strictly not defined anywhere.
I wonder if we should know better by suggesting a safe default?
"or alike" is an anti-explanation. It just means "find out for yourself", which is not the objective of a comment.
Bad name - should be testEndsWithMatches or something along those lines. Also, do you have the negative: testEndsWithFailsIfStringDoesntHaveSameEnding?
The caller of `ngx_http_pagespeed_determine_options` is going to call either `NewRewriteDriver()` or NewCustomRewriteDriver(options)`.  The first one uses the global options, the second uses options we supply.

Would it be better if `determine_options` returned the global options and then it's caller did (condensed):

    options = determine_options();
    if (options == global_options()) {
        NewRewriteDriver();
    } else {
        NewCustomRewriteDriver(options);
    }

It's a little weird to say "the caller takes ownership of options, unless the options are the global ones".
If true, ...
move pinv_wxhat calculation to fit method or do we need it before?
Nope, good catch. Someone forgot to run the tests :flushed:
4 back slashes (as well as 2 in the previous file, imho) is a lot. I think `%Q(...)` will look much nicer here.
Could you add a link to the document (if you used one) that explains this algorithm?
length is using sqrt and thus is a lengthy operation.
Seeing that you want to call this for each dropped item each tick, this will have a negative effect on speed.
You might consider using .lenghtSquared() for that.
Import only modules, not `*`. In this case, import like:

```
from django.conf import settings
```
All the tests pass and as far as I can tell this doesn't break anything. I don't think this should change the behavior of anything other than fixing the cited bug. Can you give an example of code that will see a back-compat impact?
not planning to use the annotations as of now.
I think you still want to check the namespace.
Too late =)

I guess I should be reviewing more lines instead of making comments here =)
This file isn't actually being used yet, so it probably shouldn't properly be considered part of this pull request.  But this is a good issue to raise, so we can get started talking about it here.  (With a final decision probably coming in a subsequent issue when this file is fully incorporated into some code that will use it.

In any case, yes, we want to add in a option for the multi-extension fits file kind of output that is created by `writeMulti`.

I also think the PStamps name is a bit confusing as well.  To me, PStamps and Image sound like they refer to the opposite one.  The first one makes a bunch of separate Images and the second makes just one image that is a bunch of postage stamps.

And a fifth option is probably to make one big image that isn't a bunch of postage stamps but rather lets the galaxies overlap with each other to at least some extent.  So how about these names:

- PStampImage = single image of postage stamps
- OverlappingImage = single image with potentially overlapping flux profiles
- SeparateFiles = separate files for each image
- MultiExtension = multi-extension fits file with each image in its own hdu
- DataCube = fits file storing the images in a 3d array
Is there a reason to have this loc as a field, rather than declaring it in main as you do in CloudFoundryJavaClusterFromLocationExample?
I find it nice to use the same pattern / structure so I can see the real differences between the two examples easier.
Yes, I think that non-final is better here - particularly given that all the rest of the classes in this package are non-final as well.
would be good if log message included entity.toString (e.g. if multiple entities starting simultaneously.
These lines could  be replaced with material = runnable_type.find(runnable_id)...  not critical, no change required.
Per quanto riguarda seeds.rb, come lo hai generato?
sauf un truc : tu veux couper la suite apres "for free" ?
Really minor nit: Could you add a space after the colon? :smile:
I know it's just stupid convention (that everyone screwed up), but.. You'll make me really happy if will name jquery objects with $ at the begining.
In your case it's $element
I really hate to say it, but can you use something less significant. I suppose, John Doe will be a right choice. Charles Dickens also sounds good.
Ugh, so stupid!
So, for examples in tests and documentation, it's better to use "example.com" rather than some other domain name. They were actually reserved explicitly for this purpose.

https://en.wikipedia.org/wiki/Example.com

The nice thing about that is that you're guaranteed no unintended consequences.
I take it the idea is that for us to expire all the cache items, we just bump up the version, expiring all the old keys?
Is there a difference between this and doing a ``self.user.is_authenticated()`` or would both be doing the same thing? I just asking because I haven't seen it checked this way before.
This seems to conflict with the Q_ASSERT() in :listeningRoom() ?
I believe we should insert an evert at the time of occurrence and not be the time they arrive to our server. The router might log events on the local network and do not have connection with the internet for some reason. But as soon as the connection is established it should push all the events to the nodewatcher and those should be logged appropriately.

On 03. 10. 12, at 10:01, Mitar <notifications@github.com> wrote:

> In datastream/api.py:
> 
> > @@ -234,7 +279,7 @@ def find_metrics(self, query_tags=None):
> >  
> >          return self.backend.find_metrics(query_tags)
> >  
> > -    def insert(self, metric_id, value):
> > +    def insert(self, metric_id, value, timestamp=None):
> What is this? You changed API?
> 
> I am not sure we want to allow this officially! We have unofficial _time_offset for tests and dummy data.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
corrected in latest commit
This is a hack.  This logic should be in the plugin, not in widget itself.  The way it is implemented, this code won't work when there is no system health gadget in the workspace.
I like the changes to m_varname - should we make that a coding convention for gcs?
Seems like this should only return a 200 if the request is JSONP? Otherwise a 404 would be more appropriate.
Названия пакетов со строчной буквы.
Yea, this is essentially `fatal = true;` since the check below is only for truthiness.
why not move the import to the top, instead of doing it inside the method
no, it is going to public properties. ``get`` and ``set`` are the methods in 2.0. And as Bernhard moved to public properties for performance reasons, he reverted the BC break renaming the method for consistency, to make the 2.0->2.1 migration a bit easier (renaming a method before deprecating it is useless).
全体的に[]とか@@のスペースは削除する方針に従います。
For AMD XBVA support there is
Remove "what"
this should be ssl_httpchk
That would probably serve the same purpose. But then I'd rather just say ``if out_dim:``
I am a little confused about this one. If this goes into fit, suppose user uses the private function without ```fit``` for the first time, the function will fail as we may use self.random_state directly in the ```_spectral_embedding```. This will lead to an error :) However, maybe the user is not expected to use the private functions.
I just modified this to allow for (future) coverage work to report the proper line-by-line coverage ;-)
How does one insert a line continuations in Sphinx?
`p` => `pred` or `predictions`.
This refactoring (and the two concrete implementations) are not necessarily related to this pull request itself but could've been applied in the `master` branch before.
This is a mistake on my part. Having a general node pattern is bad, since it causes aliases to be generated for pages that are never supposed to be viewed by the user (ie. tabroll nodes, bio-nodes, etc.)
Shouldn't be readded.
No, not really; updated the commit.
I don't believe PHP code highlight works unless you use a `<?php` tag.
Please change tibbapp too
we could print out the whole file contents here
Lucene (needs capital L)
> lastGood = cur = cur+matchLen;

I hardly see any difference (apart from taste).

> in fact it is confusing to update lastGood until after the subsequent match.

I could create a temporary variable to hold both offsets added up and only increment in the end, but I thought that would be even more confusing.
should check sn==0 too I suppose..
particularly as it will crash on the next check if it is..
We should also consider the case where the user has write access and may be prompt him to reload the file, with a warning that he may lose his existing changes, if any. (similar to what Visual Studio does)
I don't understand replacing the foreach with a for here, it complicates the code and makes it harder to understand.
All sorts of trailing whitespace in this file. Most of these are to clean that up
the key 'right_rackspace' sounds not enough specific and doesn't describe what should be stored there. At least 'right_rackspace_thread_storage' or something like that is more suitable imho.
Why are you using regionCode for the where clause again? Didn't we go over this before?
Deze wijziging klopt volgens mij niet..Elgert
IMO, the IO, the dispatcher and Composer should be constructor arguments instead of being passed to the run() method. They are deps of the Install class, not things specific to a given run.
I think there is no need to define the array each time when the method is called. The best way is to make the property
Creates a new entry according to the new schema
@christianv It's currently nested in cc-container-widget - should it be nested more specifically? Or do you mean that you want to nest list-selected inside of row?
Would it be better to parse the year out of the table? Or from the URL somehow?
keeps handles?
@bodepd  Fixed
I completely agree.   Just added a new diff that renames the class to DataPoint.
I'm very reluctant to put too much detail in the CONTRIBUTING.md. I'm afraid if there's too much text and links, people won't read it at all. The purpose of CONTRIBUTING.md (in my mind) is to get people to pause and look at the docs the moment before they're about to submit a pull request / issue. I'll drop in a couple more links, but getting into details like that seems to be the job of HACKING or the Dev wiki docs or something.

That's why the "Many mysteries are revealed in HACKING" line is there -- entice people to read more, but stay out of their way if they actually do know what they're doing already.
Yes, you definitely should not be creating payloads yourself.
Poorly named method. Should be something more descriptive, like ```alloc_and_write_str```.  Also has nothing to do with Windows accounts and therefore belongs in a different mixin, probably Windows::Railgun
Maybe add plot titles to label the different algorithms.
Use the numpy docstring format: https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt
If you set the content-type header, you can set the type.

Sent from my iPad

On Feb 22, 2012, at 1:02 AM, Nate Abele<reply@reply.github.com> wrote:

>> @@ -212,7 +212,7 @@ function testTransferEncodingChunkedDecode()  {
>>    }
>> 
>>    public function testTypeHeader() {
>> -        $response = new Response(array('type' => 'application/json'));
>> +        $response = new Response(array('headers' => array('Content-Type' => 'application/json')));
> 
> Can I no longer set the type through the `Response` constructor? I'd still like `new Request(array('type' => 'json'))` and `new Request(array('type' => 'application/json'))` to both work.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/UnionOfRAD/lithium/pull/350/files#r474745
Now it must be id, Legacy was changed in 2c1d67e9030e966e4f0869d90ca66c3862a99969 to use id's like interface and InMemory does.
Oxford comma? Don't know how I feel about that :D
@kristiancalhoun any tip for this doc?
@mramato Anything changed here?
As far as I can tell, there's no reason for this clone to be here.
I'm just asking if we need the quotes.  This isn't JSON so we generally don't include them, right?
I am all for writing code that works with and without instances.  In fact, @kristiancalhoun and I - well really @kristiancalhoun - did a lot of work to make this happen for `Cartesian3`.  When we know we are working with an instance, I figure it is OK, perhaps even preferred to use instance members.  If this were C++ that is what I would do.  But this is JavaScript, and I obviously don't know anything anymore.
This property has to be less ambiguous. Please rename to something like `horizontalWrap` so that the functionality is clear
small typo. notifing -> notifying
Do we want to set fullName in the case that it's just ""?
(Also, missing space before "In iOS 5".)
Цвет не критичный параметр его можно сделать и по умолчанию
The parameter is required for showing and hiding of the details. I will change the name of the parameter to something more descriptive
Add `randRange()` here too
*started *will
List items should Have first word capitalized and maybe preceded by "*"
You might just use (unsigned int)time_get() alone as seed, there's no requirement for the seed to be time.
Just use `std.traits.ParameterTypeTuple` on opSlice?
Using a static array like this is going to result in functions like `encode` returning a slice to a static array, which is extremely bad. If you use a static array, you're going to have to copy it into a dynamic array anyway. If you know what the size is ahead of time, you can just allocate a dynamic array to the correct size. Or you can use `std.array.appender` to reduce the cost of appending, if it's appending that's the problem. As it stands, this code will result in functions operating on data which is out of scope and no longer valid.
> Is this a bug, or do varargs explicitly bypass IFTI?

I would be inclined to say that it's a bug, but I don't know for sure. Slices didn't originally return a tail-const version of arrays, and IFTI didn't originally instantiate with the tail-const version. They used to use the exact type of the original array, which caused a fair bit of grief. That was fixed a year or two back, but varargs may not have been taken into account when that was done. I don't know. I'd say that it's worth bringing up in the newsgroup and/or creating a bug report for it though.

> BTW, I also noticed that a foreach can iterate on a static array. Should this code be made legal?

Maybe, but probably not. In general, static arrays shouldn't work with range-based functions without slicing them first. Exceptions to that are rare. I haven't really dealt with `lockstep` though, so I don't know what all goes on with it and don't know what the consequences of having it work with static arrays would be. But given that all you have to do to use a static array with a range-based function is to slice it, I don't think that it's all that big a deal to not accept static arrays. Also, static arrays would be copied normally if they were accepted directly, which would probably make the semantics too different from how the ranges work.
foreach (i; 0 .. coef.length)
Use `D` for code. So in this case, it would be `$(D functionAttributes)`. However, given that `functionAttributes` is actually another symbol within std.traits, it would be better to do `$(LREF functionAttributes)` so that it creates a link to it (though if we go forward with some of the documentation changes currently being discussed in the newsgroup, we won't need to manually link symbols like that anymore).
Use `std.exception.enforce`.
Good question. I guess that's because this is more general, i.e. you can set `dontcreateinstalldir` anywhere.

But having a dedicated argument for `make_installdir`would make sense.
Now that forms has landed, this is all in RepoUtils.
pls use private submethods instead of tons of newlines
you want to introduce the hook principle also for the persist interface? I mean if you think this is necessary I can add that too of course. Just for information: I want to add in a later pull request that the enhancer can be regulated, so that the user can decide different automatic update levels: eg: no update propagation at all, update propagation only for engineering objects and full update propagation
The relative path contains an invalid character
should now be static.
Good point, I'll fix that. The reason it is there is because it works :)
Sorry, I meant `request.xhr?`
Yeah, noticed that - I'll check it. My main concern is that throwing exception is an expensive operation and we need to minimize number of it as much as possible.
there's no validation on the set if `null` is passed.
Or should you be setting myhostname at all? http://www.postfix.org/postconf.5.html#myhostname
I haven't tested any of this, so if it works as you have it then great :-)
make -j 4 seems to work here.
haha, yes
I'll think about it
How do you think: should be added some test about issue https://jira.springsource.org/browse/INT-2613
when `payload-expression="##args[0]"`?

Also such configuration may produce some side-effect: our payload is Map from Gateway's method parameter and MessageHeaders will contain the same Map entries. I don't say that it is bad, because we can't control SpEL in the 'payload-expression', but we should keep it in mind.
Or it realy may be an issue: we try to put all Maps into MessageHeaders on background without the consent of the end-developer...
No assertions...
Sorry, I can't figure out what this test mean without any assertions
Code will only run if you are in a worker role in the emulator or cloud.  It is good practice to enclose all calls in service runtime in a block that checks whether the service runtime service is available, i.e.:

RoleEnvironment.isAvailable(function(error, available) {
   if (available) {
      // your service runtime code here
   }
});
The current PR alters 2 tables, so the command should alter the related tables ... so you must provide the command to enter to start these commands.
This form is very Australia-specific. We should think of a way to either make this more generic or easy to customise for other countries. Also, there's a package for local flavours that provides certain fields that might help with that [django-localflavor-au](https://github.com/django/django-localflavor-au). This is a package that has recently been move out of core Django so should be very stable.
The number of dots is correct?
добавить перенос строки
missing empty line between the methods
You are right... how the hell have I done that?! :-/
You already have to_s defined as first+last, so just use that.
It's get, so the answer might be 401, 403 or 404 - no need for explanation IMO.
This shouldn't be changing.
what happens when I have a synapse ID in the middle of a link?
this worries me. a web site will usually have multiple db connections. what operation is causing the db change? we would need at least to document in which case one may not do parallel operations.

also, i would much prefer a static class variable over a global - or do we need the connection outside this class as well?
it could be the case. If you plan to run bundle's tests in your application environment. Personally I think it is pretty rare case.
I wasn't sure where to do it, and if the `` link would handle it. I'll wrap.
estaría bueno hacer un admin model para este model tmb: con un raw_id_fields para la FK de user no sé si ahora, pero estaría bueno
It might be that it'd make more sense just to keep the RedirectView out of
core.
Make a git repo that has it plus a bit of documentation, and then link from
the bottom of the Generics Views documentation,
in a 'Third party generic views' section.
I'd like to start having 'Third party renderers/parsers/authentication'
etc... sections at the bottom of most of the API Guide pages, this might be
a good start to that?

On 23 November 2012 12:12, Ludwig Kraatz <notifications@github.com> wrote:

> In rest_framework/views.py:
>
> > +    view_name = None
> > +
> > +    def get_redirect_url(self, request, *args, **kwargs):
> > +        """
> > +        Return the URL redirect to. Arguments and Keyword arguments from the
> > +        URL pattern match generating the redirect request
> > +        are provided as kwargs to this method.
> > +        """
> > +        try:
> > +            url = reverse(self.view_name, args=args, kwargs=kwargs, request=request)
> > +        except:
> > +            return None
> > +
> > +        query_string = self.request.META.get('QUERY_STRING', '')
> > +        if query_string:
> > +            url = '%(url)s?%(query_string)s' % {'url': url, 'query_string': query_string}
>
> The django way is similar:
>
> https://github.com/django/django/blob/master/django/views/generic/base.py#L155
>
> but to be honest.. its too similar -except the view-name suport- to have
> an identical APIView Redirect... Would be better to make the django
> implementation support view-name redirection.. not sure about this anymore
>
> ( additionally i would have no idea where to put this documentation.. it
> doesn't fit into views.md and not really in generic_views.md as well.. it
> would be better to move the code to mixins.py and have it mixin style.. but
> well. somehow this all does not satisfy me.
> One alternative: Using Djangos RedirectView and having an
> ViewNameRedirectMixin -as long as django does not support view names-)
>
> your opinion?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/tomchristie/django-rest-framework/pull/418/files#r2211222>.
>
>
The workblock isn't complete yet, I wanted to get the sending and receiving of job working first.
None of these are valid UUID string representations.  I do not know why Harmony expects them to pass.

Ref:
http://docs.oracle.com/javase/6/docs/api/java/util/UUID.html#fromString()
rule instead of rule**s**
> aforementioned

gee, never heard. I had to look this one up ;-)
Regarding adding another sentence - why not. On the other hand we have to be careful not to be too verbose.
I'd say "...if any of the **child processes fail**"
@mandrews I am intrigued. My rspec knowledge is pretty limited. Are there docs you can point me to?
Y a "..".

Ca peut pas marcher.

Btw je ferai une méthode statique primary_locale sur le modele Locale qui renverrait la primary_locale.

Et tu check si le name != en dans le modele translation alors que ça devrait être dans le locale. Bref ça peut pas marcher ici je crois...
repeated logic at 3 places, extract out
Indentation should be fixed. Also, does the addUser handle duplicates? Or is it up to the controller? What does the user interface look like?
spacing around the second ``.`` as well, same in the other change here.
Not clear what you are asking.  When I run mvn clean package I get 2 jar files.  XXX-SNAPSHOT.jar and XXX-SNAPSHOT.one.jar.jar
calcdeps.py is "super-legacy" and has been replaced by closurebuilder.py.

See:
https://docs.google.com/present/view?id=dgsp8w6z_72fxtnnmdb&start=18
http://code.google.com/closure/library/docs/closurebuilder.html

Definitely should not be using calcdeps.py.
Should I remove it and make a new request?
Want to move this to the steps above and correct the path to `app/data/temp`?
But how would the developer see that?
On both platforms, if no buttonNames are defined, a dialog without a title is created. I have updated the file to make this clear.
Let me know if the above still needs to be fixed.
When I have a lot of notes on a single platform, I usually make the notes sections platform-specific, like:

#### Mobile Web Platform Implementation Notes
we generally try not to have else statements that are not needed because the code has already returned in the if case.
This has nothing to do with workgroups, move it to the "project_sheet" app.
this line uses spaces - 2 spaces and 1 tab. It needs to be rewritten to use 2 tabs.
Yes, change it. I only released it under GPL because the rest was. :-(